929 lines
29 KiB
Ruby
929 lines
29 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Projects::CreateService, '#execute' do
|
|
include ExternalAuthorizationServiceHelpers
|
|
include GitHelpers
|
|
|
|
let(:user) { create :user }
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: user.namespace.id
|
|
}
|
|
end
|
|
|
|
context 'with labels' do
|
|
subject(:project) { create_project(user, opts) }
|
|
|
|
before_all do
|
|
Label.create!(title: 'bug', template: true)
|
|
end
|
|
|
|
it 'creates labels on project creation' do
|
|
created_label = project.labels.last
|
|
|
|
expect(created_label.type).to eq('ProjectLabel')
|
|
expect(created_label.project_id).to eq(project.id)
|
|
expect(created_label.title).to eq('bug')
|
|
end
|
|
|
|
context 'using gitlab project import' do
|
|
before do
|
|
opts[:import_type] = 'gitlab_project'
|
|
end
|
|
|
|
it 'does not creates labels on project creation' do
|
|
expect(project.labels.size).to eq(0)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'setting name and path' do
|
|
subject(:project) { create_project(user, opts) }
|
|
|
|
context 'when both are set' do
|
|
let(:opts) { { name: 'one', path: 'two' } }
|
|
|
|
it 'keeps them as specified' do
|
|
expect(project.name).to eq('one')
|
|
expect(project.path).to eq('two')
|
|
end
|
|
end
|
|
|
|
context 'when path is set' do
|
|
let(:opts) { { path: 'one.two_three-four' } }
|
|
|
|
it 'sets name == path' do
|
|
expect(project.path).to eq('one.two_three-four')
|
|
expect(project.name).to eq(project.path)
|
|
end
|
|
end
|
|
|
|
context 'when name is a valid path' do
|
|
let(:opts) { { name: 'one.two_three-four' } }
|
|
|
|
it 'sets path == name' do
|
|
expect(project.name).to eq('one.two_three-four')
|
|
expect(project.path).to eq(project.name)
|
|
end
|
|
end
|
|
|
|
context 'when name is not a valid path' do
|
|
let(:opts) { { name: 'one.two_three-four and five' } }
|
|
|
|
# TODO: Retained for backwards compatibility. Remove in API v5.
|
|
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/52725
|
|
it 'parameterizes the name' do
|
|
expect(project.name).to eq('one.two_three-four and five')
|
|
expect(project.path).to eq('one-two_three-four-and-five')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'topics' do
|
|
subject(:project) { create_project(user, opts) }
|
|
|
|
context "with 'topics' parameter" do
|
|
let(:opts) { { name: 'topic-project', topics: 'topics' } }
|
|
|
|
it 'keeps them as specified' do
|
|
expect(project.topic_list).to eq(%w[topics])
|
|
end
|
|
end
|
|
|
|
context "with 'topic_list' parameter" do
|
|
let(:opts) { { name: 'topic-project', topic_list: 'topic_list' } }
|
|
|
|
it 'keeps them as specified' do
|
|
expect(project.topic_list).to eq(%w[topic_list])
|
|
end
|
|
end
|
|
|
|
context "with 'tag_list' parameter (deprecated)" do
|
|
let(:opts) { { name: 'topic-project', tag_list: 'tag_list' } }
|
|
|
|
it 'keeps them as specified' do
|
|
expect(project.topic_list).to eq(%w[tag_list])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'user namespace' do
|
|
it do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to be_valid
|
|
expect(project.owner).to eq(user)
|
|
expect(project.team.maintainers).to include(user)
|
|
expect(project.namespace).to eq(user.namespace)
|
|
end
|
|
end
|
|
|
|
describe 'after create actions' do
|
|
it 'invalidate personal_projects_count caches' do
|
|
expect(user).to receive(:invalidate_personal_projects_count)
|
|
|
|
create_project(user, opts)
|
|
end
|
|
|
|
it 'builds associated project settings' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project.project_setting).to be_new_record
|
|
end
|
|
|
|
it_behaves_like 'storing arguments in the application context' do
|
|
let(:expected_params) { { project: subject.full_path } }
|
|
|
|
subject { create_project(user, opts) }
|
|
end
|
|
end
|
|
|
|
context "admin creates project with other user's namespace_id" do
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
it 'sets the correct permissions' do
|
|
admin = create(:admin)
|
|
project = create_project(admin, opts)
|
|
|
|
expect(project).to be_persisted
|
|
expect(project.owner).to eq(user)
|
|
expect(project.team.maintainers).to contain_exactly(user)
|
|
expect(project.namespace).to eq(user.namespace)
|
|
end
|
|
end
|
|
|
|
context 'when admin mode is disabled' do
|
|
it 'is not allowed' do
|
|
admin = create(:admin)
|
|
project = create_project(admin, opts)
|
|
|
|
expect(project).not_to be_persisted
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'group namespace' do
|
|
let(:group) do
|
|
create(:group).tap do |group|
|
|
group.add_owner(user)
|
|
end
|
|
end
|
|
|
|
before do
|
|
user.refresh_authorized_projects # Ensure cache is warm
|
|
end
|
|
|
|
it do
|
|
project = create_project(user, opts.merge!(namespace_id: group.id))
|
|
|
|
expect(project).to be_valid
|
|
expect(project.owner).to eq(group)
|
|
expect(project.namespace).to eq(group)
|
|
expect(project.team.owners).to include(user)
|
|
expect(user.authorized_projects).to include(project)
|
|
end
|
|
end
|
|
|
|
context 'group sharing', :sidekiq_inline do
|
|
let_it_be(:group) { create(:group) }
|
|
let_it_be(:shared_group) { create(:group) }
|
|
let_it_be(:shared_group_user) { create(:user) }
|
|
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: shared_group.id
|
|
}
|
|
end
|
|
|
|
before do
|
|
create(:group_group_link, shared_group: shared_group, shared_with_group: group)
|
|
|
|
shared_group.add_maintainer(shared_group_user)
|
|
group.add_developer(user)
|
|
end
|
|
|
|
it 'updates authorization' do
|
|
shared_group_project = create_project(shared_group_user, opts)
|
|
|
|
expect(
|
|
Ability.allowed?(shared_group_user, :read_project, shared_group_project)
|
|
).to be_truthy
|
|
expect(
|
|
Ability.allowed?(user, :read_project, shared_group_project)
|
|
).to be_truthy
|
|
end
|
|
end
|
|
|
|
context 'membership overrides', :sidekiq_inline do
|
|
let_it_be(:group) { create(:group, :private) }
|
|
let_it_be(:subgroup_for_projects) { create(:group, :private, parent: group) }
|
|
let_it_be(:subgroup_for_access) { create(:group, :private, parent: group) }
|
|
let_it_be(:group_maintainer) { create(:user) }
|
|
|
|
let(:group_access_level) { Gitlab::Access::REPORTER }
|
|
let(:subgroup_access_level) { Gitlab::Access::DEVELOPER }
|
|
let(:share_max_access_level) { Gitlab::Access::MAINTAINER }
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: subgroup_for_projects.id
|
|
}
|
|
end
|
|
|
|
before do
|
|
group.add_maintainer(group_maintainer)
|
|
|
|
create(:group_group_link, shared_group: subgroup_for_projects,
|
|
shared_with_group: subgroup_for_access,
|
|
group_access: share_max_access_level)
|
|
end
|
|
|
|
context 'membership is higher from group hierarchy' do
|
|
let(:group_access_level) { Gitlab::Access::MAINTAINER }
|
|
|
|
it 'updates authorization' do
|
|
create(:group_member, access_level: subgroup_access_level, group: subgroup_for_access, user: user)
|
|
create(:group_member, access_level: group_access_level, group: group, user: user)
|
|
|
|
subgroup_project = create_project(group_maintainer, opts)
|
|
|
|
project_authorization = ProjectAuthorization.where(
|
|
project_id: subgroup_project.id,
|
|
user_id: user.id,
|
|
access_level: group_access_level)
|
|
|
|
expect(project_authorization).to exist
|
|
end
|
|
end
|
|
|
|
context 'membership is higher from group share' do
|
|
let(:subgroup_access_level) { Gitlab::Access::MAINTAINER }
|
|
|
|
context 'share max access level is not limiting' do
|
|
it 'updates authorization' do
|
|
create(:group_member, access_level: group_access_level, group: group, user: user)
|
|
create(:group_member, access_level: subgroup_access_level, group: subgroup_for_access, user: user)
|
|
|
|
subgroup_project = create_project(group_maintainer, opts)
|
|
|
|
project_authorization = ProjectAuthorization.where(
|
|
project_id: subgroup_project.id,
|
|
user_id: user.id,
|
|
access_level: subgroup_access_level)
|
|
|
|
expect(project_authorization).to exist
|
|
end
|
|
end
|
|
|
|
context 'share max access level is limiting' do
|
|
let(:share_max_access_level) { Gitlab::Access::DEVELOPER }
|
|
|
|
it 'updates authorization' do
|
|
create(:group_member, access_level: group_access_level, group: group, user: user)
|
|
create(:group_member, access_level: subgroup_access_level, group: subgroup_for_access, user: user)
|
|
|
|
subgroup_project = create_project(group_maintainer, opts)
|
|
|
|
project_authorization = ProjectAuthorization.where(
|
|
project_id: subgroup_project.id,
|
|
user_id: user.id,
|
|
access_level: share_max_access_level)
|
|
|
|
expect(project_authorization).to exist
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'error handling' do
|
|
it 'handles invalid options' do
|
|
opts[:invalid] = 'option'
|
|
expect(create_project(user, opts)).to eq(nil)
|
|
end
|
|
end
|
|
|
|
context 'wiki_enabled creates repository directory' do
|
|
context 'wiki_enabled true creates wiki repository directory' do
|
|
it do
|
|
project = create_project(user, opts)
|
|
|
|
expect(wiki_repo(project).exists?).to be_truthy
|
|
end
|
|
end
|
|
|
|
context 'wiki_enabled false does not create wiki repository directory' do
|
|
it do
|
|
opts[:wiki_enabled] = false
|
|
project = create_project(user, opts)
|
|
|
|
expect(wiki_repo(project).exists?).to be_falsey
|
|
end
|
|
end
|
|
|
|
def wiki_repo(project)
|
|
relative_path = ProjectWiki.new(project).disk_path + '.git'
|
|
Gitlab::Git::Repository.new(project.repository_storage, relative_path, 'foobar', project.full_path)
|
|
end
|
|
end
|
|
|
|
context 'import data' do
|
|
let(:import_data) { { data: { 'test' => 'some data' } } }
|
|
let(:imported_project) { create_project(user, { name: 'test', import_url: 'http://import-url', import_data: import_data }) }
|
|
|
|
it 'does not write repository config' do
|
|
expect_next_instance_of(Project) do |project|
|
|
expect(project).not_to receive(:set_full_path)
|
|
end
|
|
|
|
imported_project
|
|
end
|
|
|
|
it 'stores import data and URL' do
|
|
expect(imported_project.import_data).to be_persisted
|
|
expect(imported_project.import_data.data).to eq(import_data[:data])
|
|
expect(imported_project.import_url).to eq('http://import-url')
|
|
end
|
|
|
|
it 'tracks for the combined_registration experiment', :experiment do
|
|
expect(experiment(:combined_registration)).to track(:import_project).on_next_instance
|
|
|
|
imported_project
|
|
end
|
|
end
|
|
|
|
context 'builds_enabled global setting' do
|
|
let(:project) { create_project(user, opts) }
|
|
|
|
subject { project.builds_enabled? }
|
|
|
|
context 'global builds_enabled false does not enable CI by default' do
|
|
before do
|
|
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
|
|
end
|
|
|
|
it { is_expected.to be_falsey }
|
|
end
|
|
|
|
context 'global builds_enabled true does enable CI by default' do
|
|
it { is_expected.to be_truthy }
|
|
end
|
|
end
|
|
|
|
context 'default visibility level' do
|
|
let(:group) { create(:group, :private) }
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
where(:case_name, :group_level, :project_level) do
|
|
[
|
|
['in public group', Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL],
|
|
['in internal group', Gitlab::VisibilityLevel::INTERNAL, Gitlab::VisibilityLevel::INTERNAL],
|
|
['in private group', Gitlab::VisibilityLevel::PRIVATE, Gitlab::VisibilityLevel::PRIVATE]
|
|
]
|
|
end
|
|
|
|
with_them do
|
|
before do
|
|
stub_application_setting(default_project_visibility: Gitlab::VisibilityLevel::INTERNAL)
|
|
group.add_developer(user)
|
|
group.update!(visibility_level: group_level)
|
|
|
|
opts.merge!(
|
|
name: 'test',
|
|
namespace: group,
|
|
path: 'foo'
|
|
)
|
|
end
|
|
|
|
it 'creates project with correct visibility level', :aggregate_failures do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to respond_to(:errors)
|
|
expect(project.errors).to be_blank
|
|
expect(project.visibility_level).to eq(project_level)
|
|
expect(project).to be_saved
|
|
expect(project).to be_valid
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'restricted visibility level' do
|
|
before do
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
|
end
|
|
|
|
shared_examples 'restricted visibility' do
|
|
it 'does not allow a restricted visibility level for non-admins' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to respond_to(:errors)
|
|
expect(project.errors.messages).to have_key(:visibility_level)
|
|
expect(project.errors.messages[:visibility_level].first).to(
|
|
match('restricted by your GitLab administrator')
|
|
)
|
|
end
|
|
|
|
it 'does not allow a restricted visibility level for admins when admin mode is disabled' do
|
|
admin = create(:admin)
|
|
project = create_project(admin, opts)
|
|
|
|
expect(project.errors.any?).to be(true)
|
|
expect(project.saved?).to be_falsey
|
|
end
|
|
|
|
it 'allows a restricted visibility level for admins when admin mode is enabled', :enable_admin_mode do
|
|
admin = create(:admin)
|
|
project = create_project(admin, opts)
|
|
|
|
expect(project.errors.any?).to be(false)
|
|
expect(project.saved?).to be(true)
|
|
end
|
|
end
|
|
|
|
context 'when visibility is project based' do
|
|
before do
|
|
opts.merge!(
|
|
visibility_level: Gitlab::VisibilityLevel::PUBLIC
|
|
)
|
|
end
|
|
|
|
include_examples 'restricted visibility'
|
|
end
|
|
|
|
context 'when visibility is overridden' do
|
|
let(:visibility) { 'public' }
|
|
|
|
before do
|
|
opts.merge!(
|
|
import_data: {
|
|
data: {
|
|
override_params: {
|
|
visibility: visibility
|
|
}
|
|
}
|
|
}
|
|
)
|
|
end
|
|
|
|
include_examples 'restricted visibility'
|
|
|
|
context 'when visibility is misspelled' do
|
|
let(:visibility) { 'publik' }
|
|
|
|
it 'does not restrict project creation' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project.errors.any?).to be(false)
|
|
expect(project.saved?).to be(true)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'repository creation' do
|
|
it 'synchronously creates the repository' do
|
|
expect_next_instance_of(Project) do |instance|
|
|
expect(instance).to receive(:create_repository)
|
|
end
|
|
|
|
project = create_project(user, opts)
|
|
expect(project).to be_valid
|
|
expect(project.owner).to eq(user)
|
|
expect(project.namespace).to eq(user.namespace)
|
|
end
|
|
|
|
context 'when another repository already exists on disk' do
|
|
let(:opts) do
|
|
{
|
|
name: 'existing',
|
|
namespace_id: user.namespace.id
|
|
}
|
|
end
|
|
|
|
context 'with legacy storage' do
|
|
let(:fake_repo_path) { File.join(TestEnv.repos_path, user.namespace.full_path, 'existing.git') }
|
|
|
|
before do
|
|
stub_application_setting(hashed_storage_enabled: false)
|
|
TestEnv.create_bare_repository(fake_repo_path)
|
|
end
|
|
|
|
after do
|
|
FileUtils.rm_rf(fake_repo_path)
|
|
end
|
|
|
|
it 'does not allow to create a project when path matches existing repository on disk' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).not_to be_persisted
|
|
expect(project).to respond_to(:errors)
|
|
expect(project.errors.messages).to have_key(:base)
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
end
|
|
|
|
it 'does not allow to import project when path matches existing repository on disk' do
|
|
project = create_project(user, opts.merge({ import_url: 'https://gitlab.com/gitlab-org/gitlab-test.git' }))
|
|
|
|
expect(project).not_to be_persisted
|
|
expect(project).to respond_to(:errors)
|
|
expect(project.errors.messages).to have_key(:base)
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
end
|
|
end
|
|
|
|
context 'with hashed storage' do
|
|
let(:hash) { '6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b' }
|
|
let(:hashed_path) { '@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b' }
|
|
let(:fake_repo_path) { File.join(TestEnv.repos_path, "#{hashed_path}.git") }
|
|
|
|
before do
|
|
allow(Digest::SHA2).to receive(:hexdigest) { hash }
|
|
TestEnv.create_bare_repository(fake_repo_path)
|
|
end
|
|
|
|
after do
|
|
FileUtils.rm_rf(fake_repo_path)
|
|
end
|
|
|
|
it 'does not allow to create a project when path matches existing repository on disk' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).not_to be_persisted
|
|
expect(project).to respond_to(:errors)
|
|
expect(project.errors.messages).to have_key(:base)
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when readme initialization is requested' do
|
|
let(:project) { create_project(user, opts) }
|
|
|
|
before do
|
|
opts[:initialize_with_readme] = '1'
|
|
end
|
|
|
|
shared_examples 'creates README.md' do
|
|
it { expect(project.repository.commit_count).to be(1) }
|
|
it { expect(project.repository.readme.name).to eql('README.md') }
|
|
it { expect(project.repository.readme.data).to include('# GitLab') }
|
|
end
|
|
|
|
it_behaves_like 'creates README.md'
|
|
|
|
context 'and a default_branch_name is specified' do
|
|
before do
|
|
allow(Gitlab::CurrentSettings)
|
|
.to receive(:default_branch_name)
|
|
.and_return('example_branch')
|
|
end
|
|
|
|
it_behaves_like 'creates README.md'
|
|
|
|
it 'creates README.md within the specified branch rather than master' do
|
|
branches = project.repository.branches
|
|
|
|
expect(branches.size).to eq(1)
|
|
expect(branches.collect(&:name)).to contain_exactly('example_branch')
|
|
end
|
|
|
|
describe 'advanced readme content', experiment: :new_project_readme_content do
|
|
before do
|
|
stub_experiments(new_project_readme_content: :advanced)
|
|
end
|
|
|
|
it_behaves_like 'creates README.md'
|
|
|
|
it 'includes advanced content in the README.md' do
|
|
content = project.repository.readme.data
|
|
expect(content).to include <<~MARKDOWN
|
|
git remote add origin #{project.http_url_to_repo}
|
|
git branch -M example_branch
|
|
git push -uf origin example_branch
|
|
MARKDOWN
|
|
end
|
|
end
|
|
|
|
context 'and readme_template is specified' do
|
|
before do
|
|
opts[:readme_template] = "# GitLab\nThis is customized template."
|
|
end
|
|
|
|
it_behaves_like 'creates README.md'
|
|
|
|
it 'creates README.md with specified template' do
|
|
expect(project.repository.readme.data).to include('This is customized template.')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when SAST initialization is requested' do
|
|
let(:project) { create_project(user, opts) }
|
|
|
|
before do
|
|
opts[:initialize_with_sast] = '1'
|
|
allow(Gitlab::CurrentSettings).to receive(:default_branch_name).and_return('main')
|
|
end
|
|
|
|
it 'creates a commit for SAST', :aggregate_failures do
|
|
expect(project.repository.commit_count).to be(1)
|
|
expect(project.repository.commit.message).to eq(
|
|
'Configure SAST in `.gitlab-ci.yml`, creating this file if it does not already exist'
|
|
)
|
|
end
|
|
end
|
|
|
|
describe 'create integration for the project' do
|
|
subject(:project) { create_project(user, opts) }
|
|
|
|
context 'with an active instance-level integration' do
|
|
let!(:instance_integration) { create(:prometheus_integration, :instance, api_url: 'https://prometheus.instance.com/') }
|
|
|
|
it 'creates an integration from the instance-level integration' do
|
|
expect(project.integrations.count).to eq(1)
|
|
expect(project.integrations.first.api_url).to eq(instance_integration.api_url)
|
|
expect(project.integrations.first.inherit_from_id).to eq(instance_integration.id)
|
|
end
|
|
|
|
context 'with an active group-level integration' do
|
|
let!(:group_integration) { create(:prometheus_integration, group: group, project: nil, api_url: 'https://prometheus.group.com/') }
|
|
let!(:group) do
|
|
create(:group).tap do |group|
|
|
group.add_owner(user)
|
|
end
|
|
end
|
|
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: group.id
|
|
}
|
|
end
|
|
|
|
it 'creates an integration from the group-level integration' do
|
|
expect(project.integrations.count).to eq(1)
|
|
expect(project.integrations.first.api_url).to eq(group_integration.api_url)
|
|
expect(project.integrations.first.inherit_from_id).to eq(group_integration.id)
|
|
end
|
|
|
|
context 'with an active subgroup' do
|
|
let!(:subgroup_integration) { create(:prometheus_integration, group: subgroup, project: nil, api_url: 'https://prometheus.subgroup.com/') }
|
|
let!(:subgroup) do
|
|
create(:group, parent: group).tap do |subgroup|
|
|
subgroup.add_owner(user)
|
|
end
|
|
end
|
|
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: subgroup.id
|
|
}
|
|
end
|
|
|
|
it 'creates an integration from the subgroup-level integration' do
|
|
expect(project.integrations.count).to eq(1)
|
|
expect(project.integrations.first.api_url).to eq(subgroup_integration.api_url)
|
|
expect(project.integrations.first.inherit_from_id).to eq(subgroup_integration.id)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when skip_disk_validation is used' do
|
|
it 'sets the project attribute' do
|
|
opts[:skip_disk_validation] = true
|
|
project = create_project(user, opts)
|
|
|
|
expect(project.skip_disk_validation).to be_truthy
|
|
end
|
|
end
|
|
|
|
it 'calls the passed block' do
|
|
fake_block = double('block')
|
|
opts[:relations_block] = fake_block
|
|
|
|
expect_next_instance_of(Project) do |project|
|
|
expect(fake_block).to receive(:call).with(project)
|
|
end
|
|
|
|
create_project(user, opts)
|
|
end
|
|
|
|
it 'writes project full path to .git/config' do
|
|
project = create_project(user, opts)
|
|
rugged = rugged_repo(project.repository)
|
|
|
|
expect(rugged.config['gitlab.fullpath']).to eq project.full_path
|
|
end
|
|
|
|
it 'triggers PostCreationWorker' do
|
|
expect(Projects::PostCreationWorker).to receive(:perform_async).with(a_kind_of(Integer))
|
|
|
|
create_project(user, opts)
|
|
end
|
|
|
|
context 'with external authorization enabled' do
|
|
before do
|
|
enable_external_authorization_service_check
|
|
end
|
|
|
|
it 'does not save the project with an error if the service denies access' do
|
|
expect(::Gitlab::ExternalAuthorization)
|
|
.to receive(:access_allowed?).with(user, 'new-label', any_args) { false }
|
|
|
|
project = create_project(user, opts.merge({ external_authorization_classification_label: 'new-label' }))
|
|
|
|
expect(project.errors[:external_authorization_classification_label]).to be_present
|
|
expect(project).not_to be_persisted
|
|
end
|
|
|
|
it 'saves the project when the user has access to the label' do
|
|
expect(::Gitlab::ExternalAuthorization)
|
|
.to receive(:access_allowed?).with(user, 'new-label', any_args) { true }
|
|
|
|
project = create_project(user, opts.merge({ external_authorization_classification_label: 'new-label' }))
|
|
|
|
expect(project).to be_persisted
|
|
expect(project.external_authorization_classification_label).to eq('new-label')
|
|
end
|
|
|
|
it 'does not save the project when the user has no access to the default label and no label is provided' do
|
|
expect(::Gitlab::ExternalAuthorization)
|
|
.to receive(:access_allowed?).with(user, 'default_label', any_args) { false }
|
|
|
|
project = create_project(user, opts)
|
|
|
|
expect(project.errors[:external_authorization_classification_label]).to be_present
|
|
expect(project).not_to be_persisted
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'measurable service' do
|
|
before do
|
|
opts.merge!(
|
|
current_user: user,
|
|
path: 'foo'
|
|
)
|
|
end
|
|
|
|
let(:base_log_data) do
|
|
{
|
|
class: Projects::CreateService.name,
|
|
current_user: user.name,
|
|
project_full_path: "#{user.namespace.full_path}/#{opts[:path]}"
|
|
}
|
|
end
|
|
|
|
after do
|
|
create_project(user, opts)
|
|
end
|
|
end
|
|
|
|
context 'with specialized project_authorization workers' do
|
|
let_it_be(:other_user) { create(:user) }
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let(:opts) do
|
|
{
|
|
name: 'GitLab',
|
|
namespace_id: group.id
|
|
}
|
|
end
|
|
|
|
before do
|
|
group.add_maintainer(user)
|
|
group.add_developer(other_user)
|
|
end
|
|
|
|
it 'updates authorization for current_user' do
|
|
project = create_project(user, opts)
|
|
|
|
expect(
|
|
Ability.allowed?(user, :read_project, project)
|
|
).to be_truthy
|
|
end
|
|
|
|
it 'schedules authorization update for users with access to group' do
|
|
expect(AuthorizedProjectsWorker).not_to(
|
|
receive(:bulk_perform_async)
|
|
)
|
|
expect(AuthorizedProjectUpdate::ProjectCreateWorker).to(
|
|
receive(:perform_async).and_call_original
|
|
)
|
|
expect(AuthorizedProjectUpdate::UserRefreshFromReplicaWorker).to(
|
|
receive(:bulk_perform_in)
|
|
.with(1.hour,
|
|
array_including([user.id], [other_user.id]),
|
|
batch_delay: 30.seconds, batch_size: 100)
|
|
.and_call_original
|
|
)
|
|
|
|
create_project(user, opts)
|
|
end
|
|
end
|
|
|
|
def create_project(user, opts)
|
|
Projects::CreateService.new(user, opts).execute
|
|
end
|
|
|
|
context 'shared Runners config' do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
let_it_be(:user) { create :user }
|
|
|
|
context 'when parent group is present' do
|
|
let_it_be(:group, reload: true) do
|
|
create(:group) do |group|
|
|
group.add_owner(user)
|
|
end
|
|
end
|
|
|
|
before do
|
|
group.update_shared_runners_setting!(shared_runners_setting)
|
|
|
|
user.refresh_authorized_projects # Ensure cache is warm
|
|
end
|
|
|
|
context 'default value based on parent group setting' do
|
|
where(:shared_runners_setting, :desired_config_for_new_project, :expected_result_for_project) do
|
|
Namespace::SR_ENABLED | nil | true
|
|
Namespace::SR_DISABLED_WITH_OVERRIDE | nil | false
|
|
Namespace::SR_DISABLED_AND_UNOVERRIDABLE | nil | false
|
|
end
|
|
|
|
with_them do
|
|
it 'creates project following the parent config' do
|
|
params = opts.merge(namespace_id: group.id)
|
|
params = params.merge(shared_runners_enabled: desired_config_for_new_project) unless desired_config_for_new_project.nil?
|
|
project = create_project(user, params)
|
|
|
|
expect(project).to be_valid
|
|
expect(project.shared_runners_enabled).to eq(expected_result_for_project)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'parent group is present and allows desired config' do
|
|
where(:shared_runners_setting, :desired_config_for_new_project, :expected_result_for_project) do
|
|
Namespace::SR_ENABLED | true | true
|
|
Namespace::SR_ENABLED | false | false
|
|
Namespace::SR_DISABLED_WITH_OVERRIDE | false | false
|
|
Namespace::SR_DISABLED_WITH_OVERRIDE | true | true
|
|
Namespace::SR_DISABLED_AND_UNOVERRIDABLE | false | false
|
|
end
|
|
|
|
with_them do
|
|
it 'creates project following the parent config' do
|
|
params = opts.merge(namespace_id: group.id, shared_runners_enabled: desired_config_for_new_project)
|
|
project = create_project(user, params)
|
|
|
|
expect(project).to be_valid
|
|
expect(project.shared_runners_enabled).to eq(expected_result_for_project)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'parent group is present and disallows desired config' do
|
|
where(:shared_runners_setting, :desired_config_for_new_project) do
|
|
Namespace::SR_DISABLED_AND_UNOVERRIDABLE | true
|
|
end
|
|
|
|
with_them do
|
|
it 'does not create project' do
|
|
params = opts.merge(namespace_id: group.id, shared_runners_enabled: desired_config_for_new_project)
|
|
project = create_project(user, params)
|
|
|
|
expect(project.persisted?).to eq(false)
|
|
expect(project).to be_invalid
|
|
expect(project.errors[:shared_runners_enabled]).to include('cannot be enabled because parent group does not allow it')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'parent group is not present' do
|
|
where(:desired_config, :expected_result) do
|
|
true | true
|
|
false | false
|
|
nil | true
|
|
end
|
|
|
|
with_them do
|
|
it 'follows desired config' do
|
|
opts[:shared_runners_enabled] = desired_config unless desired_config.nil?
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to be_valid
|
|
expect(project.shared_runners_enabled).to eq(expected_result)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|