99 lines
2.3 KiB
Ruby
99 lines
2.3 KiB
Ruby
require 'spec_helper'
|
|
|
|
require 'rubocop'
|
|
require 'rubocop/rspec/support'
|
|
|
|
require_relative '../../../../rubocop/cop/migration/timestamps'
|
|
|
|
describe RuboCop::Cop::Migration::Timestamps do
|
|
include CopHelper
|
|
|
|
subject(:cop) { described_class.new }
|
|
let(:migration_with_timestamps) do
|
|
%q(
|
|
class Users < ActiveRecord::Migration[4.2]
|
|
DOWNTIME = false
|
|
|
|
def change
|
|
create_table :users do |t|
|
|
t.string :username, null: false
|
|
t.timestamps null: true
|
|
t.string :password
|
|
end
|
|
end
|
|
end
|
|
)
|
|
end
|
|
|
|
let(:migration_without_timestamps) do
|
|
%q(
|
|
class Users < ActiveRecord::Migration[4.2]
|
|
DOWNTIME = false
|
|
|
|
def change
|
|
create_table :users do |t|
|
|
t.string :username, null: false
|
|
t.string :password
|
|
end
|
|
end
|
|
end
|
|
)
|
|
end
|
|
|
|
let(:migration_with_timestamps_with_timezone) do
|
|
%q(
|
|
class Users < ActiveRecord::Migration[4.2]
|
|
DOWNTIME = false
|
|
|
|
def change
|
|
create_table :users do |t|
|
|
t.string :username, null: false
|
|
t.timestamps_with_timezone null: true
|
|
t.string :password
|
|
end
|
|
end
|
|
end
|
|
)
|
|
end
|
|
|
|
context 'in migration' do
|
|
before do
|
|
allow(cop).to receive(:in_migration?).and_return(true)
|
|
end
|
|
|
|
it 'registers an offense when the "timestamps" method is used' do
|
|
inspect_source(migration_with_timestamps)
|
|
|
|
aggregate_failures do
|
|
expect(cop.offenses.size).to eq(1)
|
|
expect(cop.offenses.map(&:line)).to eq([8])
|
|
end
|
|
end
|
|
|
|
it 'does not register an offense when the "timestamps" method is not used' do
|
|
inspect_source(migration_without_timestamps)
|
|
|
|
aggregate_failures do
|
|
expect(cop.offenses.size).to eq(0)
|
|
end
|
|
end
|
|
|
|
it 'does not register an offense when the "timestamps_with_timezone" method is used' do
|
|
inspect_source(migration_with_timestamps_with_timezone)
|
|
|
|
aggregate_failures do
|
|
expect(cop.offenses.size).to eq(0)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'outside of migration' do
|
|
it 'registers no offense' do
|
|
inspect_source(migration_with_timestamps)
|
|
inspect_source(migration_without_timestamps)
|
|
inspect_source(migration_with_timestamps_with_timezone)
|
|
|
|
expect(cop.offenses.size).to eq(0)
|
|
end
|
|
end
|
|
end
|