60 lines
2.3 KiB
Ruby
60 lines
2.3 KiB
Ruby
# frozen_string_literal: true
|
|
# rubocop:disable Style/SignalException
|
|
|
|
require 'yaml'
|
|
|
|
SEE_DOC = "See [the documentation](https://docs.gitlab.com/ce/development/changelog.html)."
|
|
CREATE_CHANGELOG_MESSAGE = <<~MSG
|
|
You can create one with:
|
|
|
|
```
|
|
bin/changelog -m %<mr_iid>s "%<mr_title>s"
|
|
```
|
|
|
|
If you want to create a changelog entry for GitLab EE, run the following instead:
|
|
|
|
```
|
|
bin/changelog --ee -m %<mr_iid>s "%<mr_title>s"
|
|
```
|
|
|
|
Note: Merge requests with %<labels>s do not trigger this check.
|
|
MSG
|
|
|
|
def check_changelog(path)
|
|
yaml = YAML.safe_load(File.read(path))
|
|
|
|
fail "`title` should be set, in #{gitlab.html_link(path)}! #{SEE_DOC}" if yaml["title"].nil?
|
|
fail "`type` should be set, in #{gitlab.html_link(path)}! #{SEE_DOC}" if yaml["type"].nil?
|
|
|
|
if yaml["merge_request"].nil? && !helper.security_mr?
|
|
message "Consider setting `merge_request` to #{gitlab.mr_json["iid"]} in #{gitlab.html_link(path)}. #{SEE_DOC}"
|
|
elsif yaml["merge_request"] != gitlab.mr_json["iid"] && !changelog.ce_port_changelog?(path)
|
|
fail "Merge request ID was not set to #{gitlab.mr_json["iid"]}! #{SEE_DOC}"
|
|
end
|
|
rescue Psych::SyntaxError, Psych::DisallowedClass, Psych::BadAlias
|
|
# YAML could not be parsed, fail the build.
|
|
fail "#{gitlab.html_link(path)} isn't valid YAML! #{SEE_DOC}"
|
|
rescue StandardError => e
|
|
warn "There was a problem trying to check the Changelog. Exception: #{e.name} - #{e.message}"
|
|
end
|
|
|
|
def sanitized_mr_title
|
|
helper.sanitize_mr_title(gitlab.mr_json["title"])
|
|
end
|
|
|
|
if git.modified_files.include?("CHANGELOG.md")
|
|
fail "**CHANGELOG.md was edited.** Please remove the additions and create a CHANGELOG entry.\n\n" +
|
|
format(CREATE_CHANGELOG_MESSAGE, mr_iid: gitlab.mr_json["iid"], mr_title: sanitized_mr_title, labels: changelog.presented_no_changelog_labels)
|
|
end
|
|
|
|
changelog_found = changelog.found
|
|
|
|
if changelog.needed?
|
|
if changelog_found
|
|
check_changelog(changelog_found)
|
|
else
|
|
message "**[CHANGELOG missing](https://docs.gitlab.com/ce/development/changelog.html)**: If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.\n\n" +
|
|
format(CREATE_CHANGELOG_MESSAGE, mr_iid: gitlab.mr_json["iid"], mr_title: sanitized_mr_title, labels: changelog.presented_no_changelog_labels)
|
|
end
|
|
end
|