131 lines
3.7 KiB
Ruby
131 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Projects::AfterImportService do
|
|
include GitHelpers
|
|
|
|
subject { described_class.new(project) }
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
let(:repository) { project.repository }
|
|
let(:sha) { project.commit.sha }
|
|
let(:housekeeping_service) { double(:housekeeping_service) }
|
|
|
|
describe '#execute' do
|
|
before do
|
|
allow(Projects::HousekeepingService)
|
|
.to receive(:new).with(project).and_return(housekeeping_service)
|
|
|
|
allow(housekeeping_service)
|
|
.to receive(:execute).and_yield
|
|
|
|
allow(housekeeping_service).to receive(:increment!)
|
|
end
|
|
|
|
it 'performs housekeeping' do
|
|
subject.execute
|
|
|
|
expect(housekeeping_service).to have_received(:execute)
|
|
end
|
|
|
|
context 'with some refs in refs/pull/**/*' do
|
|
before do
|
|
repository.write_ref('refs/pull/1/head', sha)
|
|
repository.write_ref('refs/pull/1/merge', sha)
|
|
|
|
subject.execute
|
|
end
|
|
|
|
it 'removes refs/pull/**/*' do
|
|
expect(rugged.references.map(&:name))
|
|
.not_to include(%r{\Arefs/pull/})
|
|
end
|
|
end
|
|
|
|
Repository::RESERVED_REFS_NAMES.each do |name|
|
|
context "with a ref in refs/#{name}/tmp" do
|
|
before do
|
|
repository.write_ref("refs/#{name}/tmp", sha)
|
|
|
|
subject.execute
|
|
end
|
|
|
|
it "does not remove refs/#{name}/tmp" do
|
|
expect(rugged.references.map(&:name))
|
|
.to include("refs/#{name}/tmp")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when after import action throw non-retriable exception' do
|
|
let(:exception) { StandardError.new('after import error') }
|
|
|
|
before do
|
|
allow(repository)
|
|
.to receive(:delete_all_refs_except)
|
|
.and_raise(exception)
|
|
end
|
|
|
|
it 'throws after import error' do
|
|
expect { subject.execute }.to raise_exception('after import error')
|
|
end
|
|
end
|
|
|
|
context 'when housekeeping service lease is taken' do
|
|
let(:exception) { Projects::HousekeepingService::LeaseTaken.new }
|
|
|
|
it 'logs the error message' do
|
|
allow_next_instance_of(Projects::HousekeepingService) do |instance|
|
|
expect(instance).to receive(:execute).and_raise(exception)
|
|
end
|
|
|
|
expect(Gitlab::Import::Logger).to receive(:info).with(
|
|
{
|
|
message: 'Project housekeeping failed',
|
|
project_full_path: project.full_path,
|
|
project_id: project.id,
|
|
'error.message' => exception.to_s
|
|
}).and_call_original
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
|
|
context 'when after import action throw retriable exception one time' do
|
|
let(:exception) { GRPC::DeadlineExceeded.new }
|
|
|
|
before do
|
|
expect(repository)
|
|
.to receive(:delete_all_refs_except)
|
|
.and_raise(exception)
|
|
expect(repository)
|
|
.to receive(:delete_all_refs_except)
|
|
.and_call_original
|
|
|
|
subject.execute
|
|
end
|
|
|
|
it 'removes refs/pull/**/*' do
|
|
expect(rugged.references.map(&:name))
|
|
.not_to include(%r{\Arefs/pull/})
|
|
end
|
|
|
|
it 'records the failures in the database', :aggregate_failures do
|
|
import_failure = ImportFailure.last
|
|
|
|
expect(import_failure.source).to eq('delete_all_refs')
|
|
expect(import_failure.project_id).to eq(project.id)
|
|
expect(import_failure.relation_key).to be_nil
|
|
expect(import_failure.relation_index).to be_nil
|
|
expect(import_failure.exception_class).to eq('GRPC::DeadlineExceeded')
|
|
expect(import_failure.exception_message).to be_present
|
|
expect(import_failure.correlation_id_value).not_to be_empty
|
|
end
|
|
end
|
|
|
|
def rugged
|
|
rugged_repo(repository)
|
|
end
|
|
end
|
|
end
|