133 lines
4.4 KiB
JavaScript
133 lines
4.4 KiB
JavaScript
import { isDataframe, convertHtmlTableToJson } from '~/notebook/cells/output/dataframe_util';
|
|
import { outputWithDataframeContent, outputWithMultiIndexDataFrame } from '../../mock_data';
|
|
import sanitizeTests from './html_sanitize_fixtures';
|
|
|
|
describe('notebook/cells/output/dataframe_utils', () => {
|
|
describe('isDataframe', () => {
|
|
describe('when output data has no text/html', () => {
|
|
it('is is not a dataframe', () => {
|
|
const input = { data: { 'image/png': ['blah'] } };
|
|
|
|
expect(isDataframe(input)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('when output data has no text/html, but no mention of dataframe', () => {
|
|
it('is is not a dataframe', () => {
|
|
const input = { data: { 'text/html': ['blah'] } };
|
|
|
|
expect(isDataframe(input)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('when output data has text/html, but no mention of dataframe in the first 20 lines', () => {
|
|
it('is is not a dataframe', () => {
|
|
const input = { data: { 'text/html': [...new Array(20).fill('a'), 'dataframe'] } };
|
|
|
|
expect(isDataframe(input)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('when output data has text/html, and includes "dataframe" within the first 20 lines', () => {
|
|
it('is is not a dataframe', () => {
|
|
const input = { data: { 'text/html': ['dataframe'] } };
|
|
|
|
expect(isDataframe(input)).toBe(true);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('convertHtmlTableToJson', () => {
|
|
it('converts table correctly', () => {
|
|
const input = outputWithDataframeContent;
|
|
|
|
const output = {
|
|
fields: [
|
|
{ key: 'index0', label: '', sortable: true, class: 'gl-font-weight-bold' },
|
|
{ key: 'column0', label: 'column_1', sortable: true, class: '' },
|
|
{ key: 'column1', label: 'column_2', sortable: true, class: '' },
|
|
],
|
|
items: [
|
|
{ index0: '0', column0: 'abc de f', column1: 'a' },
|
|
{ index0: '1', column0: 'True', column1: '0.1' },
|
|
],
|
|
};
|
|
|
|
expect(convertHtmlTableToJson(input)).toEqual(output);
|
|
});
|
|
|
|
it('converts multi-index table correctly', () => {
|
|
const input = outputWithMultiIndexDataFrame;
|
|
|
|
const output = {
|
|
fields: [
|
|
{ key: 'index0', label: 'first', sortable: true, class: 'gl-font-weight-bold' },
|
|
{ key: 'index1', label: 'second', sortable: true, class: 'gl-font-weight-bold' },
|
|
{ key: 'column0', label: '0', sortable: true, class: '' },
|
|
],
|
|
items: [
|
|
{ index0: 'bar', index1: 'one', column0: '1' },
|
|
{ index0: 'bar', index1: 'two', column0: '2' },
|
|
{ index0: 'baz', index1: 'one', column0: '3' },
|
|
{ index0: 'baz', index1: 'two', column0: '4' },
|
|
],
|
|
};
|
|
|
|
expect(convertHtmlTableToJson(input)).toEqual(output);
|
|
});
|
|
|
|
describe('sanitizes input before parsing table', () => {
|
|
it('sanitizes input html', () => {
|
|
const parser = new DOMParser();
|
|
const spy = jest.spyOn(parser, 'parseFromString');
|
|
const input = 'hello<style>p {width:50%;}</style><script>alert(1)</script>';
|
|
|
|
convertHtmlTableToJson(input, parser);
|
|
|
|
expect(spy).toHaveBeenCalledWith('hello', 'text/html');
|
|
});
|
|
});
|
|
|
|
describe('does not include harmful html', () => {
|
|
const makeDataframeWithHtml = (html) => {
|
|
return [
|
|
'<table border="1" class="dataframe">\n',
|
|
' <thead>\n',
|
|
' <tr style="text-align: right;">\n',
|
|
' <th></th>\n',
|
|
' <th>column_1</th>\n',
|
|
' </tr>\n',
|
|
' </thead>\n',
|
|
' <tbody>\n',
|
|
' <tr>\n',
|
|
' <th>0</th>\n',
|
|
` <td>${html}</td>\n`,
|
|
' </tr>\n',
|
|
' </tbody>\n',
|
|
'</table>\n',
|
|
'</div>',
|
|
];
|
|
};
|
|
|
|
it.each([
|
|
['table', 0],
|
|
['style', 1],
|
|
['iframe', 2],
|
|
['svg', 3],
|
|
])('sanitizes output for: %p', (tag, index) => {
|
|
const inputHtml = makeDataframeWithHtml(sanitizeTests[index][1].input);
|
|
const convertedHtml = convertHtmlTableToJson(inputHtml).items[0].column0;
|
|
|
|
expect(convertedHtml).not.toContain(tag);
|
|
});
|
|
});
|
|
|
|
describe('when dataframe is invalid', () => {
|
|
it('returns empty', () => {
|
|
const input = [' dataframe', ' blah'];
|
|
|
|
expect(convertHtmlTableToJson(input)).toEqual({ fields: [], items: [] });
|
|
});
|
|
});
|
|
});
|
|
});
|