1065 lines
31 KiB
YAML
1065 lines
31 KiB
YAML
# This configuration was generated by
|
|
# `rubocop --auto-gen-config`
|
|
# on 2021-01-11 15:49:32 UTC using RuboCop version 0.91.1.
|
|
# The point is for the user to remove these configuration records
|
|
# one by one as the offenses are removed from the code base.
|
|
# Note that changes in the inspected code, or installation of new
|
|
# versions of RuboCop, may require this file to be generated again.
|
|
|
|
# Offense count: 313
|
|
# Cop supports --auto-correct.
|
|
Capybara/CurrentPathExpectation:
|
|
Enabled: false
|
|
|
|
# Offense count: 218
|
|
Capybara/VisibilityMatcher:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
Gitlab/PolicyRuleBoolean:
|
|
Exclude:
|
|
- 'ee/app/policies/ee/identity_provider_policy.rb'
|
|
|
|
# Offense count: 5
|
|
Graphql/IDType:
|
|
Exclude:
|
|
- 'app/graphql/mutations/boards/issues/issue_move_list.rb'
|
|
|
|
# Offense count: 2054
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
# SupportedStyles: with_first_argument, with_fixed_indentation
|
|
Layout/ArgumentAlignment:
|
|
Enabled: false
|
|
|
|
# Offense count: 11
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyleAlignWith, Severity.
|
|
# SupportedStylesAlignWith: start_of_line, begin
|
|
Layout/BeginEndAlignment:
|
|
Exclude:
|
|
- 'app/controllers/groups/shared_projects_controller.rb'
|
|
- 'app/workers/concerns/reactive_cacheable_worker.rb'
|
|
- 'ee/app/services/security/token_revocation_service.rb'
|
|
- 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/deploy.rb'
|
|
- 'ee/lib/gitlab/ci/config/entry/vault/secret.rb'
|
|
- 'lib/api/internal/base.rb'
|
|
- 'lib/atlassian/jira_connect/serializers/build_entity.rb'
|
|
- 'lib/gitlab/ci/jwt.rb'
|
|
- 'lib/gitlab/external_authorization/client.rb'
|
|
- 'lib/gitlab/phabricator_import/project_creator.rb'
|
|
- 'scripts/gitaly_test.rb'
|
|
|
|
# Offense count: 52
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: AllowAliasSyntax, AllowedMethods.
|
|
# AllowedMethods: alias_method, public, protected, private
|
|
Layout/EmptyLinesAroundAttributeAccessor:
|
|
Enabled: false
|
|
|
|
# Offense count: 721
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
|
|
Layout/FirstArrayElementIndentation:
|
|
Enabled: false
|
|
|
|
# Offense count: 1592
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
# SupportedStyles: special_inside_parentheses, consistent, align_braces
|
|
Layout/FirstHashElementIndentation:
|
|
Enabled: false
|
|
|
|
# Offense count: 3019
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
|
|
# SupportedHashRocketStyles: key, separator, table
|
|
# SupportedColonStyles: key, separator, table
|
|
# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
|
|
Layout/HashAlignment:
|
|
Enabled: false
|
|
|
|
# Offense count: 73
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
|
|
# URISchemes: http, https
|
|
Layout/LineLength:
|
|
Max: 1313
|
|
|
|
# Offense count: 163
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
# SupportedStyles: aligned, indented
|
|
Layout/MultilineOperationIndentation:
|
|
Enabled: false
|
|
|
|
# Offense count: 11
|
|
# Cop supports --auto-correct.
|
|
Layout/RescueEnsureAlignment:
|
|
Exclude:
|
|
- 'app/models/blob_viewer/dependency_manager.rb'
|
|
- 'app/models/project.rb'
|
|
- 'app/services/prometheus/proxy_service.rb'
|
|
- 'app/workers/concerns/reactive_cacheable_worker.rb'
|
|
- 'app/workers/delete_stored_files_worker.rb'
|
|
- 'config/initializers/1_settings.rb'
|
|
- 'config/initializers/trusted_proxies.rb'
|
|
- 'lib/api/internal/base.rb'
|
|
- 'lib/gitlab/highlight.rb'
|
|
|
|
# Offense count: 53
|
|
# Cop supports --auto-correct.
|
|
Layout/SpaceAroundMethodCallOperator:
|
|
Enabled: false
|
|
|
|
# Offense count: 725
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: require_no_space, require_space
|
|
Layout/SpaceInLambdaLiteral:
|
|
Enabled: false
|
|
|
|
# Offense count: 218
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
|
|
# SupportedStyles: space, no_space
|
|
# SupportedStylesForEmptyBraces: space, no_space
|
|
Layout/SpaceInsideBlockBraces:
|
|
Enabled: false
|
|
|
|
# Offense count: 559
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: space, no_space
|
|
Layout/SpaceInsideParens:
|
|
Enabled: false
|
|
|
|
# Offense count: 18
|
|
Lint/BinaryOperatorWithIdenticalOperands:
|
|
Exclude:
|
|
- 'ee/spec/lib/ee/gitlab/application_context_spec.rb'
|
|
- 'spec/helpers/visibility_level_helper_spec.rb'
|
|
- 'spec/lib/gitlab/conan_token_spec.rb'
|
|
- 'spec/lib/gitlab/danger/sidekiq_queues_spec.rb'
|
|
- 'spec/lib/gitlab/git/conflict/parser_spec.rb'
|
|
- 'spec/lib/gitlab/graphql/lazy_spec.rb'
|
|
- 'spec/models/ci/build_trace_chunk_spec.rb'
|
|
- 'spec/models/clusters/platforms/kubernetes_spec.rb'
|
|
- 'spec/models/concerns/where_composite_spec.rb'
|
|
- 'spec/models/metrics/dashboard/annotation_spec.rb'
|
|
- 'spec/models/repository_spec.rb'
|
|
- 'spec/models/ssh_host_key_spec.rb'
|
|
|
|
# Offense count: 83
|
|
Lint/ConstantDefinitionInBlock:
|
|
Enabled: false
|
|
|
|
# Offense count: 9
|
|
# Cop supports --auto-correct.
|
|
Lint/DeprecatedOpenSSLConstant:
|
|
Exclude:
|
|
- 'app/services/clusters/kubernetes/configure_istio_ingress_service.rb'
|
|
- 'ee/lib/gitlab/geo/oauth/logout_state.rb'
|
|
- 'lib/gitlab/conan_token.rb'
|
|
- 'lib/gitlab/gitaly_client.rb'
|
|
- 'lib/gitlab/kubernetes/helm/v2/certificate.rb'
|
|
- 'spec/lib/gitlab/conan_token_spec.rb'
|
|
- 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb'
|
|
- 'spec/support/helpers/smime_helper.rb'
|
|
- 'spec/support/shared_contexts/requests/api/conan_packages_shared_context.rb'
|
|
|
|
# Offense count: 1
|
|
Lint/DuplicateRequire:
|
|
Exclude:
|
|
- 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb'
|
|
|
|
# Offense count: 2
|
|
# Configuration parameters: AllowComments.
|
|
Lint/EmptyFile:
|
|
Exclude:
|
|
- 'db/seeds.rb'
|
|
- 'ee/db/geo/seeds.rb'
|
|
|
|
# Offense count: 8
|
|
# Cop supports --auto-correct.
|
|
Lint/IdentityComparison:
|
|
Exclude:
|
|
- 'spec/lib/gitlab/danger/weightage/maintainers_spec.rb'
|
|
- 'spec/lib/gitlab/danger/weightage/reviewers_spec.rb'
|
|
|
|
# Offense count: 184
|
|
# Configuration parameters: MaximumRangeSize.
|
|
Lint/MissingCopEnableDirective:
|
|
Enabled: false
|
|
|
|
# Offense count: 14
|
|
Lint/MixedRegexpCaptureTypes:
|
|
Exclude:
|
|
- 'app/models/alert_management/alert.rb'
|
|
- 'app/models/project_services/ewm_service.rb'
|
|
- 'app/uploaders/file_uploader.rb'
|
|
- 'ee/lib/gitlab/code_owners/reference_extractor.rb'
|
|
- 'lib/gitlab/ci/pipeline/expression/lexeme/string.rb'
|
|
- 'lib/gitlab/dependency_linker/gemfile_linker.rb'
|
|
- 'lib/gitlab/diff/inline_diff.rb'
|
|
- 'lib/gitlab/diff/suggestions_parser.rb'
|
|
- 'lib/gitlab/github_import/representation/note.rb'
|
|
- 'lib/gitlab/metrics/system.rb'
|
|
- 'lib/gitlab/request_profiler/profile.rb'
|
|
- 'lib/gitlab/slash_commands/issue_move.rb'
|
|
- 'lib/gitlab/slash_commands/issue_new.rb'
|
|
- 'lib/gitlab/slash_commands/run.rb'
|
|
|
|
# Offense count: 141
|
|
# Cop supports --auto-correct.
|
|
Lint/RedundantCopDisableDirective:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
Lint/SelfAssignment:
|
|
Exclude:
|
|
- 'spec/lib/gitlab/search_context/builder_spec.rb'
|
|
|
|
# Offense count: 3
|
|
Lint/StructNewOverride:
|
|
Exclude:
|
|
- 'app/presenters/sentry_error_presenter.rb'
|
|
- 'app/serializers/environment_serializer.rb'
|
|
- 'lib/gitlab/ci/pipeline/duration.rb'
|
|
|
|
# Offense count: 1
|
|
Lint/UnreachableLoop:
|
|
Exclude:
|
|
- 'qa/qa/runtime/feature.rb'
|
|
|
|
# Offense count: 22
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: AllowComments.
|
|
Lint/UselessMethodDefinition:
|
|
Enabled: false
|
|
|
|
# Offense count: 7
|
|
# Configuration parameters: IgnoredMethods, Max.
|
|
Metrics/AbcSize:
|
|
Exclude:
|
|
- 'app/helpers/issuables_helper.rb'
|
|
- 'app/services/merge_requests/build_service.rb'
|
|
- 'app/services/projects/create_service.rb'
|
|
- 'lib/api/helpers.rb'
|
|
- 'lib/gitlab/lograge/custom_options.rb'
|
|
- 'lib/gitlab/rack_attack.rb'
|
|
- 'qa/qa/resource/repository/push.rb'
|
|
|
|
# Offense count: 15
|
|
# Configuration parameters: IgnoredMethods, Max.
|
|
Metrics/CyclomaticComplexity:
|
|
Exclude:
|
|
- 'app/services/projects/create_service.rb'
|
|
- 'app/services/system_hooks_service.rb'
|
|
- 'ee/app/controllers/ee/groups_controller.rb'
|
|
- 'ee/app/helpers/ee/groups_helper.rb'
|
|
- 'ee/lib/security/ci_configuration/sast_build_actions.rb'
|
|
- 'lib/banzai/filter/abstract_reference_filter.rb'
|
|
- 'lib/declarative_policy/runner.rb'
|
|
- 'lib/gitlab/conflict/file.rb'
|
|
- 'lib/gitlab/danger/roulette.rb'
|
|
- 'lib/gitlab/diff/parser.rb'
|
|
- 'lib/gitlab/rack_attack.rb'
|
|
- 'lib/gitlab/sidekiq_cluster/cli.rb'
|
|
- 'lib/gitlab/utils/merge_hash.rb'
|
|
- 'lib/kramdown/parser/atlassian_document_format.rb'
|
|
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
|
|
|
|
# Offense count: 15
|
|
# Configuration parameters: IgnoredMethods, Max.
|
|
Metrics/PerceivedComplexity:
|
|
Exclude:
|
|
- 'app/helpers/submodule_helper.rb'
|
|
- 'app/helpers/tab_helper.rb'
|
|
- 'app/services/projects/create_service.rb'
|
|
- 'ee/app/controllers/ee/groups_controller.rb'
|
|
- 'ee/app/helpers/ee/groups_helper.rb'
|
|
- 'ee/lib/security/ci_configuration/sast_build_actions.rb'
|
|
- 'lib/banzai/filter/abstract_reference_filter.rb'
|
|
- 'lib/banzai/renderer.rb'
|
|
- 'lib/declarative_policy/runner.rb'
|
|
- 'lib/gitlab/conflict/file.rb'
|
|
- 'lib/gitlab/danger/roulette.rb'
|
|
- 'lib/gitlab/rack_attack.rb'
|
|
- 'lib/gitlab/sidekiq_cluster/cli.rb'
|
|
- 'lib/gitlab/utils/merge_hash.rb'
|
|
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
|
|
|
|
# Offense count: 1
|
|
# Cop supports --auto-correct.
|
|
Migration/DepartmentName:
|
|
Exclude:
|
|
- 'app/models/commit.rb'
|
|
|
|
# Offense count: 184
|
|
# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, Regex, IgnoreExecutableScripts, AllowedAcronyms.
|
|
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
|
|
Naming/FileName:
|
|
Enabled: false
|
|
|
|
# Offense count: 11
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: lowercase, uppercase
|
|
Naming/HeredocDelimiterCase:
|
|
Exclude:
|
|
- 'spec/lib/gitlab/diff/parser_spec.rb'
|
|
- 'spec/lib/json_web_token/rsa_token_spec.rb'
|
|
- 'spec/models/commit_spec.rb'
|
|
- 'spec/support/helpers/repo_helpers.rb'
|
|
- 'spec/support/helpers/seed_repo.rb'
|
|
|
|
# Offense count: 308
|
|
# Configuration parameters: ForbiddenDelimiters.
|
|
# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
|
|
Naming/HeredocDelimiterNaming:
|
|
Enabled: false
|
|
|
|
# Offense count: 5
|
|
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
|
|
# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
|
|
Naming/MethodParameterName:
|
|
Exclude:
|
|
- 'lib/gitlab/diff/inline_diff.rb'
|
|
- 'spec/support/helpers/key_generator_helper.rb'
|
|
|
|
# Offense count: 206
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: PreferredName.
|
|
Naming/RescuedExceptionsVariableName:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
# Cop supports --auto-correct.
|
|
Performance/AncestorsInclude:
|
|
Exclude:
|
|
- 'lib/gitlab/ci/config/extendable/entry.rb'
|
|
|
|
# Offense count: 39
|
|
# Cop supports --auto-correct.
|
|
Performance/BlockGivenWithExplicitBlock:
|
|
Enabled: false
|
|
|
|
# Offense count: 28
|
|
# Configuration parameters: MinSize.
|
|
Performance/CollectionLiteralInLoop:
|
|
Enabled: false
|
|
|
|
# Offense count: 37
|
|
# Cop supports --auto-correct.
|
|
Performance/ConstantRegexp:
|
|
Enabled: false
|
|
|
|
# Offense count: 18
|
|
# Cop supports --auto-correct.
|
|
Performance/Count:
|
|
Exclude:
|
|
- 'app/helpers/groups_helper.rb'
|
|
- 'app/services/merge_requests/add_context_service.rb'
|
|
- 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb'
|
|
- 'lib/gitlab/sidekiq_status.rb'
|
|
- 'spec/lib/gitlab/conflict/file_spec.rb'
|
|
- 'spec/lib/gitlab/git/tree_spec.rb'
|
|
- 'spec/models/ci/build_spec.rb'
|
|
- 'spec/support_specs/helpers/active_record/query_recorder_spec.rb'
|
|
|
|
# Offense count: 14
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: SafeMultiline.
|
|
Performance/DeletePrefix:
|
|
Exclude:
|
|
- 'app/helpers/submodule_helper.rb'
|
|
- 'app/workers/concerns/application_worker.rb'
|
|
- 'ee/lib/gitlab/geo/git_ssh_proxy.rb'
|
|
- 'lib/banzai/filter/repository_link_filter.rb'
|
|
- 'lib/gitlab/auth/ldap/dn.rb'
|
|
- 'lib/gitlab/gfm/uploads_rewriter.rb'
|
|
- 'lib/gitlab/git/ref.rb'
|
|
- 'lib/gitlab/project_template.rb'
|
|
- 'lib/gitlab/setup_helper.rb'
|
|
- 'lib/gitlab/time_tracking_formatter.rb'
|
|
- 'spec/controllers/projects/artifacts_controller_spec.rb'
|
|
- 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
|
|
- 'spec/support/helpers/test_env.rb'
|
|
|
|
# Offense count: 5
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: SafeMultiline.
|
|
Performance/DeleteSuffix:
|
|
Exclude:
|
|
- 'app/helpers/submodule_helper.rb'
|
|
- 'app/workers/concerns/application_worker.rb'
|
|
- 'ee/app/models/geo/upload_registry.rb'
|
|
- 'ee/app/workers/geo/file_download_dispatch_worker/attachment_job_finder.rb'
|
|
- 'lib/sentry/client/issue.rb'
|
|
|
|
# Offense count: 13
|
|
# Cop supports --auto-correct.
|
|
Performance/Detect:
|
|
Exclude:
|
|
- 'ee/spec/controllers/projects/dependencies_controller_spec.rb'
|
|
- 'ee/spec/requests/api/dependencies_spec.rb'
|
|
- 'qa/qa/runtime/feature.rb'
|
|
- 'spec/lib/gitlab/git/tree_spec.rb'
|
|
- 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb'
|
|
- 'spec/models/event_spec.rb'
|
|
|
|
# Offense count: 116
|
|
Performance/MethodObjectAsBlock:
|
|
Enabled: false
|
|
|
|
# Offense count: 18
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: AutoCorrect.
|
|
Performance/StringInclude:
|
|
Exclude:
|
|
- 'app/helpers/groups_helper.rb'
|
|
- 'app/models/snippet_repository.rb'
|
|
- 'config/initializers/macos.rb'
|
|
- 'config/spring.rb'
|
|
- 'ee/app/models/ee/container_registry/event.rb'
|
|
- 'ee/lib/gitlab/auth/smartcard/certificate.rb'
|
|
- 'lib/gitlab/database/migration_helpers.rb'
|
|
- 'lib/kramdown/parser/atlassian_document_format.rb'
|
|
- 'lib/prometheus/pid_provider.rb'
|
|
- 'qa/qa/ee/page/merge_request/show.rb'
|
|
- 'qa/qa/specs/runner.rb'
|
|
- 'spec/features/projects/jobs_spec.rb'
|
|
- 'spec/spec_helper.rb'
|
|
- 'spec/support_specs/helpers/active_record/query_recorder_spec.rb'
|
|
|
|
# Offense count: 18
|
|
# Cop supports --auto-correct.
|
|
Performance/Sum:
|
|
Exclude:
|
|
- 'app/controllers/projects/pipelines/tests_controller.rb'
|
|
- 'app/models/application_setting_implementation.rb'
|
|
- 'app/models/ci/pipeline.rb'
|
|
- 'app/services/issues/export_csv_service.rb'
|
|
- 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb'
|
|
- 'lib/api/entities/issuable_time_stats.rb'
|
|
- 'lib/container_registry/tag.rb'
|
|
- 'lib/declarative_policy/rule.rb'
|
|
- 'lib/declarative_policy/runner.rb'
|
|
- 'lib/gitlab/ci/reports/test_suite_comparer.rb'
|
|
- 'lib/gitlab/diff/file.rb'
|
|
- 'lib/gitlab/sherlock/transaction.rb'
|
|
- 'lib/gitlab/usage_data.rb'
|
|
- 'lib/peek/views/detailed_view.rb'
|
|
- 'spec/models/namespace/root_storage_statistics_spec.rb'
|
|
|
|
# Offense count: 14717
|
|
# Configuration parameters: Prefixes.
|
|
# Prefixes: when, with, without
|
|
RSpec/ContextWording:
|
|
Enabled: false
|
|
|
|
# Offense count: 4
|
|
# Configuration parameters: CustomIncludeMethods.
|
|
RSpec/EmptyExampleGroup:
|
|
Exclude:
|
|
- 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb'
|
|
- 'spec/services/projects/prometheus/alerts/notify_service_spec.rb'
|
|
|
|
# Offense count: 1365
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: method_call, block
|
|
RSpec/ExpectChange:
|
|
Enabled: false
|
|
|
|
# Offense count: 889
|
|
RSpec/ExpectInHook:
|
|
Enabled: false
|
|
|
|
# Offense count: 16403
|
|
# Configuration parameters: AllowSubject.
|
|
RSpec/MultipleMemoizedHelpers:
|
|
Max: 40
|
|
|
|
# Offense count: 2352
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
|
|
# SupportedStyles: inflected, explicit
|
|
RSpec/PredicateMatcher:
|
|
Enabled: false
|
|
|
|
# Offense count: 112
|
|
RSpec/RepeatedExampleGroupBody:
|
|
Enabled: false
|
|
|
|
# Offense count: 219
|
|
RSpec/RepeatedExampleGroupDescription:
|
|
Enabled: false
|
|
|
|
# Offense count: 655
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: and_return, block
|
|
RSpec/ReturnFromStub:
|
|
Enabled: false
|
|
|
|
# Offense count: 596
|
|
# Cop supports --auto-correct.
|
|
RSpec/ScatteredLet:
|
|
Enabled: false
|
|
|
|
# Offense count: 6
|
|
RSpec/ScatteredSetup:
|
|
Exclude:
|
|
- 'spec/requests/api/jobs_spec.rb'
|
|
|
|
# Offense count: 10
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: symbols, strings
|
|
RSpec/VariableDefinition:
|
|
Exclude:
|
|
- 'spec/initializers/mail_encoding_patch_spec.rb'
|
|
|
|
# Offense count: 24
|
|
# Configuration parameters: EnforcedStyle, IgnoredPatterns.
|
|
# SupportedStyles: snake_case, camelCase
|
|
RSpec/VariableName:
|
|
Exclude:
|
|
- 'spec/features/projects/import_export/import_file_spec.rb'
|
|
- 'spec/features/task_lists_spec.rb'
|
|
- 'spec/initializers/mail_encoding_patch_spec.rb'
|
|
- 'spec/models/board_spec.rb'
|
|
- 'spec/support/shared_contexts/url_shared_context.rb'
|
|
- 'spec/support/shared_examples/requests/api/graphql/group_and_project_boards_query_shared_examples.rb'
|
|
- 'spec/support/shared_examples/services/boards/boards_list_service_shared_examples.rb'
|
|
|
|
# Offense count: 25
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: Include.
|
|
# Include: app/models/**/*.rb
|
|
Rails/ActiveRecordCallbacksOrder:
|
|
Enabled: false
|
|
|
|
# Offense count: 10
|
|
# Cop supports --auto-correct.
|
|
Rails/ApplicationController:
|
|
Exclude:
|
|
- 'app/controllers/acme_challenges_controller.rb'
|
|
- 'app/controllers/chaos_controller.rb'
|
|
- 'app/controllers/health_controller.rb'
|
|
- 'app/controllers/metrics_controller.rb'
|
|
- 'ee/app/controllers/oauth/geo_auth_controller.rb'
|
|
- 'ee/spec/helpers/ee/services_helper_spec.rb'
|
|
- 'lib/gitlab/base_doorkeeper_controller.rb'
|
|
- 'lib/gitlab/request_forgery_protection.rb'
|
|
- 'spec/controllers/concerns/continue_params_spec.rb'
|
|
- 'spec/lib/marginalia_spec.rb'
|
|
|
|
# Offense count: 3
|
|
# Cop supports --auto-correct.
|
|
Rails/BelongsTo:
|
|
Exclude:
|
|
- 'app/models/deployment.rb'
|
|
- 'app/models/environment.rb'
|
|
|
|
# Offense count: 90
|
|
# Configuration parameters: Database, Include.
|
|
# SupportedDatabases: mysql, postgresql
|
|
# Include: db/migrate/*.rb
|
|
Rails/BulkChangeTable:
|
|
Enabled: false
|
|
|
|
# Offense count: 153
|
|
# Cop supports --auto-correct.
|
|
Rails/ContentTag:
|
|
Enabled: false
|
|
|
|
# Offense count: 300
|
|
# Configuration parameters: Include.
|
|
# Include: db/migrate/*.rb
|
|
Rails/CreateTableWithTimestamps:
|
|
Enabled: false
|
|
|
|
# Offense count: 347
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: slashes, arguments
|
|
Rails/FilePath:
|
|
Enabled: false
|
|
|
|
# Offense count: 15
|
|
# Cop supports --auto-correct.
|
|
Rails/FindById:
|
|
Exclude:
|
|
- 'app/controllers/projects/pipelines_controller.rb'
|
|
- 'app/services/concerns/deploy_token_methods.rb'
|
|
- 'ee/app/controllers/ee/groups/group_members_controller.rb'
|
|
- 'ee/lib/api/audit_events.rb'
|
|
- 'ee/lib/api/merge_request_approval_rules.rb'
|
|
- 'ee/lib/ee/api/groups.rb'
|
|
- 'ee/lib/ee/api/projects.rb'
|
|
- 'ee/spec/finders/audit_log_finder_spec.rb'
|
|
- 'lib/api/snippets.rb'
|
|
- 'spec/finders/concerns/finder_methods_spec.rb'
|
|
- 'spec/finders/concerns/finder_with_cross_project_access_spec.rb'
|
|
|
|
# Offense count: 346
|
|
# Configuration parameters: Include.
|
|
# Include: app/models/**/*.rb
|
|
Rails/HasManyOrHasOneDependent:
|
|
Enabled: false
|
|
|
|
# Offense count: 539
|
|
# Configuration parameters: Include.
|
|
# Include: app/helpers/**/*.rb
|
|
Rails/HelperInstanceVariable:
|
|
Enabled: false
|
|
|
|
# Offense count: 17
|
|
# Cop supports --auto-correct.
|
|
Rails/IndexBy:
|
|
Exclude:
|
|
- 'app/graphql/types/design_management/design_fields.rb'
|
|
- 'app/models/ci/pipeline.rb'
|
|
- 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb'
|
|
- 'ee/app/services/projects/update_mirror_service.rb'
|
|
- 'ee/app/services/security/store_report_service.rb'
|
|
- 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb'
|
|
- 'ee/lib/ee/gitlab/background_migration/backfill_version_data_from_gitaly.rb'
|
|
- 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb'
|
|
- 'ee/lib/gitlab/elastic/document_reference.rb'
|
|
- 'ee/lib/gitlab/group_plans_preloader.rb'
|
|
- 'lib/gitlab/danger/sidekiq_queues.rb'
|
|
- 'lib/gitlab/database/count/reltuples_count_strategy.rb'
|
|
- 'lib/gitlab/language_detection.rb'
|
|
|
|
# Offense count: 45
|
|
# Cop supports --auto-correct.
|
|
Rails/IndexWith:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
Rails/Inquiry:
|
|
Exclude:
|
|
- 'spec/helpers/labels_helper_spec.rb'
|
|
|
|
# Offense count: 115
|
|
# Configuration parameters: Include.
|
|
# Include: app/models/**/*.rb
|
|
Rails/InverseOf:
|
|
Enabled: false
|
|
|
|
# Offense count: 60
|
|
# Configuration parameters: Include.
|
|
# Include: app/controllers/**/*.rb
|
|
Rails/LexicallyScopedActionFilter:
|
|
Enabled: false
|
|
|
|
# Offense count: 3
|
|
# Cop supports --auto-correct.
|
|
Rails/LinkToBlank:
|
|
Exclude:
|
|
- 'app/helpers/projects_helper.rb'
|
|
- 'app/helpers/wiki_helper.rb'
|
|
- 'ee/app/helpers/ee/user_callouts_helper.rb'
|
|
|
|
# Offense count: 1
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: Include.
|
|
# Include: app/mailers/**/*.rb
|
|
Rails/MailerName:
|
|
Exclude:
|
|
- 'app/mailers/notify.rb'
|
|
|
|
# Offense count: 51
|
|
# Cop supports --auto-correct.
|
|
Rails/NegateInclude:
|
|
Enabled: false
|
|
|
|
# Offense count: 44
|
|
# Cop supports --auto-correct.
|
|
Rails/Pick:
|
|
Enabled: false
|
|
|
|
# Offense count: 110
|
|
# Cop supports --auto-correct.
|
|
Rails/Pluck:
|
|
Enabled: false
|
|
|
|
# Offense count: 39
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: Include.
|
|
# Include: **/Rakefile, **/*.rake
|
|
Rails/RakeEnvironment:
|
|
Enabled: false
|
|
|
|
# Offense count: 58
|
|
# Cop supports --auto-correct.
|
|
Rails/RedundantForeignKey:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
Rails/RenderInline:
|
|
Exclude:
|
|
- 'ee/app/controllers/sitemap_controller.rb'
|
|
|
|
# Offense count: 4
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: conservative, aggressive
|
|
Rails/ShortI18n:
|
|
Exclude:
|
|
- 'app/models/project_services/chat_message/pipeline_message.rb'
|
|
- 'app/uploaders/content_type_whitelist.rb'
|
|
- 'spec/views/shared/runners/show.html.haml_spec.rb'
|
|
|
|
# Offense count: 1080
|
|
# Configuration parameters: ForbiddenMethods, AllowedMethods.
|
|
# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
|
|
Rails/SkipsModelValidations:
|
|
Enabled: false
|
|
|
|
# Offense count: 251
|
|
# Cop supports --auto-correct.
|
|
Rails/SquishedSQLHeredocs:
|
|
Enabled: false
|
|
|
|
# Offense count: 45
|
|
# Cop supports --auto-correct.
|
|
Rails/WhereEquals:
|
|
Enabled: false
|
|
|
|
# Offense count: 40
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: exists, where
|
|
Rails/WhereExists:
|
|
Enabled: false
|
|
|
|
# Offense count: 21
|
|
# Cop supports --auto-correct.
|
|
Rails/WhereNot:
|
|
Enabled: false
|
|
|
|
# Offense count: 8
|
|
# Cop supports --auto-correct.
|
|
Security/YAMLLoad:
|
|
Exclude:
|
|
- 'lib/gitlab/redis/wrapper.rb'
|
|
- 'lib/system_check/incoming_email/imap_authentication_check.rb'
|
|
- 'spec/config/mail_room_spec.rb'
|
|
- 'spec/initializers/secret_token_spec.rb'
|
|
- 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'
|
|
|
|
# Offense count: 240
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: separated, grouped
|
|
Style/AccessorGrouping:
|
|
Enabled: false
|
|
|
|
# Offense count: 12
|
|
# Cop supports --auto-correct.
|
|
Style/ArrayCoercion:
|
|
Exclude:
|
|
- 'app/controllers/admin/ci/variables_controller.rb'
|
|
- 'app/controllers/groups/variables_controller.rb'
|
|
- 'app/controllers/projects/variables_controller.rb'
|
|
- 'db/migrate/20190620105427_change_null_private_profile_to_false.rb'
|
|
- 'db/post_migrate/20190812070645_migrate_private_profile_nulls.rb'
|
|
- 'db/post_migrate/20200311130802_schedule_populate_user_highest_roles_table.rb'
|
|
- 'db/post_migrate/20200805152108_migrate_null_external_diff_store_to_local_value.rb'
|
|
- 'db/post_migrate/20200806173633_migrate_null_package_files_file_store_to_local_value.rb'
|
|
- 'ee/app/services/geo/blob_verification_secondary_service.rb'
|
|
- 'ee/app/services/geo/repository_verification_secondary_service.rb'
|
|
- 'ee/lib/ee/banzai/pipeline/gfm_pipeline.rb'
|
|
- 'spec/support/helpers/lfs_http_helpers.rb'
|
|
|
|
# Offense count: 183
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: percent_q, bare_percent
|
|
Style/BarePercentLiterals:
|
|
Enabled: false
|
|
|
|
# Offense count: 6
|
|
# Cop supports --auto-correct.
|
|
Style/BisectedAttrAccessor:
|
|
Exclude:
|
|
- 'lib/system_check/base_check.rb'
|
|
- 'qa/qa/resource/api_fabricator.rb'
|
|
|
|
# Offense count: 36
|
|
# Cop supports --auto-correct.
|
|
Style/CaseLikeIf:
|
|
Enabled: false
|
|
|
|
# Offense count: 15
|
|
Style/CombinableLoops:
|
|
Exclude:
|
|
- 'app/models/application_setting.rb'
|
|
- 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb'
|
|
- 'ee/lib/gitlab/audit/events/preloader.rb'
|
|
- 'ee/spec/finders/snippets_finder_spec.rb'
|
|
- 'ee/spec/lib/ee/gitlab/background_migration/remove_duplicate_cs_findings_spec.rb'
|
|
- 'rubocop/code_reuse_helpers.rb'
|
|
- 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb'
|
|
- 'spec/finders/packages/group_packages_finder_spec.rb'
|
|
- 'spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb'
|
|
- 'spec/migrations/cleanup_optimistic_locking_nulls_spec.rb'
|
|
- 'spec/requests/api/members_spec.rb'
|
|
- 'spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb'
|
|
|
|
# Offense count: 1
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
|
|
# SupportedStyles: assign_to_condition, assign_inside_condition
|
|
Style/ConditionalAssignment:
|
|
Exclude:
|
|
- 'lib/gitlab/database.rb'
|
|
|
|
# Offense count: 5
|
|
# Cop supports --auto-correct.
|
|
Style/EachWithObject:
|
|
Exclude:
|
|
- 'lib/expand_variables.rb'
|
|
- 'lib/gitlab/ci/ansi2html.rb'
|
|
- 'lib/gitlab/hook_data/issuable_builder.rb'
|
|
- 'lib/gitlab/i18n/po_linter.rb'
|
|
- 'lib/gitlab/import_export/members_mapper.rb'
|
|
|
|
# Offense count: 53
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: empty, nil, both
|
|
Style/EmptyElse:
|
|
Enabled: false
|
|
|
|
# Offense count: 197
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: compact, expanded
|
|
Style/EmptyMethod:
|
|
Enabled: false
|
|
|
|
# Offense count: 2
|
|
# Cop supports --auto-correct.
|
|
Style/ExpandPathArguments:
|
|
Exclude:
|
|
- 'cable/config.ru'
|
|
- 'config.ru'
|
|
|
|
# Offense count: 116
|
|
# Cop supports --auto-correct.
|
|
Style/ExplicitBlockArgument:
|
|
Enabled: false
|
|
|
|
# Offense count: 555
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: format, sprintf, percent
|
|
Style/FormatString:
|
|
Enabled: false
|
|
|
|
# Offense count: 61
|
|
# Cop supports --auto-correct.
|
|
Style/GlobalStdStream:
|
|
Enabled: false
|
|
|
|
# Offense count: 879
|
|
# Configuration parameters: MinBodyLength.
|
|
Style/GuardClause:
|
|
Enabled: false
|
|
|
|
# Offense count: 56
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: braces, no_braces
|
|
Style/HashAsLastArrayItem:
|
|
Enabled: false
|
|
|
|
# Offense count: 66
|
|
# Cop supports --auto-correct.
|
|
Style/HashEachMethods:
|
|
Enabled: false
|
|
|
|
# Offense count: 33
|
|
# Configuration parameters: AllowIfModifier.
|
|
Style/IfInsideElse:
|
|
Enabled: false
|
|
|
|
# Offense count: 1888
|
|
# Cop supports --auto-correct.
|
|
Style/IfUnlessModifier:
|
|
Enabled: false
|
|
|
|
# Offense count: 68
|
|
# Cop supports --auto-correct.
|
|
Style/KeywordParametersOrder:
|
|
Enabled: false
|
|
|
|
# Offense count: 431
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: line_count_dependent, lambda, literal
|
|
Style/Lambda:
|
|
Enabled: false
|
|
|
|
# Offense count: 20
|
|
Style/MissingRespondToMissing:
|
|
Enabled: false
|
|
|
|
# Offense count: 35
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, MinBodyLength.
|
|
# SupportedStyles: skip_modifier_ifs, always
|
|
Style/Next:
|
|
Enabled: false
|
|
|
|
# Offense count: 98
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedOctalStyle.
|
|
# SupportedOctalStyles: zero_with_o, zero_only
|
|
Style/NumericLiteralPrefix:
|
|
Enabled: false
|
|
|
|
# Offense count: 135
|
|
# Cop supports --auto-correct.
|
|
Style/ParallelAssignment:
|
|
Enabled: false
|
|
|
|
# Offense count: 2601
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: PreferredDelimiters.
|
|
Style/PercentLiteralDelimiters:
|
|
Enabled: false
|
|
|
|
# Offense count: 1
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: compact, exploded
|
|
Style/RaiseArgs:
|
|
Enabled: false
|
|
|
|
# Offense count: 65
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantAssignment:
|
|
Enabled: false
|
|
|
|
# Offense count: 26
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: SafeForConstants.
|
|
Style/RedundantFetchBlock:
|
|
Exclude:
|
|
- 'app/finders/admin/projects_finder.rb'
|
|
- 'lib/gitlab/diff/file.rb'
|
|
- 'spec/lib/gitlab/json_cache_spec.rb'
|
|
- 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb'
|
|
- 'spec/lib/gitlab/null_request_store_spec.rb'
|
|
- 'spec/lib/gitlab/safe_request_store_spec.rb'
|
|
|
|
# Offense count: 26
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantFileExtensionInRequire:
|
|
Enabled: false
|
|
|
|
# Offense count: 220
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantFreeze:
|
|
Enabled: false
|
|
|
|
# Offense count: 182
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantInterpolation:
|
|
Enabled: false
|
|
|
|
# Offense count: 8
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantRegexpCharacterClass:
|
|
Exclude:
|
|
- 'app/models/concerns/taskable.rb'
|
|
- 'lib/gitlab/authorized_keys.rb'
|
|
- 'lib/gitlab/fogbugz_import/repository.rb'
|
|
- 'lib/gitlab/quick_actions/substitution_definition.rb'
|
|
- 'lib/gitlab/regex.rb'
|
|
- 'spec/features/merge_request/user_views_open_merge_request_spec.rb'
|
|
- 'spec/tasks/gitlab/usage_data_rake_spec.rb'
|
|
|
|
# Offense count: 270
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantRegexpEscape:
|
|
Enabled: false
|
|
|
|
# Offense count: 920
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantSelf:
|
|
Enabled: false
|
|
|
|
# Offense count: 2
|
|
# Cop supports --auto-correct.
|
|
Style/RedundantSelfAssignment:
|
|
Exclude:
|
|
- 'app/models/concerns/issuable.rb'
|
|
- 'spec/db/schema_spec.rb'
|
|
|
|
# Offense count: 196
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
|
|
# SupportedStyles: slashes, percent_r, mixed
|
|
Style/RegexpLiteral:
|
|
Enabled: false
|
|
|
|
# Offense count: 50
|
|
# Cop supports --auto-correct.
|
|
Style/RescueModifier:
|
|
Enabled: false
|
|
|
|
# Offense count: 346
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: implicit, explicit
|
|
Style/RescueStandardError:
|
|
Enabled: false
|
|
|
|
# Offense count: 115
|
|
# Cop supports --auto-correct.
|
|
Style/SingleArgumentDig:
|
|
Enabled: false
|
|
|
|
# Offense count: 45
|
|
# Cop supports --auto-correct.
|
|
Style/SlicingWithRange:
|
|
Enabled: false
|
|
|
|
# Offense count: 61
|
|
# Configuration parameters: AllowModifier.
|
|
Style/SoleNestedConditional:
|
|
Enabled: false
|
|
|
|
# Offense count: 121
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: .
|
|
# SupportedStyles: use_perl_names, use_english_names
|
|
Style/SpecialGlobalVars:
|
|
EnforcedStyle: use_perl_names
|
|
|
|
# Offense count: 545
|
|
# Cop supports --auto-correct.
|
|
Style/StringConcatenation:
|
|
Enabled: false
|
|
|
|
# Offense count: 108
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: single_quotes, double_quotes
|
|
Style/StringLiteralsInInterpolation:
|
|
Enabled: false
|
|
|
|
# Offense count: 292
|
|
# Cop supports --auto-correct.
|
|
# Configuration parameters: IgnoredMethods.
|
|
# IgnoredMethods: respond_to, define_method
|
|
Style/SymbolProc:
|
|
Enabled: false
|
|
|