59 lines
1.2 KiB
Ruby
59 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'fast_spec_helper'
|
|
|
|
require 'rubocop'
|
|
require 'rubocop/rspec/support'
|
|
|
|
require_relative '../../../../rubocop/cop/gitlab/finder_with_find_by'
|
|
|
|
RSpec.describe RuboCop::Cop::Gitlab::FinderWithFindBy, type: :rubocop do
|
|
include CopHelper
|
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
context 'when calling execute.find' do
|
|
let(:source) do
|
|
<<~SRC
|
|
DummyFinder.new(some_args)
|
|
.execute
|
|
.find_by!(1)
|
|
SRC
|
|
end
|
|
let(:corrected_source) do
|
|
<<~SRC
|
|
DummyFinder.new(some_args)
|
|
.find_by!(1)
|
|
SRC
|
|
end
|
|
|
|
it 'registers an offence' do
|
|
inspect_source(source)
|
|
|
|
expect(cop.offenses.size).to eq(1)
|
|
end
|
|
|
|
it 'can autocorrect the source' do
|
|
expect(autocorrect_source(source)).to eq(corrected_source)
|
|
end
|
|
|
|
context 'when called within the `FinderMethods` module' do
|
|
let(:source) do
|
|
<<~SRC
|
|
module FinderMethods
|
|
def find_by!(*args)
|
|
execute.find_by!(args)
|
|
end
|
|
end
|
|
SRC
|
|
end
|
|
|
|
it 'does not register an offence' do
|
|
inspect_source(source)
|
|
|
|
expect(cop.offenses).to be_empty
|
|
end
|
|
end
|
|
end
|
|
end
|