202 lines
6.5 KiB
Ruby
202 lines
6.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe API::ProtectedTags do
|
|
let(:user) { create(:user) }
|
|
let!(:project) { create(:project, :repository) }
|
|
let(:project2) { create(:project, path: 'project2', namespace: user.namespace) }
|
|
let(:protected_name) { 'feature' }
|
|
let(:tag_name) { protected_name }
|
|
let!(:protected_tag) do
|
|
create(:protected_tag, project: project, name: protected_name)
|
|
end
|
|
|
|
describe 'GET /projects/:id/protected_tags' do
|
|
let(:route) { "/projects/#{project.id}/protected_tags" }
|
|
|
|
shared_examples_for 'protected tags' do
|
|
it 'returns the protected tags' do
|
|
get api(route, user), params: { per_page: 100 }
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
expect(response).to include_pagination_headers
|
|
expect(json_response).to be_an Array
|
|
|
|
protected_tag_names = json_response.map { |x| x['name'] }
|
|
expected_tags_names = project.protected_tags.map { |x| x['name'] }
|
|
expect(protected_tag_names).to match_array(expected_tags_names)
|
|
end
|
|
end
|
|
|
|
context 'when authenticated as a maintainer' do
|
|
before do
|
|
project.add_maintainer(user)
|
|
end
|
|
|
|
it_behaves_like 'protected tags'
|
|
end
|
|
|
|
context 'when authenticated as a guest' do
|
|
before do
|
|
project.add_guest(user)
|
|
end
|
|
|
|
it_behaves_like '403 response' do
|
|
let(:request) { get api(route, user) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'GET /projects/:id/protected_tags/:tag' do
|
|
let(:route) { "/projects/#{project.id}/protected_tags/#{tag_name}" }
|
|
|
|
shared_examples_for 'protected tag' do
|
|
it 'returns the protected tag' do
|
|
get api(route, user)
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
expect(json_response['name']).to eq(tag_name)
|
|
expect(json_response['create_access_levels'][0]['access_level']).to eq(::Gitlab::Access::MAINTAINER)
|
|
end
|
|
|
|
context 'when protected tag does not exist' do
|
|
let(:tag_name) { 'unknown' }
|
|
|
|
it_behaves_like '404 response' do
|
|
let(:request) { get api(route, user) }
|
|
let(:message) { '404 Not found' }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated as a maintainer' do
|
|
before do
|
|
project.add_maintainer(user)
|
|
end
|
|
|
|
it_behaves_like 'protected tag'
|
|
|
|
context 'when protected tag contains a wildcard' do
|
|
let(:protected_name) { 'feature*' }
|
|
|
|
it_behaves_like 'protected tag'
|
|
end
|
|
end
|
|
|
|
context 'when authenticated as a guest' do
|
|
before do
|
|
project.add_guest(user)
|
|
end
|
|
|
|
it_behaves_like '403 response' do
|
|
let(:request) { get api(route, user) }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST /projects/:id/protected_tags' do
|
|
let(:tag_name) { 'new_tag' }
|
|
|
|
context 'when authenticated as a maintainer' do
|
|
before do
|
|
project.add_maintainer(user)
|
|
end
|
|
|
|
it 'protects a single tag with maintainers can create tags' do
|
|
post api("/projects/#{project.id}/protected_tags", user), params: { name: tag_name }
|
|
|
|
expect(response).to have_gitlab_http_status(201)
|
|
expect(json_response['name']).to eq(tag_name)
|
|
expect(json_response['create_access_levels'][0]['access_level']).to eq(Gitlab::Access::MAINTAINER)
|
|
end
|
|
|
|
it 'protects a single tag with developers can create tags' do
|
|
post api("/projects/#{project.id}/protected_tags", user),
|
|
params: { name: tag_name, create_access_level: 30 }
|
|
|
|
expect(response).to have_gitlab_http_status(201)
|
|
expect(json_response['name']).to eq(tag_name)
|
|
expect(json_response['create_access_levels'][0]['access_level']).to eq(Gitlab::Access::DEVELOPER)
|
|
end
|
|
|
|
it 'protects a single tag with no one can create tags' do
|
|
post api("/projects/#{project.id}/protected_tags", user),
|
|
params: { name: tag_name, create_access_level: 0 }
|
|
|
|
expect(response).to have_gitlab_http_status(201)
|
|
expect(json_response['name']).to eq(tag_name)
|
|
expect(json_response['create_access_levels'][0]['access_level']).to eq(Gitlab::Access::NO_ACCESS)
|
|
end
|
|
|
|
it 'returns a 422 error if the same tag is protected twice' do
|
|
post api("/projects/#{project.id}/protected_tags", user), params: { name: protected_name }
|
|
|
|
expect(response).to have_gitlab_http_status(422)
|
|
expect(json_response['message'][0]).to eq('Name has already been taken')
|
|
end
|
|
|
|
it 'returns 201 if the same tag is proteted on different projects' do
|
|
post api("/projects/#{project.id}/protected_tags", user), params: { name: protected_name }
|
|
post api("/projects/#{project2.id}/protected_tags", user), params: { name: protected_name }
|
|
|
|
expect(response).to have_gitlab_http_status(201)
|
|
expect(json_response['name']).to eq(protected_name)
|
|
end
|
|
|
|
context 'when tag has a wildcard in its name' do
|
|
let(:tag_name) { 'feature/*' }
|
|
|
|
it 'protects multiple tags with a wildcard in the name' do
|
|
post api("/projects/#{project.id}/protected_tags", user), params: { name: tag_name }
|
|
|
|
expect(response).to have_gitlab_http_status(201)
|
|
expect(json_response['name']).to eq(tag_name)
|
|
expect(json_response['create_access_levels'][0]['access_level']).to eq(Gitlab::Access::MAINTAINER)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when authenticated as a guest' do
|
|
before do
|
|
project.add_guest(user)
|
|
end
|
|
|
|
it 'returns a 403 error if guest' do
|
|
post api("/projects/#{project.id}/protected_tags/", user), params: { name: tag_name }
|
|
|
|
expect(response).to have_gitlab_http_status(403)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'DELETE /projects/:id/protected_tags/unprotect/:tag' do
|
|
before do
|
|
project.add_maintainer(user)
|
|
end
|
|
|
|
it 'unprotects a single tag' do
|
|
delete api("/projects/#{project.id}/protected_tags/#{tag_name}", user)
|
|
|
|
expect(response).to have_gitlab_http_status(204)
|
|
end
|
|
|
|
it_behaves_like '412 response' do
|
|
let(:request) { api("/projects/#{project.id}/protected_tags/#{tag_name}", user) }
|
|
end
|
|
|
|
it "returns 404 if tag does not exist" do
|
|
delete api("/projects/#{project.id}/protected_tags/barfoo", user)
|
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
end
|
|
|
|
context 'when tag has a wildcard in its name' do
|
|
let(:protected_name) { 'feature*' }
|
|
|
|
it 'unprotects a wildcard tag' do
|
|
delete api("/projects/#{project.id}/protected_tags/#{tag_name}", user)
|
|
|
|
expect(response).to have_gitlab_http_status(204)
|
|
end
|
|
end
|
|
end
|
|
end
|