115 lines
3.7 KiB
Ruby
115 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Members::ApproveAccessRequestService do
|
|
let(:project) { create(:project, :public) }
|
|
let(:group) { create(:group, :public) }
|
|
let(:current_user) { create(:user) }
|
|
let(:access_requester_user) { create(:user) }
|
|
let(:access_requester) { source.requesters.find_by!(user_id: access_requester_user.id) }
|
|
let(:opts) { {} }
|
|
|
|
shared_examples 'a service raising ActiveRecord::RecordNotFound' do
|
|
it 'raises ActiveRecord::RecordNotFound' do
|
|
expect { described_class.new(current_user).execute(access_requester, **opts) }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
end
|
|
|
|
shared_examples 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
it 'raises Gitlab::Access::AccessDeniedError' do
|
|
expect { described_class.new(current_user).execute(access_requester, **opts) }.to raise_error(Gitlab::Access::AccessDeniedError)
|
|
end
|
|
end
|
|
|
|
shared_examples 'a service approving an access request' do
|
|
it 'succeeds' do
|
|
expect { described_class.new(current_user).execute(access_requester, **opts) }.to change { source.requesters.count }.by(-1)
|
|
end
|
|
|
|
it 'returns a <Source>Member' do
|
|
member = described_class.new(current_user).execute(access_requester, **opts)
|
|
|
|
expect(member).to be_a "#{source.class}Member".constantize
|
|
expect(member.requested_at).to be_nil
|
|
end
|
|
|
|
context 'with a custom access level' do
|
|
it 'returns a ProjectMember with the custom access level' do
|
|
member = described_class.new(current_user, access_level: Gitlab::Access::MAINTAINER).execute(access_requester, **opts)
|
|
|
|
expect(member.access_level).to eq(Gitlab::Access::MAINTAINER)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when an access requester is found' do
|
|
before do
|
|
project.request_access(access_requester_user)
|
|
group.request_access(access_requester_user)
|
|
end
|
|
|
|
context 'when current user is nil' do
|
|
let(:user) { nil }
|
|
|
|
context 'and :ldap option is not given' do
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { project }
|
|
end
|
|
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { group }
|
|
end
|
|
end
|
|
|
|
context 'and :skip_authorization option is false' do
|
|
let(:opts) { { skip_authorization: false } }
|
|
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { project }
|
|
end
|
|
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { group }
|
|
end
|
|
end
|
|
|
|
context 'and :skip_authorization option is true' do
|
|
let(:opts) { { skip_authorization: true } }
|
|
|
|
it_behaves_like 'a service approving an access request' do
|
|
let(:source) { project }
|
|
end
|
|
|
|
it_behaves_like 'a service approving an access request' do
|
|
let(:source) { group }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when current user cannot approve access request to the project' do
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { project }
|
|
end
|
|
|
|
it_behaves_like 'a service raising Gitlab::Access::AccessDeniedError' do
|
|
let(:source) { group }
|
|
end
|
|
end
|
|
|
|
context 'when current user can approve access request to the project' do
|
|
before do
|
|
project.add_maintainer(current_user)
|
|
group.add_owner(current_user)
|
|
end
|
|
|
|
it_behaves_like 'a service approving an access request' do
|
|
let(:source) { project }
|
|
end
|
|
|
|
it_behaves_like 'a service approving an access request' do
|
|
let(:source) { group }
|
|
end
|
|
end
|
|
end
|
|
end
|