171 lines
6.6 KiB
Ruby
171 lines
6.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe API::API, 'ProjectHooks', api: true do
|
|
include ApiHelpers
|
|
let(:user) { create(:user) }
|
|
let(:user3) { create(:user) }
|
|
let!(:project) { create(:project, creator_id: user.id, namespace: user.namespace) }
|
|
let!(:hook) do
|
|
create(:project_hook,
|
|
project: project, url: "http://example.com",
|
|
push_events: true, merge_requests_events: true, tag_push_events: true,
|
|
issues_events: true, note_events: true, build_events: true,
|
|
enable_ssl_verification: true)
|
|
end
|
|
|
|
before do
|
|
project.team << [user, :master]
|
|
project.team << [user3, :developer]
|
|
end
|
|
|
|
describe "GET /projects/:id/hooks" do
|
|
context "authorized user" do
|
|
it "should return project hooks" do
|
|
get api("/projects/#{project.id}/hooks", user)
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(json_response).to be_an Array
|
|
expect(json_response.count).to eq(1)
|
|
expect(json_response.first['url']).to eq("http://example.com")
|
|
expect(json_response.first['issues_events']).to eq(true)
|
|
expect(json_response.first['push_events']).to eq(true)
|
|
expect(json_response.first['merge_requests_events']).to eq(true)
|
|
expect(json_response.first['tag_push_events']).to eq(true)
|
|
expect(json_response.first['note_events']).to eq(true)
|
|
expect(json_response.first['build_events']).to eq(true)
|
|
expect(json_response.first['enable_ssl_verification']).to eq(true)
|
|
end
|
|
end
|
|
|
|
context "unauthorized user" do
|
|
it "should not access project hooks" do
|
|
get api("/projects/#{project.id}/hooks", user3)
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "GET /projects/:id/hooks/:hook_id" do
|
|
context "authorized user" do
|
|
it "should return a project hook" do
|
|
get api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
|
expect(response.status).to eq(200)
|
|
expect(json_response['url']).to eq(hook.url)
|
|
expect(json_response['issues_events']).to eq(hook.issues_events)
|
|
expect(json_response['push_events']).to eq(hook.push_events)
|
|
expect(json_response['merge_requests_events']).to eq(hook.merge_requests_events)
|
|
expect(json_response['tag_push_events']).to eq(hook.tag_push_events)
|
|
expect(json_response['note_events']).to eq(hook.note_events)
|
|
expect(json_response['enable_ssl_verification']).to eq(hook.enable_ssl_verification)
|
|
end
|
|
|
|
it "should return a 404 error if hook id is not available" do
|
|
get api("/projects/#{project.id}/hooks/1234", user)
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
context "unauthorized user" do
|
|
it "should not access an existing hook" do
|
|
get api("/projects/#{project.id}/hooks/#{hook.id}", user3)
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
it "should return a 404 error if hook id is not available" do
|
|
get api("/projects/#{project.id}/hooks/1234", user)
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
describe "POST /projects/:id/hooks" do
|
|
it "should add hook to project" do
|
|
expect do
|
|
post api("/projects/#{project.id}/hooks", user), url: "http://example.com", issues_events: true
|
|
end.to change {project.hooks.count}.by(1)
|
|
expect(response.status).to eq(201)
|
|
expect(json_response['url']).to eq('http://example.com')
|
|
expect(json_response['issues_events']).to eq(true)
|
|
expect(json_response['push_events']).to eq(true)
|
|
expect(json_response['merge_requests_events']).to eq(false)
|
|
expect(json_response['tag_push_events']).to eq(false)
|
|
expect(json_response['note_events']).to eq(false)
|
|
expect(json_response['build_events']).to eq(false)
|
|
expect(json_response['enable_ssl_verification']).to eq(true)
|
|
end
|
|
|
|
it "should return a 400 error if url not given" do
|
|
post api("/projects/#{project.id}/hooks", user)
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "should return a 422 error if url not valid" do
|
|
post api("/projects/#{project.id}/hooks", user), "url" => "ftp://example.com"
|
|
expect(response.status).to eq(422)
|
|
end
|
|
end
|
|
|
|
describe "PUT /projects/:id/hooks/:hook_id" do
|
|
it "should update an existing project hook" do
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user),
|
|
url: 'http://example.org', push_events: false
|
|
expect(response.status).to eq(200)
|
|
expect(json_response['url']).to eq('http://example.org')
|
|
expect(json_response['issues_events']).to eq(hook.issues_events)
|
|
expect(json_response['push_events']).to eq(false)
|
|
expect(json_response['merge_requests_events']).to eq(hook.merge_requests_events)
|
|
expect(json_response['tag_push_events']).to eq(hook.tag_push_events)
|
|
expect(json_response['note_events']).to eq(hook.note_events)
|
|
expect(json_response['enable_ssl_verification']).to eq(hook.enable_ssl_verification)
|
|
end
|
|
|
|
it "should return 404 error if hook id not found" do
|
|
put api("/projects/#{project.id}/hooks/1234", user), url: 'http://example.org'
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "should return 400 error if url is not given" do
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "should return a 422 error if url is not valid" do
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user), url: 'ftp://example.com'
|
|
expect(response.status).to eq(422)
|
|
end
|
|
end
|
|
|
|
describe "DELETE /projects/:id/hooks/:hook_id" do
|
|
it "should delete hook from project" do
|
|
expect do
|
|
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
|
end.to change {project.hooks.count}.by(-1)
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it "should return success when deleting hook" do
|
|
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it "should return a 404 error when deleting non existent hook" do
|
|
delete api("/projects/#{project.id}/hooks/42", user)
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "should return a 405 error if hook id not given" do
|
|
delete api("/projects/#{project.id}/hooks", user)
|
|
expect(response.status).to eq(405)
|
|
end
|
|
|
|
it "shold return a 404 if a user attempts to delete project hooks he/she does not own" do
|
|
test_user = create(:user)
|
|
other_project = create(:project)
|
|
other_project.team << [test_user, :master]
|
|
|
|
delete api("/projects/#{other_project.id}/hooks/#{hook.id}", test_user)
|
|
expect(response.status).to eq(404)
|
|
expect(WebHook.exists?(hook.id)).to be_truthy
|
|
end
|
|
end
|
|
end
|