303 lines
11 KiB
Ruby
303 lines
11 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Projects::LabelsController, feature_category: :team_planning do
|
|
let_it_be(:group) { create(:group) }
|
|
let_it_be(:project, reload: true) { create(:project, namespace: group) }
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let_it_be(:label_1) { create(:label, project: project, priority: 1, title: 'Label 1') }
|
|
let_it_be(:label_2) { create(:label, project: project, priority: 3, title: 'Label 2') }
|
|
let_it_be(:label_3) { create(:label, project: project, priority: 1, title: 'Label 3') }
|
|
let_it_be(:label_4) { create(:label, project: project, title: 'Label 4') }
|
|
let_it_be(:label_5) { create(:label, project: project, title: 'Label 5') }
|
|
|
|
let_it_be(:group_label_1) { create(:group_label, group: group, title: 'Group Label 1') }
|
|
let_it_be(:group_label_2) { create(:group_label, group: group, title: 'Group Label 2') }
|
|
let_it_be(:group_label_3) { create(:group_label, group: group, title: 'Group Label 3') }
|
|
let_it_be(:group_label_4) { create(:group_label, group: group, title: 'Group Label 4') }
|
|
|
|
let_it_be(:group_labels) { [group_label_3, group_label_4] }
|
|
let_it_be(:project_labels) { [label_4, label_5] }
|
|
let_it_be(:group_priority_labels) { [group_label_1, group_label_2] }
|
|
let_it_be(:project_priority_labels) { [label_1, label_2, label_3] }
|
|
|
|
before do
|
|
create(:label_priority, project: project, label: group_label_1, priority: 3)
|
|
create(:label_priority, project: project, label: group_label_2, priority: 1)
|
|
end
|
|
|
|
context '@prioritized_labels' do
|
|
before do
|
|
list_labels
|
|
end
|
|
|
|
it 'does not include labels without priority' do
|
|
list_labels
|
|
|
|
expect(assigns(:prioritized_labels)).not_to include(group_label_3, group_label_4, label_4, label_5)
|
|
end
|
|
|
|
it 'is sorted by priority, then label title' do
|
|
expect(assigns(:prioritized_labels)).to eq [group_label_2, label_1, label_3, group_label_1, label_2]
|
|
end
|
|
end
|
|
|
|
context '@labels' do
|
|
it 'is sorted by label title' do
|
|
list_labels
|
|
|
|
expect(assigns(:labels)).to eq [group_label_3, group_label_4, label_4, label_5]
|
|
end
|
|
|
|
it 'does not include labels with priority' do
|
|
list_labels
|
|
|
|
expect(assigns(:labels)).not_to include(group_label_2, label_1, label_3, group_label_1, label_2)
|
|
end
|
|
|
|
it 'does not include group labels when project does not belong to a group' do
|
|
project.update!(namespace: create(:namespace))
|
|
|
|
list_labels
|
|
|
|
expect(assigns(:labels)).not_to include(group_label_3, group_label_4)
|
|
end
|
|
end
|
|
|
|
context 'with subgroups' do
|
|
let_it_be(:subgroup) { create(:group, parent: group) }
|
|
let_it_be(:subgroup_label_1) { create(:group_label, group: subgroup, title: 'subgroup_label_1') }
|
|
let_it_be(:subgroup_label_2) { create(:group_label, group: subgroup, title: 'subgroup_label_2') }
|
|
|
|
before do
|
|
project.update!(namespace: subgroup)
|
|
subgroup.add_owner(user)
|
|
create(:label_priority, project: project, label: subgroup_label_2, priority: 1)
|
|
end
|
|
|
|
it 'returns ancestor group labels', :aggregate_failures do
|
|
params = { namespace_id: project.namespace.to_param, project_id: project }
|
|
get :index, params: params
|
|
|
|
expect(assigns(:labels)).to match_array([subgroup_label_1] + group_labels + project_labels)
|
|
expect(assigns(:prioritized_labels)).to match_array([subgroup_label_2] + group_priority_labels + project_priority_labels)
|
|
end
|
|
end
|
|
|
|
context 'with views rendered' do
|
|
render_views
|
|
|
|
before do
|
|
list_labels
|
|
end
|
|
|
|
it 'avoids N+1 queries', :use_clean_rails_redis_caching do
|
|
control = ActiveRecord::QueryRecorder.new(skip_cached: false) { list_labels }
|
|
|
|
create_list(:label, 3, project: project)
|
|
create_list(:group_label, 3, group: group)
|
|
|
|
# some n+1 queries still exist
|
|
# calls to get max project authorization access level
|
|
expect { list_labels }.not_to exceed_all_query_limit(control.count).with_threshold(25)
|
|
expect(assigns(:labels).count).to eq(10)
|
|
end
|
|
end
|
|
|
|
def list_labels
|
|
get :index, params: { namespace_id: project.namespace.to_param, project_id: project }
|
|
end
|
|
end
|
|
|
|
describe 'POST #generate' do
|
|
context 'personal project' do
|
|
let_it_be(:personal_project) { create(:project, namespace: user.namespace) }
|
|
|
|
it 'creates labels' do
|
|
post :generate, params: { namespace_id: personal_project.namespace.to_param, project_id: personal_project }
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
|
end
|
|
end
|
|
|
|
context 'project belonging to a group' do
|
|
it 'creates labels' do
|
|
post :generate, params: { namespace_id: project.namespace.to_param, project_id: project }
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST #toggle_subscription' do
|
|
it 'allows user to toggle subscription on project labels' do
|
|
label = create(:label, project: project)
|
|
|
|
toggle_subscription(label)
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
it 'allows user to toggle subscription on group labels' do
|
|
group_label = create(:group_label, group: group)
|
|
|
|
toggle_subscription(group_label)
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
end
|
|
|
|
def toggle_subscription(label)
|
|
post :toggle_subscription, params: { namespace_id: project.namespace.to_param, project_id: project, id: label.to_param }
|
|
end
|
|
end
|
|
|
|
describe 'POST #promote' do
|
|
let_it_be(:promoted_label_name) { "Promoted Label" }
|
|
let_it_be(:label_1) { create(:label, title: promoted_label_name, project: project) }
|
|
|
|
context 'not group reporters' do
|
|
it 'denies access' do
|
|
post :promote, params: { namespace_id: project.namespace.to_param, project_id: project, id: label_1.to_param }
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
context 'group reporter' do
|
|
before do
|
|
group.add_reporter(user)
|
|
end
|
|
|
|
it 'gives access' do
|
|
post :promote, params: { namespace_id: project.namespace.to_param, project_id: project, id: label_1.to_param }
|
|
|
|
expect(response).to redirect_to(namespace_project_labels_path)
|
|
end
|
|
|
|
it 'promotes the label' do
|
|
post :promote, params: { namespace_id: project.namespace.to_param, project_id: project, id: label_1.to_param }
|
|
|
|
expect(Label.where(id: label_1.id)).to be_empty
|
|
expect(GroupLabel.find_by(title: promoted_label_name)).not_to be_nil
|
|
end
|
|
|
|
it 'renders label name without parsing it as HTML' do
|
|
label_1.update!(name: 'CCC<img src=x onerror=alert(document.domain)>')
|
|
|
|
post :promote, params: { namespace_id: project.namespace.to_param, project_id: project, id: label_1.to_param }
|
|
|
|
expect(flash[:notice]).to eq("CCC<img src=x onerror=alert(document.domain)> promoted to <a href=\"#{group_labels_path(project.group)}\"><u>group label</u></a>.")
|
|
end
|
|
|
|
context 'service raising InvalidRecord' do
|
|
before do
|
|
expect_any_instance_of(Labels::PromoteService).to receive(:execute) do |label|
|
|
raise ActiveRecord::RecordInvalid, label_1
|
|
end
|
|
end
|
|
|
|
it 'returns to label list' do
|
|
post :promote, params: { namespace_id: project.namespace.to_param, project_id: project, id: label_1.to_param }
|
|
expect(response).to redirect_to(namespace_project_labels_path)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#ensure_canonical_path' do
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
context 'for a GET request' do
|
|
context 'when requesting the canonical path' do
|
|
context 'non-show path' do
|
|
context 'with exactly matching casing' do
|
|
it 'does not redirect' do
|
|
get :index, params: { namespace_id: project.namespace, project_id: project.to_param }
|
|
|
|
expect(response).not_to have_gitlab_http_status(:moved_permanently)
|
|
end
|
|
end
|
|
|
|
context 'with different casing' do
|
|
it 'redirects to the correct casing' do
|
|
get :index, params: { namespace_id: project.namespace, project_id: project.to_param.upcase }
|
|
|
|
expect(response).to redirect_to(project_labels_path(project))
|
|
expect(controller).not_to set_flash[:notice]
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when requesting a redirected path' do
|
|
let_it_be(:redirect_route) { project.redirect_routes.create!(path: project.full_path + 'old') }
|
|
|
|
it 'redirects to the canonical path' do
|
|
get :index, params: { namespace_id: project.namespace, project_id: project.to_param + 'old' }
|
|
|
|
expect(response).to redirect_to(project_labels_path(project))
|
|
expect(controller).to set_flash[:notice].to(project_moved_message(redirect_route, project))
|
|
end
|
|
|
|
context 'with an AJAX request' do
|
|
it 'redirects to the canonical path but does not set flash message' do
|
|
get :index, params: { namespace_id: project.namespace, project_id: project.to_param + 'old' }, xhr: true
|
|
|
|
expect(response).to redirect_to(project_labels_path(project))
|
|
expect(controller).not_to set_flash[:notice]
|
|
end
|
|
end
|
|
|
|
context 'with JSON format' do
|
|
it 'redirects to the canonical path but does not set flash message' do
|
|
get :index, params: { namespace_id: project.namespace, project_id: project.to_param + 'old' }, format: :json
|
|
|
|
expect(response).to redirect_to(project_labels_path(project, format: :json))
|
|
expect(controller).not_to set_flash[:notice]
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'for a non-GET request' do
|
|
context 'when requesting the canonical path with different casing' do
|
|
it 'does not 404' do
|
|
post :generate, params: { namespace_id: project.namespace, project_id: project }
|
|
|
|
expect(response).not_to have_gitlab_http_status(:not_found)
|
|
end
|
|
|
|
it 'does not redirect to the correct casing' do
|
|
post :generate, params: { namespace_id: project.namespace, project_id: project }
|
|
|
|
expect(response).not_to have_gitlab_http_status(:moved_permanently)
|
|
end
|
|
end
|
|
|
|
context 'when requesting a redirected path' do
|
|
let_it_be(:redirect_route) { project.redirect_routes.create!(path: project.full_path + 'old') }
|
|
|
|
it 'returns not found' do
|
|
post :generate, params: { namespace_id: project.namespace, project_id: project.to_param + 'old' }
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|
|
|
|
def project_moved_message(redirect_route, project)
|
|
"Project '#{redirect_route.path}' was moved to '#{project.full_path}'. Please update any links and bookmarks that may still have the old path."
|
|
end
|
|
end
|