117 lines
3.6 KiB
Ruby
117 lines
3.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Packages::Nuget::ExtractionWorker, type: :worker do
|
|
describe '#perform' do
|
|
let!(:package) { create(:nuget_package) }
|
|
let(:package_file) { package.package_files.first }
|
|
let(:package_file_id) { package_file.id }
|
|
|
|
let_it_be(:package_name) { 'DummyProject.DummyPackage' }
|
|
let_it_be(:package_version) { '1.0.0' }
|
|
|
|
subject { described_class.new.perform(package_file_id) }
|
|
|
|
shared_examples 'handling the metadata error' do |exception_class: ::Packages::Nuget::UpdatePackageFromMetadataService::InvalidMetadataError|
|
|
it 'updates package status to error', :aggregate_failures do
|
|
expect(Gitlab::ErrorTracking).to receive(:log_exception).with(
|
|
instance_of(exception_class),
|
|
project_id: package.project_id
|
|
)
|
|
|
|
subject
|
|
|
|
expect(package.reload).to be_error
|
|
end
|
|
end
|
|
|
|
context 'with valid package file' do
|
|
it 'updates package and package file' do
|
|
expect { subject }
|
|
.to not_change { Packages::Package.count }
|
|
.and not_change { Packages::PackageFile.count }
|
|
end
|
|
|
|
context 'with exisiting package' do
|
|
let!(:existing_package) { create(:nuget_package, project: package.project, name: package_name, version: package_version) }
|
|
|
|
it 'reuses existing package and updates package file' do
|
|
expect { subject }
|
|
.to change { Packages::Package.count }.by(-1)
|
|
.and change { existing_package.reload.package_files.count }.by(1)
|
|
.and not_change { Packages::PackageFile.count }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with invalid package file id' do
|
|
let(:package_file_id) { 5555 }
|
|
|
|
it "doesn't update package and package file" do
|
|
expect { subject }
|
|
.to not_change { package.reload.name }
|
|
.and not_change { package.version }
|
|
.and not_change { package_file.reload.file_name }
|
|
end
|
|
end
|
|
|
|
context 'with package file not containing a nuspec file' do
|
|
before do
|
|
allow_any_instance_of(Zip::File).to receive(:glob).and_return([])
|
|
end
|
|
|
|
it_behaves_like 'handling the metadata error', exception_class: ::Packages::Nuget::MetadataExtractionService::ExtractionError
|
|
end
|
|
|
|
context 'with package with an invalid package name' do
|
|
invalid_names = [
|
|
'',
|
|
'My/package',
|
|
'../../../my_package',
|
|
'%2e%2e%2fmy_package'
|
|
]
|
|
|
|
invalid_names.each do |invalid_name|
|
|
before do
|
|
allow_next_instance_of(::Packages::Nuget::UpdatePackageFromMetadataService) do |service|
|
|
allow(service).to receive(:package_name).and_return(invalid_name)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'handling the metadata error'
|
|
end
|
|
end
|
|
|
|
context 'with package with an invalid package version' do
|
|
invalid_versions = [
|
|
'',
|
|
'555',
|
|
'1.2',
|
|
'1./2.3',
|
|
'../../../../../1.2.3',
|
|
'%2e%2e%2f1.2.3'
|
|
]
|
|
|
|
invalid_versions.each do |invalid_version|
|
|
before do
|
|
allow_next_instance_of(::Packages::Nuget::UpdatePackageFromMetadataService) do |service|
|
|
allow(service).to receive(:package_version).and_return(invalid_version)
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'handling the metadata error'
|
|
end
|
|
end
|
|
|
|
context 'handles a processing an unaccounted for error' do
|
|
before do
|
|
expect(::Packages::Nuget::UpdatePackageFromMetadataService).to receive(:new)
|
|
.and_raise(Zip::Error)
|
|
end
|
|
|
|
it_behaves_like 'handling the metadata error', exception_class: Zip::Error
|
|
end
|
|
end
|
|
end
|