117 lines
4.1 KiB
Ruby
117 lines
4.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe IssuablePolicy, models: true do
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:guest) { create(:user) }
|
|
let_it_be(:reporter) { create(:user) }
|
|
let_it_be(:developer) { create(:user) }
|
|
let_it_be(:project) { create(:project, :public) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
let(:policies) { described_class.new(user, issue) }
|
|
|
|
before do
|
|
project.add_developer(developer)
|
|
project.add_guest(guest)
|
|
project.add_reporter(reporter)
|
|
end
|
|
|
|
def permissions(user, issue)
|
|
described_class.new(user, issue)
|
|
end
|
|
|
|
describe '#rules' do
|
|
context 'when user is author of issuable' do
|
|
let(:merge_request) { create(:merge_request, source_project: project, author: user) }
|
|
let(:policies) { described_class.new(user, merge_request) }
|
|
|
|
it 'allows resolving notes' do
|
|
expect(policies).to be_allowed(:resolve_note)
|
|
end
|
|
|
|
context 'when user is able to read project' do
|
|
it 'enables user to read and update issuables' do
|
|
expect(policies).to be_allowed(:read_issue, :update_issue, :reopen_issue, :read_merge_request, :update_merge_request, :reopen_merge_request)
|
|
end
|
|
end
|
|
|
|
context 'Timeline events' do
|
|
it 'allows non-members to read time line events' do
|
|
expect(permissions(guest, issue)).to be_allowed(:read_incident_management_timeline_event)
|
|
end
|
|
|
|
it 'disallows reporters from managing timeline events' do
|
|
expect(permissions(reporter, issue)).to be_disallowed(:admin_incident_management_timeline_event)
|
|
end
|
|
|
|
it 'allows developers to manage timeline events' do
|
|
expect(permissions(developer, issue)).to be_allowed(:admin_incident_management_timeline_event)
|
|
end
|
|
end
|
|
|
|
context 'when project is private' do
|
|
let(:project) { create(:project, :private) }
|
|
|
|
context 'when user belongs to the projects team' do
|
|
it 'enables user to read and update issuables' do
|
|
project.add_maintainer(user)
|
|
|
|
expect(policies).to be_allowed(:read_issue, :update_issue, :reopen_issue, :read_merge_request, :update_merge_request, :reopen_merge_request)
|
|
end
|
|
end
|
|
|
|
it 'disallows user from reading and updating issuables from that project' do
|
|
expect(policies).to be_disallowed(:read_issue, :update_issue, :reopen_issue, :read_merge_request, :update_merge_request, :reopen_merge_request)
|
|
end
|
|
|
|
context 'Timeline events' do
|
|
it 'disallows non-members from reading timeline events' do
|
|
expect(permissions(user, issue)).to be_disallowed(:read_incident_management_timeline_event)
|
|
end
|
|
|
|
it 'allows guests to read time line events' do
|
|
expect(permissions(guest, issue)).to be_allowed(:read_incident_management_timeline_event)
|
|
end
|
|
|
|
it 'disallows reporters from managing timeline events' do
|
|
expect(permissions(reporter, issue)).to be_disallowed(:admin_incident_management_timeline_event)
|
|
end
|
|
|
|
it 'allows developers to manage timeline events' do
|
|
expect(permissions(developer, issue)).to be_allowed(:admin_incident_management_timeline_event)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when discussion is locked for the issuable' do
|
|
let(:issue) { create(:issue, project: project, discussion_locked: true) }
|
|
|
|
context 'when the user is not a project member' do
|
|
it 'can not create a note nor award emojis' do
|
|
expect(policies).to be_disallowed(:create_note, :award_emoji)
|
|
end
|
|
|
|
it 'does not allow resolving note' do
|
|
expect(policies).to be_disallowed(:resolve_note)
|
|
end
|
|
end
|
|
|
|
context 'when the user is a project member' do
|
|
before do
|
|
project.add_developer(user)
|
|
end
|
|
|
|
it 'can create a note and award emojis' do
|
|
expect(policies).to be_allowed(:create_note, :award_emoji)
|
|
end
|
|
|
|
it 'allows resolving notes' do
|
|
expect(policies).to be_allowed(:resolve_note)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|