debian-mirror-gitlab/spec/lib/api/helpers/packages_helpers_spec.rb
2023-01-12 18:35:48 +00:00

241 lines
6.9 KiB
Ruby

# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::Helpers::PackagesHelpers do
let_it_be(:helper) { Class.new.include(API::Helpers).include(described_class).new }
let_it_be(:project) { create(:project) }
let_it_be(:group) { create(:group) }
let_it_be(:package) { create(:package) }
describe 'authorize_packages_access!' do
subject { helper.authorize_packages_access!(project) }
it 'authorizes packages access' do
expect(helper).to receive(:require_packages_enabled!)
expect(helper).to receive(:authorize_read_package!).with(project)
expect(subject).to eq nil
end
end
describe 'authorize_read_package!' do
using RSpec::Parameterized::TableSyntax
where(:subject, :expected_class) do
ref(:project) | ::Packages::Policies::Project
ref(:group) | ::Packages::Policies::Group
ref(:package) | ::Packages::Package
end
with_them do
it 'calls authorize! with correct subject' do
expect(helper).to receive(:authorize!).with(:read_package, have_attributes(id: subject.id, class: expected_class))
expect(helper.send('authorize_read_package!', subject)).to eq nil
end
end
end
%i[create_package destroy_package].each do |action|
describe "authorize_#{action}!" do
subject { helper.send("authorize_#{action}!", project) }
it 'calls authorize!' do
expect(helper).to receive(:authorize!).with(action, project)
expect(subject).to eq nil
end
end
end
describe 'require_packages_enabled!' do
let(:packages_enabled) { true }
subject { helper.require_packages_enabled! }
before do
allow(::Gitlab.config.packages).to receive(:enabled).and_return(packages_enabled)
end
context 'with packages enabled' do
it "doesn't call not_found!" do
expect(helper).not_to receive(:not_found!)
expect(subject).to eq nil
end
end
context 'with package disabled' do
let(:packages_enabled) { false }
it 'calls not_found!' do
expect(helper).to receive(:not_found!).once
subject
end
end
end
describe '#authorize_workhorse!' do
let_it_be(:headers) { {} }
subject { helper.authorize_workhorse!(subject: project) }
before do
allow(helper).to receive(:headers).and_return(headers)
end
it 'authorizes workhorse' do
expect(helper).to receive(:authorize_upload!).with(project)
expect(helper).to receive(:status).with(200)
expect(helper).to receive(:content_type).with(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
expect(Gitlab::Workhorse).to receive(:verify_api_request!).with(headers)
expect(::Packages::PackageFileUploader).to receive(:workhorse_authorize).with(has_length: true)
expect(subject).to eq nil
end
context 'without length' do
subject { helper.authorize_workhorse!(subject: project, has_length: false) }
it 'authorizes workhorse' do
expect(helper).to receive(:authorize_upload!).with(project)
expect(helper).to receive(:status).with(200)
expect(helper).to receive(:content_type).with(Gitlab::Workhorse::INTERNAL_API_CONTENT_TYPE)
expect(Gitlab::Workhorse).to receive(:verify_api_request!).with(headers)
expect(::Packages::PackageFileUploader).to receive(:workhorse_authorize).with(has_length: false, maximum_size: ::API::Helpers::PackagesHelpers::MAX_PACKAGE_FILE_SIZE)
expect(subject).to eq nil
end
end
end
describe '#authorize_upload!' do
subject { helper.authorize_upload!(project) }
it 'authorizes the upload' do
expect(helper).to receive(:authorize_create_package!).with(project)
expect(helper).to receive(:require_gitlab_workhorse!)
expect(subject).to eq nil
end
end
describe '#user_project' do
before do
allow(helper).to receive(:params).and_return(id: project.id)
end
it 'calls find_project! on default action' do
expect(helper).to receive(:find_project!)
helper.user_project
end
it 'calls find_project! on read_project action' do
expect(helper).to receive(:find_project!)
helper.user_project(action: :read_project)
end
it 'calls user_project_with_read_package on read_package action' do
expect(helper).to receive(:user_project_with_read_package)
helper.user_project(action: :read_package)
end
it 'throws ArgumentError on unexpected action' do
expect { helper.user_project(action: :other_action) }.to raise_error(ArgumentError, 'unexpected action: other_action')
end
end
describe '#user_project_with_read_package' do
before do
helper.clear_memoization(:user_project_with_read_package)
allow(helper).to receive(:params).and_return(id: params_id)
allow(helper).to receive(:route_authentication_setting).and_return({ authenticate_non_public: true })
allow(helper).to receive(:current_user).and_return(user)
allow(helper).to receive(:initial_current_user).and_return(user)
end
subject { helper.user_project_with_read_package }
context 'with non-existing project' do
let_it_be(:params_id) { non_existing_record_id }
context 'with current user' do
let_it_be(:user) { create(:user) }
it 'returns Not Found' do
expect(helper).to receive(:render_api_error!).with('404 Project Not Found', 404)
is_expected.to be_nil
end
end
context 'without current user' do
let_it_be(:user) { nil }
it 'returns Unauthorized' do
expect(helper).to receive(:render_api_error!).with('401 Unauthorized', 401)
is_expected.to be_nil
end
end
end
context 'with existing project' do
let_it_be(:params_id) { project.id }
context 'with current user' do
let_it_be(:user) { create(:user) }
context 'as developer member' do
before do
project.add_developer(user)
end
it 'returns project' do
is_expected.to eq(project)
end
end
context 'as guest member' do
before do
project.add_guest(user)
end
it 'returns Forbidden' do
expect(helper).to receive(:render_api_error!).with('403 Forbidden', 403)
is_expected.to be_nil
end
end
end
context 'without current user' do
let_it_be(:user) { nil }
it 'returns Unauthorized' do
expect(helper).to receive(:render_api_error!).with('401 Unauthorized', 401)
is_expected.to be_nil
end
end
end
context 'if no authorized project scope' do
let_it_be(:params_id) { project.id }
let_it_be(:user) { nil }
it 'returns Forbidden' do
expect(helper).to receive(:authorized_project_scope?).and_return(false)
expect(helper).to receive(:render_api_error!).with('403 Forbidden', 403)
is_expected.to be_nil
end
end
end
end