122 lines
4 KiB
Ruby
122 lines
4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe MergeRequests::ApprovalService do
|
|
describe '#execute' do
|
|
let(:user) { create(:user) }
|
|
let(:merge_request) { create(:merge_request, reviewers: [user]) }
|
|
let(:project) { merge_request.project }
|
|
let!(:todo) { create(:todo, user: user, project: project, target: merge_request) }
|
|
|
|
subject(:service) { described_class.new(project: project, current_user: user) }
|
|
|
|
before do
|
|
project.add_developer(user)
|
|
end
|
|
|
|
context 'with invalid approval' do
|
|
before do
|
|
allow(merge_request.approvals).to receive(:new).and_return(double(save: false))
|
|
end
|
|
|
|
it 'does not reset approvals' do
|
|
expect(merge_request.approvals).not_to receive(:reset)
|
|
|
|
service.execute(merge_request)
|
|
end
|
|
|
|
it 'does not track merge request approve action' do
|
|
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
|
|
.not_to receive(:track_approve_mr_action).with(user: user)
|
|
|
|
service.execute(merge_request)
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestMergeStatusUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it 'does not publish MergeRequests::ApprovedEvent' do
|
|
expect { service.execute(merge_request) }.not_to publish_event(MergeRequests::ApprovedEvent)
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestReviewersUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
end
|
|
|
|
context 'with an already approved MR' do
|
|
before do
|
|
merge_request.approvals.create!(user: user)
|
|
end
|
|
|
|
it 'does not create an approval' do
|
|
expect { service.execute(merge_request) }.not_to change { merge_request.approvals.size }
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestMergeStatusUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestReviewersUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
end
|
|
|
|
context 'with valid approval' do
|
|
it 'resets approvals' do
|
|
expect(merge_request.approvals).to receive(:reset)
|
|
|
|
service.execute(merge_request)
|
|
end
|
|
|
|
it 'tracks merge request approve action' do
|
|
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
|
|
.to receive(:track_approve_mr_action).with(user: user, merge_request: merge_request)
|
|
|
|
service.execute(merge_request)
|
|
end
|
|
|
|
it 'publishes MergeRequests::ApprovedEvent' do
|
|
expect { service.execute(merge_request) }
|
|
.to publish_event(MergeRequests::ApprovedEvent)
|
|
.with(current_user_id: user.id, merge_request_id: merge_request.id)
|
|
end
|
|
|
|
it_behaves_like 'triggers GraphQL subscription mergeRequestMergeStatusUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it_behaves_like 'triggers GraphQL subscription mergeRequestReviewersUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it_behaves_like 'triggers GraphQL subscription mergeRequestApprovalStateUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
end
|
|
|
|
context 'user cannot update the merge request' do
|
|
before do
|
|
project.add_guest(user)
|
|
end
|
|
|
|
it 'does not update approvals' do
|
|
expect { service.execute(merge_request) }.not_to change { merge_request.approvals.size }
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestMergeStatusUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestReviewersUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
|
|
it_behaves_like 'does not trigger GraphQL subscription mergeRequestApprovalStateUpdated' do
|
|
let(:action) { service.execute(merge_request) }
|
|
end
|
|
end
|
|
end
|
|
end
|