453 lines
14 KiB
Ruby
453 lines
14 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Projects::IssuesController < Projects::ApplicationController
|
|
include ToggleSubscriptionAction
|
|
include IssuableActions
|
|
include ToggleAwardEmoji
|
|
include IssuableCollections
|
|
include IssuesCalendar
|
|
include RecordUserLastActivity
|
|
include ::Observability::ContentSecurityPolicy
|
|
|
|
ISSUES_EXCEPT_ACTIONS = %i[index calendar new create bulk_update import_csv export_csv service_desk].freeze
|
|
SET_ISSUABLES_INDEX_ONLY_ACTIONS = %i[index calendar service_desk].freeze
|
|
|
|
prepend_before_action(only: [:index]) { authenticate_sessionless_user!(:rss) }
|
|
prepend_before_action(only: [:calendar]) { authenticate_sessionless_user!(:ics) }
|
|
prepend_before_action :authenticate_user!, only: [:new, :export_csv]
|
|
prepend_before_action :store_uri, only: [:new, :show, :designs]
|
|
|
|
before_action :disable_query_limiting, only: [:create_merge_request, :move, :bulk_update]
|
|
before_action :check_issues_available!
|
|
before_action :issue, unless: ->(c) { ISSUES_EXCEPT_ACTIONS.include?(c.action_name.to_sym) }
|
|
before_action :redirect_if_work_item, unless: ->(c) { ISSUES_EXCEPT_ACTIONS.include?(c.action_name.to_sym) }
|
|
|
|
after_action :log_issue_show, only: :show
|
|
|
|
before_action :set_issuables_index, if: ->(c) {
|
|
SET_ISSUABLES_INDEX_ONLY_ACTIONS.include?(c.action_name.to_sym) && !index_html_request?
|
|
}
|
|
|
|
# Allow write(create) issue
|
|
before_action :authorize_create_issue!, only: [:new, :create]
|
|
|
|
# Allow modify issue
|
|
before_action :authorize_update_issuable!, only: [:edit, :update, :move, :reorder]
|
|
|
|
# Allow create a new branch and empty WIP merge request from current issue
|
|
before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
|
|
|
|
before_action :authorize_import_issues!, only: [:import_csv]
|
|
before_action :authorize_read_code!, only: [:related_branches]
|
|
|
|
before_action do
|
|
push_frontend_feature_flag(:preserve_unchanged_markdown, project)
|
|
push_frontend_feature_flag(:content_editor_on_issues, project)
|
|
end
|
|
|
|
before_action only: [:index, :show] do
|
|
push_force_frontend_feature_flag(:work_items, project&.work_items_feature_flag_enabled?)
|
|
end
|
|
|
|
before_action only: :index do
|
|
push_frontend_feature_flag(:or_issuable_queries, project)
|
|
end
|
|
|
|
before_action only: :show do
|
|
push_frontend_feature_flag(:issue_assignees_widget, project)
|
|
push_frontend_feature_flag(:work_items_mvc, project&.group)
|
|
push_force_frontend_feature_flag(:work_items_mvc, project&.work_items_mvc_feature_flag_enabled?)
|
|
push_force_frontend_feature_flag(:work_items_mvc_2, project&.work_items_mvc_2_feature_flag_enabled?)
|
|
push_frontend_feature_flag(:epic_widget_edit_confirmation, project)
|
|
push_frontend_feature_flag(:use_iid_in_work_items_path, project)
|
|
push_force_frontend_feature_flag(:work_items_create_from_markdown, project&.work_items_create_from_markdown_feature_flag_enabled?)
|
|
end
|
|
|
|
around_action :allow_gitaly_ref_name_caching, only: [:discussions]
|
|
|
|
respond_to :html
|
|
|
|
alias_method :designs, :show
|
|
|
|
feature_category :team_planning, [
|
|
:index, :calendar, :show, :new, :create, :edit, :update,
|
|
:destroy, :move, :reorder, :designs, :toggle_subscription,
|
|
:discussions, :bulk_update, :realtime_changes,
|
|
:toggle_award_emoji, :mark_as_spam, :related_branches,
|
|
:can_create_branch, :create_merge_request
|
|
]
|
|
urgency :low, [
|
|
:index, :calendar, :show, :new, :create, :edit, :update,
|
|
:destroy, :move, :reorder, :designs, :toggle_subscription,
|
|
:discussions, :bulk_update, :realtime_changes,
|
|
:toggle_award_emoji, :mark_as_spam, :related_branches,
|
|
:can_create_branch, :create_merge_request
|
|
]
|
|
|
|
feature_category :service_desk, [:service_desk]
|
|
urgency :low, [:service_desk]
|
|
feature_category :importers, [:import_csv, :export_csv]
|
|
urgency :low, [:import_csv, :export_csv]
|
|
|
|
attr_accessor :vulnerability_id
|
|
|
|
def index
|
|
if index_html_request?
|
|
set_sort_order
|
|
else
|
|
@issues = @issuables
|
|
end
|
|
|
|
respond_to do |format|
|
|
format.html
|
|
format.atom { render layout: 'xml' }
|
|
format.json do
|
|
render json: {
|
|
html: view_to_html_string("projects/issues/_issues"),
|
|
labels: @labels.as_json(methods: :text_color)
|
|
}
|
|
end
|
|
end
|
|
end
|
|
|
|
def calendar
|
|
render_issues_calendar(@issuables)
|
|
end
|
|
|
|
def new
|
|
params[:issue] ||= ActionController::Parameters.new(
|
|
assignee_ids: ""
|
|
)
|
|
build_params = issue_params.merge(
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
|
discussion_to_resolve: params[:discussion_to_resolve],
|
|
confidential: !!Gitlab::Utils.to_boolean(issue_params[:confidential])
|
|
)
|
|
service = ::Issues::BuildService.new(project: project, current_user: current_user, params: build_params)
|
|
|
|
@issue = @noteable = service.execute
|
|
|
|
@add_related_issue = add_related_issue
|
|
|
|
@merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
|
|
|
|
if params[:discussion_to_resolve]
|
|
Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter.track_resolve_thread_in_issue_action(user: current_user)
|
|
@discussion_to_resolve = service.discussions_to_resolve.first
|
|
end
|
|
|
|
respond_with(@issue)
|
|
end
|
|
|
|
def edit
|
|
respond_with(@issue)
|
|
end
|
|
|
|
def create
|
|
create_params = issue_params.merge(
|
|
add_related_issue: add_related_issue,
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
|
discussion_to_resolve: params[:discussion_to_resolve]
|
|
)
|
|
|
|
spam_params = ::Spam::SpamParams.new_from_request(request: request)
|
|
service = ::Issues::CreateService.new(project: project, current_user: current_user, params: create_params, spam_params: spam_params)
|
|
result = service.execute
|
|
|
|
# Only irrecoverable errors such as unauthorized user won't contain an issue in the response
|
|
if result.error? && result[:issue].blank?
|
|
render_by_create_result_error(result) && return
|
|
end
|
|
|
|
@issue = result[:issue]
|
|
|
|
if result.success?
|
|
create_vulnerability_issue_feedback(@issue)
|
|
|
|
if service.discussions_to_resolve.count(&:resolved?) > 0
|
|
flash[:notice] = if service.discussion_to_resolve_id
|
|
_("Resolved 1 discussion.")
|
|
else
|
|
_("Resolved all discussions.")
|
|
end
|
|
end
|
|
|
|
redirect_to project_issue_path(@project, @issue)
|
|
else
|
|
# NOTE: this CAPTCHA support method is indirectly included via IssuableActions
|
|
with_captcha_check_html_format(spammable: spammable) { render :new }
|
|
end
|
|
end
|
|
|
|
def move
|
|
params.require(:move_to_project_id)
|
|
|
|
if params[:move_to_project_id].to_i > 0
|
|
new_project = Project.find(params[:move_to_project_id])
|
|
return render_404 unless issue.can_move?(current_user, new_project)
|
|
|
|
@issue = ::Issues::MoveService.new(project: project, current_user: current_user).execute(issue, new_project)
|
|
end
|
|
|
|
respond_to do |format|
|
|
format.json do
|
|
render_issue_json
|
|
end
|
|
end
|
|
|
|
rescue ActiveRecord::StaleObjectError
|
|
render_conflict_response
|
|
end
|
|
|
|
def reorder
|
|
service = ::Issues::ReorderService.new(project: project, current_user: current_user, params: reorder_params)
|
|
|
|
if service.execute(issue)
|
|
head :ok
|
|
else
|
|
head :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def related_branches
|
|
@related_branches = ::Issues::RelatedBranchesService
|
|
.new(project: project, current_user: current_user)
|
|
.execute(issue)
|
|
.map { |branch| branch.merge(link: branch_link(branch)) }
|
|
|
|
respond_to do |format|
|
|
format.json do
|
|
render json: {
|
|
html: view_to_html_string('projects/issues/_related_branches')
|
|
}
|
|
end
|
|
end
|
|
end
|
|
|
|
def can_create_branch
|
|
can_create = current_user &&
|
|
can?(current_user, :push_code, @project) &&
|
|
@issue.can_be_worked_on?
|
|
|
|
respond_to do |format|
|
|
format.json do
|
|
render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
|
|
end
|
|
end
|
|
end
|
|
|
|
def create_merge_request
|
|
create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
|
|
create_params[:target_project_id] = params[:target_project_id]
|
|
result = ::MergeRequests::CreateFromIssueService.new(project: project, current_user: current_user, mr_params: create_params).execute
|
|
|
|
if result[:status] == :success
|
|
render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
|
|
else
|
|
render json: result[:message], status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def export_csv
|
|
IssuableExportCsvWorker.perform_async(:issue, current_user.id, project.id, finder_options.to_h) # rubocop:disable CodeReuse/Worker
|
|
|
|
index_path = project_issues_path(project)
|
|
message = _('Your CSV export has started. It will be emailed to %{email} when complete.') % { email: current_user.notification_email_or_default }
|
|
redirect_to(index_path, notice: message)
|
|
end
|
|
|
|
def import_csv
|
|
result = Issues::PrepareImportCsvService.new(project, current_user, file: params[:file]).execute
|
|
|
|
if result.success?
|
|
flash[:notice] = result.message
|
|
else
|
|
flash[:alert] = result.message
|
|
end
|
|
|
|
redirect_to project_issues_path(project)
|
|
end
|
|
|
|
def service_desk
|
|
@issues = @issuables
|
|
@users.push(User.support_bot)
|
|
end
|
|
|
|
protected
|
|
|
|
def index_html_request?
|
|
action_name.to_sym == :index && html_request?
|
|
end
|
|
|
|
def sorting_field
|
|
Issue::SORTING_PREFERENCE_FIELD
|
|
end
|
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
|
def issue
|
|
return @issue if defined?(@issue)
|
|
|
|
# The Sortable default scope causes performance issues when used with find_by
|
|
@issuable = @noteable = @issue ||= @project.issues.inc_relations_for_view.iid_in(params[:id]).without_order.take!
|
|
@note = @project.notes.new(noteable: @issuable)
|
|
|
|
return render_404 unless can?(current_user, :read_issue, @issue)
|
|
|
|
@issue
|
|
end
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
|
|
|
def log_issue_show
|
|
return unless current_user && @issue
|
|
|
|
::Gitlab::Search::RecentIssues.new(user: current_user).log_view(@issue)
|
|
end
|
|
|
|
alias_method :subscribable_resource, :issue
|
|
alias_method :issuable, :issue
|
|
alias_method :awardable, :issue
|
|
alias_method :spammable, :issue
|
|
|
|
def spammable_path
|
|
project_issue_path(@project, @issue)
|
|
end
|
|
|
|
def authorize_create_merge_request!
|
|
render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
|
|
end
|
|
|
|
def render_issue_json
|
|
if @issue.valid?
|
|
render json: serializer.represent(@issue)
|
|
else
|
|
render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def issue_params
|
|
all_params = params.require(:issue).permit(
|
|
*issue_params_attributes,
|
|
sentry_issue_attributes: [:sentry_issue_identifier]
|
|
)
|
|
|
|
clean_params(all_params)
|
|
end
|
|
|
|
def issue_params_attributes
|
|
%i[
|
|
title
|
|
assignee_id
|
|
position
|
|
description
|
|
confidential
|
|
milestone_id
|
|
due_date
|
|
state_event
|
|
task_num
|
|
lock_version
|
|
discussion_locked
|
|
issue_type
|
|
] + [{ label_ids: [], assignee_ids: [], update_task: [:index, :checked, :line_number, :line_source] }]
|
|
end
|
|
|
|
def reorder_params
|
|
params.permit(:move_before_id, :move_after_id)
|
|
end
|
|
|
|
def store_uri
|
|
if request.get? && request.format.html?
|
|
store_location_for :user, request.fullpath
|
|
end
|
|
end
|
|
|
|
def serializer
|
|
IssueSerializer.new(current_user: current_user, project: issue.project)
|
|
end
|
|
|
|
def update_service
|
|
spam_params = ::Spam::SpamParams.new_from_request(request: request)
|
|
::Issues::UpdateService.new(project: project, current_user: current_user, params: issue_params, spam_params: spam_params)
|
|
end
|
|
|
|
def finder_type
|
|
IssuesFinder
|
|
end
|
|
|
|
def disable_query_limiting
|
|
# Also see the following issues:
|
|
#
|
|
# 1. https://gitlab.com/gitlab-org/gitlab/-/issues/20815
|
|
# 2. https://gitlab.com/gitlab-org/gitlab/-/issues/20816
|
|
# 3. https://gitlab.com/gitlab-org/gitlab/-/issues/21068
|
|
Gitlab::QueryLimiting.disable!('https://gitlab.com/gitlab-org/gitlab/-/issues/20814')
|
|
end
|
|
|
|
private
|
|
|
|
def render_by_create_result_error(result)
|
|
Gitlab::AppLogger.warn(
|
|
message: 'Cannot create issue',
|
|
errors: result.errors,
|
|
http_status: result.http_status
|
|
)
|
|
error_method_name = "render_#{result.http_status}".to_sym
|
|
|
|
if respond_to?(error_method_name, true)
|
|
send(error_method_name) # rubocop:disable GitlabSecurity/PublicSend
|
|
else
|
|
render_404
|
|
end
|
|
end
|
|
|
|
def clean_params(all_params)
|
|
issue_type = all_params[:issue_type].to_s
|
|
all_params.delete(:issue_type) unless WorkItems::Type.allowed_types_for_issues.include?(issue_type)
|
|
|
|
all_params
|
|
end
|
|
|
|
def finder_options
|
|
options = super
|
|
|
|
options[:issue_types] = Issue::TYPES_FOR_LIST
|
|
|
|
if service_desk?
|
|
options.reject! { |key| key == 'author_username' || key == 'author_id' }
|
|
options[:author_id] = User.support_bot
|
|
end
|
|
|
|
options
|
|
end
|
|
|
|
def branch_link(branch)
|
|
project_compare_path(project, from: project.default_branch, to: branch[:name])
|
|
end
|
|
|
|
def service_desk?
|
|
action_name == 'service_desk'
|
|
end
|
|
|
|
def add_related_issue
|
|
add_related_issue = project.issues.find_by_iid(params[:add_related_issue])
|
|
add_related_issue if Ability.allowed?(current_user, :read_issue, add_related_issue)
|
|
end
|
|
|
|
# Overridden in EE
|
|
def create_vulnerability_issue_feedback(issue); end
|
|
|
|
def redirect_if_work_item
|
|
return unless allowed_work_item?
|
|
|
|
if Feature.enabled?(:use_iid_in_work_items_path, project.group)
|
|
redirect_to project_work_items_path(project, issue.iid, params: request.query_parameters.merge(iid_path: true))
|
|
else
|
|
redirect_to project_work_items_path(project, issue.id, params: request.query_parameters)
|
|
end
|
|
end
|
|
|
|
def allowed_work_item?
|
|
issue.task?
|
|
end
|
|
end
|
|
|
|
Projects::IssuesController.prepend_mod_with('Projects::IssuesController')
|