require 'spec_helper' describe Ci::Runner do describe 'validation' do it { is_expected.to validate_presence_of(:access_level) } it { is_expected.to validate_presence_of(:runner_type) } context 'when runner is not allowed to pick untagged jobs' do context 'when runner does not have tags' do it 'is not valid' do runner = build(:ci_runner, tag_list: [], run_untagged: false) expect(runner).to be_invalid end end context 'when runner has tags' do it 'is valid' do runner = build(:ci_runner, tag_list: ['tag'], run_untagged: false) expect(runner).to be_valid end end end context '#exactly_one_group' do let(:group) { create(:group) } let(:runner) { create(:ci_runner, :group, groups: [group]) } it 'disallows assigning group if already assigned to a group' do runner.groups << build(:group) expect(runner).not_to be_valid expect(runner.errors.full_messages).to include('Runner needs to be assigned to exactly one group') end end context 'runner_type validations' do set(:group) { create(:group) } set(:project) { create(:project) } let(:group_runner) { create(:ci_runner, :group, groups: [group]) } let(:project_runner) { create(:ci_runner, :project, projects: [project]) } let(:instance_runner) { create(:ci_runner, :instance) } it 'disallows assigning group to project_type runner' do project_runner.groups << build(:group) expect(project_runner).not_to be_valid expect(project_runner.errors.full_messages).to include('Runner cannot have groups assigned') end it 'disallows assigning group to instance_type runner' do instance_runner.groups << build(:group) expect(instance_runner).not_to be_valid expect(instance_runner.errors.full_messages).to include('Runner cannot have groups assigned') end it 'disallows assigning project to group_type runner' do group_runner.projects << build(:project) expect(group_runner).not_to be_valid expect(group_runner.errors.full_messages).to include('Runner cannot have projects assigned') end it 'disallows assigning project to instance_type runner' do instance_runner.projects << build(:project) expect(instance_runner).not_to be_valid expect(instance_runner.errors.full_messages).to include('Runner cannot have projects assigned') end it 'should fail to save a group assigned to a project runner even if the runner is already saved' do group_runner expect { create(:group, runners: [project_runner]) } .to raise_error(ActiveRecord::RecordInvalid) end end end describe '#access_level' do context 'when creating new runner and access_level is nil' do let(:runner) do build(:ci_runner, access_level: nil) end it "object is invalid" do expect(runner).not_to be_valid end end context 'when creating new runner and access_level is defined in enum' do let(:runner) do build(:ci_runner, access_level: :not_protected) end it "object is valid" do expect(runner).to be_valid end end context 'when creating new runner and access_level is not defined in enum' do it "raises an error" do expect { build(:ci_runner, access_level: :this_is_not_defined) }.to raise_error(ArgumentError) end end end describe '.instance_type' do let(:group) { create(:group) } let(:project) { create(:project) } let!(:group_runner) { create(:ci_runner, :group, groups: [group]) } let!(:project_runner) { create(:ci_runner, :project, projects: [project]) } let!(:shared_runner) { create(:ci_runner, :instance) } it 'returns only shared runners' do expect(described_class.instance_type).to contain_exactly(shared_runner) end end describe '.belonging_to_project' do it 'returns the specific project runner' do # own specific_project = create(:project) specific_runner = create(:ci_runner, :project, projects: [specific_project]) # other other_project = create(:project) create(:ci_runner, :project, projects: [other_project]) expect(described_class.belonging_to_project(specific_project.id)).to eq [specific_runner] end end describe '.belonging_to_parent_group_of_project' do let(:project) { create(:project, group: group) } let(:group) { create(:group) } let(:runner) { create(:ci_runner, :group, groups: [group]) } let!(:unrelated_group) { create(:group) } let!(:unrelated_project) { create(:project, group: unrelated_group) } let!(:unrelated_runner) { create(:ci_runner, :group, groups: [unrelated_group]) } it 'returns the specific group runner' do expect(described_class.belonging_to_parent_group_of_project(project.id)).to contain_exactly(runner) end context 'with a parent group with a runner', :nested_groups do let(:runner) { create(:ci_runner, :group, groups: [parent_group]) } let(:project) { create(:project, group: group) } let(:group) { create(:group, parent: parent_group) } let(:parent_group) { create(:group) } it 'returns the group runner from the parent group' do expect(described_class.belonging_to_parent_group_of_project(project.id)).to contain_exactly(runner) end end end describe '.owned_or_instance_wide' do it 'returns a globally shared, a project specific and a group specific runner' do # group specific group = create(:group) project = create(:project, group: group) group_runner = create(:ci_runner, :group, groups: [group]) # project specific project_runner = create(:ci_runner, :project, projects: [project]) # globally shared shared_runner = create(:ci_runner, :instance) expect(described_class.owned_or_instance_wide(project.id)).to contain_exactly( group_runner, project_runner, shared_runner ) end end describe '#display_name' do it 'returns the description if it has a value' do runner = build(:ci_runner, description: 'Linux/Ruby-1.9.3-p448') expect(runner.display_name).to eq 'Linux/Ruby-1.9.3-p448' end it 'returns the token if it does not have a description' do runner = create(:ci_runner) expect(runner.display_name).to eq runner.description end it 'returns the token if the description is an empty string' do runner = build(:ci_runner, description: '', token: 'token') expect(runner.display_name).to eq runner.token end end describe '#assign_to' do let(:project) { create(:project) } subject { runner.assign_to(project) } context 'with shared_runner' do let(:runner) { create(:ci_runner, :instance) } it 'transitions shared runner to project runner and assigns project' do expect(subject).to be_truthy expect(runner).to be_project_type expect(runner.projects).to eq([project]) expect(runner.only_for?(project)).to be_truthy end end context 'with group runner' do let(:group) { create(:group) } let(:runner) { create(:ci_runner, :group, groups: [group]) } it 'raises an error' do expect { subject } .to raise_error(ArgumentError, 'Transitioning a group runner to a project runner is not supported') end end end describe '.online' do subject { described_class.online } before do @runner1 = create(:ci_runner, :instance, contacted_at: 1.hour.ago) @runner2 = create(:ci_runner, :instance, contacted_at: 1.second.ago) end it { is_expected.to eq([@runner2])} end describe '#online?' do let(:runner) { create(:ci_runner, :instance) } subject { runner.online? } before do allow_any_instance_of(described_class).to receive(:cached_attribute).and_call_original allow_any_instance_of(described_class).to receive(:cached_attribute) .with(:platform).and_return("darwin") end context 'no cache value' do before do stub_redis_runner_contacted_at(nil) end context 'never contacted' do before do runner.contacted_at = nil end it { is_expected.to be_falsey } end context 'contacted long time ago time' do before do runner.contacted_at = 1.year.ago end it { is_expected.to be_falsey } end context 'contacted 1s ago' do before do runner.contacted_at = 1.second.ago end it { is_expected.to be_truthy } end end context 'with cache value' do context 'contacted long time ago time' do before do runner.contacted_at = 1.year.ago stub_redis_runner_contacted_at(1.year.ago.to_s) end it { is_expected.to be_falsey } end context 'contacted 1s ago' do before do runner.contacted_at = 50.minutes.ago stub_redis_runner_contacted_at(1.second.ago.to_s) end it { is_expected.to be_truthy } end end def stub_redis_runner_contacted_at(value) Gitlab::Redis::SharedState.with do |redis| cache_key = runner.send(:cache_attribute_key) expect(redis).to receive(:get).with(cache_key) .and_return({ contacted_at: value }.to_json).at_least(:once) end end end describe '.offline' do subject { described_class.offline } before do @runner1 = create(:ci_runner, :instance, contacted_at: 1.hour.ago) @runner2 = create(:ci_runner, :instance, contacted_at: 1.second.ago) end it { is_expected.to eq([@runner1])} end describe '#can_pick?' do set(:pipeline) { create(:ci_pipeline) } let(:build) { create(:ci_build, pipeline: pipeline) } let(:runner_project) { build.project } let(:runner) { create(:ci_runner, :project, projects: [runner_project], tag_list: tag_list, run_untagged: run_untagged) } let(:tag_list) { [] } let(:run_untagged) { true } subject { runner.can_pick?(build) } context 'a different runner' do let(:other_project) { create(:project) } let(:other_runner) { create(:ci_runner, :project, projects: [other_project], tag_list: tag_list, run_untagged: run_untagged) } it 'cannot handle builds' do expect(other_runner.can_pick?(build)).to be_falsey end end context 'when runner does not have tags' do it 'can handle builds without tags' do expect(runner.can_pick?(build)).to be_truthy end it 'cannot handle build with tags' do build.tag_list = ['aa'] expect(runner.can_pick?(build)).to be_falsey end end context 'when runner has tags' do let(:tag_list) { %w(bb cc) } shared_examples 'tagged build picker' do it 'can handle build with matching tags' do build.tag_list = ['bb'] expect(runner.can_pick?(build)).to be_truthy end it 'cannot handle build without matching tags' do build.tag_list = ['aa'] expect(runner.can_pick?(build)).to be_falsey end end context 'when runner can pick untagged jobs' do it 'can handle builds without tags' do expect(runner.can_pick?(build)).to be_truthy end it_behaves_like 'tagged build picker' end context 'when runner cannot pick untagged jobs' do let(:run_untagged) { false } it 'cannot handle builds without tags' do expect(runner.can_pick?(build)).to be_falsey end it_behaves_like 'tagged build picker' end end context 'when runner is shared' do let(:runner) { create(:ci_runner, :instance) } it 'can handle builds' do expect(runner.can_pick?(build)).to be_truthy end context 'when runner is locked' do let(:runner) { create(:ci_runner, :instance, locked: true) } it 'can handle builds' do expect(runner.can_pick?(build)).to be_truthy end end end context 'when runner is not shared' do context 'when runner is assigned to a project' do it 'can handle builds' do expect(runner.can_pick?(build)).to be_truthy end end context 'when runner is assigned to another project' do let(:runner_project) { create(:project) } it 'cannot handle builds' do expect(runner.can_pick?(build)).to be_falsey end end context 'when runner is assigned to a group' do let(:group) { create(:group, projects: [build.project]) } let(:runner) { create(:ci_runner, :group, tag_list: tag_list, run_untagged: run_untagged, groups: [group]) } it 'can handle builds' do expect(runner.can_pick?(build)).to be_truthy end end end context 'when access_level of runner is not_protected' do before do runner.not_protected! end context 'when build is protected' do before do build.protected = true end it { is_expected.to be_truthy } end context 'when build is unprotected' do before do build.protected = false end it { is_expected.to be_truthy } end end context 'when access_level of runner is ref_protected' do before do runner.ref_protected! end context 'when build is protected' do before do build.protected = true end it { is_expected.to be_truthy } end context 'when build is unprotected' do before do build.protected = false end it { is_expected.to be_falsey } end end end describe '#status' do let(:runner) { create(:ci_runner, :instance, contacted_at: 1.second.ago) } subject { runner.status } context 'never connected' do before do runner.contacted_at = nil end it { is_expected.to eq(:not_connected) } end context 'contacted 1s ago' do before do runner.contacted_at = 1.second.ago end it { is_expected.to eq(:online) } end context 'contacted long time ago' do before do runner.contacted_at = 1.year.ago end it { is_expected.to eq(:offline) } end context 'inactive' do before do runner.active = false end it { is_expected.to eq(:paused) } end end describe '#tick_runner_queue' do let(:runner) { create(:ci_runner) } it 'returns a new last_update value' do expect(runner.tick_runner_queue).not_to be_empty end end describe '#ensure_runner_queue_value' do let(:runner) { create(:ci_runner) } it 'sets a new last_update value when it is called the first time' do last_update = runner.ensure_runner_queue_value expect_value_in_queues.to eq(last_update) end it 'does not change if it is not expired and called again' do last_update = runner.ensure_runner_queue_value expect(runner.ensure_runner_queue_value).to eq(last_update) expect_value_in_queues.to eq(last_update) end context 'updates runner queue after changing editable value' do let!(:last_update) { runner.ensure_runner_queue_value } before do Ci::UpdateRunnerService.new(runner).update(description: 'new runner') end it 'sets a new last_update value' do expect_value_in_queues.not_to eq(last_update) end end context 'does not update runner value after save' do let!(:last_update) { runner.ensure_runner_queue_value } before do runner.touch end it 'has an old last_update value' do expect_value_in_queues.to eq(last_update) end end def expect_value_in_queues Gitlab::Redis::Queues.with do |redis| runner_queue_key = runner.send(:runner_queue_key) expect(redis.get(runner_queue_key)) end end end describe '#update_cached_info' do let(:runner) { create(:ci_runner, :project) } subject { runner.update_cached_info(architecture: '18-bit') } context 'when database was updated recently' do before do runner.contacted_at = Time.now end it 'updates cache' do expect_redis_update subject end end context 'when database was not updated recently' do before do runner.contacted_at = 2.hours.ago end context 'with invalid runner' do before do runner.projects = [] end it 'still updates redis cache and database' do expect(runner).to be_invalid expect_redis_update does_db_update end end it 'updates redis cache and database' do expect_redis_update does_db_update end end def expect_redis_update Gitlab::Redis::SharedState.with do |redis| redis_key = runner.send(:cache_attribute_key) expect(redis).to receive(:set).with(redis_key, anything, any_args) end end def does_db_update expect { subject }.to change { runner.reload.read_attribute(:contacted_at) } .and change { runner.reload.read_attribute(:architecture) } end end describe '#destroy' do let(:runner) { create(:ci_runner) } context 'when there is a tick in the queue' do let!(:queue_key) { runner.send(:runner_queue_key) } before do runner.tick_runner_queue runner.destroy end it 'cleans up the queue' do Gitlab::Redis::Queues.with do |redis| expect(redis.get(queue_key)).to be_nil end end end end describe '.assignable_for' do let(:project) { create(:project) } let(:group) { create(:group) } let(:another_project) { create(:project) } let!(:unlocked_project_runner) { create(:ci_runner, :project, projects: [project]) } let!(:locked_project_runner) { create(:ci_runner, :project, locked: true, projects: [project]) } let!(:group_runner) { create(:ci_runner, :group, groups: [group]) } let!(:instance_runner) { create(:ci_runner, :instance) } context 'with already assigned project' do subject { described_class.assignable_for(project) } it { is_expected.to be_empty } end context 'with a different project' do subject { described_class.assignable_for(another_project) } it { is_expected.to include(unlocked_project_runner) } it { is_expected.not_to include(group_runner) } it { is_expected.not_to include(locked_project_runner) } it { is_expected.not_to include(instance_runner) } end end describe "belongs_to_one_project?" do it "returns false if there are two projects runner assigned to" do project1 = create(:project) project2 = create(:project) runner = create(:ci_runner, :project, projects: [project1, project2]) expect(runner.belongs_to_one_project?).to be_falsey end it "returns true" do project = create(:project) runner = create(:ci_runner, :project, projects: [project]) expect(runner.belongs_to_one_project?).to be_truthy end end describe '#has_tags?' do context 'when runner has tags' do subject { create(:ci_runner, tag_list: ['tag']) } it { is_expected.to have_tags } end context 'when runner does not have tags' do subject { create(:ci_runner, tag_list: []) } it { is_expected.not_to have_tags } end end describe '.search' do let(:runner) { create(:ci_runner, token: '123abc', description: 'test runner') } it 'returns runners with a matching token' do expect(described_class.search(runner.token)).to eq([runner]) end it 'returns runners with a partially matching token' do expect(described_class.search(runner.token[0..2])).to eq([runner]) end it 'returns runners with a matching token regardless of the casing' do expect(described_class.search(runner.token.upcase)).to eq([runner]) end it 'returns runners with a matching description' do expect(described_class.search(runner.description)).to eq([runner]) end it 'returns runners with a partially matching description' do expect(described_class.search(runner.description[0..2])).to eq([runner]) end it 'returns runners with a matching description regardless of the casing' do expect(described_class.search(runner.description.upcase)).to eq([runner]) end end describe '#assigned_to_group?' do subject { runner.assigned_to_group? } context 'when project runner' do let(:runner) { create(:ci_runner, :project, description: 'Project runner', projects: [project]) } let(:project) { create(:project) } it { is_expected.to be_falsey } end context 'when shared runner' do let(:runner) { create(:ci_runner, :instance, description: 'Shared runner') } it { is_expected.to be_falsey } end context 'when group runner' do let(:group) { create(:group) } let(:runner) { create(:ci_runner, :group, description: 'Group runner', groups: [group]) } it { is_expected.to be_truthy } end end describe '#assigned_to_project?' do subject { runner.assigned_to_project? } context 'when group runner' do let(:runner) { create(:ci_runner, :group, description: 'Group runner', groups: [group]) } let(:group) { create(:group) } it { is_expected.to be_falsey } end context 'when shared runner' do let(:runner) { create(:ci_runner, :instance, description: 'Shared runner') } it { is_expected.to be_falsey } end context 'when project runner' do let(:runner) { create(:ci_runner, :project, description: 'Project runner', projects: [project]) } let(:project) { create(:project) } it { is_expected.to be_truthy } end end describe '#pick_build!' do context 'runner can pick the build' do it 'calls #tick_runner_queue' do ci_build = build(:ci_build) runner = build(:ci_runner) allow(runner).to receive(:can_pick?).with(ci_build).and_return(true) expect(runner).to receive(:tick_runner_queue) runner.pick_build!(ci_build) end end context 'runner cannot pick the build' do it 'does not call #tick_runner_queue' do ci_build = build(:ci_build) runner = build(:ci_runner) allow(runner).to receive(:can_pick?).with(ci_build).and_return(false) expect(runner).not_to receive(:tick_runner_queue) runner.pick_build!(ci_build) end end end describe 'project runner without projects is destroyable' do subject { create(:ci_runner, :project, :without_projects) } it 'does not have projects' do expect(subject.runner_projects).to be_empty end it 'can be destroyed' do subject expect { subject.destroy }.to change { described_class.count }.by(-1) end end describe '.order_by' do it 'supports ordering by the contact date' do runner1 = create(:ci_runner, contacted_at: 1.year.ago) runner2 = create(:ci_runner, contacted_at: 1.month.ago) runners = described_class.order_by('contacted_asc') expect(runners).to eq([runner1, runner2]) end it 'supports ordering by the creation date' do runner1 = create(:ci_runner, created_at: 1.year.ago) runner2 = create(:ci_runner, created_at: 1.month.ago) runners = described_class.order_by('created_asc') expect(runners).to eq([runner2, runner1]) end end end