require 'spec_helper' describe Groups::BoardsController do let(:group) { create(:group) } let(:user) { create(:user) } before do group.add_maintainer(user) sign_in(user) end describe 'GET index' do it 'creates a new board when group does not have one' do expect { list_boards }.to change(group.boards, :count).by(1) end context 'when format is HTML' do it 'renders template' do list_boards expect(response).to render_template :index expect(response.content_type).to eq 'text/html' end it 'redirects to latest visited board' do board = create(:board, group: group) create(:board_group_recent_visit, group: board.group, board: board, user: user) list_boards expect(response).to redirect_to(group_board_path(id: board.id)) end it 'renders template if visited board is not found' do temporary_board = create(:board, group: group) visited = create(:board_group_recent_visit, group: temporary_board.group, board: temporary_board, user: user) temporary_board.delete allow_any_instance_of(Boards::Visits::LatestService).to receive(:execute).and_return(visited) list_boards expect(response).to render_template :index expect(response.content_type).to eq 'text/html' end context 'with unauthorized user' do before do allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true) allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(false) end it 'returns a not found 404 response' do list_boards expect(response).to have_gitlab_http_status(404) expect(response.content_type).to eq 'text/html' end end context 'when user is signed out' do let(:group) { create(:group, :public) } it 'renders template' do sign_out(user) board = create(:board, group: group) create(:board_group_recent_visit, group: board.group, board: board, user: user) list_boards expect(response).to render_template :index expect(response.content_type).to eq 'text/html' end end end context 'when format is JSON' do it 'return an array with one group board' do create(:board, group: group) expect(Boards::Visits::LatestService).not_to receive(:new) list_boards format: :json parsed_response = JSON.parse(response.body) expect(response).to match_response_schema('boards') expect(parsed_response.length).to eq 1 end context 'with unauthorized user' do before do allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true) allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(false) end it 'returns a not found 404 response' do list_boards format: :json expect(response).to have_gitlab_http_status(404) expect(response.content_type).to eq 'application/json' end end end def list_boards(format: :html) get :index, group_id: group, format: format end end describe 'GET show' do let!(:board) { create(:board, group: group) } context 'when format is HTML' do it 'renders template' do expect { read_board board: board }.to change(BoardGroupRecentVisit, :count).by(1) expect(response).to render_template :show expect(response.content_type).to eq 'text/html' end context 'with unauthorized user' do before do allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true) allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(false) end it 'returns a not found 404 response' do read_board board: board expect(response).to have_gitlab_http_status(404) expect(response.content_type).to eq 'text/html' end end context 'when user is signed out' do let(:group) { create(:group, :public) } it 'does not save visit' do sign_out(user) expect { read_board board: board }.to change(BoardGroupRecentVisit, :count).by(0) expect(response).to render_template :show expect(response.content_type).to eq 'text/html' end end end context 'when format is JSON' do it 'returns project board' do expect(Boards::Visits::CreateService).not_to receive(:new) read_board board: board, format: :json expect(response).to match_response_schema('board') end context 'with unauthorized user' do before do allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true) allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(false) end it 'returns a not found 404 response' do read_board board: board, format: :json expect(response).to have_gitlab_http_status(404) expect(response.content_type).to eq 'application/json' end end end context 'when board does not belong to group' do it 'returns a not found 404 response' do another_board = create(:board) read_board board: another_board expect(response).to have_gitlab_http_status(404) end end def read_board(board:, format: :html) get :show, group_id: group, id: board.to_param, format: format end end end