# frozen_string_literal: true require 'spec_helper' RSpec.describe Packages::Package, type: :model do include SortingHelper describe 'relationships' do it { is_expected.to belong_to(:project) } it { is_expected.to have_many(:package_files).dependent(:destroy) } it { is_expected.to have_many(:dependency_links).inverse_of(:package) } it { is_expected.to have_many(:tags).inverse_of(:package) } it { is_expected.to have_one(:conan_metadatum).inverse_of(:package) } it { is_expected.to have_one(:maven_metadatum).inverse_of(:package) } it { is_expected.to have_one(:nuget_metadatum).inverse_of(:package) } end describe '.with_composer_target' do let!(:package1) { create(:composer_package, :with_metadatum, sha: '123') } let!(:package2) { create(:composer_package, :with_metadatum, sha: '123') } let!(:package3) { create(:composer_package, :with_metadatum, sha: '234') } subject { described_class.with_composer_target('123').to_a } it 'selects packages with the specified sha' do expect(subject).to include(package1) expect(subject).to include(package2) expect(subject).not_to include(package3) end end describe '.sort_by_attribute' do let_it_be(:group) { create(:group, :public) } let_it_be(:project) { create(:project, :public, namespace: group, name: 'project A') } let!(:package1) { create(:npm_package, project: project, version: '3.1.0', name: "@#{project.root_namespace.path}/foo1") } let!(:package2) { create(:nuget_package, project: project, version: '2.0.4') } let(:package3) { create(:maven_package, project: project, version: '1.1.1', name: 'zzz') } before do travel_to(1.day.ago) do package3 end end RSpec.shared_examples 'package sorting by attribute' do |order_by| subject { described_class.where(id: packages.map(&:id)).sort_by_attribute("#{order_by}_#{sort}").to_a } context "sorting by #{order_by}" do context 'ascending order' do let(:sort) { 'asc' } it { is_expected.to eq packages } end context 'descending order' do let(:sort) { 'desc' } it { is_expected.to eq packages.reverse } end end end it_behaves_like 'package sorting by attribute', 'name' do let(:packages) { [package1, package2, package3] } end it_behaves_like 'package sorting by attribute', 'created_at' do let(:packages) { [package3, package1, package2] } end it_behaves_like 'package sorting by attribute', 'version' do let(:packages) { [package3, package2, package1] } end it_behaves_like 'package sorting by attribute', 'type' do let(:packages) { [package3, package1, package2] } end it_behaves_like 'package sorting by attribute', 'project_path' do let(:another_project) { create(:project, :public, namespace: group, name: 'project B') } let!(:package4) { create(:npm_package, project: another_project, version: '3.1.0', name: "@#{project.root_namespace.path}/bar") } let(:packages) { [package1, package2, package3, package4] } end end describe 'validations' do subject { create(:package) } it { is_expected.to validate_presence_of(:project) } it { is_expected.to validate_uniqueness_of(:name).scoped_to(:project_id, :version, :package_type) } describe '#name' do it { is_expected.to allow_value("my/domain/com/my-app").for(:name) } it { is_expected.to allow_value("my.app-11.07.2018").for(:name) } it { is_expected.not_to allow_value("my(dom$$$ain)com.my-app").for(:name) } context 'conan package' do subject { create(:conan_package) } let(:fifty_one_characters) {'f_b' * 17} it { is_expected.to allow_value('foo+bar').for(:name) } it { is_expected.to allow_value('foo_bar').for(:name) } it { is_expected.to allow_value('foo.bar').for(:name) } it { is_expected.not_to allow_value(fifty_one_characters).for(:name) } it { is_expected.not_to allow_value('+foobar').for(:name) } it { is_expected.not_to allow_value('.foobar').for(:name) } it { is_expected.not_to allow_value('%foo%bar').for(:name) } end end describe '#version' do RSpec.shared_examples 'validating version to be SemVer compliant for' do |factory_name| context "for #{factory_name}" do subject { create(factory_name) } it { is_expected.to allow_value('1.2.3').for(:version) } it { is_expected.to allow_value('1.2.3-beta').for(:version) } it { is_expected.to allow_value('1.2.3-alpha.3').for(:version) } it { is_expected.not_to allow_value('1').for(:version) } it { is_expected.not_to allow_value('1.2').for(:version) } it { is_expected.not_to allow_value('1./2.3').for(:version) } it { is_expected.not_to allow_value('../../../../../1.2.3').for(:version) } it { is_expected.not_to allow_value('%2e%2e%2f1.2.3').for(:version) } end end context 'conan package' do subject { create(:conan_package) } let(:fifty_one_characters) {'1.2' * 17} it { is_expected.to allow_value('1.2').for(:version) } it { is_expected.to allow_value('1.2.3-beta').for(:version) } it { is_expected.to allow_value('1.2.3-pre1+build2').for(:version) } it { is_expected.not_to allow_value('1').for(:version) } it { is_expected.not_to allow_value(fifty_one_characters).for(:version) } it { is_expected.not_to allow_value('1./2.3').for(:version) } it { is_expected.not_to allow_value('.1.2.3').for(:version) } it { is_expected.not_to allow_value('+1.2.3').for(:version) } it { is_expected.not_to allow_value('%2e%2e%2f1.2.3').for(:version) } end context 'maven package' do subject { create(:maven_package) } it { is_expected.to allow_value('0').for(:version) } it { is_expected.to allow_value('1').for(:version) } it { is_expected.to allow_value('10').for(:version) } it { is_expected.to allow_value('1.0').for(:version) } it { is_expected.to allow_value('1.3.350.v20200505-1744').for(:version) } it { is_expected.to allow_value('1.1-beta-2').for(:version) } it { is_expected.to allow_value('1.2-SNAPSHOT').for(:version) } it { is_expected.to allow_value('12.1.2-2-1').for(:version) } it { is_expected.to allow_value('1.2.3..beta').for(:version) } it { is_expected.to allow_value('1.2.3-beta').for(:version) } it { is_expected.to allow_value('10.2.3-beta').for(:version) } it { is_expected.to allow_value('2.0.0.v200706041905-7C78EK9E_EkMNfNOd2d8qq').for(:version) } it { is_expected.to allow_value('1.2-alpha-1-20050205.060708-1').for(:version) } it { is_expected.to allow_value('703220b4e2cea9592caeb9f3013f6b1e5335c293').for(:version) } it { is_expected.to allow_value('RELEASE').for(:version) } it { is_expected.not_to allow_value('..1.2.3').for(:version) } it { is_expected.not_to allow_value(' 1.2.3').for(:version) } it { is_expected.not_to allow_value("1.2.3 \r\t").for(:version) } it { is_expected.not_to allow_value("\r\t 1.2.3").for(:version) } it { is_expected.not_to allow_value('1.2.3-4/../../').for(:version) } it { is_expected.not_to allow_value('1.2.3-4%2e%2e%').for(:version) } it { is_expected.not_to allow_value('../../../../../1.2.3').for(:version) } it { is_expected.not_to allow_value('%2e%2e%2f1.2.3').for(:version) } end it_behaves_like 'validating version to be SemVer compliant for', :npm_package it_behaves_like 'validating version to be SemVer compliant for', :nuget_package end describe '#package_already_taken' do context 'npm package' do let!(:package) { create(:npm_package) } it 'will not allow a package of the same name' do new_package = build(:npm_package, name: package.name) expect(new_package).not_to be_valid end end context 'maven package' do let!(:package) { create(:maven_package) } it 'will allow a package of the same name' do new_package = build(:maven_package, name: package.name) expect(new_package).to be_valid end end end context "recipe uniqueness for conan packages" do let!(:package) { create('conan_package') } it "will allow a conan package with same project, name, version and package_type" do new_package = build('conan_package', project: package.project, name: package.name, version: package.version) new_package.conan_metadatum.package_channel = 'beta' expect(new_package).to be_valid end it "will not allow a conan package with same recipe (name, version, metadatum.package_channel, metadatum.package_username, and package_type)" do new_package = build('conan_package', project: package.project, name: package.name, version: package.version) expect(new_package).not_to be_valid expect(new_package.errors.to_a).to include("Package recipe already exists") end end Packages::Package.package_types.keys.without('conan').each do |pt| context "project id, name, version and package type uniqueness for package type #{pt}" do let(:package) { create("#{pt}_package") } it "will not allow a #{pt} package with same project, name, version and package_type" do new_package = build("#{pt}_package", project: package.project, name: package.name, version: package.version) expect(new_package).not_to be_valid expect(new_package.errors.to_a).to include("Name has already been taken") end end end end describe '#destroy' do let(:package) { create(:npm_package) } let(:package_file) { package.package_files.first } let(:project_statistics) { ProjectStatistics.for_project_ids(package.project.id).first } it 'affects project statistics' do expect { package.destroy! } .to change { project_statistics.reload.packages_size } .from(package_file.size).to(0) end end describe '.by_name_and_file_name' do let!(:package) { create(:npm_package) } let!(:package_file) { package.package_files.first } subject { described_class } it 'finds a package with correct arguiments' do expect(subject.by_name_and_file_name(package.name, package_file.file_name)).to eq(package) end it 'will raise error if not found' do expect { subject.by_name_and_file_name('foo', 'foo-5.5.5.tgz') }.to raise_error(ActiveRecord::RecordNotFound) end end context 'version scopes' do let!(:package1) { create(:npm_package, version: '1.0.0') } let!(:package2) { create(:npm_package, version: '1.0.1') } let!(:package3) { create(:npm_package, version: '1.0.1') } describe '.last_of_each_version' do subject { described_class.last_of_each_version } it 'includes only latest package per version' do is_expected.to include(package1, package3) is_expected.not_to include(package2) end end describe '.has_version' do subject { described_class.has_version } before do create(:maven_metadatum).package.update!(version: nil) end it 'includes only packages with version attribute' do is_expected.to match_array([package1, package2, package3]) end end describe '.with_version' do subject { described_class.with_version('1.0.1') } it 'includes only packages with specified version' do is_expected.to match_array([package2, package3]) end end describe '.without_version_like' do let(:version_pattern) { '%.0.0%' } subject { described_class.without_version_like(version_pattern) } it 'includes packages without the version pattern' do is_expected.to match_array([package2, package3]) end end end context 'conan scopes' do let!(:package) { create(:conan_package) } describe '.with_conan_channel' do subject { described_class.with_conan_channel('stable') } it 'includes only packages with specified version' do is_expected.to include(package) end end describe '.with_conan_username' do subject do described_class.with_conan_username( Packages::Conan::Metadatum.package_username_from(full_path: package.project.full_path) ) end it 'includes only packages with specified version' do is_expected.to match_array([package]) end end end describe '.without_nuget_temporary_name' do let!(:package1) { create(:nuget_package) } let!(:package2) { create(:nuget_package, name: Packages::Nuget::CreatePackageService::TEMPORARY_PACKAGE_NAME) } subject { described_class.without_nuget_temporary_name } it 'does not include nuget temporary packages' do expect(subject).to eq([package1]) end end describe '.processed' do let!(:package1) { create(:nuget_package) } let!(:package2) { create(:npm_package) } let!(:package3) { create(:nuget_package) } subject { described_class.processed } it { is_expected.to match_array([package1, package2, package3]) } context 'with temporary packages' do let!(:package1) { create(:nuget_package, name: Packages::Nuget::CreatePackageService::TEMPORARY_PACKAGE_NAME) } it { is_expected.to match_array([package2, package3]) } end end describe '.limit_recent' do let!(:package1) { create(:nuget_package) } let!(:package2) { create(:nuget_package) } let!(:package3) { create(:nuget_package) } subject { described_class.limit_recent(2) } it { is_expected.to match_array([package3, package2]) } end context 'with several packages' do let_it_be(:package1) { create(:nuget_package, name: 'FooBar') } let_it_be(:package2) { create(:nuget_package, name: 'foobar') } let_it_be(:package3) { create(:npm_package) } let_it_be(:package4) { create(:npm_package) } describe '.pluck_names' do subject { described_class.pluck_names } it { is_expected.to match_array([package1, package2, package3, package4].map(&:name)) } end describe '.pluck_versions' do subject { described_class.pluck_versions } it { is_expected.to match_array([package1, package2, package3, package4].map(&:version)) } end describe '.with_name_like' do subject { described_class.with_name_like(name_term) } context 'with downcase name' do let(:name_term) { 'foobar' } it { is_expected.to match_array([package1, package2]) } end context 'with prefix wildcard' do let(:name_term) { '%ar' } it { is_expected.to match_array([package1, package2]) } end context 'with suffix wildcard' do let(:name_term) { 'foo%' } it { is_expected.to match_array([package1, package2]) } end context 'with surrounding wildcards' do let(:name_term) { '%ooba%' } it { is_expected.to match_array([package1, package2]) } end end describe '.search_by_name' do let(:query) { 'oba' } subject { described_class.search_by_name(query) } it { is_expected.to match_array([package1, package2]) } end end describe '.select_distinct_name' do let_it_be(:nuget_package) { create(:nuget_package) } let_it_be(:nuget_packages) { create_list(:nuget_package, 3, name: nuget_package.name, project: nuget_package.project) } let_it_be(:maven_package) { create(:maven_package) } let_it_be(:maven_packages) { create_list(:maven_package, 3, name: maven_package.name, project: maven_package.project) } subject { described_class.select_distinct_name } it 'returns only distinct names' do packages = subject expect(packages.size).to eq(2) expect(packages.pluck(:name)).to match_array([nuget_package.name, maven_package.name]) end end describe '#versions' do let_it_be(:project) { create(:project) } let_it_be(:package) { create(:maven_package, project: project) } let_it_be(:package2) { create(:maven_package, project: project) } let_it_be(:package3) { create(:maven_package, project: project, name: 'foo') } it 'returns other package versions of the same package name belonging to the project' do expect(package.versions).to contain_exactly(package2) end it 'does not return different packages' do expect(package.versions).not_to include(package3) end end describe '#pipeline' do let_it_be(:package) { create(:maven_package) } context 'package without pipeline' do it 'returns nil if there is no pipeline' do expect(package.pipeline).to be_nil end end context 'package with pipeline' do let_it_be(:pipeline) { create(:ci_pipeline) } before do package.create_build_info!(pipeline: pipeline) end it 'returns the pipeline' do expect(package.pipeline).to eq(pipeline) end end end describe '#tag_names' do let_it_be(:package) { create(:nuget_package) } subject { package.tag_names } it { is_expected.to eq([]) } context 'with tags' do let(:tags) { %w(tag1 tag2 tag3) } before do tags.each { |t| create(:packages_tag, name: t, package: package) } end it { is_expected.to contain_exactly(*tags) } end end end