From fd28d39ac35ec6123272d20ade21025403b38b78 Mon Sep 17 00:00:00 2001 From: Pirate Praveen Date: Fri, 18 Oct 2019 11:20:19 +0000 Subject: [PATCH 1/2] Update d3 node module 4.13 -> 5.12 --- package.json | 2 +- yarn.lock | 130 +++++++++++++++------------------------------------ 2 files changed, 38 insertions(+), 94 deletions(-) --- a/package.json +++ b/package.json @@ -62,7 +62,7 @@ "core-js": "^3.2.1", "cropper": "^2.3.0", "css-loader": "^1.0.0", - "d3": "^4.13.0", + "d3": "^5.12.0", "d3-array": "^1.2.1", "d3-axis": "^1.0.8", "d3-brush": "^1.0.4", --- a/app/assets/javascripts/vue_shared/components/bar_chart.vue +++ b/app/assets/javascripts/vue_shared/components/bar_chart.vue @@ -124,9 +124,7 @@ }, }, mounted() { - if (!this.allValuesEmpty) { - this.draw(); - } + this.draw(); }, methods: { draw() { @@ -153,7 +151,7 @@ this.yScale = d3.scaleLinear().rangeRound([this.vbHeight, 0]); this.xScale.domain(this.graphData.map(d => d.name)); - this.yScale.domain([0, d3.max(this.graphData.map(d => d.value))]); + this.yScale.domain([0, d3.max(this.graphData.map(d => d.value)) || Infinity]); // Zoom/Panning Function this.zoom = d3