# frozen_string_literal: true require 'spec_helper' RSpec.describe 'Query.work_item(id)', feature_category: :team_planning do include GraphqlHelpers let_it_be(:developer) { create(:user) } let_it_be(:guest) { create(:user) } let_it_be(:project) { create(:project, :private) } let_it_be(:work_item) do create( :work_item, project: project, description: '- List item', start_date: Date.today, due_date: 1.week.from_now, created_at: 1.week.ago, last_edited_at: 1.day.ago, last_edited_by: guest ) end let_it_be(:child_item1) { create(:work_item, :task, project: project) } let_it_be(:child_item2) { create(:work_item, :task, confidential: true, project: project) } let_it_be(:child_link1) { create(:parent_link, work_item_parent: work_item, work_item: child_item1) } let_it_be(:child_link2) { create(:parent_link, work_item_parent: work_item, work_item: child_item2) } let(:current_user) { developer } let(:work_item_data) { graphql_data['workItem'] } let(:work_item_fields) { all_graphql_fields_for('WorkItem', max_depth: 2) } let(:global_id) { work_item.to_gid.to_s } let(:query) do graphql_query_for('workItem', { 'id' => global_id }, work_item_fields) end context 'when the user can read the work item' do before do project.add_developer(developer) project.add_guest(guest) post_graphql(query, current_user: current_user) end it_behaves_like 'a working graphql query' it 'returns all fields' do expect(work_item_data).to include( 'description' => work_item.description, 'id' => work_item.to_gid.to_s, 'iid' => work_item.iid.to_s, 'lockVersion' => work_item.lock_version, 'state' => "OPEN", 'title' => work_item.title, 'confidential' => work_item.confidential, 'workItemType' => hash_including('id' => work_item.work_item_type.to_gid.to_s), 'userPermissions' => { 'readWorkItem' => true, 'updateWorkItem' => true, 'deleteWorkItem' => false, 'adminWorkItem' => true }, 'project' => hash_including('id' => project.to_gid.to_s, 'fullPath' => project.full_path) ) end context 'when querying widgets' do describe 'description widget' do let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetDescription { description descriptionHtml edited lastEditedBy { webPath username } lastEditedAt } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'DESCRIPTION', 'description' => work_item.description, 'descriptionHtml' => ::MarkupHelper.markdown_field(work_item, :description, {}), 'edited' => true, 'lastEditedAt' => work_item.last_edited_at.iso8601, 'lastEditedBy' => { 'webPath' => "/#{guest.full_path}", 'username' => guest.username } ) ) ) end end describe 'hierarchy widget' do let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetHierarchy { parent { id } children { nodes { id } } hasChildren } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'HIERARCHY', 'parent' => nil, 'children' => { 'nodes' => match_array( [ hash_including('id' => child_link1.work_item.to_gid.to_s), hash_including('id' => child_link2.work_item.to_gid.to_s) ]) }, 'hasChildren' => true ) ) ) end it 'avoids N+1 queries' do post_graphql(query, current_user: current_user) # warm up control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do post_graphql(query, current_user: current_user) end create_list(:parent_link, 3, work_item_parent: work_item) expect do post_graphql(query, current_user: current_user) end.not_to exceed_all_query_limit(control_count) end context 'when user is guest' do let(:current_user) { guest } it 'filters out not accessible children or parent' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'HIERARCHY', 'parent' => nil, 'children' => { 'nodes' => match_array( [ hash_including('id' => child_link1.work_item.to_gid.to_s) ]) }, 'hasChildren' => true ) ) ) end end context 'when requesting child item' do let_it_be(:work_item) { create(:work_item, :task, project: project, description: '- List item') } let_it_be(:parent_link) { create(:parent_link, work_item: work_item) } it 'returns parent information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'HIERARCHY', 'parent' => hash_including('id' => parent_link.work_item_parent.to_gid.to_s), 'children' => { 'nodes' => match_array([]) }, 'hasChildren' => false ) ) ) end end context 'when ordered by default by created_at' do let_it_be(:newest_child) { create(:work_item, :task, project: project, created_at: 5.minutes.from_now) } let_it_be(:oldest_child) { create(:work_item, :task, project: project, created_at: 5.minutes.ago) } let_it_be(:newest_link) { create(:parent_link, work_item_parent: work_item, work_item: newest_child) } let_it_be(:oldest_link) { create(:parent_link, work_item_parent: work_item, work_item: oldest_child) } let(:hierarchy_widget) { work_item_data['widgets'].find { |widget| widget['type'] == 'HIERARCHY' } } let(:hierarchy_children) { hierarchy_widget['children']['nodes'] } it 'places the oldest child item to the beginning of the children list' do expect(hierarchy_children.first['id']).to eq(oldest_child.to_gid.to_s) end it 'places the newest child item to the end of the children list' do expect(hierarchy_children.last['id']).to eq(newest_child.to_gid.to_s) end context 'when relative position is set' do let_it_be(:first_child) { create(:work_item, :task, project: project, created_at: 5.minutes.from_now) } let_it_be(:first_link) do create(:parent_link, work_item_parent: work_item, work_item: first_child, relative_position: 1) end it 'places children according to relative_position at the beginning of the children list' do ordered_list = [first_child, oldest_child, child_item1, child_item2, newest_child] expect(hierarchy_children.pluck('id')).to eq(ordered_list.map(&:to_gid).map(&:to_s)) end end end end describe 'assignees widget' do let(:assignees) { create_list(:user, 2) } let(:work_item) { create(:work_item, project: project, assignees: assignees) } let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetAssignees { allowsMultipleAssignees canInviteMembers assignees { nodes { id username } } } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'ASSIGNEES', 'allowsMultipleAssignees' => boolean, 'canInviteMembers' => boolean, 'assignees' => { 'nodes' => match_array( assignees.map { |a| { 'id' => a.to_gid.to_s, 'username' => a.username } } ) } ) ) ) end end describe 'labels widget' do let(:labels) { create_list(:label, 2, project: project) } let(:work_item) { create(:work_item, project: project, labels: labels) } let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetLabels { labels { nodes { id title } } } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'LABELS', 'labels' => { 'nodes' => match_array( labels.map { |a| { 'id' => a.to_gid.to_s, 'title' => a.title } } ) } ) ) ) end end describe 'start and due date widget' do let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetStartAndDueDate { startDate dueDate } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'START_AND_DUE_DATE', 'startDate' => work_item.start_date.to_s, 'dueDate' => work_item.due_date.to_s ) ) ) end end describe 'milestone widget' do let_it_be(:milestone) { create(:milestone, project: project) } let(:work_item) { create(:work_item, project: project, milestone: milestone) } let(:work_item_fields) do <<~GRAPHQL id widgets { type ... on WorkItemWidgetMilestone { milestone { id } } } GRAPHQL end it 'returns widget information' do expect(work_item_data).to include( 'id' => work_item.to_gid.to_s, 'widgets' => include( hash_including( 'type' => 'MILESTONE', 'milestone' => { 'id' => work_item.milestone.to_gid.to_s } ) ) ) end end end context 'when an Issue Global ID is provided' do let(:global_id) { Issue.find(work_item.id).to_gid.to_s } it 'allows an Issue GID as input' do expect(work_item_data).to include('id' => work_item.to_gid.to_s) end end end context 'when the user can not read the work item' do let(:current_user) { create(:user) } before do post_graphql(query) end it 'returns an access error' do expect(work_item_data).to be_nil expect(graphql_errors).to contain_exactly( hash_including('message' => ::Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR) ) end end end