# frozen_string_literal: true require 'spec_helper' RSpec.describe Resolvers::GroupMilestonesResolver do include GraphqlHelpers describe '#resolve' do let_it_be(:current_user) { create(:user) } def resolve_group_milestones(args = {}, context = { current_user: current_user }) resolve(described_class, obj: group, args: args, ctx: context) end let_it_be(:now) { Time.now } let_it_be(:group) { create(:group, :private) } def args(**arguments) satisfy("contain only #{arguments.inspect}") do |passed| expect(passed.compact).to match(arguments) end end before_all do group.add_developer(current_user) end it 'calls MilestonesFinder#execute' do expect_next_instance_of(MilestonesFinder) do |finder| expect(finder).to receive(:execute) end resolve_group_milestones end context 'without parameters' do it 'calls MilestonesFinder to retrieve all milestones' do expect(MilestonesFinder).to receive(:new) .with(args(group_ids: group.id, state: 'all')) .and_call_original resolve_group_milestones end end context 'with parameters' do it 'calls MilestonesFinder with correct parameters' do start_date = now end_date = start_date + 1.hour expect(MilestonesFinder).to receive(:new) .with(args(group_ids: group.id, state: 'closed', start_date: start_date, end_date: end_date)) .and_call_original resolve_group_milestones(start_date: start_date, end_date: end_date, state: 'closed') end it 'understands the timeframe argument' do start_date = now end_date = start_date + 1.hour expect(MilestonesFinder).to receive(:new) .with(args(group_ids: group.id, state: 'closed', start_date: start_date, end_date: end_date)) .and_call_original resolve_group_milestones(timeframe: { start: start_date, end: end_date }, state: 'closed') end end context 'by ids' do it 'calls MilestonesFinder with correct parameters' do milestone = create(:milestone, group: group) expect(MilestonesFinder).to receive(:new) .with(args(ids: [milestone.id.to_s], group_ids: group.id, state: 'all')) .and_call_original resolve_group_milestones(ids: [milestone.to_global_id]) end end context 'by timeframe' do context 'when start_date and end_date are present' do context 'when start date is after end_date' do it 'raises error' do expect do resolve_group_milestones(start_date: now, end_date: now - 2.days) end.to raise_error(Gitlab::Graphql::Errors::ArgumentError, "startDate is after endDate") end end end context 'when only start_date is present' do it 'raises error' do expect do resolve_group_milestones(start_date: now) end.to raise_error(Gitlab::Graphql::Errors::ArgumentError, /Both startDate and endDate/) end end context 'when only end_date is present' do it 'raises error' do expect do resolve_group_milestones(end_date: now) end.to raise_error(Gitlab::Graphql::Errors::ArgumentError, /Both startDate and endDate/) end end end context 'when user cannot read milestones' do it 'raises error' do unauthorized_user = create(:user) expect do resolve_group_milestones({}, { current_user: unauthorized_user }) end.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) end end context 'when including descendant milestones in a public group' do let_it_be(:group) { create(:group, :public) } let(:args) { { include_descendants: true } } it 'finds milestones only in accessible projects and groups' do accessible_group = create(:group, :private, parent: group) accessible_project = create(:project, group: accessible_group) accessible_group.add_developer(current_user) inaccessible_group = create(:group, :private, parent: group) inaccessible_project = create(:project, :private, group: group) milestone1 = create(:milestone, group: group) milestone2 = create(:milestone, group: accessible_group) milestone3 = create(:milestone, project: accessible_project) create(:milestone, group: inaccessible_group) create(:milestone, project: inaccessible_project) expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3]) end end describe 'include_descendants and include_ancestors' do let_it_be(:parent_group) { create(:group, :public) } let_it_be(:group) { create(:group, :public, parent: parent_group) } let_it_be(:accessible_group) { create(:group, :private, parent: group) } let_it_be(:accessible_project) { create(:project, group: accessible_group) } let_it_be(:inaccessible_group) { create(:group, :private, parent: group) } let_it_be(:inaccessible_project) { create(:project, :private, group: group) } let_it_be(:milestone1) { create(:milestone, group: group) } let_it_be(:milestone2) { create(:milestone, group: accessible_group) } let_it_be(:milestone3) { create(:milestone, project: accessible_project) } let_it_be(:milestone4) { create(:milestone, group: inaccessible_group) } let_it_be(:milestone5) { create(:milestone, project: inaccessible_project) } let_it_be(:milestone6) { create(:milestone, group: parent_group) } before do accessible_group.add_developer(current_user) end context 'when including neither ancestor or descendant milestones in a public group' do let(:args) { {} } it 'finds milestones only in accessible projects and groups' do expect(resolve_group_milestones(args)).to match_array([milestone1]) end end context 'when including descendant milestones in a public group' do let(:args) { { include_descendants: true } } it 'finds milestones only in accessible projects and groups' do expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3]) end end context 'when including ancestor milestones in a public group' do let(:args) { { include_ancestors: true } } it 'finds milestones only in accessible projects and groups' do expect(resolve_group_milestones(args)).to match_array([milestone1, milestone6]) end end context 'when including both ancestor or descendant milestones in a public group' do let(:args) { { include_descendants: true, include_ancestors: true } } it 'finds milestones only in accessible projects and groups' do expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3, milestone6]) end end end end end