# frozen_string_literal: true require 'spec_helper' describe Projects::Operations::UpdateService do let_it_be(:user) { create(:user) } let_it_be(:project, refind: true) { create(:project) } let(:result) { subject.execute } subject { described_class.new(project, user, params) } describe '#execute' do context 'metrics dashboard setting' do let(:params) do { metrics_setting_attributes: { external_dashboard_url: 'http://gitlab.com' } } end context 'without existing metrics dashboard setting' do it 'creates a setting' do expect(result[:status]).to eq(:success) expect(project.reload.metrics_setting.external_dashboard_url).to eq( 'http://gitlab.com' ) end end context 'with existing metrics dashboard setting' do before do create(:project_metrics_setting, project: project) end it 'updates the settings' do expect(result[:status]).to eq(:success) expect(project.reload.metrics_setting.external_dashboard_url).to eq( 'http://gitlab.com' ) end context 'with blank external_dashboard_url in params' do let(:params) do { metrics_setting_attributes: { external_dashboard_url: '' } } end it 'destroys the metrics_setting entry in DB' do expect(result[:status]).to eq(:success) expect(project.reload.metrics_setting).to be_nil end end end end context 'error tracking' do context 'with existing error tracking setting' do let(:params) do { error_tracking_setting_attributes: { enabled: false, api_host: 'http://gitlab.com/', token: 'token', project: { slug: 'project', name: 'Project', organization_slug: 'org', organization_name: 'Org' } } } end before do create(:project_error_tracking_setting, project: project) end it 'updates the settings' do expect(result[:status]).to eq(:success) project.reload expect(project.error_tracking_setting).not_to be_enabled expect(project.error_tracking_setting.api_url).to eq( 'http://gitlab.com/api/0/projects/org/project/' ) expect(project.error_tracking_setting.token).to eq('token') expect(project.error_tracking_setting[:project_name]).to eq('Project') expect(project.error_tracking_setting[:organization_name]).to eq('Org') end context 'disable error tracking' do before do params[:error_tracking_setting_attributes][:api_host] = '' params[:error_tracking_setting_attributes][:enabled] = false end it 'can set api_url to nil' do expect(result[:status]).to eq(:success) project.reload expect(project.error_tracking_setting).not_to be_enabled expect(project.error_tracking_setting.api_url).to be_nil expect(project.error_tracking_setting.token).to eq('token') expect(project.error_tracking_setting[:project_name]).to eq('Project') expect(project.error_tracking_setting[:organization_name]).to eq('Org') end end end context 'without an existing error tracking setting' do let(:params) do { error_tracking_setting_attributes: { enabled: true, api_host: 'http://gitlab.com/', token: 'token', project: { slug: 'project', name: 'Project', organization_slug: 'org', organization_name: 'Org' } } } end it 'creates a setting' do expect(result[:status]).to eq(:success) expect(project.error_tracking_setting).to be_enabled expect(project.error_tracking_setting.api_url).to eq( 'http://gitlab.com/api/0/projects/org/project/' ) expect(project.error_tracking_setting.token).to eq('token') expect(project.error_tracking_setting[:project_name]).to eq('Project') expect(project.error_tracking_setting[:organization_name]).to eq('Org') end end context 'partial_update' do let(:params) do { error_tracking_setting_attributes: { enabled: true } } end context 'with setting' do before do create(:project_error_tracking_setting, :disabled, project: project) end it 'service succeeds' do expect(result[:status]).to eq(:success) end it 'updates attributes' do expect { result } .to change { project.reload.error_tracking_setting.enabled } .from(false) .to(true) end it 'only updates enabled attribute' do result expect(project.error_tracking_setting.previous_changes.keys) .to contain_exactly('enabled') end end context 'without setting' do it 'does not create a setting' do expect(result[:status]).to eq(:error) expect(project.reload.error_tracking_setting).to be_nil end end end context 'with masked param token' do let(:params) do { error_tracking_setting_attributes: { enabled: false, token: '*' * 8 } } end before do create(:project_error_tracking_setting, project: project, token: 'token') end it 'does not update token' do expect(result[:status]).to eq(:success) expect(project.error_tracking_setting.token).to eq('token') end end context 'with invalid parameters' do let(:params) { {} } let!(:error_tracking_setting) do create(:project_error_tracking_setting, project: project) end it 'does nothing' do expect(result[:status]).to eq(:success) expect(project.reload.error_tracking_setting) .to eq(error_tracking_setting) end end end context 'with inappropriate params' do let(:params) { { name: '' } } let!(:original_name) { project.name } it 'ignores params' do expect(result[:status]).to eq(:success) expect(project.reload.name).to eq(original_name) end end context 'grafana integration' do let(:params) do { grafana_integration_attributes: { grafana_url: 'http://new.grafana.com', token: 'VerySecureToken=' } } end context 'without existing grafana integration' do it 'creates an integration' do expect(result[:status]).to eq(:success) expected_attrs = params[:grafana_integration_attributes] integration = project.reload.grafana_integration expect(integration.grafana_url).to eq(expected_attrs[:grafana_url]) expect(integration.send(:token)).to eq(expected_attrs[:token]) end end context 'with an existing grafana integration' do before do create(:grafana_integration, project: project) end it 'updates the settings' do expect(result[:status]).to eq(:success) expected_attrs = params[:grafana_integration_attributes] integration = project.reload.grafana_integration expect(integration.grafana_url).to eq(expected_attrs[:grafana_url]) expect(integration.send(:token)).to eq(expected_attrs[:token]) end context 'with all grafana attributes blank in params' do let(:params) do { grafana_integration_attributes: { grafana_url: '', token: '' } } end it 'destroys the metrics_setting entry in DB' do expect(result[:status]).to eq(:success) expect(project.reload.grafana_integration).to be_nil end end end end context 'prometheus integration' do context 'prometheus params were passed into service' do let(:prometheus_service) do build_stubbed(:prometheus_service, project: project, properties: { api_url: "http://example.prometheus.com", manual_configuration: "0" }) end let(:prometheus_params) do { "type" => "PrometheusService", "title" => nil, "active" => true, "properties" => { "api_url" => "http://example.prometheus.com", "manual_configuration" => "0" }, "push_events" => true, "issues_events" => true, "merge_requests_events" => true, "tag_push_events" => true, "note_events" => true, "category" => "monitoring", "default" => false, "wiki_page_events" => true, "pipeline_events" => true, "confidential_issues_events" => true, "commit_events" => true, "job_events" => true, "confidential_note_events" => true, "deployment_events" => false, "description" => nil, "comment_on_event_enabled" => true, "template" => false } end let(:params) do { prometheus_integration_attributes: { api_url: 'http://new.prometheus.com', manual_configuration: '1' } } end it 'uses Project#find_or_initialize_service to include instance defined defaults and pass them to Projects::UpdateService', :aggregate_failures do project_update_service = double(Projects::UpdateService) prometheus_update_params = prometheus_params.merge('properties' => { 'api_url' => 'http://new.prometheus.com', 'manual_configuration' => '1' }) expect(project) .to receive(:find_or_initialize_service) .with('prometheus') .and_return(prometheus_service) expect(Projects::UpdateService) .to receive(:new) .with(project, user, { prometheus_service_attributes: prometheus_update_params }) .and_return(project_update_service) expect(project_update_service).to receive(:execute) subject.execute end end context 'prometheus params were not passed into service' do let(:params) { { something: :else } } it 'does not pass any prometheus params into Projects::UpdateService', :aggregate_failures do project_update_service = double(Projects::UpdateService) expect(project).not_to receive(:find_or_initialize_service) expect(Projects::UpdateService) .to receive(:new) .with(project, user, {}) .and_return(project_update_service) expect(project_update_service).to receive(:execute) subject.execute end end end end end