# frozen_string_literal: true require 'spec_helper' RSpec.describe Projects::ReleasesController do include AccessMatchersForController let!(:project) { create(:project, :repository, :public) } let_it_be(:private_project) { create(:project, :repository, :private) } let_it_be(:developer) { create(:user) } let_it_be(:reporter) { create(:user) } let_it_be(:guest) { create(:user) } let_it_be(:user) { developer } let!(:release_1) { create(:release, project: project, released_at: Time.zone.parse('2018-10-18')) } let!(:release_2) { create(:release, project: project, released_at: Time.zone.parse('2019-10-19')) } before do project.add_developer(developer) project.add_reporter(reporter) project.add_guest(guest) end shared_examples_for 'successful request' do it 'renders a 200' do subject expect(response).to have_gitlab_http_status(:success) end end shared_examples_for 'not found' do it 'renders 404' do subject expect(response).to have_gitlab_http_status(:not_found) end end shared_examples 'common access controls' do it 'renders a 200' do get_index expect(response).to have_gitlab_http_status(:ok) end context 'when the project is private' do let(:project) { private_project } before do sign_in(user) end context 'when user is a developer' do let(:user) { developer } it 'renders a 200 for a logged in developer' do sign_in(user) get_index expect(response).to have_gitlab_http_status(:ok) end end context 'when user is an external user' do let(:user) { create(:user) } it 'renders a 404 when logged in but not in the project' do sign_in(user) get_index expect(response).to have_gitlab_http_status(:not_found) end end end end describe 'GET #index' do context 'as html' do let(:format) { :html } it 'returns a text/html content_type' do get_index expect(response.media_type).to eq 'text/html' end it_behaves_like 'common access controls' context 'when the project is private and the user is not logged in' do let(:project) { private_project } it 'returns a redirect' do get_index expect(response).to have_gitlab_http_status(:redirect) end end end context 'as json' do let(:format) { :json } it 'returns an application/json content_type' do get_index expect(response.media_type).to eq 'application/json' end it "returns the project's releases as JSON, ordered by released_at" do get_index expect(json_response.map { |release| release["id"] }).to eq([release_2.id, release_1.id]) end it_behaves_like 'common access controls' context 'when the project is private and the user is not logged in' do let(:project) { private_project } it 'returns a redirect' do get_index expect(response).to have_gitlab_http_status(:redirect) end end end end describe 'GET #new' do let(:request) do get :new, params: { namespace_id: project.namespace, project_id: project } end it { expect { request }.to be_denied_for(:reporter).of(project) } it { expect { request }.to be_allowed_for(:developer).of(project) } end describe 'GET #edit' do subject do get :edit, params: { namespace_id: project.namespace, project_id: project, tag: tag } end before do sign_in(user) end let(:release) { create(:release, project: project) } let(:tag) { release.tag } it_behaves_like 'successful request' context 'when tag name contains slash' do let(:release) { create(:release, project: project, tag: 'awesome/v1.0') } let(:tag) { release.tag } it_behaves_like 'successful request' it 'is accesible at a URL encoded path' do expect(edit_project_release_path(project, release)) .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%2Fv1.0/edit") end end context 'when release does not exist' do let(:tag) { 'non-existent-tag' } it_behaves_like 'not found' end context 'when user is a reporter' do let(:user) { reporter } it_behaves_like 'not found' end end describe 'GET #show' do subject do get :show, params: { namespace_id: project.namespace, project_id: project, tag: tag } end before do sign_in(user) end let(:release) { create(:release, project: project) } let(:tag) { release.tag } it_behaves_like 'successful request' context 'when tag name contains slash' do let(:release) { create(:release, project: project, tag: 'awesome/v1.0') } let(:tag) { release.tag } it_behaves_like 'successful request' it 'is accesible at a URL encoded path' do expect(project_release_path(project, release)) .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%2Fv1.0") end end context 'when release does not exist' do let(:tag) { 'non-existent-tag' } it_behaves_like 'not found' end context 'when user is a guest' do let(:project) { private_project } let(:user) { guest } it_behaves_like 'successful request' end context 'when user is an external user for the project' do let(:project) { private_project } let(:user) { create(:user) } it 'behaves like not found' do subject expect(response).to have_gitlab_http_status(:not_found) end end end describe 'GET #latest_permalink' do # Uses default order_by=released_at parameter. subject do get :latest_permalink, params: { namespace_id: project.namespace, project_id: project } end before do sign_in(user) end let(:release) { create(:release, project: project) } let(:tag) { release.tag } context 'when user is a guest' do let(:project) { private_project } let(:user) { guest } it 'proceeds with the redirect' do subject expect(response).to have_gitlab_http_status(:redirect) end end context 'when user is an external user for the project' do let(:project) { private_project } let(:user) { create(:user) } it 'behaves like not found' do subject expect(response).to have_gitlab_http_status(:not_found) end end context 'when there are no releases for the project' do let(:project) { create(:project, :repository, :public) } let(:user) { developer } before do project.releases.destroy_all # rubocop: disable Cop/DestroyAll end it 'behaves like not found' do subject expect(response).to have_gitlab_http_status(:not_found) end end context 'multiple releases' do let(:user) { developer } it 'redirects to the latest release' do create(:release, project: project, released_at: 1.day.ago) latest_release = create(:release, project: project, released_at: Time.current) subject expect(response).to redirect_to("#{project_releases_path(project)}/#{latest_release.tag}") end end context 'suffix path redirection' do let(:user) { developer } let(:suffix_path) { 'downloads/zips/helm-hello-world.zip' } let!(:latest_release) { create(:release, project: project, released_at: Time.current) } subject do get :latest_permalink, params: { namespace_id: project.namespace, project_id: project, suffix_path: suffix_path } end it 'redirects to the latest release with suffix path and format' do subject expect(response).to redirect_to( "#{project_releases_path(project)}/#{latest_release.tag}/#{suffix_path}") end context 'suffix path abuse' do let(:suffix_path) { 'downloads/zips/../../../../../../../robots.txt' } it 'raises attack error' do expect do subject end.to raise_error(Gitlab::Utils::PathTraversalAttackError) end end context 'url parameters' do let(:suffix_path) { 'downloads/zips/helm-hello-world.zip' } subject do get :latest_permalink, params: { namespace_id: project.namespace, project_id: project, suffix_path: suffix_path, order_by: 'released_at', param_1: 1, param_2: 2 } end it 'carries over query parameters without order_by parameter in the redirect' do subject expect(response).to redirect_to( "#{project_releases_path(project)}/#{latest_release.tag}/#{suffix_path}?param_1=1¶m_2=2") end end end context 'order_by parameter' do let!(:latest_release) { create(:release, project: project, released_at: Time.current, tag: 'latest') } shared_examples_for 'redirects to latest release ordered by using released_at' do it do expect(Release).to receive(:order_released_desc).and_call_original subject expect(response).to redirect_to("#{project_releases_path(project)}/#{latest_release.tag}") end end before do create(:release, project: project, released_at: 1.day.ago, tag: 'alpha') create(:release, project: project, released_at: 2.days.ago, tag: 'beta') end context 'invalid parameter' do let(:user) { developer } subject do get :latest_permalink, params: { namespace_id: project.namespace, project_id: project, order_by: 'unsupported' } end it_behaves_like 'redirects to latest release ordered by using released_at' end context 'valid parameter' do subject do get :latest_permalink, params: { namespace_id: project.namespace, project_id: project, order_by: 'released_at' } end it_behaves_like 'redirects to latest release ordered by using released_at' end end end # `GET #downloads` is addressed in spec/requests/projects/releases_controller_spec.rb private def get_index get :index, params: { namespace_id: project.namespace, project_id: project, format: format } end end