# frozen_string_literal: true require 'spec_helper' RSpec.describe Releases::GroupReleasesFinder, feature_category: :subgroups do let(:user) { create(:user) } let(:group) { create(:group) } let(:project) { create(:project, :repository, group: group) } let(:params) { {} } let(:args) { {} } let(:repository) { project.repository } let(:v1_0_0) { create(:release, project: project, tag: 'v1.0.0') } let(:v1_1_0) { create(:release, project: project, tag: 'v1.1.0') } let(:v1_1_1) { create(:release, project: project, tag: 'v1.1.1') } before do v1_0_0.update_attribute(:released_at, 2.days.ago) v1_1_0.update_attribute(:released_at, 1.day.ago) v1_1_1.update_attribute(:released_at, 0.5.days.ago) end shared_examples_for 'when the user is not part of the project' do it 'returns no releases' do is_expected.to be_empty end end shared_examples_for 'when the user is not part of the group' do before do allow(Ability).to receive(:allowed?).with(user, :read_release, group).and_return(false) end it 'returns no releases' do is_expected.to be_empty end end shared_examples_for 'preload' do before do allow(Ability).to receive(:allowed?).with(user, :read_release, group).and_return(true) end it 'preloads associations' do expect(Release).to receive(:preloaded).once.and_call_original releases end context 'when preload is false' do let(:args) { { preload: false } } it 'does not preload associations' do expect(Release).not_to receive(:preloaded) releases end end end describe 'when parent is a group' do context 'without subgroups' do let(:project2) { create(:project, :repository, namespace: group) } let!(:v6) { create(:release, project: project2, tag: 'v6') } subject(:releases) { described_class.new(group, user, params).execute(**args) } it_behaves_like 'preload' it_behaves_like 'when the user is not part of the group' context 'when the user is a project guest on one sibling project' do before do project.add_guest(user) end it 'does not return any releases' do expect(releases.size).to eq(0) expect(releases).to eq([]) end end context 'when the user is a guest on the group' do before do group.add_guest(user) v1_0_0.update_attribute(:released_at, 3.days.ago) v6.update_attribute(:released_at, 2.days.ago) v1_1_0.update_attribute(:released_at, 1.day.ago) v1_1_1.update_attribute(:released_at, v1_1_0.released_at) end it 'sorts by release date and id' do expect(releases.size).to eq(4) expect(releases).to eq([v1_1_1, v1_1_0, v6, v1_0_0]) end end end describe 'with subgroups' do subject(:releases) { described_class.new(group, user, params).execute(**args) } context 'with a single-level subgroup' do let(:subgroup) { create(:group, parent: group) } let(:project2) { create(:project, :repository, namespace: subgroup) } let!(:v6) { create(:release, project: project2, tag: 'v6') } it_behaves_like 'when the user is not part of the group' context 'when the user a project guest in the subgroup project' do before do project2.add_guest(user) end it 'does not return any releases' do expect(releases).to match_array([]) end end context 'when the user is a guest on the group' do before do group.add_guest(user) v6.update_attribute(:released_at, 2.days.ago) end it 'returns all releases' do expect(releases).to match_array([v1_1_1, v1_1_0, v1_0_0, v6]) end end end context 'with a multi-level subgroup' do let(:subgroup) { create(:group, parent: group) } let(:subsubgroup) { create(:group, parent: subgroup) } let(:project2) { create(:project, :repository, namespace: subgroup) } let(:project3) { create(:project, :repository, namespace: subsubgroup) } let!(:v6) { create(:release, project: project2, tag: 'v6') } let!(:p3) { create(:release, project: project3, tag: 'p3') } before do v6.update_attribute(:released_at, 2.days.ago) p3.update_attribute(:released_at, 3.days.ago) end it_behaves_like 'when the user is not part of the group' context 'when the user a project guest in the subgroup and subsubgroup project' do before do project2.add_guest(user) project3.add_guest(user) end it 'does not return any releases' do expect(releases).to match_array([]) end end context 'when the user a project guest in the subsubgroup project' do before do project3.add_guest(user) end it 'does not return any releases' do expect(releases).to match_array([]) end end context 'performance testing' do shared_examples 'avoids N+1 queries' do |query_params = {}| context 'with subgroups' do let(:params) { query_params } it 'subgroups avoids N+1 queries' do control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do releases end.count subgroups = create_list(:group, 10, parent: group) projects = create_list(:project, 10, namespace: subgroups[0]) create_list(:release, 10, project: projects[0], author: user) expect do releases end.not_to exceed_all_query_limit(control_count) end end end it_behaves_like 'avoids N+1 queries' end end end end end