From bd56fdbb001509362ed131712fcc0d7f71162b34 Mon Sep 17 00:00:00 2001 From: Pirate Praveen Date: Sun, 18 Nov 2018 11:00:15 +0530 Subject: [PATCH] New upstream version 11.2.8+dfsg --- .gitattributes | 1 + .gitlab-ci.yml | 26 +- .../Database changes.md | 22 +- .../merge_request_templates/Documentation.md | 14 +- .rubocop.yml | 6 +- .rubocop_todo.yml | 6 - CHANGELOG.md | 333 +- CONTRIBUTING.md | 69 +- Dangerfile | 7 + GITALY_SERVER_VERSION | 2 +- GITLAB_SHELL_VERSION | 2 +- GITLAB_WORKHORSE_VERSION | 2 +- Gemfile | 17 +- Gemfile.lock | 61 +- Gemfile.rails5.lock | 69 +- README.md | 6 - Rakefile | 4 +- VERSION | 2 +- app/assets/javascripts/api.js | 12 + app/assets/javascripts/autosave.js | 4 + app/assets/javascripts/awards_handler.js | 55 +- .../javascripts/badges/components/badge.vue | 2 +- .../javascripts/boards/components/board.js | 13 + .../boards/components/board_list.vue | 15 +- .../boards/components/board_new_issue.vue | 3 +- .../boards/components/board_sidebar.js | 10 + .../boards/components/project_select.vue | 4 +- app/assets/javascripts/boards/index.js | 149 +- app/assets/javascripts/boards/models/list.js | 2 + .../javascripts/boards/stores/boards_store.js | 25 +- .../javascripts/clusters/clusters_bundle.js | 8 +- .../clusters/components/application_row.vue | 45 +- .../clusters/components/applications.vue | 6 +- app/assets/javascripts/clusters/constants.js | 15 +- app/assets/javascripts/commons/gitlab_ui.js | 4 + app/assets/javascripts/commons/index.js | 1 + app/assets/javascripts/commons/polyfills.js | 3 + .../polyfills/request_idle_callback.js | 17 + .../javascripts/confirm_danger_modal.js | 5 +- .../javascripts/create_item_dropdown.js | 3 +- .../diffs/components/diff_discussions.vue | 1 + .../diffs/components/diff_file_header.vue | 7 +- .../components/diff_line_gutter_content.vue | 29 +- .../diffs/components/diff_line_note_form.vue | 31 +- .../diffs/components/diff_table_cell.vue | 7 + .../components/inline_diff_comment_row.vue | 11 +- .../components/inline_diff_table_row.vue | 8 +- .../diffs/components/inline_diff_view.vue | 22 +- .../components/parallel_diff_comment_row.vue | 51 +- .../components/parallel_diff_table_row.vue | 14 +- .../diffs/components/parallel_diff_view.vue | 39 +- app/assets/javascripts/diffs/store/getters.js | 49 + app/assets/javascripts/diffs/store/utils.js | 21 + app/assets/javascripts/due_date_select.js | 4 +- .../components/environment_actions.vue | 91 +- .../components/environment_external_url.vue | 51 +- .../components/environment_item.vue | 897 +-- .../components/environment_monitoring.vue | 49 +- .../components/environment_rollback.vue | 96 +- .../components/environment_stop.vue | 114 +- .../environment_terminal_button.vue | 53 +- .../components/environments_app.vue | 4 + .../components/environments_table.vue | 13 +- .../components/stop_environment_modal.vue | 92 + .../folder/environments_folder_view.vue | 8 + .../environments/mixins/environments_mixin.js | 22 +- .../services/environments_service.js | 2 +- app/assets/javascripts/gfm_auto_complete.js | 9 +- app/assets/javascripts/gl_dropdown.js | 592 +- app/assets/javascripts/gpg_badges.js | 31 +- .../groups/components/group_item.vue | 75 +- app/assets/javascripts/groups_select.js | 1 + .../javascripts/helpers/avatar_helper.js | 33 + .../ide/components/activity_bar.vue | 21 +- .../ide/components/branches/item.vue | 60 + .../ide/components/branches/search_list.vue | 111 + .../ide/components/changed_file_icon.vue | 20 +- .../components/commit_sidebar/list_item.vue | 10 +- .../commit_sidebar/stage_button.vue | 2 +- app/assets/javascripts/ide/components/ide.vue | 27 +- .../ide/components/ide_project_header.vue | 37 + .../javascripts/ide/components/ide_review.vue | 13 +- .../ide/components/ide_side_bar.vue | 163 +- .../ide/components/ide_status_bar.vue | 21 +- .../javascripts/ide/components/ide_tree.vue | 42 +- .../ide/components/ide_tree_list.vue | 27 +- .../ide/components/jobs/detail.vue | 3 + .../components/merge_requests/dropdown.vue | 63 - .../ide/components/merge_requests/item.vue | 18 +- .../ide/components/merge_requests/list.vue | 174 +- .../ide/components/nav_dropdown.vue | 59 + .../ide/components/nav_dropdown_button.vue | 54 + .../javascripts/ide/components/nav_form.vue | 40 + .../ide/components/new_dropdown/button.vue | 52 + .../ide/components/new_dropdown/index.vue | 109 +- .../ide/components/new_dropdown/modal.vue | 98 +- .../ide/components/new_dropdown/upload.vue | 136 +- .../ide/components/panes/right.vue | 33 +- .../ide/components/preview/clientside.vue | 186 + .../ide/components/preview/navigator.vue | 147 + .../ide/components/repo_commit_section.vue | 2 +- .../ide/components/repo_editor.vue | 16 +- .../javascripts/ide/components/repo_file.vue | 25 +- .../javascripts/ide/components/repo_tab.vue | 6 +- .../ide/components/shared/tokened_input.vue | 121 + app/assets/javascripts/ide/constants.js | 23 + app/assets/javascripts/ide/ide_router.js | 25 +- app/assets/javascripts/ide/index.js | 8 +- .../javascripts/ide/lib/common/model.js | 2 +- .../javascripts/ide/lib/themes/gl_theme.js | 1 + app/assets/javascripts/ide/services/index.js | 2 +- app/assets/javascripts/ide/stores/actions.js | 47 +- .../javascripts/ide/stores/actions/file.js | 34 +- .../ide/stores/actions/merge_request.js | 14 +- .../javascripts/ide/stores/actions/tree.js | 16 +- app/assets/javascripts/ide/stores/getters.js | 8 +- app/assets/javascripts/ide/stores/index.js | 2 + .../ide/stores/modules/branches/actions.js | 39 + .../ide/stores/modules/branches/index.js | 10 + .../stores/modules/branches/mutation_types.js | 5 + .../ide/stores/modules/branches/mutations.js | 21 + .../ide/stores/modules/branches/state.js | 4 + .../ide/stores/modules/commit/actions.js | 12 +- .../ide/stores/modules/commit/getters.js | 26 +- .../stores/modules/merge_requests/actions.js | 43 +- .../stores/modules/merge_requests/getters.js | 4 - .../stores/modules/merge_requests/index.js | 2 - .../modules/merge_requests/mutations.js | 18 +- .../stores/modules/merge_requests/state.js | 10 +- .../ide/stores/modules/pipelines/actions.js | 2 +- .../javascripts/ide/stores/mutation_types.js | 6 + .../javascripts/ide/stores/mutations.js | 84 +- .../javascripts/ide/stores/mutations/file.js | 46 +- .../javascripts/ide/stores/mutations/tree.js | 11 + app/assets/javascripts/ide/stores/state.js | 6 + app/assets/javascripts/ide/stores/utils.js | 39 +- app/assets/javascripts/ide/utils.js | 17 + app/assets/javascripts/importer_status.js | 17 +- .../issue_show/components/edited.vue | 2 +- app/assets/javascripts/labels_select.js | 16 +- app/assets/javascripts/lazy_loader.js | 36 +- .../javascripts/lib/utils/common_utils.js | 20 + .../javascripts/lib/utils/http_status.js | 27 +- app/assets/javascripts/lib/utils/poll.js | 14 +- .../javascripts/lib/utils/text_utility.js | 14 + .../monitoring/components/dashboard.vue | 1 + .../monitoring/components/graph/flag.vue | 1 + .../notes/components/discussion_counter.vue | 28 +- .../notes/components/note_edited_text.vue | 2 +- .../notes/components/note_form.vue | 2 +- .../notes/components/note_header.vue | 3 + .../notes/components/noteable_discussion.vue | 73 +- app/assets/javascripts/notes/index.js | 2 +- .../javascripts/notes/mixins/autosave.js | 17 +- .../notes/mixins/discussion_navigation.js | 29 + .../javascripts/notes/stores/getters.js | 85 + .../pages/dashboard/todos/index/todos.js | 12 +- .../cohorts/index.js | 0 .../cohorts/usage_ping.js | 0 .../index.js | 0 .../pages/profiles/show/emoji_menu.js | 18 + .../javascripts/pages/profiles/show/index.js | 49 + .../pages/projects/blob/show/index.js | 3 + .../javascripts/pages/projects/new/index.js | 2 - .../components/interval_pattern_input.vue | 14 +- .../pages/projects/pipelines/builds/index.js | 9 +- .../projects/pipelines/failures/index.js | 5 +- .../projects/settings/ci_cd/show/index.js | 15 +- .../components/project_setting_row.vue | 2 +- .../javascripts/pages/projects/show/index.js | 5 +- .../pages/projects/tree/show/index.js | 6 +- .../components/performance_bar_app.vue | 27 - .../javascripts/performance_bar/index.js | 33 +- .../graph/dropdown_job_component.vue | 2 +- .../components/graph/job_component.vue | 2 +- app/assets/javascripts/profile/profile.js | 4 +- .../javascripts/projects/project_new.js | 17 +- .../commit_pipeline_status_component.vue | 162 +- .../components/grouped_test_reports_app.vue | 116 + .../javascripts/reports/components/modal.vue | 73 + .../reports/components/test_issue_body.vue | 44 + app/assets/javascripts/reports/constants.js | 16 + .../javascripts/reports/store/actions.js | 88 + .../javascripts/reports/store/getters.js | 16 + app/assets/javascripts/reports/store/index.js | 15 + .../reports/store/mutation_types.js | 7 + .../javascripts/reports/store/mutations.js | 49 + app/assets/javascripts/reports/store/state.js | 61 + app/assets/javascripts/reports/store/utils.js | 59 + app/assets/javascripts/search_autocomplete.js | 269 +- .../components/assignees/assignees.vue | 2 +- .../components/participants/participants.vue | 2 +- .../time_tracking/comparison_pane.vue | 19 +- .../sidebar/components/todo_toggle/todo.vue | 98 + app/assets/javascripts/terminal/index.js | 10 +- app/assets/javascripts/terminal/terminal.js | 123 +- app/assets/javascripts/users_select.js | 4 +- .../components/mr_widget_header.vue | 7 +- .../mr_widget_options.vue | 6 + .../stores/mr_widget_store.js | 12 +- .../vue_shared/components/bar_chart.vue | 391 ++ .../components/bar_chart_constants.js | 4 + .../components/clipboard_button.vue | 28 +- .../vue_shared/components/code_block.vue | 16 + .../content_viewer/viewers/image_viewer.vue | 3 + .../components/dropdown/dropdown_button.vue | 14 +- .../vue_shared/components/gl_modal.vue | 14 + .../components/header_ci_component.vue | 3 + .../vue_shared/components/help_popover.vue | 53 + .../vue_shared/components/icon.vue | 49 +- .../vue_shared/components/identicon.vue | 26 +- .../vue_shared/components/memory_graph.vue | 2 +- .../vue_shared/components/panel_resizer.vue | 11 +- .../components/project_avatar/default.vue | 47 + .../components/reports/constants.js | 3 + .../components/reports/issue_body.js | 9 + .../components/reports/issue_status_icon.vue | 58 + .../components/reports/issues_list.vue | 85 + .../components/reports/modal_open_name.vue | 33 + .../components/reports/report_issues.vue | 59 + .../components/reports/report_link.vue | 29 + .../components/reports/report_section.vue | 181 + .../components/reports/summary_row.vue | 71 + .../components/sidebar/toggle_sidebar.vue | 7 + .../components/stacked_progress_bar.vue | 3 +- .../vue_shared/components/svg_gradient.vue | 37 + .../user_avatar/user_avatar_image.vue | 5 +- .../stylesheets/bootstrap_migration.scss | 12 +- app/assets/stylesheets/framework/avatar.scss | 17 +- app/assets/stylesheets/framework/blocks.scss | 15 + app/assets/stylesheets/framework/buttons.scss | 4 + app/assets/stylesheets/framework/common.scss | 13 +- .../framework/contextual_sidebar.scss | 5 + .../stylesheets/framework/dropdowns.scss | 3 +- app/assets/stylesheets/framework/filters.scss | 5 +- app/assets/stylesheets/framework/forms.scss | 4 +- app/assets/stylesheets/framework/gfm.scss | 8 +- .../stylesheets/framework/gitlab_theme.scss | 32 - app/assets/stylesheets/framework/header.scss | 3 - .../stylesheets/framework/highlight.scss | 8 +- app/assets/stylesheets/framework/images.scss | 2 +- app/assets/stylesheets/framework/jquery.scss | 2 +- app/assets/stylesheets/framework/lists.scss | 4 +- app/assets/stylesheets/framework/mixins.scss | 41 +- app/assets/stylesheets/framework/panels.scss | 1 - app/assets/stylesheets/framework/sidebar.scss | 12 +- .../framework/stacked_progress_bar.scss | 2 +- .../stylesheets/framework/typography.scss | 14 +- .../stylesheets/framework/variables.scss | 38 +- .../mailers/highlighted_diff_email.scss | 4 +- .../repo.scss => page_bundles/ide.scss} | 301 +- app/assets/stylesheets/pages/boards.scss | 4 +- app/assets/stylesheets/pages/builds.scss | 22 +- app/assets/stylesheets/pages/clusters.scss | 48 +- app/assets/stylesheets/pages/commits.scss | 42 +- .../stylesheets/pages/cycle_analytics.scss | 2 +- app/assets/stylesheets/pages/detail_page.scss | 2 +- app/assets/stylesheets/pages/diff.scss | 7 +- app/assets/stylesheets/pages/editor.scss | 2 +- .../stylesheets/pages/environments.scss | 46 +- app/assets/stylesheets/pages/graph.scss | 58 + app/assets/stylesheets/pages/groups.scss | 55 +- app/assets/stylesheets/pages/issuable.scss | 39 +- app/assets/stylesheets/pages/issues.scss | 2 +- .../pages/issues/issue_count_badge.scss | 26 +- app/assets/stylesheets/pages/labels.scss | 78 + app/assets/stylesheets/pages/login.scss | 2 +- .../stylesheets/pages/merge_conflicts.scss | 210 +- .../stylesheets/pages/merge_requests.scss | 44 +- app/assets/stylesheets/pages/note_form.scss | 2 +- app/assets/stylesheets/pages/notes.scss | 5 +- app/assets/stylesheets/pages/profile.scss | 20 + app/assets/stylesheets/pages/projects.scss | 38 +- app/assets/stylesheets/pages/reports.scss | 155 + app/assets/stylesheets/pages/search.scss | 72 +- .../stylesheets/pages/settings_ci_cd.scss | 5 - app/assets/stylesheets/pages/todos.scss | 16 + app/assets/stylesheets/pages/tree.scss | 18 - app/assets/stylesheets/snippets.scss | 20 +- ...ersational_development_index_controller.rb | 5 - .../admin/deploy_keys_controller.rb | 4 +- app/controllers/admin/groups_controller.rb | 2 +- app/controllers/admin/hooks_controller.rb | 4 +- .../admin/identities_controller.rb | 2 +- .../admin/impersonations_controller.rb | 2 +- app/controllers/admin/jobs_controller.rb | 4 +- .../admin/runner_projects_controller.rb | 2 +- app/controllers/admin/runners_controller.rb | 2 +- app/controllers/admin/services_controller.rb | 6 +- app/controllers/admin/users_controller.rb | 2 +- app/controllers/application_controller.rb | 68 +- app/controllers/boards/issues_controller.rb | 17 +- .../concerns/authenticates_with_two_factor.rb | 4 +- app/controllers/concerns/issuable_actions.rb | 2 +- app/controllers/concerns/lfs_request.rb | 21 +- .../concerns/members_presentation.rb | 8 + .../concerns/membership_actions.rb | 2 + app/controllers/concerns/notes_actions.rb | 4 +- app/controllers/concerns/renders_notes.rb | 5 + app/controllers/concerns/todos_actions.rb | 12 + .../dashboard/milestones_controller.rb | 13 +- app/controllers/dashboard/todos_controller.rb | 2 +- app/controllers/groups/avatars_controller.rb | 2 +- .../groups/group_members_controller.rb | 2 +- app/controllers/groups/runners_controller.rb | 2 +- .../import/bitbucket_server_controller.rb | 131 + app/controllers/import/gitlab_controller.rb | 5 +- app/controllers/import/manifest_controller.rb | 93 + .../application_controller.rb | 10 + .../cohorts_controller.rb | 4 +- ...ersational_development_index_controller.rb | 7 + app/controllers/jwt_controller.rb | 22 +- .../notification_settings_controller.rb | 4 +- .../profiles/active_sessions_controller.rb | 2 +- .../profiles/avatars_controller.rb | 2 +- .../profiles/chat_names_controller.rb | 2 +- app/controllers/profiles/emails_controller.rb | 2 +- .../profiles/gpg_keys_controller.rb | 4 +- app/controllers/profiles/keys_controller.rb | 2 +- .../profiles/two_factor_auths_controller.rb | 2 +- app/controllers/profiles_controller.rb | 4 +- .../projects/application_controller.rb | 2 +- .../projects/avatars_controller.rb | 2 +- .../projects/branches_controller.rb | 2 +- .../projects/clusters_controller.rb | 2 +- app/controllers/projects/commit_controller.rb | 9 +- .../projects/commits_controller.rb | 10 +- .../projects/deploy_keys_controller.rb | 2 +- .../projects/environments_controller.rb | 8 +- .../projects/git_http_client_controller.rb | 4 +- .../projects/group_links_controller.rb | 4 +- app/controllers/projects/hooks_controller.rb | 4 +- app/controllers/projects/issues_controller.rb | 2 +- app/controllers/projects/labels_controller.rb | 9 +- .../projects/lfs_api_controller.rb | 9 +- .../projects/lfs_storage_controller.rb | 2 +- .../merge_requests/application_controller.rb | 2 +- .../projects/merge_requests_controller.rb | 21 +- .../projects/milestones_controller.rb | 2 +- .../projects/mirrors_controller.rb | 4 +- app/controllers/projects/notes_controller.rb | 3 +- .../projects/pipeline_schedules_controller.rb | 2 +- .../projects/pipelines_controller.rb | 11 +- app/controllers/projects/raw_controller.rb | 3 +- .../projects/releases_controller.rb | 2 +- .../projects/repositories_controller.rb | 2 +- .../projects/runner_projects_controller.rb | 2 +- .../projects/runners_controller.rb | 8 +- .../projects/services_controller.rb | 2 +- .../projects/snippets_controller.rb | 4 +- app/controllers/projects/tags_controller.rb | 2 +- .../projects/templates_controller.rb | 2 +- app/controllers/projects/todos_controller.rb | 14 +- .../projects/triggers_controller.rb | 10 +- app/controllers/projects/wikis_controller.rb | 54 +- app/controllers/projects_controller.rb | 6 +- app/controllers/sessions_controller.rb | 18 +- .../sherlock/transactions_controller.rb | 2 +- app/controllers/snippets/notes_controller.rb | 2 +- app/controllers/snippets_controller.rb | 4 +- app/controllers/users_controller.rb | 6 + app/finders/admin/projects_finder.rb | 4 +- app/finders/groups_finder.rb | 16 + app/finders/issuable_finder.rb | 2 +- app/finders/labels_finder.rb | 11 + app/finders/personal_access_tokens_finder.rb | 2 +- app/finders/personal_projects_finder.rb | 23 +- app/finders/projects_finder.rb | 20 +- app/finders/todos_finder.rb | 43 +- app/finders/user_recent_events_finder.rb | 3 + app/graphql/gitlab_schema.rb | 2 +- app/graphql/mutations/base_mutation.rb | 13 + .../concerns/mutations/resolves_project.rb | 13 + app/graphql/mutations/merge_requests/base.rb | 32 + .../mutations/merge_requests/set_wip.rb | 35 + app/graphql/types/mutation_type.rb | 6 +- app/helpers/application_settings_helper.rb | 26 +- app/helpers/auth_helper.rb | 2 +- app/helpers/avatars_helper.rb | 16 +- app/helpers/blob_helper.rb | 31 +- app/helpers/button_helper.rb | 2 +- app/helpers/ci_status_helper.rb | 13 +- app/helpers/commits_helper.rb | 9 +- app/helpers/environments_helper.rb | 19 + app/helpers/icons_helper.rb | 15 + app/helpers/issuables_helper.rb | 19 + app/helpers/milestones_helper.rb | 8 + app/helpers/namespaces_helper.rb | 45 +- app/helpers/pipeline_schedules_helper.rb | 2 +- app/helpers/projects_helper.rb | 18 +- app/helpers/repository_languages_helper.rb | 16 + app/helpers/search_helper.rb | 26 +- app/helpers/snippets_helper.rb | 2 +- app/helpers/time_helper.rb | 8 +- app/helpers/todos_helper.rb | 10 +- app/helpers/users_helper.rb | 26 +- app/helpers/visibility_level_helper.rb | 5 +- app/helpers/workhorse_helper.rb | 4 +- app/mailers/notify.rb | 4 +- app/models/ability.rb | 2 + app/models/abuse_report.rb | 2 + app/models/active_session.rb | 2 + app/models/appearance.rb | 2 + app/models/application_setting.rb | 45 +- app/models/application_setting/term.rb | 2 + app/models/audit_event.rb | 2 + app/models/award_emoji.rb | 2 + app/models/badge.rb | 2 + app/models/badges/group_badge.rb | 2 + app/models/badges/project_badge.rb | 2 + app/models/blob.rb | 2 + app/models/blob_viewer/auxiliary.rb | 2 + app/models/blob_viewer/balsamiq.rb | 2 + app/models/blob_viewer/base.rb | 2 + app/models/blob_viewer/binary_stl.rb | 2 + app/models/blob_viewer/cartfile.rb | 2 + app/models/blob_viewer/changelog.rb | 2 + app/models/blob_viewer/client_side.rb | 2 + app/models/blob_viewer/composer_json.rb | 2 + app/models/blob_viewer/contributing.rb | 2 + app/models/blob_viewer/dependency_manager.rb | 2 + app/models/blob_viewer/download.rb | 2 + app/models/blob_viewer/empty.rb | 2 + app/models/blob_viewer/gemfile.rb | 2 + app/models/blob_viewer/gemspec.rb | 2 + app/models/blob_viewer/gitlab_ci_yml.rb | 2 + app/models/blob_viewer/godeps_json.rb | 2 + app/models/blob_viewer/image.rb | 2 + app/models/blob_viewer/license.rb | 2 + app/models/blob_viewer/markup.rb | 2 + app/models/blob_viewer/notebook.rb | 2 + app/models/blob_viewer/package_json.rb | 2 + app/models/blob_viewer/pdf.rb | 2 + app/models/blob_viewer/podfile.rb | 2 + app/models/blob_viewer/podspec.rb | 2 + app/models/blob_viewer/podspec_json.rb | 2 + app/models/blob_viewer/readme.rb | 2 + app/models/blob_viewer/requirements_txt.rb | 2 + app/models/blob_viewer/rich.rb | 2 + app/models/blob_viewer/route_map.rb | 2 + app/models/blob_viewer/server_side.rb | 2 + app/models/blob_viewer/simple.rb | 2 + app/models/blob_viewer/sketch.rb | 2 + app/models/blob_viewer/static.rb | 2 + app/models/blob_viewer/svg.rb | 2 + app/models/blob_viewer/text.rb | 2 + app/models/blob_viewer/text_stl.rb | 2 + app/models/blob_viewer/video.rb | 2 + app/models/blob_viewer/yarn_lock.rb | 2 + app/models/board.rb | 2 + app/models/broadcast_message.rb | 2 + app/models/chat_name.rb | 2 + app/models/chat_team.rb | 2 + app/models/ci/artifact_blob.rb | 2 + app/models/ci/build.rb | 89 +- app/models/ci/build_metadata.rb | 2 + app/models/ci/build_runner_session.rb | 4 +- app/models/ci/build_trace_chunk.rb | 2 + app/models/ci/build_trace_chunks/database.rb | 2 + app/models/ci/build_trace_chunks/fog.rb | 2 + app/models/ci/build_trace_chunks/redis.rb | 2 + app/models/ci/build_trace_section.rb | 2 + app/models/ci/build_trace_section_name.rb | 2 + app/models/ci/group.rb | 2 + app/models/ci/group_variable.rb | 2 + app/models/ci/job_artifact.rb | 49 +- app/models/ci/legacy_stage.rb | 2 + app/models/ci/pipeline.rb | 14 + app/models/ci/pipeline_schedule.rb | 2 + app/models/ci/pipeline_schedule_variable.rb | 2 + app/models/ci/pipeline_variable.rb | 2 + app/models/ci/runner.rb | 2 + app/models/ci/runner_namespace.rb | 2 + app/models/ci/runner_project.rb | 2 + app/models/ci/stage.rb | 2 + app/models/ci/trigger.rb | 2 + app/models/ci/trigger_request.rb | 2 + app/models/ci/variable.rb | 2 + app/models/clusters/applications/helm.rb | 51 +- app/models/clusters/applications/ingress.rb | 12 +- app/models/clusters/applications/jupyter.rb | 10 +- .../clusters/applications/prometheus.rb | 17 +- app/models/clusters/applications/runner.rb | 10 +- app/models/clusters/cluster.rb | 2 + .../clusters/concerns/application_core.rb | 2 + .../clusters/concerns/application_data.rb | 28 + .../clusters/concerns/application_status.rb | 2 + .../clusters/concerns/application_version.rb | 17 + app/models/clusters/platforms/kubernetes.rb | 2 + app/models/clusters/project.rb | 2 + app/models/clusters/providers/gcp.rb | 2 + app/models/commit.rb | 10 +- app/models/commit_range.rb | 2 + app/models/commit_status.rb | 5 +- app/models/compare.rb | 2 + app/models/concerns/atomic_internal_id.rb | 21 +- app/models/concerns/avatarable.rb | 7 +- app/models/concerns/issuable.rb | 11 +- app/models/concerns/label_eventable.rb | 16 + app/models/concerns/prometheus_adapter.rb | 15 +- app/models/concerns/protected_ref.rb | 2 +- app/models/concerns/protected_ref_access.rb | 12 +- app/models/concerns/reactive_caching.rb | 40 +- app/models/concerns/redactable.rb | 33 + app/models/concerns/routable.rb | 44 +- .../select_for_project_authorization.rb | 7 +- app/models/concerns/sortable.rb | 1 + .../concerns/storage/legacy_namespace.rb | 13 +- app/models/concerns/token_authenticatable.rb | 59 +- .../token_authenticatable_strategies/base.rb | 69 + .../digest.rb | 50 + .../insecure.rb | 23 + app/models/container_repository.rb | 2 + app/models/cycle_analytics.rb | 2 + app/models/dashboard_group_milestone.rb | 36 + app/models/dashboard_milestone.rb | 2 + app/models/deploy_key.rb | 2 + app/models/deploy_keys_project.rb | 2 + app/models/deploy_token.rb | 11 +- app/models/deployment.rb | 6 +- app/models/diff_discussion.rb | 2 + app/models/diff_note.rb | 2 + app/models/directly_addressed_user.rb | 2 + app/models/discussion.rb | 2 + app/models/discussion_note.rb | 2 + app/models/email.rb | 6 + app/models/environment.rb | 6 +- app/models/epic.rb | 2 + app/models/event.rb | 2 + app/models/event_collection.rb | 2 + app/models/external_issue.rb | 2 + app/models/fork_network.rb | 2 + app/models/fork_network_member.rb | 2 + app/models/forked_project_link.rb | 2 + app/models/generic_commit_status.rb | 2 + app/models/global_label.rb | 2 + app/models/global_milestone.rb | 2 + app/models/gpg_key.rb | 2 + app/models/gpg_key_subkey.rb | 2 + app/models/gpg_signature.rb | 2 + app/models/group.rb | 18 +- app/models/group_custom_attribute.rb | 2 + app/models/group_label.rb | 2 + app/models/group_milestone.rb | 2 + app/models/guest.rb | 2 + app/models/identity.rb | 2 + app/models/import_export_upload.rb | 3 + app/models/individual_note_discussion.rb | 2 + app/models/instance_configuration.rb | 2 + app/models/internal_id.rb | 38 +- app/models/issue.rb | 7 +- app/models/issue_assignee.rb | 2 + app/models/issue_collection.rb | 2 + app/models/key.rb | 2 + app/models/label.rb | 14 + app/models/label_link.rb | 2 + app/models/label_priority.rb | 2 + app/models/legacy_diff_discussion.rb | 2 + app/models/legacy_diff_note.rb | 2 + app/models/lfs_file_lock.rb | 2 + app/models/lfs_object.rb | 2 + app/models/lfs_objects_project.rb | 2 + app/models/list.rb | 8 +- app/models/member.rb | 8 +- app/models/members/project_member.rb | 6 +- app/models/merge_request.rb | 92 +- app/models/merge_request_diff.rb | 10 +- app/models/merge_request_diff_commit.rb | 2 + app/models/merge_request_diff_file.rb | 2 + app/models/merge_requests_closing_issues.rb | 2 + app/models/milestone.rb | 33 +- app/models/namespace.rb | 4 +- app/models/network/commit.rb | 4 +- app/models/note.rb | 13 +- app/models/note_diff_file.rb | 2 + app/models/notification_reason.rb | 2 + app/models/notification_recipient.rb | 2 + app/models/notification_setting.rb | 3 + app/models/oauth_access_grant.rb | 2 + app/models/oauth_access_token.rb | 2 + app/models/out_of_context_discussion.rb | 2 + app/models/pages_domain.rb | 2 + app/models/personal_access_token.rb | 18 +- app/models/personal_snippet.rb | 2 + app/models/postgresql/replication_slot.rb | 32 + app/models/programming_language.rb | 4 + app/models/project.rb | 137 +- app/models/project_authorization.rb | 2 + app/models/project_auto_devops.rb | 2 + app/models/project_ci_cd_setting.rb | 2 + app/models/project_custom_attribute.rb | 2 + app/models/project_deploy_token.rb | 2 + app/models/project_feature.rb | 28 + app/models/project_group_link.rb | 5 +- app/models/project_import_data.rb | 2 + app/models/project_import_state.rb | 2 + app/models/project_label.rb | 2 + .../project_services/hangouts_chat_service.rb | 67 + app/models/project_services/jira_service.rb | 18 +- app/models/project_snippet.rb | 2 + app/models/project_statistics.rb | 25 +- app/models/project_team.rb | 23 +- app/models/project_wiki.rb | 16 +- app/models/protectable_dropdown.rb | 2 + app/models/protected_branch.rb | 2 + app/models/protected_ref_matcher.rb | 2 + app/models/protected_tag.rb | 2 + app/models/push_event.rb | 2 + app/models/push_event_payload.rb | 2 + app/models/readme_blob.rb | 2 + app/models/redirect_route.rb | 2 + app/models/release.rb | 2 + app/models/remote_mirror.rb | 4 +- app/models/repository.rb | 33 +- app/models/repository_language.rb | 12 + app/models/resource_label_event.rb | 35 + app/models/route.rb | 2 + app/models/security_event.rb | 2 + app/models/sent_notification.rb | 2 + app/models/service.rb | 3 + app/models/site_statistic.rb | 74 + app/models/snippet.rb | 6 + app/models/snippet_blob.rb | 2 + app/models/spam_log.rb | 2 + app/models/subscription.rb | 2 + app/models/system_note_metadata.rb | 2 + app/models/term_agreement.rb | 2 + app/models/timelog.rb | 2 + app/models/todo.rb | 13 +- app/models/tree.rb | 2 + app/models/trending_project.rb | 2 + app/models/u2f_registration.rb | 2 + app/models/upload.rb | 2 + app/models/user.rb | 60 +- app/models/user_agent_detail.rb | 2 + app/models/user_callout.rb | 2 + app/models/user_custom_attribute.rb | 2 + app/models/user_interacted_project.rb | 2 + app/models/user_status.rb | 17 + app/models/user_synced_attributes_metadata.rb | 2 + app/models/users_star_project.rb | 2 + app/models/wiki_directory.rb | 2 + app/models/wiki_page.rb | 5 +- .../application_setting/term_policy.rb | 2 + app/policies/base_policy.rb | 2 + app/policies/ci/build_policy.rb | 2 + app/policies/ci/pipeline_policy.rb | 2 + app/policies/ci/pipeline_schedule_policy.rb | 2 + app/policies/ci/runner_policy.rb | 2 + app/policies/ci/trigger_policy.rb | 2 + app/policies/clusters/cluster_policy.rb | 4 +- app/policies/commit_status_policy.rb | 2 + app/policies/concerns/policy_actor.rb | 36 + app/policies/deploy_key_policy.rb | 2 + app/policies/deploy_token_policy.rb | 6 +- app/policies/deployment_policy.rb | 2 + app/policies/environment_policy.rb | 13 +- app/policies/external_issue_policy.rb | 2 + app/policies/global_policy.rb | 7 + app/policies/group_label_policy.rb | 2 + app/policies/group_member_policy.rb | 2 + app/policies/group_policy.rb | 6 +- app/policies/issuable_policy.rb | 2 + app/policies/issue_policy.rb | 2 + app/policies/merge_request_policy.rb | 2 + app/policies/namespace_policy.rb | 2 + app/policies/nil_policy.rb | 2 + app/policies/note_policy.rb | 2 + app/policies/personal_snippet_policy.rb | 2 + app/policies/project_label_policy.rb | 2 + app/policies/project_member_policy.rb | 2 + app/policies/project_policy.rb | 10 +- app/policies/project_policy/class_methods.rb | 2 + app/policies/project_snippet_policy.rb | 2 + app/policies/protected_branch_policy.rb | 2 + app/policies/user_policy.rb | 9 + app/presenters/ci/build_metadata_presenter.rb | 2 + app/presenters/ci/build_presenter.rb | 2 + app/presenters/ci/build_runner_presenter.rb | 43 + app/presenters/ci/group_variable_presenter.rb | 2 + app/presenters/ci/pipeline_presenter.rb | 2 + app/presenters/ci/variable_presenter.rb | 2 + app/presenters/clusters/cluster_presenter.rb | 2 + app/presenters/commit_status_presenter.rb | 16 +- .../metric_presenter.rb | 2 + .../generic_commit_status_presenter.rb | 2 + app/presenters/group_member_presenter.rb | 2 + app/presenters/member_presenter.rb | 2 + app/presenters/members_presenter.rb | 2 + app/presenters/merge_request_presenter.rb | 16 +- app/presenters/project_member_presenter.rb | 2 + app/presenters/project_presenter.rb | 2 + .../settings/deploy_keys_presenter.rb | 2 + app/serializers/analytics_build_entity.rb | 2 + app/serializers/analytics_build_serializer.rb | 2 + app/serializers/analytics_commit_entity.rb | 2 + .../analytics_commit_serializer.rb | 2 + .../analytics_generic_serializer.rb | 2 + app/serializers/analytics_issue_entity.rb | 2 + app/serializers/analytics_issue_serializer.rb | 2 + .../analytics_merge_request_entity.rb | 2 + .../analytics_merge_request_serializer.rb | 2 + app/serializers/analytics_stage_entity.rb | 2 + app/serializers/analytics_stage_serializer.rb | 2 + app/serializers/analytics_summary_entity.rb | 2 + .../analytics_summary_serializer.rb | 2 + app/serializers/award_emoji_entity.rb | 2 + app/serializers/base_serializer.rb | 2 + app/serializers/blob_entity.rb | 2 + app/serializers/build_action_entity.rb | 2 + app/serializers/build_artifact_entity.rb | 2 + app/serializers/build_details_entity.rb | 2 + app/serializers/build_metadata_entity.rb | 2 + app/serializers/build_serializer.rb | 2 + app/serializers/cluster_application_entity.rb | 2 + app/serializers/cluster_entity.rb | 2 + app/serializers/cluster_serializer.rb | 2 + .../cohort_activity_month_entity.rb | 2 + app/serializers/cohort_entity.rb | 2 + app/serializers/cohorts_entity.rb | 2 + app/serializers/cohorts_serializer.rb | 2 + app/serializers/commit_entity.rb | 2 + .../concerns/user_status_tooltip.rb | 19 + app/serializers/concerns/with_pagination.rb | 2 + .../container_repositories_serializer.rb | 2 + .../container_repository_entity.rb | 2 + app/serializers/container_tag_entity.rb | 2 + app/serializers/container_tags_serializer.rb | 2 + app/serializers/deploy_key_entity.rb | 2 + app/serializers/deploy_key_serializer.rb | 2 + app/serializers/deploy_keys_project_entity.rb | 2 + app/serializers/deployment_entity.rb | 2 + app/serializers/deployment_serializer.rb | 2 + app/serializers/diff_file_entity.rb | 2 + app/serializers/diffs_entity.rb | 2 + app/serializers/diffs_serializer.rb | 2 + app/serializers/discussion_entity.rb | 2 + app/serializers/discussion_serializer.rb | 2 + app/serializers/entity_date_helper.rb | 23 +- app/serializers/entity_request.rb | 2 + app/serializers/environment_entity.rb | 14 +- app/serializers/environment_serializer.rb | 2 + app/serializers/group_child_entity.rb | 2 + app/serializers/group_child_serializer.rb | 2 + app/serializers/group_entity.rb | 2 + app/serializers/group_serializer.rb | 2 + app/serializers/group_variable_entity.rb | 2 + app/serializers/group_variable_serializer.rb | 2 + app/serializers/issuable_entity.rb | 2 + app/serializers/issuable_sidebar_entity.rb | 2 + app/serializers/issue_entity.rb | 2 + app/serializers/issue_serializer.rb | 2 + app/serializers/issue_sidebar_entity.rb | 2 + app/serializers/job_entity.rb | 2 + app/serializers/job_group_entity.rb | 2 + app/serializers/label_entity.rb | 2 + app/serializers/label_serializer.rb | 2 + app/serializers/lfs_file_lock_entity.rb | 2 + app/serializers/lfs_file_lock_serializer.rb | 2 + app/serializers/merge_request_basic_entity.rb | 2 + .../merge_request_basic_serializer.rb | 2 + .../merge_request_create_entity.rb | 2 + .../merge_request_create_serializer.rb | 2 + app/serializers/merge_request_diff_entity.rb | 2 + .../merge_request_metrics_entity.rb | 2 + app/serializers/merge_request_serializer.rb | 2 + app/serializers/merge_request_user_entity.rb | 2 + .../merge_request_widget_entity.rb | 18 + app/serializers/note_attachment_entity.rb | 2 + app/serializers/note_entity.rb | 2 + app/serializers/note_user_entity.rb | 2 + app/serializers/pipeline_details_entity.rb | 2 + app/serializers/pipeline_entity.rb | 2 + app/serializers/pipeline_serializer.rb | 11 +- app/serializers/project_entity.rb | 2 + app/serializers/project_mirror_entity.rb | 2 + app/serializers/project_note_entity.rb | 2 + app/serializers/project_note_serializer.rb | 2 + app/serializers/project_serializer.rb | 2 + app/serializers/request_aware_entity.rb | 2 + app/serializers/runner_entity.rb | 2 + app/serializers/stage_entity.rb | 2 + app/serializers/stage_serializer.rb | 2 + app/serializers/status_entity.rb | 2 + app/serializers/submodule_entity.rb | 2 + app/serializers/test_case_entity.rb | 7 + .../test_reports_comparer_entity.rb | 11 + .../test_reports_comparer_serializer.rb | 3 + app/serializers/test_suite_comparer_entity.rb | 14 + app/serializers/time_trackable_entity.rb | 2 + app/serializers/tree_entity.rb | 2 + app/serializers/tree_root_entity.rb | 2 + app/serializers/tree_serializer.rb | 2 + app/serializers/user_entity.rb | 3 + app/serializers/user_serializer.rb | 2 + app/serializers/variable_entity.rb | 2 + app/serializers/variable_serializer.rb | 2 + .../access_token_validation_service.rb | 2 + app/services/after_branch_delete_service.rb | 2 + app/services/akismet_service.rb | 2 + .../application_settings/base_service.rb | 2 + .../application_settings/update_service.rb | 2 + app/services/applications/create_service.rb | 2 + app/services/audit_event_service.rb | 2 + ...ntainer_registry_authentication_service.rb | 14 +- app/services/badges/base_service.rb | 2 + app/services/badges/build_service.rb | 2 + app/services/badges/create_service.rb | 2 + app/services/badges/update_service.rb | 4 +- app/services/base_count_service.rb | 2 + app/services/base_renderer.rb | 2 + app/services/base_service.rb | 2 + app/services/boards/base_service.rb | 2 + app/services/boards/create_service.rb | 2 + app/services/boards/issues/create_service.rb | 2 + app/services/boards/issues/list_service.rb | 29 +- app/services/boards/issues/move_service.rb | 2 + app/services/boards/list_service.rb | 2 + app/services/boards/lists/create_service.rb | 2 + app/services/boards/lists/destroy_service.rb | 2 + app/services/boards/lists/generate_service.rb | 2 + app/services/boards/lists/list_service.rb | 2 + app/services/boards/lists/move_service.rb | 2 + .../chat_names/authorize_user_service.rb | 2 + app/services/chat_names/find_user_service.rb | 2 + .../ci/compare_test_reports_service.rb | 37 + .../ci/create_pipeline_schedule_service.rb | 2 + app/services/ci/create_pipeline_service.rb | 2 + app/services/ci/ensure_stage_service.rb | 2 + ...tract_sections_from_build_trace_service.rb | 2 + .../ci/fetch_kubernetes_token_service.rb | 2 + app/services/ci/pipeline_trigger_service.rb | 2 + app/services/ci/play_build_service.rb | 2 + app/services/ci/process_pipeline_service.rb | 2 + app/services/ci/register_job_service.rb | 28 +- app/services/ci/retry_build_service.rb | 2 + app/services/ci/retry_pipeline_service.rb | 2 + app/services/ci/stop_environments_service.rb | 4 +- app/services/ci/update_build_queue_service.rb | 2 + app/services/ci/update_runner_service.rb | 2 + .../applications/base_helm_service.rb | 2 + .../check_ingress_ip_address_service.rb | 2 + .../check_installation_progress_service.rb | 10 +- .../schedule_installation_service.rb | 2 + app/services/clusters/create_service.rb | 2 + .../clusters/gcp/fetch_operation_service.rb | 2 + .../clusters/gcp/finalize_creation_service.rb | 2 + .../clusters/gcp/provision_service.rb | 2 + .../gcp/verify_provision_status_service.rb | 2 + app/services/clusters/update_service.rb | 2 + app/services/cohorts_service.rb | 2 + app/services/commits/change_service.rb | 4 +- app/services/commits/cherry_pick_service.rb | 2 + app/services/commits/create_service.rb | 2 + app/services/commits/revert_service.rb | 2 + app/services/compare_service.rb | 2 + .../concerns/exclusive_lease_guard.rb | 2 + .../concerns/issues/resolve_discussions.rb | 2 + .../concerns/update_visibility_level.rb | 2 + .../concerns/users/new_user_notifier.rb | 2 + .../concerns/users/participable_service.rb | 2 + app/services/create_branch_service.rb | 2 + app/services/create_deployment_service.rb | 2 + app/services/create_release_service.rb | 2 + app/services/create_snippet_service.rb | 2 + app/services/delete_branch_service.rb | 2 + .../delete_merged_branches_service.rb | 2 + app/services/deploy_keys/create_service.rb | 2 + app/services/deploy_tokens/create_service.rb | 2 + app/services/discussions/base_service.rb | 2 + app/services/discussions/resolve_service.rb | 2 + .../update_diff_position_service.rb | 2 + app/services/emails/base_service.rb | 2 + app/services/emails/confirm_service.rb | 2 + app/services/emails/create_service.rb | 2 + app/services/emails/destroy_service.rb | 2 + app/services/event_create_service.rb | 2 + app/services/events/render_service.rb | 2 + app/services/files/base_service.rb | 2 + app/services/files/create_dir_service.rb | 2 + app/services/files/create_service.rb | 2 + app/services/files/delete_service.rb | 2 + app/services/files/multi_service.rb | 2 + app/services/files/update_service.rb | 2 + app/services/git_push_service.rb | 104 +- app/services/git_tag_push_service.rb | 12 +- app/services/gpg_keys/create_service.rb | 2 + app/services/gravatar_service.rb | 2 + app/services/groups/base_service.rb | 2 + app/services/groups/create_service.rb | 2 + app/services/groups/destroy_service.rb | 2 + app/services/groups/nested_create_service.rb | 14 +- app/services/groups/transfer_service.rb | 2 + app/services/groups/update_service.rb | 13 +- app/services/ham_service.rb | 2 + .../import_export_clean_up_service.rb | 2 + app/services/issuable/bulk_update_service.rb | 2 + .../issuable/common_system_notes_service.rb | 2 + app/services/issuable/destroy_service.rb | 2 + app/services/issuable_base_service.rb | 4 +- app/services/issues/base_service.rb | 2 + app/services/issues/build_service.rb | 8 +- app/services/issues/close_service.rb | 2 + app/services/issues/create_service.rb | 2 + app/services/issues/duplicate_service.rb | 2 + ...fetch_referenced_merge_requests_service.rb | 2 + app/services/issues/move_service.rb | 2 + app/services/issues/reopen_service.rb | 2 + app/services/issues/update_service.rb | 4 + app/services/keys/base_service.rb | 2 + app/services/keys/create_service.rb | 2 + app/services/keys/destroy_service.rb | 2 + app/services/keys/last_used_service.rb | 2 + app/services/labels/base_service.rb | 2 + app/services/labels/create_service.rb | 2 + app/services/labels/find_or_create_service.rb | 2 + app/services/labels/promote_service.rb | 2 + app/services/labels/transfer_service.rb | 2 + app/services/labels/update_service.rb | 2 + app/services/lfs/file_transformer.rb | 2 + app/services/lfs/lock_file_service.rb | 2 + app/services/lfs/locks_finder_service.rb | 2 + app/services/lfs/unlock_file_service.rb | 2 + .../mattermost/create_team_service.rb | 2 + .../members/approve_access_request_service.rb | 2 + app/services/members/base_service.rb | 2 + app/services/members/create_service.rb | 2 + app/services/members/destroy_service.rb | 10 + .../members/request_access_service.rb | 2 + app/services/members/update_service.rb | 4 +- app/services/merge_request_metrics_service.rb | 2 + .../add_todo_when_build_fails_service.rb | 2 + .../merge_requests/assign_issues_service.rb | 2 + app/services/merge_requests/base_service.rb | 2 + app/services/merge_requests/build_service.rb | 11 +- app/services/merge_requests/close_service.rb | 2 + .../merge_requests/conflicts/base_service.rb | 2 + .../merge_requests/conflicts/list_service.rb | 2 + .../conflicts/resolve_service.rb | 2 + .../create_from_issue_service.rb | 2 + app/services/merge_requests/create_service.rb | 2 + .../delete_non_latest_diffs_service.rb | 2 + .../merge_requests/ff_merge_service.rb | 2 + .../merge_requests/get_urls_service.rb | 2 + app/services/merge_requests/merge_service.rb | 2 + .../merge_when_pipeline_succeeds_service.rb | 2 + .../merge_requests/post_merge_service.rb | 4 +- app/services/merge_requests/rebase_service.rb | 4 +- .../merge_requests/refresh_service.rb | 2 + .../merge_requests/reload_diffs_service.rb | 2 + app/services/merge_requests/reopen_service.rb | 3 + ...esolved_discussion_notification_service.rb | 2 + app/services/merge_requests/squash_service.rb | 2 + app/services/merge_requests/update_service.rb | 2 + .../working_copy_base_service.rb | 2 + app/services/metrics_service.rb | 2 + app/services/milestones/base_service.rb | 2 + app/services/milestones/close_service.rb | 2 + app/services/milestones/create_service.rb | 2 + app/services/milestones/destroy_service.rb | 2 + app/services/milestones/promote_service.rb | 2 + app/services/milestones/reopen_service.rb | 2 + app/services/milestones/update_service.rb | 4 +- app/services/note_summary.rb | 2 + app/services/notes/build_service.rb | 2 + app/services/notes/create_service.rb | 2 + app/services/notes/destroy_service.rb | 2 + app/services/notes/post_process_service.rb | 2 + app/services/notes/quick_actions_service.rb | 2 + app/services/notes/render_service.rb | 2 + app/services/notes/resolve_service.rb | 2 + app/services/notes/update_service.rb | 4 +- .../notification_recipient_service.rb | 15 +- app/services/notification_service.rb | 12 +- app/services/preview_markdown_service.rb | 2 + app/services/projects/after_import_service.rb | 2 + app/services/projects/autocomplete_service.rb | 2 + .../projects/base_move_relations_service.rb | 2 + app/services/projects/batch_count_service.rb | 2 + .../projects/batch_forks_count_service.rb | 2 + .../batch_open_issues_count_service.rb | 2 + app/services/projects/count_service.rb | 2 + .../projects/create_from_template_service.rb | 14 +- app/services/projects/create_service.rb | 4 +- app/services/projects/destroy_service.rb | 4 +- .../detect_repository_languages_service.rb | 52 + app/services/projects/download_service.rb | 2 + .../projects/enable_deploy_key_service.rb | 2 + app/services/projects/fork_service.rb | 4 +- app/services/projects/forks_count_service.rb | 2 + .../gitlab_projects_import_service.rb | 73 +- .../projects/group_links/create_service.rb | 2 + .../projects/group_links/destroy_service.rb | 2 + .../migrate_attachments_service.rb | 32 +- .../migrate_repository_service.rb | 27 +- .../hashed_storage_migration_service.rb | 13 +- app/services/projects/housekeeping_service.rb | 2 + .../projects/import_export/export_service.rb | 2 + app/services/projects/import_service.rb | 4 +- .../lfs_download_link_list_service.rb | 2 + .../lfs_pointers/lfs_download_service.rb | 4 +- .../lfs_pointers/lfs_import_service.rb | 2 + .../projects/lfs_pointers/lfs_link_service.rb | 2 + .../projects/lfs_pointers/lfs_list_service.rb | 2 + app/services/projects/move_access_service.rb | 2 + .../move_deploy_keys_projects_service.rb | 2 + app/services/projects/move_forks_service.rb | 2 + .../move_lfs_objects_projects_service.rb | 2 + .../move_notification_settings_service.rb | 2 + .../move_project_authorizations_service.rb | 2 + .../move_project_group_links_service.rb | 2 + .../projects/move_project_members_service.rb | 2 + .../move_users_star_projects_service.rb | 2 + .../projects/open_issues_count_service.rb | 2 + .../open_merge_requests_count_service.rb | 2 + .../projects/overwrite_project_service.rb | 2 + app/services/projects/participants_service.rb | 2 + .../projects/propagate_service_template.rb | 2 + app/services/projects/transfer_service.rb | 3 +- app/services/projects/unlink_fork_service.rb | 2 + .../update_pages_configuration_service.rb | 2 + app/services/projects/update_pages_service.rb | 2 + .../projects/update_remote_mirror_service.rb | 2 + app/services/projects/update_service.rb | 74 +- app/services/prometheus/adapter_service.rb | 4 +- .../protected_branches/access_level_params.rb | 4 +- .../protected_branches/api_service.rb | 2 + .../protected_branches/create_service.rb | 2 + .../protected_branches/destroy_service.rb | 2 + .../legacy_api_create_service.rb | 6 +- .../legacy_api_update_service.rb | 6 +- .../protected_branches/update_service.rb | 2 + app/services/protected_tags/create_service.rb | 2 + .../protected_tags/destroy_service.rb | 2 + app/services/protected_tags/update_service.rb | 2 + app/services/push_event_payload_service.rb | 2 + .../quick_actions/interpret_service.rb | 2 + .../repair_ldap_blocked_user_service.rb | 2 + .../repository_archive_clean_up_service.rb | 2 + app/services/reset_project_cache_service.rb | 2 + .../resource_events/change_labels_service.rb | 43 + app/services/search/global_service.rb | 2 + app/services/search/group_service.rb | 2 + app/services/search/project_service.rb | 2 + app/services/search/snippet_service.rb | 2 + app/services/search_service.rb | 2 + app/services/spam_check_service.rb | 2 + app/services/spam_service.rb | 2 + app/services/submit_usage_ping_service.rb | 2 + app/services/system_hooks_service.rb | 2 + app/services/system_note_service.rb | 35 +- app/services/tags/create_service.rb | 2 + app/services/tags/destroy_service.rb | 2 + app/services/test_hooks/base_service.rb | 2 + app/services/test_hooks/project_service.rb | 2 + app/services/test_hooks/system_service.rb | 2 + app/services/todo_service.rb | 32 +- app/services/todos/destroy/base_service.rb | 33 + .../destroy/confidential_issue_service.rb | 39 + .../todos/destroy/entity_leave_service.rb | 101 + .../todos/destroy/group_private_service.rb | 30 + .../todos/destroy/private_features_service.rb | 40 + .../todos/destroy/project_private_service.rb | 30 + app/services/update_release_service.rb | 4 +- app/services/update_snippet_service.rb | 2 + app/services/upload_service.rb | 2 + app/services/user_agent_detail_service.rb | 2 + .../user_project_access_changed_service.rb | 2 + app/services/users/activity_service.rb | 23 +- app/services/users/build_service.rb | 5 +- app/services/users/create_service.rb | 2 + app/services/users/destroy_service.rb | 2 + app/services/users/last_push_event_service.rb | 2 + .../users/migrate_to_ghost_user_service.rb | 2 + .../refresh_authorized_projects_service.rb | 2 + .../users/respond_to_terms_service.rb | 2 + app/services/users/set_status_service.rb | 39 + app/services/users/update_service.rb | 14 +- app/services/validate_new_branch_service.rb | 2 + app/services/verify_pages_domain_service.rb | 2 + app/services/web_hook_service.rb | 2 + app/services/wiki_pages/base_service.rb | 2 + app/services/wiki_pages/create_service.rb | 2 + app/services/wiki_pages/destroy_service.rb | 2 + app/services/wiki_pages/update_service.rb | 2 + app/uploaders/gitlab_uploader.rb | 22 + app/uploaders/import_export_uploader.rb | 4 +- app/uploaders/job_artifact_uploader.rb | 8 - .../application_settings/_abuse.html.haml | 4 +- .../_account_and_limit.html.haml | 12 +- .../_background_jobs.html.haml | 6 +- .../application_settings/_ci_cd.html.haml | 26 +- .../application_settings/_email.html.haml | 2 +- .../application_settings/_gitaly.html.haml | 8 +- .../application_settings/_help_page.html.haml | 6 +- .../application_settings/_influx.html.haml | 16 +- .../application_settings/_ip_limits.html.haml | 14 +- .../application_settings/_koding.html.haml | 4 +- .../application_settings/_logging.html.haml | 6 +- .../application_settings/_outbound.html.haml | 2 +- .../application_settings/_pages.html.haml | 4 +- .../_performance.html.haml | 2 +- .../_performance_bar.html.haml | 4 +- .../application_settings/_plantuml.html.haml | 4 +- .../_prometheus.html.haml | 2 +- .../application_settings/_realtime.html.haml | 4 +- .../application_settings/_registry.html.haml | 4 +- .../_repository_check.html.haml | 8 +- .../_repository_mirrors_form.html.haml | 4 +- .../_repository_storage.html.haml | 16 +- .../application_settings/_signin.html.haml | 14 +- .../application_settings/_signup.html.haml | 12 +- .../application_settings/_spam.html.haml | 12 +- .../application_settings/_terminal.html.haml | 4 +- .../application_settings/_terms.html.haml | 2 +- .../_third_party_offers.html.haml | 2 +- .../application_settings/_usage.html.haml | 7 +- .../_visibility_and_access.html.haml | 18 +- .../admin/application_settings/show.html.haml | 26 +- app/views/admin/dashboard/index.html.haml | 4 +- app/views/admin/groups/_form.html.haml | 10 +- app/views/admin/groups/_group.html.haml | 4 +- app/views/admin/groups/edit.html.haml | 4 +- app/views/admin/groups/index.html.haml | 4 +- app/views/admin/groups/new.html.haml | 4 +- app/views/admin/groups/show.html.haml | 56 +- app/views/admin/hooks/_form.html.haml | 8 +- app/views/admin/identities/edit.html.haml | 3 + app/views/admin/identities/index.html.haml | 2 + app/views/admin/identities/new.html.haml | 3 + .../impersonation_tokens/index.html.haml | 2 + app/views/admin/labels/_label.html.haml | 14 +- app/views/admin/labels/index.html.haml | 5 +- app/views/admin/projects/_projects.html.haml | 4 +- app/views/admin/runners/show.html.haml | 1 - app/views/admin/users/keys.html.haml | 2 + app/views/admin/users/projects.html.haml | 2 + app/views/admin/users/show.html.haml | 12 +- .../ci/runner/_how_to_setup_runner.html.haml | 7 +- .../dashboard/milestones/_milestone.html.haml | 2 +- app/views/dashboard/todos/index.html.haml | 48 +- .../applications/_delete_form.html.haml | 6 +- .../doorkeeper/applications/_form.html.haml | 14 +- .../doorkeeper/applications/edit.html.haml | 4 +- .../doorkeeper/applications/index.html.haml | 35 +- .../doorkeeper/applications/new.html.haml | 4 +- .../doorkeeper/applications/show.html.haml | 14 +- .../doorkeeper/authorizations/error.html.haml | 2 +- .../doorkeeper/authorizations/new.html.haml | 28 +- .../doorkeeper/authorizations/show.html.haml | 2 +- .../_delete_form.html.haml | 2 +- .../authorized_applications/index.html.haml | 6 +- app/views/explore/_head.html.haml | 4 +- app/views/explore/groups/_nav.html.haml | 2 +- app/views/explore/groups/index.html.haml | 12 +- app/views/explore/projects/_filter.html.haml | 6 +- app/views/explore/projects/_nav.html.haml | 6 +- app/views/explore/projects/index.html.haml | 4 +- app/views/explore/projects/starred.html.haml | 4 +- app/views/explore/projects/trending.html.haml | 4 +- app/views/groups/settings/_general.html.haml | 6 +- app/views/ide/index.html.haml | 8 +- app/views/import/_githubish_status.html.haml | 20 +- app/views/import/_project_status.html.haml | 11 + app/views/import/bitbucket/deploy_key.js.haml | 2 +- app/views/import/bitbucket/status.html.haml | 37 +- .../import/bitbucket_server/new.html.haml | 26 + .../import/bitbucket_server/status.html.haml | 87 + app/views/import/fogbugz/new.html.haml | 18 +- .../import/fogbugz/new_user_map.html.haml | 34 +- app/views/import/fogbugz/status.html.haml | 27 +- app/views/import/gitea/new.html.haml | 17 +- app/views/import/gitea/status.html.haml | 6 +- app/views/import/github/new.html.haml | 2 +- app/views/import/github/status.html.haml | 2 +- app/views/import/gitlab/status.html.haml | 22 +- .../import/gitlab_projects/new.html.haml | 18 +- app/views/import/google_code/new.html.haml | 42 +- .../import/google_code/new_user_map.html.haml | 36 +- app/views/import/google_code/status.html.haml | 40 +- app/views/import/manifest/_form.html.haml | 23 + app/views/import/manifest/new.html.haml | 12 + app/views/import/manifest/status.html.haml | 42 + .../cohorts/_cohorts_table.html.haml | 2 +- .../cohorts/_usage_ping.html.haml | 0 .../cohorts/index.html.haml | 0 .../_callout.html.haml | 0 .../_card.html.haml | 0 .../_disabled.html.haml | 0 .../_no_data.html.haml | 2 +- .../index.html.haml} | 2 +- app/views/layouts/_head.html.haml | 5 + .../layouts/_recaptcha_verification.html.haml | 4 +- app/views/layouts/_search.html.haml | 14 +- app/views/layouts/admin.html.haml | 4 +- app/views/layouts/dashboard.html.haml | 4 +- app/views/layouts/devise.html.haml | 13 +- app/views/layouts/devise_empty.html.haml | 6 +- app/views/layouts/explore.html.haml | 4 +- app/views/layouts/group_settings.html.haml | 2 +- app/views/layouts/header/_default.html.haml | 20 +- app/views/layouts/header/_new_dropdown.haml | 24 +- app/views/layouts/help.html.haml | 6 +- .../layouts/instance_statistics.html.haml | 6 + app/views/layouts/koding.html.haml | 6 +- app/views/layouts/mailer.text.erb | 2 +- app/views/layouts/mailer/devise.html.haml | 12 +- app/views/layouts/nav/_breadcrumbs.html.haml | 2 +- app/views/layouts/nav/_dashboard.html.haml | 48 +- app/views/layouts/nav/_explore.html.haml | 14 +- .../layouts/nav/sidebar/_admin.html.haml | 111 +- .../layouts/nav/sidebar/_group.html.haml | 54 +- .../sidebar/_instance_statistics.html.haml | 33 + .../layouts/nav/sidebar/_profile.html.haml | 56 +- .../layouts/nav/sidebar/_project.html.haml | 60 +- app/views/layouts/notify.html.haml | 7 +- app/views/layouts/profile.html.haml | 4 +- app/views/layouts/project_settings.html.haml | 2 +- app/views/layouts/search.html.haml | 4 +- app/views/layouts/snippets.html.haml | 2 +- app/views/profiles/accounts/show.html.haml | 2 +- app/views/profiles/emails/index.html.haml | 2 +- app/views/profiles/gpg_keys/_form.html.haml | 2 +- app/views/profiles/keys/_form.html.haml | 4 +- .../profiles/notifications/show.html.haml | 4 +- app/views/profiles/passwords/edit.html.haml | 6 +- .../personal_access_tokens/index.html.haml | 4 +- app/views/profiles/preferences/show.html.haml | 6 +- app/views/profiles/show.html.haml | 38 + .../profiles/two_factor_auths/show.html.haml | 10 +- app/views/projects/_home_panel.html.haml | 5 +- .../projects/_import_project_pane.html.haml | 53 +- ...ge_request_merge_method_settings.html.haml | 2 +- .../projects/_new_project_fields.html.haml | 16 +- .../projects/_project_templates.html.haml | 31 +- app/views/projects/artifacts/file.html.haml | 2 +- app/views/projects/blame/show.html.haml | 2 +- app/views/projects/blob/_header.html.haml | 2 +- app/views/projects/blob/show.html.haml | 3 + app/views/projects/buttons/_star.html.haml | 2 +- .../_gcp_signup_offer_banner.html.haml | 14 +- .../projects/clusters/gcp/_form.html.haml | 12 +- .../projects/clusters/user/_form.html.haml | 12 +- .../projects/clusters/user/_show.html.haml | 10 +- app/views/projects/commit/_change.html.haml | 4 +- .../projects/commit/_commit_box.html.haml | 5 +- app/views/projects/commits/_commit.html.haml | 4 +- .../projects/deploy_keys/_form.html.haml | 4 +- .../projects/deploy_tokens/_form.html.haml | 22 +- app/views/projects/deployments/_actions.haml | 7 +- app/views/projects/deployments/_rollback.haml | 7 +- app/views/projects/edit.html.haml | 18 +- .../environments/_external_url.html.haml | 2 +- .../projects/environments/_form.html.haml | 4 +- .../projects/environments/_stop.html.haml | 5 - .../projects/environments/metrics.html.haml | 22 +- .../projects/environments/show.html.haml | 32 +- app/views/projects/imports/new.html.haml | 6 +- app/views/projects/jobs/show.html.haml | 2 +- app/views/projects/jobs/terminal.html.haml | 2 +- app/views/projects/labels/index.html.haml | 35 +- .../conflicts/_submit_form.html.haml | 2 +- .../creations/_new_compare.html.haml | 2 +- app/views/projects/milestones/_form.html.haml | 6 +- app/views/projects/milestones/index.html.haml | 2 +- app/views/projects/milestones/show.html.haml | 2 +- .../projects/mirrors/_instructions.html.haml | 13 +- app/views/projects/mirrors/_push.html.haml | 6 +- app/views/projects/new.html.haml | 13 +- app/views/projects/pages/_destroy.haml | 4 +- .../pipeline_schedules/_form.html.haml | 12 +- app/views/projects/pipelines/_info.html.haml | 63 +- .../projects/pipelines/_with_tabs.html.haml | 3 +- app/views/projects/pipelines/new.html.haml | 2 +- app/views/projects/pipelines/show.html.haml | 6 +- .../_new_project_member.html.haml | 6 +- .../_new_shared_group.html.haml | 6 +- .../_built_in_templates.html.haml | 17 + .../_project_fields_form.html.haml | 12 + .../protected_tags/_protected_tag.html.haml | 4 +- .../_protected_tag_create_access_levels.haml | 8 + .../protected_tags/_update_protected_tag.haml | 5 - .../services/prometheus/_metrics.html.haml | 30 + .../services/prometheus/_show.html.haml | 33 +- .../settings/ci_cd/_autodevops_form.html.haml | 39 +- .../projects/settings/ci_cd/_form.html.haml | 14 +- .../projects/settings/ci_cd/show.html.haml | 4 +- app/views/projects/show.html.haml | 9 +- app/views/projects/tags/index.html.haml | 2 + app/views/projects/tree/show.html.haml | 3 + app/views/projects/triggers/_form.html.haml | 4 +- .../projects/wikis/_main_links.html.haml | 2 +- app/views/projects/wikis/_sidebar.html.haml | 8 +- app/views/shared/_import_form.html.haml | 2 +- app/views/shared/_label.html.haml | 6 +- app/views/shared/_label_row.html.haml | 13 +- .../shared/_new_project_item_select.html.haml | 4 +- .../_personal_access_tokens_form.html.haml | 6 +- .../shared/boards/components/_board.html.haml | 27 +- .../components/sidebar/_labels.html.haml | 3 +- .../shared/builds/_build_output.html.haml | 3 + app/views/shared/hook_logs/_content.html.haml | 4 +- .../issuable/_milestone_dropdown.html.haml | 2 +- .../shared/issuable/form/_metadata.html.haml | 2 +- app/views/shared/members/_member.html.haml | 1 + app/views/shared/notes/_note.html.haml | 4 +- .../shared/notes/_notes_with_form.html.haml | 2 +- app/views/shared/projects/_project.html.haml | 2 +- app/views/shared/snippets/_embed.html.haml | 2 +- app/views/shared/snippets/_header.html.haml | 1 + .../shared/tokens/_scopes_form.html.haml | 2 +- app/views/shared/web_hooks/_form.html.haml | 8 +- app/views/sherlock/queries/_general.html.haml | 4 +- app/views/users/show.html.haml | 79 +- app/workers/all_queues.yml | 9 +- app/workers/background_migration_worker.rb | 61 +- app/workers/concerns/each_shard_worker.rb | 2 + app/workers/concerns/todos_destroyer_queue.rb | 12 + app/workers/create_gpg_signature_worker.rb | 20 +- app/workers/delete_diff_files_worker.rb | 2 + .../detect_repository_languages_worker.rb | 33 + app/workers/email_receiver_worker.rb | 8 +- app/workers/emails_on_push_worker.rb | 8 +- .../object_storage/migrate_uploads_worker.rb | 2 - app/workers/process_commit_worker.rb | 5 +- .../project_migrate_hashed_storage_worker.rb | 4 +- .../repository_check/dispatch_worker.rb | 2 + app/workers/repository_import_worker.rb | 16 +- .../schedule_update_user_activity_worker.rb | 12 - .../confidential_issue_worker.rb | 10 + .../todos_destroyer/entity_leave_worker.rb | 10 + .../todos_destroyer/group_private_worker.rb | 10 + .../private_features_worker.rb | 10 + .../todos_destroyer/project_private_worker.rb | 10 + app/workers/update_user_activity_worker.rb | 27 - bin/changelog | 14 +- config/application.rb | 18 +- config/boot.rb | 5 + config/dependency_decisions.yml | 30 + config/environment.rb | 2 +- config/gitlab.yml.example | 21 +- config/initializers/1_settings.rb | 36 +- config/initializers/8_metrics.rb | 16 - config/initializers/action_mailer_hooks.rb | 12 + config/initializers/active_record_locking.rb | 4 +- .../active_record_table_definition.rb | 5 + .../active_record_verbose_query_logs.rb | 54 + .../additional_headers_interceptor.rb | 1 - config/initializers/bootstrap_form.rb | 2 +- config/initializers/devise.rb | 2 +- .../initializers/disable_email_interceptor.rb | 5 - .../email_template_interceptor.rb | 2 - config/initializers/hipchat_client_patch.rb | 14 + config/initializers/kubeclient.rb | 21 + config/initializers/omniauth.rb | 5 - config/initializers/sidekiq.rb | 2 + config/initializers/warden.rb | 44 +- config/object_store_settings.rb | 15 + config/routes.rb | 3 + config/routes/admin.rb | 4 - config/routes/import.rb | 13 + config/routes/instance_statistics.rb | 8 + config/routes/project.rb | 1 + config/routes/repository.rb | 1 + config/sidekiq_queues.yml | 4 +- config/unicorn.rb.example | 12 +- config/unicorn.rb.example.development | 17 + danger/changelog/Dangerfile | 68 + danger/changes_size/Dangerfile | 17 + danger/database/Dangerfile | 83 + danger/frozen_string/Dangerfile | 26 + danger/gemfile/Dangerfile | 24 + danger/metadata/Dangerfile | 25 + danger/specs/Dangerfile | 18 + db/fixtures/development/12_snippets.rb | 2 +- db/fixtures/development/19_environments.rb | 4 +- db/migrate/20140313092127_init_schema.rb | 9 +- db/migrate/20140407135544_fix_namespaces.rb | 1 - db/migrate/20140415124820_limits_to_mysql.rb | 1 - .../20140729145339_migrate_project_tags.rb | 1 - ...0141121133009_add_timestamps_to_members.rb | 1 - ...135007_add_import_data_to_project_table.rb | 1 - ..._home_page_url_for_application_settings.rb | 1 - ...6234545_add_gitlab_access_token_to_user.rb | 1 - ...06222854_add_notification_email_to_user.rb | 1 - ...74341_allow_null_in_services_project_id.rb | 1 - ...tbucket_access_token_and_secret_to_user.rb | 1 - ...0223022001_set_missing_last_activity_at.rb | 1 - ...sibility_levels_to_application_settings.rb | 1 - .../20150320234437_add_location_to_user.rb | 1 - ...55957_set_incorrect_assignee_id_to_null.rb | 1 - ...150327150017_add_import_data_to_project.rb | 1 - ...27223628_add_devise_two_factor_to_users.rb | 1 - ...attachment_size_to_application_settings.rb | 1 - ...d_devise_two_factor_backupable_to_users.rb | 1 - db/migrate/20150411000035_fix_identities.rb | 1 - .../20150411180045_rename_buildbox_service.rb | 1 - ...150417121913_create_project_import_data.rb | 1 - ...ect_visibililty_to_application_settings.rb | 1 - ...or_tag_names.acts_as_taggable_on_engine.rb | 1 - ...ggable_index.acts_as_taggable_on_engine.rb | 1 - ...or_tag_names.acts_as_taggable_on_engine.rb | 1 - ...ault_snippet_visibility_to_app_settings.rb | 1 - ..._remove_abandoned_group_members_records.rb | 1 - ..._signup_domains_to_application_settings.rb | 1 - ...09180749_convert_legacy_reference_notes.rb | 1 - ...th_applications_to_application_settings.rb | 1 - ...n_expire_delay_for_application_settings.rb | 1 - ...dd_default_otp_required_for_login_value.rb | 1 - ...6_add_updated_by_to_issuables_and_notes.rb | 1 - .../20150818213832_add_sent_notifications.rb | 1 - ...1905_enable_ssl_verification_by_default.rb | 1 - ...5_enable_ssl_verification_for_web_hooks.rb | 1 - ..._help_page_text_to_application_settings.rb | 1 - ..._add_ci_enabled_to_application_settings.rb | 1 - ..._invalid_milestones_from_merge_requests.rb | 1 - ...20010715_add_consumed_timestep_to_users.rb | 1 - ...1119_add_line_code_to_sent_notification.rb | 1 - ...50924125150_add_project_id_to_ci_commit.rb | 1 - ...25436_migrate_project_id_for_ci_commits.rb | 1 - ...0150930001110_merge_request_error_field.rb | 1 - ...095736_add_null_to_name_for_ci_projects.rb | 1 - .../20151002112914_add_stage_idx_to_builds.rb | 1 - ...0151002122929_add_ref_and_tag_to_builds.rb | 1 - .../20151005075649_add_user_id_to_build.rb | 1 - ...19_add_admin_notification_email_setting.rb | 1 - ...1013092124_add_artifacts_file_to_builds.rb | 1 - db/migrate/20151019111551_fix_build_tags.rb | 1 - ...20151019111703_fail_build_without_names.rb | 1 - .../20151020173516_ci_limits_to_mysql.rb | 1 - ...151023112551_fail_build_with_empty_name.rb | 1 - .../20151023144219_remove_satellites.rb | 1 - ...151103133339_add_shared_runners_setting.rb | 1 - .../20151104105513_add_file_to_lfs_objects.rb | 1 - ..._artifacts_size_to_application_settings.rb | 1 - ...51110125604_add_import_error_to_project.rb | 1 - .../20151201203948_raise_hook_url_limit.rb | 1 - .../20151209144329_migrate_ci_web_hooks.rb | 1 - .../20151209145909_migrate_ci_emails.rb | 1 - ...20151210030143_add_unlock_token_to_user.rb | 1 - ...istration_token_to_application_settings.rb | 1 - ...20151210125232_migrate_ci_slack_service.rb | 1 - ...51210125927_migrate_ci_hip_chat_service.rb | 1 - .../20151210125929_add_project_id_to_ci.rb | 1 - .../20151210125930_migrate_ci_to_project.rb | 1 - ...8154042_add_tfa_to_application_settings.rb | 1 - ...0151221234414_add_tfa_additional_fields.rb | 1 - db/migrate/20151224123230_rename_emojis.rb | 1 - ...9_add_recaptcha_to_application_settings.rb | 1 - ...0151229102248_influxdb_udp_port_setting.rb | 1 - ...2518_add_artifacts_metadata_to_ci_build.rb | 1 - ...326_add_akismet_to_application_settings.rb | 1 - ...60113111034_add_metrics_sample_interval.rb | 1 - ...5830_add_sentry_to_application_settings.rb | 1 - ..._base_commit_sha_to_merge_request_diffs.rb | 1 - ...28233227_change_lfs_objects_size_column.rb | 1 - ...remove_dot_atom_path_ending_of_projects.rb | 1 - ..._add_merge_commit_sha_to_merge_requests.rb | 1 - ...58_add_real_size_to_merge_request_diffs.rb | 1 - ...20160217100506_add_description_to_label.rb | 1 - .../20160217174422_add_note_to_tasks.rb | 1 - .../20160220123949_rename_tasks_to_todos.rb | 1 - ...9193553_add_main_language_to_repository.rb | 1 - ...port_credentials_to_project_import_data.rb | 1 - ...221555_disallow_blank_line_code_on_note.rb | 1 - ...92622_change_target_id_to_null_on_todos.rb | 1 - .../20160317092222_add_moved_to_to_issue.rb | 1 - ...4020319_remove_todos_for_deleted_issues.rb | 1 - ...115649_migrate_new_notification_setting.rb | 1 - ...remove_todos_for_deleted_merge_requests.rb | 1 - ...07120251_add_images_enabled_for_project.rb | 1 - .../20160413115152_add_token_to_web_hooks.rb | 1 - ...415062917_create_personal_access_tokens.rb | 1 - ...ed_runners_text_to_application_settings.rb | 1 - ...82152_convert_award_note_to_emoji_award.rb | 1 - .../20160419120017_add_metrics_packet_size.rb | 1 - ...sign_in_sources_to_application_settings.rb | 1 - ...504112519_add_run_untagged_to_ci_runner.rb | 1 - .../20160508215820_add_type_to_notes.rb | 1 - ...ck_access_token_to_application_settings.rb | 1 - ...ification_settings_for_deleted_projects.rb | 1 - ...en_expire_delay_to_application_settings.rb | 1 - ...remove_duplicated_notification_settings.rb | 1 - ...er_sign_up_text_to_application_settings.rb | 1 - db/migrate/20160610204157_add_deployments.rb | 2 - db/migrate/20160610204158_add_environments.rb | 2 - ...ccess_protocols_to_application_settings.rb | 1 - .../20160616102642_remove_duplicated_keys.rb | 1 - ...4938_add_protected_branches_push_access.rb | 2 +- ...952_add_protected_branches_merge_access.rb | 2 +- .../20160824124900_add_table_issue_metrics.rb | 2 - ...5052008_add_table_merge_request_metrics.rb | 2 - ...1113184239_create_user_chat_names_table.rb | 1 - ...1322_migrate_process_commit_worker_jobs.rb | 54 +- ...226122833_remove_dot_git_from_usernames.rb | 12 +- db/migrate/20170130221926_create_uploads.rb | 1 - db/migrate/20170222143317_drop_ci_projects.rb | 1 - ...639_remove_unused_ci_tables_and_columns.rb | 1 - ...70329095907_create_ci_trigger_schedules.rb | 1 - ...move_index_for_users_current_sign_in_at.rb | 2 - ...5112128_create_pipeline_schedules_table.rb | 1 - ...02091007_markdown_cache_limits_to_mysql.rb | 1 - ...name_users_ldap_email_to_external_email.rb | 1 + ...171453_add_timezone_to_issues_closed_at.rb | 1 + ...5907_migrate_remaining_issues_closed_at.rb | 1 + db/migrate/20180214093516_create_badges.rb | 1 + ...0180227182112_add_group_id_to_boards_ce.rb | 2 + ...e_foreign_keys_on_clusters_applications.rb | 1 + ...0309160427_add_partial_indexes_on_todos.rb | 11 +- ...54_rename_users_rss_token_to_feed_token.rb | 1 + ..._index_constraints_to_internal_id_table.rb | 1 + ...dd_index_to_ci_job_artifacts_file_store.rb | 1 + ...d_enforce_terms_to_application_settings.rb | 1 + .../20180425075446_create_term_agreements.rb | 1 + .../20180503131624_create_remote_mirrors.rb | 1 + ...7_add_index_to_namespaces_runners_token.rb | 1 + ...5054_add_indexes_to_project_mirror_data.rb | 1 + ...0503193542_add_indexes_to_remote_mirror.rb | 1 + ...724_add_index_on_ci_runners_runner_type.rb | 1 + ...0515005612_add_squash_to_merge_requests.rb | 1 + .../20180515121227_create_notes_diff_files.rb | 1 + ..._increase_mysql_text_limit_for_gpg_keys.rb | 1 - ...0529093006_ensure_remote_mirror_columns.rb | 1 + ...20180531185349_add_repository_languages.rb | 28 + ...e_default_value_for_dsa_key_restriction.rb | 4 +- .../20180608091413_add_group_to_todos.rb | 36 + ...name_merge_requests_allow_collaboration.rb | 1 + ...dd_columns_for_helm_tiller_certificates.rb | 12 + .../20180629153018_create_site_statistics.rb | 18 + .../20180702124358_remove_orphaned_routes.rb | 49 + .../20180702134423_generate_missing_routes.rb | 143 + ...945_add_file_format_to_ci_job_artifacts.rb | 7 + ...key_from_notification_settings_to_users.rb | 30 + .../20180713092803_create_user_statuses.rb | 20 + .../20180717125853_remove_restricted_todos.rb | 31 + ...stics_visibility_to_application_setting.rb | 20 + ...0722103201_add_private_profile_to_users.rb | 10 + ...preview_enabled_to_application_settings.rb | 20 + ...0726172057_create_resource_label_events.rb | 18 + ..._token_digest_to_personal_access_tokens.rb | 19 + ..._token_digest_on_personal_access_tokens.rb | 17 + db/migrate/gpg_keys_limits_to_mysql.rb | 1 - ...i_build_trace_chunks_raw_data_for_mysql.rb | 2 +- db/migrate/limits_to_mysql.rb | 1 - .../composite_primary_keys.rb | 6 +- ...221153951_rename_reserved_project_names.rb | 2 +- ...3418_rename_more_reserved_project_names.rb | 2 +- ...5130047_drop_ci_trigger_schedules_table.rb | 1 - ...1203055_cleanup_users_ldap_email_rename.rb | 1 + .../20170711145558_migrate_stages_statuses.rb | 1 + ...0150306_drop_events_for_migration_table.rb | 1 - ...0171106154015_remove_issues_branch_name.rb | 1 - ...leanup_add_timezone_to_issues_closed_at.rb | 1 + ..._merge_request_metrics_with_events_data.rb | 1 - ...27_build_user_interacted_projects_table.rb | 3 +- ...08143355_cleanup_users_rss_token_rename.rb | 1 + .../20180424151928_fill_file_store.rb | 2 +- ...runner_type_for_ci_runners_post_migrate.rb | 1 + ...ta_from_projects_to_project_mirror_data.rb | 1 - ...83701_set_minimal_project_build_timeout.rb | 2 + ...equests_allow_maintainer_to_push_rename.rb | 1 + ...21030_enqueue_delete_diff_files_workers.rb | 26 + .../20180704145007_update_project_indexes.rb | 2 +- ...20180706223200_populate_site_statistics.rb | 25 + ..._schedule_digest_personal_access_tokens.rb | 28 + .../20181014121030_enqueue_redact_links.rb | 65 + db/schema.rb | 67 +- doc/README.md | 4 +- doc/administration/gitaly/index.md | 50 +- .../high_availability/gitlab.md | 5 + doc/administration/high_availability/nfs.md | 20 +- .../img/raketasks/check_repos_output.png | Bin 19153 -> 0 bytes doc/administration/index.md | 3 +- doc/administration/job_artifacts.md | 13 +- .../monitoring/prometheus/gitlab_metrics.md | 2 +- .../operations/fast_ssh_key_lookup.md | 5 + doc/administration/operations/index.md | 5 +- .../operations/ssh_certificates.md | 165 + doc/administration/pages/index.md | 21 +- doc/administration/raketasks/check.md | 79 +- .../repository_storage_types.md | 2 +- doc/administration/troubleshooting/debug.md | 18 + doc/administration/uploads.md | 12 - doc/api/README.md | 45 +- doc/api/groups.md | 35 +- doc/api/issues.md | 7 +- doc/api/jobs.md | 26 +- doc/api/members.md | 75 +- doc/api/merge_requests.md | 17 +- doc/api/notes.md | 2 + doc/api/pipelines.md | 22 +- doc/api/project_import_export.md | 28 +- doc/api/projects.md | 67 +- doc/api/services.md | 48 + doc/api/settings.md | 9 +- doc/api/todos.md | 1 + doc/api/users.md | 126 +- doc/ci/docker/README.md | 1 + doc/ci/docker/using_docker_build.md | 10 +- doc/ci/docker/using_kaniko.md | 60 + doc/ci/examples/README.md | 4 + ...and-deploy-python-application-to-heroku.md | 2 +- doc/ci/img/junit_test_report.png | Bin 0 -> 9572 bytes doc/ci/junit_test_reports.md | 102 + doc/ci/variables/README.md | 6 +- doc/ci/yaml/README.md | 50 +- doc/development/README.md | 1 + doc/development/api_graphql_styleguide.md | 174 + doc/development/architecture.md | 2 +- doc/development/automatic_ce_ee_merge.md | 2 +- doc/development/background_migrations.md | 11 + doc/development/documentation/styleguide.md | 14 +- .../fe_guide/development_process.md | 6 +- doc/development/fe_guide/img/vue_arch.png | Bin 9848 -> 0 bytes doc/development/fe_guide/performance.md | 14 +- doc/development/fe_guide/vue.md | 241 +- doc/development/i18n/externalization.md | 12 +- doc/development/i18n/proofreader.md | 2 + doc/development/performance.md | 54 +- doc/development/profiling.md | 30 + doc/development/pry_debugging.md | 130 + doc/development/sql.md | 42 + .../testing_guide/best_practices.md | 2 +- .../testing_guide/frontend_testing.md | 4 + doc/development/what_requires_downtime.md | 4 +- doc/gitlab-basics/create-project.md | 2 +- doc/install/installation.md | 12 +- doc/install/kubernetes/gitlab_chart.md | 12 +- doc/install/kubernetes/preparation/tiller.md | 18 +- doc/integration/bitbucket.md | 20 +- doc/public_access/public_access.md | 6 + doc/raketasks/cleanup.md | 60 + doc/raketasks/user_management.md | 2 +- doc/security/rack_attack.md | 10 +- doc/ssh/README.md | 2 + doc/topics/autodevops/index.md | 4 +- .../high-availability/aws/README.md | 6 +- doc/update/10.6-to-10.7.md | 2 +- doc/update/11.1-to-11.2.md | 378 ++ doc/update/mysql_to_postgresql.md | 18 +- doc/update/patch_versions.md | 16 +- doc/user/admin_area/img/cohorts.png | Bin 439635 -> 0 bytes doc/user/admin_area/monitoring/convdev.md | 32 +- .../admin_area/monitoring/health_check.md | 14 +- .../monitoring/img/convdev_index.png | Bin 119743 -> 0 bytes .../admin_area/settings/usage_statistics.md | 13 +- doc/user/admin_area/user_cohorts.md | 40 +- doc/user/gitlab_com/index.md | 3 +- doc/user/index.md | 4 + doc/user/instance_statistics/convdev.md | 26 + doc/user/instance_statistics/img/cohorts.png | Bin 0 -> 59494 bytes .../instance_statistics/img/convdev_index.png | Bin 0 -> 316893 bytes .../img/instance_statistics_button.png | Bin 0 -> 9462 bytes doc/user/instance_statistics/index.md | 19 + doc/user/instance_statistics/user_cohorts.md | 27 + .../account/two_factor_authentication.md | 2 +- doc/user/profile/index.md | 44 + doc/user/profile/personal_access_tokens.md | 1 + doc/user/project/bulk_editing.md | 22 +- .../project/clusters/eks_and_gitlab/index.md | 2 +- doc/user/project/clusters/index.md | 2 +- doc/user/project/img/bulk-editing.png | Bin 0 -> 197686 bytes .../img/labels_project_list_search.png | Bin 0 -> 175669 bytes doc/user/project/import/bitbucket.md | 27 +- doc/user/project/import/bitbucket_server.md | 75 + .../img/bitbucket_import_new_project.png | Bin 1316 -> 0 bytes .../bitbucket_server_import_credentials.png | Bin 0 -> 40566 bytes ...bitbucket_server_import_select_project.png | Bin 0 -> 56750 bytes .../import_projects_from_new_project_page.png | Bin 36821 -> 81639 bytes .../project/import/img/manifest_status.png | Bin 0 -> 34878 bytes doc/user/project/import/index.md | 1 + doc/user/project/import/manifest.md | 59 + .../project/integrations/emails_on_push.md | 2 +- .../project/integrations/hangouts_chat.md | 29 + .../img/hangouts_chat_configuration.png | Bin 0 -> 101788 bytes doc/user/project/integrations/jira.md | 2 +- .../project/integrations/project_services.md | 1 + doc/user/project/integrations/webhooks.md | 28 + doc/user/project/issue_board.md | 16 +- doc/user/project/labels.md | 10 + doc/user/project/merge_requests/index.md | 3 +- .../pages/getting_started_part_three.md | 40 +- .../dns_add_new_a_record_example_updated.png | Bin 10578 -> 0 bytes ..._add_new_a_record_example_updated_2018.png | Bin 0 -> 7704 bytes .../img/admin_clientside_evaluation.png | Bin 0 -> 9342 bytes .../web_ide/img/clientside_evaluation.png | Bin 0 -> 60256 bytes doc/user/project/web_ide/index.md | 47 +- doc/user/project/wiki/index.md | 7 + doc/user/search/img/issues_mrs_shortcut.png | Bin 34115 -> 61888 bytes doc/user/search/img/project_search.png | Bin 41900 -> 89002 bytes doc/workflow/todos.md | 1 + .../migration/create_table_migration.rb | 2 + .../active_record/migration/migration.rb | 2 + .../post_deployment_migration/migration.rb | 2 + lib/additional_email_headers_interceptor.rb | 6 - lib/api/boards.rb | 6 +- lib/api/boards_responses.rb | 16 +- lib/api/branches.rb | 1 + lib/api/commits.rb | 16 +- lib/api/deploy_keys.rb | 6 +- lib/api/entities.rb | 44 +- lib/api/environments.rb | 3 +- lib/api/group_boards.rb | 6 +- lib/api/groups.rb | 6 +- lib/api/helpers.rb | 9 +- lib/api/helpers/headers_helpers.rb | 6 +- lib/api/helpers/members_helpers.rb | 25 + lib/api/helpers/notes_helpers.rb | 2 + lib/api/internal.rb | 55 +- lib/api/issues.rb | 6 +- lib/api/jobs.rb | 2 +- lib/api/keys.rb | 2 +- lib/api/members.rb | 22 +- lib/api/merge_requests.rb | 2 +- lib/api/project_hooks.rb | 2 +- lib/api/projects.rb | 94 +- lib/api/runner.rb | 28 +- lib/api/runners.rb | 2 +- lib/api/services.rb | 13 +- lib/api/settings.rb | 178 +- lib/api/users.rb | 49 +- lib/backup/repository.rb | 171 +- lib/banzai/filter/absolute_link_filter.rb | 2 + .../filter/abstract_reference_filter.rb | 2 + .../ascii_doc_post_processing_filter.rb | 2 + lib/banzai/filter/autolink_filter.rb | 2 + lib/banzai/filter/blockquote_fence_filter.rb | 24 +- lib/banzai/filter/color_filter.rb | 2 + .../filter/commit_range_reference_filter.rb | 2 + lib/banzai/filter/commit_reference_filter.rb | 2 + lib/banzai/filter/commit_trailers_filter.rb | 2 + lib/banzai/filter/emoji_filter.rb | 2 + lib/banzai/filter/epic_reference_filter.rb | 2 + .../filter/external_issue_reference_filter.rb | 2 + lib/banzai/filter/external_link_filter.rb | 2 + lib/banzai/filter/gollum_tags_filter.rb | 2 + lib/banzai/filter/html_entity_filter.rb | 2 + lib/banzai/filter/image_lazy_load_filter.rb | 4 +- lib/banzai/filter/image_link_filter.rb | 2 + lib/banzai/filter/inline_diff_filter.rb | 2 + .../filter/issuable_reference_filter.rb | 2 + lib/banzai/filter/issuable_state_filter.rb | 2 + lib/banzai/filter/issue_reference_filter.rb | 2 + lib/banzai/filter/label_reference_filter.rb | 2 + .../filter/markdown_engines/common_mark.rb | 2 +- lib/banzai/filter/markdown_filter.rb | 2 + lib/banzai/filter/math_filter.rb | 2 + .../filter/merge_request_reference_filter.rb | 2 + lib/banzai/filter/mermaid_filter.rb | 2 + .../filter/milestone_reference_filter.rb | 2 + lib/banzai/filter/plantuml_filter.rb | 2 + lib/banzai/filter/redactor_filter.rb | 2 + lib/banzai/filter/reference_filter.rb | 2 + lib/banzai/filter/relative_link_filter.rb | 2 + lib/banzai/filter/sanitization_filter.rb | 2 + lib/banzai/filter/set_direction_filter.rb | 2 + lib/banzai/filter/snippet_reference_filter.rb | 2 + lib/banzai/filter/syntax_highlight_filter.rb | 4 +- lib/banzai/filter/table_of_contents_filter.rb | 4 +- lib/banzai/filter/task_list_filter.rb | 2 + lib/banzai/filter/user_reference_filter.rb | 2 + lib/banzai/filter/video_link_filter.rb | 2 + lib/banzai/filter/wiki_link_filter.rb | 2 + lib/banzai/filter/yaml_front_matter_filter.rb | 2 + lib/banzai/pipeline/emoji_pipeline.rb | 17 + lib/banzai/pipeline/gfm_pipeline.rb | 18 +- lib/banzai/pipeline/post_process_pipeline.rb | 12 +- lib/banzai/pipeline/single_line_pipeline.rb | 8 +- lib/bitbucket_server/client.rb | 71 + lib/bitbucket_server/collection.rb | 23 + lib/bitbucket_server/connection.rb | 122 + lib/bitbucket_server/page.rb | 36 + lib/bitbucket_server/paginator.rb | 38 + .../representation/activity.rb | 71 + lib/bitbucket_server/representation/base.rb | 21 + .../representation/comment.rb | 130 + .../representation/pull_request.rb | 76 + .../representation/pull_request_comment.rb | 122 + lib/bitbucket_server/representation/repo.rb | 69 + lib/declarative_policy.rb | 12 +- lib/declarative_policy/base.rb | 10 +- lib/declarative_policy/delegate_dsl.rb | 6 +- lib/declarative_policy/policy_dsl.rb | 14 +- lib/declarative_policy/preferred_scope.rb | 10 +- lib/declarative_policy/rule.rb | 4 +- lib/declarative_policy/rule_dsl.rb | 10 +- lib/declarative_policy/runner.rb | 2 +- lib/disable_email_interceptor.rb | 7 - lib/email_template_interceptor.rb | 11 - lib/extracts_path.rb | 5 + lib/feature.rb | 6 +- lib/gitlab/access.rb | 24 +- lib/gitlab/auth.rb | 21 +- lib/gitlab/auth/activity.rb | 78 + lib/gitlab/auth/blocked_user_tracker.rb | 36 +- lib/gitlab/auth/o_auth/provider.rb | 3 +- lib/gitlab/auth/o_auth/user.rb | 2 +- lib/gitlab/auth/user_auth_finders.rb | 2 +- lib/gitlab/background_migration.rb | 6 +- .../add_merge_request_diff_commits_count.rb | 1 - .../archive_legacy_traces.rb | 1 - .../create_fork_network_memberships_range.rb | 1 - .../create_gpg_key_subkeys_from_gpg_keys.rb | 1 - .../background_migration/delete_diff_files.rb | 85 +- ...rialize_merge_request_diffs_and_commits.rb | 1 - .../background_migration/digest_column.rb | 25 + .../fill_file_store_job_artifact.rb | 1 - .../fill_file_store_lfs_object.rb | 1 - .../background_migration/fill_store_upload.rb | 1 - .../fix_cross_project_label_links.rb | 2 + .../migrate_build_stage.rb | 1 - .../migrate_events_to_push_event_payloads.rb | 1 - .../migrate_system_uploads_to_new_folder.rb | 1 - .../move_personal_snippet_files.rb | 1 - .../normalize_ldap_extern_uids_range.rb | 1 - .../populate_fork_networks_range.rb | 2 +- ..._merge_request_metrics_with_events_data.rb | 3 - .../populate_untracked_uploads.rb | 2 +- ...populate_untracked_uploads_dependencies.rb | 4 +- .../prepare_untracked_uploads.rb | 2 +- .../background_migration/redact_links.rb | 62 + .../remove_restricted_todos.rb | 105 + .../schedule_diff_files_deletion.rb | 44 + lib/gitlab/bare_repository_import/importer.rb | 36 +- .../bare_repository_import/repository.rb | 2 - .../bitbucket_server_import/importer.rb | 327 + .../project_creator.rb | 36 + lib/gitlab/checks/change_access.rb | 25 +- lib/gitlab/checks/lfs_integrity.rb | 5 +- lib/gitlab/ci/ansi2html.rb | 118 +- .../ci/build/artifacts/gzip_file_adapter.rb | 46 + lib/gitlab/ci/build/artifacts/metadata.rb | 19 +- lib/gitlab/ci/config/entry/artifacts.rb | 13 +- lib/gitlab/ci/config/entry/commands.rb | 13 +- lib/gitlab/ci/config/entry/configurable.rb | 2 +- lib/gitlab/ci/config/entry/reports.rb | 32 + lib/gitlab/ci/config/entry/validators.rb | 14 + lib/gitlab/ci/parsers.rb | 9 + lib/gitlab/ci/parsers/junit.rb | 69 + lib/gitlab/ci/reports/test_case.rb | 32 + lib/gitlab/ci/reports/test_reports.rb | 39 + .../ci/reports/test_reports_comparer.rb | 38 + lib/gitlab/ci/reports/test_suite.rb | 54 + lib/gitlab/ci/reports/test_suite_comparer.rb | 57 + lib/gitlab/ci/status/build/failed.rb | 19 +- lib/gitlab/ci/trace.rb | 2 + lib/gitlab/ci/trace/http_io.rb | 197 - lib/gitlab/ci/trace/section_parser.rb | 12 +- lib/gitlab/ci/variables/collection/item.rb | 2 +- .../cleanup/project_upload_file_finder.rb | 66 + lib/gitlab/cleanup/project_uploads.rb | 125 + lib/gitlab/cleanup/remote_uploads.rb | 80 + lib/gitlab/crypto_helper.rb | 30 + lib/gitlab/current_settings.rb | 2 +- lib/gitlab/database.rb | 26 + lib/gitlab/database/migration_helpers.rb | 4 +- lib/gitlab/diff/image_point.rb | 6 +- lib/gitlab/diff/inline_diff.rb | 4 +- lib/gitlab/ee_compat_check.rb | 28 +- .../hook/additional_headers_interceptor.rb | 12 + .../email/hook/delivery_metrics_observer.rb | 31 + .../email/hook/disable_email_interceptor.rb | 13 + .../email/hook/email_template_interceptor.rb | 18 + lib/gitlab/encoding_helper.rb | 12 +- lib/gitlab/exclusive_lease_helpers.rb | 2 +- lib/gitlab/fogbugz_import/importer.rb | 22 +- lib/gitlab/git/blob.rb | 108 +- lib/gitlab/git/commit.rb | 82 +- lib/gitlab/git/conflict/resolver.rb | 2 +- lib/gitlab/git/diff.rb | 1 + lib/gitlab/git/diff_collection.rb | 12 +- lib/gitlab/git/popen.rb | 18 +- lib/gitlab/git/repository.rb | 831 +-- lib/gitlab/git/repository_mirroring.rb | 89 +- lib/gitlab/git/rev_list.rb | 73 - .../git/support/format-git-cat-file-input | 21 - lib/gitlab/git/wiki.rb | 8 +- lib/gitlab/git_access.rb | 20 +- lib/gitlab/git_post_receive.rb | 12 +- lib/gitlab/git_ref_validator.rb | 8 +- lib/gitlab/gitaly_client.rb | 4 +- lib/gitlab/gitaly_client/commit_service.rb | 4 +- lib/gitlab/gitaly_client/diff.rb | 2 +- lib/gitlab/gitaly_client/operation_service.rb | 16 + lib/gitlab/gitaly_client/ref_service.rb | 57 +- lib/gitlab/gitaly_client/storage_settings.rb | 4 +- lib/gitlab/gitaly_client/wiki_service.rb | 4 +- lib/gitlab/gitlab_import/client.rb | 30 +- lib/gitlab/google_code_import/importer.rb | 22 +- lib/gitlab/gpg.rb | 12 +- lib/gitlab/gpg/commit.rb | 2 +- lib/gitlab/graphql/authorize.rb | 9 +- .../graphql/authorize/authorize_resource.rb | 46 + lib/gitlab/graphql/errors.rb | 1 + lib/gitlab/graphql/mount_mutation.rb | 18 + lib/gitlab/graphs/commits.rb | 2 +- lib/gitlab/hashed_storage/migrator.rb | 2 +- lib/gitlab/hook_data/base_builder.rb | 38 + lib/gitlab/hook_data/issuable_builder.rb | 8 +- lib/gitlab/hook_data/issue_builder.rb | 9 +- lib/gitlab/hook_data/merge_request_builder.rb | 9 +- lib/gitlab/hook_data/note_builder.rb | 43 + lib/gitlab/hook_data/wiki_page_builder.rb | 15 + lib/gitlab/http_io.rb | 193 + lib/gitlab/import_export/command_line_util.rb | 15 + lib/gitlab/import_export/file_importer.rb | 24 +- lib/gitlab/import_export/import_export.yml | 1 + lib/gitlab/import_export/importer.rb | 12 +- lib/gitlab/import_export/members_mapper.rb | 2 +- .../import_export/merge_request_parser.rb | 7 +- lib/gitlab/import_export/uploads_manager.rb | 5 +- lib/gitlab/import_sources.rb | 30 +- lib/gitlab/json_logger.rb | 22 + lib/gitlab/kubernetes.rb | 7 +- lib/gitlab/kubernetes/config_map.rb | 16 +- lib/gitlab/kubernetes/helm.rb | 2 +- lib/gitlab/kubernetes/helm/api.rb | 22 +- lib/gitlab/kubernetes/helm/base_command.rb | 32 +- lib/gitlab/kubernetes/helm/certificate.rb | 73 + lib/gitlab/kubernetes/helm/init_command.rb | 18 +- lib/gitlab/kubernetes/helm/install_command.rb | 35 +- lib/gitlab/kubernetes/helm/pod.rb | 8 +- lib/gitlab/language_detection.rb | 68 + lib/gitlab/logger.rb | 8 + lib/gitlab/mail_room.rb | 2 +- lib/gitlab/manifest_import/manifest.rb | 81 + lib/gitlab/manifest_import/project_creator.rb | 41 + lib/gitlab/metrics/influx_db.rb | 2 - lib/gitlab/metrics/method_call.rb | 2 - .../metrics/subscribers/active_record.rb | 2 +- lib/gitlab/middleware/basic_health_check.rb | 43 + lib/gitlab/omniauth_initializer.rb | 30 +- lib/gitlab/popen.rb | 9 +- lib/gitlab/profiler.rb | 6 + .../profiler/total_time_flat_printer.rb | 39 + .../with_nested_groups.rb | 2 +- .../without_nested_groups.rb | 2 +- lib/gitlab/project_search_results.rb | 19 +- lib/gitlab/prometheus/metric.rb | 2 +- .../additional_metrics_deployment_query.rb | 1 + .../additional_metrics_environment_query.rb | 1 + .../queries/query_additional_metrics.rb | 8 +- lib/gitlab/regex.rb | 30 + lib/gitlab/serializer/ci/variables.rb | 5 +- lib/gitlab/shell.rb | 59 +- lib/gitlab/template_helper.rb | 28 + lib/gitlab/url_sanitizer.rb | 17 +- lib/gitlab/usage_data.rb | 2 +- lib/gitlab/user_activities.rb | 34 - lib/gitlab/workhorse.rb | 63 +- lib/rouge/formatters/html_gitlab.rb | 2 +- lib/support/nginx/registry-ssl | 2 +- lib/tasks/gettext.rake | 36 +- lib/tasks/gitlab/bulk_add_permission.rake | 4 +- lib/tasks/gitlab/check.rake | 25 - lib/tasks/gitlab/cleanup.rake | 62 +- lib/tasks/gitlab/git.rake | 87 +- lib/tasks/gitlab/info.rake | 4 +- lib/tasks/gitlab/uploads/migrate.rake | 2 +- lib/tasks/tokens.rake | 14 +- locale/bg/gitlab.po | 2388 ++++++- locale/cs_CZ/gitlab.po | 2410 ++++++- locale/de/gitlab.po | 2390 ++++++- locale/eo/gitlab.po | 2388 ++++++- locale/es/gitlab.po | 2394 ++++++- locale/fil_PH/gitlab.po | 2388 ++++++- locale/fr/gitlab.po | 2508 ++++++- locale/gitlab.pot | 904 ++- locale/gl_ES/gitlab.po | 2388 ++++++- locale/id_ID/gitlab.po | 2377 ++++++- locale/it/gitlab.po | 2400 ++++++- locale/ja/gitlab.po | 3273 +++++++-- locale/ko/gitlab.po | 3125 +++++++-- locale/nl_NL/gitlab.po | 2400 ++++++- locale/pl_PL/gitlab.po | 2410 ++++++- locale/pt_BR/gitlab.po | 2608 ++++++- locale/ru/gitlab.po | 2474 ++++++- locale/tr_TR/gitlab.po | 2388 ++++++- locale/uk/gitlab.po | 2508 ++++++- locale/zh_CN/gitlab.po | 2629 ++++++- locale/zh_HK/gitlab.po | 2379 ++++++- locale/zh_TW/gitlab.po | 2409 ++++++- package.json | 31 +- public/404.html | 4 +- public/422.html | 4 +- public/500.html | 4 +- public/502.html | 4 +- public/503.html | 4 +- qa/README.md | 2 +- qa/qa.rb | 28 + qa/qa/factory/repository/project_push.rb | 2 + qa/qa/factory/repository/push.rb | 16 +- qa/qa/factory/resource/file.rb | 34 + qa/qa/factory/resource/fork.rb | 24 + qa/qa/factory/resource/kubernetes_cluster.rb | 8 +- qa/qa/factory/resource/merge_request.rb | 11 +- .../resource/merge_request_from_fork.rb | 24 + qa/qa/factory/resource/project.rb | 1 + qa/qa/factory/resource/project_milestone.rb | 36 + qa/qa/factory/resource/user.rb | 34 + qa/qa/git/repository.rb | 2 +- .../page/admin/settings/repository_storage.rb | 4 +- qa/qa/page/component/dropzone.rb | 2 +- qa/qa/page/file/form.rb | 40 + qa/qa/page/file/shared/commit_message.rb | 19 + qa/qa/page/file/show.rb | 30 + qa/qa/page/issuable/sidebar.rb | 7 + qa/qa/page/layout/banner.rb | 17 + qa/qa/page/main/login.rb | 19 +- qa/qa/page/main/oauth.rb | 2 +- qa/qa/page/main/sign_up.rb | 27 + qa/qa/page/menu/main.rb | 4 +- qa/qa/page/menu/side.rb | 13 +- qa/qa/page/merge_request/new.rb | 15 + qa/qa/page/project/fork/new.rb | 17 + qa/qa/page/project/milestone/index.rb | 17 + qa/qa/page/project/milestone/new.rb | 27 + qa/qa/page/project/new.rb | 7 +- .../project/operations/kubernetes/show.rb | 1 + qa/qa/page/project/settings/ci_cd.rb | 6 +- .../project/settings/protected_branches.rb | 6 + qa/qa/page/project/show.rb | 19 +- qa/qa/page/view.rb | 4 +- qa/qa/runtime/api/request.rb | 2 +- qa/qa/runtime/browser.rb | 4 +- qa/qa/runtime/key/base.rb | 4 +- qa/qa/runtime/release.rb | 4 +- qa/qa/scenario/test/instance.rb | 2 +- qa/qa/specs/features/login/standard_spec.rb | 15 - .../features/merge_request/create_spec.rb | 25 +- .../features/project/auto_devops_spec.rb | 2 +- qa/qa/specs/features/project/file_spec.rb | 54 + .../features/project/fork_project_spec.rb | 23 + .../repository/protected_branches_spec.rb | 24 +- qa/spec/git/repository_spec.rb | 2 +- qa/spec/page/view_spec.rb | 4 +- qa/spec/scenario/test/instance_spec.rb | 2 +- qa/spec/spec_helper.rb | 2 +- .../line_break_around_conditional_block.rb | 2 + scripts/lint-rugged | 5 +- spec/bin/changelog_spec.rb | 14 + spec/config/object_store_settings_spec.rb | 29 + .../admin/services_controller_spec.rb | 2 +- .../application_controller_spec.rb | 151 + .../autocomplete_controller_spec.rb | 20 +- .../boards/issues_controller_spec.rb | 6 +- .../boards/lists_controller_spec.rb | 2 +- .../dashboard/groups_controller_spec.rb | 4 +- .../dashboard/milestones_controller_spec.rb | 21 +- spec/controllers/dashboard_controller_spec.rb | 2 +- .../groups/boards_controller_spec.rb | 2 +- .../groups/milestones_controller_spec.rb | 2 +- .../groups/runners_controller_spec.rb | 2 +- .../groups/settings/ci_cd_controller_spec.rb | 2 +- .../groups/variables_controller_spec.rb | 2 +- spec/controllers/groups_controller_spec.rb | 6 +- .../bitbucket_server_controller_spec.rb | 154 + .../cohorts_controller_spec.rb | 7 + ...ional_development_index_controller_spec.rb | 7 + spec/controllers/profiles_controller_spec.rb | 9 + .../projects/avatars_controller_spec.rb | 2 +- .../projects/badges_controller_spec.rb | 2 +- .../projects/blame_controller_spec.rb | 2 +- .../projects/blob_controller_spec.rb | 12 +- .../projects/boards_controller_spec.rb | 2 +- .../projects/branches_controller_spec.rb | 2 +- .../clusters/applications_controller_spec.rb | 4 +- .../projects/clusters_controller_spec.rb | 36 +- .../projects/commit_controller_spec.rb | 2 +- .../projects/commits_controller_spec.rb | 14 +- .../projects/compare_controller_spec.rb | 2 +- .../cycle_analytics_controller_spec.rb | 2 +- .../projects/deploy_keys_controller_spec.rb | 2 +- .../projects/deployments_controller_spec.rb | 2 +- .../projects/environments_controller_spec.rb | 2 +- .../projects/find_file_controller_spec.rb | 2 +- .../projects/forks_controller_spec.rb | 2 +- .../projects/graphs_controller_spec.rb | 2 +- .../projects/group_links_controller_spec.rb | 4 +- .../projects/hooks_controller_spec.rb | 2 +- .../projects/imports_controller_spec.rb | 10 +- .../projects/issues_controller_spec.rb | 27 +- .../projects/jobs_controller_spec.rb | 14 +- .../projects/labels_controller_spec.rb | 2 +- .../projects/mattermosts_controller_spec.rb | 2 +- .../creations_controller_spec.rb | 4 +- .../merge_requests/diffs_controller_spec.rb | 2 +- .../merge_requests_controller_spec.rb | 84 +- .../projects/milestones_controller_spec.rb | 35 +- .../projects/pages_controller_spec.rb | 2 +- .../projects/pages_domains_controller_spec.rb | 2 +- .../pipeline_schedules_controller_spec.rb | 28 +- .../projects/pipelines_controller_spec.rb | 14 +- .../pipelines_settings_controller_spec.rb | 2 +- .../project_members_controller_spec.rb | 20 +- .../prometheus/metrics_controller_spec.rb | 2 +- .../protected_branches_controller_spec.rb | 8 +- .../protected_tags_controller_spec.rb | 2 +- .../projects/runners_controller_spec.rb | 2 +- .../projects/services_controller_spec.rb | 2 +- .../settings/ci_cd_controller_spec.rb | 6 +- .../settings/integrations_controller_spec.rb | 2 +- .../settings/repository_controller_spec.rb | 2 +- .../projects/snippets_controller_spec.rb | 6 +- .../projects/templates_controller_spec.rb | 2 +- .../projects/todos_controller_spec.rb | 133 +- .../projects/tree_controller_spec.rb | 2 +- .../projects/variables_controller_spec.rb | 2 +- .../projects/wikis_controller_spec.rb | 124 +- spec/controllers/projects_controller_spec.rb | 12 +- spec/controllers/sessions_controller_spec.rb | 4 +- spec/controllers/uploads_controller_spec.rb | 29 +- spec/controllers/users_controller_spec.rb | 64 +- spec/factories/ci/builds.rb | 6 + spec/factories/ci/job_artifacts.rb | 44 + spec/factories/ci/pipelines.rb | 12 + spec/factories/clusters/applications/helm.rb | 16 +- spec/factories/clusters/clusters.rb | 4 + spec/factories/group_members.rb | 2 +- spec/factories/issues.rb | 2 +- spec/factories/merge_requests.rb | 18 +- spec/factories/notes.rb | 1 + spec/factories/programming_languages.rb | 6 + spec/factories/project_members.rb | 4 +- spec/factories/projects.rb | 4 +- spec/factories/protected_branches.rb | 8 +- spec/factories/protected_tags.rb | 6 +- spec/factories/repository_languages.rb | 7 + spec/factories/resource_label_events.rb | 10 + spec/factories/site_statistics.rb | 7 + spec/factories/todos.rb | 4 +- spec/factories/user_statuses.rb | 9 + spec/features/admin/admin_cohorts_spec.rb | 15 - spec/features/admin/admin_groups_spec.rb | 2 +- spec/features/admin/admin_labels_spec.rb | 2 +- spec/features/admin/admin_projects_spec.rb | 4 +- spec/features/admin/admin_settings_spec.rb | 2 +- spec/features/admin/admin_users_spec.rb | 38 + spec/features/atom/dashboard_issues_spec.rb | 4 +- spec/features/atom/dashboard_spec.rb | 2 +- spec/features/atom/users_spec.rb | 2 +- spec/features/boards/add_issues_modal_spec.rb | 2 +- spec/features/boards/boards_spec.rb | 4 +- spec/features/boards/issue_ordering_spec.rb | 2 +- spec/features/boards/modal_filter_spec.rb | 2 +- spec/features/boards/new_issue_spec.rb | 2 +- spec/features/boards/sidebar_spec.rb | 2 +- .../features/boards/sub_group_project_spec.rb | 2 +- spec/features/commits_spec.rb | 8 +- spec/features/cycle_analytics_spec.rb | 6 +- spec/features/dashboard/active_tab_spec.rb | 28 +- spec/features/dashboard/activity_spec.rb | 2 +- .../dashboard/archived_projects_spec.rb | 4 +- .../dashboard/datetime_on_tooltips_spec.rb | 4 +- .../dashboard/instance_statistics_spec.rb | 60 + spec/features/dashboard/issues_filter_spec.rb | 2 +- spec/features/dashboard/issues_spec.rb | 2 +- .../features/dashboard/merge_requests_spec.rb | 4 +- .../features/dashboard/milestone_tabs_spec.rb | 2 +- spec/features/dashboard/milestones_spec.rb | 2 +- .../project_member_activity_index_spec.rb | 2 +- spec/features/dashboard/projects_spec.rb | 6 +- .../dashboard/user_filters_projects_spec.rb | 2 +- .../discussion_comments/commit_spec.rb | 2 +- .../discussion_comments/issue_spec.rb | 2 +- .../discussion_comments/merge_request_spec.rb | 2 +- .../discussion_comments/snippets_spec.rb | 2 +- spec/features/explore/groups_list_spec.rb | 4 +- spec/features/global_search_spec.rb | 2 +- spec/features/group_variables_spec.rb | 2 +- spec/features/groups/activity_spec.rb | 2 +- spec/features/groups/board_spec.rb | 35 + spec/features/groups/empty_states_spec.rb | 2 +- spec/features/groups/issues_spec.rb | 7 +- .../groups/members/filter_members_spec.rb | 2 +- .../groups/members/list_members_spec.rb | 14 +- .../master_manages_access_requests_spec.rb | 4 +- .../groups/members/request_access_spec.rb | 2 +- spec/features/groups/milestone_spec.rb | 2 +- .../groups/milestones_sorting_spec.rb | 2 +- spec/features/groups_spec.rb | 6 + spec/features/ics/dashboard_issues_spec.rb | 2 +- spec/features/ide_spec.rb | 2 +- spec/features/import/manifest_import_spec.rb | 51 + .../instance_statistics/cohorts_spec.rb | 23 + .../conversational_development_index_spec.rb} | 18 +- spec/features/invites_spec.rb | 2 +- .../close_reopen_report_toggle_spec.rb | 4 +- spec/features/issues/award_emoji_spec.rb | 2 +- .../issues/bulk_assignment_labels_spec.rb | 2 +- ...e_for_discussions_in_merge_request_spec.rb | 2 +- ...single_discussion_in_merge_request_spec.rb | 2 +- .../filtered_search/dropdown_assignee_spec.rb | 8 +- .../filtered_search/dropdown_author_spec.rb | 8 +- .../filtered_search/dropdown_emoji_spec.rb | 2 +- .../filtered_search/dropdown_hint_spec.rb | 2 +- .../filtered_search/dropdown_label_spec.rb | 2 +- .../dropdown_milestone_spec.rb | 2 +- .../filtered_search/filter_issues_spec.rb | 2 +- .../issues/filtered_search/search_bar_spec.rb | 2 +- .../filtered_search/visual_tokens_spec.rb | 4 +- spec/features/issues/form_spec.rb | 6 +- spec/features/issues/gfm_autocomplete_spec.rb | 17 +- spec/features/issues/issue_sidebar_spec.rb | 2 +- spec/features/issues/spam_issues_spec.rb | 2 +- spec/features/issues/todo_spec.rb | 2 +- spec/features/issues/update_issues_spec.rb | 6 +- .../issues/user_uses_slash_commands_spec.rb | 6 +- spec/features/issues_spec.rb | 2 +- .../markdown/gitlab_flavored_markdown_spec.rb | 2 +- .../maintainer_edits_fork_spec.rb | 2 +- ...ommits_from_memebers_who_can_merge_spec.rb | 2 +- ...er_customizes_merge_commit_message_spec.rb | 2 +- .../user_merges_immediately_spec.rb | 2 +- ...r_merges_only_if_pipeline_succeeds_spec.rb | 2 +- ...user_merges_when_pipeline_succeeds_spec.rb | 2 +- .../user_posts_diff_notes_spec.rb | 6 +- .../merge_request/user_posts_notes_spec.rb | 2 +- ...diff_notes_and_discussions_resolve_spec.rb | 9 +- .../user_sees_avatar_on_diff_notes_spec.rb | 2 +- .../user_sees_check_out_branch_modal_spec.rb | 4 +- ...rb => user_sees_cherry_pick_modal_spec.rb} | 24 +- .../user_sees_closing_issues_message_spec.rb | 2 +- .../user_sees_deleted_target_branch_spec.rb | 2 +- .../user_sees_discussions_spec.rb | 2 +- .../user_sees_empty_state_spec.rb | 2 +- ...epending_on_unresolved_discussions_spec.rb | 2 +- .../user_sees_merge_widget_spec.rb | 232 +- .../merge_request/user_sees_pipelines_spec.rb | 4 +- .../merge_request/user_sees_versions_spec.rb | 2 +- .../user_sees_wip_help_message_spec.rb | 2 +- .../user_selects_branches_for_new_mr_spec.rb | 2 +- .../user_toggles_whitespace_changes_spec.rb | 2 +- .../user_uses_slash_commands_spec.rb | 4 +- .../merge_requests/user_mass_updates_spec.rb | 6 +- .../user_squashes_merge_request_spec.rb | 2 +- spec/features/milestone_spec.rb | 2 +- .../milestones/user_edits_milestone_spec.rb | 22 + spec/features/profiles/password_spec.rb | 2 +- .../profiles/user_edit_profile_spec.rb | 80 +- .../user_visits_notifications_tab_spec.rb | 2 +- .../profiles/user_visits_profile_spec.rb | 2 +- spec/features/project_variables_spec.rb | 2 +- spec/features/projects/actve_tabs_spec.rb | 2 +- ...ser_interacts_with_awards_in_issue_spec.rb | 2 +- spec/features/projects/badges/list_spec.rb | 2 +- .../features/projects/blobs/blob_show_spec.rb | 41 +- spec/features/projects/blobs/edit_spec.rb | 4 +- ...er_creates_new_blob_in_new_project_spec.rb | 4 +- .../branches/new_branch_ref_dropdown_spec.rb | 2 +- spec/features/projects/branches_spec.rb | 4 +- .../projects/clusters/applications_spec.rb | 18 +- spec/features/projects/clusters/gcp_spec.rb | 2 +- spec/features/projects/clusters/user_spec.rb | 2 +- spec/features/projects/clusters_spec.rb | 2 +- spec/features/projects/commit/builds_spec.rb | 2 +- .../projects/commit/cherry_pick_spec.rb | 2 +- .../projects/commit/diff_notes_spec.rb | 2 +- .../user_views_user_status_on_commit_spec.rb | 40 + .../commits/user_browses_commits_spec.rb | 3 +- spec/features/projects/compare_spec.rb | 2 +- spec/features/projects/deploy_keys_spec.rb | 2 +- .../features/projects/diffs/diff_show_spec.rb | 2 +- .../projects/environments/environment_spec.rb | 17 +- .../environments/environments_spec.rb | 16 +- .../projects/features_visibility_spec.rb | 4 +- ...project_owner_creates_license_file_spec.rb | 10 +- ...eate_license_file_in_empty_project_spec.rb | 6 +- .../files/template_selector_menu_spec.rb | 2 +- .../projects/files/user_browses_files_spec.rb | 3 - .../projects/files/user_creates_files_spec.rb | 2 +- .../projects/files/user_deletes_files_spec.rb | 2 +- .../projects/files/user_edits_files_spec.rb | 2 +- .../projects/files/user_find_file_spec.rb | 2 +- .../files/user_reads_pipeline_status_spec.rb | 2 +- .../files/user_replaces_files_spec.rb | 2 +- .../projects/files/user_uploads_files_spec.rb | 2 +- spec/features/projects/fork_spec.rb | 4 +- spec/features/projects/graph_spec.rb | 2 +- .../projects/hook_logs/user_reads_log_spec.rb | 2 +- .../import_file_object_storage_spec.rb | 103 + .../import_export/import_file_spec.rb | 1 + .../projects/issuable_templates_spec.rb | 2 +- .../projects/issues/user_views_issue_spec.rb | 18 + .../projects/jobs/permissions_spec.rb | 2 +- .../projects/jobs/user_browses_job_spec.rb | 2 +- .../projects/jobs/user_browses_jobs_spec.rb | 2 +- spec/features/projects/jobs_spec.rb | 10 +- .../projects/labels/search_labels_spec.rb | 80 + .../labels/user_creates_labels_spec.rb | 4 +- .../projects/labels/user_edits_labels_spec.rb | 2 +- .../labels/user_removes_labels_spec.rb | 2 +- .../anonymous_user_sees_members_spec.rb | 2 +- ...equest_access_to_his_group_project_spec.rb | 4 +- .../projects/members/group_members_spec.rb | 8 + .../members/groups_with_access_list_spec.rb | 2 +- ...r_adds_member_with_expiration_date_spec.rb | 8 +- .../master_manages_access_requests_spec.rb | 4 +- .../projects/members/share_with_group_spec.rb | 30 +- .../features/projects/members/sorting_spec.rb | 24 +- .../members/user_requests_access_spec.rb | 6 +- .../user_closes_merge_request_spec.rb | 2 +- .../user_comments_on_commit_spec.rb | 2 +- .../user_comments_on_diff_spec.rb | 2 +- .../user_comments_on_merge_request_spec.rb | 2 +- .../user_creates_merge_request_spec.rb | 2 +- .../user_edits_merge_request_spec.rb | 2 +- .../user_manages_subscription_spec.rb | 2 +- .../user_reopens_merge_request_spec.rb | 2 +- .../user_sorts_merge_requests_spec.rb | 2 +- .../user_views_open_merge_request_spec.rb | 2 +- ...views_user_status_on_merge_request_spec.rb | 36 + .../user_interacts_with_labels_spec.rb | 2 +- spec/features/projects/new_project_spec.rb | 29 +- spec/features/projects/pages_spec.rb | 2 +- .../projects/pipeline_schedules_spec.rb | 4 +- .../projects/pipelines/pipeline_spec.rb | 6 + .../projects/pipelines/pipelines_spec.rb | 4 +- spec/features/projects/remote_mirror_spec.rb | 6 +- .../services/user_activates_asana_spec.rb | 2 +- .../services/user_activates_assembla_spec.rb | 2 +- ...user_activates_atlassian_bamboo_ci_spec.rb | 2 +- .../user_activates_emails_on_push_spec.rb | 2 +- .../services/user_activates_flowdock_spec.rb | 2 +- .../services/user_activates_hipchat_spec.rb | 2 +- .../services/user_activates_irker_spec.rb | 2 +- .../user_activates_issue_tracker_spec.rb | 2 +- ...er_activates_jetbrains_teamcity_ci_spec.rb | 2 +- .../services/user_activates_jira_spec.rb | 2 +- ...activates_mattermost_slash_command_spec.rb | 2 +- .../services/user_activates_packagist_spec.rb | 2 +- .../user_activates_pivotaltracker_spec.rb | 2 +- .../user_activates_prometheus_spec.rb | 2 +- .../services/user_activates_pushover_spec.rb | 2 +- ...user_activates_slack_notifications_spec.rb | 4 +- ...user_activates_slack_slash_command_spec.rb | 2 +- .../services/user_views_services_spec.rb | 2 +- .../settings/forked_project_settings_spec.rb | 4 +- .../settings/integration_settings_spec.rb | 4 +- .../projects/settings/lfs_settings_spec.rb | 6 +- .../settings/pipelines_settings_spec.rb | 66 +- .../projects/settings/project_badges_spec.rb | 2 +- .../settings/repository_settings_spec.rb | 6 +- .../settings/user_archives_project_spec.rb | 2 +- .../settings/user_changes_avatar_spec.rb | 2 +- .../user_interacts_with_deploy_keys_spec.rb | 4 +- .../settings/user_manages_group_links_spec.rb | 4 +- .../user_manages_project_members_spec.rb | 6 +- .../settings/user_transfers_a_project_spec.rb | 9 +- .../settings/visibility_settings_spec.rb | 8 +- .../show/user_manages_notifications_spec.rb | 32 + ...user_sees_deletion_failure_message_spec.rb | 2 +- .../user_sees_setup_shortcut_buttons_spec.rb | 8 +- .../projects/snippets/create_snippet_spec.rb | 2 +- spec/features/projects/snippets/show_spec.rb | 14 +- .../snippets/user_comments_on_snippet_spec.rb | 2 +- .../snippets/user_deletes_snippet_spec.rb | 2 +- .../snippets/user_updates_snippet_spec.rb | 2 +- .../snippets/user_views_snippets_spec.rb | 2 +- .../projects/sub_group_issuables_spec.rb | 2 +- .../projects/tree/create_directory_spec.rb | 10 +- .../projects/tree/create_file_spec.rb | 6 +- spec/features/projects/tree/tree_show_spec.rb | 72 +- .../projects/tree/upload_file_spec.rb | 6 +- .../projects/user_uses_shortcuts_spec.rb | 4 +- .../projects/user_views_empty_project_spec.rb | 4 +- spec/features/projects/view_on_env_spec.rb | 2 +- .../projects/wiki/markdown_preview_spec.rb | 2 +- .../wiki/user_creates_wiki_page_spec.rb | 48 +- .../wiki/user_updates_wiki_page_spec.rb | 2 +- .../user_views_wiki_in_project_page_spec.rb | 2 +- .../wiki/user_views_wiki_page_spec.rb | 22 +- spec/features/projects_spec.rb | 71 +- spec/features/protected_branches_spec.rb | 4 +- spec/features/reportable_note/commit_spec.rb | 2 +- spec/features/reportable_note/issue_spec.rb | 2 +- .../reportable_note/merge_request_spec.rb | 2 +- .../features/reportable_note/snippets_spec.rb | 2 +- spec/features/runners_spec.rb | 14 +- .../search/user_searches_for_code_spec.rb | 2 +- .../search/user_searches_for_issues_spec.rb | 2 +- .../user_searches_for_merge_requests_spec.rb | 2 +- .../user_searches_for_milestones_spec.rb | 2 +- .../user_searches_for_wiki_pages_spec.rb | 2 +- .../user_uses_header_search_field_spec.rb | 4 - .../security/group/internal_access_spec.rb | 10 +- .../security/group/private_access_spec.rb | 10 +- .../security/group/public_access_spec.rb | 10 +- .../security/project/internal_access_spec.rb | 68 +- .../security/project/private_access_spec.rb | 62 +- .../security/project/public_access_spec.rb | 68 +- .../project/snippet/internal_access_spec.rb | 12 +- .../project/snippet/private_access_spec.rb | 8 +- .../project/snippet/public_access_spec.rb | 16 +- spec/features/signed_commits_spec.rb | 37 +- .../notes_on_personal_snippets_spec.rb | 11 + spec/features/snippets/show_spec.rb | 8 + spec/features/tags/master_creates_tag_spec.rb | 4 +- spec/features/tags/master_deletes_tag_spec.rb | 4 +- spec/features/tags/master_updates_tag_spec.rb | 4 +- spec/features/tags/master_views_tags_spec.rb | 4 +- spec/features/task_lists_spec.rb | 2 +- spec/features/triggers_spec.rb | 4 +- .../user_uploads_avatar_to_profile_spec.rb | 2 +- spec/features/user_sees_revert_modal_spec.rb | 28 + .../users/add_email_to_existing_account.rb | 15 + spec/features/users/login_spec.rb | 241 +- spec/features/users/show_spec.rb | 84 +- ...user_browses_projects_on_user_page_spec.rb | 6 +- spec/finders/access_requests_finder_spec.rb | 4 +- spec/finders/admin/projects_finder_spec.rb | 2 +- .../finder_with_cross_project_access_spec.rb | 2 +- .../contributed_projects_finder_spec.rb | 4 +- spec/finders/environments_finder_spec.rb | 2 +- spec/finders/group_members_finder_spec.rb | 24 +- spec/finders/group_projects_finder_spec.rb | 18 +- spec/finders/issues_finder_spec.rb | 2 +- spec/finders/joined_groups_finder_spec.rb | 12 +- spec/finders/labels_finder_spec.rb | 18 +- spec/finders/members_finder_spec.rb | 12 +- spec/finders/merge_requests_finder_spec.rb | 4 +- spec/finders/move_to_project_finder_spec.rb | 22 +- spec/finders/notes_finder_spec.rb | 2 +- spec/finders/personal_projects_finder_spec.rb | 2 +- spec/finders/projects_finder_spec.rb | 4 +- spec/finders/todos_finder_spec.rb | 38 + .../finders/user_recent_events_finder_spec.rb | 15 +- spec/fixtures/aosp_manifest.xml | 685 ++ .../entities/merge_request_widget.json | 6 +- .../api/schemas/entities/test_case.json | 15 + .../entities/test_reports_comparer.json | 26 + .../schemas/entities/test_suite_comparer.json | 32 + spec/fixtures/api/schemas/pipeline.json | 4 + .../schemas/public_api/v4/pipeline/basic.json | 6 +- .../api/schemas/public_api/v4/projects.json | 15 +- spec/fixtures/emails/commands_in_reply.eml | 2 +- spec/fixtures/emails/commands_only_reply.eml | 2 +- ...ubaddressing_and_key_inside_references.eml | 2 +- ...and_key_inside_references_with_a_comma.eml | 2 +- .../emails/update_commands_only_reply.eml | 2 +- spec/fixtures/emails/valid_reply.eml | 2 +- .../bitbucket_server/activities.json | 1121 +++ .../bitbucket_server/pull_request.json | 146 + spec/fixtures/junit/junit.xml | 32 + spec/fixtures/junit/junit.xml.gz | Bin 0 -> 568 bytes spec/fixtures/junit/junit_ant.xml.gz | Bin 0 -> 1659 bytes .../junit/junit_with_corrupted_data.xml.gz | Bin 0 -> 461 bytes .../junit/junit_with_three_testsuites.xml.gz | Bin 0 -> 10106 bytes .../junit/junit_with_three_testsuites_1.xml | 8 + .../junit/junit_with_three_testsuites_2.xml | 6010 +++++++++++++++++ .../junit/junit_with_three_testsuites_3.xml | 8 + spec/fixtures/trace/sample_trace | 32 +- spec/graphql/gitlab_schema_spec.rb | 2 - .../mutations/resolves_project_spec.rb | 19 + .../mutations/merge_requests/set_wip_spec.rb | 51 + spec/graphql/types/mutation_type_spec.rb | 9 + spec/helpers/blob_helper_spec.rb | 4 +- spec/helpers/button_helper_spec.rb | 6 +- spec/helpers/icons_helper_spec.rb | 23 + spec/helpers/issuables_helper_spec.rb | 21 + spec/helpers/markup_helper_spec.rb | 2 +- spec/helpers/namespaces_helper_spec.rb | 48 + spec/helpers/notes_helper_spec.rb | 16 +- spec/helpers/projects_helper_spec.rb | 27 - spec/helpers/search_helper_spec.rb | 14 + spec/helpers/snippets_helper_spec.rb | 4 +- spec/helpers/time_helper_spec.rb | 10 +- spec/helpers/users_helper_spec.rb | 16 +- spec/helpers/visibility_level_helper_spec.rb | 23 + spec/javascripts/.eslintrc.yml | 1 - spec/javascripts/autosave_spec.js | 10 +- spec/javascripts/avatar_helper_spec.js | 98 + spec/javascripts/boards/boards_store_spec.js | 22 + spec/javascripts/boards/issue_card_spec.js | 154 +- .../clusters/clusters_bundle_spec.js | 36 +- .../components/application_row_spec.js | 49 +- .../clusters/services/mock_data.js | 27 +- .../clusters/stores/clusters_store_spec.js | 4 +- spec/javascripts/datetime_utility_spec.js | 1 - .../diffs/components/diff_file_header_spec.js | 46 +- .../diff_line_gutter_content_spec.js | 6 +- .../components/diff_line_note_form_spec.js | 41 +- spec/javascripts/diffs/store/getters_spec.js | 116 + .../environments/environment_item_spec.js | 2 +- .../environments/environment_rollback_spec.js | 4 +- .../environments/environment_stop_spec.js | 12 +- spec/javascripts/environments/mock_data.js | 12 +- spec/javascripts/fixtures/commit.rb | 2 +- spec/javascripts/fixtures/groups.rb | 2 +- spec/javascripts/fixtures/projects.rb | 2 +- .../fixtures/search_autocomplete.html.haml | 6 +- .../frequent_items/store/actions_spec.js | 4 +- spec/javascripts/gpg_badges_spec.js | 76 +- .../helpers/vue_mount_component_helper.js | 10 + .../javascripts/helpers/vuex_action_helper.js | 112 +- .../helpers/vuex_action_helper_spec.js | 166 + spec/javascripts/helpers/wait_for_promises.js | 1 + .../ide/components/activity_bar_spec.js | 20 - .../ide/components/branches/item_spec.js | 53 + .../components/branches/search_list_spec.js | 79 + .../ide/components/changed_file_icon_spec.js | 8 +- .../commit_sidebar/list_item_spec.js | 16 +- spec/javascripts/ide/components/ide_spec.js | 27 + .../ide/components/ide_status_bar_spec.js | 26 + .../jobs/detail/description_spec.js | 2 +- .../ide/components/jobs/item_spec.js | 2 +- .../merge_requests/dropdown_spec.js | 47 - .../components/merge_requests/item_spec.js | 15 +- .../components/merge_requests/list_spec.js | 112 +- .../components/nav_dropdown_button_spec.js | 63 + .../ide/components/nav_dropdown_spec.js | 50 + .../components/new_dropdown/button_spec.js | 49 + .../ide/components/new_dropdown/index_spec.js | 61 +- .../ide/components/new_dropdown/modal_spec.js | 73 +- .../components/new_dropdown/upload_spec.js | 3 - .../ide/components/panes/right_spec.js | 13 + .../ide/components/preview/clientside_spec.js | 364 + .../ide/components/preview/navigator_spec.js | 185 + .../ide/components/repo_editor_spec.js | 3 + .../ide/components/repo_file_spec.js | 19 - .../ide/components/repo_tab_spec.js | 4 +- .../components/shared/tokened_input_spec.js | 132 + spec/javascripts/ide/helpers.js | 2 + spec/javascripts/ide/ide_router_spec.js | 44 + spec/javascripts/ide/mock_data.js | 41 +- .../ide/stores/actions/file_spec.js | 25 +- .../ide/stores/actions/project_spec.js | 15 +- .../ide/stores/actions/tree_spec.js | 7 +- spec/javascripts/ide/stores/actions_spec.js | 71 + spec/javascripts/ide/stores/getters_spec.js | 10 + .../stores/modules/branches/actions_spec.js | 193 + .../stores/modules/branches/mutations_spec.js | 51 + .../ide/stores/modules/commit/actions_spec.js | 6 +- .../ide/stores/modules/commit/getters_spec.js | 16 + .../modules/merge_requests/actions_spec.js | 86 +- .../modules/merge_requests/mutations_spec.js | 19 +- .../stores/modules/pipelines/actions_spec.js | 6 +- .../ide/stores/mutations/file_spec.js | 64 + spec/javascripts/ide/stores/mutations_spec.js | 157 + spec/javascripts/ide/stores/utils_spec.js | 62 + .../javascripts/issuable_time_tracker_spec.js | 201 - .../issue_show/components/app_spec.js | 4 +- .../issue_show/components/edited_spec.js | 6 +- spec/javascripts/job_spec.js | 27 +- spec/javascripts/jobs/header_spec.js | 2 +- spec/javascripts/jobs/mock_data.js | 4 +- .../lib/utils/common_utils_spec.js | 19 + spec/javascripts/lib/utils/poll_spec.js | 39 +- .../lib/utils/text_utility_spec.js | 17 + .../components/discussion_counter_spec.js | 2 +- .../components/noteable_discussion_spec.js | 56 +- spec/javascripts/notes/mock_data.js | 84 + spec/javascripts/notes/stores/getters_spec.js | 155 + .../pages/profiles/show/emoji_menu_spec.js | 117 + spec/javascripts/pdf/page_spec.js | 2 +- .../components/performance_bar_app_spec.js | 61 +- .../javascripts/performance_bar/index_spec.js | 83 + .../graph/dropdown_job_component_spec.js | 6 +- .../pipelines/graph/job_component_spec.js | 8 +- .../graph/job_name_component_spec.js | 2 +- spec/javascripts/pipelines/graph/mock_data.js | 18 +- .../graph/stage_column_component_spec.js | 2 +- .../pipelines/header_component_spec.js | 2 +- .../pipelines/pipeline_url_spec.js | 26 +- spec/javascripts/pipelines/stage_spec.js | 4 +- .../grouped_test_reports_app_spec.js | 199 + .../reports/components/modal_spec.js | 45 + .../components/test_issue_body_spec.js | 71 + .../reports/mock_data/mock_data.js | 8 + .../new_and_fixed_failures_report.json | 1 + .../mock_data/new_failures_report.json | 1 + .../reports/mock_data/no_failures_report.json | 1 + .../reports/mock_data/resolved_failures.json | 37 + .../javascripts/reports/store/actions_spec.js | 171 + .../reports/store/mutations_spec.js | 124 + spec/javascripts/reports/store/utils_spec.js | 138 + spec/javascripts/sidebar/assignees_spec.js | 8 +- .../time_tracking/time_tracker_spec.js | 232 + spec/javascripts/sidebar/todo_spec.js | 158 + spec/javascripts/smart_interval_spec.js | 203 +- spec/javascripts/test_bundle.js | 32 +- .../components/mr_widget_header_spec.js | 37 +- spec/javascripts/vue_mr_widget/mock_data.js | 8 +- .../vue_shared/components/bar_chart_spec.js | 85 + .../vue_shared/components/ci_icon_spec.js | 20 +- .../components/clipboard_button_spec.js | 56 +- .../vue_shared/components/code_block_spec.js | 33 + .../viewers/image_diff_viewer_spec.js | 2 - .../dropdown/dropdown_button_spec.js | 15 +- .../vue_shared/components/gl_modal_spec.js | 34 +- .../components/header_ci_component_spec.js | 2 +- .../vue_shared/components/icon_spec.js | 17 +- .../vue_shared/components/identicon_spec.js | 17 +- .../components/memory_graph_spec.js | 2 +- .../components/notes/placeholder_note_spec.js | 2 +- .../components/notes/system_note_spec.js | 2 +- .../components/panel_resizer_spec.js | 4 +- .../components/project_avatar/default_spec.js | 58 + .../reports/modal_open_name_spec.js | 45 + .../components/reports/report_link_spec.js | 71 + .../components/reports/report_section_spec.js | 197 + .../components/reports/summary_row_spec.js | 37 + .../components/stacked_progress_bar_spec.js | 14 +- .../user_avatar/user_avatar_image_spec.js | 30 +- spec/lib/backup/repository_spec.rb | 44 +- .../filter/image_lazy_load_filter_spec.rb | 14 + .../lib/banzai/filter/redactor_filter_spec.rb | 2 +- .../banzai/pipeline/emoji_pipeline_spec.rb | 21 + spec/lib/bitbucket_server/client_spec.rb | 88 + spec/lib/bitbucket_server/connection_spec.rb | 68 + spec/lib/bitbucket_server/page_spec.rb | 51 + spec/lib/bitbucket_server/paginator_spec.rb | 35 + .../representation/activity_spec.rb | 38 + .../representation/comment_spec.rb | 55 + .../pull_request_comment_spec.rb | 48 + .../representation/pull_request_spec.rb | 79 + .../representation/repo_spec.rb | 80 + spec/lib/extracts_path_spec.rb | 26 + spec/lib/feature_spec.rb | 32 +- spec/lib/gitlab/auth/activity_spec.rb | 30 + .../gitlab/auth/blocked_user_tracker_spec.rb | 68 +- spec/lib/gitlab/auth/o_auth/provider_spec.rb | 42 + .../delete_diff_files_spec.rb | 62 +- ...ze_merge_request_diffs_and_commits_spec.rb | 22 +- .../digest_column_spec.rb | 46 + .../move_personal_snippet_files_spec.rb | 2 +- .../background_migration/redact_links_spec.rb | 96 + .../remove_restricted_todos_spec.rb | 124 + .../schedule_diff_files_deletion_spec.rb | 43 + .../bare_repository_import/importer_spec.rb | 54 +- .../bitbucket_server_import/importer_spec.rb | 291 + spec/lib/gitlab/checks/change_access_spec.rb | 14 +- .../build/artifacts/gzip_file_adapter_spec.rb | 56 + .../ci/build/artifacts/metadata_spec.rb | 24 +- .../gitlab/ci/config/entry/artifacts_spec.rb | 17 + .../gitlab/ci/config/entry/commands_spec.rb | 3 +- .../gitlab/ci/config/entry/reports_spec.rb | 53 + spec/lib/gitlab/ci/parsers/junit_spec.rb | 118 + spec/lib/gitlab/ci/parsers_spec.rb | 23 + .../pipeline/chain/validate/abilities_spec.rb | 4 +- spec/lib/gitlab/ci/reports/test_case_spec.rb | 90 + .../ci/reports/test_reports_comparer_spec.rb | 134 + .../gitlab/ci/reports/test_reports_spec.rb | 132 + .../ci/reports/test_suite_comparer_spec.rb | 225 + spec/lib/gitlab/ci/reports/test_suite_spec.rb | 120 + .../lib/gitlab/ci/status/build/failed_spec.rb | 27 + spec/lib/gitlab/ci/status/build/play_spec.rb | 2 +- .../lib/gitlab/ci/status/stage/common_spec.rb | 2 +- .../ci/variables/collection/item_spec.rb | 8 + .../gitlab/cleanup/project_uploads_spec.rb | 278 + .../lib/gitlab/cleanup/remote_uploads_spec.rb | 74 + .../gitlab/closing_issue_extractor_spec.rb | 18 +- .../cycle_analytics/permissions_spec.rb | 4 +- .../v1/rename_namespaces_spec.rb | 2 +- .../v1/rename_projects_spec.rb | 2 +- spec/lib/gitlab/database_spec.rb | 86 + .../additional_headers_interceptor_spec.rb} | 2 +- .../hook/delivery_metrics_observer_spec.rb | 35 + .../hook}/disable_email_interceptor_spec.rb | 2 +- .../git/attributes_at_ref_parser_spec.rb | 2 +- spec/lib/gitlab/git/attributes_parser_spec.rb | 2 +- spec/lib/gitlab/git/blame_spec.rb | 2 +- spec/lib/gitlab/git/blob_snippet_spec.rb | 2 +- spec/lib/gitlab/git/blob_spec.rb | 203 +- spec/lib/gitlab/git/branch_spec.rb | 10 +- spec/lib/gitlab/git/commit_spec.rb | 20 +- .../gitlab/git/committer_with_hooks_spec.rb | 2 +- spec/lib/gitlab/git/compare_spec.rb | 2 +- spec/lib/gitlab/git/diff_collection_spec.rb | 2 +- spec/lib/gitlab/git/diff_spec.rb | 11 +- spec/lib/gitlab/git/hooks_service_spec.rb | 2 +- spec/lib/gitlab/git/index_spec.rb | 18 +- spec/lib/gitlab/git/popen_spec.rb | 30 + spec/lib/gitlab/git/remote_repository_spec.rb | 2 +- spec/lib/gitlab/git/repository_spec.rb | 420 +- spec/lib/gitlab/git/rev_list_spec.rb | 96 - spec/lib/gitlab/git/tag_spec.rb | 2 +- spec/lib/gitlab/git/tree_spec.rb | 2 +- spec/lib/gitlab/git/wiki_spec.rb | 25 + spec/lib/gitlab/git_access_spec.rb | 64 +- spec/lib/gitlab/gitaly_client/diff_spec.rb | 6 +- .../gitaly_client/operation_service_spec.rb | 41 + .../gitlab/gitaly_client/ref_service_spec.rb | 38 + .../gitaly_client/storage_service_spec.rb | 13 + .../gitlab/gitaly_client/wiki_service_spec.rb | 22 + .../importer/pull_requests_importer_spec.rb | 6 +- spec/lib/gitlab/gitlab_import/client_spec.rb | 84 + .../google_code_import/importer_spec.rb | 2 +- .../gpg/invalid_gpg_signature_updater_spec.rb | 4 +- .../authorize/authorize_resource_spec.rb | 103 + spec/lib/gitlab/graphql/authorize_spec.rb | 20 + spec/lib/gitlab/graphs/commits_spec.rb | 2 +- .../gitlab/hashed_storage/migrator_spec.rb | 2 +- .../lib/gitlab/hook_data/base_builder_spec.rb | 64 + .../gitlab/hook_data/issue_builder_spec.rb | 9 + .../hook_data/merge_request_builder_spec.rb | 9 + .../lib/gitlab/{ci/trace => }/http_io_spec.rb | 43 +- spec/lib/gitlab/import_export/all_models.yml | 5 + .../file_importer_object_storage_spec.rb | 89 + .../import_export/file_importer_spec.rb | 4 +- .../importer_object_storage_spec.rb | 115 + .../lib/gitlab/import_export/importer_spec.rb | 5 +- .../import_export/members_mapper_spec.rb | 2 +- .../project_tree_restorer_spec.rb | 2 +- .../import_export/project_tree_saver_spec.rb | 6 +- .../gitlab/import_export/repo_saver_spec.rb | 2 +- .../import_export/wiki_repo_saver_spec.rb | 2 +- spec/lib/gitlab/import_sources_spec.rb | 33 +- spec/lib/gitlab/json_logger_spec.rb | 29 + spec/lib/gitlab/kubernetes/config_map_spec.rb | 10 +- spec/lib/gitlab/kubernetes/helm/api_spec.rb | 14 +- .../kubernetes/helm/base_command_spec.rb | 28 +- .../kubernetes/helm/certificate_spec.rb | 28 + .../kubernetes/helm/init_command_spec.rb | 4 +- .../kubernetes/helm/install_command_spec.rb | 75 +- spec/lib/gitlab/kubernetes/helm/pod_spec.rb | 29 +- spec/lib/gitlab/kubernetes_spec.rb | 15 + spec/lib/gitlab/language_detection_spec.rb | 85 + .../gitlab/manifest_import/manifest_spec.rb | 46 + .../manifest_import/project_creator_spec.rb | 33 + .../middleware/basic_health_check_spec.rb | 57 + spec/lib/gitlab/middleware/go_spec.rb | 2 +- spec/lib/gitlab/popen_spec.rb | 13 + .../lib/gitlab/project_authorizations_spec.rb | 6 +- .../lib/gitlab/project_search_results_spec.rb | 55 +- spec/lib/gitlab/sanitizers/svg_spec.rb | 4 +- .../gitlab/serializer/ci/variables_spec.rb | 6 +- spec/lib/gitlab/shell_spec.rb | 111 +- .../gitlab/slash_commands/issue_move_spec.rb | 2 +- .../gitlab/slash_commands/issue_new_spec.rb | 2 +- .../slash_commands/issue_search_spec.rb | 2 +- .../gitlab/slash_commands/issue_show_spec.rb | 2 +- spec/lib/gitlab/url_sanitizer_spec.rb | 7 +- spec/lib/gitlab/usage_data_spec.rb | 2 +- spec/lib/gitlab/user_access_spec.rb | 40 +- spec/lib/gitlab/user_activities_spec.rb | 127 - spec/lib/gitlab/workhorse_spec.rb | 152 +- spec/mailers/notify_spec.rb | 33 +- ...nfidential_note_events_on_services_spec.rb | 2 +- ...rom_notification_settings_to_users_spec.rb | 36 + .../enqueue_delete_diff_files_workers_spec.rb | 17 + spec/migrations/enqueue_redact_links_spec.rb | 42 + .../generate_missing_routes_spec.rb | 84 + .../issues_moved_to_id_foreign_key_spec.rb | 2 +- ...ters_to_new_clusters_architectures_spec.rb | 6 +- ...migrate_process_commit_worker_jobs_spec.rb | 66 +- ...e_stage_id_reference_in_background_spec.rb | 2 +- .../migrate_stages_statuses_spec.rb | 2 +- .../normalize_ldap_extern_uids_spec.rb | 10 +- ...eate_gpg_key_subkeys_from_gpg_keys_spec.rb | 2 +- ...dule_digest_personal_access_tokens_spec.rb | 46 + ...dule_merge_request_diff_migrations_spec.rb | 2 +- ...e_request_diff_migrations_take_two_spec.rb | 2 +- ...t_merge_request_diff_id_migrations_spec.rb | 2 +- ...nfidential_note_events_on_webhooks_spec.rb | 2 +- spec/models/ci/build_metadata_spec.rb | 2 +- spec/models/ci/build_runner_session_spec.rb | 2 +- spec/models/ci/build_spec.rb | 324 +- spec/models/ci/build_trace_chunk_spec.rb | 4 +- spec/models/ci/job_artifact_spec.rb | 80 +- spec/models/ci/pipeline_spec.rb | 79 + .../models/clusters/applications/helm_spec.rb | 26 +- .../clusters/applications/ingress_spec.rb | 66 +- .../clusters/applications/jupyter_spec.rb | 70 +- .../clusters/applications/prometheus_spec.rb | 119 +- .../clusters/applications/runner_spec.rb | 88 +- spec/models/concerns/avatarable_spec.rb | 4 + ...tch_destroy_dependent_associations_spec.rb | 4 +- spec/models/concerns/issuable_spec.rb | 8 +- spec/models/concerns/mentionable_spec.rb | 6 +- .../concerns/protected_ref_access_spec.rb | 10 +- spec/models/concerns/reactive_caching_spec.rb | 15 + spec/models/concerns/redactable_spec.rb | 69 + .../concerns/resolvable_discussion_spec.rb | 2 +- spec/models/concerns/routable_spec.rb | 35 +- .../concerns/token_authenticatable_spec.rb | 272 +- spec/models/deploy_token_spec.rb | 17 +- spec/models/deployment_spec.rb | 18 - spec/models/environment_spec.rb | 19 +- spec/models/group_spec.rb | 50 +- spec/models/hooks/system_hook_spec.rb | 8 +- spec/models/internal_id_spec.rb | 66 + spec/models/issue_spec.rb | 2 +- spec/models/label_spec.rb | 16 + spec/models/lfs_file_lock_spec.rb | 12 +- spec/models/member_spec.rb | 86 +- spec/models/members/group_member_spec.rb | 2 +- spec/models/members/project_member_spec.rb | 10 +- spec/models/merge_request_diff_spec.rb | 7 + spec/models/merge_request_spec.rb | 261 +- spec/models/milestone_spec.rb | 20 + spec/models/namespace_spec.rb | 42 +- spec/models/note_spec.rb | 6 +- spec/models/notification_setting_spec.rb | 8 +- spec/models/personal_access_token_spec.rb | 28 +- .../postgresql/replication_slot_spec.rb | 31 + spec/models/programming_language_spec.rb | 11 + spec/models/project_authorization_spec.rb | 6 +- spec/models/project_feature_spec.rb | 44 +- .../hangouts_chat_service_spec.rb | 246 + .../project_services/hipchat_service_spec.rb | 18 + .../project_services/jira_service_spec.rb | 53 +- spec/models/project_spec.rb | 139 +- spec/models/project_statistics_spec.rb | 6 + spec/models/project_team_spec.rb | 108 +- spec/models/project_wiki_spec.rb | 26 +- .../merge_access_level_spec.rb | 2 +- .../push_access_level_spec.rb | 2 +- spec/models/remote_mirror_spec.rb | 8 +- spec/models/repository_language_spec.rb | 16 + spec/models/repository_spec.rb | 85 +- spec/models/resource_label_event_spec.rb | 48 + spec/models/route_spec.rb | 14 +- spec/models/service_spec.rb | 2 +- spec/models/site_statistic_spec.rb | 83 + spec/models/spam_log_spec.rb | 2 +- spec/models/todo_spec.rb | 1 + spec/models/user_spec.rb | 130 +- spec/models/user_status_spec.rb | 20 + spec/models/wiki_page_spec.rb | 10 + spec/policies/ci/build_policy_spec.rb | 10 +- .../ci/pipeline_schedule_policy_spec.rb | 8 +- spec/policies/ci/trigger_policy_spec.rb | 12 +- spec/policies/clusters/cluster_policy_spec.rb | 4 +- spec/policies/concerns/policy_actor_spec.rb | 13 + spec/policies/deploy_key_policy_spec.rb | 2 +- spec/policies/deploy_token_policy_spec.rb | 12 +- spec/policies/environment_policy_spec.rb | 128 +- spec/policies/global_policy_spec.rb | 38 +- spec/policies/group_policy_spec.rb | 42 +- spec/policies/project_policy_spec.rb | 30 +- spec/policies/protected_branch_policy_spec.rb | 4 +- spec/policies/user_policy_spec.rb | 4 + .../ci/build_runner_presenter_spec.rb | 86 + .../commit_status_presenter_spec.rb | 26 + .../merge_request_presenter_spec.rb | 17 +- spec/presenters/project_presenter_spec.rb | 8 +- spec/requests/api/access_requests_spec.rb | 40 +- spec/requests/api/award_emoji_spec.rb | 2 +- spec/requests/api/badges_spec.rb | 54 +- spec/requests/api/branches_spec.rb | 16 +- spec/requests/api/commits_spec.rb | 64 +- spec/requests/api/deployments_spec.rb | 2 +- spec/requests/api/environments_spec.rb | 8 +- spec/requests/api/files_spec.rb | 30 + .../mutations/merge_requests/set_wip_spec.rb | 68 + spec/requests/api/group_variables_spec.rb | 10 +- spec/requests/api/groups_spec.rb | 54 +- spec/requests/api/helpers_spec.rb | 2 +- spec/requests/api/internal_spec.rb | 83 +- spec/requests/api/issues_spec.rb | 34 +- spec/requests/api/jobs_spec.rb | 15 +- spec/requests/api/labels_spec.rb | 2 +- spec/requests/api/members_spec.rb | 203 +- spec/requests/api/merge_request_diffs_spec.rb | 2 +- spec/requests/api/merge_requests_spec.rb | 1 + spec/requests/api/namespaces_spec.rb | 12 +- spec/requests/api/notes_spec.rb | 6 +- spec/requests/api/pages_domains_spec.rb | 28 +- spec/requests/api/pipeline_schedules_spec.rb | 24 +- spec/requests/api/pipelines_spec.rb | 5 +- spec/requests/api/project_export_spec.rb | 38 +- spec/requests/api/project_hooks_spec.rb | 4 +- spec/requests/api/project_import_spec.rb | 10 +- spec/requests/api/projects_spec.rb | 103 +- spec/requests/api/protected_branches_spec.rb | 34 +- spec/requests/api/repositories_spec.rb | 2 +- spec/requests/api/runner_spec.rb | 54 +- spec/requests/api/runners_spec.rb | 71 +- spec/requests/api/settings_spec.rb | 5 +- spec/requests/api/tags_spec.rb | 20 +- spec/requests/api/todos_spec.rb | 14 +- spec/requests/api/triggers_spec.rb | 2 +- spec/requests/api/users_spec.rb | 118 +- spec/requests/api/variables_spec.rb | 2 +- spec/requests/api/wikis_spec.rb | 62 +- spec/requests/git_http_spec.rb | 25 +- spec/requests/jwt_controller_spec.rb | 19 + spec/requests/lfs_http_spec.rb | 58 +- spec/requests/lfs_locks_api_spec.rb | 6 +- .../instance_statistics_routing_spec.rb | 11 + spec/serializers/deploy_key_entity_spec.rb | 4 +- spec/serializers/environment_entity_spec.rb | 3 +- .../environment_serializer_spec.rb | 10 +- spec/serializers/group_child_entity_spec.rb | 2 +- .../merge_request_widget_entity_spec.rb | 15 + spec/serializers/pipeline_serializer_spec.rb | 4 +- spec/serializers/test_case_entity_spec.rb | 31 + .../test_reports_comparer_entity_spec.rb | 76 + .../test_reports_comparer_serializer_spec.rb | 62 + .../test_suite_comparer_entity_spec.rb | 86 + ...er_registry_authentication_service_spec.rb | 144 +- .../ci/compare_test_reports_service_spec.rb | 75 + .../ci/create_pipeline_service_spec.rb | 8 +- spec/services/ci/register_job_service_spec.rb | 33 + spec/services/ci/retry_build_service_spec.rb | 18 +- .../ci/retry_pipeline_service_spec.rb | 4 +- .../ci/stop_environments_service_spec.rb | 2 +- ...heck_installation_progress_service_spec.rb | 2 +- .../applications/install_service_spec.rb | 2 +- .../discussions/resolve_service_spec.rb | 2 +- spec/services/event_create_service_spec.rb | 4 +- spec/services/files/create_service_spec.rb | 2 +- spec/services/files/delete_service_spec.rb | 2 +- spec/services/files/multi_service_spec.rb | 2 +- spec/services/files/update_service_spec.rb | 2 +- spec/services/git_push_service_spec.rb | 78 +- spec/services/groups/destroy_service_spec.rb | 2 +- spec/services/groups/update_service_spec.rb | 32 +- spec/services/issues/close_service_spec.rb | 2 +- spec/services/issues/create_service_spec.rb | 16 +- spec/services/issues/reopen_service_spec.rb | 4 +- spec/services/issues/update_service_spec.rb | 25 +- spec/services/lfs/unlock_file_service_spec.rb | 6 +- .../approve_access_request_service_spec.rb | 6 +- spec/services/members/create_service_spec.rb | 2 +- spec/services/members/destroy_service_spec.rb | 15 +- spec/services/members/update_service_spec.rb | 6 +- .../merge_requests/close_service_spec.rb | 2 +- .../conflicts/list_service_spec.rb | 2 +- .../merge_requests/create_service_spec.rb | 20 +- .../merge_requests/ff_merge_service_spec.rb | 2 +- .../merge_requests/merge_service_spec.rb | 5 +- .../merge_requests/post_merge_service_spec.rb | 4 +- .../merge_requests/rebase_service_spec.rb | 2 +- .../merge_requests/reopen_service_spec.rb | 8 +- .../merge_requests/update_service_spec.rb | 2 +- .../services/milestones/close_service_spec.rb | 2 +- .../milestones/create_service_spec.rb | 2 +- .../milestones/destroy_service_spec.rb | 2 +- .../milestones/promote_service_spec.rb | 2 +- spec/services/notes/create_service_spec.rb | 2 +- .../notes/post_process_service_spec.rb | 2 +- .../notes/quick_actions_service_spec.rb | 20 +- spec/services/notes/update_service_spec.rb | 2 +- spec/services/notification_service_spec.rb | 108 +- .../create_from_template_service_spec.rb | 35 +- spec/services/projects/create_service_spec.rb | 15 +- .../services/projects/destroy_service_spec.rb | 14 +- ...etect_repository_languages_service_spec.rb | 54 + spec/services/projects/fork_service_spec.rb | 2 +- .../gitlab_projects_import_service_spec.rb | 56 +- .../migrate_attachments_service_spec.rb | 17 +- .../migrate_repository_service_spec.rb | 3 +- .../hashed_storage_migration_service_spec.rb | 18 +- .../projects/housekeeping_service_spec.rb | 2 +- .../projects/move_access_service_spec.rb | 12 +- ...ove_project_authorizations_service_spec.rb | 8 +- .../move_project_group_links_service_spec.rb | 8 +- .../move_project_members_service_spec.rb | 8 +- .../overwrite_project_service_spec.rb | 8 +- .../projects/transfer_service_spec.rb | 8 +- .../projects/update_pages_service_spec.rb | 18 +- spec/services/projects/update_service_spec.rb | 51 + .../protected_branches/create_service_spec.rb | 8 +- .../protected_tags/create_service_spec.rb | 4 +- .../reset_project_cache_service_spec.rb | 2 +- .../change_labels_service_spec.rb | 53 + spec/services/search/global_service_spec.rb | 2 +- spec/services/search_service_spec.rb | 2 +- spec/services/system_hooks_service_spec.rb | 2 +- .../confidential_issue_service_spec.rb | 43 + .../destroy/entity_leave_service_spec.rb | 290 + .../destroy/group_private_service_spec.rb | 69 + .../destroy/private_features_service_spec.rb | 143 + .../destroy/project_private_service_spec.rb | 43 + spec/services/users/activity_service_spec.rb | 83 +- spec/services/users/destroy_service_spec.rb | 2 +- ...efresh_authorized_projects_service_spec.rb | 30 +- .../services/users/set_status_service_spec.rb | 58 + spec/services/users/update_service_spec.rb | 21 + spec/spec_helper.rb | 2 +- .../api/repositories_shared_context.rb | 2 +- .../api/time_tracking_shared_examples.rb | 8 +- ...issuable_slash_commands_shared_examples.rb | 32 +- spec/support/generate-seed-repo-rb | 2 +- .../helpers/cycle_analytics_helpers.rb | 3 +- spec/support/helpers/graphql_helpers.rb | 61 +- spec/support/helpers/jira_service_helper.rb | 2 +- spec/support/helpers/key_generator_helper.rb | 2 +- spec/support/helpers/markdown_feature.rb | 2 +- .../helpers/reactive_caching_helpers.rb | 4 +- spec/support/helpers/seed_helper.rb | 6 - spec/support/helpers/stub_metrics.rb | 27 + spec/support/helpers/test_env.rb | 13 +- .../helpers/user_activities_helpers.rb | 7 - spec/support/http_io/http_io_helpers.rb | 60 +- .../import_export/export_file_helper.rb | 2 +- .../access_matchers_for_controller.rb | 2 +- spec/support/matchers/graphql_matchers.rb | 9 + .../matchers/metric_counter_matcher.rb | 11 + .../matchers/user_activity_matchers.rb | 5 - spec/support/matchers/user_status_matcher.rb | 13 + .../additional_metrics_shared_examples.rb | 7 +- spec/support/rspec.rb | 2 + ..._service_slash_commands_shared_examples.rb | 4 +- .../merge_requests_allowing_collaboration.rb | 15 + .../controllers/todos_shared_examples.rb | 43 + ...creatable_merge_request_shared_examples.rb | 6 +- .../editable_merge_request_shared_examples.rb | 6 +- ..._manages_access_requests_shared_example.rb | 14 +- .../shared_examples/helm_generated_script.rb | 2 +- ..._statistics_controllers_shared_examples.rb | 37 + .../models/atomic_internal_id_spec.rb | 14 + .../members_notifications_shared_example.rb | 2 +- .../shared_examples/notify_shared_examples.rb | 6 +- .../shared_examples/requests/api/notes.rb | 1 + .../requests/graphql_shared_examples.rb | 2 +- .../services/boards/issues_list_service.rb | 10 + ...projects_import_service_shared_examples.rb | 54 + .../showing_user_status_shared_examples.rb | 11 + ...attermost_notifications_shared_examples.rb | 18 +- spec/support/stored_repositories.rb | 4 - .../test_reports/test_reports_helper.rb | 93 + spec/tasks/gitlab/backup_rake_spec.rb | 21 + spec/tasks/gitlab/cleanup_rake_spec.rb | 86 +- spec/tasks/gitlab/git_rake_spec.rb | 30 +- spec/uploaders/gitlab_uploader_spec.rb | 62 + spec/uploaders/job_artifact_uploader_spec.rb | 37 - spec/views/layouts/_head.html.haml_spec.rb | 33 + .../projects/_home_panel.html.haml_spec.rb | 129 +- .../projects/imports/new.html.haml_spec.rb | 4 +- .../merge_requests/show.html.haml_spec.rb | 13 +- .../_pipeline_schedule.html.haml_spec.rb | 6 +- .../shared/notes/_form.html.haml_spec.rb | 2 +- .../background_migration_worker_spec.rb | 52 + spec/workers/concerns/waitable_worker_spec.rb | 4 +- .../create_gpg_signature_worker_spec.rb | 47 +- ...detect_repository_languages_worker_spec.rb | 32 + spec/workers/emails_on_push_worker_spec.rb | 61 +- .../git_garbage_collect_worker_spec.rb | 7 +- spec/workers/merge_worker_spec.rb | 2 +- spec/workers/pipeline_schedule_worker_spec.rb | 2 +- spec/workers/process_commit_worker_spec.rb | 40 +- ...ject_migrate_hashed_storage_worker_spec.rb | 2 +- spec/workers/repository_import_worker_spec.rb | 4 +- ...sitory_update_remote_mirror_worker_spec.rb | 10 +- ...hedule_update_user_activity_worker_spec.rb | 25 - spec/workers/storage_migrator_worker_spec.rb | 2 +- spec/workers/stuck_import_jobs_worker_spec.rb | 4 +- .../confidential_issue_worker_spec.rb | 12 + .../entity_leave_worker_spec.rb | 12 + .../group_private_worker_spec.rb | 12 + .../private_features_worker_spec.rb | 12 + .../project_private_worker_spec.rb | 12 + .../update_user_activity_worker_spec.rb | 35 - vendor/Dockerfile/Node-alpine.Dockerfile | 11 +- vendor/Dockerfile/Node.Dockerfile | 11 +- vendor/Dockerfile/Ruby-alpine.Dockerfile | 11 +- vendor/Dockerfile/Ruby.Dockerfile | 4 +- .../javascripts/xterm/encoding-indexes.js | 39 - vendor/assets/javascripts/xterm/encoding.js | 3309 --------- vendor/assets/javascripts/xterm/fit.js | 86 - vendor/assets/javascripts/xterm/xterm.js | 2235 ------ vendor/assets/stylesheets/xterm/xterm.css | 2206 ------ vendor/gitignore/Autotools.gitignore | 2 + vendor/gitignore/Laravel.gitignore | 7 +- vendor/gitignore/VisualStudio.gitignore | 5 +- .../gitlab-ci-yml/Auto-DevOps.gitlab-ci.yml | 3 +- vendor/gitlab-ci-yml/Maven.gitlab-ci.yml | 2 +- vendor/gitlab-ci-yml/Ruby.gitlab-ci.yml | 2 +- vendor/jupyter/values.yaml | 1 + vendor/licenses.csv | 289 +- yarn.lock | 1686 ++--- 3064 files changed, 103682 insertions(+), 25503 deletions(-) create mode 100644 .gitattributes create mode 100644 Dangerfile create mode 100644 app/assets/javascripts/commons/gitlab_ui.js create mode 100644 app/assets/javascripts/commons/polyfills/request_idle_callback.js create mode 100644 app/assets/javascripts/environments/components/stop_environment_modal.vue create mode 100644 app/assets/javascripts/helpers/avatar_helper.js create mode 100644 app/assets/javascripts/ide/components/branches/item.vue create mode 100644 app/assets/javascripts/ide/components/branches/search_list.vue create mode 100644 app/assets/javascripts/ide/components/ide_project_header.vue delete mode 100644 app/assets/javascripts/ide/components/merge_requests/dropdown.vue create mode 100644 app/assets/javascripts/ide/components/nav_dropdown.vue create mode 100644 app/assets/javascripts/ide/components/nav_dropdown_button.vue create mode 100644 app/assets/javascripts/ide/components/nav_form.vue create mode 100644 app/assets/javascripts/ide/components/new_dropdown/button.vue create mode 100644 app/assets/javascripts/ide/components/preview/clientside.vue create mode 100644 app/assets/javascripts/ide/components/preview/navigator.vue create mode 100644 app/assets/javascripts/ide/components/shared/tokened_input.vue create mode 100644 app/assets/javascripts/ide/stores/modules/branches/actions.js create mode 100644 app/assets/javascripts/ide/stores/modules/branches/index.js create mode 100644 app/assets/javascripts/ide/stores/modules/branches/mutation_types.js create mode 100644 app/assets/javascripts/ide/stores/modules/branches/mutations.js create mode 100644 app/assets/javascripts/ide/stores/modules/branches/state.js delete mode 100644 app/assets/javascripts/ide/stores/modules/merge_requests/getters.js create mode 100644 app/assets/javascripts/ide/utils.js create mode 100644 app/assets/javascripts/notes/mixins/discussion_navigation.js rename app/assets/javascripts/pages/{admin => instance_statistics}/cohorts/index.js (100%) rename app/assets/javascripts/pages/{admin => instance_statistics}/cohorts/usage_ping.js (100%) rename app/assets/javascripts/pages/{admin/conversational_development_index/show => instance_statistics/conversational_development_index}/index.js (100%) create mode 100644 app/assets/javascripts/pages/profiles/show/emoji_menu.js create mode 100644 app/assets/javascripts/pages/profiles/show/index.js create mode 100644 app/assets/javascripts/reports/components/grouped_test_reports_app.vue create mode 100644 app/assets/javascripts/reports/components/modal.vue create mode 100644 app/assets/javascripts/reports/components/test_issue_body.vue create mode 100644 app/assets/javascripts/reports/constants.js create mode 100644 app/assets/javascripts/reports/store/actions.js create mode 100644 app/assets/javascripts/reports/store/getters.js create mode 100644 app/assets/javascripts/reports/store/index.js create mode 100644 app/assets/javascripts/reports/store/mutation_types.js create mode 100644 app/assets/javascripts/reports/store/mutations.js create mode 100644 app/assets/javascripts/reports/store/state.js create mode 100644 app/assets/javascripts/reports/store/utils.js create mode 100644 app/assets/javascripts/sidebar/components/todo_toggle/todo.vue create mode 100644 app/assets/javascripts/vue_shared/components/bar_chart.vue create mode 100644 app/assets/javascripts/vue_shared/components/bar_chart_constants.js create mode 100644 app/assets/javascripts/vue_shared/components/code_block.vue create mode 100644 app/assets/javascripts/vue_shared/components/help_popover.vue create mode 100644 app/assets/javascripts/vue_shared/components/project_avatar/default.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/constants.js create mode 100644 app/assets/javascripts/vue_shared/components/reports/issue_body.js create mode 100644 app/assets/javascripts/vue_shared/components/reports/issue_status_icon.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/issues_list.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/modal_open_name.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/report_issues.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/report_link.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/report_section.vue create mode 100644 app/assets/javascripts/vue_shared/components/reports/summary_row.vue create mode 100644 app/assets/javascripts/vue_shared/components/svg_gradient.vue rename app/assets/stylesheets/{pages/repo.scss => page_bundles/ide.scss} (82%) create mode 100644 app/assets/stylesheets/pages/reports.scss delete mode 100644 app/controllers/admin/conversational_development_index_controller.rb create mode 100644 app/controllers/concerns/todos_actions.rb create mode 100644 app/controllers/import/bitbucket_server_controller.rb create mode 100644 app/controllers/import/manifest_controller.rb create mode 100644 app/controllers/instance_statistics/application_controller.rb rename app/controllers/{admin => instance_statistics}/cohorts_controller.rb (69%) create mode 100644 app/controllers/instance_statistics/conversational_development_index_controller.rb create mode 100644 app/graphql/mutations/base_mutation.rb create mode 100644 app/graphql/mutations/concerns/mutations/resolves_project.rb create mode 100644 app/graphql/mutations/merge_requests/base.rb create mode 100644 app/graphql/mutations/merge_requests/set_wip.rb create mode 100644 app/helpers/repository_languages_helper.rb create mode 100644 app/models/clusters/concerns/application_version.rb create mode 100644 app/models/concerns/label_eventable.rb create mode 100644 app/models/concerns/redactable.rb create mode 100644 app/models/concerns/token_authenticatable_strategies/base.rb create mode 100644 app/models/concerns/token_authenticatable_strategies/digest.rb create mode 100644 app/models/concerns/token_authenticatable_strategies/insecure.rb create mode 100644 app/models/dashboard_group_milestone.rb create mode 100644 app/models/postgresql/replication_slot.rb create mode 100644 app/models/programming_language.rb create mode 100644 app/models/project_services/hangouts_chat_service.rb create mode 100644 app/models/repository_language.rb create mode 100644 app/models/resource_label_event.rb create mode 100644 app/models/site_statistic.rb create mode 100644 app/models/user_status.rb create mode 100644 app/policies/concerns/policy_actor.rb create mode 100644 app/presenters/ci/build_runner_presenter.rb create mode 100644 app/serializers/concerns/user_status_tooltip.rb create mode 100644 app/serializers/test_case_entity.rb create mode 100644 app/serializers/test_reports_comparer_entity.rb create mode 100644 app/serializers/test_reports_comparer_serializer.rb create mode 100644 app/serializers/test_suite_comparer_entity.rb create mode 100644 app/services/ci/compare_test_reports_service.rb create mode 100644 app/services/projects/detect_repository_languages_service.rb create mode 100644 app/services/resource_events/change_labels_service.rb create mode 100644 app/services/todos/destroy/base_service.rb create mode 100644 app/services/todos/destroy/confidential_issue_service.rb create mode 100644 app/services/todos/destroy/entity_leave_service.rb create mode 100644 app/services/todos/destroy/group_private_service.rb create mode 100644 app/services/todos/destroy/private_features_service.rb create mode 100644 app/services/todos/destroy/project_private_service.rb create mode 100644 app/services/users/set_status_service.rb create mode 100644 app/views/import/_project_status.html.haml create mode 100644 app/views/import/bitbucket_server/new.html.haml create mode 100644 app/views/import/bitbucket_server/status.html.haml create mode 100644 app/views/import/manifest/_form.html.haml create mode 100644 app/views/import/manifest/new.html.haml create mode 100644 app/views/import/manifest/status.html.haml rename app/views/{admin => instance_statistics}/cohorts/_cohorts_table.html.haml (83%) rename app/views/{admin => instance_statistics}/cohorts/_usage_ping.html.haml (100%) rename app/views/{admin => instance_statistics}/cohorts/index.html.haml (100%) rename app/views/{admin => instance_statistics}/conversational_development_index/_callout.html.haml (100%) rename app/views/{admin => instance_statistics}/conversational_development_index/_card.html.haml (100%) rename app/views/{admin => instance_statistics}/conversational_development_index/_disabled.html.haml (100%) rename app/views/{admin => instance_statistics}/conversational_development_index/_no_data.html.haml (71%) rename app/views/{admin/conversational_development_index/show.html.haml => instance_statistics/conversational_development_index/index.html.haml} (94%) create mode 100644 app/views/layouts/instance_statistics.html.haml create mode 100644 app/views/layouts/nav/sidebar/_instance_statistics.html.haml delete mode 100644 app/views/projects/environments/_stop.html.haml create mode 100644 app/views/projects/project_templates/_built_in_templates.html.haml create mode 100644 app/views/projects/project_templates/_project_fields_form.html.haml create mode 100644 app/views/projects/protected_tags/_protected_tag_create_access_levels.haml delete mode 100644 app/views/projects/protected_tags/_update_protected_tag.haml create mode 100644 app/views/projects/services/prometheus/_metrics.html.haml create mode 100644 app/workers/concerns/todos_destroyer_queue.rb create mode 100644 app/workers/detect_repository_languages_worker.rb delete mode 100644 app/workers/schedule_update_user_activity_worker.rb create mode 100644 app/workers/todos_destroyer/confidential_issue_worker.rb create mode 100644 app/workers/todos_destroyer/entity_leave_worker.rb create mode 100644 app/workers/todos_destroyer/group_private_worker.rb create mode 100644 app/workers/todos_destroyer/private_features_worker.rb create mode 100644 app/workers/todos_destroyer/project_private_worker.rb delete mode 100644 app/workers/update_user_activity_worker.rb create mode 100644 config/initializers/action_mailer_hooks.rb create mode 100644 config/initializers/active_record_verbose_query_logs.rb delete mode 100644 config/initializers/additional_headers_interceptor.rb delete mode 100644 config/initializers/disable_email_interceptor.rb delete mode 100644 config/initializers/email_template_interceptor.rb create mode 100644 config/initializers/hipchat_client_patch.rb create mode 100644 config/object_store_settings.rb create mode 100644 config/routes/instance_statistics.rb create mode 100644 danger/changelog/Dangerfile create mode 100644 danger/changes_size/Dangerfile create mode 100644 danger/database/Dangerfile create mode 100644 danger/frozen_string/Dangerfile create mode 100644 danger/gemfile/Dangerfile create mode 100644 danger/metadata/Dangerfile create mode 100644 danger/specs/Dangerfile create mode 100644 db/migrate/20180531185349_add_repository_languages.rb create mode 100644 db/migrate/20180608091413_add_group_to_todos.rb create mode 100644 db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb create mode 100644 db/migrate/20180629153018_create_site_statistics.rb create mode 100644 db/migrate/20180702124358_remove_orphaned_routes.rb create mode 100644 db/migrate/20180702134423_generate_missing_routes.rb create mode 100644 db/migrate/20180705160945_add_file_format_to_ci_job_artifacts.rb create mode 100644 db/migrate/20180710162338_add_foreign_key_from_notification_settings_to_users.rb create mode 100644 db/migrate/20180713092803_create_user_statuses.rb create mode 100644 db/migrate/20180717125853_remove_restricted_todos.rb create mode 100644 db/migrate/20180718005113_add_instance_statistics_visibility_to_application_setting.rb create mode 100644 db/migrate/20180722103201_add_private_profile_to_users.rb create mode 100644 db/migrate/20180723135214_add_web_ide_client_side_preview_enabled_to_application_settings.rb create mode 100644 db/migrate/20180726172057_create_resource_label_events.rb create mode 100644 db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb create mode 100644 db/migrate/20180910153413_add_index_to_token_digest_on_personal_access_tokens.rb create mode 100644 db/post_migrate/20180619121030_enqueue_delete_diff_files_workers.rb create mode 100644 db/post_migrate/20180706223200_populate_site_statistics.rb create mode 100644 db/post_migrate/20180913142237_schedule_digest_personal_access_tokens.rb create mode 100644 db/post_migrate/20181014121030_enqueue_redact_links.rb delete mode 100644 doc/administration/img/raketasks/check_repos_output.png create mode 100644 doc/administration/operations/ssh_certificates.md create mode 100644 doc/ci/docker/using_kaniko.md create mode 100644 doc/ci/img/junit_test_report.png create mode 100644 doc/ci/junit_test_reports.md delete mode 100644 doc/development/fe_guide/img/vue_arch.png create mode 100644 doc/development/pry_debugging.md create mode 100644 doc/update/11.1-to-11.2.md delete mode 100644 doc/user/admin_area/img/cohorts.png delete mode 100644 doc/user/admin_area/monitoring/img/convdev_index.png create mode 100644 doc/user/instance_statistics/convdev.md create mode 100644 doc/user/instance_statistics/img/cohorts.png create mode 100644 doc/user/instance_statistics/img/convdev_index.png create mode 100644 doc/user/instance_statistics/img/instance_statistics_button.png create mode 100644 doc/user/instance_statistics/index.md create mode 100644 doc/user/instance_statistics/user_cohorts.md create mode 100644 doc/user/project/img/bulk-editing.png create mode 100644 doc/user/project/img/labels_project_list_search.png create mode 100644 doc/user/project/import/bitbucket_server.md delete mode 100644 doc/user/project/import/img/bitbucket_import_new_project.png create mode 100644 doc/user/project/import/img/bitbucket_server_import_credentials.png create mode 100644 doc/user/project/import/img/bitbucket_server_import_select_project.png create mode 100644 doc/user/project/import/img/manifest_status.png create mode 100644 doc/user/project/import/manifest.md create mode 100644 doc/user/project/integrations/hangouts_chat.md create mode 100644 doc/user/project/integrations/img/hangouts_chat_configuration.png delete mode 100644 doc/user/project/pages/img/dns_add_new_a_record_example_updated.png create mode 100644 doc/user/project/pages/img/dns_add_new_a_record_example_updated_2018.png create mode 100644 doc/user/project/web_ide/img/admin_clientside_evaluation.png create mode 100644 doc/user/project/web_ide/img/clientside_evaluation.png delete mode 100644 lib/additional_email_headers_interceptor.rb create mode 100644 lib/banzai/pipeline/emoji_pipeline.rb create mode 100644 lib/bitbucket_server/client.rb create mode 100644 lib/bitbucket_server/collection.rb create mode 100644 lib/bitbucket_server/connection.rb create mode 100644 lib/bitbucket_server/page.rb create mode 100644 lib/bitbucket_server/paginator.rb create mode 100644 lib/bitbucket_server/representation/activity.rb create mode 100644 lib/bitbucket_server/representation/base.rb create mode 100644 lib/bitbucket_server/representation/comment.rb create mode 100644 lib/bitbucket_server/representation/pull_request.rb create mode 100644 lib/bitbucket_server/representation/pull_request_comment.rb create mode 100644 lib/bitbucket_server/representation/repo.rb delete mode 100644 lib/disable_email_interceptor.rb delete mode 100644 lib/email_template_interceptor.rb create mode 100644 lib/gitlab/auth/activity.rb create mode 100644 lib/gitlab/background_migration/digest_column.rb create mode 100644 lib/gitlab/background_migration/redact_links.rb create mode 100644 lib/gitlab/background_migration/remove_restricted_todos.rb create mode 100644 lib/gitlab/background_migration/schedule_diff_files_deletion.rb create mode 100644 lib/gitlab/bitbucket_server_import/importer.rb create mode 100644 lib/gitlab/bitbucket_server_import/project_creator.rb create mode 100644 lib/gitlab/ci/build/artifacts/gzip_file_adapter.rb create mode 100644 lib/gitlab/ci/config/entry/reports.rb create mode 100644 lib/gitlab/ci/parsers.rb create mode 100644 lib/gitlab/ci/parsers/junit.rb create mode 100644 lib/gitlab/ci/reports/test_case.rb create mode 100644 lib/gitlab/ci/reports/test_reports.rb create mode 100644 lib/gitlab/ci/reports/test_reports_comparer.rb create mode 100644 lib/gitlab/ci/reports/test_suite.rb create mode 100644 lib/gitlab/ci/reports/test_suite_comparer.rb delete mode 100644 lib/gitlab/ci/trace/http_io.rb create mode 100644 lib/gitlab/cleanup/project_upload_file_finder.rb create mode 100644 lib/gitlab/cleanup/project_uploads.rb create mode 100644 lib/gitlab/cleanup/remote_uploads.rb create mode 100644 lib/gitlab/crypto_helper.rb create mode 100644 lib/gitlab/email/hook/additional_headers_interceptor.rb create mode 100644 lib/gitlab/email/hook/delivery_metrics_observer.rb create mode 100644 lib/gitlab/email/hook/disable_email_interceptor.rb create mode 100644 lib/gitlab/email/hook/email_template_interceptor.rb delete mode 100644 lib/gitlab/git/rev_list.rb delete mode 100755 lib/gitlab/git/support/format-git-cat-file-input create mode 100644 lib/gitlab/graphql/authorize/authorize_resource.rb create mode 100644 lib/gitlab/graphql/mount_mutation.rb create mode 100644 lib/gitlab/hook_data/base_builder.rb create mode 100644 lib/gitlab/hook_data/note_builder.rb create mode 100644 lib/gitlab/hook_data/wiki_page_builder.rb create mode 100644 lib/gitlab/http_io.rb create mode 100644 lib/gitlab/json_logger.rb create mode 100644 lib/gitlab/kubernetes/helm/certificate.rb create mode 100644 lib/gitlab/language_detection.rb create mode 100644 lib/gitlab/manifest_import/manifest.rb create mode 100644 lib/gitlab/manifest_import/project_creator.rb create mode 100644 lib/gitlab/middleware/basic_health_check.rb create mode 100644 lib/gitlab/profiler/total_time_flat_printer.rb create mode 100644 lib/gitlab/template_helper.rb delete mode 100644 lib/gitlab/user_activities.rb create mode 100644 qa/qa/factory/resource/file.rb create mode 100644 qa/qa/factory/resource/fork.rb create mode 100644 qa/qa/factory/resource/merge_request_from_fork.rb create mode 100644 qa/qa/factory/resource/project_milestone.rb create mode 100644 qa/qa/factory/resource/user.rb create mode 100644 qa/qa/page/file/form.rb create mode 100644 qa/qa/page/file/shared/commit_message.rb create mode 100644 qa/qa/page/file/show.rb create mode 100644 qa/qa/page/layout/banner.rb create mode 100644 qa/qa/page/main/sign_up.rb create mode 100644 qa/qa/page/project/fork/new.rb create mode 100644 qa/qa/page/project/milestone/index.rb create mode 100644 qa/qa/page/project/milestone/new.rb delete mode 100644 qa/qa/specs/features/login/standard_spec.rb create mode 100644 qa/qa/specs/features/project/file_spec.rb create mode 100644 qa/qa/specs/features/project/fork_project_spec.rb create mode 100644 spec/config/object_store_settings_spec.rb create mode 100644 spec/controllers/import/bitbucket_server_controller_spec.rb create mode 100644 spec/controllers/instance_statistics/cohorts_controller_spec.rb create mode 100644 spec/controllers/instance_statistics/conversational_development_index_controller_spec.rb create mode 100644 spec/factories/programming_languages.rb create mode 100644 spec/factories/repository_languages.rb create mode 100644 spec/factories/resource_label_events.rb create mode 100644 spec/factories/site_statistics.rb create mode 100644 spec/factories/user_statuses.rb delete mode 100644 spec/features/admin/admin_cohorts_spec.rb create mode 100644 spec/features/dashboard/instance_statistics_spec.rb create mode 100644 spec/features/groups/board_spec.rb create mode 100644 spec/features/import/manifest_import_spec.rb create mode 100644 spec/features/instance_statistics/cohorts_spec.rb rename spec/features/{admin/admin_conversational_development_index_spec.rb => instance_statistics/conversational_development_index_spec.rb} (57%) rename spec/features/merge_request/{user_cherry_picks_spec.rb => user_sees_cherry_pick_modal_spec.rb} (67%) create mode 100644 spec/features/milestones/user_edits_milestone_spec.rb create mode 100644 spec/features/projects/commit/user_views_user_status_on_commit_spec.rb create mode 100644 spec/features/projects/import_export/import_file_object_storage_spec.rb create mode 100644 spec/features/projects/labels/search_labels_spec.rb create mode 100644 spec/features/projects/merge_requests/user_views_user_status_on_merge_request_spec.rb create mode 100644 spec/features/user_sees_revert_modal_spec.rb create mode 100644 spec/features/users/add_email_to_existing_account.rb create mode 100644 spec/fixtures/aosp_manifest.xml create mode 100644 spec/fixtures/api/schemas/entities/test_case.json create mode 100644 spec/fixtures/api/schemas/entities/test_reports_comparer.json create mode 100644 spec/fixtures/api/schemas/entities/test_suite_comparer.json create mode 100644 spec/fixtures/importers/bitbucket_server/activities.json create mode 100644 spec/fixtures/importers/bitbucket_server/pull_request.json create mode 100644 spec/fixtures/junit/junit.xml create mode 100644 spec/fixtures/junit/junit.xml.gz create mode 100644 spec/fixtures/junit/junit_ant.xml.gz create mode 100644 spec/fixtures/junit/junit_with_corrupted_data.xml.gz create mode 100644 spec/fixtures/junit/junit_with_three_testsuites.xml.gz create mode 100644 spec/fixtures/junit/junit_with_three_testsuites_1.xml create mode 100644 spec/fixtures/junit/junit_with_three_testsuites_2.xml create mode 100644 spec/fixtures/junit/junit_with_three_testsuites_3.xml create mode 100644 spec/graphql/mutations/concerns/mutations/resolves_project_spec.rb create mode 100644 spec/graphql/mutations/merge_requests/set_wip_spec.rb create mode 100644 spec/graphql/types/mutation_type_spec.rb create mode 100644 spec/javascripts/avatar_helper_spec.js create mode 100644 spec/javascripts/helpers/vuex_action_helper_spec.js create mode 100644 spec/javascripts/helpers/wait_for_promises.js create mode 100644 spec/javascripts/ide/components/branches/item_spec.js create mode 100644 spec/javascripts/ide/components/branches/search_list_spec.js delete mode 100644 spec/javascripts/ide/components/merge_requests/dropdown_spec.js create mode 100644 spec/javascripts/ide/components/nav_dropdown_button_spec.js create mode 100644 spec/javascripts/ide/components/nav_dropdown_spec.js create mode 100644 spec/javascripts/ide/components/new_dropdown/button_spec.js create mode 100644 spec/javascripts/ide/components/preview/clientside_spec.js create mode 100644 spec/javascripts/ide/components/preview/navigator_spec.js create mode 100644 spec/javascripts/ide/components/shared/tokened_input_spec.js create mode 100644 spec/javascripts/ide/ide_router_spec.js create mode 100644 spec/javascripts/ide/stores/modules/branches/actions_spec.js create mode 100644 spec/javascripts/ide/stores/modules/branches/mutations_spec.js delete mode 100644 spec/javascripts/issuable_time_tracker_spec.js create mode 100644 spec/javascripts/pages/profiles/show/emoji_menu_spec.js create mode 100644 spec/javascripts/performance_bar/index_spec.js create mode 100644 spec/javascripts/reports/components/grouped_test_reports_app_spec.js create mode 100644 spec/javascripts/reports/components/modal_spec.js create mode 100644 spec/javascripts/reports/components/test_issue_body_spec.js create mode 100644 spec/javascripts/reports/mock_data/mock_data.js create mode 100644 spec/javascripts/reports/mock_data/new_and_fixed_failures_report.json create mode 100644 spec/javascripts/reports/mock_data/new_failures_report.json create mode 100644 spec/javascripts/reports/mock_data/no_failures_report.json create mode 100644 spec/javascripts/reports/mock_data/resolved_failures.json create mode 100644 spec/javascripts/reports/store/actions_spec.js create mode 100644 spec/javascripts/reports/store/mutations_spec.js create mode 100644 spec/javascripts/reports/store/utils_spec.js create mode 100644 spec/javascripts/sidebar/components/time_tracking/time_tracker_spec.js create mode 100644 spec/javascripts/sidebar/todo_spec.js create mode 100644 spec/javascripts/vue_shared/components/bar_chart_spec.js create mode 100644 spec/javascripts/vue_shared/components/code_block_spec.js create mode 100644 spec/javascripts/vue_shared/components/project_avatar/default_spec.js create mode 100644 spec/javascripts/vue_shared/components/reports/modal_open_name_spec.js create mode 100644 spec/javascripts/vue_shared/components/reports/report_link_spec.js create mode 100644 spec/javascripts/vue_shared/components/reports/report_section_spec.js create mode 100644 spec/javascripts/vue_shared/components/reports/summary_row_spec.js create mode 100644 spec/lib/banzai/pipeline/emoji_pipeline_spec.rb create mode 100644 spec/lib/bitbucket_server/client_spec.rb create mode 100644 spec/lib/bitbucket_server/connection_spec.rb create mode 100644 spec/lib/bitbucket_server/page_spec.rb create mode 100644 spec/lib/bitbucket_server/paginator_spec.rb create mode 100644 spec/lib/bitbucket_server/representation/activity_spec.rb create mode 100644 spec/lib/bitbucket_server/representation/comment_spec.rb create mode 100644 spec/lib/bitbucket_server/representation/pull_request_comment_spec.rb create mode 100644 spec/lib/bitbucket_server/representation/pull_request_spec.rb create mode 100644 spec/lib/bitbucket_server/representation/repo_spec.rb create mode 100644 spec/lib/gitlab/auth/activity_spec.rb create mode 100644 spec/lib/gitlab/background_migration/digest_column_spec.rb create mode 100644 spec/lib/gitlab/background_migration/redact_links_spec.rb create mode 100644 spec/lib/gitlab/background_migration/remove_restricted_todos_spec.rb create mode 100644 spec/lib/gitlab/background_migration/schedule_diff_files_deletion_spec.rb create mode 100644 spec/lib/gitlab/bitbucket_server_import/importer_spec.rb create mode 100644 spec/lib/gitlab/ci/build/artifacts/gzip_file_adapter_spec.rb create mode 100644 spec/lib/gitlab/ci/config/entry/reports_spec.rb create mode 100644 spec/lib/gitlab/ci/parsers/junit_spec.rb create mode 100644 spec/lib/gitlab/ci/parsers_spec.rb create mode 100644 spec/lib/gitlab/ci/reports/test_case_spec.rb create mode 100644 spec/lib/gitlab/ci/reports/test_reports_comparer_spec.rb create mode 100644 spec/lib/gitlab/ci/reports/test_reports_spec.rb create mode 100644 spec/lib/gitlab/ci/reports/test_suite_comparer_spec.rb create mode 100644 spec/lib/gitlab/ci/reports/test_suite_spec.rb create mode 100644 spec/lib/gitlab/cleanup/project_uploads_spec.rb create mode 100644 spec/lib/gitlab/cleanup/remote_uploads_spec.rb rename spec/lib/{additional_email_headers_interceptor_spec.rb => gitlab/email/hook/additional_headers_interceptor_spec.rb} (92%) create mode 100644 spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb rename spec/lib/{ => gitlab/email/hook}/disable_email_interceptor_spec.rb (91%) delete mode 100644 spec/lib/gitlab/git/rev_list_spec.rb create mode 100644 spec/lib/gitlab/gitaly_client/storage_service_spec.rb create mode 100644 spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb create mode 100644 spec/lib/gitlab/graphql/authorize_spec.rb create mode 100644 spec/lib/gitlab/hook_data/base_builder_spec.rb rename spec/lib/gitlab/{ci/trace => }/http_io_spec.rb (85%) create mode 100644 spec/lib/gitlab/import_export/file_importer_object_storage_spec.rb create mode 100644 spec/lib/gitlab/import_export/importer_object_storage_spec.rb create mode 100644 spec/lib/gitlab/json_logger_spec.rb create mode 100644 spec/lib/gitlab/kubernetes/helm/certificate_spec.rb create mode 100644 spec/lib/gitlab/language_detection_spec.rb create mode 100644 spec/lib/gitlab/manifest_import/manifest_spec.rb create mode 100644 spec/lib/gitlab/manifest_import/project_creator_spec.rb create mode 100644 spec/lib/gitlab/middleware/basic_health_check_spec.rb delete mode 100644 spec/lib/gitlab/user_activities_spec.rb create mode 100644 spec/migrations/add_foreign_key_from_notification_settings_to_users_spec.rb create mode 100644 spec/migrations/enqueue_delete_diff_files_workers_spec.rb create mode 100644 spec/migrations/enqueue_redact_links_spec.rb create mode 100644 spec/migrations/generate_missing_routes_spec.rb create mode 100644 spec/migrations/schedule_digest_personal_access_tokens_spec.rb create mode 100644 spec/models/concerns/redactable_spec.rb create mode 100644 spec/models/postgresql/replication_slot_spec.rb create mode 100644 spec/models/programming_language_spec.rb create mode 100644 spec/models/project_services/hangouts_chat_service_spec.rb create mode 100644 spec/models/repository_language_spec.rb create mode 100644 spec/models/resource_label_event_spec.rb create mode 100644 spec/models/site_statistic_spec.rb create mode 100644 spec/models/user_status_spec.rb create mode 100644 spec/policies/concerns/policy_actor_spec.rb create mode 100644 spec/presenters/ci/build_runner_presenter_spec.rb create mode 100644 spec/requests/api/graphql/mutations/merge_requests/set_wip_spec.rb create mode 100644 spec/routing/instance_statistics_routing_spec.rb create mode 100644 spec/serializers/test_case_entity_spec.rb create mode 100644 spec/serializers/test_reports_comparer_entity_spec.rb create mode 100644 spec/serializers/test_reports_comparer_serializer_spec.rb create mode 100644 spec/serializers/test_suite_comparer_entity_spec.rb create mode 100644 spec/services/ci/compare_test_reports_service_spec.rb create mode 100644 spec/services/projects/detect_repository_languages_service_spec.rb create mode 100644 spec/services/resource_events/change_labels_service_spec.rb create mode 100644 spec/services/todos/destroy/confidential_issue_service_spec.rb create mode 100644 spec/services/todos/destroy/entity_leave_service_spec.rb create mode 100644 spec/services/todos/destroy/group_private_service_spec.rb create mode 100644 spec/services/todos/destroy/private_features_service_spec.rb create mode 100644 spec/services/todos/destroy/project_private_service_spec.rb create mode 100644 spec/services/users/set_status_service_spec.rb create mode 100644 spec/support/helpers/stub_metrics.rb delete mode 100644 spec/support/helpers/user_activities_helpers.rb create mode 100644 spec/support/matchers/metric_counter_matcher.rb delete mode 100644 spec/support/matchers/user_activity_matchers.rb create mode 100644 spec/support/matchers/user_status_matcher.rb create mode 100644 spec/support/shared_contexts/merge_requests_allowing_collaboration.rb create mode 100644 spec/support/shared_examples/controllers/todos_shared_examples.rb create mode 100644 spec/support/shared_examples/instance_statistics_controllers_shared_examples.rb create mode 100644 spec/support/shared_examples/services/gitlab_projects_import_service_shared_examples.rb create mode 100644 spec/support/shared_examples/showing_user_status_shared_examples.rb create mode 100644 spec/support/test_reports/test_reports_helper.rb create mode 100644 spec/workers/detect_repository_languages_worker_spec.rb delete mode 100644 spec/workers/schedule_update_user_activity_worker_spec.rb create mode 100644 spec/workers/todos_destroyer/confidential_issue_worker_spec.rb create mode 100644 spec/workers/todos_destroyer/entity_leave_worker_spec.rb create mode 100644 spec/workers/todos_destroyer/group_private_worker_spec.rb create mode 100644 spec/workers/todos_destroyer/private_features_worker_spec.rb create mode 100644 spec/workers/todos_destroyer/project_private_worker_spec.rb delete mode 100644 spec/workers/update_user_activity_worker_spec.rb delete mode 100644 vendor/assets/javascripts/xterm/encoding-indexes.js delete mode 100644 vendor/assets/javascripts/xterm/encoding.js delete mode 100644 vendor/assets/javascripts/xterm/fit.js delete mode 100644 vendor/assets/javascripts/xterm/xterm.js delete mode 100644 vendor/assets/stylesheets/xterm/xterm.css diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000000..f1c41c9bb7 --- /dev/null +++ b/.gitattributes @@ -0,0 +1 @@ +Dangerfile gitlab-language=ruby diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 70f5351a91..fd02d72b4c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,4 +1,4 @@ -image: "dev.gitlab.org:5005/gitlab/gitlab-build-images:ruby-2.4.4-golang-1.9-git-2.17-chrome-67.0-node-8.x-yarn-1.2-postgresql-9.6-graphicsmagick-1.3.29" +image: "dev.gitlab.org:5005/gitlab/gitlab-build-images:ruby-2.4.4-golang-1.9-git-2.18-chrome-67.0-node-8.x-yarn-1.2-postgresql-9.6-graphicsmagick-1.3.29" .dedicated-runner: &dedicated-runner retry: 1 @@ -86,7 +86,9 @@ stages: .rails5: &rails5 allow_failure: true only: - - /rails5/ + variables: + - $CI_COMMIT_REF_NAME =~ /rails5/ + - $RAILS5_ENABLED variables: BUNDLE_GEMFILE: "Gemfile.rails5" RAILS5: "true" @@ -436,6 +438,26 @@ setup-test-env: - config/secrets.yml - vendor/gitaly-ruby +danger-review: + image: registry.gitlab.com/gitlab-org/gitlab-build-images:danger + stage: test + allow_failure: true + cache: {} + dependencies: [] + before_script: [] + only: + variables: + - $DANGER_GITLAB_API_TOKEN + except: + refs: + - master + variables: + - $CI_COMMIT_REF_NAME =~ /^ce-to-ee-.*/ + - $CI_COMMIT_REF_NAME =~ /.*-stable(-ee)?-prepare-.*/ + script: + - git version + - danger --fail-on-errors=true + rspec-pg 0 30: *rspec-metadata-pg rspec-pg 1 30: *rspec-metadata-pg rspec-pg 2 30: *rspec-metadata-pg diff --git a/.gitlab/merge_request_templates/Database changes.md b/.gitlab/merge_request_templates/Database changes.md index d14d52e1b6..e636ec313d 100644 --- a/.gitlab/merge_request_templates/Database changes.md +++ b/.gitlab/merge_request_templates/Database changes.md @@ -34,17 +34,17 @@ When removing columns, tables, indexes or other structures: ## General checklist - [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary -- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html) -- [ ] API support added -- [ ] Tests added for this feature/bug -- Conform by the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html) - - [ ] Has been reviewed by a Backend maintainer - - [ ] Has been reviewed by a Database specialist -- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html) -- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides) +- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/index.html#contributing-to-docs) +- [ ] [API support added](https://docs.gitlab.com/ee/development/api_styleguide.html) +- [ ] [Tests added for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html) +- Conforms to the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html) + - [ ] Has been reviewed by a Backend [maintainer](https://about.gitlab.com/handbook/engineering/#maintainer) + - [ ] Has been reviewed by a Database [specialist](https://about.gitlab.com/team/structure/#specialist) +- [ ] Conforms to the [merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html) +- [ ] Conforms to the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides) - [ ] If you have multiple commits, please combine them into a few logically organized commits by [squashing them](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) -- [ ] Internationalization required/considered -- [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -- [ ] End-to-end tests pass (`package-and-qa` manual pipeline job) +- [ ] [Internationalization required/considered](https://docs.gitlab.com/ee/development/i18n/index.html) +- [ ] For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? +- [ ] [End-to-end tests](https://docs.gitlab.com/ee/development/testing_guide/end_to_end_tests.html#testing-code-in-merge-requests) pass (`package-and-qa` manual pipeline job) /label ~database diff --git a/.gitlab/merge_request_templates/Documentation.md b/.gitlab/merge_request_templates/Documentation.md index da38a703c3..531035b376 100644 --- a/.gitlab/merge_request_templates/Documentation.md +++ b/.gitlab/merge_request_templates/Documentation.md @@ -1,4 +1,4 @@ - + ## What does this MR do? @@ -13,17 +13,17 @@ Closes ## Moving docs to a new location? Read the guidelines: -https://docs.gitlab.com/ce/development/writing_documentation.html#changing-document-location +https://docs.gitlab.com/ee/development/documentation/#changing-document-location - [ ] Make sure the old link is not removed and has its contents replaced with a link to the new location. - [ ] Make sure internal links pointing to the document in question are not broken. -- [ ] Search and replace any links referring to old docs in GitLab Rails app, - specifically under the `app/views/` and `ee/app/views` (for GitLab EE) directories. -- [ ] Make sure to add [`redirect_from`](https://docs.gitlab.com/ce/development/writing_documentation.html#redirections-for-pages-with-disqus-comments) +- [ ] Search and replace any links referring to the old docs in the GitLab Rails app, + specifically under the `app/views/` and `ee/app/views` (for GitLab EE) directories. +- [ ] Make sure to add [`redirect_from`](https://docs.gitlab.com/ee/development/documentation/index.html#redirections-for-pages-with-disqus-comments) to the new document if there are any Disqus comments on the old document thread. -- [ ] If working on CE and the `ee-compat-check` jobs fails, submit an MR to EE - with the changes as well (https://docs.gitlab.com/ce/development/writing_documentation.html#cherry-picking-from-ce-to-ee). +- [ ] If working on CE and the `ee-compat-check` jobs fails, [submit an MR to EE + with the changes](https://docs.gitlab.com/ee/development/documentation/index.html#cherry-picking-from-ce-to-ee) as well. - [ ] Ping one of the technical writers for review. /label ~Documentation diff --git a/.rubocop.yml b/.rubocop.yml index 0582bfe8d7..c8b1ce327e 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -10,9 +10,9 @@ AllCops: Exclude: - 'vendor/**/*' - 'node_modules/**/*' - - 'db/**/*' - 'db/fixtures/**/*' - - 'ee/db/**/*' + - 'db/schema.rb' + - 'ee/db/geo/schema.rb' - 'tmp/**/*' - 'bin/**/*' - 'generator_templates/**/*' @@ -34,6 +34,8 @@ Style/MutableConstant: Naming/FileName: ExpectMatchingDefinition: true Exclude: + - 'db/**/*' + - 'ee/db/**/*' - 'spec/**/*' - 'features/**/*' - 'ee/spec/**/*' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3e1713f845..8a1ca6747a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -199,12 +199,6 @@ Naming/HeredocDelimiterCase: Naming/HeredocDelimiterNaming: Enabled: false -# Offense count: 27 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect. -Performance/HashEachMethods: - Enabled: false - # Offense count: 1 Performance/UnfreezeString: Exclude: diff --git a/CHANGELOG.md b/CHANGELOG.md index 7aef16f162..41c3450370 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,16 +2,38 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. -## 11.1.8 (2018-10-05) +## 11.2.8 (2018-10-31) + +### Security (1 change) + +- Monkey kubeclient to not follow any redirects. + + +## 11.2.7 (2018-10-27) + +- No changes. + +## 11.2.6 (2018-10-26) + +### Security (5 changes) + +- Escape entity title while autocomplete template rendering to prevent XSS. !2558 +- Fix XSS in merge request source branch name. +- Redact personal tokens in unsubscribe links. +- Persist only SHA digest of PersonalAccessToken#token. +- Prevent SSRF attacks in HipChat integration. + + +## 11.2.5 (2018-10-05) ### Security (3 changes) -- Filter user sensitive data from discussions JSON. !2539 +- Filter user sensitive data from discussions JSON. !2538 - Properly filter private references from system notes. - Markdown API no longer displays confidential title references unless authorized. -## 11.1.7 (2018-09-26) +## 11.2.4 (2018-09-26) ### Security (6 changes) @@ -23,11 +45,11 @@ entry. - Block loopback addresses in UrlBlocker. -## 11.1.6 (2018-08-28) +## 11.2.3 (2018-08-28) - No changes. -## 11.1.5 (2018-08-27) +## 11.2.2 (2018-08-27) ### Security (3 changes) @@ -35,32 +57,271 @@ entry. - Adding CSRF protection to Hooks resend action. - Block link-local addresses in URLBlocker. -### Fixed (1 change, 1 of them is from the community) +## 11.2.1 (2018-08-22) + +### Fixed (2 changes) + +- Fix wrong commit count in push event payload. !21338 +- Fix broken Git over HTTP clones with LDAP users. !21352 + +### Performance (1 change) + +- Eliminate unnecessary and duplicate system hook fires. !21337 + + +## 11.2.0 (2018-08-22) + +### Security (5 changes) + +- Bump Gitaly to 0.117.1 for Rouge update. !21277 +- Fix symlink vulnerability in project import. +- Bump rugged to 0.27.4 for security fixes. +- Fixed XSS in branch name in Web IDE. +- Adding CSRF protection to Hooks test action. + +### Removed (1 change) + +- Remove gitlab:user:check_repos, gitlab:check_repo, gitlab:git:prune, gitlab:git:gc, and gitlab:git:repack. !20806 + +### Fixed (81 changes, 26 of them are from the community) + +- Fix namespace move callback behavior, especially to fix Geo replication of namespace moves during certain exceptions. !19297 +- Fix breadcrumbs in Admin/User interface. !19608 (Robin Naundorf) +- Remove changes_count from MR API documentation where necessary. !19745 (Jan Beckmann) +- Fix email confirmation bug when user adds additional email to account. !20084 (muhammadn) +- Add support for daylight savings time to pipleline schedules. !20145 +- Fixing milestone date change when editing. !20279 (Orlando Del Aguila) +- Add missing maximum_timeout parameter. !20355 (gfyoung) +- [Rails5] Fix 'Invalid single-table inheritance type: Group is not a subclass of Gitlab::BackgroundMigration::FixCrossProjectLabelLinks::Namespace'. !20462 (@blackst0ne) +- Rails5 fix mysql milliseconds problem in specs. !20464 (Jasper Maes) +- Update Gemfile.rails5.lock with latest Gemfile.lock changes. !20466 (Jasper Maes) +- Rails5 mysql fix milliseconds problem in pull request importer spec. !20475 (Jasper Maes) +- Rails5 MySQL fix rename_column as part of cleanup_concurrent_column_type_change. !20514 (Jasper Maes) +- Process commits as normal in forks when the upstream project is deleted. !20534 +- Fix project visibility tooltip. !20535 (Jamie Schembri) +- Fix archived parameter for projects API. !20566 (Peter Marko) +- Limit maximum project build timeout setting to 1 month. !20591 +- Fix GitLab project imports not loading due to API timeouts. !20599 +- Avoid process deadlock in popen by consuming input pipes. !20600 +- Disable SAML and Bitbucket if OmniAuth is disabled. !20608 +- Support multiple scopes when authing container registry scopes. !20617 +- Adds the ability to view group milestones on the dashboard milestone page. !20618 +- Allow issues API to receive an internal ID (iid) on create. !20626 (Jamie Schembri) +- Fix typo in CSS transform property for Memory Graph component. !20650 +- Update design for system metrics popovers. !20655 +- Toggle Show / Hide Button for Kubernetes Password. !20659 (gfyoung) +- Board label edit dropdown shows incorrect selected labels summary. !20673 +- Resolve "Unable to save user profile update with Safari". !20676 +- Escape username and password in UrlSanitizer#full_url. !20684 +- Remove background color from card-body style. !20689 (George Tsiolis) +- Update total storage size when changing size of artifacts. !20697 (Peter Marko) +- Rails5 fix user sees revert modal spec. !20706 (Jasper Maes) +- Fix Web IDE crashing on directories named 'blob'. !20712 +- Fix accessing imported pipeline builds. !20713 +- Fixed bug with invalid repository reference using the wiki search. !20722 +- Resolve Copy diff file path as GFM is broken. !20725 +- Chart versions for applications installed by one click install buttons should be version locked. !20765 +- Fix misalignment of broadcast message on login page. !20794 (Robin Naundorf) +- Fix Vue datatype errors for markdownVersion parsing. !20800 +- Fix authorization for interactive web terminals. !20811 +- Increase width of Web IDE sidebar resize handles. !20818 +- Fix new MR card styles. !20822 +- Fix link color in markdown code brackets. !20841 +- Rails5 update Gemfile.rails5.lock. !20858 (Jasper Maes) +- fix height of full-width Metrics charts on large screens. !20866 +- Fix sorting by name on milestones page. !20881 +- Permit concurrent loads in gpg keychain mutex. !20894 (Jasper Maes) +- Prevent editing and updating wiki pages with non UTF-8 encoding via web interface. !20906 +- Retrieve merge request closing issues from database cache. !20911 +- Fix LFS uploads not working with git-lfs 2.5.0. !20923 +- Fix bug setting http headers in Files API. !20938 +- Rails5: fix flaky spec. !20953 (Jasper Maes) +- Fixed list of projects not loading in group boards. !20955 +- Fix autosave and ESC confirmation issues for MR discussions. !20968 +- Fix navigation to First and Next discussion on MR Changes tab. !20968 +- Fix rendering of the context lines in MR diffs page. !20968 +- fix error caused when using the search bar while unauthenticated. !20970 +- Fix GPG status badge loading regressions. !20987 +- Ensure links in notifications footer are not escaped. !21000 +- Rails5: update Rails5 lock for forgotten gem rouge. !21010 (Jasper Maes) +- Fix UI error whereby prometheus application status is updated. !21029 +- Solves group dashboard line height is too tall for group names. !21033 +- Fix rendering of pipeline failure view when directly navigationg to it. !21043 +- Fix missing and duplicates on project milestone listing page. !21058 +- Fix merge requests not showing any diff files for big patches. !21125 +- Auto-DevOps.gitlab-ci.yml: Update glibc package signing key URL. !21182 (sgerrand) +- Fix issue stopping Instance Statistics javascript to be executed. !21211 +- Fix broken JavaScript in IE11. !21214 +- Improve JUnit test reports in merge request widgets. !49966 +- Properly handle colons in URL passwords. +- Renders test reports for resolved failures and resets error state. +- Fix handling of annotated tags when Gitaly is not in use. +- Fix serialization of LegacyDiffNote. +- Escapes milestone and label's names on flash notice when promoting them. +- Allow to toggle notifications for issues due soon. - Sanitize git URL in import errors. (Jamie Schembri) +- Add missing predefined variable and fix docs. +- Allow updating a project's avatar without other params. (Jamie Schembri) +- Fix the UI for listing system-level labels. +- Update hamlit to fix ruby 2.5 incompatibilities, fixes #42045. (Matthew Dawson) +- Fix updated_at if created_at is set for Note API. +- Fix search bar text input alignment. + +### Changed (32 changes, 7 of them are from the community) + +- Rack attack is now disabled by default. !16669 +- Include full image URL in webhooks for uploaded images. !18109 (Satish Perala) +- Enable hashed storage for all newly created or renamed projects. !19747 +- Support manually stopping any environment from the UI. !20077 +- Close revert and cherry pick modal on escape keypress. !20341 (George Tsiolis) +- Adds with_projects optional parameter to GET /groups/:id API endpoint. !20494 +- Improve feedback when a developer is unable to push to an empty repository. !20519 +- Display GPG status on repository and blob pages. !20524 +- Updated design of new entry dropdown in Web IDE. !20526 +- UX improvements to top nav search bar. !20537 +- Update issue closing pattern. !20554 (George Tsiolis) +- Add merge request header branch actions left margin. !20643 (George Tsiolis) +- Rubix, scikit-learn, tensorflow & other useful libraries pre-installed with JupyterHub. !20714 (Amit Rathi) +- Show decimal place up to single digit in Stacked Progress Bar. !20776 +- Wrap job name on pipeline job sidebar. !20804 (George Tsiolis) +- Redesign Web IDE back button and context header. !20850 +- Removes "show all" on reports and adds an actionButtons slot. !20855 +- Put fallback reply-key address first in the References header. !20871 +- Allow non-admins to view instance statistics (if permitted by the instance admins). !20874 +- Adds the project and group name to the return type for project and group milestones. !20890 +- Restyle status message input on profile settings. !20903 +- Ensure installed Helm Tiller For GitLab Managed Apps Is protected by mutual auth. !20928 +- Allow multiple JIRA transition ids. !20939 +- Use Helm 2.7.2 for GitLab Managed Apps. !20956 +- Create branch and MR picker for Web IDE. !20978 +- Update commit message styles with monospace font and overflow-x. !20988 +- Update to Rouge 3.2.0, including Terraform and Crystal lexer and bug fixes. !20991 +- Update design of project templates. !21012 +- Update to Rouge 3.2.1, which includes a critical fix to the Perl Lexer. !21263 +- Add a 10 ms bucket for SQL timings. +- Show one digit after dot in commit_per_day value in charts page. (msdundar) +- Redesign GCP offer banner. + +### Performance (30 changes, 10 of them are from the community) + +- Stop dynamically creating project and namespace routes. !20313 +- Tracking the number of repositories and wikis with a cached counter for site-wide statistics. !20413 +- Optimize ProjectWiki#empty? check. !20573 +- Delete UserActivities and related workers. !20597 +- Enable frozen string in app/services/**/*.rb. !20656 (gfyoung) +- Enable more frozen string in app/services/**/*.rb. !20677 (gfyoung) +- Limit the TTL for anonymous sessions to 1 hour. !20700 +- Enable even more frozen string in app/services/**/*.rb. !20702 (gfyoung) +- Enable frozen string in app/serializers/**/*.rb. !20726 (gfyoung) +- Enable frozen string in newly added files to previously processed directories. !20763 (gfyoung) +- Use limit parameter to retrieve Wikis from Gitaly. !20764 +- Add Dangerfile for frozen_string_literal. !20767 (gfyoung) +- Remove method instrumentation for Banzai filters and reference parsers. !20770 +- Enable frozen strings in lib/banzai/filter/*.rb. !20775 +- Enable frozen strings in remaining lib/banzai/filter/*.rb files. !20777 +- DNS prefetching if asset_host for CDN hosting is set. !20781 +- Bump nokogiri to 1.8.4 and sanitize to 4.6.6 for performance. !20795 +- Enable frozen string in app/presenters and app/policies. !20819 (gfyoung) +- Bump haml gem to 5.0.4. !20847 +- Enable frozen string in app/models/*.rb. !20851 (gfyoung) +- Performing Commit GPG signature calculation in bulk. !20870 +- Fix /admin/jobs failing to load due to statement timeout. !20909 +- refactor pipeline job log animation to reduce CPU usage. !20915 +- Improve performance when fetching collapsed diffs and commenting in merge requests. !20940 +- Enable frozen string for app/models/**/*.rb. !21001 (gfyoung) +- Don't set gon variables in JSON requests. !21016 (Peter Leitzen) +- Improve performance and memory footprint of Changes tab of Merge Requests. !21028 +- Avoid N+1 on MRs page when metrics merging date cannot be found. !21053 +- Bump Gitaly to 0.117.0. !21055 +- Access metadata directly from Object Storage. + +### Added (41 changes, 18 of them are from the community) + +- Show repository languages for projects. !19480 +- Adds API endpoint /api/v4/(project/group)/:id/members/all to list also inherited members. !19748 (Jacopo Beschi @jacopo-beschi) +- Added live preview for JavaScript projects in the Web IDE. !19764 +- Add support for SSH certificate authentication. !19911 (Ævar Arnfjörð Bjarmason) +- Add Hangouts Chat integration. !20290 (Kukovskii Vladimir) +- Add ability to import multiple repositories by uploading a manifest file. !20304 +- Show Project ID on project home panel. !20305 (Tuğçe Nur Taş) +- Add an option to have a private profile on GitLab. !20387 (jxterry) +- Extend gitlab-ci.yml to request junit.xml test reports. !20390 +- Add the first mutations for merge requests to GraphQL. !20443 +- Add /-/health basic health check endpoint. !20456 +- Add filter for minimal access level in groups and projects API. !20478 (Marko, Peter) +- Add download button for single file (including raw files) in repository. !20480 (Kia Mei Somabes) +- Gitaly Servers link into Admin > Overview navigation menu. !20550 +- Adds foreign key to notification_settings.user_id. !20567 (Jacopo Beschi @jacopo-beschi) +- JUnit XML Test Summary In MR widget. !20576 +- Cleans up display of Deploy Tokens to match Personal Access Tokens. !20578 (Marcel Amirault) +- Users can set a status message and emoji. !20614 (niedermyer & davamr) +- Add emails delivery Prometheus metrics. !20638 +- Verify runner feature set. !20664 +- Add more comprehensive metrics tracking authentication activity. !20668 +- Add support for tar.gz AUTO_DEVOPS_CHART charts (#49324). !20691 (@kondi1) +- Adds Vuex store for reports section in MR widget. !20709 +- Redirect commits to root if no ref is provided (31576). !20738 (Kia Mei Somabes) +- Search for labels by title or description on project labels page. !20749 +- Add object storage logic to project import. !20773 +- Enable renaming files and folders in Web IDE. !20835 +- Warn user when reload IDE with staged changes. !20857 +- Add local project uploads cleanup task. !20863 +- Improve error message when adding invalid user to a project. !20885 (Jacopo Beschi @jacopo-beschi) +- Add link to homepage on static http status pages (404, 500, etc). !20898 (Jason Funk) +- Clean orphaned files in object storage. !20918 +- Adds frontend support to render test reports on the MR widget. !20936 +- Trigger system hooks when project is archived/unarchived. !20995 +- Custom Wiki Sidebar Support Issue 14995. (Josh Sooter) +- Emails on push recipients now accepts formats like John Doe . (George Thomas) +- Add new model for tracking label events. +- Improve danger confirmation modals by focusing input field. (Jamie Schembri) +- Clicking CI icon in Web IDE now opens up pipelines panel. +- Enabled deletion of files in the Web IDE. +- Added button to regenerate 2FA codes. (Luke Picciau) + +### Other (26 changes, 7 of them are from the community) + +- Update specific runners help URL. !20213 (George Tsiolis) +- Enable frozen string in apps/uploaders/*.rb. !20401 (gfyoung) +- Update docs of Helm Tiller. !20515 (Takuya Noguchi) +- Persist 'Auto DevOps' banner dismissal globally. !20540 +- Move xterm to a node dependency and remove it from vendor's folder. !20588 +- Upgrade grape-path-helpers to 1.0.6. !20601 +- Delete todos when user loses access to read the target. !20665 +- Remove tooltips from commit author avatar and name in commit lists. !20674 +- Allow cloning LFS repositories through DeployTokens. !20729 +- Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'. !20768 (@blackst0ne) +- Replace author_link snake case in stylesheets, specs, and helpers. !20797 (George Tsiolis) +- Replace snake case in SCSS variables. !20799 (George Tsiolis) +- Add rbtrace to Gemfile. !20831 +- Add support for searching users by confirmed e-mails. !20893 +- Changes poll.js to keep polling on any 2xx http status code. !20904 +- Remove todos of users without access to targets migration. !20927 +- Improve and simplify Auto DevOps settings flow. !20946 +- Keep admin settings sections open after submitting forms. !21040 +- CE port of "List groups with developer maintainer access on project creation". !21051 +- Update git rerere link in docs. !21060 (gfyoung) +- Add 'tabindex' attribute support on Icon component to show BS4 popover on trigger type 'focus'. !21066 +- Add a Gitlab::Profiler.print_by_total_time convenience method for profiling from a Rails console. +- Automatically expand runner's settings block when linking to the runner's settings page. +- Increases title column on modal for reports. +- Disables toggle comments button if diff has no discussions. +- Moves help_popover component to a common location. ## 11.1.4 (2018-07-30) -- No changes. - -## 11.1.3 (2018-07-27) - -### Fixed (8 changes, 1 of them is from the community) +### Fixed (4 changes, 1 of them is from the community) - Rework some projects table indexes around repository_storage field. !20377 -- Fix navigation to First and Next discussion on MR Changes tab. !20434 -- Fix showing outdated discussions on Changes tab. !20445 -- Fix autosave and ESC confirmation issues for MR discussions. !20569 -- Fix rendering of the context lines in MR diffs page. !20642 - Don't overflow project/group dropdown results. !20704 (gfyoung) - Fixed IDE not opening JSON files. !20798 - Disable Gitaly timeouts when creating or restoring backups. !20810 -### Performance (1 change) - -- Reduces the client side memory footprint on merge requests. !20744 +## 11.1.3 (2018-07-27) +- Not released. ## 11.1.2 (2018-07-26) @@ -331,6 +592,27 @@ entry. - Use monospaced font for MR diff commit link ref on GFM. +## 11.0.5 (2018-07-26) + +### Security (4 changes) + +- Don't expose project names in various counters. +- Don't expose project names in GitHub counters. +- Adding CSRF protection to Hooks test action. +- Fixed XSS in branch name in Web IDE. + +### Fixed (1 change) + +- Escapes milestone and label's names on flash notice when promoting them. + + +## 11.0.4 (2018-07-17) + +### Security (1 change) + +- Fix symlink vulnerability in project import. + + ## 11.0.3 (2018-07-05) ### Fixed (14 changes, 1 of them is from the community) @@ -624,6 +906,14 @@ entry. - Workhorse to send raw diff and patch for commits. +## 10.8.6 (2018-07-17) + +### Security (2 changes) + +- Fix symlink vulnerability in project import. +- Merge branch 'fix-mr-widget-border' into 'master'. + + ## 10.8.5 (2018-06-21) ### Security (5 changes) @@ -853,6 +1143,13 @@ entry. - Gitaly handles repository forks by default. +## 10.7.7 (2018-07-17) + +### Security (1 change) + +- Fix symlink vulnerability in project import. + + ## 10.7.6 (2018-06-21) ### Security (6 changes) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fd4e769ece..0bf8cba76f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,6 +50,7 @@ _This notice should stay as the first item in the CONTRIBUTING.md file._ - [Definition of done](#definition-of-done) - [Style guides](#style-guides) - [Code of conduct](#code-of-conduct) +- [Contribution Flow](#contribution-flow) @@ -132,7 +133,7 @@ Most issues will have labels for at least one of the following: - Type: ~"feature proposal", ~bug, ~customer, etc. - Subject: ~wiki, ~"container registry", ~ldap, ~api, ~frontend, etc. -- Team: ~"CI/CD", ~Discussion, ~Quality, ~Platform, etc. +- Team: ~"CI/CD", ~Plan, ~Manage, ~Quality, etc. - Release Scoping: ~Deliverable, ~Stretch, ~"Next Patch Release" - Priority: ~P1, ~P2, ~P3, ~P4 - Severity: ~S1, ~S2, ~S3, ~S4 @@ -186,16 +187,17 @@ The current team labels are: - ~Configuration - ~"CI/CD" -- ~Discussion +- ~Create - ~Distribution - ~Documentation - ~Geo - ~Gitaly +- ~Manage - ~Monitoring -- ~Platform +- ~Plan - ~Quality - ~Release -- ~"Security Products" +- ~Secure - ~UX The descriptions on the [labels page][labels-page] explain what falls under the @@ -225,24 +227,24 @@ Each issue scheduled for the current milestone should be labeled ~Deliverable or ~"Stretch". Any open issue for a previous milestone should be labeled ~"Next Patch Release", or otherwise rescheduled to a different milestone. -### Bug Priority labels +### Priority labels -Bug Priority labels help us define the time a ~bug fix should be completed. Priority determines how quickly the defect turnaround time must be. +Priority labels help us define the time a ~bug fix should be completed. Priority determines how quickly the defect turnaround time must be. If there are multiple defects, the priority decides which defect has to be fixed immediately versus later. This label documents the planned timeline & urgency which is used to measure against our actual SLA on delivering ~bug fixes. -| Label | Meaning | Estimate time to fix | Guidance | -|-------|-----------------|------------------------------------------------------------------|----------| -| ~P1 | Urgent Priority | The current release + potentially immediate hotfix to GitLab.com | | -| ~P2 | High Priority | The next release | | -| ~P3 | Medium Priority | Within the next 3 releases (approx one quarter) | | -| ~P4 | Low Priority | Anything outside the next 3 releases (approx beyond one quarter) | The issue is prominent but does not impact user workflow and a workaround is documented | +| Label | Meaning | Estimate time to fix | +|-------|-----------------|------------------------------------------------------------------| +| ~P1 | Urgent Priority | The current release + potentially immediate hotfix to GitLab.com | +| ~P2 | High Priority | The next release | +| ~P3 | Medium Priority | Within the next 3 releases (approx one quarter) | +| ~P4 | Low Priority | Anything outside the next 3 releases (approx beyond one quarter) | -### Bug Severity labels +### Severity labels Severity labels help us clearly communicate the impact of a ~bug on users. -| Label | Meaning | Impact of the defect | Example | +| Label | Meaning | Impact on Functionality | Example | |-------|-------------------|-------------------------------------------------------|---------| | ~S1 | Blocker | Outage, broken feature with no workaround | Unable to create an issue. Data corruption/loss. Security breach. | | ~S2 | Critical Severity | Broken Feature, workaround too complex & unacceptable | Can push commits, but only via the command line. | @@ -251,12 +253,14 @@ Severity labels help us clearly communicate the impact of a ~bug on users. #### Severity impact guidance -| Label | Security Impact | Availability / Performance Impact | -|-------|---------------------------------------------------------------------|--------------------------------------------------------------| -| ~S1 | >50% users impacted (possible company extinction level event) | | -| ~S2 | Many users or multiple paid customers impacted (but not apocalyptic)| The issue is (almost) guaranteed to occur in the near future | -| ~S3 | A few users or a single paid customer impacted | The issue is likely to occur in the near future | -| ~S4 | No paid users/customer impacted, or expected impact within 30 days | The issue _may_ occur but it's not likely | +Severity levels can be applied further depending on the facet of the impact; e.g. Affected customers, GitLab.com availability, performance and etc. The below is a guideline. + +| Severity | Affected Customers/Users | GitLab.com Availability | Performance Degradation | +|----------|---------------------------------------------------------------------|----------------------------------------------------|------------------------------| +| ~S1 | >50% users affected (possible company extinction level event) | Significant impact on all of GitLab.com | | +| ~S2 | Many users or multiple paid customers affected (but not apocalyptic)| Significant impact on large portions of GitLab.com | Degradation is guaranteed to occur in the near future | +| ~S3 | A few users or a single paid customer affected | Limited impact on important portions of GitLab.com | Degradation is likely to occur in the near future | +| ~S4 | No paid users/customer affected, or expected to in the near future | Minor impact on on GitLab.com | Degradation _may_ occur but it's not likely | ### Label for community contributors @@ -372,8 +376,15 @@ on those issues. Please select someone with relevant experience from the [GitLab team][team]. If there is nobody mentioned with that expertise look in the commit history for the affected files to find someone. +We also use [GitLab Triage] to automate some triaging policies. This is +currently setup as a [scheduled pipeline] running on [quality/triage-ops] +project. + [described in our handbook]: https://about.gitlab.com/handbook/engineering/issue-triage/ [issue bash events]: https://gitlab.com/gitlab-org/gitlab-ce/issues/17815 +[GitLab Triage]: https://gitlab.com/gitlab-org/gitlab-triage +[scheduled pipeline]: https://gitlab.com/gitlab-org/quality/triage-ops/pipeline_schedules/10512/edit +[quality/triage-ops]: https://gitlab.com/gitlab-org/quality/triage-ops ### Feature proposals @@ -729,6 +740,24 @@ reported by emailing `contact@gitlab.com`. This Code of Conduct is adapted from the [Contributor Covenant][contributor-covenant], version 1.1.0, available at [http://contributor-covenant.org/version/1/1/0/](http://contributor-covenant.org/version/1/1/0/). +## Contribution Flow + +When contributing to GitLab, your merge request is subject to review by merge request maintainers of a particular specialty. + +When you submit code to GitLab, we really want it to get merged, but there will be times when it will not be merged. + +When maintainers are reading through a merge request they may request guidance from other maintainers. If merge request maintainers conclude that the code should not be merged, our reasons will be fully disclosed. If it has been decided that the code quality is not up to GitLab’s standards, the merge request maintainer will refer the author to our docs and code style guides, and provide some guidance. + +Sometimes style guides will be followed but the code will lack structural integrity, or the maintainer will have reservations about the code’s overall quality. When there is a reservation the maintainer will inform the author and provide some guidance. The author may then choose to update the merge request. Once the merge request has been updated and reassigned to the maintainer, they will review the code again. Once the code has been resubmitted any number of times, the maintainer may choose to close the merge request with a summary of why it will not be merged, as well as some guidance. If the merge request is closed the maintainer will be open to discussion as to how to improve the code so it can be approved in the future. + +GitLab will do its best to review community contributions as quickly as possible. Specially appointed developers review community contributions daily. You may take a look at the [team page](https://about.gitlab.com/team/) for the merge request coach who specializes in the type of code you have written and mention them in the merge request. For example, if you have written some JavaScript in your code then you should mention the frontend merge request coach. If your code has multiple disciplines you may mention multiple merge request coaches. + +GitLab receives a lot of community contributions, so if your code has not been reviewed within 4 days of its initial submission feel free to re-mention the appropriate merge request coach. + +When submitting code to GitLab, you may feel that your contribution requires the aid of an external library. If your code includes an external library please provide a link to the library, as well as reasons for including it. + +When your code contains more than 500 changes, any major breaking changes, or an external library, `@mention` a maintainer in the merge request. If you are not sure who to mention, the reviewer will add one early in the merge request process. + [core team]: https://about.gitlab.com/core-team/ [team]: https://about.gitlab.com/team/ [getting-help]: https://about.gitlab.com/getting-help/ diff --git a/Dangerfile b/Dangerfile new file mode 100644 index 0000000000..9217610da8 --- /dev/null +++ b/Dangerfile @@ -0,0 +1,7 @@ +danger.import_dangerfile(path: 'danger/metadata') +danger.import_dangerfile(path: 'danger/changes_size') +danger.import_dangerfile(path: 'danger/changelog') +danger.import_dangerfile(path: 'danger/specs') +danger.import_dangerfile(path: 'danger/gemfile') +danger.import_dangerfile(path: 'danger/database') +danger.import_dangerfile(path: 'danger/frozen_string') diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index e11e94c5da..8387e21a25 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -0.111.4 +0.117.3 diff --git a/GITLAB_SHELL_VERSION b/GITLAB_SHELL_VERSION index b7f8ee41e6..0e79152459 100644 --- a/GITLAB_SHELL_VERSION +++ b/GITLAB_SHELL_VERSION @@ -1 +1 @@ -7.1.4 +8.1.1 diff --git a/GITLAB_WORKHORSE_VERSION b/GITLAB_WORKHORSE_VERSION index 0062ac9718..831446cbd2 100644 --- a/GITLAB_WORKHORSE_VERSION +++ b/GITLAB_WORKHORSE_VERSION @@ -1 +1 @@ -5.0.0 +5.1.0 diff --git a/Gemfile b/Gemfile index 1fbc240bf6..dfa42680c2 100644 --- a/Gemfile +++ b/Gemfile @@ -104,7 +104,7 @@ gem 'hashie-forbidden_attributes' gem 'kaminari', '~> 1.0' # HAML -gem 'hamlit', '~> 2.6.1' +gem 'hamlit', '~> 2.8.8' # Files attachments gem 'carrierwave', '~> 1.2' @@ -220,6 +220,9 @@ gem 'gemnasium-gitlab-service', '~> 0.2' # Slack integration gem 'slack-notifier', '~> 1.5.1' +# Hangouts Chat integration +gem 'hangouts-chat', '~> 0.0.5' + # Asana integration gem 'asana', '~> 0.6.0' @@ -230,7 +233,7 @@ gem 'ruby-fogbugz', '~> 0.2.1' gem 'kubeclient', '~> 3.1.0' # Sanitize user input -gem 'sanitize', '~> 4.6.5' +gem 'sanitize', '~> 4.6' gem 'babosa', '~> 1.0.2' # Sanitizes SVG input @@ -303,7 +306,7 @@ group :metrics do gem 'influxdb', '~> 0.2', require: false # Prometheus - gem 'prometheus-client-mmap', '~> 0.9.3' + gem 'prometheus-client-mmap', '~> 0.9.4' gem 'raindrops', '~> 0.18' end @@ -323,6 +326,7 @@ group :development do end group :development, :test do + gem 'bootsnap', '~> 1.3' gem 'bullet', '~> 5.5.0', require: !!ENV['ENABLE_BULLET'] gem 'pry-byebug', '~> 3.4.1', platform: :mri gem 'pry-rails', '~> 0.3.4' @@ -351,9 +355,9 @@ group :development, :test do gem 'spring', '~> 2.0.0' gem 'spring-commands-rspec', '~> 1.0.4' - gem 'gitlab-styles', '~> 2.3', require: false + gem 'gitlab-styles', '~> 2.4', require: false # Pin these dependencies, otherwise a new rule could break the CI pipelines - gem 'rubocop', '~> 0.52.1' + gem 'rubocop', '~> 0.54.0' gem 'rubocop-rspec', '~> 1.22.1' gem 'scss_lint', '~> 0.56.0', require: false @@ -396,6 +400,7 @@ gem 'email_reply_trimmer', '~> 0.1' gem 'html2text' gem 'ruby-prof', '~> 0.17.0' +gem 'rbtrace', '~> 0.4', require: false # OAuth gem 'oauth2', '~> 1.4' @@ -418,7 +423,7 @@ group :ed25519 do end # Gitaly GRPC client -gem 'gitaly-proto', '~> 0.105.0', require: 'gitaly' +gem 'gitaly-proto', '~> 0.113.0', require: 'gitaly' gem 'grpc', '~> 1.11.0' # Locked until https://github.com/google/protobuf/issues/4210 is closed diff --git a/Gemfile.lock b/Gemfile.lock index a889c4dc3a..acb2cc95bb 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -87,6 +87,8 @@ GEM binding_of_caller (0.7.2) debug_inspector (>= 0.0.1) blankslate (2.1.2.4) + bootsnap (1.3.1) + msgpack (~> 1.0) bootstrap_form (2.7.0) brakeman (4.2.1) browser (2.2.0) @@ -282,7 +284,7 @@ GEM gettext_i18n_rails (>= 0.7.1) po_to_json (>= 1.0.0) rails (>= 3.2.0) - gitaly-proto (0.105.0) + gitaly-proto (0.113.0) google-protobuf (~> 3.1) grpc (~> 1.10) github-linguist (5.3.3) @@ -312,8 +314,8 @@ GEM mime-types (>= 1.16) posix-spawn (~> 0.3) gitlab-markup (1.6.4) - gitlab-styles (2.3.2) - rubocop (~> 0.51) + gitlab-styles (2.4.1) + rubocop (~> 0.54.0) rubocop-gitlab-security (~> 0.1.0) rubocop-rspec (~> 1.19) gitlab_omniauth-ldap (2.0.4) @@ -359,7 +361,7 @@ GEM grape-entity (0.7.1) activesupport (>= 4.0) multi_json (>= 1.3.2) - grape-path-helpers (1.0.5) + grape-path-helpers (1.0.6) activesupport (>= 4, < 5.1) grape (~> 1.0) rake (~> 12) @@ -373,7 +375,8 @@ GEM google-protobuf (~> 3.1) googleapis-common-protos-types (~> 1.0.0) googleauth (>= 0.5.1, < 0.7) - haml (4.0.7) + haml (5.0.4) + temple (>= 0.8.0) tilt haml_lint (0.26.0) haml (>= 4.0, < 5.1) @@ -381,10 +384,11 @@ GEM rake (>= 10, < 13) rubocop (>= 0.49.0) sysexits (~> 1.1) - hamlit (2.6.1) - temple (~> 0.7.6) + hamlit (2.8.8) + temple (>= 0.8.0) thor tilt + hangouts-chat (0.0.5) hashdiff (0.3.4) hashie (3.5.7) hashie-forbidden_attributes (0.1.1) @@ -394,7 +398,7 @@ GEM hipchat (1.5.2) httparty mimemagic - html-pipeline (2.8.3) + html-pipeline (2.8.4) activesupport (>= 2) nokogiri (>= 1.4) html2text (0.2.0) @@ -500,6 +504,7 @@ GEM mini_portile2 (2.3.0) minitest (5.7.0) mousetrap-rails (1.4.6) + msgpack (1.2.4) multi_json (1.13.1) multi_xml (0.6.0) multipart-post (2.0.0) @@ -510,7 +515,7 @@ GEM net-ldap (0.16.0) net-ssh (5.0.1) netrc (0.11.0) - nokogiri (1.8.3) + nokogiri (1.8.4) mini_portile2 (~> 2.3.0) nokogumbo (1.5.0) nokogiri @@ -630,7 +635,7 @@ GEM parser unparser procto (0.0.3) - prometheus-client-mmap (0.9.3) + prometheus-client-mmap (0.9.4) pry (0.10.4) coderay (~> 1.1.0) method_source (~> 0.8.1) @@ -696,6 +701,10 @@ GEM ffi (>= 0.5.0, < 2) rblineprof (0.3.6) debugger-ruby_core_source (~> 1.3) + rbtrace (0.4.10) + ffi (>= 1.0.6) + msgpack (>= 0.4.3) + trollop (>= 1.16.2) rdoc (6.0.4) re2 (1.1.1) recaptcha (3.0.0) @@ -736,7 +745,7 @@ GEM retriable (3.1.1) rinku (2.0.0) rotp (2.1.2) - rouge (3.1.1) + rouge (3.2.1) rqrcode (0.7.0) chunky_png rqrcode-rails3 (0.1.7) @@ -776,16 +785,16 @@ GEM pg rails sqlite3 - rubocop (0.52.1) + rubocop (0.54.0) parallel (~> 1.10) - parser (>= 2.4.0.2, < 3.0) + parser (>= 2.5) powerpack (~> 0.1) rainbow (>= 2.2.2, < 4.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.0, >= 1.0.1) rubocop-gitlab-security (0.1.1) rubocop (>= 0.51) - rubocop-rspec (1.22.1) + rubocop-rspec (1.22.2) rubocop (>= 0.52.1) ruby-enum (0.7.2) i18n @@ -802,9 +811,9 @@ GEM rubyzip (1.2.1) rufus-scheduler (3.4.0) et-orbi (~> 1.0) - rugged (0.27.2) + rugged (0.27.4) safe_yaml (1.0.4) - sanitize (4.6.5) + sanitize (4.6.6) crass (~> 1.0.2) nokogiri (>= 1.4.4) nokogumbo (~> 1.4) @@ -889,7 +898,7 @@ GEM sys-filesystem (1.1.6) ffi sysexits (1.2.0) - temple (0.7.7) + temple (0.8.0) test-prof (0.2.5) test_after_commit (1.1.0) activerecord (>= 3.2) @@ -900,13 +909,14 @@ GEM rack (>= 1, < 3) thor (0.19.4) thread_safe (0.3.6) - tilt (2.0.6) + tilt (2.0.8) timecop (0.8.1) timfel-krb5-auth (0.8.3) toml (0.1.2) parslet (~> 1.5.0) toml-rb (1.0.0) citrus (~> 3.0, > 3.0) + trollop (2.1.3) truncato (0.7.10) htmlentities (~> 4.3.1) nokogiri (~> 1.8.0, >= 1.7.0) @@ -986,6 +996,7 @@ DEPENDENCIES benchmark-ips (~> 2.3.0) better_errors (~> 2.1.0) binding_of_caller (~> 0.7.2) + bootsnap (~> 1.3) bootstrap_form (~> 2.7.0) brakeman (~> 4.2) browser (~> 2.2) @@ -1037,13 +1048,13 @@ DEPENDENCIES gettext (~> 3.2.2) gettext_i18n_rails (~> 1.8.0) gettext_i18n_rails_js (~> 1.3) - gitaly-proto (~> 0.105.0) + gitaly-proto (~> 0.113.0) github-linguist (~> 5.3.3) gitlab-flowdock-git-hook (~> 1.0.1) gitlab-gollum-lib (~> 4.2) gitlab-gollum-rugged_adapter (~> 0.4.4) gitlab-markup (~> 1.6.4) - gitlab-styles (~> 2.3) + gitlab-styles (~> 2.4) gitlab_omniauth-ldap (~> 2.0.4) gon (~> 6.2) google-api-client (~> 0.19.8) @@ -1057,7 +1068,8 @@ DEPENDENCIES graphql (~> 1.8.0) grpc (~> 1.11.0) haml_lint (~> 0.26.0) - hamlit (~> 2.6.1) + hamlit (~> 2.8.8) + hangouts-chat (~> 0.0.5) hashie-forbidden_attributes health_check (~> 2.6.0) hipchat (~> 1.5.0) @@ -1114,7 +1126,7 @@ DEPENDENCIES peek-sidekiq (~> 1.0.3) pg (~> 0.18.2) premailer-rails (~> 1.9.7) - prometheus-client-mmap (~> 0.9.3) + prometheus-client-mmap (~> 0.9.4) pry-byebug (~> 3.4.1) pry-rails (~> 0.3.4) rack-attack (~> 4.4.1) @@ -1127,6 +1139,7 @@ DEPENDENCIES rainbow (~> 2.2) raindrops (~> 0.18) rblineprof (~> 0.3.6) + rbtrace (~> 0.4) rdoc (~> 6.0) re2 (~> 1.1.1) recaptcha (~> 3.0) @@ -1143,7 +1156,7 @@ DEPENDENCIES rspec-retry (~> 0.4.5) rspec-set (~> 0.1.3) rspec_profiling (~> 0.0.5) - rubocop (~> 0.52.1) + rubocop (~> 0.54.0) rubocop-rspec (~> 1.22.1) ruby-fogbugz (~> 0.2.1) ruby-prof (~> 0.17.0) @@ -1151,7 +1164,7 @@ DEPENDENCIES ruby_parser (~> 3.8) rufus-scheduler (~> 3.4) rugged (~> 0.27) - sanitize (~> 4.6.5) + sanitize (~> 4.6) sass-rails (~> 5.0.6) scss_lint (~> 0.56.0) seed-fu (~> 2.3.7) diff --git a/Gemfile.rails5.lock b/Gemfile.rails5.lock index 8c46b8c591..dff3a436a0 100644 --- a/Gemfile.rails5.lock +++ b/Gemfile.rails5.lock @@ -79,7 +79,7 @@ GEM babosa (1.0.2) base32 (0.3.2) batch-loader (1.2.1) - bcrypt (3.1.11) + bcrypt (3.1.12) bcrypt_pbkdf (1.0.0) benchmark-ips (2.3.0) better_errors (2.1.1) @@ -90,6 +90,8 @@ GEM binding_of_caller (0.7.2) debug_inspector (>= 0.0.1) blankslate (2.1.2.4) + bootsnap (1.3.1) + msgpack (~> 1.0) bootstrap_form (2.7.0) brakeman (4.2.1) browser (2.2.0) @@ -111,7 +113,7 @@ GEM capybara-screenshot (1.0.14) capybara (>= 1.0, < 3) launchy - carrierwave (1.2.1) + carrierwave (1.2.3) activemodel (>= 4.0.0) activesupport (>= 4.0.0) mime-types (>= 1.16) @@ -285,7 +287,7 @@ GEM gettext_i18n_rails (>= 0.7.1) po_to_json (>= 1.0.0) rails (>= 3.2.0) - gitaly-proto (0.105.0) + gitaly-proto (0.113.0) google-protobuf (~> 3.1) grpc (~> 1.10) github-linguist (5.3.3) @@ -315,8 +317,8 @@ GEM mime-types (>= 1.16) posix-spawn (~> 0.3) gitlab-markup (1.6.4) - gitlab-styles (2.3.2) - rubocop (~> 0.51) + gitlab-styles (2.4.1) + rubocop (~> 0.54.0) rubocop-gitlab-security (~> 0.1.0) rubocop-rspec (~> 1.19) gitlab_omniauth-ldap (2.0.4) @@ -362,7 +364,7 @@ GEM grape-entity (0.7.1) activesupport (>= 4.0) multi_json (>= 1.3.2) - grape-path-helpers (1.0.5) + grape-path-helpers (1.0.6) activesupport (>= 4, < 5.1) grape (~> 1.0) rake (~> 12) @@ -376,7 +378,8 @@ GEM google-protobuf (~> 3.1) googleapis-common-protos-types (~> 1.0.0) googleauth (>= 0.5.1, < 0.7) - haml (4.0.7) + haml (5.0.4) + temple (>= 0.8.0) tilt haml_lint (0.26.0) haml (>= 4.0, < 5.1) @@ -384,10 +387,11 @@ GEM rake (>= 10, < 13) rubocop (>= 0.49.0) sysexits (~> 1.1) - hamlit (2.6.1) - temple (~> 0.7.6) + hamlit (2.8.8) + temple (>= 0.8.0) thor tilt + hangouts-chat (0.0.5) hashdiff (0.3.4) hashie (3.5.7) hashie-forbidden_attributes (0.1.1) @@ -397,7 +401,7 @@ GEM hipchat (1.5.2) httparty mimemagic - html-pipeline (2.8.3) + html-pipeline (2.8.4) activesupport (>= 2) nokogiri (>= 1.4) html2text (0.2.0) @@ -503,6 +507,7 @@ GEM mini_portile2 (2.3.0) minitest (5.7.0) mousetrap-rails (1.4.6) + msgpack (1.2.4) multi_json (1.13.1) multi_xml (0.6.0) multipart-post (2.0.0) @@ -514,7 +519,7 @@ GEM net-ssh (5.0.1) netrc (0.11.0) nio4r (2.3.1) - nokogiri (1.8.2) + nokogiri (1.8.4) mini_portile2 (~> 2.3.0) nokogumbo (1.5.0) nokogiri @@ -634,7 +639,7 @@ GEM parser unparser procto (0.0.3) - prometheus-client-mmap (0.9.3) + prometheus-client-mmap (0.9.4) pry (0.10.4) coderay (~> 1.1.0) method_source (~> 0.8.1) @@ -705,6 +710,10 @@ GEM ffi (>= 0.5.0, < 2) rblineprof (0.3.6) debugger-ruby_core_source (~> 1.3) + rbtrace (0.4.10) + ffi (>= 1.0.6) + msgpack (>= 0.4.3) + trollop (>= 1.16.2) rdoc (6.0.4) re2 (1.1.1) recaptcha (3.0.0) @@ -745,7 +754,7 @@ GEM retriable (3.1.1) rinku (2.0.0) rotp (2.1.2) - rouge (3.1.1) + rouge (3.2.0) rqrcode (0.7.0) chunky_png rqrcode-rails3 (0.1.7) @@ -785,16 +794,16 @@ GEM pg rails sqlite3 - rubocop (0.52.1) + rubocop (0.54.0) parallel (~> 1.10) - parser (>= 2.4.0.2, < 3.0) + parser (>= 2.5) powerpack (~> 0.1) rainbow (>= 2.2.2, < 4.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.0, >= 1.0.1) rubocop-gitlab-security (0.1.1) rubocop (>= 0.51) - rubocop-rspec (1.22.1) + rubocop-rspec (1.22.2) rubocop (>= 0.52.1) ruby-enum (0.7.2) i18n @@ -811,9 +820,9 @@ GEM rubyzip (1.2.1) rufus-scheduler (3.4.0) et-orbi (~> 1.0) - rugged (0.27.1) + rugged (0.27.2) safe_yaml (1.0.4) - sanitize (4.6.5) + sanitize (4.6.6) crass (~> 1.0.2) nokogiri (>= 1.4.4) nokogumbo (~> 1.4) @@ -877,7 +886,7 @@ GEM activesupport (>= 4.2) spring-commands-rspec (1.0.4) spring (>= 0.9.1) - sprockets (3.7.1) + sprockets (3.7.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) sprockets-rails (3.2.1) @@ -898,7 +907,7 @@ GEM sys-filesystem (1.1.6) ffi sysexits (1.2.0) - temple (0.7.7) + temple (0.8.0) test-prof (0.2.5) text (1.3.1) thin (1.7.0) @@ -907,13 +916,14 @@ GEM rack (>= 1, < 3) thor (0.19.4) thread_safe (0.3.6) - tilt (2.0.6) + tilt (2.0.8) timecop (0.8.1) timfel-krb5-auth (0.8.3) toml (0.1.2) parslet (~> 1.5.0) toml-rb (1.0.0) citrus (~> 3.0, > 3.0) + trollop (2.1.3) truncato (0.7.10) htmlentities (~> 4.3.1) nokogiri (~> 1.8.0, >= 1.7.0) @@ -996,6 +1006,7 @@ DEPENDENCIES benchmark-ips (~> 2.3.0) better_errors (~> 2.1.0) binding_of_caller (~> 0.7.2) + bootsnap (~> 1.3) bootstrap_form (~> 2.7.0) brakeman (~> 4.2) browser (~> 2.2) @@ -1047,13 +1058,13 @@ DEPENDENCIES gettext (~> 3.2.2) gettext_i18n_rails (~> 1.8.0) gettext_i18n_rails_js (~> 1.3) - gitaly-proto (~> 0.105.0) + gitaly-proto (~> 0.113.0) github-linguist (~> 5.3.3) gitlab-flowdock-git-hook (~> 1.0.1) gitlab-gollum-lib (~> 4.2) gitlab-gollum-rugged_adapter (~> 0.4.4) gitlab-markup (~> 1.6.4) - gitlab-styles (~> 2.3) + gitlab-styles (~> 2.4) gitlab_omniauth-ldap (~> 2.0.4) gon (~> 6.2) google-api-client (~> 0.19.8) @@ -1067,7 +1078,8 @@ DEPENDENCIES graphql (~> 1.8.0) grpc (~> 1.11.0) haml_lint (~> 0.26.0) - hamlit (~> 2.6.1) + hamlit (~> 2.8.8) + hangouts-chat (~> 0.0.5) hashie-forbidden_attributes health_check (~> 2.6.0) hipchat (~> 1.5.0) @@ -1124,7 +1136,7 @@ DEPENDENCIES peek-sidekiq (~> 1.0.3) pg (~> 0.18.2) premailer-rails (~> 1.9.7) - prometheus-client-mmap (~> 0.9.3) + prometheus-client-mmap (~> 0.9.4) pry-byebug (~> 3.4.1) pry-rails (~> 0.3.4) rack-attack (~> 4.4.1) @@ -1138,6 +1150,7 @@ DEPENDENCIES rainbow (~> 2.2) raindrops (~> 0.18) rblineprof (~> 0.3.6) + rbtrace (~> 0.4) rdoc (~> 6.0) re2 (~> 1.1.1) recaptcha (~> 3.0) @@ -1154,7 +1167,7 @@ DEPENDENCIES rspec-retry (~> 0.4.5) rspec-set (~> 0.1.3) rspec_profiling (~> 0.0.5) - rubocop (~> 0.52.1) + rubocop (~> 0.54.0) rubocop-rspec (~> 1.22.1) ruby-fogbugz (~> 0.2.1) ruby-prof (~> 0.17.0) @@ -1162,7 +1175,7 @@ DEPENDENCIES ruby_parser (~> 3.8) rufus-scheduler (~> 3.4) rugged (~> 0.27) - sanitize (~> 4.6.5) + sanitize (~> 4.6) sass-rails (~> 5.0.6) scss_lint (~> 0.56.0) seed-fu (~> 2.3.7) @@ -1204,4 +1217,4 @@ DEPENDENCIES wikicloth (= 0.8.1) BUNDLED WITH - 1.16.2 + 1.16.3 diff --git a/README.md b/README.md index 77f03b791f..b6e1cc9a43 100644 --- a/README.md +++ b/README.md @@ -1,11 +1,5 @@ # GitLab -[![Build status](https://gitlab.com/gitlab-org/gitlab-ce/badges/master/build.svg)](https://gitlab.com/gitlab-org/gitlab-ce/commits/master) -[![Overall test coverage](https://gitlab.com/gitlab-org/gitlab-ce/badges/master/coverage.svg)](https://gitlab.com/gitlab-org/gitlab-ce/pipelines) -[![Code Climate](https://codeclimate.com/github/gitlabhq/gitlabhq.svg)](https://codeclimate.com/github/gitlabhq/gitlabhq) -[![Core Infrastructure Initiative Best Practices](https://bestpractices.coreinfrastructure.org/projects/42/badge)](https://bestpractices.coreinfrastructure.org/projects/42) -[![Gitter](https://badges.gitter.im/gitlabhq/gitlabhq.svg)](https://gitter.im/gitlabhq/gitlabhq?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge) - ## Test coverage - [![Ruby coverage](https://gitlab.com/gitlab-org/gitlab-ce/badges/master/coverage.svg?job=coverage)](https://gitlab-org.gitlab.io/gitlab-ce/coverage-ruby) Ruby diff --git a/Rakefile b/Rakefile index 85fff2d51e..de0d6695c7 100755 --- a/Rakefile +++ b/Rakefile @@ -2,9 +2,9 @@ # Add your own tasks in files placed in lib/tasks ending in .rake, # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake. -require File.expand_path('../config/application', __FILE__) +require File.expand_path('config/application', __dir__) -relative_url_conf = File.expand_path('../config/initializers/relative_url', __FILE__) +relative_url_conf = File.expand_path('config/initializers/relative_url', __dir__) require relative_url_conf if File.exist?("#{relative_url_conf}.rb") Gitlab::Application.load_tasks diff --git a/VERSION b/VERSION index 52fdd1cddd..c52c4031ab 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -11.1.8 +11.2.8 diff --git a/app/assets/javascripts/api.js b/app/assets/javascripts/api.js index 422becb7db..25fe2ae553 100644 --- a/app/assets/javascripts/api.js +++ b/app/assets/javascripts/api.js @@ -244,6 +244,18 @@ const Api = { }); }, + branches(id, query = '', options = {}) { + const url = Api.buildUrl(this.createBranchPath).replace(':id', encodeURIComponent(id)); + + return axios.get(url, { + params: { + search: query, + per_page: 20, + ...options, + }, + }); + }, + createBranch(id, { ref, branch }) { const url = Api.buildUrl(this.createBranchPath).replace(':id', encodeURIComponent(id)); diff --git a/app/assets/javascripts/autosave.js b/app/assets/javascripts/autosave.js index fa00a3cf38..e8c59fab60 100644 --- a/app/assets/javascripts/autosave.js +++ b/app/assets/javascripts/autosave.js @@ -53,4 +53,8 @@ export default class Autosave { return window.localStorage.removeItem(this.key); } + + dispose() { + this.field.off('input'); + } } diff --git a/app/assets/javascripts/awards_handler.js b/app/assets/javascripts/awards_handler.js index 70f20c5c7c..e34db89398 100644 --- a/app/assets/javascripts/awards_handler.js +++ b/app/assets/javascripts/awards_handler.js @@ -33,19 +33,24 @@ const categoryLabelMap = { const IS_VISIBLE = 'is-visible'; const IS_RENDERED = 'is-rendered'; -class AwardsHandler { +export class AwardsHandler { constructor(emoji) { this.emoji = emoji; this.eventListeners = []; + this.toggleButtonSelector = '.js-add-award'; + this.menuClass = 'js-award-emoji-menu'; + } + + bindEvents() { // If the user shows intent let's pre-build the menu this.registerEventListener( 'one', $(document), 'mouseenter focus', - '.js-add-award', + this.toggleButtonSelector, 'mouseenter focus', () => { - const $menu = $('.emoji-menu'); + const $menu = $(`.${this.menuClass}`); if ($menu.length === 0) { requestAnimationFrame(() => { this.createEmojiMenu(); @@ -53,7 +58,7 @@ class AwardsHandler { } }, ); - this.registerEventListener('on', $(document), 'click', '.js-add-award', e => { + this.registerEventListener('on', $(document), 'click', this.toggleButtonSelector, e => { e.stopPropagation(); e.preventDefault(); this.showEmojiMenu($(e.currentTarget)); @@ -61,15 +66,17 @@ class AwardsHandler { this.registerEventListener('on', $('html'), 'click', e => { const $target = $(e.target); - if (!$target.closest('.emoji-menu').length) { + if (!$target.closest(`.${this.menuClass}`).length) { $('.js-awards-block.current').removeClass('current'); - if ($('.emoji-menu').is(':visible')) { - $('.js-add-award.is-active').removeClass('is-active'); - this.hideMenuElement($('.emoji-menu')); + if ($(`.${this.menuClass}`).is(':visible')) { + $(`${this.toggleButtonSelector}.is-active`).removeClass('is-active'); + this.hideMenuElement($(`.${this.menuClass}`)); } } }); - this.registerEventListener('on', $(document), 'click', '.js-emoji-btn', e => { + + const emojiButtonSelector = `.js-awards-block .js-emoji-btn, .${this.menuClass} .js-emoji-btn`; + this.registerEventListener('on', $(document), 'click', emojiButtonSelector, e => { e.preventDefault(); const $target = $(e.currentTarget); const $glEmojiElement = $target.find('gl-emoji'); @@ -101,7 +108,7 @@ class AwardsHandler { $addBtn.closest('.js-awards-block').addClass('current'); } - const $menu = $('.emoji-menu'); + const $menu = $(`.${this.menuClass}`); const $thumbsBtn = $menu.find('[data-name="thumbsup"], [data-name="thumbsdown"]').parent(); const $userAuthored = this.isUserAuthored($addBtn); if ($menu.length) { @@ -118,7 +125,7 @@ class AwardsHandler { } else { $addBtn.addClass('is-loading is-active'); this.createEmojiMenu(() => { - const $createdMenu = $('.emoji-menu'); + const $createdMenu = $(`.${this.menuClass}`); $addBtn.removeClass('is-loading'); this.positionMenu($createdMenu, $addBtn); return setTimeout(() => { @@ -156,7 +163,7 @@ class AwardsHandler { } const emojiMenuMarkup = ` -
+
@@ -185,7 +192,7 @@ class AwardsHandler { // Avoid the jank and render the remaining categories separately // This will take more time, but makes UI more responsive - const menu = document.querySelector('.emoji-menu'); + const menu = document.querySelector(`.${this.menuClass}`); const emojiContentElement = menu.querySelector('.emoji-menu-content'); const remainingCategories = Object.keys(categoryMap).slice(1); const allCategoriesAddedPromise = remainingCategories.reduce( @@ -270,9 +277,9 @@ class AwardsHandler { if (isInVueNoteablePage() && !isMainAwardsBlock) { const id = votesBlock.attr('id').replace('note_', ''); - this.hideMenuElement($('.emoji-menu')); + this.hideMenuElement($(`.${this.menuClass}`)); - $('.js-add-award.is-active').removeClass('is-active'); + $(`${this.toggleButtonSelector}.is-active`).removeClass('is-active'); const toggleAwardEvent = new CustomEvent('toggleAward', { detail: { awardName: emoji, @@ -291,9 +298,9 @@ class AwardsHandler { return typeof callback === 'function' ? callback() : undefined; }); - this.hideMenuElement($('.emoji-menu')); + this.hideMenuElement($(`.${this.menuClass}`)); - return $('.js-add-award.is-active').removeClass('is-active'); + return $(`${this.toggleButtonSelector}.is-active`).removeClass('is-active'); } addAwardToEmojiBar(votesBlock, emoji, checkForMutuality) { @@ -321,7 +328,7 @@ class AwardsHandler { getVotesBlock() { if (isInVueNoteablePage()) { - const $el = $('.js-add-award.is-active').closest('.note.timeline-entry'); + const $el = $(`${this.toggleButtonSelector}.is-active`).closest('.note.timeline-entry'); if ($el.length) { return $el; @@ -458,7 +465,7 @@ class AwardsHandler { } createEmoji(votesBlock, emoji) { - if ($('.emoji-menu').length) { + if ($(`.${this.menuClass}`).length) { this.createAwardButtonForVotesBlock(votesBlock, emoji); } this.createEmojiMenu(() => { @@ -538,7 +545,7 @@ class AwardsHandler { this.searchEmojis(term); }); - const $menu = $('.emoji-menu'); + const $menu = $(`.${this.menuClass}`); this.registerEventListener('on', $menu, transitionEndEventString, e => { if (e.target === e.currentTarget) { // Clear the search @@ -608,7 +615,7 @@ class AwardsHandler { this.eventListeners.forEach(entry => { entry.element.off.call(entry.element, ...entry.args); }); - $('.emoji-menu').remove(); + $(`.${this.menuClass}`).remove(); } } @@ -616,7 +623,11 @@ let awardsHandlerPromise = null; export default function loadAwardsHandler(reload = false) { if (!awardsHandlerPromise || reload) { awardsHandlerPromise = import(/* webpackChunkName: 'emoji' */ './emoji').then( - Emoji => new AwardsHandler(Emoji), + Emoji => { + const awardsHandler = new AwardsHandler(Emoji); + awardsHandler.bindEvents(); + return awardsHandler; + }, ); } return awardsHandlerPromise; diff --git a/app/assets/javascripts/badges/components/badge.vue b/app/assets/javascripts/badges/components/badge.vue index b4bfaee1d8..155c348286 100644 --- a/app/assets/javascripts/badges/components/badge.vue +++ b/app/assets/javascripts/badges/components/badge.vue @@ -93,7 +93,7 @@ export default {
diff --git a/app/assets/javascripts/boards/components/board.js b/app/assets/javascripts/boards/components/board.js index a2355d7fd5..9ad451fa37 100644 --- a/app/assets/javascripts/boards/components/board.js +++ b/app/assets/javascripts/boards/components/board.js @@ -2,6 +2,9 @@ import Sortable from 'sortablejs'; import Vue from 'vue'; +import { n__ } from '~/locale'; +import Icon from '~/vue_shared/components/icon.vue'; +import Tooltip from '~/vue_shared/directives/tooltip'; import AccessorUtilities from '../../lib/utils/accessor'; import boardList from './board_list.vue'; import BoardBlankState from './board_blank_state.vue'; @@ -17,6 +20,10 @@ gl.issueBoards.Board = Vue.extend({ boardList, 'board-delete': gl.issueBoards.BoardDelete, BoardBlankState, + Icon, + }, + directives: { + Tooltip, }, props: { list: { @@ -46,6 +53,12 @@ gl.issueBoards.Board = Vue.extend({ filter: Store.filter, }; }, + computed: { + counterTooltip() { + const { issuesSize } = this.list; + return `${n__('%d issue', '%d issues', issuesSize)}`; + }, + }, watch: { filter: { handler() { diff --git a/app/assets/javascripts/boards/components/board_list.vue b/app/assets/javascripts/boards/components/board_list.vue index 5c7565234d..3e610a4088 100644 --- a/app/assets/javascripts/boards/components/board_list.vue +++ b/app/assets/javascripts/boards/components/board_list.vue @@ -112,12 +112,20 @@ export default { if (e.target) { const containerEl = e.target.closest('.js-board-list') || e.target.querySelector('.js-board-list'); const toBoardType = containerEl.dataset.boardType; + const cloneActions = { + label: ['milestone', 'assignee'], + assignee: ['milestone', 'label'], + milestone: ['label', 'assignee'], + }; if (toBoardType) { const fromBoardType = this.list.type; + // For each list we check if the destination list is + // a the list were we should clone the issue + const shouldClone = Object.entries(cloneActions).some(entry => ( + fromBoardType === entry[0] && entry[1].includes(toBoardType))); - if ((fromBoardType === 'assignee' && toBoardType === 'label') || - (fromBoardType === 'label' && toBoardType === 'assignee')) { + if (shouldClone) { return 'clone'; } } @@ -145,7 +153,8 @@ export default { }); }, onUpdate: (e) => { - const sortedArray = this.sortable.toArray().filter(id => id !== '-1'); + const sortedArray = this.sortable.toArray() + .filter(id => id !== '-1'); gl.issueBoards.BoardsStore .moveIssueInList(this.list, Store.moving.issue, e.oldIndex, e.newIndex, sortedArray); }, diff --git a/app/assets/javascripts/boards/components/board_new_issue.vue b/app/assets/javascripts/boards/components/board_new_issue.vue index ec23b1e7c1..1e3cd43d1f 100644 --- a/app/assets/javascripts/boards/components/board_new_issue.vue +++ b/app/assets/javascripts/boards/components/board_new_issue.vue @@ -105,7 +105,7 @@ export default {
@@ -115,6 +115,7 @@ export default { :id="list.id + '-title'" class="form-control" type="text" + name="issue_title" autocomplete="off" /> l.title).join(',') : ''; + } }, watch: { detail: { diff --git a/app/assets/javascripts/boards/components/project_select.vue b/app/assets/javascripts/boards/components/project_select.vue index eb335f352d..ef9844d556 100644 --- a/app/assets/javascripts/boards/components/project_select.vue +++ b/app/assets/javascripts/boards/components/project_select.vue @@ -46,7 +46,7 @@ export default { selectable: true, data: (term, callback) => { this.loading = true; - return Api.groupProjects(this.groupId, term, projects => { + return Api.groupProjects(this.groupId, term, {}, projects => { this.loading = false; callback(projects); }); @@ -68,7 +68,7 @@ export default {