realaravinth/debian-mirror-gitlab
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge tag 'debian/15.6.6+ds1-2' into bullseye-fasttrack

Browse source 
gitlab Debian release 15.6.6+ds1-2
This commit is contained in:
Mohammed Bilal 2023-02-06 01:21:04 +05:30
commit 9a8656169b
No known key found for this signature in database
GPG key ID: B3F5945285219E1F
5800 changed files with 211312 additions and 106730 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.eslintignore
View file

@ -8,4 +8,6 @@
/vendor/
/sitespeed-result/
/fixtures/**/*.graphql
# Storybook build artifacts
/storybook/public
spec/fixtures/**/*.graphql

1
.eslintrc.yml
View file

@ -163,6 +163,7 @@ overrides:
- '*.stories.js'
rules:
filenames/match-regex: off
'@gitlab/require-i18n-strings': off
- files:
- '*.graphql'
plugins:

14
.gitlab-ci.yml
View file

@ -45,13 +45,14 @@ workflow:
RUBY_VERSION: "3.0"
# For (detached) merge request pipelines.
- if: '$CI_MERGE_REQUEST_IID'
# For the maintenance scheduled pipelines, we set specific variables.
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule" && $SCHEDULE_TYPE == "maintenance"'
# For the scheduled pipelines, we set specific variables.
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule"'
variables:
CRYSTALBALL: "true"
CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true"
NOTIFY_PIPELINE_FAILURE_CHANNEL: "master-broken"
# Run pipelines for ruby3 branch
- if: '$CI_COMMIT_BRANCH == "ruby3"'
- if: '$CI_COMMIT_BRANCH == "ruby3" && $CI_PIPELINE_SOURCE == "schedule"'
variables:
RUBY_VERSION: "3.0"
NOTIFY_PIPELINE_FAILURE_CHANNEL: "f_ruby3"
@ -62,9 +63,12 @@ workflow:
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $GITLAB_USER_LOGIN =~ /project_\d+_bot\d*/'
variables:
GITLAB_DEPENDENCY_PROXY_ADDRESS: ""
CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true"
NOTIFY_PIPELINE_FAILURE_CHANNEL: "master-broken"
# For `$CI_DEFAULT_BRANCH` branch, create a pipeline (this includes on schedules, pushes, merges, etc.).
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
variables:
CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true"
NOTIFY_PIPELINE_FAILURE_CHANNEL: "master-broken"
# For tags, create a pipeline.
- if: '$CI_COMMIT_TAG'
@ -95,7 +99,7 @@ variables:
GIT_SUBMODULE_STRATEGY: "none"
GET_SOURCES_ATTEMPTS: "3"
DEBIAN_VERSION: "bullseye"
CHROME_VERSION: "103"
CHROME_VERSION: "106"
DOCKER_VERSION: "20.10.14"
RUBY_VERSION: "2.7"
GO_VERSION: "1.18"
@ -127,7 +131,7 @@ variables:
# Run with decomposed databases by default
DECOMPOSED_DB: "true"
DOCS_REVIEW_APPS_DOMAIN: "35.193.151.162.nip.io"
DOCS_REVIEW_APPS_DOMAIN: "docs.gitlab-review.app"
DOCS_GITLAB_REPO_SUFFIX: "ee"
REVIEW_APPS_IMAGE: "${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/ruby-3.0:gcloud-383-kubectl-1.23-helm-3.5"

595
.gitlab/CODEOWNERS
View file

@ -2,7 +2,7 @@
# project here: https://gitlab.com/gitlab-org/gitlab/-/project_members
# As described in https://docs.gitlab.com/ee/user/project/code_owners.html
* @gitlab-org/maintainers/rails-backend @gitlab-org/maintainers/frontend @gitlab-org/maintainers/database @gl-quality/qe-maintainers @gitlab-org/delivery @gitlab-org/maintainers/cicd-templates @kwiebers @nolith @jacobvosmaer-gitlab @gitlab-org/tw-leadership
* @gitlab-org/maintainers/rails-backend @gitlab-org/maintainers/frontend @gitlab-org/maintainers/database @gl-quality/qe-maintainers @gl-quality/tooling-maintainers @gitlab-org/delivery @gitlab-org/maintainers/cicd-templates @nolith @jacobvosmaer-gitlab @gitlab-org/tw-leadership
CODEOWNERS @gitlab-org/development-leaders @gitlab-org/tw-leadership
docs/CODEOWNERS @gitlab-org/development-leaders @gitlab-org/tw-leadership
@ -49,7 +49,6 @@ GITALY_SERVER_VERSION @project_278964_bot6 @gitlab-org/maintainers/rails-backend
/ee/lib/ee/gitlab/background_migration/ @gitlab-org/maintainers/database
/lib/gitlab/database/ @gitlab-org/maintainers/database
/lib/gitlab/sql/ @gitlab-org/maintainers/database
/lib/gitlab/github_import/ @gitlab-org/maintainers/database
/app/finders/ @gitlab-org/maintainers/database
/ee/app/finders/ @gitlab-org/maintainers/database
/rubocop/rubocop-migrations.yml @gitlab-org/maintainers/database
@ -82,90 +81,28 @@ Dangerfile @gl-quality/eng-prod
/ee/lib/ee/gitlab/auth/ldap/ @dblessing @mkozono
/lib/gitlab/auth/ldap/ @dblessing @mkozono
^[Verify]
/app/**/ci/ @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/jobs_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/runner_projects_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/artifacts_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/build_artifacts_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/builds_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/jobs_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/runner_setup_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipeline_schedules_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipelines_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipelines_settings_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/runner_projects_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/triggers_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/usage_quotas_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/variables_controller.rb @gitlab-org/maintainers/cicd-verify
/app/models/commit_status.rb @gitlab-org/maintainers/cicd-verify
/app/models/external_pull_request.rb @gitlab-org/maintainers/cicd-verify
/app/models/generic_commit_status.rb @gitlab-org/maintainers/cicd-verify
/app/models/namespace_ci_cd_setting.rb @gitlab-org/maintainers/cicd-verify
/app/models/project_ci_cd_setting.rb @gitlab-org/maintainers/cicd-verify
/app/presenters/commit_status_presenter.rb @gitlab-org/maintainers/cicd-verify
/app/presenters/generic_commit_status_presenter.rb @gitlab-org/maintainers/cicd-verify
/app/views/projects/artifacts/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/generic_commit_statuses/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/jobs/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/pipeline_schedules/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/triggers/ @gitlab-org/maintainers/cicd-verify
/app/workers/build_hooks_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/build_queue_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/build_success_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/ci_platform_metrics_update_cron_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/create_pipeline_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/expire_build_artifacts_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_hooks_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_metrics_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_notification_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_process_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_schedule_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/run_pipeline_schedule_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/stuck_ci_jobs_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/update_external_pull_requests_worker.rb @gitlab-org/maintainers/cicd-verify
/lib/**/ci/ @gitlab-org/maintainers/cicd-verify
/lib/api/commit_statuses.rb @gitlab-org/maintainers/cicd-verify
/ee/app/**/ci/ @gitlab-org/maintainers/cicd-verify
/ee/app/**/merge_trains/ @gitlab-org/maintainers/cicd-verify
/ee/app/models/merge_train.rb @gitlab-org/maintainers/cicd-verify
/ee/app/finders/merge_trains_finder.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/auto_merge/merge_train_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/system_notes/merge_train_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/ee/admin/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/ee/projects/pipelines_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/projects/subscriptions_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/models/merge_train.rb @gitlab-org/maintainers/cicd-verify
/ee/app/helpers/ee/projects/pipeline_helper.rb @gitlab-org/maintainers/cicd-verify
/ee/app/views/ci_minutes_usage_mailer/ @gitlab-org/maintainers/cicd-verify
/ee/app/views/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/ee/app/views/projects/settings/ci_cd/ @gitlab-org/maintainers/cicd-verify
/ee/app/workers/clear_shared_runners_minutes_worker.rb @gitlab-org/maintainers/cicd-verify
/ee/lib/**/ci/ @gitlab-org/maintainers/cicd-verify
/ee/lib/ee/api/entities/merge_train.rb @gitlab-org/maintainers/cicd-verify
/**/javascripts/jobs/ @gitlab-org/ci-cd/verify/frontend
/**/javascripts/pipelines/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/pipeline_new/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci_lint/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci_variable_list/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/pipeline_schedules/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/pipeline_editor/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/runner/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/ci_minutes_usage/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/usage_quotas/ci_minutes_usage/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/usage_quotas/pipelines/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/reports/ @gitlab-org/ci-cd/verify/frontend
^[Templates]
/lib/gitlab/ci/templates/ @gitlab-org/maintainers/cicd-templates
/lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml @DylanGriffith @mayra-cabrera @tkuah
/lib/gitlab/ci/templates/Security/ @gonzoyumo @twoodham @sethgitlab @thiagocsf
/lib/gitlab/ci/templates/Security/Container-Scanning.*.yml @gitlab-org/govern/security-policies-backend
/lib/gitlab/ci/templates/Security/API-Fuzzing.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Security/Container-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Security/Coverage-Fuzzing.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Security/DAST.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Security/Dependency-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Security/License-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Security/SAST.*.yml @gitlab-org/secure/static-analysis
/lib/gitlab/ci/templates/Security/Secret-Detection.*.yml @gitlab-org/secure/static-analysis
/lib/gitlab/ci/templates/Security/Secure-Binaries.*.yml @gitlab-org/secure/static-analysis @gitlab-org/secure/composition-analysis-be @gitlab-org/secure/dynamic-analysis
# Note: The `Fortify-FoD-sast.gitlab-ci.yml` template is provided and maintained by Fortify, an official Technology Partner with GitLab.
/lib/gitlab/ci/templates/Jobs/API-Fuzzing.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Jobs/Container-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Jobs/Coverage-Fuzzing.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Jobs/DAST.*.yml @gitlab-org/secure/dynamic-analysis
/lib/gitlab/ci/templates/Jobs/Dependency-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Jobs/License-Scanning.*.yml @gitlab-org/secure/composition-analysis-be
/lib/gitlab/ci/templates/Jobs/SAST.*.yml @gitlab-org/secure/static-analysis
/lib/gitlab/ci/templates/Jobs/Secret-Detection.*.yml @gitlab-org/secure/static-analysis
^[Project Alias]
/ee/app/models/project_alias.rb @patrickbajao
@ -186,6 +123,8 @@ Dangerfile @gl-quality/eng-prod
/ee/spec/policies/vulnerabilities/ @gitlab-org/govern/threat-insights-backend-team
/ee/spec/policies/vulnerability*.rb @gitlab-org/govern/threat-insights-backend-team
/ee/spec/presenters/projects/security/ @gitlab-org/govern/threat-insights-backend-team
/ee/app/assets/javascripts/license_compliance/components/detected_licenses_table.vue @gitlab-org/govern/threat-insights-frontend-team
/ee/spec/frontend/license_compliance/components/detected_licenses_table_spec.js @gitlab-org/govern/threat-insights-frontend-team
^[Secure]
/ee/lib/gitlab/ci/parsers/license_compliance/ @gitlab-org/secure/composition-analysis-be
@ -196,24 +135,120 @@ Dangerfile @gl-quality/eng-prod
/ee/lib/gitlab/ci/reports/security/ @gitlab-org/secure/composition-analysis-be @gitlab-org/secure/dynamic-analysis-be @gitlab-org/secure/static-analysis-be @gitlab-org/secure/fuzzing-be
/ee/app/services/app_sec/dast/ @gitlab-org/secure/dynamic-analysis-be
^[Container Security]
/ee/app/views/projects/threat_monitoring/** @gitlab-org/govern/security-policies-frontend
/ee/app/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/spec/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/projects/threat_monitoring/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/threat_monitoring/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/threat_monitoring/** @gitlab-org/govern/security-policies-frontend
^[Security Policies]
/ee/app/assets/javascripts/approvals/components/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/approvals/stores/modules/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/projects/licenses/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/projects/pipelines/licenses/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/projects/pipelines/show/license_report.js
/ee/app/assets/javascripts/vue_merge_request_widget/extensions/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/vue_shared/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/views/projects/licenses/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/approvals/components/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/approvals/stores/modules/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/vue_merge_request_widget/extensions/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/vue_shared/license_compliance/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/approvals/components/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/approvals/stores/modules/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/groups/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/pages/projects/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/app/assets/javascripts/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/app/views/groups/security/policies @gitlab-org/govern/security-policies-frontend
/ee/app/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/approvals/components/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/approvals/stores/modules/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/spec/frontend/security_orchestration/** @gitlab-org/govern/security-policies-frontend
/ee/spec/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend
/ee/app/controllers/projects/threat_monitoring_controller.rb @gitlab-org/govern/security-policies-backend
/ee/spec/controllers/projects/threat_monitoring_controller_spec.rb @gitlab-org/govern/container-security-backend
/ee/app/controllers/projects/security/policies_controller.rb @gitlab-org/govern/security-policies-backend
/ee/spec/requests/projects/security/policies_controller_spec.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/security/orchestration_policy_configuration.rb @gitlab-org/govern/security-policies-backend
/ee/spec/models/security/orchestration_policy_configuration_spec.rb @gitlab-org/govern/security-policies-backend
/app/models/clusters/applications/cilium.rb @gitlab-org/govern/security-policies-backend
/spec/models/clusters/applications/cilium_spec.rb @gitlab-org/govern/security-policies-backend
/ee/app/controllers/groups/security/policies_controller.rb @gitlab-org/govern/security-policies-backend
/ee/app/controllers/projects/security/policies_controller.rb @gitlab-org/govern/security-policies-backend
/ee/app/graphql/mutations/concerns/mutations/finds_project_or_group_for_security_policies.rb @gitlab-org/govern/security-policies-backend
/ee/app/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend
/ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb @gitlab-org/govern/security-policies-backend
/ee/app/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/app/graphql/types/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/app/helpers/ee/security_orchestration_helper.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/security/orchestration_policy_configuration.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/security/orchestration_policy_rule_schedule.rb @gitlab-org/govern/security-policies-backend
/ee/app/services/security/orchestration/** @gitlab-org/govern/security-policies-backend
/ee/app/services/security/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/app/validators/json_schemas/security_orchestration_policy.json @gitlab-org/govern/security-policies-backend
/ee/app/workers/concerns/update_orchestration_policy_configuration.rb @gitlab-org/govern/security-policies-backend
/ee/app/workers/security/create_orchestration_policy_worker.rb @gitlab-org/govern/security-policies-backend
/ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb @gitlab-org/govern/security-policies-backend
/ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb @gitlab-org/govern/security-policies-backend
/ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb @gitlab-org/govern/security-policies-backend
/ee/lib/gitlab/ci/config/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/spec/controllers/groups/security/policies_controller_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/security_orchestration_policy_configurations.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/security_orchestration_policy_rule_schedules.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/security/policies.rb @gitlab-org/govern/security-policies-backend
/ee/spec/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend
/ee/spec/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/spec/graphql/types/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/spec/helpers/ee/security_orchestration_helper_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/lib/gitlab/ci/config/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/spec/models/security/orchestration_policy_configuration_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/requests/api/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend
/ee/spec/requests/api/graphql/project/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/spec/requests/projects/security/policies_controller_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/services/security/orchestration/** @gitlab-org/govern/security-policies-backend
/ee/spec/services/security/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend
/ee/spec/support/shared_contexts/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend
/ee/spec/views/projects/security/policies/index.html.haml_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/workers/security/create_orchestration_policy_worker_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb @gitlab-org/govern/security-policies-backend
/lib/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb @gitlab-org/govern/security-policies-backend
/spec/models/clusters/applications/cilium_spec.rb @gitlab-org/govern/security-policies-backend
/app/finders/security/license_compliance_jobs_finder.rb @gitlab-org/govern/security-policies-backend
/ee/app/controllers/projects/licenses_controller.rb @gitlab-org/govern/security-policies-backend
/ee/app/finders/software_license_policies_finder.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/sca/license_compliance.rb @gitlab-org/govern/security-policies-backend @gitlab-org/secure/composition-analysis-be
/ee/app/models/sca/license_policy.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/software_license_policy.rb @gitlab-org/govern/security-policies-backend
/ee/app/models/software_license.rb @gitlab-org/govern/security-policies-backend
/ee/app/serializers/license_compliance/** @gitlab-org/govern/security-policies-backend
/ee/app/serializers/license_entity.rb @gitlab-org/govern/security-policies-backend
/ee/app/serializers/license_serializer.rb @gitlab-org/govern/security-policies-backend
/ee/app/serializers/licenses_list_entity.rb @gitlab-org/govern/security-policies-backend
/ee/app/serializers/licenses_list_serializer.rb @gitlab-org/govern/security-policies-backend
/ee/app/serializers/security/license_policy_entity.rb @gitlab-org/govern/security-policies-backend
/ee/app/services/ci/compare_license_scanning_reports_collapsed_service.rb @gitlab-org/govern/security-policies-backend
/ee/app/services/ci/compare_license_scanning_reports_service.rb @gitlab-org/govern/security-policies-backend
/ee/app/services/projects/licenses/** @gitlab-org/govern/security-policies-backend
/ee/app/services/software_license_policies/** @gitlab-org/govern/security-policies-backend
/ee/app/services/software_license_policies/update_service.rb @gitlab-org/govern/security-policies-backend
/ee/app/workers/refresh_license_compliance_checks_worker.rb @gitlab-org/govern/security-policies-backend
/ee/lib/api/managed_licenses.rb @gitlab-org/govern/security-policies-backend
/ee/lib/ee/api/entities/managed_license.rb @gitlab-org/govern/security-policies-backend
/ee/lib/gitlab/spdx/license.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/software_license_policy.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/software_license.rb @gitlab-org/govern/security-policies-backend
/ee/spec/factories/spdx_license.rb @gitlab-org/govern/security-policies-backend
/ee/spec/finders/software_license_policies_finder_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/lib/gitlab/ci/parsers/license_compliance/** @gitlab-org/govern/security-policies-backend
/ee/spec/models/sca/license_compliance_spec.rb @gitlab-org/govern/security-policies-backend @gitlab-org/secure/composition-analysis-be
/ee/spec/models/sca/license_policy_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/models/software_license_policy_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/models/software_license_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/requests/api/managed_licenses_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/serializers/license_compliance/** @gitlab-org/govern/security-policies-backend
/ee/spec/services/ci/compare_license_scanning_reports_collapsed_service_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb @gitlab-org/govern/security-policies-backend
/ee/spec/services/projects/licenses/** @gitlab-org/govern/security-policies-backend
/ee/spec/services/software_license_policies/** @gitlab-org/govern/security-policies-backend
/spec/finders/security/license_compliance_jobs_finder_spec.rb @gitlab-org/govern/security-policies-backend
^[Code Owners]
/ee/lib/gitlab/code_owners.rb @reprazent @kerrizor @garyh
@ -253,10 +288,25 @@ Dangerfile @gl-quality/eng-prod
/spec/frontend/batch_comments/ @viktomas @jboyson @iamphill @thomasrandolph
^[Product Intelligence]
/ee/lib/gitlab/usage_data_counters/ @gitlab-org/growth/product-intelligence/engineers
/ee/lib/ee/gitlab/usage_data.rb @gitlab-org/growth/product-intelligence/engineers
/lib/gitlab/usage_data.rb @gitlab-org/growth/product_intelligence/engineers
/lib/gitlab/usage_data_counters/ @gitlab-org/growth/product-intelligence/engineers
/ee/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/lib/ee/gitlab/usage_data.rb @gitlab-org/analytics-section/product-intelligence/engineers
/lib/gitlab/usage_data.rb @gitlab-org/analytics-section/product-intelligence/engineers
/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/lib/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/lib/ee/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/lib/ee/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers
/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers
/app/workers/gitlab_service_ping_worker.rb @gitlab-org/analytics-section/product-intelligence/engineers
/spec/workers/gitlab_service_ping_worker_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers
/ee/spec/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/spec/lib/ee/gitlab/usage_data_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers
/spec/lib/gitlab/usage_data_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers
/spec/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/spec/lib/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/spec/lib/ee/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/spec/lib/ee/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers
/ee/spec/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers
^[Growth Experiments]
/app/experiments/ @gitlab-org/growth/experiment-devs
@ -315,7 +365,7 @@ Dangerfile @gl-quality/eng-prod
/config/dependency_decisions.yml @gitlab-org/legal-reviewers
^[Workhorse]
/workhorse/ @jacobvosmaer-gitlab @nolith @patrickbajao
/workhorse/ @jacobvosmaer-gitlab @nolith @patrickbajao @igor.drozdov
[Application Security]
/app/assets/javascripts/lib/dompurify.js @gitlab-com/gl-security/appsec
@ -347,7 +397,9 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/data/removals/ @gl-docsteam
^[Documentation Pages]
/doc/administration/application_settings_cache.md @sselhorn
# This block is managed by the rake script at lib/tasks/gitlab/tw/codeowners.rake, manual updates will be overwritten!
# Begin rake-managed-docs-block
/doc/administration/application_settings_cache.md @jglassman1
/doc/administration/audit_event_streaming.md @eread
/doc/administration/audit_events.md @eread
/doc/administration/audit_reports.md @eread
@ -373,7 +425,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/administration/geo/setup/ @axil
/doc/administration/git_protocol.md @aqualls
/doc/administration/gitaly/ @eread
/doc/administration/housekeeping.md @axil
/doc/administration/housekeeping.md @eread
/doc/administration/inactive_project_deletion.md @eread
/doc/administration/incoming_email.md @msedlakjakubowski
/doc/administration/index.md @axil
@ -386,7 +438,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/administration/invalidate_markdown_cache.md @msedlakjakubowski
/doc/administration/issue_closing_pattern.md @aqualls
/doc/administration/job_artifacts.md @marcel.amirault
/doc/administration/job_logs.md @sselhorn
/doc/administration/job_logs.md @fneill
/doc/administration/lfs/ @aqualls
/doc/administration/libravatar.md @axil
/doc/administration/load_balancer.md @axil
@ -396,11 +448,11 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/administration/merge_request_diffs.md @ashrafkhamis
/doc/administration/monitoring/ @msedlakjakubowski
/doc/administration/monitoring/gitlab_self_monitoring_project/ @msedlakjakubowski
/doc/administration/monitoring/ip_allowlist.md @sselhorn
/doc/administration/monitoring/ip_allowlist.md @jglassman1
/doc/administration/monitoring/performance/ @msedlakjakubowski
/doc/administration/monitoring/prometheus/ @msedlakjakubowski
/doc/administration/monitoring/prometheus/index.md @axil
/doc/administration/monitoring/prometheus/web_exporter.md @sselhorn
/doc/administration/monitoring/prometheus/web_exporter.md @jglassman1
/doc/administration/nfs.md @axil
/doc/administration/object_storage.md @axil
/doc/administration/operations/ @axil
@ -426,7 +478,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/administration/restart_gitlab.md @axil
/doc/administration/server_hooks.md @eread
/doc/administration/sidekiq/ @axil
/doc/administration/sidekiq/sidekiq_memory_killer.md @sselhorn
/doc/administration/sidekiq/sidekiq_memory_killer.md @jglassman1
/doc/administration/smime_signing_email.md @axil
/doc/administration/snippets/ @ashrafkhamis
/doc/administration/static_objects_external_storage.md @ashrafkhamis
@ -461,7 +513,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/deploy_tokens.md @rdickenson
/doc/api/deployments.md @rdickenson
/doc/api/discussions.md @aqualls
/doc/api/dora/ @fneill
/doc/api/dora/ @lciutacu
/doc/api/environments.md @rdickenson
/doc/api/epic_issues.md @msedlakjakubowski
/doc/api/epic_links.md @msedlakjakubowski
@ -484,8 +536,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/graphql/sample_issue_boards.md @msedlakjakubowski
/doc/api/graphql/users_example.md @jglassman1
/doc/api/group_access_tokens.md @jglassman1
/doc/api/group_activity_analytics.md @fneill
/doc/api/group_badges.md @fneill
/doc/api/group_activity_analytics.md @lciutacu
/doc/api/group_badges.md @lciutacu
/doc/api/group_boards.md @msedlakjakubowski
/doc/api/group_clusters.md @phillipwells
/doc/api/group_import_export.md @eread
@ -498,7 +550,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/group_releases.md @rdickenson
/doc/api/group_repository_storage_moves.md @ashrafkhamis
/doc/api/group_wikis.md @ashrafkhamis
/doc/api/groups.md @fneill
/doc/api/groups.md @lciutacu
/doc/api/import.md @eread
/doc/api/index.md @ashrafkhamis
/doc/api/instance_clusters.md @phillipwells
@ -569,7 +621,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/resource_milestone_events.md @msedlakjakubowski
/doc/api/resource_state_events.md @msedlakjakubowski
/doc/api/resource_weight_events.md @msedlakjakubowski
/doc/api/runners.md @sselhorn
/doc/api/runners.md @fneill
/doc/api/saml.md @jglassman1
/doc/api/scim.md @jglassman1
/doc/api/search.md @ashrafkhamis
@ -588,7 +640,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/templates/gitlab_ci_ymls.md @marcel.amirault
/doc/api/templates/licenses.md @rdickenson
/doc/api/todos.md @msedlakjakubowski
/doc/api/topics.md @fneill
/doc/api/topics.md @lciutacu
/doc/api/usage_data.md @claytoncornell
/doc/api/users.md @jglassman1
/doc/api/version.md @phillipwells
@ -597,12 +649,9 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/api/vulnerability_exports.md @claytoncornell
/doc/api/vulnerability_findings.md @claytoncornell
/doc/api/wikis.md @ashrafkhamis
/doc/architecture/blueprints/ci_pipeline_components/ @marcel.amirault
/doc/architecture/blueprints/container_registry_metadata_database/ @claytoncornell
/doc/architecture/blueprints/database/scalability/patterns/ @aqualls
/doc/architecture/blueprints/database_scaling/ @aqualls
/doc/architecture/blueprints/gitlab_to_kubernetes_communication/ @phillipwells
/doc/architecture/blueprints/work_items/ @msedlakjakubowski
/doc/architecture/blueprints/runner_tokens/ @fneill
/doc/ci/ @marcel.amirault
/doc/ci/caching/ @marcel.amirault
/doc/ci/chatops/ @phillipwells
@ -615,7 +664,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/ci/cloud_services/google_cloud/ @marcel.amirault
/doc/ci/directed_acyclic_graph/ @marcel.amirault
/doc/ci/docker/ @marcel.amirault
/doc/ci/docker/using_docker_images.md @sselhorn
/doc/ci/docker/using_docker_images.md @fneill
/doc/ci/environments/ @rdickenson
/doc/ci/examples/ @marcel.amirault
/doc/ci/examples/authenticating-with-hashicorp-vault/ @marcel.amirault
@ -623,22 +672,22 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/ci/examples/end_to_end_testing_webdriverio/ @marcel.amirault
/doc/ci/examples/laravel_with_gitlab_and_envoy/ @marcel.amirault
/doc/ci/examples/semantic-release.md @claytoncornell
/doc/ci/interactive_web_terminal/ @sselhorn
/doc/ci/interactive_web_terminal/ @fneill
/doc/ci/introduction/ @marcel.amirault
/doc/ci/jobs/ @marcel.amirault
/doc/ci/large_repositories/ @sselhorn
/doc/ci/large_repositories/ @fneill
/doc/ci/migration/ @marcel.amirault
/doc/ci/pipeline_editor/ @marcel.amirault
/doc/ci/pipelines/ @marcel.amirault
/doc/ci/quick_start/ @marcel.amirault
/doc/ci/resource_groups/ @rdickenson
/doc/ci/review_apps/ @marcel.amirault
/doc/ci/runners/ @sselhorn
/doc/ci/runners/saas/ @sselhorn
/doc/ci/runners/saas/macos/ @sselhorn
/doc/ci/runners/ @fneill
/doc/ci/runners/saas/ @fneill
/doc/ci/runners/saas/macos/ @fneill
/doc/ci/secrets/ @marcel.amirault
/doc/ci/secure_files/ @marcel.amirault
/doc/ci/services/ @sselhorn
/doc/ci/services/ @fneill
/doc/ci/ssh_keys/ @marcel.amirault
/doc/ci/test_cases/ @msedlakjakubowski
/doc/ci/testing/ @marcel.amirault
@ -654,7 +703,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/development/backend/create_source_code_be/ @aqualls
/doc/development/build_test_package.md @axil
/doc/development/bulk_import.md @eread
/doc/development/cached_queries.md @sselhorn
/doc/development/cached_queries.md @jglassman1
/doc/development/cascading_settings.md @jglassman1
/doc/development/chatops_on_gitlabcom.md @phillipwells
/doc/development/cicd/ @marcel.amirault
@ -662,7 +711,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/development/contributing/ @sselhorn
/doc/development/database/ @aqualls
/doc/development/database/filtering_by_label.md @msedlakjakubowski
/doc/development/database/multiple_databases.md @sselhorn
/doc/development/database/multiple_databases.md @jglassman1
/doc/development/database_review.md @aqualls
/doc/development/developing_with_solargraph.md @aqualls
/doc/development/development_processes.md @sselhorn
@ -694,7 +743,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/development/graphql_guide/ @ashrafkhamis
/doc/development/graphql_guide/batchloader.md @aqualls
/doc/development/i18n/ @eread
/doc/development/image_scaling.md @sselhorn
/doc/development/image_scaling.md @jglassman1
/doc/development/import_export.md @eread
/doc/development/index.md @sselhorn
/doc/development/integrations/codesandbox.md @sselhorn
@ -718,10 +767,11 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/development/permissions.md @jglassman1
/doc/development/policies.md @jglassman1
/doc/development/product_qualified_lead_guide/ @phillipwells
/doc/development/project_templates.md @fneill
/doc/development/project_templates.md @lciutacu
/doc/development/prometheus_metrics.md @msedlakjakubowski
/doc/development/real_time.md @msedlakjakubowski
/doc/development/sec/ @rdickenson
/doc/development/sec/security_report_ingestion_overview.md @claytoncornell
/doc/development/secure_coding_guidelines.md @sselhorn
/doc/development/service_ping/ @claytoncornell
/doc/development/snowplow/ @claytoncornell
@ -730,8 +780,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/development/testing_guide/ @sselhorn
/doc/development/testing_guide/contract/ @sselhorn
/doc/development/testing_guide/end_to_end/ @sselhorn
/doc/development/value_stream_analytics.md @fneill
/doc/development/value_stream_analytics/ @fneill
/doc/development/value_stream_analytics.md @lciutacu
/doc/development/value_stream_analytics/ @lciutacu
/doc/development/wikis.md @ashrafkhamis
/doc/development/work_items.md @msedlakjakubowski
/doc/development/work_items_widgets.md @msedlakjakubowski
@ -763,14 +813,11 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/integration/sourcegraph.md @aqualls
/doc/integration/trello_power_up.md @ashrafkhamis
/doc/integration/vault.md @phillipwells
/doc/operations/error_tracking.md msedlakjakubowski
/doc/operations/ @msedlakjakubowski
/doc/operations/feature_flags.md @rdickenson
/doc/operations/incident_management/ @msedlakjakubowski
/doc/operations/index.md @msedlakjakubowski
/doc/operations/metrics/ @msedlakjakubowski
/doc/operations/metrics/dashboards/ @msedlakjakubowski
/doc/operations/product_analytics.md @lciutacu
/doc/operations/tracing.md @msedlakjakubowski
/doc/policy/ @axil
/doc/raketasks/ @axil
/doc/raketasks/generate_sample_prometheus_data.md @msedlakjakubowski
@ -798,7 +845,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/update/mysql_to_postgresql.md @aqualls
/doc/update/package/ @axil
/doc/update/upgrading_postgresql_using_slony.md @aqualls
/doc/user/admin_area/analytics/ @fneill
/doc/user/admin_area/analytics/ @lciutacu
/doc/user/admin_area/broadcast_messages.md @phillipwells
/doc/user/admin_area/credentials_inventory.md @jglassman1
/doc/user/admin_area/custom_project_templates.md @eread
@ -833,10 +880,10 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/admin_area/settings/rate_limit_on_notes_creation.md @msedlakjakubowski
/doc/user/admin_area/settings/rate_limit_on_pipelines_creation.md @marcel.amirault
/doc/user/admin_area/settings/rate_limit_on_users_api.md @jglassman1
/doc/user/admin_area/settings/third_party_offers.md @fneill
/doc/user/admin_area/settings/third_party_offers.md @lciutacu
/doc/user/admin_area/settings/usage_statistics.md @claytoncornell
/doc/user/admin_area/settings/visibility_and_access_controls.md @aqualls
/doc/user/analytics/ @fneill
/doc/user/analytics/ @lciutacu
/doc/user/analytics/ci_cd_analytics.md @rdickenson
/doc/user/application_security/api_fuzzing/ @rdickenson
/doc/user/application_security/configuration/ @rdickenson
@ -873,14 +920,14 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/discussions/ @aqualls
/doc/user/feature_flags.md @sselhorn
/doc/user/free_user_limit.md @phillipwells
/doc/user/group/ @fneill
/doc/user/group/ @lciutacu
/doc/user/group/clusters/ @phillipwells
/doc/user/group/contribution_analytics/ @fneill
/doc/user/group/contribution_analytics/ @lciutacu
/doc/user/group/custom_project_templates.md @eread
/doc/user/group/devops_adoption/ @fneill
/doc/user/group/devops_adoption/ @lciutacu
/doc/user/group/epics/ @msedlakjakubowski
/doc/user/group/import/ @eread
/doc/user/group/insights/ @fneill
/doc/user/group/insights/ @lciutacu
/doc/user/group/issues_analytics/ @msedlakjakubowski
/doc/user/group/iterations/ @msedlakjakubowski
/doc/user/group/planning_hierarchy/ @msedlakjakubowski
@ -889,18 +936,18 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/group/saml_sso/ @jglassman1
/doc/user/group/settings/group_access_tokens.md @jglassman1
/doc/user/group/settings/import_export.md @eread
/doc/user/group/subgroups/ @fneill
/doc/user/group/value_stream_analytics/ @fneill
/doc/user/group/subgroups/ @lciutacu
/doc/user/group/value_stream_analytics/ @lciutacu
/doc/user/infrastructure/ @phillipwells
/doc/user/infrastructure/clusters/ @phillipwells
/doc/user/infrastructure/clusters/connect/ @phillipwells
/doc/user/infrastructure/clusters/deploy/ @phillipwells
/doc/user/infrastructure/clusters/manage/ @phillipwells
/doc/user/infrastructure/clusters/manage/management_project_applications/ @phillipwells
/doc/user/infrastructure/clusters/manage/management_project_applications/runner.md @sselhorn
/doc/user/infrastructure/clusters/manage/management_project_applications/runner.md @fneill
/doc/user/infrastructure/iac/ @phillipwells
/doc/user/markdown.md @aqualls
/doc/user/namespace/ @fneill
/doc/user/namespace/ @lciutacu
/doc/user/packages/ @claytoncornell
/doc/user/packages/composer_repository/ @claytoncornell
/doc/user/packages/conan_repository/ @claytoncornell
@ -911,18 +958,19 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/packages/go_proxy/ @claytoncornell
/doc/user/packages/harbor_container_registry/ @claytoncornell
/doc/user/packages/helm_repository/ @claytoncornell
/doc/user/packages/infrastructure_registry/ @phillipwells
/doc/user/packages/infrastructure_registry/ @claytoncornell
/doc/user/packages/maven_repository/ @claytoncornell
/doc/user/packages/npm_registry/ @claytoncornell
/doc/user/packages/nuget_repository/ @claytoncornell
/doc/user/packages/package_registry/ @claytoncornell
/doc/user/packages/pypi_repository/ @claytoncornell
/doc/user/packages/rubygems_registry/ @claytoncornell
/doc/user/packages/terraform_module_registry/ @phillipwells
/doc/user/packages/terraform_module_registry/ @claytoncornell
/doc/user/packages/workflows/ @claytoncornell
/doc/user/permissions.md @jglassman1
/doc/user/profile/ @jglassman1
/doc/user/profile/account/ @jglassman1
/doc/user/profile/contributions_calendar.md @lciutacu
/doc/user/profile/notifications.md @msedlakjakubowski
/doc/user/project/ @aqualls
/doc/user/project/clusters/ @phillipwells
@ -933,8 +981,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/project/description_templates.md @msedlakjakubowski
/doc/user/project/import/ @eread
/doc/user/project/import/jira.md @msedlakjakubowski
/doc/user/project/index.md @fneill
/doc/user/project/insights/ @fneill
/doc/user/project/index.md @lciutacu
/doc/user/project/insights/ @lciutacu
/doc/user/project/integrations/ @ashrafkhamis
/doc/user/project/integrations/prometheus.md @msedlakjakubowski
/doc/user/project/integrations/prometheus_library/ @msedlakjakubowski
@ -942,7 +990,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/project/issues/ @msedlakjakubowski
/doc/user/project/issues/csv_import.md @eread
/doc/user/project/labels.md @msedlakjakubowski
/doc/user/project/members/ @fneill
/doc/user/project/members/ @lciutacu
/doc/user/project/merge_requests/ @aqualls
/doc/user/project/merge_requests/approvals/ @aqualls
/doc/user/project/merge_requests/csv_export.md @eread
@ -955,6 +1003,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/project/pages/getting_started/ @ashrafkhamis
/doc/user/project/quick_actions.md @msedlakjakubowski
/doc/user/project/releases/ @rdickenson
/doc/user/project/remote_development/ @ashrafkhamis
/doc/user/project/repository/ @aqualls
/doc/user/project/repository/branches/ @aqualls
/doc/user/project/repository/file_finder.md @ashrafkhamis
@ -968,14 +1017,14 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/project/requirements/ @msedlakjakubowski
/doc/user/project/service_desk.md @msedlakjakubowski
/doc/user/project/settings/import_export.md @eread
/doc/user/project/settings/index.md @fneill
/doc/user/project/settings/index.md @lciutacu
/doc/user/project/settings/project_access_tokens.md @jglassman1
/doc/user/project/time_tracking.md @msedlakjakubowski
/doc/user/project/web_ide/ @ashrafkhamis
/doc/user/project/wiki/ @ashrafkhamis
/doc/user/project/working_with_projects.md @fneill
/doc/user/public_access.md @fneill
/doc/user/reserved_names.md @fneill
/doc/user/project/working_with_projects.md @lciutacu
/doc/user/public_access.md @lciutacu
/doc/user/reserved_names.md @lciutacu
/doc/user/search/ @ashrafkhamis
/doc/user/search/global_search/ @ashrafkhamis
/doc/user/shortcuts.md @ashrafkhamis
@ -984,7 +1033,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/doc/user/tasks.md @msedlakjakubowski
/doc/user/todos.md @msedlakjakubowski
/doc/user/usage_quotas.md @fneill
/doc/user/workspace/ @fneill
/doc/user/workspace/ @lciutacu
# End rake-managed-docs-block
[Authentication and Authorization]
/app/assets/javascripts/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
@ -1003,18 +1053,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/app/assets/javascripts/pages/profiles/two_factor_auths/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pages/projects/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pages/sessions/new/oauth_remember_me.js @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pipelines/components/pipelines_list/tokens/constants.js @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pipelines/components/pipelines_list/tokens/pipeline_branch_name_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pipelines/components/pipelines_list/tokens/pipeline_source_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pipelines/components/pipelines_list/tokens/pipeline_status_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/pipelines/components/pipelines_list/tokens/pipeline_tag_name_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/projects/settings/topics/components/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/related_issues/components/issue_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/runner/components/registration/registration_token.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/runner/components/registration/registration_token_reset_dropdown_item.vue @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/runner/components/search_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/token_access/components/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/javascripts/token_access/index.js @gitlab-org/manage/authentication-and-authorization/approvers
/app/assets/stylesheets/page_bundles/profile_two_factor_auth.scss @gitlab-org/manage/authentication-and-authorization/approvers
/app/controllers/admin/impersonation_tokens_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/controllers/concerns/access_tokens_actions.rb @gitlab-org/manage/authentication-and-authorization/approvers
@ -1054,6 +1094,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/app/models/token_with_iv.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/models/webauthn_registration.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/policies/personal_access_token_policy.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/serializers/access_token_entity_base.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/serializers/group_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/serializers/group_access_token_serializer.rb @gitlab-org/manage/authentication-and-authorization/approvers
/app/serializers/impersonation_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers
@ -1081,7 +1122,6 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/app/views/admin/application_settings/_external_authorization_service_form.html.haml @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/admin/impersonation_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/authentication/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/ci/token_access/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/dashboard/projects/_zero_authorized_projects.html.haml @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/devise/mailer/password_change.html.haml @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/devise/mailer/password_change.text.erb @gitlab-org/manage/authentication-and-authorization/approvers
@ -1107,6 +1147,8 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/app/views/notify/access_token_created_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/notify/access_token_expired_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/notify/access_token_expired_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/notify/access_token_revoked_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/notify/access_token_revoked_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/profiles/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/profiles/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/app/views/profiles/two_factor_auths/ @gitlab-org/manage/authentication-and-authorization/approvers
@ -1131,6 +1173,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/config/initializers/webauthn.rb @gitlab-org/manage/authentication-and-authorization/approvers
/config/initializers_before_autoloader/100_patch_omniauth_oauth2.rb @gitlab-org/manage/authentication-and-authorization/approvers
/config/initializers_before_autoloader/100_patch_omniauth_saml.rb @gitlab-org/manage/authentication-and-authorization/approvers
/config/weak_password_digests.yml @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/audit_events/components/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/audit_events/token_utils.js @gitlab-org/manage/authentication-and-authorization/approvers
@ -1141,9 +1184,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/ee/app/assets/javascripts/pages/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/pages/profiles/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/password/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/pipelines/components/pipelines_list/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/requirements/components/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/runner/components/search_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/saml_providers/scim_token_service.js @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/saml_sso/components/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_auth.vue @gitlab-org/manage/authentication-and-authorization/approvers
@ -1166,6 +1207,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/ee/app/models/ee/project_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/models/scim_oauth_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/serializers/scim_oauth_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/services/arkose/token_verification_service.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/services/ee/auth/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/services/ee/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/app/services/ee/resource_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
@ -1191,23 +1233,22 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/ee/lib/ee/gitlab/auth/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/ee/gitlab/omniauth_initializer.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/gitlab/auth/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/gitlab/auth_logger.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/gitlab/authority_analyzer.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/gitlab/geo/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/gitlab/kerberos/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/omni_auth/ @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/system_check/geo/authorized_keys_check.rb @gitlab-org/manage/authentication-and-authorization/approvers
/ee/lib/system_check/geo/authorized_keys_flag_check.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/ci/reset_token_result.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/impersonation_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/impersonation_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/personal_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/personal_access_token_with_details.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/personal_access_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/resource_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/entities/resource_access_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/helpers/authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/helpers/packages/basic_auth_helpers.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/helpers/personal_access_tokens_helpers.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/personal_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/resource_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/api/support/token_with_expiration.rb @gitlab-org/manage/authentication-and-authorization/approvers
@ -1221,8 +1262,7 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/lib/gitlab/background_migration/migrate_u2f_webauthn.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/chat_name_token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/ci/pipeline/expression/token.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/cleanup/unused_personal_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/cleanup/personal_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/external_authorization/ @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/external_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/gitlab/grape_logging/loggers/token_logger.rb @gitlab-org/manage/authentication-and-authorization/approvers
@ -1235,11 +1275,90 @@ lib/gitlab/checks/** @proglottis @toon @zj-gitlab
/lib/gitlab/project_authorizations.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/json_web_token/ @gitlab-org/manage/authentication-and-authorization/approvers
/lib/omni_auth/ @gitlab-org/manage/authentication-and-authorization/approvers
/lib/security/weak_passwords.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/system_check/app/authorized_keys_permission_check.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/system_check/incoming_email/imap_authentication_check.rb @gitlab-org/manage/authentication-and-authorization/approvers
/lib/tasks/gitlab/password.rake @gitlab-org/manage/authentication-and-authorization/approvers
/lib/tasks/tokens.rake @gitlab-org/manage/authentication-and-authorization/approvers
^[Verify]
/app/**/ci/ @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/jobs_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/runner_projects_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/admin/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/artifacts_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/build_artifacts_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/builds_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/jobs_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/runner_setup_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipeline_schedules_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipelines_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/pipelines_settings_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/runner_projects_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/triggers_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/usage_quotas_controller.rb @gitlab-org/maintainers/cicd-verify
/app/controllers/projects/variables_controller.rb @gitlab-org/maintainers/cicd-verify
/app/models/commit_status.rb @gitlab-org/maintainers/cicd-verify
/app/models/external_pull_request.rb @gitlab-org/maintainers/cicd-verify
/app/models/generic_commit_status.rb @gitlab-org/maintainers/cicd-verify
/app/models/namespace_ci_cd_setting.rb @gitlab-org/maintainers/cicd-verify
/app/models/project_ci_cd_setting.rb @gitlab-org/maintainers/cicd-verify
/app/presenters/commit_status_presenter.rb @gitlab-org/maintainers/cicd-verify
/app/presenters/generic_commit_status_presenter.rb @gitlab-org/maintainers/cicd-verify
/app/views/projects/artifacts/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/generic_commit_statuses/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/jobs/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/pipeline_schedules/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/app/views/projects/triggers/ @gitlab-org/maintainers/cicd-verify
/app/workers/build_hooks_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/build_queue_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/build_success_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/ci_platform_metrics_update_cron_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/create_pipeline_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/expire_build_artifacts_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_hooks_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_metrics_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_notification_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_process_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/pipeline_schedule_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/run_pipeline_schedule_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/stuck_ci_jobs_worker.rb @gitlab-org/maintainers/cicd-verify
/app/workers/update_external_pull_requests_worker.rb @gitlab-org/maintainers/cicd-verify
/lib/**/ci/ @gitlab-org/maintainers/cicd-verify
/lib/api/commit_statuses.rb @gitlab-org/maintainers/cicd-verify
/ee/app/**/ci/ @gitlab-org/maintainers/cicd-verify
/ee/app/**/merge_trains/ @gitlab-org/maintainers/cicd-verify
/ee/app/models/merge_train.rb @gitlab-org/maintainers/cicd-verify
/ee/app/finders/merge_trains_finder.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/auto_merge/merge_train_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/services/system_notes/merge_train_service.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/ee/admin/runners_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/ee/projects/pipelines_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/ee/app/controllers/projects/subscriptions_controller.rb @gitlab-org/maintainers/cicd-verify
/ee/app/models/merge_train.rb @gitlab-org/maintainers/cicd-verify
/ee/app/helpers/ee/projects/pipeline_helper.rb @gitlab-org/maintainers/cicd-verify
/ee/app/views/ci_minutes_usage_mailer/ @gitlab-org/maintainers/cicd-verify
/ee/app/views/projects/pipelines/ @gitlab-org/maintainers/cicd-verify
/ee/app/views/projects/settings/ci_cd/ @gitlab-org/maintainers/cicd-verify
/ee/app/workers/clear_shared_runners_minutes_worker.rb @gitlab-org/maintainers/cicd-verify
/ee/lib/**/ci/ @gitlab-org/maintainers/cicd-verify
/ee/lib/ee/api/entities/merge_train.rb @gitlab-org/maintainers/cicd-verify
/**/javascripts/jobs/ @gitlab-org/ci-cd/verify/frontend
/**/javascripts/pipelines/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/pipeline_new/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci_lint/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci_variable_list/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/ci/pipeline_schedules/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/pipeline_editor/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/ci/ @gitlab-org/ci-cd/verify/frontend
/ee/app/assets/javascripts/reports/ @gitlab-org/ci-cd/verify/frontend
/app/assets/javascripts/token_access/ @gitlab-org/ci-cd/verify/frontend
[Manage::Workspace]
lib/api/entities/basic_project_details.rb @gitlab-org/manage/manage-workspace/backend-approvers
lib/api/entities/project_with_access.rb @gitlab-org/manage/manage-workspace/backend-approvers
@ -1248,68 +1367,68 @@ lib/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-approver
ee/lib/ee/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-approvers
[Compliance]
/ee/app/services/audit_events/build_service.rb @gitlab-org/manage/compliance
/ee/spec/services/audit_events/custom_audit_event_service_spec.rb @gitlab-org/manage/compliance
/app/models/audit_event.rb @gitlab-org/manage/compliance
/app/services/audit_event_service.rb @gitlab-org/manage/compliance
/app/services/concerns/audit_event_save_type.rb @gitlab-org/manage/compliance
/app/views/profiles/audit_log.html.haml @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_app.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_export_button.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_filter.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_log.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_stream.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_table.vue @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/components/tokens/shared/ @gitlab-org/manage/compliance
/ee/app/assets/javascripts/audit_events/init_audit_events.js @gitlab-org/manage/compliance
/ee/app/controllers/admin/audit_log_reports_controller.rb @gitlab-org/manage/compliance
/ee/app/controllers/admin/audit_logs_controller.rb @gitlab-org/manage/compliance
/ee/app/controllers/concerns/audit_events/audit_events_params.rb @gitlab-org/manage/compliance
/ee/app/controllers/groups/audit_events_controller.rb @gitlab-org/manage/compliance
/ee/app/controllers/projects/audit_events_controller.rb @gitlab-org/manage/compliance
/ee/app/finders/audit_event_finder.rb @gitlab-org/manage/compliance
/ee/app/graphql/types/audit_events/external_audit_event_destination_type.rb @gitlab-org/manage/compliance
/ee/app/helpers/audit_events_helper.rb @gitlab-org/manage/compliance
/ee/app/helpers/auditor_user_helper.rb @gitlab-org/manage/compliance
/ee/app/models/audit_events/external_audit_event_destination.rb @gitlab-org/manage/compliance
/ee/app/models/concerns/auditable.rb @gitlab-org/manage/compliance
/ee/app/models/ee/audit_event.rb @gitlab-org/manage/compliance
/ee/app/policies/audit_events/external_audit_event_destination_policy.rb @gitlab-org/manage/compliance
/ee/app/presenters/audit_event_presenter.rb @gitlab-org/manage/compliance
/ee/app/serializers/audit_event_entity.rb @gitlab-org/manage/compliance
/ee/app/serializers/audit_event_serializer.rb @gitlab-org/manage/compliance
/ee/app/services/ci/audit_variable_change_service.rb @gitlab-org/manage/compliance
/ee/app/services/ee/audit_event_service.rb @gitlab-org/manage/compliance
/ee/app/views/admin/users/_auditor_access_level_radio.html.haml @gitlab-org/manage/compliance
/ee/app/views/admin/users/_auditor_user_badge.html.haml @gitlab-org/manage/compliance
/ee/app/views/shared/icons/_icon_audit_events_purple.svg @gitlab-org/manage/compliance
/ee/app/views/shared/promotions/_promote_audit_events.html.haml @gitlab-org/manage/compliance
/ee/app/workers/audit_events/audit_event_streaming_worker.rb @gitlab-org/manage/compliance
/ee/config/events/1652263097_groups__audit_events__index_click_streams_tab.yml @gitlab-org/manage/compliance
/ee/config/events/202108302307_admin_audit_logs_index_click_date_range_button.yml @gitlab-org/manage/compliance
/ee/config/events/202108302307_groups__audit_events_controller_search_audit_event.yml @gitlab-org/manage/compliance
/ee/config/events/202108302307_profiles_controller_search_audit_event.yml @gitlab-org/manage/compliance
/ee/config/events/202108302307_projects__audit_events_controller_search_audit_event.yml @gitlab-org/manage/compliance
/ee/config/events/202111041910_admin__audit_logs_controller_search_audit_event.yml @gitlab-org/manage/compliance
/ee/config/feature_flags/development/audit_event_streaming_git_operations.yml @gitlab-org/manage/compliance
/ee/config/feature_flags/development/audit_log_group_level.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_28d/20210216183930_g_compliance_audit_events_monthly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_28d/20210216183934_i_compliance_audit_events_monthly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_28d/20210216183942_a_compliance_audit_events_api_monthly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_28d/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183906_g_compliance_audit_events.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183908_i_compliance_audit_events.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183912_a_compliance_audit_events_api.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183928_g_compliance_audit_events_weekly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183932_i_compliance_audit_events_weekly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_7d/20210216183940_a_compliance_audit_events_api_weekly.yml @gitlab-org/manage/compliance
/ee/config/metrics/counts_all/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/manage/compliance
/ee/lib/api/audit_events.rb @gitlab-org/manage/compliance
/ee/lib/audit/external_status_check_changes_auditor.rb @gitlab-org/manage/compliance
/ee/lib/audit/group_merge_request_approval_setting_changes_auditor.rb @gitlab-org/manage/compliance
/ee/lib/audit/group_push_rules_changes_auditor.rb @gitlab-org/manage/compliance
/ee/lib/ee/api/entities/audit_event.rb @gitlab-org/manage/compliance
/ee/lib/ee/audit/ @gitlab-org/manage/compliance
/ee/lib/ee/gitlab/audit/ @gitlab-org/manage/compliance
/lib/gitlab/audit/auditor.rb @gitlab-org/manage/compliance
/lib/gitlab/audit_json_logger.rb @gitlab-org/manage/compliance
/ee/app/services/audit_events/build_service.rb @gitlab-org/govern/compliance
/ee/spec/services/audit_events/custom_audit_event_service_spec.rb @gitlab-org/govern/compliance
/app/models/audit_event.rb @gitlab-org/govern/compliance
/app/services/audit_event_service.rb @gitlab-org/govern/compliance
/app/services/concerns/audit_event_save_type.rb @gitlab-org/govern/compliance
/app/views/profiles/audit_log.html.haml @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_app.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_export_button.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_filter.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_log.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_stream.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/audit_events_table.vue @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/components/tokens/shared/ @gitlab-org/govern/compliance
/ee/app/assets/javascripts/audit_events/init_audit_events.js @gitlab-org/govern/compliance
/ee/app/controllers/admin/audit_log_reports_controller.rb @gitlab-org/govern/compliance
/ee/app/controllers/admin/audit_logs_controller.rb @gitlab-org/govern/compliance
/ee/app/controllers/concerns/audit_events/audit_events_params.rb @gitlab-org/govern/compliance
/ee/app/controllers/groups/audit_events_controller.rb @gitlab-org/govern/compliance
/ee/app/controllers/projects/audit_events_controller.rb @gitlab-org/govern/compliance
/ee/app/finders/audit_event_finder.rb @gitlab-org/govern/compliance
/ee/app/graphql/types/audit_events/external_audit_event_destination_type.rb @gitlab-org/govern/compliance
/ee/app/helpers/audit_events_helper.rb @gitlab-org/govern/compliance
/ee/app/helpers/auditor_user_helper.rb @gitlab-org/govern/compliance
/ee/app/models/audit_events/external_audit_event_destination.rb @gitlab-org/govern/compliance
/ee/app/models/concerns/auditable.rb @gitlab-org/govern/compliance
/ee/app/models/ee/audit_event.rb @gitlab-org/govern/compliance
/ee/app/policies/audit_events/external_audit_event_destination_policy.rb @gitlab-org/govern/compliance
/ee/app/presenters/audit_event_presenter.rb @gitlab-org/govern/compliance
/ee/app/serializers/audit_event_entity.rb @gitlab-org/govern/compliance
/ee/app/serializers/audit_event_serializer.rb @gitlab-org/govern/compliance
/ee/app/services/ci/audit_variable_change_service.rb @gitlab-org/govern/compliance
/ee/app/services/ee/audit_event_service.rb @gitlab-org/govern/compliance
/ee/app/views/admin/users/_auditor_access_level_radio.html.haml @gitlab-org/govern/compliance
/ee/app/views/admin/users/_auditor_user_badge.html.haml @gitlab-org/govern/compliance
/ee/app/views/shared/icons/_icon_audit_events_purple.svg @gitlab-org/govern/compliance
/ee/app/views/shared/promotions/_promote_audit_events.html.haml @gitlab-org/govern/compliance
/ee/app/workers/audit_events/audit_event_streaming_worker.rb @gitlab-org/govern/compliance
/ee/config/events/1652263097_groups__audit_events__index_click_streams_tab.yml @gitlab-org/govern/compliance
/ee/config/events/202108302307_admin_audit_logs_index_click_date_range_button.yml @gitlab-org/govern/compliance
/ee/config/events/202108302307_groups__audit_events_controller_search_audit_event.yml @gitlab-org/govern/compliance
/ee/config/events/202108302307_profiles_controller_search_audit_event.yml @gitlab-org/govern/compliance
/ee/config/events/202108302307_projects__audit_events_controller_search_audit_event.yml @gitlab-org/govern/compliance
/ee/config/events/202111041910_admin__audit_logs_controller_search_audit_event.yml @gitlab-org/govern/compliance
/ee/config/feature_flags/development/audit_event_streaming_git_operations.yml @gitlab-org/govern/compliance
/ee/config/feature_flags/development/audit_log_group_level.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_28d/20210216183930_g_compliance_audit_events_monthly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_28d/20210216183934_i_compliance_audit_events_monthly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_28d/20210216183942_a_compliance_audit_events_api_monthly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_28d/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183906_g_compliance_audit_events.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183908_i_compliance_audit_events.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183912_a_compliance_audit_events_api.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183928_g_compliance_audit_events_weekly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183932_i_compliance_audit_events_weekly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_7d/20210216183940_a_compliance_audit_events_api_weekly.yml @gitlab-org/govern/compliance
/ee/config/metrics/counts_all/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/govern/compliance
/ee/lib/api/audit_events.rb @gitlab-org/govern/compliance
/ee/lib/audit/external_status_check_changes_auditor.rb @gitlab-org/govern/compliance
/ee/lib/audit/group_merge_request_approval_setting_changes_auditor.rb @gitlab-org/govern/compliance
/ee/lib/audit/group_push_rules_changes_auditor.rb @gitlab-org/govern/compliance
/ee/lib/ee/api/entities/audit_event.rb @gitlab-org/govern/compliance
/ee/lib/ee/audit/ @gitlab-org/govern/compliance
/ee/lib/ee/gitlab/audit/ @gitlab-org/govern/compliance
/lib/gitlab/audit/auditor.rb @gitlab-org/govern/compliance
/lib/gitlab/audit_json_logger.rb @gitlab-org/govern/compliance

63
.gitlab/ci/as-if-jh.gitlab-ci.yml Normal file
View file

@ -0,0 +1,63 @@
.shared-as-if-jh:
variables:
SANDBOX_PROJECT: "gitlab-org-sandbox/gitlab-jh-validation"
SANDBOX_REPOSITORY: "https://dummy:${AS_IF_JH_TOKEN}@gitlab.com/${SANDBOX_PROJECT}.git"
GITLAB_JH_MIRROR_PROJECT: "33019816"
AS_IF_JH_BRANCH: "as-if-jh/${CI_COMMIT_REF_NAME}"
JH_FILES_TO_COMMIT: "jh package.json yarn.lock"
add-jh-files:
extends:
- .shared-as-if-jh
- .as-if-jh:rules:prepare-as-if-jh
image: ${GITLAB_DEPENDENCY_PROXY}ruby:${RUBY_VERSION}
stage: prepare
before_script:
- source ./scripts/utils.sh
- source ./scripts/setup/as-if-jh.sh
- install_gitlab_gem
script:
- prepare_jh_branch
- download_jh_path ${JH_FILES_TO_COMMIT}
- echoinfo "Changes after downloading JiHu files:"
- git diff
- git status
artifacts:
expire_in: 2d
paths:
# This should match JH_FILES_TO_COMMIT
- jh/
- package.json
- yarn.lock
prepare-as-if-jh-branch:
extends:
- .shared-as-if-jh
- .as-if-jh:rules:prepare-as-if-jh
stage: prepare
needs:
- add-jh-files
script:
- git checkout -b "${AS_IF_JH_BRANCH}"
- git add ${JH_FILES_TO_COMMIT}
- git commit -m 'Add JH files' # TODO: Mark which SHA we add
# Fetch for the history of the branch so it does not cause the following error:
# ! [remote rejected] ref -> ref (shallow update not allowed)
- git fetch --unshallow --filter=tree:0 origin "${CI_COMMIT_REF_NAME}"
- git push -f "${SANDBOX_REPOSITORY}" "${AS_IF_JH_BRANCH}"
start-as-if-jh:
extends:
- .shared-as-if-jh
- .as-if-jh:rules:start-as-if-jh
stage: prepare
needs: ["prepare-as-if-jh-branch"]
inherit:
variables: false
variables:
AS_IF_EDITION: "jh"
FORCE_GITLAB_CI: "true" # TODO: Trigger a merge request pipeline
trigger:
project: gitlab-org-sandbox/gitlab-jh-validation # ${SANDBOX_PROJECT} does not work here
branch: as-if-jh/${CI_COMMIT_REF_NAME} # ${AS_IF_JH_BRANCH} does not work here
strategy: depend

12
.gitlab/ci/build-images.gitlab-ci.yml
View file

@ -1,7 +1,13 @@
.base-image-build:
extends: .use-kaniko
variables:
GIT_LFS_SKIP_SMUDGE: 1
GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs
retry: 2
.base-image-build-buildx:
extends: .use-buildx
variables:
GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs
retry: 2
# This image is used by:
@ -10,12 +16,12 @@
# See https://docs.gitlab.com/ee/development/testing_guide/end_to_end/index.html#testing-code-in-merge-requests for more details.
build-qa-image:
extends:
- .base-image-build
- .base-image-build-buildx
- .build-images:rules:build-qa-image
stage: build-images
needs: []
script:
- ./scripts/build_qa_image
- run_timed_command "scripts/build_qa_image"
# This image is used by:
# - The `CNG` pipelines (via the `review-build-cng` job): https://gitlab.com/gitlab-org/build/CNG/-/blob/cfc67136d711e1c8c409bf8e57427a644393da2f/.gitlab-ci.yml#L335

2
.gitlab/ci/dev-fixtures.gitlab-ci.yml
View file

@ -29,7 +29,7 @@ run-dev-fixtures-ee:
extends:
- .run-dev-fixtures
- .dev-fixtures:rules:ee-only
- .use-pg12-ee
- .use-pg12-es7-ee
script:
- cp ee/db/fixtures/development/* $FIXTURE_PATH
- *run-dev-fixtures-script

40
.gitlab/ci/docs.gitlab-ci.yml
View file

@ -39,17 +39,6 @@ review-docs-cleanup:
script:
- ./scripts/trigger-build.rb docs cleanup
docs-lint markdown:
extends:
- .default-retry
- .docs:rules:docs-lint
# When updating the image version here, update it in /scripts/lint-doc.sh too.
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-markdown:alpine-3.16-vale-2.20.1-markdownlint-0.32.2
stage: lint
needs: []
script:
- scripts/lint-doc.sh
docs-lint links:
extends:
- .docs:rules:docs-lint
@ -67,6 +56,35 @@ docs-lint links:
# Check the internal links and anchors (in parallel)
- "parallel time bundle exec nanoc check ::: internal_links internal_anchors"
.docs-markdown-lint-image:
# When updating the image version here, update it in /scripts/lint-doc.sh too.
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-docs/lint-markdown:alpine-3.16-vale-2.20.1-markdownlint-0.32.2
docs-lint markdown:
extends:
- .default-retry
- .docs:rules:docs-lint
- .docs-markdown-lint-image
stage: lint
needs: []
script:
- scripts/lint-doc.sh
docs-code-quality:
extends:
- .docs:rules:docs-code-quality
- .docs-markdown-lint-image
stage: lint
needs: []
script:
- vale --output=doc/.vale/vale-json.tmpl --minAlertLevel warning doc > gl-code-quality-report-docs.json || exit_code=$?
artifacts:
reports:
codequality: gl-code-quality-report-docs.json
paths:
- gl-code-quality-report-docs.json
expire_in: 1 week
ui-docs-links lint:
extends:
- .docs:rules:docs-lint

22
.gitlab/ci/frontend.gitlab-ci.yml
View file

@ -20,7 +20,12 @@
- |
if [[ "${CACHE_ASSETS_AS_PACKAGE}" == "true" ]]; then
source scripts/gitlab_component_helpers.sh
gitlab_assets_archive_doesnt_exist || run_timed_command "download_and_extract_gitlab_assets"
if ! gitlab_assets_archive_doesnt_exist; then
# We remove all assets from the native cache as they could pollute the fresh assets from the package
rm -rf public/assets/ app/assets/javascripts/locale/**/app.js
run_timed_command "download_and_extract_gitlab_assets"
fi
fi
- assets_compile_script
@ -84,17 +89,6 @@ update-assets-compile-test-cache:
- echo -n "${GITLAB_ASSETS_HASH}" > "cached-assets-hash.txt"
artifacts: {} # This job's purpose is only to update the cache.
# TODO: Remove this as it's duplicating update-assets-compile-*-cache
update-yarn-cache:
extends:
- .default-retry
- .default-utils-before_script
- .yarn-cache-push
- .shared:rules:update-cache
stage: prepare
script:
- yarn_install_script
update-storybook-yarn-cache:
extends:
- .default-retry
@ -171,7 +165,7 @@ graphql-schema-dump:
graphql-schema-dump as-if-foss:
extends:
- graphql-schema-dump
- .frontend:rules:eslint-as-if-foss
- .frontend:rules:default-frontend-jobs-as-if-foss
- .as-if-foss
.frontend-test-base:
@ -399,5 +393,5 @@ compile-storybook as-if-foss:
- .as-if-foss
- .frontend:rules:default-frontend-jobs-as-if-foss
needs:
- !reference [.compile-storybook-base, needs]
- job: "graphql-schema-dump as-if-foss"
- job: "rspec-all frontend_fixture as-if-foss"

16
.gitlab/ci/glfm.gitlab-ci.yml Normal file
View file

@ -0,0 +1,16 @@
glfm-verify:
extends:
- .rails-job-base
- .glfm:rules:glfm-verify
- .use-pg12
stage: test
needs: ["setup-test-env"]
script:
- !reference [.base-script, script]
- bundle exec scripts/glfm/verify-all-generated-files-are-up-to-date.rb
artifacts:
name: changed-files
when: on_failure
expire_in: 31d
paths:
- glfm_specification/

54
.gitlab/ci/global.gitlab-ci.yml
View file

@ -219,23 +219,16 @@
- *node-modules-cache
- *assets-tmp-cache
# TODO: Remove this as it's duplicating .assets-compile-cache-push
.yarn-cache-push:
cache:
- *node-modules-cache-push
.assets-compile-cache:
cache:
- *ruby-gems-cache
- *node-modules-cache
- *assets-cache
- *assets-tmp-cache
.assets-compile-cache-push:
cache:
- *ruby-gems-cache # We don't push this cache as it's already rebuilt by `update-setup-test-env-cache`
- *node-modules-cache-push
- *assets-cache-push
- *assets-tmp-cache-push
.storybook-yarn-cache:
@ -245,7 +238,7 @@
.storybook-yarn-cache-push:
cache:
- *node-modules-cache # We don't push this cache as it's already rebuilt by `update-yarn-cache`
- *node-modules-cache # We don't push this cache as it's already rebuilt by `update-assets-compile-*-cache`
- *storybook-node-modules-cache-push
.use-pg11:
@ -275,34 +268,34 @@
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "13"
.use-pg11-ee:
.use-pg11-es7-ee:
services:
- name: postgres:11.6
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:5.0-alpine
- name: elasticsearch:7.17.0
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
variables:
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "11"
.use-pg12-ee:
.use-pg12-es7-ee:
services:
- name: postgres:12
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.0-alpine
- name: elasticsearch:7.17.0
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
variables:
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "12"
.use-pg13-ee:
.use-pg13-es7-ee:
services:
- name: postgres:13
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.2-alpine
- name: elasticsearch:7.17.0
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
variables:
POSTGRES_HOST_AUTH_METHOD: trust
@ -313,7 +306,7 @@
- name: postgres:12
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.0-alpine
- name: elasticsearch:8.3.3
- name: elasticsearch:8.4.1
variables:
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "12"
@ -325,7 +318,19 @@
- name: postgres:12
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:1.2.4
- name: opensearchproject/opensearch:1.3.5
alias: elasticsearch
command: ["bin/opensearch", "-E", "discovery.type=single-node", "-E", "plugins.security.disabled=true"]
variables:
POSTGRES_HOST_AUTH_METHOD: trust
PG_VERSION: "12"
.use-pg12-opensearch2-ee:
services:
- name: postgres:12
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:2.2.1
alias: elasticsearch
command: ["bin/opensearch", "-E", "discovery.type=single-node", "-E", "plugins.security.disabled=true"]
variables:
@ -356,3 +361,20 @@
tags:
# See https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/7019 for tag descriptions
- gitlab-org-docker
.use-buildx:
extends: .use-docker-in-docker
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-slim:docker-${DOCKER_VERSION}-buildx-0.8
variables:
QEMU_IMAGE: tonistiigi/binfmt:qemu-v7.0.0
before_script:
- source scripts/utils.sh
- echo "$CI_REGISTRY_PASSWORD" | docker login "$CI_REGISTRY" -u "$CI_REGISTRY_USER" --password-stdin
- |
if [[ "${ARCH}" =~ arm64 ]]; then
echo -e "\033[1;33mInstalling latest qemu emulators\033[0m"
docker pull -q ${QEMU_IMAGE};
docker run --rm --privileged ${QEMU_IMAGE} --uninstall qemu-*;
docker run --rm --privileged ${QEMU_IMAGE} --install all;
fi
- docker buildx create --use # creates and set's to active buildkit builder

35
.gitlab/ci/notify.gitlab-ci.yml
View file

@ -1,8 +1,12 @@
.notify-slack:
image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine/curl
.notify-defaults:
stage: notify
dependencies: []
cache: {}
.notify-slack:
extends:
- .notify-defaults
image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}alpine/curl
variables:
MERGE_REQUEST_URL: ${CI_MERGE_REQUEST_PROJECT_URL}/-/merge_requests/${CI_MERGE_REQUEST_IID}
before_script:
@ -34,28 +38,31 @@ notify-security-pipeline:
- scripts/slack ${NOTIFY_CHANNEL} "<!subteam^S0127FU8PDE> ☠️ Pipeline for merged result failed! ☠️ See ${CI_PIPELINE_URL} (triggered from ${MERGE_REQUEST_URL})" ci_failing "GitLab Release Tools Bot"
notify-pipeline-failure:
extends: .notify-slack
extends:
- .notify-defaults
- .notify:rules:notify-pipeline-failure
image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}
rules:
# Don't report child pipeline failures
- if: '$CI_PIPELINE_SOURCE == "parent_pipeline"'
when: never
- if: '$CI_SLACK_WEBHOOK_URL && $NOTIFY_PIPELINE_FAILURE_CHANNEL'
when: on_failure
allow_failure: true
variables:
BROKEN_MASTER_INCIDENTS_PROJECT: "gitlab-org/quality/engineering-productivity/master-broken-incidents"
BROKEN_MASTER_INCIDENT_JSON: "${CI_PROJECT_DIR}/incident.json"
SLACK_CHANNEL: "${NOTIFY_PIPELINE_FAILURE_CHANNEL}"
FAILED_PIPELINE_REPORT_FILE: "failed_pipeline_report.json"
FAILED_PIPELINE_SLACK_MESSAGE_FILE: "${CI_PROJECT_DIR}/failed_pipeline_slack_message.json"
before_script:
- source scripts/utils.sh
- apt-get update && apt-get install -y jq
- install_gitlab_gem
script:
- scripts/generate-failed-pipeline-slack-message.rb
- |
curl -X POST -H 'Content-Type: application/json' --data @${FAILED_PIPELINE_REPORT_FILE} "$CI_SLACK_WEBHOOK_URL"
if [[ "${CREATE_INCIDENT_FOR_PIPELINE_FAILURE}" == "true" ]]; then
scripts/create-pipeline-failure-incident.rb -p ${BROKEN_MASTER_INCIDENTS_PROJECT} -f ${BROKEN_MASTER_INCIDENT_JSON} -t ${BROKEN_MASTER_INCIDENTS_PROJECT_TOKEN};
echosuccess "Created incident $(jq '.web_url' ${BROKEN_MASTER_INCIDENT_JSON})";
fi
- |
scripts/generate-failed-pipeline-slack-message.rb -i ${BROKEN_MASTER_INCIDENT_JSON} -f ${FAILED_PIPELINE_SLACK_MESSAGE_FILE};
curl -X POST -H 'Content-Type: application/json' --data @${FAILED_PIPELINE_SLACK_MESSAGE_FILE} "$CI_SLACK_WEBHOOK_URL";
artifacts:
paths:
- ${FAILED_PIPELINE_REPORT_FILE}
- ${BROKEN_MASTER_INCIDENT_JSON}
- ${FAILED_PIPELINE_SLACK_MESSAGE_FILE}
when: always
expire_in: 2 days

26
.gitlab/ci/package-and-test/main.gitlab-ci.yml
View file

@ -7,7 +7,7 @@ include:
- local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml
- local: .gitlab/ci/package-and-test/variables.gitlab-ci.yml
- project: gitlab-org/quality/pipeline-common
ref: 1.3.0
ref: 1.7.0
file:
- /ci/base.gitlab-ci.yml
- /ci/allure-report.yml
@ -27,6 +27,8 @@ stages:
QA_KNAPSACK_REPORT_PATH: $CI_PROJECT_DIR/qa/knapsack
.ruby-image:
# Because this pipeline template can be included directly in other projects,
# image path and registry needs to be defined explicitly
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3
.qa-install:
@ -161,7 +163,7 @@ cache-gems:
extends:
- .qa-install
- .ruby-image
- .rules:prepare
- .rules:update-cache
stage: .pre
tags:
- e2e
@ -206,7 +208,6 @@ ee:instance-parallel-ff-inverse:
QA_KNAPSACK_REPORT_NAME: ee-instance-parallel
GITLAB_QA_OPTS: --set-feature-flags $QA_FEATURE_FLAGS
rules:
- !reference [.rules:test:feature-flags-deleted, rules] # skip job when only change is ff deletion
- !reference [.rules:test:feature-flags-set, rules]
# ------------------------------------------
@ -378,6 +379,15 @@ ee:update-major:
- if: $QA_SUITES =~ /Test::Instance::Smoke/
- !reference [.rules:test:manual, rules]
ee:gitab-pages:
extends: .qa
variables:
QA_SCENARIO: Test::Integration::GitlabPages
rules:
- !reference [.rules:test:qa, rules]
- if: $QA_SUITES =~ /Test::Integration::GitlabPages/
- !reference [.rules:test:manual, rules]
ee:gitaly-cluster:
extends: .qa
variables:
@ -592,6 +602,16 @@ upload-knapsack-report:
stage: report
when: always
export-test-metrics:
extends:
- .qa-install
- .ruby-image
- .rules:report:process-results
stage: report
when: always
script:
- bundle exec rake "ci:export_test_metrics[$CI_PROJECT_DIR/gitlab-qa-run-*/**/test-metrics-*.json]"
relate-test-failures:
extends:
- .qa-install

33
.gitlab/ci/package-and-test/rules.gitlab-ci.yml
View file

@ -8,11 +8,8 @@
# FF changes
.feature-flags-set: &feature-flags-set
if: $QA_FEATURE_FLAGS != ""
if: $QA_FEATURE_FLAGS =~ /enabled|disabled/
# Only deleted feature flags
.feature-flags-deleted: &feature-flags-deleted
if: $QA_FEATURE_FLAGS != "" && $QA_FEATURE_FLAGS !~ /enabled|disabled/
# Manually trigger job on ff changes but with default ff state instead of inverted
.feature-flags-set-manual: &feature-flags-set-manual
@ -20,14 +17,17 @@
when: manual
allow_failure: true
# QA framework changes present
.qa-framework-changes: &qa-framework-changes
if: $QA_FRAMEWORK_CHANGES == "true"
# Run all tests when framework changes present, full suite execution is explicitly enabled or a feature flag file is removed
.qa-run-all-tests: &qa-run-all-tests
if: $QA_FRAMEWORK_CHANGES == "true" || $QA_RUN_ALL_TESTS == "true" || $QA_FEATURE_FLAGS =~ /deleted/
# Process test results (notify failure to slack, create test session report, relate test failures)
.process-test-results: &process-test-results
if: $PROCESS_TEST_RESULTS == "true"
.not-canonical-project: &not-canonical-project
if: '$CI_PROJECT_PATH != "gitlab-org/gitlab" && $CI_PROJECT_PATH != "gitlab-cn/gitlab"'
# Selective test execution against omnibus instance have following execution scenarios:
# * only e2e spec files changed - runs only changed specs
# * qa framework changes - runs full test suite
@ -55,6 +55,12 @@
when: never
- when: always
.rules:update-cache:
rules:
- <<: *not-canonical-project
when: never
- when: always
# ------------------------------------------
# Test
# ------------------------------------------
@ -72,17 +78,12 @@
variables:
QA_TESTS: ""
.rules:test:feature-flags-deleted:
rules:
- <<: *feature-flags-deleted
when: never
# parallel and non parallel rules are used for jobs that require parallel execution and thus need to switch
# between parallel and non parallel when only certain specs are executed
.rules:test:qa-non-parallel:
rules:
# always run parallel with full suite when framework changes present or ff state changed
- <<: *qa-framework-changes
- <<: *qa-run-all-tests
when: never
- <<: *all-specs
when: never
@ -91,7 +92,7 @@
.rules:test:qa-parallel:
rules:
- *qa-framework-changes
- *qa-run-all-tests
- <<: *specific-specs
when: manual
allow_failure: true
@ -102,7 +103,7 @@
# general qa job rule for jobs without the need to run in parallel
.rules:test:qa:
rules:
- *qa-framework-changes
- *qa-run-all-tests
- *feature-flags-set-manual
.rules:test:update:
@ -124,4 +125,6 @@
.rules:report:process-results:
rules:
- <<: *not-canonical-project
when: never
- *process-test-results

2
.gitlab/ci/package-and-test/variables.gitlab-ci.yml
View file

@ -1,6 +1,8 @@
# Default variables for package-and-test
variables:
REGISTRY_HOST: "registry.gitlab.com"
REGISTRY_GROUP: "gitlab-org"
SKIP_REPORT_IN_ISSUES: "true"
OMNIBUS_GITLAB_CACHE_UPDATE: "false"
OMNIBUS_GITLAB_RUBY3_BUILD: "false"

17
.gitlab/ci/pages.gitlab-ci.yml
View file

@ -10,20 +10,18 @@ pages:
environment: pages
resource_group: pages
needs:
- job: "rspec:coverage"
- job: "coverage-frontend"
- job: "compile-production-assets"
- job: "compile-storybook"
# `update-tests-metadata` only runs on GitLab.com's EE schedules pipelines
# while `pages` runs for all the maintenance scheduled pipelines.
- job: "update-tests-metadata"
optional: true
- "rspec:coverage"
- "coverage-frontend"
- "compile-production-assets"
- "compile-storybook"
- "update-tests-metadata"
- "generate-frontend-fixtures-mapping"
before_script:
- apt-get update && apt-get -y install brotli gzip
script:
- mv public/ .public/
- mkdir public/
- mkdir -p public/$(dirname "$KNAPSACK_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$FLAKY_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$RSPEC_PACKED_TESTS_MAPPING_PATH")
- mkdir -p public/$(dirname "$KNAPSACK_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$FLAKY_RSPEC_SUITE_REPORT_PATH") public/$(dirname "$RSPEC_PACKED_TESTS_MAPPING_PATH") public/$(dirname "$FRONTEND_FIXTURES_MAPPING_PATH")
- mv coverage/ public/coverage-ruby/ || true
- mv coverage-frontend/ public/coverage-frontend/ || true
- mv storybook/public public/storybook || true
@ -31,6 +29,7 @@ pages:
- mv $KNAPSACK_RSPEC_SUITE_REPORT_PATH public/$KNAPSACK_RSPEC_SUITE_REPORT_PATH || true
- mv $FLAKY_RSPEC_SUITE_REPORT_PATH public/$FLAKY_RSPEC_SUITE_REPORT_PATH || true
- mv $RSPEC_PACKED_TESTS_MAPPING_PATH.gz public/$RSPEC_PACKED_TESTS_MAPPING_PATH.gz || true
- mv $FRONTEND_FIXTURES_MAPPING_PATH public/$FRONTEND_FIXTURES_MAPPING_PATH || true
- *compress-public
artifacts:
paths:

1
.gitlab/ci/qa.gitlab-ci.yml
View file

@ -8,7 +8,6 @@
variables:
USE_BUNDLE_INSTALL: "false"
SETUP_DB: "false"
QA_EXPORT_TEST_METRICS: "false"
before_script:
- !reference [.default-before_script, before_script]
- cd qa && bundle install

70
.gitlab/ci/rails.gitlab-ci.yml
View file

@ -574,11 +574,6 @@ rspec-ee unit pg12 es8:
- .rspec-ee-base-pg12-es8
- .rspec-ee-unit-parallel
rspec-ee unit pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-unit-parallel
rspec-ee unit pg12 minimal:
extends:
- rspec-ee unit pg12
@ -602,11 +597,6 @@ rspec-ee integration pg12 es8:
- .rspec-ee-base-pg12-es8
- .rspec-ee-integration-parallel
rspec-ee integration pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-integration-parallel
rspec-ee integration pg12 minimal:
extends:
- rspec-ee integration pg12
@ -630,11 +620,6 @@ rspec-ee system pg12 es8:
- .rspec-ee-base-pg12-es8
- .rspec-ee-system-parallel
rspec-ee system pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-system-parallel
rspec-ee system pg12 minimal:
extends:
- rspec-ee system pg12
@ -743,6 +728,61 @@ rspec-ee system pg11:
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
- .rspec-ee-system-parallel
# PG12
rspec-ee unit pg12 es7:
extends:
- .rspec-ee-base-pg12-es7
- .rspec-ee-unit-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee unit pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-unit-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee unit pg12 opensearch2:
extends:
- .rspec-ee-base-pg12-opensearch2
- .rspec-ee-unit-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee integration pg12 es7:
extends:
- .rspec-ee-base-pg12-es7
- .rspec-ee-integration-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee integration pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-integration-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee integration pg12 opensearch2:
extends:
- .rspec-ee-base-pg12-opensearch2
- .rspec-ee-integration-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee system pg12 es7:
extends:
- .rspec-ee-base-pg12-es7
- .rspec-ee-system-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee system pg12 opensearch1:
extends:
- .rspec-ee-base-pg12-opensearch1
- .rspec-ee-system-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
rspec-ee system pg12 opensearch2:
extends:
- .rspec-ee-base-pg12-opensearch2
- .rspec-ee-system-parallel
- .rails:rules:default-branch-schedule-nightly--code-backstage-ee-only
# PG13
rspec-ee migration pg13:
extends:

18
.gitlab/ci/rails/shared.gitlab-ci.yml
View file

@ -109,12 +109,18 @@ include:
.rspec-ee-base-pg11:
extends:
- .rspec-base
- .use-pg11-ee
- .use-pg11-es7-ee
.rspec-ee-base-pg12:
extends:
- .rspec-base
- .use-pg12-ee
- .use-pg12-es7-ee
.rspec-ee-base-pg12-es7:
extends:
- .rspec-base
- .use-pg12-es7-ee
- .rails:rules:run-search-tests
.rspec-ee-base-pg12-es8:
extends:
@ -128,10 +134,16 @@ include:
- .use-pg12-opensearch1-ee
- .rails:rules:run-search-tests
.rspec-ee-base-pg12-opensearch2:
extends:
- .rspec-base
- .use-pg12-opensearch2-ee
- .rails:rules:run-search-tests
.rspec-ee-base-pg13:
extends:
- .rspec-base
- .use-pg13-ee
- .use-pg13-es7-ee
.db-job-base:
extends:

16
.gitlab/ci/reports.gitlab-ci.yml
View file

@ -40,22 +40,6 @@ brakeman-sast:
semgrep-sast:
rules: !reference [".reports:rules:semgrep-sast", rules]
gosec-sast:
variables:
GOPATH: "$CI_PROJECT_DIR/vendor/go"
COMPILE: "false"
GOSEC_GO_PKG_PATH: "$CI_PROJECT_DIR"
SECURE_LOG_LEVEL: "debug"
before_script:
- mkdir -p $GOPATH
- cd workhorse
- go get -d ./...
- cd ..
cache:
paths:
- vendor/go
rules: !reference [".reports:rules:gosec-sast", rules]
.secret-analyzer:
extends: .default-retry
stage: lint

31
.gitlab/ci/review-apps/dast-api.gitlab-ci.yml
View file

@ -2,13 +2,34 @@ include:
- template: DAST-API.gitlab-ci.yml
dast_api:
variables:
DAST_API_PROFILE: Passive
DAST_API_GRAPHQL: /api/graphql
DAST_API_TARGET_URL: ${CI_ENVIRONMENT_URL}
DAST_API_OVERRIDES_ENV: "{\"headers\":{\"Authorization\":\"Bearer $REVIEW_APPS_ROOT_TOKEN\"}}"
needs: ["review-deploy"]
# Uncomment resource_group if DAST_API_PROFILE is changed to an active scan
# resource_group: dast_api_scan
rules:
- when: never
dast_api_graphql:
extends: dast_api
variables:
DAST_API_GRAPHQL: /api/graphql
DAST_API_PROFILE: Passive
DAST_API_TARGET_URL: ${CI_ENVIRONMENT_URL}
DAST_API_OVERRIDES_ENV: "{\"headers\":{\"Authorization\":\"Bearer $REVIEW_APPS_ROOT_TOKEN\"}}"
rules:
- !reference [".reports:rules:schedule-dast", rules]
#
# To run this job in an MR pipeline, use this rule:
# - !reference [".reports:rules:test-dast", rules]
dast_api_rest:
extends: dast_api
variables:
DAST_API_OPENAPI: doc/api/openapi/openapi_v2.yaml
DAST_API_PROFILE: Passive
DAST_API_TARGET_URL: ${CI_ENVIRONMENT_URL}
DAST_API_OVERRIDES_ENV: "{\"headers\":{\"Authorization\":\"Bearer $REVIEW_APPS_ROOT_TOKEN\"}}"
rules:
- !reference [".reports:rules:schedule-dast", rules]
#
# To run this job in an MR pipeline, use this rule:
# - !reference [".reports:rules:test-dast", rules]

27
.gitlab/ci/review-apps/main.gitlab-ci.yml
View file

@ -32,14 +32,15 @@ review-build-cng-env:
extends:
- .default-retry
- .review:rules:review-build-cng
image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:3.0-alpine3.13
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-${DEBIAN_VERSION}-ruby-${RUBY_VERSION}:bundler-2.3
stage: prepare
needs: []
before_script:
- source ./scripts/utils.sh
- install_gitlab_gem
script:
- 'ruby -r./scripts/trigger-build.rb -e "puts Trigger.variables_for_env_file(Trigger::CNG.new.variables)" > build.env'
- ruby -r./scripts/trigger-build.rb -e "puts Trigger.variables_for_env_file(Trigger::CNG.new.variables)" > build.env
- ruby -e 'puts "FULL_RUBY_VERSION=#{RUBY_VERSION}"' >> build.env
- cat build.env
artifacts:
reports:
@ -70,12 +71,14 @@ review-build-cng:
FORCE_RAILS_IMAGE_BUILDS: "${FORCE_RAILS_IMAGE_BUILDS}"
CE_PIPELINE: "${CE_PIPELINE}" # Based on https://docs.gitlab.com/ee/ci/jobs/job_control.html#check-if-a-variable-exists, `if: '$CE_PIPELINE'` will evaluate to `false` when this variable is empty
EE_PIPELINE: "${EE_PIPELINE}" # Based on https://docs.gitlab.com/ee/ci/jobs/job_control.html#check-if-a-variable-exists, `if: '$EE_PIPELINE'` will evaluate to `false` when this variable is empty
GITLAB_SHELL_VERSION: "${GITLAB_SHELL_VERSION}"
GITLAB_ELASTICSEARCH_INDEXER_VERSION: "${GITLAB_ELASTICSEARCH_INDEXER_VERSION}"
GITLAB_KAS_VERSION: "${GITLAB_KAS_VERSION}"
GITLAB_WORKHORSE_VERSION: "${GITLAB_WORKHORSE_VERSION}"
GITLAB_METRICS_EXPORTER_VERSION: "${GITLAB_METRICS_EXPORTER_VERSION}"
GITLAB_PAGES_VERSION: "${GITLAB_PAGES_VERSION}"
GITLAB_SHELL_VERSION: "${GITLAB_SHELL_VERSION}"
GITLAB_WORKHORSE_VERSION: "${GITLAB_WORKHORSE_VERSION}"
GITALY_SERVER_VERSION: "${GITALY_SERVER_VERSION}"
RUBY_VERSION: "${FULL_RUBY_VERSION}"
trigger:
project: gitlab-org/build/CNG-mirror
branch: $TRIGGER_BRANCH
@ -88,7 +91,7 @@ review-build-cng:
variables:
HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}"
DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
GITLAB_HELM_CHART_REF: "138c146a5ba787942f66d4c7d795d224d6ba206a"
GITLAB_HELM_CHART_REF: "ed813953079c1d81aa69d4cb8171c69aa9741f01" # 6.5.4: https://gitlab.com/gitlab-org/charts/gitlab/-/commit/ed813953079c1d81aa69d4cb8171c69aa9741f01
environment:
name: review/${CI_COMMIT_REF_SLUG}${SCHEDULE_TYPE} # No separator for SCHEDULE_TYPE so it's compatible as before and looks nice without it
url: https://gitlab-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}
@ -113,11 +116,11 @@ review-deploy:
- echo "QA_GITLAB_URL=${CI_ENVIRONMENT_URL}" > environment.env
- *base-before_script
script:
- check_kube_domain
- download_chart
- deploy || (display_deployment_debug && exit 1)
- verify_deploy || exit 1
- disable_sign_ups || (delete_release && exit 1)
- run_timed_command "check_kube_domain"
- run_timed_command "download_chart"
- run_timed_command "deploy" || (display_deployment_debug && exit 1)
- run_timed_command "verify_deploy"|| (display_deployment_debug && exit 1)
- run_timed_command "disable_sign_ups"
after_script:
# Run seed-dast-test-data.sh only when DAST_RUN is set to true. This is to pupulate review app with data for DAST scan.
# Set DAST_RUN to true when jobs are manually scheduled.
@ -165,7 +168,7 @@ review-delete-deployment:
- .review:rules:review-delete-deployment
stage: prepare
script:
- delete_release
- delete_helm_release
review-stop:
extends:
@ -175,4 +178,4 @@ review-stop:
stage: deploy
needs: []
script:
- delete_namespace
- delete_helm_release

18
.gitlab/ci/review-apps/qa.gitlab-ci.yml
View file

@ -1,6 +1,6 @@
include:
- project: gitlab-org/quality/pipeline-common
ref: 1.3.0
ref: 1.7.0
file:
- /ci/base.gitlab-ci.yml
- /ci/allure-report.yml
@ -25,7 +25,7 @@ include:
- cd qa && bundle install
.review-qa-base:
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3-git-2.33-lfs-2.9-chrome-${CHROME_VERSION}-docker-${DOCKER_VERSION}-gcloud-383-kubectl-1.23
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3-git-2.36-lfs-2.9-chrome-${CHROME_VERSION}-docker-${DOCKER_VERSION}-gcloud-383-kubectl-1.23
extends:
- .use-docker-in-docker
- .bundle-base
@ -140,7 +140,7 @@ e2e-test-report:
variables:
ALLURE_JOB_NAME: e2e-review-qa
ALLURE_PROJECT_PATH: $CI_PROJECT_PATH
ALLURE_RESULTS_GLOB: qa/tmp/allure-results/*
ALLURE_RESULTS_GLOB: qa/tmp/allure-results
ALLURE_MERGE_REQUEST_IID: $CI_MERGE_REQUEST_IID
GITLAB_AUTH_TOKEN: $GITLAB_QA_MR_ALLURE_REPORT_TOKEN
GIT_STRATEGY: none
@ -178,7 +178,7 @@ notify-slack:
extends:
- .notify-slack-qa
- .qa-cache
- .rules:notify-slack
- .rules:main-run
stage: post-qa
variables:
RUN_WITH_BUNDLE: "true"
@ -188,6 +188,16 @@ notify-slack:
STATUS_SYM: ☠️
STATUS: failed
TYPE: "(review-app) "
when: on_failure
script:
- bundle exec gitlab-qa-report --prepare-stage-reports "$CI_PROJECT_DIR/qa/tmp/rspec-*.xml" # generate summary
- !reference [.notify-slack-qa, script]
export-test-metrics:
extends:
- .bundle-base
- .rules:main-run
stage: post-qa
when: always
script:
- bundle exec rake "ci:export_test_metrics[tmp/test-metrics-*.json]"

29
.gitlab/ci/review-apps/rules.gitlab-ci.yml
View file

@ -15,9 +15,9 @@
.app-changes: &app-changes
if: $APP_CHANGE_TRIGGER == "true"
# QA framework changes present
.qa-framework-changes: &qa-framework-changes
if: $QA_FRAMEWORK_CHANGES == "true"
# Run all tests when framework changes present or explicitly enabled full suite execution
.qa-run-all-tests: &qa-run-all-tests
if: $QA_FRAMEWORK_CHANGES == "true" || $QA_RUN_ALL_TESTS == "true"
.default-branch: &default-branch
if: $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH
@ -28,19 +28,19 @@
variables:
QA_TESTS: ""
.never-when-qa-framework-changes-or-no-specific-specs:
- <<: *qa-framework-changes
.never-when-qa-run-all-tests-or-no-specific-specs:
- <<: *qa-run-all-tests
when: never
- <<: *all-specs
when: never
.never-when-specific-specs-always-when-qa-framework-changes:
.never-when-specific-specs-always-when-qa-run-all-tests:
- *qa-run-all-tests
- <<: *specific-specs
when: manual
allow_failure: true
variables:
QA_TESTS: ""
- *qa-framework-changes
# ------------------------------------------
# Prepare
@ -62,7 +62,7 @@
- <<: *app-changes
variables:
QA_TESTS: "" # unset QA_TESTS even if specific tests were inferred from stage label
- *qa-framework-changes
- *qa-run-all-tests
- if: $QA_SUITES =~ /Test::Instance::Smoke/
- *qa-manual
@ -70,7 +70,7 @@
rules:
- <<: *app-changes
when: never
- !reference [.never-when-qa-framework-changes-or-no-specific-specs]
- !reference [.never-when-qa-run-all-tests-or-no-specific-specs]
- if: $QA_SUITES =~ /Test::Instance::ReviewBlocking/
.rules:qa-blocking-parallel:
rules:
@ -78,16 +78,16 @@
- <<: *app-changes
variables:
QA_TESTS: "" # unset QA_TESTS even if specific tests were inferred from stage label
- !reference [.never-when-specific-specs-always-when-qa-framework-changes]
- !reference [.never-when-specific-specs-always-when-qa-run-all-tests]
- if: $QA_SUITES =~ /Test::Instance::ReviewBlocking/
.rules:qa-non-blocking:
rules:
- !reference [.never-when-qa-framework-changes-or-no-specific-specs]
- !reference [.never-when-qa-run-all-tests-or-no-specific-specs]
- if: $QA_SUITES =~ /Test::Instance::ReviewNonBlocking/
.rules:qa-non-blocking-parallel:
rules:
- !reference [.never-when-specific-specs-always-when-qa-framework-changes]
- !reference [.never-when-specific-specs-always-when-qa-run-all-tests]
- *all-specs-mr # set full suite to manual when no specific specs passed in mr
- if: $QA_SUITES =~ /Test::Instance::ReviewNonBlocking/
@ -98,7 +98,6 @@
rules:
- when: always
.rules:notify-slack:
.rules:main-run:
rules:
- <<: *default-branch
when: on_failure
- *default-branch

6
.gitlab/ci/review.gitlab-ci.yml
View file

@ -3,20 +3,16 @@ review-cleanup:
- .default-retry
- .review:rules:review-cleanup
image: ${REVIEW_APPS_IMAGE}
resource_group: review/${CI_COMMIT_REF_SLUG}${SCHEDULE_TYPE} # CI_ENVIRONMENT_SLUG is not available here and we want this to be the same as the environment
stage: prepare
environment:
name: review/${CI_COMMIT_REF_SLUG}${SCHEDULE_TYPE} # No separator for SCHEDULE_TYPE so it's compatible as before and looks nice without it
name: review/regular-cleanup
action: stop
before_script:
- source scripts/utils.sh
- source scripts/review_apps/review-apps.sh
- source scripts/review_apps/gcp_cleanup.sh
- install_gitlab_gem
- setup_gcp_dependencies
script:
- delete_release
- delete_namespace
- scripts/review_apps/automated_cleanup.rb
- gcp_cleanup

350
.gitlab/ci/rules.gitlab-ci.yml
View file

@ -5,19 +5,23 @@
if: '$CI_PROJECT_NAMESPACE !~ /^gitlab(-org)?($|\/)/'
.if-not-ee: &if-not-ee
if: '$CI_PROJECT_NAME !~ /^gitlab(-ee)?$/'
# Only consider FOSS not EE
if: '$CI_PROJECT_NAME !~ /^gitlab(-ee)?$/ && $CI_PROJECT_NAME !~ /^gitlab-jh/'
.if-not-foss: &if-not-foss
if: '$CI_PROJECT_NAME != "gitlab-foss" && $CI_PROJECT_NAME != "gitlab-ce" && $CI_PROJECT_NAME != "gitlabhq"'
.if-jh: &if-jh
if: '$CI_PROJECT_PATH =~ /^gitlab-(jh|cn)\/.*/'
# Example of these projects:
# https://jihulab.com/gitlab-cn/gitlab
# https://gitlab.com/gitlab-org-sandbox/gitlab-jh-validation
if: '$CI_PROJECT_PATH =~ /^gitlab-(jh|cn)\/.*/ || $CI_PROJECT_NAME =~ /^gitlab-jh/'
.if-force-ci: &if-force-ci
if: '$FORCE_GITLAB_CI'
.if-default-refs: &if-default-refs
if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/ || $CI_COMMIT_REF_NAME =~ /^\d+-\d+-auto-deploy-\d+$/ || $CI_COMMIT_REF_NAME =~ /^security\// || $CI_MERGE_REQUEST_IID || $CI_COMMIT_TAG || $FORCE_GITLAB_CI'
if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/ || $CI_COMMIT_REF_NAME =~ /^\d+-\d+-auto-deploy-\d+$/ || $CI_COMMIT_REF_NAME =~ /^security\// || $CI_COMMIT_REF_NAME == "ruby3" || $CI_MERGE_REQUEST_IID || $CI_COMMIT_TAG || $FORCE_GITLAB_CI'
.if-default-branch-refs: &if-default-branch-refs
if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null'
@ -79,8 +83,11 @@
.if-merge-request-labels-group-global-search: &if-merge-request-labels-group-global-search
if: '$CI_MERGE_REQUEST_LABELS =~ /group::global search/'
.if-merge-request-labels-pipeline-revert: &if-merge-request-labels-pipeline-revert
if: '$CI_MERGE_REQUEST_LABELS =~ /pipeline:revert/'
.if-merge-request-labels-pipeline-expedite-master-fixing: &if-merge-request-labels-pipeline-expedite-master-fixing
if: '$CI_MERGE_REQUEST_LABELS =~ /master:(foss-)?broken/ && $CI_MERGE_REQUEST_LABELS =~ /pipeline:expedite-master-fixing/'
.if-merge-request-labels-frontend-and-feature-flag: &if-merge-request-labels-frontend-and-feature-flag
if: '$CI_MERGE_REQUEST_LABELS =~ /frontend/ && $CI_MERGE_REQUEST_LABELS =~ /feature flag/'
.if-security-merge-request: &if-security-merge-request
if: '$CI_PROJECT_NAMESPACE == "gitlab-org/security" && $CI_MERGE_REQUEST_IID'
@ -206,6 +213,9 @@
- "scripts/lint-doc.sh"
- ".gitlab/ci/docs.gitlab-ci.yml"
.docs-code-quality-patterns: &docs-code-quality-patterns
- "doc/**/*.md"
.docs-deprecations-and-removals-patterns: &docs-deprecations-and-removals-patterns
- "doc/update/deprecations.md"
- "doc/update/removals.md"
@ -275,7 +285,7 @@
- "Dockerfile.assets"
- "config/**/*.js"
- "vendor/assets/**/*"
- "{app/assets,app/components,app/helpers,app/presenters,app/views,locale,public,spec/frontend,symbol}/**/*"
- "{app/assets,app/components,app/helpers,app/presenters,app/views,locale,public,spec/frontend,storybook,symbol}/**/*"
.controllers-patterns: &controllers-patterns
- "{,ee/,jh/}{app/controllers}/**/*"
@ -390,7 +400,7 @@
- "Rakefile"
- "tests.yml"
- "config.ru"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,storybook,symbol,vendor}/**/*"
- "doc/api/graphql/reference/*" # Files in this folder are auto-generated
# CI changes
- ".gitlab-ci.yml"
@ -447,7 +457,7 @@
- "Rakefile"
- "tests.yml"
- "config.ru"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,storybook,symbol,vendor}/**/*"
- "doc/api/graphql/reference/*" # Files in this folder are auto-generated
# CI changes
- ".gitlab-ci.yml"
@ -466,6 +476,9 @@
- "data/whats_new/*.yml"
# .code-backstage-qa-patterns + .workhorse-patterns
# NOTE: `setup-test-env-patterns` intentionally does not include docs files, because this would
# result in docs-only pipelines having failures of jobs which use `setup-test-env-patterns`
# in their rules and thus require `setup-test-env`, which isn't present in docs-only pipelines.
.setup-test-env-patterns: &setup-test-env-patterns
- "{package.json,yarn.lock}"
- ".browserslistrc"
@ -481,7 +494,7 @@
- "Rakefile"
- "tests.yml"
- "config.ru"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*"
- "{,ee/,jh/}{app,bin,config,db,generator_templates,haml_lint,lib,locale,public,scripts,storybook,symbol,vendor}/**/*"
- "doc/api/graphql/reference/*" # Files in this folder are auto-generated
- "data/whats_new/*.yml"
# CI changes
@ -504,6 +517,8 @@
# CI Templates changes
- "scripts/lint_templates_bash.rb"
- "lib/gitlab/ci/templates/**/*.gitlab-ci.yml"
# GLFM specification changes
- "glfm_specification/**/*"
.static-analysis-patterns: &static-analysis-patterns
- ".{codeclimate,eslintrc,haml-lint,haml-lint_todo}.yml"
@ -535,9 +550,16 @@
.feature-flag-development-config-patterns: &feature-flag-development-config-patterns
- "{,ee/,jh/}config/feature_flags/{development,ops}/*.yml"
.glfm-patterns: &glfm-patterns
- ".gitlab/ci/rules.gitlab-ci.yml"
- "glfm_specification/**/*"
- "scripts/glfm/**/*"
- "scripts/lib/glfm/**/*"
##################
# Conditions set #
##################
.strict-ee-only-rules:
rules:
- <<: *if-not-ee
@ -545,6 +567,13 @@
- <<: *if-jh
when: never
.as-if-jh-default-exclusion-rules:
rules:
- <<: *if-security-merge-request
when: never
- <<: *if-merge-request-targeting-stable-branch
when: never
.rails:rules:minimal-default-rules:
rules:
- <<: *if-merge-request-approved
@ -558,6 +587,8 @@
rules:
- <<: *if-merge-request-labels-group-global-search
changes: *search-backend-patterns
- <<: *if-merge-request-labels-group-global-search
changes: *ci-patterns
.rails:rules:ee-and-foss-default-rules:
rules:
@ -636,7 +667,8 @@
.shared:rules:update-gitaly-binaries-cache:
rules:
- <<: *if-merge-request-labels-update-caches
- changes: *gitaly-patterns
- <<: *if-default-refs
changes: *gitaly-patterns
######################
# Build images rules #
@ -653,7 +685,11 @@
changes: *code-qa-patterns
- <<: *if-auto-deploy-branches
- <<: *if-default-branch-or-tag
variables:
ARCH: amd64,arm64
- <<: *if-dot-com-gitlab-org-schedule
variables:
ARCH: amd64,arm64
- <<: *if-force-ci
- <<: *if-ruby3-branch
@ -665,8 +701,10 @@
- <<: *if-merge-request-labels-run-review-app
- <<: *if-auto-deploy-branches
- <<: *if-ruby3-branch
- changes: *ci-build-images-patterns
- changes: *code-qa-patterns
- <<: *if-default-refs
changes: *ci-build-images-patterns
- <<: *if-default-refs
changes: *code-qa-patterns
#################
# Caching rules #
@ -760,6 +798,12 @@
when: manual
allow_failure: true
.docs:rules:docs-code-quality:
rules:
- <<: *if-default-branch-refs
- <<: *if-default-refs
changes: *docs-code-quality-patterns
.docs:rules:docs-lint:
rules:
- <<: *if-default-refs
@ -770,6 +814,36 @@
- <<: *if-default-refs
changes: *docs-deprecations-and-removals-patterns
##################
# GLFM rules #
##################
.glfm:rules:glfm-verify:
# NOTES ON RULES:
# 1. We only run this job in EE because some of the markdown examples in the generated files depend
# on EE-only features. This means that it may fail when it is first run in a full EE pipeline.
# 2. We run this job for the `.setup-test-env-patterns` subset of file changes because:
# A. There are potentially many different source files within the codebase which could
# change the contents of the generated GLFM files, and it is therefore safer to always
# run this job to ensure that no changes are missed.
# B. The `.setup-test-env-patterns` restriction is needed because the job `needs` the
# `setup-test-env` job.
# See more context on each rule in the inline comments below:
rules:
# The `glfm-verify` job has dependencies on EE, so only run it for EE
- !reference [".strict-ee-only-rules", rules]
# If any of the files that are DIRECTLY related to generating or managing the GLFM specification change,
# run `glfm-verify` to get quick feedback on any needed updates, even if the MR is not yet approved
- changes: *glfm-patterns
# Otherwise do not run `glfm-verify` if the MR is not approved
- <<: *if-merge-request-not-approved
when: never
# If we passed all the previous rules, run `glfm-verify` if there are any changes that could impact `glfm-verify`.
# This could potentially be a wide range of files, so we reuse `setup-test-env-patterns`, which includes
# almost all app files except docs files.
- changes: *setup-test-env-patterns
# If we are forcing all rspec to run, run this job too.
- <<: *if-merge-request-labels-run-all-rspec
##################
# GraphQL rules #
##################
@ -786,6 +860,8 @@
.frontend:rules:minimal-default-rules:
rules:
- <<: *if-merge-request-approved
when: never
- <<: *if-automated-merge-request
when: never
- <<: *if-security-merge-request
@ -798,15 +874,21 @@
- <<: *if-merge-request-targeting-stable-branch
- <<: *if-merge-request-labels-run-review-app
- <<: *if-auto-deploy-branches
- changes: *ci-build-images-patterns
- changes: *code-qa-patterns
- changes: *workhorse-patterns
- <<: *if-ruby3-branch
- <<: *if-default-refs
changes: *ci-build-images-patterns
- <<: *if-default-refs
changes: *code-qa-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
.frontend:rules:compile-test-assets:
rules:
- <<: *if-merge-request-labels-run-all-rspec
- changes: *code-backstage-qa-patterns
- changes: *workhorse-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
.frontend:rules:compile-test-assets-as-if-foss:
rules:
@ -814,14 +896,18 @@
when: never
- <<: *if-merge-request-labels-as-if-foss
- <<: *if-merge-request-labels-run-all-rspec
- changes: *code-backstage-qa-patterns
- changes: *startup-css-patterns
- changes: *workhorse-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *startup-css-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
.frontend:rules:default-frontend-jobs:
rules:
- <<: *if-merge-request-labels-run-all-rspec
- changes: *code-backstage-patterns
- <<: *if-default-refs
changes: *code-backstage-patterns
.frontend:rules:default-frontend-jobs-as-if-foss:
rules:
@ -832,11 +918,14 @@
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *startup-css-patterns
- <<: *if-merge-request
changes: *frontend-patterns-for-as-if-foss
.frontend:rules:frontend_fixture-as-if-foss:
rules:
- !reference [".strict-ee-only-rules", rules]
- !reference [".frontend:rules:default-frontend-jobs-as-if-foss", rules]
- <<: *if-merge-request-labels-run-all-jest
- <<: *if-merge-request
changes: *frontend-patterns-for-as-if-foss
@ -845,13 +934,18 @@
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-run-all-jest
- <<: *if-merge-request-labels-frontend-and-feature-flag
- <<: *if-merge-request
changes: *frontend-dependency-patterns
- <<: *if-merge-request
changes: [".gitlab/ci/rules.gitlab-ci.yml", ".gitlab/ci/frontend.gitlab-ci.yml"]
- <<: *if-automated-merge-request
changes: *code-backstage-patterns
- <<: *if-security-merge-request
changes: *code-backstage-patterns
- <<: *if-default-branch-refs
- <<: *if-merge-request-not-approved
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
.frontend:rules:jest:minimal:
@ -861,10 +955,13 @@
- !reference [".frontend:rules:minimal-default-rules", rules]
- <<: *if-merge-request-labels-run-all-jest
when: never
- changes: *core-frontend-patterns
- <<: *if-merge-request-labels-frontend-and-feature-flag
when: never
- <<: *if-merge-request
changes: *ci-patterns
changes: *frontend-dependency-patterns
when: never
- <<: *if-merge-request
changes: [".gitlab/ci/rules.gitlab-ci.yml", ".gitlab/ci/frontend.gitlab-ci.yml"]
when: never
- <<: *if-merge-request
changes: *code-backstage-patterns
@ -874,15 +971,26 @@
- !reference [".strict-ee-only-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
- <<: *if-merge-request-labels-run-all-jest
- <<: *if-merge-request
changes: *frontend-dependency-patterns
- <<: *if-security-merge-request
changes: *code-backstage-patterns
- <<: *if-merge-request-not-approved
when: never
- <<: *if-merge-request
changes: *frontend-patterns-for-as-if-foss
.frontend:rules:jest:minimal:as-if-foss:
rules:
- !reference [".strict-ee-only-rules", rules]
- !reference [".frontend:rules:minimal-default-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
when: never
- <<: *if-merge-request-labels-run-all-jest
when: never
- <<: *if-merge-request
changes: *frontend-dependency-patterns
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request
@ -899,7 +1007,7 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request
changes: *code-backstage-patterns
@ -941,6 +1049,18 @@
- <<: *if-default-refs
changes: *code-patterns
##########
# Notify #
##########
.notify:rules:notify-pipeline-failure:
rules:
# Don't report child pipeline failures
- if: '$CI_PIPELINE_SOURCE == "parent_pipeline"'
when: never
- if: '$CI_SLACK_WEBHOOK_URL && $NOTIFY_PIPELINE_FAILURE_CHANNEL'
when: on_failure
allow_failure: true
###############
# Pages rules #
###############
@ -996,7 +1116,7 @@
when: never
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request-targeting-stable-branch
allow_failure: true
@ -1031,6 +1151,8 @@
SKIP_REPORT_IN_ISSUES: "false"
PROCESS_TEST_RESULTS: "true"
KNAPSACK_GENERATE_REPORT: "true"
QA_SAVE_TEST_METRICS: "true"
QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency
- <<: *if-force-ci
when: manual
allow_failure: true
@ -1040,7 +1162,8 @@
###############
.rails:rules:setup-test-env:
rules:
- changes: *setup-test-env-patterns
- <<: *if-default-refs
changes: *setup-test-env-patterns
- <<: *if-merge-request-labels-run-all-rspec
.rails:rules:single-db:
@ -1072,7 +1195,8 @@
changes: *db-patterns
- <<: *if-merge-request-not-approved
when: never
- changes: *db-patterns
- <<: *if-default-refs
changes: *db-patterns
.rails:rules:ee-and-foss-migration:minimal:
rules:
@ -1105,7 +1229,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- changes: *backend-patterns
- <<: *if-default-refs
changes: *backend-patterns
.rails:rules:ee-and-foss-unit:minimal:
rules:
@ -1121,7 +1246,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- changes: *backend-patterns
- <<: *if-default-refs
changes: *backend-patterns
.rails:rules:ee-and-foss-integration:minimal:
rules:
@ -1137,7 +1263,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:system-default-rules", rules]
- changes: *code-backstage-patterns
- <<: *if-default-refs
changes: *code-backstage-patterns
.rails:rules:ee-and-foss-system:minimal:
rules:
@ -1151,11 +1278,13 @@
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *backend-patterns
- changes: *core-backend-patterns
- <<: *if-default-refs
changes: *core-backend-patterns
.rails:rules:code-backstage-qa:
rules:
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
- <<: *if-merge-request-labels-run-all-rspec
.rails:rules:ee-only-migration:
@ -1175,7 +1304,8 @@
changes: *db-patterns
- <<: *if-merge-request-not-approved
when: never
- changes: *db-patterns
- <<: *if-default-refs
changes: *db-patterns
.rails:rules:ee-only-migration:minimal:
rules:
@ -1196,7 +1326,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- changes: *backend-patterns
- <<: *if-default-refs
changes: *backend-patterns
.rails:rules:ee-only-unit:minimal:
rules:
@ -1216,7 +1347,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- changes: *backend-patterns
- <<: *if-default-refs
changes: *backend-patterns
.rails:rules:ee-only-integration:minimal:
rules:
@ -1236,7 +1368,8 @@
- <<: *if-fork-merge-request
when: never
- !reference [".rails:rules:system-default-rules", rules]
- changes: *code-backstage-patterns
- <<: *if-default-refs
changes: *code-backstage-patterns
.rails:rules:ee-only-system:minimal:
rules:
@ -1350,7 +1483,8 @@
.rails:rules:ee-and-foss-db-library-code:
rules:
- changes: *db-library-patterns
- <<: *if-default-refs
changes: *db-library-patterns
- <<: *if-merge-request-labels-run-all-rspec
.rails:rules:ee-mr-and-default-branch-only:
@ -1366,8 +1500,10 @@
.rails:rules:detect-tests:
rules:
- <<: *if-merge-request-labels-run-all-rspec
- changes: *code-backstage-qa-patterns
- changes: *workhorse-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
.rails:rules:detect-previous-failed-tests:
rules:
@ -1419,7 +1555,7 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request
changes: *code-backstage-patterns
@ -1430,7 +1566,7 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request-labels-skip-undercoverage
when: never
@ -1458,13 +1594,14 @@
rules:
- <<: *if-not-ee
when: never
- changes: *code-backstage-patterns
- <<: *if-default-refs
changes: *code-backstage-patterns
.rails:rules:flaky-tests-report:
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- if: '$SKIP_FLAKY_TESTS_AUTOMATICALLY == "true" || $RETRY_FAILED_TESTS_IN_NEW_PROCESS == "true"'
changes: *code-backstage-patterns
@ -1476,38 +1613,51 @@
.static-analysis:rules:static-analysis:
rules:
- changes: *code-backstage-qa-patterns
- changes: *static-analysis-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *static-analysis-patterns
.static-analysis:rules:static-verification-with-database:
rules:
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
.static-analysis:rules:rubocop:
rules:
- changes: *rubocop-patterns
- <<: *if-default-refs
changes: *rubocop-patterns
variables:
RUN_ALL_RUBOCOP: "true"
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
.static-analysis:rules:qa:metadata-lint:
rules:
- changes: *qa-patterns
- changes: [".gitlab/ci/static-analysis.gitlab-ci.yml"]
- <<: *if-default-refs
changes: *qa-patterns
- <<: *if-default-refs
changes: [".gitlab/ci/static-analysis.gitlab-ci.yml"]
.static-analysis:rules:haml-lint:
rules:
- changes: *rubocop-patterns
- changes: *static-analysis-patterns
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *rubocop-patterns
- <<: *if-default-refs
changes: *static-analysis-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
.static-analysis:rules:haml-lint-ee:
rules:
- <<: *if-not-ee
when: never
- changes: *rubocop-patterns
- changes: *static-analysis-patterns
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *rubocop-patterns
- <<: *if-default-refs
changes: *static-analysis-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
.static-analysis:rules:static-analysis-as-if-foss:
rules:
@ -1614,8 +1764,10 @@
rules:
- if: '$CODE_QUALITY_DISABLED'
when: never
# Run code_quality on master until https://gitlab.com/gitlab-org/gitlab/-/issues/363747 is resolved
- <<: *if-default-branch-refs
- <<: *if-default-refs
changes: *code-backstage-patterns
changes: *code-backstage-qa-patterns
.reports:rules:brakeman-sast:
rules:
@ -1623,26 +1775,19 @@
when: never
- if: $SAST_EXCLUDED_ANALYZERS =~ /brakeman/
when: never
- changes:
- <<: *if-default-refs
changes:
- '**/*.rb'
- '**/Gemfile'
.reports:rules:gosec-sast:
rules:
- if: $SAST_DISABLED
when: never
- if: $SAST_EXCLUDED_ANALYZERS =~ /gosec/
when: never
- changes:
- '**/*.go'
.reports:rules:semgrep-sast:
rules:
- if: $SAST_DISABLED
when: never
- if: $SAST_EXCLUDED_ANALYZERS =~ /semgrep/
when: never
- changes:
- <<: *if-default-refs
changes:
- '**/*.py'
- '**/*.js'
- '**/*.jsx'
@ -1658,7 +1803,8 @@
when: never
# Scan each commit on master to feed the Vulnerability Reports with detected secrets
- <<: *if-default-branch-refs
- changes: *code-backstage-qa-patterns
- <<: *if-default-refs
changes: *code-backstage-qa-patterns
.reports:rules:gemnasium-dependency_scanning:
rules:
@ -1666,7 +1812,8 @@
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
- <<: *if-default-branch-refs
- changes: *dependency-patterns
- <<: *if-default-refs
changes: *dependency-patterns
.reports:rules:gemnasium-python-dependency_scanning:
rules:
@ -1674,7 +1821,8 @@
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
- <<: *if-default-branch-refs
- changes: *python-patterns
- <<: *if-default-refs
changes: *python-patterns
.reports:rules:yarn-audit-dependency_scanning:
rules:
@ -1682,7 +1830,8 @@
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
- <<: *if-default-branch-refs
- changes: *nodejs-patterns
- <<: *if-default-refs
changes: *nodejs-patterns
.reports:rules:schedule-dast:
rules:
@ -1690,6 +1839,12 @@
when: never
- <<: *if-dot-com-ee-schedule-nightly-child-pipeline
.reports:rules:test-dast:
rules:
- if: '$DAST_DISABLED || $GITLAB_FEATURES !~ /\bdast\b/'
when: never
- <<: *if-merge-request
.reports:rules:package_hunter-yarn:
rules:
- if: "$PACKAGE_HUNTER_USER == null || $PACKAGE_HUNTER_USER == ''"
@ -1710,7 +1865,8 @@
rules:
- if: '$LICENSE_MANAGEMENT_DISABLED || $GITLAB_FEATURES !~ /\blicense_scanning\b/'
when: never
- changes: *dependency-patterns
- <<: *if-default-refs
changes: *dependency-patterns
################
# Review rules #
@ -1726,33 +1882,42 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request-labels-run-review-app
- <<: *if-dot-com-gitlab-org-merge-request
changes: *ci-review-patterns
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *frontend-build-patterns
variables: *review-change-pattern
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *controllers-patterns
variables: *review-change-pattern
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *models-patterns
variables: *review-change-pattern
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *lib-gitlab-patterns
variables: *review-change-pattern
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *qa-patterns
when: never
- <<: *if-dot-com-gitlab-org-merge-request
changes: *code-patterns
when: manual
allow_failure: true
- <<: *if-dot-com-gitlab-org-schedule
when: never
allow_failure: true
variables:
KNAPSACK_GENERATE_REPORT: "true"
QA_SAVE_TEST_METRICS: "true"
QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency
.review:rules:review-build-cng:
rules:
@ -1783,7 +1948,7 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-revert
- <<: *if-merge-request-labels-pipeline-expedite-master-fixing
when: never
- <<: *if-merge-request-labels-run-review-app
when: manual
@ -1897,7 +2062,8 @@
- <<: *if-not-ee
when: never
- <<: *if-dot-com-ee-schedule-maintenance
- changes:
- <<: *if-default-refs
changes:
- ".gitlab/ci/setup.gitlab-ci.yml"
- ".gitlab/ci/test-metadata.gitlab-ci.yml"
- "scripts/rspec_helpers.sh"
@ -1907,8 +2073,10 @@
#######################
.test-metadata:rules:retrieve-tests-metadata:
rules:
- changes: *code-backstage-patterns
- changes: *workhorse-patterns
- <<: *if-default-refs
changes: *code-backstage-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
- <<: *if-merge-request-labels-run-all-rspec
.test-metadata:rules:update-tests-metadata:
@ -1916,7 +2084,8 @@
- <<: *if-not-ee
when: never
- <<: *if-dot-com-ee-schedule-maintenance
- changes:
- <<: *if-default-refs
changes:
- ".gitlab/ci/test-metadata.gitlab-ci.yml"
- "scripts/rspec_helpers.sh"
@ -1925,7 +2094,8 @@
###################
.workhorse:rules:workhorse:
rules:
- changes: *workhorse-patterns
- <<: *if-default-refs
changes: *workhorse-patterns
###################
# yaml-lint rules #
@ -1944,3 +2114,21 @@
rules:
- <<: *if-default-refs
changes: *lint-metrics-yaml-patterns
##################
# as-if-jh rules #
##################
.as-if-jh:rules:prepare-as-if-jh:
rules:
- !reference [".strict-ee-only-rules", rules]
- !reference [".as-if-jh-default-exclusion-rules", rules]
- <<: *if-merge-request-labels-as-if-jh
# This rule should share the same logic with .as-if-jh:rules:prepare-as-if-jh
# Because the jobs using this need jobs using the preparation rules
.as-if-jh:rules:start-as-if-jh:
rules:
- !reference [".strict-ee-only-rules", rules]
- !reference [".as-if-jh-default-exclusion-rules", rules]
- <<: *if-merge-request-labels-as-if-jh
allow_failure: true # See https://gitlab.com/gitlab-org/gitlab/-/issues/351136

11
.gitlab/ci/static-analysis.gitlab-ci.yml
View file

@ -122,6 +122,8 @@ rubocop:
needs:
- job: detect-tests
optional: true
variables:
RUBOCOP_TARGET_FILES: "tmp/rubocop_target_files.txt"
script:
- |
# For non-merge request, or when RUN_ALL_RUBOCOP is 'true', run all RuboCop rules
@ -132,8 +134,13 @@ rubocop:
unset CI_SLACK_WEBHOOK_URL
run_timed_command "bundle exec rake rubocop:check:graceful"
else
cat ${RSPEC_CHANGED_FILES_PATH} | ruby -e 'puts $stdin.read.split(" ").select { |f| File.exist?(f) }.join(" ")' > tmp/rubocop_target_files.txt
run_timed_command "bundle exec rubocop --parallel --force-exclusion $(cat tmp/rubocop_target_files.txt)"
cat "${RSPEC_CHANGED_FILES_PATH}" | ruby -e 'print $stdin.read.split(" ").select { |f| File.exist?(f) }.join(" ")' > "$RUBOCOP_TARGET_FILES"
# Skip running RuboCop if there's no target files
if [ -s "${RUBOCOP_TARGET_FILES}" ]; then
run_timed_command "bundle exec rubocop --parallel --force-exclusion $(cat ${RUBOCOP_TARGET_FILES})"
else
echoinfo "Nothing interesting changed for RuboCop. Skipping."
fi
fi
qa:metadata-lint:

2
.gitlab/ci/workhorse.gitlab-ci.yml
View file

@ -27,7 +27,7 @@ workhorse:test go:
extends: .workhorse:test
parallel:
matrix:
- GO_VERSION: ["1.17", "1.18", "1.19"]
- GO_VERSION: ["1.18", "1.19"]
script:
- make -C workhorse test-coverage
coverage: '/\d+.\d+%/'

4
.gitlab/issue_templates/Deprecations.md
View file

@ -1,4 +1,4 @@
For guidance on the overall deprecations, removals and breaking changes workflow, please visit [Breaking changes, deprecations, and removing features](https://about.gitlab.com/handbook/product/gitlab-the-product/#breaking-changes-deprecations-and-removing-features)
For guidance on the overall deprecations, removals and breaking changes workflow, please visit [Breaking changes, deprecations, and removing features](https://about.gitlab.com/handbook/product/gitlab-the-product/#deprecations-removals-and-breaking-changes)
<!-- Use this template as a starting point for deprecations. -->
@ -11,7 +11,7 @@ It is recommended that you link to the documentation.
The description of the deprecation should state what actions the user should take to rectify the behavior. If the deprecation is scheduled for an upcoming release, the content should remain in the deprecations documentation page until it has been completed. For example, if a deprecation is announced in 14.9 and scheduled to be completed in 15.0, the same content would be included in the documentation for 14.9, 14.10, and 15.0.
**If this issue proposes a breaking change outside a major release XX.0, you need to get approval from your manager and request collaboration from Product Operations on communication. Be sure to follow the guidance [here](https://about.gitlab.com/handbook/product/gitlab-the-product/#breaking-changes-deprecations-and-removing-features.)**
**If this issue proposes a breaking change outside a major release XX.0, you need to get approval from your manager and request collaboration from Product Operations on communication. Be sure to follow the guidance [here](https://about.gitlab.com/handbook/product/gitlab-the-product/#deprecations-removals-and-breaking-changes.)**
-->

2
.gitlab/issue_templates/Experiment Implementation.md
View file

@ -18,7 +18,7 @@
# Tracking Details
- [json schema](https://gitlab.com/gitlab-org/iglu/-/blob/master/public/schemas/com.gitlab/gitlab_experiment/jsonschema/0-3-0) used in `gitlab-experiment` tracking.
- see [taxonomy](https://docs.gitlab.com/ee/development/snowplow/index.html#structured-event-taxonomy) for a guide.
- see [event schema](https://docs.gitlab.com/ee/development/snowplow/index.html#event-schema) for a guide.
| sequence | activity | category | action | label | property | value |
| -------- | -------- | ------ | ----- | ------- | -------- | ----- |

19
.gitlab/issue_templates/Feature Flag Roll Out.md
View file

@ -1,8 +1,17 @@
<!-- Title suggestion: [Feature flag] Enable description of feature -->
<!--
Set the main issue link: The main issue is the one that describes the problem to solve,
the one this feature flag is being added for. For example:
[main-issue]: https://gitlab.com/gitlab-org/gitlab/-/issues/123456
-->
[main-issue]: MAIN-ISSUE-LINK
## Summary
This issue is to rollout [the feature](ISSUE LINK) on production,
This issue is to rollout [the feature][main-issue] on production,
that is currently behind the `<feature-flag-name>` feature flag.
<!-- Short description of what the feature is about and link to relevant other issues. -->
@ -89,7 +98,7 @@ _Consider adding links to check for Sentry errors, Production logs for 5xx, 302s
- [ ] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production.
If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias.
- [ ] Ensure that documentation has been updated ([More info](https://docs.gitlab.com/ee/development/documentation/feature_flags.html#features-that-became-enabled-by-default)).
- [ ] Announce on [the feature issue](ISSUE LINK) an estimated time this will be enabled on GitLab.com.
- [ ] Leave a comment on [the feature issue][main-issue] announcing estimated time when this feature flag will be enabled on GitLab.com.
- [ ] Ensure that any breaking changes have been announced following the [release post process](https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations-removals-and-breaking-changes) to ensure GitLab customers are aware.
- [ ] Notify `#support_gitlab-com` and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#communicate-the-change)).
@ -104,7 +113,7 @@ For visibility, all `/chatops` commands that target production should be execute
- [ ] `/chatops run feature set <feature-flag-name> <rollout-percentage> --random`
- Enable the feature globally on production environment.
- [ ] `/chatops run feature set <feature-flag-name> true`
- [ ] Announce on [the feature issue](ISSUE LINK) that the feature has been globally enabled.
- [ ] Leave a comment on [the feature issue][main-issue] announcing that the feature has been globally enabled.
- [ ] Wait for [at least one day for the verification term](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release).
### (Optional) Release the feature with the feature flag
@ -122,7 +131,7 @@ To do so, follow these steps:
- [ ] `/chatops run release check <merge-request-url> <milestone>`
- [ ] Consider cleaning up the feature flag from all environments by running these chatops command in `#production` channel. Otherwise these settings may override the default enabled.
- [ ] `/chatops run feature delete <feature-flag-name> --dev --staging --staging-ref --production`
- [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone.
- [ ] Close [the feature issue][main-issue] to indicate the feature will be released in the current milestone.
- [ ] Set the next milestone to this rollout issue for scheduling [the flag removal](#release-the-feature).
- [ ] (Optional) You can [create a separate issue](https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Feature%20Flag%20Cleanup) for scheduling the steps below to [Release the feature](#release-the-feature).
- [ ] Set the title to "[Feature flag] Cleanup `<feature-flag-name>`".
@ -155,7 +164,7 @@ You can either [create a follow-up issue for Feature Flag Cleanup](https://gitla
If the merge request was deployed before [the monthly release was tagged](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1),
the feature can be officially announced in a release blog post.
- [ ] `/chatops run release check <merge-request-url> <milestone>`
- [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone.
- [ ] Close [the feature issue][main-issue] to indicate the feature will be released in the current milestone.
- [ ] If not already done, clean up the feature flag from all environments by running these chatops command in `#production` channel:
- [ ] `/chatops run feature delete <feature-flag-name> --dev --staging --staging-ref --production`
- [ ] Close this rollout issue.

10
.gitlab/issue_templates/Geo Replicate a new Git repository type.md
View file

@ -57,10 +57,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
# frozen_string_literal: true
class CreateCoolWidgetRegistry < Gitlab::Database::Migration[2.0]
disable_ddl_transaction!
def up
Geo::TrackingBase.transaction do
def change
create_table :cool_widget_registry, id: :bigserial, force: :cascade do |t|
t.bigint :cool_widget_id, null: false
t.datetime_with_timezone :created_at, null: false
@ -93,11 +90,6 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
end
end
end
def down
drop_table :cool_widget_registry
end
end
```
- [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md).

10
.gitlab/issue_templates/Geo Replicate a new blob type.md
View file

@ -59,10 +59,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
# frozen_string_literal: true
class CreateCoolWidgetRegistry < Gitlab::Database::Migration[2.0]
disable_ddl_transaction!
def up
Geo::TrackingBase.transaction do
def change
create_table :cool_widget_registry, id: :bigserial, force: :cascade do |t|
t.bigint :cool_widget_id, null: false
t.datetime_with_timezone :created_at, null: false
@ -93,11 +90,6 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
end
end
end
def down
drop_table :cool_widget_registry
end
end
```
- [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md).

1
.gitlab/issue_templates/Security developer workflow.md
View file

@ -64,6 +64,7 @@ After your merge request has been approved according to our [approval guidelines
| Upgrade notes | | |
| GitLab Settings updated | Yes/No| |
| Migration required | Yes/No | |
| Breaking change to UI or public API | Yes/No | <!-- How should the breaking change be communicated? --> |
| Thanks | | |
[security process for developers]: https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md

4
.gitlab/merge_request_templates/Documentation.md
View file

@ -14,7 +14,7 @@
- [Documentation guidelines](https://docs.gitlab.com/ee/development/documentation/).
- [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
- [ ] If you're adding or changing the main heading of the page (H1), ensure that the [product tier badge](https://docs.gitlab.com/ee/development/documentation/styleguide/index.html#product-tier-badges) is added.
- [ ] If you are a GitLab team member, [request a review](https://docs.gitlab.com/ee/development/code_review.html#dogfooding-the-attention-request-feature) based on:
- [ ] If you are a GitLab team member, [request a review](https://docs.gitlab.com/ee/development/code_review.html#dogfooding-the-reviewers-feature) based on:
- The documentation page's [metadata](https://docs.gitlab.com/ee/development/documentation/#metadata).
- The [associated Technical Writer](https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments).
@ -31,6 +31,8 @@ These labels cause the MR to be added to code verification QA issues.
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on [Documentation Guidelines](https://docs.gitlab.com/ee/development/documentation/) and the [Style Guide](https://docs.gitlab.com/ee/development/documentation/styleguide/).
If you aren't sure which tech writer to ask, use [roulette](https://gitlab-org.gitlab.io/gitlab-roulette/?sortKey=stats.avg30&order=-1&hourFormat24=true&visible=maintainer%7Cdocs) or ask in the [#docs](https://gitlab.slack.com/archives/C16HYA2P5) Slack channel.
- [ ] If the content requires it, ensure the information is reviewed by a subject matter expert.
- Technical writer review items:
- [ ] Ensure docs metadata is present and up-to-date.

4
.gitlab/merge_request_templates/Pipeline Configuration.md
View file

@ -1,4 +1,4 @@
<!-- See Pipelines for the GitLab project: https://docs.gitlab.com/ee/development/pipelines.html -->
<!-- See Pipelines for the GitLab project: https://docs.gitlab.com/ee/development/pipelines -->
<!-- When in doubt about a Pipeline configuration change, feel free to ping @gl-quality/eng-prod. -->
## What does this MR do?
@ -15,7 +15,7 @@
Consider the effect of the changes in this merge request on the following:
- [ ] Different [pipeline types](https://docs.gitlab.com/ee/development/pipelines.html#pipelines-for-merge-requests)
- [ ] Different [pipeline types](https://docs.gitlab.com/ee/development/pipelines/index.html#pipelines-types-for-merge-requests)
- Non-canonical projects:
- [ ] `gitlab-foss`
- [ ] `security`

2
.gitlab/merge_request_templates/Quarantine End to End Test.md
View file

@ -26,7 +26,7 @@ the noise (due to constantly failing tests, flaky tests, and so on) so that new
- [ ] Dequarantine test check-list
- [ ] Follow the [Dequarantining Tests guide](https://about.gitlab.com/handbook/engineering/quality/quality-engineering/debugging-qa-test-failures/#dequarantining-tests).
- [ ] Confirm the test consistently passes on the target GitLab environment(s).
- [ ] To ensure a faster turnaround, ask in the `#quality` Slack channel for someone to review and merge the merge request, rather than assigning it directly.
- [ ] To ensure a faster turnaround, ask in the `#quality_maintainers` Slack channel for someone to review and merge the merge request, rather than assigning it directly.
<!-- Base labels. -->
/label ~"Quality" ~"QA" ~"type::maintenance"

2
.gitlab/merge_request_templates/Removals.md
View file

@ -18,7 +18,7 @@ If there is no relevant deprecation issue, hit pause and:
Removals must be [announced as deprecations](https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations) at least 2 milestones in advance of the planned removal date.
If the removal creates a [breaking change](https://about.gitlab.com/handbook/product/gitlab-the-product/#breaking-changes-deprecations-and-removing-features), it can only be removed in a major "XX.0" release.
If the removal creates a [breaking change](https://about.gitlab.com/handbook/product/gitlab-the-product/#deprecations-removals-and-breaking-changes), it can only be removed in a major "XX.0" release.
**By the 10th**: Assign this MR to these team members as reviewers, and for approval:

49
.gitpod.yml
View file

@ -1,28 +1,38 @@
# Gitpod file reference
# https://www.gitpod.io/docs/configure/workspaces/tasks
image: registry.gitlab.com/gitlab-org/gitlab-development-kit/gitpod-workspace:stable
tasks:
- name: GDK
# "command:" emits gitpod-start
before: |
START_UNIXTIME="$(date +%s)"
echo START_UNIXTIME="$(date +%s)" > /workspace/gitpod_start_time.sh
command: |
echo START_TIME_IN_SECONDS="$(date +%s)" | tee /workspace/gitpod_start_time.sh
# send signal to other tasks that Gitpod started
gp sync-done gitpod-start
echo "Waiting for other task to copy GDK.."
gp sync-await gdk-copied && cd /workspace/gitlab-development-kit && gdk help
- init: |
echo "$(date) – Copying GDK" | tee -a /workspace/startup.log
cp -r $HOME/gitlab-development-kit /workspace/
- name: GitLab
# "command:" emits gdk-copied
init: |
(
set -e
echo "$(date) – Copying GDK" | tee -a /workspace/startup.log
cp -r $HOME/gitlab-development-kit /workspace/
cd /workspace/gitlab-development-kit
# Ensure GitLab directory is symlinked under the GDK
# ensure GitLab directory is symlinked under the GDK
ln -nfs "$GITPOD_REPO_ROOT" /workspace/gitlab-development-kit/gitlab
mv /workspace/gitlab-development-kit/secrets.yml /workspace/gitlab-development-kit/gitlab/config
mv -v /workspace/gitlab-development-kit/secrets.yml /workspace/gitlab-development-kit/gitlab/config
# ensure gdk.yml has correct instance settings
gdk config set gitlab.rails.port 443
gdk config set gitlab.rails.https.enabled true
gdk config set webpack.host 127.0.0.1
gdk config set webpack.static false
gdk config set webpack.live_reload false
gdk config set gitlab.rails.port 443 |& tee -a /workspace/startup.log
gdk config set gitlab.rails.https.enabled true |& tee -a /workspace/startup.log
gdk config set webpack.host 127.0.0.1 |& tee -a /workspace/startup.log
gdk config set webpack.static false |& tee -a /workspace/startup.log
gdk config set webpack.live_reload false |& tee -a /workspace/startup.log
# reconfigure GDK
echo "$(date) – Reconfiguring GDK" | tee -a /workspace/startup.log
gdk reconfigure
@ -36,9 +46,9 @@ tasks:
)
command: |
(
gp sync-await gitpod-start
set -e
gp sync-done gdk-copied
gp sync-await gitpod-start
[[ -f /workspace/gitpod_start_time.sh ]] && source /workspace/gitpod_start_time.sh
SECONDS=0
cd /workspace/gitlab-development-kit
@ -67,15 +77,14 @@ tasks:
make gitlab-db-migrate
fi
cd /workspace/gitlab-development-kit/gitlab
# Display which branch we're on
git branch --show-current
# Install Lefthook
echo "--- on branch: $(git branch --show-current)"
echo "--- installing lefthook"
bundle exec lefthook install
echo "--- resetting db/structure.sql"
git checkout db/structure.sql
cd /workspace/gitlab-development-kit
# Waiting for GitLab ...
echo "--- waiting for GitLab"
gp ports await 3000
printf "Waiting for GitLab at $(gp url 3000) ..."
printf "Awaiting /-/readiness on $(gp url 3000) ..."
# Check /-/readiness which returns JSON, but we're only interested in the exit code
#
# We use http://localhost:3000 instead of the public hostname because
@ -86,7 +95,7 @@ tasks:
printf "$(date) – GitLab is up (took ~%.1f minutes)\n" "$((10*$SECONDS/60))e-1" | tee -a /workspace/startup.log
gp preview $(gp url 3000) || true
PREBUILD_LOG=(/workspace/.gitpod/prebuild-log-*)
[[ -f /workspace/gitpod_start_time.sh ]] && printf "Took %.1f minutes from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitpod.yml being executed through to completion %s\n" "$((10*(($(date +%s)-${START_TIME_IN_SECONDS}))/60))e-1" "$([[ -f "$PREBUILD_LOG" ]] && echo "With Prebuilds")"
[[ -f /workspace/gitpod_start_time.sh ]] && printf "Took %.1f minutes from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitpod.yml being executed through to completion %s\n" "$((10*(($(date +%s)-${START_UNIXTIME}))/60))e-1" "$([[ -f "$PREBUILD_LOG" ]] && echo "With Prebuilds")"
)
ports:
@ -116,5 +125,5 @@ vscode:
- karunamurti.haml@1.4.1
- octref.vetur@0.36.0
- dbaeumer.vscode-eslint@2.2.6
- GitLab.gitlab-workflow@3.48.1
- GitLab.gitlab-workflow@3.56.0
- DavidAnson.vscode-markdownlint@0.47.0

1
.haml-lint.yml
View file

@ -110,6 +110,7 @@ linters:
- Cop/LineBreakAfterGuardClauses
- Cop/ProjectPathHelper
- Gitlab/FeatureAvailableUsage
- Gitlab/Json
- GitlabSecurity/PublicSend
- Layout/EmptyLineAfterGuardClause
- Layout/LeadingCommentSpace

14
.haml-lint_todo.yml
View file

@ -1,19 +1,7 @@
# This configuration was generated by
# `haml-lint --auto-gen-config`
# on 2022-09-15 12:13:31 +0000 using Haml-Lint version 0.40.1.
# on 2022-10-19 13:09:51 +0200 using Haml-Lint version 0.40.1.
# The point is for the user to remove these configuration records
# one by one as the lints are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of Haml-Lint, may require this file to be generated again.
linters:
# Offense count: 11
RuboCop:
exclude:
- "app/views/layouts/_page.html.haml"
- "app/views/layouts/header/_default.html.haml"
- "app/views/projects/merge_requests/dropdowns/_branch.html.haml"
- "app/views/projects/merge_requests/dropdowns/_project.html.haml"
- "app/views/shared/_flash_user_callout.html.haml"
- "app/views/shared/_label.html.haml"

69
.rubocop.yml
View file

@ -289,11 +289,6 @@ Rails/InverseOf:
Rails/UniqueValidationWithoutIndex:
Enabled: false
Rails/HasManyOrHasOneDependent:
Include:
- app/models/**/*.rb
- ee/app/models/**/*.rb
Rails/HelperInstanceVariable:
Include:
- app/helpers/**/*.rb
@ -308,6 +303,26 @@ Rails/RakeEnvironment:
# Context on why it's disabled: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93419#note_1048223982
Enabled: false
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94064#note_1157289970
Rails/SquishedSQLHeredocs:
Enabled: false
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/96675#note_1094403693
Rails/WhereExists:
Enabled: false
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94061#note_1160343775
Rails/SkipsModelValidations:
Enabled: false
# See https://gitlab.com/gitlab-org/gitlab/-/issues/378105#note_1138487716
Rails/HasManyOrHasOneDependent:
Enabled: false
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94019#note_1139714728
Rails/CreateTableWithTimestamps:
Enabled: false
# GitLab ###################################################################
Gitlab/ModuleWithInstanceVariables:
@ -384,7 +399,13 @@ Database/MultipleDatabases:
- 'spec/lib/gitlab/background_migration/**/*.rb'
- 'spec/lib/gitlab/database/**/*.rb'
Gitlab/DuplicateSpecLocation:
# See https://gitlab.com/gitlab-org/gitlab/-/issues/373194
Gitlab/RSpec/AvoidSetup:
Enabled: true
Include:
- 'ee/spec/features/registrations/saas/**/*'
RSpec/DuplicateSpecLocation:
Enabled: true
Gitlab/PolicyRuleBoolean:
@ -465,9 +486,17 @@ RSpec/FactoriesInMigrationSpecs:
RSpec/FactoryBot/AvoidCreate:
Enabled: true
Include:
- 'spec/presenters/**/*.rb'
- 'spec/serializers/**/*.rb'
- 'ee/spec/presenters/**/*.rb'
- 'ee/spec/serializers/**/*.rb'
RSpec/FactoryBot/StrategyInCallback:
Enabled: true
Include:
- 'spec/factories/**/*.rb'
- 'ee/spec/factories/**/*.rb'
Cop/IncludeSidekiqWorker:
Enabled: true
Exclude:
@ -582,6 +611,18 @@ Graphql/Descriptions:
- 'app/graphql/**/*'
- 'ee/app/graphql/**/*'
Graphql/EnumNames:
Enabled: true
Include:
- 'app/graphql/**/*'
- 'ee/app/graphql/**/*'
Graphql/EnumValues:
Enabled: true
Include:
- 'app/graphql/**/*'
- 'ee/app/graphql/**/*'
# Cops for upgrade to gitlab-styles 3.1.0
RSpec/ImplicitSubject:
Enabled: false
@ -704,12 +745,17 @@ Migration/PreventIndexCreation:
- !ruby/regexp /\Adb\/(post_)?migrate\/2020.*\.rb\z/
- !ruby/regexp /\Adb\/(post_)?migrate\/20210[1-6].*\.rb\z/
Migration/SchemaAdditionMethodsNoPost:
Enabled: true
Include:
- db/post_migrate/*.rb
EnforcedSince: 20221024034228
Gitlab/RailsLogger:
Exclude:
- 'spec/**/*.rb'
- 'ee/spec/**/*.rb'
# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606
RSpec/FactoryBot/InlineAssociation:
Include:
- 'spec/factories/**/*.rb'
@ -761,6 +807,10 @@ Style/RegexpLiteralMixedPreserve:
- mixed_preserve
EnforcedStyle: mixed_preserve
# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94317#note_1139610896
Style/Lambda:
EnforcedStyle: literal
RSpec/TopLevelDescribePath:
Exclude:
- 'spec/fixtures/**/*.rb'
@ -831,3 +881,8 @@ Cop/SidekiqApiUsage:
- 'lib/gitlab/sidekiq_queue.rb'
- 'config/initializers/sidekiq.rb'
- 'config/initializers/forbid_sidekiq_in_transactions.rb'
Rake/Require:
Include:
- '{,ee/,jh/}lib/**/*.rake'
- 'qa/tasks/**/*.rake'

5
.rubocop_todo/api/ensure_string_detail.yml Normal file
View file

@ -0,0 +1,5 @@
---
API/EnsureStringDetail:
Details: grace period
Exclude:
- 'ee/lib/api/analytics/group_activity_analytics.rb'

465
.rubocop_todo/gitlab/json.yml Normal file
View file

@ -0,0 +1,465 @@
---
# Cop supports --autocorrect.
Gitlab/Json:
Exclude:
- 'app/controllers/admin/application_settings_controller.rb'
- 'app/controllers/concerns/authenticates_with_two_factor.rb'
- 'app/controllers/projects/commit_controller.rb'
- 'app/controllers/projects/google_cloud/configuration_controller.rb'
- 'app/controllers/projects/google_cloud/databases_controller.rb'
- 'app/controllers/projects/google_cloud/deployments_controller.rb'
- 'app/controllers/projects/google_cloud/gcp_regions_controller.rb'
- 'app/controllers/projects/google_cloud/service_accounts_controller.rb'
- 'app/controllers/projects/graphs_controller.rb'
- 'app/controllers/projects/merge_requests_controller.rb'
- 'app/controllers/projects/notes_controller.rb'
- 'app/controllers/projects/settings/ci_cd_controller.rb'
- 'app/controllers/projects/templates_controller.rb'
- 'app/controllers/projects_controller.rb'
- 'app/controllers/search_controller.rb'
- 'app/helpers/access_tokens_helper.rb'
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/breadcrumbs_helper.rb'
- 'app/helpers/ci/builds_helper.rb'
- 'app/helpers/ci/pipelines_helper.rb'
- 'app/helpers/compare_helper.rb'
- 'app/helpers/emails_helper.rb'
- 'app/helpers/environment_helper.rb'
- 'app/helpers/groups_helper.rb'
- 'app/helpers/ide_helper.rb'
- 'app/helpers/integrations_helper.rb'
- 'app/helpers/invite_members_helper.rb'
- 'app/helpers/issuables_description_templates_helper.rb'
- 'app/helpers/issuables_helper.rb'
- 'app/helpers/jira_connect_helper.rb'
- 'app/helpers/learn_gitlab_helper.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/notes_helper.rb'
- 'app/helpers/operations_helper.rb'
- 'app/helpers/packages_helper.rb'
- 'app/helpers/projects/project_members_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/terms_helper.rb'
- 'app/helpers/users_helper.rb'
- 'app/mailers/emails/members.rb'
- 'app/presenters/packages/composer/packages_presenter.rb'
- 'app/presenters/projects/security/configuration_presenter.rb'
- 'app/workers/google_cloud/create_cloudsql_instance_worker.rb'
- 'config/initializers/rack_multipart_patch.rb'
- 'ee/app/controllers/admin/geo/nodes_controller.rb'
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- 'ee/app/controllers/ee/search_controller.rb'
- 'ee/app/controllers/subscriptions_controller.rb'
- 'ee/app/graphql/types/json_string_type.rb'
- 'ee/app/helpers/billing_plans_helper.rb'
- 'ee/app/helpers/ee/environments_helper.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb'
- 'ee/app/helpers/ee/invite_members_helper.rb'
- 'ee/app/helpers/ee/operations_helper.rb'
- 'ee/app/helpers/ee/projects/pipeline_helper.rb'
- 'ee/app/helpers/ee/projects_helper.rb'
- 'ee/app/helpers/ee/security_orchestration_helper.rb'
- 'ee/app/helpers/groups/ldap_sync_helper.rb'
- 'ee/app/helpers/groups/security_features_helper.rb'
- 'ee/app/helpers/incident_management/oncall_schedule_helper.rb'
- 'ee/app/helpers/projects/on_demand_scans_helper.rb'
- 'ee/app/helpers/projects/security/dast_profiles_helper.rb'
- 'ee/app/helpers/security_helper.rb'
- 'ee/app/helpers/subscriptions_helper.rb'
- 'ee/app/helpers/users/identity_verification_helper.rb'
- 'ee/app/helpers/vulnerabilities_helper.rb'
- 'ee/app/models/product_analytics/jitsu_authentication.rb'
- 'ee/app/presenters/epic_presenter.rb'
- 'ee/app/services/arkose/blocked_users_report_service.rb'
- 'ee/app/services/elastic/indexing_control_service.rb'
- 'ee/app/services/elastic/process_bookkeeping_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/status_page/publish_base_service.rb'
- 'ee/app/services/upcoming_reconciliations/update_service.rb'
- 'ee/app/services/vulnerabilities/create_service_base.rb'
- 'ee/app/workers/concerns/elastic/migration_state.rb'
- 'ee/app/workers/sync_seat_link_request_worker.rb'
- 'ee/db/fixtures/development/20_vulnerabilities.rb'
- 'ee/lib/api/analytics/product_analytics.rb'
- 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- 'ee/lib/gitlab/elastic/indexer.rb'
- 'ee/lib/gitlab/geo/signed_data.rb'
- 'ee/lib/gitlab/subscription_portal/clients/graphql.rb'
- 'ee/lib/gitlab/subscription_portal/clients/rest.rb'
- 'ee/lib/slack/api.rb'
- 'ee/lib/tasks/gitlab/elastic.rake'
- 'ee/lib/tasks/gitlab/spdx.rake'
- 'ee/spec/controllers/admin/application_settings_controller_spec.rb'
- 'ee/spec/controllers/countries_controller_spec.rb'
- 'ee/spec/controllers/country_states_controller_spec.rb'
- 'ee/spec/controllers/ee/search_controller_spec.rb'
- 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb'
- 'ee/spec/controllers/groups/security/policies_controller_spec.rb'
- 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb'
- 'ee/spec/controllers/subscriptions_controller_spec.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb'
- 'ee/spec/features/billings/billing_plans_spec.rb'
- 'ee/spec/features/billings/extend_reactivate_trial_spec.rb'
- 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb'
- 'ee/spec/features/projects/integrations/jira_issues_list_spec.rb'
- 'ee/spec/features/projects/integrations/user_activates_github_spec.rb'
- 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb'
- 'ee/spec/frontend/fixtures/dast_profiles.rb'
- 'ee/spec/frontend/fixtures/epic.rb'
- 'ee/spec/graphql/api/vulnerabilities_spec.rb'
- 'ee/spec/graphql/types/json_string_type_spec.rb'
- 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb'
- 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb'
- 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb'
- 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb'
- 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb'
- 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb'
- 'ee/spec/helpers/users/identity_verification_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/license_compliance/license_scanning_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb'
- 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb'
- 'ee/spec/lib/gitlab/elastic/indexer_spec.rb'
- 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb'
- 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb'
- 'ee/spec/lib/slack/api_spec.rb'
- 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/models/ee/integrations/jira_spec.rb'
- 'ee/spec/models/gitlab/seat_link_data_spec.rb'
- 'ee/spec/models/group_member_spec.rb'
- 'ee/spec/models/integrations/github/status_notifier_spec.rb'
- 'ee/spec/models/integrations/github_spec.rb'
- 'ee/spec/models/license_spec.rb'
- 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb'
- 'ee/spec/models/vulnerabilities/finding_spec.rb'
- 'ee/spec/presenters/audit_event_presenter_spec.rb'
- 'ee/spec/requests/api/analytics/product_analytics_spec.rb'
- 'ee/spec/requests/api/experiments_spec.rb'
- 'ee/spec/requests/api/geo_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb'
- 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb'
- 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb'
- 'ee/spec/requests/api/graphql/vulnerabilities/location_spec.rb'
- 'ee/spec/requests/api/integrations/slack/events_spec.rb'
- 'ee/spec/requests/api/releases_spec.rb'
- 'ee/spec/requests/api/settings_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb'
- 'ee/spec/requests/projects/security/policies_controller_spec.rb'
- 'ee/spec/requests/users/identity_verification_controller_spec.rb'
- 'ee/spec/serializers/clusters/environment_entity_spec.rb'
- 'ee/spec/serializers/clusters/environment_serializer_spec.rb'
- 'ee/spec/serializers/dependency_list_serializer_spec.rb'
- 'ee/spec/serializers/epics/related_epic_entity_spec.rb'
- 'ee/spec/serializers/evidences/evidence_entity_spec.rb'
- 'ee/spec/serializers/issue_serializer_spec.rb'
- 'ee/spec/serializers/licenses_list_serializer_spec.rb'
- 'ee/spec/serializers/member_entity_spec.rb'
- 'ee/spec/serializers/member_user_entity_spec.rb'
- 'ee/spec/serializers/status_page/incident_entity_spec.rb'
- 'ee/spec/serializers/status_page/incident_serializer_spec.rb'
- 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb'
- 'ee/spec/services/arkose/blocked_users_report_service_spec.rb'
- 'ee/spec/services/arkose/token_verification_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb'
- 'ee/spec/services/integrations/slack_events/app_home_opened_service_spec.rb'
- 'ee/spec/services/jira/requests/issues/list_service_spec.rb'
- 'ee/spec/services/projects/slack_application_install_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/support/helpers/subscription_portal_helpers.rb'
- 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb'
- 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb'
- 'ee/spec/support/shared_examples/status_page/publish_shared_examples.rb'
- 'ee/spec/tasks/gitlab/spdx_rake_spec.rb'
- 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb'
- 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb'
- 'ee/spec/workers/sync_seat_link_request_worker_spec.rb'
- 'ee/spec/workers/vulnerability_exports/export_worker_spec.rb'
- 'lib/api/api.rb'
- 'lib/api/feature_flags_user_lists.rb'
- 'lib/api/helpers.rb'
- 'lib/api/terraform/state.rb'
- 'lib/atlassian/jira_connect/client.rb'
- 'lib/atlassian/jira_connect/serializers/base_entity.rb'
- 'lib/backup/gitaly_backup.rb'
- 'lib/bitbucket_server/client.rb'
- 'lib/bulk_imports/clients/graphql.rb'
- 'lib/error_tracking/sentry_client.rb'
- 'lib/gitlab/alert_management/payload/prometheus.rb'
- 'lib/gitlab/analytics/cycle_analytics/request_params.rb'
- 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb'
- 'lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp.rb'
- 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb'
- 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb'
- 'lib/gitlab/bitbucket_import/importer.rb'
- 'lib/gitlab/bitbucket_server_import/importer.rb'
- 'lib/gitlab/chat/responder/mattermost.rb'
- 'lib/gitlab/chat/responder/slack.rb'
- 'lib/gitlab/chat_name_token.rb'
- 'lib/gitlab/ci/ansi2html.rb'
- 'lib/gitlab/ci/ansi2json/state.rb'
- 'lib/gitlab/ci/build/releaser.rb'
- 'lib/gitlab/ci/config/external/mapper.rb'
- 'lib/gitlab/ci/pipeline/chain/validate/external.rb'
- 'lib/gitlab/ci/reports/security/finding.rb'
- 'lib/gitlab/composer/cache.rb'
- 'lib/gitlab/database/background_migration/batched_migration.rb'
- 'lib/gitlab/database/background_migration_job.rb'
- 'lib/gitlab/database/migration_helpers.rb'
- 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb'
- 'lib/gitlab/database/migrations/instrumentation.rb'
- 'lib/gitlab/database/migrations/runner.rb'
- 'lib/gitlab/database/postgres_hll/buckets.rb'
- 'lib/gitlab/database/reindexing/grafana_notifier.rb'
- 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb'
- 'lib/gitlab/diff/highlight_cache.rb'
- 'lib/gitlab/discussions_diff/highlight_cache.rb'
- 'lib/gitlab/external_authorization/client.rb'
- 'lib/gitlab/file_hook.rb'
- 'lib/gitlab/gitaly_client/conflicts_service.rb'
- 'lib/gitlab/graphql/pagination/active_record_array_connection.rb'
- 'lib/gitlab/graphql/pagination/keyset/connection.rb'
- 'lib/gitlab/health_checks/middleware.rb'
- 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb'
- 'lib/gitlab/import_export/json/legacy_writer.rb'
- 'lib/gitlab/import_export/json/ndjson_writer.rb'
- 'lib/gitlab/import_export/lfs_saver.rb'
- 'lib/gitlab/jira/http_client.rb'
- 'lib/gitlab/json_cache.rb'
- 'lib/gitlab/legacy_github_import/importer.rb'
- 'lib/gitlab/lfs/client.rb'
- 'lib/gitlab/merge_requests/mergeability/redis_interface.rb'
- 'lib/gitlab/middleware/read_only/controller.rb'
- 'lib/gitlab/patch/hangouts_chat_http_override.rb'
- 'lib/gitlab/puma_logging/json_formatter.rb'
- 'lib/gitlab/sidekiq_config.rb'
- 'lib/gitlab/sidekiq_daemon/monitor.rb'
- 'lib/gitlab/sidekiq_logging/json_formatter.rb'
- 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb'
- 'lib/gitlab/utils/json_size_estimator.rb'
- 'lib/gitlab/version_info.rb'
- 'lib/gitlab/workhorse.rb'
- 'lib/mattermost/command.rb'
- 'lib/mattermost/team.rb'
- 'lib/microsoft_teams/notifier.rb'
- 'lib/tasks/gitlab/background_migrations.rake'
- 'lib/version_check.rb'
- 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb'
- 'spec/controllers/admin/integrations_controller_spec.rb'
- 'spec/controllers/concerns/product_analytics_tracking_spec.rb'
- 'spec/controllers/groups/settings/integrations_controller_spec.rb'
- 'spec/controllers/jira_connect/subscriptions_controller_spec.rb'
- 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb'
- 'spec/controllers/projects/alerting/notifications_controller_spec.rb'
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb'
- 'spec/factories/ci/pipeline_artifacts.rb'
- 'spec/features/dashboard/issues_spec.rb'
- 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb'
- 'spec/features/file_uploads/graphql_add_design_spec.rb'
- 'spec/features/groups/dependency_proxy_for_containers_spec.rb'
- 'spec/features/markdown/copy_as_gfm_spec.rb'
- 'spec/features/markdown/metrics_spec.rb'
- 'spec/features/projects/integrations/user_activates_jira_spec.rb'
- 'spec/features/projects/settings/monitor_settings_spec.rb'
- 'spec/frontend/fixtures/timezones.rb'
- 'spec/helpers/access_tokens_helper_spec.rb'
- 'spec/helpers/breadcrumbs_helper_spec.rb'
- 'spec/helpers/ci/builds_helper_spec.rb'
- 'spec/helpers/environment_helper_spec.rb'
- 'spec/helpers/environments_helper_spec.rb'
- 'spec/helpers/groups/group_members_helper_spec.rb'
- 'spec/helpers/groups_helper_spec.rb'
- 'spec/helpers/ide_helper_spec.rb'
- 'spec/helpers/invite_members_helper_spec.rb'
- 'spec/helpers/issuables_description_templates_helper_spec.rb'
- 'spec/helpers/listbox_helper_spec.rb'
- 'spec/helpers/namespaces_helper_spec.rb'
- 'spec/helpers/projects/project_members_helper_spec.rb'
- 'spec/helpers/projects_helper_spec.rb'
- 'spec/initializers/hangouts_chat_http_override_spec.rb'
- 'spec/lib/api/entities/merge_request_basic_spec.rb'
- 'spec/lib/api/helpers/caching_spec.rb'
- 'spec/lib/api/helpers/common_helpers_spec.rb'
- 'spec/lib/atlassian/jira_connect/client_spec.rb'
- 'spec/lib/atlassian/jira_connect/serializers/build_entity_spec.rb'
- 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb'
- 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb'
- 'spec/lib/atlassian/jira_connect/serializers/repository_entity_spec.rb'
- 'spec/lib/bitbucket_server/connection_spec.rb'
- 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb'
- 'spec/lib/container_registry/client_spec.rb'
- 'spec/lib/container_registry/gitlab_api_client_spec.rb'
- 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/chat/responder/mattermost_spec.rb'
- 'spec/lib/gitlab/chat/responder/slack_spec.rb'
- 'spec/lib/gitlab/ci/build/releaser_spec.rb'
- 'spec/lib/gitlab/ci/parsers/accessibility/pa11y_spec.rb'
- 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb'
- 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb'
- 'spec/lib/gitlab/ci/parsers/sbom/cyclonedx_spec.rb'
- 'spec/lib/gitlab/ci/parsers/security/common_spec.rb'
- 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
- 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb'
- 'spec/lib/gitlab/composer/cache_spec.rb'
- 'spec/lib/gitlab/composer/version_index_spec.rb'
- 'spec/lib/gitlab/data_builder/pipeline_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb'
- 'spec/lib/gitlab/database/postgres_hll/buckets_spec.rb'
- 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb'
- 'spec/lib/gitlab/diff/position_spec.rb'
- 'spec/lib/gitlab/diff/stats_cache_spec.rb'
- 'spec/lib/gitlab/discussions_diff/highlight_cache_spec.rb'
- 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb'
- 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb'
- 'spec/lib/gitlab/external_authorization/client_spec.rb'
- 'spec/lib/gitlab/external_authorization/response_spec.rb'
- 'spec/lib/gitlab/file_hook_spec.rb'
- 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb'
- 'spec/lib/gitlab/github_import/client_spec.rb'
- 'spec/lib/gitlab/gitlab_import/importer_spec.rb'
- 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb'
- 'spec/lib/gitlab/harbor/client_spec.rb'
- 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb'
- 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb'
- 'spec/lib/gitlab/json_cache_spec.rb'
- 'spec/lib/gitlab/legacy_github_import/client_spec.rb'
- 'spec/lib/gitlab/legacy_github_import/importer_spec.rb'
- 'spec/lib/gitlab/lfs/client_spec.rb'
- 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb'
- 'spec/lib/gitlab/middleware/multipart_spec.rb'
- 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb'
- 'spec/lib/gitlab/tracking/service_ping_context_spec.rb'
- 'spec/lib/gitlab/tracking/standard_context_spec.rb'
- 'spec/lib/gitlab/tracking_spec.rb'
- 'spec/lib/gitlab/usage/service_ping/legacy_metric_timing_decorator_spec.rb'
- 'spec/lib/gitlab/utils/json_size_estimator_spec.rb'
- 'spec/lib/gitlab/version_info_spec.rb'
- 'spec/lib/gitlab/webpack/manifest_spec.rb'
- 'spec/lib/gitlab/workhorse_spec.rb'
- 'spec/lib/gitlab/zentao/client_spec.rb'
- 'spec/lib/grafana/client_spec.rb'
- 'spec/lib/json_web_token/hmac_token_spec.rb'
- 'spec/lib/mattermost/command_spec.rb'
- 'spec/lib/mattermost/team_spec.rb'
- 'spec/lib/microsoft_teams/notifier_spec.rb'
- 'spec/lib/object_storage/direct_upload_spec.rb'
- 'spec/lib/service_ping/devops_report_spec.rb'
- 'spec/lib/version_check_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20220204194347_encrypt_integration_properties_spec.rb'
- 'spec/migrations/20220412143552_consume_remaining_encrypt_integration_property_jobs_spec.rb'
- 'spec/models/blob_viewer/package_json_spec.rb'
- 'spec/models/ci/runner_spec.rb'
- 'spec/models/concerns/prometheus_adapter_spec.rb'
- 'spec/models/concerns/redis_cacheable_spec.rb'
- 'spec/models/concerns/sensitive_serializable_hash_spec.rb'
- 'spec/models/diff_discussion_spec.rb'
- 'spec/models/diff_note_spec.rb'
- 'spec/models/hooks/web_hook_spec.rb'
- 'spec/models/integrations/datadog_spec.rb'
- 'spec/models/integrations/jira_spec.rb'
- 'spec/models/integrations/mattermost_slash_commands_spec.rb'
- 'spec/models/integrations/mock_ci_spec.rb'
- 'spec/models/merge_request_diff_commit_spec.rb'
- 'spec/models/packages/composer/metadatum_spec.rb'
- 'spec/models/terraform/state_spec.rb'
- 'spec/presenters/packages/composer/packages_presenter_spec.rb'
- 'spec/requests/api/ci/runner/jobs_request_post_spec.rb'
- 'spec/requests/api/composer_packages_spec.rb'
- 'spec/requests/api/conan_instance_packages_spec.rb'
- 'spec/requests/api/conan_project_packages_spec.rb'
- 'spec/requests/api/container_registry_event_spec.rb'
- 'spec/requests/api/graphql/mutations/design_management/upload_spec.rb'
- 'spec/requests/api/integrations/jira_connect/subscriptions_spec.rb'
- 'spec/requests/api/internal/base_spec.rb'
- 'spec/requests/api/merge_requests_spec.rb'
- 'spec/requests/api/namespaces_spec.rb'
- 'spec/requests/api/project_snapshots_spec.rb'
- 'spec/requests/groups/settings/access_tokens_controller_spec.rb'
- 'spec/requests/projects/incident_management/pagerduty_incidents_spec.rb'
- 'spec/requests/projects/settings/access_tokens_controller_spec.rb'
- 'spec/requests/users_controller_spec.rb'
- 'spec/requests/whats_new_controller_spec.rb'
- 'spec/scripts/pipeline_test_report_builder_spec.rb'
- 'spec/serializers/ci/dag_job_entity_spec.rb'
- 'spec/serializers/ci/dag_job_group_entity_spec.rb'
- 'spec/serializers/ci/dag_pipeline_entity_spec.rb'
- 'spec/serializers/ci/dag_pipeline_serializer_spec.rb'
- 'spec/serializers/ci/dag_stage_entity_spec.rb'
- 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb'
- 'spec/serializers/ci/lint/result_serializer_spec.rb'
- 'spec/serializers/ci/trigger_entity_spec.rb'
- 'spec/serializers/ci/trigger_serializer_spec.rb'
- 'spec/serializers/diff_line_serializer_spec.rb'
- 'spec/serializers/evidences/evidence_entity_spec.rb'
- 'spec/serializers/feature_flags_client_serializer_spec.rb'
- 'spec/serializers/group_link/group_group_link_entity_spec.rb'
- 'spec/serializers/group_link/group_group_link_serializer_spec.rb'
- 'spec/serializers/group_link/group_link_entity_spec.rb'
- 'spec/serializers/group_link/project_group_link_entity_spec.rb'
- 'spec/serializers/group_link/project_group_link_serializer_spec.rb'
- 'spec/serializers/member_entity_spec.rb'
- 'spec/serializers/member_serializer_spec.rb'
- 'spec/serializers/member_user_entity_spec.rb'
- 'spec/serializers/test_reports_comparer_serializer_spec.rb'
- 'spec/services/ci/runners/process_runner_version_update_service_spec.rb'
- 'spec/services/draft_notes/create_service_spec.rb'
- 'spec/services/error_tracking/issue_details_service_spec.rb'
- 'spec/services/error_tracking/issue_latest_event_service_spec.rb'
- 'spec/services/error_tracking/list_issues_service_spec.rb'
- 'spec/services/git/branch_push_service_spec.rb'
- 'spec/services/jira/requests/projects/list_service_spec.rb'
- 'spec/services/metrics/dashboard/transient_embed_service_spec.rb'
- 'spec/services/packages/composer/create_package_service_spec.rb'
- 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb'
- 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb'
- 'spec/services/service_ping/submit_service_ping_service_spec.rb'
- 'spec/services/webauthn/authenticate_service_spec.rb'
- 'spec/services/webauthn/register_service_spec.rb'
- 'spec/support/frontend_fixtures.rb'
- 'spec/support/google_api/cloud_platform_helpers.rb'
- 'spec/support/helpers/ci_artifact_metadata_generator.rb'
- 'spec/support/helpers/dependency_proxy_helpers.rb'
- 'spec/support/helpers/fake_webauthn_device.rb'
- 'spec/support/helpers/features/two_factor_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/input_helper.rb'
- 'spec/support/helpers/jira_integration_helpers.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- 'spec/support/helpers/prometheus_helpers.rb'
- 'spec/support/helpers/sentry_client_helpers.rb'
- 'spec/support/helpers/usage_data_helpers.rb'
- 'spec/support/import_export/configuration_helper.rb'
- 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb'
- 'spec/support/shared_contexts/features/error_tracking_shared_context.rb'
- 'spec/support/shared_contexts/prometheus/alert_shared_context.rb'
- 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb'
- 'spec/support/shared_examples/blocks_unsafe_serialization_shared_examples.rb'
- 'spec/support/shared_examples/controllers/rate_limited_endpoint_shared_examples.rb'
- 'spec/support/shared_examples/controllers/snowplow_event_tracking_examples.rb'
- 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb'
- 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb'
- 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb'
- 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb'
- 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb'
- 'spec/support_specs/helpers/graphql_helpers_spec.rb'
- 'spec/tasks/gitlab/update_templates_rake_spec.rb'
- 'spec/tasks/gitlab/usage_data_rake_spec.rb'
- 'spec/tooling/lib/tooling/kubernetes_client_spec.rb'
- 'spec/tooling/rspec_flaky/listener_spec.rb'
- 'spec/workers/ci/runners/process_runner_version_update_worker_spec.rb'
- 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb'
- 'spec/workers/packages/composer/cache_update_worker_spec.rb'

1
.rubocop_todo/gitlab/namespaced_class.yml
View file

@ -1283,7 +1283,6 @@ Gitlab/NamespacedClass:
- 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
- 'spec/models/concerns/bulk_insertable_associations_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/support/helpers/bare_repo_operations.rb'
- 'spec/support/helpers/ci_artifact_metadata_generator.rb'
- 'spec/support/helpers/fake_migration_classes.rb'
- 'spec/support/helpers/fake_u2f_device.rb'

1
.rubocop_todo/gitlab/no_code_coverage_comment.yml
View file

@ -1,6 +1,5 @@
---
Gitlab/NoCodeCoverageComment:
Details: grace period
Exclude:
- 'app/models/integration.rb'
- 'app/services/ci/job_artifacts/destroy_batch_service.rb'

1
.rubocop_todo/gitlab/service_response.yml
View file

@ -1,6 +1,5 @@
---
Gitlab/ServiceResponse:
Details: grace period
Exclude:
- 'app/services/alert_management/metric_images/upload_service.rb'
- 'app/services/analytics/cycle_analytics/stages/base_service.rb'

37
.rubocop_todo/graphql/enum_names.yml Normal file
View file

@ -0,0 +1,37 @@
---
Graphql/EnumNames:
Details: grace period
Exclude:
- 'app/graphql/types/access_level_enum.rb'
- 'app/graphql/types/availability_enum.rb'
- 'app/graphql/types/ci/pipeline_config_source_enum.rb'
- 'app/graphql/types/ci/pipeline_scope_enum.rb'
- 'app/graphql/types/ci/pipeline_status_enum.rb'
- 'app/graphql/types/container_expiration_policy_cadence_enum.rb'
- 'app/graphql/types/container_expiration_policy_keep_enum.rb'
- 'app/graphql/types/container_expiration_policy_older_than_enum.rb'
- 'app/graphql/types/data_visualization_palette/color_enum.rb'
- 'app/graphql/types/data_visualization_palette/weight_enum.rb'
- 'app/graphql/types/merge_strategy_enum.rb'
- 'app/graphql/types/milestone_state_enum.rb'
- 'app/graphql/types/packages/cleanup/keep_duplicated_package_files_enum.rb'
- 'app/graphql/types/packages/conan/metadatum_file_type_enum.rb'
- 'app/graphql/types/packages/package_type_enum.rb'
- 'app/graphql/types/security/report_type_enum.rb'
- 'app/graphql/types/snippets/blob_action_enum.rb'
- 'app/graphql/types/snippets/type_enum.rb'
- 'app/graphql/types/snippets/visibility_scopes_enum.rb'
- 'app/graphql/types/sort_direction_enum.rb'
- 'app/graphql/types/todo_action_enum.rb'
- 'app/graphql/types/todo_state_enum.rb'
- 'app/graphql/types/todo_target_enum.rb'
- 'app/graphql/types/user_callout_feature_name_enum.rb'
- 'app/graphql/types/visibility_levels_enum.rb'
- 'ee/app/graphql/types/dast_scan_type_enum.rb'
- 'ee/app/graphql/types/dast_site_profile_validation_status_enum.rb'
- 'ee/app/graphql/types/dast_site_validation_status_enum.rb'
- 'ee/app/graphql/types/dast_site_validation_strategy_enum.rb'
- 'ee/app/graphql/types/dast_target_type_enum.rb'
- 'ee/app/graphql/types/geo/replication_state_enum.rb'
- 'ee/app/graphql/types/geo/verification_state_enum.rb'
- 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb'

37
.rubocop_todo/graphql/enum_values.yml Normal file
View file

@ -0,0 +1,37 @@
---
Graphql/EnumValues:
Details: grace period
Exclude:
- 'app/graphql/types/alert_management/domain_filter_enum.rb'
- 'app/graphql/types/blob_viewers/type_enum.rb'
- 'app/graphql/types/ci/config/include_type_enum.rb'
- 'app/graphql/types/ci/test_case_status_enum.rb'
- 'app/graphql/types/container_expiration_policy_cadence_enum.rb'
- 'app/graphql/types/container_expiration_policy_keep_enum.rb'
- 'app/graphql/types/container_expiration_policy_older_than_enum.rb'
- 'app/graphql/types/customer_relations/contact_state_enum.rb'
- 'app/graphql/types/customer_relations/organization_state_enum.rb'
- 'app/graphql/types/design_management/design_version_event_enum.rb'
- 'app/graphql/types/issuable_state_enum.rb'
- 'app/graphql/types/merge_request_state_enum.rb'
- 'app/graphql/types/milestone_state_enum.rb'
- 'app/graphql/types/notes/position_type_enum.rb'
- 'app/graphql/types/packages/cleanup/keep_duplicated_package_files_enum.rb'
- 'app/graphql/types/snippets/blob_action_enum.rb'
- 'app/graphql/types/snippets/type_enum.rb'
- 'app/graphql/types/snippets/visibility_scopes_enum.rb'
- 'app/graphql/types/todo_action_enum.rb'
- 'app/graphql/types/todo_state_enum.rb'
- 'app/graphql/types/tree/type_enum.rb'
- 'app/graphql/types/user_state_enum.rb'
- 'app/graphql/types/visibility_levels_enum.rb'
- 'ee/app/graphql/ee/types/list_limit_metric_enum.rb'
- 'ee/app/graphql/types/epic_state_enum.rb'
- 'ee/app/graphql/types/health_status_enum.rb'
- 'ee/app/graphql/types/incident_management/issuable_resource_link_type_enum.rb'
- 'ee/app/graphql/types/iteration_state_enum.rb'
- 'ee/app/graphql/types/move_type_enum.rb'
- 'ee/app/graphql/types/network_policy_kind_enum.rb'
- 'ee/app/graphql/types/security_scanner_type_enum.rb'
- 'ee/app/graphql/types/vulnerability_report_type_enum.rb'
- 'ee/app/graphql/types/vulnerability_sort_enum.rb'

1
.rubocop_todo/layout/argument_alignment.yml
View file

@ -655,7 +655,6 @@ Layout/ArgumentAlignment:
- 'spec/features/merge_request/user_sees_versions_spec.rb'
- 'spec/features/merge_requests/user_lists_merge_requests_spec.rb'
- 'spec/features/merge_requests/user_views_open_merge_requests_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/commit/mini_pipeline_graph_spec.rb'
- 'spec/features/projects/environments/environment_spec.rb'
- 'spec/features/projects/environments/environments_spec.rb'

1
.rubocop_todo/layout/first_array_element_indentation.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Layout/FirstArrayElementIndentation:
Details: grace period
Exclude:
- 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb'
- 'spec/lib/gitlab/search/found_blob_spec.rb'

18
.rubocop_todo/layout/line_length.yml
View file

@ -371,7 +371,6 @@ Layout/LineLength:
- 'app/models/diff_note.rb'
- 'app/models/environment.rb'
- 'app/models/error_tracking/project_error_tracking_setting.rb'
- 'app/models/event_collection.rb'
- 'app/models/exported_protected_branch.rb'
- 'app/models/group.rb'
- 'app/models/incident_management/project_incident_management_setting.rb'
@ -597,7 +596,6 @@ Layout/LineLength:
- 'app/services/loose_foreign_keys/cleaner_service.rb'
- 'app/services/members/destroy_service.rb'
- 'app/services/members/invitation_reminder_email_service.rb'
- 'app/services/members/update_service.rb'
- 'app/services/merge_requests/add_context_service.rb'
- 'app/services/merge_requests/assign_issues_service.rb'
- 'app/services/merge_requests/base_service.rb'
@ -1817,7 +1815,6 @@ Layout/LineLength:
- 'ee/spec/features/groups/scim_token_spec.rb'
- 'ee/spec/features/groups/security/compliance_dashboards_spec.rb'
- 'ee/spec/features/groups/sso_spec.rb'
- 'ee/spec/features/groups/usage_quotas_spec.rb'
- 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb'
- 'ee/spec/features/invites_spec.rb'
- 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb'
@ -1915,7 +1912,7 @@ Layout/LineLength:
- 'ee/spec/frontend/fixtures/projects.rb'
- 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb'
- 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb'
- 'ee/spec/graphql/ee/resolvers/issues_resolver_spec.rb'
- 'ee/spec/graphql/ee/resolvers/project_issues_resolver_spec.rb'
- 'ee/spec/graphql/ee/types/board_type_spec.rb'
- 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb'
- 'ee/spec/graphql/ee/types/merge_request_type_spec.rb'
@ -2855,7 +2852,6 @@ Layout/LineLength:
- 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb'
- 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb'
- 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb'
- 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb'
- 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb'
- 'ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb'
- 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb'
@ -2910,7 +2906,6 @@ Layout/LineLength:
- 'ee/spec/workers/update_all_mirrors_worker_spec.rb'
- 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb'
- 'lib/api/admin/instance_clusters.rb'
- 'lib/api/admin/plan_limits.rb'
- 'lib/api/api.rb'
- 'lib/api/appearance.rb'
- 'lib/api/award_emoji.rb'
@ -2946,19 +2941,15 @@ Layout/LineLength:
- 'lib/api/entities/issue_basic.rb'
- 'lib/api/entities/merge_request.rb'
- 'lib/api/entities/namespace.rb'
- 'lib/api/entities/package.rb'
- 'lib/api/entities/project.rb'
- 'lib/api/entities/user.rb'
- 'lib/api/environments.rb'
- 'lib/api/error_tracking/project_settings.rb'
- 'lib/api/feature_flags.rb'
- 'lib/api/files.rb'
- 'lib/api/generic_packages.rb'
- 'lib/api/go_proxy.rb'
- 'lib/api/group_clusters.rb'
- 'lib/api/group_import.rb'
- 'lib/api/group_labels.rb'
- 'lib/api/group_packages.rb'
- 'lib/api/group_variables.rb'
- 'lib/api/groups.rb'
- 'lib/api/helm_packages.rb'
@ -2992,7 +2983,6 @@ Layout/LineLength:
- 'lib/api/members.rb'
- 'lib/api/merge_request_diffs.rb'
- 'lib/api/merge_requests.rb'
- 'lib/api/metrics/dashboard/annotations.rb'
- 'lib/api/metrics/user_starred_dashboards.rb'
- 'lib/api/milestone_responses.rb'
- 'lib/api/namespaces.rb'
@ -3921,7 +3911,6 @@ Layout/LineLength:
- 'spec/features/groups/settings/repository_spec.rb'
- 'spec/features/groups_spec.rb'
- 'spec/features/ide/static_object_external_storage_csp_spec.rb'
- 'spec/features/incidents/user_views_incident_spec.rb'
- 'spec/features/invites_spec.rb'
- 'spec/features/issuables/issuable_list_spec.rb'
- 'spec/features/issuables/markdown_references/internal_references_spec.rb'
@ -4012,7 +4001,6 @@ Layout/LineLength:
- 'spec/features/projects/blobs/shortcuts_blob_spec.rb'
- 'spec/features/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb'
- 'spec/features/projects/blobs/user_views_pipeline_editor_button_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/ci/editor_spec.rb'
- 'spec/features/projects/commit/cherry_pick_spec.rb'
- 'spec/features/projects/commit/user_reverts_commit_spec.rb'
@ -4185,11 +4173,11 @@ Layout/LineLength:
- 'spec/graphql/resolvers/group_issues_resolver_spec.rb'
- 'spec/graphql/resolvers/group_labels_resolver_spec.rb'
- 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb'
- 'spec/graphql/resolvers/issues_resolver_spec.rb'
- 'spec/graphql/resolvers/merge_requests_resolver_spec.rb'
- 'spec/graphql/resolvers/metrics/dashboard_resolver_spec.rb'
- 'spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb'
- 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb'
- 'spec/graphql/resolvers/project_issues_resolver_spec.rb'
- 'spec/graphql/resolvers/project_jobs_resolver_spec.rb'
- 'spec/graphql/resolvers/project_resolver_spec.rb'
- 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb'
@ -5543,7 +5531,6 @@ Layout/LineLength:
- 'spec/services/members/destroy_service_spec.rb'
- 'spec/services/members/invitation_reminder_email_service_spec.rb'
- 'spec/services/members/unassign_issuables_service_spec.rb'
- 'spec/services/members/update_service_spec.rb'
- 'spec/services/merge_requests/add_context_service_spec.rb'
- 'spec/services/merge_requests/after_create_service_spec.rb'
- 'spec/services/merge_requests/assign_issues_service_spec.rb'
@ -5968,7 +5955,6 @@ Layout/LineLength:
- 'spec/views/projects/tags/index.html.haml_spec.rb'
- 'spec/views/projects/tree/show.html.haml_spec.rb'
- 'spec/views/search/_results.html.haml_spec.rb'
- 'spec/views/shared/access_tokens/_table.html.haml_spec.rb'
- 'spec/views/shared/milestones/_issuable.html.haml_spec.rb'
- 'spec/views/shared/projects/_project.html.haml_spec.rb'
- 'spec/views/shared/snippets/_snippet.html.haml_spec.rb'

1
.rubocop_todo/layout/space_in_lambda_literal.yml
View file

@ -69,7 +69,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/models/diff_note.rb'
- 'app/models/environment.rb'
- 'app/models/error_tracking/error.rb'
- 'app/models/event_collection.rb'
- 'app/models/external_pull_request.rb'
- 'app/models/group.rb'
- 'app/models/integration.rb'

212
.rubocop_todo/layout/space_inside_parens.yml
View file

@ -1,103 +1,20 @@
---
# Cop supports --auto-correct.
# Cop supports --autocorrect.
Layout/SpaceInsideParens:
# Offense count: 701
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/controllers/projects/environments_controller.rb'
- 'app/controllers/projects/pipeline_schedules_controller.rb'
- 'app/graphql/mutations/ci/job/base.rb'
- 'app/helpers/icons_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/reminder_emails_helper.rb'
- 'app/models/alert_management/alert.rb'
- 'app/models/ci/build_metadata.rb'
- 'app/models/concerns/milestoneable.rb'
- 'app/models/concerns/mirror_authentication.rb'
- 'app/models/concerns/protected_ref_access.rb'
- 'app/models/cycle_analytics/project_level_stage_adapter.rb'
- 'app/models/merge_request.rb'
- 'app/models/pages_domain.rb'
- 'app/models/project.rb'
- 'app/services/ci/archive_trace_service.rb'
- 'app/services/jira_import/start_import_service.rb'
- 'app/services/labels/transfer_service.rb'
- 'app/services/packages/debian/create_distribution_service.rb'
- 'app/services/packages/debian/update_distribution_service.rb'
- 'app/services/packages/npm/create_package_service.rb'
- 'app/services/personal_access_tokens/revoke_service.rb'
- 'app/services/snippets/create_service.rb'
- 'app/services/spam/spam_verdict_service.rb'
- 'config/initializers/wikicloth_redos_patch.rb'
- 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb'
- 'ee/app/graphql/resolvers/external_issue_resolver.rb'
- 'ee/app/helpers/billing_plans_helper.rb'
- 'ee/app/helpers/ee/boards_helper.rb'
- 'ee/app/models/ee/lfs_object.rb'
- 'ee/app/models/ee/merge_request_diff.rb'
- 'ee/app/models/ee/pages_deployment.rb'
- 'ee/app/models/ee/upload.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/models/resource_iteration_event.rb'
- 'ee/app/services/compliance_management/frameworks/create_service.rb'
- 'ee/app/services/compliance_management/frameworks/destroy_service.rb'
- 'ee/app/services/compliance_management/frameworks/update_service.rb'
- 'ee/app/services/elastic/cluster_reindexing_service.rb'
- 'ee/app/services/sitemap/create_service.rb'
- 'ee/lib/ee/gitlab/auth/ldap/access.rb'
- 'ee/lib/gitlab/auth/smartcard/session.rb'
- 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'ee/spec/controllers/ee/groups_controller_spec.rb'
- 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb'
- 'ee/spec/controllers/projects/issues_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
- 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb'
- 'ee/spec/controllers/projects/settings/operations_controller_spec.rb'
- 'ee/spec/features/account_recovery_regular_check_spec.rb'
- 'ee/spec/features/billings/billing_plans_spec.rb'
- 'ee/spec/features/boards/board_filters_spec.rb'
- 'ee/spec/features/boards/group_boards/board_deletion_spec.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb'
- 'ee/spec/features/groups/issues_spec.rb'
- 'ee/spec/features/groups/iteration_spec.rb'
- 'ee/spec/features/groups/iterations/user_creates_iteration_in_cadence_spec.rb'
- 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb'
- 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb'
- 'ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb'
- 'ee/spec/features/merge_requests/user_resets_approvers_spec.rb'
- 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb'
- 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb'
- 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb'
- 'ee/spec/finders/epics_finder_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb'
- 'ee/spec/frontend/fixtures/epic.rb'
- 'ee/spec/frontend/fixtures/projects.rb'
- 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb'
- 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb'
- 'ee/spec/graphql/mutations/dast/profiles/create_spec.rb'
- 'ee/spec/graphql/resolvers/epics_resolver_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
- 'ee/spec/lib/gitlab/auth/group_saml/auth_hash_spec.rb'
- 'ee/spec/lib/gitlab/auth/group_saml/dynamic_settings_spec.rb'
- 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb'
- 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb'
- 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/dast_runner_validation_gitlab_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/ci/templates/secure_binaries_ci_yaml_spec.rb'
- 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb'
- 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb'
- 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb'
- 'ee/spec/migrations/drop_invalid_remediations_spec.rb'
@ -171,70 +88,11 @@ Layout/SpaceInsideParens:
- 'qa/qa/tools/delete_subgroups.rb'
- 'qa/spec/runtime/feature_spec.rb'
- 'qa/spec/scenario/template_spec.rb'
- 'spec/controllers/boards/issues_controller_spec.rb'
- 'spec/controllers/groups/children_controller_spec.rb'
- 'spec/controllers/groups/registry/repositories_controller_spec.rb'
- 'spec/controllers/groups/releases_controller_spec.rb'
- 'spec/controllers/groups/runners_controller_spec.rb'
- 'spec/controllers/groups_controller_spec.rb'
- 'spec/controllers/omniauth_callbacks_controller_spec.rb'
- 'spec/controllers/projects/environments_controller_spec.rb'
- 'spec/controllers/projects/issues_controller_spec.rb'
- 'spec/controllers/projects/registry/repositories_controller_spec.rb'
- 'spec/controllers/projects/runners_controller_spec.rb'
- 'spec/dependencies/omniauth_saml_spec.rb'
- 'spec/factories/usage_data.rb'
- 'spec/features/boards/board_filters_spec.rb'
- 'spec/features/boards/user_visits_board_spec.rb'
- 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
- 'spec/features/graphql_known_operations_spec.rb'
- 'spec/features/groups/activity_spec.rb'
- 'spec/features/groups/board_sidebar_spec.rb'
- 'spec/features/groups/empty_states_spec.rb'
- 'spec/features/groups/issues_spec.rb'
- 'spec/features/groups/milestone_spec.rb'
- 'spec/features/groups/milestones_sorting_spec.rb'
- 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb'
- 'spec/features/merge_request/user_edits_assignees_sidebar_spec.rb'
- 'spec/features/profiles/two_factor_auths_spec.rb'
- 'spec/features/projects/branches/user_views_branches_spec.rb'
- 'spec/features/projects/fork_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- 'spec/features/projects/pipeline_schedules_spec.rb'
- 'spec/features/projects/releases/user_views_edit_release_spec.rb'
- 'spec/features/projects/releases/user_views_releases_spec.rb'
- 'spec/finders/alert_management/http_integrations_finder_spec.rb'
- 'spec/finders/events_finder_spec.rb'
- 'spec/finders/labels_finder_spec.rb'
- 'spec/frontend/fixtures/api_merge_requests.rb'
- 'spec/frontend/fixtures/api_projects.rb'
- 'spec/frontend/fixtures/application_settings.rb'
- 'spec/frontend/fixtures/blob.rb'
- 'spec/frontend/fixtures/branches.rb'
- 'spec/frontend/fixtures/clusters.rb'
- 'spec/frontend/fixtures/deploy_keys.rb'
- 'spec/frontend/fixtures/issues.rb'
- 'spec/frontend/fixtures/jobs.rb'
- 'spec/frontend/fixtures/labels.rb'
- 'spec/frontend/fixtures/merge_requests.rb'
- 'spec/frontend/fixtures/merge_requests_diffs.rb'
- 'spec/frontend/fixtures/metrics_dashboard.rb'
- 'spec/frontend/fixtures/pipeline_schedules.rb'
- 'spec/frontend/fixtures/pipelines.rb'
- 'spec/frontend/fixtures/projects.rb'
- 'spec/frontend/fixtures/raw.rb'
- 'spec/frontend/fixtures/snippet.rb'
- 'spec/frontend/fixtures/todos.rb'
- 'spec/graphql/mutations/todos/restore_many_spec.rb'
- 'spec/graphql/resolvers/board_list_issues_resolver_spec.rb'
- 'spec/graphql/resolvers/board_lists_resolver_spec.rb'
- 'spec/graphql/resolvers/board_resolver_spec.rb'
- 'spec/graphql/resolvers/boards_resolver_spec.rb'
- 'spec/graphql/resolvers/group_packages_resolver_spec.rb'
- 'spec/graphql/resolvers/projects_resolver_spec.rb'
- 'spec/graphql/resolvers/recent_boards_resolver_spec.rb'
- 'spec/graphql/resolvers/users_resolver_spec.rb'
- 'spec/helpers/badges_helper_spec.rb'
- 'spec/helpers/ci/builds_helper_spec.rb'
- 'spec/helpers/ci/runners_helper_spec.rb'
@ -323,55 +181,9 @@ Layout/SpaceInsideParens:
- 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb'
- 'spec/migrations/backfill_issues_upvotes_count_spec.rb'
- 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/build_trace_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/ci/trigger_request_spec.rb'
- 'spec/models/clusters/applications/prometheus_spec.rb'
- 'spec/models/deploy_token_spec.rb'
- 'spec/models/environment_spec.rb'
- 'spec/models/environment_status_spec.rb'
- 'spec/models/experiment_spec.rb'
- 'spec/models/exported_protected_branch_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/integrations/jira_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/metrics/dashboard/annotation_spec.rb'
- 'spec/models/namespace_setting_spec.rb'
- 'spec/models/namespace_spec.rb'
- 'spec/models/network/graph_spec.rb'
- 'spec/models/packages/package_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/users/calloutable_spec.rb'
- 'spec/policies/clusters/agent_policy_spec.rb'
- 'spec/presenters/ci/build_presenter_spec.rb'
- 'spec/presenters/packages/conan/package_presenter_spec.rb'
- 'spec/requests/api/boards_spec.rb'
- 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb'
- 'spec/requests/api/ci/runner/jobs_request_post_spec.rb'
- 'spec/requests/api/ci/runners_reset_registration_token_spec.rb'
- 'spec/requests/api/ci/runners_spec.rb'
- 'spec/requests/api/dependency_proxy_spec.rb'
- 'spec/requests/api/deployments_spec.rb'
- 'spec/requests/api/files_spec.rb'
- 'spec/requests/api/go_proxy_spec.rb'
- 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb'
- 'spec/requests/api/graphql/ci/jobs_spec.rb'
- 'spec/requests/api/graphql/ci/pipelines_spec.rb'
- 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb'
- 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb'
- 'spec/requests/api/group_boards_spec.rb'
- 'spec/requests/api/issues/issues_spec.rb'
- 'spec/requests/api/issues/post_projects_issues_spec.rb'
- 'spec/requests/api/labels_spec.rb'
- 'spec/requests/api/merge_requests_spec.rb'
- 'spec/requests/api/pages/pages_spec.rb'
- 'spec/requests/api/project_milestones_spec.rb'
- 'spec/requests/api/project_snippets_spec.rb'
- 'spec/requests/api/snippets_spec.rb'
- 'spec/requests/api/submodules_spec.rb'
- 'spec/requests/jwt_controller_spec.rb'
- 'spec/requests/projects/merge_requests/diffs_spec.rb'
- 'spec/requests/projects/merge_requests_spec.rb'
@ -379,28 +191,6 @@ Layout/SpaceInsideParens:
- 'spec/requests/search_controller_spec.rb'
- 'spec/serializers/analytics_build_entity_spec.rb'
- 'spec/serializers/merge_request_user_entity_spec.rb'
- 'spec/services/boards/issues/list_service_spec.rb'
- 'spec/services/ci/compare_test_reports_service_spec.rb'
- 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb'
- 'spec/services/ci/retry_job_service_spec.rb'
- 'spec/services/clusters/gcp/provision_service_spec.rb'
- 'spec/services/clusters/gcp/verify_provision_status_service_spec.rb'
- 'spec/services/groups/destroy_service_spec.rb'
- 'spec/services/groups/update_shared_runners_service_spec.rb'
- 'spec/services/import/gitlab_projects/file_acquisition_strategies/file_upload_spec.rb'
- 'spec/services/issues/export_csv_service_spec.rb'
- 'spec/services/labels/promote_service_spec.rb'
- 'spec/services/members/invite_service_spec.rb'
- 'spec/services/notes/update_service_spec.rb'
- 'spec/services/packages/composer/composer_json_service_spec.rb'
- 'spec/services/packages/npm/create_package_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb'
- 'spec/services/search/group_service_spec.rb'
- 'spec/services/security/merge_reports_service_spec.rb'
- 'spec/services/suggestions/apply_service_spec.rb'
- 'spec/services/system_notes/issuables_service_spec.rb'
- 'spec/services/users/destroy_service_spec.rb'
- 'spec/services/x509_certificate_revoke_service_spec.rb'
- 'spec/support/helpers/database/partitioning_helpers.rb'
- 'spec/support/helpers/dependency_proxy_helpers.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'

1
.rubocop_todo/layout/trailing_whitespace.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Layout/TrailingWhitespace:
Details: grace period
Exclude:
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb'

2
.rubocop_todo/lint/missing_cop_enable_directive.yml
View file

@ -3,8 +3,6 @@ Lint/MissingCopEnableDirective:
Exclude:
- 'app/controllers/admin/users_controller.rb'
- 'app/controllers/projects/forks_controller.rb'
- 'app/graphql/resolvers/group_issues_resolver.rb'
- 'app/graphql/resolvers/issues_resolver.rb'
- 'app/graphql/resolvers/project_members_resolver.rb'
- 'app/graphql/resolvers/project_milestones_resolver.rb'
- 'app/graphql/resolvers/projects/snippets_resolver.rb'

1
.rubocop_todo/performance/method_object_as_block.yml
View file

@ -29,7 +29,6 @@ Performance/MethodObjectAsBlock:
- 'ee/app/services/security/findings/cleanup_service.rb'
- 'ee/app/services/security/ingestion/ingest_reports_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb'
- 'ee/app/services/security/store_findings_metadata_service.rb'
- 'ee/app/services/security/store_grouped_scans_service.rb'
- 'ee/lib/ee/container_registry/client.rb'
- 'ee/lib/ee/gitlab/ci/config_ee.rb'

1
.rubocop_todo/rails/active_record_callbacks_order.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Rails/ActiveRecordCallbacksOrder:
Details: grace period
Exclude:
- 'app/models/award_emoji.rb'
- 'app/models/gpg_key.rb'

62
.rubocop_todo/rails/content_tag.yml
View file

@ -1,63 +1,9 @@
---
# Cop supports --auto-correct.
# Cop supports --autocorrect.
Rails/ContentTag:
# Offense count: 163
# Temporarily disabled due to too many offenses
Enabled: false
Details: grace period
Exclude:
- 'app/controllers/concerns/wiki_actions.rb'
- 'app/helpers/appearances_helper.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/avatars_helper.rb'
- 'app/helpers/blob_helper.rb'
- 'app/helpers/breadcrumbs_helper.rb'
- 'app/helpers/button_helper.rb'
- 'app/helpers/ci/pipelines_helper.rb'
- 'app/helpers/ci/runners_helper.rb'
- 'app/helpers/ci/status_helper.rb'
- 'app/helpers/clusters_helper.rb'
- 'app/helpers/commits_helper.rb'
- 'app/helpers/diff_helper.rb'
- 'app/helpers/dropdowns_helper.rb'
- 'app/helpers/emails_helper.rb'
- 'app/helpers/environment_helper.rb'
- 'app/helpers/events_helper.rb'
- 'app/helpers/groups_helper.rb'
- 'app/helpers/hooks_helper.rb'
- 'app/helpers/icons_helper.rb'
- 'app/helpers/issuables_helper.rb'
- 'app/helpers/issues_helper.rb'
- 'app/helpers/labels_helper.rb'
- 'app/helpers/listbox_helper.rb'
- 'app/helpers/markup_helper.rb'
- 'app/helpers/notes_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/repository_languages_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/tab_helper.rb'
- 'app/helpers/timeboxes_helper.rb'
- 'app/helpers/todos_helper.rb'
- 'app/helpers/users_helper.rb'
- 'app/helpers/version_check_helper.rb'
- 'app/helpers/wiki_helper.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
- 'app/presenters/project_presenter.rb'
- 'app/serializers/analytics/cycle_analytics/stage_entity.rb'
- 'app/serializers/entity_date_helper.rb'
- 'app/services/system_notes/base_service.rb'
- 'app/services/system_notes/commit_service.rb'
- 'ee/app/helpers/ee/button_helper.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups_helper.rb'
- 'ee/app/helpers/ee/issuables_helper.rb'
- 'ee/app/helpers/ee/lock_helper.rb'
- 'ee/app/helpers/ee/namespaces_helper.rb'
- 'ee/app/helpers/ee/search_helper.rb'
- 'ee/lib/gitlab/expiring_subscription_message.rb'
- 'lib/banzai/filter/autolink_filter.rb'
- 'lib/banzai/filter/gollum_tags_filter.rb'
- 'lib/gitlab/emoji.rb'
- 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb'
- 'app/helpers/page_layout_helper.rb'
- 'lib/gitlab/middleware/go.rb'
- 'spec/frontend/fixtures/tabs.rb'
- 'spec/helpers/avatars_helper_spec.rb'

69
.rubocop_todo/rails/create_table_with_timestamps.yml
View file

@ -1,69 +0,0 @@
---
Rails/CreateTableWithTimestamps:
# Offense count: 63
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'db/migrate/20210305180331_create_ci_unit_tests.rb'
- 'db/migrate/20210305182855_create_ci_unit_test_failures.rb'
- 'db/migrate/20210317035357_create_dast_profiles_pipelines.rb'
- 'db/migrate/20210317104301_create_in_product_marketing_emails.rb'
- 'db/migrate/20210323125809_create_status_check_responses_table.rb'
- 'db/migrate/20210329191850_add_finding_signature_table.rb'
- 'db/migrate/20210411212813_add_clusters_integrations_prometheus.rb'
- 'db/migrate/20210423054022_create_dast_site_profiles_pipelines.rb'
- 'db/migrate/20210429032320_add_escalation_rules.rb'
- 'db/migrate/20210429131525_create_user_credit_card_validations.rb'
- 'db/migrate/20210511104929_add_epic_board_recent_visits_table.rb'
- 'db/migrate/20210512120122_add_pending_builds_table.rb'
- 'db/migrate/20210527194558_create_ci_job_token_project_scope_links.rb'
- 'db/migrate/20210601123341_add_running_builds_table.rb'
- 'db/migrate/20210602122213_add_upcoming_reconciliations.rb'
- 'db/migrate/20210604032738_create_dast_site_profiles_builds.rb'
- 'db/migrate/20210604051330_create_dast_scanner_profiles_builds.rb'
- 'db/migrate/20210604082145_create_external_status_checks_table.rb'
- 'db/migrate/20210713211008_create_banned_users.rb'
- 'db/migrate/20210729081739_create_project_topics.rb'
- 'db/migrate/20210729202143_create_incident_management_issuable_escalation_statuses.rb'
- 'db/migrate/20210730101609_create_analytics_cycle_analytics_stage_event_hashes.rb'
- 'db/migrate/20210809014850_create_agent_group_authorizations.rb'
- 'db/migrate/20210812171704_create_project_ci_feature_usages.rb'
- 'db/migrate/20210813101742_create_zentao_tracker_data.rb'
- 'db/migrate/20210813111909_create_ci_build_trace_metadata.rb'
- 'db/migrate/20210819185500_create_external_audit_event_destinations_table.rb'
- 'db/migrate/20210823172643_create_user_group_callout.rb'
- 'db/migrate/20210823213417_create_dependency_proxy_image_ttl_group_policies.rb'
- 'db/migrate/20210913010411_create_agent_project_authorizations.rb'
- 'db/migrate/20210922215740_create_issue_customer_relations_contacts.rb'
- 'db/migrate/20211004062942_create_coverage_fuzzing_corpuses.rb'
- 'db/migrate/20211004122540_create_member_tasks.rb'
- 'db/migrate/20211011004242_create_content_blocked_states.rb'
- 'db/migrate/20211011140930_create_ci_namespace_mirrors.rb'
- 'db/migrate/20211011140931_create_ci_project_mirrors.rb'
- 'db/migrate/20211011140932_create_namespaces_sync_events.rb'
- 'db/migrate/20211011141239_create_projects_sync_events.rb'
- 'db/migrate/20211028132247_create_packages_npm_metadata.rb'
- 'db/migrate/20211101132310_add_reindexing_queue.rb'
- 'db/migrate/20211101165656_create_upload_states.rb'
- 'db/migrate/20211110014701_create_agent_activity_events.rb'
- 'db/migrate/20211110092710_create_issue_emails.rb'
- 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb'
- 'db/migrate/20211115132613_create_incident_management_timeline_events.rb'
- 'db/migrate/20211117174209_create_vulnerability_reads.rb'
- 'db/migrate/20211119111006_create_job_artifact_states.rb'
- 'db/migrate/20211119154221_create_pages_deployment_states.rb'
- 'db/migrate/20211119195201_create_deployment_approvals.rb'
- 'db/migrate/20211201143042_create_lfs_object_states.rb'
- 'db/migrate/20211216220939_add_group_crm_settings.rb'
- 'db/migrate/20220110170953_create_ci_secure_files.rb'
- 'db/migrate/20220112205111_create_security_training_providers.rb'
- 'db/migrate/20220113125401_create_security_trainings.rb'
- 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb'
- 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb'
- 'db/migrate/20220211125954_create_related_epic_links.rb'
- 'db/migrate/20220216110023_create_saved_replies.rb'
- 'db/migrate/20220301175426_create_project_build_artifacts_size_refresh.rb'
- 'db/migrate/20220302110724_add_group_features_table.rb'
- 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb'
- 'db/migrate/20220425120604_create_packages_cleanup_policies.rb'
- 'db/migrate/20220503102855_add_namespace_ci_cd_settings_table.rb'

1
.rubocop_todo/rails/file_path.yml
View file

@ -1,6 +1,5 @@
---
Rails/FilePath:
Details: grace period
Exclude:
- 'app/controllers/help_controller.rb'
- 'app/helpers/startupjs_helper.rb'

154
.rubocop_todo/rails/has_many_or_has_one_dependent.yml
View file

@ -1,154 +0,0 @@
---
Rails/HasManyOrHasOneDependent:
# Offense count: 593
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/models/alert_management/alert.rb'
- 'app/models/analytics/cycle_analytics/project_value_stream.rb'
- 'app/models/analytics/cycle_analytics/stage_event_hash.rb'
- 'app/models/application_setting/term.rb'
- 'app/models/bulk_import.rb'
- 'app/models/bulk_imports/entity.rb'
- 'app/models/bulk_imports/export.rb'
- 'app/models/ci/bridge.rb'
- 'app/models/ci/build.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/ci/pipeline_schedule.rb'
- 'app/models/ci/processable.rb'
- 'app/models/ci/ref.rb'
- 'app/models/ci/resource_group.rb'
- 'app/models/ci/runner.rb'
- 'app/models/ci/stage.rb'
- 'app/models/ci/trigger.rb'
- 'app/models/ci/trigger_request.rb'
- 'app/models/ci/unit_test.rb'
- 'app/models/clusters/agent.rb'
- 'app/models/clusters/applications/knative.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/project.rb'
- 'app/models/commit_status.rb'
- 'app/models/concerns/ci/metadatable.rb'
- 'app/models/concerns/integrations/has_data_fields.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/label_eventable.rb'
- 'app/models/concerns/milestone_eventable.rb'
- 'app/models/concerns/packages/debian/distribution.rb'
- 'app/models/concerns/protected_ref.rb'
- 'app/models/concerns/state_eventable.rb'
- 'app/models/concerns/timebox.rb'
- 'app/models/concerns/versioned_description.rb'
- 'app/models/concerns/with_uploads.rb'
- 'app/models/customer_relations/contact.rb'
- 'app/models/deploy_key.rb'
- 'app/models/deploy_token.rb'
- 'app/models/deployment.rb'
- 'app/models/design_management/design.rb'
- 'app/models/design_management/version.rb'
- 'app/models/environment.rb'
- 'app/models/error_tracking/error.rb'
- 'app/models/event.rb'
- 'app/models/experiment.rb'
- 'app/models/fork_network.rb'
- 'app/models/gpg_key.rb'
- 'app/models/group.rb'
- 'app/models/hooks/web_hook.rb'
- 'app/models/integration.rb'
- 'app/models/issue.rb'
- 'app/models/jira_connect_installation.rb'
- 'app/models/label.rb'
- 'app/models/lfs_object.rb'
- 'app/models/list.rb'
- 'app/models/member.rb'
- 'app/models/merge_request.rb'
- 'app/models/merge_request_context_commit.rb'
- 'app/models/milestone.rb'
- 'app/models/namespace.rb'
- 'app/models/namespaces/project_namespace.rb'
- 'app/models/note.rb'
- 'app/models/operations/feature_flag.rb'
- 'app/models/operations/feature_flags/strategy.rb'
- 'app/models/operations/feature_flags/user_list.rb'
- 'app/models/packages/debian/project_distribution.rb'
- 'app/models/packages/dependency.rb'
- 'app/models/packages/dependency_link.rb'
- 'app/models/packages/package.rb'
- 'app/models/packages/package_file.rb'
- 'app/models/pages_domain.rb'
- 'app/models/plan.rb'
- 'app/models/pool_repository.rb'
- 'app/models/project.rb'
- 'app/models/projects/topic.rb'
- 'app/models/prometheus_alert.rb'
- 'app/models/prometheus_metric.rb'
- 'app/models/release.rb'
- 'app/models/snippet.rb'
- 'app/models/terraform/state.rb'
- 'app/models/user.rb'
- 'app/models/wiki_page/meta.rb'
- 'app/models/work_items/type.rb'
- 'app/models/x509_certificate.rb'
- 'app/models/x509_issuer.rb'
- 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb'
- 'ee/app/models/analytics/devops_adoption/snapshot.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/approval_project_rule.rb'
- 'ee/app/models/boards/epic_board.rb'
- 'ee/app/models/boards/epic_list.rb'
- 'ee/app/models/compliance_management/framework.rb'
- 'ee/app/models/concerns/ee/iteration_eventable.rb'
- 'ee/app/models/concerns/ee/protected_branch.rb'
- 'ee/app/models/concerns/ee/protected_ref.rb'
- 'ee/app/models/concerns/ee/weight_eventable.rb'
- 'ee/app/models/concerns/geo/eventable.rb'
- 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb'
- 'ee/app/models/concerns/security/scan_execution_policy.rb'
- 'ee/app/models/dast/profile.rb'
- 'ee/app/models/dast_site.rb'
- 'ee/app/models/dast_site_profile.rb'
- 'ee/app/models/dast_site_validation.rb'
- 'ee/app/models/ee/alert_management/alert.rb'
- 'ee/app/models/ee/analytics/cycle_analytics/stage_event_hash.rb'
- 'ee/app/models/ee/board.rb'
- 'ee/app/models/ee/ci/build.rb'
- 'ee/app/models/ee/ci/job_artifact.rb'
- 'ee/app/models/ee/ci/pipeline.rb'
- 'ee/app/models/ee/deployment.rb'
- 'ee/app/models/ee/environment.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/issue.rb'
- 'ee/app/models/ee/iteration.rb'
- 'ee/app/models/ee/label.rb'
- 'ee/app/models/ee/lfs_object.rb'
- 'ee/app/models/ee/merge_request.rb'
- 'ee/app/models/ee/merge_request_diff.rb'
- 'ee/app/models/ee/milestone.rb'
- 'ee/app/models/ee/namespace.rb'
- 'ee/app/models/ee/pages_deployment.rb'
- 'ee/app/models/ee/plan.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/upload.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/models/elastic/reindexing_subtask.rb'
- 'ee/app/models/elastic/reindexing_task.rb'
- 'ee/app/models/geo/event.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/incident_management/escalation_policy.rb'
- 'ee/app/models/incident_management/oncall_participant.rb'
- 'ee/app/models/incident_management/oncall_rotation.rb'
- 'ee/app/models/incident_management/oncall_schedule.rb'
- 'ee/app/models/integrations/gitlab_slack_application.rb'
- 'ee/app/models/iterations/cadence.rb'
- 'ee/app/models/protected_environment.rb'
- 'ee/app/models/protected_environments/approval_rule.rb'
- 'ee/app/models/push_rule.rb'
- 'ee/app/models/saml_provider.rb'
- 'ee/app/models/security/finding.rb'
- 'ee/app/models/security/scan.rb'
- 'ee/app/models/security/training_provider.rb'
- 'ee/app/models/vulnerabilities/finding.rb'
- 'ee/app/models/vulnerabilities/identifier.rb'
- 'ee/app/models/vulnerabilities/remediation.rb'
- 'ee/app/models/vulnerabilities/scanner.rb'

1
.rubocop_todo/rails/helper_instance_variable.yml
View file

@ -1,6 +1,5 @@
---
Rails/HelperInstanceVariable:
Details: grace period
Exclude:
- 'app/helpers/admin/user_actions_helper.rb'
- 'app/helpers/application_helper.rb'

1
.rubocop_todo/rails/index_with.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Rails/IndexWith:
Details: grace period
Exclude:
- 'app/helpers/ci/jobs_helper.rb'
- 'app/models/ci/build_trace_chunk.rb'

1
.rubocop_todo/rails/inverse_of.yml
View file

@ -1,6 +1,5 @@
---
Rails/InverseOf:
Details: grace period
Exclude:
- 'app/models/alert_management/alert.rb'
- 'app/models/alert_management/alert_assignee.rb'

11
.rubocop_todo/rails/lexically_scoped_action_filter.yml
View file

@ -1,15 +1,13 @@
---
Rails/LexicallyScopedActionFilter:
# Offense count: 73
# Temporarily disabled due to too many offenses
Enabled: false
Details: grace period
Exclude:
- 'app/controllers/admin/groups_controller.rb'
- 'app/controllers/admin/hooks_controller.rb'
- 'app/controllers/clusters/base_controller.rb'
- 'app/controllers/clusters/clusters_controller.rb'
- 'app/controllers/concerns/enforces_two_factor_authentication.rb'
- 'app/controllers/concerns/integrations/actions.rb'
- 'app/controllers/concerns/multiple_boards_actions.rb'
- 'app/controllers/concerns/oauth_applications.rb'
- 'app/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support.rb'
- 'app/controllers/confirmations_controller.rb'
@ -17,14 +15,17 @@ Rails/LexicallyScopedActionFilter:
- 'app/controllers/groups/group_members_controller.rb'
- 'app/controllers/groups/milestones_controller.rb'
- 'app/controllers/groups/runners_controller.rb'
- 'app/controllers/groups/settings/repository_controller.rb'
- 'app/controllers/groups/uploads_controller.rb'
- 'app/controllers/groups_controller.rb'
- 'app/controllers/import/base_controller.rb'
- 'app/controllers/oauth/applications_controller.rb'
- 'app/controllers/passwords_controller.rb'
- 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb'
- 'app/controllers/projects/badges_controller.rb'
- 'app/controllers/projects/branches_controller.rb'
- 'app/controllers/projects/environments_controller.rb'
- 'app/controllers/projects/hooks_controller.rb'
- 'app/controllers/projects/incidents_controller.rb'
- 'app/controllers/projects/issue_links_controller.rb'
- 'app/controllers/projects/issues_controller.rb'
@ -36,6 +37,8 @@ Rails/LexicallyScopedActionFilter:
- 'app/controllers/projects/project_members_controller.rb'
- 'app/controllers/projects/prometheus/alerts_controller.rb'
- 'app/controllers/projects/releases_controller.rb'
- 'app/controllers/projects/settings/integration_hook_logs_controller.rb'
- 'app/controllers/projects/settings/merge_requests_controller.rb'
- 'app/controllers/projects/snippets_controller.rb'
- 'app/controllers/projects/tags_controller.rb'
- 'app/controllers/projects/todos_controller.rb'

14
.rubocop_todo/rails/negate_include.yml
View file

@ -1,30 +1,28 @@
---
# Cop supports --auto-correct.
Rails/NegateInclude:
# Offense count: 65
# Temporarily disabled due to too many offenses
Enabled: false
Details: grace period
Exclude:
- 'app/finders/projects_finder.rb'
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/tree_helper.rb'
- 'app/models/concerns/timebox.rb'
- 'app/models/integrations/chat_message/pipeline_message.rb'
- 'app/models/integrations/field.rb'
- 'app/models/label.rb'
- 'app/models/merge_request.rb'
- 'app/models/milestone.rb'
- 'app/services/todo_service.rb'
- 'app/services/work_items/parent_links/create_service.rb'
- 'config/application.rb'
- 'config/initializers/1_settings.rb'
- 'danger/roulette/Dangerfile'
- 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/services/epic_issues/create_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb'
- 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb'
- 'lib/api/maven_packages.rb'
- 'lib/generators/gitlab/usage_metric_generator.rb'
- 'lib/gitlab/background_migration/legacy_upload_mover.rb'
- 'lib/gitlab/ci/build/rules/rule/clause/exists.rb'
- 'lib/gitlab/ci/parsers/coverage/sax_document.rb'
@ -38,11 +36,10 @@ Rails/NegateInclude:
- 'lib/gitlab/task_helpers.rb'
- 'lib/gitlab/url_blocker.rb'
- 'lib/gitlab_edition.rb'
- 'qa/qa/page/merge_request/show.rb'
- 'qa/qa/runtime/ip_address.rb'
- 'qa/qa/support/run.rb'
- 'qa/qa/tools/delete_test_users.rb'
- 'qa/qa/vendor/jenkins/page/configure_job.rb'
- 'qa/qa/vendor/jenkins/page/last_job_console.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- 'rubocop/cop/graphql/id_type.rb'
- 'rubocop/cop/migration/add_reference.rb'
@ -56,3 +53,4 @@ Rails/NegateInclude:
- 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb'
- 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb'
- 'spec/uploaders/object_storage_spec.rb'
- 'tooling/danger/specs.rb'

1
.rubocop_todo/rails/redundant_foreign_key.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Rails/RedundantForeignKey:
Details: grace period
Exclude:
- 'app/models/alert_management/metric_image.rb'
- 'app/models/ci/build.rb'

730
.rubocop_todo/rails/skips_model_validations.yml
View file

@ -1,730 +0,0 @@
---
Rails/SkipsModelValidations:
# Offense count: 1424
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/controllers/import/github_controller.rb'
- 'app/controllers/projects/environments_controller.rb'
- 'app/controllers/projects/notes_controller.rb'
- 'app/models/alert_management/alert.rb'
- 'app/models/analytics/cycle_analytics/aggregation.rb'
- 'app/models/chat_name.rb'
- 'app/models/ci/build.rb'
- 'app/models/ci/build_trace_chunks/database.rb'
- 'app/models/ci/build_trace_metadata.rb'
- 'app/models/ci/daily_build_group_report_result.rb'
- 'app/models/ci/deleted_object.rb'
- 'app/models/ci/namespace_mirror.rb'
- 'app/models/ci/pending_build.rb'
- 'app/models/ci/pipeline_schedule.rb'
- 'app/models/ci/processable.rb'
- 'app/models/ci/project_mirror.rb'
- 'app/models/ci/resource_group.rb'
- 'app/models/ci/runner.rb'
- 'app/models/ci/running_build.rb'
- 'app/models/ci/unit_test.rb'
- 'app/models/commit_status.rb'
- 'app/models/concerns/batch_nullify_dependent_associations.rb'
- 'app/models/concerns/board_recent_visit.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/concerns/can_move_repository_storage.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
- 'app/models/concerns/counter_attribute.rb'
- 'app/models/concerns/deprecated_assignee.rb'
- 'app/models/concerns/file_store_mounter.rb'
- 'app/models/concerns/has_wiki_page_meta_attributes.rb'
- 'app/models/concerns/noteable.rb'
- 'app/models/concerns/packages/debian/distribution.rb'
- 'app/models/concerns/relative_positioning.rb'
- 'app/models/concerns/repository_storage_movable.rb'
- 'app/models/concerns/resolvable_note.rb'
- 'app/models/concerns/schedulable.rb'
- 'app/models/concerns/subscribable.rb'
- 'app/models/container_expiration_policy.rb'
- 'app/models/customer_relations/contact.rb'
- 'app/models/customer_relations/organization.rb'
- 'app/models/deployment.rb'
- 'app/models/diff_note_position.rb'
- 'app/models/environment.rb'
- 'app/models/gpg_key.rb'
- 'app/models/group.rb'
- 'app/models/group_import_state.rb'
- 'app/models/hooks/web_hook.rb'
- 'app/models/internal_id.rb'
- 'app/models/issue.rb'
- 'app/models/jira_import_state.rb'
- 'app/models/loose_foreign_keys/deleted_record.rb'
- 'app/models/merge_request.rb'
- 'app/models/merge_request/diff_commit_user.rb'
- 'app/models/merge_request_diff.rb'
- 'app/models/namespace.rb'
- 'app/models/note.rb'
- 'app/models/project.rb'
- 'app/models/project_authorization.rb'
- 'app/models/project_import_state.rb'
- 'app/models/project_statistics.rb'
- 'app/models/project_wiki.rb'
- 'app/models/projects/ci_feature_usage.rb'
- 'app/models/projects/repository_storage_move.rb'
- 'app/models/projects/topic.rb'
- 'app/models/raw_usage_data.rb'
- 'app/models/remote_mirror.rb'
- 'app/models/route.rb'
- 'app/models/todo.rb'
- 'app/models/u2f_registration.rb'
- 'app/models/user.rb'
- 'app/models/user_custom_attribute.rb'
- 'app/models/user_interacted_project.rb'
- 'app/services/boards/lists/base_destroy_service.rb'
- 'app/services/boards/lists/move_service.rb'
- 'app/services/bulk_create_integration_service.rb'
- 'app/services/bulk_update_integration_service.rb'
- 'app/services/ci/abort_pipelines_service.rb'
- 'app/services/ci/disable_user_pipeline_schedules_service.rb'
- 'app/services/ci/expire_pipeline_cache_service.rb'
- 'app/services/ci/job_artifacts/create_service.rb'
- 'app/services/ci/job_artifacts/destroy_batch_service.rb'
- 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb'
- 'app/services/ci/job_artifacts/update_unknown_locked_status_service.rb'
- 'app/services/ci/test_failure_history_service.rb'
- 'app/services/ci/update_build_state_service.rb'
- 'app/services/ci/update_pending_build_service.rb'
- 'app/services/clusters/agent_tokens/track_usage_service.rb'
- 'app/services/clusters/agents/refresh_authorization_service.rb'
- 'app/services/clusters/integrations/prometheus_health_check_service.rb'
- 'app/services/deployments/archive_in_project_service.rb'
- 'app/services/event_create_service.rb'
- 'app/services/groups/transfer_service.rb'
- 'app/services/issuable_base_service.rb'
- 'app/services/issues/move_service.rb'
- 'app/services/issues/set_crm_contacts_service.rb'
- 'app/services/keys/expiry_notification_service.rb'
- 'app/services/keys/last_used_service.rb'
- 'app/services/labels/promote_service.rb'
- 'app/services/labels/transfer_service.rb'
- 'app/services/merge_requests/bulk_remove_attention_requested_service.rb'
- 'app/services/merge_requests/cleanup_refs_service.rb'
- 'app/services/merge_requests/ff_merge_service.rb'
- 'app/services/merge_requests/merge_service.rb'
- 'app/services/merge_requests/rebase_service.rb'
- 'app/services/merge_requests/reopen_service.rb'
- 'app/services/milestones/promote_service.rb'
- 'app/services/milestones/transfer_service.rb'
- 'app/services/packages/composer/create_package_service.rb'
- 'app/services/packages/debian/generate_distribution_service.rb'
- 'app/services/packages/generic/create_package_file_service.rb'
- 'app/services/packages/mark_package_files_for_destruction_service.rb'
- 'app/services/packages/npm/create_tag_service.rb'
- 'app/services/packages/pypi/create_package_service.rb'
- 'app/services/packages/rubygems/create_dependencies_service.rb'
- 'app/services/personal_access_tokens/last_used_service.rb'
- 'app/services/projects/destroy_service.rb'
- 'app/services/projects/detect_repository_languages_service.rb'
- 'app/services/projects/move_deploy_keys_projects_service.rb'
- 'app/services/projects/move_forks_service.rb'
- 'app/services/projects/move_lfs_objects_projects_service.rb'
- 'app/services/projects/move_notification_settings_service.rb'
- 'app/services/projects/move_project_authorizations_service.rb'
- 'app/services/projects/move_project_group_links_service.rb'
- 'app/services/projects/move_project_members_service.rb'
- 'app/services/projects/move_users_star_projects_service.rb'
- 'app/services/projects/repository_languages_service.rb'
- 'app/services/projects/unlink_fork_service.rb'
- 'app/services/reset_project_cache_service.rb'
- 'app/services/spam/akismet_mark_as_spam_service.rb'
- 'app/services/spam/ham_service.rb'
- 'app/services/suggestions/apply_service.rb'
- 'app/services/suggestions/outdate_service.rb'
- 'app/services/users/activity_service.rb'
- 'app/services/users/migrate_to_ghost_user_service.rb'
- 'app/services/users/respond_to_terms_service.rb'
- 'app/services/users/set_status_service.rb'
- 'app/services/users/upsert_credit_card_validation_service.rb'
- 'app/services/x509_certificate_revoke_service.rb'
- 'app/uploaders/file_mover.rb'
- 'app/uploaders/object_storage.rb'
- 'app/workers/analytics/usage_trends/counter_job_worker.rb'
- 'app/workers/concerns/dependency_proxy/expireable.rb'
- 'app/workers/concerns/packages/cleanup_artifact_worker.rb'
- 'app/workers/container_expiration_policy_worker.rb'
- 'app/workers/packages/helm/extraction_worker.rb'
- 'app/workers/packages/nuget/extraction_worker.rb'
- 'app/workers/packages/rubygems/extraction_worker.rb'
- 'app/workers/personal_access_tokens/expired_notification_worker.rb'
- 'app/workers/personal_access_tokens/expiring_worker.rb'
- 'app/workers/pipeline_metrics_worker.rb'
- 'app/workers/process_commit_worker.rb'
- 'app/workers/repository_check/clear_worker.rb'
- 'app/workers/repository_check/single_repository_worker.rb'
- 'app/workers/stuck_merge_jobs_worker.rb'
- 'app/workers/x509_issuer_crl_check_worker.rb'
- 'db/migrate/20210428151144_update_invalid_web_hooks.rb'
- 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb'
- 'db/migrate/20210630224625_generate_customers_dot_jwt_signing_key.rb'
- 'db/migrate/20210729123101_confirm_security_bot.rb'
- 'db/migrate/20220413054910_backfill_delayed_group_deletion.rb'
- 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb'
- 'db/post_migrate/20210303165302_cleanup_cluster_tokens_with_null_name.rb'
- 'db/post_migrate/20210406144743_backfill_total_tuple_count_for_batched_migrations.rb'
- 'db/post_migrate/20210513155546_backfill_nuget_temporary_packages_to_processing_status.rb'
- 'db/post_migrate/20210601073400_fix_total_stage_in_vsa.rb'
- 'db/post_migrate/20210615234935_fix_batched_migrations_old_format_job_arguments.rb'
- 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb'
- 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb'
- 'db/post_migrate/20210809123658_orphaned_invite_tokens_cleanup.rb'
- 'db/post_migrate/20210811122206_update_external_project_bots.rb'
- 'db/post_migrate/20210825150212_cleanup_remaining_orphan_invites.rb'
- 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb'
- 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb'
- 'db/post_migrate/20210908132335_disable_job_token_scope_when_unused.rb'
- 'db/post_migrate/20210914095310_cleanup_orphan_project_access_tokens.rb'
- 'db/post_migrate/20211217174331_mark_recalculate_finding_signatures_as_completed.rb'
- 'db/post_migrate/20211220123956_update_invalid_member_states.rb'
- 'db/post_migrate/20220305223212_add_security_training_providers.rb'
- 'db/post_migrate/20220307203459_rename_user_email_lookup_limit_setting_to_search_settings_cleanup.rb'
- 'db/post_migrate/20220322132242_update_pages_onboarding_state.rb'
- 'ee/app/controllers/ee/clusters/clusters_controller.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/ci/minutes/namespace_monthly_usage.rb'
- 'ee/app/models/ci/minutes/project_monthly_usage.rb'
- 'ee/app/models/concerns/deprecated_approvals_before_merge.rb'
- 'ee/app/models/concerns/epic_tree_sorting.rb'
- 'ee/app/models/concerns/geo/replicable_registry.rb'
- 'ee/app/models/concerns/geo/verification_state.rb'
- 'ee/app/models/ee/description_version.rb'
- 'ee/app/models/ee/environment.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/event.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/iteration.rb'
- 'ee/app/models/ee/namespace_setting.rb'
- 'ee/app/models/ee/project_wiki.rb'
- 'ee/app/models/geo/container_repository_registry.rb'
- 'ee/app/models/geo/design_registry.rb'
- 'ee/app/models/geo/project_registry.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/incident_management/oncall_rotation.rb'
- 'ee/app/models/vulnerabilities/feedback.rb'
- 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb'
- 'ee/app/services/ci/minutes/additional_packs/change_namespace_service.rb'
- 'ee/app/services/ci/minutes/batch_reset_service.rb'
- 'ee/app/services/ci/minutes/refresh_cached_data_service.rb'
- 'ee/app/services/ci/minutes/reset_usage_service.rb'
- 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb'
- 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb'
- 'ee/app/services/ee/issues/move_service.rb'
- 'ee/app/services/ee/labels/promote_service.rb'
- 'ee/app/services/ee/milestones/promote_service.rb'
- 'ee/app/services/ee/projects/transfer_service.rb'
- 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb'
- 'ee/app/services/epics/strategies/due_date_inherited_strategy.rb'
- 'ee/app/services/epics/strategies/start_date_inherited_strategy.rb'
- 'ee/app/services/geo/repository_verification_reset.rb'
- 'ee/app/services/incident_management/oncall_rotations/edit_service.rb'
- 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb'
- 'ee/app/services/iterations/cadences/create_iterations_in_advance_service.rb'
- 'ee/app/services/iterations/cadences/destroy_service.rb'
- 'ee/app/services/iterations/delete_service.rb'
- 'ee/app/services/iterations/roll_over_issues_service.rb'
- 'ee/app/services/ldap_group_reset_service.rb'
- 'ee/app/services/personal_access_tokens/revoke_invalid_tokens.rb'
- 'ee/app/services/security/findings/cleanup_service.rb'
- 'ee/app/services/security/ingestion/mark_as_resolved_service.rb'
- 'ee/app/services/security/store_findings_metadata_service.rb'
- 'ee/app/services/security/store_scan_service.rb'
- 'ee/app/services/security/update_training_service.rb'
- 'ee/app/services/vulnerabilities/starboard_vulnerability_resolve_service.rb'
- 'ee/app/workers/import_software_licenses_worker.rb'
- 'ee/app/workers/iterations_update_status_worker.rb'
- 'ee/app/workers/sync_seat_link_request_worker.rb'
- 'ee/lib/api/geo_replication.rb'
- 'ee/lib/ee/api/protected_branches.rb'
- 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/gitlab/geo/replicator.rb'
- 'ee/lib/tasks/migrate/ldap.rake'
- 'ee/spec/controllers/admin/geo/projects_controller_spec.rb'
- 'ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb'
- 'ee/spec/controllers/groups/ldaps_controller_spec.rb'
- 'ee/spec/controllers/projects/merge_requests_controller_spec.rb'
- 'ee/spec/factories/import_states.rb'
- 'ee/spec/features/admin/admin_settings_spec.rb'
- 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb'
- 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb'
- 'ee/spec/features/projects/settings/issues_settings_spec.rb'
- 'ee/spec/features/projects/settings/protected_environments_spec.rb'
- 'ee/spec/features/projects/user_applies_custom_file_template_spec.rb'
- 'ee/spec/features/trials/select_namespace_spec.rb'
- 'ee/spec/finders/geo/repository_verification_finder_spec.rb'
- 'ee/spec/finders/security/findings_finder_spec.rb'
- 'ee/spec/finders/security/training_urls_finder_spec.rb'
- 'ee/spec/finders/template_finder_spec.rb'
- 'ee/spec/graphql/mutations/issues/set_epic_spec.rb'
- 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb'
- 'ee/spec/graphql/mutations/issues/set_iteration_spec.rb'
- 'ee/spec/graphql/resolvers/boards/epic_lists_resolvers_spec.rb'
- 'ee/spec/helpers/ee/blob_helper_spec.rb'
- 'ee/spec/helpers/push_rules_helper_spec.rb'
- 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb'
- 'ee/spec/lib/ee/api/helpers_spec.rb'
- 'ee/spec/lib/ee/audit/group_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/audit/project_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/audit/project_ci_cd_setting_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/audit/project_feature_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb'
- 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb'
- 'ee/spec/lib/gitlab/auth/saml/user_spec.rb'
- 'ee/spec/lib/gitlab/custom_file_templates_spec.rb'
- 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb'
- 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb'
- 'ee/spec/lib/gitlab/geo/signed_data_spec.rb'
- 'ee/spec/lib/gitlab/git_access_spec.rb'
- 'ee/spec/models/application_setting_spec.rb'
- 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb'
- 'ee/spec/models/concerns/elastic/note_spec.rb'
- 'ee/spec/models/concerns/geo/verification_state_spec.rb'
- 'ee/spec/models/dast/profile_schedule_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
- 'ee/spec/models/ee/groups/feature_setting_spec.rb'
- 'ee/spec/models/ee/iteration_spec.rb'
- 'ee/spec/models/ee/iterations/cadence_spec.rb'
- 'ee/spec/models/ee/vulnerability_spec.rb'
- 'ee/spec/models/geo_node_spec.rb'
- 'ee/spec/models/geo_node_status_spec.rb'
- 'ee/spec/models/group_wiki_repository_spec.rb'
- 'ee/spec/models/instance_security_dashboard_spec.rb'
- 'ee/spec/models/merge_request/blocking_spec.rb'
- 'ee/spec/models/merge_train_spec.rb'
- 'ee/spec/models/packages/package_file_spec.rb'
- 'ee/spec/models/project_feature_spec.rb'
- 'ee/spec/models/project_import_state_spec.rb'
- 'ee/spec/models/project_spec.rb'
- 'ee/spec/models/project_team_spec.rb'
- 'ee/spec/models/push_rule_spec.rb'
- 'ee/spec/models/requirements_management/requirement_spec.rb'
- 'ee/spec/models/security/scan_spec.rb'
- 'ee/spec/models/snippet_repository_spec.rb'
- 'ee/spec/models/vulnerabilities/feedback_spec.rb'
- 'ee/spec/models/vulnerabilities/stat_diff_spec.rb'
- 'ee/spec/policies/group_policy_spec.rb'
- 'ee/spec/policies/project_policy_spec.rb'
- 'ee/spec/requests/api/epic_issues_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb'
- 'ee/spec/requests/api/groups_spec.rb'
- 'ee/spec/requests/api/internal/app_sec/dast/site_validations_spec.rb'
- 'ee/spec/requests/api/internal/kubernetes_spec.rb'
- 'ee/spec/requests/api/namespaces_spec.rb'
- 'ee/spec/requests/api/project_approvals_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/requests/projects/merge_requests_controller_spec.rb'
- 'ee/spec/serializers/merge_request_widget_entity_spec.rb'
- 'ee/spec/services/ci/create_pipeline_service_spec.rb'
- 'ee/spec/services/ci/minutes/email_notification_service_spec.rb'
- 'ee/spec/services/ci/register_job_service_spec.rb'
- 'ee/spec/services/ci_cd/setup_project_spec.rb'
- 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
- 'ee/spec/services/ee/notification_service_spec.rb'
- 'ee/spec/services/ee/releases/create_evidence_service_spec.rb'
- 'ee/spec/services/epic_issues/update_service_spec.rb'
- 'ee/spec/services/epics/issue_promote_service_spec.rb'
- 'ee/spec/services/epics/update_service_spec.rb'
- 'ee/spec/services/geo/file_registry_removal_service_spec.rb'
- 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb'
- 'ee/spec/services/groups/create_service_spec.rb'
- 'ee/spec/services/groups/update_service_spec.rb'
- 'ee/spec/services/merge_trains/check_status_service_spec.rb'
- 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb'
- 'ee/spec/services/merge_trains/refresh_service_spec.rb'
- 'ee/spec/services/projects/setup_ci_cd_spec.rb'
- 'ee/spec/services/projects/update_mirror_service_spec.rb'
- 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb'
- 'ee/spec/services/vulnerabilities/starboard_vulnerability_resolve_service_spec.rb'
- 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb'
- 'ee/spec/services/vulnerabilities/statistics/update_service_spec.rb'
- 'ee/spec/support/helpers/ee/geo_helpers.rb'
- 'ee/spec/support/shared_examples/models/requirement_issues_examples.rb'
- 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb'
- 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb'
- 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb'
- 'ee/spec/workers/geo/repositories_clean_up_worker_spec.rb'
- 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb'
- 'ee/spec/workers/geo/repository_sync_worker_spec.rb'
- 'ee/spec/workers/geo/repository_verification/primary/batch_worker_spec.rb'
- 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb'
- 'ee/spec/workers/geo/repository_verification/secondary/scheduler_worker_spec.rb'
- 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb'
- 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb'
- 'ee/spec/workers/import_software_licenses_worker_spec.rb'
- 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb'
- 'ee/spec/workers/iterations_update_status_worker_spec.rb'
- 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb'
- 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb'
- 'ee/spec/workers/update_all_mirrors_worker_spec.rb'
- 'lib/api/commit_statuses.rb'
- 'lib/api/usage_data.rb'
- 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb'
- 'lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2.rb'
- 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb'
- 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb'
- 'lib/gitlab/background_migration/backfill_topics_title.rb'
- 'lib/gitlab/background_migration/backfill_user_namespace.rb'
- 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb'
- 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb'
- 'lib/gitlab/background_migration/copy_column_using_background_migration_job.rb'
- 'lib/gitlab/background_migration/legacy_upload_mover.rb'
- 'lib/gitlab/background_migration/merge_topics_with_same_name.rb'
- 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb'
- 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb'
- 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb'
- 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb'
- 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'lib/gitlab/bitbucket_import/importer.rb'
- 'lib/gitlab/bitbucket_server_import/importer.rb'
- 'lib/gitlab/ci/tags/bulk_insert.rb'
- 'lib/gitlab/ci/trace.rb'
- 'lib/gitlab/composer/cache.rb'
- 'lib/gitlab/database/background_migration_job.rb'
- 'lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin.rb'
- 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb'
- 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb'
- 'lib/gitlab/database/schema_migrations.rb'
- 'lib/gitlab/etag_caching/middleware.rb'
- 'lib/gitlab/fogbugz_import/importer.rb'
- 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb'
- 'lib/gitlab/github_import/importer/pull_request_review_importer.rb'
- 'lib/gitlab/import/set_async_jid.rb'
- 'lib/gitlab/jira_import/handle_labels_service.rb'
- 'lib/gitlab/job_waiter.rb'
- 'lib/gitlab/legacy_github_import/importer.rb'
- 'lib/gitlab/markdown_cache/active_record/extension.rb'
- 'lib/gitlab/otp_key_rotator.rb'
- 'lib/gitlab/seeder.rb'
- 'lib/tasks/ci/cleanup.rake'
- 'lib/tasks/gitlab/external_diffs.rake'
- 'lib/tasks/gitlab/ldap.rake'
- 'lib/tasks/gitlab/user_management.rake'
- 'lib/tasks/migrate/migrate_iids.rake'
- 'spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb'
- 'spec/controllers/groups_controller_spec.rb'
- 'spec/controllers/import/bitbucket_controller_spec.rb'
- 'spec/controllers/import/gitlab_controller_spec.rb'
- 'spec/controllers/omniauth_callbacks_controller_spec.rb'
- 'spec/controllers/projects/forks_controller_spec.rb'
- 'spec/controllers/projects/graphs_controller_spec.rb'
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/content_controller_spec.rb'
- 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/controllers/projects/notes_controller_spec.rb'
- 'spec/controllers/projects/pipelines/tests_controller_spec.rb'
- 'spec/controllers/projects/repositories_controller_spec.rb'
- 'spec/controllers/projects/settings/ci_cd_controller_spec.rb'
- 'spec/controllers/projects/starrers_controller_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- 'spec/controllers/uploads_controller_spec.rb'
- 'spec/factories/alert_management/alerts.rb'
- 'spec/factories/container_expiration_policies.rb'
- 'spec/factories/design_management/versions.rb'
- 'spec/factories/environments.rb'
- 'spec/factories/import_states.rb'
- 'spec/factories/projects.rb'
- 'spec/factories/usage_data.rb'
- 'spec/features/admin/admin_settings_spec.rb'
- 'spec/features/admin/admin_uses_repository_checks_spec.rb'
- 'spec/features/dashboard/projects_spec.rb'
- 'spec/features/groups_spec.rb'
- 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb'
- 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb'
- 'spec/features/issues/discussion_lock_spec.rb'
- 'spec/features/merge_request/merge_request_discussion_lock_spec.rb'
- 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb'
- 'spec/features/merge_request/user_locks_discussion_spec.rb'
- 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb'
- 'spec/features/merge_request/user_sees_diff_spec.rb'
- 'spec/features/merge_request/user_sees_merge_button_depending_on_unresolved_discussions_spec.rb'
- 'spec/features/merge_request/user_sees_merge_widget_spec.rb'
- 'spec/features/merge_request/user_sees_pipelines_spec.rb'
- 'spec/features/merge_request/user_views_merge_request_from_deleted_fork_spec.rb'
- 'spec/features/monitor_sidebar_link_spec.rb'
- 'spec/features/password_reset_spec.rb'
- 'spec/features/profiles/emails_spec.rb'
- 'spec/features/projects/blobs/blob_show_spec.rb'
- 'spec/features/projects/diffs/diff_show_spec.rb'
- 'spec/features/projects/features_visibility_spec.rb'
- 'spec/features/projects/fork_spec.rb'
- 'spec/features/projects/jobs_spec.rb'
- 'spec/features/projects/milestones/milestone_spec.rb'
- 'spec/features/projects/pipeline_schedules_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- 'spec/features/projects/settings/service_desk_setting_spec.rb'
- 'spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb'
- 'spec/features/projects/user_sees_sidebar_spec.rb'
- 'spec/features/projects_spec.rb'
- 'spec/features/u2f_spec.rb'
- 'spec/features/users/show_spec.rb'
- 'spec/features/webauthn_spec.rb'
- 'spec/finders/groups_finder_spec.rb'
- 'spec/finders/notes_finder_spec.rb'
- 'spec/finders/packages/go/package_finder_spec.rb'
- 'spec/finders/packages/maven/package_finder_spec.rb'
- 'spec/finders/packages/npm/package_finder_spec.rb'
- 'spec/finders/packages/nuget/package_finder_spec.rb'
- 'spec/finders/packages/package_finder_spec.rb'
- 'spec/finders/projects_finder_spec.rb'
- 'spec/finders/releases/group_releases_finder_spec.rb'
- 'spec/finders/releases_finder_spec.rb'
- 'spec/finders/user_group_notification_settings_finder_spec.rb'
- 'spec/graphql/mutations/custom_emoji/destroy_spec.rb'
- 'spec/graphql/mutations/issues/set_escalation_status_spec.rb'
- 'spec/graphql/mutations/issues/update_spec.rb'
- 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb'
- 'spec/graphql/types/project_type_spec.rb'
- 'spec/helpers/auth_helper_spec.rb'
- 'spec/helpers/events_helper_spec.rb'
- 'spec/helpers/groups_helper_spec.rb'
- 'spec/helpers/import_helper_spec.rb'
- 'spec/helpers/members_helper_spec.rb'
- 'spec/helpers/projects_helper_spec.rb'
- 'spec/initializers/active_record_locking_spec.rb'
- 'spec/lib/api/helpers_spec.rb'
- 'spec/lib/backup/repositories_spec.rb'
- 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb'
- 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb'
- 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb'
- 'spec/lib/gitlab/asciidoc_spec.rb'
- 'spec/lib/gitlab/auth/saml/user_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
- 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb'
- 'spec/lib/gitlab/ci/variables/builder/group_spec.rb'
- 'spec/lib/gitlab/ci/variables/builder/project_spec.rb'
- 'spec/lib/gitlab/contributions_calendar_spec.rb'
- 'spec/lib/gitlab/cycle_analytics/permissions_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
- 'spec/lib/gitlab/database/batch_count_spec.rb'
- 'spec/lib/gitlab/database/consistency_checker_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb'
- 'spec/lib/gitlab/database/load_balancing_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb'
- 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb'
- 'spec/lib/gitlab/discussions_diff/file_collection_spec.rb'
- 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
- 'spec/lib/gitlab/email/handler/create_note_on_issuable_handler_spec.rb'
- 'spec/lib/gitlab/etag_caching/store_spec.rb'
- 'spec/lib/gitlab/git_access_spec.rb'
- 'spec/lib/gitlab/git_access_wiki_spec.rb'
- 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb'
- 'spec/lib/gitlab/middleware/go_spec.rb'
- 'spec/lib/gitlab/middleware/query_analyzer_spec.rb'
- 'spec/lib/gitlab/object_hierarchy_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb'
- 'spec/lib/sidebars/projects/menus/project_information_menu_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20211126115449_encrypt_static_objects_external_storage_auth_token_spec.rb'
- 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb'
- 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb'
- 'spec/models/application_setting_spec.rb'
- 'spec/models/ci/build_dependencies_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/group_spec.rb'
- 'spec/models/ci/pipeline_schedule_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/ci/processable_spec.rb'
- 'spec/models/ci/resource_group_spec.rb'
- 'spec/models/ci/runner_spec.rb'
- 'spec/models/ci/stage_spec.rb'
- 'spec/models/commit_signatures/gpg_signature_spec.rb'
- 'spec/models/commit_status_spec.rb'
- 'spec/models/concerns/cache_markdown_field_spec.rb'
- 'spec/models/concerns/deployment_platform_spec.rb'
- 'spec/models/concerns/deprecated_assignee_spec.rb'
- 'spec/models/concerns/each_batch_spec.rb'
- 'spec/models/concerns/pg_full_text_searchable_spec.rb'
- 'spec/models/concerns/project_features_compatibility_spec.rb'
- 'spec/models/concerns/spammable_spec.rb'
- 'spec/models/container_repository_spec.rb'
- 'spec/models/deploy_keys_project_spec.rb'
- 'spec/models/deploy_token_spec.rb'
- 'spec/models/diff_discussion_spec.rb'
- 'spec/models/diff_note_spec.rb'
- 'spec/models/environment_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/guest_spec.rb'
- 'spec/models/integration_spec.rb'
- 'spec/models/issue_spec.rb'
- 'spec/models/loose_foreign_keys/deleted_record_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/members/group_member_spec.rb'
- 'spec/models/members/project_member_spec.rb'
- 'spec/models/merge_request_diff_spec.rb'
- 'spec/models/merge_request_spec.rb'
- 'spec/models/namespace/traversal_hierarchy_spec.rb'
- 'spec/models/namespace_spec.rb'
- 'spec/models/note_spec.rb'
- 'spec/models/project_authorization_spec.rb'
- 'spec/models/project_feature_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/project_statistics_spec.rb'
- 'spec/models/projects/build_artifacts_size_refresh_spec.rb'
- 'spec/models/projects/topic_spec.rb'
- 'spec/models/remote_mirror_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/route_spec.rb'
- 'spec/models/snippet_repository_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/policies/ci/build_policy_spec.rb'
- 'spec/policies/custom_emoji_policy_spec.rb'
- 'spec/policies/note_policy_spec.rb'
- 'spec/policies/project_policy_spec.rb'
- 'spec/presenters/ci/build_presenter_spec.rb'
- 'spec/presenters/project_presenter_spec.rb'
- 'spec/requests/api/ci/job_artifacts_spec.rb'
- 'spec/requests/api/ci/runner/jobs_request_post_spec.rb'
- 'spec/requests/api/container_repositories_spec.rb'
- 'spec/requests/api/graphql/container_repository/container_repository_details_spec.rb'
- 'spec/requests/api/graphql/group/dependency_proxy_blobs_spec.rb'
- 'spec/requests/api/graphql/group/dependency_proxy_group_setting_spec.rb'
- 'spec/requests/api/graphql/group/dependency_proxy_image_ttl_policy_spec.rb'
- 'spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb'
- 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb'
- 'spec/requests/api/graphql/mutations/snippets/create_spec.rb'
- 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb'
- 'spec/requests/api/graphql/mutations/snippets/update_spec.rb'
- 'spec/requests/api/helm_packages_spec.rb'
- 'spec/requests/api/issues/get_group_issues_spec.rb'
- 'spec/requests/api/issues/get_project_issues_spec.rb'
- 'spec/requests/api/issues/issues_spec.rb'
- 'spec/requests/api/merge_requests_spec.rb'
- 'spec/requests/api/notes_spec.rb'
- 'spec/requests/api/nuget_group_packages_spec.rb'
- 'spec/requests/api/projects_spec.rb'
- 'spec/requests/api/pypi_packages_spec.rb'
- 'spec/requests/api/releases_spec.rb'
- 'spec/requests/api/rubygem_packages_spec.rb'
- 'spec/requests/api/snippets_spec.rb'
- 'spec/requests/api/tags_spec.rb'
- 'spec/requests/git_http_spec.rb'
- 'spec/requests/groups/settings/access_tokens_controller_spec.rb'
- 'spec/requests/jwt_controller_spec.rb'
- 'spec/requests/lfs_http_spec.rb'
- 'spec/requests/projects/merge_requests_spec.rb'
- 'spec/requests/projects/settings/access_tokens_controller_spec.rb'
- 'spec/services/alert_management/create_alert_issue_service_spec.rb'
- 'spec/services/ci/compare_reports_base_service_spec.rb'
- 'spec/services/ci/compare_test_reports_service_spec.rb'
- 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb'
- 'spec/services/ci/register_job_service_spec.rb'
- 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb'
- 'spec/services/ci/retry_job_service_spec.rb'
- 'spec/services/ci/retry_pipeline_service_spec.rb'
- 'spec/services/ci/test_failure_history_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb'
- 'spec/services/container_expiration_policies/cleanup_service_spec.rb'
- 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb'
- 'spec/services/deployments/update_environment_service_spec.rb'
- 'spec/services/groups/create_service_spec.rb'
- 'spec/services/groups/transfer_service_spec.rb'
- 'spec/services/groups/update_service_spec.rb'
- 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb'
- 'spec/services/issuable/common_system_notes_service_spec.rb'
- 'spec/services/issues/clone_service_spec.rb'
- 'spec/services/issues/close_service_spec.rb'
- 'spec/services/issues/update_service_spec.rb'
- 'spec/services/members/destroy_service_spec.rb'
- 'spec/services/merge_requests/get_urls_service_spec.rb'
- 'spec/services/merge_requests/merge_service_spec.rb'
- 'spec/services/merge_requests/refresh_service_spec.rb'
- 'spec/services/merge_requests/reopen_service_spec.rb'
- 'spec/services/merge_requests/update_service_spec.rb'
- 'spec/services/notes/update_service_spec.rb'
- 'spec/services/notification_service_spec.rb'
- 'spec/services/packages/maven/metadata/sync_service_spec.rb'
- 'spec/services/packages/nuget/search_service_spec.rb'
- 'spec/services/projects/container_repository/delete_tags_service_spec.rb'
- 'spec/services/projects/create_service_spec.rb'
- 'spec/services/projects/destroy_service_spec.rb'
- 'spec/services/projects/fork_service_spec.rb'
- 'spec/services/projects/refresh_build_artifacts_size_statistics_service_spec.rb'
- 'spec/services/repositories/destroy_service_spec.rb'
- 'spec/services/spam/ham_service_spec.rb'
- 'spec/services/system_notes/design_management_service_spec.rb'
- 'spec/services/system_notes/issuables_service_spec.rb'
- 'spec/services/system_notes/time_tracking_service_spec.rb'
- 'spec/services/users/repair_ldap_blocked_service_spec.rb'
- 'spec/services/work_items/task_list_reference_replacement_service_spec.rb'
- 'spec/support/helpers/access_matchers_helpers.rb'
- 'spec/support/matchers/access_matchers_for_controller.rb'
- 'spec/support/shared_contexts/email_shared_context.rb'
- 'spec/support/shared_contexts/finders/packages/npm/package_finder_shared_context.rb'
- 'spec/support/shared_contexts/mailers/notify_shared_context.rb'
- 'spec/support/shared_contexts/requests/api/npm_packages_shared_context.rb'
- 'spec/support/shared_examples/ci/stuck_builds_shared_examples.rb'
- 'spec/support/shared_examples/controllers/create_notes_rate_limit_shared_examples.rb'
- 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb'
- 'spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb'
- 'spec/support/shared_examples/features/2fa_shared_examples.rb'
- 'spec/support/shared_examples/features/access_tokens_shared_examples.rb'
- 'spec/support/shared_examples/features/sidebar_shared_examples.rb'
- 'spec/support/shared_examples/lib/banzai/reference_parser_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/featurable_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/ttl_expirable_shared_examples.rb'
- 'spec/support/shared_examples/models/members_notifications_shared_example.rb'
- 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb'
- 'spec/support/shared_examples/models/throttled_touch_shared_examples.rb'
- 'spec/support/shared_examples/policies/resource_access_token_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/members_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb'
- 'spec/support/shared_examples/requests/user_activity_shared_examples.rb'
- 'spec/support/shared_examples/services/boards/lists_list_service_shared_examples.rb'
- 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb'
- 'spec/support/shared_examples/services/notification_service_shared_examples.rb'
- 'spec/support/shared_examples/views/pipeline_status_changes_email.rb'
- 'spec/support/trace/trace_helpers.rb'
- 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
- 'spec/tasks/gitlab/artifacts/check_rake_spec.rb'
- 'spec/tasks/gitlab/external_diffs_rake_spec.rb'
- 'spec/tasks/gitlab/uploads/check_rake_spec.rb'
- 'spec/uploaders/job_artifact_uploader_spec.rb'
- 'spec/views/groups/edit.html.haml_spec.rb'
- 'spec/views/projects/environments/terminal.html.haml_spec.rb'
- 'spec/workers/auto_devops/disable_worker_spec.rb'
- 'spec/workers/build_finished_worker_spec.rb'
- 'spec/workers/ci/merge_requests/add_todo_when_build_fails_worker_spec.rb'
- 'spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb'
- 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb'
- 'spec/workers/container_expiration_policy_worker_spec.rb'
- 'spec/workers/container_registry/migration/guard_worker_spec.rb'
- 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb'
- 'spec/workers/packages/cleanup_package_file_worker_spec.rb'
- 'spec/workers/packages/cleanup_package_registry_worker_spec.rb'
- 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb'
- 'spec/workers/pipeline_schedule_worker_spec.rb'
- 'spec/workers/remote_mirror_notification_worker_spec.rb'
- 'spec/workers/repository_check/batch_worker_spec.rb'
- 'spec/workers/repository_check/clear_worker_spec.rb'

215
.rubocop_todo/rails/squished_sql_heredocs.yml
View file

@ -1,215 +0,0 @@
---
# Cop supports --auto-correct.
Rails/SquishedSQLHeredocs:
# Offense count: 356
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/finders/members_finder.rb'
- 'app/models/analytics/cycle_analytics/stage_event_hash.rb'
- 'app/models/ci/resource_group.rb'
- 'app/models/clusters/clusters_hierarchy.rb'
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'app/models/concerns/has_environment_scope.rb'
- 'app/models/customer_relations/contact.rb'
- 'app/models/customer_relations/organization.rb'
- 'app/models/deployment.rb'
- 'app/models/issue/metrics.rb'
- 'app/models/merge_request/metrics.rb'
- 'app/models/namespace/traversal_hierarchy.rb'
- 'app/models/namespaces/traversal/linear.rb'
- 'app/models/project.rb'
- 'app/models/user.rb'
- 'app/services/issuable/destroy_label_links_service.rb'
- 'app/services/issues/relative_position_rebalancing_service.rb'
- 'app/services/projects/fetch_statistics_increment_service.rb'
- 'app/services/todos/destroy/destroyed_issuable_service.rb'
- 'app/workers/users/deactivate_dormant_users_worker.rb'
- 'db/migrate/20210323155010_populate_dismissal_information_for_vulnerabilities.rb'
- 'db/migrate/20210601080039_group_protected_environments_add_index_and_constraint.rb'
- 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb'
- 'db/migrate/20210617022324_create_incident_management_pending_alert_escalations.rb'
- 'db/migrate/20210621043337_rename_services_to_integrations.rb'
- 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb'
- 'db/migrate/20210706152139_add_index_type_to_postgres_indexes_view.rb'
- 'db/migrate/20210719145532_add_foreign_keys_view.rb'
- 'db/migrate/20210721135638_add_triggers_to_integrations_type_new.rb'
- 'db/migrate/20210721174453_remove_schedule_and_status_null_constraints_from_pending_escalations_alert.rb'
- 'db/migrate/20210722150102_operations_feature_flags_correct_flexible_rollout_values.rb'
- 'db/migrate/20210730194555_create_incident_management_pending_issue_escalations.rb'
- 'db/migrate/20210818175949_update_integrations_trigger_type_new_on_insert.rb'
- 'db/migrate/20210825104656_create_analytics_cycle_analytics_merge_request_stage_events.rb'
- 'db/migrate/20210825110016_create_analytics_cycle_analytics_issue_stage_events.rb'
- 'db/migrate/20210826122748_create_loose_foreign_keys_deleted_records.rb'
- 'db/migrate/20210826145509_add_function_for_inserting_deleted_records.rb'
- 'db/migrate/20210903054158_recreate_stage_issue_events_table_with_bigints.rb'
- 'db/migrate/20210906100021_delete_project_namespace_trigger.rb'
- 'db/migrate/20210929032555_create_verification_codes.rb'
- 'db/migrate/20211005092428_drop_time_range_partitioned_loose_fk.rb'
- 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb'
- 'db/migrate/20211005100112_recreate_loose_fk_insert_function.rb'
- 'db/migrate/20211007090229_create_issue_search_table.rb'
- 'db/migrate/20211011141242_create_namespaces_sync_trigger.rb'
- 'db/migrate/20211011141243_create_projects_sync_trigger.rb'
- 'db/migrate/20211012015903_next_traversal_ids_sibling_function.rb'
- 'db/migrate/20211018161447_fix_double_entries_in_postgres_index_view.rb'
- 'db/migrate/20211112155416_populate_default_value_for_personal_access_tokens_prefix.rb'
- 'db/migrate/20211118103439_remove_hardcoded_partition_from_loose_fk_trigger_function.rb'
- 'db/migrate/20211123135255_create_batched_background_migration_job_transition_logs.rb'
- 'db/migrate/20220106111958_add_insert_or_update_vulnerability_reads_trigger.rb'
- 'db/migrate/20220106112043_add_update_vulnerability_reads_trigger.rb'
- 'db/migrate/20220106112085_add_update_vulnerability_reads_location_trigger.rb'
- 'db/migrate/20220106163326_add_has_issues_on_vulnerability_reads_trigger.rb'
- 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb'
- 'db/migrate/20220211214605_update_integrations_trigger_type_new_on_insert_null_safe.rb'
- 'db/migrate/20220213100000_remove_integration_type_triggers.rb'
- 'db/migrate/20220304052335_remove_not_null_contraint_on_title_from_sprints.rb'
- 'db/migrate/20220321234317_remove_all_issuable_escalation_statuses.rb'
- 'db/migrate/20220329110630_add_ci_namespace_mirrors_unnest_index_on_traversal_ids.rb'
- 'db/migrate/20220412060931_add_nullify_build_data_trigger_on_merge_request_metrics.rb'
- 'db/migrate/20220413124200_add_view_for_per_table_autovacuum_status.rb'
- 'db/migrate/20220415015143_replace_iterations_cadence_date_range_constraint.rb'
- 'db/migrate/20220422200633_fix_view_for_per_table_autovacuum_status.rb'
- 'db/migrate/20220422220507_remove_tmp_index_supporting_leaky_regex_cleanup.rb'
- 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb'
- 'db/post_migrate/20210311045138_set_traversal_ids_for_gitlab_org_group_staging.rb'
- 'db/post_migrate/20210311045139_set_traversal_ids_for_gitlab_org_group_com.rb'
- 'db/post_migrate/20210311093723_add_partial_index_on_ci_pipelines_by_cancelable_status_and_users.rb'
- 'db/post_migrate/20210317104032_set_iteration_cadence_automatic_to_false.rb'
- 'db/post_migrate/20210331105335_drop_non_partitioned_audit_events.rb'
- 'db/post_migrate/20210430134202_copy_adoption_snapshot_namespace.rb'
- 'db/post_migrate/20210430135954_copy_adoption_segments_namespace.rb'
- 'db/post_migrate/20210525075724_clean_up_pending_builds_table.rb'
- 'db/post_migrate/20210609125005_drop_non_partitioned_web_hook_logs.rb'
- 'db/post_migrate/20210610102413_migrate_protected_attribute_to_pending_builds.rb'
- 'db/post_migrate/20210610141711_disable_expiration_policies_linked_to_no_container_images.rb'
- 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb'
- 'db/post_migrate/20210721174521_add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations.rb'
- 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb'
- 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb'
- 'db/post_migrate/20210910194952_update_report_type_for_existing_approval_project_rules.rb'
- 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb'
- 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb'
- 'db/post_migrate/20211130165043_backfill_sequence_column_for_sprints_table.rb'
- 'db/post_migrate/20211206161271_add_indexes_for_primary_email_cleanup_migration.rb'
- 'db/post_migrate/20211220064757_drop_temporary_indexes_for_primary_email_migration.rb'
- 'db/post_migrate/20220128155251_remove_dangling_running_builds.rb'
- 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb'
- 'db/post_migrate/20220204110725_backfill_cycle_analytics_aggregations.rb'
- 'db/post_migrate/20220213103859_remove_integrations_type.rb'
- 'db/post_migrate/20220309084954_remove_leftover_external_pull_request_deletions.rb'
- 'db/post_migrate/20220318111040_add_indexes_for_primary_email_second_cleanup_migration.rb'
- 'db/post_migrate/20220318111949_drop_temporary_indexes_for_primary_email_migration_second_cleanup.rb'
- 'db/post_migrate/20220329175119_remove_leftover_ci_job_artifact_deletions.rb'
- 'db/post_migrate/20220420135946_update_batched_background_migration_arguments.rb'
- 'ee/app/models/dora/daily_metrics.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/issue.rb'
- 'ee/app/models/iterations/cadence.rb'
- 'ee/app/models/vulnerabilities/statistic.rb'
- 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb'
- 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb'
- 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb'
- 'ee/app/services/vulnerabilities/statistics/update_service.rb'
- 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb'
- 'ee/db/geo/migrate/20180510223634_set_resync_flag_for_retried_projects.rb'
- 'ee/db/geo/post_migrate/20210217020154_add_unique_index_on_container_repository_registry.rb'
- 'ee/db/geo/post_migrate/20210217020156_add_unique_index_on_terraform_state_version_registry.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_test_reports_issue_id.rb'
- 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/gitlab/geo/base_batcher.rb'
- 'ee/spec/models/ee/user_spec.rb'
- 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb'
- 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb'
- 'lib/gitlab/background_migration/backfill_group_features.rb'
- 'lib/gitlab/background_migration/backfill_integrations_type_new.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
- 'lib/gitlab/background_migration/backfill_project_settings.rb'
- 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb'
- 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb'
- 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb'
- 'lib/gitlab/background_migration/encrypt_static_object_token.rb'
- 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb'
- 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb'
- 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb'
- 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb'
- 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb'
- 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb'
- 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb'
- 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb'
- 'lib/gitlab/background_migration/populate_vulnerability_reads.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb'
- 'lib/gitlab/background_migration/update_timelogs_project_id.rb'
- 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb'
- 'lib/gitlab/database/bulk_update.rb'
- 'lib/gitlab/database/count/tablesample_count_strategy.rb'
- 'lib/gitlab/database/load_balancing/load_balancer.rb'
- 'lib/gitlab/database/migration_helpers.rb'
- 'lib/gitlab/database/migration_helpers/loose_foreign_key_helpers.rb'
- 'lib/gitlab/database/migration_helpers/v2.rb'
- 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb'
- 'lib/gitlab/database/migrations/observers/query_statistics.rb'
- 'lib/gitlab/database/partitioning/replace_table.rb'
- 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb'
- 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
- 'lib/gitlab/database/partitioning/time_partition.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
- 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb'
- 'lib/gitlab/database/schema_helpers.rb'
- 'lib/gitlab/database/schema_migrations/migrations.rb'
- 'lib/gitlab/database/unidirectional_copy_trigger.rb'
- 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb'
- 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb'
- 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb'
- 'lib/gitlab/sql/glob.rb'
- 'lib/tasks/dev.rake'
- 'qa/qa/service/praefect_manager.rb'
- 'spec/db/schema_spec.rb'
- 'spec/initializers/00_rails_disable_joins_spec.rb'
- 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers_spec.rb'
- 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb'
- 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb'
- 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb'
- 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb'
- 'spec/lib/gitlab/database/partitioning/replace_table_spec.rb'
- 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb'
- 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'
- 'spec/lib/gitlab/database/partitioning_spec.rb'
- 'spec/lib/gitlab/database/postgres_foreign_key_spec.rb'
- 'spec/lib/gitlab/database/postgres_index_bloat_estimate_spec.rb'
- 'spec/lib/gitlab/database/postgres_index_spec.rb'
- 'spec/lib/gitlab/database/postgres_partition_spec.rb'
- 'spec/lib/gitlab/database/postgres_partitioned_table_spec.rb'
- 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb'
- 'spec/lib/gitlab/database/reindexing_spec.rb'
- 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb'
- 'spec/lib/gitlab/database/similarity_score_spec.rb'
- 'spec/lib/gitlab/database/unidirectional_copy_trigger_spec.rb'
- 'spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb'
- 'spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/order_spec.rb'
- 'spec/models/application_record_spec.rb'
- 'spec/models/concerns/after_commit_queue_spec.rb'
- 'spec/support/db_cleaner.rb'
- 'spec/support/helpers/database/partitioning_helpers.rb'
- 'spec/support/helpers/database/table_schema_helpers.rb'
- 'spec/support/helpers/database/trigger_helpers.rb'
- 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb'

44
.rubocop_todo/rails/where_exists.yml
View file

@ -1,44 +0,0 @@
---
# Cop supports --auto-correct.
Rails/WhereExists:
# Offense count: 48
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/models/application_setting/term.rb'
- 'app/models/ci/pipeline_artifact.rb'
- 'app/models/ci/ref.rb'
- 'app/models/clusters/agent.rb'
- 'app/models/concerns/has_wiki.rb'
- 'app/models/concerns/noteable.rb'
- 'app/models/container_repository.rb'
- 'app/models/design_management/design.rb'
- 'app/models/group.rb'
- 'app/models/group_deploy_token.rb'
- 'app/models/label.rb'
- 'app/models/lfs_object.rb'
- 'app/models/merge_request_diff.rb'
- 'app/models/namespace.rb'
- 'app/models/project.rb'
- 'app/models/protected_branch/push_access_level.rb'
- 'app/services/projects/transfer_service.rb'
- 'app/services/todos/destroy/unauthorized_features_service.rb'
- 'db/migrate/20210422195929_create_elastic_reindexing_slices.rb'
- 'ee/app/models/approval_merge_request_rule_source.rb'
- 'ee/app/models/concerns/ee/protected_ref_access.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group_member.rb'
- 'ee/app/models/ee/milestone_release.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/merge_requests/external_status_check.rb'
- 'ee/app/models/merge_train.rb'
- 'ee/app/workers/concerns/elastic/indexing_control.rb'
- 'lib/gitlab/auth.rb'
- 'lib/gitlab/checks/matching_merge_request.rb'
- 'lib/gitlab/database/partitioning/detached_partition_dropper.rb'
- 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/services/clusters/cleanup/service_account_service_spec.rb'
- 'spec/services/clusters/destroy_service_spec.rb'

26
.rubocop_todo/rake/require.yml Normal file
View file

@ -0,0 +1,26 @@
---
Rake/Require:
Details: grace period
Exclude:
- 'ee/lib/tasks/gitlab/spdx.rake'
- 'lib/tasks/gitlab/artifacts/migrate.rake'
- 'lib/tasks/gitlab/assets.rake'
- 'lib/tasks/gitlab/backup.rake'
- 'lib/tasks/gitlab/cleanup.rake'
- 'lib/tasks/gitlab/dependency_proxy/migrate.rake'
- 'lib/tasks/gitlab/docs/redirect.rake'
- 'lib/tasks/gitlab/graphql.rake'
- 'lib/tasks/gitlab/lfs/migrate.rake'
- 'lib/tasks/gitlab/metrics_exporter.rake'
- 'lib/tasks/gitlab/openapi.rake'
- 'lib/tasks/gitlab/packages/events.rake'
- 'lib/tasks/gitlab/packages/migrate.rake'
- 'lib/tasks/gitlab/pages.rake'
- 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake'
- 'lib/tasks/gitlab/terraform/migrate.rake'
- 'lib/tasks/gitlab/tw/codeowners.rake'
- 'lib/tasks/gitlab/x509/update.rake'
- 'lib/tasks/import.rake'
- 'lib/tasks/tokens.rake'
- 'qa/tasks/ci.rake'
- 'qa/tasks/webdrivers.rake'

8
.rubocop_todo/rspec/context_wording.yml
View file

@ -123,10 +123,8 @@ RSpec/ContextWording:
- 'ee/spec/features/groups/push_rules_spec.rb'
- 'ee/spec/features/groups/saml_enforcement_spec.rb'
- 'ee/spec/features/groups/saml_providers_spec.rb'
- 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb'
- 'ee/spec/features/groups/security/compliance_dashboards_spec.rb'
- 'ee/spec/features/groups/sso_spec.rb'
- 'ee/spec/features/groups/usage_quotas_spec.rb'
- 'ee/spec/features/groups_spec.rb'
- 'ee/spec/features/ide/user_commits_changes_spec.rb'
- 'ee/spec/features/ide/user_opens_ide_spec.rb'
@ -498,7 +496,6 @@ RSpec/ContextWording:
- 'ee/spec/models/ee/audit_event_spec.rb'
- 'ee/spec/models/ee/award_emoji_spec.rb'
- 'ee/spec/models/ee/ci/job_artifact_spec.rb'
- 'ee/spec/models/ee/event_collection_spec.rb'
- 'ee/spec/models/ee/event_spec.rb'
- 'ee/spec/models/ee/group_group_link_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
@ -1361,7 +1358,6 @@ RSpec/ContextWording:
- 'spec/features/projects/blobs/blob_show_spec.rb'
- 'spec/features/projects/blobs/edit_spec.rb'
- 'spec/features/projects/branches/user_views_branches_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/ci/lint_spec.rb'
- 'spec/features/projects/clusters_spec.rb'
- 'spec/features/projects/commit/comments/user_adds_comment_spec.rb'
@ -1571,7 +1567,6 @@ RSpec/ContextWording:
- 'spec/graphql/resolvers/group_milestones_resolver_spec.rb'
- 'spec/graphql/resolvers/group_packages_resolver_spec.rb'
- 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb'
- 'spec/graphql/resolvers/issues_resolver_spec.rb'
- 'spec/graphql/resolvers/kas/agent_configurations_resolver_spec.rb'
- 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb'
- 'spec/graphql/resolvers/last_commit_resolver_spec.rb'
@ -2401,7 +2396,6 @@ RSpec/ContextWording:
- 'spec/models/environment_spec.rb'
- 'spec/models/environment_status_spec.rb'
- 'spec/models/error_tracking/error_spec.rb'
- 'spec/models/event_collection_spec.rb'
- 'spec/models/event_spec.rb'
- 'spec/models/experiment_spec.rb'
- 'spec/models/external_pull_request_spec.rb'
@ -2777,7 +2771,6 @@ RSpec/ContextWording:
- 'spec/routing/project_routing_spec.rb'
- 'spec/rubocop/cop/gitlab/change_timezone_spec.rb'
- 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb'
- 'spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb'
- 'spec/rubocop/cop/gitlab/event_store_subscriber_spec.rb'
- 'spec/rubocop/cop/gitlab/feature_available_usage_spec.rb'
- 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb'
@ -2976,7 +2969,6 @@ RSpec/ContextWording:
- 'spec/services/members/destroy_service_spec.rb'
- 'spec/services/members/groups/creator_service_spec.rb'
- 'spec/services/members/projects/creator_service_spec.rb'
- 'spec/services/members/update_service_spec.rb'
- 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
- 'spec/services/merge_requests/after_create_service_spec.rb'
- 'spec/services/merge_requests/approval_service_spec.rb'

1
.rubocop_todo/rspec/empty_line_after_hook.yml
View file

@ -4,7 +4,6 @@ RSpec/EmptyLineAfterHook:
Exclude:
- 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb'
- 'ee/spec/controllers/projects/push_rules_controller_spec.rb'
- 'ee/spec/features/groups/usage_quotas_spec.rb'
- 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb'
- 'ee/spec/features/profiles/usage_quotas_spec.rb'
- 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb'

2
.rubocop_todo/rspec/expect_change.yml
View file

@ -293,7 +293,6 @@ RSpec/ExpectChange:
- 'ee/spec/services/security/orchestration/assign_service_spec.rb'
- 'ee/spec/services/security/override_uuids_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb'
- 'ee/spec/services/security/store_findings_metadata_service_spec.rb'
- 'ee/spec/services/security/store_scan_service_spec.rb'
- 'ee/spec/services/start_pull_mirroring_service_spec.rb'
- 'ee/spec/services/status_page/mark_for_publication_service_spec.rb'
@ -712,6 +711,7 @@ RSpec/ExpectChange:
- 'spec/services/draft_notes/destroy_service_spec.rb'
- 'spec/services/draft_notes/publish_service_spec.rb'
- 'spec/services/emails/create_service_spec.rb'
- 'spec/services/environments/create_for_build_service_spec.rb'
- 'spec/services/error_tracking/collect_error_service_spec.rb'
- 'spec/services/error_tracking/list_projects_service_spec.rb'
- 'spec/services/event_create_service_spec.rb'

80
.rubocop_todo/rspec/factory_bot/avoid_create.yml
View file

@ -1,7 +1,27 @@
---
RSpec/FactoryBot/AvoidCreate:
Details: grace period
Exclude:
- 'ee/spec/presenters/approval_rule_presenter_spec.rb'
- 'ee/spec/presenters/audit_event_presenter_spec.rb'
- 'ee/spec/presenters/ci/build_runner_presenter_spec.rb'
- 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb'
- 'ee/spec/presenters/ci/pipeline_presenter_spec.rb'
- 'ee/spec/presenters/dast/site_profile_presenter_spec.rb'
- 'ee/spec/presenters/ee/blob_presenter_spec.rb'
- 'ee/spec/presenters/ee/clusters/cluster_presenter_spec.rb'
- 'ee/spec/presenters/ee/instance_clusterable_presenter_spec.rb'
- 'ee/spec/presenters/ee/issue_presenter_spec.rb'
- 'ee/spec/presenters/ee/projects/security/configuration_presenter_spec.rb'
- 'ee/spec/presenters/epic_issue_presenter_spec.rb'
- 'ee/spec/presenters/epic_presenter_spec.rb'
- 'ee/spec/presenters/group_clusterable_presenter_spec.rb'
- 'ee/spec/presenters/label_presenter_spec.rb'
- 'ee/spec/presenters/merge_request_approver_presenter_spec.rb'
- 'ee/spec/presenters/merge_request_presenter_spec.rb'
- 'ee/spec/presenters/project_clusterable_presenter_spec.rb'
- 'ee/spec/presenters/subscription_presenter_spec.rb'
- 'ee/spec/presenters/vulnerability_presenter_spec.rb'
- 'ee/spec/presenters/web_hooks/group/hook_presenter_spec.rb'
- 'ee/spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb'
- 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb'
- 'ee/spec/serializers/audit_event_entity_spec.rb'
@ -11,7 +31,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/serializers/clusters/environment_entity_spec.rb'
- 'ee/spec/serializers/clusters/environment_serializer_spec.rb'
- 'ee/spec/serializers/dashboard_environment_entity_spec.rb'
- 'ee/spec/serializers/dashboard_environments_project_entity_spec.rb'
- 'ee/spec/serializers/dashboard_environments_serializer_spec.rb'
- 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb'
- 'ee/spec/serializers/dependency_entity_spec.rb'
@ -73,6 +92,62 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb'
- 'ee/spec/serializers/vulnerability_entity_spec.rb'
- 'ee/spec/serializers/vulnerability_note_entity_spec.rb'
- 'spec/presenters/alert_management/alert_presenter_spec.rb'
- 'spec/presenters/blob_presenter_spec.rb'
- 'spec/presenters/blobs/notebook_presenter_spec.rb'
- 'spec/presenters/ci/bridge_presenter_spec.rb'
- 'spec/presenters/ci/build_presenter_spec.rb'
- 'spec/presenters/ci/build_runner_presenter_spec.rb'
- 'spec/presenters/ci/group_variable_presenter_spec.rb'
- 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb'
- 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb'
- 'spec/presenters/ci/pipeline_presenter_spec.rb'
- 'spec/presenters/ci/stage_presenter_spec.rb'
- 'spec/presenters/ci/trigger_presenter_spec.rb'
- 'spec/presenters/ci/variable_presenter_spec.rb'
- 'spec/presenters/clusterable_presenter_spec.rb'
- 'spec/presenters/clusters/cluster_presenter_spec.rb'
- 'spec/presenters/commit_presenter_spec.rb'
- 'spec/presenters/commit_status_presenter_spec.rb'
- 'spec/presenters/deployments/deployment_presenter_spec.rb'
- 'spec/presenters/event_presenter_spec.rb'
- 'spec/presenters/gitlab/blame_presenter_spec.rb'
- 'spec/presenters/group_clusterable_presenter_spec.rb'
- 'spec/presenters/instance_clusterable_presenter_spec.rb'
- 'spec/presenters/issue_presenter_spec.rb'
- 'spec/presenters/label_presenter_spec.rb'
- 'spec/presenters/merge_request_presenter_spec.rb'
- 'spec/presenters/milestone_presenter_spec.rb'
- 'spec/presenters/packages/composer/packages_presenter_spec.rb'
- 'spec/presenters/packages/conan/package_presenter_spec.rb'
- 'spec/presenters/packages/detail/package_presenter_spec.rb'
- 'spec/presenters/packages/helm/index_presenter_spec.rb'
- 'spec/presenters/packages/npm/package_presenter_spec.rb'
- 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb'
- 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb'
- 'spec/presenters/packages/nuget/packages_versions_presenter_spec.rb'
- 'spec/presenters/packages/nuget/search_results_presenter_spec.rb'
- 'spec/presenters/packages/nuget/service_index_presenter_spec.rb'
- 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb'
- 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb'
- 'spec/presenters/pages_domain_presenter_spec.rb'
- 'spec/presenters/project_clusterable_presenter_spec.rb'
- 'spec/presenters/project_hook_presenter_spec.rb'
- 'spec/presenters/project_presenter_spec.rb'
- 'spec/presenters/projects/import_export/project_export_presenter_spec.rb'
- 'spec/presenters/projects/security/configuration_presenter_spec.rb'
- 'spec/presenters/projects/settings/deploy_keys_presenter_spec.rb'
- 'spec/presenters/prometheus_alert_presenter_spec.rb'
- 'spec/presenters/release_presenter_spec.rb'
- 'spec/presenters/releases/link_presenter_spec.rb'
- 'spec/presenters/search_service_presenter_spec.rb'
- 'spec/presenters/service_hook_presenter_spec.rb'
- 'spec/presenters/snippet_blob_presenter_spec.rb'
- 'spec/presenters/snippet_presenter_spec.rb'
- 'spec/presenters/terraform/modules_presenter_spec.rb'
- 'spec/presenters/tree_entry_presenter_spec.rb'
- 'spec/presenters/user_presenter_spec.rb'
- 'spec/presenters/web_hook_log_presenter_spec.rb'
- 'spec/serializers/access_token_entity_base_spec.rb'
- 'spec/serializers/analytics_build_entity_spec.rb'
- 'spec/serializers/analytics_build_serializer_spec.rb'
@ -192,7 +267,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/serializers/project_serializer_spec.rb'
- 'spec/serializers/prometheus_alert_entity_spec.rb'
- 'spec/serializers/release_serializer_spec.rb'
- 'spec/serializers/remote_mirror_entity_spec.rb'
- 'spec/serializers/review_app_setup_entity_spec.rb'
- 'spec/serializers/runner_entity_spec.rb'
- 'spec/serializers/serverless/domain_entity_spec.rb'

54
.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml Normal file
View file

@ -0,0 +1,54 @@
---
RSpec/FactoryBot/StrategyInCallback:
Details: grace period
Exclude:
- 'ee/spec/factories/ci/builds.rb'
- 'ee/spec/factories/ci/pipelines.rb'
- 'ee/spec/factories/dast_scanner_profiles.rb'
- 'ee/spec/factories/description_version.rb'
- 'ee/spec/factories/elastic/reindexing_tasks.rb'
- 'ee/spec/factories/epic_issues.rb'
- 'ee/spec/factories/geo/design_registry.rb'
- 'ee/spec/factories/geo_nodes.rb'
- 'ee/spec/factories/groups.rb'
- 'ee/spec/factories/merge_requests.rb'
- 'ee/spec/factories/namespaces.rb'
- 'ee/spec/factories/projects.rb'
- 'ee/spec/factories/protected_environments.rb'
- 'ee/spec/factories/users.rb'
- 'ee/spec/factories/vulnerabilities.rb'
- 'ee/spec/factories/vulnerabilities/external_issue_links.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/factories/vulnerabilities/issue_links.rb'
- 'ee/spec/factories/work_items.rb'
- 'spec/factories/alert_management/alerts.rb'
- 'spec/factories/ci/builds.rb'
- 'spec/factories/ci/pipelines.rb'
- 'spec/factories/ci/processable.rb'
- 'spec/factories/ci/runner_namespaces.rb'
- 'spec/factories/ci/runner_projects.rb'
- 'spec/factories/ci/runners.rb'
- 'spec/factories/clusters/clusters.rb'
- 'spec/factories/commits.rb'
- 'spec/factories/container_expiration_policies.rb'
- 'spec/factories/design_management/designs.rb'
- 'spec/factories/design_management/versions.rb'
- 'spec/factories/environments.rb'
- 'spec/factories/group_members.rb'
- 'spec/factories/groups.rb'
- 'spec/factories/integrations.rb'
- 'spec/factories/issues.rb'
- 'spec/factories/merge_requests.rb'
- 'spec/factories/ml/candidates.rb'
- 'spec/factories/namespaces.rb'
- 'spec/factories/packages/dependency_links.rb'
- 'spec/factories/packages/package_files.rb'
- 'spec/factories/packages/packages.rb'
- 'spec/factories/pool_repositories.rb'
- 'spec/factories/project_members.rb'
- 'spec/factories/projects.rb'
- 'spec/factories/releases.rb'
- 'spec/factories/resource_label_events.rb'
- 'spec/factories/terraform/state.rb'
- 'spec/factories/users.rb'
- 'spec/factories/work_items/parent_links.rb'

2
.rubocop_todo/rspec/file_path.yml
View file

@ -1,6 +1,5 @@
---
RSpec/FilePath:
Details: grace period
Exclude:
- 'ee/spec/frontend/fixtures/analytics/charts.rb'
- 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb'
@ -65,3 +64,4 @@ RSpec/FilePath:
- 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb'
- 'spec/services/ci/create_pipeline_service/rules_spec.rb'
- 'spec/services/ci/create_pipeline_service/tags_spec.rb'
- 'spec/services/ci/create_pipeline_service/variables_spec.rb'

1
.rubocop_todo/rspec/multiple_memoized_helpers.yml
View file

@ -1,6 +1,5 @@
---
RSpec/MultipleMemoizedHelpers:
Details: grace period
Exclude:
- 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb'
- 'ee/spec/finders/epics_finder_spec.rb'

1
.rubocop_todo/rspec/scattered_let.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
RSpec/ScatteredLet:
Details: grace period
Exclude:
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/features/groups/group_roadmap_spec.rb'

1
.rubocop_todo/rspec/timecop_travel.yml
View file

@ -1,5 +1,4 @@
---
RSpec/TimecopTravel:
Exclude:
- spec/workers/concerns/reenqueuer_spec.rb
- qa/spec/support/repeater_spec.rb

1
.rubocop_todo/style/accessor_grouping.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/AccessorGrouping:
Details: grace period
Exclude:
- 'app/finders/template_finder.rb'
- 'app/models/commit.rb'

1
.rubocop_todo/style/bare_percent_literals.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/BarePercentLiterals:
Details: grace period
Exclude:
- 'app/models/commit.rb'
- 'app/models/concerns/storage/legacy_namespace.rb'

63
.rubocop_todo/style/case_like_if.yml
View file

@ -1,63 +0,0 @@
---
# Cop supports --auto-correct.
Style/CaseLikeIf:
Details: grace period
Exclude:
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/groups/dependency_proxy/application_controller.rb'
- 'app/controllers/projects/labels_controller.rb'
- 'app/graphql/types/ci/job_need_union.rb'
- 'app/helpers/avatars_helper.rb'
- 'app/helpers/broadcast_messages_helper.rb'
- 'app/helpers/issues_helper.rb'
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/helpers/todos_helper.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/members/member_task.rb'
- 'app/models/namespace.rb'
- 'app/models/packages/go/module_version.rb'
- 'app/serializers/group_child_serializer.rb'
- 'app/services/google_cloud/generate_pipeline_service.rb'
- 'app/services/issuable/bulk_update_service.rb'
- 'app/services/todo_service.rb'
- 'app/services/user_project_access_changed_service.rb'
- 'ee/app/controllers/concerns/credentials_inventory_actions.rb'
- 'ee/app/finders/ee/notes_finder.rb'
- 'ee/app/finders/security/scan_execution_policies_finder.rb'
- 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb'
- 'ee/app/helpers/ee/branches_helper.rb'
- 'ee/app/services/epics/tree_reorder_service.rb'
- 'ee/app/services/merge_request_approval_settings/update_service.rb'
- 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb'
- 'ee/spec/config/metrics/every_metric_definition_spec.rb'
- 'ee/spec/features/boards/user_adds_lists_to_board_spec.rb'
- 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb'
- 'ee/spec/features/projects/custom_projects_template_spec.rb'
- 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb'
- 'lib/api/helpers/label_helpers.rb'
- 'lib/gitlab/ci/ansi2html.rb'
- 'lib/gitlab/ci/ansi2json/converter.rb'
- 'lib/gitlab/ci/build/image.rb'
- 'lib/gitlab/identifier.rb'
- 'lib/gitlab/issues/rebalancing/state.rb'
- 'lib/gitlab/pagination/gitaly_keyset_pager.rb'
- 'lib/gitlab/utils.rb'
- 'lib/gitlab/utils/strong_memoize.rb'
- 'qa/qa/git/repository.rb'
- 'qa/qa/scenario/bootable.rb'
- 'spec/features/boards/user_adds_lists_to_board_spec.rb'
- 'spec/lib/gitlab/auth/auth_finders_spec.rb'
- 'spec/lib/gitlab/database/load_balancing_spec.rb'
- 'spec/lib/omni_auth/strategies/jwt_spec.rb'
- 'spec/models/concerns/sha_attribute_spec.rb'
- 'spec/models/preloaders/labels_preloader_spec.rb'
- 'spec/requests/api/personal_access_tokens_spec.rb'
- 'spec/requests/api/rubygem_packages_spec.rb'
- 'spec/requests/api/terraform/modules/v1/packages_spec.rb'
- 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb'
- 'spec/services/resource_events/change_state_service_spec.rb'
- 'spec/support/helpers/filter_spec_helper.rb'
- 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb'
- 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb'

1
.rubocop_todo/style/empty_method.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/EmptyMethod:
Details: grace period
Exclude:
- 'app/controllers/admin/application_settings/appearances_controller.rb'
- 'app/controllers/admin/applications_controller.rb'

1
.rubocop_todo/style/explicit_block_argument.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/ExplicitBlockArgument:
Details: grace period
Exclude:
- 'app/controllers/admin/background_migrations_controller.rb'
- 'app/controllers/admin/batched_jobs_controller.rb'

2
.rubocop_todo/style/guard_clause.yml
View file

@ -693,7 +693,6 @@ Style/GuardClause:
- 'qa/qa/specs/helpers/feature_flag.rb'
- 'qa/qa/vendor/jenkins/job.rb'
- 'rubocop/cop/api/grape_array_missing_coerce.rb'
- 'rubocop/cop/gitlab/duplicate_spec_location.rb'
- 'rubocop/cop/gitlab/event_store_subscriber.rb'
- 'rubocop/cop/gitlab/finder_with_find_by.rb'
- 'rubocop/cop/gitlab/keys_first_and_values_first.rb'
@ -717,7 +716,6 @@ Style/GuardClause:
- 'spec/support/capybara.rb'
- 'spec/support/database/prevent_cross_joins.rb'
- 'spec/support/helpers/access_matchers_helpers.rb'
- 'spec/support/helpers/bare_repo_operations.rb'
- 'spec/support/helpers/capybara_helpers.rb'
- 'spec/support/helpers/dropzone_helper.rb'
- 'spec/support/helpers/fake_blob_helpers.rb'

3
.rubocop_todo/style/if_unless_modifier.yml
View file

@ -309,7 +309,6 @@ Style/IfUnlessModifier:
- 'app/services/issues/update_service.rb'
- 'app/services/lfs/lock_file_service.rb'
- 'app/services/members/destroy_service.rb'
- 'app/services/members/update_service.rb'
- 'app/services/merge_requests/add_context_service.rb'
- 'app/services/merge_requests/base_service.rb'
- 'app/services/merge_requests/build_service.rb'
@ -743,7 +742,6 @@ Style/IfUnlessModifier:
- 'ee/spec/support/http_io/http_io_helpers.rb'
- 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb'
- 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb'
- 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb'
- 'ee/spec/workers/elastic/migration_worker_spec.rb'
- 'lib/api/api_guard.rb'
- 'lib/api/boards_responses.rb'
@ -1202,7 +1200,6 @@ Style/IfUnlessModifier:
- 'spec/views/groups/edit.html.haml_spec.rb'
- 'spec/views/profiles/keys/_key.html.haml_spec.rb'
- 'spec/views/projects/edit.html.haml_spec.rb'
- 'spec/views/shared/access_tokens/_table.html.haml_spec.rb'
- 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/lib/tooling/find_codeowners.rb'

2
.rubocop_todo/style/keyword_parameters_order.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/KeywordParametersOrder:
Details: grace period
Exclude:
- 'app/controllers/concerns/product_analytics_tracking.rb'
- 'app/finders/group_descendants_finder.rb'
@ -50,7 +49,6 @@ Style/KeywordParametersOrder:
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb'
- 'qa/spec/runtime/env_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/graphql/types/ci/pipeline_counts_type_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'

295
.rubocop_todo/style/lambda.yml
View file

@ -1,273 +1,82 @@
---
# Cop supports --auto-correct.
# Cop supports --autocorrect.
Style/Lambda:
# Offense count: 653
# Temporarily disabled due to too many offenses
Enabled: false
Details: grace period
Exclude:
- 'app/controllers/concerns/notes_actions.rb'
- 'app/controllers/concerns/spammable_actions/captcha_check/rest_api_actions_support.rb'
- 'app/controllers/projects/issues_controller.rb'
- 'app/controllers/search_controller.rb'
- 'app/graphql/mutations/container_repositories/destroy_tags.rb'
- 'app/graphql/mutations/design_management/delete.rb'
- 'app/graphql/types/permission_types/base_permission_type.rb'
- 'app/models/analytics/cycle_analytics/issue_stage_event.rb'
- 'app/models/analytics/cycle_analytics/merge_request_stage_event.rb'
- 'app/models/bulk_imports/tracker.rb'
- 'app/models/ci/build.rb'
- 'app/models/ci/deleted_object.rb'
- 'app/models/ci/instance_variable.rb'
- 'app/models/ci/job_artifact.rb'
- 'app/models/ci/namespace_mirror.rb'
- 'app/models/ci/pending_build.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/ci/processable.rb'
- 'app/models/ci/runner.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/concerns/application_status.rb'
- 'app/models/commit_status.rb'
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'app/models/concerns/approvable_base.rb'
- 'app/models/concerns/atomic_internal_id.rb'
- 'app/models/concerns/ci/has_status.rb'
- 'app/models/concerns/clusters/agents/authorization_config_scopes.rb'
- 'app/models/concerns/has_environment_scope.rb'
- 'app/models/concerns/has_wiki_page_meta_attributes.rb'
- 'app/models/concerns/id_in_ordered.rb'
- 'app/models/concerns/integrations/has_issue_tracker_fields.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/issue_resource_event.rb'
- 'app/models/concerns/milestoneable.rb'
- 'app/models/concerns/mirror_authentication.rb'
- 'app/models/concerns/packages/debian/component_file.rb'
- 'app/models/concerns/reactive_caching.rb'
- 'app/models/concerns/timebox.rb'
- 'app/models/container_repository.rb'
- 'app/models/custom_emoji.rb'
- 'app/models/deployment.rb'
- 'app/models/design_management/action.rb'
- 'app/models/design_management/design.rb'
- 'app/models/design_management/version.rb'
- 'app/models/environment.rb'
- 'app/models/event.rb'
- 'app/models/group.rb'
- 'app/models/group_deploy_key.rb'
- 'app/models/group_group_link.rb'
- 'app/models/hooks/web_hook.rb'
- 'app/models/identity.rb'
- 'app/models/import_failure.rb'
- 'app/models/integrations/zentao_tracker_data.rb'
- 'app/models/internal_id.rb'
- 'app/models/issue.rb'
- 'app/models/issue/metrics.rb'
- 'app/models/jira_connect_installation.rb'
- 'app/models/label.rb'
- 'app/models/label_link.rb'
- 'app/models/loose_foreign_keys/deleted_record.rb'
- 'app/models/member.rb'
- 'app/models/members/project_member.rb'
- 'app/models/merge_request.rb'
- 'app/models/merge_request/cleanup_schedule.rb'
- 'app/models/merge_request_diff.rb'
- 'app/models/merge_request_diff_file.rb'
- 'app/models/merge_requests_closing_issues.rb'
- 'app/models/milestone.rb'
- 'app/models/namespace.rb'
- 'app/models/note.rb'
- 'app/models/note_diff_file.rb'
- 'app/models/notification_setting.rb'
- 'app/models/onboarding/progress.rb'
- 'app/models/operations/feature_flags/user_list.rb'
- 'app/models/packages/package.rb'
- 'app/models/packages/package_file.rb'
- 'app/models/pages_domain.rb'
- 'app/models/product_analytics_event.rb'
- 'app/models/programming_language.rb'
- 'app/models/project.rb'
- 'app/controllers/concerns/project_unauthorized.rb'
- 'app/controllers/profiles/two_factor_auths_controller.rb'
- 'app/models/concerns/featurable.rb'
- 'app/models/project_feature.rb'
- 'app/models/project_feature_usage.rb'
- 'app/models/projects/topic.rb'
- 'app/models/prometheus_alert_event.rb'
- 'app/models/raw_usage_data.rb'
- 'app/models/redirect_route.rb'
- 'app/models/release.rb'
- 'app/models/remote_mirror.rb'
- 'app/models/repository_language.rb'
- 'app/models/snippet.rb'
- 'app/models/timelog.rb'
- 'app/models/todo.rb'
- 'app/models/user.rb'
- 'app/models/users/in_product_marketing_email.rb'
- 'app/serializers/ci/daily_build_group_report_result_entity.rb'
- 'app/serializers/group_child_entity.rb'
- 'app/serializers/issuable_sidebar_basic_entity.rb'
- 'app/serializers/merge_request_sidebar_basic_entity.rb'
- 'app/services/issues/referenced_merge_requests_service.rb'
- 'config/initializers/deprecations.rb'
- 'config/initializers/rspec_profiling.rb'
- 'config/application.rb'
- 'config/initializers/0_license.rb'
- 'config/initializers/0_log_deprecations.rb'
- 'config/initializers/action_cable.rb'
- 'config/initializers/gitlab_experiment.rb'
- 'config/initializers/lograge.rb'
- 'config/routes.rb'
- 'config/routes/dashboard.rb'
- 'config/routes/group.rb'
- 'config/routes/issues.rb'
- 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb'
- 'db/post_migrate/20210513155546_backfill_nuget_temporary_packages_to_processing_status.rb'
- 'db/post_migrate/20210823132600_remove_duplicate_dast_site_tokens.rb'
- 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb'
- 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb'
- 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb'
- 'ee/app/models/analytics/devops_adoption/snapshot.rb'
- 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/boards/epic_board_position.rb'
- 'ee/app/models/boards/epic_user_preference.rb'
- 'ee/app/models/ci/minutes/project_monthly_usage.rb'
- 'ee/app/models/concerns/ee/protected_ref.rb'
- 'ee/app/models/concerns/geo/replicable_model.rb'
- 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb'
- 'ee/app/models/dast/profile.rb'
- 'ee/app/models/dast_site_validation.rb'
- 'ee/app/models/dora/daily_metrics.rb'
- 'ee/app/models/ee/ci/build.rb'
- 'ee/app/models/ee/ci/daily_build_group_report_result.rb'
- 'ee/app/models/ee/ci/job_artifact.rb'
- 'ee/app/models/ee/ci/pipeline.rb'
- 'ee/app/models/ee/environment.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/group_member.rb'
- 'ee/app/models/ee/identity.rb'
- 'ee/app/models/ee/issue.rb'
- 'ee/app/models/ee/iteration.rb'
- 'ee/app/models/ee/label.rb'
- 'ee/app/models/ee/member.rb'
- 'ee/app/models/ee/merge_request.rb'
- 'ee/app/models/ee/namespace.rb'
- 'ee/app/models/ee/namespace_ci_cd_setting.rb'
- 'ee/app/models/ee/note.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/models/gitlab_subscription.rb'
- 'ee/app/models/incident_management/oncall_rotation.rb'
- 'ee/app/models/incident_management/oncall_shift.rb'
- 'ee/app/models/iterations/cadence.rb'
- 'ee/app/models/merge_request_block.rb'
- 'ee/app/models/merge_requests/external_status_check.rb'
- 'ee/app/models/merge_train.rb'
- 'ee/app/models/protected_environment.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/models/security/finding.rb'
- 'ee/app/models/security/orchestration_policy_configuration.rb'
- 'ee/app/models/security/orchestration_policy_rule_schedule.rb'
- 'ee/app/models/security/scan.rb'
- 'ee/app/models/security/training_provider.rb'
- 'ee/app/models/software_license_policy.rb'
- 'ee/app/models/vulnerabilities/feedback.rb'
- 'ee/app/models/vulnerabilities/finding.rb'
- 'ee/app/models/vulnerabilities/historical_statistic.rb'
- 'ee/app/models/vulnerabilities/read.rb'
- 'ee/app/models/vulnerabilities/scanner.rb'
- 'ee/app/controllers/concerns/ee/routable_actions/sso_enforcement_redirect.rb'
- 'ee/app/serializers/ee/group_child_entity.rb'
- 'ee/lib/ee/api/entities/application_setting.rb'
- 'ee/lib/ee/api/entities/geo_node_status.rb'
- 'ee/lib/ee/api/entities/group.rb'
- 'ee/app/services/ee/issues/export_csv_service.rb'
- 'ee/lib/ee/api/entities/group_detail.rb'
- 'ee/lib/ee/api/entities/group_push_rule.rb'
- 'ee/lib/ee/api/entities/project.rb'
- 'ee/lib/ee/api/entities/vulnerability_issue_link.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/banzai/filter/sanitization_filter.rb'
- 'ee/lib/ee/gitlab/checks/diff_check.rb'
- 'ee/lib/elastic/latest/application_class_proxy.rb'
- 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb'
- 'ee/spec/migrations/backfill_delayed_group_deletion_spec.rb'
- 'ee/spec/migrations/remove_schedule_and_status_null_constraints_from_pending_escalations_alert_spec.rb'
- 'ee/spec/elastic_integration/global_search_spec.rb'
- 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb'
- 'ee/spec/services/ee/groups/autocomplete_service_spec.rb'
- 'ee/spec/services/ee/notes/create_service_spec.rb'
- 'ee/spec/support/helpers/elasticsearch_helpers.rb'
- 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb'
- 'ee/spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_ee_instance_shared_examples.rb'
- 'lib/api/ci/jobs.rb'
- 'lib/api/ci/pipelines.rb'
- 'lib/api/entities/group_detail.rb'
- 'lib/api/entities/issue.rb'
- 'lib/api/entities/label.rb'
- 'lib/api/entities/merge_request.rb'
- 'lib/api/entities/project.rb'
- 'lib/api/entities/project_export_status.rb'
- 'lib/api/feature_flags_user_lists.rb'
- 'lib/container_registry/base_client.rb'
- 'lib/container_registry/client.rb'
- 'lib/csv_builder.rb'
- 'lib/event_filter.rb'
- 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb'
- 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/ci/config/entry/includes.rb'
- 'lib/gitlab/ci/config/entry/trigger.rb'
- 'lib/gitlab/config/entry/validatable.rb'
- 'lib/gitlab/database/background_migration/batched_migration.rb'
- 'lib/gitlab/database/background_migration_job.rb'
- 'lib/gitlab/database/postgres_foreign_key.rb'
- 'lib/gitlab/database/postgres_index.rb'
- 'lib/gitlab/database/postgres_partition.rb'
- 'lib/gitlab/database/postgres_partitioned_table.rb'
- 'lib/gitlab/gl_repository.rb'
- 'lib/gitlab/import_export/import_failure_service.rb'
- 'lib/gitlab/merge_requests/commit_message_generator.rb'
- 'lib/gitlab/seeder.rb'
- 'lib/api/validations/types/comma_separated_to_array.rb'
- 'lib/api/validations/types/comma_separated_to_integer_array.rb'
- 'lib/api/validations/types/hash_of_integer_values.rb'
- 'lib/api/validations/validators/check_assignees_count.rb'
- 'lib/banzai/filter/ascii_doc_sanitization_filter.rb'
- 'lib/banzai/filter/base_sanitization_filter.rb'
- 'lib/banzai/filter/sanitization_filter.rb'
- 'lib/gitlab/action_cable/request_store_callbacks.rb'
- 'lib/gitlab/checks/diff_check.rb'
- 'lib/gitlab/database/load_balancing/action_cable_callbacks.rb'
- 'lib/gitlab/memory/watchdog/configurator.rb'
- 'lib/gitlab/middleware/rack_multipart_tempfile_factory.rb'
- 'lib/gitlab/omniauth_initializer.rb'
- 'lib/gitlab/prometheus/queries/query_additional_metrics.rb'
- 'lib/gitlab/rack_attack.rb'
- 'lib/gitlab/sidekiq_config/worker_matcher.rb'
- 'lib/gitlab/sidekiq_signals.rb'
- 'lib/gitlab/utils/measuring.rb'
- 'lib/gitlab/visibility_level.rb'
- 'rubocop/cop/rspec/modify_sidekiq_middleware.rb'
- 'rubocop/cop/rspec/timecop_freeze.rb'
- 'rubocop/cop/rspec/timecop_travel.rb'
- 'lib/gitlab/sidekiq_middleware.rb'
- 'lib/gitlab/utils/usage_data.rb'
- 'qa/qa/page/base.rb'
- 'qa/qa/runtime/allure_report.rb'
- 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb'
- 'qa/qa/support/api.rb'
- 'rubocop/cop/inject_enterprise_edition_module.rb'
- 'rubocop/cop/rspec/have_gitlab_http_status.rb'
- 'spec/controllers/concerns/routable_actions_spec.rb'
- 'spec/deprecation_toolkit_env.rb'
- 'spec/factories/design_management/designs.rb'
- 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb'
- 'spec/graphql/resolvers/concerns/resolves_groups_spec.rb'
- 'spec/features/groups/dependency_proxy_for_containers_spec.rb'
- 'spec/graphql/types/base_object_spec.rb'
- 'spec/lib/gitlab/action_cable/request_store_callbacks_spec.rb'
- 'spec/lib/gitlab/cross_project_access/class_methods_spec.rb'
- 'spec/lib/gitlab/database/consistency_spec.rb'
- 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb'
- 'spec/lib/gitlab/database/load_balancing_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb'
- 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb'
- 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb'
- 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb'
- 'spec/migrations/20210722150102_operations_feature_flags_correct_flexible_rollout_values_spec.rb'
- 'spec/migrations/20210804150320_create_base_work_item_types_spec.rb'
- 'spec/migrations/20210819145000_drop_temporary_columns_and_triggers_for_ci_builds_runner_session_spec.rb'
- 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb'
- 'spec/migrations/20210902144144_drop_temporary_columns_and_triggers_for_ci_build_needs_spec.rb'
- 'spec/migrations/20210906100316_drop_temporary_columns_and_triggers_for_ci_build_trace_chunks_spec.rb'
- 'spec/migrations/20210906130643_drop_temporary_columns_and_triggers_for_taggings_spec.rb'
- 'spec/migrations/20210907013944_cleanup_bigint_conversion_for_ci_builds_metadata_spec.rb'
- 'spec/migrations/20210915022415_cleanup_bigint_conversion_for_ci_builds_spec.rb'
- 'spec/migrations/20210922021816_drop_int4_columns_for_ci_job_artifacts_spec.rb'
- 'spec/migrations/20210922025631_drop_int4_column_for_ci_sources_pipelines_spec.rb'
- 'spec/migrations/20210922082019_drop_int4_column_for_events_spec.rb'
- 'spec/migrations/20210922091402_drop_int4_column_for_push_event_payloads_spec.rb'
- 'spec/migrations/20211126115449_encrypt_static_objects_external_storage_auth_token_spec.rb'
- 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb'
- 'spec/migrations/20220120094340_drop_position_from_security_findings_spec.rb'
- 'spec/migrations/20220128155814_fix_approval_rules_code_owners_rule_type_index_spec.rb'
- 'spec/migrations/20220305223212_add_security_training_providers_spec.rb'
- 'spec/migrations/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints_spec.rb'
- 'spec/migrations/generate_customers_dot_jwt_signing_key_spec.rb'
- 'spec/migrations/insert_ci_daily_pipeline_schedule_triggers_plan_limits_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb'
- 'spec/migrations/remove_schedule_and_status_from_pending_alert_escalations_spec.rb'
- 'spec/models/ability_spec.rb'
- 'spec/models/broadcast_message_spec.rb'
- 'spec/models/concerns/participable_spec.rb'
- 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb'
- 'spec/lib/gitlab/path_regex_spec.rb'
- 'spec/services/groups/autocomplete_service_spec.rb'
- 'spec/services/notes/create_service_spec.rb'
- 'spec/services/issues/referenced_merge_requests_service_spec.rb'
- 'spec/services/projects/autocomplete_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb'
- 'spec/support/helpers/email_helpers.rb'
- 'spec/support/helpers/reference_parser_helpers.rb'
- 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb'
- 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
- 'spec/workers/process_commit_worker_spec.rb'

28
.rubocop_todo/style/next.yml
View file

@ -2,32 +2,4 @@
# Cop supports --auto-correct.
Style/Next:
Exclude:
- 'app/models/concerns/integrations/slack_mattermost_notifier.rb'
- 'app/validators/nested_attributes_duplicates_validator.rb'
- 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb'
- 'ee/db/fixtures/development/20_vulnerabilities.rb'
- 'ee/lib/ee/audit/protected_branches_changes_auditor.rb'
- 'ee/lib/gitlab/elastic/search_results.rb'
- 'ee/lib/system_check/geo/authorized_keys_check.rb'
- 'lib/backup/manager.rb'
- 'lib/banzai/filter/external_link_filter.rb'
- 'lib/banzai/filter/footnote_filter.rb'
- 'lib/banzai/filter/kroki_filter.rb'
- 'lib/banzai/filter/math_filter.rb'
- 'lib/banzai/filter/plantuml_filter.rb'
- 'lib/banzai/filter/table_of_contents_filter.rb'
- 'lib/gitlab/background_migration/encrypt_static_object_token.rb'
- 'lib/gitlab/database.rb'
- 'lib/gitlab/fogbugz_import/importer.rb'
- 'lib/gitlab/gitaly_client/repository_service.rb'
- 'lib/gitlab/import_export/attributes_permitter.rb'
- 'lib/gitlab/import_export/base/relation_object_saver.rb'
- 'lib/gitlab/metrics/samplers/base_sampler.rb'
- 'lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy.rb'
- 'lib/gitlab/reference_extractor.rb'
- 'lib/tasks/gitlab/assets.rake'
- 'lib/tasks/gitlab/db/validate_config.rake'
- 'scripts/perf/query_limiting_report.rb'
- 'scripts/qa/quarantine-types-check'
- 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb'
- 'spec/presenters/packages/npm/package_presenter_spec.rb'

1
.rubocop_todo/style/numeric_literal_prefix.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/NumericLiteralPrefix:
Details: grace period
Exclude:
- 'app/models/container_repository.rb'
- 'app/services/packages/debian/generate_distribution_key_service.rb'

1
.rubocop_todo/style/percent_literal_delimiters.yml
View file

@ -696,7 +696,6 @@ Style/PercentLiteralDelimiters:
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'
- 'spec/features/projects/active_tabs_spec.rb'
- 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/environments/environment_spec.rb'
- 'spec/features/projects/integrations/user_activates_jira_spec.rb'
- 'spec/features/projects/jobs_spec.rb'

1
.rubocop_todo/style/redundant_begin.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/RedundantBegin:
Details: grace period
Exclude:
- 'app/controllers/concerns/membership_actions.rb'
- 'app/controllers/concerns/metrics_dashboard.rb'

79
.rubocop_todo/style/redundant_interpolation.yml
View file

@ -94,83 +94,4 @@ Style/RedundantInterpolation:
- 'qa/qa/tools/generate_perf_testdata.rb'
- 'scripts/perf/gc/print_gc_stats.rb'
- 'scripts/qa/testcases-check'
- 'spec/controllers/admin/integrations_controller_spec.rb'
- 'spec/features/commits_spec.rb'
- 'spec/features/issues/user_edits_issue_spec.rb'
- 'spec/features/merge_request/user_scrolls_to_note_on_load_spec.rb'
- 'spec/features/merge_request/user_sees_deployment_widget_spec.rb'
- 'spec/features/one_trust_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
- 'spec/features/projects/jobs/user_browses_jobs_spec.rb'
- 'spec/graphql/resolvers/container_repositories_resolver_spec.rb'
- 'spec/helpers/environments_helper_spec.rb'
- 'spec/helpers/snippets_helper_spec.rb'
- 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb'
- 'spec/lib/api/validations/validators/git_ref_spec.rb'
- 'spec/lib/api/validations/validators/limit_spec.rb'
- 'spec/lib/backup/database_backup_error_spec.rb'
- 'spec/lib/backup/file_backup_error_spec.rb'
- 'spec/lib/banzai/filter/autolink_filter_spec.rb'
- 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
- 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb'
- 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb'
- 'spec/lib/feature_spec.rb'
- 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/ci/config/entry/job_spec.rb'
- 'spec/lib/gitlab/ci/config/entry/processable_spec.rb'
- 'spec/lib/gitlab/ci/reports/test_suite_spec.rb'
- 'spec/lib/gitlab/database/batch_count_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb'
- 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb'
- 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb'
- 'spec/lib/gitlab/metrics/dashboard/url_spec.rb'
- 'spec/lib/gitlab/redis/multi_store_spec.rb'
- 'spec/lib/grafana/client_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/clusters/platforms/kubernetes_spec.rb'
- 'spec/models/diff_discussion_spec.rb'
- 'spec/models/namespace_spec.rb'
- 'spec/presenters/project_presenter_spec.rb'
- 'spec/rack_servers/configs/config.ru'
- 'spec/requests/api/alert_management_alerts_spec.rb'
- 'spec/requests/api/markdown_spec.rb'
- 'spec/requests/api/merge_requests_spec.rb'
- 'spec/requests/api/metrics/dashboard/annotations_spec.rb'
- 'spec/requests/api/tags_spec.rb'
- 'spec/requests/api/terraform/state_spec.rb'
- 'spec/requests/projects/google_cloud/deployments_controller_spec.rb'
- 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb'
- 'spec/routing/project_routing_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
- 'spec/services/groups/transfer_service_spec.rb'
- 'spec/services/members/invite_service_spec.rb'
- 'spec/services/todo_service_spec.rb'
- 'spec/services/todos/destroy/entity_leave_service_spec.rb'
- 'spec/services/users/approve_service_spec.rb'
- 'spec/services/users/ban_service_spec.rb'
- 'spec/services/users/reject_service_spec.rb'
- 'spec/services/users/unban_service_spec.rb'
- 'spec/support/google_api/cloud_platform_helpers.rb'
- 'spec/support/helpers/features/releases_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- 'spec/support/matchers/exceed_query_limit.rb'
- 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb'
- 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb'
- 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb'
- 'spec/support/shared_examples/mailers/notify_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/issues_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/services/users/dismiss_user_callout_service_shared_examples.rb'
- 'spec/support_specs/graphql/arguments_spec.rb'
- 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
- 'tooling/rspec_flaky/flaky_example.rb'

1
.rubocop_todo/style/single_argument_dig.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/SingleArgumentDig:
Details: grace period
Exclude:
- 'app/graphql/resolvers/namespace_projects_resolver.rb'
- 'app/models/ci/build.rb'

1
.rubocop_todo/style/sole_nested_conditional.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/SoleNestedConditional:
Details: grace period
Exclude:
- 'app/controllers/admin/application_settings_controller.rb'
- 'app/controllers/ldap/omniauth_callbacks_controller.rb'

4
.rubocop_todo/style/special_global_vars.yml
View file

@ -1,4 +0,0 @@
---
# Cop supports --auto-correct.
Style/SpecialGlobalVars:
Details: grace period

2
.rubocop_todo/style/string_concatenation.yml
View file

@ -100,7 +100,6 @@ Style/StringConcatenation:
- 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb'
- 'ee/spec/tasks/gitlab/license_rake_spec.rb'
- 'lib/api/entities/tree_object.rb'
- 'lib/api/go_proxy.rb'
- 'lib/api/internal/kubernetes.rb'
- 'lib/backup/files.rb'
- 'lib/backup/manager.rb'
@ -316,7 +315,6 @@ Style/StringConcatenation:
- 'spec/services/verify_pages_domain_service_spec.rb'
- 'spec/support/capybara.rb'
- 'spec/support/helpers/ci_artifact_metadata_generator.rb'
- 'spec/support/helpers/git_helpers.rb'
- 'spec/support/helpers/gitaly_setup.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'

1
.rubocop_todo/style/string_literals_in_interpolation.yml
View file

@ -1,7 +1,6 @@
---
# Cop supports --auto-correct.
Style/StringLiteralsInInterpolation:
Details: grace period
Exclude:
- 'app/graphql/mutations/base_mutation.rb'
- 'app/helpers/colors_helper.rb'

Some files were not shown because too many files have changed in this diff Show more