diff --git a/.eslintrc.yml b/.eslintrc.yml index 0b242e4cb9..ae0d461092 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -28,11 +28,11 @@ rules: import/no-unresolved: - error - ignore: - # In FOSS, these import paths are rewritten using - # NormalModuleReplacementPlugin, which import/no-unresolved doesn't - # consider. See - # https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89831. - - '^(ee|jh)_component/' + # In FOSS, these import paths are rewritten using + # NormalModuleReplacementPlugin, which import/no-unresolved doesn't + # consider. See + # https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89831. + - '^(ee|jh)_component/' # Disabled for now, to make the airbnb-base 12.1.0 -> 13.1.0 update smoother no-else-return: - error @@ -48,12 +48,12 @@ rules: '@gitlab/vue-no-new-non-primitive-in-template': - error - allowNames: - - 'class(es)?$' - - '^style$' - - '^to$' - - '^$' - - '^variables$' - - 'attrs?$' + - 'class(es)?$' + - '^style$' + - '^to$' + - '^$' + - '^variables$' + - 'attrs?$' no-param-reassign: - error - props: true @@ -117,6 +117,11 @@ rules: message: 'Migrate to GlSkeletonLoader, or import GlDeprecatedSkeletonLoading.' - selector: ImportSpecifier[imported.name='GlSafeHtmlDirective'] message: 'Use directive at ~/vue_shared/directives/safe_html.js instead.' + no-restricted-imports: + - error + - paths: + - name: mousetrap + message: 'Import { Mousetrap } from ~/lib/mousetrap instead.' # See https://gitlab.com/gitlab-org/gitlab/-/issues/360551 vue/multi-word-component-names: off unicorn/prefer-dom-node-dataset: @@ -131,7 +136,7 @@ rules: methods: 'sanitize' overrides: - files: - - '{,ee/,jh/}spec/frontend*/**/*' + - '{,ee/,jh/}spec/frontend*/**/*' rules: '@gitlab/require-i18n-strings': off '@gitlab/no-runtime-template-compiler': off @@ -148,6 +153,8 @@ overrides: message: 'Prefer explicit waitForPromises (or equivalent), or jest.runAllTimers (or equivalent) to vague setImmediate calls.' - selector: ImportSpecifier[imported.name='GlSkeletonLoading'] message: 'Migrate to GlSkeletonLoader, or import GlDeprecatedSkeletonLoading.' + - selector: CallExpression[arguments.length=1][arguments.0.type='Literal'] CallExpression[callee.property.name='toBe'] CallExpression[callee.property.name='attributes'][arguments.length=1][arguments.0.value='disabled'] + message: Avoid asserting disabled attribute exact value, because Vue.js 2 and Vue.js 3 renders it differently. Use toBeDefined / toBeUndefined instead no-unsanitized/method: off no-unsanitized/property: off - files: @@ -193,6 +200,6 @@ overrides: '@graphql-eslint/no-unused-fragments': error '@graphql-eslint/no-duplicate-fields': error - files: - - '{,ee/}spec/contracts/consumer/**/*' + - '{,ee/}spec/contracts/consumer/**/*' rules: '@gitlab/require-i18n-strings': off diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 86cc79ab64..9b9b217126 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -165,6 +165,7 @@ variables: RSPEC_PACKED_TESTS_MAPPING_PATH: crystalball/packed-mapping.json RSPEC_PROFILING_FOLDER_PATH: rspec/profiling RSPEC_TESTS_MAPPING_PATH: crystalball/mapping.json + RSPEC_FAST_QUARANTINE_LOCAL_PATH: rspec/fast_quarantine-gitlab.txt TMP_TEST_FOLDER: "${CI_PROJECT_DIR}/tmp/tests" TMP_TEST_GITLAB_WORKHORSE_PATH: "${TMP_TEST_FOLDER}/${GITLAB_WORKHORSE_FOLDER}" @@ -174,7 +175,6 @@ variables: CACHE_CLASSES: "true" CHECK_PRECOMPILED_ASSETS: "true" FF_USE_FASTZIP: "true" - SKIP_FLAKY_TESTS_AUTOMATICALLY: "false" RETRY_FAILED_TESTS_IN_NEW_PROCESS: "true" # Run with decomposed databases by default DECOMPOSED_DB: "true" diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index e58dd1780b..0d6bf442a9 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -2,16 +2,17 @@ # project here: https://gitlab.com/gitlab-org/gitlab/-/project_members # As described in https://docs.gitlab.com/ee/user/project/code_owners.html -* @gitlab-org/maintainers/rails-backend @gitlab-org/maintainers/frontend @gitlab-org/maintainers/database @gl-quality/qe-maintainers @gl-quality/tooling-maintainers @gitlab-org/delivery @gitlab-org/maintainers/cicd-templates @nolith @jacobvosmaer-gitlab @gitlab-org/tw-leadership +* @gitlab-org/maintainers/rails-backend @gitlab-org/maintainers/frontend @gitlab-org/maintainers/database @gl-quality/qe-maintainers @gl-quality/tooling-maintainers @gitlab-org/delivery @gitlab-org/maintainers/cicd-templates @nolith @gitlab-org/tw-leadership -CODEOWNERS @gitlab-org/development-leaders @gitlab-org/tw-leadership -docs/CODEOWNERS @gitlab-org/development-leaders @gitlab-org/tw-leadership .gitlab/CODEOWNERS @gitlab-org/development-leaders @gitlab-org/tw-leadership ## Allows release tooling to update the Gitaly Version GITALY_SERVER_VERSION @project_278964_bot6 @gitlab-org/maintainers/rails-backend @gitlab-org/delivery ## Files that are excluded from required approval +## These rules override the * rule above, so that changes to docs and templates +## can be merged by any user who has maintainer rights, but is not included in +## the * rule (usually technical writers). /.gitlab/issue_templates/*.md /.gitlab/merge_request_templates/*.md /doc/*.md @@ -21,9 +22,10 @@ GITALY_SERVER_VERSION @project_278964_bot6 @gitlab-org/maintainers/rails-backend /data/deprecations/*.yml /data/removals/**/*.yml -## Technical writing files that do need approval -/data/deprecations/templates/ @marcel.amirault @gitlab-org/tw-leadership @sarahgerman -/data/removals/templates/ @marcel.amirault @gitlab-org/tw-leadership @sarahgerman +## Technical writing files that do not need `*` rule approval, +## but still require an approval from a TW team DRI for each file. +/data/deprecations/templates/ @marcel.amirault @sarahgerman @gitlab-org/tw-leadership +/data/removals/templates/ @marcel.amirault @sarahgerman @gitlab-org/tw-leadership .markdownlint.yml @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership /doc/.markdownlint/ @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership /doc/.vale/ @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership @@ -32,240 +34,241 @@ GITALY_SERVER_VERSION @project_278964_bot6 @gitlab-org/maintainers/rails-backend ^[Source code editing] .solargraph.yml.example @igor.drozdov -^[Backend] -*.rb @gitlab-org/maintainers/rails-backend -*.rake @gitlab-org/maintainers/rails-backend +^[Backend] @gitlab-org/maintainers/rails-backend +*.rb +*.rake -^[Frontend] -*.scss @gitlab-org/maintainers/frontend -*.js @gitlab-org/maintainers/frontend -/app/assets/ @gitlab-org/maintainers/frontend -/ee/app/assets/ @gitlab-org/maintainers/frontend -/spec/frontend/ @gitlab-org/maintainers/frontend -/ee/spec/frontend/ @gitlab-org/maintainers/frontend -/spec/frontend_integration/ @gitlab-org/maintainers/frontend -/ee/spec/frontend_integration/ @gitlab-org/maintainers/frontend +^[Frontend] @gitlab-org/maintainers/frontend +*.scss +*.js +/app/assets/ +/ee/app/assets/ +/spec/frontend/ +/ee/spec/frontend/ +/spec/frontend_integration/ +/ee/spec/frontend_integration/ -^[Database] -/db/ @gitlab-org/maintainers/database -/ee/db/ @gitlab-org/maintainers/database -/lib/gitlab/background_migration/ @gitlab-org/maintainers/database -/ee/lib/ee/gitlab/background_migration/ @gitlab-org/maintainers/database -/lib/gitlab/database/ @gitlab-org/maintainers/database -/lib/gitlab/sql/ @gitlab-org/maintainers/database -/app/finders/ @gitlab-org/maintainers/database -/ee/app/finders/ @gitlab-org/maintainers/database -/rubocop/rubocop-migrations.yml @gitlab-org/maintainers/database +^[Database] @gitlab-org/maintainers/database +/db/ +/ee/db/ +/lib/gitlab/background_migration/ +/ee/lib/ee/gitlab/background_migration/ +/lib/gitlab/database/ +/lib/gitlab/sql/ +/app/finders/ +/ee/app/finders/ +/rubocop/rubocop-migrations.yml -[Engineering Productivity] -/.gitlab-ci.yml @gl-quality/eng-prod -/.gitlab/ci/ @gl-quality/eng-prod +[Engineering Productivity] @gl-quality/eng-prod +/.gitlab-ci.yml +/.gitlab/ci/ /.gitlab/ci/docs.gitlab-ci.yml @gl-quality/eng-prod @gl-docsteam +/.gitlab/ci/package-and-test/ @gl-quality/eng-prod @gl-quality/qe-maintainers +/.gitlab/ci/qa.gitlab-ci.yml @gl-quality/eng-prod @gl-quality/qe-maintainers /.gitlab/ci/releases.gitlab-ci.yml @gl-quality/eng-prod @gitlab-org/delivery -/.gitlab/ci/reports.gitlab-ci.yml @gitlab-com/gl-security/appsec @gl-quality/eng-prod -Dangerfile @gl-quality/eng-prod -/danger/ @gl-quality/eng-prod -/tooling/danger/ @gl-quality/eng-prod -/scripts/ @gl-quality/eng-prod +/.gitlab/ci/reports.gitlab-ci.yml @gl-quality/eng-prod @gitlab-com/gl-security/appsec +/.gitlab/ci/review-apps/qa.gitlab-ci.yml @gl-quality/eng-prod @gl-quality/qe-maintainers +/.gitlab/ci/test-on-gdk/ @gl-quality/eng-prod @gl-quality/qe-maintainers +Dangerfile +/danger/ +/tooling/danger/ +/scripts/ /scripts/frontend/ @gl-quality/eng-prod @gitlab-org/maintainers/frontend -/scripts/review_apps/seed-dast-test-data.sh @dappelt @ngeorge1 @gl-quality/eng-prod -.editorconfig @gl-quality/eng-prod +/scripts/review_apps/seed-dast-test-data.sh @gl-quality/eng-prod @dappelt @ngeorge1 +.editorconfig -^[Backend Static Code Analysis] -.rubocop*.yml @dstull @splattael @gl-quality/eng-prod -.rubocop_todo.yml @dstull @splattael @gl-quality/eng-prod -.rubocop_todo/ @dstull @splattael @gl-quality/eng-prod -/rubocop/ @dstull @splattael @gl-quality/eng-prod -/spec/rubocop/ @dstull @splattael @gl-quality/eng-prod +^[Backend Static Code Analysis] @gl-quality/eng-prod @dstull @splattael +.rubocop*.yml +.rubocop_todo/ +/rubocop/ +/spec/rubocop/ -^[End-to-end] -/qa/ @gl-quality +^[End-to-end] @gl-quality +/qa/ -^[LDAP] -/ee/lib/ee/gitlab/auth/ldap/ @dblessing @mkozono -/lib/gitlab/auth/ldap/ @dblessing @mkozono +^[LDAP] @dblessing @mkozono +/ee/lib/ee/gitlab/auth/ldap/ +/lib/gitlab/auth/ldap/ -^[Project Alias] -/ee/app/models/project_alias.rb @patrickbajao -/ee/lib/api/project_aliases.rb @patrickbajao +^[Project Alias] @patrickbajao +/ee/app/models/project_alias.rb +/ee/lib/api/project_aliases.rb -^[Distribution] -/lib/support/ @gitlab-org/distribution +^[Distribution] @gitlab-org/distribution +/lib/support/ # Secure & Threat Management ownership delineation # https://about.gitlab.com/handbook/engineering/development/threat-management/delineate-secure-threat-management.html#technical-boundaries -^[Threat Insights] -/app/finders/security/ @gitlab-org/govern/threat-insights-backend-team -/app/models/vulnerability.rb @gitlab-org/govern/threat-insights-backend-team -/app/presenters/projects/security/ @gitlab-org/govern/threat-insights-backend-team -/spec/presenters/projects/security/ @gitlab-org/govern/threat-insights-backend-team -/ee/app/finders/security/ @gitlab-org/govern/threat-insights-backend-team -/ee/app/models/security/ @gitlab-org/govern/threat-insights-backend-team -/ee/app/models/vulnerabilities/ @gitlab-org/govern/threat-insights-backend-team -/ee/app/policies/vulnerabilities/ @gitlab-org/govern/threat-insights-backend-team -/ee/app/policies/vulnerability*.rb @gitlab-org/govern/threat-insights-backend-team -/ee/lib/api/vulnerabilit*.rb @gitlab-org/govern/threat-insights-backend-team -/ee/spec/policies/vulnerabilities/ @gitlab-org/govern/threat-insights-backend-team -/ee/spec/policies/vulnerability*.rb @gitlab-org/govern/threat-insights-backend-team -/ee/app/assets/javascripts/license_compliance/components/detected_licenses_table.vue @gitlab-org/govern/threat-insights-frontend-team -/ee/spec/frontend/license_compliance/components/detected_licenses_table_spec.js @gitlab-org/govern/threat-insights-frontend-team +^[Threat Insights backend] @gitlab-org/govern/threat-insights-backend-team +/app/finders/security/ +/app/models/vulnerability.rb +/app/presenters/projects/security/ +/spec/presenters/projects/security/ +/ee/app/finders/security/ +/ee/app/models/security/ +/ee/app/models/vulnerabilities/ +/ee/app/policies/vulnerabilities/ +/ee/app/policies/vulnerability*.rb +/ee/lib/api/vulnerabilit*.rb +/ee/spec/policies/vulnerabilities/ +/ee/spec/policies/vulnerability*.rb -^[Secure] -/ee/lib/gitlab/ci/parsers/license_compliance/ @gitlab-org/secure/composition-analysis-be -/ee/lib/gitlab/ci/parsers/security/ @gitlab-org/secure/composition-analysis-be @gitlab-org/secure/dynamic-analysis-be @gitlab-org/secure/static-analysis-be @gitlab-org/secure/fuzzing-be -/ee/lib/gitlab/ci/reports/coverage_fuzzing/ @gitlab-org/secure/fuzzing-be -/ee/lib/gitlab/ci/reports/dependency_list/ @gitlab-org/secure/composition-analysis-be -/ee/lib/gitlab/ci/reports/license_scanning/ @gitlab-org/secure/composition-analysis-be -/ee/lib/gitlab/ci/reports/security/ @gitlab-org/secure/composition-analysis-be @gitlab-org/secure/dynamic-analysis-be @gitlab-org/secure/static-analysis-be @gitlab-org/secure/fuzzing-be -/ee/app/services/app_sec/dast/ @gitlab-org/secure/dynamic-analysis-be +^[Threat Insights frontend] @gitlab-org/govern/threat-insights-frontend-team +/ee/app/assets/javascripts/license_compliance/components/detected_licenses_table.vue +/ee/spec/frontend/license_compliance/components/detected_licenses_table_spec.js -^[Security Policies] -/ee/app/assets/javascripts/approvals/components/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/approvals/stores/modules/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/pages/projects/licenses/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/pages/projects/pipelines/licenses/** @gitlab-org/govern/security-policies-frontend +^[Secure] @gitlab-org/secure/dynamic-analysis-be +/ee/app/services/app_sec/dast/ + +^[Security Policies frontend] @gitlab-org/govern/security-policies-frontend +/ee/app/assets/javascripts/approvals/components/license_compliance/** +/ee/app/assets/javascripts/approvals/stores/modules/license_compliance/** +/ee/app/assets/javascripts/license_compliance/** +/ee/app/assets/javascripts/pages/projects/licenses/** +/ee/app/assets/javascripts/pages/projects/pipelines/licenses/** /ee/app/assets/javascripts/pages/projects/pipelines/show/license_report.js -/ee/app/assets/javascripts/vue_merge_request_widget/extensions/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/vue_shared/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/app/views/projects/licenses/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/approvals/components/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/approvals/stores/modules/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/vue_merge_request_widget/extensions/license_compliance/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/vue_shared/license_compliance/** @gitlab-org/govern/security-policies-frontend +/ee/app/assets/javascripts/vue_merge_request_widget/extensions/license_compliance/** +/ee/app/assets/javascripts/vue_shared/license_compliance/** +/ee/app/views/projects/licenses/** +/ee/spec/frontend/approvals/components/license_compliance/** +/ee/spec/frontend/approvals/stores/modules/license_compliance/** +/ee/spec/frontend/license_compliance/** +/ee/spec/frontend/vue_merge_request_widget/extensions/license_compliance/** +/ee/spec/frontend/vue_shared/license_compliance/** -/ee/app/assets/javascripts/approvals/components/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/approvals/stores/modules/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/pages/groups/security/policies/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/pages/projects/security/policies/** @gitlab-org/govern/security-policies-frontend -/ee/app/assets/javascripts/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/app/views/groups/security/policies @gitlab-org/govern/security-policies-frontend -/ee/app/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/approvals/components/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/approvals/stores/modules/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/spec/frontend/security_orchestration/** @gitlab-org/govern/security-policies-frontend -/ee/spec/views/projects/security/policies/** @gitlab-org/govern/security-policies-frontend +/ee/app/assets/javascripts/approvals/components/security_orchestration/** +/ee/app/assets/javascripts/approvals/stores/modules/security_orchestration/** +/ee/app/assets/javascripts/pages/groups/security/policies/** +/ee/app/assets/javascripts/pages/projects/security/policies/** +/ee/app/assets/javascripts/security_orchestration/** +/ee/app/views/groups/security/policies +/ee/app/views/projects/security/policies/** +/ee/spec/frontend/approvals/components/security_orchestration/** +/ee/spec/frontend/approvals/stores/modules/security_orchestration/** +/ee/spec/frontend/security_orchestration/** +/ee/spec/views/projects/security/policies/** -/app/models/clusters/applications/cilium.rb @gitlab-org/govern/security-policies-backend -/ee/app/controllers/groups/security/policies_controller.rb @gitlab-org/govern/security-policies-backend -/ee/app/controllers/projects/security/policies_controller.rb @gitlab-org/govern/security-policies-backend -/ee/app/graphql/mutations/concerns/mutations/finds_project_or_group_for_security_policies.rb @gitlab-org/govern/security-policies-backend -/ee/app/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend -/ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb @gitlab-org/govern/security-policies-backend -/ee/app/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/app/graphql/types/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/app/helpers/ee/security_orchestration_helper.rb @gitlab-org/govern/security-policies-backend -/ee/app/models/security/orchestration_policy_configuration.rb @gitlab-org/govern/security-policies-backend -/ee/app/models/security/orchestration_policy_rule_schedule.rb @gitlab-org/govern/security-policies-backend -/ee/app/services/security/orchestration/** @gitlab-org/govern/security-policies-backend -/ee/app/services/security/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/app/validators/json_schemas/security_orchestration_policy.json @gitlab-org/govern/security-policies-backend -/ee/app/workers/concerns/update_orchestration_policy_configuration.rb @gitlab-org/govern/security-policies-backend -/ee/app/workers/security/create_orchestration_policy_worker.rb @gitlab-org/govern/security-policies-backend -/ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb @gitlab-org/govern/security-policies-backend -/ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb @gitlab-org/govern/security-policies-backend -/ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb @gitlab-org/govern/security-policies-backend -/ee/lib/gitlab/ci/config/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/spec/controllers/groups/security/policies_controller_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/security_orchestration_policy_configurations.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/security_orchestration_policy_rule_schedules.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/security/policies.rb @gitlab-org/govern/security-policies-backend -/ee/spec/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend -/ee/spec/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/spec/graphql/types/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/spec/helpers/ee/security_orchestration_helper_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/lib/gitlab/ci/config/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/spec/models/security/orchestration_policy_configuration_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/requests/api/graphql/mutations/security_policy/** @gitlab-org/govern/security-policies-backend -/ee/spec/requests/api/graphql/project/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/spec/requests/projects/security/policies_controller_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/services/security/orchestration/** @gitlab-org/govern/security-policies-backend -/ee/spec/services/security/security_orchestration_policies/** @gitlab-org/govern/security-policies-backend -/ee/spec/support/shared_contexts/graphql/resolvers/security_orchestration/** @gitlab-org/govern/security-policies-backend -/ee/spec/views/projects/security/policies/index.html.haml_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/workers/security/create_orchestration_policy_worker_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb @gitlab-org/govern/security-policies-backend -/lib/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb @gitlab-org/govern/security-policies-backend -/spec/models/clusters/applications/cilium_spec.rb @gitlab-org/govern/security-policies-backend +^[Security Policies backend] @gitlab-org/govern/security-policies-backend +/app/models/clusters/applications/cilium.rb +/ee/app/controllers/groups/security/policies_controller.rb +/ee/app/controllers/projects/security/policies_controller.rb +/ee/app/graphql/mutations/concerns/mutations/finds_project_or_group_for_security_policies.rb +/ee/app/graphql/mutations/security_policy/** +/ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb +/ee/app/graphql/resolvers/security_orchestration/** +/ee/app/graphql/types/security_orchestration/** +/ee/app/helpers/ee/security_orchestration_helper.rb +/ee/app/models/security/orchestration_policy_configuration.rb +/ee/app/models/security/orchestration_policy_rule_schedule.rb +/ee/app/services/security/orchestration/** +/ee/app/services/security/security_orchestration_policies/** +/ee/app/validators/json_schemas/security_orchestration_policy.json +/ee/app/workers/concerns/update_orchestration_policy_configuration.rb +/ee/app/workers/security/create_orchestration_policy_worker.rb +/ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb +/ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb +/ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb +/ee/lib/gitlab/ci/config/security_orchestration_policies/** +/ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/** +/ee/spec/controllers/groups/security/policies_controller_spec.rb +/ee/spec/factories/security_orchestration_policy_configurations.rb +/ee/spec/factories/security_orchestration_policy_rule_schedules.rb +/ee/spec/factories/security/policies.rb +/ee/spec/graphql/mutations/security_policy/** +/ee/spec/graphql/resolvers/security_orchestration/** +/ee/spec/graphql/types/security_orchestration/** +/ee/spec/helpers/ee/security_orchestration_helper_spec.rb +/ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb +/ee/spec/lib/gitlab/ci/config/security_orchestration_policies/** +/ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/** +/ee/spec/models/security/orchestration_policy_configuration_spec.rb +/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb +/ee/spec/requests/api/graphql/mutations/security_policy/** +/ee/spec/requests/api/graphql/project/security_orchestration/** +/ee/spec/requests/projects/security/policies_controller_spec.rb +/ee/spec/services/security/orchestration/** +/ee/spec/services/security/security_orchestration_policies/** +/ee/spec/support/shared_contexts/graphql/resolvers/security_orchestration/** +/ee/spec/views/projects/security/policies/index.html.haml_spec.rb +/ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb +/ee/spec/workers/security/create_orchestration_policy_worker_spec.rb +/ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb +/ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb +/lib/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb +/spec/models/clusters/applications/cilium_spec.rb -/app/finders/security/license_compliance_jobs_finder.rb @gitlab-org/govern/security-policies-backend -/ee/app/controllers/projects/licenses_controller.rb @gitlab-org/govern/security-policies-backend -/ee/app/finders/software_license_policies_finder.rb @gitlab-org/govern/security-policies-backend +/app/finders/security/license_compliance_jobs_finder.rb +/ee/app/controllers/projects/licenses_controller.rb +/ee/app/finders/software_license_policies_finder.rb /ee/app/models/sca/license_compliance.rb @gitlab-org/govern/security-policies-backend @gitlab-org/secure/composition-analysis-be -/ee/app/models/sca/license_policy.rb @gitlab-org/govern/security-policies-backend -/ee/app/models/software_license_policy.rb @gitlab-org/govern/security-policies-backend -/ee/app/models/software_license.rb @gitlab-org/govern/security-policies-backend -/ee/app/serializers/license_compliance/** @gitlab-org/govern/security-policies-backend -/ee/app/serializers/license_entity.rb @gitlab-org/govern/security-policies-backend -/ee/app/serializers/licenses_list_entity.rb @gitlab-org/govern/security-policies-backend -/ee/app/serializers/licenses_list_serializer.rb @gitlab-org/govern/security-policies-backend -/ee/app/serializers/security/license_policy_entity.rb @gitlab-org/govern/security-policies-backend -/ee/app/services/ci/compare_license_scanning_reports_collapsed_service.rb @gitlab-org/govern/security-policies-backend -/ee/app/services/ci/compare_license_scanning_reports_service.rb @gitlab-org/govern/security-policies-backend -/ee/app/services/software_license_policies/** @gitlab-org/govern/security-policies-backend -/ee/app/services/software_license_policies/update_service.rb @gitlab-org/govern/security-policies-backend -/ee/app/workers/refresh_license_compliance_checks_worker.rb @gitlab-org/govern/security-policies-backend -/ee/lib/api/managed_licenses.rb @gitlab-org/govern/security-policies-backend -/ee/lib/ee/api/entities/managed_license.rb @gitlab-org/govern/security-policies-backend -/ee/lib/gitlab/spdx/license.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/software_license_policy.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/software_license.rb @gitlab-org/govern/security-policies-backend -/ee/spec/factories/spdx_license.rb @gitlab-org/govern/security-policies-backend -/ee/spec/finders/software_license_policies_finder_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/lib/gitlab/ci/parsers/license_compliance/** @gitlab-org/govern/security-policies-backend +/ee/app/models/sca/license_policy.rb +/ee/app/models/software_license_policy.rb +/ee/app/models/software_license.rb +/ee/app/serializers/license_compliance/** +/ee/app/serializers/license_entity.rb +/ee/app/serializers/licenses_list_entity.rb +/ee/app/serializers/licenses_list_serializer.rb +/ee/app/serializers/security/license_policy_entity.rb +/ee/app/services/ci/compare_license_scanning_reports_collapsed_service.rb +/ee/app/services/ci/compare_license_scanning_reports_service.rb +/ee/app/services/software_license_policies/** +/ee/app/services/software_license_policies/update_service.rb +/ee/app/workers/refresh_license_compliance_checks_worker.rb +/ee/lib/api/managed_licenses.rb +/ee/lib/ee/api/entities/managed_license.rb +/ee/lib/gitlab/spdx/license.rb +/ee/spec/factories/software_license_policy.rb +/ee/spec/factories/software_license.rb +/ee/spec/factories/spdx_license.rb +/ee/spec/finders/software_license_policies_finder_spec.rb +/ee/spec/lib/gitlab/ci/parsers/license_compliance/** /ee/spec/models/sca/license_compliance_spec.rb @gitlab-org/govern/security-policies-backend @gitlab-org/secure/composition-analysis-be -/ee/spec/models/sca/license_policy_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/models/software_license_policy_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/models/software_license_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/requests/api/managed_licenses_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/serializers/license_compliance/** @gitlab-org/govern/security-policies-backend -/ee/spec/services/ci/compare_license_scanning_reports_collapsed_service_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb @gitlab-org/govern/security-policies-backend -/ee/spec/services/software_license_policies/** @gitlab-org/govern/security-policies-backend -/spec/finders/security/license_compliance_jobs_finder_spec.rb @gitlab-org/govern/security-policies-backend +/ee/spec/models/sca/license_policy_spec.rb +/ee/spec/models/software_license_policy_spec.rb +/ee/spec/models/software_license_spec.rb +/ee/spec/requests/api/managed_licenses_spec.rb +/ee/spec/serializers/license_compliance/** +/ee/spec/services/ci/compare_license_scanning_reports_collapsed_service_spec.rb +/ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb +/ee/spec/services/software_license_policies/** +/spec/finders/security/license_compliance_jobs_finder_spec.rb -^[Code Owners] -/ee/lib/gitlab/code_owners.rb @reprazent @kerrizor @garyh -/ee/lib/gitlab/code_owners/ @reprazent @kerrizor @garyh -/ee/spec/lib/gitlab/code_owners/ @reprazent @kerrizor @garyh -/doc/user/project/code_owners.md @reprazent @kerrizor @garyh +^[Code Owners] @reprazent @kerrizor @garyh +/ee/lib/gitlab/code_owners.rb +/ee/lib/gitlab/code_owners/ +/ee/spec/lib/gitlab/code_owners/ +/doc/user/project/code_owners.md -^[Merge Requests] -/app/controllers/projects/merge_requests/ @garyh @patrickbajao @marc_shaw @kerrizor -/app/models/merge_request.rb @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/app/services/merge_requests/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/app/workers/merge_requests/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/app/workers/merge_request_mergeability_check_worker.rb @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/lib/gitlab/diff/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/lib/gitlab/discussions_diff/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/lib/gitlab/quick_actions/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor +^[Merge Requests backend] @garyh @patrickbajao @marc_shaw @kerrizor +/app/controllers/projects/merge_requests/ +/app/models/merge_request.rb @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/app/services/merge_requests/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/app/workers/merge_requests/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/app/workers/merge_request_mergeability_check_worker.rb @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/lib/gitlab/diff/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/lib/gitlab/discussions_diff/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/lib/gitlab/quick_actions/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab -/ee/app/models/ee/merge_request.rb @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/ee/app/services/merge_requests/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/ee/app/workers/merge_requests/ @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor -/ee/app/workers/merge_request_reset_approvals_worker.rb @dskim_gitlab @garyh @patrickbajao @marc_shaw @kerrizor +/ee/app/models/ee/merge_request.rb @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/ee/app/services/merge_requests/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/ee/app/workers/merge_requests/ @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab +/ee/app/workers/merge_request_reset_approvals_worker.rb @garyh @patrickbajao @marc_shaw @kerrizor @dskim_gitlab -/app/assets/javascripts/diffs @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/batch_comments/ @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/notes @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/merge_conflicts @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/mr_notes @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/issuable/popover @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/vue_merge_request_widget @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/merge_request.js @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/javascripts/merge_request_tabs.js @viktomas @jboyson @iamphill @thomasrandolph -/app/assets/stylesheets/framework/diffs.scss @viktomas @jboyson @iamphill @thomasrandolph -/ee/app/assets/javascripts/diffs/ @viktomas @jboyson @iamphill @thomasrandolph -/ee/app/assets/javascripts/vue_merge_request_widget @viktomas @jboyson @iamphill @thomasrandolph -/spec/frontend/diffs/ @viktomas @jboyson @iamphill @thomasrandolph -/spec/frontend/batch_comments/ @viktomas @jboyson @iamphill @thomasrandolph +^[Merge Requests frontend] @viktomas @jboyson @iamphill @thomasrandolph +/app/assets/javascripts/diffs +/app/assets/javascripts/batch_comments/ +/app/assets/javascripts/notes +/app/assets/javascripts/merge_conflicts +/app/assets/javascripts/mr_notes +/app/assets/javascripts/issuable/popover +/app/assets/javascripts/vue_merge_request_widget +/app/assets/javascripts/merge_request.js +/app/assets/javascripts/merge_request_tabs.js +/app/assets/stylesheets/framework/diffs.scss +/ee/app/assets/javascripts/diffs/ +/ee/app/assets/javascripts/vue_merge_request_widget +/spec/frontend/diffs/ +/spec/frontend/batch_comments/ ^[Product Analytics] @gitlab-org/analytics-section/product-analytics/engineers/frontend /ee/app/assets/javascripts/analytics/analytics_dashboards/components/analytics_dashboard.vue @@ -275,118 +278,118 @@ Dangerfile @gl-quality/eng-prod /ee/app/assets/javascripts/vue_shared/components/customizable_dashboard/panels_base.vue /ee/app/assets/javascripts/product_analytics/ -^[Product Intelligence] -/ee/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/lib/ee/gitlab/usage_data.rb @gitlab-org/analytics-section/product-intelligence/engineers -/lib/gitlab/usage_data.rb @gitlab-org/analytics-section/product-intelligence/engineers -/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/lib/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/lib/ee/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/lib/ee/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers -/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers -/app/workers/gitlab_service_ping_worker.rb @gitlab-org/analytics-section/product-intelligence/engineers -/spec/workers/gitlab_service_ping_worker_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers -/ee/spec/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/spec/lib/ee/gitlab/usage_data_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers -/spec/lib/gitlab/usage_data_spec.rb @gitlab-org/analytics-section/product-intelligence/engineers -/spec/lib/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/spec/lib/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/spec/lib/ee/gitlab/usage_data_counters/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/spec/lib/ee/gitlab/usage/ @gitlab-org/analytics-section/product-intelligence/engineers -/ee/spec/config/metrics/ @gitlab-org/analytics-section/product-intelligence/engineers +^[Analytics Instrumentation] @gitlab-org/analytics-section/product-intelligence/engineers +/ee/lib/gitlab/usage_data_counters/ +/ee/lib/ee/gitlab/usage_data.rb +/lib/gitlab/usage_data.rb +/lib/gitlab/usage_data_counters/ +/lib/gitlab/usage/ +/ee/lib/ee/gitlab/usage_data_counters/ +/ee/lib/ee/gitlab/usage/ +/config/metrics/ +/ee/config/metrics/ +/app/workers/gitlab_service_ping_worker.rb +/spec/workers/gitlab_service_ping_worker_spec.rb +/ee/spec/lib/gitlab/usage_data_counters/ +/ee/spec/lib/ee/gitlab/usage_data_spec.rb +/spec/lib/gitlab/usage_data_spec.rb +/spec/lib/gitlab/usage_data_counters/ +/spec/lib/gitlab/usage/ +/ee/spec/lib/ee/gitlab/usage_data_counters/ +/ee/spec/lib/ee/gitlab/usage/ +/ee/spec/config/metrics/ -^[Growth Experiments] -/app/experiments/ @gitlab-org/growth/experiment-devs -/spec/experiments/ @gitlab-org/growth/experiment-devs -/config/initializers/gitlab_experiment.rb @gitlab-org/growth/experiment-devs -/config/feature_flags/experiment/ @gitlab-org/growth/experiment-devs -/ee/config/feature_flags/experiment/ @gitlab-org/growth/experiment-devs -/ee/lib/api/experiments.rb @gitlab-org/growth/experiment-devs -/ee/spec/requests/api/experiments_spec.rb @gitlab-org/growth/experiment-devs -/ee/lib/ee/api/entities/experiment.rb @gitlab-org/growth/experiment-devs -/ee/spec/lib/ee/api/entities/experiment_spec.rb @gitlab-org/growth/experiment-devs +^[Growth Experiments] @gitlab-org/growth/experiment-devs +/app/experiments/ +/spec/experiments/ +/config/initializers/gitlab_experiment.rb +/config/feature_flags/experiment/ +/ee/config/feature_flags/experiment/ +/ee/lib/api/experiments.rb +/ee/spec/requests/api/experiments_spec.rb +/ee/lib/ee/api/entities/experiment.rb +/ee/spec/lib/ee/api/entities/experiment_spec.rb -^[Growth] -/ee/app/workers/onboarding/ @gitlab-org/growth/engineers -/ee/spec/workers/onboarding/ @gitlab-org/growth/engineers -/app/models/onboarding/ @gitlab-org/growth/engineers -/spec/models/onboarding/ @gitlab-org/growth/engineers -/app/services/onboarding/ @gitlab-org/growth/engineers -/spec/services/onboarding/ @gitlab-org/growth/engineers -/ee/app/components/namespaces/free_user_cap/ @gitlab-org/growth/engineers -/ee/spec/components/namespaces/free_user_cap/ @gitlab-org/growth/engineers -/ee/app/models/namespaces/free_user_cap/ @gitlab-org/growth/engineers -/ee/spec/models/namespaces/free_user_cap/ @gitlab-org/growth/engineers -/app/controllers/registrations_controller.rb @gitlab-org/growth/engineers -/spec/controllers/registrations_controller_spec.rb @gitlab-org/growth/engineers -/app/controllers/registrations/ @gitlab-org/growth/engineers -/spec/controllers/registrations/ @gitlab-org/growth/engineers -/app/controllers/confirmations_controller.rb @gitlab-org/growth/engineers -/spec/controllers/confirmations_controller_spec.rb @gitlab-org/growth/engineers -/ee/app/controllers/trial_registrations_controller.rb @gitlab-org/growth/engineers -/ee/spec/controllers/trial_registrations_controller_spec.rb @gitlab-org/growth/engineers -/ee/spec/requests/trial_registrations_controller_spec.rb @gitlab-org/growth/engineers -/ee/app/controllers/registrations/ @gitlab-org/growth/engineers -/ee/spec/controllers/registrations/ @gitlab-org/growth/engineers -/ee/spec/requests/registrations/ @gitlab-org/growth/engineers -/ee/app/controllers/ee/registrations_controller.rb @gitlab-org/growth/engineers -/ee/spec/controllers/ee/registrations_controller_spec.rb @gitlab-org/growth/engineers -/ee/app/controllers/ee/registrations/ @gitlab-org/growth/engineers -/ee/app/controllers/ee/confirmations_controller.rb @gitlab-org/growth/engineers -/ee/app/controllers/subscriptions_controller.rb @gitlab-org/growth/engineers -/ee/spec/controllers/subscriptions_controller_spec.rb @gitlab-org/growth/engineers -/ee/app/controllers/subscriptions/ @gitlab-org/growth/engineers -/ee/spec/controllers/subscriptions/ @gitlab-org/growth/engineers -/app/services/users/in_product_marketing_email_records.rb @gitlab-org/growth/engineers -/spec/services/users/in_product_marketing_email_records_spec.rb @gitlab-org/growth/engineers -/app/workers/namespaces/in_product_marketing_emails_worker.rb @gitlab-org/growth/engineers -/spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb @gitlab-org/growth/engineers -/ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb @gitlab-org/growth/engineers -/ee/spec/workers/ee/namespaces/in_product_marketing_emails_worker_spec.rb @gitlab-org/growth/engineers -/app/models/users/in_product_marketing_email.rb @gitlab-org/growth/engineers -/spec/models/users/in_product_marketing_email_spec.rb @gitlab-org/growth/engineers -/app/services/namespaces/in_product_marketing_emails_service.rb @gitlab-org/growth/engineers -/spec/services/namespaces/in_product_marketing_emails_service_spec.rb @gitlab-org/growth/engineers -/ee/app/services/ee/namespaces/in_product_marketing_emails_service.rb @gitlab-org/growth/engineers -/ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb @gitlab-org/growth/engineers -/app/workers/projects/record_target_platforms_worker.rb @gitlab-org/growth/engineers -/spec/workers/projects/record_target_platforms_worker_spec.rb @gitlab-org/growth/engineers +^[Growth] @gitlab-org/growth/engineers +/ee/app/workers/onboarding/ +/ee/spec/workers/onboarding/ +/app/models/onboarding/ +/spec/models/onboarding/ +/app/services/onboarding/ +/spec/services/onboarding/ +/ee/app/components/namespaces/free_user_cap/ +/ee/spec/components/namespaces/free_user_cap/ +/ee/app/models/namespaces/free_user_cap/ +/ee/spec/models/namespaces/free_user_cap/ +/app/controllers/registrations_controller.rb +/spec/controllers/registrations_controller_spec.rb +/app/controllers/registrations/ +/spec/controllers/registrations/ +/app/controllers/confirmations_controller.rb +/spec/controllers/confirmations_controller_spec.rb +/ee/app/controllers/trial_registrations_controller.rb +/ee/spec/controllers/trial_registrations_controller_spec.rb +/ee/spec/requests/trial_registrations_controller_spec.rb +/ee/app/controllers/registrations/ +/ee/spec/controllers/registrations/ +/ee/spec/requests/registrations/ +/ee/app/controllers/ee/registrations_controller.rb +/ee/spec/controllers/ee/registrations_controller_spec.rb +/ee/app/controllers/ee/registrations/ +/ee/app/controllers/ee/confirmations_controller.rb +/ee/app/controllers/subscriptions_controller.rb +/ee/spec/controllers/subscriptions_controller_spec.rb +/ee/app/controllers/subscriptions/ +/ee/spec/controllers/subscriptions/ +/app/services/users/in_product_marketing_email_records.rb +/spec/services/users/in_product_marketing_email_records_spec.rb +/app/workers/namespaces/in_product_marketing_emails_worker.rb +/spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb +/ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb +/ee/spec/workers/ee/namespaces/in_product_marketing_emails_worker_spec.rb +/app/models/users/in_product_marketing_email.rb +/spec/models/users/in_product_marketing_email_spec.rb +/app/services/namespaces/in_product_marketing_emails_service.rb +/spec/services/namespaces/in_product_marketing_emails_service_spec.rb +/ee/app/services/ee/namespaces/in_product_marketing_emails_service.rb +/ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb +/app/workers/projects/record_target_platforms_worker.rb +/spec/workers/projects/record_target_platforms_worker_spec.rb -^[Legal] -/config/dependency_decisions.yml @gitlab-org/legal-reviewers +^[Legal] @gitlab-org/legal-reviewers +/config/dependency_decisions.yml -^[Workhorse] -/workhorse/ @jacobvosmaer-gitlab @nolith @patrickbajao @igor.drozdov +^[Workhorse] @nolith @patrickbajao @igor.drozdov +/workhorse/ -[Application Security] -/app/assets/javascripts/lib/dompurify.js @gitlab-com/gl-security/appsec -/app/assets/javascripts/gfm_auto_complete.js @gitlab-com/gl-security/appsec -/ee/app/assets/javascripts/gfm_auto_complete.js @gitlab-com/gl-security/appsec -/app/validators/addressable_url_validator.rb @gitlab-com/gl-security/appsec -/app/validators/public_url_validator.rb @gitlab-com/gl-security/appsec -/config/initializers/content_security_policy.rb @gitlab-com/gl-security/appsec -/lib/gitlab/content_security_policy/ @gitlab-com/gl-security/appsec -/lib/gitlab/http.rb @gitlab-com/gl-security/appsec -/lib/gitlab/http_connection_adapter.rb @gitlab-com/gl-security/appsec -/lib/gitlab/sanitizers @gitlab-com/gl-security/appsec -/lib/gitlab/untrusted_regexp.rb @gitlab-com/gl-security/appsec -/lib/gitlab/url_blocker.rb @gitlab-com/gl-security/appsec -/lib/gitlab/url_blockers/ @gitlab-com/gl-security/appsec -/lib/gitlab/utils.rb @gitlab-com/gl-security/appsec +[Application Security] @gitlab-com/gl-security/appsec +/app/assets/javascripts/lib/dompurify.js +/app/assets/javascripts/gfm_auto_complete.js +/ee/app/assets/javascripts/gfm_auto_complete.js +/app/validators/addressable_url_validator.rb +/app/validators/public_url_validator.rb +/config/initializers/content_security_policy.rb +/lib/gitlab/content_security_policy/ +/lib/gitlab/http.rb +/lib/gitlab/http_connection_adapter.rb +/lib/gitlab/sanitizers +/lib/gitlab/untrusted_regexp.rb +/lib/gitlab/url_blocker.rb +/lib/gitlab/url_blockers/ +/lib/gitlab/utils.rb -^[Gitaly] -lib/gitlab/git_access.rb @proglottis @toon -lib/gitlab/git_access_*.rb @proglottis @toon -ee/lib/ee/gitlab/git_access.rb @proglottis @toon -ee/lib/ee/gitlab/git_access_*.rb @proglottis @toon -ee/lib/ee/gitlab/checks/** @proglottis @toon -lib/gitlab/checks/** @proglottis @toon +^[Gitaly] @proglottis @toon +lib/gitlab/git_access.rb +lib/gitlab/git_access_*.rb +ee/lib/ee/gitlab/git_access.rb +ee/lib/ee/gitlab/git_access_*.rb +ee/lib/ee/gitlab/checks/** +lib/gitlab/checks/** -^[Documentation Directories] -/doc/ @gl-docsteam -/data/deprecations/ @gl-docsteam -/data/removals/ @gl-docsteam +^[Documentation Directories] @gl-docsteam +/doc/ +/data/deprecations/ +/data/removals/ ^[Documentation Pages] # This block is managed by the rake script at lib/tasks/gitlab/tw/codeowners.rake, manual updates will be overwritten! @@ -408,7 +411,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/administration/environment_variables.md @axil /doc/administration/external_pipeline_validation.md @drcatherinepope /doc/administration/feature_flags.md @axil -/doc/administration/file_hooks.md @ashrafkhamis +/doc/administration/file_hooks.md @eread @ashrafkhamis /doc/administration/geo/ @axil /doc/administration/get_started.md @kpaizee /doc/administration/git_protocol.md @aqualls @@ -433,8 +436,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/administration/logs/index.md @msedlakjakubowski /doc/administration/maintenance_mode/ @axil /doc/administration/merge_request_diffs.md @aqualls -/doc/administration/monitoring/github_imports.md @eread -/doc/administration/monitoring/gitlab_self_monitoring_project/ @msedlakjakubowski +/doc/administration/monitoring/github_imports.md @eread @ashrafkhamis /doc/administration/monitoring/index.md @msedlakjakubowski /doc/administration/monitoring/ip_allowlist.md @jglassman1 /doc/administration/monitoring/performance/gitlab_configuration.md @msedlakjakubowski @@ -477,7 +479,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/administration/smime_signing_email.md @axil /doc/administration/snippets/ @aqualls /doc/administration/static_objects_external_storage.md @ashrafkhamis -/doc/administration/system_hooks.md @ashrafkhamis +/doc/administration/system_hooks.md @eread @ashrafkhamis /doc/administration/terraform_state.md @phillipwells /doc/administration/timezone.md @axil /doc/administration/troubleshooting/ @axil @@ -487,7 +489,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/access_requests.md @jglassman1 /doc/api/admin_sidekiq_queues.md @axil /doc/api/alert_management_alerts.md @msedlakjakubowski -/doc/api/api_resources.md @ashrafkhamis +/doc/api/api_resources.md @eread @ashrafkhamis /doc/api/appearance.md @jglassman1 /doc/api/applications.md @jglassman1 /doc/api/audit_events.md @eread @@ -495,7 +497,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/award_emoji.md @msedlakjakubowski /doc/api/boards.md @msedlakjakubowski /doc/api/branches.md @aqualls -/doc/api/bulk_imports.md @eread +/doc/api/bulk_imports.md @eread @ashrafkhamis /doc/api/cluster_agents.md @phillipwells /doc/api/commits.md @aqualls /doc/api/container_registry.md @marcel.amirault @@ -519,13 +521,14 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/features.md @phillipwells /doc/api/freeze_periods.md @phillipwells /doc/api/geo_nodes.md @axil +/doc/api/geo_sites.md @axil /doc/api/graphql/audit_report.md @eread /doc/api/graphql/branch_rules.md @aqualls /doc/api/graphql/custom_emoji.md @msedlakjakubowski -/doc/api/graphql/getting_started.md @ashrafkhamis -/doc/api/graphql/index.md @ashrafkhamis -/doc/api/graphql/reference/ @ashrafkhamis -/doc/api/graphql/removed_items.md @ashrafkhamis +/doc/api/graphql/getting_started.md @eread @ashrafkhamis +/doc/api/graphql/index.md @eread @ashrafkhamis +/doc/api/graphql/reference/ @eread @ashrafkhamis +/doc/api/graphql/removed_items.md @eread @ashrafkhamis /doc/api/graphql/sample_issue_boards.md @msedlakjakubowski /doc/api/graphql/users_example.md @jglassman1 /doc/api/group_access_tokens.md @jglassman1 @@ -534,22 +537,22 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/group_boards.md @msedlakjakubowski /doc/api/group_clusters.md @phillipwells /doc/api/group_epic_boards.md @msedlakjakubowski -/doc/api/group_import_export.md @eread +/doc/api/group_import_export.md @eread @ashrafkhamis /doc/api/group_iterations.md @msedlakjakubowski /doc/api/group_labels.md @msedlakjakubowski /doc/api/group_level_variables.md @marcel.amirault /doc/api/group_milestones.md @msedlakjakubowski /doc/api/group_protected_branches.md @aqualls /doc/api/group_protected_environments.md @phillipwells -/doc/api/group_relations_export.md @eread +/doc/api/group_relations_export.md @eread @ashrafkhamis /doc/api/group_releases.md @phillipwells /doc/api/group_repository_storage_moves.md @ashrafkhamis /doc/api/groups.md @lciutacu -/doc/api/import.md @eread -/doc/api/index.md @ashrafkhamis +/doc/api/import.md @eread @ashrafkhamis +/doc/api/index.md @eread @ashrafkhamis /doc/api/instance_clusters.md @phillipwells /doc/api/instance_level_ci_variables.md @marcel.amirault -/doc/api/integrations.md @ashrafkhamis +/doc/api/integrations.md @eread @ashrafkhamis /doc/api/issue_links.md @msedlakjakubowski /doc/api/issues.md @msedlakjakubowski /doc/api/issues_statistics.md @msedlakjakubowski @@ -577,7 +580,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/notes.md @msedlakjakubowski /doc/api/notification_settings.md @msedlakjakubowski /doc/api/oauth2.md @jglassman1 -/doc/api/openapi/ @ashrafkhamis +/doc/api/openapi/ @eread @ashrafkhamis /doc/api/packages.md @marcel.amirault /doc/api/packages/ @marcel.amirault /doc/api/personal_access_tokens.md @eread @@ -592,7 +595,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/project_clusters.md @phillipwells /doc/api/project_import_export.md @aqualls /doc/api/project_level_variables.md @marcel.amirault -/doc/api/project_relations_export.md @eread +/doc/api/project_relations_export.md @eread @ashrafkhamis /doc/api/project_repository_storage_moves.md @eread /doc/api/project_snippets.md @aqualls /doc/api/project_statistics.md @aqualls @@ -613,7 +616,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/resource_milestone_events.md @msedlakjakubowski /doc/api/resource_state_events.md @msedlakjakubowski /doc/api/resource_weight_events.md @msedlakjakubowski -/doc/api/rest/ @ashrafkhamis +/doc/api/rest/ @eread @ashrafkhamis /doc/api/runners.md @fneill /doc/api/saml.md @jglassman1 /doc/api/scim.md @jglassman1 @@ -626,7 +629,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/api/statistics.md @jglassman1 /doc/api/status_checks.md @eread /doc/api/suggestions.md @aqualls -/doc/api/system_hooks.md @ashrafkhamis +/doc/api/system_hooks.md @eread @ashrafkhamis /doc/api/tags.md @aqualls /doc/api/templates/dockerfiles.md @aqualls /doc/api/templates/gitignores.md @aqualls @@ -646,9 +649,10 @@ lib/gitlab/checks/** @proglottis @toon /doc/architecture/blueprints/database_scaling/ @aqualls /doc/ci/ @drcatherinepope /doc/ci/caching/ @marcel.amirault -/doc/ci/chatops/ @phillipwells +/doc/ci/chatops/ @eread @ashrafkhamis /doc/ci/cloud_deployment/ @phillipwells /doc/ci/cloud_services/ @marcel.amirault +/doc/ci/components/ @marcel.amirault /doc/ci/directed_acyclic_graph/ @marcel.amirault /doc/ci/docker/using_docker_images.md @fneill /doc/ci/environments/ @phillipwells @@ -687,10 +691,10 @@ lib/gitlab/checks/** @proglottis @toon /doc/development/backend/ @sselhorn /doc/development/backend/create_source_code_be/ @aqualls /doc/development/build_test_package.md @axil -/doc/development/bulk_import.md @eread +/doc/development/bulk_import.md @eread @ashrafkhamis /doc/development/cached_queries.md @jglassman1 /doc/development/cascading_settings.md @jglassman1 -/doc/development/chatops_on_gitlabcom.md @phillipwells +/doc/development/chatops_on_gitlabcom.md @eread @ashrafkhamis /doc/development/cicd/ @marcel.amirault /doc/development/cicd/cicd_tables.md @drcatherinepope /doc/development/cicd/index.md @drcatherinepope @@ -706,7 +710,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/development/distributed_tracing.md @msedlakjakubowski /doc/development/distribution/ @axil /doc/development/documentation/ @sselhorn -/doc/development/export_csv.md @eread +/doc/development/export_csv.md @eread @ashrafkhamis /doc/development/fe_guide/customizable_dashboards.md @lciutacu /doc/development/fe_guide/dark_mode.md @sselhorn /doc/development/fe_guide/graphql.md @sselhorn @@ -723,13 +727,13 @@ lib/gitlab/checks/** @proglottis @toon /doc/development/gitaly.md @eread /doc/development/gitlab_flavored_markdown/ @ashrafkhamis /doc/development/gitlab_shell/ @aqualls -/doc/development/graphql_guide/ @ashrafkhamis +/doc/development/graphql_guide/ @eread @ashrafkhamis /doc/development/graphql_guide/batchloader.md @aqualls -/doc/development/i18n/ @eread +/doc/development/i18n/ @eread @ashrafkhamis /doc/development/image_scaling.md @lciutacu -/doc/development/import_export.md @eread +/doc/development/import_export.md @eread @ashrafkhamis /doc/development/index.md @sselhorn -/doc/development/integrations/ @ashrafkhamis +/doc/development/integrations/ @eread @ashrafkhamis /doc/development/integrations/secure.md @rdickenson /doc/development/integrations/secure_partner_integration.md @rdickenson /doc/development/internal_api/ @aqualls @@ -775,21 +779,21 @@ lib/gitlab/checks/** @proglottis @toon /doc/integration/advanced_search/ @ashrafkhamis /doc/integration/akismet.md @phillipwells /doc/integration/arkose.md @phillipwells -/doc/integration/datadog.md @ashrafkhamis -/doc/integration/external-issue-tracker.md @ashrafkhamis +/doc/integration/datadog.md @eread @ashrafkhamis +/doc/integration/external-issue-tracker.md @eread @ashrafkhamis /doc/integration/gitpod.md @ashrafkhamis /doc/integration/glab/ @aqualls -/doc/integration/gmail_action_buttons_for_gitlab.md @ashrafkhamis -/doc/integration/index.md @ashrafkhamis -/doc/integration/jenkins.md @ashrafkhamis -/doc/integration/jira/ @ashrafkhamis +/doc/integration/gmail_action_buttons_for_gitlab.md @eread @ashrafkhamis +/doc/integration/index.md @eread @ashrafkhamis +/doc/integration/jenkins.md @eread @ashrafkhamis +/doc/integration/jira/ @eread @ashrafkhamis /doc/integration/mattermost/ @axil /doc/integration/partner_marketplace.md @fneill /doc/integration/recaptcha.md @phillipwells /doc/integration/security_partners/ @rdickenson -/doc/integration/slash_commands.md @ashrafkhamis +/doc/integration/slash_commands.md @eread @ashrafkhamis /doc/integration/sourcegraph.md @aqualls -/doc/integration/trello_power_up.md @ashrafkhamis +/doc/integration/trello_power_up.md @eread @ashrafkhamis /doc/integration/vault.md @phillipwells /doc/operations/error_tracking.md @drcatherinepope /doc/operations/feature_flags.md @phillipwells @@ -808,21 +812,23 @@ lib/gitlab/checks/** @proglottis @toon /doc/subscriptions/gitlab_dedicated/ @drcatherinepope /doc/topics/authentication/ @jglassman1 /doc/topics/autodevops/ @phillipwells -/doc/topics/awesome_co.md @sselhorn +/doc/topics/data_seeder.md @sselhorn /doc/topics/git/ @aqualls /doc/topics/gitlab_flow.md @aqualls /doc/topics/offline/ @axil /doc/topics/plan_and_track.md @msedlakjakubowski -/doc/topics/your_work.md @sselhorn /doc/tutorials/ @kpaizee -/doc/tutorials/create_compliance_pipeline.md @eread -/doc/tutorials/fuzz_testing_tutorial.md @rdickenson -/doc/tutorials/scan_result_policy.md @rdickenson +/doc/tutorials/boards_for_teams/ @msedlakjakubowski +/doc/tutorials/compliance_pipeline/ @eread +/doc/tutorials/convert_personal_namespace_to_group/ @lciutacu +/doc/tutorials/fuzz_testing/ @rdickenson +/doc/tutorials/move_personal_project_to_group/ @lciutacu +/doc/tutorials/scan_result_policy/ @rdickenson /doc/update/ @axil /doc/update/background_migrations.md @aqualls /doc/user/admin_area/analytics/ @lciutacu /doc/user/admin_area/credentials_inventory.md @jglassman1 -/doc/user/admin_area/custom_project_templates.md @eread +/doc/user/admin_area/custom_project_templates.md @aqualls /doc/user/admin_area/diff_limits.md @aqualls /doc/user/admin_area/external_users.md @jglassman1 /doc/user/admin_area/geo_sites.md @axil @@ -843,12 +849,12 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/admin_area/settings/files_api_rate_limits.md @aqualls /doc/user/admin_area/settings/git_lfs_rate_limits.md @aqualls /doc/user/admin_area/settings/gitaly_timeouts.md @eread -/doc/user/admin_area/settings/import_export_rate_limits.md @eread +/doc/user/admin_area/settings/import_export_rate_limits.md @eread @ashrafkhamis /doc/user/admin_area/settings/incident_management_rate_limits.md @msedlakjakubowski /doc/user/admin_area/settings/index.md @aqualls /doc/user/admin_area/settings/instance_template_repository.md @aqualls /doc/user/admin_area/settings/package_registry_rate_limits.md @marcel.amirault -/doc/user/admin_area/settings/project_integration_management.md @ashrafkhamis +/doc/user/admin_area/settings/project_integration_management.md @eread @ashrafkhamis /doc/user/admin_area/settings/push_event_activities_limit.md @aqualls /doc/user/admin_area/settings/rate_limit_on_issues_creation.md @msedlakjakubowski /doc/user/admin_area/settings/rate_limit_on_notes_creation.md @msedlakjakubowski @@ -878,10 +884,10 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/group/clusters/ @phillipwells /doc/user/group/compliance_frameworks.md @eread /doc/user/group/contribution_analytics/ @lciutacu -/doc/user/group/custom_project_templates.md @eread +/doc/user/group/custom_project_templates.md @aqualls /doc/user/group/devops_adoption/ @lciutacu /doc/user/group/epics/ @msedlakjakubowski -/doc/user/group/import/ @eread +/doc/user/group/import/ @eread @ashrafkhamis /doc/user/group/index.md @lciutacu /doc/user/group/insights/ @lciutacu /doc/user/group/issues_analytics/ @msedlakjakubowski @@ -927,16 +933,16 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/project/file_lock.md @aqualls /doc/user/project/git_attributes.md @aqualls /doc/user/project/highlighting.md @aqualls -/doc/user/project/import/ @eread +/doc/user/project/import/ @eread @ashrafkhamis /doc/user/project/import/jira.md @msedlakjakubowski /doc/user/project/index.md @lciutacu /doc/user/project/insights/ @lciutacu -/doc/user/project/integrations/ @ashrafkhamis +/doc/user/project/integrations/ @eread @ashrafkhamis /doc/user/project/integrations/prometheus.md @msedlakjakubowski /doc/user/project/integrations/prometheus_library/ @msedlakjakubowski /doc/user/project/issue_board.md @msedlakjakubowski /doc/user/project/issues/ @msedlakjakubowski -/doc/user/project/issues/csv_import.md @eread +/doc/user/project/issues/csv_import.md @eread @ashrafkhamis /doc/user/project/labels.md @msedlakjakubowski /doc/user/project/members/ @lciutacu /doc/user/project/merge_requests/ @aqualls @@ -949,6 +955,7 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/project/push_options.md @aqualls /doc/user/project/quick_actions.md @msedlakjakubowski /doc/user/project/releases/ @phillipwells +/doc/user/project/releases/release_evidence.md @eread /doc/user/project/remote_development/ @ashrafkhamis /doc/user/project/repository/ @aqualls /doc/user/project/repository/file_finder.md @ashrafkhamis @@ -958,14 +965,13 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/project/repository/web_editor.md @ashrafkhamis /doc/user/project/requirements/ @msedlakjakubowski /doc/user/project/service_desk.md @msedlakjakubowski -/doc/user/project/settings/import_export.md @eread -/doc/user/project/settings/import_export_troubleshooting.md @eread +/doc/user/project/settings/import_export.md @eread @ashrafkhamis +/doc/user/project/settings/import_export_troubleshooting.md @eread @ashrafkhamis /doc/user/project/settings/index.md @lciutacu /doc/user/project/settings/project_access_tokens.md @jglassman1 /doc/user/project/system_notes.md @aqualls /doc/user/project/time_tracking.md @msedlakjakubowski /doc/user/project/web_ide/ @ashrafkhamis -/doc/user/project/web_ide_beta/ @ashrafkhamis /doc/user/project/working_with_projects.md @lciutacu /doc/user/public_access.md @lciutacu /doc/user/report_abuse.md @phillipwells @@ -977,261 +983,262 @@ lib/gitlab/checks/** @proglottis @toon /doc/user/tasks.md @msedlakjakubowski /doc/user/todos.md @msedlakjakubowski /doc/user/usage_quotas.md @fneill -/doc/user/workspace/quick_start/ @ashrafkhamis +/doc/user/workspace/ @ashrafkhamis # End rake-managed-docs-block -[Authentication and Authorization] -/app/assets/javascripts/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/authentication/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/ide/components/shared/tokened_input.vue @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/packages_and_registries/package_registry/components/list/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/admin/impersonation_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/groups/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/ldap/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/omniauth_callbacks/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/profiles/password_prompt/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/profiles/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/profiles/two_factor_auths/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/projects/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/pages/sessions/new/oauth_remember_me.js @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/projects/settings/topics/components/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/javascripts/related_issues/components/issue_token.vue @gitlab-org/manage/authentication-and-authorization/approvers -/app/assets/stylesheets/page_bundles/profile_two_factor_auth.scss @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/admin/impersonation_tokens_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/access_tokens_actions.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/authenticates_with_two_factor.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/authenticates_with_two_factor_for_admin_mode.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/enforces_admin_authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/enforces_two_factor_authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/oauth_applications.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/project_unauthorized.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/require_email_verification.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/sessionless_authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/snippet_authorizations.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/verifies_with_email.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/concerns/workhorse_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/groups/settings/access_tokens_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/ldap/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/omniauth_callbacks_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/passwords_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/profiles/passwords_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/profiles/personal_access_tokens_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/profiles/two_factor_auths_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/profiles/webauthn_registrations_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/projects/settings/access_tokens_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/controllers/sessions_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/finders/groups/projects_requiring_authorizations_refresh/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/finders/personal_access_tokens_finder.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/helpers/access_tokens_helper.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/helpers/auth_helper.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/authentication_event.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/admin_changed_password_notifier.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/mirror_authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/select_for_project_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/token_authenticatable.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/concerns/token_authenticatable_strategies/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/oauth_access_grant.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/oauth_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/personal_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/project_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/token_with_iv.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/models/webauthn_registration.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/policies/personal_access_token_policy.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/access_token_entity_base.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/group_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/group_access_token_serializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/impersonation_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/impersonation_access_token_serializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/personal_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/personal_access_token_serializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/project_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/serializers/project_access_token_serializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/access_token_validation_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/authorized_project_update/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/chat_names/authorize_user_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/projects/move_project_authorizations_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/resource_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/todos/destroy/unauthorized_features_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/users/authorized_build_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/users/authorized_create_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/users/email_verification/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/users/refresh_authorized_projects_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/services/webauthn/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/validators/json_schemas/cluster_agent_authorization_configuration.json @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/admin/application_settings/_external_authorization_service_form.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/admin/impersonation_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/authentication/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/dashboard/projects/_zero_authorized_projects.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/password_change.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/password_change.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/password_change_by_admin.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/password_change_by_admin.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/reset_password_instructions.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/mailer/reset_password_instructions.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/**/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/doorkeeper/authorizations/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/doorkeeper/authorized_applications/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/errors/omniauth_error.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/groups/settings/_resource_access_token_creation.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/groups/settings/_two_factor_auth.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/groups/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/layouts/oauth_error.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_about_to_expire_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_about_to_expire_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_created_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_created_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_expired_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_expired_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_revoked_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/notify/access_token_revoked_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/profiles/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/profiles/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/profiles/two_factor_auths/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/projects/mirrors/_authentication_method.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/projects/settings/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/shared/_no_password.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/shared/_two_factor_auth_recovery_settings_check.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/shared/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/shared/members/_two_factor_auth_badge.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/shared/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/workers/authorized_keys_worker.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/workers/authorized_project_update/ @gitlab-org/manage/authentication-and-authorization/approvers -/app/workers/authorized_projects_worker.rb @gitlab-org/manage/authentication-and-authorization/approvers -/app/workers/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/01_secret_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/devise_dynamic_password_length_validation.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/devise_password_length.rb.example @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/gitlab_shell_secret_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/omniauth.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/rails_host_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/rails_host_authorization_gitpod.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers/webauthn.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers_before_autoloader/100_patch_omniauth_oauth2.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/initializers_before_autoloader/100_patch_omniauth_saml.rb @gitlab-org/manage/authentication-and-authorization/approvers -/config/weak_password_digests.yml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/audit_events/components/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/audit_events/token_utils.js @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/batch_comments/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/groups/settings/components/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/pages/admin/application_settings/general/components/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/pages/groups/omniauth_callbacks/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/pages/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/pages/profiles/passwords/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/password/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/requirements/components/tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/saml_providers/scim_token_service.js @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/saml_sso/components/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_auth.vue @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/concerns/ee/authenticates_with_two_factor.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/concerns/ee/enforces_two_factor_authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/concerns/saml_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/ee/ldap/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/ee/omniauth_callbacks_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/ee/passwords_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/ee/sessions_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/groups/omniauth_callbacks_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/groups/scim_oauth_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/omniauth_kerberos_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/controllers/users/identity_verification_controller.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/finders/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/helpers/ee/access_tokens_helper.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/helpers/ee/auth_helper.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/helpers/ee/personal_access_tokens_helper.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/models/concerns/identity_verifiable.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/models/concerns/password_complexity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/models/ee/personal_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/models/ee/project_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/models/scim_oauth_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/serializers/scim_oauth_access_token_entity.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/arkose/token_verification_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/ee/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/ee/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/ee/resource_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/ee/users/authorized_build_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/security/token_revocation_service.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/services/users/email_verification/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/validators/password/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/admin/application_settings/_personal_access_token_expiration_policy.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/credentials_inventory_mailer/personal_access_token_revoked_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/credentials_inventory_mailer/personal_access_token_revoked_email.text.haml @gitlab-org/manage/authentication-and-authorization/approvers -/app/views/devise/**/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/groups/_personal_access_token_expiration_policy.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/groups/sso/_authorize_pane.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/notify/policy_revoked_personal_access_tokens_email.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/notify/policy_revoked_personal_access_tokens_email.text.erb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/shared/_password_requirements_list.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/shared/credentials_inventory/_personal_access_tokens.html.haml @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/views/shared/credentials_inventory/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/workers/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/app/workers/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/config/routes/oauth.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/ee/gitlab/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/ee/gitlab/omniauth_initializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/gitlab/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/gitlab/authority_analyzer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/gitlab/geo/oauth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/gitlab/kerberos/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/omni_auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/system_check/geo/authorized_keys_check.rb @gitlab-org/manage/authentication-and-authorization/approvers -/ee/lib/system_check/geo/authorized_keys_flag_check.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/impersonation_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/impersonation_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/personal_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/personal_access_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/resource_access_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/entities/resource_access_token_with_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/helpers/authentication.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/helpers/packages/basic_auth_helpers.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/helpers/personal_access_tokens_helpers.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/personal_access_tokens/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/personal_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/resource_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/api/support/token_with_expiration.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/api_authentication/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/auth.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/auth_logger.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/authorized_keys.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/background_migration/encrypt_static_object_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/background_migration/expire_o_auth_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/background_migration/migrate_u2f_webauthn.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/chat_name_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/cleanup/personal_access_tokens.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/external_authorization/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/external_authorization.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/grape_logging/loggers/token_logger.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/graphql/authorize/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/jwt_authenticatable.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/jwt_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/lfs_token.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/mail_room/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/omniauth_initializer.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/gitlab/project_authorizations.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/json_web_token/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/omni_auth/ @gitlab-org/manage/authentication-and-authorization/approvers -/lib/security/weak_passwords.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/system_check/app/authorized_keys_permission_check.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/system_check/incoming_email/imap_authentication_check.rb @gitlab-org/manage/authentication-and-authorization/approvers -/lib/tasks/gitlab/password.rake @gitlab-org/manage/authentication-and-authorization/approvers -/lib/tasks/tokens.rake @gitlab-org/manage/authentication-and-authorization/approvers +[Authentication and Authorization] @gitlab-org/manage/authentication-and-authorization/approvers +/app/assets/javascripts/access_tokens/ +/app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql +/app/assets/javascripts/authentication/ +/app/assets/javascripts/ide/components/shared/tokened_input.vue +/app/assets/javascripts/packages_and_registries/package_registry/components/list/tokens/ +/app/assets/javascripts/pages/admin/impersonation_tokens/ +/app/assets/javascripts/pages/groups/settings/access_tokens/ +/app/assets/javascripts/pages/ldap/ +/app/assets/javascripts/pages/oauth/ +/app/assets/javascripts/pages/omniauth_callbacks/ +/app/assets/javascripts/pages/profiles/password_prompt/ +/app/assets/javascripts/pages/profiles/personal_access_tokens/ +/app/assets/javascripts/pages/profiles/two_factor_auths/ +/app/assets/javascripts/pages/projects/settings/access_tokens/ +/app/assets/javascripts/pages/sessions/new/oauth_remember_me.js +/app/assets/javascripts/projects/settings/topics/components/ +/app/assets/javascripts/related_issues/components/issue_token.vue +/app/assets/stylesheets/page_bundles/profile_two_factor_auth.scss +/app/controllers/admin/impersonation_tokens_controller.rb +/app/controllers/concerns/access_tokens_actions.rb +/app/controllers/concerns/authenticates_with_two_factor.rb +/app/controllers/concerns/authenticates_with_two_factor_for_admin_mode.rb +/app/controllers/concerns/enforces_admin_authentication.rb +/app/controllers/concerns/enforces_two_factor_authentication.rb +/app/controllers/concerns/oauth_applications.rb +/app/controllers/concerns/project_unauthorized.rb +/app/models/concerns/require_email_verification.rb +/app/controllers/concerns/sessionless_authentication.rb +/app/controllers/concerns/snippet_authorizations.rb +/app/controllers/concerns/verifies_with_email.rb +/app/controllers/concerns/workhorse_authorization.rb +/app/controllers/groups/settings/access_tokens_controller.rb +/app/controllers/ldap/ +/app/controllers/oauth/ +/app/controllers/omniauth_callbacks_controller.rb +/app/controllers/passwords_controller.rb +/app/controllers/profiles/passwords_controller.rb +/app/controllers/profiles/personal_access_tokens_controller.rb +/app/controllers/profiles/two_factor_auths_controller.rb +/app/controllers/profiles/webauthn_registrations_controller.rb +/app/controllers/projects/settings/access_tokens_controller.rb +/app/controllers/sessions_controller.rb +/app/finders/groups/projects_requiring_authorizations_refresh/ +/app/finders/personal_access_tokens_finder.rb +/app/helpers/access_tokens_helper.rb +/app/helpers/auth_helper.rb +/app/models/authentication_event.rb +/app/models/concerns/admin_changed_password_notifier.rb +/app/models/concerns/mirror_authentication.rb +/app/models/concerns/select_for_project_authorization.rb +/app/models/concerns/token_authenticatable.rb +/app/models/concerns/token_authenticatable_strategies/ +/app/models/oauth_access_grant.rb +/app/models/oauth_access_token.rb +/app/models/personal_access_token.rb +/app/models/project_authorization.rb +/app/models/token_with_iv.rb +/app/models/webauthn_registration.rb +/app/policies/personal_access_token_policy.rb +/app/serializers/access_token_entity_base.rb +/app/serializers/group_access_token_entity.rb +/app/serializers/group_access_token_serializer.rb +/app/serializers/impersonation_access_token_entity.rb +/app/serializers/impersonation_access_token_serializer.rb +/app/serializers/personal_access_token_entity.rb +/app/serializers/personal_access_token_serializer.rb +/app/serializers/project_access_token_entity.rb +/app/serializers/project_access_token_serializer.rb +/app/services/access_token_validation_service.rb +/app/services/auth/ +/app/services/authorized_project_update/ +/app/services/chat_names/authorize_user_service.rb +/app/services/personal_access_tokens/ +/app/services/projects/move_project_authorizations_service.rb +/app/services/resource_access_tokens/ +/app/services/todos/destroy/unauthorized_features_service.rb +/app/services/users/authorized_build_service.rb +/app/services/users/authorized_create_service.rb +/app/services/users/email_verification/ +/app/services/users/refresh_authorized_projects_service.rb +/app/services/webauthn/ +/app/validators/json_schemas/cluster_agent_authorization_configuration.json +/app/views/admin/application_settings/_external_authorization_service_form.html.haml +/app/views/admin/impersonation_tokens/ +/app/views/authentication/ +/app/views/dashboard/projects/_zero_authorized_projects.html.haml +/app/views/devise/mailer/password_change.html.haml +/app/views/devise/mailer/password_change.text.erb +/app/views/devise/mailer/password_change_by_admin.html.haml +/app/views/devise/mailer/password_change_by_admin.text.erb +/app/views/devise/mailer/reset_password_instructions.html.haml +/app/views/devise/mailer/reset_password_instructions.text.erb +/app/views/devise/**/ +/app/views/doorkeeper/authorizations/ +/app/views/doorkeeper/authorized_applications/ +/app/views/errors/omniauth_error.html.haml +/app/views/groups/settings/_resource_access_token_creation.html.haml +/app/views/groups/settings/_two_factor_auth.html.haml +/app/views/groups/settings/access_tokens/ +/app/views/layouts/oauth_error.html.haml +/app/views/notify/access_token_about_to_expire_email.html.haml +/app/views/notify/access_token_about_to_expire_email.text.erb +/app/views/notify/access_token_created_email.html.haml +/app/views/notify/access_token_created_email.text.erb +/app/views/notify/access_token_expired_email.html.haml +/app/views/notify/access_token_expired_email.text.erb +/app/views/notify/access_token_revoked_email.html.haml +/app/views/notify/access_token_revoked_email.text.erb +/app/views/profiles/passwords/ +/app/views/profiles/personal_access_tokens/ +/app/views/profiles/two_factor_auths/ +/app/views/projects/mirrors/_authentication_method.html.haml +/app/views/projects/settings/access_tokens/ +/app/views/shared/_no_password.html.haml +/app/views/shared/_two_factor_auth_recovery_settings_check.html.haml +/app/views/shared/access_tokens/ +/app/views/shared/members/_two_factor_auth_badge.html.haml +/app/views/shared/tokens/ +/app/workers/authorized_keys_worker.rb +/app/workers/authorized_project_update/ +/app/workers/authorized_projects_worker.rb +/app/workers/personal_access_tokens/ +/config/initializers/01_secret_token.rb +/config/initializers/devise_dynamic_password_length_validation.rb +/config/initializers/devise_password_length.rb.example +/config/initializers/gitlab_shell_secret_token.rb +/config/initializers/omniauth.rb +/config/initializers/rails_host_authorization.rb +/config/initializers/rails_host_authorization_gitpod.rb +/config/initializers/webauthn.rb +/config/initializers_before_autoloader/100_patch_omniauth_oauth2.rb +/config/initializers_before_autoloader/100_patch_omniauth_saml.rb +/config/weak_password_digests.yml +/ee/app/assets/javascripts/access_tokens/ +/ee/app/assets/javascripts/audit_events/components/tokens/ +/ee/app/assets/javascripts/audit_events/token_utils.js +/ee/app/assets/javascripts/batch_comments/ +/ee/app/assets/javascripts/groups/settings/components/ +/ee/app/assets/javascripts/pages/admin/application_settings/general/components/ +/ee/app/assets/javascripts/pages/groups/omniauth_callbacks/ +/ee/app/assets/javascripts/pages/passwords/ +/ee/app/assets/javascripts/pages/profiles/passwords/ +/ee/app/assets/javascripts/password/ +/ee/app/assets/javascripts/requirements/components/tokens/ +/ee/app/assets/javascripts/saml_providers/scim_token_service.js +/ee/app/assets/javascripts/saml_sso/components/ +/ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_auth.vue +/ee/app/controllers/concerns/ee/authenticates_with_two_factor.rb +/ee/app/controllers/concerns/ee/enforces_two_factor_authentication.rb +/ee/app/controllers/concerns/saml_authorization.rb +/ee/app/controllers/ee/ldap/ +/ee/app/controllers/ee/omniauth_callbacks_controller.rb +/ee/app/controllers/ee/passwords_controller.rb +/ee/app/controllers/ee/sessions_controller.rb +/ee/app/controllers/groups/omniauth_callbacks_controller.rb +/ee/app/controllers/groups/scim_oauth_controller.rb +/ee/app/controllers/oauth/ +/ee/app/controllers/omniauth_kerberos_controller.rb +/ee/app/controllers/users/identity_verification_controller.rb +/ee/app/finders/auth/ +/ee/app/helpers/ee/access_tokens_helper.rb +/ee/app/helpers/ee/auth_helper.rb +/ee/app/helpers/ee/personal_access_tokens_helper.rb +/ee/app/models/concerns/identity_verifiable.rb +/ee/app/models/concerns/password_complexity.rb +/ee/app/models/ee/personal_access_token.rb +/ee/app/models/ee/project_authorization.rb +/ee/app/models/scim_oauth_access_token.rb +/ee/app/serializers/scim_oauth_access_token_entity.rb +/ee/app/services/arkose/token_verification_service.rb +/ee/app/services/ee/auth/ +/ee/app/services/ee/personal_access_tokens/ +/ee/app/services/ee/resource_access_tokens/ +/ee/app/services/ee/users/authorized_build_service.rb +/ee/app/services/personal_access_tokens/ +/ee/app/services/security/token_revocation_service.rb +/ee/app/services/users/email_verification/ +/ee/app/validators/password/ +/ee/app/views/admin/application_settings/_personal_access_token_expiration_policy.html.haml +/ee/app/views/credentials_inventory_mailer/personal_access_token_revoked_email.html.haml +/ee/app/views/credentials_inventory_mailer/personal_access_token_revoked_email.text.haml +/app/views/devise/**/ +/ee/app/views/groups/_personal_access_token_expiration_policy.html.haml +/ee/app/views/groups/sso/_authorize_pane.html.haml +/ee/app/views/notify/policy_revoked_personal_access_tokens_email.html.haml +/ee/app/views/notify/policy_revoked_personal_access_tokens_email.text.erb +/ee/app/views/oauth/ +/ee/app/views/shared/_password_requirements_list.html.haml +/ee/app/views/shared/credentials_inventory/_personal_access_tokens.html.haml +/ee/app/views/shared/credentials_inventory/personal_access_tokens/ +/ee/app/workers/auth/ +/ee/app/workers/personal_access_tokens/ +/ee/config/routes/oauth.rb +/ee/lib/ee/gitlab/auth/ +/ee/lib/ee/gitlab/omniauth_initializer.rb +/ee/lib/gitlab/auth/ +/ee/lib/gitlab/authority_analyzer.rb +/ee/lib/gitlab/geo/oauth/ +/ee/lib/gitlab/kerberos/ +/ee/lib/omni_auth/ +/ee/lib/system_check/geo/authorized_keys_check.rb +/ee/lib/system_check/geo/authorized_keys_flag_check.rb +/lib/api/entities/impersonation_token.rb +/lib/api/entities/impersonation_token_with_token.rb +/lib/api/entities/personal_access_token.rb +/lib/api/entities/personal_access_token_with_token.rb +/lib/api/entities/resource_access_token.rb +/lib/api/entities/resource_access_token_with_token.rb +/lib/api/helpers/authentication.rb +/lib/api/helpers/packages/basic_auth_helpers.rb +/lib/api/helpers/personal_access_tokens_helpers.rb +/lib/api/personal_access_tokens/ +/lib/api/personal_access_tokens.rb +/lib/api/resource_access_tokens.rb +/lib/api/support/token_with_expiration.rb +/lib/gitlab/api_authentication/ +/lib/gitlab/auth/ +/lib/gitlab/auth.rb +/lib/gitlab/auth_logger.rb +/lib/gitlab/authorized_keys.rb +/lib/gitlab/background_migration/encrypt_static_object_token.rb +/lib/gitlab/background_migration/expire_o_auth_tokens.rb +/lib/gitlab/background_migration/migrate_u2f_webauthn.rb +/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb +/lib/gitlab/chat_name_token.rb +/lib/gitlab/cleanup/personal_access_tokens.rb +/lib/gitlab/external_authorization/ +/lib/gitlab/external_authorization.rb +/lib/gitlab/grape_logging/loggers/token_logger.rb +/lib/gitlab/graphql/authorize/ +/lib/gitlab/jwt_authenticatable.rb +/lib/gitlab/jwt_token.rb +/lib/gitlab/lfs_token.rb +/lib/gitlab/mail_room/ +/lib/gitlab/omniauth_initializer.rb +/lib/gitlab/project_authorizations.rb +/lib/json_web_token/ +/lib/omni_auth/ +/lib/security/weak_passwords.rb +/lib/system_check/app/authorized_keys_permission_check.rb +/lib/system_check/incoming_email/imap_authentication_check.rb +/lib/tasks/gitlab/password.rake +/lib/tasks/tokens.rake -[Verify] @gitlab-org/maintainers/cicd-verify @shinya.maeda @stanhu @ayufan -# Verify Backend +[Verify] @gitlab-org/maintainers/cicd-verify @shinya.maeda @stanhu @ayufan +# With these catch-all rules we will require backend approval and use it as an +# opportunity to refine specific rules defined in this section. +# Note that frontend, CI templates and other concerns should be kept within +# the same section. /**/app/**/ci/ /**/lib/**/ci/ -/**/spec/**/ci/ /**/app/**/merge_trains/ -/**/spec/**/merge_trains/ /app/controllers/admin/jobs_controller.rb /app/controllers/admin/runner_projects_controller.rb /app/controllers/admin/runners_controller.rb @@ -1295,60 +1302,70 @@ lib/gitlab/checks/** @proglottis @toon /ee/app/workers/clear_shared_runners_minutes_worker.rb /ee/lib/api/merge_trains.rb /ee/lib/ee/api/entities/merge_train.rb -/ee/spec/requests/api/merge_trains_spec.rb -/spec/controllers/admin/jobs_controller_spec.rb -/spec/controllers/admin/runner_projects_controller_spec.rb -/spec/controllers/admin/runners_controller_spec.rb -/spec/controllers/projects/artifacts_controller_spec.rb -/spec/controllers/projects/jobs_controller_spec.rb -/spec/requests/runner_setup_controller_spec.rb -/spec/controllers/projects/pipeline_schedules_controller_spec.rb -/spec/requests/projects/pipelines_controller_spec.rb -/spec/controllers/projects/pipelines_settings_controller_spec.rb -/spec/controllers/projects/runners_controller_spec.rb -/spec/controllers/groups/variables_controller_spec.rb -/spec/models/commit_status_spec.rb -/spec/models/external_pull_request_spec.rb -/spec/models/generic_commit_status_spec.rb -/spec/models/namespace_ci_cd_setting_spec.rb -/spec/models/project_ci_cd_setting_spec.rb -/spec/presenters/commit_status_presenter_spec.rb -/spec/views/projects/jobs/ -/spec/views/projects/pipeline_schedules/ -/spec/views/projects/pipelines/ -/spec/views/projects/settings/ci_cd/ -/spec/workers/build_hooks_worker_spec.rb -/spec/workers/build_queue_worker_spec.rb -/spec/workers/build_success_worker_spec.rb -/spec/workers/ci_platform_metrics_update_cron_worker_spec.rb -/spec/workers/create_pipeline_worker_spec.rb -/spec/workers/expire_build_artifacts_worker_spec.rb -/spec/workers/pipeline_hooks_worker_spec.rb -/spec/workers/pipeline_metrics_worker_spec.rb -/spec/workers/pipeline_notification_worker_spec.rb -/spec/workers/pipeline_process_worker_spec.rb -/spec/workers/pipeline_schedule_worker_spec.rb -/spec/workers/run_pipeline_schedule_worker_spec.rb -/spec/workers/stuck_ci_jobs_worker_spec.rb -/spec/workers/update_external_pull_requests_worker_spec.rb -/ee/spec/finders/merge_trains_finder_spec.rb -/ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb -/ee/spec/services/auto_merge/merge_train_service_spec.rb -/ee/spec/services/system_notes/merge_train_service_spec.rb -/ee/spec/controllers/projects/subscriptions_controller_spec.rb -/ee/spec/helpers/ee/projects/pipeline_helper_spec.rb -/ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb -# Verify Frontend -/**/spec/frontend/**/ci/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/ci/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/pipelines/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/jobs/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/token_access/ @gitlab-org/ci-cd/verify/frontend -/**/javascripts/admin/application_settings/runner_token_expiration/ @gitlab-org/ci-cd/verify/frontend +# Overrides for Verify. These files below require approval from teams outside Verify. +/**/lib/**/ci/reports/**/ @gitlab-org/maintainers/rails-backend +/**/lib/**/ci/parsers/**/ @gitlab-org/maintainers/rails-backend +/ee/lib/gitlab/ci/parsers/license_compliance/ @gitlab-org/secure/composition-analysis-be +/ee/lib/gitlab/ci/parsers/security/ @gitlab-org/govern/threat-insights-backend-team +/ee/lib/gitlab/ci/reports/coverage_fuzzing/ @gitlab-org/secure/fuzzing-be +/ee/lib/gitlab/ci/reports/dependency_list/ @gitlab-org/secure/composition-analysis-be +/ee/lib/gitlab/ci/reports/license_scanning/ @gitlab-org/secure/composition-analysis-be +/ee/lib/gitlab/ci/reports/security/ @gitlab-org/govern/threat-insights-backend-team + +# Verify frontend +/**/javascripts/ci/ @gitlab-org/ci-cd/verify/frontend +/**/javascripts/pipelines/ @gitlab-org/ci-cd/verify/frontend +/**/javascripts/jobs/ @gitlab-org/ci-cd/verify/frontend +/**/javascripts/token_access/ @gitlab-org/ci-cd/verify/frontend +/**/javascripts/admin/application_settings/runner_token_expiration/ @gitlab-org/ci-cd/verify/frontend /**/javascripts/usage_quotas/pipelines/ @gitlab-org/ci-cd/verify/frontend @sheldonled @aalakkad @kpalchyk -# CI/CD templates +## Verify:Runner Fleet Backend + +/app/controllers/admin/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/controllers/concerns/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/controllers/groups/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/controllers/projects/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/controllers/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/finders/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/mutations/ci/runner/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/resolvers/ci/*_runners_resolver.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/resolvers/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/types/ci/runner_*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/types/namespace/shared_runners_setting_enum.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/graphql/types/permission_types/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/models/ci/build_runner_session.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/models/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/models/concerns/ci/has_runner_executor.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/models/concerns/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/models/preloaders/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/policies/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/presenters/ci/runner_*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/serializers/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/services/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/app/workers/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/db/docs/ci_runner*.yml @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/controllers/ee/admin/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/controllers/ee/groups/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/graphql/ee/mutations/ci/runner/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/graphql/ee/types/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/graphql/resolvers/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/models/ee/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/policies/ee/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/services/audit_events/*runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/services/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/services/ee/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/ee/app/workers/ci/runners/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/api/ci/helpers/runner.rb @gitlab-org/maintainers/cicd-verify @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/api/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/api/ci/runner.rb @gitlab-org/maintainers/cicd-verify @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/api/entities/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/gitlab/audit/ci_runner_token_author.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/gitlab/ci/runner*.rb @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/gitlab/seeders/ci/runner/ @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +/lib/tasks/gitlab/seed/runner_fleet.rake @gitlab-org/ci-cd/runner-fleet-team/backend-approvers +# CI/CD templates require approval from specific owners. /lib/gitlab/ci/templates/ @gitlab-org/maintainers/cicd-templates /lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml @DylanGriffith @mayra-cabrera @tkuah /lib/gitlab/ci/templates/Security/ @gonzoyumo @twoodham @sethgitlab @thiagocsf @@ -1368,95 +1385,96 @@ lib/gitlab/checks/** @proglottis @toon /lib/gitlab/ci/templates/Jobs/SAST.*.yml @gitlab-org/secure/static-analysis /lib/gitlab/ci/templates/Jobs/Secret-Detection.*.yml @gitlab-org/secure/static-analysis -[Manage::Workspace] -lib/api/entities/basic_project_details.rb @gitlab-org/manage/manage-workspace/backend-approvers -lib/api/entities/project_with_access.rb @gitlab-org/manage/manage-workspace/backend-approvers -lib/api/entities/project_identity.rb @gitlab-org/manage/manage-workspace/backend-approvers -lib/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-approvers -ee/lib/ee/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-approvers +[Data Stores::Tenant Scale] @abdwdd @alexpooley @manojmj +lib/api/entities/basic_project_details.rb +lib/api/entities/project_with_access.rb +lib/api/entities/project_identity.rb +lib/api/entities/project.rb +ee/lib/ee/api/entities/project.rb -[Compliance] -/app/services/audit_events/build_service.rb @gitlab-org/govern/compliance -/ee/spec/services/audit_events/custom_audit_event_service_spec.rb @gitlab-org/govern/compliance -/app/models/audit_event.rb @gitlab-org/govern/compliance -/app/services/audit_event_service.rb @gitlab-org/govern/compliance -/app/services/concerns/audit_event_save_type.rb @gitlab-org/govern/compliance -/app/views/profiles/audit_log.html.haml @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_app.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_export_button.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_filter.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_log.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_stream.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/audit_events_table.vue @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/components/tokens/shared/ @gitlab-org/govern/compliance -/ee/app/assets/javascripts/audit_events/init_audit_events.js @gitlab-org/govern/compliance -/ee/app/controllers/admin/audit_log_reports_controller.rb @gitlab-org/govern/compliance -/ee/app/controllers/admin/audit_logs_controller.rb @gitlab-org/govern/compliance -/ee/app/controllers/concerns/audit_events/audit_events_params.rb @gitlab-org/govern/compliance -/ee/app/controllers/groups/audit_events_controller.rb @gitlab-org/govern/compliance -/ee/app/controllers/projects/audit_events_controller.rb @gitlab-org/govern/compliance -/ee/app/finders/audit_event_finder.rb @gitlab-org/govern/compliance -/ee/app/graphql/types/audit_events/external_audit_event_destination_type.rb @gitlab-org/govern/compliance -/ee/app/helpers/audit_events_helper.rb @gitlab-org/govern/compliance -/ee/app/helpers/auditor_user_helper.rb @gitlab-org/govern/compliance -/ee/app/models/audit_events/external_audit_event_destination.rb @gitlab-org/govern/compliance -/ee/app/models/concerns/auditable.rb @gitlab-org/govern/compliance -/ee/app/models/ee/audit_event.rb @gitlab-org/govern/compliance -/ee/app/policies/audit_events/external_audit_event_destination_policy.rb @gitlab-org/govern/compliance -/ee/app/presenters/audit_event_presenter.rb @gitlab-org/govern/compliance -/ee/app/serializers/audit_event_entity.rb @gitlab-org/govern/compliance -/ee/app/serializers/audit_event_serializer.rb @gitlab-org/govern/compliance -/ee/app/services/ci/audit_variable_change_service.rb @gitlab-org/govern/compliance -/ee/app/services/ee/audit_event_service.rb @gitlab-org/govern/compliance -/ee/app/views/admin/users/_auditor_access_level_radio.html.haml @gitlab-org/govern/compliance -/ee/app/views/admin/users/_auditor_user_badge.html.haml @gitlab-org/govern/compliance -/ee/app/views/shared/icons/_icon_audit_events_purple.svg @gitlab-org/govern/compliance -/ee/app/views/shared/promotions/_promote_audit_events.html.haml @gitlab-org/govern/compliance -/ee/app/workers/audit_events/audit_event_streaming_worker.rb @gitlab-org/govern/compliance -/ee/config/events/1652263097_groups__audit_events__index_click_streams_tab.yml @gitlab-org/govern/compliance -/ee/config/events/202108302307_admin_audit_logs_index_click_date_range_button.yml @gitlab-org/govern/compliance -/ee/config/events/202108302307_groups__audit_events_controller_search_audit_event.yml @gitlab-org/govern/compliance -/ee/config/events/202108302307_profiles_controller_search_audit_event.yml @gitlab-org/govern/compliance -/ee/config/events/202108302307_projects__audit_events_controller_search_audit_event.yml @gitlab-org/govern/compliance -/ee/config/events/202111041910_admin__audit_logs_controller_search_audit_event.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_28d/20210216183930_g_compliance_audit_events_monthly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_28d/20210216183934_i_compliance_audit_events_monthly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_28d/20210216183942_a_compliance_audit_events_api_monthly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_28d/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183906_g_compliance_audit_events.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183908_i_compliance_audit_events.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183912_a_compliance_audit_events_api.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183928_g_compliance_audit_events_weekly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183932_i_compliance_audit_events_weekly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_7d/20210216183940_a_compliance_audit_events_api_weekly.yml @gitlab-org/govern/compliance -/ee/config/metrics/counts_all/20211130085433_g_manage_compliance_audit_event_destinations.yml @gitlab-org/govern/compliance -/ee/lib/api/audit_events.rb @gitlab-org/govern/compliance -/ee/lib/audit/ @gitlab-org/govern/compliance -/ee/lib/ee/api/entities/audit_event.rb @gitlab-org/govern/compliance -/ee/lib/ee/gitlab/audit/ @gitlab-org/govern/compliance -/lib/gitlab/audit/auditor.rb @gitlab-org/govern/compliance -/lib/gitlab/audit_json_logger.rb @gitlab-org/govern/compliance +[Compliance] @gitlab-org/govern/compliance +/app/services/audit_events/build_service.rb +/ee/app/services/ee/audit_events/build_service.rb +/ee/spec/services/audit_events/custom_audit_event_service_spec.rb +/app/models/audit_event.rb +/app/services/audit_event_service.rb +/app/services/concerns/audit_event_save_type.rb +/app/views/profiles/audit_log.html.haml +/ee/app/assets/javascripts/audit_events/ +/ee/app/controllers/admin/audit_log_reports_controller.rb +/ee/app/controllers/admin/audit_logs_controller.rb +/ee/app/controllers/concerns/audit_events/audit_events_params.rb +/ee/app/controllers/groups/audit_events_controller.rb +/ee/app/controllers/projects/audit_events_controller.rb +/ee/app/finders/audit_event_finder.rb +/ee/app/graphql/types/audit_events/ +/ee/app/helpers/audit_events_helper.rb +/ee/app/helpers/auditor_user_helper.rb +/ee/app/models/audit_events/external_audit_event_destination.rb +/ee/app/models/concerns/auditable.rb +/ee/app/models/ee/audit_event.rb +/ee/app/policies/audit_events/external_audit_event_destination_policy.rb +/ee/app/presenters/audit_event_presenter.rb +/ee/app/serializers/audit_event_entity.rb +/ee/app/serializers/audit_event_serializer.rb +/ee/app/services/ci/audit_variable_change_service.rb +/ee/app/services/ee/audit_event_service.rb +/ee/app/views/admin/users/_auditor_access_level_radio.html.haml +/ee/app/views/admin/users/_auditor_user_badge.html.haml +/ee/app/views/shared/icons/_icon_audit_events_purple.svg +/ee/app/views/shared/promotions/_promote_audit_events.html.haml +/ee/app/workers/audit_events/audit_event_streaming_worker.rb +/ee/config/events/1652263097_groups__audit_events__index_click_streams_tab.yml +/ee/config/events/202108302307_admin_audit_logs_index_click_date_range_button.yml +/ee/config/events/202108302307_groups__audit_events_controller_search_audit_event.yml +/ee/config/events/202108302307_profiles_controller_search_audit_event.yml +/ee/config/events/202108302307_projects__audit_events_controller_search_audit_event.yml +/ee/config/events/202111041910_admin__audit_logs_controller_search_audit_event.yml +/ee/config/metrics/counts_28d/20210216183930_g_compliance_audit_events_monthly.yml +/ee/config/metrics/counts_28d/20210216183934_i_compliance_audit_events_monthly.yml +/ee/config/metrics/counts_28d/20210216183942_a_compliance_audit_events_api_monthly.yml +/ee/config/metrics/counts_28d/20211130085433_g_manage_compliance_audit_event_destinations.yml +/ee/config/metrics/counts_7d/20210216183906_g_compliance_audit_events.yml +/ee/config/metrics/counts_7d/20210216183908_i_compliance_audit_events.yml +/ee/config/metrics/counts_7d/20210216183912_a_compliance_audit_events_api.yml +/ee/config/metrics/counts_7d/20210216183928_g_compliance_audit_events_weekly.yml +/ee/config/metrics/counts_7d/20210216183932_i_compliance_audit_events_weekly.yml +/ee/config/metrics/counts_7d/20210216183940_a_compliance_audit_events_api_weekly.yml +/ee/config/metrics/counts_all/20211130085433_g_manage_compliance_audit_event_destinations.yml +/ee/lib/api/audit_events.rb +/ee/lib/audit/ +/ee/lib/ee/api/entities/audit_event.rb +/ee/lib/ee/gitlab/audit/ +/lib/gitlab/audit/auditor.rb +/lib/gitlab/audit_json_logger.rb +/ee/app/graphql/mutations/audit_events/ +/ee/app/models/concerns/audit_events/ +/ee/app/views/projects/audit_events/ +/app/controllers/groups/releases_controller.rb +/app/controllers/projects/releases/evidences_controller.rb +/app/workers/releases/create_evidence_worker.rb +/app/workers/releases/manage_evidence_worker.rb -[Fulfillment::Utilization] -/ee/app/assets/javascripts/usage_quotas/components/ @sheldonled @aalakkad @kpalchyk -/ee/app/assets/javascripts/usage_quotas/seats/ @sheldonled @aalakkad @kpalchyk -/ee/app/assets/javascripts/usage_quotas/storage/ @sheldonled @aalakkad @kpalchyk +[Fulfillment::Utilization] @sheldonled @aalakkad @kpalchyk +/ee/app/assets/javascripts/usage_quotas/components/ +/ee/app/assets/javascripts/usage_quotas/seats/ +/ee/app/assets/javascripts/usage_quotas/storage/ -[Manage::Foundations] -/lib/sidebars/ @gitlab-org/manage/foundations/engineering -/ee/lib/sidebars/ @gitlab-org/manage/foundations/engineering +[Manage::Foundations] @gitlab-org/manage/foundations/engineering +/lib/sidebars/ +/ee/lib/sidebars/ # JiHu GitLab rules. See https://gitlab.com/gitlab-jh/gitlab-jh-enablement/-/issues/213#note_1024367528 [JH Frontend] @jihulab/maintainers/frontend /jh/app/assets/ -/jh/*.scss -/jh/*.js -/jh/*.vue +/jh/**/*.scss +/jh/**/*.js +/jh/**/*.vue [JH Rails Backend] @jihulab/maintainers/rails-backend -/jh/*.rb -/jh/*.rake +/jh/**/*.rb +/jh/**/*.rake /jh/qa/ @jihulab/maintainers/quality [JH Technical Writer] @jihulab/maintainers/technical-writer diff --git a/.gitlab/ci/as-if-jh.gitlab-ci.yml b/.gitlab/ci/as-if-jh.gitlab-ci.yml index 2c90112bbf..ae589ddfc2 100644 --- a/.gitlab/ci/as-if-jh.gitlab-ci.yml +++ b/.gitlab/ci/as-if-jh.gitlab-ci.yml @@ -1,9 +1,13 @@ -.shared-as-if-jh: +.as-if-jh-sandbox-variables: variables: - SANDBOX_PROJECT: "gitlab-org-sandbox/gitlab-jh-validation" - SANDBOX_REPOSITORY: "https://dummy:${AS_IF_JH_TOKEN}@gitlab.com/${SANDBOX_PROJECT}.git" - GITLAB_JH_MIRROR_PROJECT: "33019816" AS_IF_JH_BRANCH: "as-if-jh/${CI_COMMIT_REF_NAME}" + SANDBOX_REPOSITORY: "https://dummy:${AS_IF_JH_TOKEN}@gitlab.com/gitlab-org-sandbox/gitlab-jh-validation.git" + +.shared-as-if-jh: + extends: + - .as-if-jh-sandbox-variables + variables: + GITLAB_JH_MIRROR_PROJECT: "33019816" JH_FILES_TO_COMMIT: "jh package.json yarn.lock" add-jh-files: @@ -42,30 +46,61 @@ prepare-as-if-jh-branch: # so instead we tell runner to not clone anything, and we set up the # repository by ourselves. GIT_STRATEGY: "none" - script: - - git clone --filter=tree:0 "$CI_REPOSITORY_URL" gitlab + before_script: + - git clone --filter=tree:0 "${CI_REPOSITORY_URL}" gitlab # We should checkout before moving/changing files - cd gitlab - git checkout -b "${AS_IF_JH_BRANCH}" "${CI_COMMIT_SHA}" - cd .. - - mv $JH_FILES_TO_COMMIT gitlab/ + - mv ${JH_FILES_TO_COMMIT} gitlab/ + script: - cd gitlab - git add ${JH_FILES_TO_COMMIT} - git commit -m 'Add JH files' # TODO: Mark which SHA we add - git push -f "${SANDBOX_REPOSITORY}" "${AS_IF_JH_BRANCH}" -start-as-if-jh: +sync-as-if-jh-branch: extends: - - .shared-as-if-jh - - .as-if-jh:rules:start-as-if-jh + - .as-if-jh-sandbox-variables + - .as-if-jh:rules:sync-as-if-jh stage: prepare needs: ["prepare-as-if-jh-branch"] + inherit: + variables: + # From .gitlab-ci.yml for the default Docker image and cache + - DEFAULT_CI_IMAGE + - REGISTRY_HOST + - REGISTRY_GROUP + - DEBIAN_VERSION + - RUBY_VERSION + - GO_VERSION + - RUST_VERSION + - PG_VERSION + - RUBYGEMS_VERSION + - CHROME_VERSION + - NODE_ENV + variables: + MERGE_FROM: "${CI_COMMIT_SHA}" # This is used in https://jihulab.com/gitlab-cn/gitlab/-/blob/e98bcb37aea4cfe1e78e1daef1b58b5f732cf289/jh/bin/build_packagejson where we run in https://gitlab.com/gitlab-org-sandbox/gitlab-jh-validation + trigger: + # What this runs can be found at: + # https://gitlab.com/gitlab-org-sandbox/gitlab-jh-validation/-/blob/as-if-jh-code-sync/jh/.gitlab-ci.yml + project: gitlab-org-sandbox/gitlab-jh-validation + branch: as-if-jh-code-sync + strategy: depend + +start-as-if-jh: + extends: + - .as-if-jh:rules:start-as-if-jh + stage: prepare + needs: + - job: "prepare-as-if-jh-branch" + - job: "sync-as-if-jh-branch" + optional: true inherit: variables: false variables: - AS_IF_EDITION: "jh" FORCE_GITLAB_CI: "true" # TODO: Trigger a merge request pipeline trigger: - project: gitlab-org-sandbox/gitlab-jh-validation # ${SANDBOX_PROJECT} does not work here - branch: as-if-jh/${CI_COMMIT_REF_NAME} # ${AS_IF_JH_BRANCH} does not work here + project: gitlab-org-sandbox/gitlab-jh-validation + branch: as-if-jh/${CI_COMMIT_REF_NAME} strategy: depend diff --git a/.gitlab/ci/build-images.gitlab-ci.yml b/.gitlab/ci/build-images.gitlab-ci.yml index c1123b29d6..b866446c6e 100644 --- a/.gitlab/ci/build-images.gitlab-ci.yml +++ b/.gitlab/ci/build-images.gitlab-ci.yml @@ -1,13 +1,13 @@ .base-image-build: extends: .use-kaniko variables: - GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs + GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs retry: 2 .base-image-build-buildx: extends: .use-buildx variables: - GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs + GIT_LFS_SKIP_SMUDGE: 1 # disable pulling objects from lfs retry: 2 # This image is used by: diff --git a/.gitlab/ci/dev-fixtures.gitlab-ci.yml b/.gitlab/ci/dev-fixtures.gitlab-ci.yml index f89456a18f..891a5dd79a 100644 --- a/.gitlab/ci/dev-fixtures.gitlab-ci.yml +++ b/.gitlab/ci/dev-fixtures.gitlab-ci.yml @@ -15,8 +15,8 @@ # SEED_NESTED_GROUPS: "false" # requires network connection .run-dev-fixtures-script: &run-dev-fixtures-script - - run_timed_command "scripts/gitaly-test-spawn" - - run_timed_command "bundle exec rake db:seed_fu" + - section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here + - section_start "seeding-db" "Seeding DB"; bundle exec rake db:seed_fu; section_end "seeding-db"; run-dev-fixtures: extends: diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index 51fad741a1..708069d9b6 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -138,22 +138,14 @@ retrieve-frontend-fixtures: # More information in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/74003. WEBPACK_VENDOR_DLL: "true" script: - - source scripts/utils.sh - source scripts/gitlab_component_helpers.sh - | - if [[ -d "tmp/tests/frontend" ]]; then - # Remove tmp/tests/frontend/ except on the first parallelized job so that depending - # jobs don't download the exact same artifact multiple times. - if [[ -n "${CI_NODE_INDEX}" ]] && [[ "${CI_NODE_INDEX}" -ne 1 ]]; then - echoinfo "INFO: Removing 'tmp/tests/frontend' as we're on node ${CI_NODE_INDEX}."; - rm -rf "tmp/tests/frontend"; - fi + if check_fixtures_reuse; then + echoinfo "INFO: Reusing frontend fixtures from 'retrieve-frontend-fixtures'." exit 0 - else - echo "No frontend fixtures directory, generating frontend fixtures." fi - run_timed_command "gem install knapsack --no-document" - - run_timed_command "scripts/gitaly-test-spawn" + - section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here - source ./scripts/rspec_helpers.sh - rspec_paralellized_job artifacts: diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 02e13be9a7..4362269103 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -219,8 +219,9 @@ .use-pg12: services: - - name: postgres:12 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-12-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine variables: POSTGRES_HOST_AUTH_METHOD: trust @@ -228,8 +229,9 @@ .use-pg13: services: - - name: postgres:13 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.2-alpine variables: POSTGRES_HOST_AUTH_METHOD: trust @@ -237,8 +239,9 @@ .use-pg14: services: - - name: postgres:14 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.2-alpine variables: POSTGRES_HOST_AUTH_METHOD: trust @@ -246,8 +249,9 @@ .use-pg12-es7-ee: services: - - name: postgres:12 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-12-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: elasticsearch:7.17.6 command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"] @@ -261,8 +265,9 @@ .use-pg13-es7-ee: services: - - name: postgres:13 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.2-alpine - name: elasticsearch:7.17.6 command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"] @@ -276,8 +281,9 @@ .use-pg14-es7-ee: services: - - name: postgres:14 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.2-alpine - name: elasticsearch:7.17.6 command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"] @@ -291,8 +297,9 @@ .use-pg13-es8-ee: services: - - name: postgres:13 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: elasticsearch:8.6.2 - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.0 @@ -307,8 +314,9 @@ .use-pg14-es8-ee: services: - - name: postgres:14 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: elasticsearch:8.6.2 - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.0 @@ -323,8 +331,9 @@ .use-pg13-opensearch1-ee: services: - - name: postgres:13 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: opensearchproject/opensearch:1.3.5 alias: elasticsearch @@ -339,8 +348,9 @@ .use-pg13-opensearch2-ee: services: - - name: postgres:13 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: opensearchproject/opensearch:2.2.1 alias: elasticsearch @@ -355,8 +365,9 @@ .use-pg14-opensearch1-ee: services: - - name: postgres:14 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: opensearchproject/opensearch:1.3.5 alias: elasticsearch @@ -371,8 +382,9 @@ .use-pg14-opensearch2-ee: services: - - name: postgres:14 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1 command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"] + alias: postgres - name: redis:6.0-alpine - name: opensearchproject/opensearch:2.2.1 alias: elasticsearch @@ -425,7 +437,7 @@ docker run --rm --privileged ${QEMU_IMAGE} --uninstall qemu-*; docker run --rm --privileged ${QEMU_IMAGE} --install all; fi - - docker buildx create --use # creates and set's to active buildkit builder + - docker buildx create --use # creates and set's to active buildkit builder .use-kube-context: before_script: diff --git a/.gitlab/ci/package-and-test-nightly/main.gitlab-ci.yml b/.gitlab/ci/package-and-test-nightly/main.gitlab-ci.yml new file mode 100644 index 0000000000..a5474d00cb --- /dev/null +++ b/.gitlab/ci/package-and-test-nightly/main.gitlab-ci.yml @@ -0,0 +1,87 @@ +include: + - local: .gitlab/ci/qa-common/main.gitlab-ci.yml + - local: .gitlab/ci/qa-common/rules.gitlab-ci.yml + - local: .gitlab/ci/qa-common/variables.gitlab-ci.yml + +workflow: + rules: + - if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule" && $SCHEDULE_TYPE == "nightly"' + +.ce: + variables: + RELEASE: ${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ce:${CI_COMMIT_SHA} + +.ee: + variables: + RELEASE: ${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ee:${CI_COMMIT_SHA} + +# ========================================== +# Prepare stage +# ========================================== +# TODO: enable once ee jobs are added +# trigger-omnibus-env: +# extends: +# - .trigger-omnibus-env + +trigger-omnibus-env-ce: + extends: + - .trigger-omnibus-env-ce + variables: + FOSS_ONLY: "1" # set FOSS_ONLY because we don't pass it via trigger job + +# TODO: enable once ee jobs are added +# trigger-omnibus: +# extends: +# - .trigger-omnibus +# needs: +# - trigger-omnibus-env + +trigger-omnibus-ce: + extends: + - .trigger-omnibus-ce + needs: + - trigger-omnibus-env-ce + +# TODO: enable when first parallel job is added +# download-knapsack-report: +# extends: +# - .download-knapsack-report +# - .rules:download-knapsack + +# ========================================== +# Test stage +# ========================================== +update-ee-to-ce: + extends: + - .qa + - .update-script + - .ce + variables: + UPDATE_TYPE: minor + UPDATE_FROM_EDITION: ee + QA_RSPEC_TAGS: --tag smoke + +# ========================================== +# Post test stage +# ========================================== +e2e-test-report: + extends: + - .e2e-test-report + +# TODO: enable when first parallel job is added +# upload-knapsack-report: +# extends: +# - .upload-knapsack-report +# - .rules:report:process-results + +export-test-metrics: + extends: + - .export-test-metrics + +relate-test-failures: + extends: + - .relate-test-failures + +notify-slack: + extends: + - .notify-slack diff --git a/.gitlab/ci/package-and-test/main.gitlab-ci.yml b/.gitlab/ci/package-and-test/main.gitlab-ci.yml index 270bf7eae4..e90c0bbc7c 100644 --- a/.gitlab/ci/package-and-test/main.gitlab-ci.yml +++ b/.gitlab/ci/package-and-test/main.gitlab-ci.yml @@ -1,72 +1,9 @@ # E2E tests pipeline loaded dynamically by script: scripts/generate-e2e-pipeline # For adding new tests, refer to: doc/development/testing_guide/end_to_end/package_and_test_pipeline.md - -default: - interruptible: true - -workflow: - name: $PIPELINE_NAME - include: - - local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml - - local: .gitlab/ci/package-and-test/variables.gitlab-ci.yml - - project: gitlab-org/quality/pipeline-common - ref: 3.1.2 - file: - - /ci/base.gitlab-ci.yml - - /ci/allure-report.yml - - /ci/knapsack-report.yml - -stages: - - test - - report - - notify - -# ========================================== -# Templates -# ========================================== -.parallel: - parallel: 5 - variables: - QA_KNAPSACK_REPORT_PATH: $CI_PROJECT_DIR/qa/knapsack - -.ruby-image: - # Because this pipeline template can be included directly in other projects, - # image path and registry needs to be defined explicitly - image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3 - -.qa-install: - variables: - BUNDLE_SUPPRESS_INSTALL_USING_MESSAGES: "true" - BUNDLE_SILENCE_ROOT_WARNING: "true" - extends: - - .gitlab-qa-install - -.update-script: - script: - - !reference [.bundle-prefix] - - export QA_COMMAND="$BUNDLE_PREFIX gitlab-qa Test::Omnibus::UpdateFromPrevious $RELEASE $GITLAB_SEMVER_VERSION $UPDATE_TYPE -- $QA_RSPEC_TAGS $RSPEC_REPORT_OPTS" - - echo "Running - '$QA_COMMAND'" - - eval "$QA_COMMAND" - -.qa: - extends: - - .qa-base - - .qa-install - - .gitlab-qa-report - stage: test - tags: - - e2e - variables: - QA_GENERATE_ALLURE_REPORT: "true" - QA_CAN_TEST_PRAEFECT: "false" - QA_INTERCEPT_REQUESTS: "true" - GITLAB_LICENSE_MODE: test - GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN - GITLAB_QA_OPTS: $EXTRA_GITLAB_QA_OPTS - # todo: remove in 16.1 milestone when not needed for backwards compatibility anymore - EE_LICENSE: $QA_EE_LICENSE - GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN + - local: .gitlab/ci/qa-common/main.gitlab-ci.yml + - local: .gitlab/ci/qa-common/rules.gitlab-ci.yml + - local: .gitlab/ci/qa-common/variables.gitlab-ci.yml # ========================================== # Prepare stage @@ -83,124 +20,34 @@ check-release-set: echo "Omnibus installation image is set to '$RELEASE'" fi -dont-interrupt-me: - extends: .rules:dont-interrupt - stage: .pre - interruptible: false - script: - - echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible." - trigger-omnibus-env: extends: + - .trigger-omnibus-env - .rules:omnibus-build - stage: .pre - needs: - # We need this job because we need its `cached-assets-hash.txt` artifact, so that we can pass the assets image tag to the downstream omnibus-gitlab pipeline. - - pipeline: $PARENT_PIPELINE_ID - job: build-assets-image - variables: - BUILD_ENV: build.env - before_script: - - | - # This is duplicating the function from `scripts/utils.sh` since `.gitlab/ci/package-and-test/main.gitlab-ci.yml` can be included in other projects. - function assets_image_tag() { - local cache_assets_hash_file="cached-assets-hash.txt" - - if [[ -n "${CI_COMMIT_TAG}" ]]; then - echo -n "${CI_COMMIT_REF_NAME}" - elif [[ -f "${cache_assets_hash_file}" ]]; then - echo -n "assets-hash-$(cat ${cache_assets_hash_file} | cut -c1-10)" - else - echo -n "${CI_COMMIT_SHA}" - fi - } - script: - - | - SECURITY_SOURCES=$([[ ! "$CI_PROJECT_NAMESPACE" =~ ^gitlab-org\/security ]] || echo "true") - echo "SECURITY_SOURCES=${SECURITY_SOURCES:-false}" > $BUILD_ENV - echo "OMNIBUS_GITLAB_CACHE_UPDATE=${OMNIBUS_GITLAB_CACHE_UPDATE:-false}" >> $BUILD_ENV - for version_file in *_VERSION; do echo "$version_file=$(cat $version_file)" >> $BUILD_ENV; done - echo "OMNIBUS_GITLAB_RUBY3_BUILD=${OMNIBUS_GITLAB_RUBY3_BUILD:-false}" >> $BUILD_ENV - echo "OMNIBUS_GITLAB_RUBY2_BUILD=${OMNIBUS_GITLAB_RUBY2_BUILD:-false}" >> $BUILD_ENV - echo "OMNIBUS_GITLAB_CACHE_EDITION=${OMNIBUS_GITLAB_CACHE_EDITION:-GITLAB}" >> $BUILD_ENV - echo "OMNIBUS_GITLAB_BUILD_ON_ALL_OS=${OMNIBUS_GITLAB_BUILD_ON_ALL_OS:-false}" >> $BUILD_ENV - echo "GITLAB_ASSETS_TAG=$(assets_image_tag)" >> $BUILD_ENV - echo "EE=$([[ $FOSS_ONLY == '1' ]] && echo 'false' || echo 'true')" >> $BUILD_ENV - target_branch_name="${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_COMMIT_REF_NAME}}" - echo "TRIGGER_BRANCH=$([[ "${target_branch_name}" =~ ^[0-9-]+-stable(-ee)?$ ]] && echo ${target_branch_name%-ee} || echo 'master')" >> $BUILD_ENV - echo "Built environment file for omnibus build:" - cat $BUILD_ENV - artifacts: - reports: - dotenv: $BUILD_ENV trigger-omnibus-env-ce: extends: - - trigger-omnibus-env + - .trigger-omnibus-env-ce - .rules:omnibus-build-ce - needs: - - pipeline: $PARENT_PIPELINE_ID - job: build-assets-image as-if-foss trigger-omnibus: - extends: .rules:omnibus-build - stage: .pre + extends: + - .trigger-omnibus + - .rules:omnibus-build needs: - trigger-omnibus-env - inherit: - variables: false - variables: - GITALY_SERVER_VERSION: $GITALY_SERVER_VERSION - GITLAB_ELASTICSEARCH_INDEXER_VERSION: $GITLAB_ELASTICSEARCH_INDEXER_VERSION - GITLAB_KAS_VERSION: $GITLAB_KAS_VERSION - GITLAB_METRICS_EXPORTER_VERSION: $GITLAB_METRICS_EXPORTER_VERSION - GITLAB_PAGES_VERSION: $GITLAB_PAGES_VERSION - GITLAB_SHELL_VERSION: $GITLAB_SHELL_VERSION - GITLAB_WORKHORSE_VERSION: $GITLAB_WORKHORSE_VERSION - GITLAB_VERSION: $CI_COMMIT_SHA - GITLAB_ASSETS_TAG: $GITLAB_ASSETS_TAG - IMAGE_TAG: $CI_COMMIT_SHA - TOP_UPSTREAM_SOURCE_PROJECT: $CI_PROJECT_PATH - SECURITY_SOURCES: $SECURITY_SOURCES - CACHE_UPDATE: $OMNIBUS_GITLAB_CACHE_UPDATE - RUBY3_BUILD: $OMNIBUS_GITLAB_RUBY3_BUILD - RUBY2_BUILD: $OMNIBUS_GITLAB_RUBY2_BUILD - CACHE_EDITION: $OMNIBUS_GITLAB_CACHE_EDITION - BUILD_ON_ALL_OS: $OMNIBUS_GITLAB_BUILD_ON_ALL_OS - SKIP_QA_TEST: "true" - ee: $EE - trigger: - project: gitlab-org/build/omnibus-gitlab-mirror - branch: $TRIGGER_BRANCH - strategy: depend trigger-omnibus-ce: extends: - - trigger-omnibus + - .trigger-omnibus-ce - .rules:omnibus-build-ce - variables: - # Override gitlab repository so that omnibus doesn't use foss repository for CE build - GITLAB_ALTERNATIVE_REPO: $CI_PROJECT_URL needs: - trigger-omnibus-env-ce download-knapsack-report: extends: - - .gitlab-qa-image + - .download-knapsack-report - .rules:download-knapsack - stage: .pre - variables: - KNAPSACK_DIR: ${CI_PROJECT_DIR}/qa/knapsack - GIT_STRATEGY: none - script: - # when using qa-image, code runs in /home/gitlab/qa folder - - bundle exec rake "knapsack:download[test]" - - mkdir -p "$KNAPSACK_DIR" && cp knapsack/*.json "${KNAPSACK_DIR}/" - allow_failure: true - artifacts: - paths: - - qa/knapsack/*.json - expire_in: 1 day cache-gems: extends: @@ -649,87 +496,30 @@ importers: # ========================================== e2e-test-report: extends: - - .generate-allure-report-base + - .e2e-test-report - .rules:report:allure-report - stage: report - variables: - GITLAB_AUTH_TOKEN: $PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE - ALLURE_PROJECT_PATH: $CI_PROJECT_PATH - ALLURE_MERGE_REQUEST_IID: $CI_MERGE_REQUEST_IID upload-knapsack-report: extends: - - .generate-knapsack-report-base - - .qa-install - - .ruby-image + - .upload-knapsack-report - .rules:report:process-results - stage: report - when: always export-test-metrics: extends: - - .qa-install - - .ruby-image + - .export-test-metrics - .rules:report:process-results - stage: report - when: always - script: - - bundle exec rake "ci:export_test_metrics[$CI_PROJECT_DIR/gitlab-qa-run-*/**/test-metrics-*.json]" relate-test-failures: extends: - - .qa-install - - .ruby-image + - .relate-test-failures - .rules:report:process-results - stage: report - variables: - QA_FAILURES_REPORTING_PROJECT: gitlab-org/gitlab - QA_FAILURES_MAX_DIFF_RATIO: "0.15" - GITLAB_QA_ACCESS_TOKEN: $QA_GITLAB_CI_TOKEN - when: on_failure - script: - - | - bundle exec gitlab-qa-report \ - --relate-failure-issue "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.json" \ - --project "$QA_FAILURES_REPORTING_PROJECT" \ - --max-diff-ratio "$QA_FAILURES_MAX_DIFF_RATIO" generate-test-session: extends: - - .qa-install - - .ruby-image + - .generate-test-session - .rules:report:process-results - stage: report - variables: - QA_TESTCASE_SESSIONS_PROJECT: gitlab-org/quality/testcase-sessions - GITLAB_QA_ACCESS_TOKEN: $QA_TEST_SESSION_TOKEN - GITLAB_CI_API_TOKEN: $QA_GITLAB_CI_TOKEN - when: always - script: - - | - bundle exec gitlab-qa-report \ - --generate-test-session "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.json" \ - --project "$QA_TESTCASE_SESSIONS_PROJECT" - artifacts: - when: always - expire_in: 1d - paths: - - qa/REPORT_ISSUE_URL notify-slack: extends: - - .notify-slack-qa - - .qa-install - - .ruby-image + - .notify-slack - .rules:report:process-results - stage: notify - variables: - ALLURE_JOB_NAME: e2e-package-and-test - SLACK_ICON_EMOJI: ci_failing - STATUS_SYM: ☠️ - STATUS: failed - TYPE: "(package-and-test) " - when: on_failure - script: - - bundle exec gitlab-qa-report --prepare-stage-reports "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.xml" # generate summary - - !reference [.notify-slack-qa, script] diff --git a/.gitlab/ci/preflight.gitlab-ci.yml b/.gitlab/ci/preflight.gitlab-ci.yml index 526492a75c..e477466e5f 100644 --- a/.gitlab/ci/preflight.gitlab-ci.yml +++ b/.gitlab/ci/preflight.gitlab-ci.yml @@ -30,9 +30,12 @@ rails-production-server-boot: needs: [] script: - source scripts/utils.sh - - bundle exec rails server -e production & - - sleep 40 # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/114124#note_1309506358 - - retry_times_sleep 10 5 "curl http://0.0.0.0:3000" + - cp config/puma.rb.example config/puma.rb + - sed --in-place "s:/home/git/gitlab:${PWD}:" config/puma.rb + - echo 'bind "tcp://127.0.0.1:3000"' >> config/puma.rb + - bundle exec puma --environment production --config config/puma.rb & + - sleep 40 # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/114124#note_1309506358 + - retry_times_sleep 10 5 "curl http://127.0.0.1:3000" - kill $(jobs -p) no-ee-check: diff --git a/.gitlab/ci/qa-common/main.gitlab-ci.yml b/.gitlab/ci/qa-common/main.gitlab-ci.yml new file mode 100644 index 0000000000..de393f9455 --- /dev/null +++ b/.gitlab/ci/qa-common/main.gitlab-ci.yml @@ -0,0 +1,280 @@ +default: + interruptible: true + +workflow: + name: $PIPELINE_NAME + +include: + - project: gitlab-org/quality/pipeline-common + ref: 5.1.1 + file: + - /ci/base.gitlab-ci.yml + - /ci/allure-report.yml + - /ci/knapsack-report.yml + +stages: + - test + - report + - notify + +# ========================================== +# Templates +# ========================================== +.parallel: + parallel: 5 + variables: + QA_KNAPSACK_REPORT_PATH: $CI_PROJECT_DIR/qa/knapsack + +.ruby-image: + # Because this pipeline template can be included directly in other projects, + # image path and registry needs to be defined explicitly + image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3 + +.qa-install: + variables: + BUNDLE_SUPPRESS_INSTALL_USING_MESSAGES: "true" + BUNDLE_SILENCE_ROOT_WARNING: "true" + extends: + - .gitlab-qa-install + +.update-script: + script: + - !reference [.bundle-prefix] + - export QA_COMMAND="$BUNDLE_PREFIX gitlab-qa Test::Omnibus::UpdateFromPrevious $RELEASE $GITLAB_SEMVER_VERSION $UPDATE_TYPE $UPDATE_FROM_EDITION -- $QA_RSPEC_TAGS $RSPEC_REPORT_OPTS" + - echo "Running - '$QA_COMMAND'" + - eval "$QA_COMMAND" + +.qa: + extends: + - .qa-base + - .qa-install + - .gitlab-qa-report + stage: test + tags: + - e2e + variables: + QA_GENERATE_ALLURE_REPORT: "true" + QA_CAN_TEST_PRAEFECT: "false" + QA_INTERCEPT_REQUESTS: "true" + GITLAB_LICENSE_MODE: test + GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN + GITLAB_QA_OPTS: $EXTRA_GITLAB_QA_OPTS + # todo: remove in 16.1 milestone when not needed for backwards compatibility anymore + EE_LICENSE: $QA_EE_LICENSE + GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN + # Allow QA jobs to fail as they are flaky. The top level `package-and-e2e:ee` + # pipeline is not allowed to fail, so without allowing QA to fail, we will be + # blocking merges due to flaky tests. + allow_failure: true + +.trigger-omnibus-env: + stage: .pre + needs: + # We need this job because we need its `cached-assets-hash.txt` artifact, so that we can pass the assets image tag to the downstream omnibus-gitlab pipeline. + - pipeline: $PARENT_PIPELINE_ID + job: build-assets-image + variables: + BUILD_ENV: build.env + before_script: + - | + # This is duplicating the function from `scripts/utils.sh` since `.gitlab/ci/package-and-test/main.gitlab-ci.yml` can be included in other projects. + function assets_image_tag() { + local cache_assets_hash_file="cached-assets-hash.txt" + + if [[ -n "${CI_COMMIT_TAG}" ]]; then + echo -n "${CI_COMMIT_REF_NAME}" + elif [[ -f "${cache_assets_hash_file}" ]]; then + echo -n "assets-hash-$(cat ${cache_assets_hash_file} | cut -c1-10)" + else + echo -n "${CI_COMMIT_SHA}" + fi + } + script: + - | + SECURITY_SOURCES=$([[ ! "$CI_PROJECT_NAMESPACE" =~ ^gitlab-org\/security ]] || echo "true") + echo "SECURITY_SOURCES=${SECURITY_SOURCES:-false}" > $BUILD_ENV + echo "OMNIBUS_GITLAB_CACHE_UPDATE=${OMNIBUS_GITLAB_CACHE_UPDATE:-false}" >> $BUILD_ENV + for version_file in *_VERSION; do echo "$version_file=$(cat $version_file)" >> $BUILD_ENV; done + echo "OMNIBUS_GITLAB_RUBY3_BUILD=${OMNIBUS_GITLAB_RUBY3_BUILD:-false}" >> $BUILD_ENV + echo "OMNIBUS_GITLAB_RUBY2_BUILD=${OMNIBUS_GITLAB_RUBY2_BUILD:-false}" >> $BUILD_ENV + echo "OMNIBUS_GITLAB_CACHE_EDITION=${OMNIBUS_GITLAB_CACHE_EDITION:-GITLAB}" >> $BUILD_ENV + echo "OMNIBUS_GITLAB_BUILD_ON_ALL_OS=${OMNIBUS_GITLAB_BUILD_ON_ALL_OS:-false}" >> $BUILD_ENV + echo "GITLAB_ASSETS_TAG=$(assets_image_tag)" >> $BUILD_ENV + echo "EE=$([[ $FOSS_ONLY == '1' ]] && echo 'false' || echo 'true')" >> $BUILD_ENV + target_branch_name="${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_COMMIT_REF_NAME}}" + echo "TRIGGER_BRANCH=$([[ "${target_branch_name}" =~ ^[0-9-]+-stable(-ee)?$ ]] && echo ${target_branch_name%-ee} || echo 'master')" >> $BUILD_ENV + - | + echo "Built environment file for omnibus build:" + cat $BUILD_ENV + artifacts: + expire_in: 3 days + reports: + dotenv: $BUILD_ENV + paths: + - $BUILD_ENV + +.trigger-omnibus-env-ce: + extends: .trigger-omnibus-env + needs: + - pipeline: $PARENT_PIPELINE_ID + job: build-assets-image as-if-foss + +.trigger-omnibus: + stage: .pre + inherit: + variables: false + variables: + GITALY_SERVER_VERSION: $GITALY_SERVER_VERSION + GITLAB_ELASTICSEARCH_INDEXER_VERSION: $GITLAB_ELASTICSEARCH_INDEXER_VERSION + GITLAB_KAS_VERSION: $GITLAB_KAS_VERSION + GITLAB_METRICS_EXPORTER_VERSION: $GITLAB_METRICS_EXPORTER_VERSION + GITLAB_PAGES_VERSION: $GITLAB_PAGES_VERSION + GITLAB_SHELL_VERSION: $GITLAB_SHELL_VERSION + GITLAB_WORKHORSE_VERSION: $GITLAB_WORKHORSE_VERSION + GITLAB_VERSION: $CI_COMMIT_SHA + GITLAB_ASSETS_TAG: $GITLAB_ASSETS_TAG + IMAGE_TAG: $CI_COMMIT_SHA + TOP_UPSTREAM_SOURCE_PROJECT: $CI_PROJECT_PATH + SECURITY_SOURCES: $SECURITY_SOURCES + CACHE_UPDATE: $OMNIBUS_GITLAB_CACHE_UPDATE + RUBY3_BUILD: $OMNIBUS_GITLAB_RUBY3_BUILD + RUBY2_BUILD: $OMNIBUS_GITLAB_RUBY2_BUILD + CACHE_EDITION: $OMNIBUS_GITLAB_CACHE_EDITION + BUILD_ON_ALL_OS: $OMNIBUS_GITLAB_BUILD_ON_ALL_OS + SKIP_QA_TEST: "true" + ee: $EE + trigger: + project: gitlab-org/build/omnibus-gitlab-mirror + branch: $TRIGGER_BRANCH + strategy: depend + +.trigger-omnibus-ce: + extends: + - .trigger-omnibus + variables: + # Override gitlab repository so that omnibus doesn't use foss repository for CE build + GITLAB_ALTERNATIVE_REPO: $CI_PROJECT_URL + +.download-knapsack-report: + extends: + - .gitlab-qa-image + stage: .pre + variables: + KNAPSACK_DIR: ${CI_PROJECT_DIR}/qa/knapsack + GIT_STRATEGY: none + script: + # when using qa-image, code runs in /home/gitlab/qa folder + - bundle exec rake "knapsack:download[test]" + - mkdir -p "$KNAPSACK_DIR" && cp knapsack/*.json "${KNAPSACK_DIR}/" + allow_failure: true + artifacts: + paths: + - qa/knapsack/*.json + expire_in: 1 day + +.e2e-test-report: + extends: + - .generate-allure-report-base + stage: report + variables: + GITLAB_AUTH_TOKEN: $PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE + ALLURE_PROJECT_PATH: $CI_PROJECT_PATH + ALLURE_MERGE_REQUEST_IID: $CI_MERGE_REQUEST_IID + +.upload-knapsack-report: + extends: + - .generate-knapsack-report-base + - .qa-install + - .ruby-image + stage: report + when: always + +.export-test-metrics: + extends: + - .qa-install + - .ruby-image + stage: report + when: always + variables: + QA_METRICS_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/gitlab-qa-run-*/**/test-metrics-*.json + script: + - bundle exec rake "ci:export_test_metrics[$QA_METRICS_REPORT_FILE_PATTERN]" + +.relate-test-failures: + extends: + - .qa-install + - .ruby-image + stage: report + when: always + variables: + QA_RSPEC_JSON_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.json" + script: + - | + if [ "$SUITE_FAILED" != "true" ] && [ "$SUITE_RAN" == "true" ]; then + echo "Test suite passed. Exiting..." + exit 0 + fi + - | + bundle exec relate-failure-issue \ + --input-files "${QA_RSPEC_JSON_FILE_PATTERN}" \ + --project "gitlab-org/gitlab" \ + --token "${QA_RELATE_FAILURE_ISSUE_TOKEN}" + +.generate-test-session: + extends: + - .qa-install + - .ruby-image + stage: report + when: always + variables: + QA_RSPEC_JSON_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.json" + script: + - | + bundle exec generate-test-session \ + --input-files "${QA_RSPEC_JSON_FILE_PATTERN}" \ + --project "gitlab-org/quality/testcase-sessions" \ + --token "${QA_TEST_SESSION_TOKEN}" \ + --ci-project-token "${GENERATE_TEST_SESSION_READ_API_REPORTER_TOKEN}" \ + --issue-url-file report_issue_url.txt + artifacts: + when: always + expire_in: 1d + paths: + - qa/report_issue_url.txt + +.notify-slack: + extends: + - .notify-slack-qa + - .qa-install + - .ruby-image + stage: notify + variables: + QA_RSPEC_XML_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.xml" + SLACK_ICON_EMOJI: ci_failing + STATUS_SYM: ☠️ + STATUS: failed + TYPE: "($QA_RUN_TYPE) " + when: always + script: + - | + if [ "$SUITE_FAILED" != "true" ] && [ "$SUITE_RAN" == "true" ]; then + echo "Test suite passed. Exiting..." + exit 0 + fi + - bundle exec prepare-stage-reports --input-files "${QA_RSPEC_XML_FILE_PATTERN}" + - !reference [.notify-slack-qa, script] + +# ========================================== +# Pre stage +# ========================================== +dont-interrupt-me: + stage: .pre + interruptible: false + script: + - echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible." + rules: + - if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null' + allow_failure: true + - if: '$CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached"' + when: manual + allow_failure: true diff --git a/.gitlab/ci/package-and-test/rules.gitlab-ci.yml b/.gitlab/ci/qa-common/rules.gitlab-ci.yml similarity index 92% rename from .gitlab/ci/package-and-test/rules.gitlab-ci.yml rename to .gitlab/ci/qa-common/rules.gitlab-ci.yml index 8f63dbc38c..3580339921 100644 --- a/.gitlab/ci/package-and-test/rules.gitlab-ci.yml +++ b/.gitlab/ci/qa-common/rules.gitlab-ci.yml @@ -48,14 +48,6 @@ rules: - when: always -.rules:dont-interrupt: - rules: - - if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null' - allow_failure: true - - if: '$CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached"' - when: manual - allow_failure: true - .rules:omnibus-build: rules: - if: $SKIP_OMNIBUS_TRIGGER == "true" @@ -132,6 +124,11 @@ # these jobs need gitlab version because we can't reliably detect it from just the image - if: $GITLAB_SEMVER_VERSION !~ /^\d+\.\d+\.\d+/ when: never + # update type tests are used to check if gitlab upgrade can be performed correctly (mainly migrations) + # there isn't much benefit in running tests after update with new sidebar enabled and there + # is also an issue to properly pass feature toggle to this job due to how gitlab-qa parses cli args + - if: $QA_SUPER_SIDEBAR_ENABLED == "true" + when: never - !reference [.rules:test:ee-only, rules] - !reference [.rules:test:qa, rules] diff --git a/.gitlab/ci/package-and-test/variables.gitlab-ci.yml b/.gitlab/ci/qa-common/variables.gitlab-ci.yml similarity index 100% rename from .gitlab/ci/package-and-test/variables.gitlab-ci.yml rename to .gitlab/ci/qa-common/variables.gitlab-ci.yml diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 6f06746c49..81127b7c11 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -12,6 +12,40 @@ - !reference [.default-before_script, before_script] - cd qa && bundle install +.e2e-trigger-base: + extends: .production # this makes sure GITLAB_ALLOW_SEPARATE_CI_DATABASE is passed to the child pipeline + stage: qa + needs: + - build-assets-image + - build-qa-image + - e2e-test-pipeline-generate + variables: + # This is needed by `trigger-omnibus-env` (`.gitlab/ci/package-and-test/main.gitlab-ci.yml`). + PARENT_PIPELINE_ID: $CI_PIPELINE_ID + SKIP_MESSAGE: Skipping package-and-test due to mr containing only quarantine changes! + GITLAB_QA_IMAGE: "${CI_REGISTRY_IMAGE}/gitlab-ee-qa:${CI_COMMIT_SHA}" + RUN_WITH_BUNDLE: "true" # instructs pipeline to install and run gitlab-qa gem via bundler + QA_PATH: qa # sets the optional path for bundler to run from + DYNAMIC_PIPELINE_YML: package-and-test-pipeline.yml # yml files are generated by scripts/generate-e2e-pipeline script + inherit: + variables: + - CHROME_VERSION + - RUBY_VERSION + - DOCKER_VERSION + - REGISTRY_GROUP + - REGISTRY_HOST + - OMNIBUS_GITLAB_CACHE_EDITION + - OMNIBUS_GITLAB_RUBY3_BUILD + - OMNIBUS_GITLAB_RUBY2_BUILD + trigger: + strategy: depend + forward: + yaml_variables: true + pipeline_variables: true + include: + - artifact: $DYNAMIC_PIPELINE_YML + job: e2e-test-pipeline-generate + qa:internal: extends: - .qa-job-base @@ -54,42 +88,17 @@ qa:update-qa-cache: e2e:package-and-test-ee: extends: - - .production # this makes sure GITLAB_ALLOW_SEPARATE_CI_DATABASE is passed to the child pipeline + - .e2e-trigger-base - .qa:rules:package-and-test-ee - stage: qa needs: - build-assets-image - build-qa-image - e2e-test-pipeline-generate variables: - # This is needed by `trigger-omnibus-env` (`.gitlab/ci/package-and-test/main.gitlab-ci.yml`). - PARENT_PIPELINE_ID: $CI_PIPELINE_ID - SKIP_MESSAGE: Skipping package-and-test due to mr containing only quarantine changes! RELEASE: "${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ee:${CI_COMMIT_SHA}" - GITLAB_QA_IMAGE: "${CI_REGISTRY_IMAGE}/gitlab-ee-qa:${CI_COMMIT_SHA}" - RUN_WITH_BUNDLE: "true" # instructs pipeline to install and run gitlab-qa gem via bundler - QA_PATH: qa # sets the optional path for bundler to run from QA_RUN_TYPE: e2e-package-and-test ALLURE_JOB_NAME: e2e-package-and-test PIPELINE_NAME: E2E Omnibus GitLab EE - inherit: - variables: - - CHROME_VERSION - - RUBY_VERSION - - DOCKER_VERSION - - REGISTRY_GROUP - - REGISTRY_HOST - - OMNIBUS_GITLAB_CACHE_EDITION - - OMNIBUS_GITLAB_RUBY3_BUILD - - OMNIBUS_GITLAB_RUBY2_BUILD - trigger: - strategy: depend - forward: - yaml_variables: true - pipeline_variables: true - include: - - artifact: package-and-test-pipeline.yml - job: e2e-test-pipeline-generate e2e:package-and-test-ce: extends: @@ -119,8 +128,26 @@ e2e:package-and-test-super-sidebar: ALLURE_JOB_NAME: e2e-package-and-test-super-sidebar PIPELINE_NAME: E2E Omnibus Super Sidebar +e2e:package-and-test-nightly: + extends: + - .e2e-trigger-base + - .qa:rules:package-and-test-nightly + needs: + - build-assets-image + - build-assets-image as-if-foss + - build-qa-image + - build-qa-image as-if-foss + - e2e-test-pipeline-generate + variables: + GITLAB_SEMVER_VERSION: $GITLAB_SEMVER_VERSION + QA_RUN_TYPE: nightly + ALLURE_JOB_NAME: nightly + PIPELINE_NAME: E2E Omnibus GitLab Nightly + DYNAMIC_PIPELINE_YML: package-and-test-nightly-pipeline.yml + e2e:test-on-gdk: extends: + - .e2e-trigger-base - .qa:rules:e2e:test-on-gdk stage: qa needs: @@ -128,10 +155,12 @@ e2e:test-on-gdk: # In MRs we assume the last scheduled master pipeline built the image already. - job: build-qa-on-gdk-master-image optional: true + - job: e2e-test-pipeline-generate + artifacts: true + variables: + ALLURE_JOB_NAME: e2e-test-on-gdk + QA_RUN_TYPE: e2e-test-on-gdk + PIPELINE_NAME: E2E GDK + DYNAMIC_PIPELINE_YML: test-on-gdk-pipeline.yml + SKIP_MESSAGE: Skipping test-on-gdk due to mr containing only quarantine changes! allow_failure: true - trigger: - strategy: depend - forward: - yaml_variables: true - pipeline_variables: true - include: .gitlab/ci/test-on-gdk/main.gitlab-ci.yml diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 6e055d5b3e..a4041f771d 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -15,11 +15,9 @@ setup-test-env: - echo $CI_MERGE_REQUEST_APPROVED - source scripts/gitlab_component_helpers.sh - run_timed_command "download_and_extract_gitlab_workhorse_package" || true - - run_timed_command "scripts/setup-test-env" - - run_timed_command "select_gitlab_workhorse_essentials" - - echo -e "\e[0Ksection_start:`date +%s`:gitaly-test-build[collapsed=true]\r\e[0KCompiling Gitaly binaries" - - run_timed_command "scripts/gitaly-test-build" # Do not use 'bundle exec' here - - echo -e "\e[0Ksection_end:`date +%s`:gitaly-test-build\r\e[0K" + - section_start "setup-test-env" "Setting up testing environment"; scripts/setup-test-env; section_end "setup-test-env"; + - select_gitlab_workhorse_essentials + - section_start "gitaly-test-build" "Compiling Gitaly binaries"; scripts/gitaly-test-build; section_end "gitaly-test-build"; # Do not use 'bundle exec' here artifacts: expire_in: 7d paths: @@ -274,6 +272,12 @@ rspec:coverage: - rspec unit pg13 - rspec integration pg13 - rspec system pg13 + # as-if-foss jobs + - rspec migration pg13-as-if-foss + - rspec background_migration pg13-as-if-foss + - rspec unit pg13-as-if-foss + - rspec integration pg13-as-if-foss + - rspec system pg13-as-if-foss # EE jobs - rspec-ee migration pg13 - rspec-ee background_migration pg13 @@ -342,7 +346,7 @@ rspec:flaky-tests-report: # so we use `dependencies` here. dependencies: !reference ["rspec:coverage", "dependencies"] variables: - SKIPPED_FLAKY_TESTS_REPORT_PATH: rspec/flaky/skipped_flaky_tests_report.txt + SKIPPED_TESTS_REPORT_PATH: rspec/skipped_tests_report.txt RETRIED_TESTS_REPORT_PATH: rspec/flaky/retried_tests_report.txt before_script: - source scripts/utils.sh diff --git a/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb b/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb index e7a1ee6022..84aa67de4c 100644 --- a/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb +++ b/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb @@ -39,7 +39,7 @@ dont-interrupt-me: RSPEC_TESTS_MAPPING_ENABLED: "true" script: - !reference [.base-script, script] - - rspec_paralellized_job "--tag ~quarantine --tag ~level:migration --tag ~zoekt" + - rspec_paralellized_job "--tag ~quarantine --tag ~level:background_migration --tag ~zoekt" artifacts: expire_in: 7d paths: diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index adcfcd2010..33aef166af 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -25,7 +25,7 @@ include: # gems could not be found under some circumstance. No idea why, hours wasted. - run_timed_command "gem install knapsack --no-document" - echo -e "\e[0Ksection_start:`date +%s`:gitaly-test-spawn[collapsed=true]\r\e[0KStarting Gitaly" - - run_timed_command "scripts/gitaly-test-spawn" # Do not use 'bundle exec' here + - section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn" # Do not use 'bundle exec' here - echo -e "\e[0Ksection_end:`date +%s`:gitaly-test-spawn\r\e[0K" .single-db: diff --git a/.gitlab/ci/reports.gitlab-ci.yml b/.gitlab/ci/reports.gitlab-ci.yml index c77ee0276c..b072b3dc77 100644 --- a/.gitlab/ci/reports.gitlab-ci.yml +++ b/.gitlab/ci/reports.gitlab-ci.yml @@ -31,7 +31,7 @@ code_quality: variables: SAST_BRAKEMAN_LEVEL: 2 # GitLab-specific SAST_EXCLUDED_PATHS: "qa, spec, doc, ee/spec, config/gitlab.yml.example, tmp" # GitLab-specific - SAST_EXCLUDED_ANALYZERS: bandit, flawfinder, phpcs-security-audit, pmd-apex, security-code-scan, spotbugs, eslint, nodejs-scan + SAST_EXCLUDED_ANALYZERS: bandit, flawfinder, phpcs-security-audit, pmd-apex, security-code-scan, spotbugs, eslint, nodejs-scan, sobelow brakeman-sast: rules: !reference [".reports:rules:brakeman-sast", rules] diff --git a/.gitlab/ci/review-apps/main.gitlab-ci.yml b/.gitlab/ci/review-apps/main.gitlab-ci.yml index 94492e93b7..680254a664 100644 --- a/.gitlab/ci/review-apps/main.gitlab-ci.yml +++ b/.gitlab/ci/review-apps/main.gitlab-ci.yml @@ -90,9 +90,9 @@ review-build-cng: strategy: depend .review-workflow-base: - extends: - - .default-retry image: ${REVIEW_APPS_IMAGE} + retry: + max: 2 # This is confusing but this means "3 runs at max" variables: HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}" DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}" @@ -110,7 +110,7 @@ review-deploy: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}dtzar/helm-kubectl:3.9.3 needs: - review-build-cng - - review-delete-deployment # We always want to start from a clean slate (i.e. no helm release, no k8s namespace) + - review-delete-deployment # We always want to start from a clean slate (i.e. no helm release, no k8s namespace) cache: key: "review-deploy-dependencies-charts-${GITLAB_HELM_CHART_REF}-v1" paths: @@ -126,6 +126,7 @@ review-deploy: - *base-before_script - !reference [".use-kube-context", before_script] script: + - run_timed_command "retry delete_helm_release" - run_timed_command "check_kube_domain" - run_timed_command "download_chart" - run_timed_command "deploy" || (display_deployment_debug && exit 1) diff --git a/.gitlab/ci/review-apps/qa.gitlab-ci.yml b/.gitlab/ci/review-apps/qa.gitlab-ci.yml index 13623a576d..9dd24f20c4 100644 --- a/.gitlab/ci/review-apps/qa.gitlab-ci.yml +++ b/.gitlab/ci/review-apps/qa.gitlab-ci.yml @@ -1,6 +1,6 @@ include: - project: gitlab-org/quality/pipeline-common - ref: 3.1.2 + ref: 5.1.1 file: - /ci/base.gitlab-ci.yml - /ci/allure-report.yml @@ -40,7 +40,6 @@ include: WD_INSTALL_DIR: /usr/local/bin RSPEC_REPORT_OPTS: --force-color --order random --format documentation --format RspecJunitFormatter --out tmp/rspec-${CI_JOB_ID}.xml script: - - export EE_LICENSE="$(cat $REVIEW_APPS_EE_LICENSE_FILE)" - QA_COMMAND="bundle exec bin/qa ${QA_SCENARIO} ${QA_GITLAB_URL} -- ${QA_TESTS} ${RSPEC_REPORT_OPTS}" - echo "Running - '${QA_COMMAND}'" - eval "$QA_COMMAND" @@ -170,7 +169,7 @@ notify-slack: TYPE: "(review-app) " when: on_failure script: - - bundle exec gitlab-qa-report --prepare-stage-reports "$CI_PROJECT_DIR/qa/tmp/rspec-*.xml" # generate summary + - bundle exec prepare-stage-reports --input-files "${CI_PROJECT_DIR}/qa/tmp/rspec-*.xml" - !reference [.notify-slack-qa, script] export-test-metrics: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 710856fe13..0b660c4c0a 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -41,16 +41,11 @@ # Once https://gitlab.com/gitlab-org/gitlab/-/issues/373904 is implemented, we should be able to change this back to # if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_APPROVALS_COUNT > 0' # or any similar condition to check that the MR has *any* approval (not just required approval). -# -# Temprorarily adding || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/ for backward compatibility, -# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out .if-merge-request-approved: &if-merge-request-approved - if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/ || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/' + if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/' -# Temprorarily adding && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/ for backward compatibility, -# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out .if-merge-request-not-approved: &if-merge-request-not-approved - if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS !~ /pipeline:mr-approved/ && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/' + if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS !~ /pipeline:mr-approved/' .if-automated-merge-request: &if-automated-merge-request if: '$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME == "release-tools/update-gitaly" || $CI_MERGE_REQUEST_TARGET_BRANCH_NAME =~ /stable-ee$/' @@ -98,7 +93,7 @@ if: '$CI_MERGE_REQUEST_LABELS =~ /group::global search/' .if-merge-request-labels-pipeline-expedite: &if-merge-request-labels-pipeline-expedite - if: '($CI_MERGE_REQUEST_LABELS =~ /master:(foss-)?broken/ || $CI_MERGE_REQUEST_TITLE =~ /^[Rr]evert/) && $CI_MERGE_REQUEST_LABELS =~ /pipeline:expedite/' + if: '($CI_MERGE_REQUEST_LABELS =~ /master:(foss-)?broken/ || $CI_MERGE_REQUEST_LABELS =~ /quarantine/) && $CI_MERGE_REQUEST_LABELS =~ /pipeline:expedite/' .if-merge-request-labels-frontend-and-feature-flag: &if-merge-request-labels-frontend-and-feature-flag if: '$CI_MERGE_REQUEST_LABELS =~ /frontend/ && $CI_MERGE_REQUEST_LABELS =~ /feature flag/' @@ -619,6 +614,8 @@ .rails:rules:ee-and-foss-default-rules: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *core-backend-patterns @@ -631,6 +628,8 @@ .rails:rules:system-default-rules: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *core-backend-patterns @@ -645,6 +644,8 @@ .rails:rules:previous-failed-tests-default-rules: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-security-merge-request when: never - <<: *if-merge-request-labels-run-all-rspec @@ -811,12 +812,27 @@ rules: - <<: *if-not-canonical-namespace when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-targeting-stable-branch - <<: *if-merge-request-labels-run-review-app - - <<: *if-dot-com-gitlab-org-and-security-merge-request + - <<: *if-merge-request changes: *ci-build-images-patterns - - <<: *if-dot-com-gitlab-org-and-security-merge-request + - <<: *if-merge-request changes: *code-qa-patterns + # Rules to support .qa:rules:package-and-test-ee + - <<: *if-merge-request + changes: *dependency-patterns + - <<: *if-merge-request-labels-run-all-e2e + - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e + changes: *feature-flag-development-config-patterns + - <<: *if-merge-request + changes: *feature-flag-development-config-patterns + - <<: *if-merge-request + changes: *nodejs-patterns + - <<: *if-merge-request + changes: *ci-qa-patterns + - <<: *if-force-ci .build-images:rules:build-qa-image: rules: @@ -835,7 +851,6 @@ - <<: *if-dot-com-gitlab-org-schedule variables: ARCH: amd64,arm64 - - <<: *if-force-ci - <<: *if-ruby2-branch .build-images:rules:build-qa-image-as-if-foss: @@ -859,16 +874,17 @@ rules: - <<: *if-not-canonical-namespace when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-targeting-stable-branch - <<: *if-ruby2-branch - <<: *if-merge-request-labels-run-review-app - - <<: *if-merge-request-labels-run-all-e2e - <<: *if-auto-deploy-branches - <<: *if-default-refs changes: *ci-build-images-patterns - <<: *if-default-refs changes: *code-qa-patterns - # Rules to support .qa:rules:package-and-test-mrs + # Rules to support .qa:rules:package-and-test-ee - <<: *if-merge-request changes: *dependency-patterns - <<: *if-merge-request-labels-run-all-e2e @@ -954,6 +970,8 @@ ###################### .dev-fixtures:rules:ee-and-foss: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-backstage-patterns @@ -961,6 +979,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-backstage-patterns @@ -1006,6 +1026,8 @@ rules: # The `glfm-verify` job has dependencies on EE, so only run it for EE - !reference [".strict-ee-only-rules", rules] + - <<: *if-merge-request-labels-pipeline-expedite + when: never # If any of the files that are DIRECTLY related to generating or managing the GLFM specification change, # run `glfm-verify` to get quick feedback on any needed updates, even if the MR is not yet approved - changes: *glfm-patterns @@ -1032,7 +1054,6 @@ ################## # Frontend rules # ################## - .frontend:rules:predictive-default-rules: rules: - <<: *if-merge-request-approved @@ -1041,11 +1062,15 @@ when: never - <<: *if-security-merge-request when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never .frontend:rules:compile-production-assets: rules: - <<: *if-not-canonical-namespace when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-targeting-stable-branch - <<: *if-merge-request-labels-run-review-app - <<: *if-merge-request-labels-run-all-e2e @@ -1064,8 +1089,6 @@ when: never - <<: *if-not-ee when: never - - <<: *if-merge-request-labels-pipeline-expedite - when: never - !reference [.frontend:rules:compile-production-assets, rules] .frontend:rules:compile-test-assets: @@ -1092,6 +1115,8 @@ .frontend:rules:default-frontend-jobs: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request-labels-frontend-and-feature-flag - <<: *if-default-refs @@ -1100,6 +1125,8 @@ .frontend:rules:default-frontend-jobs-as-if-foss: rules: - !reference [".strict-ee-only-rules", rules] + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-security-merge-request changes: *code-backstage-patterns - <<: *if-merge-request-labels-as-if-foss @@ -1123,6 +1150,8 @@ # The new strategy to upload fixtures as generic packages is experimental and can be disabled by removing the `REUSE_FRONTEND_FIXTURES_ENABLED` variable - if: '$REUSE_FRONTEND_FIXTURES_ENABLED != "true"' when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-dot-com-gitlab-org-default-branch changes: *code-backstage-patterns - <<: *if-foss-default-branch @@ -1136,6 +1165,8 @@ .frontend:rules:jest: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-fork-merge-request when: never - <<: *if-merge-request-labels-run-all-jest @@ -1175,6 +1206,8 @@ rules: - !reference [".strict-ee-only-rules", rules] - <<: *if-merge-request-labels-as-if-foss + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-jest - <<: *if-merge-request changes: *frontend-dependency-patterns @@ -1205,6 +1238,8 @@ rules: - !reference [".strict-ee-only-rules", rules] - <<: *if-merge-request-labels-as-if-foss + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *frontend-patterns-for-as-if-foss @@ -1223,6 +1258,8 @@ rules: - <<: *if-not-canonical-namespace when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-branch-refs changes: *frontend-build-patterns allow_failure: true @@ -1235,6 +1272,8 @@ ################ .memory:rules: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-patterns @@ -1243,6 +1282,8 @@ ########## .notify:rules:create-issues-for-failing-tests: rules: + - <<: *if-not-canonical-namespace + when: never # Don't report child pipeline failures - if: '$CI_PIPELINE_SOURCE == "parent_pipeline"' when: never @@ -1297,16 +1338,36 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-targeting-stable-branch allow_failure: true - - <<: *if-dot-com-gitlab-org-and-security-merge-request + - <<: *if-merge-request changes: *code-backstage-qa-patterns allow_failure: true - <<: *if-dot-com-gitlab-org-schedule allow_failure: true + - <<: *if-ruby2-branch + # Rules to support .qa:rules:package-and-test-ee + - <<: *if-merge-request + changes: *dependency-patterns + allow_failure: true + - <<: *if-merge-request-labels-run-all-e2e + allow_failure: true + - <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e + changes: *feature-flag-development-config-patterns + allow_failure: true + - <<: *if-merge-request + changes: *feature-flag-development-config-patterns + allow_failure: true + - <<: *if-merge-request + changes: *nodejs-patterns + allow_failure: true + - <<: *if-merge-request + changes: *ci-qa-patterns + allow_failure: true - <<: *if-force-ci allow_failure: true - - <<: *if-ruby2-branch .qa:rules:package-and-test-common: rules: @@ -1322,7 +1383,6 @@ allow_failure: true - <<: *if-merge-request changes: *dependency-patterns - allow_failure: true variables: OMNIBUS_GITLAB_BUILD_ON_ALL_OS: 'true' - <<: *if-merge-request-labels-run-all-e2e @@ -1345,7 +1405,7 @@ allow_failure: true - <<: *if-merge-request changes: - - qa/Gemfile.lock # qa/Gemfile.lock is a part of *qa-patterns, so this rule must be placed before the one with *qa-patterns changes + - qa/Gemfile.lock # qa/Gemfile.lock is a part of *qa-patterns, so this rule must be placed before the one with *qa-patterns changes variables: UPDATE_QA_CACHE: "true" - <<: *if-merge-request @@ -1354,21 +1414,16 @@ - <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified changes: *code-patterns allow_failure: true - -.qa:rules:package-and-test-mrs: - rules: - - !reference [".qa:rules:package-and-test-common", rules] + - <<: *if-force-ci + when: manual + allow_failure: true - <<: *if-merge-request changes: *code-patterns when: manual allow_failure: true - - <<: *if-force-ci - when: manual - allow_failure: true -.qa:rules:package-and-test-ee: +.qa:rules:package-and-test-schedule: rules: - - !reference [".qa:rules:package-and-test-mrs", rules] - <<: *if-dot-com-gitlab-org-schedule allow_failure: true variables: @@ -1377,7 +1432,12 @@ KNAPSACK_GENERATE_REPORT: "true" UPDATE_QA_CACHE: "true" QA_SAVE_TEST_METRICS: "true" - QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency + QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency + +.qa:rules:package-and-test-ee: + rules: + - !reference [".qa:rules:package-and-test-common", rules] + - !reference [".qa:rules:package-and-test-schedule", rules] .qa:rules:package-and-test-ce: rules: @@ -1401,25 +1461,36 @@ - if: '$QA_RUN_TESTS_ON_GDK !~ /true|yes|1/i' when: never - !reference [".qa:rules:package-and-test-common", rules] - - <<: *if-merge-request - changes: *code-patterns - allow_failure: true - - <<: *if-force-ci - when: manual - allow_failure: true + - !reference [".qa:rules:package-and-test-schedule", rules] .qa:rules:package-and-test-sidebar: rules: - - !reference [".qa:rules:package-and-test-mrs", rules] - - <<: *if-dot-com-gitlab-org-schedule + - <<: *if-not-canonical-namespace + when: never + - <<: *if-not-ee + when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never + - <<: *if-merge-request + changes: *code-patterns + when: manual + allow_failure: true + - <<: *if-default-branch-schedule-nightly allow_failure: true variables: - SKIP_REPORT_IN_ISSUES: "true" - PROCESS_TEST_RESULTS: "false" - KNAPSACK_GENERATE_REPORT: "false" - UPDATE_QA_CACHE: "false" + SKIP_REPORT_IN_ISSUES: "false" + PROCESS_TEST_RESULTS: "true" QA_SAVE_TEST_METRICS: "true" - QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency + QA_EXPORT_TEST_METRICS: "false" + +.qa:rules:package-and-test-nightly: + rules: + - <<: *if-default-branch-schedule-nightly + variables: + KNAPSACK_GENERATE_REPORT: "true" + SKIP_REPORT_IN_ISSUES: "false" + QA_SAVE_TEST_METRICS: "true" + QA_EXPORT_TEST_METRICS: "false" ############### # Rails rules # @@ -1433,6 +1504,8 @@ .rails:rules:single-db: rules: - <<: *if-merge-request-labels-run-single-db + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *db-patterns - <<: *if-merge-request @@ -1442,6 +1515,8 @@ .rails:rules:db:check-migrations-single-db: rules: - <<: *if-merge-request-labels-run-single-db + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *db-patterns - <<: *if-merge-request @@ -1450,6 +1525,8 @@ .rails:rules:single-db-ci-connection: rules: - <<: *if-merge-request-labels-run-single-db + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *db-patterns - <<: *if-merge-request @@ -1459,6 +1536,8 @@ .rails:rules:db:check-migrations-single-db-ci-connection: rules: - <<: *if-merge-request-labels-run-single-db + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *db-patterns - <<: *if-merge-request @@ -1466,6 +1545,8 @@ .rails:rules:db-backup: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-default-refs changes: *db-backup-patterns @@ -1492,6 +1573,8 @@ rules: - <<: *if-fork-merge-request when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *core-backend-patterns @@ -1506,6 +1589,10 @@ .rails:rules:rspec-predictive: rules: + - <<: *if-fork-merge-request + changes: *code-backstage-patterns + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-approved when: never - <<: *if-automated-merge-request @@ -1525,6 +1612,8 @@ .rails:rules:ee-and-foss-mr-with-migration: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request changes: *db-patterns - <<: *if-merge-request-labels-run-all-rspec @@ -1581,6 +1670,10 @@ rules: - <<: *if-not-ee when: never + - <<: *if-fork-merge-request + when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *core-backend-patterns @@ -1637,6 +1730,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *core-backend-patterns @@ -1663,6 +1758,8 @@ when: never - <<: *if-fork-merge-request when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - !reference [".rails:rules:ee-and-foss-default-rules", rules] - <<: *if-merge-request-labels-as-if-foss changes: *backend-patterns @@ -1673,6 +1770,8 @@ when: never - <<: *if-fork-merge-request when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - !reference [".rails:rules:ee-and-foss-default-rules", rules] - <<: *if-merge-request-labels-as-if-foss changes: *backend-patterns @@ -1683,12 +1782,16 @@ when: never - <<: *if-fork-merge-request when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - !reference [".rails:rules:system-default-rules", rules] - <<: *if-merge-request-labels-as-if-foss changes: *code-backstage-patterns .rails:rules:ee-and-foss-db-library-code: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *db-library-patterns - <<: *if-merge-request-labels-run-all-rspec @@ -1698,6 +1801,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-merge-request-labels-run-all-rspec - <<: *if-merge-request changes: *code-backstage-patterns @@ -1726,6 +1831,8 @@ when: never - <<: *if-merge-request-labels-as-if-foss when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-security-merge-request changes: *code-backstage-patterns - <<: *if-dot-com-gitlab-org-merge-request @@ -1755,6 +1862,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-branch-schedule-nightly - <<: *if-ruby2-branch-schedule-nightly - <<: *if-merge-request-labels-run-all-rspec @@ -1793,6 +1902,8 @@ .rails:rules:default-branch-schedule-nightly--code-backstage-default-rules: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-branch-schedule-nightly - <<: *if-merge-request changes: [".gitlab/ci/rails.gitlab-ci.yml"] @@ -1811,6 +1922,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-backstage-patterns @@ -1820,7 +1933,7 @@ when: never - <<: *if-merge-request-labels-pipeline-expedite when: never - - if: '$SKIP_FLAKY_TESTS_AUTOMATICALLY != "true" && $RETRY_FAILED_TESTS_IN_NEW_PROCESS != "true"' + - if: '$FAST_QUARANTINE == "false" && $RETRY_FAILED_TESTS_IN_NEW_PROCESS != "true"' when: never - <<: *if-merge-request changes: *code-backstage-patterns @@ -1946,12 +2059,6 @@ changes: ["vendor/gems/omniauth-azure-oauth2/**/*"] - <<: *if-merge-request-labels-run-all-rspec -.vendor:rules:omniauth-cas3: - rules: - - <<: *if-merge-request - changes: ["vendor/gems/omniauth-cas3/**/*"] - - <<: *if-merge-request-labels-run-all-rspec - .vendor:rules:omniauth_crowd: rules: - <<: *if-merge-request @@ -2027,6 +2134,8 @@ ################# .reports:rules:code_quality: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$CODE_QUALITY_DISABLED' when: never # Run code_quality on master until https://gitlab.com/gitlab-org/gitlab/-/issues/363747 is resolved @@ -2038,6 +2147,8 @@ .reports:rules:brakeman-sast: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: $SAST_DISABLED when: never - if: $SAST_EXCLUDED_ANALYZERS =~ /brakeman/ @@ -2049,6 +2160,8 @@ .reports:rules:semgrep-sast: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: $SAST_DISABLED when: never - if: $SAST_EXCLUDED_ANALYZERS =~ /semgrep/ @@ -2066,6 +2179,8 @@ .reports:rules:secret_detection: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$SECRET_DETECTION_DISABLED' when: never # Scan each commit on master to feed the Vulnerability Reports with detected secrets @@ -2075,6 +2190,8 @@ .reports:rules:gemnasium-dependency_scanning: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium([^-]|$)/' when: never # Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved @@ -2084,6 +2201,8 @@ .reports:rules:gemnasium-python-dependency_scanning: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/' when: never # Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved @@ -2093,6 +2212,8 @@ .reports:rules:yarn-audit-dependency_scanning: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/' when: never # Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved @@ -2102,6 +2223,8 @@ .reports:rules:test-dast: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - if: '$DAST_DISABLED || $GITLAB_FEATURES !~ /\bdast\b/' when: never - <<: *if-merge-request @@ -2173,7 +2296,7 @@ variables: KNAPSACK_GENERATE_REPORT: "true" QA_SAVE_TEST_METRICS: "true" - QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency + QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency # The following rules needs to be the same as the one for .review:rules:start-review-app-pipeline # except that: @@ -2283,6 +2406,8 @@ .setup:rules:gitlab_git_test: rules: + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-backstage-patterns @@ -2313,6 +2438,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-expedite + when: never - <<: *if-default-refs changes: *code-backstage-patterns @@ -2393,6 +2520,33 @@ - <<: *if-dot-com-gitlab-org-merge-request changes: *feature-flag-development-config-patterns +# This rule should share the same logic with .as-if-jh:rules:prepare-as-if-jh +# in additionally that there are changes in dependency-patterns +# Unfortunately, we can't say it has changes in +# feature-flag-development-config-patterns +# And in +# dependency-patterns +# At the same time. Note that this can't be using OR so using a union pattern +# doesn't work either. Given that we cannot specify this, there's a gap can +# happen when: +# * The merge request does not have ~"pipeline:run-as-if-jh" +# * The merge request changes a feature flag +# * The merge request also changes dependencies +# In this case, we expect that we do run `sync-as-if-jh-branch` but it won't, +# meaning that dependencies in the JH validation pipeline will be outdated. +# To work around this issue, apply ~"pipeline:run-as-if-jh" to the merge +# request so we can force it to run `sync-as-if-jh-branch` when there are +# dependencies changes. +.as-if-jh:rules:sync-as-if-jh: + rules: + - !reference [".strict-ee-only-rules", rules] + - !reference [".as-if-jh-default-exclusion-rules", rules] + - <<: *if-merge-request-labels-as-if-jh + changes: *dependency-patterns + # Ideally, we should be able to do this: + # - <<: *if-dot-com-gitlab-org-merge-request + # changes: *feature-flag-development-config-patterns && *dependency-patterns + # This rule should share the same logic with .as-if-jh:rules:prepare-as-if-jh # Because the jobs using this need jobs using the preparation rules .as-if-jh:rules:start-as-if-jh: diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 0b5860b3dd..36e2c33874 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -90,7 +90,7 @@ generate-frontend-fixtures-mapping: before_script: - !reference [.default-before_script, before_script] - source ./scripts/rspec_helpers.sh - - run_timed_command "scripts/gitaly-test-spawn" + - section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here script: - generate_frontend_fixtures_mapping artifacts: @@ -106,7 +106,7 @@ detect-tests: variables: RSPEC_TESTS_MAPPING_ENABLED: "true" before_script: - - apt-get update && apt-get install -y curl # Not present in ruby-slim, so we add it manually + - apt-get update && apt-get install -y curl # Not present in ruby-slim, so we add it manually script: - source ./scripts/utils.sh - source ./scripts/rspec_helpers.sh @@ -163,8 +163,6 @@ e2e-test-pipeline-generate: stage: prepare variables: ENV_FILE: $CI_PROJECT_DIR/qa_tests_vars.env - OMNIBUS_PIPELINE_YML: package-and-test-pipeline.yml - REVIEW_PIPELINE_YML: review-app-pipeline.yml COLORIZED_LOGS: "true" script: - bundle exec rake "ci:detect_changes[$ENV_FILE]" @@ -172,5 +170,4 @@ e2e-test-pipeline-generate: artifacts: expire_in: 1 day paths: - - $OMNIBUS_PIPELINE_YML - - $REVIEW_PIPELINE_YML + - '*-pipeline.yml' diff --git a/.gitlab/ci/test-metadata.gitlab-ci.yml b/.gitlab/ci/test-metadata.gitlab-ci.yml index 20d768c9e9..41fd0b4917 100644 --- a/.gitlab/ci/test-metadata.gitlab-ci.yml +++ b/.gitlab/ci/test-metadata.gitlab-ci.yml @@ -18,7 +18,7 @@ retrieve-tests-metadata: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-slim stage: prepare script: - - apt-get update && apt-get install -y curl # Not present in ruby-slim, so we add it manually + - apt-get update && apt-get install -y curl # Not present in ruby-slim, so we add it manually - install_gitlab_gem - source ./scripts/rspec_helpers.sh - retrieve_tests_metadata diff --git a/.gitlab/ci/test-on-gdk/main.gitlab-ci.yml b/.gitlab/ci/test-on-gdk/main.gitlab-ci.yml index d51e255fb9..6073098ef0 100644 --- a/.gitlab/ci/test-on-gdk/main.gitlab-ci.yml +++ b/.gitlab/ci/test-on-gdk/main.gitlab-ci.yml @@ -1,15 +1,7 @@ -default: - interruptible: true - include: - - local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml - -dont-interrupt-me: - extends: .rules:dont-interrupt - stage: test - interruptible: false - script: - - echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible." + - local: .gitlab/ci/qa-common/main.gitlab-ci.yml + - local: .gitlab/ci/qa-common/rules.gitlab-ci.yml + - local: .gitlab/ci/qa-common/variables.gitlab-ci.yml .run-tests: stage: test @@ -21,19 +13,19 @@ dont-interrupt-me: before_script: - docker login -u $CI_REGISTRY_USER -p $CI_REGISTRY_PASSWORD $CI_REGISTRY - sysctl -n -w fs.inotify.max_user_watches=524288 + - echo "SUITE_RAN=true" > suite_status.env variables: DOCKER_DRIVER: overlay2 DOCKER_HOST: tcp://docker:2375 QA_GDK_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab-qa-gdk:master" - QA_GENERATE_ALLURE_REPORT: "false" + QA_GENERATE_ALLURE_REPORT: "true" QA_CAN_TEST_PRAEFECT: "false" QA_INTERCEPT_REQUESTS: "false" - QA_RUN_TYPE: e2e-test-on-gdk TEST_LICENSE_MODE: $QA_TEST_LICENSE_MODE EE_LICENSE: $QA_EE_LICENSE GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN - QA_KNAPSACK_REPORTS: qa-smoke,ee-instance-parallel + RSPEC_REPORT_OPTS: "--format QA::Support::JsonFormatter --out tmp/rspec-${CI_JOB_ID}.json --format RspecJunitFormatter --out tmp/rspec-${CI_JOB_ID}.xml --format html --out tmp/rspec-${CI_JOB_ID}.htm --color --format documentation" timeout: 2 hours artifacts: when: always @@ -41,6 +33,9 @@ dont-interrupt-me: - test_output - logs expire_in: 7 days + reports: + junit: test_output/**/rspec-*.xml + dotenv: suite_status.env script: - echo -e "\e[0Ksection_start:`date +%s`:pull_image\r\e[0KPull GDK QA image" - docker pull ${QA_GDK_IMAGE} @@ -49,7 +44,7 @@ dont-interrupt-me: - cd qa && bundle install --jobs=$(nproc) --retry=3 --quiet - mkdir -p $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs/gdk $CI_PROJECT_DIR/logs/gitlab # This command matches the permissions of the user that runs GDK inside the container. - - chown -R 1000:1000 $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs + - chown -R 1000:1000 $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs $CI_PROJECT_DIR/qa/knapsack - | docker run --rm --name gdk --add-host gdk.test:127.0.0.1 --shm-size=2gb \ --env-file <(bundle exec rake ci:env_var_name_list) \ @@ -57,9 +52,20 @@ dont-interrupt-me: --volume $CI_PROJECT_DIR/test_output:/home/gdk/gdk/gitlab/qa/tmp:z \ --volume $CI_PROJECT_DIR/logs/gdk:/home/gdk/gdk/log \ --volume $CI_PROJECT_DIR/logs/gitlab:/home/gdk/gdk/gitlab/log \ - ${QA_GDK_IMAGE} "${CI_COMMIT_SHA}" "$TEST_GDK_TAGS --tag ~requires_praefect" || true - - echo -e "\e[0Ksection_end:`date +%s`:launch_gdk_and_tests\r\e[0K" + --volume $CI_PROJECT_DIR/qa/knapsack:/home/gdk/gdk/gitlab/qa/knapsack \ + ${QA_GDK_IMAGE} "${CI_COMMIT_SHA}" "$RSPEC_REPORT_OPTS $TEST_GDK_TAGS --tag ~requires_praefect" + # The above image's launch script takes two arguments only - first one is the commit sha and the second one Rspec Args allow_failure: true + after_script: + - | + if [ "$CI_JOB_STATUS" == "failed" ]; then + echo "SUITE_FAILED=true" >> suite_status.env + fi + +download-knapsack-report: + extends: + - .download-knapsack-report + - .rules:download-knapsack test-on-gdk-smoke: extends: @@ -67,7 +73,6 @@ test-on-gdk-smoke: parallel: 2 variables: TEST_GDK_TAGS: "--tag smoke" - QA_KNAPSACK_REPORT_NAME: qa-smoke rules: - when: always @@ -75,7 +80,50 @@ test-on-gdk-full: extends: - .run-tests parallel: 5 - variables: - QA_KNAPSACK_REPORT_NAME: ee-instance-parallel rules: - when: manual + +# ========================================== +# Post test stage +# ========================================== +e2e-test-report: + extends: + - .e2e-test-report + - .rules:report:allure-report + variables: + ALLURE_RESULTS_GLOB: test_output/allure-results + +upload-knapsack-report: + extends: + - .upload-knapsack-report + - .rules:report:process-results + variables: + QA_KNAPSACK_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/test_output/knapsack/*/*.json + +export-test-metrics: + extends: + - .export-test-metrics + - .rules:report:process-results + variables: + QA_METRICS_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/test_output/test-metrics-*.json + +relate-test-failures: + extends: + - .relate-test-failures + - .rules:report:process-results + variables: + QA_RSPEC_JSON_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.json + +generate-test-session: + extends: + - .generate-test-session + - .rules:report:process-results + variables: + QA_RSPEC_JSON_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.json + +notify-slack: + extends: + - .notify-slack + - .rules:report:process-results + variables: + QA_RSPEC_XML_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.xml diff --git a/.gitlab/ci/vendored-gems.gitlab-ci.yml b/.gitlab/ci/vendored-gems.gitlab-ci.yml index a2af802c65..3773a343d6 100644 --- a/.gitlab/ci/vendored-gems.gitlab-ci.yml +++ b/.gitlab/ci/vendored-gems.gitlab-ci.yml @@ -38,14 +38,6 @@ vendor omniauth-azure-oauth2: include: vendor/gems/omniauth-azure-oauth2/.gitlab-ci.yml strategy: depend -vendor omniauth-cas3: - extends: - - .vendor:rules:omniauth-cas3 - needs: [] - trigger: - include: vendor/gems/omniauth-cas3/.gitlab-ci.yml - strategy: depend - vendor omniauth_crowd: extends: - .vendor:rules:omniauth_crowd diff --git a/.gitlab/issue_templates/AI Project Proposal.md b/.gitlab/issue_templates/AI Project Proposal.md index 1b3202b402..072e7ed9ed 100644 --- a/.gitlab/issue_templates/AI Project Proposal.md +++ b/.gitlab/issue_templates/AI Project Proposal.md @@ -1,8 +1,18 @@ - +TITLE FORMAT +🤖 [AI Proposal] {Need/outcome} {Beneficiary} {Job/Small Job} + +The title should be something that is easily understood that quickly communicates the intent of the project allowing team members to easily understand and recognize the expected work that will be done. A proposal title should combine the beneficiary of the feature/UI, the job it will allow them to accomplish (see https://about.gitlab.com/handbook/product/ux/jobs-to-be-done/#how-to-write-a-jtbd), and their expected outcome when the work is delivered. Well-defined statements are concise without sacrificing the substance of the proposal so that anyone can understand it at a glance. (e.g. {Reduce the effort} {for security teams} {when prioritizing business-critical risks in their assets}). +--> + +# Experiment + +This section should be completed prior to work on the Experiment beginning. # [Experiment](https://docs.gitlab.com/ee/policy/alpha-beta-support.html#experiment) @@ -21,22 +31,26 @@ _What assumptions are you making about this problem and the solution?_ _What [personas](https://about.gitlab.com/handbook/product/personas/#list-of-user-personas) have this problem, who is the intended user?_ ## Proposal - + ### Success _How will you measure whether this experiment is a success?_ -# [General Availability](https://docs.gitlab.com/ee/policy/alpha-beta-support.html#generally-available-ga) -## Main Job story +# Feature release + +### Main Job story _What job to be done will this solve?_ -### Proposal updates/additions - +## Proposal updates/additions + ### Problem validation _What validation exists that customers have this problem?_ + ### Business objective _What business objective will be achieved with this proposal?_ @@ -59,34 +73,33 @@ _What tasks or actions should the user be capable of performing with this featur #### The user needs to be able to: - ... - ... -- ... ## Checklist ### Experiment - -
- Issue information +
Issue information - [ ] Add information to the issue body about: - - [ ] The user problem being solved - - [ ] Your assumptions - - [ ] Who it's for, list of personas impacted - - [ ] Your proposal + - [ ] The user problem being solved + - [ ] Your assumptions + - [ ] Who it's for, list of personas impacted + - [ ] Your proposal - [ ] Add relevant designs to the Design Management area of the issue if available +- [ ] Confirm that an unexpected outage of this feature will not negatively impact the application or other features +- [ ] Add a feature flag so that this feature can be quickly disabled if/when needed +- [ ] If this experiment introduces a new service or data store, ensure it is not processing or storing [red data](https://about.gitlab.com/handbook/security/data-classification-standard.html#data-classification-levels) without a security and if needed legal review + - *NOTE*: We recommend using one of the already adopted models or data stores. If you need to use something else, be aware that using other models or data stores will require additional review during the feature stage for operational fitness and compliance. - [ ] Ensure this issue has the ~wg-ai-integration label to ensure visibility to various teams working on this
-### General Availability - -
-Issue information +### Feature release +
Issue information - [ ] Add information to the issue body about: - - [ ] Your proposal - - [ ] The Job Statement it's expected to satisfy - - [ ] Details about the user problem and provide any research or problem validation + - [ ] Your proposal + - [ ] The Job Statement it's expected to satisfy + - [ ] Details about the user problem and provide any research or problem validation - [ ] List the personas impacted by the proposal. - [ ] Add all relevant solution validation issues to the Linked items section that shows this proposal will solve the customer problem, or details explaining why it's not possible to provide that validation. - [ ] Add relevant designs to the Design Management area of the issue. @@ -95,30 +108,28 @@ _What tasks or actions should the user be capable of performing with this featur
-
-Technical needs +
Technical needs -- [ ] [Operational Requirements Review - Checklist - #note_1337519985](https://gitlab.com/gitlab-org/gitlab/-/issues/403859#note_1337519985) +- [ ] Please consider the operational aspects of the feature you are creating. A list of things to think about is in: https://gitlab.com/gitlab-org/gitlab/-/issues/403859. We will be improving this process in the future: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117637#note_1353253349. +- [ ] @ mention your [AppSec Stable Counterpart](https://about.gitlab.com/handbook/product/categories/) and read the [AI secure coding guidelines](https://docs.gitlab.com/ee/development/secure_coding_guidelines.html#artificial-intelligence-ai-features) -1. **Work estimate and skills needs to build an ML viable feature:** To build any ML feature depending on the work, there are many personas that contribute including, Data Scientist, NLP engineer, ML Engineer, MLOps Engineer, ML Infra engineers, and Fullstack engineer to integrate the ML Services with Gitlab. Post-prototype we would assess the skills needed to build a production-grade ML feature for the prototype -2. **Data Limitation:** We would like to upfront validate if we have viable data for the feature including whether we can use the DataOps pipeline of ModelOps or create a custom one. We would want to understand the training data, test data, and feedback data to dial up the accuracy and the limitations of the data. -3. **Model Limitation:** We would want to understand if we can use an open-source pre-trained model, tune and customize it or start a model from scratch as well. Further, we would asses based on the ModelOps model evaluation framework which would be the right model to use based on the use case. -4. **Cost, Scalability, Reliability:** We would want to estimate the cost of hosting, serving, inference of the model, and the full end-to-end infrastructure including monitoring and observability. -5. **Legal and Ethical Framework:** We would want to align with legal and ethical framework like any other ModelOps features to cover across the nine principles of responsible ML and any legal support needed. +1. Work estimate and skills needs to build an ML viable feature: To build any ML feature depending on the work, there are many personas that contribute including, Data Scientist, NLP engineer, ML Engineer, MLOps Engineer, ML Infra engineers, and Fullstack engineer to integrate the ML Services with Gitlab. Post-prototype we would assess the skills needed to build a production-grade ML feature for the prototype. +2. Data Limitation: We would like to upfront validate if we have viable data for the feature including whether we can use the DataOps pipeline of ModelOps or create a custom one. We would want to understand the training data, test data, and feedback data to dial up the accuracy and the limitations of the data. +3. Model Limitation: We would want to understand if we can use an open-source pre-trained model, tune and customize it or start a model from scratch as well. Further, we would assess based on the ModelOps model evaluation framework which would be the right model to use based on the use case. +4. Cost, Scalability, Reliability: We would want to estimate the cost of hosting, serving, inference of the model, and the full end-to-end infrastructure including monitoring and observability. +5. Legal and Ethical Framework: We would want to align with legal and ethical framework like any other ModelOps features to cover across the nine principles of responsible ML and any legal support needed.
-
-Dependency needs +
Dependency needs -- [ ] [Operational Requirements Review - Checklist - #note_1337519985](https://gitlab.com/gitlab-org/gitlab/-/issues/403859#note_1337519985) +- [ ] Please consider the operational aspects of the service you are creating. A list of things to think about is in: https://gitlab.com/gitlab-org/gitlab/-/issues/403859. We will be improving this process in the future: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117637#note_1353253349.
-
-Legal needs +
Legal needs -- [ ] TBD +- [ ] TBD
@@ -134,5 +145,3 @@ _What tasks or actions should the user be capable of performing with this featur /label ~wg-ai-integration /cc @tmccaslin @hbenson @wayne @pedroms @jmandell /confidential - -[Make change to this template](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/AI%20Project%20Proposal.md) diff --git a/.gitlab/issue_templates/Feature Flag Cleanup.md b/.gitlab/issue_templates/Feature Flag Cleanup.md index d32b0c874d..f96165fd35 100644 --- a/.gitlab/issue_templates/Feature Flag Cleanup.md +++ b/.gitlab/issue_templates/Feature Flag Cleanup.md @@ -48,4 +48,4 @@ Are there any other stages or teams involved that need to be kept in the loop? - [ ] Close this rollout issue. -/label ~"feature flag" ~"type::feature" ~"feature::addition" +/label ~"feature flag" ~"type::maintenance" ~"maintenance::removal" diff --git a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md index 60b091b04a..05a643c967 100644 --- a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md +++ b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md @@ -100,7 +100,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org - [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md). -- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/docs): +- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/geo/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/geo/docs): ```yaml table_name: cool_widget_registry @@ -602,6 +602,7 @@ Metrics are gathered by `Geo::MetricsUpdateWorker`, persisted in `GeoNodeStatus` | `geo_cool_widgets_verified` | Gauge | XX.Y | Number of Cool Widgets successfully verified on secondary | `url` | | `geo_cool_widgets_verification_failed` | Gauge | XX.Y | Number of Cool Widgets that failed verification on secondary | `url` | ``` +- [ ] Run the rake task `geo:dev:ssf_metrics` and commit the changes to `ee/config/metrics/object_schemas/geo_node_usage.json` Cool Widget replication and verification metrics should now be available in the API, the `Admin > Geo > Sites` view, and Prometheus. diff --git a/.gitlab/issue_templates/Geo Replicate a new blob type.md b/.gitlab/issue_templates/Geo Replicate a new blob type.md index df2d1871a8..fc454919ce 100644 --- a/.gitlab/issue_templates/Geo Replicate a new blob type.md +++ b/.gitlab/issue_templates/Geo Replicate a new blob type.md @@ -100,7 +100,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org - [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md). -- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/docs): +- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/geo/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/geo/docs): ```yaml table_name: cool_widget_registry @@ -570,6 +570,7 @@ Metrics are gathered by `Geo::MetricsUpdateWorker`, persisted in `GeoNodeStatus` | `geo_cool_widgets_verified` | Gauge | XX.Y | Number of Cool Widgets successfully verified on secondary | `url` | | `geo_cool_widgets_verification_failed` | Gauge | XX.Y | Number of Cool Widgets that failed verification on secondary | `url` | ``` +- [ ] Run the rake task `geo:dev:ssf_metrics` and commit the changes to `ee/config/metrics/object_schemas/geo_node_usage.json` Cool Widget replication and verification metrics should now be available in the API, the `Admin > Geo > Sites` view, and Prometheus. diff --git a/.gitlab/issue_templates/Utilization group - bug.md b/.gitlab/issue_templates/Utilization group - bug.md new file mode 100644 index 0000000000..03fed78189 --- /dev/null +++ b/.gitlab/issue_templates/Utilization group - bug.md @@ -0,0 +1,166 @@ + +Utilization group: Bug Report Template + +## Bug Summary + + + +## Steps to reproduce + + + +1. [Step 1] +1. [Step 2] +1. [Step 3] +1. [Step 4] +1. [Step 5] + +## Example Project + + + +## What is the current *bug* behavior? + + + +## What is the expected *correct* behavior? + + + +## Reproducibility + + + +## Impact Assessment + + + +## Severity + + + +## Environment + + + +## Screenshots and/or Relevant logs + + + + +## Output of checks (GitLab.com) + + + + + + +## Results of GitLab environment info + + + +
+Expand for output related to GitLab environment info + +
+
+(For installations with omnibus-gitlab package run and paste the output of:
+`sudo gitlab-rake gitlab:env:info`)
+
+(For installations from source run and paste the output of:
+`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
+
+
+
+ +## Results of GitLab application Check + + + +
+Expand for output related to the GitLab application check +
+
+(For installations with omnibus-gitlab package run and paste the output of:
+`sudo gitlab-rake gitlab:check SANITIZE=true`)
+
+(For installations from source run and paste the output of:
+`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
+
+(we will only investigate if the tests are passing)
+
+
+
+ +## Possible fixes + + + + + +/label ~"type::bug" +/label ~"Category:Consumables Cost Management" +/label ~"group::utilization" +/label ~"section::fulfillment" + +--- +
+Illustrative Description: (This is not an actual issue, but rather a sample report that demonstrates how a bug could be presented) +## Bug Summary + +When attempting to log in to GitLab using a new account, the system does not recognize the account and returns an error message. + +## Steps to Reproduce + +1. Navigate to the GitLab login page. +1. Enter the email and password for a new account. +1. Click the "Log In" button. +1. Observe the error message: "The email or password you entered is incorrect. Please try again." + +## What is the current *bug* behavior? + +The system does not recognize the new account and returns an error message. + +## What is the expected *correct* behavior? + +The system should recognize the new account and allow the user to log in. + +## Reproducibility + +This bug occurs consistently when attempting to log in with a new account. + +## Impact Assessment + +This bug prevents new users from accessing GitLab and may result in frustration and lost productivity. + +## Severity + +This bug is of medium severity, as it prevents new users from accessing the system, but does not affect the functionality of existing users. + +## Environment + +- Operating System: macOS Ventura +- Browser: Google Chrome 111.0.5563.146 + +## Screenshots and/or Relevant logs + +[Insert screenshot of the error message.] + +## Possible Fix + +It is unclear what may be causing this bug. Further investigation is required to identify a possible fix. + +
diff --git a/.gitlab/issue_templates/Utilization group - feature.md b/.gitlab/issue_templates/Utilization group - feature.md new file mode 100644 index 0000000000..57a4d4128c --- /dev/null +++ b/.gitlab/issue_templates/Utilization group - feature.md @@ -0,0 +1,65 @@ +Utilization group: Feature Template + +## Description + + + +## Acceptance Criteria + +## Technical Requirements + + + +## Design Requirements + + + +## Impact Assessment + + + +## User Story + + +/label ~"type::feature" +/label ~"Category:Consumables Cost Management" +/label ~"group::utilization" +/label ~"section::fulfillment" + +
+Illustrative Description: (This is not an actual issue, but rather a sample report that demonstrates how a feature could be presented) + +## Description + +As a developer, I want to be able to easily create and manage merge requests, so that I can collaborate effectively with my team and ensure that code changes are reviewed and merged efficiently. + +## Acceptance Criteria + +- [ ] The merge request feature should allow developers to create a new merge request from a branch. +- [ ] The merge request feature should allow developers to assign the merge request to another team member for review. +- [ ] The merge request feature should provide a clear and easy-to-use interface for managing merge requests. +- [ ] The merge request feature should integrate with other GitLab features, such as issue tracking and continuous integration. + +## Technical Requirements + +- The merge request feature should be implemented using GitLab's API. +- The merge request feature should be integrated with GitLab's existing authentication and authorization system. +- The merge request feature should be optimized for performance and scalability. + +## Design Requirements + +- [Design specifications for this feature can be found here.](insert_design_link_here) + +## Impact Assessment + +This feature will significantly enhance the collaboration and code review process for developers using GitLab. By providing an intuitive and easy-to-use interface for managing merge requests, developers will be able to work more efficiently and effectively as a team. Additionally, integrating the merge request feature with other GitLab features will further streamline the development process. + +## User Story + +As a developer working on a new feature branch, I want to be able to create a new merge request and assign it to a team member for review, so that I can ensure that my code changes are thoroughly reviewed before being merged into the main codebase. With the new merge request feature, I can easily create a new merge request, assign it to a team member for review, and track its status throughout the review process. This will help me work more efficiently and effectively as a team, while also maintaining high code quality and reliability. + +
diff --git a/.gitlab/issue_templates/Utilization group - maintenance.md b/.gitlab/issue_templates/Utilization group - maintenance.md new file mode 100644 index 0000000000..e25c80e26c --- /dev/null +++ b/.gitlab/issue_templates/Utilization group - maintenance.md @@ -0,0 +1,69 @@ +Utilization Group: Maintenance Template + +## Description + + +## Acceptance Criteria + + +## Technical Requirements + + +## Impact Assessment + + +## Steps to Reproduce + + +## Expected Results + + +## Actual Results + + +/label ~type::maintenance +/label ~"Category:Consumables Cost Management" +/label ~"group::utilization" +/label ~"section::fulfillment" + +
+Illustrative Description: (This is not an actual maintenance issue, but rather a sample report that demonstrates how a maintenance issue could be presented) + +## Description + +The login page is taking longer than expected to load, which is impacting the user experience. + +## Acceptance Criteria + +- [ ] The login page should load in less than 3 seconds on both desktop and mobile devices. +- [ ] The login page should be tested on different browsers to ensure compatibility. +- [ ] The login page should not display any errors or warnings in the console. + +## Technical Requirements + +- [ ] The login page should be optimized for performance. +- [ ] The login page should be tested on different browsers. +- [ ] The login page should be updated to use the latest version of the authentication library. + +## Impact Assessment + +This maintenance issue is impacting the user experience by causing delays in the login process. By resolving this issue, users will be able to log in faster and have a better overall experience. + +## Steps to Reproduce + +1. Open the login page. +1. Wait for the page to load. +1. Measure the time it takes for the page to fully load. + +## Expected Results + +The login page should load in less than 3 seconds on both desktop and mobile devices. + +## Actual Results + +The login page is currently taking more than 5 seconds to load on desktop devices and more than 7 seconds on mobile devices. This is causing frustration and delays for users. + +
diff --git a/.gitlab/merge_request_templates/Change Documentation Location.md b/.gitlab/merge_request_templates/Change Documentation Location.md index 36678c44d7..5e4f289c1f 100644 --- a/.gitlab/merge_request_templates/Change Documentation Location.md +++ b/.gitlab/merge_request_templates/Change Documentation Location.md @@ -14,17 +14,14 @@ ## Moving docs to a new location? -Read the guidelines: -https://docs.gitlab.com/ee/development/documentation/index.html#move-or-rename-a-page +Read the [redirect guidelines](https://docs.gitlab.com/ee/development/documentation/redirects.html) first. - [ ] Make sure the old link is not removed and has its contents replaced with a link to the new location. - [ ] Make sure internal links pointing to the document in question are not broken. - [ ] Search and replace any links referring to old docs in GitLab Rails app, specifically under the `app/views/` and `ee/app/views` (for GitLab EE) directories. -- [ ] Make sure to add [`redirect_from`](https://docs.gitlab.com/ee/development/documentation/index.html#redirections-for-pages-with-disqus-comments) - to the new document if there are any Disqus comments on the old document thread. -- [ ] Update the link in `features.yml` (if applicable). +- [ ] Update the link in [`features.yml`](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/master/data/features.yml) (if applicable). - [ ] Assign one of the technical writers for review. -/label ~documentation ~"Technical Writing" +/label ~documentation ~"Technical Writing" ~"type::maintenance" ~"maintenance::refactor" diff --git a/.gitlab/merge_request_templates/Default.md b/.gitlab/merge_request_templates/Default.md index f670882a72..404a18ad07 100644 --- a/.gitlab/merge_request_templates/Default.md +++ b/.gitlab/merge_request_templates/Default.md @@ -8,6 +8,8 @@ that reviewers can understand your intent. Keeping the description updated is especially important if they didn't participate in the discussion. --> +%{first_multiline_commit} + ## Screenshots or screen recordings _Screenshots are required for UI changes, and strongly recommended for all other merge requests._ @@ -25,10 +27,6 @@ _Numbered steps to set up and validate the change are strongly suggested._ /label ~"release post" ~"release post item" ~"Technical Writing" ~devops:: ~group:: ~"release post item::removal" -/label ~"type::maintenance" +/label ~"type::maintenance" ~"maintenance::removal" /milestone % /assign `@EM/PM` (choose the DRI; remove backticks here, and below) @@ -46,7 +46,6 @@ Please review: - [ ] Set yourself as the Assignee, meaning you are the DRI. - [ ] If the removal is a [breaking change](https://about.gitlab.com/handbook/product/gitlab-the-product/#breaking-change), add label `breaking change`. - [ ] Follow the process to [create a removal YAML file](https://about.gitlab.com/handbook/marketing/blog/release-posts/#creating-a-removal-entry). -- [ ] Make sure that the milestone dates are based on the dates in [Product milestone creation](https://about.gitlab.com/handbook/product/milestones/#product-milestone-creation). - [ ] Add reviewers by the 10th. - [ ] When ready to be merged and not later than the 15th, add the ~ready label and @ message the TW for final review and merge. - Removal notices should not be merged before the code is removed from the product. Do not mark ~ready until the removal is complete, or you are certain it will be completed within the current milestone and released. If PMs are not sure, they should confirm with their Engineering Manager. diff --git a/.gitlab/merge_request_templates/Stable Branch.md b/.gitlab/merge_request_templates/Stable Branch.md index 949aa6386a..f8fc85f5bd 100644 --- a/.gitlab/merge_request_templates/Stable Branch.md +++ b/.gitlab/merge_request_templates/Stable Branch.md @@ -23,14 +23,13 @@ This checklist encourages us to confirm any changes have been analyzed to reduce #### Note to the merge request author and maintainer -The process of backporting bug fixes into stable branches is tracked as part of an -[internal pilot]. If you have questions about this process, please: +If you have questions about the patch release process, please: -* Refer to the [internal pilot] issue for feedback or questions. * Refer to the [patch release runbook for engineers and maintainers] for guidance. +* Ask questions on the [`#releases`] Slack channel (internal only). [severity label]: https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity -[internal pilot]: https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2886 -[patch release runbook for engineers and maintainers]: https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/process_new.md +[patch release runbook for engineers and maintainers]: https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md +[`#releases`]: https://gitlab.slack.com/archives/C0XM5UU6B /assign me diff --git a/.gitlab/secret-detection-ruleset.toml b/.gitlab/secret-detection-ruleset.toml index 5fcde57cad..4a76fb22d0 100644 --- a/.gitlab/secret-detection-ruleset.toml +++ b/.gitlab/secret-detection-ruleset.toml @@ -4,3 +4,8 @@ [secrets.ruleset.identifier] type = "gitleaks_rule_id" value = "Password in URL" + [[secrets.passthrough]] + type = "file" + # note this must be gitleaks.toml + target = "gitleaks.toml" + value = "config/gitleaks.toml" diff --git a/.gitpod.yml b/.gitpod.yml index ef6e39881e..684f9a8e5a 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -51,6 +51,9 @@ tasks: [[ -f /workspace/gitpod_start_time.sh ]] && source /workspace/gitpod_start_time.sh SECONDS=0 cd /workspace/gitlab-development-kit + make gitlab-update + make gitlab-shell-update + make gitlab-workhorse-update # update GDK if [ "$GITLAB_UPDATE_GDK" == true ]; then echo "$(date) – Updating GDK" | tee -a /workspace/startup.log @@ -126,3 +129,4 @@ vscode: - dbaeumer.vscode-eslint@2.2.6 - GitLab.gitlab-workflow@3.56.0 - DavidAnson.vscode-markdownlint@0.47.0 + - esbenp.prettier-vscode diff --git a/.markdownlint.yml b/.markdownlint.yml index b77e7c488c..e1143511b6 100644 --- a/.markdownlint.yml +++ b/.markdownlint.yml @@ -52,6 +52,7 @@ proper-names: "Geo", "Git LFS", "git-annex", + "git-credential-oauth", "git-sizer", "Git", "Gitaly", diff --git a/.rubocop.yml b/.rubocop.yml index 6aa0e1ca4d..81ad4cd31f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -107,6 +107,9 @@ InternalAffairs/DeprecateCopHelper: Layout/LineLength: AllowedPatterns: ['^RSpec\.describe\s.*\sdo'] + Exclude: + - 'ee/spec/controllers/concerns/routable_actions_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/sso_enforcer_spec.rb' Lint/LastKeywordArgument: Safe: false @@ -114,6 +117,7 @@ Lint/LastKeywordArgument: Lint/EmptyFile: Exclude: - 'db/seeds.rb' + - 'ee/db/embedding/seeds.rb' - 'ee/db/geo/seeds.rb' # This cop checks whether some constant value isn't a @@ -148,6 +152,8 @@ RSpec/FilePath: - 'ee/spec/frontend/fixtures/*' - 'spec/requests/api/v3/*' - 'spec/fixtures/**/*' + CustomTransform: + HTTPartyBasicAuth: httparty_basic_auth # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: @@ -521,6 +527,12 @@ RSpec/AvoidTestProf: - 'ee/spec/lib/gitlab/background_migration/**/*.rb' - 'ee/spec/lib/ee/gitlab/background_migration/**/*.rb' +RSpec/AvoidConditionalStatements: + Enabled: true + Include: + - 'spec/features/**/*.rb' + - 'ee/spec/features/**/*.rb' + RSpec/FactoriesInMigrationSpecs: Enabled: true Include: @@ -991,3 +1003,7 @@ SidekiqLoadBalancing/WorkerDataConsistency: Include: - 'app/workers/**/*' - 'ee/app/workers/**/*' + +# This cop is disabled for Ruby 3.0+ anyway. +Lint/NonDeterministicRequireOrder: + Enabled: false diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 32f8ddc0ae..d303f0d533 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -17,7 +17,6 @@ Capybara/VisibilityMatcher: - 'ee/spec/support/helpers/billing_plans_helpers.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' @@ -55,7 +54,6 @@ Capybara/VisibilityMatcher: - 'spec/features/search/user_searches_for_commits_spec.rb' - 'spec/features/snippets/notes_on_personal_snippets_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' @@ -69,7 +67,6 @@ Capybara/VisibilityMatcher: - 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb' - 'spec/views/import/gitlab_projects/new.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/profiles/preferences/show.html.haml_spec.rb' - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' diff --git a/.rubocop_todo/cop/redirect_with_status.yml b/.rubocop_todo/cop/redirect_with_status.yml deleted file mode 100644 index 3b4d9d2681..0000000000 --- a/.rubocop_todo/cop/redirect_with_status.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -Cop/RedirectWithStatus: - Details: grace period - Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/membership_actions.rb' diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index d0e1d035a8..82f57e5288 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -16,7 +16,6 @@ Cop/UserAdmin: - 'app/services/projects/fork_service.rb' - 'app/services/users/build_service.rb' - 'ee/app/controllers/ee/projects_controller.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/services/ee/groups/create_service.rb' diff --git a/.rubocop_todo/database/disable_referential_integrity.yml b/.rubocop_todo/database/disable_referential_integrity.yml deleted file mode 100644 index 95cfc5920d..0000000000 --- a/.rubocop_todo/database/disable_referential_integrity.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Database/DisableReferentialIntegrity: - Exclude: - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' diff --git a/.rubocop_todo/database/rescue_query_canceled.yml b/.rubocop_todo/database/rescue_query_canceled.yml index 324ab498dd..3fa3c8c388 100644 --- a/.rubocop_todo/database/rescue_query_canceled.yml +++ b/.rubocop_todo/database/rescue_query_canceled.yml @@ -2,7 +2,6 @@ Database/RescueQueryCanceled: Exclude: - 'app/services/issues/relative_position_rebalancing_service.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/issuables_count_for_state.rb' diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml index f39ca78fd8..bfb5125029 100644 --- a/.rubocop_todo/fips/sha1.yml +++ b/.rubocop_todo/fips/sha1.yml @@ -18,18 +18,13 @@ Fips/SHA1: - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/spec/factories/vulnerabilities/feedback.rb' - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/resource_weight_event_spec.rb' - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' @@ -76,7 +71,6 @@ Fips/SHA1: - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' @@ -84,9 +78,7 @@ Fips/SHA1: - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/pipeline_spec.rb' diff --git a/.rubocop_todo/gettext/static_identifier.yml b/.rubocop_todo/gettext/static_identifier.yml new file mode 100644 index 0000000000..c330ffe148 --- /dev/null +++ b/.rubocop_todo/gettext/static_identifier.yml @@ -0,0 +1,28 @@ +--- +Gettext/StaticIdentifier: + Details: grace period + Exclude: + - 'app/graphql/types/project_type.rb' + - 'app/models/integrations/apple_app_store.rb' + - 'app/models/integrations/confluence.rb' + - 'app/models/integrations/google_play.rb' + - 'app/services/import/fogbugz_service.rb' + - 'app/services/issuable_links/create_service.rb' + - 'app/services/issues/set_crm_contacts_service.rb' + - 'app/services/projects/create_from_template_service.rb' + - 'app/services/security/ci_configuration/base_create_service.rb' + - 'app/services/users/banned_user_base_service.rb' + - 'app/services/work_items/widgets/hierarchy_service/base_service.rb' + - 'ee/app/controllers/admin/licenses_controller.rb' + - 'ee/app/controllers/subscriptions/groups_controller.rb' + - 'ee/app/mailers/ee/emails/admin_notification.rb' + - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/app/services/ee/projects/create_from_template_service.rb' + - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' + - 'ee/app/services/timebox/rollup_report_service.rb' + - 'ee/app/services/timebox_report_service.rb' + - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' + - 'ee/spec/features/registrations/identity_verification_spec.rb' + - 'lib/gitlab/github_import/settings.rb' diff --git a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml deleted file mode 100644 index f5433dfd32..0000000000 --- a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml +++ /dev/null @@ -1,13 +0,0 @@ ---- -Gitlab/DeprecateTrackRedisHLLEvent: - Exclude: - - 'app/controllers/concerns/snippets_actions.rb' - - 'app/controllers/concerns/wiki_actions.rb' - - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/pipelines_controller.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' - - 'ee/app/controllers/admin/credentials_controller.rb' - - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' - - 'ee/app/controllers/groups/audit_events_controller.rb' - - 'ee/app/controllers/groups/epic_boards_controller.rb' - - 'spec/controllers/concerns/redis_tracking_spec.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index 67c70593b4..ad203c8abd 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -24,7 +24,6 @@ Gitlab/DocUrl: - 'ee/app/mailers/emails/user_cap.rb' - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/system_check/app/advanced_search_migrations_check.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'lib/backup/database.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 0ec0bc6686..3a81130a47 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -79,7 +79,6 @@ Gitlab/NamespacedClass: - 'app/finders/resource_milestone_event_finder.rb' - 'app/finders/resource_state_event_finder.rb' - 'app/finders/sentry_issue_finder.rb' - - 'app/finders/serverless_domain_finder.rb' - 'app/finders/snippets_finder.rb' - 'app/finders/starred_projects_finder.rb' - 'app/finders/tags_finder.rb' @@ -245,6 +244,7 @@ Gitlab/NamespacedClass: - 'app/models/notification_setting.rb' - 'app/models/oauth_access_grant.rb' - 'app/models/oauth_access_token.rb' + - 'app/models/organization.rb' - 'app/models/out_of_context_discussion.rb' - 'app/models/pages_deployment.rb' - 'app/models/pages_domain.rb' @@ -307,6 +307,7 @@ Gitlab/NamespacedClass: - 'app/models/service_desk_setting.rb' - 'app/models/service_list.rb' - 'app/models/shard.rb' + - 'app/models/slack_integration.rb' - 'app/models/snippet.rb' - 'app/models/snippet_blob.rb' - 'app/models/snippet_input_action.rb' @@ -353,6 +354,7 @@ Gitlab/NamespacedClass: - 'app/models/x509_certificate.rb' - 'app/models/x509_issuer.rb' - 'app/models/zoom_meeting.rb' + - 'app/policies/abuse_report_policy.rb' - 'app/policies/application_setting/term_policy.rb' - 'app/policies/award_emoji_policy.rb' - 'app/policies/base_policy.rb' @@ -477,7 +479,6 @@ Gitlab/NamespacedClass: - 'app/serializers/build_metadata_entity.rb' - 'app/serializers/build_trace_entity.rb' - 'app/serializers/build_trace_serializer.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/cluster_entity.rb' - 'app/serializers/cluster_serializer.rb' - 'app/serializers/codequality_degradation_entity.rb' @@ -821,8 +822,6 @@ Gitlab/NamespacedClass: - 'app/workers/run_pipeline_schedule_worker.rb' - 'app/workers/schedule_merge_request_cleanup_refs_worker.rb' - 'app/workers/schedule_migrate_external_diffs_worker.rb' - - 'app/workers/self_monitoring_project_create_worker.rb' - - 'app/workers/self_monitoring_project_delete_worker.rb' - 'app/workers/service_desk_email_receiver_worker.rb' - 'app/workers/stage_update_worker.rb' - 'app/workers/stuck_ci_jobs_worker.rb' @@ -938,7 +937,6 @@ Gitlab/NamespacedClass: - 'ee/app/models/scim_identity.rb' - 'ee/app/models/scim_oauth_access_token.rb' - 'ee/app/models/scoped_label_set.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/smartcard_identity.rb' - 'ee/app/models/software_license.rb' - 'ee/app/models/software_license_policy.rb' @@ -1049,6 +1047,7 @@ Gitlab/NamespacedClass: - 'ee/app/workers/elastic_namespace_indexer_worker.rb' - 'ee/app/workers/elastic_namespace_rollout_worker.rb' - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' - 'ee/app/workers/geo_repository_destroy_worker.rb' - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/app/workers/historical_data_worker.rb' @@ -1069,7 +1068,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/sync_seat_link_request_worker.rb' - 'ee/app/workers/sync_seat_link_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/gitlab/authority_analyzer.rb' - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -1270,7 +1268,6 @@ Gitlab/NamespacedClass: - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - 'spec/support/helpers/fake_migration_classes.rb' - - 'spec/support/helpers/fake_u2f_device.rb' - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/markdown_feature.rb' - 'spec/support/helpers/redis_without_keys.rb' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml index d6ce963388..a61bb27ed2 100644 --- a/.rubocop_todo/gitlab/service_response.yml +++ b/.rubocop_todo/gitlab/service_response.yml @@ -60,7 +60,6 @@ Gitlab/ServiceResponse: - 'ee/app/services/iterations/roll_over_issues_service.rb' - 'ee/app/services/iterations/update_service.rb' - 'ee/app/services/security/findings/dismiss_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/services/vulnerability_issue_links/create_service.rb' - 'ee/app/services/vulnerability_issue_links/delete_service.rb' - 'ee/spec/graphql/mutations/security/finding/dismiss_spec.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index c9ed5041ab..1ab7930a2d 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -356,7 +356,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/gitlab_subscription.rb' - 'ee/app/models/issuables_analytics.rb' - 'ee/app/models/license.rb' - - 'ee/app/models/namespaces/storage/root_excess_size.rb' - 'ee/app/models/sca/license_compliance.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' @@ -409,7 +408,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/incident_management/escalation_policies/update_service.rb' - 'ee/app/services/incident_management/pending_escalations/process_service.rb' - 'ee/app/services/iterations/create_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/services/projects/restore_service.rb' - 'ee/app/services/protected_environments/base_service.rb' @@ -469,7 +467,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/gitlab/auth/group_saml/user.rb' - 'ee/lib/gitlab/auth/saml/membership_updater.rb' - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'ee/lib/gitlab/ci/minutes/build_consumption.rb' - 'ee/lib/gitlab/ci/minutes/cached_quota.rb' - 'ee/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor.rb' - 'ee/lib/gitlab/ci/minutes/runners_availability.rb' @@ -547,7 +544,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' - 'lib/gitlab/auth/request_authenticator.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - - 'lib/gitlab/bare_repository_import/repository.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/chat/command.rb' @@ -653,7 +649,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/lfs_restorer.rb' - 'lib/gitlab/import_export/project/sample/date_calculator.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' @@ -679,7 +674,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/relative_positioning/starting_from.rb' - 'lib/gitlab/request_context.rb' - 'lib/gitlab/search/found_blob.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_queue.rb' diff --git a/.rubocop_todo/graphql/authorize_types.yml b/.rubocop_todo/graphql/authorize_types.yml new file mode 100644 index 0000000000..6735ef9c9a --- /dev/null +++ b/.rubocop_todo/graphql/authorize_types.yml @@ -0,0 +1,7 @@ +--- +Graphql/AuthorizeTypes: + Exclude: + - 'app/graphql/types/data_transfer/base_type.rb' + - 'app/graphql/types/data_transfer/egress_node_type.rb' + - 'app/graphql/types/data_transfer/group_data_transfer_type.rb' + - 'app/graphql/types/data_transfer/project_data_transfer_type.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 4fda4e8f2b..bdd3a15489 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -506,28 +506,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb' - 'app/graphql/types/x509_certificate_type.rb' - 'app/graphql/types/x509_issuer_type.rb' - - 'app/mailers/emails/projects.rb' - - 'app/mailers/notify.rb' - - 'app/models/abuse_report.rb' - - 'app/models/achievements/achievement.rb' - - 'app/models/achievements/user_achievement.rb' - - 'app/models/active_session.rb' - - 'app/models/analytics/cycle_analytics/project_level.rb' - - 'app/models/analytics/cycle_analytics/stage.rb' - - 'app/models/analytics/cycle_analytics/value_stream.rb' - - 'app/models/appearance.rb' - - 'app/models/application_setting.rb' - - 'app/models/atlassian/identity.rb' - - 'app/models/bulk_imports/configuration.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/clusters/kubernetes_namespace.rb' - - 'app/models/container_repository.rb' - - 'app/models/cycle_analytics/project_level_stage_adapter.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/version.rb' - - 'app/models/diff_discussion.rb' - - 'app/models/diff_viewer/base.rb' - 'app/models/discussion.rb' - 'app/models/environment.rb' - 'app/models/generic_commit_status.rb' @@ -541,16 +519,6 @@ Layout/ArgumentAlignment: - 'app/models/integrations/jira.rb' - 'app/models/jira_connect_installation.rb' - 'app/models/lfs_object.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/merge_requests_closing_issues.rb' - - 'app/models/ml/candidate_metadata.rb' - - 'app/models/ml/experiment_metadata.rb' - - 'app/models/namespace.rb' - - 'app/models/namespaces/traversal/linear_scopes.rb' - - 'app/models/note.rb' - - 'app/models/note_diff_file.rb' - 'app/models/packages/cleanup/policy.rb' - 'app/models/packages/conan/metadatum.rb' - 'app/models/packages/debian/file_entry.rb' @@ -568,26 +536,10 @@ Layout/ArgumentAlignment: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/resource_timebox_event.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/service_desk_setting.rb' - 'app/models/terraform/state.rb' - 'app/models/time_tracking/timelog_category.rb' - 'app/models/u2f_registration.rb' - - 'app/models/user.rb' - - 'app/models/user_preference.rb' - - 'app/models/users/group_callout.rb' - - 'app/models/users/phone_number_validation.rb' - - 'app/models/users/project_callout.rb' - - 'app/models/users/user_follow_user.rb' - - 'app/models/web_ide_terminal.rb' - - 'app/models/webauthn_registration.rb' - - 'app/models/wiki_page.rb' - - 'app/models/work_item.rb' - - 'app/services/ci/archive_trace_service.rb' - - 'app/services/ci/ensure_stage_service.rb' - - 'app/services/ci/list_config_variables_service.rb' - - 'app/services/ci/parse_dotenv_artifact_service.rb' - - 'app/services/ci/stuck_builds/drop_helpers.rb' - 'app/services/compare_service.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/design_management/copy_design_collection/copy_service.rb' @@ -608,22 +560,11 @@ Layout/ArgumentAlignment: - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/members/base_service.rb' - 'app/services/members/create_service.rb' - - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/ff_merge_service.rb' - - 'app/services/merge_requests/merge_service.rb' - - 'app/services/merge_requests/merge_to_ref_service.rb' - - 'app/services/merge_requests/push_options_handler_service.rb' - - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/merge_requests/reload_diffs_service.rb' - - 'app/services/merge_requests/retarget_chain_service.rb' - 'app/services/metrics/dashboard/annotations/create_service.rb' - 'app/services/metrics/dashboard/annotations/delete_service.rb' - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/users_starred_dashboards/create_service.rb' - 'app/services/ml/experiment_tracking/experiment_repository.rb' - - 'app/services/notes/create_service.rb' - - 'app/services/notes/destroy_service.rb' - - 'app/services/notes/update_service.rb' - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/preview_markdown_service.rb' @@ -656,13 +597,6 @@ Layout/ArgumentAlignment: - 'config/initializers/rack_timeout.rb' - 'config/initializers/rest-client-hostname_override.rb' - 'config/initializers/zz_metrics.rb' - - 'db/migrate/20210901065504_add_index_on_name_and_id_to_public_groups.rb' - - 'db/migrate/20210910014741_add_dependency_proxy_ttl_group_policy_worker_capacity_to_application_settings.rb' - - 'db/migrate/20211111112639_add_fk_compliance_violations_merge_request.rb' - - 'db/migrate/20211111112713_add_fk_compliance_violations_violating_user.rb' - - 'db/migrate/20211224112937_add_packages_cleanup_package_file_worker_capacity_to_application_settings.rb' - - 'db/migrate/20220204154220_add_index_on_greatest_done_at_to_container_repositories.rb' - - 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb' - 'db/migrate/20220401113123_add_check_constraint_to_vsa_aggregation_runtime_data_columns.rb' - 'db/migrate/20220405125459_add_non_migrated_index_to_container_repositories.rb' - 'db/migrate/20220408001450_add_work_item_type_name_unique_index_null_namespaces.rb' @@ -725,20 +659,6 @@ Layout/ArgumentAlignment: - 'db/migrate/20230124193917_add_index_for_protected_tag_create_access_levels.rb' - 'db/migrate/20230127151529_add_project_pointer_for_analytics_dashboard.rb' - 'db/migrate/20230127151531_change_dashboard_analytics_project_pointer_project_null.rb' - - 'db/post_migrate/20210921062820_add_image_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211022112202_add_cluster_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211027112901_drop_index_keys_on_expires_at_and_before_expiry_notification_undelivered.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211213064821_add_agent_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211217120000_modify_kubernetes_resource_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220216201949_remove_package_files_limit_from_application_settings.rb' - - 'db/post_migrate/20220307192534_create_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192645_remove_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192725_create_unique_index_release_tag_project.rb' - 'db/post_migrate/20220415124802_remove_job_artifact_deprecated_geo_fields.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - 'db/post_migrate/20220523164734_add_foreign_key_to_vulnerability_reads_casted_cluster_agent_id.rb' @@ -792,7 +712,6 @@ Layout/ArgumentAlignment: - 'db/post_migrate/20230130070623_add_index_on_packages_package_file_file_name.rb' - 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/shared.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/create.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/update.rb' - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' @@ -922,7 +841,6 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/mutations/vulnerabilities/create_external_issue_link.rb' - 'ee/app/graphql/mutations/vulnerabilities/destroy_external_issue_link.rb' - 'ee/app/graphql/mutations/vulnerabilities/dismiss.rb' - - 'ee/app/graphql/mutations/vulnerabilities/finding/dismiss.rb' - 'ee/app/graphql/mutations/vulnerabilities/resolve.rb' - 'ee/app/graphql/mutations/vulnerabilities/revert_to_detected.rb' - 'ee/app/graphql/resolvers/alert_management/payload_alert_field_resolver.rb' @@ -1076,8 +994,6 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/types/work_items/widgets/status_filter_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/status_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/weight_input_type.rb' - - 'ee/app/mailers/ee/emails/projects.rb' - - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/approval_wrapped_rule.rb' - 'ee/app/models/dast/pre_scan_verification.rb' - 'ee/app/models/deployments/approval.rb' @@ -1118,7 +1034,6 @@ Layout/ArgumentAlignment: - 'ee/app/models/scim_identity.rb' - 'ee/app/models/security/finding.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/smartcard_identity.rb' - 'ee/app/models/status_page/project_setting.rb' - 'ee/app/models/vulnerabilities/external_issue_link.rb' @@ -1171,44 +1086,11 @@ Layout/ArgumentAlignment: - 'ee/db/geo/post_migrate/20210217020154_add_unique_index_on_container_repository_registry.rb' - 'ee/db/geo/post_migrate/20210217020156_add_unique_index_on_terraform_state_version_registry.rb' - 'ee/db/seeds/awesome_co/awesome_co.rb' - - 'ee/lib/api/analytics/code_review_analytics.rb' - - 'ee/lib/api/analytics/product_analytics.rb' - - 'ee/lib/api/audit_events.rb' - - 'ee/lib/api/dependencies.rb' - - 'ee/lib/api/epics.rb' - - 'ee/lib/api/group_push_rule.rb' - - 'ee/lib/api/helpers/project_approval_rules_helpers.rb' - - 'ee/lib/api/ldap_group_links.rb' - - 'ee/lib/api/merge_request_approval_settings.rb' - - 'ee/lib/api/merge_trains.rb' - - 'ee/lib/api/project_aliases.rb' - - 'ee/lib/api/project_push_rule.rb' - - 'ee/lib/api/related_epic_links.rb' - - 'ee/lib/api/saml_group_links.rb' - - 'ee/lib/api/status_checks.rb' - - 'ee/lib/api/vulnerability_exports.rb' - - 'ee/lib/api/vulnerability_findings.rb' - - 'ee/lib/api/vulnerability_issue_links.rb' - 'ee/lib/audit/compliance_framework_changes_auditor.rb' - 'ee/lib/audit/external_status_check_changes_auditor.rb' - 'ee/lib/audit/group_changes_auditor.rb' - 'ee/lib/audit/group_push_rules_changes_auditor.rb' - 'ee/lib/audit/project_changes_auditor.rb' - - 'ee/lib/ee/api/entities/approval_rule.rb' - - 'ee/lib/ee/api/entities/epic_issue.rb' - - 'ee/lib/ee/api/entities/epic_issue_link.rb' - - 'ee/lib/ee/api/entities/group.rb' - - 'ee/lib/ee/api/entities/group_detail.rb' - - 'ee/lib/ee/api/entities/group_push_rule.rb' - - 'ee/lib/ee/api/entities/member.rb' - - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - - 'ee/lib/ee/api/entities/merge_request_approval_state_rule.rb' - - 'ee/lib/ee/api/entities/project.rb' - - 'ee/lib/ee/api/groups.rb' - - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/ee/api/members.rb' - - 'ee/lib/ee/api/merge_request_approvals.rb' - - 'ee/lib/ee/api/projects.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' @@ -1233,20 +1115,11 @@ Layout/ArgumentAlignment: - 'ee/lib/gitlab/status_page/pipeline/post_process_pipeline.rb' - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - 'ee/lib/gitlab/zoekt/search_results.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/spec/components/billing/plan_component_spec.rb' - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb' - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb' - - 'ee/spec/factories/epic_tree_nodes.rb' - - 'ee/spec/factories/groups.rb' - - 'ee/spec/factories/import_states.rb' - - 'ee/spec/factories/merge_requests.rb' - - 'ee/spec/factories/namespaces.rb' - - 'ee/spec/factories/projects.rb' - - 'ee/spec/factories/security_scans.rb' - - 'ee/spec/factories/vulnerabilities/findings.rb' - 'ee/spec/features/account_recovery_regular_check_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' @@ -1344,9 +1217,7 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' @@ -1370,7 +1241,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/project_config_spec.rb' @@ -1398,7 +1268,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/zoekt/search_results_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb' - 'ee/spec/models/dast/pre_scan_verification_step_spec.rb' - 'ee/spec/models/dast_site_profile_spec.rb' @@ -1514,34 +1383,17 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups/settings/domain_verification_controller_spec.rb' - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' - - 'ee/spec/requests/projects/analytics/cycle_analytics/stages_controller_spec.rb' - - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' - - 'ee/spec/requests/projects/security/dast_configuration_controller_spec.rb' - - 'ee/spec/requests/projects/security/dast_profiles_controller_spec.rb' - 'ee/spec/requests/registrations/project_creation_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scan_configs/build_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' - 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/boards/lists/update_service_spec.rb' - - 'ee/spec/services/ci/process_pipeline_service_spec.rb' - - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' - - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' - - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' @@ -1556,7 +1408,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/geo/blob_upload_service_spec.rb' - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' @@ -1570,7 +1421,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/groups/restore_service_spec.rb' - 'ee/spec/services/issue_feature_flags/list_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/protected_environments/create_service_spec.rb' - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' @@ -1601,15 +1451,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/vulnerabilities/user_notes_count_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' - - 'ee/spec/support/shared_examples/audit/audit_event_type_stream_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/dast/dast_profile_schedule_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/api/access_requests.rb' - 'lib/api/admin/plan_limits.rb' @@ -1732,15 +1573,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' - 'lib/gitlab/alert_management/payload/prometheus.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects.rb' - - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects.rb' - - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'lib/gitlab/background_migration/reset_status_on_container_repositories.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/chat/command.rb' - 'lib/gitlab/ci/ansi2json/line.rb' @@ -1831,12 +1663,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - 'lib/gitlab/metrics/requests_rack_middleware.rb' - 'lib/gitlab/other_markup.rb' - - 'lib/gitlab/phabricator_import/cache/map.rb' - - 'lib/gitlab/phabricator_import/conduit/maniphest.rb' - - 'lib/gitlab/phabricator_import/conduit/response.rb' - - 'lib/gitlab/phabricator_import/conduit/user.rb' - - 'lib/gitlab/phabricator_import/issues/importer.rb' - - 'lib/gitlab/phabricator_import/user_finder.rb' - 'lib/gitlab/project_authorizations.rb' - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/request_context.rb' @@ -1846,7 +1672,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_config/worker.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/spamcheck/client.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - 'lib/gitlab/usage_data.rb' @@ -1894,14 +1719,8 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/tag_revision_trigger_prereceive_hook_spec.rb' - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/group_member_access_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_group_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/parent_group_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb' @@ -1961,7 +1780,6 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/ee/browser_ui/15_growth/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' @@ -1981,12 +1799,6 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/factories/ci/processable.rb' - - 'spec/factories/draft_note.rb' - - 'spec/factories/environments.rb' - - 'spec/factories/group_members.rb' - - 'spec/factories/ml/candidates.rb' - - 'spec/factories/notes.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb' - 'spec/features/atom/issues_spec.rb' @@ -2093,7 +1905,6 @@ Layout/ArgumentAlignment: - 'spec/features/snippets/spam_snippets_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/user_sees_revert_modal_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' @@ -2159,21 +1970,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_environment_tiers_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_releases_author_id_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' @@ -2188,26 +1984,10 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_five_mb_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - - 'spec/lib/gitlab/background_migration/prune_stale_project_export_jobs_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' - 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb' @@ -2327,15 +2107,9 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/pagination_delegate_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - - 'spec/lib/gitlab/phabricator_import/cache/map_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/repository_cache/preloader_spec.rb' - 'spec/lib/gitlab/repository_cache_spec.rb' @@ -2370,29 +2144,6 @@ Layout/ArgumentAlignment: - 'spec/lib/security/weak_passwords_spec.rb' - 'spec/lib/sidebars/projects/menus/repository_menu_spec.rb' - 'spec/lib/uploaded_file_spec.rb' - - 'spec/mailers/emails/merge_requests_spec.rb' - - 'spec/mailers/emails/pipelines_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/models/analytics/cycle_analytics/stage_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/clusters/kubernetes_namespace_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/commit_spec.rb' - - 'spec/models/container_repository_spec.rb' - - 'spec/models/deployment_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/environment_status_spec.rb' - - 'spec/models/event_collection_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/generic_commit_status_spec.rb' - - 'spec/models/group_group_link_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/integrations/apple_app_store_spec.rb' - - 'spec/models/integrations/buildkite_spec.rb' - - 'spec/models/integrations/hangouts_chat_spec.rb' - 'spec/models/integrations/mattermost_slash_commands_spec.rb' - 'spec/models/integrations/microsoft_teams_spec.rb' - 'spec/models/issue_spec.rb' @@ -2414,15 +2165,6 @@ Layout/ArgumentAlignment: - 'spec/models/project_team_spec.rb' - 'spec/models/release_spec.rb' - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/resource_state_event_spec.rb' - - 'spec/models/snippet_spec.rb' - - 'spec/models/spam_log_spec.rb' - - 'spec/models/u2f_registration_spec.rb' - - 'spec/models/upload_spec.rb' - - 'spec/models/user_detail_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/wiki_page/meta_spec.rb' - 'spec/requests/admin/applications_controller_spec.rb' - 'spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' @@ -2461,10 +2203,6 @@ Layout/ArgumentAlignment: - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' - 'spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb' - 'spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_cancel_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_play_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_retry_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_unschedule_spec.rb' - 'spec/requests/api/graphql/mutations/ci/pipeline_retry_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' @@ -2556,12 +2294,6 @@ Layout/ArgumentAlignment: - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - - 'spec/requests/projects/environments_controller_spec.rb' - - 'spec/requests/projects/incident_management/timeline_events_spec.rb' - - 'spec/requests/projects/issue_links_controller_spec.rb' - - 'spec/requests/projects/issues_controller_spec.rb' - - 'spec/requests/projects/merge_requests_controller_spec.rb' - - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/requests/recursive_webhook_detection_spec.rb' - 'spec/requests/users/group_callouts_spec.rb' @@ -2582,24 +2314,6 @@ Layout/ArgumentAlignment: - 'spec/services/award_emojis/destroy_service_spec.rb' - 'spec/services/bulk_imports/create_service_spec.rb' - 'spec/services/bulk_imports/get_importable_data_service_spec.rb' - - 'spec/services/ci/archive_trace_service_spec.rb' - - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/include_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' - - 'spec/services/ci/create_pipeline_service/partitioning_spec.rb' - - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/job_artifacts/track_artifact_report_service_spec.rb' - - 'spec/services/ci/list_config_variables_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - - 'spec/services/ci/play_manual_stage_service_spec.rb' - - 'spec/services/ci/process_sync_events_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/ci/run_scheduled_build_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/cohorts_service_spec.rb' @@ -2630,30 +2344,8 @@ Layout/ArgumentAlignment: - 'spec/services/issues/resolve_discussions_spec.rb' - 'spec/services/issues/update_service_spec.rb' - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - - 'spec/services/merge_requests/assign_issues_service_spec.rb' - - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/ff_merge_service_spec.rb' - - 'spec/services/merge_requests/merge_orchestration_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/mergeability/detailed_merge_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability_check_service_spec.rb' - - 'spec/services/merge_requests/rebase_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/update_assignees_service_spec.rb' - - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - 'spec/services/note_summary_spec.rb' - - 'spec/services/notes/build_service_spec.rb' - - 'spec/services/notes/copy_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' - - 'spec/services/notes/destroy_service_spec.rb' - - 'spec/services/notes/render_service_spec.rb' - 'spec/services/notification_service_spec.rb' - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' @@ -2682,48 +2374,10 @@ Layout/ArgumentAlignment: - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - - 'spec/support/shared_contexts/design_management_shared_contexts.rb' - - 'spec/support/shared_contexts/merge_request_create_shared_context.rb' - - 'spec/support/shared_contexts/merge_request_edit_shared_context.rb' - - 'spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb' - - 'spec/support/shared_contexts/requests/api/graphql/releases_and_group_releases_shared_context.rb' - - 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb' - - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb' - - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - - 'spec/support/shared_examples/graphql/members_shared_examples.rb' - - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' - - 'spec/support/shared_examples/graphql/mutations/set_assignees_shared_examples.rb' - - 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb' - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/gitaly_client_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/project_search_results_shared_examples.rb' - - 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb' - - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' - - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - - 'spec/support/shared_examples/observability/csp_shared_examples.rb' - - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - - 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb' - - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/mutations/snippets_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/projects/branch_protections/access_level_request_examples.rb' - - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/time_tracking_shared_examples.rb' - - 'spec/support/shared_examples/requests/graphql_shared_examples.rb' - - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - - 'spec/support/shared_examples/views/pipeline_status_changes_email.rb' - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 51e48bafa4..893a9338c5 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -4,7 +4,6 @@ Layout/ArrayAlignment: Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/plan_limits_controller.rb' - 'app/controllers/concerns/observability/content_security_policy.rb' - 'app/controllers/profiles_controller.rb' @@ -101,7 +100,6 @@ Layout/ArrayAlignment: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -184,7 +182,6 @@ Layout/ArrayAlignment: - 'lib/gitlab/metrics/samplers/threads_sampler.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/project_authorizations.rb' - - 'lib/gitlab/rack_attack/instrumented_cache_store.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' @@ -351,7 +348,6 @@ Layout/ArrayAlignment: - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/login_helpers.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/models/label_note_shared_examples.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 0f6447df6a..93302cebaa 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -40,7 +40,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/helpers/ci/secure_files_helper.rb' - 'app/helpers/projects/google_cloud/cloudsql_helper.rb' - 'app/helpers/projects/ml/experiments_helper.rb' - - 'app/models/airflow.rb' - 'app/models/ci/job_token/allowlist.rb' - 'app/models/commit_signatures/gpg_signature.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -133,7 +132,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/workers/concerns/limited_capacity/job_tracker.rb' - 'app/workers/database/batched_background_migration/ci_database_worker.rb' - 'app/workers/gitlab/import/stuck_project_import_jobs_worker.rb' - - 'app/workers/gitlab/phabricator_import/import_tasks_worker.rb' - 'config/application.rb' - 'config/initializers/fog_core_patch.rb' - 'config/initializers/rubyzip.rb' @@ -144,11 +142,6 @@ Layout/EmptyLineAfterMagicComment: - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - - 'db/migrate/20210929121516_add_releases_author_id_id_created_at_index.rb' - - 'db/migrate/20211019153615_add_state_to_merge_request_assignees.rb' - - 'db/migrate/20211126113029_add_text_limit_for_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - 'db/migrate/20220506154054_create_sync_namespace_details_trigger.rb' - 'db/migrate/20220524184149_create_sync_project_namespace_details_trigger.rb' - 'db/migrate/20220617141347_create_ci_secure_file_states.rb' @@ -162,8 +155,6 @@ Layout/EmptyLineAfterMagicComment: - 'db/migrate/20221219103007_add_name_to_ml_candidates.rb' - 'db/migrate/20221219122320_copy_clickhouse_connection_string_to_encrypted_var.rb' - 'db/migrate/20230111124512_remove_tmp_index_vulns_on_report_type.rb' - - 'db/post_migrate/20211209203820_add_tmp_index_on_report_type.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - 'db/post_migrate/20220412143551_add_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220413011328_remove_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb' @@ -215,7 +206,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/models/dependencies/dependency_list_export.rb' - 'ee/app/models/ee/issue_assignee.rb' - 'ee/app/models/geo/ci_secure_file_state.rb' - - 'ee/app/models/namespaces/storage/cli_notification.rb' - 'ee/app/models/namespaces/storage/limit_exclusion.rb' - 'ee/app/models/project_security_setting.rb' - 'ee/app/models/protected_environment.rb' @@ -337,7 +327,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' @@ -435,7 +424,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/services/wikis/create_attachment_service_spec.rb' - 'ee/spec/support/helpers/board_helpers.rb' - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' - - 'ee/spec/workers/integrations/slack_event_worker_spec.rb' - 'ee/spec/workers/namespaces/free_user_cap/backfill_notification_jobs_worker_spec.rb' - 'lib/api/commits.rb' - 'lib/api/concerns/packages/nuget_endpoints.rb' @@ -452,11 +440,7 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_project_import_level.rb' - 'lib/gitlab/background_migration/backfill_project_namespace_details.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/ci/secure_files/mobile_provision.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' - 'lib/gitlab/database/migrations/background_migration_helpers.rb' @@ -475,25 +459,12 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/import_export/recursive_merge_folders.rb' - 'lib/gitlab/import_export/shared.rb' - 'lib/gitlab/json_logger.rb' - - 'lib/gitlab/kubernetes/helm/v2/certificate.rb' - 'lib/gitlab/lfs/client.rb' - 'lib/gitlab/merge_requests/mergeability/check_result.rb' - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' - 'lib/gitlab/merge_requests/mergeability/results_store.rb' - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - - 'lib/gitlab/phabricator_import/cache/map.rb' - - 'lib/gitlab/phabricator_import/conduit.rb' - - 'lib/gitlab/phabricator_import/conduit/client.rb' - - 'lib/gitlab/phabricator_import/conduit/maniphest.rb' - - 'lib/gitlab/phabricator_import/conduit/pagination.rb' - - 'lib/gitlab/phabricator_import/conduit/response.rb' - - 'lib/gitlab/phabricator_import/conduit/tasks_response.rb' - - 'lib/gitlab/phabricator_import/conduit/user.rb' - - 'lib/gitlab/phabricator_import/issues/importer.rb' - - 'lib/gitlab/phabricator_import/issues/task_importer.rb' - - 'lib/gitlab/phabricator_import/representation/task.rb' - - 'lib/gitlab/phabricator_import/worker_state.rb' - 'lib/gitlab/relative_positioning/gap.rb' - 'lib/gitlab/safe_device_detector.rb' - 'lib/gitlab/spamcheck/client.rb' @@ -550,7 +521,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/factories/airflow/dags.rb' - 'spec/factories/alert_management/alerts.rb' - 'spec/factories/draft_note.rb' - 'spec/factories/ml/candidates.rb' @@ -586,18 +556,13 @@ Layout/EmptyLineAfterMagicComment: - 'spec/graphql/types/label_type_spec.rb' - 'spec/graphql/types/users/email_type_spec.rb' - 'spec/graphql/types/users/namespace_commit_email_type_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/keyset_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - 'spec/lib/constraints/admin_constrainer_spec.rb' - 'spec/lib/gitlab/analytics/date_filler_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/class_attributes_spec.rb' - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' @@ -611,7 +576,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - - 'spec/lib/gitlab/database/schema_validation/index_spec.rb' - 'spec/lib/gitlab/file_markdown_link_builder_spec.rb' - 'spec/lib/gitlab/file_type_detection_spec.rb' - 'spec/lib/gitlab/git/patches/collection_spec.rb' @@ -631,7 +595,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/jwt_token_spec.rb' - 'spec/lib/gitlab/kroki_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' @@ -640,15 +603,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/client_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/users_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/project_creator_spec.rb' - 'spec/lib/gitlab/request_endpoints_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_new_spec.rb' - 'spec/lib/gitlab/ssh/commit_spec.rb' @@ -658,17 +612,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/x509/commit_spec.rb' - 'spec/lib/gitlab/x509/tag_spec.rb' - 'spec/lib/security/report_schema_version_matcher_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/20220322132242_update_pages_onboarding_state_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' @@ -845,7 +788,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/features/access_token_helpers.rb' - 'spec/support/helpers/features/iteration_helpers.rb' - - 'spec/support/helpers/features/list_rows_helpers.rb' - 'spec/support/helpers/features/responsive_table_helpers.rb' - 'spec/support/helpers/features/two_factor_helpers.rb' - 'spec/support/helpers/lfs_http_helpers.rb' @@ -877,12 +819,10 @@ Layout/EmptyLineAfterMagicComment: - 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/import_tasks_worker_spec.rb' - 'spec/workers/integrations/execute_worker_spec.rb' - 'spec/workers/partition_creation_worker_spec.rb' - 'spec/workers/projects/delete_branch_worker_spec.rb' - 'spec/workers/web_hook_worker_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/suggestor.rb' - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index e06a9a9d82..f55a4e6b0d 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -3,7 +3,6 @@ Layout/FirstArrayElementIndentation: Details: grace period Exclude: - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/plan_limits_controller.rb' - 'app/finders/user_groups_counter.rb' - 'app/helpers/search_helper.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index fed5e18589..4537d0a499 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -23,7 +23,6 @@ Layout/FirstHashElementIndentation: - 'app/helpers/tags_helper.rb' - 'app/models/application_setting.rb' - 'app/models/ci/build_metadata.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/taskable.rb' @@ -199,8 +198,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/container_registry/client_spec.rb' - 'spec/lib/gitlab/application_rate_limiter_spec.rb' - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' @@ -220,7 +217,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/mattermost/team_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml index ca9a5a0b6f..f2c9feec08 100644 --- a/.rubocop_todo/layout/line_continuation_leading_space.yml +++ b/.rubocop_todo/layout/line_continuation_leading_space.yml @@ -20,7 +20,6 @@ Layout/LineContinuationLeadingSpace: - 'ee/app/services/system_notes/epics_service.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - 'ee/lib/ee/gitlab/git_access.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 0c256bce42..bbb9e83ce4 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -16,7 +16,6 @@ Layout/LineContinuationSpacing: - 'app/models/environment.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/teamcity.rb' - - 'app/models/members/member_role.rb' - 'app/models/work_items/parent_link.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/issues/build_service.rb' @@ -151,7 +150,6 @@ Layout/LineContinuationSpacing: - 'spec/features/projects/files/user_edits_files_spec.rb' - 'spec/features/projects/files/user_replaces_files_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' @@ -181,7 +179,6 @@ Layout/LineContinuationSpacing: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/project_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 06baecba0f..d1b6eddb46 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -26,7 +26,6 @@ Layout/LineEndStringConcatenationIndentation: - 'app/models/concerns/spammable.rb' - 'app/models/environment.rb' - 'app/models/integrations/pivotaltracker.rb' - - 'app/models/members/member_role.rb' - 'app/models/merge_request_diff_commit.rb' - 'app/models/postgresql/replication_slot.rb' - 'app/presenters/packages/npm/package_presenter.rb' @@ -82,7 +81,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/lib/ee/gitlab/git_access.rb' - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/groups/group_members_controller_spec.rb' @@ -295,7 +293,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' @@ -307,7 +304,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/users_spec.rb' - - 'spec/requests/self_monitoring_project_spec.rb' - 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb' - 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' @@ -331,7 +327,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb' - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb' - 'spec/views/projects/pages/show.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index ad0272376a..339edfce78 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -214,7 +214,6 @@ Layout/LineLength: - 'app/graphql/types/root_storage_statistics_type.rb' - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - 'app/graphql/types/todo_action_enum.rb' - - 'app/helpers/analytics/cycle_analytics_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/application_settings_helper.rb' - 'app/helpers/award_emoji_helper.rb' @@ -301,8 +300,6 @@ Layout/LineLength: - 'app/models/ci/runner.rb' - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - - 'app/models/clusters/applications/knative.rb' - - 'app/models/clusters/applications/prometheus.rb' - 'app/models/clusters/cluster.rb' - 'app/models/commit_range.rb' - 'app/models/commit_status.rb' @@ -444,7 +441,6 @@ Layout/LineLength: - 'app/models/releases/link.rb' - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - - 'app/models/serverless/domain.rb' - 'app/models/service_desk_setting.rb' - 'app/models/suggestion.rb' - 'app/models/todo.rb' @@ -747,149 +743,8 @@ Layout/LineLength: - 'danger/roulette/Dangerfile' - 'danger/vue_shared_documentation/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210830085837_add_throttle_authenticated_git_lfs_columns.rb' - - 'db/migrate/20210831203408_upsert_base_work_item_types.rb' - - 'db/migrate/20210908140437_add_sidekiq_limits_to_application_settings.rb' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - - 'db/migrate/20210910015047_add_app_settings_dep_proxy_ttl_worker_capacity_check_constraint.rb' - - 'db/migrate/20210913224558_update_dependency_proxy_manifests_uniqueness_constraint.rb' - - 'db/migrate/20210914145810_add_throttle_deprecated_api_columns.rb' - - 'db/migrate/20210917153905_remove_pipeline_fk_from_packages_package_file_build_infos.rb' - - 'db/migrate/20210921063924_index_labels_using_varchar_pattern_ops.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/migrate/20210929031049_add_unique_index_phone_on_user_details.rb' - - 'db/migrate/20210929115340_add_security_policy_configurations_management_project_id_foreign_key.rb' - - 'db/migrate/20210930081208_fix_deprecated_api_throttle_defaults.rb' - - 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb' - - 'db/migrate/20211006103122_change_helm_channel_length.rb' - - 'db/migrate/20211011004242_create_content_blocked_states.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - - 'db/migrate/20211013192749_add_states_into_approval_project_rules.rb' - - 'db/migrate/20211028132247_create_packages_npm_metadata.rb' - - 'db/migrate/20211101165656_create_upload_states.rb' - - 'db/migrate/20211110015252_add_agent_activity_events_foreign_keys.rb' - - 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb' - - 'db/migrate/20211116093739_add_foreign_key_to_incident_management_timeline_events_on_updated_by_user.rb' - - 'db/migrate/20211117174209_create_vulnerability_reads.rb' - - 'db/migrate/20211119111006_create_job_artifact_states.rb' - - 'db/migrate/20211119154221_create_pages_deployment_states.rb' - - 'db/migrate/20211126042235_add_sequence_column_to_sprints_table.rb' - - 'db/migrate/20211126115449_encrypt_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20211130151724_add_foreign_key_to_incident_management_timeline_events_on_note.rb' - - 'db/migrate/20211130205719_add_uniqueness_for_evidence_occurrence_id.rb' - - 'db/migrate/20211201143042_create_lfs_object_states.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20211207154413_add_ci_runners_index_on_created_at_where_active_is_false.rb' - - 'db/migrate/20211207154414_add_ci_runners_index_on_contacted_at_where_active_is_false.rb' - - 'db/migrate/20211216135651_add_index_to_cluster_agent_id.rb' - - 'db/migrate/20211217050753_remove_artifacts_archive_id_foreign_key_from_project_pages_metadata.rb' - - 'db/migrate/20220106230629_add_registry_migration_application_settings.rb' - - 'db/migrate/20220107091629_add_route_namespace_index.rb' - - 'db/migrate/20220111154951_add_index_to_ci_runners_token_expires_at.rb' - - 'db/migrate/20220112232605_add_member_namespace_index.rb' - - 'db/migrate/20220113125401_create_security_trainings.rb' - - 'db/migrate/20220118155846_add_runner_token_expiration_interval_settings_to_application_settings.rb' - - 'db/migrate/20220118155847_add_runner_token_expiration_interval_settings_to_namespace_settings.rb' - - 'db/migrate/20220119094023_add_unique_index_to_aed_verification_token.rb' - - 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb' - - 'db/migrate/20220120211831_temp_index_for_group_namespace_member_backfill.rb' - - 'db/migrate/20220125122725_add_topics_non_private_projects_count_index.rb' - - 'db/migrate/20220202115350_add_migration_indexes_to_container_repositories.rb' - - 'db/migrate/20220203091304_fix_unique_packages_index_excluding_pending_destruction_status.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220207083129_add_users_get_by_id_limit_to_application_setting.rb' - - 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/migrate/20220216110023_create_saved_replies.rb' - - 'db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb' - - 'db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb' - - 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb' - - 'db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb' - - 'db/migrate/20220304062107_remove_unique_index_for_sprints_on_project_id_and_title.rb' - - 'db/migrate/20220310101118_update_holder_name_limit.rb' - 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb' - 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb' - - 'db/post_migrate/20210901184511_prepare_async_indexes_for_ci_builds.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - - 'db/post_migrate/20210923135909_remove_delayed_project_removal_from_namespaces.rb' - - 'db/post_migrate/20210927153807_update_issues_relative_position_indexes.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211012155931_remove_schedule_and_status_from_pending_alert_escalations.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211031152417_add_indexes_to_issue_stage_events.rb' - - 'db/post_migrate/20211031154919_add_indexes_to_merge_request_stage_events.rb' - - 'db/post_migrate/20211104165220_remove_vulnerability_finding_links.rb' - - 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb' - - 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211201101541_drop_clusters_applications_runners_ci_runners_fk.rb' - - 'db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb' - - 'db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb' - - 'db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb' - - 'db/post_migrate/20211210140000_add_temporary_static_object_token_index.rb' - - 'db/post_migrate/20211210173137_remove_vulnerability_finding_links_again.rb' - - 'db/post_migrate/20211213102111_drop_ci_pipelines_mr_metrics_fk.rb' - - 'db/post_migrate/20211220120402_add_index_on_ci_pipelines_user_id_id_failure_reason.rb' - - 'db/post_migrate/20220104060049_remove_foreign_key_ci_group_variables_group_id.rb' - - 'db/post_migrate/20220105020514_remove_ci_minutes_additional_packs_namespace_id_foreign_key_constraint.rb' - - 'db/post_migrate/20220106231518_remove_foreign_key_ci_daily_build_group_report_results_group_id.rb' - - 'db/post_migrate/20220106233459_remove_foreign_key_ci_pending_builds_namespace_id.rb' - - 'db/post_migrate/20220106235626_remove_foreign_key_ci_runner_namespaces_namespace_id.rb' - - 'db/post_migrate/20220110224913_remove_dast_scanner_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220110231420_remove_requirements_management_test_reports_build_id_fk.rb' - - 'db/post_migrate/20220110233155_remove_dast_site_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220111002756_remove_security_scans_build_id_fk.rb' - - 'db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb' - - 'db/post_migrate/20220112015940_remove_projects_ci_running_builds_fk.rb' - - 'db/post_migrate/20220112230642_remove_projects_ci_unit_tests_project_id_fk.rb' - - 'db/post_migrate/20220112232723_remove_projects_ci_daily_build_group_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113013319_remove_projects_ci_freeze_periods_project_id_fk.rb' - - 'db/post_migrate/20220113014438_remove_projects_ci_resource_groups_project_id_fk.rb' - - 'db/post_migrate/20220113015830_remove_projects_ci_build_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb' - - 'db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220119141736_remove_projects_ci_pipeline_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220119143130_remove_projects_ci_sources_pipelines_source_project_id_fk.rb' - - 'db/post_migrate/20220119144458_remove_users_ci_triggers_owner_id_fk.rb' - - 'db/post_migrate/20220119151221_remove_merge_requests_ci_pipelines_merge_request_id_fk.rb' - - 'db/post_migrate/20220119153706_remove_ci_pipelines_merge_trains_pipeline_id_fk.rb' - - 'db/post_migrate/20220119154442_remove_ci_pipelines_merge_requests_head_pipeline_id_fk.rb' - - 'db/post_migrate/20220119193130_remove_ci_pipelines_dast_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220119201340_remove_ci_pipelines_vulnerability_statistics_latest_pipeline_id_fk.rb' - - 'db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb' - - 'db/post_migrate/20220120123700_add_tmp_index_routes_id_for_namespaces.rb' - - 'db/post_migrate/20220121214752_remove_projects_ci_stages_project_id_fk.rb' - - 'db/post_migrate/20220121221651_remove_projects_ci_variables_project_id_fk.rb' - - 'db/post_migrate/20220124130028_dedup_runner_projects.rb' - - 'db/post_migrate/20220124145019_remove_projects_external_pull_requests_project_id_fk.rb' - - 'db/post_migrate/20220124151456_remove_projects_ci_triggers_project_id_fk.rb' - - 'db/post_migrate/20220124151949_remove_projects_ci_runner_projects_project_id_fk.rb' - - 'db/post_migrate/20220124152824_remove_projects_ci_subscriptions_projects_downstream_project_id_fk.rb' - - 'db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb' - - 'db/post_migrate/20220124184338_remove_projects_ci_subscriptions_projects_upstream_project_id_fk.rb' - - 'db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220124214131_remove_projects_ci_refs_project_id_fk.rb' - - 'db/post_migrate/20220124215857_remove_projects_ci_job_token_project_scope_links_source_project_id_fk.rb' - - 'db/post_migrate/20220124221521_remove_projects_ci_project_monthly_usages_project_id_fk.rb' - - 'db/post_migrate/20220125083520_remove_ci_pipelines_dast_site_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220125084348_remove_ci_pipelines_vulnerability_feedback_pipeline_id_fk.rb' - - 'db/post_migrate/20220126201752_remove_projects_ci_job_token_project_scope_links_target_project_id_fk.rb' - - 'db/post_migrate/20220126202654_remove_projects_ci_sources_projects_source_project_id_fk.rb' - - 'db/post_migrate/20220126203421_remove_projects_ci_pipeline_schedules_project_id_fk.rb' - - 'db/post_migrate/20220126210021_remove_projects_ci_builds_project_id_fk.rb' - - 'db/post_migrate/20220126210657_remove_projects_ci_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000000_index_job_artifacts_on_trace_type_and_expire_at.rb' - - 'db/post_migrate/20220201193033_add_unique_index_to_vulnerability_finding_links_with_truncate.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220224000000_async_build_trace_expire_at_index.rb' - - 'db/post_migrate/20220305223212_add_security_training_providers.rb' - - 'db/post_migrate/20220307192610_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb' - 'db/post_migrate/20220316102902_add_user_foreign_key_to_deploy_tokens.rb' - 'db/post_migrate/20220317161914_remove_ci_runners_ci_builds_runner_id_fk.rb' @@ -1026,7 +881,6 @@ Layout/LineLength: - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' @@ -1327,7 +1181,6 @@ Layout/LineLength: - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/config/routes/group.rb' - 'ee/config/routes/project.rb' - 'ee/db/fixtures/development/20_burndown.rb' @@ -1412,14 +1265,9 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' @@ -1614,7 +1462,6 @@ Layout/LineLength: - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - - 'ee/spec/features/invites_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' - 'ee/spec/features/issues/form_spec.rb' - 'ee/spec/features/labels_hierarchy_spec.rb' @@ -1840,16 +1687,10 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -1910,8 +1751,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/auth/ldap/user_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -2010,14 +1849,9 @@ Layout/LineLength: - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/migrate_lfs_objects_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/set_resync_flag_for_retried_projects_spec.rb' - - 'ee/spec/migrations/schedule_populate_test_reports_issue_id_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' @@ -2368,7 +2202,6 @@ Layout/LineLength: - 'ee/spec/services/ci/compare_security_reports_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/minutes/refresh_cached_data_service_spec.rb' - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb' - 'ee/spec/services/ci/process_build_service_spec.rb' @@ -2416,7 +2249,6 @@ Layout/LineLength: - 'ee/spec/services/epic_issues/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/epics/update_dates_service_spec.rb' - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/external_status_checks/update_service_spec.rb' @@ -2464,7 +2296,6 @@ Layout/LineLength: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' @@ -2788,7 +2619,6 @@ Layout/LineLength: - 'lib/banzai/filter/markdown_post_escape_filter.rb' - 'lib/banzai/filter/references/external_issue_reference_filter.rb' - 'lib/banzai/filter/references/issue_reference_filter.rb' - - 'lib/banzai/filter/references/iteration_reference_filter.rb' - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/filter/references/reference_filter.rb' - 'lib/banzai/filter/references/vulnerability_reference_filter.rb' @@ -2842,27 +2672,17 @@ Layout/LineLength: - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/buffered_io.rb' @@ -2956,7 +2776,6 @@ Layout/LineLength: - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/database/with_lock_retries_outside_transaction.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/dependency_linker/base_linker.rb' - 'lib/gitlab/dependency_linker/go_mod_linker.rb' - 'lib/gitlab/dependency_linker/go_sum_linker.rb' @@ -3012,8 +2831,6 @@ Layout/LineLength: - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/parallel_scheduling.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/gl_repository.rb' - 'lib/gitlab/global_id/deprecations.rb' - 'lib/gitlab/golang.rb' @@ -3035,7 +2852,6 @@ Layout/LineLength: - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' - 'lib/gitlab/import_export/lfs_saver.rb' - 'lib/gitlab/import_export/members_mapper.rb' @@ -3051,7 +2867,6 @@ Layout/LineLength: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/jira_import/issues_importer.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/kubernetes/pod_cmd.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' @@ -3112,7 +2927,6 @@ Layout/LineLength: - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' @@ -3141,7 +2955,6 @@ Layout/LineLength: - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/usage_data_counters/issue_activity_unique_counter.rb' - 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/track_unique_events.rb' - 'lib/gitlab/utils/delegator_override/error.rb' - 'lib/gitlab/utils/markdown.rb' - 'lib/gitlab/utils/override.rb' @@ -3229,7 +3042,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb' @@ -3247,9 +3059,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' @@ -3292,11 +3101,9 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/snippet/share_snippet_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/create_first_file_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/link_to_line_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' @@ -3330,8 +3137,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' @@ -3581,7 +3386,6 @@ Layout/LineLength: - 'spec/features/groups/settings/repository_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - - 'spec/features/invites_spec.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' - 'spec/features/issuables/markdown_references/jira_spec.rb' @@ -3747,7 +3551,6 @@ Layout/LineLength: - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/deployments_finder_spec.rb' @@ -3782,7 +3585,6 @@ Layout/LineLength: - 'spec/finders/projects_finder_spec.rb' - 'spec/finders/repositories/tree_finder_spec.rb' - 'spec/finders/security/security_jobs_finder_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/finders/snippets_finder_spec.rb' - 'spec/finders/tags_finder_spec.rb' - 'spec/finders/todos_finder_spec.rb' @@ -3886,7 +3688,6 @@ Layout/LineLength: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/clusters_helper_spec.rb' @@ -4064,33 +3865,17 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/buffered_io_spec.rb' @@ -4213,7 +3998,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/transaction/observer_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/dependency_linker/package_json_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/requirements_txt_linker_spec.rb' @@ -4334,8 +4118,6 @@ Layout/LineLength: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' @@ -4385,12 +4167,8 @@ Layout/LineLength: - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar/redis_adapter_when_peek_enabled_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' @@ -4409,9 +4187,7 @@ Layout/LineLength: - 'spec/lib/gitlab/search/found_blob_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' @@ -4453,7 +4229,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' @@ -4501,38 +4276,10 @@ Layout/LineLength: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - - 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - - 'spec/migrations/backfill_all_project_namespaces_spec.rb' - - 'spec/migrations/backfill_project_namespaces_for_group_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - - 'spec/migrations/update_invalid_member_states_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/acts_as_taggable_on/tag_spec.rb' - 'spec/models/acts_as_taggable_on/tagging_spec.rb' @@ -4545,7 +4292,6 @@ Layout/LineLength: - 'spec/models/award_emoji_spec.rb' - 'spec/models/blob_viewer/go_mod_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' @@ -4563,9 +4309,6 @@ Layout/LineLength: - 'spec/models/ci/runner_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' @@ -4702,7 +4445,6 @@ Layout/LineLength: - 'spec/models/resource_state_event_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/models/service_desk_setting_spec.rb' - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' @@ -5105,7 +4847,6 @@ Layout/LineLength: - 'spec/services/lfs/push_service_spec.rb' - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' - - 'spec/services/members/approve_access_request_service_spec.rb' - 'spec/services/members/create_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/members/invitation_reminder_email_service_spec.rb' @@ -5255,11 +4996,10 @@ Layout/LineLength: - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/db_cleaner.rb' - - 'spec/support/flaky_tests.rb' + - 'spec/support/fast_quarantine.rb' - 'spec/support/helpers/api_helpers.rb' - 'spec/support/helpers/board_helpers.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' @@ -5474,7 +5214,7 @@ Layout/LineLength: - 'spec/tasks/migrate/schema_check_rake_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/product_intelligence_spec.rb' + - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' @@ -5589,7 +5329,7 @@ Layout/LineLength: - 'spec/workers/todos_destroyer/confidential_issue_worker_spec.rb' - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' - 'spec/workers/users/deactivate_dormant_users_worker_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/project_helper.rb' - 'tooling/danger/specs.rb' - 'tooling/graphql/docs/helper.rb' diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml index 4fafbab602..56a96fb82c 100644 --- a/.rubocop_todo/layout/parameter_alignment.yml +++ b/.rubocop_todo/layout/parameter_alignment.yml @@ -3,15 +3,9 @@ Layout/ParameterAlignment: Details: grace period Exclude: - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'lib/gitlab/cross_project_access.rb' - 'lib/gitlab/data_builder/push.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/support/helpers/content_security_policy_helpers.rb' - 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb' - 'spec/support/helpers/repo_helpers.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 144b4eb04a..62aa752c37 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -20,7 +20,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/clusters/agent.rb' - 'app/models/clusters/agent_token.rb' - 'app/models/clusters/agents/activity_event.rb' - - 'app/models/clusters/applications/knative.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/kubernetes_namespace.rb' - 'app/models/commit_status.rb' @@ -36,7 +35,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/milestoneable.rb' - - 'app/models/concerns/protected_ref_access.rb' - 'app/models/concerns/reactive_caching.rb' - 'app/models/concerns/shardable.rb' - 'app/models/concerns/timebox.rb' @@ -119,7 +117,6 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/ci/job_entity.rb' - 'app/serializers/ci/pipeline_entity.rb' - 'app/serializers/ci/trigger_entity.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/concerns/user_status_tooltip.rb' - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' @@ -233,7 +230,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/security/scan.rb' - 'ee/app/models/security/training.rb' - 'ee/app/models/security/training_provider.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/software_license.rb' - 'ee/app/models/software_license_policy.rb' - 'ee/app/models/vulnerabilities/external_issue_link.rb' @@ -278,7 +274,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/seat_usage_export_service.rb' - 'ee/app/services/historical_user_data/csv_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/user_permissions/export_service.rb' - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' @@ -352,7 +347,6 @@ Layout/SpaceInLambdaLiteral: - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/cache/helpers.rb' - 'lib/gitlab/ci/config/entry/inherit/default.rb' - 'lib/gitlab/ci/config/entry/inherit/variables.rb' @@ -397,7 +391,6 @@ Layout/SpaceInLambdaLiteral: - 'spec/lib/gitlab/sidekiq_signals_spec.rb' - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - 'spec/models/ability_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/concerns/participable_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 56b37ba768..b27fae0c6b 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -21,7 +21,6 @@ Layout/SpaceInsideParens: - 'ee/spec/lib/gitlab/search/index_curator_spec.rb' - 'ee/spec/lib/world_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' @@ -68,7 +67,6 @@ Layout/SpaceInsideParens: - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/epic_issues/update_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' @@ -98,7 +96,6 @@ Layout/SpaceInsideParens: - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/dev_ops_report_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' @@ -166,7 +163,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' - 'spec/lib/gitlab/redis/queues_spec.rb' - 'spec/lib/gitlab/redis/shared_state_spec.rb' @@ -184,7 +180,6 @@ Layout/SpaceInsideParens: - 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb' - 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb' - 'spec/mailers/emails/profile_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - 'spec/models/ci/pending_build_spec.rb' - 'spec/models/ci/running_build_spec.rb' - 'spec/models/ml/candidate_metric_spec.rb' @@ -226,7 +221,6 @@ Layout/SpaceInsideParens: - 'spec/views/dashboard/projects/_blank_state_welcome.html.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - 'spec/views/search/_results.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' - 'spec/workers/pipeline_schedule_worker_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml index 1395fa78e3..35db371a05 100644 --- a/.rubocop_todo/layout/trailing_whitespace.yml +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -6,7 +6,6 @@ Layout/TrailingWhitespace: - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb' - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index 8b6ef5db13..a890c6af6d 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -30,7 +30,6 @@ Lint/AmbiguousOperatorPrecedence: - 'app/services/issuable_links/create_service.rb' - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/jira/requests/base.rb' - - 'app/services/projects/blame_service.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' @@ -39,7 +38,6 @@ Lint/AmbiguousOperatorPrecedence: - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' - - 'ee/app/models/namespaces/storage/root_size.rb' - 'ee/app/policies/ee/issuable_policy.rb' - 'ee/app/services/boards/epics/position_create_service.rb' - 'ee/app/services/geo/registry_consistency_service.rb' @@ -82,7 +80,6 @@ Lint/AmbiguousOperatorPrecedence: - 'lib/gitlab/template_parser/parser.rb' - 'lib/gitlab/tree_summary.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - - 'lib/gitlab/utils/email.rb' - 'lib/omni_auth/strategies/bitbucket.rb' - 'qa/qa/ee/page/project/secure/pipeline_security.rb' - 'qa/qa/resource/api_fabricator.rb' @@ -142,7 +139,6 @@ Lint/AmbiguousOperatorPrecedence: - 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/web_hook_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/helpers/dependency_proxy_helpers.rb' - 'spec/support/models/ci/partitioning_testing/cascade_check.rb' - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index d0160d620d..6f2b8f03f8 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -62,8 +62,6 @@ Lint/AmbiguousRegexpLiteral: - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml index 89d1ff7e2a..6a171415cb 100644 --- a/.rubocop_todo/lint/duplicate_branch.yml +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -33,4 +33,3 @@ Lint/DuplicateBranch: - 'lib/sidebars/groups/menus/settings_menu.rb' - 'qa/qa/resource/pipeline.rb' - 'scripts/rubocop-parse' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml index 813a27455a..c0d46ba9e9 100644 --- a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml +++ b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml @@ -4,4 +4,3 @@ Lint/DuplicateRegexpCharacterClassElement: Details: grace period Exclude: - 'lib/gitlab/path_regex.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index 43289b4bfb..e111703ce3 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -108,7 +108,6 @@ Lint/EmptyBlock: - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' - 'spec/lib/gitlab/database/migrations/lock_retries_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' - - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' - 'spec/lib/gitlab/database/shared_model_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' @@ -137,10 +136,8 @@ Lint/EmptyBlock: - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/search_context/builder_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 8346468e4f..8cfecb87f2 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -67,7 +67,6 @@ Lint/MissingCopEnableDirective: - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' @@ -137,7 +136,6 @@ Lint/MissingCopEnableDirective: - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb' - 'ee/app/workers/groups/export_memberships_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' @@ -151,27 +149,16 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/data_builder/push.rb' @@ -195,6 +182,5 @@ Lint/MissingCopEnableDirective: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 1ae433adc0..6274aecec0 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -77,13 +77,9 @@ Lint/RedundantCopDisableDirective: - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220316022505_create_namespace_details.rb' - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' @@ -151,7 +147,6 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' - - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' @@ -188,12 +183,9 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/bitbucket_import/importer.rb' @@ -226,7 +218,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/git/patches/collection.rb' - 'lib/gitlab/github_import/markdown_text.rb' - 'lib/gitlab/github_import/user_finder.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/health_checks/metric.rb' - 'lib/gitlab/health_checks/probes/status.rb' @@ -274,7 +265,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' @@ -327,7 +317,7 @@ Lint/RedundantCopDisableDirective: - 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb' - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/stable_branch.rb' - 'tooling/danger/suggestor.rb' - 'tooling/lib/tooling/helm3_client.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index da56c28318..c7f8b9549f 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -15,17 +15,11 @@ Lint/SymbolConversion: - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' - 'ee/app/models/product_analytics/jitsu_authentication.rb' - 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb' - - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_closed_service.rb' - - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_submit_service.rb' - - 'ee/app/services/integrations/slack_interactions/slack_block_actions/incident_management/project_update_handler.rb' - - 'ee/app/services/integrations/slack_options/user_search_handler.rb' - 'ee/db/fixtures/development/35_merge_request_predictions.rb' - 'ee/lib/api/analytics/product_analytics.rb' - 'ee/lib/ee/gitlab/scim/attribute_transform.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/gitlab/applied_ml/suggested_reviewers/client.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - - 'ee/lib/slack/block_kit/incident_management/incident_modal_opened.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' @@ -36,7 +30,6 @@ Lint/SymbolConversion: - 'ee/spec/helpers/ee/environments_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/lib/arkose/logger_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/tracking_spec.rb' @@ -54,13 +47,9 @@ Lint/SymbolConversion: - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' - - 'ee/spec/requests/api/integrations/slack/interactions_spec.rb' - - 'ee/spec/requests/api/integrations/slack/options_spec.rb' - 'ee/spec/requests/api/scim/group_scim_spec.rb' - 'ee/spec/requests/api/scim/instance_scim_spec.rb' - 'ee/spec/services/elastic/data_migration_service_spec.rb' - - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_closed_service_spec.rb' - - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' @@ -126,7 +115,6 @@ Lint/SymbolConversion: - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/harbor/client_spec.rb' - 'spec/lib/gitlab/harbor/query_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' diff --git a/.rubocop_todo/lint/triple_quotes.yml b/.rubocop_todo/lint/triple_quotes.yml deleted file mode 100644 index 7695fa46b0..0000000000 --- a/.rubocop_todo/lint/triple_quotes.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -# Cop supports --autocorrect. -Lint/TripleQuotes: - Details: grace period - Exclude: - - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index c09dc939ef..7676faf027 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -33,12 +33,10 @@ Lint/UnusedBlockArgument: - 'app/models/clusters/cluster.rb' - 'app/models/concerns/atomic_internal_id.rb' - 'app/models/concerns/avatarable.rb' - - 'app/models/concerns/enum_with_nil.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/customer_relations/organization.rb' - 'app/models/integration.rb' - 'app/models/merge_request.rb' - - 'app/models/namespace/root_storage_statistics.rb' - 'app/models/project.rb' - 'app/models/projects/build_artifacts_size_refresh.rb' - 'app/models/service_desk_setting.rb' @@ -87,7 +85,6 @@ Lint/UnusedBlockArgument: - 'config/initializers/warden.rb' - 'config/routes/project.rb' - 'config/routes/wiki.rb' - - 'db/post_migrate/20211117084814_migrate_remaining_u2f_registrations.rb' - 'ee/app/finders/security/training_providers/kontra_url_finder.rb' - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - 'ee/app/graphql/resolvers/incident_management/escalation_policies_resolver.rb' @@ -135,14 +132,12 @@ Lint/UnusedBlockArgument: - 'ee/spec/factories/projects.rb' - 'ee/spec/factories/protected_branches.rb' - 'ee/spec/factories/protected_environments.rb' - - 'ee/spec/factories/slack_integrations.rb' - 'ee/spec/factories/users.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb' - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' - 'ee/spec/lib/compliance_management/compliance_report/commit_loader_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' @@ -334,7 +329,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/feature_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/logger_spec.rb' @@ -365,7 +359,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/gitlab/utils/usage_data_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/concerns/ci/partitionable/switch_spec.rb' @@ -391,7 +384,6 @@ Lint/UnusedBlockArgument: - 'spec/services/snippets/update_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 0d6f91336c..45f18e605b 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -105,7 +105,6 @@ Lint/UnusedMethodArgument: - 'app/models/ci/runner.rb' - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/concerns/ci/partitionable/partitioned_filter.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' @@ -283,7 +282,6 @@ Lint/UnusedMethodArgument: - 'ee/app/services/group_saml/identity/destroy_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' - 'ee/app/workers/automation/execute_rule_worker.rb' - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' @@ -326,7 +324,6 @@ Lint/UnusedMethodArgument: - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb' @@ -384,7 +381,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/auth/database/authentication.rb' - 'lib/gitlab/auth/ldap/access.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' @@ -599,8 +595,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/truncate_overlong_vulnerability_html_titles_spec.rb' @@ -611,9 +605,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - 'spec/models/concerns/from_set_operator_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' - 'spec/policies/resource_state_event_policy_spec.rb' diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml index 634ec6221f..414f4f6243 100644 --- a/.rubocop_todo/metrics/cyclomatic_complexity.yml +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -18,4 +18,3 @@ Metrics/CyclomaticComplexity: - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/metrics/perceived_complexity.yml b/.rubocop_todo/metrics/perceived_complexity.yml index 1eef5031e4..51ec88c158 100644 --- a/.rubocop_todo/metrics/perceived_complexity.yml +++ b/.rubocop_todo/metrics/perceived_complexity.yml @@ -17,4 +17,3 @@ Metrics/PerceivedComplexity: - 'qa/qa/support/repeater.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 6050a4d805..6e5d34726e 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -1,78 +1,45 @@ --- Migration/BackgroundMigrationBaseClass: Exclude: - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - - 'lib/gitlab/background_migration/backfill_user_namespace.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/delete_orphaned_deployments.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/background_migration/legacy_uploads_migrator.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - 'lib/gitlab/background_migration/migrate_pages_to_zip_storage.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb' - 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/remove_vulnerability_finding_links.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users.rb' - - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - - 'lib/gitlab/background_migration/update_timelogs_project_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml index ec2b9fb6d6..c803790525 100644 --- a/.rubocop_todo/migration/background_migration_record.yml +++ b/.rubocop_todo/migration/background_migration_record.yml @@ -3,46 +3,24 @@ Migration/BackgroundMigrationRecord: Exclude: - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml index ce2ad6da45..fee1a7a0a6 100644 --- a/.rubocop_todo/migration/background_migrations.yml +++ b/.rubocop_todo/migration/background_migrations.yml @@ -1,38 +1,6 @@ --- Migration/BackgroundMigrations: Exclude: - - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' - - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' - - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' - - 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb' - - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' - - 'db/post_migrate/20211005194425_schedule_requirements_migration.rb' - - 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb' - - 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb' - - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb' - - 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' - - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20211210140629_encrypt_static_object_token.rb' - - 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb' - - 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb' - - 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - - 'db/post_migrate/20220204194347_encrypt_integration_properties.rb' - - 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 7614480143..9b6d26a53c 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -8,7 +8,6 @@ Naming/HeredocDelimiterNaming: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/limited_capacity/job_tracker.rb' - 'config/initializers/01_secret_token.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb' - 'ee/db/geo/migrate/20191010204941_migrate_lfs_objects_to_separate_registry.rb' - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' @@ -83,14 +82,6 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/config_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index 5f2331d6ed..2ea13f71fa 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -69,7 +69,6 @@ Performance/MapCompact: - 'ee/lib/ee/api/entities/experiment.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/elastic/latest/repository_instance_proxy.rb' - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' - 'ee/lib/gitlab/ci/parsers/security/dast.rb' @@ -102,7 +101,6 @@ Performance/MapCompact: - 'lib/gitlab/ci/reports/security/finding.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/database/load_balancing/service_discovery.rb' - - 'lib/gitlab/database/obsolete_ignored_columns.rb' - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/conflict/file.rb' - 'lib/gitlab/git/rugged_impl/commit.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index a18dec335d..e536c22e51 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -78,7 +78,6 @@ Rails/FilePath: - 'spec/factories/file_uploaders.rb' - 'spec/factories/packages/debian/distribution_key.rb' - 'spec/factories/pages_domains.rb' - - 'spec/factories/serverless/domain_cluster.rb' - 'spec/features/admin/admin_appearance_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - 'spec/features/groups/import_export/import_file_spec.rb' @@ -101,7 +100,6 @@ Rails/FilePath: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/startupjs_helper_spec.rb' - 'spec/lib/backup/database_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb' - 'spec/lib/gitlab/database/schema_migrations/context_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index de45a47fed..59c0e14e18 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -6,7 +6,6 @@ Rails/InverseOf: - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/trigger_request.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' @@ -76,7 +75,6 @@ Rails/InverseOf: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_participant.rb' - 'ee/app/models/insight.rb' - - 'ee/app/models/integrations/gitlab_slack_application.rb' - 'ee/app/models/iteration.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/requirements_management/test_report.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 7eb7094749..4571e1ae19 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -28,7 +28,6 @@ Rails/Pluck: - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/gitlab/search/index_curator.rb' @@ -74,7 +73,6 @@ Rails/Pluck: - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/iterations_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/project_approval_rules_spec.rb' - 'ee/spec/requests/api/project_approval_settings_spec.rb' - 'ee/spec/requests/api/projects_spec.rb' @@ -150,14 +148,11 @@ Rails/Pluck: - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - 'spec/controllers/projects/starrers_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/features/issues/csv_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' @@ -182,7 +177,6 @@ Rails/Pluck: - 'spec/lib/gitlab/language_detection_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/search/query_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_matcher_spec.rb' @@ -278,15 +272,5 @@ Rails/Pluck: - 'spec/support/helpers/api_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/matchers/background_migrations_matchers.rb' - - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/support/shared_examples/services/packages_shared_examples.rb' - 'spec/tooling/docs/deprecation_handling_spec.rb' - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 9824c78a8f..fc0f1c97fb 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -14,7 +14,6 @@ Rails/RedundantForeignKey: - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/stage.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -59,7 +58,3 @@ Rails/RedundantForeignKey: - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/models/vulnerabilities/finding_signature.rb' - 'ee/app/models/vulnerabilities/identifier.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' diff --git a/.rubocop_todo/rails/render_inline.yml b/.rubocop_todo/rails/render_inline.yml deleted file mode 100644 index fbebec72cd..0000000000 --- a/.rubocop_todo/rails/render_inline.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Rails/RenderInline: - Exclude: - - 'ee/app/controllers/sitemap_controller.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 220a6f3955..00e8150585 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -44,7 +44,6 @@ Rails/TimeZone: - 'lib/gitlab/instrumentation_helper.rb' - 'lib/gitlab/lfs_token.rb' - 'lib/gitlab/loop_helpers.rb' - - 'lib/gitlab/phabricator_import/representation/task.rb' - 'lib/gitlab/popen.rb' - 'lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb' - 'lib/gitlab/prometheus/queries/matched_metric_query.rb' @@ -97,8 +96,6 @@ Rails/TimeZone: - 'spec/lib/gitlab/lfs_token_spec.rb' - 'spec/lib/gitlab/log_timestamp_formatter_spec.rb' - 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index b278eb355d..e8cc0e77ca 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -55,7 +55,6 @@ RSpec/AnyInstanceOf: - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/support/helpers/ee/stub_configuration.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' diff --git a/.rubocop_todo/rspec/avoid_conditional_statements.yml b/.rubocop_todo/rspec/avoid_conditional_statements.yml new file mode 100644 index 0000000000..43ffaaa452 --- /dev/null +++ b/.rubocop_todo/rspec/avoid_conditional_statements.yml @@ -0,0 +1,84 @@ +--- +RSpec/AvoidConditionalStatements: + Details: grace period + Exclude: + - 'ee/spec/features/admin/admin_settings_spec.rb' + - 'ee/spec/features/analytics/code_analytics_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/boards/scoped_issue_board_spec.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_spec.rb' + - 'ee/spec/features/epics/epic_show_spec.rb' + - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' + - 'ee/spec/features/group_protected_branches_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' + - 'ee/spec/features/groups/iterations/user_views_iteration_spec.rb' + - 'ee/spec/features/incidents/incident_details_spec.rb' + - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' + - 'ee/spec/features/labels_hierarchy_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' + - 'ee/spec/features/projects/analytics/visualization_designer_spec.rb' + - 'ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb' + - 'ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb' + - 'ee/spec/features/projects/settings/issues_settings_spec.rb' + - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/registrations/email_confirmation_spec.rb' + - 'ee/spec/features/registrations/identity_verification_spec.rb' + - 'ee/spec/features/search/elastic/snippet_search_spec.rb' + - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' + - 'ee/spec/features/users/identity_verification_spec.rb' + - 'spec/features/admin/dashboard_spec.rb' + - 'spec/features/calendar_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/groups/empty_states_spec.rb' + - 'spec/features/groups/group_settings_spec.rb' + - 'spec/features/groups/members/sort_members_spec.rb' + - 'spec/features/groups/navbar_spec.rb' + - 'spec/features/issuables/issuable_list_spec.rb' + - 'spec/features/issuables/markdown_references/jira_spec.rb' + - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' + - 'spec/features/issues/user_bulk_edits_issues_labels_spec.rb' + - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' + - 'spec/features/issues/user_edits_issue_spec.rb' + - 'spec/features/issues/user_interacts_with_awards_spec.rb' + - 'spec/features/labels_hierarchy_spec.rb' + - 'spec/features/markdown/keyboard_shortcuts_spec.rb' + - 'spec/features/merge_request/batch_comments_spec.rb' + - 'spec/features/merge_request/user_posts_diff_notes_spec.rb' + - 'spec/features/merge_request/user_reverts_merge_request_spec.rb' + - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' + - 'spec/features/merge_request/user_squashes_merge_request_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/features/monitor_sidebar_link_spec.rb' + - 'spec/features/oauth_login_spec.rb' + - 'spec/features/participants_autocomplete_spec.rb' + - 'spec/features/profiles/user_edit_profile_spec.rb' + - 'spec/features/projects/blobs/edit_spec.rb' + - 'spec/features/projects/branches_spec.rb' + - 'spec/features/projects/commit/cherry_pick_spec.rb' + - 'spec/features/projects/commit/user_reverts_commit_spec.rb' + - 'spec/features/projects/compare_spec.rb' + - 'spec/features/projects/deploy_keys_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/files/template_selector_menu_spec.rb' + - 'spec/features/projects/integrations/user_activates_issue_tracker_spec.rb' + - 'spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'spec/features/projects/labels/user_removes_labels_spec.rb' + - 'spec/features/projects/members/sorting_spec.rb' + - 'spec/features/projects/milestones/milestone_spec.rb' + - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/project_settings_spec.rb' + - 'spec/features/projects/settings/repository_settings_spec.rb' + - 'spec/features/projects/settings/user_transfers_a_project_spec.rb' + - 'spec/features/projects/show/user_sees_git_instructions_spec.rb' + - 'spec/features/projects/tree/create_directory_spec.rb' + - 'spec/features/projects/tree/create_file_spec.rb' + - 'spec/features/projects_spec.rb' + - 'spec/features/search/user_uses_header_search_field_spec.rb' + - 'spec/features/snippets/explore_spec.rb' + - 'spec/features/tags/developer_creates_tag_spec.rb' + - 'spec/features/usage_stats_consent_spec.rb' + - 'spec/features/users/login_spec.rb' + - 'spec/features/users/overview_spec.rb' diff --git a/.rubocop_todo/rspec/context_method.yml b/.rubocop_todo/rspec/context_method.yml deleted file mode 100644 index fa428552cb..0000000000 --- a/.rubocop_todo/rspec/context_method.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -# Cop supports --autocorrect. -RSpec/ContextMethod: - Details: grace period - Exclude: - - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/geo_node_status_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index ced205ff8e..a2886ff967 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -305,8 +305,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -424,7 +422,6 @@ RSpec/ContextWording: - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/application_setting_spec.rb' @@ -782,7 +779,6 @@ RSpec/ContextWording: - 'ee/spec/services/jira/jql_builder_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' @@ -830,7 +826,6 @@ RSpec/ContextWording: - 'ee/spec/services/security/store_grouped_scans_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/security/vulnerability_counting_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/services/software_license_policies/update_service_spec.rb' - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' @@ -941,10 +936,8 @@ RSpec/ContextWording: - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' @@ -980,7 +973,6 @@ RSpec/ContextWording: - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/admin/instance_review_controller_spec.rb' - 'spec/controllers/admin/integrations_controller_spec.rb' - - 'spec/controllers/admin/runner_projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' @@ -1162,7 +1154,6 @@ RSpec/ContextWording: - 'spec/features/ics/project_issues_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - 'spec/features/incidents/user_creates_new_incident_spec.rb' - - 'spec/features/invites_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' - 'spec/features/issuables/sorting_list_spec.rb' - 'spec/features/issuables/user_sees_sidebar_spec.rb' @@ -1343,7 +1334,6 @@ RSpec/ContextWording: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb' - 'spec/finders/contributed_projects_finder_spec.rb' @@ -1399,7 +1389,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/merge_requests.rb' - 'spec/frontend/fixtures/projects.rb' - 'spec/frontend/fixtures/search.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' @@ -1660,14 +1649,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/blame_spec.rb' @@ -1923,9 +1908,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' @@ -1951,8 +1933,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' @@ -2000,14 +1980,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/project_authorizations_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' @@ -2037,7 +2015,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' @@ -2089,7 +2066,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - 'spec/lib/gitlab/utils/mime_type_spec.rb' @@ -2140,7 +2116,6 @@ RSpec/ContextWording: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb' - 'spec/models/ability_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/alert_management/alert_spec.rb' @@ -2183,13 +2158,6 @@ RSpec/ContextWording: - 'spec/models/ci/trigger_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/crossplane_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/kubernetes_namespace_spec.rb' @@ -2623,7 +2591,6 @@ RSpec/ContextWording: - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' @@ -2810,7 +2777,6 @@ RSpec/ContextWording: - 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' - 'spec/services/metrics/dashboard/pod_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/self_monitoring_dashboard_service_spec.rb' - 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb' - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' @@ -2965,7 +2931,6 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/features/integrations/group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_and_group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_integrations_shared_context.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_jira_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_shared_context.rb' - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 99800ab825..67f7c36524 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -93,7 +93,6 @@ RSpec/DescribedClass: - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/seeder_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' @@ -107,8 +106,6 @@ RSpec/DescribedClass: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/application_record_spec.rb' - 'spec/models/application_setting_spec.rb' - - 'spec/models/awareness_session_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 154a305663..8cecf3677d 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -17,7 +17,6 @@ RSpec/ExpectChange: - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' @@ -196,7 +195,6 @@ RSpec/ExpectChange: - 'ee/spec/workers/groups/create_event_worker_spec.rb' - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' @@ -241,11 +239,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' @@ -257,7 +251,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/database/tables_truncate_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb' - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' @@ -273,7 +266,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/pages/cache_control_spec.rb' - 'spec/lib/gitlab/query_limiting/transaction_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - 'spec/migrations/20220321234317_remove_all_issuable_escalation_statuses_spec.rb' - 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb' - 'spec/migrations/20220512190659_remove_web_hooks_web_hook_logs_web_hook_id_fk_spec.rb' @@ -286,7 +278,6 @@ RSpec/ExpectChange: - 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb' - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb' - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' @@ -445,6 +436,5 @@ RSpec/ExpectChange: - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - 'spec/services/work_items/update_service_spec.rb' - 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb' - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' - 'spec/services/x509_certificate_revoke_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 8d36ed7520..4003908c97 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -62,7 +62,6 @@ RSpec/ExpectInHook: - 'ee/spec/requests/omniauth_kerberos_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' @@ -219,7 +218,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' - 'spec/lib/gitlab/faraday/error_callback_spec.rb' @@ -247,7 +245,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' @@ -257,7 +254,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' - 'spec/lib/gitlab/kas/client_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' @@ -439,7 +435,6 @@ RSpec/ExpectInHook: - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/search_service_spec.rb' - - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 752f10101b..3a990dcd12 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -27,7 +27,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/hooks_helper_spec.rb' @@ -205,7 +204,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' @@ -249,7 +247,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/components/pajamas/avatar_component_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -428,7 +425,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/ci/lint/result_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/ci/trigger_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/cluster_serializer_spec.rb' - 'spec/serializers/clusters/kubernetes_error_entity_spec.rb' @@ -554,7 +550,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/groups/new.html.haml_spec.rb' - 'spec/views/help/instance_configuration.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/fullscreen.html.haml_spec.rb' @@ -624,7 +619,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb' - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/projects/_project.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index 9cc2e1b5b6..ea19394890 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -12,6 +12,7 @@ RSpec/FilePath: - 'ee/spec/frontend/fixtures/analytics/value_streams_staging_stage.rb' - 'ee/spec/frontend/fixtures/analytics/value_streams_test_stage.rb' - 'ee/spec/frontend/fixtures/dora/metrics.rb' + - 'ee/spec/helpers/merge_requests_helper_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb' - 'ee/spec/requests/api/ci/runner/jobs_trace_spec.rb' @@ -24,7 +25,6 @@ RSpec/FilePath: - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - - 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml index 24b3ef082a..66b2fc4887 100644 --- a/.rubocop_todo/rspec/hooks_before_examples.yml +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -26,19 +26,14 @@ RSpec/HooksBeforeExamples: - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/spec/specs/runner_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index 7dc84c5743..fe632cdd57 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -75,7 +75,6 @@ RSpec/InstanceVariable: - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/triggers_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/finders/admin/plans_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - 'spec/frontend/fixtures/listbox.rb' @@ -83,7 +82,6 @@ RSpec/InstanceVariable: - 'spec/frontend/fixtures/sessions.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/frontend/fixtures/timezones.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/award_emoji_helper_spec.rb' @@ -100,7 +98,6 @@ RSpec/InstanceVariable: - 'spec/lib/extracts_ref_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' @@ -122,7 +119,6 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/x509/certificate_spec.rb' - 'spec/mailers/emails/issues_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - 'spec/models/integrations/campfire_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 8018d9ab05..58d02eb364 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -1,11 +1,7 @@ --- RSpec/MissingFeatureCategory: Exclude: - - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/user_pre_enforcement_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/clusters_controller_spec.rb' - 'ee/spec/controllers/autocomplete_controller_spec.rb' @@ -35,10 +31,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/elastic/migrate/20210825110300_backfill_namespace_ancestry_for_issues_spec.rb' - 'ee/spec/elastic/migrate/20210910094600_add_namespace_ancestry_ids_to_issues_mapping_spec.rb' - 'ee/spec/elastic/migrate/20210910100000_redo_backfill_namespace_ancestry_ids_for_issues_spec.rb' - - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - - 'ee/spec/elastic/migrate/20220824123000_add_label_ids_and_schema_version_to_issues_mapping_spec.rb' - - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/elastic_integration/repository_index_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' @@ -59,7 +51,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/boards/milestones_finder_spec.rb' - 'ee/spec/finders/boards/users_finder_spec.rb' - 'ee/spec/finders/clusters/environments_finder_spec.rb' - - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/concerns/epics/with_access_check_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' - 'ee/spec/finders/dast/profiles_finder_spec.rb' @@ -69,7 +60,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/autocomplete/users_finder_spec.rb' - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' - - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/fork_targets_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' @@ -95,15 +85,11 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/iterations/cadences_finder_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/licenses_finder_spec.rb' - - 'ee/spec/finders/merge_requests_finder_spec.rb' - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/finders/notes_finder_spec.rb' - 'ee/spec/finders/productivity_analytics_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/scim_finder_spec.rb' - - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - - 'ee/spec/finders/security/scan_result_policies_finder_spec.rb' - 'ee/spec/finders/security/training_providers/base_url_finder_spec.rb' - 'ee/spec/finders/security/training_providers/kontra_url_finder_spec.rb' - 'ee/spec/finders/security/training_providers/secure_code_warrior_url_finder_spec.rb' @@ -144,7 +130,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/api/vulnerabilities_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - - 'ee/spec/graphql/ee/mutations/ci/project_ci_cd_settings_update_spec.rb' - 'ee/spec/graphql/ee/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' @@ -177,8 +162,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/ee/types/repository/blob_type_spec.rb' - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' - 'ee/spec/graphql/ee/types/user_merge_request_interaction_type_spec.rb' - - 'ee/spec/graphql/graphql_triggers_spec.rb' - - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' @@ -263,7 +246,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/ci/code_coverage_activities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/ci/code_coverage_summary_resolver_spec.rb' - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_profile_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb' @@ -284,7 +266,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/network_policy_resolver_spec.rb' - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/product_analytics/dashboards_resolver_spec.rb' - 'ee/spec/graphql/resolvers/product_analytics/visualization_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb' @@ -295,7 +276,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - 'ee/spec/graphql/resolvers/user_discussions_count_resolver_spec.rb' - 'ee/spec/graphql/resolvers/user_notes_count_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities_count_per_day_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' @@ -359,7 +339,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/epic_issue_type_spec.rb' - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - 'ee/spec/graphql/types/epic_state_enum_spec.rb' - - 'ee/spec/graphql/types/epic_type_spec.rb' - 'ee/spec/graphql/types/external_issue_type_spec.rb' - 'ee/spec/graphql/types/gitlab_subscriptions/user_role_enum_spec.rb' - 'ee/spec/graphql/types/global_id_type_spec.rb' @@ -415,7 +394,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/security_report_summary_type_spec.rb' - 'ee/spec/graphql/types/security_scanner_type_enum_spec.rb' - 'ee/spec/graphql/types/security_scanners_spec.rb' - - 'ee/spec/graphql/types/subscription_type_spec.rb' - 'ee/spec/graphql/types/timebox_report_type_spec.rb' - 'ee/spec/graphql/types/vulnerabilities_count_by_day_type_spec.rb' - 'ee/spec/graphql/types/vulnerability/external_issue_link_external_tracker_enum_spec.rb' @@ -506,7 +484,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' - 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/profiles_helper_spec.rb' @@ -521,9 +498,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/system_note_helper_spec.rb' - 'ee/spec/helpers/ee/todos_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/ee/version_check_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' @@ -533,7 +508,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' - 'ee/spec/helpers/kerberos_helper_spec.rb' - - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' - 'ee/spec/helpers/markup_helper_spec.rb' @@ -556,7 +530,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - - 'ee/spec/helpers/users_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - 'ee/spec/initializers/database_config_spec.rb' - 'ee/spec/initializers/fog_google_https_private_urls_spec.rb' @@ -576,7 +549,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/api/entities/protected_environments/deploy_access_level_spec.rb' - 'ee/spec/lib/arkose/logger_spec.rb' - 'ee/spec/lib/arkose/settings_spec.rb' - - 'ee/spec/lib/arkose/verify_response_spec.rb' - 'ee/spec/lib/audit/base_changes_auditor_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/compliance_framework_changes_auditor_spec.rb' @@ -634,7 +606,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' - 'ee/spec/lib/ee/api/support/git_access_actor_spec.rb' - - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/banzai/filter/sanitization_filter_spec.rb' - 'ee/spec/lib/ee/bulk_imports/groups/stage_spec.rb' - 'ee/spec/lib/ee/bulk_imports/projects/stage_spec.rb' @@ -663,8 +634,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' @@ -672,12 +641,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_merge_request_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/file_size_check_spec.rb' @@ -689,13 +654,10 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/ci/jwt_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/after_config_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb' @@ -723,7 +685,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/metrics/samplers/database_sampler_spec.rb' - 'ee/spec/lib/ee/gitlab/middleware/read_only_spec.rb' - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb' - - 'ee/spec/lib/ee/gitlab/namespaces/storage/enforcement_spec.rb' - 'ee/spec/lib/ee/gitlab/omniauth_initializer_spec.rb' - 'ee/spec/lib/ee/gitlab/pages/deployment_update_spec.rb' - 'ee/spec/lib/ee/gitlab/prometheus/metric_group_spec.rb' @@ -773,10 +734,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gem_extensions/elasticsearch/model/adapter/active_record/records_spec.rb' - - 'ee/spec/lib/gem_extensions/elasticsearch/model/indexing/instance_methods_spec.rb' - 'ee/spec/lib/gitlab/alert_management/alert_payload_field_extractor_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/aggregated/data_for_duration_chart_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_for_duration_chart_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_closed_spec.rb' @@ -806,7 +765,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/response_check_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/response_store_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/sso_state_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' @@ -827,8 +785,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/auth/smartcard/session_spec.rb' - 'ee/spec/lib/gitlab/auth_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/bullet/exclusions_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' @@ -852,18 +808,14 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/validators/default_branch_image_validator_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' - 'ee/spec/lib/gitlab/ci/project_config_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/coverage_fuzzing/report_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/dependency_list/report_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/license_scanning/dependency_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/license_scanning/license_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/license_scanning/reports_comparer_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/metrics/report_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/metrics/reports_comparer_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' @@ -879,13 +831,11 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/templates/secure_binaries_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/cidr_spec.rb' - - 'ee/spec/lib/gitlab/com_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/customers_dot/jwt_spec.rb' - 'ee/spec/lib/gitlab/data_builder/vulnerability_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - 'ee/spec/lib/gitlab/elastic/elasticsearch_enabled_cache_spec.rb' - 'ee/spec/lib/gitlab/elastic/group_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' @@ -937,7 +887,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ip_address_state_spec.rb' - 'ee/spec/lib/gitlab/items_collection_spec.rb' - 'ee/spec/lib/gitlab/kerberos/authentication_spec.rb' - - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'ee/spec/lib/gitlab/licenses/submit_license_usage_data_banner_spec.rb' - 'ee/spec/lib/gitlab/manual_quarterly_co_term_banner_spec.rb' - 'ee/spec/lib/gitlab/metrics/samplers/global_search_sampler_spec.rb' @@ -1035,9 +984,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/quality/seeders/vulnerabilities_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/security_compliance_menu_spec.rb' - - 'ee/spec/lib/slack/api_spec.rb' - - 'ee/spec/lib/slack/block_kit/app_home_opened_spec.rb' - - 'ee/spec/lib/slack/block_kit/incident_management/incident_modal_opened_spec.rb' - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' @@ -1048,14 +994,12 @@ RSpec/MissingFeatureCategory: - 'ee/spec/mailers/ee/emails/profile_spec.rb' - 'ee/spec/mailers/ee/emails/projects_spec.rb' - 'ee/spec/mailers/emails/epics_spec.rb' - - 'ee/spec/mailers/emails/free_user_cap_spec.rb' - 'ee/spec/mailers/emails/group_memberships_spec.rb' - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/emails/user_cap_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/aggregation_context_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/runtime_limiter_spec.rb' @@ -1098,11 +1042,9 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/commit_spec.rb' - 'ee/spec/models/compliance_management/compliance_framework/project_settings_spec.rb' - 'ee/spec/models/compliance_management/framework_spec.rb' - - 'ee/spec/models/concerns/approval_rule_like_spec.rb' - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/auditable_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/mentionable_spec.rb' - 'ee/spec/models/concerns/ee/milestoneable_spec.rb' @@ -1110,9 +1052,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/concerns/ee/participable_spec.rb' - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' - 'ee/spec/models/concerns/ee/weight_eventable_spec.rb' - - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - 'ee/spec/models/concerns/elastic/milestone_spec.rb' - - 'ee/spec/models/concerns/elastic/project_wiki_spec.rb' - 'ee/spec/models/concerns/elastic/projects_search_spec.rb' - 'ee/spec/models/concerns/elastic/repository_spec.rb' - 'ee/spec/models/concerns/elastic/snippet_spec.rb' @@ -1185,12 +1125,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/ee/preloaders/group_policy_preloader_spec.rb' - 'ee/spec/models/ee/project_authorization_spec.rb' - 'ee/spec/models/ee/project_group_link_spec.rb' - - 'ee/spec/models/ee/project_setting_spec.rb' - 'ee/spec/models/ee/project_statistics_spec.rb' - 'ee/spec/models/ee/project_wiki_spec.rb' - - 'ee/spec/models/ee/projects/wiki_repository_spec.rb' - - 'ee/spec/models/ee/protected_branch_spec.rb' - - 'ee/spec/models/ee/protected_ref_access_spec.rb' - 'ee/spec/models/ee/protected_ref_spec.rb' - 'ee/spec/models/ee/release_spec.rb' - 'ee/spec/models/ee/resource_label_event_spec.rb' @@ -1218,7 +1154,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/group_member_spec.rb' - 'ee/spec/models/group_merge_request_approval_setting_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/groups/repository_storage_move_spec.rb' - 'ee/spec/models/historical_data_spec.rb' - 'ee/spec/models/identity_spec.rb' @@ -1245,26 +1180,20 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/iteration_note_spec.rb' - 'ee/spec/models/label_note_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/models/merge_request_block_spec.rb' - - 'ee/spec/models/merge_request_spec.rb' - - 'ee/spec/models/merge_requests/compliance_violation_spec.rb' - 'ee/spec/models/merge_requests/external_status_check_spec.rb' - 'ee/spec/models/merge_requests/status_check_response_spec.rb' - 'ee/spec/models/milestone_release_spec.rb' - 'ee/spec/models/milestone_spec.rb' - 'ee/spec/models/namespace_limit_spec.rb' - 'ee/spec/models/namespace_setting_spec.rb' - - 'ee/spec/models/namespaces/free_user_cap_spec.rb' - 'ee/spec/models/namespaces/storage/root_excess_size_spec.rb' - 'ee/spec/models/namespaces/storage/root_size_spec.rb' - - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' - 'ee/spec/models/path_lock_spec.rb' - 'ee/spec/models/plan_spec.rb' - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/product_analytics/dashboard_spec.rb' - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - 'ee/spec/models/productivity_analytics_spec.rb' - 'ee/spec/models/project_alias_spec.rb' @@ -1276,7 +1205,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/project_security_setting_spec.rb' - 'ee/spec/models/project_team_spec.rb' - 'ee/spec/models/protected_branch/required_code_owners_section_spec.rb' - - 'ee/spec/models/protected_branch/unprotect_access_level_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/protected_environments/approval_rule_spec.rb' - 'ee/spec/models/protected_environments/deploy_access_level_spec.rb' @@ -1332,7 +1260,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb' - 'ee/spec/policies/instance_security_dashboard_policy_spec.rb' - 'ee/spec/policies/issuable_policy_spec.rb' - - 'ee/spec/policies/issue_policy_spec.rb' - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb' - 'ee/spec/policies/note_policy_spec.rb' - 'ee/spec/policies/path_lock_policy_spec.rb' @@ -1343,7 +1270,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/policies/security/finding_policy_spec.rb' - 'ee/spec/policies/security/scan_policy_spec.rb' - 'ee/spec/policies/user_policy_spec.rb' - - 'ee/spec/policies/vulnerability_policy_spec.rb' - 'ee/spec/presenters/analytics/cycle_analytics/stage_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_presenter_spec.rb' @@ -1371,7 +1297,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/requests/admin/credentials_controller_spec.rb' - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/ee/application_controller_spec.rb' - 'ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb' - 'ee/spec/routing/admin_routing_spec.rb' - 'ee/spec/routing/git_http_routing_spec.rb' @@ -1488,7 +1413,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/app_sec/dast/profiles/build_config_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - 'ee/spec/services/app_sec/dast/scans/create_service_spec.rb' - 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' @@ -1513,7 +1437,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/record_user_data_service_spec.rb' - 'ee/spec/services/arkose/token_verification_service_spec.rb' - 'ee/spec/services/audit_events/build_service_spec.rb' - 'ee/spec/services/audit_events/custom_audit_event_service_spec.rb' @@ -1533,7 +1456,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/award_emojis/add_service_spec.rb' - 'ee/spec/services/award_emojis/destroy_service_spec.rb' @@ -1570,7 +1492,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/fork_service_spec.rb' - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/group_links/update_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' @@ -1586,7 +1507,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/projects/setup_ci_cd_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/protected_environments/base_service_spec.rb' - 'ee/spec/services/protected_environments/environment_dropdown_service_spec.rb' - 'ee/spec/services/protected_environments/search_service_spec.rb' @@ -1597,7 +1517,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/releases/update_service_spec.rb' - 'ee/spec/services/requirements_management/prepare_import_csv_service_spec.rb' - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' - - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' @@ -1623,24 +1542,18 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - 'ee/spec/views/devise/sessions/new.html.haml_spec.rb' - 'ee/spec/views/groups/_compliance_frameworks.html.haml_spec.rb' - - 'ee/spec/views/groups/compliance_frameworks/edit.html.haml_spec.rb' - - 'ee/spec/views/groups/compliance_frameworks/new.html.haml_spec.rb' - - 'ee/spec/views/groups/edit.html.haml_spec.rb' - 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb' - 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/checkout.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - - 'ee/spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - - 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb' - 'ee/spec/views/layouts/project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' @@ -1659,9 +1572,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' - 'ee/spec/views/projects/settings/merge_requests/_merge_request_approvals.html.haml_spec.rb' - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' - - 'ee/spec/views/registrations/company/new.html.haml_spec.rb' - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' @@ -1690,12 +1601,10 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/views/subscriptions/new.html.haml_spec.rb' - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb' - - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/audit_event_type_spec.rb' - 'spec/bin/diagnostic_reports_uploader_spec.rb' - 'spec/bin/sidekiq_cluster_spec.rb' - 'spec/channels/application_cable/connection_spec.rb' - - 'spec/channels/awareness_channel_spec.rb' - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' @@ -1718,7 +1627,6 @@ RSpec/MissingFeatureCategory: - 'spec/components/pajamas/toggle_component_spec.rb' - 'spec/controllers/acme_challenges_controller_spec.rb' - 'spec/controllers/admin/application_settings/appearances_controller_spec.rb' - - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/admin/applications_controller_spec.rb' - 'spec/controllers/admin/ci/variables_controller_spec.rb' - 'spec/controllers/admin/cohorts_controller_spec.rb' @@ -1743,7 +1651,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/chaos_controller_spec.rb' - 'spec/controllers/concerns/check_rate_limit_spec.rb' - 'spec/controllers/concerns/checks_collaboration_spec.rb' - - 'spec/controllers/concerns/confirm_email_warning_spec.rb' - 'spec/controllers/concerns/continue_params_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' @@ -1761,10 +1668,8 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/concerns/preferred_language_switcher_spec.rb' - 'spec/controllers/concerns/project_unauthorized_spec.rb' - 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb' - - 'spec/controllers/concerns/redis_tracking_spec.rb' - 'spec/controllers/concerns/renders_commits_spec.rb' - 'spec/controllers/concerns/routable_actions_spec.rb' - - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/concerns/sorting_preference_spec.rb' - 'spec/controllers/concerns/sourcegraph_decorator_spec.rb' - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' @@ -1803,18 +1708,7 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/groups/variables_controller_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' - - 'spec/controllers/import/bitbucket_controller_spec.rb' - - 'spec/controllers/import/bitbucket_server_controller_spec.rb' - - 'spec/controllers/import/fogbugz_controller_spec.rb' - - 'spec/controllers/import/gitea_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - - 'spec/controllers/import/manifest_controller_spec.rb' - - 'spec/controllers/import/phabricator_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' - - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - - 'spec/controllers/jira_connect/branches_controller_spec.rb' - - 'spec/controllers/jira_connect/events_controller_spec.rb' - - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - 'spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/oauth/applications_controller_spec.rb' @@ -1842,8 +1736,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/autocomplete_sources_controller_spec.rb' - 'spec/controllers/projects/avatars_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' - - 'spec/controllers/projects/blame_controller_spec.rb' - - 'spec/controllers/projects/blob_controller_spec.rb' - 'spec/controllers/projects/boards_controller_spec.rb' - 'spec/controllers/projects/ci/daily_build_group_report_results_controller_spec.rb' - 'spec/controllers/projects/ci/lints_controller_spec.rb' @@ -1866,7 +1758,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/find_file_controller_spec.rb' - 'spec/controllers/projects/graphs_controller_spec.rb' - 'spec/controllers/projects/import/jira_controller_spec.rb' - - 'spec/controllers/projects/imports_controller_spec.rb' - 'spec/controllers/projects/incidents_controller_spec.rb' - 'spec/controllers/projects/issue_links_controller_spec.rb' - 'spec/controllers/projects/mattermosts_controller_spec.rb' @@ -1903,13 +1794,11 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/templates_controller_spec.rb' - 'spec/controllers/projects/terraform_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' - - 'spec/controllers/projects/tree_controller_spec.rb' - 'spec/controllers/projects/uploads_controller_spec.rb' - 'spec/controllers/projects/usage_quotas_controller_spec.rb' - 'spec/controllers/projects/variables_controller_spec.rb' - 'spec/controllers/projects/web_ide_schemas_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - - 'spec/controllers/projects/wikis_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/sent_notifications_controller_spec.rb' @@ -1971,7 +1860,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/ci/runner_jobs_finder_spec.rb' - 'spec/finders/ci/variables_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agent_tokens_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/knative_services_finder_spec.rb' @@ -2005,7 +1893,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - 'spec/finders/incident_management/timeline_event_tags_finder_spec.rb' - 'spec/finders/incident_management/timeline_events_finder_spec.rb' @@ -2028,7 +1915,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/packages/build_infos_finder_spec.rb' - 'spec/finders/packages/composer/packages_finder_spec.rb' - 'spec/finders/packages/conan/package_file_finder_spec.rb' - - 'spec/finders/packages/conan/package_finder_spec.rb' - 'spec/finders/packages/debian/distributions_finder_spec.rb' - 'spec/finders/packages/generic/package_finder_spec.rb' - 'spec/finders/packages/go/module_finder_spec.rb' @@ -2118,7 +2004,6 @@ RSpec/MissingFeatureCategory: - 'spec/frontend/fixtures/prometheus_integration.rb' - 'spec/frontend/fixtures/raw.rb' - 'spec/frontend/fixtures/releases.rb' - - 'spec/frontend/fixtures/runner.rb' - 'spec/frontend/fixtures/search.rb' - 'spec/frontend/fixtures/sessions.rb' - 'spec/frontend/fixtures/snippet.rb' @@ -2130,7 +2015,6 @@ RSpec/MissingFeatureCategory: - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/features/authorization_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb' - - 'spec/graphql/graphql_triggers_spec.rb' - 'spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb' - 'spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' @@ -2153,7 +2037,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_group_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' @@ -2236,10 +2119,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/board_resolver_spec.rb' - 'spec/graphql/resolvers/boards_resolver_spec.rb' - 'spec/graphql/resolvers/branch_commit_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/all_jobs_resolver_spec.rb' - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' - 'spec/graphql/resolvers/ci/job_token_scope_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/jobs_resolver_spec.rb' - 'spec/graphql/resolvers/ci/project_pipeline_counts_resolver_spec.rb' - 'spec/graphql/resolvers/ci/template_resolver_spec.rb' - 'spec/graphql/resolvers/ci/test_report_summary_resolver_spec.rb' @@ -2280,7 +2161,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/group_labels_resolver_spec.rb' - 'spec/graphql/resolvers/group_members/notification_email_resolver_spec.rb' - 'spec/graphql/resolvers/group_members_resolver_spec.rb' - - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' - 'spec/graphql/resolvers/group_resolver_spec.rb' - 'spec/graphql/resolvers/incident_management/timeline_event_tags_resolver_spec.rb' @@ -2299,7 +2179,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/package_details_resolver_spec.rb' - 'spec/graphql/resolvers/package_pipelines_resolver_spec.rb' - 'spec/graphql/resolvers/packages_base_resolver_spec.rb' - - 'spec/graphql/resolvers/paginated_tree_resolver_spec.rb' - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' - 'spec/graphql/resolvers/project_jobs_resolver_spec.rb' - 'spec/graphql/resolvers/project_members_resolver_spec.rb' @@ -2386,7 +2265,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/ci/job_kind_enum_spec.rb' - 'spec/graphql/types/ci/job_need_union_spec.rb' - 'spec/graphql/types/ci/job_status_enum_spec.rb' - - 'spec/graphql/types/ci/job_type_spec.rb' - 'spec/graphql/types/ci/manual_variable_type_spec.rb' - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - 'spec/graphql/types/ci/pipeline_merge_request_event_type_enum_spec.rb' @@ -2505,7 +2383,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/merge_request_sort_enum_spec.rb' - 'spec/graphql/types/merge_request_state_enum_spec.rb' - 'spec/graphql/types/merge_request_state_event_enum_spec.rb' - - 'spec/graphql/types/merge_request_type_spec.rb' - 'spec/graphql/types/merge_requests/assignee_type_spec.rb' - 'spec/graphql/types/merge_requests/author_type_spec.rb' - 'spec/graphql/types/merge_requests/participant_type_spec.rb' @@ -2612,10 +2489,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/user_callout_feature_name_enum_spec.rb' - 'spec/graphql/types/user_callout_type_spec.rb' - 'spec/graphql/types/user_merge_request_interaction_type_spec.rb' - - 'spec/graphql/types/user_preferences_type_spec.rb' - 'spec/graphql/types/user_status_type_spec.rb' - 'spec/graphql/types/work_item_id_type_spec.rb' - - 'spec/graphql/types/work_item_type_spec.rb' - 'spec/graphql/types/work_items/widget_interface_spec.rb' - 'spec/graphql/types/work_items/widget_type_enum_spec.rb' - 'spec/graphql/types/work_items/widgets/assignees_input_type_spec.rb' @@ -2641,11 +2516,9 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/auth_helper_spec.rb' - 'spec/helpers/auto_devops_helper_spec.rb' - - 'spec/helpers/avatars_helper_spec.rb' - 'spec/helpers/award_emoji_helper_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/bizible_helper_spec.rb' - - 'spec/helpers/blame_helper_spec.rb' - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' @@ -2656,7 +2529,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/ci/pipelines_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/ci/secure_files_helper_spec.rb' - 'spec/helpers/ci/status_helper_spec.rb' - 'spec/helpers/ci/triggers_helper_spec.rb' @@ -2707,10 +2579,7 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/markup_helper_spec.rb' - 'spec/helpers/members_helper_spec.rb' - 'spec/helpers/milestones_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/helpers/nav/top_nav_helper_spec.rb' - - 'spec/helpers/nav_helper_spec.rb' - - 'spec/helpers/notes_helper_spec.rb' - 'spec/helpers/notifications_helper_spec.rb' - 'spec/helpers/notify_helper_spec.rb' - 'spec/helpers/numbers_helper_spec.rb' @@ -2760,7 +2629,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/users/group_callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/version_check_helper_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - 'spec/helpers/web_ide_button_helper_spec.rb' - 'spec/helpers/webpack_helper_spec.rb' - 'spec/helpers/whats_new_helper_spec.rb' @@ -2794,7 +2662,6 @@ RSpec/MissingFeatureCategory: - 'spec/initializers/mailer_retries_spec.rb' - 'spec/initializers/microsoft_graph_mailer_spec.rb' - 'spec/initializers/net_http_patch_spec.rb' - - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/omniauth_spec.rb' - 'spec/initializers/pages_storage_check_spec.rb' - 'spec/initializers/rack_VULNDB-255039_patch_spec.rb' @@ -2828,7 +2695,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/api/entities/ci/job_request/port_spec.rb' - 'spec/lib/api/entities/ci/job_request/service_spec.rb' - 'spec/lib/api/entities/ci/pipeline_spec.rb' - - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' - 'spec/lib/api/entities/clusters/agent_spec.rb' - 'spec/lib/api/entities/deploy_key_spec.rb' - 'spec/lib/api/entities/deploy_keys_project_spec.rb' @@ -2892,10 +2758,7 @@ RSpec/MissingFeatureCategory: - 'spec/lib/backup/database_backup_error_spec.rb' - 'spec/lib/backup/file_backup_error_spec.rb' - 'spec/lib/backup/files_spec.rb' - - 'spec/lib/backup/gitaly_backup_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/backup/task_spec.rb' - - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/inline_alert_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_cluster_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_diff_filter_spec.rb' @@ -2964,7 +2827,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/releases_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/repository_bundle_pipeline_spec.rb' @@ -3050,7 +2912,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/api_authentication/token_locator_spec.rb' - 'spec/lib/gitlab/api_authentication/token_type_builder_spec.rb' - 'spec/lib/gitlab/app_json_logger_spec.rb' - - 'spec/lib/gitlab/app_logger_spec.rb' - 'spec/lib/gitlab/app_text_logger_spec.rb' - 'spec/lib/gitlab/application_context_spec.rb' - 'spec/lib/gitlab/application_rate_limiter/base_strategy_spec.rb' @@ -3085,7 +2946,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/ldap/dn_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/devise_spec.rb' @@ -3100,28 +2960,20 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/saml/origin_validator_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth/two_factor_auth_verifier_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - 'spec/lib/gitlab/auth/unique_ips_limiter_spec.rb' - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_integrations_type_new_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_internal_on_notes_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_project_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_children_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb' @@ -3130,11 +2982,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_settings_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_topics_title_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_upvotes_count_on_issues_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_user_details_fields_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_user_namespace_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/background_migration/base_job_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' @@ -3145,76 +2994,44 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_orphaned_routes_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_licence_for_recent_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/mailers/unconfirm_mailer_spec.rb' - - 'spec/lib/gitlab/background_migration/merge_topics_with_same_name_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations_spec.rb' - 'spec/lib/gitlab/background_migration/populate_projects_star_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_non_private_projects_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_total_projects_count_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/update_ci_pipeline_artifacts_unknown_locked_status_spec.rb' - 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' - 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb' @@ -3223,7 +3040,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb' - 'spec/lib/gitlab/buffered_io_spec.rb' - 'spec/lib/gitlab/build_access_spec.rb' - - 'spec/lib/gitlab/bullet/exclusions_spec.rb' - 'spec/lib/gitlab/bullet_spec.rb' - 'spec/lib/gitlab/cache/helpers_spec.rb' - 'spec/lib/gitlab/cache/import/caching_spec.rb' @@ -3259,7 +3075,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/ansi2json/parser_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/result_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - 'spec/lib/gitlab/ci/artifact_file_reader_spec.rb' - 'spec/lib/gitlab/ci/artifacts/logger_spec.rb' - 'spec/lib/gitlab/ci/artifacts/metrics_spec.rb' @@ -3278,7 +3093,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/path_spec.rb' - 'spec/lib/gitlab/ci/build/cache_spec.rb' - - 'spec/lib/gitlab/ci/build/context/global_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/factory_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/registry/dependency_proxy_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/registry/gitlab_registry_spec.rb' @@ -3362,7 +3176,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/cron_parser_spec.rb' - 'spec/lib/gitlab/ci/jwt_spec.rb' - - 'spec/lib/gitlab/ci/jwt_v2_spec.rb' - 'spec/lib/gitlab/ci/mask_secret_spec.rb' - 'spec/lib/gitlab/ci/matching/build_matcher_spec.rb' - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' @@ -3420,7 +3233,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/project_config_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' - - 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/coverage_report_generator_spec.rb' @@ -3477,7 +3289,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/status/build/waiting_for_approval_spec.rb' - 'spec/lib/gitlab/ci/status/build/waiting_for_resource_spec.rb' - 'spec/lib/gitlab/ci/status/canceled_spec.rb' - - 'spec/lib/gitlab/ci/status/composite_spec.rb' - 'spec/lib/gitlab/ci/status/core_spec.rb' - 'spec/lib/gitlab/ci/status/created_spec.rb' - 'spec/lib/gitlab/ci/status/extended_spec.rb' @@ -3494,7 +3305,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb' - 'spec/lib/gitlab/ci/status/pipeline/factory_spec.rb' - 'spec/lib/gitlab/ci/status/preparing_spec.rb' - - 'spec/lib/gitlab/ci/status/processable/waiting_for_resource_spec.rb' - 'spec/lib/gitlab/ci/status/running_spec.rb' - 'spec/lib/gitlab/ci/status/scheduled_spec.rb' - 'spec/lib/gitlab/ci/status/skipped_spec.rb' @@ -3599,10 +3409,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_transition_log_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb' - 'spec/lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log_spec.rb' - - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - 'spec/lib/gitlab/database/background_migration/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/database/background_migration_job_spec.rb' - 'spec/lib/gitlab/database/batch_average_counter_spec.rb' @@ -3617,7 +3425,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - 'spec/lib/gitlab/database/each_database_spec.rb' - 'spec/lib/gitlab/database/grant_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb' - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' @@ -3628,7 +3435,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb' - 'spec/lib/gitlab/database/load_balancing/session_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/srv_resolver_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sticking_spec.rb' - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' @@ -3655,7 +3461,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/migrations/sidekiq_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb' - 'spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb' - - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' @@ -3666,7 +3471,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/pg_class_spec.rb' - 'spec/lib/gitlab/database/postgres_constraint_spec.rb' - 'spec/lib/gitlab/database/postgres_hll/batch_distinct_counter_spec.rb' @@ -3701,10 +3505,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/unidirectional_copy_trigger_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/prometheus_metric_spec.rb' - - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/delete_service_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/default_branch_spec.rb' - 'spec/lib/gitlab/dependency_linker/base_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/cargo_toml_linker_spec.rb' @@ -3733,8 +3533,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/formatters/image_formatter_spec.rb' - 'spec/lib/gitlab/diff/formatters/text_formatter_spec.rb' - - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - - 'spec/lib/gitlab/diff/highlight_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_markdown_marker_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_marker_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_spec.rb' @@ -3773,7 +3571,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' @@ -3787,7 +3584,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/message/in_product_marketing_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/receiver_spec.rb' - - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' - 'spec/lib/gitlab/email/smime/signer_spec.rb' - 'spec/lib/gitlab/emoji_spec.rb' @@ -3834,7 +3630,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/fips_spec.rb' - 'spec/lib/gitlab/fogbugz_import/client_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - - 'spec/lib/gitlab/fogbugz_import/project_creator_spec.rb' - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' @@ -3847,7 +3642,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/git/bundle_file_spec.rb' - 'spec/lib/gitlab/git/changed_path_spec.rb' - 'spec/lib/gitlab/git/changes_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/commit_stats_spec.rb' - 'spec/lib/gitlab/git/compare_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' @@ -3877,7 +3671,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/git/user_spec.rb' - 'spec/lib/gitlab/git/util_spec.rb' - 'spec/lib/gitlab/git/wiki_page_version_spec.rb' - - 'spec/lib/gitlab/git/wraps_gitaly_errors_spec.rb' - 'spec/lib/gitlab/git_access_design_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' - 'spec/lib/gitlab/git_access_snippet_spec.rb' @@ -3889,7 +3682,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/call_spec.rb' - 'spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_spec.rb' @@ -3929,7 +3721,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_requests/review_request_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/repository_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' @@ -3962,9 +3753,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/single_endpoint_notes_importing_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - 'spec/lib/gitlab/github_import_spec.rb' - - 'spec/lib/gitlab/gitlab_import/client_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - - 'spec/lib/gitlab/gitlab_import/project_creator_spec.rb' - 'spec/lib/gitlab/gl_repository/identifier_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'spec/lib/gitlab/gl_repository_spec.rb' @@ -4075,18 +3863,13 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/duration_measuring_spec.rb' - 'spec/lib/gitlab/import_export/error_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - - 'spec/lib/gitlab/import_export/fork_spec.rb' - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/hash_util_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/legacy_relation_tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' @@ -4116,10 +3899,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/uploads_saver_spec.rb' - 'spec/lib/gitlab/import_export/wiki_repo_saver_spec.rb' - 'spec/lib/gitlab/import_formatter_spec.rb' - - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - 'spec/lib/gitlab/incident_management/pager_duty/incident_issue_description_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb' - 'spec/lib/gitlab/instrumentation/rate_limiting_gates_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' @@ -4156,19 +3937,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - 'spec/lib/gitlab/kubernetes/generic_secret_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/kubernetes/ingress_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/entry/cluster_spec.rb' @@ -4219,7 +3987,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/mailgun/webhook_processors/member_invites_spec.rb' - 'spec/lib/gitlab/manifest_import/manifest_spec.rb' - 'spec/lib/gitlab/manifest_import/metadata_spec.rb' - - 'spec/lib/gitlab/manifest_import/project_creator_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/field_data_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' @@ -4278,10 +4045,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/metrics/sli_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_view_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/external_http_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rails_cache_spec.rb' - 'spec/lib/gitlab/metrics/system_spec.rb' @@ -4355,21 +4120,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/performance_bar/stats_spec.rb' - 'spec/lib/gitlab/performance_bar/with_top_level_warnings_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - - 'spec/lib/gitlab/phabricator_import/cache/map_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/client_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/users_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/project_creator_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - - 'spec/lib/gitlab/phabricator_import/worker_state_spec.rb' - 'spec/lib/gitlab/pipeline_scope_counts_spec.rb' - 'spec/lib/gitlab/polling_interval_spec.rb' - 'spec/lib/gitlab/popen/runner_spec.rb' @@ -4404,7 +4154,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/query_limiting_spec.rb' - 'spec/lib/gitlab/quick_actions/command_definition_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - 'spec/lib/gitlab/quick_actions/spend_time_and_date_separator_spec.rb' - 'spec/lib/gitlab/quick_actions/substitution_definition_spec.rb' - 'spec/lib/gitlab/quick_actions/timeline_text_and_date_time_separator_spec.rb' @@ -4445,7 +4194,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/route_map_spec.rb' - 'spec/lib/gitlab/routing_spec.rb' - 'spec/lib/gitlab/rugged_instrumentation_spec.rb' - - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/saas_spec.rb' - 'spec/lib/gitlab/safe_request_loader_spec.rb' - 'spec/lib/gitlab/safe_request_purger_spec.rb' @@ -4470,7 +4218,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/service_desk_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - 'spec/lib/gitlab/setup_helper/praefect_spec.rb' @@ -4482,7 +4229,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_spec.rb' - 'spec/lib/gitlab/sidekiq_config_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb' - 'spec/lib/gitlab/sidekiq_death_handler_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/deduplication_logger_spec.rb' @@ -4492,7 +4238,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/none_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executed_spec.rb' @@ -4541,7 +4286,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/slash_commands/run_spec.rb' - 'spec/lib/gitlab/snippet_search_results_spec.rb' - 'spec/lib/gitlab/sourcegraph_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/sql/cte_spec.rb' - 'spec/lib/gitlab/sql/except_spec.rb' - 'spec/lib/gitlab/sql/glob_spec.rb' @@ -4582,14 +4326,11 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/tracking/service_ping_context_spec.rb' - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' - - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/unicode_spec.rb' - 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb' - - 'spec/lib/gitlab/untrusted_regexp_spec.rb' - 'spec/lib/gitlab/uploads_transfer_spec.rb' - 'spec/lib/gitlab/url_blockers/domain_allowlist_entry_spec.rb' - - 'spec/lib/gitlab/url_blockers/ip_allowlist_entry_spec.rb' - 'spec/lib/gitlab/url_blockers/url_allowlist_spec.rb' - 'spec/lib/gitlab/url_builder_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' @@ -4671,7 +4412,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' - 'spec/lib/gitlab/user_access_snippet_spec.rb' - - 'spec/lib/gitlab/user_access_spec.rb' - 'spec/lib/gitlab/utils/batch_loader_spec.rb' - 'spec/lib/gitlab/utils/deep_size_spec.rb' - 'spec/lib/gitlab/utils/delegator_override/error_spec.rb' @@ -4751,7 +4491,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/mattermost/team_spec.rb' - 'spec/lib/microsoft_teams/activity_spec.rb' - 'spec/lib/microsoft_teams/notifier_spec.rb' - - 'spec/lib/object_storage/direct_upload_spec.rb' - 'spec/lib/omni_auth/strategies/bitbucket_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/pager_duty/webhook_payload_parser_spec.rb' @@ -4762,11 +4501,9 @@ RSpec/MissingFeatureCategory: - 'spec/lib/peek/views/redis_detailed_spec.rb' - 'spec/lib/peek/views/rugged_spec.rb' - 'spec/lib/product_analytics/event_params_spec.rb' - - 'spec/lib/product_analytics/tracker_spec.rb' - 'spec/lib/prometheus/cleanup_multiproc_dir_service_spec.rb' - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/quality/seeders/issues_spec.rb' - - 'spec/lib/rouge/formatters/html_gitlab_spec.rb' - 'spec/lib/safe_zip/entry_spec.rb' - 'spec/lib/safe_zip/extract_params_spec.rb' - 'spec/lib/safe_zip/extract_spec.rb' @@ -4811,7 +4548,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/system_check_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - - 'spec/lib/uploaded_file_spec.rb' - 'spec/lib/version_check_spec.rb' - 'spec/mailers/abuse_report_mailer_spec.rb' - 'spec/mailers/devise_mailer_spec.rb' @@ -4824,10 +4560,8 @@ RSpec/MissingFeatureCategory: - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' - 'spec/mailers/emails/pipelines_spec.rb' - - 'spec/mailers/emails/profile_spec.rb' - 'spec/mailers/emails/projects_spec.rb' - 'spec/mailers/emails/releases_spec.rb' - - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/mailers/previews_spec.rb' - 'spec/mailers/repository_check_mailer_spec.rb' @@ -4852,7 +4586,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/audit_event_spec.rb' - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/aws/role_spec.rb' - 'spec/models/badge_spec.rb' - 'spec/models/badges/group_badge_spec.rb' @@ -4867,7 +4600,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/blob_viewer/license_spec.rb' - 'spec/models/blob_viewer/markup_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - - 'spec/models/blob_viewer/package_json_spec.rb' - 'spec/models/blob_viewer/podspec_json_spec.rb' - 'spec/models/blob_viewer/podspec_spec.rb' - 'spec/models/blob_viewer/readme_spec.rb' @@ -4878,12 +4610,9 @@ RSpec/MissingFeatureCategory: - 'spec/models/board_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/bulk_imports/configuration_spec.rb' - - 'spec/models/bulk_imports/export_spec.rb' - 'spec/models/bulk_imports/export_status_spec.rb' - 'spec/models/bulk_imports/export_upload_spec.rb' - 'spec/models/bulk_imports/failure_spec.rb' - - 'spec/models/bulk_imports/file_transfer/group_config_spec.rb' - - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' - 'spec/models/bulk_imports/file_transfer_spec.rb' - 'spec/models/bulk_imports/tracker_spec.rb' - 'spec/models/chat_team_spec.rb' @@ -4895,8 +4624,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/build_trace_chunks/database_spec.rb' - 'spec/models/ci/build_trace_chunks/fog_spec.rb' - 'spec/models/ci/build_trace_chunks/redis_spec.rb' - - 'spec/models/ci/build_trace_spec.rb' - - 'spec/models/ci/commit_with_pipeline_spec.rb' - 'spec/models/ci/daily_build_group_report_result_spec.rb' - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/group_spec.rb' @@ -4921,17 +4648,8 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/trigger_request_spec.rb' - 'spec/models/ci/unit_test_failure_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - - 'spec/models/clusters/agent_spec.rb' - 'spec/models/clusters/agent_token_spec.rb' - 'spec/models/clusters/agents/activity_event_spec.rb' - - 'spec/models/clusters/agents/group_authorization_spec.rb' - - 'spec/models/clusters/agents/implicit_authorization_spec.rb' - - 'spec/models/clusters/agents/project_authorization_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_enabled_grant_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/group_spec.rb' @@ -4945,8 +4663,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/commit_signatures/gpg_signature_spec.rb' - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/compare_spec.rb' - 'spec/models/concerns/access_requestable_spec.rb' - 'spec/models/concerns/after_commit_queue_spec.rb' - 'spec/models/concerns/approvable_spec.rb' @@ -4954,7 +4670,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/avatarable_spec.rb' - 'spec/models/concerns/awardable_spec.rb' - - 'spec/models/concerns/awareness_spec.rb' - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/models/concerns/batch_nullify_dependent_associations_spec.rb' - 'spec/models/concerns/blob_language_from_git_attributes_spec.rb' @@ -4971,7 +4686,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - 'spec/models/concerns/ci/partitionable_spec.rb' - 'spec/models/concerns/ci/track_environment_usage_spec.rb' - - 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb' - 'spec/models/concerns/commit_signature_spec.rb' - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/cron_schedulable_spec.rb' @@ -5020,7 +4734,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/project_api_compatibility_spec.rb' - 'spec/models/concerns/project_features_compatibility_spec.rb' - 'spec/models/concerns/prometheus_adapter_spec.rb' - - 'spec/models/concerns/protected_ref_access_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/redactable_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' @@ -5076,7 +4789,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/design_management/design_action_spec.rb' - 'spec/models/design_management/design_at_version_spec.rb' - 'spec/models/design_management/design_collection_spec.rb' - - 'spec/models/design_management/repository_spec.rb' - 'spec/models/design_management/version_spec.rb' - 'spec/models/design_user_mention_spec.rb' - 'spec/models/dev_ops_report/metric_spec.rb' @@ -5220,7 +4932,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/milestone_spec.rb' - 'spec/models/ml/candidate_metric_spec.rb' - 'spec/models/ml/candidate_param_spec.rb' - - 'spec/models/ml/experiment_spec.rb' - 'spec/models/namespace/admin_note_spec.rb' - 'spec/models/namespace/aggregation_schedule_spec.rb' - 'spec/models/namespace/detail_spec.rb' @@ -5252,20 +4963,16 @@ RSpec/MissingFeatureCategory: - 'spec/models/packages/debian/group_component_file_spec.rb' - 'spec/models/packages/debian/group_component_spec.rb' - 'spec/models/packages/debian/group_distribution_key_spec.rb' - - 'spec/models/packages/debian/group_distribution_spec.rb' - 'spec/models/packages/debian/project_architecture_spec.rb' - 'spec/models/packages/debian/project_component_file_spec.rb' - 'spec/models/packages/debian/project_component_spec.rb' - 'spec/models/packages/debian/project_distribution_key_spec.rb' - - 'spec/models/packages/debian/project_distribution_spec.rb' - 'spec/models/packages/debian/publication_spec.rb' - 'spec/models/packages/dependency_link_spec.rb' - - 'spec/models/packages/dependency_spec.rb' - 'spec/models/packages/go/module_spec.rb' - 'spec/models/packages/go/module_version_spec.rb' - 'spec/models/packages/helm/file_metadatum_spec.rb' - 'spec/models/packages/maven/metadatum_spec.rb' - - 'spec/models/packages/npm/metadatum_spec.rb' - 'spec/models/packages/npm_spec.rb' - 'spec/models/packages/nuget/dependency_link_metadatum_spec.rb' - 'spec/models/packages/nuget/metadatum_spec.rb' @@ -5313,13 +5020,10 @@ RSpec/MissingFeatureCategory: - 'spec/models/project_metrics_setting_spec.rb' - 'spec/models/project_pages_metadatum_spec.rb' - 'spec/models/project_repository_spec.rb' - - 'spec/models/project_setting_spec.rb' - 'spec/models/project_snippet_spec.rb' - 'spec/models/project_statistics_spec.rb' - - 'spec/models/project_wiki_spec.rb' - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - 'spec/models/projects/ci_feature_usage_spec.rb' - - 'spec/models/projects/import_export/relation_export_spec.rb' - 'spec/models/projects/import_export/relation_export_upload_spec.rb' - 'spec/models/projects/project_topic_spec.rb' - 'spec/models/projects/repository_storage_move_spec.rb' @@ -5330,8 +5034,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/prometheus_alert_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/protectable_dropdown_spec.rb' - - 'spec/models/protected_branch/merge_access_level_spec.rb' - - 'spec/models/protected_branch/push_access_level_spec.rb' - 'spec/models/protected_tag_spec.rb' - 'spec/models/push_event_payload_spec.rb' - 'spec/models/push_event_spec.rb' @@ -5364,14 +5066,11 @@ RSpec/MissingFeatureCategory: - 'spec/models/synthetic_note_spec.rb' - 'spec/models/system_note_metadata_spec.rb' - 'spec/models/term_agreement_spec.rb' - - 'spec/models/terraform/state_spec.rb' - - 'spec/models/terraform/state_version_spec.rb' - 'spec/models/time_tracking/timelog_category_spec.rb' - 'spec/models/todo_spec.rb' - 'spec/models/token_with_iv_spec.rb' - 'spec/models/tree_spec.rb' - 'spec/models/trending_project_spec.rb' - - 'spec/models/u2f_registration_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/uploads/fog_spec.rb' - 'spec/models/uploads/local_spec.rb' @@ -5385,7 +5084,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/user_mentions/issue_user_mention_spec.rb' - 'spec/models/user_mentions/merge_request_user_mention_spec.rb' - 'spec/models/user_mentions/snippet_user_mention_spec.rb' - - 'spec/models/user_preference_spec.rb' - 'spec/models/user_status_spec.rb' - 'spec/models/users/banned_user_spec.rb' - 'spec/models/users/callout_spec.rb' @@ -5456,7 +5154,6 @@ RSpec/MissingFeatureCategory: - 'spec/policies/metrics/dashboard/annotation_policy_spec.rb' - 'spec/policies/namespace/root_storage_statistics_policy_spec.rb' - 'spec/policies/namespaces/project_namespace_policy_spec.rb' - - 'spec/policies/namespaces/user_namespace_policy_spec.rb' - 'spec/policies/packages/package_policy_spec.rb' - 'spec/policies/packages/policies/group_policy_spec.rb' - 'spec/policies/packages/policies/project_policy_spec.rb' @@ -5486,7 +5183,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/ci/build_runner_presenter_spec.rb' - 'spec/presenters/ci/group_variable_presenter_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb' - - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/ci/stage_presenter_spec.rb' - 'spec/presenters/ci/trigger_presenter_spec.rb' @@ -5511,7 +5207,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/helm/index_presenter_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_versions_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' @@ -5537,7 +5232,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/user_presenter_spec.rb' - 'spec/presenters/web_hook_log_presenter_spec.rb' - 'spec/rack_servers/puma_spec.rb' - - 'spec/requests/api/admin/ci/variables_spec.rb' - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_create_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb' @@ -5549,7 +5243,6 @@ RSpec/MissingFeatureCategory: - 'spec/routing/environments_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' - - 'spec/routing/import_routing_spec.rb' - 'spec/routing/notifications_routing_spec.rb' - 'spec/routing/openid_connect_spec.rb' - 'spec/routing/project_routing_spec.rb' @@ -5591,7 +5284,6 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/gitlab/change_timezone_spec.rb' - 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb' - 'spec/rubocop/cop/gitlab/delegate_predicate_methods_spec.rb' - - 'spec/rubocop/cop/gitlab/deprecate_track_redis_hll_event_spec.rb' - 'spec/rubocop/cop/gitlab/event_store_subscriber_spec.rb' - 'spec/rubocop/cop/gitlab/except_spec.rb' - 'spec/rubocop/cop/gitlab/feature_available_usage_spec.rb' @@ -5681,17 +5373,14 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/rubocop/cop/rspec/factory_bot/strategy_in_callback_spec.rb' - 'spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb' - - 'spec/rubocop/cop/rspec/htt_party_basic_auth_spec.rb' - 'spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb' - 'spec/rubocop/cop/rspec/top_level_describe_path_spec.rb' - 'spec/rubocop/cop/rspec/web_mock_enable_spec.rb' - - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/rubocop/cop/safe_params_spec.rb' - 'spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb' - 'spec/rubocop/cop/scalability/cron_worker_context_spec.rb' - 'spec/rubocop/cop/scalability/idempotent_worker_spec.rb' - 'spec/rubocop/cop/sidekiq_api_usage_spec.rb' - - 'spec/rubocop/cop/sidekiq_load_balancing/worker_data_consistency_spec.rb' - 'spec/rubocop/cop/sidekiq_options_queue_spec.rb' - 'spec/rubocop/cop/sidekiq_redis_call_spec.rb' - 'spec/rubocop/cop/static_translation_definition_spec.rb' @@ -5731,7 +5420,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/build_artifact_entity_spec.rb' - 'spec/serializers/build_details_entity_spec.rb' - 'spec/serializers/build_trace_entity_spec.rb' - - 'spec/serializers/ci/codequality_mr_diff_entity_spec.rb' - 'spec/serializers/ci/codequality_mr_diff_report_serializer_spec.rb' - 'spec/serializers/ci/dag_job_entity_spec.rb' - 'spec/serializers/ci/dag_job_group_entity_spec.rb' @@ -5813,7 +5501,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/impersonation_access_token_serializer_spec.rb' - 'spec/serializers/import/bitbucket_provider_repo_entity_spec.rb' - 'spec/serializers/import/bitbucket_server_provider_repo_entity_spec.rb' - - 'spec/serializers/import/bulk_import_entity_spec.rb' - 'spec/serializers/import/fogbugz_provider_repo_entity_spec.rb' - 'spec/serializers/import/github_org_entity_spec.rb' - 'spec/serializers/import/github_org_serializer_spec.rb' @@ -5850,7 +5537,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/serializers/merge_request_for_pipeline_entity_spec.rb' - 'spec/serializers/merge_request_metrics_helper_spec.rb' - - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - 'spec/serializers/merge_request_sidebar_basic_entity_spec.rb' @@ -5915,7 +5601,6 @@ RSpec/MissingFeatureCategory: - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/helpers/graphql_helpers_spec.rb' - 'spec/support_specs/helpers/html_escaped_helpers_spec.rb' - - 'spec/support_specs/helpers/migrations_helpers_spec.rb' - 'spec/support_specs/helpers/redis_commands/recorder_spec.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' - 'spec/support_specs/helpers/stub_method_calls_spec.rb' @@ -5927,7 +5612,6 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/check_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/background_migrations_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/container_registry_rake_spec.rb' - 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb' @@ -5943,7 +5627,6 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/gitlab/pages_rake_spec.rb' - 'spec/tasks/gitlab/password_rake_spec.rb' - 'spec/tasks/gitlab/praefect_rake_spec.rb' - - 'spec/tasks/gitlab/refresh_project_statistics_build_artifacts_size_rake_spec.rb' - 'spec/tasks/gitlab/setup_rake_spec.rb' - 'spec/tasks/gitlab/shell_rake_spec.rb' - 'spec/tasks/gitlab/sidekiq_rake_spec.rb' @@ -5963,7 +5646,7 @@ RSpec/MissingFeatureCategory: - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/product_intelligence_spec.rb' + - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/docs/deprecation_handling_spec.rb' @@ -6000,7 +5683,6 @@ RSpec/MissingFeatureCategory: - 'spec/uploaders/metric_image_uploader_spec.rb' - 'spec/uploaders/namespace_file_uploader_spec.rb' - 'spec/uploaders/object_storage/cdn/google_ip_cache_spec.rb' - - 'spec/uploaders/object_storage_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'spec/uploaders/packages/debian/component_file_uploader_spec.rb' - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb' @@ -6066,7 +5748,6 @@ RSpec/MissingFeatureCategory: - 'spec/views/events/event/_common.html.haml_spec.rb' - 'spec/views/events/event/_push.html.haml_spec.rb' - 'spec/views/groups/_home_panel.html.haml_spec.rb' - - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/groups/milestones/index.html.haml_spec.rb' - 'spec/views/groups/new.html.haml_spec.rb' - 'spec/views/groups/observability/observability.html.haml_spec.rb' @@ -6080,13 +5761,10 @@ RSpec/MissingFeatureCategory: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/devise_empty.html.haml_spec.rb' - 'spec/views/layouts/fullscreen.html.haml_spec.rb' - 'spec/views/layouts/header/_gitlab_version.html.haml_spec.rb' - - 'spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_profile.html.haml_spec.rb' - 'spec/views/layouts/profile.html.haml_spec.rb' @@ -6164,7 +5842,6 @@ RSpec/MissingFeatureCategory: - 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb' - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/projects/_project.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb' - 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 708543510a..ddb9f70c3b 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -5,7 +5,6 @@ RSpec/MultipleMemoizedHelpers: - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' @@ -15,7 +14,6 @@ RSpec/MultipleMemoizedHelpers: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - 'spec/finders/user_recent_events_finder_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/milestone_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index e34ea087ed..d5b3ad81d0 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -1,7 +1,6 @@ --- RSpec/RepeatedExampleGroupDescription: Exclude: - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' @@ -90,7 +89,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 2b39bcbcd0..da4c41e2f6 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -15,7 +15,6 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' @@ -75,7 +74,6 @@ RSpec/ReturnFromStub: - 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb' - 'ee/spec/workers/post_receive_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/feature_flag_spec.rb' @@ -112,7 +110,6 @@ RSpec/ReturnFromStub: - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' - 'spec/graphql/types/project_type_spec.rb' - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/dashboard_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/explore_helper_spec.rb' @@ -134,7 +131,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/policy/changes_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb' @@ -166,7 +162,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/redis/shared_state_spec.rb' - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executed_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 8e3a2895d0..573991418f 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -125,7 +125,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' diff --git a/.rubocop_todo/rspec/shared_groups_metadata.yml b/.rubocop_todo/rspec/shared_groups_metadata.yml index b87c851d2f..ddac8bf658 100644 --- a/.rubocop_todo/rspec/shared_groups_metadata.yml +++ b/.rubocop_todo/rspec/shared_groups_metadata.yml @@ -2,7 +2,5 @@ RSpec/SharedGroupsMetadata: Details: grace period Exclude: - - 'ee/spec/requests/ee/admin/plan_limits_controller_spec.rb' - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' - - 'spec/models/container_repository_spec.rb' diff --git a/.rubocop_todo/rspec/variable_name.yml b/.rubocop_todo/rspec/variable_name.yml deleted file mode 100644 index 8858fbd9eb..0000000000 --- a/.rubocop_todo/rspec/variable_name.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -RSpec/VariableName: - Exclude: - - 'spec/models/user_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 6c7653fe0c..88b6f302e5 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -31,7 +31,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' - 'ee/spec/helpers/kerberos_helper_spec.rb' - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' @@ -169,7 +168,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' - 'ee/spec/services/status_page/publish_service_spec.rb' - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' @@ -210,7 +208,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/workers/ldap_group_sync_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/base_spec.rb' - 'qa/spec/page/validator_spec.rb' @@ -376,7 +373,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/background_migration/base_job_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' @@ -617,7 +613,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/config_map_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' - 'spec/lib/gitlab/lazy_spec.rb' - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' @@ -672,16 +667,12 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/performance_bar/stats_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/polling_interval_spec.rb' - 'spec/lib/gitlab/popen/runner_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/query_limiting/middleware_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' @@ -748,7 +739,6 @@ RSpec/VerifiedDoubles: - 'spec/models/ci/commit_with_pipeline_spec.rb' - 'spec/models/ci/group_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' @@ -1011,7 +1001,6 @@ RSpec/VerifiedDoubles: - 'spec/workers/bulk_imports/export_request_worker_spec.rb' - 'spec/workers/chat_notification_worker_spec.rb' - 'spec/workers/ci/build_prepare_worker_spec.rb' - - 'spec/workers/ci/create_cross_project_pipeline_worker_spec.rb' - 'spec/workers/ci/create_downstream_pipeline_worker_spec.rb' - 'spec/workers/ci/pipeline_bridge_status_worker_spec.rb' - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' diff --git a/.rubocop_todo/search/namespaced_class.yml b/.rubocop_todo/search/namespaced_class.yml index 10e8498f55..ad27603ad4 100644 --- a/.rubocop_todo/search/namespaced_class.yml +++ b/.rubocop_todo/search/namespaced_class.yml @@ -50,8 +50,6 @@ Search/NamespacedClass: - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/elastic/process_initial_bookkeeping_service.rb' - - 'ee/app/services/integrations/slack_options/label_search_handler.rb' - - 'ee/app/services/integrations/slack_options/user_search_handler.rb' - 'ee/app/services/protected_environments/search_service.rb' - 'ee/app/workers/concerns/elastic/bulk_cron_worker.rb' - 'ee/app/workers/concerns/elastic/indexing_control.rb' @@ -76,6 +74,7 @@ Search/NamespacedClass: - 'ee/app/workers/elastic_namespace_indexer_worker.rb' - 'ee/app/workers/elastic_namespace_rollout_worker.rb' - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' - 'ee/app/workers/zoekt/indexer_worker.rb' - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' - 'ee/lib/ee/api/helpers/search_helpers.rb' @@ -120,6 +119,7 @@ Search/NamespacedClass: - 'ee/lib/elastic/latest/user_class_proxy.rb' - 'ee/lib/elastic/latest/user_config.rb' - 'ee/lib/elastic/latest/user_instance_proxy.rb' + - 'ee/lib/elastic/latest/wiki_config.rb' - 'ee/lib/elastic/metrics_update_service.rb' - 'ee/lib/elastic/migration.rb' - 'ee/lib/elastic/multi_version_class_proxy.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index efd7db7ad2..a7311c1c6d 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -92,7 +92,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'app/workers/dependency_proxy/cleanup_dependency_proxy_worker.rb' - 'app/workers/dependency_proxy/cleanup_manifest_worker.rb' - 'app/workers/dependency_proxy/image_ttl_group_policy_worker.rb' - - 'app/workers/deployments/drop_older_deployments_worker.rb' - 'app/workers/deployments/link_merge_request_worker.rb' - 'app/workers/deployments/update_environment_worker.rb' - 'app/workers/design_management/copy_design_collection_worker.rb' @@ -135,7 +134,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'app/workers/gitlab/jira_import/advance_stage_worker.rb' - 'app/workers/gitlab/jira_import/import_issue_worker.rb' - 'app/workers/gitlab/jira_import/stage/start_import_worker.rb' - - 'app/workers/gitlab/phabricator_import/import_tasks_worker.rb' - 'app/workers/gitlab_performance_bar_stats_worker.rb' - 'app/workers/gitlab_service_ping_worker.rb' - 'app/workers/gitlab_shell_worker.rb' @@ -272,8 +270,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'app/workers/run_pipeline_schedule_worker.rb' - 'app/workers/schedule_merge_request_cleanup_refs_worker.rb' - 'app/workers/schedule_migrate_external_diffs_worker.rb' - - 'app/workers/self_monitoring_project_create_worker.rb' - - 'app/workers/self_monitoring_project_delete_worker.rb' - 'app/workers/service_desk_email_receiver_worker.rb' - 'app/workers/snippets/schedule_bulk_repository_shard_moves_worker.rb' - 'app/workers/ssh_keys/expired_notification_worker.rb' @@ -354,6 +350,7 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'ee/app/workers/elastic_namespace_indexer_worker.rb' - 'ee/app/workers/elastic_namespace_rollout_worker.rb' - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' - 'ee/app/workers/emails/abandoned_trial_emails_cron_worker.rb' - 'ee/app/workers/epics/new_epic_issue_worker.rb' - 'ee/app/workers/epics/update_cached_metadata_worker.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 4485a5df95..4257adbdc6 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -90,7 +90,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/import/history_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/import/phabricator_controller.rb' - 'app/controllers/import/url_controller.rb' - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/jira_connect/application_controller.rb' @@ -99,7 +98,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/jira_connect/installations_controller.rb' - 'app/controllers/jira_connect/oauth_callbacks_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - - 'app/controllers/jira_connect/users_controller.rb' - 'app/controllers/ldap/omniauth_callbacks_controller.rb' - 'app/controllers/oauth/applications_controller.rb' - 'app/controllers/oauth/authorizations_controller.rb' @@ -121,7 +119,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/profiles/personal_access_tokens_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/profiles/u2f_registrations_controller.rb' - 'app/controllers/profiles/webauthn_registrations_controller.rb' - 'app/controllers/projects/alert_management_controller.rb' - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb' @@ -368,7 +365,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/admin/subscriptions_controller.rb' - 'ee/app/controllers/admin/user_permission_exports_controller.rb' - - 'ee/app/controllers/concerns/registrations/verification.rb' - 'ee/app/controllers/ee/profiles/accounts_controller.rb' - 'ee/app/controllers/ee/profiles/preferences_controller.rb' - 'ee/app/controllers/ee/projects/analytics/cycle_analytics/summary_controller.rb' @@ -434,7 +430,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - 'ee/app/finders/ee/group_members_finder.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/coverage/corpus/create.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/security_orchestration_helper.rb' - 'ee/app/helpers/groups/ldap_sync_helper.rb' @@ -504,15 +499,11 @@ Style/ClassAndModuleChildren: - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/records_fetcher.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/ee/gitlab/throttle.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'lib/api/error_tracking/client_keys.rb' - 'lib/api/error_tracking/collector.rb' - 'lib/api/error_tracking/project_settings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/badge/base.rb' - 'lib/gitlab/ci/badge/coverage/metadata.rb' @@ -538,7 +529,6 @@ Style/ClassAndModuleChildren: - 'lib/gitlab/ci/warnings.rb' - 'lib/gitlab/config_helper.rb' - 'lib/gitlab/instrumentation/elasticsearch_transport.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/usage_data_counters/cycle_analytics_counter.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index 87b170297a..e2074f4f2e 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -2,54 +2,27 @@ # Cop supports --autocorrect. Style/EmptyElse: Exclude: - - 'app/controllers/concerns/issuable_collections_action.rb' - 'app/controllers/concerns/sends_blob.rb' - 'app/controllers/google_api/authorizations_controller.rb' - - 'app/controllers/projects_controller.rb' - 'app/finders/group_finder.rb' - - 'app/finders/merge_requests_finder/params.rb' - - 'app/finders/snippets_finder.rb' - - 'app/graphql/mutations/concerns/mutations/spam_protection.rb' - 'app/graphql/resolvers/group_milestones_resolver.rb' - 'app/graphql/types/ci/detailed_status_type.rb' - - 'app/graphql/types/packages/package_base_type.rb' - - 'app/graphql/types/packages/package_file_type.rb' - - 'app/helpers/submodule_helper.rb' - - 'app/models/commit.rb' - 'app/models/legacy_diff_discussion.rb' - - 'app/models/note.rb' - 'app/models/performance_monitoring/prometheus_dashboard.rb' - - 'app/models/repository.rb' - 'app/models/resource_state_event.rb' - 'app/models/resource_timebox_event.rb' - 'app/services/award_emojis/add_service.rb' - - 'app/services/merge_requests/update_service.rb' - 'app/workers/post_receive.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' - - 'ee/app/controllers/ee/groups_controller.rb' - 'ee/app/helpers/ee/kerberos_helper.rb' - - 'ee/app/models/ee/audit_event.rb' - - 'ee/app/services/ee/users/update_service.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb' - - 'ee/lib/gitlab/geo/oauth/logout_token.rb' - - 'lib/api/subscriptions.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' - 'lib/gitlab/database/sha256_attribute.rb' - - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/git.rb' - - 'lib/gitlab/git/ref.rb' - - 'lib/gitlab/git/tag.rb' - - 'lib/gitlab/pagination/keyset/paginator.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - - 'lib/gitlab/x509/signature.rb' - 'lib/peek/views/external_http.rb' - - 'qa/qa/support/loglinking.rb' - - 'spec/support/helpers/api_internal_base_helpers.rb' - - 'spec/support/shared_examples/requests/api/snippets_shared_examples.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index dd55c4f45c..adf3e8ee9b 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -4,7 +4,6 @@ Style/EmptyMethod: Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/deploy_keys_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/labels_controller.rb' @@ -21,7 +20,6 @@ Style/EmptyMethod: - 'app/controllers/import/bitbucket_server_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/import/phabricator_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' - 'app/controllers/profiles/passwords_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' @@ -70,8 +68,6 @@ Style/EmptyMethod: - 'app/services/issuable_base_service.rb' - 'app/services/projects/transfer_service.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - - 'db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' @@ -113,16 +109,12 @@ Style/EmptyMethod: - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/ci/config/entry/need.rb' - 'lib/gitlab/ci/config/entry/rules/rule.rb' - 'lib/gitlab/ci/limit.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 591c228f18..5027e699ae 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -6,7 +6,6 @@ Style/ExplicitBlockArgument: - 'app/controllers/admin/batched_jobs_controller.rb' - 'app/controllers/application_controller.rb' - 'app/models/application_record.rb' - - 'app/models/broadcast_message.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunks/redis.rb' - 'app/models/ci/build_trace_chunks/redis_trace_chunks.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index fc74f8fe07..9d202dcd7f 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -109,7 +109,6 @@ Style/FormatString: - 'app/models/project.rb' - 'app/models/resource_event.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/domain.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' @@ -216,7 +215,6 @@ Style/FormatString: - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/vulnerabilities/destroy_dismissal_feedback_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' @@ -267,7 +265,6 @@ Style/FormatString: - 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/in_product_marketing/create.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' @@ -305,7 +302,6 @@ Style/FormatString: - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/groups/import_export/connect_instance_spec.rb' - 'spec/features/issues/form_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/lib/api/entities/release_spec.rb' @@ -314,7 +310,6 @@ Style/FormatString: - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/datadog_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 3c123b2595..50a823c9ee 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -260,10 +260,6 @@ Style/GuardClause: - 'config/initializers/postgresql_cte.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - - 'db/migrate/20210830140524_add_state_to_member.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/replicables_controller.rb' @@ -432,7 +428,6 @@ Style/GuardClause: - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/support/ci/minutes_helpers.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' - 'lib/api/error_tracking/collector.rb' @@ -533,8 +528,6 @@ Style/GuardClause: - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/object_counter.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' @@ -579,7 +572,6 @@ Style/GuardClause: - 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb' - 'lib/gitlab/search/params.rb' - 'lib/gitlab/serializer/pagination.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index 859061d657..d7032af880 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -45,7 +45,6 @@ Style/HashAsLastArrayItem: - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - - 'spec/migrations/20210914095310_cleanup_orphan_project_access_tokens_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index a4bd4a1885..78e2795178 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -112,7 +112,6 @@ Style/IfUnlessModifier: - 'app/models/ability.rb' - 'app/models/appearance.rb' - 'app/models/application_setting_implementation.rb' - - 'app/models/broadcast_message.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/ci/application_record.rb' - 'app/models/ci/build.rb' @@ -386,11 +385,7 @@ Style/IfUnlessModifier: - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - 'db/migrate/20220324175325_add_key_data_to_secure_files.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -553,7 +548,6 @@ Style/IfUnlessModifier: - 'ee/app/services/security/security_orchestration_policies/process_policy_service.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - - 'ee/app/services/slash_commands/global_slack_handler.rb' - 'ee/app/services/start_pull_mirroring_service.rb' - 'ee/app/services/system_notes/epics_service.rb' - 'ee/app/services/timebox_report_service.rb' @@ -749,12 +743,8 @@ Style/IfUnlessModifier: - 'lib/gitlab/auth/ldap/authentication.rb' - 'lib/gitlab/authorized_keys.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - - 'lib/gitlab/bare_repository_import/repository.rb' - 'lib/gitlab/bullet/exclusions.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/changelog/config.rb' @@ -860,8 +850,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/representation/issue.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/graphql/queries.rb' @@ -876,7 +864,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - - 'lib/gitlab/import_export/json/legacy_writer.rb' - 'lib/gitlab/import_export/merge_request_parser.rb' - 'lib/gitlab/import_export/project/export_task.rb' - 'lib/gitlab/import_export/project/relation_factory.rb' @@ -1004,7 +991,6 @@ Style/IfUnlessModifier: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' - 'spec/factories/labels.rb' @@ -1021,7 +1007,6 @@ Style/IfUnlessModifier: - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' @@ -1056,7 +1041,7 @@ Style/IfUnlessModifier: - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' - 'spec/support/external_authorization_service_helpers.rb' - - 'spec/support/flaky_tests.rb' + - 'spec/support/fast_quarantine.rb' - 'spec/support/generate-seed-repo-rb' - 'spec/support/helpers/filter_spec_helper.rb' - 'spec/support/helpers/filtered_search_helpers.rb' @@ -1089,7 +1074,7 @@ Style/IfUnlessModifier: - 'spec/support/webmock.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 3730a86221..e4b751a92d 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -8,7 +8,6 @@ Style/KeywordParametersOrder: - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/insights/executors/dora_executor.rb' - 'ee/lib/gitlab/insights/executors/issuable_executor.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' - 'lib/gitlab/background_migration/batched_migration_job.rb' - 'lib/gitlab/checks/timed_logger.rb' diff --git a/.rubocop_todo/style/numbered_parameters.yml b/.rubocop_todo/style/numbered_parameters.yml index 3251cc0bca..fc08515bc2 100644 --- a/.rubocop_todo/style/numbered_parameters.yml +++ b/.rubocop_todo/style/numbered_parameters.yml @@ -25,7 +25,6 @@ Style/NumberedParameters: - 'app/services/web_hooks/log_execution_service.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/security/finding.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/services/security/ingestion/tasks/hooks_execution.rb' - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' @@ -77,7 +76,6 @@ Style/NumberedParameters: - 'spec/services/web_hook_service_spec.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/lib/sbom/package_url_shared_contexts.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 44f9ab098a..441e4389aa 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -6,14 +6,11 @@ Style/NumericLiteralPrefix: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'config/initializers/01_secret_token.rb' - 'config/initializers/1_settings.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/ee/group_spec.rb' @@ -21,7 +18,6 @@ Style/NumericLiteralPrefix: - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - 'lib/backup/files.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/jwt_authenticatable.rb' - 'lib/system_check/app/uploads_path_permission_check.rb' @@ -32,7 +28,6 @@ Style/NumericLiteralPrefix: - 'qa/qa/support/ssh.rb' - 'qa/spec/support/ssh_spec.rb' - 'scripts/security-harness' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 31195e54f7..496f05c7ca 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -173,9 +173,6 @@ Style/PercentLiteralDelimiters: - 'config/initializers_before_autoloader/000_inflections.rb' - 'config/object_store_settings.rb' - 'config/spring.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' @@ -238,7 +235,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/api/search.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' @@ -460,7 +456,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/auth/ldap/adapter.rb' - 'lib/gitlab/auth/ldap/config.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/config/entry/bridge.rb' - 'lib/gitlab/ci/reports/codequality_reports.rb' @@ -495,7 +490,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/jira_import/metadata_collector.rb' - 'lib/gitlab/kas.rb' - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/logger.rb' - 'lib/gitlab/lograge/custom_options.rb' @@ -599,7 +593,6 @@ Style/PercentLiteralDelimiters: - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/clusters/clusters.rb' - 'spec/factories/clusters/integrations/prometheus.rb' - 'spec/factories/clusters/providers/aws.rb' @@ -710,7 +703,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/cache_spec.rb' @@ -795,7 +787,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_writer_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' @@ -871,7 +862,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/system_check/orphans/namespace_check_spec.rb' - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/system_check/sidekiq_check_spec.rb' - - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' @@ -1117,7 +1107,6 @@ Style/PercentLiteralDelimiters: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/projects/commit/branches.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/concerns/worker_context_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml deleted file mode 100644 index 8f490002fd..0000000000 --- a/.rubocop_todo/style/redundant_begin.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantBegin: - Exclude: - - 'app/controllers/concerns/metrics_dashboard.rb' - - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 3a0f099fd2..b65fe11a9b 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -42,8 +42,6 @@ Style/RedundantFreeze: - 'app/models/packages/debian/file_entry.rb' - 'app/models/personal_access_token.rb' - 'app/models/releases/link.rb' - - 'app/models/serverless/domain.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/snippet_repository.rb' - 'app/models/terraform/state.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' @@ -112,7 +110,6 @@ Style/RedundantFreeze: - 'lib/gitaly/server.rb' - 'lib/gitlab.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/changelog/generator.rb' - 'lib/gitlab/ci/build/artifacts/metadata.rb' @@ -154,7 +151,6 @@ Style/RedundantFreeze: - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - 'lib/gitlab/email/handler/create_note_on_issuable_handler.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/hook/validate_addresses_interceptor.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - 'lib/gitlab/front_matter.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 5335915271..3168a5d215 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -18,7 +18,6 @@ Style/RedundantSelf: - 'app/models/ci/stage.rb' - 'app/models/ci/trigger.rb' - 'app/models/ci_platform_metric.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/concerns/application_status.rb' @@ -132,7 +131,6 @@ Style/RedundantSelf: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/function.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet.rb' - 'app/models/terraform/state.rb' @@ -169,7 +167,6 @@ Style/RedundantSelf: - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_project_rule.rb' @@ -230,8 +227,6 @@ Style/RedundantSelf: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/database.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/legacy_model.rb' @@ -279,10 +274,8 @@ Style/RedundantSelf: - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/auth/result.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/job_coordinator.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/parser.rb' @@ -405,4 +398,3 @@ Style/RedundantSelf: - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/support/before_all_adapter.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 8d35373a2c..d41dc0add0 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -47,7 +47,6 @@ Style/SingleArgumentDig: - 'lib/gitlab/config/entry/simplifiable.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/database/transaction/observer.rb' - - 'lib/gitlab/serverless/service.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/vendor/mail_hog/api.rb' - 'spec/controllers/graphql_controller_spec.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 8209781e78..9403b13e1b 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -17,7 +17,6 @@ Style/StringConcatenation: - 'app/models/pool_repository.rb' - 'app/models/project_wiki.rb' - 'app/models/repository.rb' - - 'app/models/serverless/function.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' - 'app/presenters/snippet_blob_presenter.rb' @@ -91,7 +90,6 @@ Style/StringConcatenation: - 'lib/feature/definition.rb' - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - 'lib/gitlab/ci/status/build/retried.rb' - 'lib/gitlab/config/entry/validators.rb' @@ -183,8 +181,6 @@ Style/StringConcatenation: - 'spec/lib/container_registry/tag_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' - 'spec/lib/gitlab/ci/config/entry/artifacts_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 7273161aef..ceb6a92227 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -8,7 +8,6 @@ Style/StringLiteralsInInterpolation: - 'app/models/ci/namespace_mirror.rb' - 'app/models/integrations/campfire.rb' - 'app/models/integrations/jira.rb' - - 'app/models/serverless/domain.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' - 'app/validators/nested_attributes_duplicates_validator.rb' @@ -53,7 +52,6 @@ Style/StringLiteralsInInterpolation: - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' @@ -61,7 +59,6 @@ Style/StringLiteralsInInterpolation: - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/keys_spec.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/views/notify/import_issues_csv_email.html.haml_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index b6d0de8ef5..0e4602f9f3 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -66,7 +66,6 @@ Style/SymbolProc: - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - 'config/settings.rb' - - 'db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb' - 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' @@ -96,9 +95,6 @@ Style/SymbolProc: - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -132,8 +128,6 @@ Style/SymbolProc: - 'lib/container_registry/gitlab_api_client.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' diff --git a/CHANGELOG.md b/CHANGELOG.md index 722a2406cd..a34362da52 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,95 +2,863 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. -## 15.11.11 (2023-07-04) +## 16.0.7 (2023-07-04) ### Security (1 change) -- [Add authorization to the subscriptions group controller](gitlab-org/security/gitlab@a6cb78e56a0e6b08ee7bbabd1687fb43a9f8703b) ([merge request](gitlab-org/security/gitlab!3381)) +- [Add authorization to the subscriptions group controller](gitlab-org/security/gitlab@07fa510bd2a18c0c0c35503f2fd9dd421d2b4049) ([merge request](gitlab-org/security/gitlab!3380)) -## 15.11.10 (2023-06-28) +## 16.0.6 (2023-06-28) -### Security (10 changes) +### Security (12 changes) -- [Revert 'security-leaked-ci-job-token-permission-15-11' from '15-11'"](gitlab-org/security/gitlab@19f73bf5494d34b43eb8c807f860d545acae0c32) ([merge request](gitlab-org/security/gitlab!3375)) -- [Use fully qualified ref when loading code owner file](gitlab-org/security/gitlab@d7ffb4cca68373bff38bd05f0b8afc868cda9e04) ([merge request](gitlab-org/security/gitlab!3354)) -- [Maintainer can leak masked webhook secrets by manipulating URL masking](gitlab-org/security/gitlab@3a7ccdac5e41870fdce362c38d0a1d1437906fbd) ([merge request](gitlab-org/security/gitlab!3361)) -- [Remove approvals when the only commit gets amended](gitlab-org/security/gitlab@f8a4ad8be7e5fdf752f525ed58b94b1ce625b9a1) ([merge request](gitlab-org/security/gitlab!3368)) -- [Fix for fork permissions check in compare controller](gitlab-org/security/gitlab@8edf44b13e55ffe0c912f98134d0341a5a6bcd28) ([merge request](gitlab-org/security/gitlab!3344)) -- [Webhook token leaked in Sidekiq logs if log format is 'default'](gitlab-org/security/gitlab@02b58237085930c62ee277c9ebd89a0560f44a98) ([merge request](gitlab-org/security/gitlab!3347)) -- [Mitigate epic reference filter ReDOS](gitlab-org/security/gitlab@4c2cd6e5f7c994aca554be37d9ea9e5e114341f1) ([merge request](gitlab-org/security/gitlab!3339)) -- [Increasing security for CI_JOB_TOKEN on public and internal projects](gitlab-org/security/gitlab@4f8a00b2499e876df5b65eca921812fbb3215800) ([merge request](gitlab-org/security/gitlab!3319)) -- [Sanitize user email addresses in admin confirm user dialog](gitlab-org/security/gitlab@608c8001c349b0a62aae81850de669d3af02ab60) ([merge request](gitlab-org/security/gitlab!3332)) -- [Obfuscate email of service desk issue creator in issue REST API](gitlab-org/security/gitlab@a092ebc54cce4492f87f8ed2bf67c31793b0bd0e) ([merge request](gitlab-org/security/gitlab!3316)) +- [Revert 'security-leaked-ci-job-token-permission-16-0' from '16-0'"](gitlab-org/security/gitlab@3c4fdbad26a123c581253fb501b5bace953a5e85) ([merge request](gitlab-org/security/gitlab!3373)) +- [Use fully qualified ref when loading code owner file](gitlab-org/security/gitlab@69c61fcbdc88873b60a217cfd3810364718417e9) ([merge request](gitlab-org/security/gitlab!3355)) +- [Maintainer can leak masked webhook secrets by manipulating URL masking](gitlab-org/security/gitlab@a3e055010523db5a1c346464e2589cc75f73629d) ([merge request](gitlab-org/security/gitlab!3360)) +- [Remove approvals when the only commit gets amended](gitlab-org/security/gitlab@01e59413e2570744dc34dd50efd2601dc91c8d2d) ([merge request](gitlab-org/security/gitlab!3367)) +- [Add authorization validation to GithubController#failures action](gitlab-org/security/gitlab@9eab0689991debab8c8a1afb9e32a3bac9978325) ([merge request](gitlab-org/security/gitlab!3334)) +- [Fix for fork permissions check in compare controller](gitlab-org/security/gitlab@da9bb4c761dfe7e8efdd910ed3fc89f348e47e90) ([merge request](gitlab-org/security/gitlab!3343)) +- [Webhook token leaked in Sidekiq logs if log format is 'default'](gitlab-org/security/gitlab@a9835cb72eddfae1748c66314618b3157a6bcb57) ([merge request](gitlab-org/security/gitlab!3346)) +- [Mitigate epic reference filter ReDOS](gitlab-org/security/gitlab@c8046028a30fe9dca7e141eec2acf3d4b49d93ee) ([merge request](gitlab-org/security/gitlab!3340)) +- [Increasing security for CI_JOB_TOKEN on public and internal projects](gitlab-org/security/gitlab@b67db0cdd9324633f4abb59bc27bca43e94e3362) ([merge request](gitlab-org/security/gitlab!3318)) +- [Adjust access to value stream create, edit and destroy actions](gitlab-org/security/gitlab@ee20f3f3a84a75c7e07e1aa6fde95761636a669f) ([merge request](gitlab-org/security/gitlab!3321)) +- [Sanitize user email addresses in admin confirm user dialog](gitlab-org/security/gitlab@545e0913336e823eb905a8bd86fe2905b321a284) ([merge request](gitlab-org/security/gitlab!3331)) +- [Obfuscate email of service desk issue creator in issue REST API](gitlab-org/security/gitlab@b921f10b565bafbd6d50d93d84d34b5f103839ea) ([merge request](gitlab-org/security/gitlab!3315)) -## 15.11.9 (2023-06-15) +## 16.0.5 (2023-06-16) + +### Fixed (1 change) + +- [Update gitlab-elasticsearch-indexer version](gitlab-org/gitlab@d080c6c9af405b24e65e269ccb7b723cd5510940) ([merge request](gitlab-org/gitlab!122335)) ### Changed (1 change) -- [Make MigrateSharedVulnerabilityIdentifiers use slow iteration](gitlab-org/gitlab@1d91c7b295b22e844b81fb665748c447028525cd) ([merge request](gitlab-org/gitlab!122856)) **GitLab Enterprise Edition** +- [Make MigrateSharedVulnerabilityIdentifiers use slow iteration](gitlab-org/gitlab@252da7be42ec95a5d470c17f43209c27890a7e85) ([merge request](gitlab-org/gitlab!122859)) **GitLab Enterprise Edition** -## 15.11.8 (2023-06-06) +## 16.0.4 (2023-06-08) -### Fixed (2 changes) +### Fixed (1 change) -- [Fix memory leak in CI config includes entry](gitlab-org/gitlab@3e367e614c855352295e3bcab25bf5af4ec66bf5) ([merge request](gitlab-org/gitlab!122540)) -- [Fix serialization of pull_requests in Bitbucket Server Import](gitlab-org/gitlab@201ad93dfdf8f4acfb6d6eee32e2bd6a4ff68157) ([merge request](gitlab-org/gitlab!122396)) +- [Fix LDAP tls_options not working](gitlab-org/gitlab@e6038d0d4e8bb190ccfeca5fe7204d6a6af266e5) ([merge request](gitlab-org/gitlab!122797)) -### Security (1 change) +## 16.0.3 (2023-06-06) -- [Validate description length in labels](gitlab-org/gitlab@2c821ee0823e37a57a6dc049591097232c933713) ([merge request](gitlab-org/gitlab!122697)) +### Fixed (3 changes) + +- [Fix memory leak in CI config includes entry](gitlab-org/gitlab@1e42968f69e556d13b4765ccd685dd47c87c4493) ([merge request](gitlab-org/gitlab!122539)) +- [Fix MR approval rules sync when disabling scan result policy](gitlab-org/gitlab@d708d6e5ca85dbc806e76c320661ffc8c2ea694d) ([merge request](gitlab-org/gitlab!122466)) **GitLab Enterprise Edition** +- [Fix serialization of pull requests in BitbucketServer Import](gitlab-org/gitlab@8b3dce34122aa9a40921db7e957353f42750d3c5) ([merge request](gitlab-org/gitlab!122395)) ### Performance (1 change) -- [LFS: Serve pre-signed URLs in `/lfs/objects/batch`](gitlab-org/gitlab@df3a9655a0e8f0bdab3433cefcbd37acfb8ebcff) ([merge request](gitlab-org/gitlab!122348)) +- [LFS: Serve pre-signed URLs in `/lfs/objects/batch`](gitlab-org/gitlab@086ded4a9ed937e44b816a2ad835bb20d99e084e) ([merge request](gitlab-org/gitlab!122349)) -## 15.11.7 (2023-06-05) +## 16.0.2 (2023-06-05) + +### Fixed (1 change) + +- [Fix Sidekiq crash when gitlab.yml contains UTF-8 characters](gitlab-org/security/gitlab@bb3f94f25f14068e11ff242e00841ec6ad4952a5) + +### Changed (1 change) + +- [Introduce parallelised BitBucket Server Importer](gitlab-org/security/gitlab@6aa9cf0799d3fa30d7498a9d119dbfb52a839247) ### Security (16 changes) -- [Fix DoS on test report artifacts](gitlab-org/security/gitlab@76133e75ad38326bf971e2d913263349781aecbe) ([merge request](gitlab-org/security/gitlab!3200)) -- [Fix XSS in Abuse Reports form action](gitlab-org/security/gitlab@e9f9b656b34bb30a7bd66ce82a9d8f6ac43c1ba8) ([merge request](gitlab-org/security/gitlab!3290)) -- [Escape the source branch link correctly](gitlab-org/security/gitlab@77ed3e8c2ef51e7bcc89ad1c8c549424a69e3478) ([merge request](gitlab-org/security/gitlab!3288)) -- [Import source owners with maintainer access if importer is a maintainer](gitlab-org/security/gitlab@98f939c9ba3efd5e51807adbaee189f180131544) ([merge request](gitlab-org/security/gitlab!3283)) -- [Filter inaccessible issuable notes when exporting project](gitlab-org/security/gitlab@29fe6582dd81855cdb263e118459aba370a7c7eb) ([merge request](gitlab-org/security/gitlab!3274)) -- [Block tag names that are prepended with refs/tags/, due to conflicts](gitlab-org/security/gitlab@2b39d58eb21cf2ecc581bc5e1bd4dd48dcfd20bc) ([merge request](gitlab-org/security/gitlab!3262)) -- [Set IP in ActionContoller filter before IP enforcement is evaluated](gitlab-org/security/gitlab@8d6e83ff72564f3fa3b24e2040072024b715a073) ([merge request](gitlab-org/security/gitlab!3279)) -- [Prevent primary email returned as verified on unsaved change](gitlab-org/security/gitlab@8ac9a3e3efea62d9b3e6d758ab3f1c43f2354ea5) ([merge request](gitlab-org/security/gitlab!3223)) -- [Use UntrustedRegexp to protect FrontMatter filter](gitlab-org/security/gitlab@5d300c3af9c37a7607d795868ae2b4e51b8802c5) ([merge request](gitlab-org/security/gitlab!3257)) -- [Improve ambiguous_ref? logic to include heads and tags](gitlab-org/security/gitlab@f478b7673efd183971e9375be84ad06af641893f) ([merge request](gitlab-org/security/gitlab!3247)) -- [Use UntrustedRegexp to protect InlineDiff filter](gitlab-org/security/gitlab@4056d6ccc5b592029ea92ebb90b6e6a66c6eb157) ([merge request](gitlab-org/security/gitlab!3254)) -- [Ignore user-defined diff paths in diff notes](gitlab-org/security/gitlab@b21208f4c10e8bd4e6754f9bfd2cc5fc96c8be20) ([merge request](gitlab-org/security/gitlab!3267)) -- [Reject NPM metadata requests with invalid package_name](gitlab-org/security/gitlab@c4d0f6256bae18d9bb9f6afc87afeeb3ff971335) ([merge request](gitlab-org/security/gitlab!3285)) -- [Use UntrustedRegexp to protect MathFilter regex](gitlab-org/security/gitlab@fd8298b140dba65ac77ed340a5f78e1fc8032db6) ([merge request](gitlab-org/security/gitlab!3251)) -- [Resolve Overall Project Vulnerability Disclosure](gitlab-org/security/gitlab@199048eb1c61063409e25d3433e7276faf95709b) ([merge request](gitlab-org/security/gitlab!3230)) -- [Validate description length in labels](gitlab-org/security/gitlab@208342903aabd7c4b78c24c0b9b173dfbd62e405) ([merge request](gitlab-org/security/gitlab!3242)) +- [Fix DoS on test report artifacts](gitlab-org/security/gitlab@1058018d0f40165150742f2703e3feb0e0810799) ([merge request](gitlab-org/security/gitlab!3271)) +- [Fix XSS in Abuse Reports form action](gitlab-org/security/gitlab@c5ab6568c8d9d084876b8680394cfe18d6c58ba1) ([merge request](gitlab-org/security/gitlab!3289)) +- [Escape the source branch link correctly](gitlab-org/security/gitlab@40a3d27c0293190fb094216a8d7a193751e61acd) ([merge request](gitlab-org/security/gitlab!3286)) +- [Import source owners with maintainer access if importer is a maintainer](gitlab-org/security/gitlab@2d580f269e4285834f478df6601132f7cdc3130a) ([merge request](gitlab-org/security/gitlab!3282)) +- [Filter inaccessible issuable notes when exporting project](gitlab-org/security/gitlab@ca46e35908072748b5ae68d099acf46f8f667cfc) ([merge request](gitlab-org/security/gitlab!3275)) +- [Block tag names that are prepended with refs/tags/, due to conflicts](gitlab-org/security/gitlab@80e86cec6ea8a87c6b869eeeaa8c9a317f53d26d) ([merge request](gitlab-org/security/gitlab!3269)) +- [Set IP in ActionContoller filter before IP enforcement is evaluated](gitlab-org/security/gitlab@121f1270bed598cf1ca249fc5fd27c9806765421) ([merge request](gitlab-org/security/gitlab!3278)) +- [Prevent primary email returned as verified on unsaved change](gitlab-org/security/gitlab@506533fc3a1928361ea451dbb7a702da2912f16f) ([merge request](gitlab-org/security/gitlab!3259)) +- [Use UntrustedRegexp to protect FrontMatter filter](gitlab-org/security/gitlab@50e26a058850e907970ea12d94a72e8be4c6b296) ([merge request](gitlab-org/security/gitlab!3258)) +- [Improve ambiguous_ref? logic to include heads and tags](gitlab-org/security/gitlab@0d24382ab68543cafb08e88e25ff973cd7fbd17e) ([merge request](gitlab-org/security/gitlab!3294)) +- [Use UntrustedRegexp to protect InlineDiff filter](gitlab-org/security/gitlab@2dc1ecf6a4f89b43a6e75f07580ee4076d9073dc) ([merge request](gitlab-org/security/gitlab!3253)) +- [Ignore user-defined diff paths in diff notes](gitlab-org/security/gitlab@5f4dc756d0aa396e808d556d82e74a1832728b09) ([merge request](gitlab-org/security/gitlab!3266)) +- [Reject NPM metadata requests with invalid package_name](gitlab-org/security/gitlab@28e13218559dc1fe3e82400fe438d09d20f210c1) ([merge request](gitlab-org/security/gitlab!3281)) +- [Use UntrustedRegexp to protect MathFilter regex](gitlab-org/security/gitlab@d686081bc5a93b7e55bca0fde388bca7cc8d3626) ([merge request](gitlab-org/security/gitlab!3252)) +- [Resolve Overall Project Vulnerability Disclosure](gitlab-org/security/gitlab@0b2770814ad2f6c741b146c25025773678efbcb1) ([merge request](gitlab-org/security/gitlab!3270)) +- [Validate description length in labels](gitlab-org/security/gitlab@688225aba7e485de365b1ad914049acbc6bd07d2) ([merge request](gitlab-org/security/gitlab!3244)) -## 15.11.6 (2023-05-24) +## 16.0.1 (2023-05-22) -### Changed (1 change) +### Security (1 change) -- [Introduce parallelised BitBucket Server Importer](gitlab-org/gitlab@41fead2e5b8b8c61c269de902282e2aa75b967a5) ([merge request](gitlab-org/gitlab!121332)) +- [Fix arbitary file read via filename param](gitlab-org/security/gitlab@2ddbf5464954addce7b8c82102377f0f137b604f) ([merge request](gitlab-org/security/gitlab!3265)) -## 15.11.5 (2023-05-19) +## 16.0.0 (2023-05-18) -### Fixed (5 changes) +### Added (168 changes) -- [Makes roadmap current day indicator & timeline locale aware](gitlab-org/gitlab@2dc71e59e277d017118d77743d8658be5b05ddf3) ([merge request](gitlab-org/gitlab!121104)) **GitLab Enterprise Edition** -- [Fix height calculations with roadmap to prevent extra scrollers](gitlab-org/gitlab@58080e99cb0a551c41b557d5a0000d686c512fdf) ([merge request](gitlab-org/gitlab!120965)) **GitLab Enterprise Edition** -- [Update by_parent filter in EpicsFinder](gitlab-org/gitlab@97115082a328bc01d04abc651e3b54913a19832a) ([merge request](gitlab-org/gitlab!120966)) **GitLab Enterprise Edition** -- [Fix no_proxy not working when DNS rebinding protection enabled](gitlab-org/gitlab@84012b21559126cde51cfe341ebff44eda9b3d62) ([merge request](gitlab-org/gitlab!120809)) -- [Remove epic date fields authorization](gitlab-org/gitlab@5c36e497d1e43e4ccf05a0684c3388385b247e45) ([merge request](gitlab-org/gitlab!120290)) **GitLab Enterprise Edition** +- [Add X-GitLab-ConfidentialIssue: header boolean](gitlab-org/gitlab@e3594865e0b4b95914df2533613c6ac21384c7ed) by @micah ([merge request](gitlab-org/gitlab!101558)) +- [Adds CI information to candidate detail](gitlab-org/gitlab@7a2b5cbb51c8fda57c7fc7935df981c29bae500e) ([merge request](gitlab-org/gitlab!119733)) +- [Added pipelines shortcut](gitlab-org/gitlab@b93d0c5d72dcbd29207704c1800318fec7985fc0) by @AlexNewson ([merge request](gitlab-org/gitlab!119090)) +- [Add user deactivate service](gitlab-org/gitlab@d152ca26fb82f12867a5ec9a11d033118e068d7f) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117776)) **GitLab Enterprise Edition** +- [Updated code based on suggestion](gitlab-org/gitlab@7e0dab6d96b41ee07c157606d5d79ca5c55ef692) ([merge request](gitlab-org/gitlab!119497)) +- [feat: Add lock_version to milestone](gitlab-org/gitlab@9019b79935b04aeb5d605db11cce0a75bdaf65ca) by @gerardo-navarro ([merge request](gitlab-org/gitlab!119859)) +- [Enable import_details_page ff by default](gitlab-org/gitlab@0698522dc3e90a079741b1a57f857c4aeb6bd47c) ([merge request](gitlab-org/gitlab!120265)) +- [Add audit events schema definitions](gitlab-org/gitlab@fa7087bd21164a195fdca9e6d1463ade7fac16de) ([merge request](gitlab-org/gitlab!114991)) **GitLab Enterprise Edition** +- [Add specs for ApprovalProjectRule creation](gitlab-org/gitlab@4be4a12f8377f342ef890f7f5ec9071a8b3592dd) ([merge request](gitlab-org/gitlab!120362)) +- [Add environment tier to deployment webhooks](gitlab-org/gitlab@ca4a20056f62e79a5831c3390ee871f90899d7f1) ([merge request](gitlab-org/gitlab!120151)) +- [Add keyword to allow multiple cache fallback keys](gitlab-org/gitlab@3b795d64cd0cd82cddbba66d909680feb15e756b) by @renehernandez ([merge request](gitlab-org/gitlab!110467)) +- [Add emoji awards for work item](gitlab-org/gitlab@1ce458ee16d86aa0e760c7dfb32797db05bd2197) ([merge request](gitlab-org/gitlab!119585)) **GitLab Enterprise Edition** +- [GraphQL project fields for refs containing a commit](gitlab-org/gitlab@2fea8e046fcdd05ab6cebf7e11198e5b446995bc) ([merge request](gitlab-org/gitlab!116705)) +- [Make group-level git protocol control available](gitlab-org/gitlab@4f6f078c27f4f62e169097edbd30eaf7926f34eb) ([merge request](gitlab-org/gitlab!113360)) +- [[Audit Events] Asynchronous database index addition](gitlab-org/gitlab@ec1804b76ef4af2bd807f2f6a3cd9c2423d14fdc) ([merge request](gitlab-org/gitlab!120581)) **GitLab Enterprise Edition** +- [Show alert about any configured deploy freezes](gitlab-org/gitlab@40ccf5c48df47d07b2d72c3bfca6705063d26726) ([merge request](gitlab-org/gitlab!120351)) +- [Model and table for google cloud logging integration](gitlab-org/gitlab@98ece342bb378c4b971d8440f0a9990b6a15d0cf) ([merge request](gitlab-org/gitlab!119943)) +- [Add to do widget for work items](gitlab-org/gitlab@7dcd1687a054b299a3e9a8a6def44cd27e4006dc) ([merge request](gitlab-org/gitlab!118135)) **GitLab Enterprise Edition** +- [Add Zola template for .gitlab-ci.yml](gitlab-org/gitlab@cc7d8d2bc039d2cadf2dea71eea7b875649fc2c7) by @homersimpsons ([merge request](gitlab-org/gitlab!118395)) +- [Allow sending secret detection vulnerabilities to the AI API](gitlab-org/gitlab@33fc1505d02f264ab62f82f64782d15be61b6987) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120370)) **GitLab Enterprise Edition** +- [Enable realtime approval updates by default](gitlab-org/gitlab@d2ff57301d7274d5f8f8baa159bb191d2dc84b3b) ([merge request](gitlab-org/gitlab!120524)) +- [Add coverage fuzzing to registration features](gitlab-org/gitlab@33f39f3466aa4bde726eafabf89c68c0a3e12e73) ([merge request](gitlab-org/gitlab!119510)) **GitLab Enterprise Edition** +- [Add update_design permission to check user rights to edit description](gitlab-org/gitlab@3d37415cae122ac4c985023b9f65c6fb2890d215) ([merge request](gitlab-org/gitlab!120438)) +- [Add blocked_by and blocks quick actions for issues](gitlab-org/gitlab@20b88e0b627db7e35cf336e86013eecd67b368a3) ([merge request](gitlab-org/gitlab!120006)) **GitLab Enterprise Edition** +- [Implement YAML config file for the Value stream dashboard](gitlab-org/gitlab@8c4848a60fbe2520751c9448f6168cb81349fbe4) ([merge request](gitlab-org/gitlab!119108)) **GitLab Enterprise Edition** +- [Add branches to the initial Jira data sync](gitlab-org/gitlab@5747fb0e5b12cc1d3df367834206973ddb2894a1) ([merge request](gitlab-org/gitlab!120317)) +- [Adds PAT based auth](gitlab-org/gitlab@bcdc845486ffbc4e1c921212c2d225c979b86b54) ([merge request](gitlab-org/gitlab!118054)) +- [Add model for storing ai ci editor conversations](gitlab-org/gitlab@5b9973e1c3596d859a25929729b8f9a1f2896ecb) ([merge request](gitlab-org/gitlab!120181)) +- [Add dismissal reason and comment to vulnerability bulk updates](gitlab-org/gitlab@ed4cd2726aa3f349b78f8fc7a151ee4bcce8e70d) ([merge request](gitlab-org/gitlab!119476)) **GitLab Enterprise Edition** +- [Add a Breach and Attack Simulation CI template](gitlab-org/gitlab@c07e16060042f96c715fa612ac24276378626a02) ([merge request](gitlab-org/gitlab!119981)) **GitLab Enterprise Edition** +- [Add support for npm group level endpoints in compressed json middleware](gitlab-org/gitlab@047f5272cba407e9bd79d117a96a4dd334e64a3c) ([merge request](gitlab-org/gitlab!118824)) +- [Add RTL support in content editor](gitlab-org/gitlab@c515ce3991d21b18f8d06f2940482f06225f5cff) ([merge request](gitlab-org/gitlab!110140)) +- [Add support for basic auth on Maven registry download endpoints](gitlab-org/gitlab@943f9dfabc522af845f95d349da89adb963cd58c) ([merge request](gitlab-org/gitlab!118692)) +- [Add health_status to webhook payload data](gitlab-org/gitlab@defd1ca715341cdb320b66ec8923833c2f4965b7) ([merge request](gitlab-org/gitlab!120327)) **GitLab Enterprise Edition** +- [Add update action and update service for Abuse Reports](gitlab-org/gitlab@1966433cbbffd7a03bb789433d4728f3305bea38) ([merge request](gitlab-org/gitlab!119999)) +- [Resource access token rotation API](gitlab-org/gitlab@96b746281ca3cac97ad9531e377ecb1cd2b56fe7) ([merge request](gitlab-org/gitlab!119631)) +- [Add model for storing ai ci editor conversations](gitlab-org/gitlab@706bebfc84ab853783396790cda07b4ab41df808) ([merge request](gitlab-org/gitlab!119840)) +- [Add ability to read_vulnerability to custom roles](gitlab-org/gitlab@e92d335732252a5c9ad2c3fffb2c34336f8542fe) ([merge request](gitlab-org/gitlab!114734)) +- [Extend VertexAi::Client to add text/code/message_chat methods](gitlab-org/gitlab@a99134d71c018da56af2929eba277a3ad1f05ea6) ([merge request](gitlab-org/gitlab!119766)) **GitLab Enterprise Edition** +- [Add documentation for Compliance Framework CSV Export](gitlab-org/gitlab@c4b6edaaba28aa73058e22130f854fc92427ca06) ([merge request](gitlab-org/gitlab!119783)) **GitLab Enterprise Edition** +- [Enable feature flags for new runner creation](gitlab-org/gitlab@00349c048ec7562345fd91387a3d95c58a99cea9) ([merge request](gitlab-org/gitlab!119336)) +- [Add SecureFlag training provider](gitlab-org/gitlab@b2c9a4ea360bdc15b9e216360b7b1a36691d8add) by @bruce.lay ([merge request](gitlab-org/gitlab!111592)) +- [Support + and +s reference expansion for work items](gitlab-org/gitlab@809568f1a814f59c6b6187ef5fe3d08e12b33ca2) ([merge request](gitlab-org/gitlab!113294)) +- [Shows link to jobs on the list of Ml::Candidate](gitlab-org/gitlab@edd3f0a5d29f3ee7bff670257924d08a70baf492) ([merge request](gitlab-org/gitlab!119454)) +- [Create a service to build npm metadata cache record](gitlab-org/gitlab@60d605eb5bc27e993c671ded06270813f13e388e) ([merge request](gitlab-org/gitlab!116553)) +- [Enable the feature flag `ci_include_components`](gitlab-org/gitlab@795d84f55d970d1c96c5fd5ced348a746c0b1572) ([merge request](gitlab-org/gitlab!120093)) +- [Add HLL counter for projects that initialize product analytics](gitlab-org/gitlab@ae3a520d20365c07343e1a7891dc3fe1a733af4b) ([merge request](gitlab-org/gitlab!119659)) **GitLab Enterprise Edition** +- [Add merged merge request delete audit event](gitlab-org/gitlab@690401c3755a9d8e4e15a059eb3cf23e0dca873f) ([merge request](gitlab-org/gitlab!118793)) **GitLab Enterprise Edition** +- [PAT rotation API](gitlab-org/gitlab@ea6d855994d322f2f6721eb438691d445ceb0e4d) ([merge request](gitlab-org/gitlab!113125)) +- [Enable work item conversion](gitlab-org/gitlab@4a34449123e5a69bd1b816939686cfd9d0ff2bab) ([merge request](gitlab-org/gitlab!120075)) +- [Add GraphQL query for inherited CI variables](gitlab-org/gitlab@fb8eaa033c49b2c2e19d3e23fe9cad0a7c8c520c) ([merge request](gitlab-org/gitlab!119444)) +- [Allow remember me to be set in Admin area general settings](gitlab-org/gitlab@6ce7595d6a19e42c1717397a51c37d69e557d860) ([merge request](gitlab-org/gitlab!119381)) +- [Add truncated text component](gitlab-org/gitlab@accf817e010f9b3bb17725d4be4c5e173cb1346f) ([merge request](gitlab-org/gitlab!119458)) +- [Show services on Environments index page](gitlab-org/gitlab@ccd1d2eac6196e7ef6d7aa79bb2542c877cf12b9) ([merge request](gitlab-org/gitlab!118498)) +- [Backend to allow remember me to be disabled](gitlab-org/gitlab@2da1f399e8bb9b5ceda61bd2a08fab1ecad5b468) ([merge request](gitlab-org/gitlab!119324)) +- [Remote Development feature behind a feature flag](gitlab-org/gitlab@8837ba86332292701967e54979d606be6493db33) ([merge request](gitlab-org/gitlab!105783)) +- [Add vulnerabilities counts to VSD](gitlab-org/gitlab@36bf0a14f77e1496d79bccc280c8726f1295c8c4) ([merge request](gitlab-org/gitlab!119437)) **GitLab Enterprise Edition** +- [Add GraphQL support for visibility_pipeline_id](gitlab-org/gitlab@67c5ab4630b424aaa73c7672fe90315a5d8b366c) ([merge request](gitlab-org/gitlab!117840)) +- [Add type quick action for work items](gitlab-org/gitlab@f5e553009436827c5966544d8dc775de045c8a64) ([merge request](gitlab-org/gitlab!118790)) +- [Expose reference and createNoteEmail fields](gitlab-org/gitlab@ea2738a80eaf4b1284c847e2c0b57071ecc86f2b) ([merge request](gitlab-org/gitlab!119985)) +- [Add runner field to job_type](gitlab-org/gitlab@a68839db397cda193f8b95f57da05ee619d8f521) by @TrueKalix ([merge request](gitlab-org/gitlab!119060)) +- [Create routing table for ci_builds](gitlab-org/gitlab@2590c42b8e3dddb2b5ca545bc4aab61c164e5373) ([merge request](gitlab-org/gitlab!115485)) +- [Geo Sites - Add primary last event id](gitlab-org/gitlab@d2875c30b80af4c76e8bfe939020e1da21d71918) ([merge request](gitlab-org/gitlab!119694)) **GitLab Enterprise Edition** +- [Add data migration for human user type](gitlab-org/gitlab@1def6c535fac473ee2d1726fbbf7fa813b3f1d9c) ([merge request](gitlab-org/gitlab!115849)) +- [Implement Gitlab::Llm::Anthropic::Client](gitlab-org/gitlab@c28a1f462644a808c4e7371ae188783a6ad6a7e3) ([merge request](gitlab-org/gitlab!119651)) +- [Skip copy job artifacts uploaded to final location](gitlab-org/gitlab@426ecb7e5f0e4313613ebcf70bbc0e24cab44744) ([merge request](gitlab-org/gitlab!106740)) +- [Implement runner backoff for migrations](gitlab-org/gitlab@d579565c19c8f4b9794a769dc0db849bca60b920) ([merge request](gitlab-org/gitlab!115679)) +- [Expose Issues Completed under GraphQL flow metrics](gitlab-org/gitlab@7390511dd72edd1dee4499fd44991f40e6f904b5) ([merge request](gitlab-org/gitlab!119423)) **GitLab Enterprise Edition** +- [Preload SamlProvider for cross child epics groups](gitlab-org/gitlab@a095c237bb4c21f6659fb3b810fb434cce7c5f48) ([merge request](gitlab-org/gitlab!117249)) **GitLab Enterprise Edition** +- [Only allow user to be remembered if application setting enabled](gitlab-org/gitlab@263f40ff1e473ec2596dcbd81a0b016e99017a3a) ([merge request](gitlab-org/gitlab!119244)) +- [Enable vsa_group_and_project_parity FF by default](gitlab-org/gitlab@e29f75e4e91a901fcc9b28f603c8c2dab19fdb93) ([merge request](gitlab-org/gitlab!119759)) **GitLab Enterprise Edition** +- [Add RedisHLL counter for creating dashboards](gitlab-org/gitlab@d3e207e8ee93348d6b99b8c1f5a4ac538dac2eda) ([merge request](gitlab-org/gitlab!119481)) **GitLab Enterprise Edition** +- [Add redis counter for viewing dashboard](gitlab-org/gitlab@ce685608aaedb941d72ae7dd2390f8077a75c345) ([merge request](gitlab-org/gitlab!119328)) **GitLab Enterprise Edition** +- [Geo Sites - Read Help Icon to Secondary Site](gitlab-org/gitlab@64099a5635821f8d21e5a858a961b2d81a3aa7e0) ([merge request](gitlab-org/gitlab!119691)) **GitLab Enterprise Edition** +- [Add new properties to `GET /users/:user_id/projects`](gitlab-org/gitlab@8d21a3ebb289b6bedfc0f397951890fa8915308b) ([merge request](gitlab-org/gitlab!119541)) +- [Add export button for framework report](gitlab-org/gitlab@8026163a043c5edb3b66edd655a56c1bdaa4bcd6) ([merge request](gitlab-org/gitlab!118373)) **GitLab Enterprise Edition** +- [Add support for cancelling drag on Esc key press](gitlab-org/gitlab@e469f6764435577dfaeeaef8a95c23734e98c67c) ([merge request](gitlab-org/gitlab!119311)) **GitLab Enterprise Edition** +- [Add ability to filter github repositories by relation type](gitlab-org/gitlab@c3403326f5b312f9bc1be75799ff347b1eddff9e) ([merge request](gitlab-org/gitlab!118573)) +- [Enable GlFilteredSearch terms-as-tokens prop on Plan pages](gitlab-org/gitlab@eb28eb74f218dec9b2a5f077b24dbf53e0956ae2) ([merge request](gitlab-org/gitlab!119339)) +- [Add output moderation to OpenAI::Client](gitlab-org/gitlab@48fbee95df50e15f4bf644a938a10a6a522fad62) ([merge request](gitlab-org/gitlab!119465)) **GitLab Enterprise Edition** +- [Add ability to add/edit compliance frameworks directly from report](gitlab-org/gitlab@99e39bc92f94362cb12945fb50ac75d7b5fb5986) ([merge request](gitlab-org/gitlab!118281)) **GitLab Enterprise Edition** +- [Add Value Stream Dashboard tracking table](gitlab-org/gitlab@1f93f4f33408b508f9d2c63649ba2072bed92de2) ([merge request](gitlab-org/gitlab!118908)) +- [Skip phone verification when TeleSign is down](gitlab-org/gitlab@159e03e2fcb201b0af395edb1f82eacaf7735165) ([merge request](gitlab-org/gitlab!117618)) **GitLab Enterprise Edition** +- [Disallow runner registration if allow_runner_registration_token disabled](gitlab-org/gitlab@a39879ad86bcb35c92ec9a073eaaedd6724b87d6) ([merge request](gitlab-org/gitlab!118299)) +- [Add new table to store note metadata](gitlab-org/gitlab@5cbcad5da3886834ab014c0cfc91a3a934fbbc68) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117149)) +- [Allow all users to opt-in to the navigation redesign beta](gitlab-org/gitlab@058644e7916f34ead8b29d0980c45d31db067b5f) ([merge request](gitlab-org/gitlab!119488)) +- [Adding create API for instance audit external destinations](gitlab-org/gitlab@f95b40cd52a314949c35edb5e51555199f8e6840) ([merge request](gitlab-org/gitlab!118363)) **GitLab Enterprise Edition** +- [Adds link to settings from dependency proxy](gitlab-org/gitlab@d79b2bed892d94954228a422dee2764d19ce1fd6) ([merge request](gitlab-org/gitlab!118923)) +- [Reflect state transition comments in system notes](gitlab-org/gitlab@8c16976b31e6a27518129029c738c25ce2f88bf0) ([merge request](gitlab-org/gitlab!119451)) **GitLab Enterprise Edition** +- [Associate Ml::Candidate to Ci::Build](gitlab-org/gitlab@ae5d1b2d02294ab9df88b57360d6f923ea524345) ([merge request](gitlab-org/gitlab!117412)) +- [Create the Organization model](gitlab-org/gitlab@61ee6041d994ce73f4b4a3d20473d4a2facc48da) ([merge request](gitlab-org/gitlab!119421)) +- [Adds digest label & copy button for dependency proxy UI](gitlab-org/gitlab@5763cbf851eb74200d5756f369cb193539ab582b) ([merge request](gitlab-org/gitlab!114538)) +- [Add support for new vulnerability status filtering](gitlab-org/gitlab@e509d661c331acb126bacf191edcce9ce59748f3) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117394)) **GitLab Enterprise Edition** +- [Enable sync_approval_rules_from_findings by default](gitlab-org/gitlab@a8f05b1a6c6790b5de7821bcfe7ef33498a3d2ca) ([merge request](gitlab-org/gitlab!119367)) +- [Add option to keep quick actions in text](gitlab-org/gitlab@c71df501b44ecda05778fb1f83a497d5243f448a) ([merge request](gitlab-org/gitlab!117797)) +- [Add Abuse Reports Detail View](gitlab-org/gitlab@5f4615b8ecbc65c5e271b8167cf0e61f76843f07) ([merge request](gitlab-org/gitlab!115867)) +- [Add moderation to OpenAI::Client](gitlab-org/gitlab@312b5f7e43db9bdeca7406586e6f5b57ccc0c5cb) ([merge request](gitlab-org/gitlab!119050)) **GitLab Enterprise Edition** +- [Add settings to database](gitlab-org/gitlab@7c6027cc99c18f67349e6833dae8b22c53283007) ([merge request](gitlab-org/gitlab!118222)) +- [Add runners to job/pipeline seed data](gitlab-org/gitlab@0609b36e915a67d851af1038050670915a572dac) by @TrueKalix ([merge request](gitlab-org/gitlab!119053)) +- [Create Abuse Report Events table](gitlab-org/gitlab@f89452bc5fbcf267e4403192e937144ab6604841) ([merge request](gitlab-org/gitlab!119199)) +- [Add project cell admin jobs vue](gitlab-org/gitlab@eb5a77ecbb9927ff5989f44f192b17de4c0e1dbc) by @TrueKalix ([merge request](gitlab-org/gitlab!119294)) +- [Add Remember Me Enabled to Application Settings](gitlab-org/gitlab@674ade60bbcad0817ccfba640db3c59bb8264ef2) ([merge request](gitlab-org/gitlab!119226)) +- [Create a new table to hold diff summaries](gitlab-org/gitlab@801bd719cd345a4fa3db00a6c6c3013633faa999) ([merge request](gitlab-org/gitlab!118671)) +- [Create bot user when security policy is linked](gitlab-org/gitlab@4a5f475cdd9f46fedccc316b1abb027109a480cd) ([merge request](gitlab-org/gitlab!118089)) +- [Autofocus link URL when editing link](gitlab-org/gitlab@f2ae2235c7317bab0b4a45f1c493b6be90a28c64) ([merge request](gitlab-org/gitlab!119069)) +- [Add geo_sites API endpoint](gitlab-org/gitlab@6d2a5b8f70058d086a324cf7b80904f5844a670f) ([merge request](gitlab-org/gitlab!115214)) **GitLab Enterprise Edition** +- [Add PA configuration to project level settings](gitlab-org/gitlab@5a2f82d52d86b301e77c2631153715f4cb654d7b) ([merge request](gitlab-org/gitlab!117701)) +- [Add `ref_path` to CI job JWTs](gitlab-org/gitlab@3f2dd7621b364f99d200a982e502d26d27e4225a) ([merge request](gitlab-org/gitlab!119075)) +- [Allow uploading more image types](gitlab-org/gitlab@182007ab07ee7dc5bff0064559050b5d717f2924) ([merge request](gitlab-org/gitlab!119063)) +- [Add maximum length validation for ci_builds columns](gitlab-org/gitlab@637cb6b0297a2b047abc44a552d9cccb1e00588b) ([merge request](gitlab-org/gitlab!118148)) +- [Add cost tracking to OpenAi::Client](gitlab-org/gitlab@aac1aa27467487007a8d70ba8a8caf97a8ae2149) ([merge request](gitlab-org/gitlab!118925)) **GitLab Enterprise Edition** +- [Create partitioned table for VSD counts](gitlab-org/gitlab@faecc03c8ca6452f8cfc14e650eaf60e585383bc) ([merge request](gitlab-org/gitlab!118220)) +- [Feature Flag: Add FF for Rust metrics marshaling](gitlab-org/gitlab@90e14264c6d2fc5ffad67e7f59487123fde9067c) ([merge request](gitlab-org/gitlab!119005)) +- [Add registry table to track replication and verification state](gitlab-org/gitlab@b62caa4ef4532290e07efbf953ac4cf59a0ce9c3) ([merge request](gitlab-org/gitlab!117909)) +- [Add column visibility_pipeline_id](gitlab-org/gitlab@b527fce6ef55915507d5f66f6539e93228ecaf90) ([merge request](gitlab-org/gitlab!117844)) +- [Enable feedback deprecation by default](gitlab-org/gitlab@c4eef68d1354bc5f922027cf8a46c2480d4ae26f) ([merge request](gitlab-org/gitlab!118963)) +- [Improve the performance of the "vulnerability report" page](gitlab-org/gitlab@00f776fadcdef65cba20e5ea84cc859322ab52e4) ([merge request](gitlab-org/gitlab!118759)) **GitLab Enterprise Edition** +- [Add maintenance mode to registration features](gitlab-org/gitlab@655052a932d1999726f5fd2bde4098b05321d75a) ([merge request](gitlab-org/gitlab!118760)) **GitLab Enterprise Edition** +- [Adds link to settings on container registry image list page](gitlab-org/gitlab@ef9352fa23af35a2ce9e3afcc53a669b67518833) ([merge request](gitlab-org/gitlab!118124)) +- [Add first assigned to Issue and MR events to VSA](gitlab-org/gitlab@402bb9992932689d0bb155ebfc8a6c7af50dfb7e) ([merge request](gitlab-org/gitlab!118467)) **GitLab Enterprise Edition** +- [Add the tanuki_bot migration/model](gitlab-org/gitlab@ed687eb59db8e63516050e4a3cab97d42d9f5e31) ([merge request](gitlab-org/gitlab!118463)) **GitLab Enterprise Edition** +- [Enable mr widget V2 by default](gitlab-org/gitlab@88588b1519e7db159c6134e369651a91dd4a5daa) ([merge request](gitlab-org/gitlab!118843)) +- [Improve error messages](gitlab-org/gitlab@347805c958f93667991b7d1a4db577b0efab8f1b) by @TrueKalix ([merge request](gitlab-org/gitlab!118742)) +- [Enable use_merge_base_for_security_widget by default](gitlab-org/gitlab@b4b75f7e7b6aada85525903146e5094240af7211) ([merge request](gitlab-org/gitlab!118820)) +- [Add support for TOFA AI API](gitlab-org/gitlab@1244e4b50263820c900af4632e89370a44fa49ac) ([merge request](gitlab-org/gitlab!118754)) +- [Add private endpoint to show github import errors](gitlab-org/gitlab@ecc9538e22f59d06d2d8d87e59250de3f1e9d927) ([merge request](gitlab-org/gitlab!117133)) +- [Track spam scores for users](gitlab-org/gitlab@6992f93a81e47c5f8c83baed750f0d22151d58fb) ([merge request](gitlab-org/gitlab!118706)) +- [Add ci_max_includes to application settings](gitlab-org/gitlab@cbb8875ab483200edcc44c3f63d6604cf942ec92) ([merge request](gitlab-org/gitlab!118392)) +- [Add tooltips to Value Stream Dashboard sparkline charts](gitlab-org/gitlab@ab1a0803b5d246344c1d01565f3b8d9c165582ab) ([merge request](gitlab-org/gitlab!118647)) **GitLab Enterprise Edition** +- [Add jobs count admin jobs vue](gitlab-org/gitlab@d6fee6cd47198fb91e765b4449edd87cf1bd89ab) by @TrueKalix ([merge request](gitlab-org/gitlab!118765)) +- [Add geo sites fixtures schemas](gitlab-org/gitlab@53c6e9b624f7309727c3e084496144e520faf88c) ([merge request](gitlab-org/gitlab!118695)) **GitLab Enterprise Edition** +- [Add Tanuki Bot backend service and API](gitlab-org/gitlab@bc1c9c82b1a059c27ada88d4e56b40a5611d52e7) ([merge request](gitlab-org/gitlab!117695)) **GitLab Enterprise Edition** +- [Add artifacts management page](gitlab-org/gitlab@c643926cba4e6146ce1daf47f23ed84d93056b79) ([merge request](gitlab-org/gitlab!118101)) +- [Show services on Environments index page](gitlab-org/gitlab@fedfa5c12c44c5fba1449fa56d6e2128ea8ae129) ([merge request](gitlab-org/gitlab!117879)) +- [Add `ciPipelineStage` to `QueryType`](gitlab-org/gitlab@da54ba3de0cc0cb503bdb484f5ab4cefc4b27fdf) ([merge request](gitlab-org/gitlab!118238)) +- [Add the tanuki_bot migration/model](gitlab-org/gitlab@a219b6e5f6439d7b81830c15091e4ffff4b29403) ([merge request](gitlab-org/gitlab!118195)) **GitLab Enterprise Edition** +- [Introduce "update filters" popover after assigning framework](gitlab-org/gitlab@e1b73834949406eb267f350bb6385bc06ed9cd40) ([merge request](gitlab-org/gitlab!118580)) **GitLab Enterprise Edition** +- [Enable dismissal_reason feature flag by default](gitlab-org/gitlab@1576c488aa95092436d3e63d97bc0336dca5d031) ([merge request](gitlab-org/gitlab!118603)) **GitLab Enterprise Edition** +- [Report abuse to admin for WI notes](gitlab-org/gitlab@663c0e1d601ba6fd3b4b9efbfbf707884f5043c2) ([merge request](gitlab-org/gitlab!115319)) +- [Enable Fetching upstream to the fork](gitlab-org/gitlab@5ea73a04c131599caefbc6536b5589c21e300cb3) ([merge request](gitlab-org/gitlab!118606)) +- [Add ability to add/remove compliance framework from single item](gitlab-org/gitlab@8bafa8b2067fbb611993e3470d80939526bd9d2c) ([merge request](gitlab-org/gitlab!117703)) **GitLab Enterprise Edition** +- [Add backend for setWorkItemMetadata](gitlab-org/gitlab@c3a9fbe90f60cb8d726c4b3587312662145bc944) ([merge request](gitlab-org/gitlab!118587)) +- [Add display_color to epic_boards](gitlab-org/gitlab@db4d920c625a7f0155a82d5764829ddf2d1f1b11) ([merge request](gitlab-org/gitlab!118492)) +- [Add ability to disable social feature (following)](gitlab-org/gitlab@9bec50099b5411b4ec18e7fbc7fa334cf4d986f4) ([merge request](gitlab-org/gitlab!116023)) +- [Add job filter admin jobs vue](gitlab-org/gitlab@5911785f6d7b20949d42d4dd54af94a483e0d803) by @TrueKalix ([merge request](gitlab-org/gitlab!118304)) +- [Add user feedback](gitlab-org/gitlab@b5baae5bdbc283cb1cce4286286fa5ffe9d4e804) ([merge request](gitlab-org/gitlab!118071)) **GitLab Enterprise Edition** +- [Add intersection observer admin jobs vue](gitlab-org/gitlab@64f99a0e6c434dafa1a02d2afe79ede82292cdbc) by @TrueKalix ([merge request](gitlab-org/gitlab!118052)) +- [Add audit event schema definitions](gitlab-org/gitlab@2fa1b8022aa1e46643dfc902641c69f25dc7ae08) ([merge request](gitlab-org/gitlab!115500)) **GitLab Enterprise Edition** +- [Set minimum role for importing projects to Maintainer](gitlab-org/gitlab@ea4f3662d412f0297b6505a6a0e00380224d521e) ([merge request](gitlab-org/gitlab!117374)) +- [feat: New REST api endpoint to fetch CI_JOB_TOKEN access settings](gitlab-org/gitlab@e46b236d618695b66876b9b22738b808b3955bad) by @gerardo-navarro ([merge request](gitlab-org/gitlab!117842)) +- [Store MR and issue assignment events](gitlab-org/gitlab@9824aad971827803a1c14f4dc819afb7e08dbf36) ([merge request](gitlab-org/gitlab!118186)) +- [Index for namespaces by root namespace lookup](gitlab-org/gitlab@c588a15bac74f2e58dba4e09a1d376e9b13f2776) ([merge request](gitlab-org/gitlab!118031)) +- [Add skeleton loader to admin jobs vue](gitlab-org/gitlab@21ce76183e15b56bdc2e64efc80daaa2da9d5188) by @TrueKalix ([merge request](gitlab-org/gitlab!118044)) +- [Show work item id in breadcrumb](gitlab-org/gitlab@7c5a79cdb4856bd1162c06bb1927b85a8ee45a66) ([merge request](gitlab-org/gitlab!118018)) +- [Admins can edit arkose_risk_band](gitlab-org/gitlab@03472cdcb40aee5cddaf4dbec36ae489b12b04ad) ([merge request](gitlab-org/gitlab!117332)) **GitLab Enterprise Edition** +- [Introduce circuit breaker for OpenAI client](gitlab-org/gitlab@0c6118892eab87317f1cf38b3de566e25a04854a) ([merge request](gitlab-org/gitlab!117993)) +- [Switch status tabs](gitlab-org/gitlab@c8240abd8ea03b0e6605fcad9cb25db9e42860ac) by @TrueKalix ([merge request](gitlab-org/gitlab!118307)) +- [Promote Key Result to Objective](gitlab-org/gitlab@0309f820d188d020fe2c2363d0481a8dc51ea2e7) ([merge request](gitlab-org/gitlab!117482)) +- [Add Environments::Stop mutation](gitlab-org/gitlab@37c10a4fe1180cd464a4b8d05e55926ede0a43ec) ([merge request](gitlab-org/gitlab!116838)) +- [Add branch filtering for compliance violations report](gitlab-org/gitlab@edbb2284c94ded42cdf6d78942d04fb6d4b00352) ([merge request](gitlab-org/gitlab!117948)) **GitLab Enterprise Edition** +- [Add Sidekiq execution SLI as apdex](gitlab-org/gitlab@168450dd62c4b08c9841ef2846b8f59f050406e3) ([merge request](gitlab-org/gitlab!116827)) +- [Add API to toggle pass_user_identities_to_ci_jwt](gitlab-org/gitlab@1ad2cd36d028e57b67353084740ef628957a3244) by @joe-snyder ([merge request](gitlab-org/gitlab!117874)) +- [Add sync index security_scans_on_pipeline_id_and_scan_type](gitlab-org/gitlab@1bfc91c360a728bb8e4309954432a3e12d6b5e79) ([merge request](gitlab-org/gitlab!116147)) +- [Adds request forwarding warning to package details modal](gitlab-org/gitlab@235570f39baab6a8913de70a2fc59dd39f79fc36) ([merge request](gitlab-org/gitlab!117497)) +- [Adds confirmation prompt to container image repository delete modal](gitlab-org/gitlab@301ce156a65916a19d52a20ceb31dca6e988d788) ([merge request](gitlab-org/gitlab!117619)) +- [Prepare todos for bigint migration](gitlab-org/gitlab@25d0b2c0fe61e21c925022187652737cdcaea365) ([merge request](gitlab-org/gitlab!117963)) +- [Change fetch policy for work item detail](gitlab-org/gitlab@9514c5a504f9e6113377e247a147e301f428f4f7) ([merge request](gitlab-org/gitlab!117977)) +- [Populate missing dismissal info](gitlab-org/gitlab@61f1844bcbddceacc488329f7920ada4829406de) ([merge request](gitlab-org/gitlab!117478)) -## 15.11.4 (2023-05-16) +### Fixed (163 changes) -### Fixed (2 changes) +- [Add top margin to admin email alert](gitlab-org/gitlab@3762434b50076d6f3e8a4161dee3527c490d3974) ([merge request](gitlab-org/gitlab!120352)) **GitLab Enterprise Edition** +- [Update by_parent filter in EpicsFinder](gitlab-org/gitlab@b1a760c09594b63fa85e94b5e977e92e632a7594) ([merge request](gitlab-org/gitlab!120480)) **GitLab Enterprise Edition** +- [View projects pending deletion from subgroup](gitlab-org/gitlab@103538c8ab1b37c7be88084652f3f94dbcbf61be) ([merge request](gitlab-org/gitlab!119950)) **GitLab Enterprise Edition** +- [Fixes roadmap timeline bar alignment](gitlab-org/gitlab@ea5f02d848e19f581515e71d0cba04d7dff44d30) ([merge request](gitlab-org/gitlab!120718)) **GitLab Enterprise Edition** +- [Fix no_proxy not working when DNS rebinding protection enabled](gitlab-org/gitlab@e82d081b771bbd1cdf7d237be6411e6bb5c9fac6) ([merge request](gitlab-org/gitlab!120412)) +- [Handle String response in ResponseLogger](gitlab-org/gitlab@30208becf36b670d650fcae3a7c61faea71f4140) ([merge request](gitlab-org/gitlab!120697)) +- [Fix case sensitive GraphQL username argument](gitlab-org/gitlab@eb9bb5cc9d9ef97a89581ed3153cd320143436d8) ([merge request](gitlab-org/gitlab!120689)) +- [Fix bridge status not inheriting canceled](gitlab-org/gitlab@1e4c1b719bdbe747ff20f3d402abe21d5daf49ab) ([merge request](gitlab-org/gitlab!120276)) +- [Fixed how series render and legend in VSA Overview "Total time" chart](gitlab-org/gitlab@4950bd51cfc77f8a75bb4477d74916d9a6e9e7f3) ([merge request](gitlab-org/gitlab!118656)) **GitLab Enterprise Edition** +- [Updating PipelineJobResolver for type filter](gitlab-org/gitlab@8ac1474ac72b6978af08e346a218724a67fa158b) ([merge request](gitlab-org/gitlab!119569)) +- [Make new jira_auth_type Jira API argument optional](gitlab-org/gitlab@7502785b1378db65019a7f687cbf6dc1670f5eae) ([merge request](gitlab-org/gitlab!120565)) +- [Fix pending status when SecureFlag has no content](gitlab-org/gitlab@2cade9536cfa6f1b72d4c6f55ad4ad3ab525b26c) ([merge request](gitlab-org/gitlab!120538)) **GitLab Enterprise Edition** +- [Fix auditing of merged merge request when metrics are nil](gitlab-org/gitlab@83223d9b04d8e7f491ad8887fd6144d0cfe0bb26) ([merge request](gitlab-org/gitlab!120495)) **GitLab Enterprise Edition** +- [Skip to main content interactive when super sidebar is inert](gitlab-org/gitlab@e7a13517cae06ec91296067731c487709c357344) ([merge request](gitlab-org/gitlab!120224)) +- [Remove extra top padding on collapsible discussion](gitlab-org/gitlab@da0db8601a83fe7e5d3fd547ceb96ec26b0b72ee) ([merge request](gitlab-org/gitlab!120344)) +- [Fix the query when migration add_suffix_project_in_wiki_rid not finished](gitlab-org/gitlab@65c829c0782afa76137fbb6337f367df6c945829) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120335)) **GitLab Enterprise Edition** +- [Fix event location detection for the branch list](gitlab-org/gitlab@b99c09976db6b0ce826734767748c7d72e8429c5) ([merge request](gitlab-org/gitlab!120487)) +- [Add a boolean field hidden in the MergeRequest ES mapping](gitlab-org/gitlab@b1960f39910a6ee31768e8535088981a4257b8b0) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118842)) **GitLab Enterprise Edition** +- [Removing Ci:Bridge jobs from ProjectJob#show](gitlab-org/gitlab@b7c74b1e5e7a7f2d40e4aec707a4d868a71a6c79) ([merge request](gitlab-org/gitlab!119798)) +- [Replace stable Terraform CI templates with latest templates](gitlab-org/gitlab@65e8b71bee99f0acb9ea875e4dfff6345185895b) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118375)) +- [Status checks widget: Remove double bottom border](gitlab-org/gitlab@31007b0c78212feab0d709f5d49417ce46efa617) ([merge request](gitlab-org/gitlab!119334)) +- [Fix border on description box](gitlab-org/gitlab@eca16350679e5baaa5d4bbdec76c124ffcf8077c) ([merge request](gitlab-org/gitlab!120389)) +- [Fix syntax highlighting on Wiki Diff pages](gitlab-org/gitlab@6a438198bc423c6c2f796f60f85b80d719bfb31f) ([merge request](gitlab-org/gitlab!119773)) +- [Update GraphQl spec to include SHARED_INTO_ANCESTORS](gitlab-org/gitlab@dc69b2cdc81e2ea0c3efaa50136067d723e175e2) ([merge request](gitlab-org/gitlab!120410)) +- [Fix height calculations with roadmap to prevent extra scrollers](gitlab-org/gitlab@82e24e80b31abbc85aede907fe639c5d0e92927a) ([merge request](gitlab-org/gitlab!119954)) **GitLab Enterprise Edition** +- [Fix comments template dropdown being hidden](gitlab-org/gitlab@d75a502bb1abd3d0acfd9528f9ffe6e422d2f9d5) ([merge request](gitlab-org/gitlab!120393)) +- [Include shared from groups members in the projects members](gitlab-org/gitlab@49ebbf5a9b1298a569d03ba36050eb256ca09ff3) ([merge request](gitlab-org/gitlab!96543)) +- [Fix container scanning via group level policy](gitlab-org/gitlab@14bbaf4adc399e2a6134ee88524c15f69e391bdc) ([merge request](gitlab-org/gitlab!119681)) +- [Append bubble menus to body](gitlab-org/gitlab@418f4d83bc15ff734402f3285886541d9bdec5ec) ([merge request](gitlab-org/gitlab!120336)) +- [Fix MR activity filtering](gitlab-org/gitlab@5ca6ce192ce4505f7c942d5875e118d013a43b0f) ([merge request](gitlab-org/gitlab!120328)) +- [Do not autofocus the description field](gitlab-org/gitlab@0b7aaeaa053a5099a7c510b19b1638757d28aebe) ([merge request](gitlab-org/gitlab!120296)) +- [Remove epic date fields authorization](gitlab-org/gitlab@e63da25092c6d761b49c235bf8baed898134c769) ([merge request](gitlab-org/gitlab!120261)) **GitLab Enterprise Edition** +- [Namespace the Gitlab constant to avoid NameError](gitlab-org/gitlab@e0dc3fefe453cfd065a79a30fa52947061052b6b) ([merge request](gitlab-org/gitlab!120275)) +- [Fixes missing background in tasks](gitlab-org/gitlab@f26196599c39e1ada90cb5ab4fbd32c61a6e25d7) ([merge request](gitlab-org/gitlab!120074)) +- [Alter installation_creation_date metric logic](gitlab-org/gitlab@442fa1dc51e49b479c97570944e6a2638e5dbebe) ([merge request](gitlab-org/gitlab!119588)) +- [Move feature-flag to outside pipelined block](gitlab-org/gitlab@7dae7feb9164409d1ba4f7566428eb2407fece00) ([merge request](gitlab-org/gitlab!120255)) +- [Return the error when failed to register runner](gitlab-org/gitlab@cb4a044aba5a8165ce40edfb482da9395ea67887) ([merge request](gitlab-org/gitlab!120249)) +- [Fix avatar when commit email is an empty string](gitlab-org/gitlab@39db71032ee73be5b1ba0b730f429a81b99d3556) ([merge request](gitlab-org/gitlab!119708)) +- [Allow merge when rules are invalid for security policy project](gitlab-org/gitlab@8692342f0fbc41fb1937eeedde841ea43ce2ce73) ([merge request](gitlab-org/gitlab!120240)) **GitLab Enterprise Edition** +- [Fix redirect for work items notes for diffPath and deletePath](gitlab-org/gitlab@3a213d4324f2ccbc7c205bc2e0918ef90962c116) ([merge request](gitlab-org/gitlab!119327)) +- [Lock tables before dropping the LFK trigger](gitlab-org/gitlab@440e1f5ba4b055e03f1788f7705cb010f943eaf2) ([merge request](gitlab-org/gitlab!120210)) +- [Update new navigation nav item badge positon and hover styles](gitlab-org/gitlab@86b28e561a7adba677c3f393908a1d62e951cd69) ([merge request](gitlab-org/gitlab!120204)) +- [Do not limit batch_size in migration](gitlab-org/gitlab@cd8d2542d30390dffda94da5a30fba1551c58ce6) ([merge request](gitlab-org/gitlab!120199)) **GitLab Enterprise Edition** +- [Clicking task item doesn’t when using “1)”](gitlab-org/gitlab@a6f27d6d7d71a7e07e38aff40610cd4dec4fce3c) ([merge request](gitlab-org/gitlab!120187)) +- [Prevent logged in user from blocking themselves in abuse reports](gitlab-org/gitlab@4f987ce1a21207faef6a33adb61e3178ef806c91) ([merge request](gitlab-org/gitlab!119002)) +- [Fix incorrect handler location for list of branches](gitlab-org/gitlab@f8407bbdbadff2327a2c3701dc92379fdb59782f) ([merge request](gitlab-org/gitlab!118775)) +- [Show detected licenses with their URLs](gitlab-org/gitlab@5e28b54d561c0697d8dbfd4eee2f3353e7885efd) ([merge request](gitlab-org/gitlab!119689)) **GitLab Enterprise Edition** +- [Fix active state overlay in content editor](gitlab-org/gitlab@76f782dc95816c90d4fe95e33f6b1f354d25b3d0) ([merge request](gitlab-org/gitlab!115999)) +- [Add missing license check for project approval rules endpoints](gitlab-org/gitlab@53213d187bfd0808406e22270dd969e7c7504084) ([merge request](gitlab-org/gitlab!119976)) **GitLab Enterprise Edition** +- [Fixes Content-Type for Service Desk emails with attachments](gitlab-org/gitlab@dd2ac2c031740942d6ac9141728d1f2769d77b9b) ([merge request](gitlab-org/gitlab!118359)) +- [Fix DORA deployment frequency calculation](gitlab-org/gitlab@4bf28154bb7940162afac11b78be36a45e6f6627) ([merge request](gitlab-org/gitlab!118879)) **GitLab Enterprise Edition** +- [Resolve "Immediately preview when editing a broadcast message"](gitlab-org/gitlab@9322b12533f13038c5c08813180c43df3aa039ec) ([merge request](gitlab-org/gitlab!120012)) +- [Fix group blobs search permission when migration is not complete](gitlab-org/gitlab@9b2a4a5240d4a73a2a46dc0d565cc6f8c6a01bc4) ([merge request](gitlab-org/gitlab!119848)) **GitLab Enterprise Edition** +- [Fix arguments in container replication event](gitlab-org/gitlab@c0f183e0de865b1ba9c4fbdf65e2ea8fe0c2939e) ([merge request](gitlab-org/gitlab!120031)) **GitLab Enterprise Edition** +- [Fixes NoMethod when tags are empty](gitlab-org/gitlab@d270b7d7498949c1763edbfdffcc190c886963c3) ([merge request](gitlab-org/gitlab!119988)) +- [Fixing a misspelling of "absence"](gitlab-org/gitlab@d72810dc61f20055deeeaa93f7b652d5a2b709e2) ([merge request](gitlab-org/gitlab!119987)) +- [Fixed issue description editor keeping autosaved data after save](gitlab-org/gitlab@9919ebd4d1e750cb73055b756eefc3872aa83268) by @zillemarco ([merge request](gitlab-org/gitlab!119043)) +- [Do not show issuable email address when FF is on](gitlab-org/gitlab@4cbb8800476dcd17b3b29ab7c26b5abaacaafc47) ([merge request](gitlab-org/gitlab!119717)) +- [SSO enforcement shouldn't require SSO for non-members and public groups](gitlab-org/gitlab@f251c7bf9b0ad1a45a59d756a8b6db7dce889041) ([merge request](gitlab-org/gitlab!118596)) **GitLab Enterprise Edition** +- [Fallback to highlighting HAML with Rouge](gitlab-org/gitlab@bf2d46a277051f525cd50e3acdfea3c7c34dd727) ([merge request](gitlab-org/gitlab!119970)) +- [Hide Add button in issue if user has Guest role](gitlab-org/gitlab@18d67a77f3b42719b17615f2a285e993ee3c36b1) ([merge request](gitlab-org/gitlab!117030)) +- [Fix TypeError exceptions in UpdateMergeRequestWorker](gitlab-org/gitlab@4dd9306f1a29df1bd45806f2966eaf9c46bdf3c0) ([merge request](gitlab-org/gitlab!119853)) +- [Fixes shortcut not working without focus](gitlab-org/gitlab@361954a495cb589380975b365d2c306bc66cef42) ([merge request](gitlab-org/gitlab!119927)) +- [Fixes rich text editor not wrapping on mobile](gitlab-org/gitlab@873697fd9cafcae0404ab43eac4604338c5e62fd) ([merge request](gitlab-org/gitlab!119930)) +- [Fix loading Web IDE Beta outside gitlab_url](gitlab-org/gitlab@7d84bc508c6a7bfde2d2afab709da2913f3c2e6f) ([merge request](gitlab-org/gitlab!118875)) +- [Follow k6's rename of ex/sample folder](gitlab-org/gitlab@5644211d4f76c4f0d079666e018c84b290d44198) ([merge request](gitlab-org/gitlab!119764)) +- [Fixes registry search alignment](gitlab-org/gitlab@47b323d6e96362265542c48a7bc38de2a9f5961f) ([merge request](gitlab-org/gitlab!119284)) +- [Fix tab count admin jobs vue](gitlab-org/gitlab@c57f7714f8c0322041881f1e96687f6590139759) by @TrueKalix ([merge request](gitlab-org/gitlab!119371)) +- [Enable "inherit_approval_rules_on_creation" feature flag](gitlab-org/gitlab@3df84899802c0d5feeafe175a0f60ebff90edc1c) ([merge request](gitlab-org/gitlab!119672)) +- [SSO enforcement should respect Admin Mode for groups access](gitlab-org/gitlab@38136bbd593951398e4993a18df72eefb10f03bc) ([merge request](gitlab-org/gitlab!118400)) **GitLab Enterprise Edition** +- [Remove counter_attribute_db_lease_for_update FF](gitlab-org/gitlab@468828f9f5b8ed81a2961796bc5f14dceb8a6a0b) ([merge request](gitlab-org/gitlab!119652)) +- [Fix empty attachments 500 error in NPM package PUT request](gitlab-org/gitlab@89f9f417293ee8915c1bd94726e939f3d98bfca0) ([merge request](gitlab-org/gitlab!119209)) +- [Fix conan search to not find instance-wide packages on project-level](gitlab-org/gitlab@e7e3c4350432c5ba1741348b1f1f54702af1f3c6) ([merge request](gitlab-org/gitlab!118099)) +- [Fix Stop Environment Diaglog shows wrong text](gitlab-org/gitlab@85ec62a292464bf7d9e09ee928cccb45089d4729) ([merge request](gitlab-org/gitlab!118459)) +- [Use trueup_period_seat_count for true-up check](gitlab-org/gitlab@6b8132a8056799478a8801e4022e57b8ae694022) ([merge request](gitlab-org/gitlab!119001)) **GitLab Enterprise Edition** +- [Make sure `/api/v4/geo_nodes/current/failures` works with the unified URL](gitlab-org/gitlab@75944b23f54472f836b626da4704d07b8c08b7ce) ([merge request](gitlab-org/gitlab!119538)) +- [Inject apollo for pipelines table](gitlab-org/gitlab@a5ee2d24fa77a7d1437f0f2ed64ae397fec3d457) ([merge request](gitlab-org/gitlab!119216)) +- [Checks loaded visualisation for tree traversal](gitlab-org/gitlab@732f79d182deeb10fe7fcfbc81f5102f7f57bf54) ([merge request](gitlab-org/gitlab!119513)) **GitLab Enterprise Edition** +- [Cleanup leftovers in packages_dependencies table](gitlab-org/gitlab@dfcec8993a5a70398ceaeac468d36ec334555162) ([merge request](gitlab-org/gitlab!113076)) +- [Globally enable ff filter_vulnerability_findings_dismissed_on_default](gitlab-org/gitlab@38a3350679c90658e3aad89bb6332adc5e9e21ec) ([merge request](gitlab-org/gitlab!119486)) **GitLab Enterprise Edition** +- [Fix root_ancestor undefined method error](gitlab-org/gitlab@a32f5b2e5d702926478b316234d70e55f00d3dda) ([merge request](gitlab-org/gitlab!119457)) **GitLab Enterprise Edition** +- [Fix custom template import permission](gitlab-org/gitlab@5b6ff2e2321ccefce3446c469184e51a82c79a84) ([merge request](gitlab-org/gitlab!119319)) +- [Set static page size for fetching notes](gitlab-org/gitlab@4049cd2b3ca27c7e4e52cdb508fbf9477a364c49) ([merge request](gitlab-org/gitlab!119431)) +- [Put actual default branch in readme on project creation](gitlab-org/gitlab@5301aa516c3a523828f89fc70a6d7155b8f34ed6) ([merge request](gitlab-org/gitlab!119408)) +- [Change API endpoint used when inviting a group to a project](gitlab-org/gitlab@9fd2e295a2033a49759c3efa2242ecd004e241db) ([merge request](gitlab-org/gitlab!112867)) +- [Fix N+1 issue for GraphQL VulnerabilityType](gitlab-org/gitlab@a3c6ff0b192c988092d17f5b61f7c438f9b13350) ([merge request](gitlab-org/gitlab!116643)) **GitLab Enterprise Edition** +- [Enable remove_scan_result_policy_transaction by default](gitlab-org/gitlab@86d2a3cd116532b37965e7c60c3bf916347c2049) ([merge request](gitlab-org/gitlab!119365)) **GitLab Enterprise Edition** +- [Search without project namespaces](gitlab-org/gitlab@aebee8dbc5b4480d8ff158d80a6d8b2adc9f0e8d) ([merge request](gitlab-org/gitlab!118150)) +- [View projects pending deletion from subgroup](gitlab-org/gitlab@7ebc26c8306bfcad966ad87bbb74b14b7db55129) ([merge request](gitlab-org/gitlab!119292)) **GitLab Enterprise Edition** +- [Crop long texts in the MR Security Reports widget](gitlab-org/gitlab@1ff4cb8b10b73cc887b4a0824d32d4bf0a9c14f6) ([merge request](gitlab-org/gitlab!118778)) **GitLab Enterprise Edition** +- [Fix: display correct duration for pipeline >24 hour runtime](gitlab-org/gitlab@74d4386c48cc4499c4e9689b83379266ce6354f3) by @endera_ ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118693)) +- [Use fallback when avatar fails to load](gitlab-org/gitlab@8791ed457e2173c3e623b72e9c113c76629cf4aa) ([merge request](gitlab-org/gitlab!119285)) +- [Fix vue3 spec violation in environments_folder_view_spec.js](gitlab-org/gitlab@c47748861ccca19c3cc710d7ed58d20930f13cc7) ([merge request](gitlab-org/gitlab!119281)) +- [Update chat prompt to move references to the end](gitlab-org/gitlab@6887b31f21ed90436e272794443565a6b9f00a95) ([merge request](gitlab-org/gitlab!119274)) **GitLab Enterprise Edition** +- [Fix installation activation bug](gitlab-org/gitlab@6b60dab52541f37de0fc034d6c6f918532543db5) ([merge request](gitlab-org/gitlab!119272)) **GitLab Enterprise Edition** +- [Fix for the rebase merge request state being shown incorrectly](gitlab-org/gitlab@5f61cd5508f02352d9230f0d15316d85976dd08e) ([merge request](gitlab-org/gitlab!118327)) +- [Prevent errors when focusing platform button](gitlab-org/gitlab@9ee00bb75e98d7adde0ca1b886ee8a7bc2be6e43) ([merge request](gitlab-org/gitlab!119193)) +- [Do not touch last_downloaded_at when on a geo secondary](gitlab-org/gitlab@91096e643310a58c0764c291f29a260809a85122) ([merge request](gitlab-org/gitlab!118542)) **GitLab Enterprise Edition** +- [Make it possible to run Puma v6](gitlab-org/gitlab@dbc751f6e956131b5b02acefe4b6c5e6114c740b) ([merge request](gitlab-org/gitlab!119137)) +- [Fix signing-up page renders](gitlab-org/gitlab@d3b0fba80384d035fce185585388de47e2cf9827) by @lyb124553153 ([merge request](gitlab-org/gitlab!119023)) +- [Fix extra social dot divider](gitlab-org/gitlab@e550d668136e9bb36a3740be8cf7fae900603e0e) ([merge request](gitlab-org/gitlab!118314)) +- [Make propmpt_location dynamic, fix spacing in chat](gitlab-org/gitlab@04c4eccffa5cb625d8f88bfdd0f2c1a8ba99d1ad) ([merge request](gitlab-org/gitlab!118899)) +- [Allow individual pages to set super sidebar open on page load](gitlab-org/gitlab@b155dd54a0e5ba6305b0ed094fd70b31de674858) ([merge request](gitlab-org/gitlab!118141)) +- [Fix member source determination in group members report](gitlab-org/gitlab@cb10856be249d615a5db01818f63f9105385f215) ([merge request](gitlab-org/gitlab!118583)) **GitLab Enterprise Edition** +- [Fix Merge request tabs page bundle loading](gitlab-org/gitlab@6d772f5eb5e60e0fb02f1412ccbec09c7efecd2a) ([merge request](gitlab-org/gitlab!119042)) +- [Fixes random questions being answered by Tanuki Bot](gitlab-org/gitlab@058d5e2e1abd496df9224d13db7e0c36d39a78e7) ([merge request](gitlab-org/gitlab!119011)) **GitLab Enterprise Edition** +- [Fix vue3 spec violations for tree_content_spec.js](gitlab-org/gitlab@a22c3944389267f41e3ab8ee94dcaa4ec40abd36) ([merge request](gitlab-org/gitlab!117839)) +- [Fix sidekiq_remove_jobs not to run in transaction](gitlab-org/gitlab@59d9576b77c4bf6a30db98e9deedb21b7fb29bd7) ([merge request](gitlab-org/gitlab!119000)) +- [Reject invalid repository archive request formats](gitlab-org/gitlab@4a6330a30e3ac14263bfc7733ee5c609990d9d51) ([merge request](gitlab-org/gitlab!118996)) +- [Update groups header](gitlab-org/gitlab@a32c0da6a8897a4d611941432cdf6de89a68232c) ([merge request](gitlab-org/gitlab!118977)) +- [Remove global audit events stream page refreshes on edits](gitlab-org/gitlab@c5786eec08c9fa168ebbaaf7e250e55489e0258d) ([merge request](gitlab-org/gitlab!118119)) **GitLab Enterprise Edition** +- [Fix compliance framework creation error on GitLab premium plans](gitlab-org/gitlab@a41049c6f1819bb60e89d823c599b88d7e0bd4fc) ([merge request](gitlab-org/gitlab!118914)) **GitLab Enterprise Edition** +- [Fix expanded avatars list display in the MR widget](gitlab-org/gitlab@de88bea2dd3511260acb5c369c9d12008490e742) ([merge request](gitlab-org/gitlab!118516)) +- [Work item tree tooltip fix](gitlab-org/gitlab@a8029ad669fe1aa701422bb570a443cf0f16fbb1) ([merge request](gitlab-org/gitlab!118894)) +- [User profile fix bg for fixed with layout](gitlab-org/gitlab@5996bffbf518492fe2edb24acbb16152d4a0204e) ([merge request](gitlab-org/gitlab!118597)) +- [Fix cadence description box width](gitlab-org/gitlab@2c7f150adadbe62e61e4d532f40bb33c3358bbd0) ([merge request](gitlab-org/gitlab!118864)) **GitLab Enterprise Edition** +- [Fix search cron worker when indexing is disabled](gitlab-org/gitlab@2a94b16b566228c72490d2638f16341d26a32b9d) ([merge request](gitlab-org/gitlab!118782)) **GitLab Enterprise Edition** +- [Fix invite project members modal closing on error](gitlab-org/gitlab@c0f82c6fa9cd660ceb70e64ce6a2c873f3b2e836) ([merge request](gitlab-org/gitlab!118686)) +- [Vertically align epic colors in dropdown](gitlab-org/gitlab@813568d77ce92edfcad111f66db1bc7dec9c54bb) ([merge request](gitlab-org/gitlab!118685)) +- [Create unique digests for email verification tokens](gitlab-org/gitlab@99afed32979a210e859f1385b92b4827e554582b) ([merge request](gitlab-org/gitlab!118768)) +- [Fix encoding error for commits endpoint](gitlab-org/gitlab@317441419d85afabdc1055468d500c0590337b56) ([merge request](gitlab-org/gitlab!118771)) +- [Fix data in import_sources column of application_settings](gitlab-org/gitlab@d5558470d57353c4fcc8f6c19f114e4e8b1dc76f) ([merge request](gitlab-org/gitlab!118757)) +- [Fix burnup chart line going backwards](gitlab-org/gitlab@e2db423aa2431f273bd7fc3ab414c4824c72f50f) ([merge request](gitlab-org/gitlab!117360)) **GitLab Enterprise Edition** +- [Spread sidekiq jobs on reschedule during github import](gitlab-org/gitlab@63c3102c28c11c2725eff09b80123fde07f6ff35) ([merge request](gitlab-org/gitlab!117720)) +- [Remove transaction in ProcessScanResultPolicyWorker](gitlab-org/gitlab@3e92de4153d422bab0bdf912457d158904d9bf3f) ([merge request](gitlab-org/gitlab!118173)) **GitLab Enterprise Edition** +- [Fail transfer only with namespaced npm packages](gitlab-org/gitlab@4dbff74c96d139e322c90e58a50c1905a0c2b006) ([merge request](gitlab-org/gitlab!95852)) +- [Removes hardcoded path to svg](gitlab-org/gitlab@d7ea2a277d9e513094301e2b1c1c45d7105ba78a) ([merge request](gitlab-org/gitlab!117796)) +- [Fix use of the bootstrap form group with label](gitlab-org/gitlab@88a3eae8dc221c21a32fa6ccb3de68a3b0d4da11) ([merge request](gitlab-org/gitlab!118675)) +- [Bugfix invite members modal](gitlab-org/gitlab@413330a3280f6bec9e70d15b97bce65417ccf196) ([merge request](gitlab-org/gitlab!117538)) +- [Putting CI/CD settings behind appropriate permission levels](gitlab-org/gitlab@affc8d6f07e3cecb19672f8c84dd40db1f9c44a0) ([merge request](gitlab-org/gitlab!117933)) +- [Fix Web IDE Beta icons not loading in Safari](gitlab-org/gitlab@302d94ca386dfba199008a0bb1f201782de27075) by @gitlab-dependency-update-bot ([merge request](gitlab-org/gitlab!118577)) +- [Provide a single line of vulnerable code](gitlab-org/gitlab@2ab3190e1de9394d0b1eb886b74d26fe8601ac01) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118270)) **GitLab Enterprise Edition** +- [Improve Vale's ElementDescriptors rule to catch previous false negatives](gitlab-org/gitlab@985ad711ab0c7039fc2d6837dfa32f7246169355) by @JonstonChan ([merge request](gitlab-org/gitlab!118564)) +- [Fix GraphQL timelog Int overflow bug](gitlab-org/gitlab@cef012af00c81d1ade4b5d2cf089e5b3e6db2bd3) ([merge request](gitlab-org/gitlab!118556)) +- [Fix bug in UpdateApprovalsService when target pipeline is empty](gitlab-org/gitlab@23a47f552012e1dbca60c4d047494f0ca8e60a30) ([merge request](gitlab-org/gitlab!117946)) **GitLab Enterprise Edition** +- [Fix broken mermaid markdown rendering of milestone detail views](gitlab-org/gitlab@e45642f17f213646c8535faa2ca01fac771791d7) by @gerardo-navarro ([merge request](gitlab-org/gitlab!117444)) +- [Use consistent orange color for low severity](gitlab-org/gitlab@bb73786233a7cb7199d1538253cd2cd14f089c98) ([merge request](gitlab-org/gitlab!118050)) +- [Get rid of infinite work item calls in work item modal](gitlab-org/gitlab@b7740186a7ecb7ab534bab821f01f1d7a365145a) ([merge request](gitlab-org/gitlab!118468)) +- [Improve Vale's CIConfigFile rule to catch previous false negatives](gitlab-org/gitlab@42a58912f274e53425de84337eaa66f5135606ff) by @JonstonChan ([merge request](gitlab-org/gitlab!118426)) +- [Do not block project overview when wiki repository fails](gitlab-org/gitlab@c599b9593d9963e09b1dea0503bcd1788b4df3e6) ([merge request](gitlab-org/gitlab!117270)) +- [Remove `operations_access_level` REST API field](gitlab-org/gitlab@4611c619a852e5c6012707bc41d594cc3f1bd8fe) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117867)) +- [Fix error when scan result policy is missing actions or rules](gitlab-org/gitlab@fcc8094d28784117199754ab0d90042f000d8624) ([merge request](gitlab-org/gitlab!118397)) **GitLab Enterprise Edition** +- [Fix layout of mr widget checkboxes](gitlab-org/gitlab@de716c69bc0af53fd0a427d883e6a6b2ab04393a) ([merge request](gitlab-org/gitlab!117890)) +- [Scroll to job line from hash](gitlab-org/gitlab@ba2a042342280d994b2fc3fb6e7dd50f93f37826) ([merge request](gitlab-org/gitlab!117069)) +- [Fix work item children order by relative position](gitlab-org/gitlab@901a18f28e2f2150362f60e38e7860d137cfbdbf) ([merge request](gitlab-org/gitlab!118055)) +- [Revert "Merge branch 'revert-allow-dots-ff' into 'master'"](gitlab-org/gitlab@5f4938ba576623e8a5ecbed6a21ec2b6127dd3f1) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118355)) +- [Fix assignee avatars alignment on issues list](gitlab-org/gitlab@2f743e80dade40f7fca4653fbbabb25000289d83) ([merge request](gitlab-org/gitlab!118340)) +- [Renders indexes for Jupyter Notebooks](gitlab-org/gitlab@8aa513d68c8a0801eb922f1ca2057c3abcf20cd9) ([merge request](gitlab-org/gitlab!117511)) +- [Set retry limit 2 for Zoekt::IndexerWorker](gitlab-org/gitlab@8a1c8b44e8f837a4ec863447b5535cdea03591e1) ([merge request](gitlab-org/gitlab!118273)) **GitLab Enterprise Edition** +- [Don't index empty or missing repositories in Zoekt::IndexerWorker](gitlab-org/gitlab@df74e49ef96866938f8e97e2e99f22576eb12756) ([merge request](gitlab-org/gitlab!118280)) **GitLab Enterprise Edition** +- [Add max-width and min-width to the chat component](gitlab-org/gitlab@3f730a66eafa6b2c733382edaf4dc3b0d59453e5) ([merge request](gitlab-org/gitlab!118244)) **GitLab Enterprise Edition** +- [Exclude any_approver rule from being marked as invalid](gitlab-org/gitlab@c213cc168689d9a36c2edce66304dbdc8d938df8) ([merge request](gitlab-org/gitlab!118189)) **GitLab Enterprise Edition** +- [Do not require email verification for oAuth users](gitlab-org/gitlab@118ebe58d75ab9e066eaa89869d4c95f53e00c4b) ([merge request](gitlab-org/gitlab!116941)) +- [Include forks in github repository list](gitlab-org/gitlab@3b5c202946b193fa23c635356e9fa44c0b755774) ([merge request](gitlab-org/gitlab!118201)) +- [Fix docs](gitlab-org/gitlab@2c3d00fe153c600bdac23c7b5df89774470ac1b0) ([merge request](gitlab-org/gitlab!118075)) +- [Hide `New project` button if visibility is restricted](gitlab-org/gitlab@e2d017230cb93b63aa950d5c752112303aa62dde) ([merge request](gitlab-org/gitlab!117718)) +- [Ensure wiki errors are bubbled up to its form](gitlab-org/gitlab@509376d45272b49905d2f55e72c2e8dd009daaa5) ([merge request](gitlab-org/gitlab!114499)) +- [Add correct widget list styles to MR dependencies](gitlab-org/gitlab@c7788cd636acb5382fadb9f2215a2b0df2b0873e) ([merge request](gitlab-org/gitlab!118095)) +- [Fix namespace async index creation](gitlab-org/gitlab@0662a1b0a67b82f2c5ea73332b243b6eb49c94fa) ([merge request](gitlab-org/gitlab!118032)) +- [Fix groups appearing for project create/import](gitlab-org/gitlab@85fcb1a7522ec367b0078926e76ac8ea94c3732e) ([merge request](gitlab-org/gitlab!117863)) +- [Fix comments rendering in content editor](gitlab-org/gitlab@e96962c4b56cdca628752d0189a7ae4cabc648c0) ([merge request](gitlab-org/gitlab!117745)) +- [Fix Ci::CommitWithPipeline batch loader key](gitlab-org/gitlab@d7c40107e7e79eef6bebd73b25f03d75e829f100) ([merge request](gitlab-org/gitlab!117739)) +- [Do not use snapshots on single database instances](gitlab-org/gitlab@f70eaafb0e0b4267df9911e11a760f2154d8c345) ([merge request](gitlab-org/gitlab!117055)) -- [Do not autofocus the description field](gitlab-org/gitlab@978ae42ee723d5bc5235115b8ebfd7c67c8d858b) ([merge request](gitlab-org/gitlab!120306)) -- [Fix group blobs search permission when migration is not complete](gitlab-org/gitlab@c718fc80bf2ae389d63760db0c4aa95ec6c67f7e) ([merge request](gitlab-org/gitlab!120159)) **GitLab Enterprise Edition** +### Changed (250 changes) -### Changed (1 change) +- [Merge request sticky header height and border bottom](gitlab-org/gitlab@4277467e6eaa1d50589e6ece4e6c71aeff21c9ae) ([merge request](gitlab-org/gitlab!120390)) +- [Add default organization](gitlab-org/gitlab@d3e9f674a863c848cc285ff4c358a736a74fc490) ([merge request](gitlab-org/gitlab!120118)) +- [Update external status check url visiblity](gitlab-org/gitlab@ec47ab58a97fd451aea35ff161a67d8219af4c61) ([merge request](gitlab-org/gitlab!117675)) **GitLab Enterprise Edition** +- [Upgrade DAST to version 4](gitlab-org/gitlab@7219a974e77b7aea3cabf8d9fa4ed201cca99e74) ([merge request](gitlab-org/gitlab!120250)) **GitLab Enterprise Edition** +- [Added reveal/hide password input to login page](gitlab-org/gitlab@23c575f4f1fcbedb37fefec7785af850151706fd) ([merge request](gitlab-org/gitlab!120137)) +- [Enables the auto_merge_labels_mr_widget feature flag](gitlab-org/gitlab@b76a471900fab5cb9d1f4a6fd34027a845964f2b) ([merge request](gitlab-org/gitlab!120649)) +- [Refactors ml_candidate_show](gitlab-org/gitlab@bcb843fa234395698b862f30fde7c922279ec08c) ([merge request](gitlab-org/gitlab!120451)) +- [Move collaborators import to Advanced import setting](gitlab-org/gitlab@7729b0927c3b072b051b43ac35c36172b0312962) ([merge request](gitlab-org/gitlab!118850)) +- [Update POST `approvals` endpoint](gitlab-org/gitlab@1163f8a8d45fcee2734dc1c7e863976bca9ed0b2) ([merge request](gitlab-org/gitlab!119794)) **GitLab Enterprise Edition** +- [Update package license json schema](gitlab-org/gitlab@509bd10f25dbacb75eab34e88c95180565a00bcd) ([merge request](gitlab-org/gitlab!120124)) **GitLab Enterprise Edition** +- [Remove namespace storage limit dates](gitlab-org/gitlab@7051295485d24633718b8ab1e3497a10e0694116) ([merge request](gitlab-org/gitlab!119464)) **GitLab Enterprise Edition** +- [Add worker behind a feature flag to check missing repositories](gitlab-org/gitlab@b944fdd0838b90a5f5a0c265594e47bc6762ea96) ([merge request](gitlab-org/gitlab!115156)) +- [Disable Compliance pipeline field for Premium licenses](gitlab-org/gitlab@8cc7be8240569d9c5cbba2e950e45c73c1bec622) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119163)) **GitLab Enterprise Edition** +- [Update expires_at column value to 365 days from now when its nil](gitlab-org/gitlab@5f62649dc1261d6866366489fdec0d14ac35a32e) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120239/)) +- [Move code suggestions beta feature to free](gitlab-org/gitlab@0aae1a134c0702bb51b8960e0f6ccc5b0bcbdfd8) ([merge request](gitlab-org/gitlab!120512)) **GitLab Enterprise Edition** +- [Add password complexity to registration features](gitlab-org/gitlab@feb37a6cb0b1054f879d7c610e890ed5e67a2946) ([merge request](gitlab-org/gitlab!119850)) +- [Update environments empty state](gitlab-org/gitlab@c44963ec4839ee1024a5fb05a2755e72e5959b39) by @catinbag ([merge request](gitlab-org/gitlab!119246)) +- [Update new entity pages crumbs](gitlab-org/gitlab@149130e8b3637daf0196b3983a6893fc57308ea6) by @catinbag ([merge request](gitlab-org/gitlab!119153)) +- [Add description_diffs to Registration Features](gitlab-org/gitlab@fc1c16ad72db79fcfb17a5ca03858173edeedba5) ([merge request](gitlab-org/gitlab!120253)) +- [Expose link to runner if admin](gitlab-org/gitlab@3762184436c054f5a80633f6df4b4dd5e0526aed) ([merge request](gitlab-org/gitlab!120008)) +- [Stores job exceptions into sampling artifacts](gitlab-org/gitlab@55ef9cb07b3fe745f71f2607e2cd9607f8e229d8) ([merge request](gitlab-org/gitlab!120365)) +- [Two column format in sign in/up page](gitlab-org/gitlab@1881a4b7775ebc43c1f45c1cb4046f5dbd9601f4) ([merge request](gitlab-org/gitlab!118957)) +- [Move external issue trackers and wikis from Uncategorized to Plan](gitlab-org/gitlab@52cc8c20f00eb816c0414c9492532059c91432ee) ([merge request](gitlab-org/gitlab!120108)) +- [Remove formatting bubble menu](gitlab-org/gitlab@7a783d23551a3eda9176ea743644cc5d4bec25c0) ([merge request](gitlab-org/gitlab!117540)) +- [Add a warning about a db requirement](gitlab-org/gitlab@011b91190d246dd0cd21ff02f5a5081d2aede250) ([merge request](gitlab-org/gitlab!120147)) +- [Gitlab Chat guarded by AI toggle](gitlab-org/gitlab@e577be0f829317774c53d22c06e9e37bf042f50e) ([merge request](gitlab-org/gitlab!120115)) **GitLab Enterprise Edition** +- [Designs: add widget styles](gitlab-org/gitlab@36afbdd1552d6c9a74b44ce99dae3ebb8bdd2630) ([merge request](gitlab-org/gitlab!120439)) +- [Extend dependencies finder to group level](gitlab-org/gitlab@4292e9c515cbc1c9d11ff4700cc7cbaa6a728b03) ([merge request](gitlab-org/gitlab!119664)) **GitLab Enterprise Edition** +- [Set PostgreSQL 13 as the minimum supported version](gitlab-org/gitlab@3df9c4e474dfeaf34e52142ff06b3c37a230d7e4) ([merge request](gitlab-org/gitlab!120551)) +- [Lower ProcessSyncEventsWorker dedupe TTL to 1 minute](gitlab-org/gitlab@fe2cd4abbf6968b192396635e36686d4efeeb76c) ([merge request](gitlab-org/gitlab!120580)) +- [Return `HTTP 410 Gone` status code from `POST /runners` endpoint](gitlab-org/gitlab@de7ac331967b12cd803bbf249a53033ddd940eb7) ([merge request](gitlab-org/gitlab!120421)) +- [Upgrade to doorkeeper-openid_connect v1.8.6](gitlab-org/gitlab@3119ec407bf14a15a973c2a9bdf43b7aebfc4b69) ([merge request](gitlab-org/gitlab!120576)) +- [Disable invalid_scan_result_policy_prevents_merge by default](gitlab-org/gitlab@57e47f56581c3d82a773583346408283e9b3def8) ([merge request](gitlab-org/gitlab!120331)) **GitLab Enterprise Edition** +- [Remove "merged" icon for merge train in activity](gitlab-org/gitlab@1bafd6a03fb73b49b8ec3638a14baa31a5846530) ([merge request](gitlab-org/gitlab!120278)) +- [Add feature flag and show new tab](gitlab-org/gitlab@86c62c1e085bfff5820b6846d99a6c9bbb820987) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119008)) **GitLab Enterprise Edition** +- [Rename `widgets` to panels to align with pajamas guidelines](gitlab-org/gitlab@a1d28d02bd85d707c0dda423da7c3b1c3b7e5fea) ([merge request](gitlab-org/gitlab!120467)) **GitLab Enterprise Edition** +- [Add admin access option to protected branches and tags](gitlab-org/gitlab@ff86117a268ee816ae5e564ffd79f41cc39e7de0) ([merge request](gitlab-org/gitlab!118661)) +- [Adds backfill migration for secure file metadata fix](gitlab-org/gitlab@72dba13b0c43ead962567405f921691589ecdd6f) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120013)) +- [Updates keep rules text for container cleanup policies](gitlab-org/gitlab@f3a2e86615ac7b393732e7f183c65f442eca66c5) ([merge request](gitlab-org/gitlab!120220)) +- [Remove stickyness from Diff Stats Header](gitlab-org/gitlab@73438e9eec2b2e3426c3ec7e1ed660579a43daa2) ([merge request](gitlab-org/gitlab!119773)) +- [Update Scan Result Policy documentation](gitlab-org/gitlab@5bb80f35a57be443be99e266cb6dcd06a40fb35a) ([merge request](gitlab-org/gitlab!120376)) +- [Remove broadcast messages for sign in/sign up flows](gitlab-org/gitlab@368b78e1a4ee6ccc82d0beed4c82e64b0b9e56a6) ([merge request](gitlab-org/gitlab!119702)) **GitLab Enterprise Edition** +- [Change cancel running button](gitlab-org/gitlab@15844ff1726724a9e6ae0e9004c3db10156e622d) ([merge request](gitlab-org/gitlab!119982)) +- [Refactor group level runner registration setting](gitlab-org/gitlab@538bc2f9945d11195b02e304d8a65d944e4558f9) by @markus.ferrell ([merge request](gitlab-org/gitlab!117285)) +- [Reschedule evidences migration from raw_metadata](gitlab-org/gitlab@c49d4dd5f56bc2fda0421042e3a247396404a124) ([merge request](gitlab-org/gitlab!119983)) **GitLab Enterprise Edition** +- [Use correct migration finalisation method](gitlab-org/gitlab@19d1330125270e9443e318914d5386f321be4d7f) ([merge request](gitlab-org/gitlab!119315)) +- [Add Admin Mode to new navigation](gitlab-org/gitlab@359142c12c17bae7b33946d7a421d766365a8a7f) ([merge request](gitlab-org/gitlab!118157)) **GitLab Enterprise Edition** +- [Improve file upload experience in content editor](gitlab-org/gitlab@f5d67de7ad80bb4018e180738e320c50cebb2b82) ([merge request](gitlab-org/gitlab!119156)) +- [Removed autofocus from fields throughout the registration flow](gitlab-org/gitlab@99d02662dc03520c161d8e7acb15e1e56d17fb31) ([merge request](gitlab-org/gitlab!120266)) **GitLab Enterprise Edition** +- [Disable rule mode when vulnerability_states are invalid](gitlab-org/gitlab@db6216238b81af3916ad068370125d2e1e89d152) ([merge request](gitlab-org/gitlab!119636)) **GitLab Enterprise Edition** +- [UI polish: Spacing in runner list](gitlab-org/gitlab@8d221a1488062a035bbc33cd034fa7f0cd622f04) ([merge request](gitlab-org/gitlab!115631)) +- [Cleanup disallow_environment_name_update feature flag](gitlab-org/gitlab@cc290c4ace499a577dfd5df471496bbe5a901d5b) ([merge request](gitlab-org/gitlab!120218)) +- [Clarify iteration rollover depends on timezone](gitlab-org/gitlab@8c4c4cc2373cca28a6e1169e00410ab98dac457d) ([merge request](gitlab-org/gitlab!118861)) **GitLab Enterprise Edition** +- [Remove user legacy Web IDE toggle](gitlab-org/gitlab@28a48cff993a3963222fddb6f8346f25519687ca) ([merge request](gitlab-org/gitlab!120063)) +- [Schedule database index on members](gitlab-org/gitlab@7ddd3121e4b1c5798c2933561e5cdddaf9cb00b4) ([merge request](gitlab-org/gitlab!119317)) +- [Ignore temp schema objects](gitlab-org/gitlab@37a870af9fe3a28380bb542bf7d44b0ca23689b8) ([merge request](gitlab-org/gitlab!118253)) +- [Notify KAS on git push events](gitlab-org/gitlab@ee18d545ed93da25eb14ef353f9d0bf1ac275168) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119168)) +- [Refactor compliance framework create/edit to modals](gitlab-org/gitlab@538559f57b445a69ed3979135f7762c0e63e30c6) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119581)) **GitLab Enterprise Edition** +- [Upgrade to Gemnasium v4](gitlab-org/gitlab@1fef0f1257dfb4fe5f678817e232803c1394b398) ([merge request](gitlab-org/gitlab!119313)) **GitLab Enterprise Edition** +- [Disable importers by default in new self-manages instances](gitlab-org/gitlab@4c29b955666b4cd57a408591049d126bb0100cf1) ([merge request](gitlab-org/gitlab!118970)) +- [Add tooltips to jobs table actions](gitlab-org/gitlab@6e556a478c4641f776c5f8a1a0001c1d705857ed) ([merge request](gitlab-org/gitlab!119782)) +- [Add extra instructions for self-managed setup](gitlab-org/gitlab@23ac8358680c88076c589163c364a7a9c96e7d81) ([merge request](gitlab-org/gitlab!120061)) +- [Enable New Environment Details Page](gitlab-org/gitlab@71c975e95cac17498345ced8e9d7936a7329f67a) ([merge request](gitlab-org/gitlab!120164)) +- [Update layout of admin labels page](gitlab-org/gitlab@34fc5854d6144225447caab6035aa4979aaddcd1) ([merge request](gitlab-org/gitlab!119400)) +- [Fixes incorrect expiration date in secure files metadata](gitlab-org/gitlab@0891cb31846252b87748c26be17c66a75b792fb0) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119805)) +- [Add metrics to GCP banner](gitlab-org/gitlab@297ab59732e191fb36f3fb512b0a4f55b13afb8c) by @asadath1395 ([merge request](gitlab-org/gitlab!119940)) +- [Add filter by package_name for dependencies](gitlab-org/gitlab@6edddcd974cadaea91feb343d5ba253d489f2831) ([merge request](gitlab-org/gitlab!119219)) **GitLab Enterprise Edition** +- [Updated hide/reveal password input to be reuseable](gitlab-org/gitlab@f3c18b6de227c3fffb30b023a84159c299461434) ([merge request](gitlab-org/gitlab!119635)) +- [Unlink achievement visibility from namespace visibility](gitlab-org/gitlab@472dd9ce01326cf543ffe9aafe3e7aa5dc8bb1c7) by @Taucher2003 ([merge request](gitlab-org/gitlab!119384)) +- [Hide banner when subscription is already on cloud licensing](gitlab-org/gitlab@fb34f3323949c3af7948e83406acb6d1555050c4) ([merge request](gitlab-org/gitlab!119565)) **GitLab Enterprise Edition** +- [Removed autofocus on fields throughout the registration flow](gitlab-org/gitlab@bf87b808b5c2d56f19eb5369c37b9b0ab574d473) ([merge request](gitlab-org/gitlab!119682)) **GitLab Enterprise Edition** +- [Update status and policy drawer tab titles](gitlab-org/gitlab@a760d5d5a2e609dc7a3e7fa42d92ae76402d9d75) ([merge request](gitlab-org/gitlab!120083)) **GitLab Enterprise Edition** +- [Reorganize Analytics tab in general settings](gitlab-org/gitlab@b2886c76b5361ba4b2ba72bbfee32953843fe51b) ([merge request](gitlab-org/gitlab!119059)) **GitLab Enterprise Edition** +- [Migrate all daily aggregated RedisHLL events to weekly](gitlab-org/gitlab@867bb428de8690edf0f67ad551cd0067d1befcea) ([merge request](gitlab-org/gitlab!114967)) +- [Adapt status filtering to support new values](gitlab-org/gitlab@c9a5a01caf5721f7fd950aa26b49591250664078) ([merge request](gitlab-org/gitlab!119475)) **GitLab Enterprise Edition** +- [Enable mirror only branches match regex feature flag by default](gitlab-org/gitlab@d518d984ed7845e18032054e2229e21a3c4bb5db) by @lyb124553153 ([merge request](gitlab-org/gitlab!117613)) **GitLab Enterprise Edition** +- [Increment the major version of DAST API and API Fuzzing](gitlab-org/gitlab@9852d02d861e8a8e41d4f606c8b316fd3d97f451) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119126)) **GitLab Enterprise Edition** +- [Clarify message about no analytics data to show](gitlab-org/gitlab@6d9a1debbba92ddb7d1a3157db7e71135ec44687) ([merge request](gitlab-org/gitlab!119663)) +- [Rescue errors when dropping pg_stat_statements view](gitlab-org/gitlab@32a29441b6239ce2bdfca4fc202c797ad2967bf1) ([merge request](gitlab-org/gitlab!118830)) +- [Support deduplicated package licenses](gitlab-org/gitlab@e14635124bb0ef2b189a08ee07857213a9228eb8) ([merge request](gitlab-org/gitlab!119265)) **GitLab Enterprise Edition** +- [Mark environment URLs as unsafe](gitlab-org/gitlab@afdb29abe57f8f99338e45389b61c5d8bbaf0775) ([merge request](gitlab-org/gitlab!119241)) +- [Fix runtime check for Puma v6](gitlab-org/gitlab@9ff62e402e83827a95d7d3bab1963e1774b3ec79) ([merge request](gitlab-org/gitlab!119684)) +- [Allow just one parallel job](gitlab-org/gitlab@f9274efa03c330f429b494394ed397e2e00548e1) by @mcfedr ([merge request](gitlab-org/gitlab!118774)) +- [Remove IncubationAlert from ml_experiments_show](gitlab-org/gitlab@97289429db509e34adc6ec383a79f57eaf40a4c9) ([merge request](gitlab-org/gitlab!119674)) +- [Update Settings/Pages layout](gitlab-org/gitlab@18fbc4f01e7af975d8b2053330843344200d2c81) by @catinbag ([merge request](gitlab-org/gitlab!119211)) +- [Remove Incubation Alert from ml_experiments_index](gitlab-org/gitlab@81c85dcc35f9383b007cd328bedcfddf3ef1f128) ([merge request](gitlab-org/gitlab!119671)) +- [Delayed deletion, enabled by default](gitlab-org/gitlab@336cf08b089b49d5abeb8bb9be6544a289c1247d) ([merge request](gitlab-org/gitlab!119606)) +- [Removes Incubation alert from ml_candidate_show](gitlab-org/gitlab@577fab34c147022ab876795b636fa878a9f9a030) ([merge request](gitlab-org/gitlab!119593)) +- [Cleanup environment_search_api_min_chars feature flag](gitlab-org/gitlab@d76dba79c662dc96c2480c8389b3a919d11566a2) ([merge request](gitlab-org/gitlab!118579)) +- [Updates mermaid to 10.0.2](gitlab-org/gitlab@67ca1e06df2ce253a33d30bc44e45804e72e9b95) ([merge request](gitlab-org/gitlab!115885)) +- [Mark `project_fingerprint` as experiment](gitlab-org/gitlab@30e2db26d5bcb17cefb05aa9fb50df877d93508c) ([merge request](gitlab-org/gitlab!119921)) **GitLab Enterprise Edition** +- [Enable restrict_merge_status_recheck feature flag](gitlab-org/gitlab@07781de9e2f107f99911088aa4d4a1feddf139a6) ([merge request](gitlab-org/gitlab!119901)) +- [Remove feature flag ci_builds_columns_size_validation](gitlab-org/gitlab@9a6a03863fbf54cba420125d1e9ac51386a7b544) ([merge request](gitlab-org/gitlab!119450)) +- [Used GlBroadcastMessage for table preview](gitlab-org/gitlab@d86856c4784c36b1e9ea077d51dc4ab6eb43f786) by @catinbag ([merge request](gitlab-org/gitlab!119873)) +- [Default to two database connections for source install](gitlab-org/gitlab@b43e8ab7dfb8f17a9982f141e8642099911d3903) ([merge request](gitlab-org/gitlab!119139)) +- [Remove sub-nav transition animation in new sidebar](gitlab-org/gitlab@df0075a6282f74bff76aa870a466c5cc45408c89) ([merge request](gitlab-org/gitlab!119801)) +- [Update tags list](gitlab-org/gitlab@7211153c599e7be901c7ec6cd9fb2915c2576ae3) ([merge request](gitlab-org/gitlab!119536)) +- [Remove draft_quick_action_non_toggle feature flag](gitlab-org/gitlab@52c9e9239fa07bfb5c146a783ef19c2458e3d00f) ([merge request](gitlab-org/gitlab!119756)) +- [Remove Blame page streaming feature flag](gitlab-org/gitlab@6614a56c21419194f54d3f01230f2fccbcb04b6b) ([merge request](gitlab-org/gitlab!119752)) +- [Enable password check on registration trial page](gitlab-org/gitlab@f4423764bf4b063e31b8d9114e16fe979d533b68) ([merge request](gitlab-org/gitlab!119745)) +- [Upgrade `kas-grpc` gem to `0.1.0`](gitlab-org/gitlab@1878b1ca39b4461b32ed5b197d6c4a889762a520) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119077)) +- [Linear groups finder queries](gitlab-org/gitlab@7841d80023a918d9fb38bb50be64f5c9c7b9da25) ([merge request](gitlab-org/gitlab!119725)) +- [Update gitlab pages](gitlab-org/gitlab@510da28cf121ceb7d25c02faeeb65d73dcd23980) ([merge request](gitlab-org/gitlab!119719)) +- [Disable automatic Todo creation for approvers](gitlab-org/gitlab@4f5b122b41e0f61104fc2707fbfd12080266f898) ([merge request](gitlab-org/gitlab!119703)) **GitLab Enterprise Edition** +- [Update commits list UI](gitlab-org/gitlab@9a24fa229794ba81b51bfa694eb42f1a39b245fb) ([merge request](gitlab-org/gitlab!119521)) +- [Ensure all CI config loading uses correct loader](gitlab-org/gitlab@dc3447fa262ab324062c2f2ffe09f030e1c315ce) ([merge request](gitlab-org/gitlab!118639)) +- [New layout for editors](gitlab-org/gitlab@2b89b7f8a2550abcf792151f99e2e469d2885d86) ([merge request](gitlab-org/gitlab!117734)) +- [Note actions: Dropdown migration to use Disclousre dropdown](gitlab-org/gitlab@32e124a4dd6d912f162f4094b452ff7d34f376be) ([merge request](gitlab-org/gitlab!117643)) +- [Fix inconsistencies in new file form](gitlab-org/gitlab@1dd21396af196cf6a42c4ff4ac6c3479c6f41417) ([merge request](gitlab-org/gitlab!119563)) +- [Add empty state for jobs tab in runner details](gitlab-org/gitlab@b487fb88f602a72f6947d10d25e8fa6fd80fdfff) ([merge request](gitlab-org/gitlab!119051)) +- [Preselect trial on namespace if started inside namespace](gitlab-org/gitlab@f6bd4a23bce506c7e5bc2186c7c202c27ca00bce) ([merge request](gitlab-org/gitlab!119247)) **GitLab Enterprise Edition** +- [Capture GRPC::ResourceExhausted error](gitlab-org/gitlab@55aa2f14f8654a7b7a493c0897761c5657d8a597) ([merge request](gitlab-org/gitlab!119054)) +- [Extract subscriptions comparison url to saas.rb](gitlab-org/gitlab@a2994551e1be6b4008458385595fb2537c65c0b5) by @orozot ([merge request](gitlab-org/gitlab!119620)) **GitLab Enterprise Edition** +- [Make operators prop required for NumberRangeSelect](gitlab-org/gitlab@02bf06017b1fabd6f435f1af36299860e69e0b6f) ([merge request](gitlab-org/gitlab!119618)) **GitLab Enterprise Edition** +- [Record first_contribution for all contributors](gitlab-org/gitlab@66cf9bfb19abff227e15f102f10aa8c01e123a9a) ([merge request](gitlab-org/gitlab!119523)) +- [Add empty state for jobs tab in runner details](gitlab-org/gitlab@50cd48229a3a86b6fbeade00a3d2089d32b53f96) by @glauciellesa ([merge request](gitlab-org/gitlab!119360)) +- [Enable invalid_scan_result_policy_prevents_merge by default](gitlab-org/gitlab@b714f06062bd59eb0531816c7f660906b5a632ca) ([merge request](gitlab-org/gitlab!119609)) **GitLab Enterprise Edition** +- [Add issue description to thank you email in SD](gitlab-org/gitlab@1218604e0893eeb7d4e700cccb5ccce55a731326) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118731)) +- [Branches list: move delete branches button into dropdown](gitlab-org/gitlab@c32ab435ef23b6eaebf92eb9e8f22d738d4c87ac) ([merge request](gitlab-org/gitlab!119516)) +- [Disallow negative integers for vulnerabilities_allowed](gitlab-org/gitlab@0ba1054eaf7273edf728c63ae490d153fd3313b7) ([merge request](gitlab-org/gitlab!119595)) **GitLab Enterprise Edition** +- [Disable rule mode when vulnerabilities_allowed is invalid](gitlab-org/gitlab@84e219c452f4bae38168176cb2da3a6e5bfa1edb) ([merge request](gitlab-org/gitlab!118919)) **GitLab Enterprise Edition** +- [Initialize the migration to convert pk for ci_pipeline_variables](gitlab-org/gitlab@178c8157063746da79638c565dabd8ac773a4c67) ([merge request](gitlab-org/gitlab!118878)) +- [Set jira_dvcs_end_of_life_amnesty to default false](gitlab-org/gitlab@d920dcafcd322ea7a58537092e1af6b29774ff9c) ([merge request](gitlab-org/gitlab!119575)) +- [Confirm before disabling group shared runners](gitlab-org/gitlab@5d816647801f44e5edbc10da664ffbb570399e2d) ([merge request](gitlab-org/gitlab!119288)) +- [Update snippet form](gitlab-org/gitlab@5d35bd62072bc3f58fa9730bfbed7e7b79a92007) ([merge request](gitlab-org/gitlab!119558)) +- [Displays latest pipeline on package list page](gitlab-org/gitlab@121ddfea4bd5bbe643f1202b4a7863dc66cfc8ad) ([merge request](gitlab-org/gitlab!118366)) +- [Streamline notification style for deleting release](gitlab-org/gitlab@fa29703f9e810146022a9720dfeb722184bc60b9) by @catinbag ([merge request](gitlab-org/gitlab!118694)) +- [Restyle integrated error details info](gitlab-org/gitlab@00a1f96d42628716f6ffaeb31a4b586f23f0f2c4) ([merge request](gitlab-org/gitlab!118917)) +- [Branches list: Improve list styling](gitlab-org/gitlab@9bc059fb5b32e6835e2c7b3accb1caac4e69fa7e) ([merge request](gitlab-org/gitlab!119505)) +- [Add backend for exporting compliance frameworks](gitlab-org/gitlab@7ba7be4be149dab3deb1b09dd70d4277c7290460) ([merge request](gitlab-org/gitlab!117471)) **GitLab Enterprise Edition** +- [Removed DORA metrics tiles from VSA Overview page](gitlab-org/gitlab@ebf1d053475e51fc0a1d859d94417ed01a98e44f) ([merge request](gitlab-org/gitlab!119110)) +- [Add screen reader title to broadcast message](gitlab-org/gitlab@c34a660c8bd5af6f6f9e70fcaf1d21f846fa0cab) ([merge request](gitlab-org/gitlab!118200)) +- [Reaction: Remove toast](gitlab-org/gitlab@3fecc52f87e9101196c6cdb5ef83d0ed3eed774d) ([merge request](gitlab-org/gitlab!119463)) +- [Show alert when shared runners setting is disabled](gitlab-org/gitlab@e4a69501974012e62c50f4ad5414cf3d4802b406) ([merge request](gitlab-org/gitlab!119321)) +- [Add first_contribution field to MR metrics](gitlab-org/gitlab@f8df4215f676c0d16ab6eafa2e374855811e6053) ([merge request](gitlab-org/gitlab!116844)) +- [Remove route_hll_to_snowplow_phase3 FF](gitlab-org/gitlab@79b9b1ca71e58802b41815f56e0bed14a7decdae) ([merge request](gitlab-org/gitlab!119436)) +- [Add advisories to package metadata](gitlab-org/gitlab@ea54222683dc419fe48a956ed7503781b8bdd175) ([merge request](gitlab-org/gitlab!117326)) **GitLab Enterprise Edition** +- [Hides users from protected branch setting dropdown](gitlab-org/gitlab@5af9e6e531e135f2df705beece5ded569b17467b) ([merge request](gitlab-org/gitlab!119382)) **GitLab Enterprise Edition** +- [Use native number input for weight on "New issue" form](gitlab-org/gitlab@6bf46305b5d1e84810e999e89e7207dad1384ed8) ([merge request](gitlab-org/gitlab!118958)) **GitLab Enterprise Edition** +- [Success alert when runner is assigned to project](gitlab-org/gitlab@6e2e0a6e6164fc5cd15ece9ac8c0bd586d09a126) ([merge request](gitlab-org/gitlab!119325)) +- [Bump major version of secrets](gitlab-org/gitlab@e9cfb1df76b6460999dd992ba3e31d5c68465785) ([merge request](gitlab-org/gitlab!118833)) +- [Renamed View Merged YAML to Full configuration](gitlab-org/gitlab@6d9298fa32539ac4dc4be63e676164765f36e08a) by @catinbag ([merge request](gitlab-org/gitlab!118815)) +- [Update dependency auto-deploy-image to v2.48.2](gitlab-org/gitlab@145802bab2766e4f0dca12b08c4ab8a1df6963c1) ([merge request](gitlab-org/gitlab!119343)) +- [Update edit issuables button to bulk edit](gitlab-org/gitlab@78d3bdbefc53fdb167a9914043710931048403b7) ([merge request](gitlab-org/gitlab!119337)) +- [Avoid redundant job refetching](gitlab-org/gitlab@b4509c1d77dc1124d4bd40963decf1f16a0ab3ae) by @TrueKalix ([merge request](gitlab-org/gitlab!119304)) +- [Disable Role-based Approvals for Guests/Reporters](gitlab-org/gitlab@7408a147a861bf4887f6d8830245510b49ec5673) ([merge request](gitlab-org/gitlab!118851)) **GitLab Enterprise Edition** +- [Change color function to check for relative luminance](gitlab-org/gitlab@7f100c449946781ce6ae49507fcea6d9da71dd85) ([merge request](gitlab-org/gitlab!118622)) +- [Initialize the migration to convert pk to bigint for ci_pipelines](gitlab-org/gitlab@b7f4df334359be05f15da6f5a94dbcb218b02b5a) ([merge request](gitlab-org/gitlab!118136)) +- [Add info popover to status checks](gitlab-org/gitlab@5514324e8735b097b701cf6fb729759ac8cb4594) ([merge request](gitlab-org/gitlab!117952)) **GitLab Enterprise Edition** +- [Swap system_note_metadata.note_id to bigint](gitlab-org/gitlab@68fd004dc97b4d07babb407d9ad20c71d8c5e270) ([merge request](gitlab-org/gitlab!117343)) +- [Add allowed vulnerabilities number information to policy drawer](gitlab-org/gitlab@50ab9cb9cfd4569fdb05a19086747b93c55af747) ([merge request](gitlab-org/gitlab!118926)) **GitLab Enterprise Edition** +- [Update prometheus-client-mmap to v0.23.0](gitlab-org/gitlab@c4ba879cb0b73860e0c97dc598327fc2c0450cc0) ([merge request](gitlab-org/gitlab!119236)) +- [Update sast analyzer major versions](gitlab-org/gitlab@622df2d9f5cbba63562cea008b07b52506a1637e) ([merge request](gitlab-org/gitlab!118836)) +- [Use new priority label illustration in empty state](gitlab-org/gitlab@20b6bc98aae904572f8a57f876fdd1f0812fc7c1) ([merge request](gitlab-org/gitlab!119200)) +- [Release reading fingerprints from UploadedFile instance in maven upload](gitlab-org/gitlab@f66951861df17ef424b593400f24620f5770d673) ([merge request](gitlab-org/gitlab!119183)) +- [Remove package icon from package row](gitlab-org/gitlab@4bd2976e78e4ec192d071d5dabc3975cbf5ec7bf) by @catinbag ([merge request](gitlab-org/gitlab!118794)) +- [This MR adds preserving state of selected filters](gitlab-org/gitlab@d76c37091f620e1e3f2bf005b2b1d2e725fdbe51) ([merge request](gitlab-org/gitlab!118852)) **GitLab Enterprise Edition** +- [Splits mlflow.rb into multiple files](gitlab-org/gitlab@c2e67e78acbeefb0421f804d3ea2a54145368cf6) ([merge request](gitlab-org/gitlab!118762)) +- [Remove admin override for ProtectedRef Access](gitlab-org/gitlab@edab23e145742bea7cf4af29dca7383e45c2d7e6) ([merge request](gitlab-org/gitlab!118532)) +- [Remove unnecessary attributes for filters in vulnerability_filters.vue](gitlab-org/gitlab@4021af090776d043db85454287bbc2aaa65c1480) ([merge request](gitlab-org/gitlab!119129)) **GitLab Enterprise Edition** +- [Update stackprof to v0.0.25](gitlab-org/gitlab@9e95beec6951a45d155f5802b538a20e16e98233) ([merge request](gitlab-org/gitlab!119127)) +- [Remove strict_ip_enforcement feature flag for universal enablement](gitlab-org/gitlab@4495eed6cf491e3cf154dd3cfa5ed8ae32cd65a4) ([merge request](gitlab-org/gitlab!119106)) +- [Update labels page design](gitlab-org/gitlab@e51252fe36563381d16973e8ddd8a93658dd814e) ([merge request](gitlab-org/gitlab!118381)) +- [Fetch traces only when on tab](gitlab-org/gitlab@1808df0546a459e008e7bd1fbc7dc89af74dc396) ([merge request](gitlab-org/gitlab!118549)) +- [Add a note to about Azure Database for PostgreSQL Flexible Server](gitlab-org/gitlab@92956d28bd029db7fb9cdea6f553b29d1466ed8e) ([merge request](gitlab-org/gitlab!118994)) +- [Enable GraphQL subscription load balancing](gitlab-org/gitlab@da86d4367808f30d2fcba6032a380905e3591dde) ([merge request](gitlab-org/gitlab!119076)) +- [Retain selection in content editor on blur](gitlab-org/gitlab@98c9d35418cee4610d0c2d0f3df195cafbd3e504) ([merge request](gitlab-org/gitlab!117752)) +- [Change warning text when adding a related issue as a Guest](gitlab-org/gitlab@45cb3b381944b34de82c451d79565bcc83c3e3d2) by @LXY1226 ([merge request](gitlab-org/gitlab!115119)) +- [Add sorting for the dependencies_resolver](gitlab-org/gitlab@ddd8146664eb70482b099303de65811f074bbbdd) ([merge request](gitlab-org/gitlab!116976)) **GitLab Enterprise Edition** +- [Never show security configuration upgrade banner in CE](gitlab-org/gitlab@666ed4f160ce14177bff63ec6bcf2c7ebe284566) ([merge request](gitlab-org/gitlab!119047)) +- [Select range for allowed vulnerabilities using dropdown](gitlab-org/gitlab@ab1580a05505300a416a270f2fcca8f89d9d0da7) ([merge request](gitlab-org/gitlab!118902)) **GitLab Enterprise Edition** +- [Pass namespace in the params](gitlab-org/gitlab@ed5235b107f1bbead60dc091f87e052ec338cfb2) ([merge request](gitlab-org/gitlab!118339)) **GitLab Enterprise Edition** +- [Add rake task to maintain Geo SSF metric schema](gitlab-org/gitlab@6389a012cd5d9020f43e392bde63640b613cbc3a) ([merge request](gitlab-org/gitlab!117931)) **GitLab Enterprise Edition** +- [Restrict cleanup migrations only for GitLab.com](gitlab-org/gitlab@6ebf1d5e59ed7c0f0b7ff962eab5ec6ccb0ed3cd) ([merge request](gitlab-org/gitlab!118999)) +- [Remove group_analytics_dashboards_page feature flag](gitlab-org/gitlab@5328f768027343f3cefc29c1e29b8dd66bfe4309) ([merge request](gitlab-org/gitlab!117846)) +- [Add buttons to access docs and copy Terraform init command](gitlab-org/gitlab@f15fad575f9e2e75e5372e2f90f7c0567398adc7) by @glauciellesa ([merge request](gitlab-org/gitlab!118593)) +- [Upgrade Container Scanning analyzer to version 6](gitlab-org/gitlab@848045b9cb6e5bb87cdc9fc97e1cf6d682ad4132) ([merge request](gitlab-org/gitlab!118947)) **GitLab Enterprise Edition** +- [Combine import, export, and subscribe options into dropdown](gitlab-org/gitlab@8a1c5c350ba0fb47daa1ccbcabadf6ee5b9c3c95) ([merge request](gitlab-org/gitlab!114157)) +- [Cleanup legacy_merge_request_state_check_for_merged_pipelines flag](gitlab-org/gitlab@5d9c96eb89f8d177e7cd805ca9ee7c5f61180ea4) ([merge request](gitlab-org/gitlab!118886)) +- [Update cluster management project template to latest revision](gitlab-org/gitlab@00e8f2342b985ccfda05fb2bc3ba19e4dddd6c89) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118161)) +- [Remove redundant alert message for CI/CD variables setting](gitlab-org/gitlab@5501911072a499ac9aef260275e224ea86154ed7) ([merge request](gitlab-org/gitlab!118727)) +- [Add support for separate wiki index](gitlab-org/gitlab@3dd30db869b8cede40c8f02e707169d9de14aca1) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/107365)) **GitLab Enterprise Edition** +- [Update docs and Rake task to require Redis 6](gitlab-org/gitlab@9554ce88f3523842290dba0dd764e22cb40bf26f) ([merge request](gitlab-org/gitlab!118448)) +- [Sign ansi2json state by default](gitlab-org/gitlab@51804299525a2c88f902f76fa964f7e25ee34e4f) ([merge request](gitlab-org/gitlab!118817)) +- [Update user admin header](gitlab-org/gitlab@cdc62c588dba0baad6bd3fedc337a20d185809d7) ([merge request](gitlab-org/gitlab!118533)) +- [Hide borders when entering admin mode - 2](gitlab-org/gitlab@7899dc983d2e557b45acf93bdf70b0b6e01b28ea) ([merge request](gitlab-org/gitlab!118798)) +- [Group import/export requirements button into dropdown](gitlab-org/gitlab@f37a7e9208cb0cda82bf8e6950eb24e84e30446a) ([merge request](gitlab-org/gitlab!118770)) +- [Improve TeleSign logging](gitlab-org/gitlab@0f7e976c8cd8610a4857cf6efb949d19ae34816a) ([merge request](gitlab-org/gitlab!117959)) **GitLab Enterprise Edition** +- [Support custom format in getTimeago](gitlab-org/gitlab@4a882fe473fe0fbcd9240e95406345b7464a2fd1) ([merge request](gitlab-org/gitlab!117576)) +- [Make name in ScanExecutionPolicyCommit mutation mandatory](gitlab-org/gitlab@e45080df8fc5e6e9625e36a3257504fabbd23642) ([merge request](gitlab-org/gitlab!118272)) **GitLab Enterprise Edition** +- [Move edit compliance form into modal](gitlab-org/gitlab@018d844ef5654a60bdd5621bef5120fc41687a14) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/113641)) **GitLab Enterprise Edition** +- [Remove margin class from related item component](gitlab-org/gitlab@93fda5179b043b5df1763be217ced4a569fd488d) ([merge request](gitlab-org/gitlab!118713)) +- [Remove border on merge request sticky header](gitlab-org/gitlab@cd8ce70f1f6c293a9059703d490735ea58c34b4b) ([merge request](gitlab-org/gitlab!118680)) +- [Remove "hash form" support in alert management router](gitlab-org/gitlab@d2cde19d0af885e54a990b851a9d3e13eac37ded) by @ali_o_kan ([merge request](gitlab-org/gitlab!105638)) +- [Implement timeout for the blockquote banzai filter](gitlab-org/gitlab@8453c4195e4f5e6775f14b8e6860a1f064ae678e) ([merge request](gitlab-org/gitlab!118560)) +- [Remove unused shortcuts](gitlab-org/gitlab@289056b8aa90d9d8aa67b25f96fa9869515c2d19) ([merge request](gitlab-org/gitlab!118311)) +- [Add runner_id, runner_environment and sha claims to CI JWT V2](gitlab-org/gitlab@f01ddf0e655989251a6d9ba7c0cc11ad67721aef) ([merge request](gitlab-org/gitlab!116867)) +- [Activity sort filter dropdown migration](gitlab-org/gitlab@473323400c74d78f63cb8040b5acf3d8b765ad4f) ([merge request](gitlab-org/gitlab!117658)) +- [Add running Scan Execution Policies for merge_request_event pipelines](gitlab-org/gitlab@467f799a3697887000dd07f9379e3dcfec359b8b) ([merge request](gitlab-org/gitlab!118388)) +- [This MR adds empty state selector](gitlab-org/gitlab@c1115c959118634b79554cca9b4a0b899632dc0a) ([merge request](gitlab-org/gitlab!118245)) **GitLab Enterprise Edition** +- [Unscope i18n strings that are incorrectly scoped in HAML files](gitlab-org/gitlab@e9672f1160c9235d8588ff26b958ba26ba2745da) by @JonstonChan ([merge request](gitlab-org/gitlab!118574)) +- [Improve job fixutre](gitlab-org/gitlab@1ef435e48f65dfdd2b5c39ebdd215f2a83b8a2b2) by @TrueKalix ([merge request](gitlab-org/gitlab!118508)) +- [GraphQL: Change runner.projects default sort](gitlab-org/gitlab@c490069a3fc0e56d4126add42c727eaa04e0ee78) ([merge request](gitlab-org/gitlab!117904)) +- [Action Cable metrics: add labels to transmit](gitlab-org/gitlab@b698aea25d2438a9571b3722932c5f37e18dba4c) ([merge request](gitlab-org/gitlab!117411)) +- [Add data to Code Quality MR diff json](gitlab-org/gitlab@e7e364e5b21d05680197b0aa4ec36b0d3792d44e) ([merge request](gitlab-org/gitlab!117169)) +- [FOSS VSA spec reflects component dir structure](gitlab-org/gitlab@f357f245f9d7212e0d9ca466824a2a636142893f) by @catinbag ([merge request](gitlab-org/gitlab!118377)) +- [Rename include:with to include:inputs](gitlab-org/gitlab@06ab2377ac3781bffa7fed4553bd6107ba01d2c6) ([merge request](gitlab-org/gitlab!118352)) +- [Update parsing of *_DISABLED variables](gitlab-org/gitlab@15250a6d9328603b4e75f5a55d6e0fb5e1fe13cb) ([merge request](gitlab-org/gitlab!118232)) +- [Refactor/Clean up users specs](gitlab-org/gitlab@3979272113984dee15ed0a64b28d7d655a77352b) by @TrueKalix ([merge request](gitlab-org/gitlab!117359)) +- [Disallow NO_ACCESS for UnprotectAccessLevel#access_level](gitlab-org/gitlab@524316d4ec76aaa6dd62ac6118bf0c2e330df9ad) ([merge request](gitlab-org/gitlab!117689)) **GitLab Enterprise Edition** +- [Clean up soft_email_confirmation ff](gitlab-org/gitlab@b5c408c4611b022d65d4f7dae2b72274a93601f5) ([merge request](gitlab-org/gitlab!117291)) +- [Move edit label action into dropdown](gitlab-org/gitlab@97fa8b5e581538816c27db4a9616ddc3a219ef0f) ([merge request](gitlab-org/gitlab!118080)) +- [Preinstall prettier for gitpod](gitlab-org/gitlab@f3b08450636869dfa6597a6b9832911172147ea5) ([merge request](gitlab-org/gitlab!118497)) +- [Hide borders when entering admin mode](gitlab-org/gitlab@72064bdd3afc1cfe7cbb54e46d44cca4f8aa0362) ([merge request](gitlab-org/gitlab!118333)) +- [Replaced Feature flag to reduce aggregation schedule lease](gitlab-org/gitlab@4ac4dff52fd8e6b18a5d758021b7ea5eaba92071) ([merge request](gitlab-org/gitlab!118472)) +- [Adapt MR widget to support fail-closed approval rules](gitlab-org/gitlab@b9febcba51b0dec3b1e66d724f0e44d5b49c9779) ([merge request](gitlab-org/gitlab!118214)) **GitLab Enterprise Edition** +- [Update vendored Express project to match project template](gitlab-org/gitlab@8ae68db6dca1ca1056127cafc09ff2f7a1e37c34) by @JonstonChan ([merge request](gitlab-org/gitlab!118437)) +- [Improve repo forking layout](gitlab-org/gitlab@89dd3e3a44e4b3e68f6cb8f6b57a5535aaec0bc3) by @catinbag ([merge request](gitlab-org/gitlab!118529)) +- [Simplify this_desctructuring in components](gitlab-org/gitlab@be7f2be77508930450a5c21b3f9dd7228d10b74a) by @catinbag ([merge request](gitlab-org/gitlab!118421)) +- [Set approval rule as invalid if there are not enough approvers](gitlab-org/gitlab@e90fe1f99b54557ecc5588bedf13c6ecab5ec1af) ([merge request](gitlab-org/gitlab!117557)) **GitLab Enterprise Edition** +- [Make new label form pajamas-compliant](gitlab-org/gitlab@9ee44b0bdc6c6b90026e23117db7b69c689c3109) ([merge request](gitlab-org/gitlab!118104)) +- [Update admin labels page](gitlab-org/gitlab@9358e751dc9c927232152a8a828f787edaa82eed) ([merge request](gitlab-org/gitlab!118391)) +- [Update Value Streams Dashboard title and description](gitlab-org/gitlab@6ddc00f559bb73604c46e62668b919ad0603e859) ([merge request](gitlab-org/gitlab!118257)) **GitLab Enterprise Edition** +- [Create a utils helper to generate date ranges](gitlab-org/gitlab@4071d26e25aeea320e2346790f6413f534b7a1f0) by @catinbag ([merge request](gitlab-org/gitlab!117630)) **GitLab Enterprise Edition** +- [Update label styling](gitlab-org/gitlab@cb6fde316c86749d531aa8851160fc3c83e7f956) ([merge request](gitlab-org/gitlab!118371)) +- [Rename 'Terraform menu' to 'Terraform states'](gitlab-org/gitlab@56aa0f1c69c6a3ef173dfbe14e012a3bc4013997) ([merge request](gitlab-org/gitlab!117227)) +- [Rate limit API deletion of member](gitlab-org/gitlab@ec474567789b98645dccc1d46313df465b3f3ba9) ([merge request](gitlab-org/gitlab!118296)) +- [Improve audit streams display](gitlab-org/gitlab@8110bf61c9a878d258510e8baf69ba5a11cf9289) ([merge request](gitlab-org/gitlab!117612)) **GitLab Enterprise Edition** +- [This MR creates new filtering layout](gitlab-org/gitlab@70e3b63cbdd052fe9614df45e8ed641e90b678e7) ([merge request](gitlab-org/gitlab!117186)) **GitLab Enterprise Edition** +- [Geo: Reduce exclusive lease log noise](gitlab-org/gitlab@c7f14ce40cc81112ca65f24dfa8893fcf0a4e8b6) ([merge request](gitlab-org/gitlab!117727)) **GitLab Enterprise Edition** +- [Update issuable list design](gitlab-org/gitlab@a5425dd678500cdcb0860f2831865b932841d57a) ([merge request](gitlab-org/gitlab!118255)) +- [This MR migrates Dropdown to RefSelector](gitlab-org/gitlab@92eb8f9657f2ea805454838f2f9dfe8ede83da0c) ([merge request](gitlab-org/gitlab!110046)) +- [Add small animation to "Finish review" button](gitlab-org/gitlab@c558a107e25cf0649f9f3a73f21cd992b962a386) ([merge request](gitlab-org/gitlab!117704)) +- [Move code suggestions feature to Premium](gitlab-org/gitlab@3158538d4b8c3f3525e91ba026fa6f124a9b60cd) ([merge request](gitlab-org/gitlab!118130)) **GitLab Enterprise Edition** +- [Use merge_base_pipeline for security report comparison MR widget](gitlab-org/gitlab@e03aedc6fdab7144533fefff6026eba172ebc8b4) by @jimmy-outschool ([merge request](gitlab-org/gitlab!117594)) **GitLab Enterprise Edition** +- [Auto-selects labels created in dropdown](gitlab-org/gitlab@d5cdbba3736a6793b76afdfdeb58f3b99bca64fb) ([merge request](gitlab-org/gitlab!117418)) +- [Move streaming frontend bundle to separate action](gitlab-org/gitlab@6daece4a975916a930c1dfc4a86b5d5848c8f8e7) ([merge request](gitlab-org/gitlab!117887)) +- [Reschedule migration for](gitlab-org/gitlab@e3f99d71fd791b953543f32d15b09c2400d24cc3) ([merge request](gitlab-org/gitlab!117419)) **GitLab Enterprise Edition** +- [Expose valid_runner_registrars in Application Settings API](gitlab-org/gitlab@9ced46b6e0d9c1c2226b98116016ac639be707f7) by @tomsiewert ([merge request](gitlab-org/gitlab!118040)) +- [Always show target url on note email](gitlab-org/gitlab@748d483b394e2963faa1cb5e471959bd77766d5d) ([merge request](gitlab-org/gitlab!118084)) +- [Use textarea instead of text field for label description](gitlab-org/gitlab@aedfee96070b84919b17575f59fa82f18c077a12) ([merge request](gitlab-org/gitlab!118074)) +- [Restyle color chips in label selector](gitlab-org/gitlab@dde5cad7c728f517ff4a069f8874eaa3a2edc0d7) ([merge request](gitlab-org/gitlab!118069)) +- [Update issuable lists](gitlab-org/gitlab@1d2e9d11dd47fb0972c53448ff9ccb76f5003010) ([merge request](gitlab-org/gitlab!118062)) +- [Remove futile colon in userfacing Error Message util](gitlab-org/gitlab@8048b4ec09a81f1bdad1665bea96dc51c4f696ed) ([merge request](gitlab-org/gitlab!118013)) +- [Combine RSS and calendar options into dropdown on dashboard issues](gitlab-org/gitlab@6c53bf320198b7b8f235e22ab9d81e149e5d2c33) ([merge request](gitlab-org/gitlab!118017)) +- [Fix right padding on LDAP radio buttons](gitlab-org/gitlab@99c7048c850bea586a642ed7a18dade5c3e744c7) ([merge request](gitlab-org/gitlab!116955)) **GitLab Enterprise Edition** +- [Adjusts param handling in namespace API](gitlab-org/gitlab@d0b32278a09811364969bab062713daa21585399) ([merge request](gitlab-org/gitlab!116932)) **GitLab Enterprise Edition** +- [Update openssl gem to v3.1.0](gitlab-org/gitlab@7fb8faddef18f8f219565e1445f9583a3531e943) ([merge request](gitlab-org/gitlab!117063)) +- [Update dependency auto-build-image to v1.32.0](gitlab-org/gitlab@2138f6846864d11bf515328640f9fa158571b248) ([merge request](gitlab-org/gitlab!116881)) +- [Update dependency auto-deploy-image to v2.48.1](gitlab-org/gitlab@e10fa845a3d60a05a80f2f7c435f44eb81234983) ([merge request](gitlab-org/gitlab!116521)) -- [Use correct migration finalisation method](gitlab-org/gitlab@db7999c368aa41a155f717206b5b8340c91927f7) ([merge request](gitlab-org/gitlab!120683)) +### Deprecated (15 changes) + +- [Add Metrics Dashboard GraphQL API to FF](gitlab-org/gitlab@889cb6da14f78ccee0a9fc499b0de9d448bf1d98) ([merge request](gitlab-org/gitlab!120307)) +- [Move merged_by under pull_request namespace](gitlab-org/gitlab@123df7bef2ca6df503b908959ebf9f7db4ca4f5b) ([merge request](gitlab-org/gitlab!119081)) +- [Announce deprecation of omnibus packaged Grafana](gitlab-org/gitlab@36da3d7d556151ccd41ddf568d0711b81cfb5865) ([merge request](gitlab-org/gitlab!120357)) +- [Return an empty `pipelines` in the package REST API payload](gitlab-org/gitlab@3a6c9d6a671c1ab87dd3603d13ca574daf3f1d33) ([merge request](gitlab-org/gitlab!118504)) +- [Deprecate backfill traversal ids to blobs and wiki blobs](gitlab-org/gitlab@d526352fd1724b22046cdb36abdf537ce7ba144e) ([merge request](gitlab-org/gitlab!119969)) **GitLab Enterprise Edition** +- [Analyzer consolidation for 16.0](gitlab-org/gitlab@88a951a5b660d1b222b9c5f18971516db32a677b) ([merge request](gitlab-org/gitlab!111460)) +- [Deprecate obsolete migrations](gitlab-org/gitlab@c9498f0e5c882c76bb5a3287f96f0114f261279b) ([merge request](gitlab-org/gitlab!118111)) **GitLab Enterprise Edition** +- [Move reviews under to pull_request namespace](gitlab-org/gitlab@cea3657ceab7351c4016f63b77c85d3b145991ae) ([merge request](gitlab-org/gitlab!119085)) +- [GraphQL: Rename RunnerMembershipFilter to CiRunnerMembershipFilter](gitlab-org/gitlab@778602a2102a231e5575e23bbdc5e8af580b0210) ([merge request](gitlab-org/gitlab!119185)) +- [Remove CreateCrossProjectPipelineWorker](gitlab-org/gitlab@9ecec6da903efceac5746e47379fb22b1a1c8f12) ([merge request](gitlab-org/gitlab!119044)) +- [Deprecate add hidden to issues migration](gitlab-org/gitlab@33274d4b69f47b36ca84e74735e28150c27bd42d) ([merge request](gitlab-org/gitlab!118628)) **GitLab Enterprise Edition** +- [GraphQL: Rename CiRunnerUpgradeStatusType to CiRunnerUpgradeStatus](gitlab-org/gitlab@d8320c2d022f4bf92f8be336c84ef775bba8eddf) ([merge request](gitlab-org/gitlab!119184)) +- [Deprecate CiRunner.projects default sort order value for removal in 17.0](gitlab-org/gitlab@45f9b5b619a01ad96c6c85e3dce50b1981092d81) ([merge request](gitlab-org/gitlab!119082)) +- [Deprecate user index migrations](gitlab-org/gitlab@bdc0e31410bf7343614d04bb2b0bfaffe413f209) ([merge request](gitlab-org/gitlab!118633)) **GitLab Enterprise Edition** +- [Remove CreateCrossProjectPipelineWorker](gitlab-org/gitlab@8c9478ac45ba6513e8a594fa2fa1abe98771c403) ([merge request](gitlab-org/gitlab!118334)) + +### Removed (73 changes) + +- [Remove legacy project routes](gitlab-org/gitlab@1ca2ccf4defd2f5a9c91d5ddd116eabed42efb5c) ([merge request](gitlab-org/gitlab!120720)) +- [Remove depricated Monitor Metrics feature](gitlab-org/gitlab@001cdb68bfc6147eb19c5364e1b2eedb9ba55e16) ([merge request](gitlab-org/gitlab!119989)) +- [Remove unused ci_triggers.ref column](gitlab-org/gitlab@bf8fe85abdccc24f5d3e9ee58ecd296703651f95) ([merge request](gitlab-org/gitlab!120301)) +- [Geo Sites - Remove Full Details button](gitlab-org/gitlab@feea702f29575376f433afc6dd8abcf550bd6d45) ([merge request](gitlab-org/gitlab!120355)) **GitLab Enterprise Edition** +- [Set default PAT expiration to 365 days from now](gitlab-org/gitlab@fa7da8318e4ae777d919f2601781f021a887cbdf) ([merge request](gitlab-org/gitlab!120213)) +- [Remove the `opt_in_jwt` feature](gitlab-org/gitlab@b08104d4c2362d3b1727dbf7d8ac0aeb08004f7d) ([merge request](gitlab-org/gitlab!118246)) +- [Announce removal of Redis localhost ports](gitlab-org/gitlab@40ab3a697be25d01dca83d4ae4e55b1faeb2f571) ([merge request](gitlab-org/gitlab!119592)) +- [Add 16.0 Grafana Helm Chart removal notice](gitlab-org/gitlab@d3ef23fc2e108444cc1ed489ad522f59da315215) ([merge request](gitlab-org/gitlab!120350)) +- [Revert "Merge branch 'suppress-schema-deprecation-warning' into 'master'"](gitlab-org/gitlab@9572e7c793764779e5ff05c335a0b492afc96314) ([merge request](gitlab-org/gitlab!119065)) **GitLab Enterprise Edition** +- [Add 16.0 breaking change removal notice for PG12](gitlab-org/gitlab@d94d61a516b35e9860efe207241a29afd017d28a) ([merge request](gitlab-org/gitlab!120343)) +- [Remove deprecated security schemas](gitlab-org/gitlab@5797aefc4d166b77f5c482e1b9f939498551b435) ([merge request](gitlab-org/gitlab!116538)) **GitLab Enterprise Edition** +- [Remove deprecated 'started' state for iteration](gitlab-org/gitlab@86c246fd1c038c9fb1449487a81da7199b6d3072) ([merge request](gitlab-org/gitlab!91366)) +- [Remove DS support for Java 13 to 16](gitlab-org/gitlab@dfec26dc55015c9ba4d3e0d4ca448698ed97cac5) ([merge request](gitlab-org/gitlab!120246)) **GitLab Enterprise Edition** +- [Remove POST /ci/lint](gitlab-org/gitlab@c345ba06c51765f4482e23de227b77ae42a59ef1) ([merge request](gitlab-org/gitlab!119991)) +- [Remove deprecated environment_tier param](gitlab-org/gitlab@1fbc9eb7203782364c4fbc4cbfc738fdddf16b9d) ([merge request](gitlab-org/gitlab!118882)) **GitLab Enterprise Edition** +- [Remove License-Check feature](gitlab-org/gitlab@ce79975fa801ddf8d4ee5216862217174b7af668) ([merge request](gitlab-org/gitlab!117941)) **GitLab Enterprise Edition** +- [Remove unused sequence from VSD table](gitlab-org/gitlab@61a463e57aa0dea9940979f86a28958c683692e3) ([merge request](gitlab-org/gitlab!120072)) +- [GH-style Jira OAuth endpoints default return 404](gitlab-org/gitlab@a7ea014b11f2efa13a6d469b004b2eb9deceb30c) ([merge request](gitlab-org/gitlab!120051)) +- [Set ci_remove_legacy_predefined_variables default ON](gitlab-org/gitlab@f2eb37cc7f495ac0b2ef0ae51a585050bc62a0f3) ([merge request](gitlab-org/gitlab!120050)) +- [Remove legacyMode for runner status in graphql](gitlab-org/gitlab@9ca217b8e33a1c20ea33a5e2697b16d58985c7b0) ([merge request](gitlab-org/gitlab!117886)) +- [Remove obsolete npm packages tags shared example](gitlab-org/gitlab@8d4d485101e4051a8ea20978f15bc2a05be0e8d6) ([merge request](gitlab-org/gitlab!120017)) +- [Migration remove gitlab as import_source](gitlab-org/gitlab@b571f0fcc64587fbd02d3291de0f1f07c655a2e7) ([merge request](gitlab-org/gitlab!119615)) +- [Remove jira_connect/users page](gitlab-org/gitlab@960b72737b49c393922fea1db06046e770d7d71f) ([merge request](gitlab-org/gitlab!119712)) +- [Remove setting Redis config file path via env](gitlab-org/gitlab@12429653611af05ef960689c8971108d5a85c937) ([merge request](gitlab-org/gitlab!119750)) +- [Drop clusters_applications_prometheus table](gitlab-org/gitlab@c59365b0eac704fcd5706caeee3b13d386a3e4c3) ([merge request](gitlab-org/gitlab!119533)) +- [Remove deprecated gitlab.com importer](gitlab-org/gitlab@7eada8ca61107245e3d301979bbec4ccf5c91f83) ([merge request](gitlab-org/gitlab!118891)) +- [Add migration to drop crossplane](gitlab-org/gitlab@ccafc46b9a2f481d99fd025d47b8e216c99cca19) ([merge request](gitlab-org/gitlab!119361)) +- [Remove SoftwareLicensePolicies without ScanResultPolicy](gitlab-org/gitlab@d9e7724ac364788f3a587f5a5b4b0f97181f966f) ([merge request](gitlab-org/gitlab!119119)) **GitLab Enterprise Edition** +- [Remove special Redis fallback URLs](gitlab-org/gitlab@e2bd22c43c7961704af09fe4a4ab920a02063f07) ([merge request](gitlab-org/gitlab!119492)) +- [Remove toggle for limiting JWT token access](gitlab-org/gitlab@7879b0682f1991b6063f5f5f5b0bdfdef1898df7) ([merge request](gitlab-org/gitlab!115644)) +- [Drop clusters_applications_jupyter table](gitlab-org/gitlab@a700ec8cefc84a5d990b8b2c90209fb44ba0bc5e) ([merge request](gitlab-org/gitlab!119469)) +- [Remove setting Redis config file path via env var](gitlab-org/gitlab@209b22b8ce348a68cce588354f071074e0b83fa1) ([merge request](gitlab-org/gitlab!119429)) +- [Drop clusters_applications_cert_managers table](gitlab-org/gitlab@93ed20984d3daf6999dd897eb9783cd5c7de92ff) ([merge request](gitlab-org/gitlab!119238)) +- [Remove POST `approvals` endpoint](gitlab-org/gitlab@2099a9de2ea6a5269dd0e9e1cd7220364706ffd0) ([merge request](gitlab-org/gitlab!118036)) **GitLab Enterprise Edition** +- [Remove pql_three_cta_test](gitlab-org/gitlab@59ebad0b4722dcf14621cea0a4a8dd055fd4781c) ([merge request](gitlab-org/gitlab!119470)) **GitLab Enterprise Edition** +- [GH-style Jira DVCS endpoints return 404 by default](gitlab-org/gitlab@ba014cda135b7410154b56c786eae7c8be1a90a1) ([merge request](gitlab-org/gitlab!118126)) +- [GraphQL: Remove CiCdSettingsUpdate](gitlab-org/gitlab@70cb61e8ec33197419bc7114d961cd521d400d7c) ([merge request](gitlab-org/gitlab!119061)) +- [Remove redundant index from container_repositories](gitlab-org/gitlab@c9fda7b7198077d9ad5c3f92bf6975c17c636a44) ([merge request](gitlab-org/gitlab!119422)) +- [Enable frozen outbound job tokens by default](gitlab-org/gitlab@f42d78d756306d76694ffd28e40571620035be08) ([merge request](gitlab-org/gitlab!118653)) +- [Add changelog item for redis 5 removal](gitlab-org/gitlab@5be211978c810765a126639b7003e5a981b73ce2) ([merge request](gitlab-org/gitlab!119121)) +- [Remove PipelineSecurityReportFinding.name GraphQL field](gitlab-org/gitlab@d022e7d4f10047923ec80f214daedbed450cfab1) ([merge request](gitlab-org/gitlab!119055)) **GitLab Enterprise Edition** +- [Remove preload_max_access_levels_for_labels_... FF](gitlab-org/gitlab@81d4b88234f0fa2671c38f8ff303243e70cdd631) ([merge request](gitlab-org/gitlab!119305)) +- [Remove the apiFuzzingCiConfigurationCreate GraphQL mutation](gitlab-org/gitlab@474d0b732b591f4ba2cb7a5a79c94c3b1b4a0d74) ([merge request](gitlab-org/gitlab!87119)) **GitLab Enterprise Edition** +- [Remove revoked agent tokens from API](gitlab-org/gitlab@a743fc4aedb5151428e060bd14c5a9f5fbec2f71) ([merge request](gitlab-org/gitlab!117991)) +- [Remove Redownload button](gitlab-org/gitlab@0735a875b922eef384d3a267e3739c0b28d1fbdd) ([merge request](gitlab-org/gitlab!118411)) **GitLab Enterprise Edition** +- [Remove feature flag for ci_fix_for_runner_cache_prefix](gitlab-org/gitlab@0c28a1e99bb1428d5df9f8c65ef4dde2b3e644aa) ([merge request](gitlab-org/gitlab!118091)) +- [Remove vulnerabilityFindingDismiss GraphQL mutation](gitlab-org/gitlab@da5b17429c319536aa281a23a74e0a54fdbb6a46) ([merge request](gitlab-org/gitlab!118626)) **GitLab Enterprise Edition** +- [Remove `confidence` field from `PipelineSecurityReportFinding` type](gitlab-org/gitlab@390766d028670005a11e11ef0063b8b313e1adb2) ([merge request](gitlab-org/gitlab!118617)) **GitLab Enterprise Edition** +- [Drop U2F foreign key from WebauthnRegistrations](gitlab-org/gitlab@7b846a592fea4b6641b4d9f32f3aac6f4c1ebcf2) ([merge request](gitlab-org/gitlab!118179)) +- [Remove legacy Sidekiq Daemon Memory Killer](gitlab-org/gitlab@89e1f281e8d0f22f651e01b1b88a9e68a0798319) ([merge request](gitlab-org/gitlab!118507)) +- [Remove 'external' field in ReleaseAssetLink type](gitlab-org/gitlab@49b660dd66a3d31deaff6c7efa890c95e847d2c0) by @missy-davies ([merge request](gitlab-org/gitlab!111750)) +- [Remove external field from Releases and Release Links APIs](gitlab-org/gitlab@35a6eadc619771da8a5d48603885423991adf869) by @missy-davies ([merge request](gitlab-org/gitlab!112490)) +- [Remove column application_settings clickhouse_connection_string](gitlab-org/gitlab@c1869bbcec1517d3b01a935a5df6f8c4d2800f5c) ([merge request](gitlab-org/gitlab!118526)) +- [Remove Bare repository import rake task](gitlab-org/gitlab@8eeb5aafb2b7c113e9973804b670e15d89b13bd9) ([merge request](gitlab-org/gitlab!118676)) +- [Remove the feature flag npm_obtain_lease_to_create_package](gitlab-org/gitlab@a7e655f6bb365c01913b3f3305477061ccc1042c) ([merge request](gitlab-org/gitlab!118681)) +- [Remove refactor_vulnerability_filters feature flag](gitlab-org/gitlab@bd12c07ff6002a77c18ad414495ba7e2e7f42822) ([merge request](gitlab-org/gitlab!117244)) **GitLab Enterprise Edition** +- [Remove the legacy Contribution App and feature flag](gitlab-org/gitlab@913a6f622134c603b4a6075c883c557b8d64e172) ([merge request](gitlab-org/gitlab!117912)) **GitLab Enterprise Edition** +- [Stop using file_md5 from debian component files](gitlab-org/gitlab@a6260a57da844c6ff694e63bda72612ab655b78d) by @sathieu ([merge request](gitlab-org/gitlab!116893)) +- [Revert "Merge branch 'issue_370251_remove_namespace_agg_scheduler_lease' into 'master'"](gitlab-org/gitlab@3622c439609bf1635644a05455ba3cba2ba49bd4) ([merge request](gitlab-org/gitlab!117845)) +- [Migration to remove phabricator](gitlab-org/gitlab@5dbfa5ea471d3808bc7bf6f440d7e5fe53f4fdfc) ([merge request](gitlab-org/gitlab!118026)) +- [Clean up role_targeted_broadcast_messages](gitlab-org/gitlab@ac10453f7e58c5809c2099b82e879d6237bd8409) ([merge request](gitlab-org/gitlab!117398)) +- [Remove RT issue weight feature flag](gitlab-org/gitlab@03ac24911e5267745ee419971734da2891a55fc1) ([merge request](gitlab-org/gitlab!118474)) +- [Removes the feature flag use_sub_repositories_api](gitlab-org/gitlab@9f046123299f0a7b20b77cdddc431059ffd0d1c0) ([merge request](gitlab-org/gitlab!118429)) +- [Remove index_security_scans_on_pipeline_id concurrently](gitlab-org/gitlab@0ab3a30457cbd8e667b424ce2a512749d33d2991) ([merge request](gitlab-org/gitlab!118256)) +- [Remove phabricator code, docs and metrics](gitlab-org/gitlab@a8c35d4d4b0aed52e9701322d31b9f81cd325f4a) ([merge request](gitlab-org/gitlab!117649)) +- [Remove job_age from jobs/request API endpoint](gitlab-org/gitlab@6f6bf321f58ebe1da714513365db411c887074c6) ([merge request](gitlab-org/gitlab!118045)) +- [Unset POSTGRES_ENABLED in Auto DevOps template](gitlab-org/gitlab@d9de4543526887fbba7e23c0b6cac0e1437713f5) ([merge request](gitlab-org/gitlab!117980)) +- [Removing Pipeline Activity Limit in 16.0 as the feature is deprecated](gitlab-org/gitlab@f30fa989d7c08d6d2e531662c7d5469a06170fca) ([merge request](gitlab-org/gitlab!117951)) +- [Cleanup the detect_android_projects](gitlab-org/gitlab@457d69ff00e0da38fbf905d297a96835fbc50614) ([merge request](gitlab-org/gitlab!117254)) +- [Remove exit_registration_verification feature](gitlab-org/gitlab@6bdbecf63e87e748c5d13446fd2853dfe8d30cdb) ([merge request](gitlab-org/gitlab!117230)) +- [Remove temporary index tmp_idx_package_files_on_non_zero_size](gitlab-org/gitlab@70d4eb9810df4cbfa964e0e898ee8b3fdcf1ba24) ([merge request](gitlab-org/gitlab!118154)) +- [Remove GitHub import deprecated workers](gitlab-org/gitlab@b28de7f86e89e68dee293033eadcf27194e1f8c1) ([merge request](gitlab-org/gitlab!118049)) +- [Remove gitbook project template](gitlab-org/gitlab@18671518159e453d5fbcc26836b26bab81876364) ([merge request](gitlab-org/gitlab!116859)) + +### Security (10 changes) + +- [Bump gitaly version](gitlab-org/gitlab@82e01eb0f17717fddf698e27bbf62d8741c96c4d) ([merge request](gitlab-org/gitlab!120385)) +- [Only maintainers of projects should be able to assign runners to them](gitlab-org/gitlab@28e7c9fea548bac5a989bbe1e8474a8d37232dd2) +- [Relay state to check for only allowing sub paths](gitlab-org/gitlab@991a075fa9b25b3d6ba00900b1d7a5c9473491a8) ([merge request](gitlab-org/gitlab!119342)) +- [Update policy to prevent banned members from accessing public projects](gitlab-org/gitlab@a2d2d9915814f4ab877a716dd180543751a99dd2) ([merge request](gitlab-org/gitlab!119342)) +- [Handle invalid URLs in asset proxy](gitlab-org/gitlab@9bd7d073f07e920f8f5cb0a6a12dbd979de64ed7) ([merge request](gitlab-org/gitlab!119342)) +- [Add specs for external users flag](gitlab-org/gitlab@6cb32af1d5f69f0b16edc61e13180d3de480f951) ([merge request](gitlab-org/gitlab!119342)) +- [Commit trailers now only match public user email addresses](gitlab-org/gitlab@dbe10f2def7d907b0b26b6fb3419e608a4dd063f) ([merge request](gitlab-org/gitlab!119342)) +- [Authorize access to vulnerabilitiesCountByDay resolver](gitlab-org/gitlab@f10225e7a93c695c9a2538bb767bace2cf8846b2) ([merge request](gitlab-org/gitlab!119342)) +- [Use dummy filename as filename when viewing raw xml files](gitlab-org/gitlab@67501cd7d4e2fbadb7b6294eced1e26abfad0ee6) ([merge request](gitlab-org/gitlab!119342)) +- [Prohibit 40 character hex sets at beginning of path-based branch name](gitlab-org/gitlab@b671690322e9f40759087aef715e847bbc2da11d) ([merge request](gitlab-org/gitlab!119342)) + +### Performance (11 changes) + +- [Drop partial_index_deployments_for_project_id_and_tag](gitlab-org/gitlab@c8d596c7ad87bf9788c7e3139fe726473676ff9a) ([merge request](gitlab-org/gitlab!119271)) +- [Use linear query to refresh the project authorizations](gitlab-org/gitlab@2901e12ad85e3bdedf25f7aff9386c8ae9e0b416) ([merge request](gitlab-org/gitlab!117988)) +- [Enable Deployments API error on updated_at filter by default](gitlab-org/gitlab@3f1dd04c30b8e61b00a3a95b7624d22e82bc6868) ([merge request](gitlab-org/gitlab!120066)) +- [Remove the ci_enforce_rate_limits_jobs_api feature flag](gitlab-org/gitlab@1c672aaf177689b2b207992d08f076bae23a9bb5) ([merge request](gitlab-org/gitlab!120010)) +- [Set rate limit by default](gitlab-org/gitlab@72b215f8a4351accaea2103c5375a9ccb3ff94e8) ([merge request](gitlab-org/gitlab!119603)) +- [Add code for the new permutation migration](gitlab-org/gitlab@7e92f60b0408731348556e1c14ae58d294c4af88) ([merge request](gitlab-org/gitlab!119479)) **GitLab Enterprise Edition** +- [Fix usage of enqueue_delete_todos](gitlab-org/gitlab@b81ea4b297e0c65d68e16d7ecda6b2810282394f) ([merge request](gitlab-org/gitlab!118169)) +- [Optimise deployments table by removing an unused index](gitlab-org/gitlab@1d469f00ad4e65c8b2a8a86896f8acbdb67c59c5) ([merge request](gitlab-org/gitlab!119270)) +- [Allow using db replicas for GraphQL subs](gitlab-org/gitlab@3d5d68ae4c31fd54094a8d65db616e9df29b8d27) ([merge request](gitlab-org/gitlab!117678)) +- [Process limited number of refs in commit](gitlab-org/gitlab@c353070a02ecc252ff67ba13e1817cedd41911d5) ([merge request](gitlab-org/gitlab!118005)) +- [Performance: Preload pipeline in PipelinesController to fix N+1](gitlab-org/gitlab@cce65887ab4849c02fb52fbb4c3e98af609f8268) ([merge request](gitlab-org/gitlab!116408)) + +### Other (56 changes) + +- [Add states and registry table to add SSF support for designs](gitlab-org/gitlab@55c76f042ca5181bc27eec7122ecb84750f9fe66) ([merge request](gitlab-org/gitlab!120429)) +- [Rate limits for unauthenticated Projects API use](gitlab-org/gitlab@af900cba0ac8ccbc5593a7648f317827641e47b5) ([merge request](gitlab-org/gitlab!120445)) +- [Synchronously removing merge_request_mentions_temp_index](gitlab-org/gitlab@60d4d2783bb41d502347a0c809fa12060caa261f) ([merge request](gitlab-org/gitlab!118715)) +- [Add store labels to gitlab_cache_read_multikey_count metric](gitlab-org/gitlab@2f721ae65a4f7414173652734e23f6ffb480b17e) ([merge request](gitlab-org/gitlab!120677)) +- [Update Gitlab Shell version to 14.20.0](gitlab-org/gitlab@50a074278899f78acac2e4fa3715728bd102692a) ([merge request](gitlab-org/gitlab!120651)) +- [Logs all Exception errors from DB LB service discovery](gitlab-org/gitlab@6cebcd8ced30e9b45a485bf845222246eb3c404d) ([merge request](gitlab-org/gitlab!120172)) +- [Revert "Merge branch '388156-read-vuln-custom-role' into 'master'"](gitlab-org/gitlab@12f02dccb9a9ee828271b1cf71f8a9a98f97fc46) ([merge request](gitlab-org/gitlab!120415)) +- [Use listbox in image_filter](gitlab-org/gitlab@aebdc9e80cc89be1fcd3ee1304f9630aa5d0a0d8) ([merge request](gitlab-org/gitlab!119973)) **GitLab Enterprise Edition** +- [Remove DropOlderDeploymentsWorker](gitlab-org/gitlab@208d05276142f11c92a55f23ad68b8c3132accc3) ([merge request](gitlab-org/gitlab!120065)) +- [Prepare async index for system_note_metadata](gitlab-org/gitlab@ec11c240f50f55c6f127cacf48108771b4e0a9bf) ([merge request](gitlab-org/gitlab!119020)) +- [Remove recursive_approach_for_all_projects feature flag](gitlab-org/gitlab@e2209a9b6a6aa5226aadd78791fe2158959cdb49) ([merge request](gitlab-org/gitlab!120205)) +- [Remove feature flag sign_and_verify_ansi2json_state](gitlab-org/gitlab@0171ac09a6462c24aa5220c78a953307572fbab2) ([merge request](gitlab-org/gitlab!120192)) +- [Update PipelineProcessWorker dedup strategy](gitlab-org/gitlab@b1be5e2bfc23e13c4596fefef370693213e0fda7) ([merge request](gitlab-org/gitlab!120174)) +- [Add a new worker for wiki indexing](gitlab-org/gitlab@3facaac4447902a3cc371d9a87ae1a3cb9c09eca) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118349)) **GitLab Enterprise Edition** +- [Disable optional runner token encryption for groups and projects](gitlab-org/gitlab@10600779cdbe3db62dfafc21ed97b8e98cc8b617) ([merge request](gitlab-org/gitlab!120094)) +- [Use clean_gitlab_redis_rate_limiting in search specs to avoid rate limit](gitlab-org/gitlab@f37977c3349799ce79a62de768398d58d5bd8ea4) by @asadath1395 ([merge request](gitlab-org/gitlab!120091)) +- [Remove application_settings_tokens_optional_encryption feature flag](gitlab-org/gitlab@350f91aa24169decddda84bb2859b1eaf45bc504) ([merge request](gitlab-org/gitlab!120089)) +- [Update restore docs to reflect changes in restore process](gitlab-org/gitlab@648eccf200bcac07d07efd95c990ae907b697e25) ([merge request](gitlab-org/gitlab!119781)) +- [Refactored project creation updation events](gitlab-org/gitlab@887bd376447054c047748b6e9e211c023bd21948) ([merge request](gitlab-org/gitlab!119462)) **GitLab Enterprise Edition** +- [Add a migration to add prefix project in wiki rid](gitlab-org/gitlab@a353177c6b9df1009c45757757b68806130f8f25) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119261)) **GitLab Enterprise Edition** +- [Record VSD total visits weekly and monthly](gitlab-org/gitlab@74bf7672e716db7180689975acef72281d14e4c7) ([merge request](gitlab-org/gitlab!119807)) **GitLab Enterprise Edition** +- [Prepare indexes for converting notes.id to bigint](gitlab-org/gitlab@01305100f3bfd436e5f09904fcf8f1f6396a5b88) ([merge request](gitlab-org/gitlab!119913)) +- [Use invoice preview API to calculate plan pricing for SaaS purchase](gitlab-org/gitlab@5a0d8df34b7c4fd109df205ed96536e6ec50913f) ([merge request](gitlab-org/gitlab!118710)) **GitLab Enterprise Edition** +- [Extract token masking code into a separate class](gitlab-org/gitlab@1b11dc6231f91fd3cfd60bc7541556c1dcc1d150) by @asadath1395 ([merge request](gitlab-org/gitlab!119869)) +- [Clean up FF remove_job_age_from_jobs_api](gitlab-org/gitlab@2cd83af50489a041f3f3d23def2e88381acc5fc2) ([merge request](gitlab-org/gitlab!118918)) +- [Remove use_replica_for_mailers feature flag](gitlab-org/gitlab@324a595b76b331f6f62c2a631e18dc0c54f55ca7) ([merge request](gitlab-org/gitlab!119578)) +- [Drop cycle analytics unused tables](gitlab-org/gitlab@2257f9a98bdcf8c1ef1b4ed398d2bd46798ec39c) ([merge request](gitlab-org/gitlab!118980)) +- [Make DesignManagement::Repository a container for GitRepository](gitlab-org/gitlab@a6067f3d8e1501db8ad26b7f710f255bc8972043) ([merge request](gitlab-org/gitlab!118510)) +- [Update OpenAI::Client cost tracking to include feature category](gitlab-org/gitlab@b2be766a0a30544a4875c9057f306ee26c551893) ([merge request](gitlab-org/gitlab!119346)) **GitLab Enterprise Edition** +- [Remove use_merge_base_for_security_widget feature flag](gitlab-org/gitlab@23b7cd12c766229ad705d898cb602372d048dc8d) ([merge request](gitlab-org/gitlab!119356)) +- [Refactored audit events for projects](gitlab-org/gitlab@ed6446b21961a943b04e80bede9b167df36d3232) ([merge request](gitlab-org/gitlab!117543)) **GitLab Enterprise Edition** +- [Swap todos.note_id to bigint](gitlab-org/gitlab@71498c161866a366f25dc90a012a9c6bb4401b32) ([merge request](gitlab-org/gitlab!118123)) +- [Replace legacy variable CI_BUILD_TAG with CI_COMMIT_TAG](gitlab-org/gitlab@0dfb59da4d13b4775630800b19fb353d2e615eec) ([merge request](gitlab-org/gitlab!118966)) +- [Remove 24h time setting](gitlab-org/gitlab@b8d3a92c280b34fbbf0290fcc536182bfdbabed7) ([merge request](gitlab-org/gitlab!119025)) +- [Fix existing incidents issue_type/work_item column out of sync](gitlab-org/gitlab@6b3d7f99ca3582b8e3a37ec48d95bb9a36a197e6) ([merge request](gitlab-org/gitlab!117728)) +- [Add bulk_imports_batched_import_export feature flag](gitlab-org/gitlab@67de831d5f300f8472b47c0d16198bcfdbcf3523) ([merge request](gitlab-org/gitlab!117243)) +- [Use database replica for active jobs](gitlab-org/gitlab@0b8c0c9be46ff46c47ab5c6ee53aff2a70330ad9) ([merge request](gitlab-org/gitlab!116357)) +- [Remove jira_connect_oauth FF](gitlab-org/gitlab@dd8774110f3439a6f21688f961fbcdf7ea3ac1fe) ([merge request](gitlab-org/gitlab!117648)) +- [Refactored Contribution Analytics Jest test data to GraphQL Fixtures](gitlab-org/gitlab@f315370193d699da34efcf9377e205431d90df7f) ([merge request](gitlab-org/gitlab!117426)) **GitLab Enterprise Edition** +- [Add tooltip to feature flag descriptions](gitlab-org/gitlab@1c6a1051721ddd3e3e1a9e73e93300180da372d6) by @JonstonChan ([merge request](gitlab-org/gitlab!118424)) +- [Delete vue_issues_dashboard feature flag](gitlab-org/gitlab@dcdf8da50c07c161dcba0ae8283d79bc94e0d0c9) ([merge request](gitlab-org/gitlab!109335)) +- [Modify rubocop to allow revert](gitlab-org/gitlab@e9b9cb4bf7f83c2ea7807d17b5972a06082ca640) ([merge request](gitlab-org/gitlab!118368)) +- [Remove dynamic_image_resizing feature flag](gitlab-org/gitlab@316ba8e581fa9817747f33022ccd6df0cf3540df) ([merge request](gitlab-org/gitlab!118362)) +- [Remove ClusterRateLimiting and related feature flags](gitlab-org/gitlab@9f7af8c78899b5f9dec128e6b319abb1cd9f58e3) ([merge request](gitlab-org/gitlab!115478)) +- [Fix Style/EmptyElse Cop](gitlab-org/gitlab@466c8f40c09dd2f6329b7a1237a855e9c97a8a0c) by @JonstonChan ([merge request](gitlab-org/gitlab!118423)) +- [Adds more info in BBM health status logger](gitlab-org/gitlab@b2de35b070226dab791e2428d27cd061ae25cffc) ([merge request](gitlab-org/gitlab!117297)) +- [Updating partitioning docs to reflect BBM changes](gitlab-org/gitlab@7b47acc617f45717e62df428e44cf35d4587771a) ([merge request](gitlab-org/gitlab!117838)) +- [Backfill design_management_repositories table](gitlab-org/gitlab@15d02673bf96ac5c3dbd539eeae49ef1ae214a28) ([merge request](gitlab-org/gitlab!116975)) **GitLab Enterprise Edition** +- [Swap award_emoji.awardable_id to bigint](gitlab-org/gitlab@87214ed22da67c33443e3fe8f3a3170d9f3646c3) ([merge request](gitlab-org/gitlab!118125)) +- [Change Service Desk setting text](gitlab-org/gitlab@6535be9ac4975e435d9bdd98ba6de39659220aa2) ([merge request](gitlab-org/gitlab!118077)) +- [Change convert type to work item MVC feature flag](gitlab-org/gitlab@1702d19008c241108323dac8d9d0facc7f213a1c) ([merge request](gitlab-org/gitlab!117997)) +- [Clean up FF ci_fix_max_includes](gitlab-org/gitlab@5e17bdb4dc118f851e17210728e27f7a3c1ca1c4) ([merge request](gitlab-org/gitlab!117954)) +- [Prepare async index creation. Temp issue_type for incidents index](gitlab-org/gitlab@dc36487c1dcad421682bf48f11872350f87c0ae1) ([merge request](gitlab-org/gitlab!117943)) +- [Purges legacy bg migration helpers from partitioning helpers](gitlab-org/gitlab@e51304127b8032819e1689d297e8a5c21e958572) ([merge request](gitlab-org/gitlab!116601)) +- [Add index to group_group_links table](gitlab-org/gitlab@9a3f2c1a90b54074e61d0abf07101ce664198e81) ([merge request](gitlab-org/gitlab!117386)) +- [Validate the projects.creator_id foregin key synchronously](gitlab-org/gitlab@ed9351984a16f20506babf6eab6706b917904ed1) ([merge request](gitlab-org/gitlab!117147)) ## 15.11.3 (2023-05-10) @@ -944,6 +1712,38 @@ entry. - [Update header section](gitlab-org/gitlab@cf4ab283267d84fa1c0dc90fefb1b6ddd2617b5c) ([merge request](gitlab-org/gitlab!114102)) **GitLab Enterprise Edition** - [Swap merge_request_user_mentions.note_id to bigint](gitlab-org/gitlab@96baed47326db4f0cc9f60b2e74215211effd814) ([merge request](gitlab-org/gitlab!113928)) +## 15.10.7 (2023-05-10) + +### Fixed (1 change) + +- [Backport MR 119319 changes to 15-10-stable-ee](gitlab-org/security/gitlab@6c9e1f2f706b0151b1caa3d5199aa312b23c683a) **GitLab Enterprise Edition** + +## 15.10.6 (2023-05-03) + +### Security (1 change) + +- [Only maintainers of projects should be able to assign runners to them](gitlab-org/security/gitlab@a20f5018b757a78a772d2bf1f9f8cdfe95a019ed) ([merge request](gitlab-org/security/gitlab!3235)) + +## 15.10.5 (2023-05-01) + +### Security (9 changes) + +- [Set minimum role for importing projects to Maintainer](gitlab-org/security/gitlab@d4cff7e53961d819b30ae748a38e4c8e4d856b32) ([merge request](gitlab-org/security/gitlab!3215)) +- [Commit trailers now only match public user email addresses](gitlab-org/security/gitlab@4948acdb39ba6ae9a71ef133e38ec47327d14f97) ([merge request](gitlab-org/security/gitlab!3208)) +- [Handle invalid URLs in asset proxy](gitlab-org/security/gitlab@b22e923ab3d48d9389311192d92dd89e2bfc24aa) ([merge request](gitlab-org/security/gitlab!3212)) +- [Relay state to check for only allowing sub paths](gitlab-org/security/gitlab@24f84fafd65dfedf36e859d305dd46bf3e71c8dc) ([merge request](gitlab-org/security/gitlab!3220)) +- [Prohibit 40 character hex sets at beginning of path-based branch name](gitlab-org/security/gitlab@71d30b6537f6853fef45acba16ab26b6f32718f7) ([merge request](gitlab-org/security/gitlab!3194)) +- [Add specs for external users flag](gitlab-org/security/gitlab@dfdb540285e573bd55a8647db4de8370ba6b3286) ([merge request](gitlab-org/security/gitlab!3190)) +- [Update policy to prevent banned members from accessing public projects](gitlab-org/security/gitlab@bc211b8be25e56f35c80d2331447f251c7a7dd56) ([merge request](gitlab-org/security/gitlab!3186)) +- [Use dummy filename as filename when viewing raw xml files](gitlab-org/security/gitlab@6d871f56d7a343d705f8c849d24a94b3528c3a97) ([merge request](gitlab-org/security/gitlab!3192)) +- [Authorize access to vulnerabilitiesCountByDay resolver](gitlab-org/security/gitlab@888c187aab7c7062ea43b61a282c4dea8c6a47be) ([merge request](gitlab-org/security/gitlab!3180)) + +## 15.10.4 (2023-04-21) + +### Fixed (1 change) + +- [Patch mail gem to handle TLS settings properly](gitlab-org/gitlab@cd4cfc46e17c91dbf5ef10ab1ca0a473d6b2a4d6) ([merge request](gitlab-org/gitlab!117559)) + ## 15.10.3 (2023-04-14) ### Fixed (3 changes) @@ -1717,6 +2517,35 @@ entry. - [Update submit buttons to use Pajamas component](gitlab-org/gitlab@4ffb92755e6be3268c78f02e471f5c2a21f437be) ([merge request](gitlab-org/gitlab!114246)) +## 15.9.8 (2023-05-10) + +No changes. + +## 15.9.7 (2023-05-03) + +### Security (1 change) + +- [Only maintainers of projects should be able to assign runners to them](gitlab-org/security/gitlab@695748314b758ca2d9992df7509025a6ac868000) ([merge request](gitlab-org/security/gitlab!3236)) + +## 15.9.6 (2023-05-01) + +### Security (8 changes) + +- [Resolve ambiguous references for archive metadata](gitlab-org/security/gitlab@233b0f78baf8eb9adcfd77e4d1aa606d54472d34) ([merge request](gitlab-org/security/gitlab!3203)) +- [Commit trailers now only match public user email addresses](gitlab-org/security/gitlab@e360774721bb9b5f6a2da9908ef08d92ad5a79cd) ([merge request](gitlab-org/security/gitlab!3209)) +- [Handle invalid URLs in asset proxy](gitlab-org/security/gitlab@ee6df7196b14014b5416f090a684e3b6ba600b5a) ([merge request](gitlab-org/security/gitlab!3213)) +- [Relay state to check for only allowing sub paths](gitlab-org/security/gitlab@c690eec0a2f8aa506b8ff3ffadf306aa91501648) ([merge request](gitlab-org/security/gitlab!3221)) +- [Prohibit 40 character hex sets at beginning of path-based branch name](gitlab-org/security/gitlab@889683b6b1884bfc36208dfae899d0fb9437246c) ([merge request](gitlab-org/security/gitlab!3195)) +- [Update policy to prevent banned members from accessing public projects](gitlab-org/security/gitlab@1abcbdc23881dab5f675e858afa31be87d5d47ce) ([merge request](gitlab-org/security/gitlab!3187)) +- [Use dummy filename as filename when viewing raw xml files](gitlab-org/security/gitlab@33563159bcc7d46c95f013bf089ed94128f10379) ([merge request](gitlab-org/security/gitlab!3193)) +- [Authorize access to vulnerabilitiesCountByDay resolver](gitlab-org/security/gitlab@4b0825f79b0a27eeddabaee0b3a7f627b2487706) ([merge request](gitlab-org/security/gitlab!3181)) + +## 15.9.5 (2023-04-21) + +### Fixed (1 change) + +- [Fix automatically-retried jobs stuck in pending state](gitlab-org/gitlab@752fbfcd613259b71af37f62a83321e8f573219b) ([merge request](gitlab-org/gitlab!117281)) + ## 15.9.4 (2023-03-30) ### Security (16 changes) @@ -3032,6 +3861,12 @@ No changes. - [Do not use _test when not necessary](gitlab-org/gitlab@1bde73aba2bd1d7f9e833c7325cffa0c90d1c106) ([merge request](gitlab-org/gitlab!107373)) - [Add config/redis.yml unified config file](gitlab-org/gitlab@ace8301236eecc07a511975b57f80e21ec7be3c2) ([merge request](gitlab-org/gitlab!106854)) +## 15.7.9 (2023-04-20) + +### Fixed (1 change) + +- [Fix automatically-retried jobs stuck in pending state](gitlab-org/gitlab@0243a8419734e5c1a2fdfc4ea607731e6c497ec5) ([merge request](gitlab-org/gitlab!117284)) + ## 15.7.8 (2023-03-02) ### Security (12 changes) diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index c694fe833b..81552bbef7 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -15.11.11 \ No newline at end of file +16.0.7 \ No newline at end of file diff --git a/GITLAB_ELASTICSEARCH_INDEXER_VERSION b/GITLAB_ELASTICSEARCH_INDEXER_VERSION index 80895903a1..eda862a98c 100644 --- a/GITLAB_ELASTICSEARCH_INDEXER_VERSION +++ b/GITLAB_ELASTICSEARCH_INDEXER_VERSION @@ -1 +1 @@ -4.3.0 +4.3.4 diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index 9f28d5d9d5..e2edcba56c 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -v15.11.0 +v16.0.1 diff --git a/GITLAB_PAGES_VERSION b/GITLAB_PAGES_VERSION index c694fe833b..81552bbef7 100644 --- a/GITLAB_PAGES_VERSION +++ b/GITLAB_PAGES_VERSION @@ -1 +1 @@ -15.11.11 \ No newline at end of file +16.0.7 \ No newline at end of file diff --git a/GITLAB_SHELL_VERSION b/GITLAB_SHELL_VERSION index c2324e8e46..a3eb5a03fa 100644 --- a/GITLAB_SHELL_VERSION +++ b/GITLAB_SHELL_VERSION @@ -1 +1 @@ -14.18.0 +14.20.0 diff --git a/Gemfile b/Gemfile index 25fbc65d27..10c4d6dc8d 100644 --- a/Gemfile +++ b/Gemfile @@ -2,7 +2,7 @@ source 'https://rubygems.org' -if ENV['BUNDLER_CHECKSUM_VERIFICATION_OPT_IN'] # this verification is still experimental +if ENV.fetch('BUNDLER_CHECKSUM_VERIFICATION_OPT_IN', 'false') != 'false' # this verification is still experimental $LOAD_PATH.unshift(File.expand_path("vendor/gems/bundler-checksum/lib", __dir__)) require 'bundler-checksum' BundlerChecksum.patch! @@ -17,9 +17,7 @@ gem 'rails', '~> 6.1.7.2' gem 'bootsnap', '~> 1.16.0', require: false -# Pin openssl to match the version bundled with our supported Rubies. -# See https://stdgems.org/openssl/#gem-version. -gem 'openssl', '2.2.2' +gem 'openssl', '~> 3.0' gem 'ipaddr', '~> 1.2.5' # Responders respond_to and respond_with @@ -27,10 +25,12 @@ gem 'responders', '~> 3.0' gem 'sprockets', '~> 3.7.0' -gem 'view_component', '~> 2.74.1' +gem 'view_component', '~> 2.82.0' # Supported DBs -gem 'pg', '~> 1.4.6' +gem 'pg', '~> 1.5.3' + +gem 'neighbor', '~> 0.2.3' gem 'rugged', '~> 1.5' gem 'grape-path-helpers', '~> 1.7.1' @@ -46,14 +46,13 @@ gem 'devise', '~> 4.8.1' gem 'devise-pbkdf2-encryptable', '~> 0.0.0', path: 'vendor/gems/devise-pbkdf2-encryptable' gem 'bcrypt', '~> 3.1', '>= 3.1.14' gem 'doorkeeper', '~> 5.6', '>= 5.6.6' -gem 'doorkeeper-openid_connect', '~> 1.8', '>= 1.8.5' +gem 'doorkeeper-openid_connect', '~> 1.8', '>= 1.8.6' gem 'rexml', '~> 3.2.5' gem 'ruby-saml', '~> 1.13.0' gem 'omniauth', '~> 2.1.0' gem 'omniauth-auth0', '~> 3.1' gem 'omniauth-azure-activedirectory-v2', '~> 2.0' gem 'omniauth-azure-oauth2', '~> 0.0.9', path: 'vendor/gems/omniauth-azure-oauth2' # See gem README.md -gem 'omniauth-cas3', '~> 1.1.4', path: 'vendor/gems/omniauth-cas3' # See vendor/gems/omniauth-cas3/README.md gem 'omniauth-dingtalk-oauth2', '~> 1.0' gem 'omniauth-alicloud', '~> 2.0.1' gem 'omniauth-facebook', '~> 4.0.0' @@ -61,7 +60,7 @@ gem 'omniauth-github', '2.0.1' gem 'omniauth-gitlab', '~> 4.0.0', path: 'vendor/gems/omniauth-gitlab' # See vendor/gems/omniauth-gitlab/README.md gem 'omniauth-google-oauth2', '~> 1.1' gem 'omniauth-oauth2-generic', '~> 0.2.2' -gem 'omniauth-saml', '~> 2.0.0' +gem 'omniauth-saml', '~> 2.1.0' gem 'omniauth-twitter', '~> 1.4' gem 'omniauth_crowd', '~> 2.4.0', path: 'vendor/gems/omniauth_crowd' # See vendor/gems/omniauth_crowd/README.md gem 'omniauth_openid_connect', '~> 0.6.1' @@ -86,7 +85,6 @@ gem 'invisible_captcha', '~> 2.0.0' gem 'devise-two-factor', '~> 4.0.2' gem 'rqrcode-rails3', '~> 0.1.7' gem 'attr_encrypted', '~> 3.2.4', path: 'vendor/gems/attr_encrypted' -gem 'u2f', '~> 0.2.1' # GitLab Pages gem 'validates_hostname', '~> 1.0.11' @@ -174,9 +172,9 @@ gem 'seed-fu', '~> 2.3.7' gem 'elasticsearch-model', '~> 7.2' gem 'elasticsearch-rails', '~> 7.2', require: 'elasticsearch/rails/instrumentation' gem 'elasticsearch-api', '7.13.3' -gem 'aws-sdk-core', '~> 3.171.0' +gem 'aws-sdk-core', '~> 3.172.0' gem 'aws-sdk-cloudformation', '~> 1' -gem 'aws-sdk-s3', '~> 1.121.0' +gem 'aws-sdk-s3', '~> 1.122.0' gem 'faraday_middleware-aws-sigv4', '~>0.3.0' gem 'typhoeus', '~> 1.4.0' # Used with Elasticsearch to support http keep-alive connections @@ -207,7 +205,7 @@ gem 'diffy', '~> 3.4' gem 'diff_match_patch', '~> 0.1.0' # Application server -gem 'rack', '~> 2.2.6', '>= 2.2.6.4' +gem 'rack', '~> 2.2.7' # https://github.com/zombocom/rack-timeout/blob/master/README.md#rails-apps-manually gem 'rack-timeout', '~> 0.6.3', require: 'rack/timeout/base' @@ -241,9 +239,6 @@ gem 'rainbow', '~> 3.0' # Progress bar gem 'ruby-progressbar', '~> 1.10' -# GitLab settings -gem 'settingslogic', '~> 2.0.9' - # Linear-time regex library for untrusted regular expressions gem 're2', '~> 1.6.0' @@ -289,13 +284,14 @@ gem 'kubeclient', '~> 4.11.0' # AI gem 'ruby-openai', '~> 3.7' +gem 'circuitbox', '2.0.0' # Sanitize user input gem 'sanitize', '~> 6.0' gem 'babosa', '~> 1.0.4' # Sanitizes SVG input -gem 'loofah', '~> 2.20.0' +gem 'loofah', '~> 2.21.0' # Working with license # Detects the open source license the repository includes @@ -344,7 +340,7 @@ gem 'pg_query', '~> 2.2', '>= 2.2.1' gem 'premailer-rails', '~> 1.10.3' -gem 'gitlab-labkit', '~> 0.31.1' +gem 'gitlab-labkit', '~> 0.32.0' gem 'thrift', '>= 0.16.0' # I18n @@ -367,20 +363,20 @@ gem 'snowplow-tracker', '~> 0.8.0' # Metrics gem 'webrick', '~> 1.8.1', require: false -gem 'prometheus-client-mmap', '~> 0.19', require: 'prometheus/client' +gem 'prometheus-client-mmap', '~> 0.23', require: 'prometheus/client' gem 'warning', '~> 1.3.0' group :development do - gem 'lefthook', '~> 1.3.10', require: false + gem 'lefthook', '~> 1.3.13', require: false gem 'rubocop' gem 'solargraph', '~> 0.47.2', require: false gem 'letter_opener_web', '~> 2.0.0' - gem 'lookbook', '~> 1.5', '>= 1.5.3' + gem 'lookbook', '~> 2.0', '>= 2.0.1' # Better errors handler - gem 'better_errors', '~> 2.9.1' + gem 'better_errors', '~> 2.10.0' gem 'sprite-factory', '~> 1.7' @@ -435,7 +431,7 @@ group :development, :test do end group :development, :test, :danger do - gem 'gitlab-dangerfiles', '~> 3.9.0', require: false + gem 'gitlab-dangerfiles', '~> 3.10.0', require: false end group :development, :test, :coverage do @@ -459,7 +455,8 @@ group :test do gem 'capybara', '~> 3.39' gem 'capybara-screenshot', '~> 1.0.26' - gem 'selenium-webdriver', '~> 3.142', '>= 3.142.7' + # 4.9.1 drops Ruby 2.7 support. We can upgrade further after we drop Ruby 2.7 support. + gem 'selenium-webdriver', '= 4.9.0' gem 'graphlyte', '~> 1.0.0' @@ -484,7 +481,7 @@ gem 'gitlab-mail_room', '~> 0.0.23', require: 'mail_room' gem 'email_reply_trimmer', '~> 0.1' gem 'html2text' -gem 'stackprof', '~> 0.2.23', require: false +gem 'stackprof', '~> 0.2.25', require: false gem 'rbtrace', '~> 0.4', require: false gem 'memory_profiler', '~> 1.0', require: false gem 'activerecord-explain-analyze', '~> 0.1', require: false @@ -512,7 +509,7 @@ gem 'spamcheck', '~> 1.3.0' gem 'gitaly', '~> 15.9.0-rc3' # KAS GRPC protocol definitions -gem 'kas-grpc', '~> 0.0.2' +gem 'kas-grpc', '~> 0.1.0' gem 'grpc', '~> 1.42.0' @@ -589,6 +586,9 @@ gem 'cvss-suite', '~> 3.0.1', require: 'cvss_suite' # Work with RPM packages gem 'arr-pm', '~> 0.0.12' +# Remote Development +gem 'devfile', '~> 0.0.17.pre.alpha1' + # Apple plist parsing gem 'CFPropertyList', '~> 3.0.0' gem 'app_store_connect' diff --git a/Gemfile.checksum b/Gemfile.checksum index bebac94cf7..4b24bc11b3 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -35,11 +35,11 @@ {"name":"awesome_print","version":"1.9.2","platform":"ruby","checksum":"e99b32b704acff16d768b3468680793ced40bfdc4537eb07e06a4be11133786e"}, {"name":"awrence","version":"1.2.1","platform":"ruby","checksum":"dd1d214c12a91f449d1ef81d7ee3babc2816944e450752e7522c65521872483e"}, {"name":"aws-eventstream","version":"1.2.0","platform":"ruby","checksum":"ffa53482c92880b001ff2fb06919b9bb82fd847cbb0fa244985d2ebb6dd0d1df"}, -{"name":"aws-partitions","version":"1.733.0","platform":"ruby","checksum":"4d418ca98c499cc88536cc03b46ae16a7d0ea5c9aa905509dd814949aa51bb52"}, +{"name":"aws-partitions","version":"1.761.0","platform":"ruby","checksum":"291e444e1edfc92c5521a6dbdd1236ccc3f122b3520163b2be6ec5b6ef350ef2"}, {"name":"aws-sdk-cloudformation","version":"1.41.0","platform":"ruby","checksum":"31e47539719734413671edf9b1a31f8673fbf9688549f50c41affabbcb1c6b26"}, -{"name":"aws-sdk-core","version":"3.171.0","platform":"ruby","checksum":"69c82d00b872dacf7fdf2a7c68f8b82aec0d3ade4d07ad5d11ff98f8d1de621c"}, -{"name":"aws-sdk-kms","version":"1.63.0","platform":"ruby","checksum":"025864a5ca61637efeca31ea92841da65dcb58a3ce87b4d7d9b9ba8644fc076d"}, -{"name":"aws-sdk-s3","version":"1.121.0","platform":"ruby","checksum":"683a3a30a1d426e06beafc7f45bad9cfde529500b49dfd4699f1c49bd219bbe8"}, +{"name":"aws-sdk-core","version":"3.172.0","platform":"ruby","checksum":"ddc03774a8957033ca2f1564349d5b273a4b615c2cb756407e1b3b8983754c1b"}, +{"name":"aws-sdk-kms","version":"1.64.0","platform":"ruby","checksum":"40de596c95047bfc6e1aacea24f3df6241aa716b6f7ce08ac4c5f7e3120395ad"}, +{"name":"aws-sdk-s3","version":"1.122.0","platform":"ruby","checksum":"3d1fb6d0a6c55cf568ff66d657b4a6e7eaa718675f1f3156d7b44e3791f39905"}, {"name":"aws-sigv4","version":"1.5.1","platform":"ruby","checksum":"d68c87fff4ee843b4b92b23c7f31f957f254ec6eb064181f7119124aab8b8bb4"}, {"name":"axe-core-api","version":"4.6.0","platform":"ruby","checksum":"1b0ddec3353f108dc10363baf2282f43a5ff7f13d4e25f99071294e78f8a6c62"}, {"name":"axe-core-rspec","version":"4.6.0","platform":"ruby","checksum":"11c25bc9dd388c137ba4e5e63d64d20092bf22c884d8ffc829a22acfbacd747f"}, @@ -58,7 +58,7 @@ {"name":"benchmark-memory","version":"0.2.0","platform":"ruby","checksum":"ca1e436433b09535ee8f64f80600a5edb407cff1f6ac70e089ca238118e6ab5c"}, {"name":"benchmark-perf","version":"0.6.0","platform":"ruby","checksum":"fe2b01959f3de0f9dd34820d54ef881eb4f3589fccb7d17b63068ac92d7f9621"}, {"name":"benchmark-trend","version":"0.4.0","platform":"ruby","checksum":"de5a02a9f443babefbbd97784759820decee8554a0c273d859c02a0990845d81"}, -{"name":"better_errors","version":"2.9.1","platform":"ruby","checksum":"39efc116ab04d6c4200052c5782936e4bd99906978d098992bce6bf81d054284"}, +{"name":"better_errors","version":"2.10.0","platform":"ruby","checksum":"e3ab6a7da8977f76950f4faf7a57755c770ba5c05031b58e4994b0334342113a"}, {"name":"bindata","version":"2.4.11","platform":"ruby","checksum":"c38e0c99ffcd80c10a0a7ae6c8586d2fe26bf245cbefac90bec8764523220f6a"}, {"name":"binding_of_caller","version":"1.0.0","platform":"ruby","checksum":"3aad25d1d538fc6e7972978f9bf512ccd992784009947c81633bea776713161d"}, {"name":"bootsnap","version":"1.16.0","platform":"ruby","checksum":"f87410c00f69cd84a6e72a6c4bdba733f800d80d934f4315849d18ca9f288fed"}, @@ -76,8 +76,8 @@ {"name":"charlock_holmes","version":"0.7.7","platform":"ruby","checksum":"1790eca3f661ffa6bbf5866c53c7191e4b8472626fc4997ff9dbe7c425e2cb43"}, {"name":"chef-config","version":"16.10.17","platform":"ruby","checksum":"1f4961e4d6aa4df374f739c6f62ae1d2be03dcff1bd93e56d9c963b8a156747c"}, {"name":"chef-utils","version":"16.10.17","platform":"ruby","checksum":"a74253da6aab8ff92c955549536bdecbc4d1ce8032c8201576f2a8ef4e8ed7b3"}, -{"name":"childprocess","version":"3.0.0","platform":"ruby","checksum":"4579a87cdc962de252eebf1482a4185fad383ae7dbe29a746ba2be8e261280c5"}, {"name":"chunky_png","version":"1.3.5","platform":"ruby","checksum":"b6ab1011b2e79bcc973c92deee4110d071d5cd59ed950efcd0aba49a5f57c06d"}, +{"name":"circuitbox","version":"2.0.0","platform":"ruby","checksum":"496e9c1e76496e1e141490085f6cdcc4a8dedc72da8361bef69d8c5423b4da14"}, {"name":"citrus","version":"3.0.2","platform":"ruby","checksum":"4ec2412fc389ad186735f4baee1460f7900a8e130ffe3f216b30d4f9c684f650"}, {"name":"claide","version":"1.1.0","platform":"ruby","checksum":"6d3c5c089dde904d96aa30e73306d0d4bd444b1accb9b3125ce14a3c0183f82e"}, {"name":"claide-plugins","version":"0.9.2","platform":"ruby","checksum":"c7ea78bc067ab23bce8515497cdcdcb8f01c86dadfbe13c44644e382922c1c2e"}, @@ -109,6 +109,9 @@ {"name":"deprecation_toolkit","version":"1.5.1","platform":"ruby","checksum":"a8a1ab1a19ae40ea12560b65010e099f3459ebde390b76621ef0c21c516a04ba"}, {"name":"derailed_benchmarks","version":"2.1.2","platform":"ruby","checksum":"eaadc6206ceeb5538ff8f5e04a0023d54ebdd95d04f33e8960fb95a5f189a14f"}, {"name":"descendants_tracker","version":"0.0.4","platform":"ruby","checksum":"e9c41dd4cfbb85829a9301ea7e7c48c2a03b26f09319db230e6479ccdc780897"}, +{"name":"devfile","version":"0.0.17.pre.alpha1","platform":"arm64-darwin","checksum":"a6e4d970914399a3acce38d81c42ba5b98f849d878031ff83decd6575369d0c3"}, +{"name":"devfile","version":"0.0.17.pre.alpha1","platform":"ruby","checksum":"2855e7513ab8322e456d3080bf2449109cf4a5785e262443128db0ebf48e646c"}, +{"name":"devfile","version":"0.0.17.pre.alpha1","platform":"x86_64-linux","checksum":"da045e7cbeb2f0685b9b6c7f3d54147403720dced01f727e2f8ca53cef333eaa"}, {"name":"device_detector","version":"1.0.0","platform":"ruby","checksum":"b800fb3150b00c23e87b6768011808ac1771fffaae74c3238ebaf2b782947a7d"}, {"name":"devise","version":"4.8.1","platform":"ruby","checksum":"fdd48bbe79a89e7c1152236a70479842ede48bea4fa7f4f2d8da1f872559803e"}, {"name":"devise-two-factor","version":"4.0.2","platform":"ruby","checksum":"6548d2696ed090d27046f888f4fa7380f151e0f823902d46fd9b91e7d0cac511"}, @@ -120,7 +123,7 @@ {"name":"docile","version":"1.4.0","platform":"ruby","checksum":"5f1734bde23721245c20c3d723e76c104208e1aa01277a69901ce770f0ebb8d3"}, {"name":"domain_name","version":"0.5.20190701","platform":"ruby","checksum":"000a600454cb4a344769b2f10b531765ea7bd3a304fe47ed12e5ca1eab969851"}, {"name":"doorkeeper","version":"5.6.6","platform":"ruby","checksum":"2344e86c77770526efcda893b5217aa13d1c7eb1b40de840b58b19eb1ff757e0"}, -{"name":"doorkeeper-openid_connect","version":"1.8.5","platform":"ruby","checksum":"d4ee57687945402843c948cee399c758cdddf04468c42b1fb02a8800dd0627f6"}, +{"name":"doorkeeper-openid_connect","version":"1.8.6","platform":"ruby","checksum":"8dc46543e697476f441496a5d465bbc68c10d052e54348cec4db06d123b1e003"}, {"name":"dotenv","version":"2.7.6","platform":"ruby","checksum":"2451ed5e8e43776d7a787e51d6f8903b98e446146c7ad143d5678cc2c409d547"}, {"name":"dry-configurable","version":"0.12.0","platform":"ruby","checksum":"87a9579a04dfbae73e401d694282800d64bbdb8631cb3e987bfb79b673df7c67"}, {"name":"dry-container","version":"0.7.2","platform":"ruby","checksum":"a071824ba3451048b23500210f96a2b9facd6e46ac687f65e49c75d18786f6da"}, @@ -207,11 +210,11 @@ {"name":"gitaly","version":"15.9.0.pre.rc3","platform":"ruby","checksum":"6ac64320a70417131a4b97f5dd45d4e203d60703cc3cba156561e7f8c50a4abe"}, {"name":"gitlab","version":"4.19.0","platform":"ruby","checksum":"3f645e3e195dbc24f0834fbf83e8ccfb2056d8e9712b01a640aad418a6949679"}, {"name":"gitlab-chronic","version":"0.10.5","platform":"ruby","checksum":"f80f18dc699b708870a80685243331290bc10cfeedb6b99c92219722f729c875"}, -{"name":"gitlab-dangerfiles","version":"3.9.0","platform":"ruby","checksum":"37baa9856861b1c6a91d44adcde8654117a5cf2804ad513feffa2a86bda0d78e"}, +{"name":"gitlab-dangerfiles","version":"3.10.0","platform":"ruby","checksum":"df4cfe051f52529c0256346d89d06d5ef2bb630928754eb620b5233eb9b14041"}, {"name":"gitlab-experiment","version":"0.7.1","platform":"ruby","checksum":"166dddb3aa83428bcaa93c35684ed01dc4d61f321fd2ae40b020806dc54a7824"}, {"name":"gitlab-fog-azure-rm","version":"1.7.0","platform":"ruby","checksum":"969c67943c54ad4c259a6acd040493f13922fbdf2211bb4eca00e71505263dc2"}, -{"name":"gitlab-labkit","version":"0.31.1","platform":"ruby","checksum":"3e3a39370966b5d2739c2d9d9005c0ea27541d32cb7292e856e8bd74c720bffb"}, -{"name":"gitlab-license","version":"2.2.1","platform":"ruby","checksum":"39fcf6be8b2887df8afe01b5dcbae8d08b7c5d937ff56b0fb40484a8c4f02d30"}, +{"name":"gitlab-labkit","version":"0.32.0","platform":"ruby","checksum":"f30a33edc53586c059fd0b5d748acd2a12be75f6fc72a87669a0a08fe922866e"}, +{"name":"gitlab-license","version":"2.2.2","platform":"ruby","checksum":"2ccbc763828d013524b0b3b9ee671e58d5277693e5ffb2e5463cbac87e8aed1e"}, {"name":"gitlab-mail_room","version":"0.0.23","platform":"ruby","checksum":"23564fa4dab24ec5011d4c64a801fc0228301d5b0f046a26a1d8e96e36c19997"}, {"name":"gitlab-markup","version":"1.9.0","platform":"ruby","checksum":"7eda045a08ec2d110084252fa13a8c9eac8bdac0e302035ca7db4b82bcbd7ed4"}, {"name":"gitlab-net-dns","version":"0.9.2","platform":"ruby","checksum":"f726d978479d43810819f12a45c0906d775a07e34df111bbe693fffbbef3059d"}, @@ -321,13 +324,13 @@ {"name":"kaminari-actionview","version":"1.2.2","platform":"ruby","checksum":"1330f6fc8b59a4a4ef6a549ff8a224797289ebf7a3a503e8c1652535287cc909"}, {"name":"kaminari-activerecord","version":"1.2.2","platform":"ruby","checksum":"0dd3a67bab356a356f36b3b7236bcb81cef313095365befe8e98057dd2472430"}, {"name":"kaminari-core","version":"1.2.2","platform":"ruby","checksum":"3bd26fec7370645af40ca73b9426a448d09b8a8ba7afa9ba3c3e0d39cdbb83ff"}, -{"name":"kas-grpc","version":"0.0.2","platform":"ruby","checksum":"111ff7515952e939f491297ba4c69a218b72d9d0ef8e5bff80a5df6a56df9a16"}, +{"name":"kas-grpc","version":"0.1.0","platform":"ruby","checksum":"b219c79b7bddf1f3ac6a78119e25b0b52c0c29608b3a80c75929c47f32a50dda"}, {"name":"knapsack","version":"1.21.1","platform":"ruby","checksum":"82f70422adebcacec1b514f6ebff65265fc85d836e3c320718a160d8ac41cf14"}, {"name":"kramdown","version":"2.3.2","platform":"ruby","checksum":"cb4530c2e9d16481591df2c9336723683c354e5416a5dd3e447fa48215a6a71c"}, {"name":"kramdown-parser-gfm","version":"1.1.0","platform":"ruby","checksum":"fb39745516427d2988543bf01fc4cf0ab1149476382393e0e9c48592f6581729"}, {"name":"kubeclient","version":"4.11.0","platform":"ruby","checksum":"4985fcd749fb8c364a668a8350a49821647f03aa52d9ee6cbc582beb8e883fcc"}, {"name":"launchy","version":"2.5.0","platform":"ruby","checksum":"954243c4255920982ce682f89a42e76372dba94770bf09c23a523e204bdebef5"}, -{"name":"lefthook","version":"1.3.10","platform":"ruby","checksum":"68cd583689b0484eed4e5eee58fb4a8c1b40892821d69cd813f8b38e959a59b3"}, +{"name":"lefthook","version":"1.3.13","platform":"ruby","checksum":"0f51b9eaa3b9193cf423d8766012df3bd1bc0467c458755ed16779013930df72"}, {"name":"letter_opener","version":"1.7.0","platform":"ruby","checksum":"095bc0d58e006e5b43ea7d219e64ecf2de8d1f7d9dafc432040a845cf59b4725"}, {"name":"letter_opener_web","version":"2.0.0","platform":"ruby","checksum":"33860ad41e1785d75456500e8ca8bba8ed71ee6eaf08a98d06bbab67c5577b6f"}, {"name":"libyajl2","version":"1.2.0","platform":"ruby","checksum":"1117cd1e48db013b626e36269bbf1cef210538ca6d2e62d3fa3db9ded005b258"}, @@ -338,8 +341,8 @@ {"name":"locale","version":"2.1.3","platform":"ruby","checksum":"b6ddee011e157817cb98e521b3ce7cb626424d5882f1e844aafdee3e8b212725"}, {"name":"lockbox","version":"1.1.1","platform":"ruby","checksum":"0af16b14c54f791c148615a0115387b51903d868c7fe622f49606c97071c2ac0"}, {"name":"lograge","version":"0.11.2","platform":"ruby","checksum":"4cbd1554b86f545d795eff15a0c24fd25057d2ac4e1caa5fc186168b3da932ef"}, -{"name":"loofah","version":"2.20.0","platform":"ruby","checksum":"e8fa874c8e2cd2fbdbecc1b6badc3f713639796aaca3f6dd494c4737828a24d6"}, -{"name":"lookbook","version":"1.5.3","platform":"ruby","checksum":"4a0ff475af85de0dcdf45a5541fbc40dd8f66669a559efe8297c1d7fee028b38"}, +{"name":"loofah","version":"2.21.0","platform":"ruby","checksum":"ec407f23abdbd3481640c79342a9179320d297b30456df3b46381ba0981f025b"}, +{"name":"lookbook","version":"2.0.1","platform":"ruby","checksum":"0f14729c8c992810de0792a0be865a5792e5765fbaea5950cce74c6e5c73fc4a"}, {"name":"lru_redux","version":"1.1.0","platform":"ruby","checksum":"ee71d0ccab164c51de146c27b480a68b3631d5b4297b8ffe8eda1c72de87affb"}, {"name":"lumberjack","version":"1.2.7","platform":"ruby","checksum":"a5c6aae6b4234f1420dbcd80b23e3bca0817bd239440dde097ebe3fa63c63b1f"}, {"name":"mail","version":"2.8.1","platform":"ruby","checksum":"ec3b9fadcf2b3755c78785cb17bc9a0ca9ee9857108a64b6f5cfc9c0b5bfc9ad"}, @@ -372,6 +375,7 @@ {"name":"mustermann","version":"1.1.1","platform":"ruby","checksum":"0a21cfe505869cce9ce17998db5260344e78df81ae857c07a62143fd30299531"}, {"name":"mustermann-grape","version":"1.0.1","platform":"ruby","checksum":"00ce12b3df66be33ec4304aa9108fb9e1a0689f2a136c96b51c104684f5c5436"}, {"name":"nap","version":"1.1.0","platform":"ruby","checksum":"949691660f9d041d75be611bb2a8d2fd559c467537deac241f4097d9b5eea576"}, +{"name":"neighbor","version":"0.2.3","platform":"ruby","checksum":"70887ac2110d0c7ab243ee988f64359b8bb94a63a0c78542bbeef4f33b1933e5"}, {"name":"nenv","version":"0.3.0","platform":"ruby","checksum":"d9de6d8fb7072228463bf61843159419c969edb34b3cef51832b516ae7972765"}, {"name":"net-http-persistent","version":"4.0.1","platform":"ruby","checksum":"2752f4cce05fd1c45e0537c6f3a98fa5a4899efd5f88e63c104ed5f05cbddef9"}, {"name":"net-imap","version":"0.3.4","platform":"ruby","checksum":"a82a59e2a429433dc54cae5a8b2979ffe49da8c66085740811bfa337dc3729b5"}, @@ -417,12 +421,12 @@ {"name":"omniauth-oauth","version":"1.2.0","platform":"ruby","checksum":"e7a78658498dc83aa3f3be1a776425c0f06a60d45d9236dbe5e98e61fadf827b"}, {"name":"omniauth-oauth2","version":"1.8.0","platform":"ruby","checksum":"b2f8e9559cc7e2d4efba57607691d6d2b634b879fc5b5b6ccfefa3da85089e78"}, {"name":"omniauth-oauth2-generic","version":"0.2.8","platform":"ruby","checksum":"ce6e8539019d5ebf2f48867072b9f248f148bb4cbe7166dee655865abfae7613"}, -{"name":"omniauth-saml","version":"2.0.0","platform":"ruby","checksum":"02594fd6630de26a9e65a2e64223e9ad32324fa97a6c7f1f22a1553ea3dd44c7"}, +{"name":"omniauth-saml","version":"2.1.0","platform":"ruby","checksum":"969cb7ba271891d09dfa57b206fc274f43203c52727492517decda93decc6906"}, {"name":"omniauth-twitter","version":"1.4.0","platform":"ruby","checksum":"c5cc6c77cd767745ffa9ebbd5fbd694a3fa99d1d2d82a4d7def0bf3b6131b264"}, {"name":"omniauth_openid_connect","version":"0.6.1","platform":"ruby","checksum":"5f1318f5b19b05e339ff494def060b57a503b1e3ea83c3a0ced6cc014407d423"}, {"name":"open4","version":"1.3.4","platform":"ruby","checksum":"a1df037310624ecc1ea1d81264b11c83e96d0c3c1c6043108d37d396dcd0f4b1"}, {"name":"openid_connect","version":"1.3.0","platform":"ruby","checksum":"a796855096850cc01140e37ea6ae9fd14f2be818b9b5bc698418063dfe228770"}, -{"name":"openssl","version":"2.2.2","platform":"ruby","checksum":"53f72382bac046c36c37049c7ec9d5597d42628d140b5cfbcd61e0226c0ca077"}, +{"name":"openssl","version":"3.1.0","platform":"ruby","checksum":"e3a01279e918a7a5cf741db69b124864878b1a9783b1f2d34854bc1d444ac430"}, {"name":"openssl-signature_algorithm","version":"1.3.0","platform":"ruby","checksum":"a3b40b5e8276162d4a6e50c7c97cdaf1446f9b2c3946a6fa2c14628e0c957e80"}, {"name":"opentracing","version":"0.5.0","platform":"ruby","checksum":"deb5d7abe6b0e7631d866d8cb5ee7bb9352650a504a32f61591302bc510b9286"}, {"name":"optimist","version":"3.0.1","platform":"ruby","checksum":"336b753676d6117cad9301fac7e91dab4228f747d4e7179891ad3a163c64e2ed"}, @@ -437,10 +441,10 @@ {"name":"parslet","version":"1.8.2","platform":"ruby","checksum":"08d1ab3721cd3f175bfbee8788b2ddff71f92038f2d69bd65454c22bb9fbd98a"}, {"name":"pastel","version":"0.8.0","platform":"ruby","checksum":"481da9fb7d2f6e6b1a08faf11fa10363172dc40fd47848f096ae21209f805a75"}, {"name":"peek","version":"1.1.0","platform":"ruby","checksum":"d6501ead8cde46d8d8ed0d59eb6f0ba713d0a41c11a2c4a81447b2dce37b3ecc"}, -{"name":"pg","version":"1.4.6","platform":"ruby","checksum":"d98f3dcb4a6ae29780a2219340cb0e55dbafbb7eb4ccc2b99f892f2569a7a61e"}, -{"name":"pg","version":"1.4.6","platform":"x64-mingw-ucrt","checksum":"1efb4f932d5579b87b1c37e0ef49d101925d4f0e3fcf282569aed0382a522b68"}, -{"name":"pg","version":"1.4.6","platform":"x64-mingw32","checksum":"26c4a010fe2cefe61f56f0c4ba9a86b6e99d0965af100f30eaba1602a167af56"}, -{"name":"pg","version":"1.4.6","platform":"x86-mingw32","checksum":"14376f8a122ec58b9e1b4123774e7eafb59222544b7c6cfaa379c6ef28785ae6"}, +{"name":"pg","version":"1.5.3","platform":"ruby","checksum":"6b9ee5e2d5aee975588232c41f8203e766157cf71dba54ee85b343a45ced9bfd"}, +{"name":"pg","version":"1.5.3","platform":"x64-mingw-ucrt","checksum":"1f2a6b2afaf0ccb8afe8b6a00131bce8151fbd6e8826b2d944288f6f2b615389"}, +{"name":"pg","version":"1.5.3","platform":"x64-mingw32","checksum":"ab7f5f3020323094a2b16f9638166b04c103e152a9079a1b8e795f4bf79765e0"}, +{"name":"pg","version":"1.5.3","platform":"x86-mingw32","checksum":"aa6ddda9887462d30a6d49d875eb9d27fca8cdb7185103b650e7351b38f15ddf"}, {"name":"pg_query","version":"2.2.1","platform":"ruby","checksum":"6086972bbf4eab86d8425b35f14ca8b6fe41e4341423582801c1ec86ff5f8cea"}, {"name":"plist","version":"3.6.0","platform":"ruby","checksum":"f468bcf6b72ec6d1585ed6744eb4817c1932a5bf91895ed056e69b7f12ca10f2"}, {"name":"png_quantizator","version":"0.2.1","platform":"ruby","checksum":"6023d4d064125c3a7e02929c95b7320ed6ac0d7341f9e8de0c9ea6576ef3106b"}, @@ -448,7 +452,11 @@ {"name":"premailer","version":"1.16.0","platform":"ruby","checksum":"03e4402c448e6bae13fb5f6301a8bde4f3508e1bff90ae7c0972c7be94694786"}, {"name":"premailer-rails","version":"1.10.3","platform":"ruby","checksum":"7cdcb97027866f7a81c490c6d15ada7f39666b5f6375f0821b7e97e0483b112f"}, {"name":"proc_to_ast","version":"0.1.0","platform":"ruby","checksum":"92a73fa66e2250a83f8589f818b0751bcf227c68f85916202df7af85082f8691"}, -{"name":"prometheus-client-mmap","version":"0.19.1","platform":"ruby","checksum":"718b5f1aacab79877b30ae2f897fbf0c6a6d15d7f6e03928abb50a76ba479c7d"}, +{"name":"prometheus-client-mmap","version":"0.23.1","platform":"aarch64-linux","checksum":"4091121090d1d44747b3d09f2dbd5fdd61e274d557b8ed98b06c65cdd006d174"}, +{"name":"prometheus-client-mmap","version":"0.23.1","platform":"arm64-darwin","checksum":"fa54f230631852392b38cba1ad396c0472cb9f088eef563d0c381b19b1333855"}, +{"name":"prometheus-client-mmap","version":"0.23.1","platform":"ruby","checksum":"48545f23217a5e85ca79fa8c2563711e319debdae46ddbd6348ff37f48029c40"}, +{"name":"prometheus-client-mmap","version":"0.23.1","platform":"x86_64-darwin","checksum":"99b56f4017f0a1a062914da253c613b9957bfabf5b38af5012e3d8515ed49555"}, +{"name":"prometheus-client-mmap","version":"0.23.1","platform":"x86_64-linux","checksum":"624da747dbb97e0d88be1f2ba5ae5253941fc85dea875845f5b4c7a2c95ee032"}, {"name":"pry","version":"0.14.2","platform":"java","checksum":"fd780670977ba04ff7ee32dabd4d02fe4bf02e977afe8809832d5dca1412862e"}, {"name":"pry","version":"0.14.2","platform":"ruby","checksum":"c4fe54efedaca1d351280b45b8849af363184696fcac1c72e0415f9bdac4334d"}, {"name":"pry-byebug","version":"3.10.1","platform":"ruby","checksum":"c8f975c32255bfdb29e151f5532130be64ff3d0042dc858d0907e849125581f8"}, @@ -462,7 +470,7 @@ {"name":"raabro","version":"1.4.0","platform":"ruby","checksum":"d4fa9ff5172391edb92b242eed8be802d1934b1464061ae5e70d80962c5da882"}, {"name":"racc","version":"1.6.2","platform":"java","checksum":"0880781e7dfde09e665d0b6160b583e01ed52fcc2955d7891447d33c2d1d2cf1"}, {"name":"racc","version":"1.6.2","platform":"ruby","checksum":"58d26b3666382396fea84d33dc0639b7ee8d704156a52f8f22681f07b2f94f26"}, -{"name":"rack","version":"2.2.6.4","platform":"ruby","checksum":"d3d92be402b5881058caccc0975e6d67a1e0ba929d1d144a43daf689169bfce1"}, +{"name":"rack","version":"2.2.7","platform":"ruby","checksum":"b3377e8b2227b8ffa6b617ef8649ffb5e265e46ca8fa1f31244c809fe609829b"}, {"name":"rack-accept","version":"0.4.5","platform":"ruby","checksum":"66247b5449db64ebb93ae2ec4af4764b87d1ae8a7463c7c68893ac13fa8d4da2"}, {"name":"rack-attack","version":"6.6.1","platform":"ruby","checksum":"187e5d248c6a162ed8cafa8241a7b5947d9b9cf122a4870eb1cdd0db861f3a11"}, {"name":"rack-cors","version":"1.1.1","platform":"ruby","checksum":"4702644ac6d63ebbddff372a3cd4cd573513287e3524b5a5415f678970057a4b"}, @@ -481,6 +489,7 @@ {"name":"rake","version":"13.0.6","platform":"ruby","checksum":"5ce4bf5037b4196c24ac62834d8db1ce175470391026bd9e557d669beeb19097"}, {"name":"rb-fsevent","version":"0.11.2","platform":"ruby","checksum":"43900b972e7301d6570f64b850a5aa67833ee7d87b458ee92805d56b7318aefe"}, {"name":"rb-inotify","version":"0.10.1","platform":"ruby","checksum":"050062d4f31d307cca52c3f6a7f4b946df8de25fc4bd373e1a5142e41034a7ca"}, +{"name":"rb_sys","version":"0.9.75","platform":"ruby","checksum":"435427cf071c40a684b4be20f14bb7e64e122e75b131f24101fa897c8ed9a8ff"}, {"name":"rbtrace","version":"0.4.14","platform":"ruby","checksum":"162bbf89cecabfc4f09c869b655f6f3a679c4870ebb7cbdcadf7393a81cc1769"}, {"name":"rbtree","version":"0.4.6","platform":"ruby","checksum":"14eea4469b24fd2472542e5f3eb105d6344c8ccf36f0b56d55fdcfeb4e0f10fc"}, {"name":"rchardet","version":"1.8.0","platform":"ruby","checksum":"693acd5253d5ade81a51940697955f6dd4bb2f0d245bda76a8e23deec70a52c7"}, @@ -555,14 +564,13 @@ {"name":"sawyer","version":"0.9.2","platform":"ruby","checksum":"fa3a72d62a4525517b18857ddb78926aab3424de0129be6772a8e2ba240e7aca"}, {"name":"sd_notify","version":"0.1.1","platform":"ruby","checksum":"cbc7ac6caa7cedd26b30a72b5eeb6f36050dc0752df263452ea24fb5a4ad3131"}, {"name":"seed-fu","version":"2.3.7","platform":"ruby","checksum":"f19673443e9af799b730e3d4eca6a89b39e5a36825015dffd00d02ea3365cf74"}, -{"name":"selenium-webdriver","version":"3.142.7","platform":"ruby","checksum":"dea0993e0e4fdb364f0453144814c0e6099a411d17396807c6cac666d0ddac29"}, +{"name":"selenium-webdriver","version":"4.9.0","platform":"ruby","checksum":"0f5fc4118ab231e5ef1895b1e14a4366eb9d73d60a8e42b0d84f69cdfdd8b6cf"}, {"name":"semver_dialects","version":"1.2.1","platform":"ruby","checksum":"60a1f67659f79c51a667e8858ec9b089c1e4ce4f6d2a0f0b4ac101916946eb23"}, {"name":"sentry-rails","version":"5.8.0","platform":"ruby","checksum":"c11b2d909de2c2bfda793c45f64180fd784d54c46886338b683ee3f8efa7731b"}, {"name":"sentry-raven","version":"3.1.2","platform":"ruby","checksum":"103d3b122958810d34898ce2e705bcf549ddb9d855a70ce9a3970ee2484f364a"}, {"name":"sentry-ruby","version":"5.8.0","platform":"ruby","checksum":"caeb121433be379fb94e991a45265a287b13a9a9083e7264f539752369d37110"}, {"name":"sentry-sidekiq","version":"5.8.0","platform":"ruby","checksum":"90d1123d16a9fc5fd99dbad190b766dd189eaf9e2baddad641f1334e1877c779"}, {"name":"set","version":"1.0.1","platform":"ruby","checksum":"d169fe8df4738e9da1118199429a9cf1ce0ac5e8a3cacc481e2ed24d585419dd"}, -{"name":"settingslogic","version":"2.0.9","platform":"ruby","checksum":"5925a91d0d48dfb59a6e48ae2bb9c9b801fe6fab25a8e8d302ce8699d92f2ae6"}, {"name":"sexp_processor","version":"4.16.1","platform":"ruby","checksum":"5caadbf4bbe5ab539cb892a5bcf74ca33a2f2a897cecafdee4a63be79b4819dc"}, {"name":"shellany","version":"0.0.1","platform":"ruby","checksum":"0e127a9132698766d7e752e82cdac8250b6adbd09e6c0a7fbbb6f61964fedee7"}, {"name":"shoulda-matchers","version":"5.1.0","platform":"ruby","checksum":"a01d20589989e9653ab4a28c67d9db2b82bcf0a2496cf01d5e1a95a4aaaf5b07"}, @@ -600,7 +608,7 @@ {"name":"sqlite3","version":"1.6.0","platform":"x86_64-linux","checksum":"a2488dcf0e72928bab2b15b934113ce8d7a3b4031277e362d66e40956d5c709e"}, {"name":"ssh_data","version":"1.3.0","platform":"ruby","checksum":"ec7c1e95a3aebeee412147998f4c147b4b05da6ed0aafda6083f9449318eaac0"}, {"name":"ssrf_filter","version":"1.0.8","platform":"ruby","checksum":"03f49f54837e407d43ee93ec733a8a94dc1bcf8185647ac61606e63aaedaa0db"}, -{"name":"stackprof","version":"0.2.23","platform":"ruby","checksum":"5c930b229c27bc64a2a0eb5e7203d76756ba0567bad7bf5290921ee1ed50230b"}, +{"name":"stackprof","version":"0.2.25","platform":"ruby","checksum":"28db0e2d22b817ae35def7163822505a04a026b02ef119b6aa89d70b967b0d2e"}, {"name":"state_machines","version":"0.5.0","platform":"ruby","checksum":"23e6249d374a920b528dccade403518b4abbd83841a3e2c9ef13e6f1a009b102"}, {"name":"state_machines-activemodel","version":"0.8.0","platform":"ruby","checksum":"e932dab190d4be044fb5f9cab01a3ea0b092c5f113d4676c6c0a0d49bf738d2c"}, {"name":"state_machines-activerecord","version":"0.8.0","platform":"ruby","checksum":"072fb701b8ab03de0608297f6c55dc34ed096e556fa8f77e556f3c461c71aab6"}, @@ -644,7 +652,6 @@ {"name":"tty-screen","version":"0.8.1","platform":"ruby","checksum":"6508657c38f32bdca64880abe201ce237d80c94146e1f9b911cba3c7823659a2"}, {"name":"typhoeus","version":"1.4.0","platform":"ruby","checksum":"fff9880d5dc35950e7706cf132fd297f377c049101794be1cf01c95567f642d4"}, {"name":"tzinfo","version":"2.0.6","platform":"ruby","checksum":"8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b"}, -{"name":"u2f","version":"0.2.1","platform":"ruby","checksum":"7907b163c00682ce94d82178154af2ec3930e50f342c3502d64929c6370c5553"}, {"name":"uber","version":"0.1.0","platform":"ruby","checksum":"5beeb407ff807b5db994f82fa9ee07cfceaa561dad8af20be880bc67eba935dc"}, {"name":"undercover","version":"0.4.5","platform":"ruby","checksum":"27bb5d708e253e2c1a3f3edd3668a30728f0e59a1e18004b623d5e7b1e86f3b9"}, {"name":"unf","version":"0.1.4","platform":"java","checksum":"49a5972ec0b3d091d3b0b2e00113f2f342b9b212f0db855eb30a629637f6d302"}, @@ -665,7 +672,7 @@ {"name":"validates_hostname","version":"1.0.11","platform":"ruby","checksum":"d506bae0342ec14c920eb319e057fc1886c321a59b85b4b6e966ee4b88fab8c3"}, {"name":"version_gem","version":"1.1.0","platform":"ruby","checksum":"6b009518020db57f51ec7b410213fae2bf692baea9f1b51770db97fbc93d9a80"}, {"name":"version_sorter","version":"2.3.0","platform":"ruby","checksum":"2147f2a1a3804fbb8f60d268b7d7c1ec717e6dd727ffe2c165b4e05e82efe1da"}, -{"name":"view_component","version":"2.74.1","platform":"ruby","checksum":"0bbd47a9c11455a45043dc01aa604db708654718a4d8755c911425482e8392c0"}, +{"name":"view_component","version":"2.82.0","platform":"ruby","checksum":"c8b69561e19d8f9c4ba8c16df7f3bf2a5f0bba439dd25a597948e118f6bc9baf"}, {"name":"virtus","version":"2.0.0","platform":"ruby","checksum":"8841dae4eb7fcc097320ba5ea516bf1839e5d056c61ee27138aa4bddd6e3d1c2"}, {"name":"vmstat","version":"2.3.0","platform":"ruby","checksum":"ab5446a3e3bd0a9cdb9d9ac69a0bbd119c4f161d945a0846a519dd7018af656d"}, {"name":"warden","version":"1.2.9","platform":"ruby","checksum":"46684f885d35a69dbb883deabf85a222c8e427a957804719e143005df7a1efd0"}, @@ -674,6 +681,7 @@ {"name":"webfinger","version":"1.2.0","platform":"ruby","checksum":"7814ef1c85da47514f65c6e5ca14205fa9ce41ea2a70785e0c872842162852a2"}, {"name":"webmock","version":"3.18.1","platform":"ruby","checksum":"54c955df4ae4bec6181dd266eeec632a1808288c633f9551d81bafb53921d2d7"}, {"name":"webrick","version":"1.8.1","platform":"ruby","checksum":"19411ec6912911fd3df13559110127ea2badd0c035f7762873f58afc803e158f"}, +{"name":"websocket","version":"1.2.9","platform":"ruby","checksum":"884b12dee993217795bb5f58acc89c0121c88bdc99df4d1636c0505dca352b36"}, {"name":"websocket-driver","version":"0.7.5","platform":"java","checksum":"fffa83aa188e9ac90e32a385832ec9d26acdf019538e1c7d703f2c8a323b39c8"}, {"name":"websocket-driver","version":"0.7.5","platform":"ruby","checksum":"a280c3f44dcbb0323d58bc78dc49350c05d589ab7d13267fcff08d9d5ae76b28"}, {"name":"websocket-extensions","version":"0.1.5","platform":"ruby","checksum":"1c6ba63092cda343eb53fc657110c71c754c56484aad42578495227d717a8241"}, diff --git a/Gemfile.lock b/Gemfile.lock index cbc11b360a..199c806a85 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -61,14 +61,6 @@ PATH omniauth (~> 2.0) omniauth-oauth2 (~> 1.4) -PATH - remote: vendor/gems/omniauth-cas3 - specs: - omniauth-cas3 (1.1.4) - addressable (~> 2.3) - nokogiri (~> 1.7, >= 1.7.1) - omniauth (~> 2.0) - PATH remote: vendor/gems/omniauth-gitlab specs: @@ -207,19 +199,19 @@ GEM awesome_print (1.9.2) awrence (1.2.1) aws-eventstream (1.2.0) - aws-partitions (1.733.0) + aws-partitions (1.761.0) aws-sdk-cloudformation (1.41.0) aws-sdk-core (~> 3, >= 3.99.0) aws-sigv4 (~> 1.1) - aws-sdk-core (3.171.0) + aws-sdk-core (3.172.0) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.651.0) aws-sigv4 (~> 1.5) jmespath (~> 1, >= 1.6.1) - aws-sdk-kms (1.63.0) + aws-sdk-kms (1.64.0) aws-sdk-core (~> 3, >= 3.165.0) aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.121.0) + aws-sdk-s3 (1.122.0) aws-sdk-core (~> 3, >= 3.165.0) aws-sdk-kms (~> 1) aws-sigv4 (~> 1.4) @@ -256,10 +248,10 @@ GEM memory_profiler (~> 1) benchmark-perf (0.6.0) benchmark-trend (0.4.0) - better_errors (2.9.1) - coderay (>= 1.0.0) + better_errors (2.10.0) erubi (>= 1.0.0) rack (>= 0.9.0) + rouge (>= 1.0.0) bindata (2.4.11) binding_of_caller (1.0.0) debug_inspector (>= 0.0.1) @@ -303,8 +295,8 @@ GEM mixlib-shellout (>= 2.0, < 4.0) tomlrb (~> 1.2) chef-utils (16.10.17) - childprocess (3.0.0) chunky_png (1.3.5) + circuitbox (2.0.0) citrus (3.0.2) claide (1.1.0) claide-plugins (0.9.2) @@ -375,6 +367,7 @@ GEM thor (>= 0.19, < 2) descendants_tracker (0.0.4) thread_safe (~> 0.3, >= 0.3.1) + devfile (0.0.17.pre.alpha1) device_detector (1.0.0) devise (4.8.1) bcrypt (~> 3.0) @@ -400,7 +393,7 @@ GEM unf (>= 0.0.5, < 1.0.0) doorkeeper (5.6.6) railties (>= 5) - doorkeeper-openid_connect (1.8.5) + doorkeeper-openid_connect (1.8.6) doorkeeper (>= 5.5, < 5.7) jwt (>= 2.5) dotenv (2.7.6) @@ -595,7 +588,7 @@ GEM terminal-table (>= 1.5.1) gitlab-chronic (0.10.5) numerizer (~> 0.2) - gitlab-dangerfiles (3.9.0) + gitlab-dangerfiles (3.10.0) danger (>= 8.4.5) danger-gitlab (>= 8.0.0) rake @@ -609,7 +602,7 @@ GEM fog-json (~> 1.2.0) mime-types ms_rest_azure (~> 0.12.0) - gitlab-labkit (0.31.1) + gitlab-labkit (0.32.0) actionpack (>= 5.0.0, < 8.0.0) activesupport (>= 5.0.0, < 8.0.0) grpc (>= 1.37) @@ -617,7 +610,7 @@ GEM opentracing (~> 0.4) pg_query (~> 2.1) redis (> 3.0.0, < 6.0.0) - gitlab-license (2.2.1) + gitlab-license (2.2.2) gitlab-mail_room (0.0.23) jwt (>= 2.0) net-imap (>= 0.2.1) @@ -870,7 +863,7 @@ GEM activerecord kaminari-core (= 1.2.2) kaminari-core (1.2.2) - kas-grpc (0.0.2) + kas-grpc (0.1.0) grpc (~> 1.0) knapsack (1.21.1) rake @@ -885,7 +878,7 @@ GEM rest-client (~> 2.0) launchy (2.5.0) addressable (~> 2.7) - lefthook (1.3.10) + lefthook (1.3.13) letter_opener (1.7.0) launchy (~> 2.2) letter_opener_web (2.0.0) @@ -920,20 +913,19 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.20.0) + loofah (2.21.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) - lookbook (1.5.3) - actioncable + lookbook (2.0.1) activemodel css_parser htmlbeautifier (~> 1.3) htmlentities (~> 4.3.4) - listen (~> 3.0) + marcel (~> 1.0) railties (>= 5.0) redcarpet (~> 3.5) rouge (>= 3.26, < 5.0) - view_component (> 2.0, < 4) + view_component (>= 2.0) yard (~> 0.9.25) zeitwerk (~> 2.5) lru_redux (1.1.0) @@ -984,6 +976,8 @@ GEM mustermann-grape (1.0.1) mustermann (>= 1.0.0) nap (1.1.0) + neighbor (0.2.3) + activerecord (>= 5.2) nenv (0.3.0) net-http-persistent (4.0.1) connection_pool (~> 2.2) @@ -1073,9 +1067,9 @@ GEM omniauth-oauth2-generic (0.2.8) omniauth-oauth2 (~> 1.0) rake - omniauth-saml (2.0.0) + omniauth-saml (2.1.0) omniauth (~> 2.0) - ruby-saml (~> 1.9) + ruby-saml (~> 1.12) omniauth-twitter (1.4.0) omniauth-oauth (~> 1.1) rack @@ -1093,8 +1087,7 @@ GEM validate_email validate_url webfinger (>= 1.0.1) - openssl (2.2.2) - ipaddr + openssl (3.1.0) openssl-signature_algorithm (1.3.0) openssl (> 2.0) opentracing (0.5.0) @@ -1134,7 +1127,7 @@ GEM tty-color (~> 0.5) peek (1.1.0) railties (>= 4.0.0) - pg (1.4.6) + pg (1.5.3) pg_query (2.2.1) google-protobuf (>= 3.19.2) plist (3.6.0) @@ -1152,7 +1145,8 @@ GEM coderay parser unparser - prometheus-client-mmap (0.19.1) + prometheus-client-mmap (0.23.1) + rb_sys (~> 0.9) pry (0.14.2) coderay (~> 1.1) method_source (~> 1.0) @@ -1174,7 +1168,7 @@ GEM pyu-ruby-sasl (0.0.3.3) raabro (1.4.0) racc (1.6.2) - rack (2.2.6.4) + rack (2.2.7) rack-accept (0.4.5) rack (>= 0.4) rack-attack (6.6.1) @@ -1232,6 +1226,7 @@ GEM rb-fsevent (0.11.2) rb-inotify (0.10.1) ffi (~> 1.0) + rb_sys (0.9.75) rbtrace (0.4.14) ffi (>= 1.0.6) msgpack (>= 0.4.3) @@ -1400,9 +1395,10 @@ GEM seed-fu (2.3.7) activerecord (>= 3.1) activesupport (>= 3.1) - selenium-webdriver (3.142.7) - childprocess (>= 0.5, < 4.0) - rubyzip (>= 1.2.2) + selenium-webdriver (4.9.0) + rexml (~> 3.2, >= 3.2.5) + rubyzip (>= 1.2.2, < 3.0) + websocket (~> 1.0) semver_dialects (1.2.1) pastel (~> 0.8.0) thor (~> 1.2.0) @@ -1418,7 +1414,6 @@ GEM sentry-ruby (~> 5.8.0) sidekiq (>= 3.0) set (1.0.1) - settingslogic (2.0.9) sexp_processor (4.16.1) shellany (0.0.1) shoulda-matchers (5.1.0) @@ -1487,7 +1482,7 @@ GEM mini_portile2 (~> 2.8.0) ssh_data (1.3.0) ssrf_filter (1.0.8) - stackprof (0.2.23) + stackprof (0.2.25) state_machines (0.5.0) state_machines-activemodel (0.8.0) activemodel (>= 5.1) @@ -1574,7 +1569,6 @@ GEM ethon (>= 0.9.0) tzinfo (2.0.6) concurrent-ruby (~> 1.0) - u2f (0.2.1) uber (0.1.0) undercover (0.4.5) imagen (>= 0.1.8) @@ -1606,8 +1600,8 @@ GEM activesupport (>= 3.0) version_gem (1.1.0) version_sorter (2.3.0) - view_component (2.74.1) - activesupport (>= 5.0.0, < 8.0) + view_component (2.82.0) + activesupport (>= 5.2.0, < 8.0) concurrent-ruby (~> 1.0) method_source (~> 1.0) virtus (2.0.0) @@ -1635,6 +1629,7 @@ GEM crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) webrick (1.8.1) + websocket (1.2.9) websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -1677,8 +1672,8 @@ DEPENDENCIES autoprefixer-rails (= 10.2.5.1) awesome_print aws-sdk-cloudformation (~> 1) - aws-sdk-core (~> 3.171.0) - aws-sdk-s3 (~> 1.121.0) + aws-sdk-core (~> 3.172.0) + aws-sdk-s3 (~> 1.122.0) axe-core-rspec babosa (~> 1.0.4) base32 (~> 0.3.0) @@ -1686,7 +1681,7 @@ DEPENDENCIES bcrypt (~> 3.1, >= 3.1.14) benchmark-ips (~> 2.11.0) benchmark-memory (~> 0.1) - better_errors (~> 2.9.1) + better_errors (~> 2.10.0) bootsnap (~> 1.16.0) browser (~> 5.3.1) bullet (~> 7.0.2) @@ -1696,6 +1691,7 @@ DEPENDENCIES capybara-screenshot (~> 1.0.26) carrierwave (~> 1.3) charlock_holmes (~> 0.7.7) + circuitbox (= 2.0.0) cloud_profiler_agent (~> 0.0.0)! commonmarker (~> 0.23.6) concurrent-ruby (~> 1.1) @@ -1709,6 +1705,7 @@ DEPENDENCIES declarative_policy (~> 1.1.0) deprecation_toolkit (~> 1.5.1) derailed_benchmarks + devfile (~> 0.0.17.pre.alpha1) device_detector devise (~> 4.8.1) devise-pbkdf2-encryptable (~> 0.0.0)! @@ -1717,7 +1714,7 @@ DEPENDENCIES diffy (~> 3.4) discordrb-webhooks (~> 3.4) doorkeeper (~> 5.6, >= 5.6.6) - doorkeeper-openid_connect (~> 1.8, >= 1.8.5) + doorkeeper-openid_connect (~> 1.8, >= 1.8.6) duo_api (~> 1.3) ed25519 (~> 1.3.0) elasticsearch-api (= 7.13.3) @@ -1746,10 +1743,10 @@ DEPENDENCIES gettext_i18n_rails_js (~> 1.3) gitaly (~> 15.9.0.pre.rc3) gitlab-chronic (~> 0.10.5) - gitlab-dangerfiles (~> 3.9.0) + gitlab-dangerfiles (~> 3.10.0) gitlab-experiment (~> 0.7.1) gitlab-fog-azure-rm (~> 1.7.0) - gitlab-labkit (~> 0.31.1) + gitlab-labkit (~> 0.32.0) gitlab-license (~> 2.2.1) gitlab-mail_room (~> 0.0.23) gitlab-markup (~> 1.9.0) @@ -1805,19 +1802,19 @@ DEPENDENCIES json_schemer (~> 0.2.18) jwt (~> 2.5) kaminari (~> 1.2.2) - kas-grpc (~> 0.0.2) + kas-grpc (~> 0.1.0) knapsack (~> 1.21.1) kramdown (~> 2.3.1) kubeclient (~> 4.11.0) - lefthook (~> 1.3.10) + lefthook (~> 1.3.13) letter_opener_web (~> 2.0.0) license_finder (~> 7.0) licensee (~> 9.15) listen (~> 3.7) lockbox (~> 1.1.1) lograge (~> 0.5) - loofah (~> 2.20.0) - lookbook (~> 1.5, >= 1.5.3) + loofah (~> 2.21.0) + lookbook (~> 2.0, >= 2.0.1) lru_redux mail (= 2.8.1) mail-smtp_pool (~> 0.1.0)! @@ -1827,6 +1824,7 @@ DEPENDENCIES mini_magick (~> 4.10.1) minitest (~> 5.11.0) multi_json (~> 1.14.1) + neighbor (~> 0.2.3) net-ldap (~> 0.17.1) net-ntp net-protocol (~> 0.1.3) @@ -1842,7 +1840,6 @@ DEPENDENCIES omniauth-auth0 (~> 3.1) omniauth-azure-activedirectory-v2 (~> 2.0) omniauth-azure-oauth2 (~> 0.0.9)! - omniauth-cas3 (~> 1.1.4)! omniauth-dingtalk-oauth2 (~> 1.0) omniauth-facebook (~> 4.0.0) omniauth-github (= 2.0.1) @@ -1850,28 +1847,28 @@ DEPENDENCIES omniauth-google-oauth2 (~> 1.1) omniauth-oauth2-generic (~> 0.2.2) omniauth-salesforce (~> 1.0.5)! - omniauth-saml (~> 2.0.0) + omniauth-saml (~> 2.1.0) omniauth-twitter (~> 1.4) omniauth_crowd (~> 2.4.0)! omniauth_openid_connect (~> 0.6.1) openid_connect (= 1.3.0) - openssl (= 2.2.2) + openssl (~> 3.0) org-ruby (~> 0.9.12) pact (~> 1.63) parallel (~> 1.19) parslet (~> 1.8) peek (~> 1.1) - pg (~> 1.4.6) + pg (~> 1.5.3) pg_query (~> 2.2, >= 2.2.1) png_quantizator (~> 0.2.1) premailer-rails (~> 1.10.3) - prometheus-client-mmap (~> 0.19) + prometheus-client-mmap (~> 0.23) pry-byebug pry-rails (~> 0.3.9) pry-shell (~> 0.6.1) puma (~> 5.6.5) puma_worker_killer (~> 0.3.1) - rack (~> 2.2.6, >= 2.2.6.4) + rack (~> 2.2.7) rack-attack (~> 6.6.1) rack-cors (~> 1.1.1) rack-oauth2 (~> 1.21.3) @@ -1913,13 +1910,12 @@ DEPENDENCIES sassc-rails (~> 2.1.0) sd_notify (~> 0.1.0) seed-fu (~> 2.3.7) - selenium-webdriver (~> 3.142, >= 3.142.7) + selenium-webdriver (= 4.9.0) semver_dialects (~> 1.2.1) sentry-rails (~> 5.8.0) sentry-raven (~> 3.1) sentry-ruby (~> 5.8.0) sentry-sidekiq (~> 5.8.0) - settingslogic (~> 2.0.9) shoulda-matchers (~> 5.1.0) sidekiq (~> 6.5.7) sidekiq-cron (~> 1.8.0) @@ -1937,7 +1933,7 @@ DEPENDENCIES sprite-factory (~> 1.7) sprockets (~> 3.7.0) ssh_data (~> 1.3) - stackprof (~> 0.2.23) + stackprof (~> 0.2.25) state_machines-activerecord (~> 0.8.0) sys-filesystem (~> 1.4.3) tanuki_emoji (~> 0.6) @@ -1950,14 +1946,13 @@ DEPENDENCIES toml-rb (~> 2.2.0) truncato (~> 0.7.12) typhoeus (~> 1.4.0) - u2f (~> 0.2.1) undercover (~> 0.4.4) unf (~> 0.1.4) unleash (~> 3.2.2) valid_email (~> 0.1) validates_hostname (~> 1.0.11) version_sorter (~> 2.3) - view_component (~> 2.74.1) + view_component (~> 2.82.0) vmstat (~> 2.3.0) warning (~> 1.3.0) webauthn (~> 3.0) @@ -1967,4 +1962,4 @@ DEPENDENCIES yajl-ruby (~> 1.4.3) BUNDLED WITH - 2.4.12 + 2.4.13 diff --git a/README.md b/README.md index b61af1b1f4..ee46c4ccdf 100644 --- a/README.md +++ b/README.md @@ -43,7 +43,7 @@ We are hiring developers, support people, and production engineers all the time, On [about.gitlab.com](https://about.gitlab.com/) you can find more information about: - [Subscriptions](https://about.gitlab.com/pricing/) -- [Consultancy](https://about.gitlab.com/consultancy/) +- [Professional Services](https://about.gitlab.com/services/) - [Community](https://about.gitlab.com/community/) - [Hosted GitLab.com](https://about.gitlab.com/gitlab-com/) use GitLab as a free service - [GitLab Enterprise Edition](https://about.gitlab.com/features/#enterprise) with additional features aimed at larger organizations. @@ -84,7 +84,7 @@ GitLab is a Ruby on Rails application that runs on the following software: - Ubuntu/Debian/CentOS/RHEL/OpenSUSE - Ruby (MRI) 3.0.5 - Git 2.33+ -- Redis 5.0+ +- Redis 6.0+ - PostgreSQL 12+ For more information please see the [architecture](https://docs.gitlab.com/ee/development/architecture.html) and [requirements](https://docs.gitlab.com/ee/install/requirements.html) documentation. diff --git a/VERSION b/VERSION index c694fe833b..81552bbef7 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -15.11.11 \ No newline at end of file +16.0.7 \ No newline at end of file diff --git a/app/assets/images/vulnerability/secureflag-logo.svg b/app/assets/images/vulnerability/secureflag-logo.svg new file mode 100644 index 0000000000..621c56b904 --- /dev/null +++ b/app/assets/images/vulnerability/secureflag-logo.svg @@ -0,0 +1,25 @@ + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/assets/javascripts/achievements/components/achievements_app.vue b/app/assets/javascripts/achievements/components/achievements_app.vue new file mode 100644 index 0000000000..5f40231856 --- /dev/null +++ b/app/assets/javascripts/achievements/components/achievements_app.vue @@ -0,0 +1,31 @@ + + + diff --git a/app/assets/javascripts/achievements/constants.js b/app/assets/javascripts/achievements/constants.js new file mode 100644 index 0000000000..82a56588c9 --- /dev/null +++ b/app/assets/javascripts/achievements/constants.js @@ -0,0 +1,7 @@ +export const INDEX_ROUTE_NAME = 'index'; +export const NEW_ROUTE_NAME = 'new'; +export const EDIT_ROUTE_NAME = 'edit'; +export const trackViewsOptions = { + category: 'Achievements' /* eslint-disable-line @gitlab/require-i18n-strings */, + action: 'view_achievements_list', +}; diff --git a/app/assets/javascripts/achievements/routes.js b/app/assets/javascripts/achievements/routes.js new file mode 100644 index 0000000000..12aa17d73b --- /dev/null +++ b/app/assets/javascripts/achievements/routes.js @@ -0,0 +1,16 @@ +import { INDEX_ROUTE_NAME, NEW_ROUTE_NAME, EDIT_ROUTE_NAME } from './constants'; + +export default [ + { + name: INDEX_ROUTE_NAME, + path: '/', + }, + { + name: NEW_ROUTE_NAME, + path: '/new', + }, + { + name: EDIT_ROUTE_NAME, + path: '/:id/edit', + }, +]; diff --git a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue index a5f8f36960..a9fb692b29 100644 --- a/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue +++ b/app/assets/javascripts/add_context_commits_modal/components/add_context_commits_modal_wrapper.vue @@ -18,6 +18,7 @@ import { removeIfPresent, } from '../utils'; import Token from './token.vue'; +import DateOption from './date_option.vue'; export default { components: { @@ -73,6 +74,7 @@ export default { operators: OPERATORS_IS, token: Token, unique: true, + optionComponent: DateOption, }, { formattedKey: __('Committed-after'), @@ -86,6 +88,7 @@ export default { operators: OPERATORS_IS, token: Token, unique: true, + optionComponent: DateOption, }, ], }; @@ -317,16 +320,7 @@ export default { :available-tokens="availableTokens" @clear="handleSearchCommits" @submit="handleSearchCommits" - > - - + /> +export default { + props: { + option: { + type: Object, + required: true, + }, + }, +}; + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/abuse_report_app.vue b/app/assets/javascripts/admin/abuse_report/components/abuse_report_app.vue new file mode 100644 index 0000000000..9355c1c788 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/abuse_report_app.vue @@ -0,0 +1,35 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/history_items.vue b/app/assets/javascripts/admin/abuse_report/components/history_items.vue new file mode 100644 index 0000000000..28b66db84a --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/history_items.vue @@ -0,0 +1,51 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/report_header.vue b/app/assets/javascripts/admin/abuse_report/components/report_header.vue new file mode 100644 index 0000000000..5458604135 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/report_header.vue @@ -0,0 +1,46 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/reported_content.vue b/app/assets/javascripts/admin/abuse_report/components/reported_content.vue new file mode 100644 index 0000000000..b5ffba2636 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/reported_content.vue @@ -0,0 +1,141 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/user_detail.vue b/app/assets/javascripts/admin/abuse_report/components/user_detail.vue new file mode 100644 index 0000000000..0aeee5e05f --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/user_detail.vue @@ -0,0 +1,27 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/components/user_details.vue b/app/assets/javascripts/admin/abuse_report/components/user_details.vue new file mode 100644 index 0000000000..3dc03a8748 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/components/user_details.vue @@ -0,0 +1,115 @@ + + + diff --git a/app/assets/javascripts/admin/abuse_report/constants.js b/app/assets/javascripts/admin/abuse_report/constants.js new file mode 100644 index 0000000000..a59e10b5d4 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/constants.js @@ -0,0 +1,61 @@ +import { s__, n__ } from '~/locale'; + +export const REPORT_HEADER_I18N = { + adminProfile: s__('AbuseReport|Admin profile'), +}; + +export const USER_DETAILS_I18N = { + createdAt: s__('AbuseReport|Member since'), + email: s__('AbuseReport|Email'), + plan: s__('AbuseReport|Tier'), + verification: s__('AbuseReport|Verification'), + creditCard: s__('AbuseReport|Credit card'), + otherReports: s__('AbuseReport|Abuse reports'), + normalLocation: s__('AbuseReport|Normal location'), + lastSignInIp: s__('AbuseReport|Last login'), + snippets: s__('AbuseReport|Snippets'), + groups: s__('AbuseReport|Groups'), + notes: s__('AbuseReport|Comments'), + snippetsCount: (count) => n__(`%d snippet`, `%d snippets`, count), + groupsCount: (count) => n__(`%d group`, `%d groups`, count), + notesCount: (count) => n__(`%d comment`, `%d comments`, count), + verificationMethods: { + email: s__('AbuseReport|Email'), + phone: s__('AbuseReport|Phone'), + creditCard: s__('AbuseReport|Credit card'), + }, + otherReport: s__( + 'AbuseReport|%{reportLinkStart}Reported%{reportLinkEnd} for %{category} %{timeAgo}.', + ), + registeredWith: s__('AbuseReport|Registered with name %{name}.'), + similarRecords: s__( + 'AbuseReport|Card matches %{cardMatchesLinkStart}%{count} accounts%{cardMatchesLinkEnd}', + ), +}; + +export const REPORTED_CONTENT_I18N = { + reportTypes: { + profile: s__('AbuseReport|Reported profile'), + comment: s__('AbuseReport|Reported comment'), + issue: s__('AbuseReport|Reported issue'), + merge_request: s__('AbuseReport|Reported merge request'), + unknown: s__('AbuseReport|Reported content'), + }, + viewScreenshot: s__('AbuseReport|View screenshot'), + screenshotTitle: s__('AbuseReport|Screenshot of reported abuse'), + goToType: { + profile: s__('AbuseReport|Go to profile'), + comment: s__('AbuseReport|Go to comment'), + issue: s__('AbuseReport|Go to issue'), + merge_request: s__('AbuseReport|Go to merge request'), + unknown: s__('AbuseReport|Go to content'), + }, + reportedBy: s__('AbuseReport|Reported by'), + deletedReporter: s__('AbuseReport|No user found'), +}; + +export const HISTORY_ITEMS_I18N = { + activity: s__('AbuseReport|Activity'), + reportedByForCategory: s__('AbuseReport|Reported by %{name} for %{category}.'), + deletedReporter: s__('AbuseReport|No user found'), +}; diff --git a/app/assets/javascripts/admin/abuse_report/index.js b/app/assets/javascripts/admin/abuse_report/index.js new file mode 100644 index 0000000000..8ff3e69012 --- /dev/null +++ b/app/assets/javascripts/admin/abuse_report/index.js @@ -0,0 +1,27 @@ +import Vue from 'vue'; +import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils'; +import AbuseReportApp from './components/abuse_report_app.vue'; + +export const initAbuseReportApp = () => { + const el = document.querySelector('#js-abuse-reports-detail-view'); + + if (!el) { + return null; + } + + const { abuseReportData } = el.dataset; + const abuseReport = convertObjectPropsToCamelCase(JSON.parse(abuseReportData), { + deep: true, + }); + + return new Vue({ + el, + name: 'AbuseReportAppRoot', + render: (createElement) => + createElement(AbuseReportApp, { + props: { + abuseReport, + }, + }), + }); +}; diff --git a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_actions.vue b/app/assets/javascripts/admin/abuse_reports/components/abuse_report_actions.vue index f2271f8af2..5d42caa75a 100644 --- a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_actions.vue +++ b/app/assets/javascripts/admin/abuse_reports/components/abuse_report_actions.vue @@ -1,7 +1,8 @@ diff --git a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_details.vue b/app/assets/javascripts/admin/abuse_reports/components/abuse_report_details.vue deleted file mode 100644 index f49411604f..0000000000 --- a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_details.vue +++ /dev/null @@ -1,66 +0,0 @@ - - - diff --git a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_row.vue b/app/assets/javascripts/admin/abuse_reports/components/abuse_report_row.vue index a9fe59a7b8..b8a4640de5 100644 --- a/app/assets/javascripts/admin/abuse_reports/components/abuse_report_row.vue +++ b/app/assets/javascripts/admin/abuse_reports/components/abuse_report_row.vue @@ -1,20 +1,15 @@