realaravinth/debian-mirror-gitlab
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

New upstream version 16.0.7+ds1

Browse source
This commit is contained in:
Pirate Praveen 2023-07-09 08:55:56 +05:30
parent 6b3dcb98e5
commit 271ccb9124
5859 changed files with 236572 additions and 184073 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.eslintrc.yml
View file

@ -117,6 +117,11 @@ rules:
message: 'Migrate to GlSkeletonLoader, or import GlDeprecatedSkeletonLoading.'
- selector: ImportSpecifier[imported.name='GlSafeHtmlDirective']
message: 'Use directive at ~/vue_shared/directives/safe_html.js instead.'
no-restricted-imports:
- error
- paths:
- name: mousetrap
message: 'Import { Mousetrap } from ~/lib/mousetrap instead.'
# See https://gitlab.com/gitlab-org/gitlab/-/issues/360551
vue/multi-word-component-names: off
unicorn/prefer-dom-node-dataset:
@ -148,6 +153,8 @@ overrides:
message: 'Prefer explicit waitForPromises (or equivalent), or jest.runAllTimers (or equivalent) to vague setImmediate calls.'
- selector: ImportSpecifier[imported.name='GlSkeletonLoading']
message: 'Migrate to GlSkeletonLoader, or import GlDeprecatedSkeletonLoading.'
- selector: CallExpression[arguments.length=1][arguments.0.type='Literal'] CallExpression[callee.property.name='toBe'] CallExpression[callee.property.name='attributes'][arguments.length=1][arguments.0.value='disabled']
message: Avoid asserting disabled attribute exact value, because Vue.js 2 and Vue.js 3 renders it differently. Use toBeDefined / toBeUndefined instead
no-unsanitized/method: off
no-unsanitized/property: off
- files:

2
.gitlab-ci.yml
View file

@ -165,6 +165,7 @@ variables:
RSPEC_PACKED_TESTS_MAPPING_PATH: crystalball/packed-mapping.json
RSPEC_PROFILING_FOLDER_PATH: rspec/profiling
RSPEC_TESTS_MAPPING_PATH: crystalball/mapping.json
RSPEC_FAST_QUARANTINE_LOCAL_PATH: rspec/fast_quarantine-gitlab.txt
TMP_TEST_FOLDER: "${CI_PROJECT_DIR}/tmp/tests"
TMP_TEST_GITLAB_WORKHORSE_PATH: "${TMP_TEST_FOLDER}/${GITLAB_WORKHORSE_FOLDER}"
@ -174,7 +175,6 @@ variables:
CACHE_CLASSES: "true"
CHECK_PRECOMPILED_ASSETS: "true"
FF_USE_FASTZIP: "true"
SKIP_FLAKY_TESTS_AUTOMATICALLY: "false"
RETRY_FAILED_TESTS_IN_NEW_PROCESS: "true"
# Run with decomposed databases by default
DECOMPOSED_DB: "true"

1504
.gitlab/CODEOWNERS
View file

File diff suppressed because it is too large Load diff

61
.gitlab/ci/as-if-jh.gitlab-ci.yml
View file

@ -1,9 +1,13 @@
.shared-as-if-jh:
.as-if-jh-sandbox-variables:
variables:
SANDBOX_PROJECT: "gitlab-org-sandbox/gitlab-jh-validation"
SANDBOX_REPOSITORY: "https://dummy:${AS_IF_JH_TOKEN}@gitlab.com/${SANDBOX_PROJECT}.git"
GITLAB_JH_MIRROR_PROJECT: "33019816"
AS_IF_JH_BRANCH: "as-if-jh/${CI_COMMIT_REF_NAME}"
SANDBOX_REPOSITORY: "https://dummy:${AS_IF_JH_TOKEN}@gitlab.com/gitlab-org-sandbox/gitlab-jh-validation.git"
.shared-as-if-jh:
extends:
- .as-if-jh-sandbox-variables
variables:
GITLAB_JH_MIRROR_PROJECT: "33019816"
JH_FILES_TO_COMMIT: "jh package.json yarn.lock"
add-jh-files:
@ -42,30 +46,61 @@ prepare-as-if-jh-branch:
# so instead we tell runner to not clone anything, and we set up the
# repository by ourselves.
GIT_STRATEGY: "none"
script:
- git clone --filter=tree:0 "$CI_REPOSITORY_URL" gitlab
before_script:
- git clone --filter=tree:0 "${CI_REPOSITORY_URL}" gitlab
# We should checkout before moving/changing files
- cd gitlab
- git checkout -b "${AS_IF_JH_BRANCH}" "${CI_COMMIT_SHA}"
- cd ..
- mv $JH_FILES_TO_COMMIT gitlab/
- mv ${JH_FILES_TO_COMMIT} gitlab/
script:
- cd gitlab
- git add ${JH_FILES_TO_COMMIT}
- git commit -m 'Add JH files' # TODO: Mark which SHA we add
- git push -f "${SANDBOX_REPOSITORY}" "${AS_IF_JH_BRANCH}"
start-as-if-jh:
sync-as-if-jh-branch:
extends:
- .shared-as-if-jh
- .as-if-jh:rules:start-as-if-jh
- .as-if-jh-sandbox-variables
- .as-if-jh:rules:sync-as-if-jh
stage: prepare
needs: ["prepare-as-if-jh-branch"]
inherit:
variables:
# From .gitlab-ci.yml for the default Docker image and cache
- DEFAULT_CI_IMAGE
- REGISTRY_HOST
- REGISTRY_GROUP
- DEBIAN_VERSION
- RUBY_VERSION
- GO_VERSION
- RUST_VERSION
- PG_VERSION
- RUBYGEMS_VERSION
- CHROME_VERSION
- NODE_ENV
variables:
MERGE_FROM: "${CI_COMMIT_SHA}" # This is used in https://jihulab.com/gitlab-cn/gitlab/-/blob/e98bcb37aea4cfe1e78e1daef1b58b5f732cf289/jh/bin/build_packagejson where we run in https://gitlab.com/gitlab-org-sandbox/gitlab-jh-validation
trigger:
# What this runs can be found at:
# https://gitlab.com/gitlab-org-sandbox/gitlab-jh-validation/-/blob/as-if-jh-code-sync/jh/.gitlab-ci.yml
project: gitlab-org-sandbox/gitlab-jh-validation
branch: as-if-jh-code-sync
strategy: depend
start-as-if-jh:
extends:
- .as-if-jh:rules:start-as-if-jh
stage: prepare
needs:
- job: "prepare-as-if-jh-branch"
- job: "sync-as-if-jh-branch"
optional: true
inherit:
variables: false
variables:
AS_IF_EDITION: "jh"
FORCE_GITLAB_CI: "true" # TODO: Trigger a merge request pipeline
trigger:
project: gitlab-org-sandbox/gitlab-jh-validation # ${SANDBOX_PROJECT} does not work here
branch: as-if-jh/${CI_COMMIT_REF_NAME} # ${AS_IF_JH_BRANCH} does not work here
project: gitlab-org-sandbox/gitlab-jh-validation
branch: as-if-jh/${CI_COMMIT_REF_NAME}
strategy: depend

4
.gitlab/ci/dev-fixtures.gitlab-ci.yml
View file

@ -15,8 +15,8 @@
# SEED_NESTED_GROUPS: "false" # requires network connection
.run-dev-fixtures-script: &run-dev-fixtures-script
- run_timed_command "scripts/gitaly-test-spawn"
- run_timed_command "bundle exec rake db:seed_fu"
- section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here
- section_start "seeding-db" "Seeding DB"; bundle exec rake db:seed_fu; section_end "seeding-db";
run-dev-fixtures:
extends:

14
.gitlab/ci/frontend.gitlab-ci.yml
View file

@ -138,22 +138,14 @@ retrieve-frontend-fixtures:
# More information in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/74003.
WEBPACK_VENDOR_DLL: "true"
script:
- source scripts/utils.sh
- source scripts/gitlab_component_helpers.sh
- |
if [[ -d "tmp/tests/frontend" ]]; then
# Remove tmp/tests/frontend/ except on the first parallelized job so that depending
# jobs don't download the exact same artifact multiple times.
if [[ -n "${CI_NODE_INDEX}" ]] && [[ "${CI_NODE_INDEX}" -ne 1 ]]; then
echoinfo "INFO: Removing 'tmp/tests/frontend' as we're on node ${CI_NODE_INDEX}.";
rm -rf "tmp/tests/frontend";
fi
if check_fixtures_reuse; then
echoinfo "INFO: Reusing frontend fixtures from 'retrieve-frontend-fixtures'."
exit 0
else
echo "No frontend fixtures directory, generating frontend fixtures."
fi
- run_timed_command "gem install knapsack --no-document"
- run_timed_command "scripts/gitaly-test-spawn"
- section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here
- source ./scripts/rspec_helpers.sh
- rspec_paralellized_job
artifacts:

36
.gitlab/ci/global.gitlab-ci.yml
View file

@ -219,8 +219,9 @@
.use-pg12:
services:
- name: postgres:12
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-12-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
variables:
POSTGRES_HOST_AUTH_METHOD: trust
@ -228,8 +229,9 @@
.use-pg13:
services:
- name: postgres:13
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.2-alpine
variables:
POSTGRES_HOST_AUTH_METHOD: trust
@ -237,8 +239,9 @@
.use-pg14:
services:
- name: postgres:14
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.2-alpine
variables:
POSTGRES_HOST_AUTH_METHOD: trust
@ -246,8 +249,9 @@
.use-pg12-es7-ee:
services:
- name: postgres:12
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-12-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
@ -261,8 +265,9 @@
.use-pg13-es7-ee:
services:
- name: postgres:13
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.2-alpine
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
@ -276,8 +281,9 @@
.use-pg14-es7-ee:
services:
- name: postgres:14
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.2-alpine
- name: elasticsearch:7.17.6
command: ["elasticsearch", "-E", "discovery.type=single-node", "-E", "xpack.security.enabled=false"]
@ -291,8 +297,9 @@
.use-pg13-es8-ee:
services:
- name: postgres:13
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: elasticsearch:8.6.2
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.0
@ -307,8 +314,9 @@
.use-pg14-es8-ee:
services:
- name: postgres:14
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: elasticsearch:8.6.2
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.0
@ -323,8 +331,9 @@
.use-pg13-opensearch1-ee:
services:
- name: postgres:13
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:1.3.5
alias: elasticsearch
@ -339,8 +348,9 @@
.use-pg13-opensearch2-ee:
services:
- name: postgres:13
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-13-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:2.2.1
alias: elasticsearch
@ -355,8 +365,9 @@
.use-pg14-opensearch1-ee:
services:
- name: postgres:14
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:1.3.5
alias: elasticsearch
@ -371,8 +382,9 @@
.use-pg14-opensearch2-ee:
services:
- name: postgres:14
- name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:postgres-14-pgvector-0.4.1
command: ["postgres", "-c", "fsync=off", "-c", "synchronous_commit=off", "-c", "full_page_writes=off"]
alias: postgres
- name: redis:6.0-alpine
- name: opensearchproject/opensearch:2.2.1
alias: elasticsearch

87
.gitlab/ci/package-and-test-nightly/main.gitlab-ci.yml Normal file
View file

@ -0,0 +1,87 @@
include:
- local: .gitlab/ci/qa-common/main.gitlab-ci.yml
- local: .gitlab/ci/qa-common/rules.gitlab-ci.yml
- local: .gitlab/ci/qa-common/variables.gitlab-ci.yml
workflow:
rules:
- if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH && $CI_PIPELINE_SOURCE == "schedule" && $SCHEDULE_TYPE == "nightly"'
.ce:
variables:
RELEASE: ${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ce:${CI_COMMIT_SHA}
.ee:
variables:
RELEASE: ${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ee:${CI_COMMIT_SHA}
# ==========================================
# Prepare stage
# ==========================================
# TODO: enable once ee jobs are added
# trigger-omnibus-env:
# extends:
# - .trigger-omnibus-env
trigger-omnibus-env-ce:
extends:
- .trigger-omnibus-env-ce
variables:
FOSS_ONLY: "1" # set FOSS_ONLY because we don't pass it via trigger job
# TODO: enable once ee jobs are added
# trigger-omnibus:
# extends:
# - .trigger-omnibus
# needs:
# - trigger-omnibus-env
trigger-omnibus-ce:
extends:
- .trigger-omnibus-ce
needs:
- trigger-omnibus-env-ce
# TODO: enable when first parallel job is added
# download-knapsack-report:
# extends:
# - .download-knapsack-report
# - .rules:download-knapsack
# ==========================================
# Test stage
# ==========================================
update-ee-to-ce:
extends:
- .qa
- .update-script
- .ce
variables:
UPDATE_TYPE: minor
UPDATE_FROM_EDITION: ee
QA_RSPEC_TAGS: --tag smoke
# ==========================================
# Post test stage
# ==========================================
e2e-test-report:
extends:
- .e2e-test-report
# TODO: enable when first parallel job is added
# upload-knapsack-report:
# extends:
# - .upload-knapsack-report
# - .rules:report:process-results
export-test-metrics:
extends:
- .export-test-metrics
relate-test-failures:
extends:
- .relate-test-failures
notify-slack:
extends:
- .notify-slack

242
.gitlab/ci/package-and-test/main.gitlab-ci.yml
View file

@ -1,72 +1,9 @@
# E2E tests pipeline loaded dynamically by script: scripts/generate-e2e-pipeline
# For adding new tests, refer to: doc/development/testing_guide/end_to_end/package_and_test_pipeline.md
default:
interruptible: true
workflow:
name: $PIPELINE_NAME
include:
- local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml
- local: .gitlab/ci/package-and-test/variables.gitlab-ci.yml
- project: gitlab-org/quality/pipeline-common
ref: 3.1.2
file:
- /ci/base.gitlab-ci.yml
- /ci/allure-report.yml
- /ci/knapsack-report.yml
stages:
- test
- report
- notify
# ==========================================
# Templates
# ==========================================
.parallel:
parallel: 5
variables:
QA_KNAPSACK_REPORT_PATH: $CI_PROJECT_DIR/qa/knapsack
.ruby-image:
# Because this pipeline template can be included directly in other projects,
# image path and registry needs to be defined explicitly
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3
.qa-install:
variables:
BUNDLE_SUPPRESS_INSTALL_USING_MESSAGES: "true"
BUNDLE_SILENCE_ROOT_WARNING: "true"
extends:
- .gitlab-qa-install
.update-script:
script:
- !reference [.bundle-prefix]
- export QA_COMMAND="$BUNDLE_PREFIX gitlab-qa Test::Omnibus::UpdateFromPrevious $RELEASE $GITLAB_SEMVER_VERSION $UPDATE_TYPE -- $QA_RSPEC_TAGS $RSPEC_REPORT_OPTS"
- echo "Running - '$QA_COMMAND'"
- eval "$QA_COMMAND"
.qa:
extends:
- .qa-base
- .qa-install
- .gitlab-qa-report
stage: test
tags:
- e2e
variables:
QA_GENERATE_ALLURE_REPORT: "true"
QA_CAN_TEST_PRAEFECT: "false"
QA_INTERCEPT_REQUESTS: "true"
GITLAB_LICENSE_MODE: test
GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN
GITLAB_QA_OPTS: $EXTRA_GITLAB_QA_OPTS
# todo: remove in 16.1 milestone when not needed for backwards compatibility anymore
EE_LICENSE: $QA_EE_LICENSE
GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN
- local: .gitlab/ci/qa-common/main.gitlab-ci.yml
- local: .gitlab/ci/qa-common/rules.gitlab-ci.yml
- local: .gitlab/ci/qa-common/variables.gitlab-ci.yml
# ==========================================
# Prepare stage
@ -83,124 +20,34 @@ check-release-set:
echo "Omnibus installation image is set to '$RELEASE'"
fi
dont-interrupt-me:
extends: .rules:dont-interrupt
stage: .pre
interruptible: false
script:
- echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible."
trigger-omnibus-env:
extends:
- .trigger-omnibus-env
- .rules:omnibus-build
stage: .pre
needs:
# We need this job because we need its `cached-assets-hash.txt` artifact, so that we can pass the assets image tag to the downstream omnibus-gitlab pipeline.
- pipeline: $PARENT_PIPELINE_ID
job: build-assets-image
variables:
BUILD_ENV: build.env
before_script:
- |
# This is duplicating the function from `scripts/utils.sh` since `.gitlab/ci/package-and-test/main.gitlab-ci.yml` can be included in other projects.
function assets_image_tag() {
local cache_assets_hash_file="cached-assets-hash.txt"
if [[ -n "${CI_COMMIT_TAG}" ]]; then
echo -n "${CI_COMMIT_REF_NAME}"
elif [[ -f "${cache_assets_hash_file}" ]]; then
echo -n "assets-hash-$(cat ${cache_assets_hash_file} | cut -c1-10)"
else
echo -n "${CI_COMMIT_SHA}"
fi
}
script:
- |
SECURITY_SOURCES=$([[ ! "$CI_PROJECT_NAMESPACE" =~ ^gitlab-org\/security ]] || echo "true")
echo "SECURITY_SOURCES=${SECURITY_SOURCES:-false}" > $BUILD_ENV
echo "OMNIBUS_GITLAB_CACHE_UPDATE=${OMNIBUS_GITLAB_CACHE_UPDATE:-false}" >> $BUILD_ENV
for version_file in *_VERSION; do echo "$version_file=$(cat $version_file)" >> $BUILD_ENV; done
echo "OMNIBUS_GITLAB_RUBY3_BUILD=${OMNIBUS_GITLAB_RUBY3_BUILD:-false}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_RUBY2_BUILD=${OMNIBUS_GITLAB_RUBY2_BUILD:-false}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_CACHE_EDITION=${OMNIBUS_GITLAB_CACHE_EDITION:-GITLAB}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_BUILD_ON_ALL_OS=${OMNIBUS_GITLAB_BUILD_ON_ALL_OS:-false}" >> $BUILD_ENV
echo "GITLAB_ASSETS_TAG=$(assets_image_tag)" >> $BUILD_ENV
echo "EE=$([[ $FOSS_ONLY == '1' ]] && echo 'false' || echo 'true')" >> $BUILD_ENV
target_branch_name="${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_COMMIT_REF_NAME}}"
echo "TRIGGER_BRANCH=$([[ "${target_branch_name}" =~ ^[0-9-]+-stable(-ee)?$ ]] && echo ${target_branch_name%-ee} || echo 'master')" >> $BUILD_ENV
echo "Built environment file for omnibus build:"
cat $BUILD_ENV
artifacts:
reports:
dotenv: $BUILD_ENV
trigger-omnibus-env-ce:
extends:
- trigger-omnibus-env
- .trigger-omnibus-env-ce
- .rules:omnibus-build-ce
needs:
- pipeline: $PARENT_PIPELINE_ID
job: build-assets-image as-if-foss
trigger-omnibus:
extends: .rules:omnibus-build
stage: .pre
extends:
- .trigger-omnibus
- .rules:omnibus-build
needs:
- trigger-omnibus-env
inherit:
variables: false
variables:
GITALY_SERVER_VERSION: $GITALY_SERVER_VERSION
GITLAB_ELASTICSEARCH_INDEXER_VERSION: $GITLAB_ELASTICSEARCH_INDEXER_VERSION
GITLAB_KAS_VERSION: $GITLAB_KAS_VERSION
GITLAB_METRICS_EXPORTER_VERSION: $GITLAB_METRICS_EXPORTER_VERSION
GITLAB_PAGES_VERSION: $GITLAB_PAGES_VERSION
GITLAB_SHELL_VERSION: $GITLAB_SHELL_VERSION
GITLAB_WORKHORSE_VERSION: $GITLAB_WORKHORSE_VERSION
GITLAB_VERSION: $CI_COMMIT_SHA
GITLAB_ASSETS_TAG: $GITLAB_ASSETS_TAG
IMAGE_TAG: $CI_COMMIT_SHA
TOP_UPSTREAM_SOURCE_PROJECT: $CI_PROJECT_PATH
SECURITY_SOURCES: $SECURITY_SOURCES
CACHE_UPDATE: $OMNIBUS_GITLAB_CACHE_UPDATE
RUBY3_BUILD: $OMNIBUS_GITLAB_RUBY3_BUILD
RUBY2_BUILD: $OMNIBUS_GITLAB_RUBY2_BUILD
CACHE_EDITION: $OMNIBUS_GITLAB_CACHE_EDITION
BUILD_ON_ALL_OS: $OMNIBUS_GITLAB_BUILD_ON_ALL_OS
SKIP_QA_TEST: "true"
ee: $EE
trigger:
project: gitlab-org/build/omnibus-gitlab-mirror
branch: $TRIGGER_BRANCH
strategy: depend
trigger-omnibus-ce:
extends:
- trigger-omnibus
- .trigger-omnibus-ce
- .rules:omnibus-build-ce
variables:
# Override gitlab repository so that omnibus doesn't use foss repository for CE build
GITLAB_ALTERNATIVE_REPO: $CI_PROJECT_URL
needs:
- trigger-omnibus-env-ce
download-knapsack-report:
extends:
- .gitlab-qa-image
- .download-knapsack-report
- .rules:download-knapsack
stage: .pre
variables:
KNAPSACK_DIR: ${CI_PROJECT_DIR}/qa/knapsack
GIT_STRATEGY: none
script:
# when using qa-image, code runs in /home/gitlab/qa folder
- bundle exec rake "knapsack:download[test]"
- mkdir -p "$KNAPSACK_DIR" && cp knapsack/*.json "${KNAPSACK_DIR}/"
allow_failure: true
artifacts:
paths:
- qa/knapsack/*.json
expire_in: 1 day
cache-gems:
extends:
@ -649,87 +496,30 @@ importers:
# ==========================================
e2e-test-report:
extends:
- .generate-allure-report-base
- .e2e-test-report
- .rules:report:allure-report
stage: report
variables:
GITLAB_AUTH_TOKEN: $PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE
ALLURE_PROJECT_PATH: $CI_PROJECT_PATH
ALLURE_MERGE_REQUEST_IID: $CI_MERGE_REQUEST_IID
upload-knapsack-report:
extends:
- .generate-knapsack-report-base
- .qa-install
- .ruby-image
- .upload-knapsack-report
- .rules:report:process-results
stage: report
when: always
export-test-metrics:
extends:
- .qa-install
- .ruby-image
- .export-test-metrics
- .rules:report:process-results
stage: report
when: always
script:
- bundle exec rake "ci:export_test_metrics[$CI_PROJECT_DIR/gitlab-qa-run-*/**/test-metrics-*.json]"
relate-test-failures:
extends:
- .qa-install
- .ruby-image
- .relate-test-failures
- .rules:report:process-results
stage: report
variables:
QA_FAILURES_REPORTING_PROJECT: gitlab-org/gitlab
QA_FAILURES_MAX_DIFF_RATIO: "0.15"
GITLAB_QA_ACCESS_TOKEN: $QA_GITLAB_CI_TOKEN
when: on_failure
script:
- |
bundle exec gitlab-qa-report \
--relate-failure-issue "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.json" \
--project "$QA_FAILURES_REPORTING_PROJECT" \
--max-diff-ratio "$QA_FAILURES_MAX_DIFF_RATIO"
generate-test-session:
extends:
- .qa-install
- .ruby-image
- .generate-test-session
- .rules:report:process-results
stage: report
variables:
QA_TESTCASE_SESSIONS_PROJECT: gitlab-org/quality/testcase-sessions
GITLAB_QA_ACCESS_TOKEN: $QA_TEST_SESSION_TOKEN
GITLAB_CI_API_TOKEN: $QA_GITLAB_CI_TOKEN
when: always
script:
- |
bundle exec gitlab-qa-report \
--generate-test-session "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.json" \
--project "$QA_TESTCASE_SESSIONS_PROJECT"
artifacts:
when: always
expire_in: 1d
paths:
- qa/REPORT_ISSUE_URL
notify-slack:
extends:
- .notify-slack-qa
- .qa-install
- .ruby-image
- .notify-slack
- .rules:report:process-results
stage: notify
variables:
ALLURE_JOB_NAME: e2e-package-and-test
SLACK_ICON_EMOJI: ci_failing
STATUS_SYM: ☠️
STATUS: failed
TYPE: "(package-and-test) "
when: on_failure
script:
- bundle exec gitlab-qa-report --prepare-stage-reports "$CI_PROJECT_DIR/gitlab-qa-run-*/**/rspec-*.xml" # generate summary
- !reference [.notify-slack-qa, script]

7
.gitlab/ci/preflight.gitlab-ci.yml
View file

@ -30,9 +30,12 @@ rails-production-server-boot:
needs: []
script:
- source scripts/utils.sh
- bundle exec rails server -e production &
- cp config/puma.rb.example config/puma.rb
- sed --in-place "s:/home/git/gitlab:${PWD}:" config/puma.rb
- echo 'bind "tcp://127.0.0.1:3000"' >> config/puma.rb
- bundle exec puma --environment production --config config/puma.rb &
- sleep 40 # See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/114124#note_1309506358
- retry_times_sleep 10 5 "curl http://0.0.0.0:3000"
- retry_times_sleep 10 5 "curl http://127.0.0.1:3000"
- kill $(jobs -p)
no-ee-check:

280
.gitlab/ci/qa-common/main.gitlab-ci.yml Normal file
View file

@ -0,0 +1,280 @@
default:
interruptible: true
workflow:
name: $PIPELINE_NAME
include:
- project: gitlab-org/quality/pipeline-common
ref: 5.1.1
file:
- /ci/base.gitlab-ci.yml
- /ci/allure-report.yml
- /ci/knapsack-report.yml
stages:
- test
- report
- notify
# ==========================================
# Templates
# ==========================================
.parallel:
parallel: 5
variables:
QA_KNAPSACK_REPORT_PATH: $CI_PROJECT_DIR/qa/knapsack
.ruby-image:
# Because this pipeline template can be included directly in other projects,
# image path and registry needs to be defined explicitly
image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3
.qa-install:
variables:
BUNDLE_SUPPRESS_INSTALL_USING_MESSAGES: "true"
BUNDLE_SILENCE_ROOT_WARNING: "true"
extends:
- .gitlab-qa-install
.update-script:
script:
- !reference [.bundle-prefix]
- export QA_COMMAND="$BUNDLE_PREFIX gitlab-qa Test::Omnibus::UpdateFromPrevious $RELEASE $GITLAB_SEMVER_VERSION $UPDATE_TYPE $UPDATE_FROM_EDITION -- $QA_RSPEC_TAGS $RSPEC_REPORT_OPTS"
- echo "Running - '$QA_COMMAND'"
- eval "$QA_COMMAND"
.qa:
extends:
- .qa-base
- .qa-install
- .gitlab-qa-report
stage: test
tags:
- e2e
variables:
QA_GENERATE_ALLURE_REPORT: "true"
QA_CAN_TEST_PRAEFECT: "false"
QA_INTERCEPT_REQUESTS: "true"
GITLAB_LICENSE_MODE: test
GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN
GITLAB_QA_OPTS: $EXTRA_GITLAB_QA_OPTS
# todo: remove in 16.1 milestone when not needed for backwards compatibility anymore
EE_LICENSE: $QA_EE_LICENSE
GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN
# Allow QA jobs to fail as they are flaky. The top level `package-and-e2e:ee`
# pipeline is not allowed to fail, so without allowing QA to fail, we will be
# blocking merges due to flaky tests.
allow_failure: true
.trigger-omnibus-env:
stage: .pre
needs:
# We need this job because we need its `cached-assets-hash.txt` artifact, so that we can pass the assets image tag to the downstream omnibus-gitlab pipeline.
- pipeline: $PARENT_PIPELINE_ID
job: build-assets-image
variables:
BUILD_ENV: build.env
before_script:
- |
# This is duplicating the function from `scripts/utils.sh` since `.gitlab/ci/package-and-test/main.gitlab-ci.yml` can be included in other projects.
function assets_image_tag() {
local cache_assets_hash_file="cached-assets-hash.txt"
if [[ -n "${CI_COMMIT_TAG}" ]]; then
echo -n "${CI_COMMIT_REF_NAME}"
elif [[ -f "${cache_assets_hash_file}" ]]; then
echo -n "assets-hash-$(cat ${cache_assets_hash_file} | cut -c1-10)"
else
echo -n "${CI_COMMIT_SHA}"
fi
}
script:
- |
SECURITY_SOURCES=$([[ ! "$CI_PROJECT_NAMESPACE" =~ ^gitlab-org\/security ]] || echo "true")
echo "SECURITY_SOURCES=${SECURITY_SOURCES:-false}" > $BUILD_ENV
echo "OMNIBUS_GITLAB_CACHE_UPDATE=${OMNIBUS_GITLAB_CACHE_UPDATE:-false}" >> $BUILD_ENV
for version_file in *_VERSION; do echo "$version_file=$(cat $version_file)" >> $BUILD_ENV; done
echo "OMNIBUS_GITLAB_RUBY3_BUILD=${OMNIBUS_GITLAB_RUBY3_BUILD:-false}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_RUBY2_BUILD=${OMNIBUS_GITLAB_RUBY2_BUILD:-false}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_CACHE_EDITION=${OMNIBUS_GITLAB_CACHE_EDITION:-GITLAB}" >> $BUILD_ENV
echo "OMNIBUS_GITLAB_BUILD_ON_ALL_OS=${OMNIBUS_GITLAB_BUILD_ON_ALL_OS:-false}" >> $BUILD_ENV
echo "GITLAB_ASSETS_TAG=$(assets_image_tag)" >> $BUILD_ENV
echo "EE=$([[ $FOSS_ONLY == '1' ]] && echo 'false' || echo 'true')" >> $BUILD_ENV
target_branch_name="${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_COMMIT_REF_NAME}}"
echo "TRIGGER_BRANCH=$([[ "${target_branch_name}" =~ ^[0-9-]+-stable(-ee)?$ ]] && echo ${target_branch_name%-ee} || echo 'master')" >> $BUILD_ENV
- |
echo "Built environment file for omnibus build:"
cat $BUILD_ENV
artifacts:
expire_in: 3 days
reports:
dotenv: $BUILD_ENV
paths:
- $BUILD_ENV
.trigger-omnibus-env-ce:
extends: .trigger-omnibus-env
needs:
- pipeline: $PARENT_PIPELINE_ID
job: build-assets-image as-if-foss
.trigger-omnibus:
stage: .pre
inherit:
variables: false
variables:
GITALY_SERVER_VERSION: $GITALY_SERVER_VERSION
GITLAB_ELASTICSEARCH_INDEXER_VERSION: $GITLAB_ELASTICSEARCH_INDEXER_VERSION
GITLAB_KAS_VERSION: $GITLAB_KAS_VERSION
GITLAB_METRICS_EXPORTER_VERSION: $GITLAB_METRICS_EXPORTER_VERSION
GITLAB_PAGES_VERSION: $GITLAB_PAGES_VERSION
GITLAB_SHELL_VERSION: $GITLAB_SHELL_VERSION
GITLAB_WORKHORSE_VERSION: $GITLAB_WORKHORSE_VERSION
GITLAB_VERSION: $CI_COMMIT_SHA
GITLAB_ASSETS_TAG: $GITLAB_ASSETS_TAG
IMAGE_TAG: $CI_COMMIT_SHA
TOP_UPSTREAM_SOURCE_PROJECT: $CI_PROJECT_PATH
SECURITY_SOURCES: $SECURITY_SOURCES
CACHE_UPDATE: $OMNIBUS_GITLAB_CACHE_UPDATE
RUBY3_BUILD: $OMNIBUS_GITLAB_RUBY3_BUILD
RUBY2_BUILD: $OMNIBUS_GITLAB_RUBY2_BUILD
CACHE_EDITION: $OMNIBUS_GITLAB_CACHE_EDITION
BUILD_ON_ALL_OS: $OMNIBUS_GITLAB_BUILD_ON_ALL_OS
SKIP_QA_TEST: "true"
ee: $EE
trigger:
project: gitlab-org/build/omnibus-gitlab-mirror
branch: $TRIGGER_BRANCH
strategy: depend
.trigger-omnibus-ce:
extends:
- .trigger-omnibus
variables:
# Override gitlab repository so that omnibus doesn't use foss repository for CE build
GITLAB_ALTERNATIVE_REPO: $CI_PROJECT_URL
.download-knapsack-report:
extends:
- .gitlab-qa-image
stage: .pre
variables:
KNAPSACK_DIR: ${CI_PROJECT_DIR}/qa/knapsack
GIT_STRATEGY: none
script:
# when using qa-image, code runs in /home/gitlab/qa folder
- bundle exec rake "knapsack:download[test]"
- mkdir -p "$KNAPSACK_DIR" && cp knapsack/*.json "${KNAPSACK_DIR}/"
allow_failure: true
artifacts:
paths:
- qa/knapsack/*.json
expire_in: 1 day
.e2e-test-report:
extends:
- .generate-allure-report-base
stage: report
variables:
GITLAB_AUTH_TOKEN: $PROJECT_TOKEN_FOR_CI_SCRIPTS_API_USAGE
ALLURE_PROJECT_PATH: $CI_PROJECT_PATH
ALLURE_MERGE_REQUEST_IID: $CI_MERGE_REQUEST_IID
.upload-knapsack-report:
extends:
- .generate-knapsack-report-base
- .qa-install
- .ruby-image
stage: report
when: always
.export-test-metrics:
extends:
- .qa-install
- .ruby-image
stage: report
when: always
variables:
QA_METRICS_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/gitlab-qa-run-*/**/test-metrics-*.json
script:
- bundle exec rake "ci:export_test_metrics[$QA_METRICS_REPORT_FILE_PATTERN]"
.relate-test-failures:
extends:
- .qa-install
- .ruby-image
stage: report
when: always
variables:
QA_RSPEC_JSON_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.json"
script:
- |
if [ "$SUITE_FAILED" != "true" ] && [ "$SUITE_RAN" == "true" ]; then
echo "Test suite passed. Exiting..."
exit 0
fi
- |
bundle exec relate-failure-issue \
--input-files "${QA_RSPEC_JSON_FILE_PATTERN}" \
--project "gitlab-org/gitlab" \
--token "${QA_RELATE_FAILURE_ISSUE_TOKEN}"
.generate-test-session:
extends:
- .qa-install
- .ruby-image
stage: report
when: always
variables:
QA_RSPEC_JSON_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.json"
script:
- |
bundle exec generate-test-session \
--input-files "${QA_RSPEC_JSON_FILE_PATTERN}" \
--project "gitlab-org/quality/testcase-sessions" \
--token "${QA_TEST_SESSION_TOKEN}" \
--ci-project-token "${GENERATE_TEST_SESSION_READ_API_REPORTER_TOKEN}" \
--issue-url-file report_issue_url.txt
artifacts:
when: always
expire_in: 1d
paths:
- qa/report_issue_url.txt
.notify-slack:
extends:
- .notify-slack-qa
- .qa-install
- .ruby-image
stage: notify
variables:
QA_RSPEC_XML_FILE_PATTERN: "${CI_PROJECT_DIR}/gitlab-qa-run-*/**/rspec-*.xml"
SLACK_ICON_EMOJI: ci_failing
STATUS_SYM: ☠️
STATUS: failed
TYPE: "($QA_RUN_TYPE) "
when: always
script:
- |
if [ "$SUITE_FAILED" != "true" ] && [ "$SUITE_RAN" == "true" ]; then
echo "Test suite passed. Exiting..."
exit 0
fi
- bundle exec prepare-stage-reports --input-files "${QA_RSPEC_XML_FILE_PATTERN}"
- !reference [.notify-slack-qa, script]
# ==========================================
# Pre stage
# ==========================================
dont-interrupt-me:
stage: .pre
interruptible: false
script:
- echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible."
rules:
- if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null'
allow_failure: true
- if: '$CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached"'
when: manual
allow_failure: true

13
.gitlab/ci/package-and-test/rules.gitlab-ci.yml → .gitlab/ci/qa-common/rules.gitlab-ci.yml
View file

@ -48,14 +48,6 @@
rules:
- when: always
.rules:dont-interrupt:
rules:
- if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $CI_MERGE_REQUEST_IID == null'
allow_failure: true
- if: '$CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached"'
when: manual
allow_failure: true
.rules:omnibus-build:
rules:
- if: $SKIP_OMNIBUS_TRIGGER == "true"
@ -132,6 +124,11 @@
# these jobs need gitlab version because we can't reliably detect it from just the image
- if: $GITLAB_SEMVER_VERSION !~ /^\d+\.\d+\.\d+/
when: never
# update type tests are used to check if gitlab upgrade can be performed correctly (mainly migrations)
# there isn't much benefit in running tests after update with new sidebar enabled and there
# is also an issue to properly pass feature toggle to this job due to how gitlab-qa parses cli args
- if: $QA_SUPER_SIDEBAR_ENABLED == "true"
when: never
- !reference [.rules:test:ee-only, rules]
- !reference [.rules:test:qa, rules]

0
.gitlab/ci/package-and-test/variables.gitlab-ci.yml → .gitlab/ci/qa-common/variables.gitlab-ci.yml
View file

93
.gitlab/ci/qa.gitlab-ci.yml
View file

@ -12,6 +12,40 @@
- !reference [.default-before_script, before_script]
- cd qa && bundle install
.e2e-trigger-base:
extends: .production # this makes sure GITLAB_ALLOW_SEPARATE_CI_DATABASE is passed to the child pipeline
stage: qa
needs:
- build-assets-image
- build-qa-image
- e2e-test-pipeline-generate
variables:
# This is needed by `trigger-omnibus-env` (`.gitlab/ci/package-and-test/main.gitlab-ci.yml`).
PARENT_PIPELINE_ID: $CI_PIPELINE_ID
SKIP_MESSAGE: Skipping package-and-test due to mr containing only quarantine changes!
GITLAB_QA_IMAGE: "${CI_REGISTRY_IMAGE}/gitlab-ee-qa:${CI_COMMIT_SHA}"
RUN_WITH_BUNDLE: "true" # instructs pipeline to install and run gitlab-qa gem via bundler
QA_PATH: qa # sets the optional path for bundler to run from
DYNAMIC_PIPELINE_YML: package-and-test-pipeline.yml # yml files are generated by scripts/generate-e2e-pipeline script
inherit:
variables:
- CHROME_VERSION
- RUBY_VERSION
- DOCKER_VERSION
- REGISTRY_GROUP
- REGISTRY_HOST
- OMNIBUS_GITLAB_CACHE_EDITION
- OMNIBUS_GITLAB_RUBY3_BUILD
- OMNIBUS_GITLAB_RUBY2_BUILD
trigger:
strategy: depend
forward:
yaml_variables: true
pipeline_variables: true
include:
- artifact: $DYNAMIC_PIPELINE_YML
job: e2e-test-pipeline-generate
qa:internal:
extends:
- .qa-job-base
@ -54,42 +88,17 @@ qa:update-qa-cache:
e2e:package-and-test-ee:
extends:
- .production # this makes sure GITLAB_ALLOW_SEPARATE_CI_DATABASE is passed to the child pipeline
- .e2e-trigger-base
- .qa:rules:package-and-test-ee
stage: qa
needs:
- build-assets-image
- build-qa-image
- e2e-test-pipeline-generate
variables:
# This is needed by `trigger-omnibus-env` (`.gitlab/ci/package-and-test/main.gitlab-ci.yml`).
PARENT_PIPELINE_ID: $CI_PIPELINE_ID
SKIP_MESSAGE: Skipping package-and-test due to mr containing only quarantine changes!
RELEASE: "${REGISTRY_HOST}/${REGISTRY_GROUP}/build/omnibus-gitlab-mirror/gitlab-ee:${CI_COMMIT_SHA}"
GITLAB_QA_IMAGE: "${CI_REGISTRY_IMAGE}/gitlab-ee-qa:${CI_COMMIT_SHA}"
RUN_WITH_BUNDLE: "true" # instructs pipeline to install and run gitlab-qa gem via bundler
QA_PATH: qa # sets the optional path for bundler to run from
QA_RUN_TYPE: e2e-package-and-test
ALLURE_JOB_NAME: e2e-package-and-test
PIPELINE_NAME: E2E Omnibus GitLab EE
inherit:
variables:
- CHROME_VERSION
- RUBY_VERSION
- DOCKER_VERSION
- REGISTRY_GROUP
- REGISTRY_HOST
- OMNIBUS_GITLAB_CACHE_EDITION
- OMNIBUS_GITLAB_RUBY3_BUILD
- OMNIBUS_GITLAB_RUBY2_BUILD
trigger:
strategy: depend
forward:
yaml_variables: true
pipeline_variables: true
include:
- artifact: package-and-test-pipeline.yml
job: e2e-test-pipeline-generate
e2e:package-and-test-ce:
extends:
@ -119,8 +128,26 @@ e2e:package-and-test-super-sidebar:
ALLURE_JOB_NAME: e2e-package-and-test-super-sidebar
PIPELINE_NAME: E2E Omnibus Super Sidebar
e2e:package-and-test-nightly:
extends:
- .e2e-trigger-base
- .qa:rules:package-and-test-nightly
needs:
- build-assets-image
- build-assets-image as-if-foss
- build-qa-image
- build-qa-image as-if-foss
- e2e-test-pipeline-generate
variables:
GITLAB_SEMVER_VERSION: $GITLAB_SEMVER_VERSION
QA_RUN_TYPE: nightly
ALLURE_JOB_NAME: nightly
PIPELINE_NAME: E2E Omnibus GitLab Nightly
DYNAMIC_PIPELINE_YML: package-and-test-nightly-pipeline.yml
e2e:test-on-gdk:
extends:
- .e2e-trigger-base
- .qa:rules:e2e:test-on-gdk
stage: qa
needs:
@ -128,10 +155,12 @@ e2e:test-on-gdk:
# In MRs we assume the last scheduled master pipeline built the image already.
- job: build-qa-on-gdk-master-image
optional: true
- job: e2e-test-pipeline-generate
artifacts: true
variables:
ALLURE_JOB_NAME: e2e-test-on-gdk
QA_RUN_TYPE: e2e-test-on-gdk
PIPELINE_NAME: E2E GDK
DYNAMIC_PIPELINE_YML: test-on-gdk-pipeline.yml
SKIP_MESSAGE: Skipping test-on-gdk due to mr containing only quarantine changes!
allow_failure: true
trigger:
strategy: depend
forward:
yaml_variables: true
pipeline_variables: true
include: .gitlab/ci/test-on-gdk/main.gitlab-ci.yml

16
.gitlab/ci/rails.gitlab-ci.yml
View file

@ -15,11 +15,9 @@ setup-test-env:
- echo $CI_MERGE_REQUEST_APPROVED
- source scripts/gitlab_component_helpers.sh
- run_timed_command "download_and_extract_gitlab_workhorse_package" || true
- run_timed_command "scripts/setup-test-env"
- run_timed_command "select_gitlab_workhorse_essentials"
- echo -e "\e[0Ksection_start:`date +%s`:gitaly-test-build[collapsed=true]\r\e[0KCompiling Gitaly binaries"
- run_timed_command "scripts/gitaly-test-build" # Do not use 'bundle exec' here
- echo -e "\e[0Ksection_end:`date +%s`:gitaly-test-build\r\e[0K"
- section_start "setup-test-env" "Setting up testing environment"; scripts/setup-test-env; section_end "setup-test-env";
- select_gitlab_workhorse_essentials
- section_start "gitaly-test-build" "Compiling Gitaly binaries"; scripts/gitaly-test-build; section_end "gitaly-test-build"; # Do not use 'bundle exec' here
artifacts:
expire_in: 7d
paths:
@ -274,6 +272,12 @@ rspec:coverage:
- rspec unit pg13
- rspec integration pg13
- rspec system pg13
# as-if-foss jobs
- rspec migration pg13-as-if-foss
- rspec background_migration pg13-as-if-foss
- rspec unit pg13-as-if-foss
- rspec integration pg13-as-if-foss
- rspec system pg13-as-if-foss
# EE jobs
- rspec-ee migration pg13
- rspec-ee background_migration pg13
@ -342,7 +346,7 @@ rspec:flaky-tests-report:
# so we use `dependencies` here.
dependencies: !reference ["rspec:coverage", "dependencies"]
variables:
SKIPPED_FLAKY_TESTS_REPORT_PATH: rspec/flaky/skipped_flaky_tests_report.txt
SKIPPED_TESTS_REPORT_PATH: rspec/skipped_tests_report.txt
RETRIED_TESTS_REPORT_PATH: rspec/flaky/retried_tests_report.txt
before_script:
- source scripts/utils.sh

2
.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb
View file

@ -39,7 +39,7 @@ dont-interrupt-me:
RSPEC_TESTS_MAPPING_ENABLED: "true"
script:
- !reference [.base-script, script]
- rspec_paralellized_job "--tag ~quarantine --tag ~level:migration --tag ~zoekt"
- rspec_paralellized_job "--tag ~quarantine --tag ~level:background_migration --tag ~zoekt"
artifacts:
expire_in: 7d
paths:

2
.gitlab/ci/rails/shared.gitlab-ci.yml
View file

@ -25,7 +25,7 @@ include:
# gems could not be found under some circumstance. No idea why, hours wasted.
- run_timed_command "gem install knapsack --no-document"
- echo -e "\e[0Ksection_start:`date +%s`:gitaly-test-spawn[collapsed=true]\r\e[0KStarting Gitaly"
- run_timed_command "scripts/gitaly-test-spawn" # Do not use 'bundle exec' here
- section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn" # Do not use 'bundle exec' here
- echo -e "\e[0Ksection_end:`date +%s`:gitaly-test-spawn\r\e[0K"
.single-db:

2
.gitlab/ci/reports.gitlab-ci.yml
View file

@ -31,7 +31,7 @@ code_quality:
variables:
SAST_BRAKEMAN_LEVEL: 2 # GitLab-specific
SAST_EXCLUDED_PATHS: "qa, spec, doc, ee/spec, config/gitlab.yml.example, tmp" # GitLab-specific
SAST_EXCLUDED_ANALYZERS: bandit, flawfinder, phpcs-security-audit, pmd-apex, security-code-scan, spotbugs, eslint, nodejs-scan
SAST_EXCLUDED_ANALYZERS: bandit, flawfinder, phpcs-security-audit, pmd-apex, security-code-scan, spotbugs, eslint, nodejs-scan, sobelow
brakeman-sast:
rules: !reference [".reports:rules:brakeman-sast", rules]

5
.gitlab/ci/review-apps/main.gitlab-ci.yml
View file

@ -90,9 +90,9 @@ review-build-cng:
strategy: depend
.review-workflow-base:
extends:
- .default-retry
image: ${REVIEW_APPS_IMAGE}
retry:
max: 2 # This is confusing but this means "3 runs at max"
variables:
HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}"
DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
@ -126,6 +126,7 @@ review-deploy:
- *base-before_script
- !reference [".use-kube-context", before_script]
script:
- run_timed_command "retry delete_helm_release"
- run_timed_command "check_kube_domain"
- run_timed_command "download_chart"
- run_timed_command "deploy" || (display_deployment_debug && exit 1)

5
.gitlab/ci/review-apps/qa.gitlab-ci.yml
View file

@ -1,6 +1,6 @@
include:
- project: gitlab-org/quality/pipeline-common
ref: 3.1.2
ref: 5.1.1
file:
- /ci/base.gitlab-ci.yml
- /ci/allure-report.yml
@ -40,7 +40,6 @@ include:
WD_INSTALL_DIR: /usr/local/bin
RSPEC_REPORT_OPTS: --force-color --order random --format documentation --format RspecJunitFormatter --out tmp/rspec-${CI_JOB_ID}.xml
script:
- export EE_LICENSE="$(cat $REVIEW_APPS_EE_LICENSE_FILE)"
- QA_COMMAND="bundle exec bin/qa ${QA_SCENARIO} ${QA_GITLAB_URL} -- ${QA_TESTS} ${RSPEC_REPORT_OPTS}"
- echo "Running - '${QA_COMMAND}'"
- eval "$QA_COMMAND"
@ -170,7 +169,7 @@ notify-slack:
TYPE: "(review-app) "
when: on_failure
script:
- bundle exec gitlab-qa-report --prepare-stage-reports "$CI_PROJECT_DIR/qa/tmp/rspec-*.xml" # generate summary
- bundle exec prepare-stage-reports --input-files "${CI_PROJECT_DIR}/qa/tmp/rspec-*.xml"
- !reference [.notify-slack-qa, script]
export-test-metrics:

250
.gitlab/ci/rules.gitlab-ci.yml
View file

@ -41,16 +41,11 @@
# Once https://gitlab.com/gitlab-org/gitlab/-/issues/373904 is implemented, we should be able to change this back to
# if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_APPROVALS_COUNT > 0'
# or any similar condition to check that the MR has *any* approval (not just required approval).
#
# Temprorarily adding || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/ for backward compatibility,
# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out
.if-merge-request-approved: &if-merge-request-approved
if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/ || $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/'
if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS =~ /pipeline:mr-approved/'
# Temprorarily adding && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/ for backward compatibility,
# remove once https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1557 is fully rolled out
.if-merge-request-not-approved: &if-merge-request-not-approved
if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS !~ /pipeline:mr-approved/ && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/'
if: '($CI_MERGE_REQUEST_EVENT_TYPE == "merged_result" || $CI_MERGE_REQUEST_EVENT_TYPE == "detached") && $CI_MERGE_REQUEST_LABELS !~ /pipeline:mr-approved/'
.if-automated-merge-request: &if-automated-merge-request
if: '$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME == "release-tools/update-gitaly" || $CI_MERGE_REQUEST_TARGET_BRANCH_NAME =~ /stable-ee$/'
@ -98,7 +93,7 @@
if: '$CI_MERGE_REQUEST_LABELS =~ /group::global search/'
.if-merge-request-labels-pipeline-expedite: &if-merge-request-labels-pipeline-expedite
if: '($CI_MERGE_REQUEST_LABELS =~ /master:(foss-)?broken/ || $CI_MERGE_REQUEST_TITLE =~ /^[Rr]evert/) && $CI_MERGE_REQUEST_LABELS =~ /pipeline:expedite/'
if: '($CI_MERGE_REQUEST_LABELS =~ /master:(foss-)?broken/ || $CI_MERGE_REQUEST_LABELS =~ /quarantine/) && $CI_MERGE_REQUEST_LABELS =~ /pipeline:expedite/'
.if-merge-request-labels-frontend-and-feature-flag: &if-merge-request-labels-frontend-and-feature-flag
if: '$CI_MERGE_REQUEST_LABELS =~ /frontend/ && $CI_MERGE_REQUEST_LABELS =~ /feature flag/'
@ -619,6 +614,8 @@
.rails:rules:ee-and-foss-default-rules:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *core-backend-patterns
@ -631,6 +628,8 @@
.rails:rules:system-default-rules:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *core-backend-patterns
@ -645,6 +644,8 @@
.rails:rules:previous-failed-tests-default-rules:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-security-merge-request
when: never
- <<: *if-merge-request-labels-run-all-rspec
@ -811,12 +812,27 @@
rules:
- <<: *if-not-canonical-namespace
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-targeting-stable-branch
- <<: *if-merge-request-labels-run-review-app
- <<: *if-dot-com-gitlab-org-and-security-merge-request
- <<: *if-merge-request
changes: *ci-build-images-patterns
- <<: *if-dot-com-gitlab-org-and-security-merge-request
- <<: *if-merge-request
changes: *code-qa-patterns
# Rules to support .qa:rules:package-and-test-ee
- <<: *if-merge-request
changes: *dependency-patterns
- <<: *if-merge-request-labels-run-all-e2e
- <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e
changes: *feature-flag-development-config-patterns
- <<: *if-merge-request
changes: *feature-flag-development-config-patterns
- <<: *if-merge-request
changes: *nodejs-patterns
- <<: *if-merge-request
changes: *ci-qa-patterns
- <<: *if-force-ci
.build-images:rules:build-qa-image:
rules:
@ -835,7 +851,6 @@
- <<: *if-dot-com-gitlab-org-schedule
variables:
ARCH: amd64,arm64
- <<: *if-force-ci
- <<: *if-ruby2-branch
.build-images:rules:build-qa-image-as-if-foss:
@ -859,16 +874,17 @@
rules:
- <<: *if-not-canonical-namespace
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-targeting-stable-branch
- <<: *if-ruby2-branch
- <<: *if-merge-request-labels-run-review-app
- <<: *if-merge-request-labels-run-all-e2e
- <<: *if-auto-deploy-branches
- <<: *if-default-refs
changes: *ci-build-images-patterns
- <<: *if-default-refs
changes: *code-qa-patterns
# Rules to support .qa:rules:package-and-test-mrs
# Rules to support .qa:rules:package-and-test-ee
- <<: *if-merge-request
changes: *dependency-patterns
- <<: *if-merge-request-labels-run-all-e2e
@ -954,6 +970,8 @@
######################
.dev-fixtures:rules:ee-and-foss:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
@ -961,6 +979,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
@ -1006,6 +1026,8 @@
rules:
# The `glfm-verify` job has dependencies on EE, so only run it for EE
- !reference [".strict-ee-only-rules", rules]
- <<: *if-merge-request-labels-pipeline-expedite
when: never
# If any of the files that are DIRECTLY related to generating or managing the GLFM specification change,
# run `glfm-verify` to get quick feedback on any needed updates, even if the MR is not yet approved
- changes: *glfm-patterns
@ -1032,7 +1054,6 @@
##################
# Frontend rules #
##################
.frontend:rules:predictive-default-rules:
rules:
- <<: *if-merge-request-approved
@ -1041,11 +1062,15 @@
when: never
- <<: *if-security-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
.frontend:rules:compile-production-assets:
rules:
- <<: *if-not-canonical-namespace
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-targeting-stable-branch
- <<: *if-merge-request-labels-run-review-app
- <<: *if-merge-request-labels-run-all-e2e
@ -1064,8 +1089,6 @@
when: never
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- !reference [.frontend:rules:compile-production-assets, rules]
.frontend:rules:compile-test-assets:
@ -1092,6 +1115,8 @@
.frontend:rules:default-frontend-jobs:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request-labels-frontend-and-feature-flag
- <<: *if-default-refs
@ -1100,6 +1125,8 @@
.frontend:rules:default-frontend-jobs-as-if-foss:
rules:
- !reference [".strict-ee-only-rules", rules]
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-security-merge-request
changes: *code-backstage-patterns
- <<: *if-merge-request-labels-as-if-foss
@ -1123,6 +1150,8 @@
# The new strategy to upload fixtures as generic packages is experimental and can be disabled by removing the `REUSE_FRONTEND_FIXTURES_ENABLED` variable
- if: '$REUSE_FRONTEND_FIXTURES_ENABLED != "true"'
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-dot-com-gitlab-org-default-branch
changes: *code-backstage-patterns
- <<: *if-foss-default-branch
@ -1136,6 +1165,8 @@
.frontend:rules:jest:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-run-all-jest
@ -1175,6 +1206,8 @@
rules:
- !reference [".strict-ee-only-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-jest
- <<: *if-merge-request
changes: *frontend-dependency-patterns
@ -1205,6 +1238,8 @@
rules:
- !reference [".strict-ee-only-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *frontend-patterns-for-as-if-foss
@ -1223,6 +1258,8 @@
rules:
- <<: *if-not-canonical-namespace
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-branch-refs
changes: *frontend-build-patterns
allow_failure: true
@ -1235,6 +1272,8 @@
################
.memory:rules:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-patterns
@ -1243,6 +1282,8 @@
##########
.notify:rules:create-issues-for-failing-tests:
rules:
- <<: *if-not-canonical-namespace
when: never
# Don't report child pipeline failures
- if: '$CI_PIPELINE_SOURCE == "parent_pipeline"'
when: never
@ -1297,16 +1338,36 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-targeting-stable-branch
allow_failure: true
- <<: *if-dot-com-gitlab-org-and-security-merge-request
- <<: *if-merge-request
changes: *code-backstage-qa-patterns
allow_failure: true
- <<: *if-dot-com-gitlab-org-schedule
allow_failure: true
- <<: *if-ruby2-branch
# Rules to support .qa:rules:package-and-test-ee
- <<: *if-merge-request
changes: *dependency-patterns
allow_failure: true
- <<: *if-merge-request-labels-run-all-e2e
allow_failure: true
- <<: *if-dot-com-gitlab-org-and-security-merge-request-manual-ff-package-and-e2e
changes: *feature-flag-development-config-patterns
allow_failure: true
- <<: *if-merge-request
changes: *feature-flag-development-config-patterns
allow_failure: true
- <<: *if-merge-request
changes: *nodejs-patterns
allow_failure: true
- <<: *if-merge-request
changes: *ci-qa-patterns
allow_failure: true
- <<: *if-force-ci
allow_failure: true
- <<: *if-ruby2-branch
.qa:rules:package-and-test-common:
rules:
@ -1322,7 +1383,6 @@
allow_failure: true
- <<: *if-merge-request
changes: *dependency-patterns
allow_failure: true
variables:
OMNIBUS_GITLAB_BUILD_ON_ALL_OS: 'true'
- <<: *if-merge-request-labels-run-all-e2e
@ -1354,21 +1414,16 @@
- <<: *if-dot-com-gitlab-org-and-security-merge-request-and-qa-tests-specified
changes: *code-patterns
allow_failure: true
.qa:rules:package-and-test-mrs:
rules:
- !reference [".qa:rules:package-and-test-common", rules]
- <<: *if-force-ci
when: manual
allow_failure: true
- <<: *if-merge-request
changes: *code-patterns
when: manual
allow_failure: true
- <<: *if-force-ci
when: manual
allow_failure: true
.qa:rules:package-and-test-ee:
.qa:rules:package-and-test-schedule:
rules:
- !reference [".qa:rules:package-and-test-mrs", rules]
- <<: *if-dot-com-gitlab-org-schedule
allow_failure: true
variables:
@ -1379,6 +1434,11 @@
QA_SAVE_TEST_METRICS: "true"
QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency
.qa:rules:package-and-test-ee:
rules:
- !reference [".qa:rules:package-and-test-common", rules]
- !reference [".qa:rules:package-and-test-schedule", rules]
.qa:rules:package-and-test-ce:
rules:
- <<: *if-not-canonical-namespace
@ -1401,25 +1461,36 @@
- if: '$QA_RUN_TESTS_ON_GDK !~ /true|yes|1/i'
when: never
- !reference [".qa:rules:package-and-test-common", rules]
- <<: *if-merge-request
changes: *code-patterns
allow_failure: true
- <<: *if-force-ci
when: manual
allow_failure: true
- !reference [".qa:rules:package-and-test-schedule", rules]
.qa:rules:package-and-test-sidebar:
rules:
- !reference [".qa:rules:package-and-test-mrs", rules]
- <<: *if-dot-com-gitlab-org-schedule
- <<: *if-not-canonical-namespace
when: never
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *code-patterns
when: manual
allow_failure: true
- <<: *if-default-branch-schedule-nightly
allow_failure: true
variables:
SKIP_REPORT_IN_ISSUES: "true"
PROCESS_TEST_RESULTS: "false"
KNAPSACK_GENERATE_REPORT: "false"
UPDATE_QA_CACHE: "false"
SKIP_REPORT_IN_ISSUES: "false"
PROCESS_TEST_RESULTS: "true"
QA_SAVE_TEST_METRICS: "true"
QA_EXPORT_TEST_METRICS: "false" # on main runs, metrics are exported to separate bucket via rake task for better consistency
QA_EXPORT_TEST_METRICS: "false"
.qa:rules:package-and-test-nightly:
rules:
- <<: *if-default-branch-schedule-nightly
variables:
KNAPSACK_GENERATE_REPORT: "true"
SKIP_REPORT_IN_ISSUES: "false"
QA_SAVE_TEST_METRICS: "true"
QA_EXPORT_TEST_METRICS: "false"
###############
# Rails rules #
@ -1433,6 +1504,8 @@
.rails:rules:single-db:
rules:
- <<: *if-merge-request-labels-run-single-db
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *db-patterns
- <<: *if-merge-request
@ -1442,6 +1515,8 @@
.rails:rules:db:check-migrations-single-db:
rules:
- <<: *if-merge-request-labels-run-single-db
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *db-patterns
- <<: *if-merge-request
@ -1450,6 +1525,8 @@
.rails:rules:single-db-ci-connection:
rules:
- <<: *if-merge-request-labels-run-single-db
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *db-patterns
- <<: *if-merge-request
@ -1459,6 +1536,8 @@
.rails:rules:db:check-migrations-single-db-ci-connection:
rules:
- <<: *if-merge-request-labels-run-single-db
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *db-patterns
- <<: *if-merge-request
@ -1466,6 +1545,8 @@
.rails:rules:db-backup:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-default-refs
changes: *db-backup-patterns
@ -1492,6 +1573,8 @@
rules:
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *core-backend-patterns
@ -1506,6 +1589,10 @@
.rails:rules:rspec-predictive:
rules:
- <<: *if-fork-merge-request
changes: *code-backstage-patterns
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-approved
when: never
- <<: *if-automated-merge-request
@ -1525,6 +1612,8 @@
.rails:rules:ee-and-foss-mr-with-migration:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request
changes: *db-patterns
- <<: *if-merge-request-labels-run-all-rspec
@ -1581,6 +1670,10 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *core-backend-patterns
@ -1637,6 +1730,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *core-backend-patterns
@ -1663,6 +1758,8 @@
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
changes: *backend-patterns
@ -1673,6 +1770,8 @@
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- !reference [".rails:rules:ee-and-foss-default-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
changes: *backend-patterns
@ -1683,12 +1782,16 @@
when: never
- <<: *if-fork-merge-request
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- !reference [".rails:rules:system-default-rules", rules]
- <<: *if-merge-request-labels-as-if-foss
changes: *code-backstage-patterns
.rails:rules:ee-and-foss-db-library-code:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *db-library-patterns
- <<: *if-merge-request-labels-run-all-rspec
@ -1698,6 +1801,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-merge-request-labels-run-all-rspec
- <<: *if-merge-request
changes: *code-backstage-patterns
@ -1726,6 +1831,8 @@
when: never
- <<: *if-merge-request-labels-as-if-foss
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-security-merge-request
changes: *code-backstage-patterns
- <<: *if-dot-com-gitlab-org-merge-request
@ -1755,6 +1862,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-branch-schedule-nightly
- <<: *if-ruby2-branch-schedule-nightly
- <<: *if-merge-request-labels-run-all-rspec
@ -1793,6 +1902,8 @@
.rails:rules:default-branch-schedule-nightly--code-backstage-default-rules:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-branch-schedule-nightly
- <<: *if-merge-request
changes: [".gitlab/ci/rails.gitlab-ci.yml"]
@ -1811,6 +1922,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
@ -1820,7 +1933,7 @@
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$SKIP_FLAKY_TESTS_AUTOMATICALLY != "true" && $RETRY_FAILED_TESTS_IN_NEW_PROCESS != "true"'
- if: '$FAST_QUARANTINE == "false" && $RETRY_FAILED_TESTS_IN_NEW_PROCESS != "true"'
when: never
- <<: *if-merge-request
changes: *code-backstage-patterns
@ -1946,12 +2059,6 @@
changes: ["vendor/gems/omniauth-azure-oauth2/**/*"]
- <<: *if-merge-request-labels-run-all-rspec
.vendor:rules:omniauth-cas3:
rules:
- <<: *if-merge-request
changes: ["vendor/gems/omniauth-cas3/**/*"]
- <<: *if-merge-request-labels-run-all-rspec
.vendor:rules:omniauth_crowd:
rules:
- <<: *if-merge-request
@ -2027,6 +2134,8 @@
#################
.reports:rules:code_quality:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$CODE_QUALITY_DISABLED'
when: never
# Run code_quality on master until https://gitlab.com/gitlab-org/gitlab/-/issues/363747 is resolved
@ -2038,6 +2147,8 @@
.reports:rules:brakeman-sast:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: $SAST_DISABLED
when: never
- if: $SAST_EXCLUDED_ANALYZERS =~ /brakeman/
@ -2049,6 +2160,8 @@
.reports:rules:semgrep-sast:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: $SAST_DISABLED
when: never
- if: $SAST_EXCLUDED_ANALYZERS =~ /semgrep/
@ -2066,6 +2179,8 @@
.reports:rules:secret_detection:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$SECRET_DETECTION_DISABLED'
when: never
# Scan each commit on master to feed the Vulnerability Reports with detected secrets
@ -2075,6 +2190,8 @@
.reports:rules:gemnasium-dependency_scanning:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium([^-]|$)/'
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
@ -2084,6 +2201,8 @@
.reports:rules:gemnasium-python-dependency_scanning:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/'
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
@ -2093,6 +2212,8 @@
.reports:rules:yarn-audit-dependency_scanning:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/'
when: never
# Run Dependency Scanning on master until https://gitlab.com/gitlab-org/gitlab/-/issues/361657 is resolved
@ -2102,6 +2223,8 @@
.reports:rules:test-dast:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- if: '$DAST_DISABLED || $GITLAB_FEATURES !~ /\bdast\b/'
when: never
- <<: *if-merge-request
@ -2283,6 +2406,8 @@
.setup:rules:gitlab_git_test:
rules:
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
@ -2313,6 +2438,8 @@
rules:
- <<: *if-not-ee
when: never
- <<: *if-merge-request-labels-pipeline-expedite
when: never
- <<: *if-default-refs
changes: *code-backstage-patterns
@ -2393,6 +2520,33 @@
- <<: *if-dot-com-gitlab-org-merge-request
changes: *feature-flag-development-config-patterns
# This rule should share the same logic with .as-if-jh:rules:prepare-as-if-jh
# in additionally that there are changes in dependency-patterns
# Unfortunately, we can't say it has changes in
# feature-flag-development-config-patterns
# And in
# dependency-patterns
# At the same time. Note that this can't be using OR so using a union pattern
# doesn't work either. Given that we cannot specify this, there's a gap can
# happen when:
# * The merge request does not have ~"pipeline:run-as-if-jh"
# * The merge request changes a feature flag
# * The merge request also changes dependencies
# In this case, we expect that we do run `sync-as-if-jh-branch` but it won't,
# meaning that dependencies in the JH validation pipeline will be outdated.
# To work around this issue, apply ~"pipeline:run-as-if-jh" to the merge
# request so we can force it to run `sync-as-if-jh-branch` when there are
# dependencies changes.
.as-if-jh:rules:sync-as-if-jh:
rules:
- !reference [".strict-ee-only-rules", rules]
- !reference [".as-if-jh-default-exclusion-rules", rules]
- <<: *if-merge-request-labels-as-if-jh
changes: *dependency-patterns
# Ideally, we should be able to do this:
# - <<: *if-dot-com-gitlab-org-merge-request
# changes: *feature-flag-development-config-patterns && *dependency-patterns
# This rule should share the same logic with .as-if-jh:rules:prepare-as-if-jh
# Because the jobs using this need jobs using the preparation rules
.as-if-jh:rules:start-as-if-jh:

7
.gitlab/ci/setup.gitlab-ci.yml
View file

@ -90,7 +90,7 @@ generate-frontend-fixtures-mapping:
before_script:
- !reference [.default-before_script, before_script]
- source ./scripts/rspec_helpers.sh
- run_timed_command "scripts/gitaly-test-spawn"
- section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here
script:
- generate_frontend_fixtures_mapping
artifacts:
@ -163,8 +163,6 @@ e2e-test-pipeline-generate:
stage: prepare
variables:
ENV_FILE: $CI_PROJECT_DIR/qa_tests_vars.env
OMNIBUS_PIPELINE_YML: package-and-test-pipeline.yml
REVIEW_PIPELINE_YML: review-app-pipeline.yml
COLORIZED_LOGS: "true"
script:
- bundle exec rake "ci:detect_changes[$ENV_FILE]"
@ -172,5 +170,4 @@ e2e-test-pipeline-generate:
artifacts:
expire_in: 1 day
paths:
- $OMNIBUS_PIPELINE_YML
- $REVIEW_PIPELINE_YML
- '*-pipeline.yml'

88
.gitlab/ci/test-on-gdk/main.gitlab-ci.yml
View file

@ -1,15 +1,7 @@
default:
interruptible: true
include:
- local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml
dont-interrupt-me:
extends: .rules:dont-interrupt
stage: test
interruptible: false
script:
- echo "This jobs makes sure this pipeline won't be interrupted! See https://docs.gitlab.com/ee/ci/yaml/#interruptible."
- local: .gitlab/ci/qa-common/main.gitlab-ci.yml
- local: .gitlab/ci/qa-common/rules.gitlab-ci.yml
- local: .gitlab/ci/qa-common/variables.gitlab-ci.yml
.run-tests:
stage: test
@ -21,19 +13,19 @@ dont-interrupt-me:
before_script:
- docker login -u $CI_REGISTRY_USER -p $CI_REGISTRY_PASSWORD $CI_REGISTRY
- sysctl -n -w fs.inotify.max_user_watches=524288
- echo "SUITE_RAN=true" > suite_status.env
variables:
DOCKER_DRIVER: overlay2
DOCKER_HOST: tcp://docker:2375
QA_GDK_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab-qa-gdk:master"
QA_GENERATE_ALLURE_REPORT: "false"
QA_GENERATE_ALLURE_REPORT: "true"
QA_CAN_TEST_PRAEFECT: "false"
QA_INTERCEPT_REQUESTS: "false"
QA_RUN_TYPE: e2e-test-on-gdk
TEST_LICENSE_MODE: $QA_TEST_LICENSE_MODE
EE_LICENSE: $QA_EE_LICENSE
GITHUB_ACCESS_TOKEN: $QA_GITHUB_ACCESS_TOKEN
GITLAB_QA_ADMIN_ACCESS_TOKEN: $QA_ADMIN_ACCESS_TOKEN
QA_KNAPSACK_REPORTS: qa-smoke,ee-instance-parallel
RSPEC_REPORT_OPTS: "--format QA::Support::JsonFormatter --out tmp/rspec-${CI_JOB_ID}.json --format RspecJunitFormatter --out tmp/rspec-${CI_JOB_ID}.xml --format html --out tmp/rspec-${CI_JOB_ID}.htm --color --format documentation"
timeout: 2 hours
artifacts:
when: always
@ -41,6 +33,9 @@ dont-interrupt-me:
- test_output
- logs
expire_in: 7 days
reports:
junit: test_output/**/rspec-*.xml
dotenv: suite_status.env
script:
- echo -e "\e[0Ksection_start:`date +%s`:pull_image\r\e[0KPull GDK QA image"
- docker pull ${QA_GDK_IMAGE}
@ -49,7 +44,7 @@ dont-interrupt-me:
- cd qa && bundle install --jobs=$(nproc) --retry=3 --quiet
- mkdir -p $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs/gdk $CI_PROJECT_DIR/logs/gitlab
# This command matches the permissions of the user that runs GDK inside the container.
- chown -R 1000:1000 $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs
- chown -R 1000:1000 $CI_PROJECT_DIR/test_output $CI_PROJECT_DIR/logs $CI_PROJECT_DIR/qa/knapsack
- |
docker run --rm --name gdk --add-host gdk.test:127.0.0.1 --shm-size=2gb \
--env-file <(bundle exec rake ci:env_var_name_list) \
@ -57,9 +52,20 @@ dont-interrupt-me:
--volume $CI_PROJECT_DIR/test_output:/home/gdk/gdk/gitlab/qa/tmp:z \
--volume $CI_PROJECT_DIR/logs/gdk:/home/gdk/gdk/log \
--volume $CI_PROJECT_DIR/logs/gitlab:/home/gdk/gdk/gitlab/log \
${QA_GDK_IMAGE} "${CI_COMMIT_SHA}" "$TEST_GDK_TAGS --tag ~requires_praefect" || true
- echo -e "\e[0Ksection_end:`date +%s`:launch_gdk_and_tests\r\e[0K"
--volume $CI_PROJECT_DIR/qa/knapsack:/home/gdk/gdk/gitlab/qa/knapsack \
${QA_GDK_IMAGE} "${CI_COMMIT_SHA}" "$RSPEC_REPORT_OPTS $TEST_GDK_TAGS --tag ~requires_praefect"
# The above image's launch script takes two arguments only - first one is the commit sha and the second one Rspec Args
allow_failure: true
after_script:
- |
if [ "$CI_JOB_STATUS" == "failed" ]; then
echo "SUITE_FAILED=true" >> suite_status.env
fi
download-knapsack-report:
extends:
- .download-knapsack-report
- .rules:download-knapsack
test-on-gdk-smoke:
extends:
@ -67,7 +73,6 @@ test-on-gdk-smoke:
parallel: 2
variables:
TEST_GDK_TAGS: "--tag smoke"
QA_KNAPSACK_REPORT_NAME: qa-smoke
rules:
- when: always
@ -75,7 +80,50 @@ test-on-gdk-full:
extends:
- .run-tests
parallel: 5
variables:
QA_KNAPSACK_REPORT_NAME: ee-instance-parallel
rules:
- when: manual
# ==========================================
# Post test stage
# ==========================================
e2e-test-report:
extends:
- .e2e-test-report
- .rules:report:allure-report
variables:
ALLURE_RESULTS_GLOB: test_output/allure-results
upload-knapsack-report:
extends:
- .upload-knapsack-report
- .rules:report:process-results
variables:
QA_KNAPSACK_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/test_output/knapsack/*/*.json
export-test-metrics:
extends:
- .export-test-metrics
- .rules:report:process-results
variables:
QA_METRICS_REPORT_FILE_PATTERN: $CI_PROJECT_DIR/test_output/test-metrics-*.json
relate-test-failures:
extends:
- .relate-test-failures
- .rules:report:process-results
variables:
QA_RSPEC_JSON_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.json
generate-test-session:
extends:
- .generate-test-session
- .rules:report:process-results
variables:
QA_RSPEC_JSON_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.json
notify-slack:
extends:
- .notify-slack
- .rules:report:process-results
variables:
QA_RSPEC_XML_FILE_PATTERN: $CI_PROJECT_DIR/test_output/rspec-*.xml

8
.gitlab/ci/vendored-gems.gitlab-ci.yml
View file

@ -38,14 +38,6 @@ vendor omniauth-azure-oauth2:
include: vendor/gems/omniauth-azure-oauth2/.gitlab-ci.yml
strategy: depend
vendor omniauth-cas3:
extends:
- .vendor:rules:omniauth-cas3
needs: []
trigger:
include: vendor/gems/omniauth-cas3/.gitlab-ci.yml
strategy: depend
vendor omniauth_crowd:
extends:
- .vendor:rules:omniauth_crowd

71
.gitlab/issue_templates/AI Project Proposal.md
View file

@ -1,8 +1,18 @@
<!-- AI Project Proposal title format: 🤖 [AI Proposal] {`Need/outcome` } + {`Beneficiary`} + {`Job/Small Job`}
<!--
HOW TO USE THIS TEMPLATE
To propose an AI experiment, focus on completing the “Experiment” section first. As you refine the idea and gather feedback on your experiment, use the “Feature release” section to define how it will evolve as a Beta or GA capability. It's important that we link experiment to feature release. Feel free to add sections, but keep the existing ones.
The title should be something that is easily understood that quickly communicates the intent of the project allowing team members to easily understand and recognize the expected work that will be done.
You can choose how to get started with this template. For example, the proposal can start as an issue, and then be promoted to an epic to house all the work related to the experiment/prototype and feature release. If you prefer to start with an epic, you have to manually apply the proposal template. Regardless, if the experiment is eventually prioritized for development, the template content will need to appear in a top-level epic so it can be tracked alongside other prioritized AI experiments.
A proposal title should combine the beneficiary of the feature/UI, the job it will allow them to accomplish, and their expected outcome when the work is delivered. Well-defined statements are concise without sacrificing the substance of the proposal so that anyone can understand it at a glance. (e.g.🤖 {Reduce the effort} + {for security teams} + {when prioritizing business-critical risks in their assets}) -->
TITLE FORMAT
🤖 [AI Proposal] {Need/outcome} {Beneficiary} {Job/Small Job}
The title should be something that is easily understood that quickly communicates the intent of the project allowing team members to easily understand and recognize the expected work that will be done. A proposal title should combine the beneficiary of the feature/UI, the job it will allow them to accomplish (see https://about.gitlab.com/handbook/product/ux/jobs-to-be-done/#how-to-write-a-jtbd), and their expected outcome when the work is delivered. Well-defined statements are concise without sacrificing the substance of the proposal so that anyone can understand it at a glance. (e.g. {Reduce the effort} {for security teams} {when prioritizing business-critical risks in their assets}).
-->
# Experiment
This section should be completed prior to work on the Experiment beginning.
# [Experiment](https://docs.gitlab.com/ee/policy/alpha-beta-support.html#experiment)
@ -21,22 +31,26 @@ _What assumptions are you making about this problem and the solution?_
_What [personas](https://about.gitlab.com/handbook/product/personas/#list-of-user-personas) have this problem, who is the intended user?_
## Proposal
<!-- Use this section to explain the proposed changes, including details around usage and business drivers. -->
<!-- Explain the proposed changes, including details around usage and business drivers. -->
### Success
_How will you measure whether this experiment is a success?_
# [General Availability](https://docs.gitlab.com/ee/policy/alpha-beta-support.html#generally-available-ga)
## Main Job story
# Feature release
<!-- DO NOT REMOVE THIS SECTION
Although the initial focus is on the “Experiment” section, do not remove this “Feature release” section. It's important that we link experiment to feature release. Fill this section as you progress.
-->
### Main Job story
_What job to be done will this solve?_
<!-- What is the [Main Job story](https://about.gitlab.com/handbook/product/ux/jobs-to-be-done/#how-to-write-a-jtbd) that this proposal was derived from? (e.g. When I am on triage rotation, I want to address all the business-critical risks in my assets, So I can minimize the likelihood of my organization being compromised by a security breach.) -->
### Proposal updates/additions
<!-- Use this section to explain any changes or updates to the original proposal, including details around usage, business drivers, and reasonings that drove the updates/additions. -->
## Proposal updates/additions
<!-- Explain any changes or updates to the original proposal from the experiment, including details around usage, business drivers, and reasonings that drove the updates/additions. -->
### Problem validation
_What validation exists that customers have this problem?_
<!-- Refer to https://about.gitlab.com/handbook/product/ux/ux-research/research-in-the-AI-space/#guideline-1-problem-validation --- to help identify and understand user needs -->
### Business objective
_What business objective will be achieved with this proposal?_
@ -59,14 +73,11 @@ _What tasks or actions should the user be capable of performing with this featur
#### The user needs to be able to:
- ...
- ...
- ...
## Checklist
### Experiment
<details>
<summary> Issue information </summary>
<details> <summary> Issue information </summary>
- [ ] Add information to the issue body about:
- [ ] The user problem being solved
@ -74,14 +85,16 @@ _What tasks or actions should the user be capable of performing with this featur
- [ ] Who it's for, list of personas impacted
- [ ] Your proposal
- [ ] Add relevant designs to the Design Management area of the issue if available
- [ ] Confirm that an unexpected outage of this feature will not negatively impact the application or other features
- [ ] Add a feature flag so that this feature can be quickly disabled if/when needed
- [ ] If this experiment introduces a new service or data store, ensure it is not processing or storing [red data](https://about.gitlab.com/handbook/security/data-classification-standard.html#data-classification-levels) without a security and if needed legal review
- *NOTE*: We recommend using one of the already adopted models or data stores. If you need to use something else, be aware that using other models or data stores will require additional review during the feature stage for operational fitness and compliance.
- [ ] Ensure this issue has the ~wg-ai-integration label to ensure visibility to various teams working on this
</details>
### General Availability
<details>
<summary>Issue information</summary>
### Feature release
<details> <summary> Issue information </summary>
- [ ] Add information to the issue body about:
- [ ] Your proposal
@ -95,28 +108,26 @@ _What tasks or actions should the user be capable of performing with this featur
</details>
<details>
<summary>Technical needs</summary>
<details> <summary> Technical needs </summary>
- [ ] [Operational Requirements Review - Checklist - #note_1337519985](https://gitlab.com/gitlab-org/gitlab/-/issues/403859#note_1337519985)
- [ ] Please consider the operational aspects of the feature you are creating. A list of things to think about is in: https://gitlab.com/gitlab-org/gitlab/-/issues/403859. We will be improving this process in the future: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117637#note_1353253349.
- [ ] @ mention your [AppSec Stable Counterpart](https://about.gitlab.com/handbook/product/categories/) and read the [AI secure coding guidelines](https://docs.gitlab.com/ee/development/secure_coding_guidelines.html#artificial-intelligence-ai-features)
1. **Work estimate and skills needs to build an ML viable feature:** To build any ML feature depending on the work, there are many personas that contribute including, Data Scientist, NLP engineer, ML Engineer, MLOps Engineer, ML Infra engineers, and Fullstack engineer to integrate the ML Services with Gitlab. Post-prototype we would assess the skills needed to build a production-grade ML feature for the prototype
2. **Data Limitation:** We would like to upfront validate if we have viable data for the feature including whether we can use the DataOps pipeline of ModelOps or create a custom one. We would want to understand the training data, test data, and feedback data to dial up the accuracy and the limitations of the data.
3. **Model Limitation:** We would want to understand if we can use an open-source pre-trained model, tune and customize it or start a model from scratch as well. Further, we would asses based on the ModelOps model evaluation framework which would be the right model to use based on the use case.
4. **Cost, Scalability, Reliability:** We would want to estimate the cost of hosting, serving, inference of the model, and the full end-to-end infrastructure including monitoring and observability.
5. **Legal and Ethical Framework:** We would want to align with legal and ethical framework like any other ModelOps features to cover across the nine principles of responsible ML and any legal support needed.
1. Work estimate and skills needs to build an ML viable feature: To build any ML feature depending on the work, there are many personas that contribute including, Data Scientist, NLP engineer, ML Engineer, MLOps Engineer, ML Infra engineers, and Fullstack engineer to integrate the ML Services with Gitlab. Post-prototype we would assess the skills needed to build a production-grade ML feature for the prototype.
2. Data Limitation: We would like to upfront validate if we have viable data for the feature including whether we can use the DataOps pipeline of ModelOps or create a custom one. We would want to understand the training data, test data, and feedback data to dial up the accuracy and the limitations of the data.
3. Model Limitation: We would want to understand if we can use an open-source pre-trained model, tune and customize it or start a model from scratch as well. Further, we would assess based on the ModelOps model evaluation framework which would be the right model to use based on the use case.
4. Cost, Scalability, Reliability: We would want to estimate the cost of hosting, serving, inference of the model, and the full end-to-end infrastructure including monitoring and observability.
5. Legal and Ethical Framework: We would want to align with legal and ethical framework like any other ModelOps features to cover across the nine principles of responsible ML and any legal support needed.
</details>
<details>
<summary>Dependency needs</summary>
<details> <summary> Dependency needs </summary>
- [ ] [Operational Requirements Review - Checklist - #note_1337519985](https://gitlab.com/gitlab-org/gitlab/-/issues/403859#note_1337519985)
- [ ] Please consider the operational aspects of the service you are creating. A list of things to think about is in: https://gitlab.com/gitlab-org/gitlab/-/issues/403859. We will be improving this process in the future: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117637#note_1353253349.
</details>
<details>
<summary>Legal needs</summary>
<details> <summary> Legal needs </summary>
- [ ] TBD
@ -134,5 +145,3 @@ _What tasks or actions should the user be capable of performing with this featur
/label ~wg-ai-integration
/cc @tmccaslin @hbenson @wayne @pedroms @jmandell
/confidential
[Make change to this template](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/AI%20Project%20Proposal.md)

2
.gitlab/issue_templates/Feature Flag Cleanup.md
View file

@ -48,4 +48,4 @@ Are there any other stages or teams involved that need to be kept in the loop?
- [ ] Close this rollout issue.
/label ~"feature flag" ~"type::feature" ~"feature::addition"
/label ~"feature flag" ~"type::maintenance" ~"maintenance::removal"

3
.gitlab/issue_templates/Geo Replicate a new Git repository type.md
View file

@ -100,7 +100,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
- [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md).
- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/docs):
- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/geo/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/geo/docs):
```yaml
table_name: cool_widget_registry
@ -602,6 +602,7 @@ Metrics are gathered by `Geo::MetricsUpdateWorker`, persisted in `GeoNodeStatus`
| `geo_cool_widgets_verified` | Gauge | XX.Y | Number of Cool Widgets successfully verified on secondary | `url` |
| `geo_cool_widgets_verification_failed` | Gauge | XX.Y | Number of Cool Widgets that failed verification on secondary | `url` |
```
- [ ] Run the rake task `geo:dev:ssf_metrics` and commit the changes to `ee/config/metrics/object_schemas/geo_node_usage.json`
Cool Widget replication and verification metrics should now be available in the API, the `Admin > Geo > Sites` view, and Prometheus.

3
.gitlab/issue_templates/Geo Replicate a new blob type.md
View file

@ -100,7 +100,7 @@ Geo secondary sites have a [Geo tracking database](https://gitlab.com/gitlab-org
- [ ] If deviating from the above example, then be sure to order columns according to [our guidelines](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/ordering_table_columns.md).
- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/docs):
- [ ] Add the new table to the [database dictionary](https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/database/database_dictionary.md) defined in [`ee/db/geo/docs/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/db/geo/docs):
```yaml
table_name: cool_widget_registry
@ -570,6 +570,7 @@ Metrics are gathered by `Geo::MetricsUpdateWorker`, persisted in `GeoNodeStatus`
| `geo_cool_widgets_verified` | Gauge | XX.Y | Number of Cool Widgets successfully verified on secondary | `url` |
| `geo_cool_widgets_verification_failed` | Gauge | XX.Y | Number of Cool Widgets that failed verification on secondary | `url` |
```
- [ ] Run the rake task `geo:dev:ssf_metrics` and commit the changes to `ee/config/metrics/object_schemas/geo_node_usage.json`
Cool Widget replication and verification metrics should now be available in the API, the `Admin > Geo > Sites` view, and Prometheus.

166
.gitlab/issue_templates/Utilization group - bug.md Normal file
View file

@ -0,0 +1,166 @@
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "type::bug" label:
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests?scope=all&label_name[]=group%3A%3Autilization&label_name[]=section%3A%3Afulfillment&label_name%5B%5D=type::regression
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests?scope=all&label_name[]=group%3A%3Autilization&label_name[]=section%3A%3Afulfillment&label_name%5B%5D=type::bug
and verify the issue you're about to submit isn't a duplicate.
--->
Utilization group: Bug Report Template
## Bug Summary
<!-- Provide a brief overview of the issue. What is the problem that needs to be addressed? -->
## Steps to reproduce
<!-- Provide a clear and detailed description of the steps needed to reproduce the bug. This should include any specific inputs, expected outputs, and observed outputs. -->
1. [Step 1]
1. [Step 2]
1. [Step 3]
1. [Step 4]
1. [Step 5]
## Example Project
<!-- If possible, please create an example project here on GitLab.com that exhibits the problematic
behavior, and link to it here in the bug report. If you are using an older version of GitLab, this
will also determine whether the bug is fixed in a more recent version. -->
## What is the current *bug* behavior?
<!-- Describe the current behavior of the system or application in response to the actions described in the steps above. -->
## What is the expected *correct* behavior?
<!-- Describe the expected behavior of the system or application in response to the actions described in the steps above. -->
## Reproducibility
<!-- Describe how frequently the bug occurs. -->
## Impact Assessment
<!-- Describe the impact of this bug on the user experience and/or the product as a whole. -->
## Severity
<!-- Provide an assessment of the severity of the bug, based on its impact on the user experience and/or the product as a whole. -->
## Environment
<!-- List the relevant environment information, including the operating system, web browser, device, etc. -->
## Screenshots and/or Relevant logs
<!-- Include any relevant screenshots to help illustrate the bug. -->
<!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code
as it's tough to read otherwise. -->
## Output of checks (GitLab.com)
<!-- If you are reporting a bug on GitLab.com, uncomment below, if not, delete this section -->
<!-- This bug happens on GitLab.com -->
<!-- /label ~"reproduced on GitLab.com" -->
## Results of GitLab environment info
<!-- Input any relevant GitLab environment information if needed. -->
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
</pre>
</details>
## Results of GitLab application Check
<!-- Input any relevant GitLab application check information if needed. -->
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)
</pre>
</details>
## Possible fixes
<!-- If you can, link to the line of code that might be responsible for the problem. -->
<!-- If you have any suggestions for how to fix the bug, provide them here. -->
<!-- If you are unsure about the subtype of this bug, please check our SSOT https://about.gitlab.com/handbook/engineering/metrics/?_gl=1*920mnx*_ga*ODQ3OTI1Mjk1LjE2NzA0MDg0NjU.*_ga_ENFH3X7M5Y*MTY4MTM3OTA3My4yNzkuMS4xNjgxMzc5MTI0LjAuMC4w#work-type-classification -->
/label ~"type::bug"
/label ~"Category:Consumables Cost Management"
/label ~"group::utilization"
/label ~"section::fulfillment"
---
<details>
<summary>Illustrative Description: (This is not an actual issue, but rather a sample report that demonstrates how a bug could be presented)</summary>
## Bug Summary
When attempting to log in to GitLab using a new account, the system does not recognize the account and returns an error message.
## Steps to Reproduce
1. Navigate to the GitLab login page.
1. Enter the email and password for a new account.
1. Click the "Log In" button.
1. Observe the error message: "The email or password you entered is incorrect. Please try again."
## What is the current *bug* behavior?
The system does not recognize the new account and returns an error message.
## What is the expected *correct* behavior?
The system should recognize the new account and allow the user to log in.
## Reproducibility
This bug occurs consistently when attempting to log in with a new account.
## Impact Assessment
This bug prevents new users from accessing GitLab and may result in frustration and lost productivity.
## Severity
This bug is of medium severity, as it prevents new users from accessing the system, but does not affect the functionality of existing users.
## Environment
- Operating System: macOS Ventura
- Browser: Google Chrome 111.0.5563.146
## Screenshots and/or Relevant logs
[Insert screenshot of the error message.]
## Possible Fix
It is unclear what may be causing this bug. Further investigation is required to identify a possible fix.
</details>

65
.gitlab/issue_templates/Utilization group - feature.md Normal file
View file

@ -0,0 +1,65 @@
Utilization group: Feature Template
## Description
<!-- As a [user or stakeholder], I want [goal or objective] so that [reason or benefit]. -->
## Acceptance Criteria
<!--
- [ ] [Describe what must be achieved to complete this issue.]
- [ ] [Describe another requirement needed to complete this issue.]
- [ ] [Add additional acceptance criteria as needed.]
-->
## Technical Requirements
<!-- [If applicable, please list out any technical requirements for this feature/enhancement.] -->
## Design Requirements
<!-- [If applicable, please provide a link to the design specifications for this feature/enhancement.] -->
## Impact Assessment
<!-- [Please describe the impact this feature/enhancement will have on the user experience and/or the product as a whole.] -->
## User Story
<!-- [Provide a user story to illustrate the use case for this feature/enhancement. Include examples to help communicate the intended functionality.] -->
/label ~"type::feature"
/label ~"Category:Consumables Cost Management"
/label ~"group::utilization"
/label ~"section::fulfillment"
<details>
<summary>Illustrative Description: (This is not an actual issue, but rather a sample report that demonstrates how a feature could be presented) </summary>
## Description
As a developer, I want to be able to easily create and manage merge requests, so that I can collaborate effectively with my team and ensure that code changes are reviewed and merged efficiently.
## Acceptance Criteria
- [ ] The merge request feature should allow developers to create a new merge request from a branch.
- [ ] The merge request feature should allow developers to assign the merge request to another team member for review.
- [ ] The merge request feature should provide a clear and easy-to-use interface for managing merge requests.
- [ ] The merge request feature should integrate with other GitLab features, such as issue tracking and continuous integration.
## Technical Requirements
- The merge request feature should be implemented using GitLab's API.
- The merge request feature should be integrated with GitLab's existing authentication and authorization system.
- The merge request feature should be optimized for performance and scalability.
## Design Requirements
- [Design specifications for this feature can be found here.](insert_design_link_here)
## Impact Assessment
This feature will significantly enhance the collaboration and code review process for developers using GitLab. By providing an intuitive and easy-to-use interface for managing merge requests, developers will be able to work more efficiently and effectively as a team. Additionally, integrating the merge request feature with other GitLab features will further streamline the development process.
## User Story
As a developer working on a new feature branch, I want to be able to create a new merge request and assign it to a team member for review, so that I can ensure that my code changes are thoroughly reviewed before being merged into the main codebase. With the new merge request feature, I can easily create a new merge request, assign it to a team member for review, and track its status throughout the review process. This will help me work more efficiently and effectively as a team, while also maintaining high code quality and reliability.
</details>

69
.gitlab/issue_templates/Utilization group - maintenance.md Normal file
View file

@ -0,0 +1,69 @@
Utilization Group: Maintenance Template
## Description
<!-- Briefly describe the maintenance issue. -->
## Acceptance Criteria
<!--
- [ ] [Describe the completion requirements.]
- [ ] [Add additional acceptance criteria as necessary.]
-->
## Technical Requirements
<!-- [List any technical requirements for this maintenance issue.] -->
## Impact Assessment
<!-- [Describe the impact of this maintenance issue on the user experience and/or the product as a whole.] -->
## Steps to Reproduce
<!-- [Provide detailed steps on how to reproduce the maintenance issue.] -->
## Expected Results
<!-- [Describe the expected outcome when the maintenance issue is resolved.] -->
## Actual Results
<!-- [Describe the current outcome of the maintenance issue.] -->
/label ~type::maintenance
/label ~"Category:Consumables Cost Management"
/label ~"group::utilization"
/label ~"section::fulfillment"
<details>
<summary>Illustrative Description: (This is not an actual maintenance issue, but rather a sample report that demonstrates how a maintenance issue could be presented) </summary>
## Description
The login page is taking longer than expected to load, which is impacting the user experience.
## Acceptance Criteria
- [ ] The login page should load in less than 3 seconds on both desktop and mobile devices.
- [ ] The login page should be tested on different browsers to ensure compatibility.
- [ ] The login page should not display any errors or warnings in the console.
## Technical Requirements
- [ ] The login page should be optimized for performance.
- [ ] The login page should be tested on different browsers.
- [ ] The login page should be updated to use the latest version of the authentication library.
## Impact Assessment
This maintenance issue is impacting the user experience by causing delays in the login process. By resolving this issue, users will be able to log in faster and have a better overall experience.
## Steps to Reproduce
1. Open the login page.
1. Wait for the page to load.
1. Measure the time it takes for the page to fully load.
## Expected Results
The login page should load in less than 3 seconds on both desktop and mobile devices.
## Actual Results
The login page is currently taking more than 5 seconds to load on desktop devices and more than 7 seconds on mobile devices. This is causing frustration and delays for users.
</details>

9
.gitlab/merge_request_templates/Change Documentation Location.md
View file

@ -14,17 +14,14 @@
## Moving docs to a new location?
Read the guidelines:
https://docs.gitlab.com/ee/development/documentation/index.html#move-or-rename-a-page
Read the [redirect guidelines](https://docs.gitlab.com/ee/development/documentation/redirects.html) first.
- [ ] Make sure the old link is not removed and has its contents replaced with
a link to the new location.
- [ ] Make sure internal links pointing to the document in question are not broken.
- [ ] Search and replace any links referring to old docs in GitLab Rails app,
specifically under the `app/views/` and `ee/app/views` (for GitLab EE) directories.
- [ ] Make sure to add [`redirect_from`](https://docs.gitlab.com/ee/development/documentation/index.html#redirections-for-pages-with-disqus-comments)
to the new document if there are any Disqus comments on the old document thread.
- [ ] Update the link in `features.yml` (if applicable).
- [ ] Update the link in [`features.yml`](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/master/data/features.yml) (if applicable).
- [ ] Assign one of the technical writers for review.
/label ~documentation ~"Technical Writing"
/label ~documentation ~"Technical Writing" ~"type::maintenance" ~"maintenance::refactor"

6
.gitlab/merge_request_templates/Default.md
View file

@ -8,6 +8,8 @@ that reviewers can understand your intent. Keeping the description updated is
especially important if they didn't participate in the discussion.
-->
%{first_multiline_commit}
## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._
@ -25,10 +27,6 @@ _Numbered steps to set up and validate the change are strongly suggested._
<!--
Example below:
1. Enable the invite modal
```ruby
Feature.enable(:invite_members_group_modal)
```
1. In rails console enable the experiment fully
```ruby
Feature.enable(:member_areas_of_focus)

2
.gitlab/merge_request_templates/Deprecations.md
View file

@ -106,4 +106,4 @@ If you have trouble running the Rake task, check the [troubleshooting steps](htt
/label ~"release post" ~"release post item" ~"Technical Writing" ~"release post item::deprecation"
/label ~"type::maintenance"
/label ~"maintenance::refactor"
/label ~"maintenance::removal"

3
.gitlab/merge_request_templates/Removals.md
View file

@ -1,7 +1,7 @@
<!-- Set the correct label and milestone using autocomplete for guidance. Please @mention only the DRI(s) for each stage or group rather than an entire department. -->
/label ~"release post" ~"release post item" ~"Technical Writing" ~devops:: ~group:: ~"release post item::removal"
/label ~"type::maintenance"
/label ~"type::maintenance" ~"maintenance::removal"
/milestone %
/assign `@EM/PM` (choose the DRI; remove backticks here, and below)
@ -46,7 +46,6 @@ Please review:
- [ ] Set yourself as the Assignee, meaning you are the DRI.
- [ ] If the removal is a [breaking change](https://about.gitlab.com/handbook/product/gitlab-the-product/#breaking-change), add label `breaking change`.
- [ ] Follow the process to [create a removal YAML file](https://about.gitlab.com/handbook/marketing/blog/release-posts/#creating-a-removal-entry).
- [ ] Make sure that the milestone dates are based on the dates in [Product milestone creation](https://about.gitlab.com/handbook/product/milestones/#product-milestone-creation).
- [ ] Add reviewers by the 10th.
- [ ] When ready to be merged and not later than the 15th, add the ~ready label and @ message the TW for final review and merge.
- Removal notices should not be merged before the code is removed from the product. Do not mark ~ready until the removal is complete, or you are certain it will be completed within the current milestone and released. If PMs are not sure, they should confirm with their Engineering Manager.

9
.gitlab/merge_request_templates/Stable Branch.md
View file

@ -23,14 +23,13 @@ This checklist encourages us to confirm any changes have been analyzed to reduce
#### Note to the merge request author and maintainer
The process of backporting bug fixes into stable branches is tracked as part of an
[internal pilot]. If you have questions about this process, please:
If you have questions about the patch release process, please:
* Refer to the [internal pilot] issue for feedback or questions.
* Refer to the [patch release runbook for engineers and maintainers] for guidance.
* Ask questions on the [`#releases`] Slack channel (internal only).
[severity label]: https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity
[internal pilot]: https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2886
[patch release runbook for engineers and maintainers]: https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/process_new.md
[patch release runbook for engineers and maintainers]: https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md
[`#releases`]: https://gitlab.slack.com/archives/C0XM5UU6B
/assign me

5
.gitlab/secret-detection-ruleset.toml
View file

@ -4,3 +4,8 @@
[secrets.ruleset.identifier]
type = "gitleaks_rule_id"
value = "Password in URL"
[[secrets.passthrough]]
type = "file"
# note this must be gitleaks.toml
target = "gitleaks.toml"
value = "config/gitleaks.toml"

4
.gitpod.yml
View file

@ -51,6 +51,9 @@ tasks:
[[ -f /workspace/gitpod_start_time.sh ]] && source /workspace/gitpod_start_time.sh
SECONDS=0
cd /workspace/gitlab-development-kit
make gitlab-update
make gitlab-shell-update
make gitlab-workhorse-update
# update GDK
if [ "$GITLAB_UPDATE_GDK" == true ]; then
echo "$(date) – Updating GDK" | tee -a /workspace/startup.log
@ -126,3 +129,4 @@ vscode:
- dbaeumer.vscode-eslint@2.2.6
- GitLab.gitlab-workflow@3.56.0
- DavidAnson.vscode-markdownlint@0.47.0
- esbenp.prettier-vscode

1
.markdownlint.yml
View file

@ -52,6 +52,7 @@ proper-names:
"Geo",
"Git LFS",
"git-annex",
"git-credential-oauth",
"git-sizer",
"Git",
"Gitaly",

16
.rubocop.yml
View file

@ -107,6 +107,9 @@ InternalAffairs/DeprecateCopHelper:
Layout/LineLength:
AllowedPatterns: ['^RSpec\.describe\s.*\sdo']
Exclude:
- 'ee/spec/controllers/concerns/routable_actions_spec.rb'
- 'ee/spec/lib/gitlab/auth/group_saml/sso_enforcer_spec.rb'
Lint/LastKeywordArgument:
Safe: false
@ -114,6 +117,7 @@ Lint/LastKeywordArgument:
Lint/EmptyFile:
Exclude:
- 'db/seeds.rb'
- 'ee/db/embedding/seeds.rb'
- 'ee/db/geo/seeds.rb'
# This cop checks whether some constant value isn't a
@ -148,6 +152,8 @@ RSpec/FilePath:
- 'ee/spec/frontend/fixtures/*'
- 'spec/requests/api/v3/*'
- 'spec/fixtures/**/*'
CustomTransform:
HTTPartyBasicAuth: httparty_basic_auth
# Configuration parameters: AllowSubject.
RSpec/MultipleMemoizedHelpers:
@ -521,6 +527,12 @@ RSpec/AvoidTestProf:
- 'ee/spec/lib/gitlab/background_migration/**/*.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/**/*.rb'
RSpec/AvoidConditionalStatements:
Enabled: true
Include:
- 'spec/features/**/*.rb'
- 'ee/spec/features/**/*.rb'
RSpec/FactoriesInMigrationSpecs:
Enabled: true
Include:
@ -991,3 +1003,7 @@ SidekiqLoadBalancing/WorkerDataConsistency:
Include:
- 'app/workers/**/*'
- 'ee/app/workers/**/*'
# This cop is disabled for Ruby 3.0+ anyway.
Lint/NonDeterministicRequireOrder:
Enabled: false

3
.rubocop_todo/capybara/visibility_matcher.yml
View file

@ -17,7 +17,6 @@ Capybara/VisibilityMatcher:
- 'ee/spec/support/helpers/billing_plans_helpers.rb'
- 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb'
- 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb'
- 'ee/spec/views/layouts/_search.html.haml_spec.rb'
- 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb'
- 'spec/features/admin/admin_mode_spec.rb'
- 'spec/features/dashboard/merge_requests_spec.rb'
@ -55,7 +54,6 @@ Capybara/VisibilityMatcher:
- 'spec/features/search/user_searches_for_commits_spec.rb'
- 'spec/features/snippets/notes_on_personal_snippets_spec.rb'
- 'spec/features/task_lists_spec.rb'
- 'spec/features/u2f_spec.rb'
- 'spec/features/uploads/user_uploads_file_to_note_spec.rb'
- 'spec/features/users/email_verification_on_login_spec.rb'
- 'spec/features/users/overview_spec.rb'
@ -69,7 +67,6 @@ Capybara/VisibilityMatcher:
- 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb'
- 'spec/views/import/gitlab_projects/new.html.haml_spec.rb'
- 'spec/views/layouts/_header_search.html.haml_spec.rb'
- 'spec/views/layouts/_search.html.haml_spec.rb'
- 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb'
- 'spec/views/profiles/preferences/show.html.haml_spec.rb'
- 'spec/views/projects/merge_requests/edit.html.haml_spec.rb'

6
.rubocop_todo/cop/redirect_with_status.yml
View file

@ -1,6 +0,0 @@
---
Cop/RedirectWithStatus:
Details: grace period
Exclude:
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/concerns/membership_actions.rb'

1
.rubocop_todo/cop/user_admin.yml
View file

@ -16,7 +16,6 @@ Cop/UserAdmin:
- 'app/services/projects/fork_service.rb'
- 'app/services/users/build_service.rb'
- 'ee/app/controllers/ee/projects_controller.rb'
- 'ee/app/models/concerns/ee/protected_ref_access.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/policies/ee/group_policy.rb'
- 'ee/app/services/ee/groups/create_service.rb'

4
.rubocop_todo/database/disable_referential_integrity.yml
View file

@ -1,4 +0,0 @@
---
Database/DisableReferentialIntegrity:
Exclude:
- 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb'

1
.rubocop_todo/database/rescue_query_canceled.yml
View file

@ -2,7 +2,6 @@
Database/RescueQueryCanceled:
Exclude:
- 'app/services/issues/relative_position_rebalancing_service.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb'
- 'lib/gitlab/database/batch_counter.rb'
- 'lib/gitlab/issuables_count_for_state.rb'

8
.rubocop_todo/fips/sha1.yml
View file

@ -18,18 +18,13 @@ Fips/SHA1:
- 'ee/app/services/vulnerabilities/create_service_base.rb'
- 'ee/app/services/vulnerabilities/manually_create_service.rb'
- 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb'
- 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'ee/spec/factories/vulnerabilities/feedback.rb'
- 'ee/spec/factories/vulnerabilities/finding_signatures.rb'
- 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb'
- 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb'
- 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb'
- 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb'
- 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/models/resource_weight_event_spec.rb'
- 'ee/spec/models/vulnerabilities/finding_signature_spec.rb'
- 'ee/spec/models/vulnerabilities/finding_spec.rb'
@ -76,7 +71,6 @@ Fips/SHA1:
- 'spec/lib/gitlab/alert_management/payload/generic_spec.rb'
- 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb'
@ -84,9 +78,7 @@ Fips/SHA1:
- 'spec/lib/gitlab/diff/position_spec.rb'
- 'spec/lib/gitlab/git/branch_spec.rb'
- 'spec/lib/gitlab/git/tag_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb'
- 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'spec/models/ci/artifact_blob_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'

28
.rubocop_todo/gettext/static_identifier.yml Normal file
View file

@ -0,0 +1,28 @@
---
Gettext/StaticIdentifier:
Details: grace period
Exclude:
- 'app/graphql/types/project_type.rb'
- 'app/models/integrations/apple_app_store.rb'
- 'app/models/integrations/confluence.rb'
- 'app/models/integrations/google_play.rb'
- 'app/services/import/fogbugz_service.rb'
- 'app/services/issuable_links/create_service.rb'
- 'app/services/issues/set_crm_contacts_service.rb'
- 'app/services/projects/create_from_template_service.rb'
- 'app/services/security/ci_configuration/base_create_service.rb'
- 'app/services/users/banned_user_base_service.rb'
- 'app/services/work_items/widgets/hierarchy_service/base_service.rb'
- 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/controllers/subscriptions/groups_controller.rb'
- 'ee/app/mailers/ee/emails/admin_notification.rb'
- 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb'
- 'ee/app/models/ee/member.rb'
- 'ee/app/models/integrations/github.rb'
- 'ee/app/services/ee/projects/create_from_template_service.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb'
- 'ee/app/services/timebox/rollup_report_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- 'ee/spec/controllers/groups/security/policies_controller_spec.rb'
- 'ee/spec/features/registrations/identity_verification_spec.rb'
- 'lib/gitlab/github_import/settings.rb'

13
.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml
View file

@ -1,13 +0,0 @@
---
Gitlab/DeprecateTrackRedisHLLEvent:
Exclude:
- 'app/controllers/concerns/snippets_actions.rb'
- 'app/controllers/concerns/wiki_actions.rb'
- 'app/controllers/projects/blob_controller.rb'
- 'app/controllers/projects/pipelines_controller.rb'
- 'ee/app/controllers/admin/audit_logs_controller.rb'
- 'ee/app/controllers/admin/credentials_controller.rb'
- 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb'
- 'ee/app/controllers/groups/audit_events_controller.rb'
- 'ee/app/controllers/groups/epic_boards_controller.rb'
- 'spec/controllers/concerns/redis_tracking_spec.rb'

1
.rubocop_todo/gitlab/doc_url.yml
View file

@ -24,7 +24,6 @@ Gitlab/DocUrl:
- 'ee/app/mailers/emails/user_cap.rb'
- 'ee/app/workers/concerns/elastic/migration_obsolete.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
- 'ee/lib/slack/block_kit/app_home_opened.rb'
- 'ee/lib/system_check/app/advanced_search_migrations_check.rb'
- 'ee/lib/tasks/gitlab/geo.rake'
- 'lib/backup/database.rb'

11
.rubocop_todo/gitlab/namespaced_class.yml
View file

@ -79,7 +79,6 @@ Gitlab/NamespacedClass:
- 'app/finders/resource_milestone_event_finder.rb'
- 'app/finders/resource_state_event_finder.rb'
- 'app/finders/sentry_issue_finder.rb'
- 'app/finders/serverless_domain_finder.rb'
- 'app/finders/snippets_finder.rb'
- 'app/finders/starred_projects_finder.rb'
- 'app/finders/tags_finder.rb'
@ -245,6 +244,7 @@ Gitlab/NamespacedClass:
- 'app/models/notification_setting.rb'
- 'app/models/oauth_access_grant.rb'
- 'app/models/oauth_access_token.rb'
- 'app/models/organization.rb'
- 'app/models/out_of_context_discussion.rb'
- 'app/models/pages_deployment.rb'
- 'app/models/pages_domain.rb'
@ -307,6 +307,7 @@ Gitlab/NamespacedClass:
- 'app/models/service_desk_setting.rb'
- 'app/models/service_list.rb'
- 'app/models/shard.rb'
- 'app/models/slack_integration.rb'
- 'app/models/snippet.rb'
- 'app/models/snippet_blob.rb'
- 'app/models/snippet_input_action.rb'
@ -353,6 +354,7 @@ Gitlab/NamespacedClass:
- 'app/models/x509_certificate.rb'
- 'app/models/x509_issuer.rb'
- 'app/models/zoom_meeting.rb'
- 'app/policies/abuse_report_policy.rb'
- 'app/policies/application_setting/term_policy.rb'
- 'app/policies/award_emoji_policy.rb'
- 'app/policies/base_policy.rb'
@ -477,7 +479,6 @@ Gitlab/NamespacedClass:
- 'app/serializers/build_metadata_entity.rb'
- 'app/serializers/build_trace_entity.rb'
- 'app/serializers/build_trace_serializer.rb'
- 'app/serializers/cluster_application_entity.rb'
- 'app/serializers/cluster_entity.rb'
- 'app/serializers/cluster_serializer.rb'
- 'app/serializers/codequality_degradation_entity.rb'
@ -821,8 +822,6 @@ Gitlab/NamespacedClass:
- 'app/workers/run_pipeline_schedule_worker.rb'
- 'app/workers/schedule_merge_request_cleanup_refs_worker.rb'
- 'app/workers/schedule_migrate_external_diffs_worker.rb'
- 'app/workers/self_monitoring_project_create_worker.rb'
- 'app/workers/self_monitoring_project_delete_worker.rb'
- 'app/workers/service_desk_email_receiver_worker.rb'
- 'app/workers/stage_update_worker.rb'
- 'app/workers/stuck_ci_jobs_worker.rb'
@ -938,7 +937,6 @@ Gitlab/NamespacedClass:
- 'ee/app/models/scim_identity.rb'
- 'ee/app/models/scim_oauth_access_token.rb'
- 'ee/app/models/scoped_label_set.rb'
- 'ee/app/models/slack_integration.rb'
- 'ee/app/models/smartcard_identity.rb'
- 'ee/app/models/software_license.rb'
- 'ee/app/models/software_license_policy.rb'
@ -1049,6 +1047,7 @@ Gitlab/NamespacedClass:
- 'ee/app/workers/elastic_namespace_indexer_worker.rb'
- 'ee/app/workers/elastic_namespace_rollout_worker.rb'
- 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb'
- 'ee/app/workers/elastic_wiki_indexer_worker.rb'
- 'ee/app/workers/geo_repository_destroy_worker.rb'
- 'ee/app/workers/group_saml_group_sync_worker.rb'
- 'ee/app/workers/historical_data_worker.rb'
@ -1069,7 +1068,6 @@ Gitlab/NamespacedClass:
- 'ee/app/workers/sync_seat_link_request_worker.rb'
- 'ee/app/workers/sync_seat_link_worker.rb'
- 'ee/app/workers/update_all_mirrors_worker.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'ee/lib/gitlab/authority_analyzer.rb'
- 'ee/lib/gitlab/cidr.rb'
- 'ee/lib/gitlab/custom_file_templates.rb'
@ -1270,7 +1268,6 @@ Gitlab/NamespacedClass:
- 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
- 'spec/support/helpers/ci_artifact_metadata_generator.rb'
- 'spec/support/helpers/fake_migration_classes.rb'
- 'spec/support/helpers/fake_u2f_device.rb'
- 'spec/support/helpers/fake_webauthn_device.rb'
- 'spec/support/helpers/markdown_feature.rb'
- 'spec/support/helpers/redis_without_keys.rb'

1
.rubocop_todo/gitlab/service_response.yml
View file

@ -60,7 +60,6 @@ Gitlab/ServiceResponse:
- 'ee/app/services/iterations/roll_over_issues_service.rb'
- 'ee/app/services/iterations/update_service.rb'
- 'ee/app/services/security/findings/dismiss_service.rb'
- 'ee/app/services/vulnerabilities/finding_dismiss_service.rb'
- 'ee/app/services/vulnerability_issue_links/create_service.rb'
- 'ee/app/services/vulnerability_issue_links/delete_service.rb'
- 'ee/spec/graphql/mutations/security/finding/dismiss_spec.rb'

6
.rubocop_todo/gitlab/strong_memoize_attr.yml
View file

@ -356,7 +356,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/models/gitlab_subscription.rb'
- 'ee/app/models/issuables_analytics.rb'
- 'ee/app/models/license.rb'
- 'ee/app/models/namespaces/storage/root_excess_size.rb'
- 'ee/app/models/sca/license_compliance.rb'
- 'ee/app/models/security/orchestration_policy_configuration.rb'
- 'ee/app/models/security/orchestration_policy_rule_schedule.rb'
@ -409,7 +408,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/services/incident_management/escalation_policies/update_service.rb'
- 'ee/app/services/incident_management/pending_escalations/process_service.rb'
- 'ee/app/services/iterations/create_service.rb'
- 'ee/app/services/merge_commits/export_csv_service.rb'
- 'ee/app/services/merge_requests/update_blocks_service.rb'
- 'ee/app/services/projects/restore_service.rb'
- 'ee/app/services/protected_environments/base_service.rb'
@ -469,7 +467,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/lib/gitlab/auth/group_saml/user.rb'
- 'ee/lib/gitlab/auth/saml/membership_updater.rb'
- 'ee/lib/gitlab/auth/smartcard/certificate.rb'
- 'ee/lib/gitlab/ci/minutes/build_consumption.rb'
- 'ee/lib/gitlab/ci/minutes/cached_quota.rb'
- 'ee/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor.rb'
- 'ee/lib/gitlab/ci/minutes/runners_availability.rb'
@ -547,7 +544,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb'
- 'lib/gitlab/auth/request_authenticator.rb'
- 'lib/gitlab/background_migration/legacy_upload_mover.rb'
- 'lib/gitlab/bare_repository_import/repository.rb'
- 'lib/gitlab/blob_helper.rb'
- 'lib/gitlab/cache/ci/project_pipeline_status.rb'
- 'lib/gitlab/chat/command.rb'
@ -653,7 +649,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/import_export/fast_hash_serializer.rb'
- 'lib/gitlab/import_export/group/tree_restorer.rb'
- 'lib/gitlab/import_export/importer.rb'
- 'lib/gitlab/import_export/json/legacy_reader.rb'
- 'lib/gitlab/import_export/lfs_restorer.rb'
- 'lib/gitlab/import_export/project/sample/date_calculator.rb'
- 'lib/gitlab/import_export/project/tree_restorer.rb'
@ -679,7 +674,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/relative_positioning/starting_from.rb'
- 'lib/gitlab/request_context.rb'
- 'lib/gitlab/search/found_blob.rb'
- 'lib/gitlab/serverless/service.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb'
- 'lib/gitlab/sidekiq_queue.rb'

7
.rubocop_todo/graphql/authorize_types.yml Normal file
View file

@ -0,0 +1,7 @@
---
Graphql/AuthorizeTypes:
Exclude:
- 'app/graphql/types/data_transfer/base_type.rb'
- 'app/graphql/types/data_transfer/egress_node_type.rb'
- 'app/graphql/types/data_transfer/group_data_transfer_type.rb'
- 'app/graphql/types/data_transfer/project_data_transfer_type.rb'

346
.rubocop_todo/layout/argument_alignment.yml
View file

@ -506,28 +506,6 @@ Layout/ArgumentAlignment:
- 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb'
- 'app/graphql/types/x509_certificate_type.rb'
- 'app/graphql/types/x509_issuer_type.rb'
- 'app/mailers/emails/projects.rb'
- 'app/mailers/notify.rb'
- 'app/models/abuse_report.rb'
- 'app/models/achievements/achievement.rb'
- 'app/models/achievements/user_achievement.rb'
- 'app/models/active_session.rb'
- 'app/models/analytics/cycle_analytics/project_level.rb'
- 'app/models/analytics/cycle_analytics/stage.rb'
- 'app/models/analytics/cycle_analytics/value_stream.rb'
- 'app/models/appearance.rb'
- 'app/models/application_setting.rb'
- 'app/models/atlassian/identity.rb'
- 'app/models/bulk_imports/configuration.rb'
- 'app/models/bulk_imports/entity.rb'
- 'app/models/clusters/kubernetes_namespace.rb'
- 'app/models/container_repository.rb'
- 'app/models/cycle_analytics/project_level_stage_adapter.rb'
- 'app/models/deployment.rb'
- 'app/models/design_management/design.rb'
- 'app/models/design_management/version.rb'
- 'app/models/diff_discussion.rb'
- 'app/models/diff_viewer/base.rb'
- 'app/models/discussion.rb'
- 'app/models/environment.rb'
- 'app/models/generic_commit_status.rb'
@ -541,16 +519,6 @@ Layout/ArgumentAlignment:
- 'app/models/integrations/jira.rb'
- 'app/models/jira_connect_installation.rb'
- 'app/models/lfs_object.rb'
- 'app/models/loose_foreign_keys/deleted_record.rb'
- 'app/models/merge_request.rb'
- 'app/models/merge_request_diff.rb'
- 'app/models/merge_requests_closing_issues.rb'
- 'app/models/ml/candidate_metadata.rb'
- 'app/models/ml/experiment_metadata.rb'
- 'app/models/namespace.rb'
- 'app/models/namespaces/traversal/linear_scopes.rb'
- 'app/models/note.rb'
- 'app/models/note_diff_file.rb'
- 'app/models/packages/cleanup/policy.rb'
- 'app/models/packages/conan/metadatum.rb'
- 'app/models/packages/debian/file_entry.rb'
@ -568,26 +536,10 @@ Layout/ArgumentAlignment:
- 'app/models/remote_mirror.rb'
- 'app/models/repository.rb'
- 'app/models/resource_timebox_event.rb'
- 'app/models/serverless/domain_cluster.rb'
- 'app/models/service_desk_setting.rb'
- 'app/models/terraform/state.rb'
- 'app/models/time_tracking/timelog_category.rb'
- 'app/models/u2f_registration.rb'
- 'app/models/user.rb'
- 'app/models/user_preference.rb'
- 'app/models/users/group_callout.rb'
- 'app/models/users/phone_number_validation.rb'
- 'app/models/users/project_callout.rb'
- 'app/models/users/user_follow_user.rb'
- 'app/models/web_ide_terminal.rb'
- 'app/models/webauthn_registration.rb'
- 'app/models/wiki_page.rb'
- 'app/models/work_item.rb'
- 'app/services/ci/archive_trace_service.rb'
- 'app/services/ci/ensure_stage_service.rb'
- 'app/services/ci/list_config_variables_service.rb'
- 'app/services/ci/parse_dotenv_artifact_service.rb'
- 'app/services/ci/stuck_builds/drop_helpers.rb'
- 'app/services/compare_service.rb'
- 'app/services/concerns/rate_limited_service.rb'
- 'app/services/design_management/copy_design_collection/copy_service.rb'
@ -608,22 +560,11 @@ Layout/ArgumentAlignment:
- 'app/services/markdown_content_rewriter_service.rb'
- 'app/services/members/base_service.rb'
- 'app/services/members/create_service.rb'
- 'app/services/merge_requests/build_service.rb'
- 'app/services/merge_requests/ff_merge_service.rb'
- 'app/services/merge_requests/merge_service.rb'
- 'app/services/merge_requests/merge_to_ref_service.rb'
- 'app/services/merge_requests/push_options_handler_service.rb'
- 'app/services/merge_requests/refresh_service.rb'
- 'app/services/merge_requests/reload_diffs_service.rb'
- 'app/services/merge_requests/retarget_chain_service.rb'
- 'app/services/metrics/dashboard/annotations/create_service.rb'
- 'app/services/metrics/dashboard/annotations/delete_service.rb'
- 'app/services/metrics/dashboard/clone_dashboard_service.rb'
- 'app/services/metrics/users_starred_dashboards/create_service.rb'
- 'app/services/ml/experiment_tracking/experiment_repository.rb'
- 'app/services/notes/create_service.rb'
- 'app/services/notes/destroy_service.rb'
- 'app/services/notes/update_service.rb'
- 'app/services/pages/migrate_from_legacy_storage_service.rb'
- 'app/services/post_receive_service.rb'
- 'app/services/preview_markdown_service.rb'
@ -656,13 +597,6 @@ Layout/ArgumentAlignment:
- 'config/initializers/rack_timeout.rb'
- 'config/initializers/rest-client-hostname_override.rb'
- 'config/initializers/zz_metrics.rb'
- 'db/migrate/20210901065504_add_index_on_name_and_id_to_public_groups.rb'
- 'db/migrate/20210910014741_add_dependency_proxy_ttl_group_policy_worker_capacity_to_application_settings.rb'
- 'db/migrate/20211111112639_add_fk_compliance_violations_merge_request.rb'
- 'db/migrate/20211111112713_add_fk_compliance_violations_violating_user.rb'
- 'db/migrate/20211224112937_add_packages_cleanup_package_file_worker_capacity_to_application_settings.rb'
- 'db/migrate/20220204154220_add_index_on_greatest_done_at_to_container_repositories.rb'
- 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb'
- 'db/migrate/20220401113123_add_check_constraint_to_vsa_aggregation_runtime_data_columns.rb'
- 'db/migrate/20220405125459_add_non_migrated_index_to_container_repositories.rb'
- 'db/migrate/20220408001450_add_work_item_type_name_unique_index_null_namespaces.rb'
@ -725,20 +659,6 @@ Layout/ArgumentAlignment:
- 'db/migrate/20230124193917_add_index_for_protected_tag_create_access_levels.rb'
- 'db/migrate/20230127151529_add_project_pointer_for_analytics_dashboard.rb'
- 'db/migrate/20230127151531_change_dashboard_analytics_project_pointer_project_null.rb'
- 'db/post_migrate/20210921062820_add_image_location_index_to_vulnerability_occurrences.rb'
- 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb'
- 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb'
- 'db/post_migrate/20211022112202_add_cluster_id_location_index_to_vulnerability_occurrences.rb'
- 'db/post_migrate/20211027112901_drop_index_keys_on_expires_at_and_before_expiry_notification_undelivered.rb'
- 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb'
- 'db/post_migrate/20211118194239_drop_invalid_remediations.rb'
- 'db/post_migrate/20211213064821_add_agent_id_location_index_to_vulnerability_occurrences.rb'
- 'db/post_migrate/20211217120000_modify_kubernetes_resource_location_index_to_vulnerability_occurrences.rb'
- 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb'
- 'db/post_migrate/20220216201949_remove_package_files_limit_from_application_settings.rb'
- 'db/post_migrate/20220307192534_create_index_for_remove_duplicate_project_tag_releases.rb'
- 'db/post_migrate/20220307192645_remove_index_for_remove_duplicate_project_tag_releases.rb'
- 'db/post_migrate/20220307192725_create_unique_index_release_tag_project.rb'
- 'db/post_migrate/20220415124802_remove_job_artifact_deprecated_geo_fields.rb'
- 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb'
- 'db/post_migrate/20220523164734_add_foreign_key_to_vulnerability_reads_casted_cluster_agent_id.rb'
@ -792,7 +712,6 @@ Layout/ArgumentAlignment:
- 'db/post_migrate/20230130070623_add_index_on_packages_package_file_file_name.rb'
- 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb'
- 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb'
- 'ee/app/components/namespaces/free_user_cap/shared.rb'
- 'ee/app/graphql/ee/mutations/alert_management/http_integration/create.rb'
- 'ee/app/graphql/ee/mutations/alert_management/http_integration/update.rb'
- 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb'
@ -922,7 +841,6 @@ Layout/ArgumentAlignment:
- 'ee/app/graphql/mutations/vulnerabilities/create_external_issue_link.rb'
- 'ee/app/graphql/mutations/vulnerabilities/destroy_external_issue_link.rb'
- 'ee/app/graphql/mutations/vulnerabilities/dismiss.rb'
- 'ee/app/graphql/mutations/vulnerabilities/finding/dismiss.rb'
- 'ee/app/graphql/mutations/vulnerabilities/resolve.rb'
- 'ee/app/graphql/mutations/vulnerabilities/revert_to_detected.rb'
- 'ee/app/graphql/resolvers/alert_management/payload_alert_field_resolver.rb'
@ -1076,8 +994,6 @@ Layout/ArgumentAlignment:
- 'ee/app/graphql/types/work_items/widgets/status_filter_input_type.rb'
- 'ee/app/graphql/types/work_items/widgets/status_input_type.rb'
- 'ee/app/graphql/types/work_items/widgets/weight_input_type.rb'
- 'ee/app/mailers/ee/emails/projects.rb'
- 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb'
- 'ee/app/models/approval_wrapped_rule.rb'
- 'ee/app/models/dast/pre_scan_verification.rb'
- 'ee/app/models/deployments/approval.rb'
@ -1118,7 +1034,6 @@ Layout/ArgumentAlignment:
- 'ee/app/models/scim_identity.rb'
- 'ee/app/models/security/finding.rb'
- 'ee/app/models/security/orchestration_policy_rule_schedule.rb'
- 'ee/app/models/slack_integration.rb'
- 'ee/app/models/smartcard_identity.rb'
- 'ee/app/models/status_page/project_setting.rb'
- 'ee/app/models/vulnerabilities/external_issue_link.rb'
@ -1171,44 +1086,11 @@ Layout/ArgumentAlignment:
- 'ee/db/geo/post_migrate/20210217020154_add_unique_index_on_container_repository_registry.rb'
- 'ee/db/geo/post_migrate/20210217020156_add_unique_index_on_terraform_state_version_registry.rb'
- 'ee/db/seeds/awesome_co/awesome_co.rb'
- 'ee/lib/api/analytics/code_review_analytics.rb'
- 'ee/lib/api/analytics/product_analytics.rb'
- 'ee/lib/api/audit_events.rb'
- 'ee/lib/api/dependencies.rb'
- 'ee/lib/api/epics.rb'
- 'ee/lib/api/group_push_rule.rb'
- 'ee/lib/api/helpers/project_approval_rules_helpers.rb'
- 'ee/lib/api/ldap_group_links.rb'
- 'ee/lib/api/merge_request_approval_settings.rb'
- 'ee/lib/api/merge_trains.rb'
- 'ee/lib/api/project_aliases.rb'
- 'ee/lib/api/project_push_rule.rb'
- 'ee/lib/api/related_epic_links.rb'
- 'ee/lib/api/saml_group_links.rb'
- 'ee/lib/api/status_checks.rb'
- 'ee/lib/api/vulnerability_exports.rb'
- 'ee/lib/api/vulnerability_findings.rb'
- 'ee/lib/api/vulnerability_issue_links.rb'
- 'ee/lib/audit/compliance_framework_changes_auditor.rb'
- 'ee/lib/audit/external_status_check_changes_auditor.rb'
- 'ee/lib/audit/group_changes_auditor.rb'
- 'ee/lib/audit/group_push_rules_changes_auditor.rb'
- 'ee/lib/audit/project_changes_auditor.rb'
- 'ee/lib/ee/api/entities/approval_rule.rb'
- 'ee/lib/ee/api/entities/epic_issue.rb'
- 'ee/lib/ee/api/entities/epic_issue_link.rb'
- 'ee/lib/ee/api/entities/group.rb'
- 'ee/lib/ee/api/entities/group_detail.rb'
- 'ee/lib/ee/api/entities/group_push_rule.rb'
- 'ee/lib/ee/api/entities/member.rb'
- 'ee/lib/ee/api/entities/merge_request_approval_state.rb'
- 'ee/lib/ee/api/entities/merge_request_approval_state_rule.rb'
- 'ee/lib/ee/api/entities/project.rb'
- 'ee/lib/ee/api/groups.rb'
- 'ee/lib/ee/api/helpers/issues_helpers.rb'
- 'ee/lib/ee/api/members.rb'
- 'ee/lib/ee/api/merge_request_approvals.rb'
- 'ee/lib/ee/api/projects.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb'
@ -1233,20 +1115,11 @@ Layout/ArgumentAlignment:
- 'ee/lib/gitlab/status_page/pipeline/post_process_pipeline.rb'
- 'ee/lib/gitlab/subscription_portal/clients/graphql.rb'
- 'ee/lib/gitlab/zoekt/search_results.rb'
- 'ee/lib/slack/block_kit/app_home_opened.rb'
- 'ee/spec/components/billing/plan_component_spec.rb'
- 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb'
- 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb'
- 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb'
- 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb'
- 'ee/spec/factories/epic_tree_nodes.rb'
- 'ee/spec/factories/groups.rb'
- 'ee/spec/factories/import_states.rb'
- 'ee/spec/factories/merge_requests.rb'
- 'ee/spec/factories/namespaces.rb'
- 'ee/spec/factories/projects.rb'
- 'ee/spec/factories/security_scans.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/features/account_recovery_regular_check_spec.rb'
- 'ee/spec/features/admin/admin_emails_spec.rb'
- 'ee/spec/features/admin/admin_settings_spec.rb'
@ -1344,9 +1217,7 @@ Layout/ArgumentAlignment:
- 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb'
@ -1370,7 +1241,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb'
- 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb'
- 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb'
- 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb'
- 'ee/spec/lib/gitlab/ci/project_config_spec.rb'
@ -1398,7 +1268,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/lib/gitlab/zoekt/search_results_spec.rb'
- 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb'
- 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb'
- 'ee/spec/models/dast/pre_scan_verification_step_spec.rb'
- 'ee/spec/models/dast_site_profile_spec.rb'
@ -1514,34 +1383,17 @@ Layout/ArgumentAlignment:
- 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/groups/settings/domain_verification_controller_spec.rb'
- 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb'
- 'ee/spec/requests/projects/analytics/cycle_analytics/stages_controller_spec.rb'
- 'ee/spec/requests/projects/mirrors_controller_spec.rb'
- 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb'
- 'ee/spec/requests/projects/security/dast_configuration_controller_spec.rb'
- 'ee/spec/requests/projects/security/dast_profiles_controller_spec.rb'
- 'ee/spec/requests/registrations/project_creation_spec.rb'
- 'ee/spec/requests/smartcard_controller_spec.rb'
- 'ee/spec/requests/users/identity_verification_controller_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb'
- 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scan_configs/build_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb'
- 'ee/spec/services/arkose/blocked_users_report_service_spec.rb'
- 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb'
- 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb'
- 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb'
- 'ee/spec/services/auto_merge/merge_train_service_spec.rb'
- 'ee/spec/services/boards/lists/update_service_spec.rb'
- 'ee/spec/services/ci/process_pipeline_service_spec.rb'
- 'ee/spec/services/ci/retry_pipeline_service_spec.rb'
- 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb'
- 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb'
- 'ee/spec/services/ci_cd/github_setup_service_spec.rb'
- 'ee/spec/services/ee/boards/issues/create_service_spec.rb'
- 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
- 'ee/spec/services/ee/boards/issues/move_service_spec.rb'
@ -1556,7 +1408,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb'
- 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb'
- 'ee/spec/services/epics/issue_promote_service_spec.rb'
- 'ee/spec/services/epics/tree_reorder_service_spec.rb'
- 'ee/spec/services/geo/blob_upload_service_spec.rb'
- 'ee/spec/services/geo/framework_repository_sync_service_spec.rb'
- 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb'
@ -1570,7 +1421,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/services/groups/restore_service_spec.rb'
- 'ee/spec/services/issue_feature_flags/list_service_spec.rb'
- 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb'
- 'ee/spec/services/merge_requests/build_service_spec.rb'
- 'ee/spec/services/protected_environments/create_service_spec.rb'
- 'ee/spec/services/protected_environments/update_service_spec.rb'
- 'ee/spec/services/quick_actions/interpret_service_spec.rb'
@ -1601,15 +1451,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/services/vulnerabilities/user_notes_count_service_spec.rb'
- 'ee/spec/services/vulnerability_feedback/create_service_spec.rb'
- 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb'
- 'ee/spec/support/shared_examples/audit/audit_event_type_stream_shared_examples.rb'
- 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb'
- 'ee/spec/support/shared_examples/graphql/dast/dast_profile_schedule_shared_examples.rb'
- 'ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb'
- 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb'
- 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb'
- 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb'
- 'ee/spec/tasks/gitlab/elastic_rake_spec.rb'
- 'lib/api/access_requests.rb'
- 'lib/api/admin/plan_limits.rb'
@ -1732,15 +1573,6 @@ Layout/ArgumentAlignment:
- 'lib/gitlab/alert_management/payload/managed_prometheus.rb'
- 'lib/gitlab/alert_management/payload/prometheus.rb'
- 'lib/gitlab/auth/ldap/adapter.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb'
- 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects.rb'
- 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects.rb'
- 'lib/gitlab/background_migration/encrypt_integration_properties.rb'
- 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb'
- 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/reset_status_on_container_repositories.rb'
- 'lib/gitlab/bare_repository_import/importer.rb'
- 'lib/gitlab/bitbucket_server_import/importer.rb'
- 'lib/gitlab/chat/command.rb'
- 'lib/gitlab/ci/ansi2json/line.rb'
@ -1831,12 +1663,6 @@ Layout/ArgumentAlignment:
- 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb'
- 'lib/gitlab/metrics/requests_rack_middleware.rb'
- 'lib/gitlab/other_markup.rb'
- 'lib/gitlab/phabricator_import/cache/map.rb'
- 'lib/gitlab/phabricator_import/conduit/maniphest.rb'
- 'lib/gitlab/phabricator_import/conduit/response.rb'
- 'lib/gitlab/phabricator_import/conduit/user.rb'
- 'lib/gitlab/phabricator_import/issues/importer.rb'
- 'lib/gitlab/phabricator_import/user_finder.rb'
- 'lib/gitlab/project_authorizations.rb'
- 'lib/gitlab/redis/multi_store.rb'
- 'lib/gitlab/request_context.rb'
@ -1846,7 +1672,6 @@ Layout/ArgumentAlignment:
- 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb'
- 'lib/gitlab/setup_helper.rb'
- 'lib/gitlab/sidekiq_config/worker.rb'
- 'lib/gitlab/sidekiq_daemon/memory_killer.rb'
- 'lib/gitlab/spamcheck/client.rb'
- 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb'
- 'lib/gitlab/usage_data.rb'
@ -1894,14 +1719,8 @@ Layout/ArgumentAlignment:
- 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb'
- 'qa/qa/specs/features/api/3_create/repository/tag_revision_trigger_prereceive_hook_spec.rb'
- 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/group/group_member_access_request_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_group_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/integrations/jenkins/jenkins_build_status_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/user/parent_group_access_termination_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb'
@ -1961,7 +1780,6 @@ Layout/ArgumentAlignment:
- 'qa/qa/specs/features/ee/browser_ui/15_growth/free_trial_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb'
@ -1981,12 +1799,6 @@ Layout/ArgumentAlignment:
- 'spec/components/previews/pajamas/alert_component_preview.rb'
- 'spec/components/previews/pajamas/banner_component_preview.rb'
- 'spec/components/previews/pajamas/button_component_preview.rb'
- 'spec/factories/ci/processable.rb'
- 'spec/factories/draft_note.rb'
- 'spec/factories/environments.rb'
- 'spec/factories/group_members.rb'
- 'spec/factories/ml/candidates.rb'
- 'spec/factories/notes.rb'
- 'spec/features/admin/admin_mode/login_spec.rb'
- 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb'
- 'spec/features/atom/issues_spec.rb'
@ -2093,7 +1905,6 @@ Layout/ArgumentAlignment:
- 'spec/features/snippets/spam_snippets_spec.rb'
- 'spec/features/snippets/user_creates_snippet_spec.rb'
- 'spec/features/task_lists_spec.rb'
- 'spec/features/u2f_spec.rb'
- 'spec/features/user_sees_revert_modal_spec.rb'
- 'spec/features/users/email_verification_on_login_spec.rb'
- 'spec/features/users/login_spec.rb'
@ -2159,21 +1970,6 @@ Layout/ArgumentAlignment:
- 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb'
- 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb'
- 'spec/lib/gitlab/auth/saml/user_spec.rb'
- 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_environment_tiers_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_namespace_details_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_namespace_details_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_releases_author_id_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb'
- 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb'
@ -2188,26 +1984,10 @@ Layout/ArgumentAlignment:
- 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb'
- 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_five_mb_spec.rb'
- 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb'
- 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb'
- 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb'
- 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb'
- 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb'
- 'spec/lib/gitlab/background_migration/prune_stale_project_export_jobs_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb'
- 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb'
- 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb'
- 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb'
- 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb'
- 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb'
- 'spec/lib/gitlab/bare_repository_import/importer_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb'
@ -2327,15 +2107,9 @@ Layout/ArgumentAlignment:
- 'spec/lib/gitlab/middleware/multipart_spec.rb'
- 'spec/lib/gitlab/pagination_delegate_spec.rb'
- 'spec/lib/gitlab/path_regex_spec.rb'
- 'spec/lib/gitlab/phabricator_import/cache/map_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb'
- 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb'
- 'spec/lib/gitlab/profiler_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb'
- 'spec/lib/gitlab/redis/sidekiq_status_spec.rb'
- 'spec/lib/gitlab/repository_cache/preloader_spec.rb'
- 'spec/lib/gitlab/repository_cache_spec.rb'
@ -2370,29 +2144,6 @@ Layout/ArgumentAlignment:
- 'spec/lib/security/weak_passwords_spec.rb'
- 'spec/lib/sidebars/projects/menus/repository_menu_spec.rb'
- 'spec/lib/uploaded_file_spec.rb'
- 'spec/mailers/emails/merge_requests_spec.rb'
- 'spec/mailers/emails/pipelines_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/models/analytics/cycle_analytics/stage_spec.rb'
- 'spec/models/application_setting_spec.rb'
- 'spec/models/clusters/cluster_spec.rb'
- 'spec/models/clusters/kubernetes_namespace_spec.rb'
- 'spec/models/clusters/platforms/kubernetes_spec.rb'
- 'spec/models/commit_spec.rb'
- 'spec/models/container_repository_spec.rb'
- 'spec/models/deployment_spec.rb'
- 'spec/models/design_management/version_spec.rb'
- 'spec/models/diff_note_spec.rb'
- 'spec/models/environment_spec.rb'
- 'spec/models/environment_status_spec.rb'
- 'spec/models/event_collection_spec.rb'
- 'spec/models/event_spec.rb'
- 'spec/models/generic_commit_status_spec.rb'
- 'spec/models/group_group_link_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/integrations/apple_app_store_spec.rb'
- 'spec/models/integrations/buildkite_spec.rb'
- 'spec/models/integrations/hangouts_chat_spec.rb'
- 'spec/models/integrations/mattermost_slash_commands_spec.rb'
- 'spec/models/integrations/microsoft_teams_spec.rb'
- 'spec/models/issue_spec.rb'
@ -2414,15 +2165,6 @@ Layout/ArgumentAlignment:
- 'spec/models/project_team_spec.rb'
- 'spec/models/release_spec.rb'
- 'spec/models/remote_mirror_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/resource_state_event_spec.rb'
- 'spec/models/snippet_spec.rb'
- 'spec/models/spam_log_spec.rb'
- 'spec/models/u2f_registration_spec.rb'
- 'spec/models/upload_spec.rb'
- 'spec/models/user_detail_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/models/wiki_page/meta_spec.rb'
- 'spec/requests/admin/applications_controller_spec.rb'
- 'spec/requests/admin/impersonation_tokens_controller_spec.rb'
- 'spec/requests/api/access_requests_spec.rb'
@ -2461,10 +2203,6 @@ Layout/ArgumentAlignment:
- 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb'
- 'spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb'
- 'spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/job_cancel_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/job_play_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/job_retry_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/job_unschedule_spec.rb'
- 'spec/requests/api/graphql/mutations/ci/pipeline_retry_spec.rb'
- 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb'
- 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb'
@ -2556,12 +2294,6 @@ Layout/ArgumentAlignment:
- 'spec/requests/jwt_controller_spec.rb'
- 'spec/requests/lfs_http_spec.rb'
- 'spec/requests/oauth_tokens_spec.rb'
- 'spec/requests/projects/environments_controller_spec.rb'
- 'spec/requests/projects/incident_management/timeline_events_spec.rb'
- 'spec/requests/projects/issue_links_controller_spec.rb'
- 'spec/requests/projects/issues_controller_spec.rb'
- 'spec/requests/projects/merge_requests_controller_spec.rb'
- 'spec/requests/projects/merge_requests_spec.rb'
- 'spec/requests/rack_attack_global_spec.rb'
- 'spec/requests/recursive_webhook_detection_spec.rb'
- 'spec/requests/users/group_callouts_spec.rb'
@ -2582,24 +2314,6 @@ Layout/ArgumentAlignment:
- 'spec/services/award_emojis/destroy_service_spec.rb'
- 'spec/services/bulk_imports/create_service_spec.rb'
- 'spec/services/bulk_imports/get_importable_data_service_spec.rb'
- 'spec/services/ci/archive_trace_service_spec.rb'
- 'spec/services/ci/create_downstream_pipeline_service_spec.rb'
- 'spec/services/ci/create_pipeline_service/include_spec.rb'
- 'spec/services/ci/create_pipeline_service/logger_spec.rb'
- 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb'
- 'spec/services/ci/create_pipeline_service/partitioning_spec.rb'
- 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb'
- 'spec/services/ci/create_pipeline_service_spec.rb'
- 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb'
- 'spec/services/ci/job_artifacts/track_artifact_report_service_spec.rb'
- 'spec/services/ci/list_config_variables_service_spec.rb'
- 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb'
- 'spec/services/ci/play_build_service_spec.rb'
- 'spec/services/ci/play_manual_stage_service_spec.rb'
- 'spec/services/ci/process_sync_events_service_spec.rb'
- 'spec/services/ci/retry_job_service_spec.rb'
- 'spec/services/ci/retry_pipeline_service_spec.rb'
- 'spec/services/ci/run_scheduled_build_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb'
- 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
- 'spec/services/cohorts_service_spec.rb'
@ -2630,30 +2344,8 @@ Layout/ArgumentAlignment:
- 'spec/services/issues/resolve_discussions_spec.rb'
- 'spec/services/issues/update_service_spec.rb'
- 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb'
- 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb'
- 'spec/services/merge_requests/assign_issues_service_spec.rb'
- 'spec/services/merge_requests/conflicts/resolve_service_spec.rb'
- 'spec/services/merge_requests/create_service_spec.rb'
- 'spec/services/merge_requests/ff_merge_service_spec.rb'
- 'spec/services/merge_requests/merge_orchestration_service_spec.rb'
- 'spec/services/merge_requests/merge_service_spec.rb'
- 'spec/services/merge_requests/merge_to_ref_service_spec.rb'
- 'spec/services/merge_requests/mergeability/detailed_merge_status_service_spec.rb'
- 'spec/services/merge_requests/mergeability_check_service_spec.rb'
- 'spec/services/merge_requests/rebase_service_spec.rb'
- 'spec/services/merge_requests/refresh_service_spec.rb'
- 'spec/services/merge_requests/reload_diffs_service_spec.rb'
- 'spec/services/merge_requests/squash_service_spec.rb'
- 'spec/services/merge_requests/update_assignees_service_spec.rb'
- 'spec/services/merge_requests/update_reviewers_service_spec.rb'
- 'spec/services/merge_requests/update_service_spec.rb'
- 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb'
- 'spec/services/note_summary_spec.rb'
- 'spec/services/notes/build_service_spec.rb'
- 'spec/services/notes/copy_service_spec.rb'
- 'spec/services/notes/create_service_spec.rb'
- 'spec/services/notes/destroy_service_spec.rb'
- 'spec/services/notes/render_service_spec.rb'
- 'spec/services/notification_service_spec.rb'
- 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb'
- 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb'
@ -2682,48 +2374,10 @@ Layout/ArgumentAlignment:
- 'spec/services/work_items/task_list_reference_removal_service_spec.rb'
- 'spec/services/work_items/widgets/description_service/update_service_spec.rb'
- 'spec/sidekiq/cron/job_gem_dependency_spec.rb'
- 'spec/support/import_export/export_file_helper.rb'
- 'spec/support/redis/redis_shared_examples.rb'
- 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb'
- 'spec/support/shared_contexts/design_management_shared_contexts.rb'
- 'spec/support/shared_contexts/merge_request_create_shared_context.rb'
- 'spec/support/shared_contexts/merge_request_edit_shared_context.rb'
- 'spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb'
- 'spec/support/shared_contexts/requests/api/graphql/releases_and_group_releases_shared_context.rb'
- 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb'
- 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb'
- 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb'
- 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb'
- 'spec/support/shared_examples/graphql/members_shared_examples.rb'
- 'spec/support/shared_examples/graphql/mutation_shared_examples.rb'
- 'spec/support/shared_examples/graphql/mutations/set_assignees_shared_examples.rb'
- 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb'
- 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb'
- 'spec/support/shared_examples/integrations/integration_settings_form.rb'
- 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/gitaly_client_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/project_search_results_shared_examples.rb'
- 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb'
- 'spec/support/shared_examples/models/chat_integration_shared_examples.rb'
- 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb'
- 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb'
- 'spec/support/shared_examples/models/member_shared_examples.rb'
- 'spec/support/shared_examples/observability/csp_shared_examples.rb'
- 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb'
- 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb'
- 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/mutations/snippets_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/projects/branch_protections/access_level_request_examples.rb'
- 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/packages_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/time_tracking_shared_examples.rb'
- 'spec/support/shared_examples/requests/graphql_shared_examples.rb'
- 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb'
- 'spec/support/shared_examples/views/pipeline_status_changes_email.rb'
- 'spec/tasks/cache/clear/redis_spec.rb'
- 'spec/tasks/gitlab/cleanup_rake_spec.rb'
- 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb'

4
.rubocop_todo/layout/array_alignment.yml
View file

@ -4,7 +4,6 @@ Layout/ArrayAlignment:
Details: grace period
Exclude:
- 'app/controllers/admin/application_settings_controller.rb'
- 'app/controllers/admin/broadcast_messages_controller.rb'
- 'app/controllers/admin/plan_limits_controller.rb'
- 'app/controllers/concerns/observability/content_security_policy.rb'
- 'app/controllers/profiles_controller.rb'
@ -101,7 +100,6 @@ Layout/ArrayAlignment:
- 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
- 'ee/spec/lib/audit/project_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
- 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb'
@ -184,7 +182,6 @@ Layout/ArrayAlignment:
- 'lib/gitlab/metrics/samplers/threads_sampler.rb'
- 'lib/gitlab/object_hierarchy.rb'
- 'lib/gitlab/project_authorizations.rb'
- 'lib/gitlab/rack_attack/instrumented_cache_store.rb'
- 'lib/gitlab/reference_extractor.rb'
- 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb'
- 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb'
@ -351,7 +348,6 @@ Layout/ArrayAlignment:
- 'spec/services/spam/spam_verdict_service_spec.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- 'spec/support/helpers/login_helpers.rb'
- 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb'
- 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
- 'spec/support/shared_examples/lib/wikis_api_examples.rb'
- 'spec/support/shared_examples/models/label_note_shared_examples.rb'

62
.rubocop_todo/layout/empty_line_after_magic_comment.yml
View file

@ -40,7 +40,6 @@ Layout/EmptyLineAfterMagicComment:
- 'app/helpers/ci/secure_files_helper.rb'
- 'app/helpers/projects/google_cloud/cloudsql_helper.rb'
- 'app/helpers/projects/ml/experiments_helper.rb'
- 'app/models/airflow.rb'
- 'app/models/ci/job_token/allowlist.rb'
- 'app/models/commit_signatures/gpg_signature.rb'
- 'app/models/commit_signatures/x509_commit_signature.rb'
@ -133,7 +132,6 @@ Layout/EmptyLineAfterMagicComment:
- 'app/workers/concerns/limited_capacity/job_tracker.rb'
- 'app/workers/database/batched_background_migration/ci_database_worker.rb'
- 'app/workers/gitlab/import/stuck_project_import_jobs_worker.rb'
- 'app/workers/gitlab/phabricator_import/import_tasks_worker.rb'
- 'config/application.rb'
- 'config/initializers/fog_core_patch.rb'
- 'config/initializers/rubyzip.rb'
@ -144,11 +142,6 @@ Layout/EmptyLineAfterMagicComment:
- 'danger/ce_ee_vue_templates/Dangerfile'
- 'danger/feature_flag/Dangerfile'
- 'danger/pajamas/Dangerfile'
- 'db/migrate/20210929121516_add_releases_author_id_id_created_at_index.rb'
- 'db/migrate/20211019153615_add_state_to_merge_request_assignees.rb'
- 'db/migrate/20211126113029_add_text_limit_for_static_objects_external_storage_auth_token.rb'
- 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb'
- 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb'
- 'db/migrate/20220506154054_create_sync_namespace_details_trigger.rb'
- 'db/migrate/20220524184149_create_sync_project_namespace_details_trigger.rb'
- 'db/migrate/20220617141347_create_ci_secure_file_states.rb'
@ -162,8 +155,6 @@ Layout/EmptyLineAfterMagicComment:
- 'db/migrate/20221219103007_add_name_to_ml_candidates.rb'
- 'db/migrate/20221219122320_copy_clickhouse_connection_string_to_encrypted_var.rb'
- 'db/migrate/20230111124512_remove_tmp_index_vulns_on_report_type.rb'
- 'db/post_migrate/20211209203820_add_tmp_index_on_report_type.rb'
- 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb'
- 'db/post_migrate/20220412143551_add_partial_index_on_unencrypted_integrations.rb'
- 'db/post_migrate/20220413011328_remove_partial_index_on_unencrypted_integrations.rb'
- 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb'
@ -215,7 +206,6 @@ Layout/EmptyLineAfterMagicComment:
- 'ee/app/models/dependencies/dependency_list_export.rb'
- 'ee/app/models/ee/issue_assignee.rb'
- 'ee/app/models/geo/ci_secure_file_state.rb'
- 'ee/app/models/namespaces/storage/cli_notification.rb'
- 'ee/app/models/namespaces/storage/limit_exclusion.rb'
- 'ee/app/models/project_security_setting.rb'
- 'ee/app/models/protected_environment.rb'
@ -337,7 +327,6 @@ Layout/EmptyLineAfterMagicComment:
- 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb'
- 'ee/spec/helpers/ee/auth_helper_spec.rb'
- 'ee/spec/helpers/ee/geo_helper_spec.rb'
- 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb'
- 'ee/spec/helpers/ee/invite_members_helper_spec.rb'
- 'ee/spec/helpers/ee/namespaces_helper_spec.rb'
- 'ee/spec/helpers/ee/saml_providers_helper_spec.rb'
@ -435,7 +424,6 @@ Layout/EmptyLineAfterMagicComment:
- 'ee/spec/services/wikis/create_attachment_service_spec.rb'
- 'ee/spec/support/helpers/board_helpers.rb'
- 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb'
- 'ee/spec/workers/integrations/slack_event_worker_spec.rb'
- 'ee/spec/workers/namespaces/free_user_cap/backfill_notification_jobs_worker_spec.rb'
- 'lib/api/commits.rb'
- 'lib/api/concerns/packages/nuget_endpoints.rb'
@ -452,11 +440,7 @@ Layout/EmptyLineAfterMagicComment:
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_project_import_level.rb'
- 'lib/gitlab/background_migration/backfill_project_namespace_details.rb'
- 'lib/gitlab/background_migration/drop_invalid_security_findings.rb'
- 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb'
- 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb'
- 'lib/gitlab/ci/secure_files/mobile_provision.rb'
- 'lib/gitlab/cleanup/remote_uploads.rb'
- 'lib/gitlab/database/migrations/background_migration_helpers.rb'
@ -475,25 +459,12 @@ Layout/EmptyLineAfterMagicComment:
- 'lib/gitlab/import_export/recursive_merge_folders.rb'
- 'lib/gitlab/import_export/shared.rb'
- 'lib/gitlab/json_logger.rb'
- 'lib/gitlab/kubernetes/helm/v2/certificate.rb'
- 'lib/gitlab/lfs/client.rb'
- 'lib/gitlab/merge_requests/mergeability/check_result.rb'
- 'lib/gitlab/merge_requests/mergeability/redis_interface.rb'
- 'lib/gitlab/merge_requests/mergeability/results_store.rb'
- 'lib/gitlab/merge_requests/message_generator.rb'
- 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb'
- 'lib/gitlab/phabricator_import/cache/map.rb'
- 'lib/gitlab/phabricator_import/conduit.rb'
- 'lib/gitlab/phabricator_import/conduit/client.rb'
- 'lib/gitlab/phabricator_import/conduit/maniphest.rb'
- 'lib/gitlab/phabricator_import/conduit/pagination.rb'
- 'lib/gitlab/phabricator_import/conduit/response.rb'
- 'lib/gitlab/phabricator_import/conduit/tasks_response.rb'
- 'lib/gitlab/phabricator_import/conduit/user.rb'
- 'lib/gitlab/phabricator_import/issues/importer.rb'
- 'lib/gitlab/phabricator_import/issues/task_importer.rb'
- 'lib/gitlab/phabricator_import/representation/task.rb'
- 'lib/gitlab/phabricator_import/worker_state.rb'
- 'lib/gitlab/relative_positioning/gap.rb'
- 'lib/gitlab/safe_device_detector.rb'
- 'lib/gitlab/spamcheck/client.rb'
@ -550,7 +521,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/controllers/application_controller_spec.rb'
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb'
- 'spec/factories/airflow/dags.rb'
- 'spec/factories/alert_management/alerts.rb'
- 'spec/factories/draft_note.rb'
- 'spec/factories/ml/candidates.rb'
@ -586,18 +556,13 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/graphql/types/label_type_spec.rb'
- 'spec/graphql/types/users/email_type_spec.rb'
- 'spec/graphql/types/users/namespace_commit_email_type_spec.rb'
- 'spec/helpers/analytics/cycle_analytics_helper_spec.rb'
- 'spec/helpers/keyset_helper_spec.rb'
- 'spec/helpers/sorting_helper_spec.rb'
- 'spec/initializers/mail_encoding_patch_spec.rb'
- 'spec/lib/constraints/admin_constrainer_spec.rb'
- 'spec/lib/gitlab/analytics/date_filler_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb'
- 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb'
- 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb'
- 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/class_attributes_spec.rb'
- 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb'
@ -611,7 +576,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb'
- 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb'
- 'spec/lib/gitlab/database/migrations/runner_spec.rb'
- 'spec/lib/gitlab/database/schema_validation/index_spec.rb'
- 'spec/lib/gitlab/file_markdown_link_builder_spec.rb'
- 'spec/lib/gitlab/file_type_detection_spec.rb'
- 'spec/lib/gitlab/git/patches/collection_spec.rb'
@ -631,7 +595,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/lib/gitlab/json_cache_spec.rb'
- 'spec/lib/gitlab/jwt_token_spec.rb'
- 'spec/lib/gitlab/kroki_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb'
- 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb'
- 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb'
- 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb'
@ -640,15 +603,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/lib/gitlab/metrics/rails_slis_spec.rb'
- 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb'
- 'spec/lib/gitlab/middleware/request_context_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/client_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/users_response_spec.rb'
- 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb'
- 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb'
- 'spec/lib/gitlab/phabricator_import/project_creator_spec.rb'
- 'spec/lib/gitlab/request_endpoints_spec.rb'
- 'spec/lib/gitlab/slash_commands/presenters/issue_new_spec.rb'
- 'spec/lib/gitlab/ssh/commit_spec.rb'
@ -658,17 +612,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/lib/gitlab/x509/commit_spec.rb'
- 'spec/lib/gitlab/x509/tag_spec.rb'
- 'spec/lib/security/report_schema_version_matcher_spec.rb'
- 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb'
- 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb'
- 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb'
- 'spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/migrations/20220202105733_delete_service_template_records_spec.rb'
- 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb'
- 'spec/migrations/20220222192525_remove_null_releases_spec.rb'
- 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb'
- 'spec/migrations/20220322132242_update_pages_onboarding_state_spec.rb'
- 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb'
- 'spec/models/analytics/cycle_analytics/aggregation_spec.rb'
@ -845,7 +788,6 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/support/helpers/fake_webauthn_device.rb'
- 'spec/support/helpers/features/access_token_helpers.rb'
- 'spec/support/helpers/features/iteration_helpers.rb'
- 'spec/support/helpers/features/list_rows_helpers.rb'
- 'spec/support/helpers/features/responsive_table_helpers.rb'
- 'spec/support/helpers/features/two_factor_helpers.rb'
- 'spec/support/helpers/lfs_http_helpers.rb'
@ -877,12 +819,10 @@ Layout/EmptyLineAfterMagicComment:
- 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb'
- 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb'
- 'spec/workers/auto_devops/disable_worker_spec.rb'
- 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb'
- 'spec/workers/gitlab/phabricator_import/import_tasks_worker_spec.rb'
- 'spec/workers/integrations/execute_worker_spec.rb'
- 'spec/workers/partition_creation_worker_spec.rb'
- 'spec/workers/projects/delete_branch_worker_spec.rb'
- 'spec/workers/web_hook_worker_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/analytics_instrumentation.rb'
- 'tooling/danger/suggestor.rb'
- 'tooling/docs/deprecation_handling.rb'

1
.rubocop_todo/layout/first_array_element_indentation.yml
View file

@ -3,7 +3,6 @@
Layout/FirstArrayElementIndentation:
Details: grace period
Exclude:
- 'app/controllers/admin/broadcast_messages_controller.rb'
- 'app/controllers/admin/plan_limits_controller.rb'
- 'app/finders/user_groups_counter.rb'
- 'app/helpers/search_helper.rb'

4
.rubocop_todo/layout/first_hash_element_indentation.yml
View file

@ -23,7 +23,6 @@ Layout/FirstHashElementIndentation:
- 'app/helpers/tags_helper.rb'
- 'app/models/application_setting.rb'
- 'app/models/ci/build_metadata.rb'
- 'app/models/clusters/applications/crossplane.rb'
- 'app/models/concerns/has_wiki_page_slug_attributes.rb'
- 'app/models/concerns/subscribable.rb'
- 'app/models/concerns/taskable.rb'
@ -199,8 +198,6 @@ Layout/FirstHashElementIndentation:
- 'spec/lib/container_registry/client_spec.rb'
- 'spec/lib/gitlab/application_rate_limiter_spec.rb'
- 'spec/lib/gitlab/asciidoc_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/ci/config_spec.rb'
- 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb'
@ -220,7 +217,6 @@ Layout/FirstHashElementIndentation:
- 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
- 'spec/lib/gitlab/instrumentation_helper_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb'
- 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb'
- 'spec/lib/gitlab/workhorse_spec.rb'
- 'spec/lib/mattermost/team_spec.rb'

1
.rubocop_todo/layout/line_continuation_leading_space.yml
View file

@ -20,7 +20,6 @@ Layout/LineContinuationLeadingSpace:
- 'ee/app/services/system_notes/epics_service.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
- 'ee/lib/ee/gitlab/git_access.rb'
- 'ee/lib/slack/block_kit/app_home_opened.rb'
- 'ee/lib/tasks/gitlab/geo.rake'
- 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb'
- 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb'

3
.rubocop_todo/layout/line_continuation_spacing.yml
View file

@ -16,7 +16,6 @@ Layout/LineContinuationSpacing:
- 'app/models/environment.rb'
- 'app/models/integrations/base_third_party_wiki.rb'
- 'app/models/integrations/teamcity.rb'
- 'app/models/members/member_role.rb'
- 'app/models/work_items/parent_link.rb'
- 'app/services/feature_flags/update_service.rb'
- 'app/services/issues/build_service.rb'
@ -151,7 +150,6 @@ Layout/LineContinuationSpacing:
- 'spec/features/projects/files/user_edits_files_spec.rb'
- 'spec/features/projects/files/user_replaces_files_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
- 'spec/features/u2f_spec.rb'
- 'spec/features/users/email_verification_on_login_spec.rb'
- 'spec/features/users/login_spec.rb'
- 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb'
@ -181,7 +179,6 @@ Layout/LineContinuationSpacing:
- 'spec/models/integrations/chat_message/push_message_spec.rb'
- 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/members/member_role_spec.rb'
- 'spec/models/operations/feature_flags_client_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb'

5
.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
View file

@ -26,7 +26,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'app/models/concerns/spammable.rb'
- 'app/models/environment.rb'
- 'app/models/integrations/pivotaltracker.rb'
- 'app/models/members/member_role.rb'
- 'app/models/merge_request_diff_commit.rb'
- 'app/models/postgresql/replication_slot.rb'
- 'app/presenters/packages/npm/package_presenter.rb'
@ -82,7 +81,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/lib/ee/gitlab/git_access.rb'
- 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb'
- 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
- 'ee/lib/slack/block_kit/app_home_opened.rb'
- 'ee/lib/tasks/gitlab/geo.rake'
- 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- 'ee/spec/controllers/groups/group_members_controller_spec.rb'
@ -295,7 +293,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/models/integrations/chat_message/push_message_spec.rb'
- 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/members/member_role_spec.rb'
- 'spec/models/operations/feature_flags_client_spec.rb'
- 'spec/models/ssh_host_key_spec.rb'
- 'spec/presenters/ci/pipeline_presenter_spec.rb'
@ -307,7 +304,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb'
- 'spec/requests/api/releases_spec.rb'
- 'spec/requests/api/users_spec.rb'
- 'spec/requests/self_monitoring_project_spec.rb'
- 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb'
- 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb'
- 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb'
@ -331,7 +327,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb'
- 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb'
- 'spec/uploaders/file_mover_spec.rb'
- 'spec/views/devise/shared/_signup_box.html.haml_spec.rb'
- 'spec/views/projects/pages/show.html.haml_spec.rb'

266
.rubocop_todo/layout/line_length.yml
View file

@ -214,7 +214,6 @@ Layout/LineLength:
- 'app/graphql/types/root_storage_statistics_type.rb'
- 'app/graphql/types/snippets/visibility_scopes_enum.rb'
- 'app/graphql/types/todo_action_enum.rb'
- 'app/helpers/analytics/cycle_analytics_helper.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/award_emoji_helper.rb'
@ -301,8 +300,6 @@ Layout/LineLength:
- 'app/models/ci/runner.rb'
- 'app/models/ci/unit_test.rb'
- 'app/models/clusters/agent.rb'
- 'app/models/clusters/applications/knative.rb'
- 'app/models/clusters/applications/prometheus.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/commit_range.rb'
- 'app/models/commit_status.rb'
@ -444,7 +441,6 @@ Layout/LineLength:
- 'app/models/releases/link.rb'
- 'app/models/remote_mirror.rb'
- 'app/models/repository.rb'
- 'app/models/serverless/domain.rb'
- 'app/models/service_desk_setting.rb'
- 'app/models/suggestion.rb'
- 'app/models/todo.rb'
@ -747,149 +743,8 @@ Layout/LineLength:
- 'danger/roulette/Dangerfile'
- 'danger/vue_shared_documentation/Dangerfile'
- 'danger/z_metadata/Dangerfile'
- 'db/migrate/20210830085837_add_throttle_authenticated_git_lfs_columns.rb'
- 'db/migrate/20210831203408_upsert_base_work_item_types.rb'
- 'db/migrate/20210908140437_add_sidekiq_limits_to_application_settings.rb'
- 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb'
- 'db/migrate/20210910015047_add_app_settings_dep_proxy_ttl_worker_capacity_check_constraint.rb'
- 'db/migrate/20210913224558_update_dependency_proxy_manifests_uniqueness_constraint.rb'
- 'db/migrate/20210914145810_add_throttle_deprecated_api_columns.rb'
- 'db/migrate/20210917153905_remove_pipeline_fk_from_packages_package_file_build_infos.rb'
- 'db/migrate/20210921063924_index_labels_using_varchar_pattern_ops.rb'
- 'db/migrate/20210928155022_improve_index_for_error_tracking.rb'
- 'db/migrate/20210929031049_add_unique_index_phone_on_user_details.rb'
- 'db/migrate/20210929115340_add_security_policy_configurations_management_project_id_foreign_key.rb'
- 'db/migrate/20210930081208_fix_deprecated_api_throttle_defaults.rb'
- 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb'
- 'db/migrate/20211006103122_change_helm_channel_length.rb'
- 'db/migrate/20211011004242_create_content_blocked_states.rb'
- 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb'
- 'db/migrate/20211013192749_add_states_into_approval_project_rules.rb'
- 'db/migrate/20211028132247_create_packages_npm_metadata.rb'
- 'db/migrate/20211101165656_create_upload_states.rb'
- 'db/migrate/20211110015252_add_agent_activity_events_foreign_keys.rb'
- 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb'
- 'db/migrate/20211116093739_add_foreign_key_to_incident_management_timeline_events_on_updated_by_user.rb'
- 'db/migrate/20211117174209_create_vulnerability_reads.rb'
- 'db/migrate/20211119111006_create_job_artifact_states.rb'
- 'db/migrate/20211119154221_create_pages_deployment_states.rb'
- 'db/migrate/20211126042235_add_sequence_column_to_sprints_table.rb'
- 'db/migrate/20211126115449_encrypt_static_objects_external_storage_auth_token.rb'
- 'db/migrate/20211130151724_add_foreign_key_to_incident_management_timeline_events_on_note.rb'
- 'db/migrate/20211130205719_add_uniqueness_for_evidence_occurrence_id.rb'
- 'db/migrate/20211201143042_create_lfs_object_states.rb'
- 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb'
- 'db/migrate/20211207154413_add_ci_runners_index_on_created_at_where_active_is_false.rb'
- 'db/migrate/20211207154414_add_ci_runners_index_on_contacted_at_where_active_is_false.rb'
- 'db/migrate/20211216135651_add_index_to_cluster_agent_id.rb'
- 'db/migrate/20211217050753_remove_artifacts_archive_id_foreign_key_from_project_pages_metadata.rb'
- 'db/migrate/20220106230629_add_registry_migration_application_settings.rb'
- 'db/migrate/20220107091629_add_route_namespace_index.rb'
- 'db/migrate/20220111154951_add_index_to_ci_runners_token_expires_at.rb'
- 'db/migrate/20220112232605_add_member_namespace_index.rb'
- 'db/migrate/20220113125401_create_security_trainings.rb'
- 'db/migrate/20220118155846_add_runner_token_expiration_interval_settings_to_application_settings.rb'
- 'db/migrate/20220118155847_add_runner_token_expiration_interval_settings_to_namespace_settings.rb'
- 'db/migrate/20220119094023_add_unique_index_to_aed_verification_token.rb'
- 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb'
- 'db/migrate/20220120211831_temp_index_for_group_namespace_member_backfill.rb'
- 'db/migrate/20220125122725_add_topics_non_private_projects_count_index.rb'
- 'db/migrate/20220202115350_add_migration_indexes_to_container_repositories.rb'
- 'db/migrate/20220203091304_fix_unique_packages_index_excluding_pending_destruction_status.rb'
- 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb'
- 'db/migrate/20220207083129_add_users_get_by_id_limit_to_application_setting.rb'
- 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb'
- 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb'
- 'db/migrate/20220216110023_create_saved_replies.rb'
- 'db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb'
- 'db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb'
- 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb'
- 'db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb'
- 'db/migrate/20220304062107_remove_unique_index_for_sprints_on_project_id_and_title.rb'
- 'db/migrate/20220310101118_update_holder_name_limit.rb'
- 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb'
- 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb'
- 'db/post_migrate/20210901184511_prepare_async_indexes_for_ci_builds.rb'
- 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb'
- 'db/post_migrate/20210923135909_remove_delayed_project_removal_from_namespaces.rb'
- 'db/post_migrate/20210927153807_update_issues_relative_position_indexes.rb'
- 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb'
- 'db/post_migrate/20211012155931_remove_schedule_and_status_from_pending_alert_escalations.rb'
- 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb'
- 'db/post_migrate/20211031152417_add_indexes_to_issue_stage_events.rb'
- 'db/post_migrate/20211031154919_add_indexes_to_merge_request_stage_events.rb'
- 'db/post_migrate/20211104165220_remove_vulnerability_finding_links.rb'
- 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb'
- 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb'
- 'db/post_migrate/20211118194239_drop_invalid_remediations.rb'
- 'db/post_migrate/20211201101541_drop_clusters_applications_runners_ci_runners_fk.rb'
- 'db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb'
- 'db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb'
- 'db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb'
- 'db/post_migrate/20211210140000_add_temporary_static_object_token_index.rb'
- 'db/post_migrate/20211210173137_remove_vulnerability_finding_links_again.rb'
- 'db/post_migrate/20211213102111_drop_ci_pipelines_mr_metrics_fk.rb'
- 'db/post_migrate/20211220120402_add_index_on_ci_pipelines_user_id_id_failure_reason.rb'
- 'db/post_migrate/20220104060049_remove_foreign_key_ci_group_variables_group_id.rb'
- 'db/post_migrate/20220105020514_remove_ci_minutes_additional_packs_namespace_id_foreign_key_constraint.rb'
- 'db/post_migrate/20220106231518_remove_foreign_key_ci_daily_build_group_report_results_group_id.rb'
- 'db/post_migrate/20220106233459_remove_foreign_key_ci_pending_builds_namespace_id.rb'
- 'db/post_migrate/20220106235626_remove_foreign_key_ci_runner_namespaces_namespace_id.rb'
- 'db/post_migrate/20220110224913_remove_dast_scanner_profiles_builds_ci_build_id_fk.rb'
- 'db/post_migrate/20220110231420_remove_requirements_management_test_reports_build_id_fk.rb'
- 'db/post_migrate/20220110233155_remove_dast_site_profiles_builds_ci_build_id_fk.rb'
- 'db/post_migrate/20220111002756_remove_security_scans_build_id_fk.rb'
- 'db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb'
- 'db/post_migrate/20220112015940_remove_projects_ci_running_builds_fk.rb'
- 'db/post_migrate/20220112230642_remove_projects_ci_unit_tests_project_id_fk.rb'
- 'db/post_migrate/20220112232723_remove_projects_ci_daily_build_group_report_results_project_id_fk.rb'
- 'db/post_migrate/20220113013319_remove_projects_ci_freeze_periods_project_id_fk.rb'
- 'db/post_migrate/20220113014438_remove_projects_ci_resource_groups_project_id_fk.rb'
- 'db/post_migrate/20220113015830_remove_projects_ci_build_report_results_project_id_fk.rb'
- 'db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb'
- 'db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb'
- 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb'
- 'db/post_migrate/20220119141736_remove_projects_ci_pipeline_artifacts_project_id_fk.rb'
- 'db/post_migrate/20220119143130_remove_projects_ci_sources_pipelines_source_project_id_fk.rb'
- 'db/post_migrate/20220119144458_remove_users_ci_triggers_owner_id_fk.rb'
- 'db/post_migrate/20220119151221_remove_merge_requests_ci_pipelines_merge_request_id_fk.rb'
- 'db/post_migrate/20220119153706_remove_ci_pipelines_merge_trains_pipeline_id_fk.rb'
- 'db/post_migrate/20220119154442_remove_ci_pipelines_merge_requests_head_pipeline_id_fk.rb'
- 'db/post_migrate/20220119193130_remove_ci_pipelines_dast_profiles_pipelines_ci_pipeline_id_fk.rb'
- 'db/post_migrate/20220119201340_remove_ci_pipelines_vulnerability_statistics_latest_pipeline_id_fk.rb'
- 'db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb'
- 'db/post_migrate/20220120123700_add_tmp_index_routes_id_for_namespaces.rb'
- 'db/post_migrate/20220121214752_remove_projects_ci_stages_project_id_fk.rb'
- 'db/post_migrate/20220121221651_remove_projects_ci_variables_project_id_fk.rb'
- 'db/post_migrate/20220124130028_dedup_runner_projects.rb'
- 'db/post_migrate/20220124145019_remove_projects_external_pull_requests_project_id_fk.rb'
- 'db/post_migrate/20220124151456_remove_projects_ci_triggers_project_id_fk.rb'
- 'db/post_migrate/20220124151949_remove_projects_ci_runner_projects_project_id_fk.rb'
- 'db/post_migrate/20220124152824_remove_projects_ci_subscriptions_projects_downstream_project_id_fk.rb'
- 'db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb'
- 'db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb'
- 'db/post_migrate/20220124184338_remove_projects_ci_subscriptions_projects_upstream_project_id_fk.rb'
- 'db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb'
- 'db/post_migrate/20220124214131_remove_projects_ci_refs_project_id_fk.rb'
- 'db/post_migrate/20220124215857_remove_projects_ci_job_token_project_scope_links_source_project_id_fk.rb'
- 'db/post_migrate/20220124221521_remove_projects_ci_project_monthly_usages_project_id_fk.rb'
- 'db/post_migrate/20220125083520_remove_ci_pipelines_dast_site_profiles_pipelines_ci_pipeline_id_fk.rb'
- 'db/post_migrate/20220125084348_remove_ci_pipelines_vulnerability_feedback_pipeline_id_fk.rb'
- 'db/post_migrate/20220126201752_remove_projects_ci_job_token_project_scope_links_target_project_id_fk.rb'
- 'db/post_migrate/20220126202654_remove_projects_ci_sources_projects_source_project_id_fk.rb'
- 'db/post_migrate/20220126203421_remove_projects_ci_pipeline_schedules_project_id_fk.rb'
- 'db/post_migrate/20220126210021_remove_projects_ci_builds_project_id_fk.rb'
- 'db/post_migrate/20220126210657_remove_projects_ci_pipelines_project_id_fk.rb'
- 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb'
- 'db/post_migrate/20220131000000_index_job_artifacts_on_trace_type_and_expire_at.rb'
- 'db/post_migrate/20220201193033_add_unique_index_to_vulnerability_finding_links_with_truncate.rb'
- 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb'
- 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb'
- 'db/post_migrate/20220224000000_async_build_trace_expire_at_index.rb'
- 'db/post_migrate/20220305223212_add_security_training_providers.rb'
- 'db/post_migrate/20220307192610_remove_duplicate_project_tag_releases.rb'
- 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb'
- 'db/post_migrate/20220316102902_add_user_foreign_key_to_deploy_tokens.rb'
- 'db/post_migrate/20220317161914_remove_ci_runners_ci_builds_runner_id_fk.rb'
@ -1026,7 +881,6 @@ Layout/LineLength:
- 'ee/app/helpers/ee/button_helper.rb'
- 'ee/app/helpers/ee/feature_flags_helper.rb'
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb'
- 'ee/app/helpers/ee/groups/settings_helper.rb'
- 'ee/app/helpers/ee/groups_helper.rb'
- 'ee/app/helpers/ee/import_helper.rb'
@ -1327,7 +1181,6 @@ Layout/LineLength:
- 'ee/app/workers/repository_update_mirror_worker.rb'
- 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb'
- 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'ee/config/routes/group.rb'
- 'ee/config/routes/project.rb'
- 'ee/db/fixtures/development/20_burndown.rb'
@ -1412,14 +1265,9 @@ Layout/LineLength:
- 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb'
- 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb'
- 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
- 'ee/lib/ee/gitlab/ci/config_ee.rb'
@ -1614,7 +1462,6 @@ Layout/LineLength:
- 'ee/spec/features/groups/security/compliance_dashboards_spec.rb'
- 'ee/spec/features/groups/sso_spec.rb'
- 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb'
- 'ee/spec/features/invites_spec.rb'
- 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb'
- 'ee/spec/features/issues/form_spec.rb'
- 'ee/spec/features/labels_hierarchy_spec.rb'
@ -1840,16 +1687,10 @@ Layout/LineLength:
- 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb'
@ -1910,8 +1751,6 @@ Layout/LineLength:
- 'ee/spec/lib/gitlab/auth/ldap/user_spec.rb'
- 'ee/spec/lib/gitlab/auth/saml/user_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'ee/spec/lib/gitlab/checks/diff_check_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb'
- 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb'
@ -2010,14 +1849,9 @@ Layout/LineLength:
- 'ee/spec/mailers/emails/requirements_spec.rb'
- 'ee/spec/mailers/license_mailer_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/migrations/drop_invalid_remediations_spec.rb'
- 'ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb'
- 'ee/spec/migrations/geo/migrate_lfs_objects_to_separate_registry_spec.rb'
- 'ee/spec/migrations/geo/set_resync_flag_for_retried_projects_spec.rb'
- 'ee/spec/migrations/schedule_populate_test_reports_issue_id_spec.rb'
- 'ee/spec/migrations/schedule_requirements_migration_spec.rb'
- 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb'
- 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb'
- 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb'
@ -2368,7 +2202,6 @@ Layout/LineLength:
- 'ee/spec/services/ci/compare_security_reports_service_spec.rb'
- 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb'
- 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb'
- 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb'
- 'ee/spec/services/ci/minutes/refresh_cached_data_service_spec.rb'
- 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb'
- 'ee/spec/services/ci/process_build_service_spec.rb'
@ -2416,7 +2249,6 @@ Layout/LineLength:
- 'ee/spec/services/epic_issues/create_service_spec.rb'
- 'ee/spec/services/epics/issue_promote_service_spec.rb'
- 'ee/spec/services/epics/related_epic_links/create_service_spec.rb'
- 'ee/spec/services/epics/tree_reorder_service_spec.rb'
- 'ee/spec/services/epics/update_dates_service_spec.rb'
- 'ee/spec/services/epics/update_service_spec.rb'
- 'ee/spec/services/external_status_checks/update_service_spec.rb'
@ -2464,7 +2296,6 @@ Layout/LineLength:
- 'ee/spec/services/jira/requests/issues/list_service_spec.rb'
- 'ee/spec/services/ldap_group_reset_service_spec.rb'
- 'ee/spec/services/members/activate_service_spec.rb'
- 'ee/spec/services/merge_commits/export_csv_service_spec.rb'
- 'ee/spec/services/merge_requests/merge_service_spec.rb'
- 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb'
- 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb'
@ -2788,7 +2619,6 @@ Layout/LineLength:
- 'lib/banzai/filter/markdown_post_escape_filter.rb'
- 'lib/banzai/filter/references/external_issue_reference_filter.rb'
- 'lib/banzai/filter/references/issue_reference_filter.rb'
- 'lib/banzai/filter/references/iteration_reference_filter.rb'
- 'lib/banzai/filter/references/milestone_reference_filter.rb'
- 'lib/banzai/filter/references/reference_filter.rb'
- 'lib/banzai/filter/references/vulnerability_reference_filter.rb'
@ -2842,27 +2672,17 @@ Layout/LineLength:
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_snippet_repositories.rb'
- 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb'
- 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb'
- 'lib/gitlab/background_migration/create_security_setting.rb'
- 'lib/gitlab/background_migration/drop_invalid_remediations.rb'
- 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb'
- 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb'
- 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb'
- 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb'
- 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb'
- 'lib/gitlab/background_migration/populate_namespace_statistics.rb'
- 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'
- 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- 'lib/gitlab/bitbucket_import/importer.rb'
- 'lib/gitlab/bitbucket_server_import/importer.rb'
- 'lib/gitlab/buffered_io.rb'
@ -2956,7 +2776,6 @@ Layout/LineLength:
- 'lib/gitlab/database/with_lock_retries.rb'
- 'lib/gitlab/database/with_lock_retries_outside_transaction.rb'
- 'lib/gitlab/database_importers/instance_administrators/create_group.rb'
- 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb'
- 'lib/gitlab/dependency_linker/base_linker.rb'
- 'lib/gitlab/dependency_linker/go_mod_linker.rb'
- 'lib/gitlab/dependency_linker/go_sum_linker.rb'
@ -3012,8 +2831,6 @@ Layout/LineLength:
- 'lib/gitlab/github_import.rb'
- 'lib/gitlab/github_import/importer/pull_request_importer.rb'
- 'lib/gitlab/github_import/parallel_scheduling.rb'
- 'lib/gitlab/gitlab_import/client.rb'
- 'lib/gitlab/gitlab_import/importer.rb'
- 'lib/gitlab/gl_repository.rb'
- 'lib/gitlab/global_id/deprecations.rb'
- 'lib/gitlab/golang.rb'
@ -3035,7 +2852,6 @@ Layout/LineLength:
- 'lib/gitlab/import_export/file_importer.rb'
- 'lib/gitlab/import_export/group/relation_tree_restorer.rb'
- 'lib/gitlab/import_export/importer.rb'
- 'lib/gitlab/import_export/json/legacy_reader.rb'
- 'lib/gitlab/import_export/json/streaming_serializer.rb'
- 'lib/gitlab/import_export/lfs_saver.rb'
- 'lib/gitlab/import_export/members_mapper.rb'
@ -3051,7 +2867,6 @@ Layout/LineLength:
- 'lib/gitlab/jira_import.rb'
- 'lib/gitlab/jira_import/base_importer.rb'
- 'lib/gitlab/jira_import/issues_importer.rb'
- 'lib/gitlab/kubernetes/helm/pod.rb'
- 'lib/gitlab/kubernetes/kubectl_cmd.rb'
- 'lib/gitlab/kubernetes/pod_cmd.rb'
- 'lib/gitlab/legacy_github_import/project_creator.rb'
@ -3112,7 +2927,6 @@ Layout/LineLength:
- 'lib/gitlab/setup_helper.rb'
- 'lib/gitlab/sidekiq_config.rb'
- 'lib/gitlab/sidekiq_config/worker_router.rb'
- 'lib/gitlab/sidekiq_daemon/memory_killer.rb'
- 'lib/gitlab/sidekiq_daemon/monitor.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb'
- 'lib/gitlab/sidekiq_middleware/server_metrics.rb'
@ -3141,7 +2955,6 @@ Layout/LineLength:
- 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'lib/gitlab/usage_data_counters/issue_activity_unique_counter.rb'
- 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb'
- 'lib/gitlab/usage_data_counters/track_unique_events.rb'
- 'lib/gitlab/utils/delegator_override/error.rb'
- 'lib/gitlab/utils/markdown.rb'
- 'lib/gitlab/utils/override.rb'
@ -3229,7 +3042,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb'
- 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb'
- 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb'
- 'qa/qa/specs/features/api/1_manage/users_spec.rb'
- 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb'
- 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb'
- 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb'
@ -3247,9 +3059,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb'
@ -3292,11 +3101,9 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/3_create/snippet/share_snippet_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/create_first_file_in_web_ide_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/link_to_line_in_web_ide_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_web_ide_from_diff_tab_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb'
@ -3330,8 +3137,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb'
@ -3581,7 +3386,6 @@ Layout/LineLength:
- 'spec/features/groups/settings/repository_spec.rb'
- 'spec/features/groups_spec.rb'
- 'spec/features/ide/static_object_external_storage_csp_spec.rb'
- 'spec/features/invites_spec.rb'
- 'spec/features/issuables/issuable_list_spec.rb'
- 'spec/features/issuables/markdown_references/internal_references_spec.rb'
- 'spec/features/issuables/markdown_references/jira_spec.rb'
@ -3747,7 +3551,6 @@ Layout/LineLength:
- 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb'
- 'spec/finders/ci/runners_finder_spec.rb'
- 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb'
- 'spec/finders/clusters/agent_authorizations_finder_spec.rb'
- 'spec/finders/clusters_finder_spec.rb'
- 'spec/finders/deploy_tokens/tokens_finder_spec.rb'
- 'spec/finders/deployments_finder_spec.rb'
@ -3782,7 +3585,6 @@ Layout/LineLength:
- 'spec/finders/projects_finder_spec.rb'
- 'spec/finders/repositories/tree_finder_spec.rb'
- 'spec/finders/security/security_jobs_finder_spec.rb'
- 'spec/finders/serverless_domain_finder_spec.rb'
- 'spec/finders/snippets_finder_spec.rb'
- 'spec/finders/tags_finder_spec.rb'
- 'spec/finders/todos_finder_spec.rb'
@ -3886,7 +3688,6 @@ Layout/LineLength:
- 'spec/helpers/blob_helper_spec.rb'
- 'spec/helpers/boards_helper_spec.rb'
- 'spec/helpers/branches_helper_spec.rb'
- 'spec/helpers/broadcast_messages_helper_spec.rb'
- 'spec/helpers/button_helper_spec.rb'
- 'spec/helpers/ci/pipeline_editor_helper_spec.rb'
- 'spec/helpers/clusters_helper_spec.rb'
@ -4064,33 +3865,17 @@ Layout/LineLength:
- 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb'
- 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb'
- 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb'
- 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb'
- 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb'
- 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb'
- 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb'
- 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb'
- 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb'
- 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb'
- 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb'
- 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb'
- 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb'
- 'spec/lib/gitlab/bare_repository_import/importer_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb'
- 'spec/lib/gitlab/buffered_io_spec.rb'
@ -4213,7 +3998,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/database/transaction/observer_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
- 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb'
- 'spec/lib/gitlab/database_spec.rb'
- 'spec/lib/gitlab/dependency_linker/package_json_linker_spec.rb'
- 'spec/lib/gitlab/dependency_linker/requirements_txt_linker_spec.rb'
@ -4334,8 +4118,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/kas/client_spec.rb'
- 'spec/lib/gitlab/kas_spec.rb'
- 'spec/lib/gitlab/kubernetes/deployment_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/api_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb'
- 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb'
- 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb'
- 'spec/lib/gitlab/kubernetes/namespace_spec.rb'
@ -4385,12 +4167,8 @@ Layout/LineLength:
- 'spec/lib/gitlab/pagination/offset_pagination_spec.rb'
- 'spec/lib/gitlab/path_regex_spec.rb'
- 'spec/lib/gitlab/performance_bar/redis_adapter_when_peek_enabled_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb'
- 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb'
- 'spec/lib/gitlab/project_search_results_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'
- 'spec/lib/gitlab/prometheus/query_variables_spec.rb'
- 'spec/lib/gitlab/prometheus_client_spec.rb'
@ -4409,9 +4187,7 @@ Layout/LineLength:
- 'spec/lib/gitlab/search/found_blob_spec.rb'
- 'spec/lib/gitlab/search_results_spec.rb'
- 'spec/lib/gitlab/serializer/pagination_spec.rb'
- 'spec/lib/gitlab/serverless/service_spec.rb'
- 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb'
- 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb'
- 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb'
@ -4453,7 +4229,6 @@ Layout/LineLength:
- 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb'
- 'spec/lib/gitlab/usage_data_metrics_spec.rb'
- 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb'
- 'spec/lib/gitlab/usage_data_queries_spec.rb'
@ -4501,38 +4276,10 @@ Layout/LineLength:
- 'spec/mailers/emails/releases_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb'
- 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb'
- 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb'
- 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb'
- 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb'
- 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb'
- 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb'
- 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb'
- 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb'
- 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb'
- 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb'
- 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb'
- 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb'
- 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb'
- 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb'
- 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb'
- 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb'
- 'spec/migrations/active_record/schema_spec.rb'
- 'spec/migrations/backfill_all_project_namespaces_spec.rb'
- 'spec/migrations/backfill_project_namespaces_for_group_spec.rb'
- 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb'
- 'spec/migrations/finalize_project_namespaces_backfill_spec.rb'
- 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb'
- 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb'
- 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb'
- 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb'
- 'spec/migrations/update_invalid_member_states_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/acts_as_taggable_on/tag_spec.rb'
- 'spec/models/acts_as_taggable_on/tagging_spec.rb'
@ -4545,7 +4292,6 @@ Layout/LineLength:
- 'spec/models/award_emoji_spec.rb'
- 'spec/models/blob_viewer/go_mod_spec.rb'
- 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb'
- 'spec/models/broadcast_message_spec.rb'
- 'spec/models/bulk_import_spec.rb'
- 'spec/models/bulk_imports/entity_spec.rb'
- 'spec/models/bulk_imports/file_transfer/project_config_spec.rb'
@ -4563,9 +4309,6 @@ Layout/LineLength:
- 'spec/models/ci/runner_spec.rb'
- 'spec/models/ci/variable_spec.rb'
- 'spec/models/clusters/agent_spec.rb'
- 'spec/models/clusters/applications/ingress_spec.rb'
- 'spec/models/clusters/applications/knative_spec.rb'
- 'spec/models/clusters/applications/prometheus_spec.rb'
- 'spec/models/clusters/cluster_spec.rb'
- 'spec/models/clusters/platforms/kubernetes_spec.rb'
- 'spec/models/commit_spec.rb'
@ -4702,7 +4445,6 @@ Layout/LineLength:
- 'spec/models/resource_state_event_spec.rb'
- 'spec/models/sent_notification_spec.rb'
- 'spec/models/sentry_issue_spec.rb'
- 'spec/models/serverless/domain_spec.rb'
- 'spec/models/service_desk_setting_spec.rb'
- 'spec/models/snippet_input_action_spec.rb'
- 'spec/models/snippet_repository_spec.rb'
@ -5105,7 +4847,6 @@ Layout/LineLength:
- 'spec/services/lfs/push_service_spec.rb'
- 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb'
- 'spec/services/loose_foreign_keys/cleaner_service_spec.rb'
- 'spec/services/members/approve_access_request_service_spec.rb'
- 'spec/services/members/create_service_spec.rb'
- 'spec/services/members/destroy_service_spec.rb'
- 'spec/services/members/invitation_reminder_email_service_spec.rb'
@ -5255,11 +4996,10 @@ Layout/LineLength:
- 'spec/spec_helper.rb'
- 'spec/support/atlassian/jira_connect/schemata.rb'
- 'spec/support/capybara.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/database/prevent_cross_database_modification.rb'
- 'spec/support/database/prevent_cross_joins.rb'
- 'spec/support/db_cleaner.rb'
- 'spec/support/flaky_tests.rb'
- 'spec/support/fast_quarantine.rb'
- 'spec/support/helpers/api_helpers.rb'
- 'spec/support/helpers/board_helpers.rb'
- 'spec/support/helpers/cycle_analytics_helpers.rb'
@ -5474,7 +5214,7 @@ Layout/LineLength:
- 'spec/tasks/migrate/schema_check_rake_spec.rb'
- 'spec/tooling/danger/datateam_spec.rb'
- 'spec/tooling/danger/feature_flag_spec.rb'
- 'spec/tooling/danger/product_intelligence_spec.rb'
- 'spec/tooling/danger/analytics_instrumentation_spec.rb'
- 'spec/tooling/danger/project_helper_spec.rb'
- 'spec/tooling/danger/sidekiq_queues_spec.rb'
- 'spec/tooling/lib/tooling/kubernetes_client_spec.rb'
@ -5589,7 +5329,7 @@ Layout/LineLength:
- 'spec/workers/todos_destroyer/confidential_issue_worker_spec.rb'
- 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb'
- 'spec/workers/users/deactivate_dormant_users_worker_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/analytics_instrumentation.rb'
- 'tooling/danger/project_helper.rb'
- 'tooling/danger/specs.rb'
- 'tooling/graphql/docs/helper.rb'

6
.rubocop_todo/layout/parameter_alignment.yml
View file

@ -3,15 +3,9 @@
Layout/ParameterAlignment:
Details: grace period
Exclude:
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'lib/gitlab/cross_project_access.rb'
- 'lib/gitlab/data_builder/push.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb'
- 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/support/helpers/content_security_policy_helpers.rb'
- 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb'
- 'spec/support/helpers/repo_helpers.rb'

7
.rubocop_todo/layout/space_in_lambda_literal.yml
View file

@ -20,7 +20,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/models/clusters/agent.rb'
- 'app/models/clusters/agent_token.rb'
- 'app/models/clusters/agents/activity_event.rb'
- 'app/models/clusters/applications/knative.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/kubernetes_namespace.rb'
- 'app/models/commit_status.rb'
@ -36,7 +35,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/mentionable.rb'
- 'app/models/concerns/milestoneable.rb'
- 'app/models/concerns/protected_ref_access.rb'
- 'app/models/concerns/reactive_caching.rb'
- 'app/models/concerns/shardable.rb'
- 'app/models/concerns/timebox.rb'
@ -119,7 +117,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/serializers/ci/job_entity.rb'
- 'app/serializers/ci/pipeline_entity.rb'
- 'app/serializers/ci/trigger_entity.rb'
- 'app/serializers/cluster_application_entity.rb'
- 'app/serializers/concerns/user_status_tooltip.rb'
- 'app/serializers/container_repository_entity.rb'
- 'app/serializers/container_tag_entity.rb'
@ -233,7 +230,6 @@ Layout/SpaceInLambdaLiteral:
- 'ee/app/models/security/scan.rb'
- 'ee/app/models/security/training.rb'
- 'ee/app/models/security/training_provider.rb'
- 'ee/app/models/slack_integration.rb'
- 'ee/app/models/software_license.rb'
- 'ee/app/models/software_license_policy.rb'
- 'ee/app/models/vulnerabilities/external_issue_link.rb'
@ -278,7 +274,6 @@ Layout/SpaceInLambdaLiteral:
- 'ee/app/services/groups/memberships/export_service.rb'
- 'ee/app/services/groups/seat_usage_export_service.rb'
- 'ee/app/services/historical_user_data/csv_service.rb'
- 'ee/app/services/merge_commits/export_csv_service.rb'
- 'ee/app/services/user_permissions/export_service.rb'
- 'ee/app/services/vulnerability_exports/exporters/csv_service.rb'
- 'ee/app/workers/update_all_mirrors_worker.rb'
@ -352,7 +347,6 @@ Layout/SpaceInLambdaLiteral:
- 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/purge_stale_security_scans.rb'
- 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb'
- 'lib/gitlab/cache/helpers.rb'
- 'lib/gitlab/ci/config/entry/inherit/default.rb'
- 'lib/gitlab/ci/config/entry/inherit/variables.rb'
@ -397,7 +391,6 @@ Layout/SpaceInLambdaLiteral:
- 'spec/lib/gitlab/sidekiq_signals_spec.rb'
- 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb'
- 'spec/models/ability_spec.rb'
- 'spec/models/broadcast_message_spec.rb'
- 'spec/models/concerns/participable_spec.rb'
- 'spec/models/merge_request_spec.rb'
- 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb'

6
.rubocop_todo/layout/space_inside_parens.yml
View file

@ -21,7 +21,6 @@ Layout/SpaceInsideParens:
- 'ee/spec/lib/gitlab/search/index_curator_spec.rb'
- 'ee/spec/lib/world_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/migrations/drop_invalid_remediations_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/boards/epic_board_position_spec.rb'
- 'ee/spec/models/dora/change_failure_rate_metric_spec.rb'
@ -68,7 +67,6 @@ Layout/SpaceInsideParens:
- 'ee/spec/services/ee/users/update_service_spec.rb'
- 'ee/spec/services/epic_issues/update_service_spec.rb'
- 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb'
- 'ee/spec/services/epics/tree_reorder_service_spec.rb'
- 'ee/spec/services/geo/container_repository_sync_spec.rb'
- 'ee/spec/services/geo/replication_toggle_request_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb'
@ -98,7 +96,6 @@ Layout/SpaceInsideParens:
- 'spec/helpers/application_helper_spec.rb'
- 'spec/helpers/badges_helper_spec.rb'
- 'spec/helpers/ci/builds_helper_spec.rb'
- 'spec/helpers/ci/runners_helper_spec.rb'
- 'spec/helpers/dev_ops_report_helper_spec.rb'
- 'spec/helpers/git_helper_spec.rb'
- 'spec/helpers/gitlab_routing_helper_spec.rb'
@ -166,7 +163,6 @@ Layout/SpaceInsideParens:
- 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb'
- 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb'
- 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb'
- 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb'
- 'spec/lib/gitlab/redis/cache_spec.rb'
- 'spec/lib/gitlab/redis/queues_spec.rb'
- 'spec/lib/gitlab/redis/shared_state_spec.rb'
@ -184,7 +180,6 @@ Layout/SpaceInsideParens:
- 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb'
- 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb'
- 'spec/mailers/emails/profile_spec.rb'
- 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb'
- 'spec/models/ci/pending_build_spec.rb'
- 'spec/models/ci/running_build_spec.rb'
- 'spec/models/ml/candidate_metric_spec.rb'
@ -226,7 +221,6 @@ Layout/SpaceInsideParens:
- 'spec/views/dashboard/projects/_blank_state_welcome.html.haml_spec.rb'
- 'spec/views/profiles/keys/_form.html.haml_spec.rb'
- 'spec/views/search/_results.html.haml_spec.rb'
- 'spec/views/shared/runners/_runner_details.html.haml_spec.rb'
- 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb'
- 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb'
- 'spec/workers/pipeline_schedule_worker_spec.rb'

1
.rubocop_todo/layout/trailing_whitespace.yml
View file

@ -6,7 +6,6 @@ Layout/TrailingWhitespace:
- 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb'
- 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb'
- 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb'
- 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb'
- 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb'
- 'spec/services/suggestions/apply_service_spec.rb'
- 'spec/support/helpers/x509_helpers.rb'

4
.rubocop_todo/lint/ambiguous_operator_precedence.yml
View file

@ -30,7 +30,6 @@ Lint/AmbiguousOperatorPrecedence:
- 'app/services/issuable_links/create_service.rb'
- 'app/services/issues/relative_position_rebalancing_service.rb'
- 'app/services/jira/requests/base.rb'
- 'app/services/projects/blame_service.rb'
- 'config/initializers/1_settings.rb'
- 'config/initializers/carrierwave_patch.rb'
- 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb'
@ -39,7 +38,6 @@ Lint/AmbiguousOperatorPrecedence:
- 'ee/app/models/geo/upload_registry.rb'
- 'ee/app/models/iterations/cadence.rb'
- 'ee/app/models/license.rb'
- 'ee/app/models/namespaces/storage/root_size.rb'
- 'ee/app/policies/ee/issuable_policy.rb'
- 'ee/app/services/boards/epics/position_create_service.rb'
- 'ee/app/services/geo/registry_consistency_service.rb'
@ -82,7 +80,6 @@ Lint/AmbiguousOperatorPrecedence:
- 'lib/gitlab/template_parser/parser.rb'
- 'lib/gitlab/tree_summary.rb'
- 'lib/gitlab/usage/metrics/name_suggestion.rb'
- 'lib/gitlab/utils/email.rb'
- 'lib/omni_auth/strategies/bitbucket.rb'
- 'qa/qa/ee/page/project/secure/pipeline_security.rb'
- 'qa/qa/resource/api_fabricator.rb'
@ -142,7 +139,6 @@ Lint/AmbiguousOperatorPrecedence:
- 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb'
- 'spec/services/issues/relative_position_rebalancing_service_spec.rb'
- 'spec/services/web_hook_service_spec.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/helpers/dependency_proxy_helpers.rb'
- 'spec/support/models/ci/partitioning_testing/cascade_check.rb'
- 'spec/support/shared_examples/features/sidebar_shared_examples.rb'

2
.rubocop_todo/lint/ambiguous_regexp_literal.yml
View file

@ -62,8 +62,6 @@ Lint/AmbiguousRegexpLiteral:
- 'spec/lib/gitlab/database/partitioning_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb'
- 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'

1
.rubocop_todo/lint/duplicate_branch.yml
View file

@ -33,4 +33,3 @@ Lint/DuplicateBranch:
- 'lib/sidebars/groups/menus/settings_menu.rb'
- 'qa/qa/resource/pipeline.rb'
- 'scripts/rubocop-parse'
- 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb'

1
.rubocop_todo/lint/duplicate_regexp_character_class_element.yml
View file

@ -4,4 +4,3 @@ Lint/DuplicateRegexpCharacterClassElement:
Details: grace period
Exclude:
- 'lib/gitlab/path_regex.rb'
- 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb'

3
.rubocop_todo/lint/empty_block.yml
View file

@ -108,7 +108,6 @@ Lint/EmptyBlock:
- 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb'
- 'spec/lib/gitlab/database/migrations/lock_retries_helpers_spec.rb'
- 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb'
- 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb'
- 'spec/lib/gitlab/database/shared_model_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
@ -137,10 +136,8 @@ Lint/EmptyBlock:
- 'spec/lib/gitlab/patch/prependable_spec.rb'
- 'spec/lib/gitlab/profiler_spec.rb'
- 'spec/lib/gitlab/quick_actions/extractor_spec.rb'
- 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb'
- 'spec/lib/gitlab/search_context/builder_spec.rb'
- 'spec/lib/gitlab/session_spec.rb'
- 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb'
- 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'

16
.rubocop_todo/lint/missing_cop_enable_directive.yml
View file

@ -67,7 +67,6 @@ Lint/MissingCopEnableDirective:
- 'danger/feature_flag/Dangerfile'
- 'danger/pajamas/Dangerfile'
- 'danger/z_metadata/Dangerfile'
- 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb'
- 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb'
- 'ee/app/controllers/ee/admin/dashboard_controller.rb'
- 'ee/app/controllers/ee/admin/groups_controller.rb'
@ -137,7 +136,6 @@ Lint/MissingCopEnableDirective:
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb'
- 'ee/app/workers/groups/export_memberships_worker.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'ee/lib/api/ldap_group_links.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
@ -151,27 +149,16 @@ Lint/MissingCopEnableDirective:
- 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb'
- 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb'
- 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb'
- 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb'
- 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb'
- 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'lib/gitlab/background_migration/purge_stale_security_scans.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb'
- 'lib/gitlab/buffered_io.rb'
- 'lib/gitlab/ci/reports/test_suite_summary.rb'
- 'lib/gitlab/data_builder/push.rb'
@ -195,6 +182,5 @@ Lint/MissingCopEnableDirective:
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/support/capybara.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/google_api/cloud_platform_helpers.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/analytics_instrumentation.rb'

12
.rubocop_todo/lint/redundant_cop_disable_directive.yml
View file

@ -77,13 +77,9 @@ Lint/RedundantCopDisableDirective:
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
- 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb'
- 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb'
- 'db/migrate/20220316022505_create_namespace_details.rb'
- 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb'
- 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb'
- 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb'
- 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb'
- 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb'
@ -151,7 +147,6 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/gitlab/spdx/license.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb'
- 'ee/spec/controllers/concerns/registrations/verification_spec.rb'
- 'ee/spec/controllers/concerns/routable_actions_spec.rb'
- 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
@ -188,12 +183,9 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb'
- 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb'
- 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb'
- 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb'
- 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb'
- 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'
- 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'lib/gitlab/bitbucket_import/importer.rb'
@ -226,7 +218,6 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/git/patches/collection.rb'
- 'lib/gitlab/github_import/markdown_text.rb'
- 'lib/gitlab/github_import/user_finder.rb'
- 'lib/gitlab/gitlab_import/importer.rb'
- 'lib/gitlab/graphql/pagination/keyset/connection.rb'
- 'lib/gitlab/health_checks/metric.rb'
- 'lib/gitlab/health_checks/probes/status.rb'
@ -274,7 +265,6 @@ Lint/RedundantCopDisableDirective:
- 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb'
- 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb'
- 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb'
- 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb'
- 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb'
- 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb'
@ -327,7 +317,7 @@ Lint/RedundantCopDisableDirective:
- 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb'
- 'spec/uploaders/packages/composer/cache_uploader_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/analytics_instrumentation.rb'
- 'tooling/danger/stable_branch.rb'
- 'tooling/danger/suggestor.rb'
- 'tooling/lib/tooling/helm3_client.rb'

12
.rubocop_todo/lint/symbol_conversion.yml
View file

@ -15,17 +15,11 @@ Lint/SymbolConversion:
- 'ee/app/controllers/projects/security/scanned_resources_controller.rb'
- 'ee/app/models/product_analytics/jitsu_authentication.rb'
- 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb'
- 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_closed_service.rb'
- 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_submit_service.rb'
- 'ee/app/services/integrations/slack_interactions/slack_block_actions/incident_management/project_update_handler.rb'
- 'ee/app/services/integrations/slack_options/user_search_handler.rb'
- 'ee/db/fixtures/development/35_merge_request_predictions.rb'
- 'ee/lib/api/analytics/product_analytics.rb'
- 'ee/lib/ee/gitlab/scim/attribute_transform.rb'
- 'ee/lib/elastic/latest/note_class_proxy.rb'
- 'ee/lib/gitlab/applied_ml/suggested_reviewers/client.rb'
- 'ee/lib/slack/block_kit/app_home_opened.rb'
- 'ee/lib/slack/block_kit/incident_management/incident_modal_opened.rb'
- 'ee/spec/controllers/admin/audit_logs_controller_spec.rb'
- 'ee/spec/controllers/groups/audit_events_controller_spec.rb'
- 'ee/spec/controllers/projects/audit_events_controller_spec.rb'
@ -36,7 +30,6 @@ Lint/SymbolConversion:
- 'ee/spec/helpers/ee/environments_helper_spec.rb'
- 'ee/spec/helpers/subscriptions_helper_spec.rb'
- 'ee/spec/lib/arkose/logger_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb'
- 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb'
- 'ee/spec/lib/ee/gitlab/tracking_spec.rb'
@ -54,13 +47,9 @@ Lint/SymbolConversion:
- 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb'
- 'ee/spec/requests/api/integrations/slack/interactions_spec.rb'
- 'ee/spec/requests/api/integrations/slack/options_spec.rb'
- 'ee/spec/requests/api/scim/group_scim_spec.rb'
- 'ee/spec/requests/api/scim/instance_scim_spec.rb'
- 'ee/spec/services/elastic/data_migration_service_spec.rb'
- 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_closed_service_spec.rb'
- 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/support/helpers/subscription_portal_helpers.rb'
- 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb'
@ -126,7 +115,6 @@ Lint/SymbolConversion:
- 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb'
- 'spec/lib/gitlab/harbor/client_spec.rb'
- 'spec/lib/gitlab/harbor/query_spec.rb'
- 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb'
- 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
- 'spec/lib/gitlab/lfs/client_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'

7
.rubocop_todo/lint/triple_quotes.yml
View file

@ -1,7 +0,0 @@
---
# Cop supports --autocorrect.
Lint/TripleQuotes:
Details: grace period
Exclude:
- 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb'
- 'spec/lib/gitlab/database/with_lock_retries_spec.rb'

8
.rubocop_todo/lint/unused_block_argument.yml
View file

@ -33,12 +33,10 @@ Lint/UnusedBlockArgument:
- 'app/models/clusters/cluster.rb'
- 'app/models/concerns/atomic_internal_id.rb'
- 'app/models/concerns/avatarable.rb'
- 'app/models/concerns/enum_with_nil.rb'
- 'app/models/concerns/mentionable.rb'
- 'app/models/customer_relations/organization.rb'
- 'app/models/integration.rb'
- 'app/models/merge_request.rb'
- 'app/models/namespace/root_storage_statistics.rb'
- 'app/models/project.rb'
- 'app/models/projects/build_artifacts_size_refresh.rb'
- 'app/models/service_desk_setting.rb'
@ -87,7 +85,6 @@ Lint/UnusedBlockArgument:
- 'config/initializers/warden.rb'
- 'config/routes/project.rb'
- 'config/routes/wiki.rb'
- 'db/post_migrate/20211117084814_migrate_remaining_u2f_registrations.rb'
- 'ee/app/finders/security/training_providers/kontra_url_finder.rb'
- 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb'
- 'ee/app/graphql/resolvers/incident_management/escalation_policies_resolver.rb'
@ -135,14 +132,12 @@ Lint/UnusedBlockArgument:
- 'ee/spec/factories/projects.rb'
- 'ee/spec/factories/protected_branches.rb'
- 'ee/spec/factories/protected_environments.rb'
- 'ee/spec/factories/slack_integrations.rb'
- 'ee/spec/factories/users.rb'
- 'ee/spec/features/groups/group_settings_spec.rb'
- 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb'
- 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb'
- 'ee/spec/lib/compliance_management/compliance_report/commit_loader_spec.rb'
- 'ee/spec/lib/ee/gitlab/application_context_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb'
- 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb'
- 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb'
- 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb'
@ -334,7 +329,6 @@ Lint/UnusedBlockArgument:
- 'spec/lib/feature_spec.rb'
- 'spec/lib/gitlab/auth/saml/user_spec.rb'
- 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
- 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb'
- 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/logger_spec.rb'
@ -365,7 +359,6 @@ Lint/UnusedBlockArgument:
- 'spec/lib/gitlab/utils/usage_data_spec.rb'
- 'spec/lib/mattermost/session_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/concerns/ci/partitionable/switch_spec.rb'
@ -391,7 +384,6 @@ Lint/UnusedBlockArgument:
- 'spec/services/snippets/update_service_spec.rb'
- 'spec/spec_helper.rb'
- 'spec/support/atlassian/jira_connect/schemata.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/database/prevent_cross_database_modification.rb'
- 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb'
- 'spec/support/helpers/cycle_analytics_helpers.rb'

9
.rubocop_todo/lint/unused_method_argument.yml
View file

@ -105,7 +105,6 @@ Lint/UnusedMethodArgument:
- 'app/models/ci/runner.rb'
- 'app/models/concerns/bulk_insert_safe.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/concerns/ci/partitionable/partitioned_filter.rb'
- 'app/models/concerns/cross_database_modification.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/mentionable.rb'
@ -283,7 +282,6 @@ Lint/UnusedMethodArgument:
- 'ee/app/services/group_saml/identity/destroy_service.rb'
- 'ee/app/services/projects/update_mirror_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
- 'ee/app/services/vulnerabilities/finding_dismiss_service.rb'
- 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb'
- 'ee/app/workers/automation/execute_rule_worker.rb'
- 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb'
@ -326,7 +324,6 @@ Lint/UnusedMethodArgument:
- 'ee/spec/helpers/ee/integrations_helper_spec.rb'
- 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb'
- 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition_spec.rb'
- 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb'
- 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb'
@ -384,7 +381,6 @@ Lint/UnusedMethodArgument:
- 'lib/gitlab/auth/database/authentication.rb'
- 'lib/gitlab/auth/ldap/access.rb'
- 'lib/gitlab/auth/ldap/adapter.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_project_settings.rb'
- 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb'
- 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb'
@ -599,8 +595,6 @@ Lint/UnusedMethodArgument:
- 'spec/lib/banzai/reference_parser/base_parser_spec.rb'
- 'spec/lib/gitlab/auth_spec.rb'
- 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb'
- 'spec/lib/gitlab/background_migration/truncate_overlong_vulnerability_html_titles_spec.rb'
@ -611,9 +605,6 @@ Lint/UnusedMethodArgument:
- 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware_spec.rb'
- 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb'
- 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb'
- 'spec/models/concerns/from_set_operator_spec.rb'
- 'spec/models/concerns/redis_cacheable_spec.rb'
- 'spec/policies/resource_state_event_policy_spec.rb'

1
.rubocop_todo/metrics/cyclomatic_complexity.yml
View file

@ -18,4 +18,3 @@ Metrics/CyclomaticComplexity:
- 'qa/qa/runtime/browser.rb'
- 'qa/qa/support/repeater.rb'
- 'sidekiq_cluster/cli.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'

1
.rubocop_todo/metrics/perceived_complexity.yml
View file

@ -17,4 +17,3 @@ Metrics/PerceivedComplexity:
- 'qa/qa/support/repeater.rb'
- 'rubocop/cop/gitlab/mark_used_feature_flags.rb'
- 'sidekiq_cluster/cli.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'

33
.rubocop_todo/migration/background_migration_base_class.yml
View file

@ -1,78 +1,45 @@
---
Migration/BackgroundMigrationBaseClass:
Exclude:
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb'
- 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb'
- 'lib/gitlab/background_migration/backfill_integrations_type_new.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb'
- 'lib/gitlab/background_migration/backfill_note_discussion_id.rb'
- 'lib/gitlab/background_migration/backfill_project_repositories.rb'
- 'lib/gitlab/background_migration/backfill_project_settings.rb'
- 'lib/gitlab/background_migration/backfill_snippet_repositories.rb'
- 'lib/gitlab/background_migration/backfill_topics_title.rb'
- 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb'
- 'lib/gitlab/background_migration/backfill_user_namespace.rb'
- 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb'
- 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb'
- 'lib/gitlab/background_migration/create_security_setting.rb'
- 'lib/gitlab/background_migration/delete_orphaned_deployments.rb'
- 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb'
- 'lib/gitlab/background_migration/drop_invalid_remediations.rb'
- 'lib/gitlab/background_migration/drop_invalid_security_findings.rb'
- 'lib/gitlab/background_migration/encrypt_integration_properties.rb'
- 'lib/gitlab/background_migration/encrypt_static_object_token.rb'
- 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb'
- 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb'
- 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb'
- 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb'
- 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb'
- 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb'
- 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb'
- 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb'
- 'lib/gitlab/background_migration/legacy_upload_mover.rb'
- 'lib/gitlab/background_migration/legacy_uploads_migrator.rb'
- 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb'
- 'lib/gitlab/background_migration/merge_topics_with_same_name.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb'
- 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb'
- 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb'
- 'lib/gitlab/background_migration/migrate_pages_to_zip_storage.rb'
- 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb'
- 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb'
- 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb'
- 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb'
- 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb'
- 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_namespace_statistics.rb'
- 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb'
- 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb'
- 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb'
- 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'lib/gitlab/background_migration/populate_vulnerability_reads.rb'
- 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
- 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb'
- 'lib/gitlab/background_migration/project_namespaces/models/project.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb'
- 'lib/gitlab/background_migration/remove_vulnerability_finding_links.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users.rb'
- 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb'
- 'lib/gitlab/background_migration/update_timelogs_project_id.rb'
- 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb'
- 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb'

22
.rubocop_todo/migration/background_migration_record.yml
View file

@ -3,46 +3,24 @@ Migration/BackgroundMigrationRecord:
Exclude:
- 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb'
- 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb'
- 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb'
- 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb'
- 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
- 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb'
- 'lib/gitlab/background_migration/backfill_project_repositories.rb'
- 'lib/gitlab/background_migration/backfill_topics_title.rb'
- 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb'
- 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb'
- 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb'
- 'lib/gitlab/background_migration/drop_invalid_security_findings.rb'
- 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb'
- 'lib/gitlab/background_migration/encrypt_integration_properties.rb'
- 'lib/gitlab/background_migration/encrypt_static_object_token.rb'
- 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb'
- 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb'
- 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb'
- 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb'
- 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb'
- 'lib/gitlab/background_migration/merge_topics_with_same_name.rb'
- 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb'
- 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb'
- 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb'
- 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb'
- 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb'
- 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb'
- 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb'
- 'lib/gitlab/background_migration/project_namespaces/models/project.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'
- 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb'
- 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb'

32
.rubocop_todo/migration/background_migrations.yml
View file

@ -1,38 +1,6 @@
---
Migration/BackgroundMigrations:
Exclude:
- 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb'
- 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb'
- 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb'
- 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb'
- 'db/post_migrate/20211005194425_schedule_requirements_migration.rb'
- 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb'
- 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb'
- 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb'
- 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb'
- 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb'
- 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
- 'db/post_migrate/20211118194239_drop_invalid_remediations.rb'
- 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb'
- 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb'
- 'db/post_migrate/20211210140629_encrypt_static_object_token.rb'
- 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb'
- 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb'
- 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb'
- 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb'
- 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb'
- 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb'
- 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb'
- 'db/post_migrate/20220204194347_encrypt_integration_properties.rb'
- 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb'
- 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb'
- 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb'
- 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb'
- 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb'
- 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb'
- 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb'

9
.rubocop_todo/naming/heredoc_delimiter_naming.yml
View file

@ -8,7 +8,6 @@ Naming/HeredocDelimiterNaming:
- 'app/services/packages/debian/generate_distribution_key_service.rb'
- 'app/workers/concerns/limited_capacity/job_tracker.rb'
- 'config/initializers/01_secret_token.rb'
- 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb'
- 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb'
- 'ee/db/geo/migrate/20191010204941_migrate_lfs_objects_to_separate_registry.rb'
- 'ee/lib/api/elasticsearch_indexed_namespaces.rb'
@ -83,14 +82,6 @@ Naming/HeredocDelimiterNaming:
- 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb'
- 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb'
- 'spec/lib/gitlab/import_export/config_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb'
- 'spec/lib/gitlab/patch/database_config_spec.rb'
- 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb'

2
.rubocop_todo/performance/map_compact.yml
View file

@ -69,7 +69,6 @@ Performance/MapCompact:
- 'ee/lib/ee/api/entities/experiment.rb'
- 'ee/lib/ee/gitlab/auth/ldap/person.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb'
- 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'ee/lib/elastic/latest/repository_instance_proxy.rb'
- 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb'
- 'ee/lib/gitlab/ci/parsers/security/dast.rb'
@ -102,7 +101,6 @@ Performance/MapCompact:
- 'lib/gitlab/ci/reports/security/finding.rb'
- 'lib/gitlab/ci/reports/test_suite_summary.rb'
- 'lib/gitlab/database/load_balancing/service_discovery.rb'
- 'lib/gitlab/database/obsolete_ignored_columns.rb'
- 'lib/gitlab/git/commit.rb'
- 'lib/gitlab/git/conflict/file.rb'
- 'lib/gitlab/git/rugged_impl/commit.rb'

2
.rubocop_todo/rails/file_path.yml
View file

@ -78,7 +78,6 @@ Rails/FilePath:
- 'spec/factories/file_uploaders.rb'
- 'spec/factories/packages/debian/distribution_key.rb'
- 'spec/factories/pages_domains.rb'
- 'spec/factories/serverless/domain_cluster.rb'
- 'spec/features/admin/admin_appearance_spec.rb'
- 'spec/features/groups/group_settings_spec.rb'
- 'spec/features/groups/import_export/import_file_spec.rb'
@ -101,7 +100,6 @@ Rails/FilePath:
- 'spec/helpers/blob_helper_spec.rb'
- 'spec/helpers/startupjs_helper_spec.rb'
- 'spec/lib/backup/database_spec.rb'
- 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb'
- 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb'
- 'spec/lib/gitlab/database/schema_migrations/context_spec.rb'

2
.rubocop_todo/rails/inverse_of.yml
View file

@ -6,7 +6,6 @@ Rails/InverseOf:
- 'app/models/ci/sources/pipeline.rb'
- 'app/models/ci/trigger_request.rb'
- 'app/models/ci/unit_test_failure.rb'
- 'app/models/clusters/applications/runner.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/concerns/application_core.rb'
- 'app/models/clusters/integrations/prometheus.rb'
@ -76,7 +75,6 @@ Rails/InverseOf:
- 'ee/app/models/incident_management/escalation_rule.rb'
- 'ee/app/models/incident_management/oncall_participant.rb'
- 'ee/app/models/insight.rb'
- 'ee/app/models/integrations/gitlab_slack_application.rb'
- 'ee/app/models/iteration.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/models/requirements_management/test_report.rb'

16
.rubocop_todo/rails/pluck.yml
View file

@ -28,7 +28,6 @@ Rails/Pluck:
- 'ee/lib/banzai/filter/references/iteration_reference_filter.rb'
- 'ee/lib/ee/gitlab/auth/ldap/person.rb'
- 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
- 'ee/lib/elastic/latest/custom_language_analyzers.rb'
- 'ee/lib/gitlab/search/index_curator.rb'
@ -74,7 +73,6 @@ Rails/Pluck:
- 'ee/spec/requests/api/groups_spec.rb'
- 'ee/spec/requests/api/iterations_spec.rb'
- 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/requests/api/merge_request_approval_rules_spec.rb'
- 'ee/spec/requests/api/project_approval_rules_spec.rb'
- 'ee/spec/requests/api/project_approval_settings_spec.rb'
- 'ee/spec/requests/api/projects_spec.rb'
@ -150,14 +148,11 @@ Rails/Pluck:
- 'spec/controllers/projects/feature_flags_controller_spec.rb'
- 'spec/controllers/projects/issues_controller_spec.rb'
- 'spec/controllers/projects/jobs_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb'
- 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb'
- 'spec/controllers/projects/pipelines/tests_controller_spec.rb'
- 'spec/controllers/projects/releases_controller_spec.rb'
- 'spec/controllers/projects/starrers_controller_spec.rb'
- 'spec/db/schema_spec.rb'
- 'spec/features/issues/csv_spec.rb'
- 'spec/features/merge_request/user_sees_versions_spec.rb'
- 'spec/finders/license_template_finder_spec.rb'
- 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb'
- 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb'
@ -182,7 +177,6 @@ Rails/Pluck:
- 'spec/lib/gitlab/language_detection_spec.rb'
- 'spec/lib/gitlab/lograge/custom_options_spec.rb'
- 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb'
- 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb'
- 'spec/lib/gitlab/relative_positioning/item_context_spec.rb'
- 'spec/lib/gitlab/search/query_spec.rb'
- 'spec/lib/gitlab/sidekiq_config/worker_matcher_spec.rb'
@ -278,15 +272,5 @@ Rails/Pluck:
- 'spec/support/helpers/api_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/matchers/background_migrations_matchers.rb'
- 'spec/support/shared_examples/graphql/mutation_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb'
- 'spec/support/shared_examples/services/packages_shared_examples.rb'
- 'spec/tooling/docs/deprecation_handling_spec.rb'
- 'tooling/docs/deprecation_handling.rb'

5
.rubocop_todo/rails/redundant_foreign_key.yml
View file

@ -14,7 +14,6 @@ Rails/RedundantForeignKey:
- 'app/models/ci/sources/pipeline.rb'
- 'app/models/ci/stage.rb'
- 'app/models/ci/unit_test_failure.rb'
- 'app/models/clusters/applications/runner.rb'
- 'app/models/clusters/concerns/application_core.rb'
- 'app/models/clusters/integrations/prometheus.rb'
- 'app/models/commit_signatures/x509_commit_signature.rb'
@ -59,7 +58,3 @@ Rails/RedundantForeignKey:
- 'ee/app/models/vulnerabilities/finding.rb'
- 'ee/app/models/vulnerabilities/finding_signature.rb'
- 'ee/app/models/vulnerabilities/identifier.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'

4
.rubocop_todo/rails/render_inline.yml
View file

@ -1,4 +0,0 @@
---
Rails/RenderInline:
Exclude:
- 'ee/app/controllers/sitemap_controller.rb'

3
.rubocop_todo/rails/time_zone.yml
View file

@ -44,7 +44,6 @@ Rails/TimeZone:
- 'lib/gitlab/instrumentation_helper.rb'
- 'lib/gitlab/lfs_token.rb'
- 'lib/gitlab/loop_helpers.rb'
- 'lib/gitlab/phabricator_import/representation/task.rb'
- 'lib/gitlab/popen.rb'
- 'lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb'
- 'lib/gitlab/prometheus/queries/matched_metric_query.rb'
@ -97,8 +96,6 @@ Rails/TimeZone:
- 'spec/lib/gitlab/lfs_token_spec.rb'
- 'spec/lib/gitlab/log_timestamp_formatter_spec.rb'
- 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb'
- 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb'
- 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb'

1
.rubocop_todo/rspec/any_instance_of.yml
View file

@ -55,7 +55,6 @@ RSpec/AnyInstanceOf:
- 'ee/spec/services/projects/destroy_service_spec.rb'
- 'ee/spec/services/projects/group_links/destroy_service_spec.rb'
- 'ee/spec/services/projects/update_service_spec.rb'
- 'ee/spec/services/slash_commands/global_slack_handler_spec.rb'
- 'ee/spec/support/helpers/ee/stub_configuration.rb'
- 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb'

84
.rubocop_todo/rspec/avoid_conditional_statements.yml Normal file
View file

@ -0,0 +1,84 @@
---
RSpec/AvoidConditionalStatements:
Details: grace period
Exclude:
- 'ee/spec/features/admin/admin_settings_spec.rb'
- 'ee/spec/features/analytics/code_analytics_spec.rb'
- 'ee/spec/features/billings/billing_plans_spec.rb'
- 'ee/spec/features/boards/scoped_issue_board_spec.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/features/ci_shared_runner_warnings_spec.rb'
- 'ee/spec/features/epic_boards/epic_boards_spec.rb'
- 'ee/spec/features/epics/epic_show_spec.rb'
- 'ee/spec/features/epics/gfm_autocomplete_spec.rb'
- 'ee/spec/features/group_protected_branches_spec.rb'
- 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'
- 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb'
- 'ee/spec/features/groups/iterations/user_views_iteration_spec.rb'
- 'ee/spec/features/incidents/incident_details_spec.rb'
- 'ee/spec/features/issues/user_sees_empty_state_spec.rb'
- 'ee/spec/features/labels_hierarchy_spec.rb'
- 'ee/spec/features/profiles/usage_quotas_spec.rb'
- 'ee/spec/features/projects/analytics/visualization_designer_spec.rb'
- 'ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb'
- 'ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb'
- 'ee/spec/features/projects/settings/issues_settings_spec.rb'
- 'ee/spec/features/projects_spec.rb'
- 'ee/spec/features/registrations/email_confirmation_spec.rb'
- 'ee/spec/features/registrations/identity_verification_spec.rb'
- 'ee/spec/features/search/elastic/snippet_search_spec.rb'
- 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb'
- 'ee/spec/features/users/identity_verification_spec.rb'
- 'spec/features/admin/dashboard_spec.rb'
- 'spec/features/calendar_spec.rb'
- 'spec/features/groups/dependency_proxy_for_containers_spec.rb'
- 'spec/features/groups/empty_states_spec.rb'
- 'spec/features/groups/group_settings_spec.rb'
- 'spec/features/groups/members/sort_members_spec.rb'
- 'spec/features/groups/navbar_spec.rb'
- 'spec/features/issuables/issuable_list_spec.rb'
- 'spec/features/issuables/markdown_references/jira_spec.rb'
- 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb'
- 'spec/features/issues/user_bulk_edits_issues_labels_spec.rb'
- 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb'
- 'spec/features/issues/user_edits_issue_spec.rb'
- 'spec/features/issues/user_interacts_with_awards_spec.rb'
- 'spec/features/labels_hierarchy_spec.rb'
- 'spec/features/markdown/keyboard_shortcuts_spec.rb'
- 'spec/features/merge_request/batch_comments_spec.rb'
- 'spec/features/merge_request/user_posts_diff_notes_spec.rb'
- 'spec/features/merge_request/user_reverts_merge_request_spec.rb'
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'
- 'spec/features/merge_request/user_squashes_merge_request_spec.rb'
- 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb'
- 'spec/features/monitor_sidebar_link_spec.rb'
- 'spec/features/oauth_login_spec.rb'
- 'spec/features/participants_autocomplete_spec.rb'
- 'spec/features/profiles/user_edit_profile_spec.rb'
- 'spec/features/projects/blobs/edit_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/commit/cherry_pick_spec.rb'
- 'spec/features/projects/commit/user_reverts_commit_spec.rb'
- 'spec/features/projects/compare_spec.rb'
- 'spec/features/projects/deploy_keys_spec.rb'
- 'spec/features/projects/environments/environment_spec.rb'
- 'spec/features/projects/files/template_selector_menu_spec.rb'
- 'spec/features/projects/integrations/user_activates_issue_tracker_spec.rb'
- 'spec/features/projects/integrations/user_activates_jira_spec.rb'
- 'spec/features/projects/labels/user_removes_labels_spec.rb'
- 'spec/features/projects/members/sorting_spec.rb'
- 'spec/features/projects/milestones/milestone_spec.rb'
- 'spec/features/projects/releases/user_views_releases_spec.rb'
- 'spec/features/projects/settings/project_settings_spec.rb'
- 'spec/features/projects/settings/repository_settings_spec.rb'
- 'spec/features/projects/settings/user_transfers_a_project_spec.rb'
- 'spec/features/projects/show/user_sees_git_instructions_spec.rb'
- 'spec/features/projects/tree/create_directory_spec.rb'
- 'spec/features/projects/tree/create_file_spec.rb'
- 'spec/features/projects_spec.rb'
- 'spec/features/search/user_uses_header_search_field_spec.rb'
- 'spec/features/snippets/explore_spec.rb'
- 'spec/features/tags/developer_creates_tag_spec.rb'
- 'spec/features/usage_stats_consent_spec.rb'
- 'spec/features/users/login_spec.rb'
- 'spec/features/users/overview_spec.rb'

7
.rubocop_todo/rspec/context_method.yml
View file

@ -1,7 +0,0 @@
---
# Cop supports --autocorrect.
RSpec/ContextMethod:
Details: grace period
Exclude:
- 'ee/spec/models/geo/secondary_usage_data_spec.rb'
- 'ee/spec/models/geo_node_status_spec.rb'

35
.rubocop_todo/rspec/context_wording.yml
View file

@ -305,8 +305,6 @@ RSpec/ContextWording:
- 'ee/spec/lib/ee/gitlab/application_context_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb'
- 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb'
@ -424,7 +422,6 @@ RSpec/ContextWording:
- 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb'
- 'ee/spec/mailers/ee/emails/issues_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/migrations/schedule_requirements_migration_spec.rb'
- 'ee/spec/models/alert_management/alert_payload_field_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/application_setting_spec.rb'
@ -782,7 +779,6 @@ RSpec/ContextWording:
- 'ee/spec/services/jira/jql_builder_service_spec.rb'
- 'ee/spec/services/ldap_group_reset_service_spec.rb'
- 'ee/spec/services/members/activate_service_spec.rb'
- 'ee/spec/services/merge_commits/export_csv_service_spec.rb'
- 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb'
- 'ee/spec/services/merge_requests/build_service_spec.rb'
- 'ee/spec/services/merge_requests/merge_service_spec.rb'
@ -830,7 +826,6 @@ RSpec/ContextWording:
- 'ee/spec/services/security/store_grouped_scans_service_spec.rb'
- 'ee/spec/services/security/track_scan_service_spec.rb'
- 'ee/spec/services/security/vulnerability_counting_service_spec.rb'
- 'ee/spec/services/slash_commands/global_slack_handler_spec.rb'
- 'ee/spec/services/software_license_policies/update_service_spec.rb'
- 'ee/spec/services/status_page/publish_attachments_service_spec.rb'
- 'ee/spec/services/status_page/publish_details_service_spec.rb'
@ -941,10 +936,8 @@ RSpec/ContextWording:
- 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb'
- 'ee/spec/workers/security/track_secure_scans_worker_spec.rb'
- 'ee/spec/workers/sync_seat_link_worker_spec.rb'
- 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb'
- 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb'
@ -980,7 +973,6 @@ RSpec/ContextWording:
- 'spec/controllers/admin/application_settings_controller_spec.rb'
- 'spec/controllers/admin/instance_review_controller_spec.rb'
- 'spec/controllers/admin/integrations_controller_spec.rb'
- 'spec/controllers/admin/runner_projects_controller_spec.rb'
- 'spec/controllers/admin/sessions_controller_spec.rb'
- 'spec/controllers/admin/users_controller_spec.rb'
- 'spec/controllers/application_controller_spec.rb'
@ -1162,7 +1154,6 @@ RSpec/ContextWording:
- 'spec/features/ics/project_issues_spec.rb'
- 'spec/features/ide/static_object_external_storage_csp_spec.rb'
- 'spec/features/incidents/user_creates_new_incident_spec.rb'
- 'spec/features/invites_spec.rb'
- 'spec/features/issuables/markdown_references/internal_references_spec.rb'
- 'spec/features/issuables/sorting_list_spec.rb'
- 'spec/features/issuables/user_sees_sidebar_spec.rb'
@ -1343,7 +1334,6 @@ RSpec/ContextWording:
- 'spec/finders/ci/runners_finder_spec.rb'
- 'spec/finders/cluster_ancestors_finder_spec.rb'
- 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb'
- 'spec/finders/clusters/agent_authorizations_finder_spec.rb'
- 'spec/finders/clusters/agents_finder_spec.rb'
- 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb'
- 'spec/finders/contributed_projects_finder_spec.rb'
@ -1399,7 +1389,6 @@ RSpec/ContextWording:
- 'spec/frontend/fixtures/merge_requests.rb'
- 'spec/frontend/fixtures/projects.rb'
- 'spec/frontend/fixtures/search.rb'
- 'spec/frontend/fixtures/u2f.rb'
- 'spec/frontend/fixtures/webauthn.rb'
- 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb'
- 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb'
@ -1660,14 +1649,10 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/auth_spec.rb'
- 'spec/lib/gitlab/authorized_keys_spec.rb'
- 'spec/lib/gitlab/avatar_cache_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb'
- 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb'
- 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb'
- 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb'
- 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb'
- 'spec/lib/gitlab/bare_repository_import/importer_spec.rb'
- 'spec/lib/gitlab/bare_repository_import/repository_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb'
- 'spec/lib/gitlab/blame_spec.rb'
@ -1923,9 +1908,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb'
- 'spec/lib/gitlab/import_export/importer_spec.rb'
- 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb'
- 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb'
- 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb'
- 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb'
- 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb'
- 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
@ -1951,8 +1933,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/kas/client_spec.rb'
- 'spec/lib/gitlab/kas_spec.rb'
- 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/api_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb'
- 'spec/lib/gitlab/kubernetes/kube_client_spec.rb'
- 'spec/lib/gitlab/legacy_github_import/client_spec.rb'
- 'spec/lib/gitlab/lfs/client_spec.rb'
@ -2000,14 +1980,12 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/patch/prependable_spec.rb'
- 'spec/lib/gitlab/path_regex_spec.rb'
- 'spec/lib/gitlab/performance_bar_spec.rb'
- 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb'
- 'spec/lib/gitlab/popen_spec.rb'
- 'spec/lib/gitlab/process_supervisor_spec.rb'
- 'spec/lib/gitlab/profiler_spec.rb'
- 'spec/lib/gitlab/project_authorizations_spec.rb'
- 'spec/lib/gitlab/project_search_results_spec.rb'
- 'spec/lib/gitlab/prometheus/adapter_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb'
- 'spec/lib/gitlab/prometheus/query_variables_spec.rb'
@ -2037,7 +2015,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/search_context/controller_concern_spec.rb'
- 'spec/lib/gitlab/search_results_spec.rb'
- 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb'
- 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb'
- 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb'
@ -2089,7 +2066,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb'
- 'spec/lib/gitlab/usage_data_spec.rb'
- 'spec/lib/gitlab/utils/lazy_attributes_spec.rb'
- 'spec/lib/gitlab/utils/mime_type_spec.rb'
@ -2140,7 +2116,6 @@ RSpec/ContextWording:
- 'spec/mailers/emails/releases_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb'
- 'spec/models/ability_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/alert_management/alert_spec.rb'
@ -2183,13 +2158,6 @@ RSpec/ContextWording:
- 'spec/models/ci/trigger_spec.rb'
- 'spec/models/ci/variable_spec.rb'
- 'spec/models/clusters/agent_spec.rb'
- 'spec/models/clusters/applications/crossplane_spec.rb'
- 'spec/models/clusters/applications/helm_spec.rb'
- 'spec/models/clusters/applications/ingress_spec.rb'
- 'spec/models/clusters/applications/jupyter_spec.rb'
- 'spec/models/clusters/applications/knative_spec.rb'
- 'spec/models/clusters/applications/prometheus_spec.rb'
- 'spec/models/clusters/applications/runner_spec.rb'
- 'spec/models/clusters/cluster_spec.rb'
- 'spec/models/clusters/clusters_hierarchy_spec.rb'
- 'spec/models/clusters/kubernetes_namespace_spec.rb'
@ -2623,7 +2591,6 @@ RSpec/ContextWording:
- 'spec/scripts/pipeline_test_report_builder_spec.rb'
- 'spec/serializers/analytics_build_entity_spec.rb'
- 'spec/serializers/ci/pipeline_entity_spec.rb'
- 'spec/serializers/cluster_application_entity_spec.rb'
- 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb'
- 'spec/serializers/diff_file_base_entity_spec.rb'
- 'spec/serializers/diffs_entity_spec.rb'
@ -2810,7 +2777,6 @@ RSpec/ContextWording:
- 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb'
- 'spec/services/metrics/dashboard/panel_preview_service_spec.rb'
- 'spec/services/metrics/dashboard/pod_dashboard_service_spec.rb'
- 'spec/services/metrics/dashboard/self_monitoring_dashboard_service_spec.rb'
- 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb'
- 'spec/services/metrics/dashboard/transient_embed_service_spec.rb'
- 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb'
@ -2965,7 +2931,6 @@ RSpec/ContextWording:
- 'spec/support/shared_contexts/features/integrations/group_integrations_shared_context.rb'
- 'spec/support/shared_contexts/features/integrations/instance_and_group_integrations_shared_context.rb'
- 'spec/support/shared_contexts/features/integrations/instance_integrations_shared_context.rb'
- 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb'
- 'spec/support/shared_contexts/features/integrations/project_integrations_jira_context.rb'
- 'spec/support/shared_contexts/features/integrations/project_integrations_shared_context.rb'
- 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb'

3
.rubocop_todo/rspec/described_class.yml
View file

@ -93,7 +93,6 @@ RSpec/DescribedClass:
- 'spec/lib/gitlab/relative_positioning/range_spec.rb'
- 'spec/lib/gitlab/runtime_spec.rb'
- 'spec/lib/gitlab/seeder_spec.rb'
- 'spec/lib/gitlab/serverless/service_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb'
- 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb'
- 'spec/lib/gitlab/utils/measuring_spec.rb'
@ -107,8 +106,6 @@ RSpec/DescribedClass:
- 'spec/models/alert_management/alert_spec.rb'
- 'spec/models/application_record_spec.rb'
- 'spec/models/application_setting_spec.rb'
- 'spec/models/awareness_session_spec.rb'
- 'spec/models/broadcast_message_spec.rb'
- 'spec/models/chat_name_spec.rb'
- 'spec/models/ci/build_runner_session_spec.rb'
- 'spec/models/ci/build_spec.rb'

10
.rubocop_todo/rspec/expect_change.yml
View file

@ -17,7 +17,6 @@ RSpec/ExpectChange:
- 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb'
- 'ee/spec/lib/ee/feature_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb'
- 'ee/spec/lib/gitlab/audit/auditor_spec.rb'
- 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb'
@ -196,7 +195,6 @@ RSpec/ExpectChange:
- 'ee/spec/workers/groups/create_event_worker_spec.rb'
- 'ee/spec/workers/import_software_licenses_worker_spec.rb'
- 'ee/spec/workers/sync_seat_link_request_worker_spec.rb'
- 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb'
- 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb'
- 'spec/controllers/admin/groups_controller_spec.rb'
- 'spec/controllers/admin/users_controller_spec.rb'
@ -241,11 +239,7 @@ RSpec/ExpectChange:
- 'spec/lib/gitlab/auth_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
- 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb'
- 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb'
- 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb'
- 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb'
@ -257,7 +251,6 @@ RSpec/ExpectChange:
- 'spec/lib/gitlab/database/tables_truncate_spec.rb'
- 'spec/lib/gitlab/diff/file_spec.rb'
- 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb'
- 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb'
- 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb'
@ -273,7 +266,6 @@ RSpec/ExpectChange:
- 'spec/lib/gitlab/pages/cache_control_spec.rb'
- 'spec/lib/gitlab/query_limiting/transaction_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb'
- 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb'
- 'spec/migrations/20220321234317_remove_all_issuable_escalation_statuses_spec.rb'
- 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb'
- 'spec/migrations/20220512190659_remove_web_hooks_web_hook_logs_web_hook_id_fk_spec.rb'
@ -286,7 +278,6 @@ RSpec/ExpectChange:
- 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb'
- 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb'
- 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb'
- 'spec/models/awareness_session_spec.rb'
- 'spec/models/ci/build_metadata_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
@ -445,6 +436,5 @@ RSpec/ExpectChange:
- 'spec/services/work_items/task_list_reference_replacement_service_spec.rb'
- 'spec/services/work_items/update_service_spec.rb'
- 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb'
- 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb'
- 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb'
- 'spec/services/x509_certificate_revoke_service_spec.rb'

5
.rubocop_todo/rspec/expect_in_hook.yml
View file

@ -62,7 +62,6 @@ RSpec/ExpectInHook:
- 'ee/spec/requests/omniauth_kerberos_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb'
- 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb'
- 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb'
- 'ee/spec/services/ci/runners/register_runner_service_spec.rb'
- 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb'
- 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb'
@ -219,7 +218,6 @@ RSpec/ExpectInHook:
- 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
- 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb'
- 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb'
- 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb'
- 'spec/lib/gitlab/diff/highlight_cache_spec.rb'
- 'spec/lib/gitlab/email/service_desk_receiver_spec.rb'
- 'spec/lib/gitlab/faraday/error_callback_spec.rb'
@ -247,7 +245,6 @@ RSpec/ExpectInHook:
- 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb'
- 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb'
- 'spec/lib/gitlab/import_export/import_failure_service_spec.rb'
- 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb'
- 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb'
- 'spec/lib/gitlab/import_export/lfs_saver_spec.rb'
- 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb'
@ -257,7 +254,6 @@ RSpec/ExpectInHook:
- 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb'
- 'spec/lib/gitlab/jira_import/labels_importer_spec.rb'
- 'spec/lib/gitlab/kas/client_spec.rb'
- 'spec/lib/gitlab/kubernetes/helm/api_spec.rb'
- 'spec/lib/gitlab/kubernetes/kube_client_spec.rb'
- 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb'
- 'spec/lib/gitlab/memory/instrumentation_spec.rb'
@ -439,7 +435,6 @@ RSpec/ExpectInHook:
- 'spec/services/projects/update_remote_mirror_service_spec.rb'
- 'spec/services/projects/update_repository_storage_service_spec.rb'
- 'spec/services/search_service_spec.rb'
- 'spec/services/serverless/associate_domain_service_spec.rb'
- 'spec/services/snippets/update_repository_storage_service_spec.rb'
- 'spec/services/suggestions/apply_service_spec.rb'
- 'spec/services/suggestions/create_service_spec.rb'

6
.rubocop_todo/rspec/factory_bot/avoid_create.yml
View file

@ -27,7 +27,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/helpers/ee/feature_flags_helper_spec.rb'
- 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb'
- 'ee/spec/helpers/ee/graph_helper_spec.rb'
- 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb'
- 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb'
- 'ee/spec/helpers/ee/groups_helper_spec.rb'
- 'ee/spec/helpers/ee/hooks_helper_spec.rb'
@ -205,7 +204,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb'
- 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb'
- 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb'
- 'ee/spec/views/layouts/_search.html.haml_spec.rb'
- 'ee/spec/views/layouts/application.html.haml_spec.rb'
- 'ee/spec/views/layouts/group.html.haml_spec.rb'
- 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb'
@ -249,7 +247,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/components/pajamas/avatar_component_spec.rb'
- 'spec/helpers/admin/identities_helper_spec.rb'
- 'spec/helpers/admin/user_actions_helper_spec.rb'
- 'spec/helpers/analytics/cycle_analytics_helper_spec.rb'
- 'spec/helpers/appearances_helper_spec.rb'
- 'spec/helpers/application_helper_spec.rb'
- 'spec/helpers/application_settings_helper_spec.rb'
@ -428,7 +425,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/serializers/ci/lint/result_serializer_spec.rb'
- 'spec/serializers/ci/pipeline_entity_spec.rb'
- 'spec/serializers/ci/trigger_entity_spec.rb'
- 'spec/serializers/cluster_application_entity_spec.rb'
- 'spec/serializers/cluster_entity_spec.rb'
- 'spec/serializers/cluster_serializer_spec.rb'
- 'spec/serializers/clusters/kubernetes_error_entity_spec.rb'
@ -554,7 +550,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/views/groups/edit.html.haml_spec.rb'
- 'spec/views/groups/new.html.haml_spec.rb'
- 'spec/views/help/instance_configuration.html.haml_spec.rb'
- 'spec/views/layouts/_search.html.haml_spec.rb'
- 'spec/views/layouts/application.html.haml_spec.rb'
- 'spec/views/layouts/devise.html.haml_spec.rb'
- 'spec/views/layouts/fullscreen.html.haml_spec.rb'
@ -624,7 +619,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb'
- 'spec/views/shared/projects/_list.html.haml_spec.rb'
- 'spec/views/shared/projects/_project.html.haml_spec.rb'
- 'spec/views/shared/runners/_runner_details.html.haml_spec.rb'
- 'spec/views/shared/snippets/_snippet.html.haml_spec.rb'
- 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb'
- 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb'

2
.rubocop_todo/rspec/file_path.yml
View file

@ -12,6 +12,7 @@ RSpec/FilePath:
- 'ee/spec/frontend/fixtures/analytics/value_streams_staging_stage.rb'
- 'ee/spec/frontend/fixtures/analytics/value_streams_test_stage.rb'
- 'ee/spec/frontend/fixtures/dora/metrics.rb'
- 'ee/spec/helpers/merge_requests_helper_spec.rb'
- 'ee/spec/models/merge_request/blocking_spec.rb'
- 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb'
- 'ee/spec/requests/api/ci/runner/jobs_trace_spec.rb'
@ -24,7 +25,6 @@ RSpec/FilePath:
- 'spec/docs_screenshots/container_registry_docs.rb'
- 'spec/docs_screenshots/wiki_docs.rb'
- 'spec/lib/error_tracking/sentry_client/event_spec.rb'
- 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb'
- 'spec/lib/gitlab/import_export/import_export_spec.rb'
- 'spec/lib/gitlab/mail_room/mail_room_spec.rb'
- 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb'

5
.rubocop_todo/rspec/hooks_before_examples.yml
View file

@ -26,19 +26,14 @@ RSpec/HooksBeforeExamples:
- 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb'
- 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb'
- 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb'
- 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb'
- 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb'
- 'qa/spec/specs/runner_spec.rb'

Some files were not shown because too many files have changed in this diff Show more