From 17d8b8b016937f284f5295b92772087185720b97 Mon Sep 17 00:00:00 2001 From: Pirate Praveen Date: Tue, 18 Aug 2020 19:51:02 +0530 Subject: [PATCH] New upstream version 13.2.5 --- CHANGELOG.md | 31 ++- GITALY_SERVER_VERSION | 2 +- Gemfile | 2 +- Gemfile.lock | 4 +- VERSION | 2 +- .../jobs/components/environments_block.vue | 255 +++++++----------- .../enforces_two_factor_authentication.rb | 9 +- .../oauth/applications_controller.rb | 3 - .../oauth/authorizations_controller.rb | 2 +- .../authorized_applications_controller.rb | 2 +- .../oauth/token_info_controller.rb | 2 + app/controllers/oauth/tokens_controller.rb | 5 + app/helpers/issuables_helper.rb | 2 +- app/mailers/emails/members.rb | 17 +- app/models/clusters/applications/runner.rb | 2 +- .../process_prometheus_alert_service.rb | 22 +- .../project_group_link_create_service.rb | 18 +- app/services/groups/transfer_service.rb | 11 + .../projects/group_links/create_service.rb | 7 +- .../project_group_link_create_worker.rb | 7 +- app/workers/authorized_projects_worker.rb | 3 + .../process_alert_worker.rb | 6 +- config/routes.rb | 3 +- doc/push_rules/push_rules.md | 7 + ...import_decompressed_archive_size_limits.md | 28 ++ doc/user/project/web_ide/index.md | 2 +- lib/banzai/filter/label_reference_filter.rb | 2 + lib/banzai/filter/reference_filter.rb | 1 - lib/gitlab/base_doorkeeper_controller.rb | 2 + lib/gitlab/checks/branch_check.rb | 12 +- .../decompressed_archive_size_validator.rb | 90 +++++++ lib/gitlab/import_export/file_importer.rb | 9 + lib/gitlab/markdown_cache.rb | 2 +- locale/gitlab.pot | 3 + .../oauth/applications_controller_spec.rb | 27 ++ .../oauth/authorizations_controller_spec.rb | 92 ++++--- ...authorized_applications_controller_spec.rb | 20 ++ .../oauth/token_info_controller_spec.rb | 4 + .../oauth/tokens_controller_spec.rb | 9 + spec/factories/alert_management/alerts.rb | 10 + spec/features/projects/jobs_spec.rb | 18 +- .../components/environments_block_spec.js | 70 ++--- spec/helpers/issuables_helper_spec.rb | 8 + .../filter/issue_reference_filter_spec.rb | 6 + spec/lib/gitlab/checks/branch_check_spec.rb | 23 ++ ...ecompressed_archive_size_validator_spec.rb | 58 ++++ .../import_export/file_importer_spec.rb | 39 +++ spec/mailers/notify_spec.rb | 18 ++ .../process_prometheus_alert_service_spec.rb | 16 ++ .../project_group_link_create_service_spec.rb | 23 +- spec/services/groups/transfer_service_spec.rb | 119 ++++++-- .../group_links/create_service_spec.rb | 7 +- .../process_alert_worker_spec.rb | 93 ++++--- 53 files changed, 894 insertions(+), 341 deletions(-) create mode 100644 app/controllers/oauth/tokens_controller.rb create mode 100644 doc/security/project_import_decompressed_archive_size_limits.md create mode 100644 lib/gitlab/import_export/decompressed_archive_size_validator.rb create mode 100644 spec/controllers/oauth/tokens_controller_spec.rb create mode 100644 spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb diff --git a/CHANGELOG.md b/CHANGELOG.md index 6055223dfd..395ff400fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,39 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. -## 13.2.3 (2020-08-05) +## 13.2.5 (2020-08-17) - No changes. +## 13.2.4 (2020-08-11) + +### Security (1 change) + +- Add decompressed archive size validation on Project/Group Import. !38736 + +### Fixed (1 change) + +- Fix automatic issue creation via Prometheus alerts. !37884 + + +## 13.2.3 (2020-08-05) + +### Security (12 changes) + +- Update kramdown gem to version 2.3.0. +- Enforce 2FA on Doorkeeper controllers. +- Revoke OAuth grants when a user revokes an application. +- Refresh project authorizations when transferring groups. +- Stop excess logs from failure to send invite email when group no longer exists. +- Verify confirmed email for OAuth Authorize POST endpoint. +- Fix XSS in Markdown reference tooltips. +- Fix XSS in milestone tooltips. +- Fix xss vulnerability on jobs view. +- Block 40-character hexadecimal branches. +- Prevent a temporary access escalation before group memberships are recalculated when specialized project share workers are enabled. +- Update GitLab Runner Helm Chart to 0.18.2. + + ## 13.2.2 (2020-07-29) ### Fixed (3 changes) diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index d8308f987e..8c339431c5 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -13.2.3 +13.2.5 diff --git a/Gemfile b/Gemfile index e082094715..83e66ef838 100644 --- a/Gemfile +++ b/Gemfile @@ -142,7 +142,7 @@ gem 'deckar01-task_list', '2.3.1' gem 'gitlab-markup', '~> 1.7.1' gem 'github-markup', '~> 1.7.0', require: 'github/markup' gem 'commonmarker', '~> 0.20' -gem 'kramdown', '~> 2.2.1' +gem 'kramdown', '~> 2.3.0' gem 'RedCloth', '~> 4.3.2' gem 'rdoc', '~> 6.1.2' gem 'org-ruby', '~> 0.9.12' diff --git a/Gemfile.lock b/Gemfile.lock index fbe5cfff1f..f211012331 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -589,7 +589,7 @@ GEM kgio (2.11.3) knapsack (1.17.0) rake - kramdown (2.2.1) + kramdown (2.3.0) rexml kramdown-parser-gfm (1.1.0) kramdown (~> 2.0) @@ -1297,7 +1297,7 @@ DEPENDENCIES jwt (~> 2.1.0) kaminari (~> 1.0) knapsack (~> 1.17) - kramdown (~> 2.2.1) + kramdown (~> 2.3.0) kubeclient (~> 4.6.0) letter_opener_web (~> 1.3.4) license_finder (~> 5.4) diff --git a/VERSION b/VERSION index d8308f987e..8c339431c5 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -13.2.3 +13.2.5 diff --git a/app/assets/javascripts/jobs/components/environments_block.vue b/app/assets/javascripts/jobs/components/environments_block.vue index c78738221f..9166c13a4f 100644 --- a/app/assets/javascripts/jobs/components/environments_block.vue +++ b/app/assets/javascripts/jobs/components/environments_block.vue @@ -1,11 +1,15 @@