debian-mirror-gitlab/spec/policies/project_policy_spec.rb

577 lines
19 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2016-09-29 09:46:39 +05:30
require 'spec_helper'
2017-09-10 17:25:29 +05:30
describe ProjectPolicy do
2019-07-07 11:18:12 +05:30
include ExternalAuthorizationServiceHelpers
include_context 'ProjectPolicy context'
2020-04-08 14:13:33 +05:30
let_it_be(:guest) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:developer) { create(:user) }
let_it_be(:maintainer) { create(:user) }
let_it_be(:owner) { create(:user) }
let_it_be(:admin) { create(:admin) }
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, :public, namespace: owner.namespace) }
2016-09-29 09:46:39 +05:30
2018-03-17 18:26:18 +05:30
let(:base_guest_permissions) do
2017-08-17 22:00:37 +05:30
%i[
2018-05-09 12:01:36 +05:30
read_project read_board read_list read_wiki read_issue
2019-02-02 18:00:53 +05:30
read_project_for_iids read_issue_iid read_label
2020-03-13 15:44:24 +05:30
read_milestone read_snippet read_project_member read_note
2018-05-09 12:01:36 +05:30
create_project create_issue create_note upload_file create_merge_request_in
2019-07-31 22:56:46 +05:30
award_emoji read_release
2016-11-03 12:29:30 +05:30
]
2016-09-29 09:46:39 +05:30
end
2018-03-17 18:26:18 +05:30
let(:base_reporter_permissions) do
2017-08-17 22:00:37 +05:30
%i[
2020-03-13 15:44:24 +05:30
download_code fork_project create_snippet update_issue
2017-08-17 22:00:37 +05:30
admin_issue admin_label admin_list read_commit_status read_build
read_container_image read_pipeline read_environment read_deployment
2019-07-31 22:56:46 +05:30
read_merge_request download_wiki_code read_sentry_issue
2016-11-03 12:29:30 +05:30
]
end
let(:team_member_reporter_permissions) do
2017-08-17 22:00:37 +05:30
%i[build_download_code build_read_container_image]
2016-11-03 12:29:30 +05:30
end
let(:developer_permissions) do
2017-08-17 22:00:37 +05:30
%i[
2019-09-30 21:07:59 +05:30
admin_tag admin_milestone admin_merge_request update_merge_request create_commit_status
2017-08-17 22:00:37 +05:30
update_commit_status create_build update_build create_pipeline
2018-05-09 12:01:36 +05:30
update_pipeline create_merge_request_from create_wiki push_code
2019-09-04 21:01:54 +05:30
resolve_note create_container_image update_container_image destroy_container_image
2020-01-01 13:55:28 +05:30
create_environment update_environment create_deployment update_deployment create_release update_release
2016-11-03 12:29:30 +05:30
]
end
2018-11-18 11:00:15 +05:30
let(:base_maintainer_permissions) do
2017-08-17 22:00:37 +05:30
%i[
2020-03-13 15:44:24 +05:30
push_to_delete_protected_branch update_snippet
admin_snippet admin_project_member admin_note admin_wiki admin_project
2017-08-17 22:00:37 +05:30
admin_commit_status admin_build admin_container_image
2019-02-15 15:39:39 +05:30
admin_pipeline admin_environment admin_deployment destroy_release add_cluster
2020-04-08 14:13:33 +05:30
daily_statistics read_deploy_token create_deploy_token destroy_deploy_token
2016-11-03 12:29:30 +05:30
]
end
let(:public_permissions) do
2017-08-17 22:00:37 +05:30
%i[
download_code fork_project read_commit_status read_pipeline
read_container_image build_download_code build_read_container_image
2019-02-15 15:39:39 +05:30
download_wiki_code read_release
2016-11-03 12:29:30 +05:30
]
end
let(:owner_permissions) do
2017-08-17 22:00:37 +05:30
%i[
change_namespace change_visibility_level rename_project remove_project
archive_project remove_fork_project destroy_merge_request destroy_issue
2019-09-04 21:01:54 +05:30
set_issue_iid set_issue_created_at set_issue_updated_at set_note_created_at
2016-11-03 12:29:30 +05:30
]
2016-09-29 09:46:39 +05:30
end
2018-03-17 18:26:18 +05:30
# Used in EE specs
2019-03-02 22:35:43 +05:30
let(:additional_guest_permissions) { [] }
2018-03-17 18:26:18 +05:30
let(:additional_reporter_permissions) { [] }
2018-11-18 11:00:15 +05:30
let(:additional_maintainer_permissions) { [] }
2018-03-17 18:26:18 +05:30
let(:guest_permissions) { base_guest_permissions + additional_guest_permissions }
let(:reporter_permissions) { base_reporter_permissions + additional_reporter_permissions }
2018-11-18 11:00:15 +05:30
let(:maintainer_permissions) { base_maintainer_permissions + additional_maintainer_permissions }
2018-03-17 18:26:18 +05:30
2016-09-29 09:46:39 +05:30
before do
2018-03-17 18:26:18 +05:30
project.add_guest(guest)
2018-11-18 11:00:15 +05:30
project.add_maintainer(maintainer)
2018-03-17 18:26:18 +05:30
project.add_developer(developer)
project.add_reporter(reporter)
2016-09-29 09:46:39 +05:30
end
2017-09-10 17:25:29 +05:30
def expect_allowed(*permissions)
permissions.each { |p| is_expected.to be_allowed(p) }
end
def expect_disallowed(*permissions)
permissions.each { |p| is_expected.not_to be_allowed(p) }
end
2019-12-04 20:38:33 +05:30
context 'with no project feature' do
subject { described_class.new(owner, project) }
before do
project.project_feature.destroy
project.reload
end
it 'returns false' do
is_expected.to be_disallowed(:read_build)
end
end
2016-09-29 09:46:39 +05:30
it 'does not include the read_issue permission when the issue author is not a member of the private project' do
2017-09-10 17:25:29 +05:30
project = create(:project, :private)
2018-03-17 18:26:18 +05:30
issue = create(:issue, project: project, author: create(:user))
2016-09-29 09:46:39 +05:30
user = issue.author
2017-09-10 17:25:29 +05:30
expect(project.team.member?(issue.author)).to be false
expect(Ability).not_to be_allowed(user, :read_issue, project)
end
2019-02-02 18:00:53 +05:30
context 'wiki feature' do
let(:permissions) { %i(read_wiki create_wiki update_wiki admin_wiki download_wiki_code) }
2017-09-10 17:25:29 +05:30
subject { described_class.new(owner, project) }
2019-02-02 18:00:53 +05:30
context 'when the feature is disabled' do
before do
project.project_feature.update_attribute(:wiki_access_level, ProjectFeature::DISABLED)
end
it 'does not include the wiki permissions' do
expect_disallowed(*permissions)
end
context 'when there is an external wiki' do
it 'does not include the wiki permissions' do
allow(project).to receive(:has_external_wiki?).and_return(true)
2017-09-10 17:25:29 +05:30
2019-02-02 18:00:53 +05:30
expect_disallowed(*permissions)
end
end
2017-09-10 17:25:29 +05:30
end
2019-10-12 21:52:04 +05:30
describe 'read_wiki' do
subject { described_class.new(user, project) }
member_roles = %i[guest developer]
stranger_roles = %i[anonymous non_member]
user_roles = stranger_roles + member_roles
# When a user is anonymous, their `current_user == nil`
let(:user) { create(:user) unless user_role == :anonymous }
before do
project.visibility = project_visibility
project.project_feature.update_attribute(:wiki_access_level, wiki_access_level)
project.add_user(user, user_role) if member_roles.include?(user_role)
end
title = ->(project_visibility, wiki_access_level, user_role) do
[
"project is #{Gitlab::VisibilityLevel.level_name project_visibility}",
"wiki is #{ProjectFeature.str_from_access_level wiki_access_level}",
"user is #{user_role}"
].join(', ')
end
describe 'Situations where :read_wiki is always false' do
where(case_names: title,
project_visibility: Gitlab::VisibilityLevel.options.values,
wiki_access_level: [ProjectFeature::DISABLED],
user_role: user_roles)
with_them do
it { is_expected.to be_disallowed(:read_wiki) }
end
end
describe 'Situations where :read_wiki is always true' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::PUBLIC],
wiki_access_level: [ProjectFeature::ENABLED],
user_role: user_roles)
with_them do
it { is_expected.to be_allowed(:read_wiki) }
end
end
describe 'Situations where :read_wiki requires project membership' do
context 'the wiki is private, and the user is a member' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::PUBLIC,
Gitlab::VisibilityLevel::INTERNAL],
wiki_access_level: [ProjectFeature::PRIVATE],
user_role: member_roles)
with_them do
it { is_expected.to be_allowed(:read_wiki) }
end
end
context 'the wiki is private, and the user is not member' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::PUBLIC,
Gitlab::VisibilityLevel::INTERNAL],
wiki_access_level: [ProjectFeature::PRIVATE],
user_role: stranger_roles)
with_them do
it { is_expected.to be_disallowed(:read_wiki) }
end
end
context 'the wiki is enabled, and the user is a member' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::PRIVATE],
wiki_access_level: [ProjectFeature::ENABLED],
user_role: member_roles)
with_them do
it { is_expected.to be_allowed(:read_wiki) }
end
end
context 'the wiki is enabled, and the user is not a member' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::PRIVATE],
wiki_access_level: [ProjectFeature::ENABLED],
user_role: stranger_roles)
with_them do
it { is_expected.to be_disallowed(:read_wiki) }
end
end
end
describe 'Situations where :read_wiki prohibits anonymous access' do
context 'the user is not anonymous' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::INTERNAL],
wiki_access_level: [ProjectFeature::ENABLED, ProjectFeature::PUBLIC],
user_role: user_roles.reject { |u| u == :anonymous })
with_them do
it { is_expected.to be_allowed(:read_wiki) }
end
end
context 'the user is not anonymous' do
where(case_names: title,
project_visibility: [Gitlab::VisibilityLevel::INTERNAL],
wiki_access_level: [ProjectFeature::ENABLED, ProjectFeature::PUBLIC],
user_role: %i[anonymous])
with_them do
it { is_expected.to be_disallowed(:read_wiki) }
end
end
end
end
2017-09-10 17:25:29 +05:30
end
context 'issues feature' do
subject { described_class.new(owner, project) }
context 'when the feature is disabled' do
2019-03-13 22:55:13 +05:30
before do
2017-09-10 17:25:29 +05:30
project.issues_enabled = false
project.save!
2019-03-13 22:55:13 +05:30
end
2017-09-10 17:25:29 +05:30
2019-03-13 22:55:13 +05:30
it 'does not include the issues permissions' do
2018-05-09 12:01:36 +05:30
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue
2017-09-10 17:25:29 +05:30
end
2016-09-29 09:46:39 +05:30
2019-03-13 22:55:13 +05:30
it 'disables boards and lists permissions' do
2019-07-07 11:18:12 +05:30
expect_disallowed :read_board, :create_board, :update_board
2019-03-13 22:55:13 +05:30
expect_disallowed :read_list, :create_list, :update_list, :admin_list
end
2016-09-29 09:46:39 +05:30
2019-03-13 22:55:13 +05:30
context 'when external tracker configured' do
it 'does not include the issues permissions' do
create(:jira_service, project: project)
2017-09-10 17:25:29 +05:30
2019-03-13 22:55:13 +05:30
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue
end
2018-05-09 12:01:36 +05:30
end
end
end
context 'merge requests feature' do
subject { described_class.new(owner, project) }
it 'disallows all permissions when the feature is disabled' do
project.project_feature.update(merge_requests_access_level: ProjectFeature::DISABLED)
mr_permissions = [:create_merge_request_from, :read_merge_request,
:update_merge_request, :admin_merge_request,
:create_merge_request_in]
expect_disallowed(*mr_permissions)
end
end
2019-02-02 18:00:53 +05:30
context 'for a guest in a private project' do
let(:project) { create(:project, :private) }
2020-01-01 13:55:28 +05:30
2019-02-02 18:00:53 +05:30
subject { described_class.new(guest, project) }
it 'disallows the guest from reading the merge request and merge request iid' do
expect_disallowed(:read_merge_request)
expect_disallowed(:read_merge_request_iid)
end
end
2019-12-26 22:10:19 +05:30
context 'pipeline feature' do
let(:project) { create(:project) }
describe 'for unconfirmed user' do
let(:unconfirmed_user) { create(:user, confirmed_at: nil) }
2020-01-01 13:55:28 +05:30
2019-12-26 22:10:19 +05:30
subject { described_class.new(unconfirmed_user, project) }
it 'disallows to modify pipelines' do
expect_disallowed(:create_pipeline)
expect_disallowed(:update_pipeline)
expect_disallowed(:create_pipeline_schedule)
end
end
describe 'for confirmed user' do
subject { described_class.new(developer, project) }
it 'allows modify pipelines' do
expect_allowed(:create_pipeline)
expect_allowed(:update_pipeline)
expect_allowed(:create_pipeline_schedule)
end
end
end
2018-11-08 19:23:39 +05:30
context 'builds feature' do
2019-02-02 18:00:53 +05:30
context 'when builds are disabled' do
subject { described_class.new(owner, project) }
2018-11-08 19:23:39 +05:30
2019-02-02 18:00:53 +05:30
before do
project.project_feature.update(builds_access_level: ProjectFeature::DISABLED)
end
it 'disallows all permissions except pipeline when the feature is disabled' do
builds_permissions = [
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
:create_pipeline_schedule, :read_pipeline_schedule, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
:create_cluster, :read_cluster, :update_cluster, :admin_cluster, :destroy_cluster,
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment
]
expect_disallowed(*builds_permissions)
end
end
context 'when builds are disabled only for some users' do
subject { described_class.new(guest, project) }
before do
project.project_feature.update(builds_access_level: ProjectFeature::PRIVATE)
end
it 'disallows pipeline and commit_status permissions' do
builds_permissions = [
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
:create_commit_status, :update_commit_status, :admin_commit_status, :destroy_commit_status
]
expect_disallowed(*builds_permissions)
end
2018-11-08 19:23:39 +05:30
end
end
context 'repository feature' do
subject { described_class.new(owner, project) }
it 'disallows all permissions when the feature is disabled' do
project.project_feature.update(repository_access_level: ProjectFeature::DISABLED)
repository_permissions = [
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
:create_pipeline_schedule, :read_pipeline_schedule, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
2019-02-15 15:39:39 +05:30
:create_cluster, :read_cluster, :update_cluster, :admin_cluster,
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment,
:destroy_release
2018-11-08 19:23:39 +05:30
]
expect_disallowed(*repository_permissions)
end
end
2018-03-17 18:26:18 +05:30
it_behaves_like 'project policies as anonymous'
it_behaves_like 'project policies as guest'
it_behaves_like 'project policies as reporter'
it_behaves_like 'project policies as developer'
2018-11-18 11:00:15 +05:30
it_behaves_like 'project policies as maintainer'
2018-03-17 18:26:18 +05:30
it_behaves_like 'project policies as owner'
it_behaves_like 'project policies as admin'
2018-03-27 19:54:05 +05:30
context 'when a public project has merge requests allowing access' do
include ProjectForksHelper
let(:user) { create(:user) }
let(:target_project) { create(:project, :public) }
let(:project) { fork_project(target_project) }
let!(:merge_request) do
create(
:merge_request,
target_project: target_project,
source_project: project,
2018-11-08 19:23:39 +05:30
allow_collaboration: true
2018-03-27 19:54:05 +05:30
)
end
let(:maintainer_abilities) do
2018-11-08 19:23:39 +05:30
%w(create_build create_pipeline)
2018-03-27 19:54:05 +05:30
end
subject { described_class.new(user, project) }
it 'does not allow pushing code' do
expect_disallowed(*maintainer_abilities)
end
it 'allows pushing if the user is a member with push access to the target project' do
target_project.add_developer(user)
expect_allowed(*maintainer_abilities)
end
it 'dissallows abilities to a maintainer if the merge request was closed' do
target_project.add_developer(user)
merge_request.close!
expect_disallowed(*maintainer_abilities)
end
end
2019-02-15 15:39:39 +05:30
it_behaves_like 'clusterable policies' do
let(:clusterable) { create(:project, :repository) }
let(:cluster) do
create(:cluster,
:provided_by_gcp,
:project,
projects: [clusterable])
end
end
2019-07-07 11:18:12 +05:30
context 'reading a project' do
it 'allows access when a user has read access to the repo' do
expect(described_class.new(owner, project)).to be_allowed(:read_project)
expect(described_class.new(developer, project)).to be_allowed(:read_project)
expect(described_class.new(admin, project)).to be_allowed(:read_project)
end
it 'never checks the external service' do
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
expect(described_class.new(owner, project)).to be_allowed(:read_project)
end
context 'with an external authorization service' do
before do
enable_external_authorization_service_check
end
it 'allows access when the external service allows it' do
external_service_allow_access(owner, project)
external_service_allow_access(developer, project)
expect(described_class.new(owner, project)).to be_allowed(:read_project)
expect(described_class.new(developer, project)).to be_allowed(:read_project)
end
it 'does not check the external service for admins and allows access' do
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
expect(described_class.new(admin, project)).to be_allowed(:read_project)
end
it 'prevents all but seeing a public project in a list when access is denied' do
[developer, owner, build(:user), nil].each do |user|
external_service_deny_access(user, project)
policy = described_class.new(user, project)
expect(policy).not_to be_allowed(:read_project)
expect(policy).not_to be_allowed(:owner_access)
expect(policy).not_to be_allowed(:change_namespace)
end
end
it 'passes the full path to external authorization for logging purposes' do
expect(::Gitlab::ExternalAuthorization)
.to receive(:access_allowed?).with(owner, 'default_label', project.full_path).and_call_original
described_class.new(owner, project).allowed?(:read_project)
end
end
end
2019-12-21 20:55:43 +05:30
2020-03-13 15:44:24 +05:30
context 'forking a project' do
subject { described_class.new(current_user, project) }
context 'anonymous user' do
let(:current_user) { nil }
it { is_expected.to be_disallowed(:fork_project) }
end
context 'project member' do
let_it_be(:project) { create(:project, :private) }
context 'guest' do
let(:current_user) { guest }
it { is_expected.to be_disallowed(:fork_project) }
end
%w(reporter developer maintainer).each do |role|
context role do
let(:current_user) { send(role) }
it { is_expected.to be_allowed(:fork_project) }
end
end
end
end
2019-12-21 20:55:43 +05:30
describe 'update_max_artifacts_size' do
subject { described_class.new(current_user, project) }
context 'when no user' do
let(:current_user) { nil }
it { expect_disallowed(:update_max_artifacts_size) }
end
context 'admin' do
let(:current_user) { admin }
it { expect_allowed(:update_max_artifacts_size) }
end
%w(guest reporter developer maintainer owner).each do |role|
context role do
let(:current_user) { send(role) }
it { expect_disallowed(:update_max_artifacts_size) }
end
end
end
2020-03-13 15:44:24 +05:30
context 'alert bot' do
let(:current_user) { User.alert_bot }
subject { described_class.new(current_user, project) }
it { is_expected.to be_allowed(:reporter_access) }
context 'within a private project' do
let(:project) { create(:project, :private) }
it { is_expected.to be_allowed(:admin_issue) }
end
end
2016-09-29 09:46:39 +05:30
end