debian-mirror-gitlab/spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb

87 lines
2.9 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2019-12-04 20:38:33 +05:30
require 'spec_helper'
2017-08-17 22:00:37 +05:30
2020-06-23 00:09:42 +05:30
RSpec.describe 'Resolve an open thread in a merge request by creating an issue', :js do
2017-08-17 22:00:37 +05:30
let(:user) { create(:user) }
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, :repository, only_allow_merge_if_all_discussions_are_resolved: true) }
2017-08-17 22:00:37 +05:30
let(:merge_request) { create(:merge_request, source_project: project) }
let!(:discussion) { create(:diff_note_on_merge_request, noteable: merge_request, project: project).to_discussion }
2018-11-08 19:23:39 +05:30
def resolve_discussion_selector
2019-09-30 21:07:59 +05:30
title = 'Resolve this thread in a new issue'
2018-11-08 19:23:39 +05:30
url = new_project_issue_path(project, discussion_to_resolve: discussion.id, merge_request_to_resolve_discussions_of: merge_request.iid)
2020-03-13 15:44:24 +05:30
"a[title=\"#{title}\"][href=\"#{url}\"]"
2018-11-08 19:23:39 +05:30
end
2017-08-17 22:00:37 +05:30
describe 'As a user with access to the project' do
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2017-09-10 17:25:29 +05:30
sign_in user
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
context 'with the internal tracker disabled' do
before do
project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
2017-09-10 17:25:29 +05:30
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
it 'does not show a link to create a new issue' do
2018-11-08 19:23:39 +05:30
expect(page).not_to have_css resolve_discussion_selector
2017-08-17 22:00:37 +05:30
end
end
2019-09-30 21:07:59 +05:30
context 'resolving the thread' do
2017-08-17 22:00:37 +05:30
before do
2019-09-30 21:07:59 +05:30
click_button 'Resolve thread'
2017-08-17 22:00:37 +05:30
end
it 'hides the link for creating a new issue' do
2018-11-08 19:23:39 +05:30
expect(page).not_to have_css resolve_discussion_selector
2017-08-17 22:00:37 +05:30
end
2019-09-30 21:07:59 +05:30
it 'shows the link for creating a new issue when unresolving a thread' do
2017-08-17 22:00:37 +05:30
page.within '.diff-content' do
2019-09-30 21:07:59 +05:30
click_button 'Unresolve thread'
2017-08-17 22:00:37 +05:30
end
2018-11-08 19:23:39 +05:30
expect(page).to have_css resolve_discussion_selector
2017-08-17 22:00:37 +05:30
end
end
2019-09-30 21:07:59 +05:30
it 'has a link to create a new issue for a thread' do
2018-11-08 19:23:39 +05:30
expect(page).to have_css resolve_discussion_selector
2017-08-17 22:00:37 +05:30
end
context 'creating the issue' do
before do
2019-09-30 21:07:59 +05:30
find(resolve_discussion_selector, match: :first).click
2017-08-17 22:00:37 +05:30
end
2019-09-30 21:07:59 +05:30
it 'has a hidden field for the thread' do
2017-08-17 22:00:37 +05:30
discussion_field = find('#discussion_to_resolve', visible: false)
expect(discussion_field.value).to eq(discussion.id.to_s)
end
2019-09-30 21:07:59 +05:30
it_behaves_like 'creating an issue for a thread'
2017-08-17 22:00:37 +05:30
end
end
describe 'as a reporter' do
before do
2018-03-17 18:26:18 +05:30
project.add_reporter(user)
2017-09-10 17:25:29 +05:30
sign_in user
visit new_project_issue_path(project, merge_request_to_resolve_discussions_of: merge_request.iid,
discussion_to_resolve: discussion.id)
2017-08-17 22:00:37 +05:30
end
2019-09-30 21:07:59 +05:30
it 'Shows a notice to ask someone else to resolve the threads' do
expect(page).to have_content("The thread at #{merge_request.to_reference}"\
2017-08-17 22:00:37 +05:30
" (discussion #{discussion.first_note.id}) will stay unresolved."\
" Ask someone with permission to resolve it.")
end
end
end