debian-mirror-gitlab/spec/services/suggestions/create_service_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

205 lines
6.1 KiB
Ruby
Raw Normal View History

2019-02-15 15:39:39 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Suggestions::CreateService do
2019-02-15 15:39:39 +05:30
let(:project_with_repo) { create(:project, :repository) }
let(:merge_request) do
create(:merge_request, source_project: project_with_repo,
target_project: project_with_repo)
end
2019-07-07 11:18:12 +05:30
def build_position(args = {})
default_args = { old_path: "files/ruby/popen.rb",
new_path: "files/ruby/popen.rb",
old_line: nil,
new_line: 14,
diff_refs: merge_request.diff_refs }
Gitlab::Diff::Position.new(default_args.merge(args))
2019-02-15 15:39:39 +05:30
end
2019-07-07 11:18:12 +05:30
let(:position) { build_position }
2019-02-15 15:39:39 +05:30
let(:markdown) do
<<-MARKDOWN.strip_heredoc
```suggestion
foo
bar
```
```
nothing
```
```suggestion
xpto
baz
```
```thing
this is not a suggestion, it's a thing
```
2019-07-07 11:18:12 +05:30
```suggestion:-3+2
# multi-line suggestion 1
```
```suggestion:-5
# multi-line suggestion 1
```
2019-02-15 15:39:39 +05:30
MARKDOWN
end
subject { described_class.new(note) }
2021-03-11 19:13:27 +05:30
shared_examples_for 'service not tracking add suggestion event' do
it 'does not track add suggestion event' do
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
.not_to receive(:track_add_suggestion_action)
subject.execute
end
end
2019-02-15 15:39:39 +05:30
describe '#execute' do
context 'should not try to parse suggestions' do
context 'when not a diff note for merge requests' do
let(:note) do
create(:diff_note_on_commit, project: project_with_repo,
note: markdown)
end
it 'does not try to parse suggestions' do
2019-07-07 11:18:12 +05:30
expect(Gitlab::Diff::SuggestionsParser).not_to receive(:parse)
2019-02-15 15:39:39 +05:30
subject.execute
end
2021-03-11 19:13:27 +05:30
it_behaves_like 'service not tracking add suggestion event'
2019-02-15 15:39:39 +05:30
end
context 'when diff note is not for text' do
let(:note) do
create(:diff_note_on_merge_request, project: project_with_repo,
noteable: merge_request,
position: position,
note: markdown)
end
2021-03-11 19:13:27 +05:30
before do
2019-02-15 15:39:39 +05:30
allow(note).to receive(:on_text?) { false }
2021-03-11 19:13:27 +05:30
end
2019-02-15 15:39:39 +05:30
2021-03-11 19:13:27 +05:30
it 'does not try to parse suggestions' do
2019-07-07 11:18:12 +05:30
expect(Gitlab::Diff::SuggestionsParser).not_to receive(:parse)
2019-02-15 15:39:39 +05:30
subject.execute
end
2021-03-11 19:13:27 +05:30
it_behaves_like 'service not tracking add suggestion event'
2019-02-15 15:39:39 +05:30
end
end
2021-03-11 19:13:27 +05:30
context 'when diff file is not found' do
2019-05-18 00:54:41 +05:30
let(:note) do
create(:diff_note_on_merge_request, project: project_with_repo,
noteable: merge_request,
position: position,
note: markdown)
end
2021-03-11 19:13:27 +05:30
before do
2019-07-07 11:18:12 +05:30
expect_next_instance_of(DiffNote) do |diff_note|
2019-09-04 21:01:54 +05:30
expect(diff_note).to receive(:latest_diff_file).once { nil }
2019-05-30 16:15:17 +05:30
end
2021-03-11 19:13:27 +05:30
end
2019-02-15 15:39:39 +05:30
2021-03-11 19:13:27 +05:30
it 'creates no suggestion' do
2019-07-07 11:18:12 +05:30
expect { subject.execute }.not_to change(Suggestion, :count)
end
2021-03-11 19:13:27 +05:30
it_behaves_like 'service not tracking add suggestion event'
2019-07-07 11:18:12 +05:30
end
2019-02-15 15:39:39 +05:30
2019-07-07 11:18:12 +05:30
context 'should create suggestions' do
let(:note) do
create(:diff_note_on_merge_request, project: project_with_repo,
noteable: merge_request,
position: position,
note: markdown)
end
let(:expected_suggestions) do
Gitlab::Diff::SuggestionsParser.parse(markdown,
project: note.project,
position: note.position)
end
it 'persists suggestion records' do
expect { subject.execute }.to change { note.suggestions.count }
.from(0).to(expected_suggestions.size)
end
it 'persists suggestions data correctly' do
subject.execute
2019-05-18 00:54:41 +05:30
2019-07-07 11:18:12 +05:30
suggestions = note.suggestions.order(:relative_order)
2019-05-18 00:54:41 +05:30
2019-07-07 11:18:12 +05:30
suggestions.zip(expected_suggestions) do |suggestion, expected_suggestion|
expected_data = expected_suggestion.to_hash
2019-05-18 00:54:41 +05:30
2019-07-07 11:18:12 +05:30
expect(suggestion.from_content).to eq(expected_data[:from_content])
expect(suggestion.to_content).to eq(expected_data[:to_content])
expect(suggestion.lines_above).to eq(expected_data[:lines_above])
expect(suggestion.lines_below).to eq(expected_data[:lines_below])
end
end
2021-03-11 19:13:27 +05:30
it 'tracks add suggestion event' do
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
.to receive(:track_add_suggestion_action)
2021-11-11 11:23:49 +05:30
.with(note: note)
2021-03-11 19:13:27 +05:30
subject.execute
end
2019-07-07 11:18:12 +05:30
context 'outdated position note' do
let!(:outdated_diff) { merge_request.merge_request_diff }
let!(:latest_diff) { merge_request.create_merge_request_diff }
let(:outdated_position) { build_position(diff_refs: outdated_diff.diff_refs) }
let(:position) { build_position(diff_refs: latest_diff.diff_refs) }
it 'uses the correct position when creating the suggestion' do
expect(Gitlab::Diff::SuggestionsParser).to receive(:parse)
.with(note.note, project: note.project, position: note.position)
.and_call_original
subject.execute
2019-02-15 15:39:39 +05:30
end
end
2019-09-04 21:01:54 +05:30
context 'when a patch removes an empty line' do
let(:markdown) do
<<-MARKDOWN.strip_heredoc
```suggestion
```
MARKDOWN
end
2020-10-24 23:57:45 +05:30
2019-09-04 21:01:54 +05:30
let(:position) { build_position(new_line: 13) }
it 'creates an appliable suggestion' do
subject.execute
suggestion = note.suggestions.last
expect(suggestion).to be_appliable
expect(suggestion.from_content).to eq("\n")
expect(suggestion.to_content).to eq("")
end
end
2019-02-15 15:39:39 +05:30
end
end
end