2018-12-13 13:39:08 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe UserPreference do
|
2023-03-04 22:38:38 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:user_preference) { create(:user_preference, user: user) }
|
2019-03-02 22:35:43 +05:30
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
describe 'validations' do
|
|
|
|
describe 'diffs_deletion_color and diffs_addition_color' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(color: [
|
2022-11-25 23:54:43 +05:30
|
|
|
'#000000',
|
|
|
|
'#123456',
|
|
|
|
'#abcdef',
|
|
|
|
'#AbCdEf',
|
|
|
|
'#ffffff',
|
|
|
|
'#fFfFfF',
|
|
|
|
'#000',
|
|
|
|
'#123',
|
|
|
|
'#abc',
|
|
|
|
'#AbC',
|
|
|
|
'#fff',
|
|
|
|
'#fFf',
|
|
|
|
''
|
|
|
|
])
|
2022-06-21 17:19:12 +05:30
|
|
|
|
|
|
|
with_them do
|
|
|
|
it { is_expected.to allow_value(color).for(:diffs_deletion_color) }
|
|
|
|
it { is_expected.to allow_value(color).for(:diffs_addition_color) }
|
|
|
|
end
|
|
|
|
|
|
|
|
where(color: [
|
2022-11-25 23:54:43 +05:30
|
|
|
'#1',
|
|
|
|
'#12',
|
|
|
|
'#1234',
|
|
|
|
'#12345',
|
|
|
|
'#1234567',
|
|
|
|
'123456',
|
|
|
|
'#12345x'
|
|
|
|
])
|
2022-06-21 17:19:12 +05:30
|
|
|
|
|
|
|
with_them do
|
|
|
|
it { is_expected.not_to allow_value(color).for(:diffs_deletion_color) }
|
|
|
|
it { is_expected.not_to allow_value(color).for(:diffs_addition_color) }
|
|
|
|
end
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
|
|
|
describe 'use_legacy_web_ide' do
|
|
|
|
it { is_expected.to allow_value(true).for(:use_legacy_web_ide) }
|
|
|
|
it { is_expected.to allow_value(false).for(:use_legacy_web_ide) }
|
|
|
|
it { is_expected.not_to allow_value(nil).for(:use_legacy_web_ide) }
|
|
|
|
it { is_expected.not_to allow_value("").for(:use_legacy_web_ide) }
|
|
|
|
end
|
2022-06-21 17:19:12 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe 'notes filters global keys' do
|
|
|
|
it 'contains expected values' do
|
|
|
|
expect(UserPreference::NOTES_FILTERS.keys).to match_array([:all_notes, :only_comments, :only_activity])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
describe '#set_notes_filter' do
|
|
|
|
let(:issuable) { build_stubbed(:issue) }
|
|
|
|
|
|
|
|
shared_examples 'setting system notes' do
|
|
|
|
it 'returns updated discussion filter' do
|
|
|
|
filter_name =
|
|
|
|
user_preference.set_notes_filter(filter, issuable)
|
|
|
|
|
|
|
|
expect(filter_name).to eq(filter)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates discussion filter for issuable class' do
|
|
|
|
user_preference.set_notes_filter(filter, issuable)
|
|
|
|
|
|
|
|
expect(user_preference.reload.issue_notes_filter).to eq(filter)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when filter is set to all notes' do
|
|
|
|
let(:filter) { described_class::NOTES_FILTERS[:all_notes] }
|
|
|
|
|
|
|
|
it_behaves_like 'setting system notes'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when filter is set to only comments' do
|
|
|
|
let(:filter) { described_class::NOTES_FILTERS[:only_comments] }
|
|
|
|
|
|
|
|
it_behaves_like 'setting system notes'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when filter is set to only activity' do
|
|
|
|
let(:filter) { described_class::NOTES_FILTERS[:only_activity] }
|
|
|
|
|
|
|
|
it_behaves_like 'setting system notes'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notes_filter parameter is invalid' do
|
|
|
|
let(:only_comments) { described_class::NOTES_FILTERS[:only_comments] }
|
|
|
|
|
|
|
|
it 'returns the current notes filter' do
|
|
|
|
user_preference.set_notes_filter(only_comments, issuable)
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(user_preference.set_notes_filter(non_existing_record_id, issuable)).to eq(only_comments)
|
2018-12-13 13:39:08 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-03-02 22:35:43 +05:30
|
|
|
|
|
|
|
describe 'sort_by preferences' do
|
|
|
|
shared_examples_for 'a sort_by preference' do
|
|
|
|
it 'allows nil sort fields' do
|
2021-06-08 01:23:25 +05:30
|
|
|
user_preference.update!(attribute => nil)
|
2019-03-02 22:35:43 +05:30
|
|
|
|
|
|
|
expect(user_preference).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'merge_requests_sort attribute' do
|
|
|
|
let(:attribute) { :merge_requests_sort }
|
|
|
|
|
|
|
|
it_behaves_like 'a sort_by preference'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'issues_sort attribute' do
|
|
|
|
let(:attribute) { :issues_sort }
|
|
|
|
|
|
|
|
it_behaves_like 'a sort_by preference'
|
|
|
|
end
|
|
|
|
end
|
2019-07-31 22:56:46 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe '#tab_width' do
|
|
|
|
it 'is set to 8 by default' do
|
|
|
|
# Intentionally not using factory here to test the constructor.
|
2023-03-04 22:38:38 +05:30
|
|
|
pref = described_class.new
|
|
|
|
|
|
|
|
expect(pref.tab_width).to eq(8)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when assigning nil' do
|
|
|
|
pref = described_class.new(tab_width: nil)
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(pref.tab_width).to eq(8)
|
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
it 'returns default value when the value is NULL' do
|
|
|
|
pref = create(:user_preference, user: user)
|
|
|
|
pref.update_column(:tab_width, nil)
|
|
|
|
|
|
|
|
expect(pref.reload.tab_width).to eq(8)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it do
|
|
|
|
is_expected.to validate_numericality_of(:tab_width)
|
|
|
|
.only_integer
|
|
|
|
.is_greater_than_or_equal_to(1)
|
|
|
|
.is_less_than_or_equal_to(12)
|
|
|
|
end
|
|
|
|
end
|
2023-03-04 22:38:38 +05:30
|
|
|
|
|
|
|
describe '#tab_width=' do
|
|
|
|
it 'sets to default value when nil' do
|
|
|
|
pref = described_class.new(tab_width: nil)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:tab_width)).to eq(8)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets user values' do
|
|
|
|
pref = described_class.new(tab_width: 12)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:tab_width)).to eq(12)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#time_display_relative' do
|
|
|
|
it 'is set to true by default' do
|
|
|
|
pref = described_class.new
|
|
|
|
|
|
|
|
expect(pref.time_display_relative).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when assigning nil' do
|
|
|
|
pref = described_class.new(time_display_relative: nil)
|
|
|
|
|
|
|
|
expect(pref.time_display_relative).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when the value is NULL' do
|
|
|
|
pref = create(:user_preference, user: user)
|
|
|
|
pref.update_column(:time_display_relative, nil)
|
|
|
|
|
|
|
|
expect(pref.reload.time_display_relative).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns assigned value' do
|
|
|
|
pref = described_class.new(time_display_relative: false)
|
|
|
|
|
|
|
|
expect(pref.time_display_relative).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#time_display_relative=' do
|
|
|
|
it 'sets to default value when nil' do
|
|
|
|
pref = described_class.new(time_display_relative: nil)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:time_display_relative)).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets user values' do
|
|
|
|
pref = described_class.new(time_display_relative: false)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:time_display_relative)).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#time_format_in_24h' do
|
|
|
|
it 'is set to false by default' do
|
|
|
|
pref = described_class.new
|
|
|
|
|
|
|
|
expect(pref.time_format_in_24h).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when assigning nil' do
|
|
|
|
pref = described_class.new(time_format_in_24h: nil)
|
|
|
|
|
|
|
|
expect(pref.time_format_in_24h).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when the value is NULL' do
|
|
|
|
pref = create(:user_preference, user: user)
|
|
|
|
pref.update_column(:time_format_in_24h, nil)
|
|
|
|
|
|
|
|
expect(pref.reload.time_format_in_24h).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns assigned value' do
|
|
|
|
pref = described_class.new(time_format_in_24h: true)
|
|
|
|
|
|
|
|
expect(pref.time_format_in_24h).to eq(true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#time_format_in_24h=' do
|
|
|
|
it 'sets to default value when nil' do
|
|
|
|
pref = described_class.new(time_format_in_24h: nil)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:time_format_in_24h)).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets user values' do
|
|
|
|
pref = described_class.new(time_format_in_24h: true)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:time_format_in_24h)).to eq(true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#render_whitespace_in_code' do
|
|
|
|
it 'is set to false by default' do
|
|
|
|
pref = described_class.new
|
|
|
|
|
|
|
|
expect(pref.render_whitespace_in_code).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when assigning nil' do
|
|
|
|
pref = described_class.new(render_whitespace_in_code: nil)
|
|
|
|
|
|
|
|
expect(pref.render_whitespace_in_code).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default value when the value is NULL' do
|
|
|
|
pref = create(:user_preference, user: user)
|
|
|
|
pref.update_column(:render_whitespace_in_code, nil)
|
|
|
|
|
|
|
|
expect(pref.reload.render_whitespace_in_code).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns assigned value' do
|
|
|
|
pref = described_class.new(render_whitespace_in_code: true)
|
|
|
|
|
|
|
|
expect(pref.render_whitespace_in_code).to eq(true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#render_whitespace_in_code=' do
|
|
|
|
it 'sets to default value when nil' do
|
|
|
|
pref = described_class.new(render_whitespace_in_code: nil)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:render_whitespace_in_code)).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets user values' do
|
|
|
|
pref = described_class.new(render_whitespace_in_code: true)
|
|
|
|
|
|
|
|
expect(pref.read_attribute(:render_whitespace_in_code)).to eq(true)
|
|
|
|
end
|
|
|
|
end
|
2018-12-13 13:39:08 +05:30
|
|
|
end
|