2020-11-24 15:15:51 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe JiraConnect::SubscriptionsController do
|
|
|
|
let_it_be(:installation) { create(:jira_connect_installation) }
|
|
|
|
|
|
|
|
describe '#index' do
|
|
|
|
before do
|
2021-10-27 15:23:28 +05:30
|
|
|
request.headers['Accept'] = content_type
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
get :index, params: { jwt: jwt }
|
|
|
|
end
|
|
|
|
|
2021-10-27 15:23:28 +05:30
|
|
|
let(:content_type) { 'text/html' }
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'without JWT' do
|
|
|
|
let(:jwt) { nil }
|
|
|
|
|
|
|
|
it 'returns 403' do
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with valid JWT' do
|
|
|
|
let(:qsh) { Atlassian::Jwt.create_query_string_hash('https://gitlab.test/subscriptions', 'GET', 'https://gitlab.test') }
|
|
|
|
let(:jwt) { Atlassian::Jwt.encode({ iss: installation.client_key, qsh: qsh }, installation.shared_secret) }
|
|
|
|
|
|
|
|
it 'returns 200' do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes X-Frame-Options to allow rendering in iframe' do
|
|
|
|
expect(response.headers['X-Frame-Options']).to be_nil
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
|
|
|
|
context 'with JSON format' do
|
|
|
|
let_it_be(:subscription) { create(:jira_connect_subscription, installation: installation) }
|
|
|
|
|
|
|
|
let(:content_type) { 'application/json' }
|
|
|
|
|
|
|
|
it 'renders the relevant data as JSON', :aggregate_failures do
|
|
|
|
expect(json_response).to include('groups_path' => api_v4_groups_path(params: { min_access_level: Gitlab::Access::MAINTAINER, skip_groups: [subscription.namespace_id] }))
|
|
|
|
expect(json_response).to include(
|
|
|
|
'subscriptions' => [
|
|
|
|
'group' => {
|
|
|
|
'name' => subscription.namespace.name,
|
|
|
|
'avatar_url' => subscription.namespace.avatar_url,
|
|
|
|
'full_name' => subscription.namespace.full_name,
|
|
|
|
'description' => subscription.namespace.description
|
|
|
|
},
|
|
|
|
'created_at' => subscription.created_at.iso8601(3),
|
|
|
|
'unlink_path' => jira_connect_subscription_path(subscription)
|
|
|
|
]
|
|
|
|
)
|
|
|
|
expect(json_response).to include('subscriptions_path' => jira_connect_subscriptions_path)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when not signed in to GitLab' do
|
|
|
|
it 'contains a login path' do
|
|
|
|
expect(json_response).to include('login_path' => jira_connect_users_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when signed in to GitLab' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get :index, params: { jwt: jwt }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not contain a login path' do
|
|
|
|
expect(json_response).to include('login_path' => nil)
|
|
|
|
end
|
|
|
|
end
|
2022-06-21 17:19:12 +05:30
|
|
|
|
|
|
|
context 'with context qsh' do
|
|
|
|
# The JSON endpoint will be requested by frontend using a JWT that Atlassian provides via Javascript.
|
|
|
|
# This JWT will likely use a context-qsh because Atlassian don't know for which endpoint it will be used.
|
|
|
|
# Read more about context JWT here: https://developer.atlassian.com/cloud/jira/platform/understanding-jwt-for-connect-apps/
|
|
|
|
|
|
|
|
let(:qsh) { 'context-qsh' }
|
|
|
|
|
|
|
|
specify do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#create' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { post :create, params: { jwt: jwt, namespace_path: group.path, format: :json } }
|
|
|
|
|
|
|
|
context 'without JWT' do
|
|
|
|
let(:jwt) { nil }
|
|
|
|
|
|
|
|
it 'returns 403' do
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with valid JWT' do
|
2022-06-21 17:19:12 +05:30
|
|
|
let(:claims) { { iss: installation.client_key, sub: 1234, qsh: '123' } }
|
2021-09-04 01:27:46 +05:30
|
|
|
let(:jwt) { Atlassian::Jwt.encode(claims, installation.shared_secret) }
|
|
|
|
let(:jira_user) { { 'groups' => { 'items' => [{ 'name' => jira_group_name }] } } }
|
|
|
|
let(:jira_group_name) { 'site-admins' }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
context 'signed in to GitLab' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
2021-09-04 01:27:46 +05:30
|
|
|
WebMock
|
|
|
|
.stub_request(:get, "#{installation.base_url}/rest/api/3/user?accountId=1234&expand=groups")
|
|
|
|
.to_return(body: jira_user.to_json, status: 200, headers: { 'Content-Type' => 'application/json' })
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'dev panel integration is available' do
|
|
|
|
it 'creates a subscription' do
|
|
|
|
expect { subject }.to change { installation.subscriptions.count }.from(0).to(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 200' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
2021-09-04 01:27:46 +05:30
|
|
|
|
|
|
|
context 'when the Jira user is not a site-admin' do
|
|
|
|
let(:jira_group_name) { 'some-other-group' }
|
|
|
|
|
|
|
|
it 'returns forbidden' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
|
|
|
end
|
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'not signed in to GitLab' do
|
|
|
|
it 'returns 401' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:unauthorized)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#destroy' do
|
|
|
|
let(:subscription) { create(:jira_connect_subscription, installation: installation) }
|
2021-09-04 01:27:46 +05:30
|
|
|
let(:jira_user) { { 'groups' => { 'items' => [{ 'name' => jira_group_name }] } } }
|
|
|
|
let(:jira_group_name) { 'site-admins' }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
before do
|
2021-09-04 01:27:46 +05:30
|
|
|
WebMock
|
|
|
|
.stub_request(:get, "#{installation.base_url}/rest/api/3/user?accountId=1234&expand=groups")
|
|
|
|
.to_return(body: jira_user.to_json, status: 200, headers: { 'Content-Type' => 'application/json' })
|
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
delete :destroy, params: { jwt: jwt, id: subscription.id, format: :json }
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'without JWT' do
|
|
|
|
let(:jwt) { nil }
|
|
|
|
|
|
|
|
it 'returns 403' do
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with valid JWT' do
|
2022-06-21 17:19:12 +05:30
|
|
|
let(:claims) { { iss: installation.client_key, sub: 1234, qsh: '123' } }
|
2021-09-04 01:27:46 +05:30
|
|
|
let(:jwt) { Atlassian::Jwt.encode(claims, installation.shared_secret) }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
it 'deletes the subscription' do
|
|
|
|
expect { subscription.reload }.to raise_error ActiveRecord::RecordNotFound
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
2021-09-04 01:27:46 +05:30
|
|
|
|
|
|
|
context 'when the Jira user is not a site admin' do
|
|
|
|
let(:jira_group_name) { 'some-other-group' }
|
|
|
|
|
|
|
|
it 'does not delete the subscription' do
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
|
|
|
|
|
|
|
expect { subscription.reload }.not_to raise_error
|
|
|
|
end
|
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|