2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
describe Gitlab::Ci::Config::Entry::Cache do
|
2017-09-10 17:25:29 +05:30
|
|
|
subject(:entry) { described_class.new(config) }
|
2016-08-24 12:49:21 +05:30
|
|
|
|
|
|
|
describe 'validations' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
entry.compose!
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
|
|
|
|
context 'when entry config value is correct' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:policy) { nil }
|
2019-12-26 22:10:19 +05:30
|
|
|
let(:key) { 'some key' }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
let(:config) do
|
2019-12-26 22:10:19 +05:30
|
|
|
{ key: key,
|
2016-08-24 12:49:21 +05:30
|
|
|
untracked: true,
|
2017-09-10 17:25:29 +05:30
|
|
|
paths: ['some/path/'],
|
|
|
|
policy: policy }
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe '#value' do
|
2019-12-26 22:10:19 +05:30
|
|
|
shared_examples 'hash key value' do
|
|
|
|
it 'returns hash value' do
|
|
|
|
expect(entry.value).to eq(key: key, untracked: true, paths: ['some/path/'], policy: 'pull-push')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'hash key value'
|
|
|
|
|
|
|
|
context 'with files' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:key) { { files: %w[a-file other-file] } }
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
it_behaves_like 'hash key value'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with files and prefix' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:key) { { files: %w[a-file other-file], prefix: 'prefix-value' } }
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
it_behaves_like 'hash key value'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with prefix' do
|
|
|
|
let(:key) { { prefix: 'prefix-value' } }
|
|
|
|
|
|
|
|
it 'key is nil' do
|
|
|
|
expect(entry.value).to match(a_hash_including(key: nil))
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#valid?' do
|
2017-09-10 17:25:29 +05:30
|
|
|
it { is_expected.to be_valid }
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
context 'with files' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:key) { { files: %w[a-file other-file] } }
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'policy is pull-push' do
|
|
|
|
let(:policy) { 'pull-push' }
|
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
it { expect(entry.value).to include(policy: 'pull-push') }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'policy is push' do
|
|
|
|
let(:policy) { 'push' }
|
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
it { expect(entry.value).to include(policy: 'push') }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'policy is pull' do
|
|
|
|
let(:policy) { 'pull' }
|
|
|
|
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
it { expect(entry.value).to include(policy: 'pull') }
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
context 'when key is missing' do
|
|
|
|
let(:config) do
|
|
|
|
{ untracked: true,
|
|
|
|
paths: ['some/path/'] }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#value' do
|
|
|
|
it 'sets key with the default' do
|
|
|
|
expect(entry.value[:key])
|
|
|
|
.to eq(Gitlab::Ci::Config::Entry::Key.default)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when entry value is not correct' do
|
|
|
|
describe '#errors' do
|
2017-09-10 17:25:29 +05:30
|
|
|
subject { entry.errors }
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'when is not a hash' do
|
|
|
|
let(:config) { 'ls' }
|
|
|
|
|
|
|
|
it 'reports errors with config value' do
|
2017-09-10 17:25:29 +05:30
|
|
|
is_expected.to include 'cache config should be a hash'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when policy is unknown' do
|
|
|
|
let(:config) { { policy: "unknown" } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
is_expected.to include('cache policy should be pull-push, push, or pull')
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when descendants are invalid' do
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'with invalid keys' do
|
|
|
|
let(:config) { { key: 1 } }
|
2016-08-24 12:49:21 +05:30
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'reports error with descendants' do
|
|
|
|
is_expected.to include 'key should be a hash, a string or a symbol'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with empty key' do
|
|
|
|
let(:config) { { key: {} } }
|
|
|
|
|
|
|
|
it 'reports error with descendants' do
|
|
|
|
is_expected.to include 'key config missing required keys: files'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with invalid files' do
|
|
|
|
let(:config) { { key: { files: 'a-file' } } }
|
|
|
|
|
|
|
|
it 'reports error with descendants' do
|
|
|
|
is_expected.to include 'key:files config should be an array of strings'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with prefix without files' do
|
|
|
|
let(:config) { { key: { prefix: 'a-prefix' } } }
|
|
|
|
|
|
|
|
it 'reports error with descendants' do
|
|
|
|
is_expected.to include 'key config missing required keys: files'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is an unknown key present' do
|
|
|
|
let(:config) { { key: { unknown: 'a-file' } } }
|
|
|
|
|
|
|
|
it 'reports error with descendants' do
|
|
|
|
is_expected.to include 'key config contains unknown keys: unknown'
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is an unknown key present' do
|
|
|
|
let(:config) { { invalid: true } }
|
|
|
|
|
|
|
|
it 'reports error with descendants' do
|
2017-09-10 17:25:29 +05:30
|
|
|
is_expected.to include 'cache config contains unknown keys: invalid'
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|