2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.shared_examples_for 'snippet editor' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2020-01-01 13:55:28 +05:30
|
|
|
stub_feature_flags(snippets_vue: false)
|
2020-04-22 19:07:51 +05:30
|
|
|
stub_feature_flags(snippets_edit_vue: false)
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
def description_field
|
2020-04-08 14:13:33 +05:30
|
|
|
find('.js-description-input').find('input,textarea')
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
def fill_form
|
|
|
|
fill_in 'personal_snippet_title', with: 'My Snippet Title'
|
2020-03-13 15:44:24 +05:30
|
|
|
|
|
|
|
# Click placeholder first to expand full description field
|
|
|
|
description_field.click
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'personal_snippet_description', with: 'My Snippet **Description**'
|
2020-03-13 15:44:24 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
page.within('.file-editor') do
|
2020-05-24 23:13:21 +05:30
|
|
|
el = find('.inputarea')
|
2020-04-08 14:13:33 +05:30
|
|
|
el.send_keys 'Hello World!'
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'Authenticated user creates a snippet' do
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_form
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
page.within('.snippet-header .description') do
|
|
|
|
expect(page).to have_content('My Snippet Description')
|
|
|
|
expect(page).to have_selector('strong')
|
|
|
|
end
|
|
|
|
expect(page).to have_content('Hello World!')
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'previews a snippet with file' do
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
# Click placeholder first to expand full description field
|
|
|
|
description_field.click
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'personal_snippet_description', with: 'My Snippet'
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
find('.js-md-preview-button').click
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
page.within('#new_personal_snippet .md-preview-holder') do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(page).to have_content('My Snippet')
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
link = find('a.no-attachment-icon img.js-lazy-loaded[alt="banana_sample"]')['src']
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(link).to match(%r{/uploads/-/system/user/#{user.id}/\h{32}/banana_sample\.gif\z})
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
# Adds a cache buster for checking if the image exists as Selenium is now handling the cached regquests
|
|
|
|
# not anymore as requests when they come straight from memory cache.
|
|
|
|
reqs = inspect_requests { visit("#{link}?ran=#{SecureRandom.base64(20)}") }
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(reqs.first.status_code).to eq(200)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'uploads a file when dragging into textarea' do
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_form
|
|
|
|
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
|
|
|
|
expect(page.find_field("personal_snippet_description").value).to have_content('banana_sample')
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
link = find('a.no-attachment-icon img.js-lazy-loaded[alt="banana_sample"]')['src']
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).to match(%r{/uploads/-/system/personal_snippet/#{Snippet.last.id}/\h{32}/banana_sample\.gif\z})
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
reqs = inspect_requests { visit("#{link}?ran=#{SecureRandom.base64(20)}") }
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(reqs.first.status_code).to eq(200)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
context 'when the git operation fails' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:error) { 'Error creating the snippet' }
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow_next_instance_of(Snippets::CreateService) do |instance|
|
|
|
|
allow(instance).to receive(:create_commit).and_raise(StandardError, error)
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
fill_form
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'displays the error' do
|
|
|
|
expect(page).to have_content(error)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders new page' do
|
|
|
|
expect(page).to have_content('New Snippet')
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
it 'has the correct action path' do
|
|
|
|
action = find('form.snippet-form')['action']
|
|
|
|
expect(action).to match(%r{/snippets\z})
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'validation fails for the first time' do
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'personal_snippet_title', with: 'My Snippet Title'
|
|
|
|
click_button('Create snippet')
|
|
|
|
|
|
|
|
expect(page).to have_selector('#error_explanation')
|
|
|
|
|
|
|
|
fill_form
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
page.within('.snippet-header .description') do
|
|
|
|
expect(page).to have_content('My Snippet Description')
|
|
|
|
expect(page).to have_selector('strong')
|
|
|
|
end
|
|
|
|
expect(page).to have_content('Hello World!')
|
2020-04-08 14:13:33 +05:30
|
|
|
link = find('a.no-attachment-icon img.js-lazy-loaded[alt="banana_sample"]')['src']
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).to match(%r{/uploads/-/system/personal_snippet/#{Snippet.last.id}/\h{32}/banana_sample\.gif\z})
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
reqs = inspect_requests { visit("#{link}?ran=#{SecureRandom.base64(20)}") }
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(reqs.first.status_code).to eq(200)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'Authenticated user creates a snippet with + in filename' do
|
2020-06-23 00:09:42 +05:30
|
|
|
visit new_snippet_path
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'personal_snippet_title', with: 'My Snippet Title'
|
|
|
|
page.within('.file-editor') do
|
|
|
|
find(:xpath, "//input[@id='personal_snippet_file_name']").set 'snippet+file+name'
|
2020-05-24 23:13:21 +05:30
|
|
|
el = find('.inputarea')
|
2020-04-08 14:13:33 +05:30
|
|
|
el.send_keys 'Hello World!'
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
click_button 'Create snippet'
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
expect(page).to have_content('snippet+file+name')
|
|
|
|
expect(page).to have_content('Hello World!')
|
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
context 'when snippets default visibility level is restricted' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PRIVATE],
|
|
|
|
default_snippet_visibility: Gitlab::VisibilityLevel::PRIVATE)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a snippet using the lowest available visibility level as default' do
|
|
|
|
visit new_snippet_path
|
|
|
|
|
|
|
|
fill_form
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
visit snippets_path
|
|
|
|
click_link('Internal')
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
created_snippet = Snippet.last
|
|
|
|
expect(created_snippet.visibility_level).to eq(Gitlab::VisibilityLevel::INTERNAL)
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe 'User creates snippet', :js do
|
2020-04-08 14:13:33 +05:30
|
|
|
include DropzoneHelper
|
|
|
|
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
it_behaves_like "snippet editor"
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|