2018-11-18 11:00:15 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
module Issues
|
|
|
|
class UpdateService < Issues::BaseService
|
2020-10-04 03:57:07 +05:30
|
|
|
extend ::Gitlab::Utils::Override
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
# NOTE: For Issues::UpdateService, we default the spam_params to nil, because spam_checking is not
|
|
|
|
# necessary in many cases, and we don't want to require every caller to explicitly pass it as nil
|
|
|
|
# to disable spam checking.
|
|
|
|
def initialize(project:, current_user: nil, params: {}, spam_params: nil)
|
|
|
|
super(project: project, current_user: current_user, params: params)
|
|
|
|
@spam_params = spam_params
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
def execute(issue)
|
2018-03-17 18:26:18 +05:30
|
|
|
handle_move_between_ids(issue)
|
2021-03-11 19:13:27 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
change_issue_duplicate(issue)
|
2021-02-22 17:27:13 +05:30
|
|
|
move_issue_to_new_project(issue) || clone_issue(issue) || update_task_event(issue) || update(issue)
|
2015-11-26 14:37:03 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
def update(issue)
|
|
|
|
create_merge_request_from_quick_action
|
|
|
|
|
|
|
|
super
|
|
|
|
end
|
|
|
|
|
2019-09-30 21:07:59 +05:30
|
|
|
def before_update(issue, skip_spam_check: false)
|
2021-11-11 11:23:49 +05:30
|
|
|
change_work_item_type(issue)
|
|
|
|
|
2021-03-11 19:13:27 +05:30
|
|
|
return if skip_spam_check
|
|
|
|
|
|
|
|
Spam::SpamActionService.new(
|
|
|
|
spammable: issue,
|
2021-09-30 23:02:18 +05:30
|
|
|
spam_params: spam_params,
|
2021-03-11 19:13:27 +05:30
|
|
|
user: current_user,
|
|
|
|
action: :update
|
2021-09-30 23:02:18 +05:30
|
|
|
).execute
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def change_work_item_type(issue)
|
|
|
|
return unless issue.changed_attributes['issue_type']
|
|
|
|
|
|
|
|
type_id = find_work_item_type_id(issue.issue_type)
|
|
|
|
|
|
|
|
issue.work_item_type_id = type_id
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
def handle_changes(issue, options)
|
2021-09-04 01:27:46 +05:30
|
|
|
super
|
2018-03-17 18:26:18 +05:30
|
|
|
old_associations = options.fetch(:old_associations, {})
|
|
|
|
old_labels = old_associations.fetch(:labels, [])
|
|
|
|
old_mentioned_users = old_associations.fetch(:mentioned_users, [])
|
|
|
|
old_assignees = old_associations.fetch(:assignees, [])
|
2021-09-30 23:02:18 +05:30
|
|
|
old_severity = old_associations[:severity]
|
2022-03-02 08:16:31 +05:30
|
|
|
old_escalation_status = old_associations[:escalation_status]
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
if has_changes?(issue, old_labels: old_labels, old_assignees: old_assignees)
|
2020-06-23 00:09:42 +05:30
|
|
|
todo_service.resolve_todos_for_target(issue, current_user)
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
if issue.previous_changes.include?('title') ||
|
2017-08-17 22:00:37 +05:30
|
|
|
issue.previous_changes.include?('description')
|
|
|
|
todo_service.update_issue(issue, current_user, old_mentioned_users)
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
handle_assignee_changes(issue, old_assignees)
|
2021-11-11 11:23:49 +05:30
|
|
|
handle_confidential_change(issue)
|
|
|
|
handle_added_labels(issue, old_labels)
|
2018-12-13 13:39:08 +05:30
|
|
|
handle_milestone_change(issue)
|
2021-11-11 11:23:49 +05:30
|
|
|
handle_added_mentions(issue, old_mentioned_users)
|
2021-09-30 23:02:18 +05:30
|
|
|
handle_severity_change(issue, old_severity)
|
2022-03-02 08:16:31 +05:30
|
|
|
handle_escalation_status_change(issue, old_escalation_status)
|
2021-11-11 11:23:49 +05:30
|
|
|
handle_issue_type_change(issue)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
def handle_assignee_changes(issue, old_assignees)
|
|
|
|
return if issue.assignees == old_assignees
|
|
|
|
|
|
|
|
create_assignee_note(issue, old_assignees)
|
|
|
|
notification_service.async.reassigned_issue(issue, current_user, old_assignees)
|
|
|
|
todo_service.reassigned_assignable(issue, current_user, old_assignees)
|
|
|
|
track_incident_action(current_user, issue, :incident_assigned)
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
if Feature.enabled?(:broadcast_issue_updates, issue.project, default_enabled: :yaml)
|
2021-06-08 01:23:25 +05:30
|
|
|
GraphqlTriggers.issuable_assignees_updated(issue)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-03-02 22:35:43 +05:30
|
|
|
def handle_task_changes(issuable)
|
2020-06-23 00:09:42 +05:30
|
|
|
todo_service.resolve_todos_for_target(issuable, current_user)
|
2019-03-02 22:35:43 +05:30
|
|
|
todo_service.update_issue(issuable, current_user)
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
def handle_move_between_ids(issue)
|
2021-06-08 01:23:25 +05:30
|
|
|
issue.check_repositioning_allowed! if params[:move_between_ids]
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
super
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
rebalance_if_needed(issue)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
def positioning_scope_key
|
|
|
|
:board_group_id
|
|
|
|
end
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
2017-09-10 17:25:29 +05:30
|
|
|
def change_issue_duplicate(issue)
|
|
|
|
canonical_issue_id = params.delete(:canonical_issue_id)
|
2019-03-02 22:35:43 +05:30
|
|
|
return unless canonical_issue_id
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
canonical_issue = IssuesFinder.new(current_user).find_by(id: canonical_issue_id)
|
|
|
|
|
|
|
|
if canonical_issue
|
2021-06-08 01:23:25 +05:30
|
|
|
Issues::DuplicateService.new(project: project, current_user: current_user).execute(issue, canonical_issue)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
def move_issue_to_new_project(issue)
|
|
|
|
target_project = params.delete(:target_project)
|
|
|
|
|
|
|
|
return unless target_project &&
|
|
|
|
issue.can_move?(current_user, target_project) &&
|
|
|
|
target_project != issue.project
|
|
|
|
|
|
|
|
update(issue)
|
2021-06-08 01:23:25 +05:30
|
|
|
Issues::MoveService.new(project: project, current_user: current_user).execute(issue, target_project)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
private
|
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
attr_reader :spam_params
|
2021-03-11 19:13:27 +05:30
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
def clone_issue(issue)
|
|
|
|
target_project = params.delete(:target_clone_project)
|
|
|
|
with_notes = params.delete(:clone_with_notes)
|
|
|
|
|
|
|
|
return unless target_project &&
|
|
|
|
issue.can_clone?(current_user, target_project)
|
|
|
|
|
|
|
|
# we've pre-empted this from running in #execute, so let's go ahead and update the Issue now.
|
|
|
|
update(issue)
|
2021-06-08 01:23:25 +05:30
|
|
|
Issues::CloneService.new(project: project, current_user: current_user).execute(issue, target_project, with_notes: with_notes)
|
2021-02-22 17:27:13 +05:30
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
def create_merge_request_from_quick_action
|
|
|
|
create_merge_request_params = params.delete(:create_merge_request)
|
|
|
|
return unless create_merge_request_params
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
MergeRequests::CreateFromIssueService.new(project: project, current_user: current_user, mr_params: create_merge_request_params).execute
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def handle_confidential_change(issue)
|
|
|
|
if issue.previous_changes.include?('confidential')
|
|
|
|
# don't enqueue immediately to prevent todos removal in case of a mistake
|
|
|
|
TodosDestroyer::ConfidentialIssueWorker.perform_in(Todo::WAIT_FOR_DELETE, issue.id) if issue.confidential?
|
|
|
|
create_confidentiality_note(issue)
|
|
|
|
track_usage_event(:incident_management_incident_change_confidential, current_user.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def handle_added_labels(issue, old_labels)
|
|
|
|
added_labels = issue.labels - old_labels
|
|
|
|
|
|
|
|
if added_labels.present?
|
|
|
|
notification_service.async.relabeled_issue(issue, added_labels, current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
def handle_milestone_change(issue)
|
|
|
|
return unless issue.previous_changes.include?('milestone_id')
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
invalidate_milestone_issue_counters(issue)
|
|
|
|
send_milestone_change_notification(issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def invalidate_milestone_issue_counters(issue)
|
|
|
|
issue.previous_changes['milestone_id'].each do |milestone_id|
|
|
|
|
next unless milestone_id
|
|
|
|
|
|
|
|
milestone = Milestone.find_by_id(milestone_id)
|
|
|
|
|
|
|
|
delete_milestone_closed_issue_counter_cache(milestone)
|
|
|
|
delete_milestone_total_issue_counter_cache(milestone)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def send_milestone_change_notification(issue)
|
|
|
|
return if skip_milestone_email
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
if issue.milestone.nil?
|
|
|
|
notification_service.async.removed_milestone_issue(issue, current_user)
|
|
|
|
else
|
|
|
|
notification_service.async.changed_milestone_issue(issue, issue.milestone, current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def handle_added_mentions(issue, old_mentioned_users)
|
|
|
|
added_mentions = issue.mentioned_users(current_user) - old_mentioned_users
|
|
|
|
|
|
|
|
if added_mentions.present?
|
|
|
|
notification_service.async.new_mentions_in_issue(issue, added_mentions, current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
def handle_severity_change(issue, old_severity)
|
|
|
|
return unless old_severity && issue.severity != old_severity
|
|
|
|
|
|
|
|
::IncidentManagement::AddSeveritySystemNoteWorker.perform_async(issue.id, current_user.id)
|
|
|
|
end
|
|
|
|
|
2022-03-02 08:16:31 +05:30
|
|
|
def handle_escalation_status_change(issue, old_escalation_status)
|
|
|
|
return unless old_escalation_status.present?
|
|
|
|
return if issue.escalation_status&.slice(:status, :policy_id) == old_escalation_status
|
|
|
|
|
|
|
|
::IncidentManagement::IssuableEscalationStatuses::AfterUpdateService.new(issue, current_user).execute
|
|
|
|
end
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
2021-04-29 21:17:54 +05:30
|
|
|
def issuable_for_positioning(id, board_group_id = nil)
|
2018-05-01 15:08:00 +05:30
|
|
|
return unless id
|
|
|
|
|
|
|
|
issue =
|
|
|
|
if board_group_id
|
2018-05-09 12:01:36 +05:30
|
|
|
IssuesFinder.new(current_user, group_id: board_group_id, include_subgroups: true).find_by(id: id)
|
2018-05-01 15:08:00 +05:30
|
|
|
else
|
|
|
|
project.issues.find(id)
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
issue if can?(current_user, :update_issue, issue)
|
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
def create_confidentiality_note(issue)
|
|
|
|
SystemNoteService.change_issue_confidentiality(issue, issue.project, current_user)
|
|
|
|
end
|
2021-09-04 01:27:46 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def handle_issue_type_change(issue)
|
|
|
|
return unless issue.previous_changes.include?('issue_type')
|
|
|
|
|
|
|
|
do_handle_issue_type_change(issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def do_handle_issue_type_change(issue)
|
|
|
|
SystemNoteService.change_issue_type(issue, current_user)
|
2022-03-02 08:16:31 +05:30
|
|
|
|
|
|
|
::IncidentManagement::IssuableEscalationStatuses::CreateService.new(issue).execute if issue.supports_escalation?
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
Issues::UpdateService.prepend_mod_with('Issues::UpdateService')
|