2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
describe ProjectImportState, type: :model do
|
2020-04-22 19:07:51 +05:30
|
|
|
let_it_be(:correlation_id) { 'cid' }
|
|
|
|
let_it_be(:import_state, refind: true) { create(:import_state, correlation_id_value: correlation_id) }
|
|
|
|
|
|
|
|
subject { import_state }
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
describe 'associations' do
|
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'validations' do
|
|
|
|
it { is_expected.to validate_presence_of(:project) }
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
describe 'Project import job' do
|
2020-04-22 19:07:51 +05:30
|
|
|
let_it_be(:import_state) { create(:import_state, import_url: generate(:url)) }
|
|
|
|
let_it_be(:project) { import_state.project }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Gitlab::GitalyClient::RepositoryService).to receive(:import_repository)
|
|
|
|
.with(project.import_url).and_return(true)
|
|
|
|
|
|
|
|
# Works around https://github.com/rspec/rspec-mocks/issues/910
|
|
|
|
allow(Project).to receive(:find).with(project.id).and_return(project)
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(project).to receive(:after_import).and_call_original
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'imports a project', :sidekiq_might_not_need_inline do
|
2019-02-15 15:39:39 +05:30
|
|
|
expect(RepositoryImportWorker).to receive(:perform_async).and_call_original
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect { import_state.schedule }.to change { import_state.status }.from('none').to('finished')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'records job and correlation IDs', :sidekiq_might_not_need_inline do
|
|
|
|
allow(Labkit::Correlation::CorrelationId).to receive(:current_or_new_id).and_return(correlation_id)
|
|
|
|
|
|
|
|
import_state.schedule
|
|
|
|
|
|
|
|
expect(import_state.jid).to be_an_instance_of(String)
|
|
|
|
expect(import_state.correlation_id).to eq(correlation_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#relation_hard_failures' do
|
|
|
|
let_it_be(:failures) { create_list(:import_failure, 2, :hard_failure, project: import_state.project, correlation_id_value: correlation_id) }
|
|
|
|
|
|
|
|
it 'returns hard relation failures related to this import' do
|
|
|
|
expect(subject.relation_hard_failures(limit: 100)).to match_array(failures)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'limits returned collection to given maximum' do
|
|
|
|
expect(subject.relation_hard_failures(limit: 1).size).to eq(1)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
describe '#mark_as_failed' do
|
|
|
|
let(:error_message) { 'some message' }
|
|
|
|
|
|
|
|
it 'logs error when update column fails' do
|
|
|
|
allow(import_state).to receive(:update_column).and_raise(ActiveRecord::ActiveRecordError)
|
|
|
|
|
|
|
|
expect_next_instance_of(Gitlab::Import::Logger) do |logger|
|
|
|
|
expect(logger).to receive(:error).with(
|
|
|
|
error: 'ActiveRecord::ActiveRecordError',
|
|
|
|
message: 'Error setting import status to failed',
|
|
|
|
original_error: error_message
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
import_state.mark_as_failed(error_message)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates last_error with error message' do
|
|
|
|
import_state.mark_as_failed(error_message)
|
|
|
|
|
|
|
|
expect(import_state.last_error).to eq(error_message)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
describe '#human_status_name' do
|
|
|
|
context 'when import_state exists' do
|
|
|
|
it 'returns the humanized status name' do
|
|
|
|
import_state = build(:import_state, :started)
|
|
|
|
|
|
|
|
expect(import_state.human_status_name).to eq("started")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'import state transitions' do
|
|
|
|
context 'state transition: [:started] => [:finished]' do
|
|
|
|
let(:after_import_service) { spy(:after_import_service) }
|
|
|
|
let(:housekeeping_service) { spy(:housekeeping_service) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Projects::AfterImportService)
|
|
|
|
.to receive(:new) { after_import_service }
|
|
|
|
|
|
|
|
allow(after_import_service)
|
|
|
|
.to receive(:execute) { housekeeping_service.execute }
|
|
|
|
|
|
|
|
allow(Projects::HousekeepingService)
|
|
|
|
.to receive(:new) { housekeeping_service }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'resets last_error' do
|
|
|
|
error_message = 'Some error'
|
|
|
|
import_state = create(:import_state, :started, last_error: error_message)
|
|
|
|
|
|
|
|
expect { import_state.finish }.to change { import_state.last_error }.from(error_message).to(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'performs housekeeping when an import of a fresh project is completed' do
|
|
|
|
project = create(:project_empty_repo, :import_started, import_type: :github)
|
|
|
|
|
|
|
|
project.import_state.finish
|
|
|
|
|
|
|
|
expect(after_import_service).to have_received(:execute)
|
|
|
|
expect(housekeeping_service).to have_received(:execute)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not perform housekeeping when project repository does not exist' do
|
|
|
|
project = create(:project, :import_started, import_type: :github)
|
|
|
|
|
|
|
|
project.import_state.finish
|
|
|
|
|
|
|
|
expect(housekeeping_service).not_to have_received(:execute)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not perform housekeeping when project does not have a valid import type' do
|
|
|
|
project = create(:project, :import_started, import_type: nil)
|
|
|
|
|
|
|
|
project.import_state.finish
|
|
|
|
|
|
|
|
expect(housekeeping_service).not_to have_received(:execute)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
describe 'clearing `jid` after finish', :clean_gitlab_redis_cache do
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'without an JID' do
|
|
|
|
it 'does nothing' do
|
2020-01-01 13:55:28 +05:30
|
|
|
import_state = create(:import_state, :started)
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
expect(Gitlab::SidekiqStatus)
|
|
|
|
.not_to receive(:unset)
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
import_state.finish!
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an JID' do
|
|
|
|
it 'unsets the JID' do
|
2020-01-01 13:55:28 +05:30
|
|
|
import_state = create(:import_state, :started, jid: '123')
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
expect(Gitlab::SidekiqStatus)
|
|
|
|
.to receive(:unset)
|
|
|
|
.with('123')
|
|
|
|
.and_call_original
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
import_state.finish!
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
expect(import_state.jid).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|