debian-mirror-gitlab/spec/lib/banzai/reference_parser/base_parser_spec.rb

363 lines
10 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Banzai::ReferenceParser::BaseParser do
include ReferenceParserHelpers
let(:user) { create(:user) }
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, :public) }
2018-05-09 12:01:36 +05:30
let(:context) { Banzai::RenderContext.new(project, user) }
2020-10-24 23:57:45 +05:30
let(:parser_class) do
Class.new(described_class) do
self.reference_type = :foo
end
2020-10-24 23:57:45 +05:30
end
2020-10-24 23:57:45 +05:30
subject do
parser_class.new(context)
end
describe '.reference_type=' do
it 'sets the reference type' do
dummy = Class.new(described_class)
dummy.reference_type = :foo
expect(dummy.reference_type).to eq(:foo)
end
end
2018-05-09 12:01:36 +05:30
describe '#project_for_node' do
it 'returns the Project for a node' do
document = instance_double('document', fragment?: false)
project = instance_double('project')
object = instance_double('object', project: project)
node = instance_double('node', document: document)
context.associate_document(document, object)
expect(subject.project_for_node(node)).to eq(project)
end
end
describe '#nodes_visible_to_user' do
let(:link) { empty_html_link }
context 'when the link has a data-project attribute' do
2020-10-24 23:57:45 +05:30
before do
link['data-project'] = project.id.to_s
2020-10-24 23:57:45 +05:30
end
2020-10-24 23:57:45 +05:30
it 'includes the link if can_read_reference? returns true' do
expect(subject).to receive(:can_read_reference?).with(user, project, link).and_return(true)
2020-10-24 23:57:45 +05:30
expect(subject.nodes_visible_to_user(user, [link])).to contain_exactly(link)
end
it 'excludes the link if can_read_reference? returns false' do
expect(subject).to receive(:can_read_reference?).with(user, project, link).and_return(false)
expect(subject.nodes_visible_to_user(user, [link])).to be_empty
end
end
context 'when the link does not have a data-project attribute' do
it 'returns the nodes' do
expect(subject.nodes_visible_to_user(user, [link])).to eq([link])
end
end
end
describe '#nodes_user_can_reference' do
it 'returns the nodes' do
link = double(:link)
expect(subject.nodes_user_can_reference(user, [link])).to eq([link])
end
end
describe '#referenced_by' do
context 'when references_relation is implemented' do
2021-09-30 23:02:18 +05:30
context 'and ids_only is set to false' do
it 'returns a collection of objects' do
links = Nokogiri::HTML.fragment("<a data-foo='#{user.id}'></a>")
.children
2021-09-30 23:02:18 +05:30
expect(subject).to receive(:references_relation).and_return(User)
expect(subject.referenced_by(links)).to eq([user])
end
end
context 'and ids_only is set to true' do
it 'returns a collection of id values without performing a db query' do
links = Nokogiri::HTML.fragment("<a data-foo='1'></a><a data-foo='2'></a>").children
expect(subject).not_to receive(:references_relation)
expect(subject.referenced_by(links, ids_only: true)).to eq(%w(1 2))
end
context 'and the html fragment does not contain any attributes' do
it 'returns an empty array' do
links = Nokogiri::HTML.fragment("no links").children
expect(subject.referenced_by(links, ids_only: true)).to eq([])
end
end
end
end
context 'when references_relation is not implemented' do
it 'raises NotImplementedError' do
links = Nokogiri::HTML.fragment('<a data-foo="1"></a>').children
2017-09-10 17:25:29 +05:30
expect { subject.referenced_by(links) }
.to raise_error(NotImplementedError)
end
end
end
describe '#references_relation' do
it 'raises NotImplementedError' do
expect { subject.references_relation }.to raise_error(NotImplementedError)
end
end
describe '#gather_attributes_per_project' do
it 'returns a Hash containing attribute values per project' do
2017-09-10 17:25:29 +05:30
link = Nokogiri::HTML.fragment('<a data-project="1" data-foo="2"></a>')
.children[0]
hash = subject.gather_attributes_per_project([link], 'data-foo')
expect(hash).to be_an_instance_of(Hash)
expect(hash[1].to_a).to eq(['2'])
end
end
describe '#grouped_objects_for_nodes' do
2017-08-17 22:00:37 +05:30
it 'returns a Hash grouping objects per node' do
link = double(:link)
2017-09-10 17:25:29 +05:30
expect(link).to receive(:has_attribute?)
.with('data-user')
.and_return(true)
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(link).to receive(:attr)
.with('data-user')
.and_return(user.id.to_s)
2017-08-17 22:00:37 +05:30
nodes = [link]
2017-09-10 17:25:29 +05:30
expect(subject).to receive(:unique_attribute_values)
.with(nodes, 'data-user')
.and_return([user.id.to_s])
hash = subject.grouped_objects_for_nodes(nodes, User, 'data-user')
2017-08-17 22:00:37 +05:30
expect(hash).to eq({ link => user })
end
2017-09-10 17:25:29 +05:30
it 'returns an empty Hash when entry does not exist in the database', :request_store do
2017-08-17 22:00:37 +05:30
link = double(:link)
2017-09-10 17:25:29 +05:30
expect(link).to receive(:has_attribute?)
.with('data-user')
.and_return(true)
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(link).to receive(:attr)
.with('data-user')
.and_return('1')
2017-08-17 22:00:37 +05:30
nodes = [link]
bad_id = user.id + 100
2017-09-10 17:25:29 +05:30
expect(subject).to receive(:unique_attribute_values)
.with(nodes, 'data-user')
.and_return([bad_id.to_s])
2017-08-17 22:00:37 +05:30
hash = subject.grouped_objects_for_nodes(nodes, User, 'data-user')
expect(hash).to eq({})
end
end
describe '#unique_attribute_values' do
it 'returns an Array of unique values' do
link = double(:link)
2017-09-10 17:25:29 +05:30
expect(link).to receive(:has_attribute?)
.with('data-foo')
.twice
.and_return(true)
2017-09-10 17:25:29 +05:30
expect(link).to receive(:attr)
.with('data-foo')
.twice
.and_return('1')
nodes = [link, link]
expect(subject.unique_attribute_values(nodes, 'data-foo')).to eq(['1'])
end
end
describe '#process' do
it 'gathers the references for every node matching the reference type' do
dummy = Class.new(described_class) do
self.reference_type = :test
2021-09-30 23:02:18 +05:30
def gather_references(nodes, ids_only: false)
2020-10-24 23:57:45 +05:30
nodes
end
end
2020-10-24 23:57:45 +05:30
instance = dummy.new(context)
document_a = Nokogiri::HTML.fragment(<<-FRAG)
<a class="gfm">one</a>
<a class="gfm" data-reference-type="test">two</a>
<a class="gfm" data-reference-type="other">three</a>
FRAG
document_b = Nokogiri::HTML.fragment(<<-FRAG)
<a class="gfm" data-reference-type="test">four</a>
FRAG
document_c = Nokogiri::HTML.fragment('')
expect(instance.process([document_a, document_b, document_c]))
.to contain_exactly(document_a.css('a')[1], document_b.css('a')[0])
end
end
describe '#gather_references' do
2020-10-24 23:57:45 +05:30
let(:nodes) { (1..10).map { |n| double(:link, id: n) } }
2020-10-24 23:57:45 +05:30
let(:parser_class) do
Class.new(described_class) do
def nodes_user_can_reference(_user, nodes)
nodes.select { |n| n.id.even? }
end
2020-10-24 23:57:45 +05:30
def nodes_visible_to_user(_user, nodes)
nodes.select { |n| n.id > 5 }
end
2021-09-30 23:02:18 +05:30
def referenced_by(nodes, ids_only: false)
2020-10-24 23:57:45 +05:30
nodes.map(&:id)
end
end
end
2020-10-24 23:57:45 +05:30
it 'returns referenceable and visible objects, alongside nodes that are referenceable but not visible' do
expect(subject.gather_references(nodes)).to match(
visible: contain_exactly(6, 8, 10),
not_visible: match_array(nodes.select { |n| n.id.even? && n.id <= 5 })
)
end
2020-10-24 23:57:45 +05:30
it 'is always empty if the input is empty' do
expect(subject.gather_references([])) .to match(visible: be_empty, not_visible: be_empty)
end
end
describe '#can?' do
it 'delegates the permissions check to the Ability class' do
user = double(:user)
2017-09-10 17:25:29 +05:30
expect(Ability).to receive(:allowed?)
.with(user, :read_project, project)
subject.can?(user, :read_project, project)
end
end
describe '#find_projects_for_hash_keys' do
it 'returns a list of Projects' do
2017-09-10 17:25:29 +05:30
expect(subject.find_projects_for_hash_keys(project.id => project))
.to eq([project])
end
end
2016-08-24 12:49:21 +05:30
describe '#collection_objects_for_ids' do
context 'with RequestStore disabled' do
it 'queries the collection directly' do
collection = User.all
expect(collection).to receive(:where).twice.and_call_original
2.times do
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(collection, [user.id]))
.to eq([user])
2016-08-24 12:49:21 +05:30
end
end
end
2018-12-05 23:21:45 +05:30
context 'with RequestStore enabled', :request_store do
2016-08-24 12:49:21 +05:30
before do
cache = Hash.new { |hash, key| hash[key] = {} }
allow(subject).to receive(:collection_cache).and_return(cache)
end
it 'queries the collection on the first call' do
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(User, [user.id]))
.to eq([user])
2016-08-24 12:49:21 +05:30
end
it 'does not query previously queried objects' do
collection = User.all
expect(collection).to receive(:where).once.and_call_original
2.times do
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(collection, [user.id]))
.to eq([user])
2016-08-24 12:49:21 +05:30
end
end
it 'casts String based IDs to Fixnums before querying objects' do
2.times do
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(User, [user.id.to_s]))
.to eq([user])
2016-08-24 12:49:21 +05:30
end
end
it 'queries any additional objects after the first call' do
other_user = create(:user)
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(User, [user.id]))
.to eq([user])
2016-08-24 12:49:21 +05:30
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(User, [user.id, other_user.id]))
.to eq([user, other_user])
2016-08-24 12:49:21 +05:30
end
it 'caches objects on a per collection class basis' do
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(User, [user.id]))
.to eq([user])
2016-08-24 12:49:21 +05:30
2017-09-10 17:25:29 +05:30
expect(subject.collection_objects_for_ids(Project, [project.id]))
.to eq([project])
2016-08-24 12:49:21 +05:30
end
2020-03-13 15:44:24 +05:30
it 'will not overflow the stack' do
ids = 1.upto(1_000_000).to_a
2021-01-29 00:20:46 +05:30
# Avoid executing a large, unnecessary SQL query
expect(User).to receive(:where).with(id: ids).and_return(User.none)
2020-03-13 15:44:24 +05:30
expect { subject.collection_objects_for_ids(User, ids) }.not_to raise_error
end
2016-08-24 12:49:21 +05:30
end
end
describe '#collection_cache_key' do
it 'returns the cache key for a Class' do
expect(subject.collection_cache_key(Project)).to eq(Project)
end
it 'returns the cache key for an ActiveRecord::Relation' do
expect(subject.collection_cache_key(Project.all)).to eq(Project)
end
end
end