2020-04-08 14:13:33 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'fast_spec_helper'
|
|
|
|
|
|
|
|
require_relative '../../../../rubocop/cop/migration/schedule_async'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do
|
2020-04-08 14:13:33 +05:30
|
|
|
let(:cop) { described_class.new }
|
|
|
|
let(:source) do
|
|
|
|
<<~SOURCE
|
|
|
|
def up
|
|
|
|
BackgroundMigrationWorker.perform_async(ClazzName, "Bar", "Baz")
|
|
|
|
end
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'a disabled cop' do
|
|
|
|
it 'does not register any offenses' do
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_no_offenses(source)
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'outside of a migration' do
|
|
|
|
it_behaves_like 'a disabled cop'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'in a migration' do
|
|
|
|
before do
|
|
|
|
allow(cop).to receive(:in_migration?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'in an old migration' do
|
|
|
|
before do
|
|
|
|
allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE - 5)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a disabled cop'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'that is recent' do
|
|
|
|
before do
|
|
|
|
allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE + 5)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'BackgroundMigrationWorker.perform_async' do
|
2021-04-17 20:07:23 +05:30
|
|
|
it 'adds an offense when calling `BackgroundMigrationWorker.peform_async` and corrects', :aggregate_failures do
|
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
def up
|
|
|
|
BackgroundMigrationWorker.perform_async(ClazzName, "Bar", "Baz")
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't call [...]
|
|
|
|
end
|
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_correction(<<~RUBY)
|
|
|
|
def up
|
|
|
|
migrate_async(ClazzName, "Bar", "Baz")
|
|
|
|
end
|
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'BackgroundMigrationWorker.perform_in' do
|
2021-04-17 20:07:23 +05:30
|
|
|
it 'adds an offense and corrects', :aggregate_failures do
|
|
|
|
expect_offense(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
BackgroundMigrationWorker
|
2021-04-17 20:07:23 +05:30
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^ Don't call [...]
|
2020-04-08 14:13:33 +05:30
|
|
|
.perform_in(delay, ClazzName, "Bar", "Baz")
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_correction(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
migrate_in(delay, ClazzName, "Bar", "Baz")
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'BackgroundMigrationWorker.bulk_perform_async' do
|
2021-04-17 20:07:23 +05:30
|
|
|
it 'adds an offense and corrects', :aggregate_failures do
|
|
|
|
expect_offense(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
BackgroundMigrationWorker
|
2021-04-17 20:07:23 +05:30
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^ Don't call [...]
|
2020-04-08 14:13:33 +05:30
|
|
|
.bulk_perform_async(jobs)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_correction(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
bulk_migrate_async(jobs)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'BackgroundMigrationWorker.bulk_perform_in' do
|
2021-04-17 20:07:23 +05:30
|
|
|
it 'adds an offense and corrects', :aggregate_failures do
|
|
|
|
expect_offense(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
BackgroundMigrationWorker
|
2021-04-17 20:07:23 +05:30
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^ Don't call [...]
|
2020-04-08 14:13:33 +05:30
|
|
|
.bulk_perform_in(5.minutes, jobs)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_correction(<<~RUBY)
|
2020-04-08 14:13:33 +05:30
|
|
|
def up
|
|
|
|
bulk_migrate_in(5.minutes, jobs)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
RUBY
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|