2020-10-24 23:57:45 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe API::Internal::Kubernetes do
|
2020-11-24 15:15:51 +05:30
|
|
|
let(:jwt_auth_headers) do
|
|
|
|
jwt_token = JWT.encode({ 'iss' => Gitlab::Kas::JWT_ISSUER }, Gitlab::Kas.secret, 'HS256')
|
|
|
|
|
|
|
|
{ Gitlab::Kas::INTERNAL_API_REQUEST_HEADER => jwt_token }
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:jwt_secret) { SecureRandom.random_bytes(Gitlab::Kas::SECRET_LENGTH) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Gitlab::Kas).to receive(:secret).and_return(jwt_secret)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'authorization' do
|
|
|
|
context 'not authenticated' do
|
|
|
|
it 'returns 401' do
|
|
|
|
send_request(headers: { Gitlab::Kas::INTERNAL_API_REQUEST_HEADER => '' })
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:unauthorized)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
context 'kubernetes_agent_internal_api feature flag disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(kubernetes_agent_internal_api: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
shared_examples 'agent authentication' do
|
2021-04-29 21:17:54 +05:30
|
|
|
it 'returns 401 if Authorization header not sent' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:unauthorized)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
it 'returns 401 if Authorization is for non-existent agent' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(headers: { 'Authorization' => 'Bearer NONEXISTENT' })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:unauthorized)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'agent token tracking' do
|
|
|
|
it 'tracks token usage' do
|
|
|
|
expect { response }.to change { agent_token.reload.read_attribute(:last_used_at) }
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST /internal/kubernetes/usage_metrics' do
|
|
|
|
def send_request(headers: {}, params: {})
|
|
|
|
post api('/internal/kubernetes/usage_metrics'), params: params, headers: headers.reverse_merge(jwt_auth_headers)
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'authorization'
|
|
|
|
|
|
|
|
context 'is authenticated for an agent' do
|
|
|
|
let!(:agent_token) { create(:cluster_agent_token) }
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
it 'returns no_content for valid events' do
|
|
|
|
send_request(params: { gitops_sync_count: 10, k8s_api_proxy_request_count: 5 })
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:no_content)
|
|
|
|
end
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
it 'returns no_content for counts of zero' do
|
|
|
|
send_request(params: { gitops_sync_count: 0, k8s_api_proxy_request_count: 0 })
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:no_content)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 400 for non number' do
|
2021-06-08 01:23:25 +05:30
|
|
|
send_request(params: { gitops_sync_count: 'string', k8s_api_proxy_request_count: 1 })
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 400 for negative number' do
|
2021-06-08 01:23:25 +05:30
|
|
|
send_request(params: { gitops_sync_count: -1, k8s_api_proxy_request_count: 1 })
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
describe 'GET /internal/kubernetes/agent_info' do
|
2020-11-24 15:15:51 +05:30
|
|
|
def send_request(headers: {}, params: {})
|
|
|
|
get api('/internal/kubernetes/agent_info'), params: params, headers: headers.reverse_merge(jwt_auth_headers)
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'authorization'
|
|
|
|
include_examples 'agent authentication'
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
context 'an agent is found' do
|
|
|
|
let!(:agent_token) { create(:cluster_agent_token) }
|
|
|
|
|
|
|
|
let(:agent) { agent_token.agent }
|
|
|
|
let(:project) { agent.project }
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
shared_examples 'agent token tracking'
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it 'returns expected data', :aggregate_failures do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:success)
|
|
|
|
|
|
|
|
expect(json_response).to match(
|
|
|
|
a_hash_including(
|
|
|
|
'project_id' => project.id,
|
|
|
|
'agent_id' => agent.id,
|
|
|
|
'agent_name' => agent.name,
|
|
|
|
'gitaly_info' => a_hash_including(
|
|
|
|
'address' => match(/\.socket$/),
|
|
|
|
'token' => 'secret',
|
|
|
|
'features' => {}
|
|
|
|
),
|
|
|
|
'gitaly_repository' => a_hash_including(
|
|
|
|
'storage_name' => project.repository_storage,
|
|
|
|
'relative_path' => project.disk_path + '.git',
|
|
|
|
'gl_repository' => "project-#{project.id}",
|
|
|
|
'gl_project_path' => project.full_path
|
|
|
|
)
|
|
|
|
)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET /internal/kubernetes/project_info' do
|
2020-11-24 15:15:51 +05:30
|
|
|
def send_request(headers: {}, params: {})
|
|
|
|
get api('/internal/kubernetes/project_info'), params: params, headers: headers.reverse_merge(jwt_auth_headers)
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
include_examples 'authorization'
|
|
|
|
include_examples 'agent authentication'
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
context 'an agent is found' do
|
2021-02-22 17:27:13 +05:30
|
|
|
let_it_be(:agent_token) { create(:cluster_agent_token) }
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
shared_examples 'agent token tracking'
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
context 'project is public' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
it 'returns expected data', :aggregate_failures do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(params: { id: project.id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:success)
|
|
|
|
|
|
|
|
expect(json_response).to match(
|
|
|
|
a_hash_including(
|
|
|
|
'project_id' => project.id,
|
|
|
|
'gitaly_info' => a_hash_including(
|
|
|
|
'address' => match(/\.socket$/),
|
|
|
|
'token' => 'secret',
|
|
|
|
'features' => {}
|
|
|
|
),
|
|
|
|
'gitaly_repository' => a_hash_including(
|
|
|
|
'storage_name' => project.repository_storage,
|
|
|
|
'relative_path' => project.disk_path + '.git',
|
|
|
|
'gl_repository' => "project-#{project.id}",
|
|
|
|
'gl_project_path' => project.full_path
|
|
|
|
)
|
|
|
|
)
|
|
|
|
)
|
|
|
|
end
|
2020-11-05 12:06:23 +05:30
|
|
|
|
|
|
|
context 'repository is for project members only' do
|
|
|
|
let(:project) { create(:project, :public, :repository_private) }
|
|
|
|
|
|
|
|
it 'returns 404' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(params: { id: project.id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-11-05 12:06:23 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'project is private' do
|
|
|
|
let(:project) { create(:project, :private) }
|
|
|
|
|
|
|
|
it 'returns 404' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(params: { id: project.id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
2021-02-22 17:27:13 +05:30
|
|
|
|
|
|
|
context 'and agent belongs to project' do
|
|
|
|
let(:agent_token) { create(:cluster_agent_token, agent: create(:cluster_agent, project: project)) }
|
|
|
|
|
|
|
|
it 'returns 200' do
|
|
|
|
send_request(params: { id: project.id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:success)
|
|
|
|
end
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'project is internal' do
|
|
|
|
let(:project) { create(:project, :internal) }
|
|
|
|
|
|
|
|
it 'returns 404' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(params: { id: project.id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'project does not exist' do
|
|
|
|
it 'returns 404' do
|
2020-11-24 15:15:51 +05:30
|
|
|
send_request(params: { id: non_existing_record_id }, headers: { 'Authorization' => "Bearer #{agent_token.token}" })
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|