debian-mirror-gitlab/spec/requests/api/access_requests_spec.rb

272 lines
9.8 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2016-09-13 17:45:13 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe API::AccessRequests do
2020-03-13 15:44:24 +05:30
let_it_be(:maintainer) { create(:user) }
let_it_be(:developer) { create(:user) }
let_it_be(:access_requester) { create(:user) }
let_it_be(:stranger) { create(:user) }
2016-09-13 17:45:13 +05:30
2020-03-13 15:44:24 +05:30
let_it_be(:project) do
2019-12-21 20:55:43 +05:30
create(:project, :public, creator_id: maintainer.id, namespace: maintainer.namespace) do |project|
2018-03-17 18:26:18 +05:30
project.add_developer(developer)
2018-11-18 11:00:15 +05:30
project.add_maintainer(maintainer)
2017-08-17 22:00:37 +05:30
project.request_access(access_requester)
end
2016-09-13 17:45:13 +05:30
end
2020-03-13 15:44:24 +05:30
let_it_be(:group) do
2019-12-21 20:55:43 +05:30
create(:group, :public) do |group|
2017-08-17 22:00:37 +05:30
group.add_developer(developer)
2018-11-18 11:00:15 +05:30
group.add_owner(maintainer)
2017-08-17 22:00:37 +05:30
group.request_access(access_requester)
end
2016-09-13 17:45:13 +05:30
end
shared_examples 'GET /:sources/:id/access_requests' do |source_type|
context "with :sources == #{source_type.pluralize}" do
it_behaves_like 'a 404 response when source is private' do
let(:route) { get api("/#{source_type.pluralize}/#{source.id}/access_requests", stranger) }
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a non-maintainer/owner' do
2016-09-13 17:45:13 +05:30
%i[developer access_requester stranger].each do |type|
context "as a #{type}" do
it 'returns 403' do
user = public_send(type)
get api("/#{source_type.pluralize}/#{source.id}/access_requests", user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-09-13 17:45:13 +05:30
end
end
end
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a maintainer/owner' do
2016-09-13 17:45:13 +05:30
it 'returns access requesters' do
2018-11-18 11:00:15 +05:30
get api("/#{source_type.pluralize}/#{source.id}/access_requests", maintainer)
2016-09-13 17:45:13 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-09-13 17:45:13 +05:30
expect(json_response).to be_an Array
expect(json_response.size).to eq(1)
end
end
end
end
shared_examples 'POST /:sources/:id/access_requests' do |source_type|
context "with :sources == #{source_type.pluralize}" do
it_behaves_like 'a 404 response when source is private' do
let(:route) { post api("/#{source_type.pluralize}/#{source.id}/access_requests", stranger) }
end
context 'when authenticated as a member' do
2018-11-18 11:00:15 +05:30
%i[developer maintainer].each do |type|
2016-09-13 17:45:13 +05:30
context "as a #{type}" do
2016-11-03 12:29:30 +05:30
it 'returns 403' do
2016-09-13 17:45:13 +05:30
expect do
user = public_send(type)
post api("/#{source_type.pluralize}/#{source.id}/access_requests", user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-09-13 17:45:13 +05:30
end.not_to change { source.requesters.count }
end
end
end
end
context 'when authenticated as an access requester' do
it 'returns 400' do
expect do
post api("/#{source_type.pluralize}/#{source.id}/access_requests", access_requester)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2016-09-13 17:45:13 +05:30
end.not_to change { source.requesters.count }
end
end
context 'when authenticated as a stranger' do
2016-11-03 12:29:30 +05:30
context "when access request is disabled for the #{source_type}" do
before do
2020-11-24 15:15:51 +05:30
source.update!(request_access_enabled: false)
2016-11-03 12:29:30 +05:30
end
it 'returns 403' do
expect do
post api("/#{source_type.pluralize}/#{source.id}/access_requests", stranger)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-11-03 12:29:30 +05:30
end.not_to change { source.requesters.count }
end
end
2016-09-13 17:45:13 +05:30
it 'returns 201' do
expect do
post api("/#{source_type.pluralize}/#{source.id}/access_requests", stranger)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2016-09-13 17:45:13 +05:30
end.to change { source.requesters.count }.by(1)
# User attributes
expect(json_response['id']).to eq(stranger.id)
expect(json_response['name']).to eq(stranger.name)
expect(json_response['username']).to eq(stranger.username)
expect(json_response['state']).to eq(stranger.state)
expect(json_response['avatar_url']).to eq(stranger.avatar_url)
expect(json_response['web_url']).to eq(Gitlab::Routing.url_helpers.user_url(stranger))
# Member attributes
expect(json_response['requested_at']).to be_present
end
end
end
end
shared_examples 'PUT /:sources/:id/access_requests/:user_id/approve' do |source_type|
context "with :sources == #{source_type.pluralize}" do
it_behaves_like 'a 404 response when source is private' do
let(:route) { put api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}/approve", stranger) }
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a non-maintainer/owner' do
2016-09-13 17:45:13 +05:30
%i[developer access_requester stranger].each do |type|
context "as a #{type}" do
it 'returns 403' do
user = public_send(type)
put api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}/approve", user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-09-13 17:45:13 +05:30
end
end
end
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a maintainer/owner' do
2016-09-13 17:45:13 +05:30
it 'returns 201' do
expect do
2018-11-18 11:00:15 +05:30
put api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}/approve", maintainer),
2019-02-15 15:39:39 +05:30
params: { access_level: Member::MAINTAINER }
2016-09-13 17:45:13 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2016-09-13 17:45:13 +05:30
end.to change { source.members.count }.by(1)
# User attributes
expect(json_response['id']).to eq(access_requester.id)
expect(json_response['name']).to eq(access_requester.name)
expect(json_response['username']).to eq(access_requester.username)
expect(json_response['state']).to eq(access_requester.state)
expect(json_response['avatar_url']).to eq(access_requester.avatar_url)
expect(json_response['web_url']).to eq(Gitlab::Routing.url_helpers.user_url(access_requester))
# Member attributes
2018-11-18 11:00:15 +05:30
expect(json_response['access_level']).to eq(Member::MAINTAINER)
2016-09-13 17:45:13 +05:30
end
context 'user_id does not match an existing access requester' do
it 'returns 404' do
expect do
2018-11-18 11:00:15 +05:30
put api("/#{source_type.pluralize}/#{source.id}/access_requests/#{stranger.id}/approve", maintainer)
2016-09-13 17:45:13 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2016-09-13 17:45:13 +05:30
end.not_to change { source.members.count }
end
end
end
end
end
shared_examples 'DELETE /:sources/:id/access_requests/:user_id' do |source_type|
context "with :sources == #{source_type.pluralize}" do
it_behaves_like 'a 404 response when source is private' do
let(:route) { delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}", stranger) }
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a non-maintainer/owner' do
2016-09-13 17:45:13 +05:30
%i[developer stranger].each do |type|
context "as a #{type}" do
it 'returns 403' do
user = public_send(type)
delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}", user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-09-13 17:45:13 +05:30
end
end
end
end
context 'when authenticated as the access requester' do
2016-11-03 12:29:30 +05:30
it 'deletes the access requester' do
2016-09-13 17:45:13 +05:30
expect do
delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}", access_requester)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:no_content)
2016-09-13 17:45:13 +05:30
end.to change { source.requesters.count }.by(-1)
end
end
2018-11-18 11:00:15 +05:30
context 'when authenticated as a maintainer/owner' do
2016-11-03 12:29:30 +05:30
it 'deletes the access requester' do
2016-09-13 17:45:13 +05:30
expect do
2018-11-18 11:00:15 +05:30
delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{access_requester.id}", maintainer)
2016-09-13 17:45:13 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:no_content)
2016-09-13 17:45:13 +05:30
end.to change { source.requesters.count }.by(-1)
end
2016-11-03 12:29:30 +05:30
context 'user_id matches a member, not an access requester' do
it 'returns 404' do
expect do
2018-11-18 11:00:15 +05:30
delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{developer.id}", maintainer)
2016-11-03 12:29:30 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2016-11-03 12:29:30 +05:30
end.not_to change { source.requesters.count }
end
end
2016-09-13 17:45:13 +05:30
context 'user_id does not match an existing access requester' do
it 'returns 404' do
expect do
2018-11-18 11:00:15 +05:30
delete api("/#{source_type.pluralize}/#{source.id}/access_requests/#{stranger.id}", maintainer)
2016-09-13 17:45:13 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2016-09-13 17:45:13 +05:30
end.not_to change { source.requesters.count }
end
end
end
end
end
it_behaves_like 'GET /:sources/:id/access_requests', 'project' do
let(:source) { project }
end
it_behaves_like 'GET /:sources/:id/access_requests', 'group' do
let(:source) { group }
end
it_behaves_like 'POST /:sources/:id/access_requests', 'project' do
let(:source) { project }
end
it_behaves_like 'POST /:sources/:id/access_requests', 'group' do
let(:source) { group }
end
it_behaves_like 'PUT /:sources/:id/access_requests/:user_id/approve', 'project' do
let(:source) { project }
end
it_behaves_like 'PUT /:sources/:id/access_requests/:user_id/approve', 'group' do
let(:source) { group }
end
it_behaves_like 'DELETE /:sources/:id/access_requests/:user_id', 'project' do
let(:source) { project }
end
it_behaves_like 'DELETE /:sources/:id/access_requests/:user_id', 'group' do
let(:source) { group }
end
end