2014-09-02 18:07:02 +05:30
|
|
|
class Projects::IssuesController < Projects::ApplicationController
|
2017-08-17 22:00:37 +05:30
|
|
|
include RendersNotes
|
2016-06-02 11:05:42 +05:30
|
|
|
include ToggleSubscriptionAction
|
|
|
|
include IssuableActions
|
2016-06-16 23:09:34 +05:30
|
|
|
include ToggleAwardEmoji
|
2016-09-13 17:45:13 +05:30
|
|
|
include IssuableCollections
|
|
|
|
include SpammableActions
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
prepend_before_action :authenticate_user!, only: [:new]
|
|
|
|
|
2016-09-13 17:45:13 +05:30
|
|
|
before_action :redirect_to_external_issue_tracker, only: [:index, :new]
|
2015-09-11 14:41:01 +05:30
|
|
|
before_action :module_enabled
|
2016-06-02 11:05:42 +05:30
|
|
|
before_action :issue, only: [:edit, :update, :show, :referenced_merge_requests,
|
2017-08-17 22:00:37 +05:30
|
|
|
:related_branches, :can_create_branch, :rendered_title, :create_merge_request]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
# Allow read any issue
|
2017-08-17 22:00:37 +05:30
|
|
|
before_action :authorize_read_issue!, only: [:show, :rendered_title]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
# Allow write(create) issue
|
2015-09-11 14:41:01 +05:30
|
|
|
before_action :authorize_create_issue!, only: [:new, :create]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
# Allow modify issue
|
2015-09-11 14:41:01 +05:30
|
|
|
before_action :authorize_update_issue!, only: [:edit, :update]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Allow create a new branch and empty WIP merge request from current issue
|
|
|
|
before_action :authorize_create_merge_request!, only: [:create_merge_request]
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to :html
|
|
|
|
|
|
|
|
def index
|
2017-08-17 22:00:37 +05:30
|
|
|
@collection_type = "Issue"
|
|
|
|
@issues = issues_collection
|
|
|
|
@issues = @issues.page(params[:page])
|
|
|
|
@issuable_meta_data = issuable_meta_data(@issues, @collection_type)
|
|
|
|
|
|
|
|
if @issues.out_of_range? && @issues.total_pages != 0
|
|
|
|
return redirect_to url_for(params.merge(page: @issues.total_pages, only_path: true))
|
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
if params[:label_name].present?
|
|
|
|
@labels = LabelsFinder.new(current_user, project_id: @project.id, title: params[:label_name]).execute
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
@users = []
|
|
|
|
|
|
|
|
if params[:assignee_id].present?
|
|
|
|
assignee = User.find_by_id(params[:assignee_id])
|
|
|
|
@users.push(assignee) if assignee
|
|
|
|
end
|
|
|
|
|
|
|
|
if params[:author_id].present?
|
|
|
|
author = User.find_by_id(params[:author_id])
|
|
|
|
@users.push(author) if author
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.html
|
|
|
|
format.atom { render layout: false }
|
|
|
|
format.json do
|
|
|
|
render json: {
|
2016-06-02 11:05:42 +05:30
|
|
|
html: view_to_html_string("projects/issues/_issues"),
|
|
|
|
labels: @labels.as_json(methods: :text_color)
|
2014-09-02 18:07:02 +05:30
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def new
|
|
|
|
params[:issue] ||= ActionController::Parameters.new(
|
2017-08-17 22:00:37 +05:30
|
|
|
assignee_ids: ""
|
2014-09-02 18:07:02 +05:30
|
|
|
)
|
2017-08-17 22:00:37 +05:30
|
|
|
build_params = issue_params.merge(
|
|
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
|
|
|
discussion_to_resolve: params[:discussion_to_resolve]
|
|
|
|
)
|
|
|
|
service = Issues::BuildService.new(project, current_user, build_params)
|
|
|
|
|
|
|
|
@issue = @noteable = service.execute
|
|
|
|
@merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
|
|
|
|
@discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def edit
|
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def show
|
|
|
|
@noteable = @issue
|
2017-08-17 22:00:37 +05:30
|
|
|
@note = @project.notes.new(noteable: @issue)
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
@discussions = @issue.discussions
|
|
|
|
@notes = prepare_notes_for_rendering(@discussions.flat_map(&:notes))
|
2016-09-13 17:45:13 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.html
|
|
|
|
format.json do
|
2017-08-17 22:00:37 +05:30
|
|
|
render json: IssueSerializer.new.represent(@issue)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def create
|
2017-08-17 22:00:37 +05:30
|
|
|
create_params = issue_params.merge(spammable_params).merge(
|
|
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
|
|
|
discussion_to_resolve: params[:discussion_to_resolve]
|
|
|
|
)
|
|
|
|
|
|
|
|
service = Issues::CreateService.new(project, current_user, create_params)
|
|
|
|
@issue = service.execute
|
|
|
|
|
|
|
|
if service.discussions_to_resolve.count(&:resolved?) > 0
|
|
|
|
flash[:notice] = if service.discussion_to_resolve_id
|
|
|
|
"Resolved 1 discussion."
|
|
|
|
else
|
|
|
|
"Resolved all discussions."
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.html do
|
2017-08-17 22:00:37 +05:30
|
|
|
recaptcha_check_with_fallback { render :new }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2016-09-13 17:45:13 +05:30
|
|
|
format.js do
|
2014-09-02 18:07:02 +05:30
|
|
|
@link = @issue.attachment.url.to_js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def update
|
2017-08-17 22:00:37 +05:30
|
|
|
update_params = issue_params.merge(spammable_params)
|
|
|
|
|
|
|
|
@issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
if params[:move_to_project_id].to_i > 0
|
|
|
|
new_project = Project.find(params[:move_to_project_id])
|
|
|
|
return render_404 unless issue.can_move?(current_user, new_project)
|
|
|
|
|
|
|
|
move_service = Issues::MoveService.new(project, current_user)
|
|
|
|
@issue = move_service.execute(@issue, new_project)
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.html do
|
2017-08-17 22:00:37 +05:30
|
|
|
recaptcha_check_with_fallback { render :edit }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
format.json do
|
2017-08-17 22:00:37 +05:30
|
|
|
if @issue.valid?
|
|
|
|
render json: @issue.to_json(methods: [:task_status, :task_status_short],
|
|
|
|
include: { milestone: {},
|
|
|
|
assignees: { only: [:id, :name, :username], methods: [:avatar_url] },
|
|
|
|
labels: { methods: :text_color } })
|
|
|
|
else
|
|
|
|
render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
rescue ActiveRecord::StaleObjectError
|
2017-08-17 22:00:37 +05:30
|
|
|
render_conflict_response
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def referenced_merge_requests
|
|
|
|
@merge_requests = @issue.referenced_merge_requests(current_user)
|
|
|
|
@closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)
|
|
|
|
|
|
|
|
respond_to do |format|
|
2014-09-02 18:07:02 +05:30
|
|
|
format.json do
|
|
|
|
render json: {
|
2016-06-02 11:05:42 +05:30
|
|
|
html: view_to_html_string('projects/issues/_merge_requests')
|
2014-09-02 18:07:02 +05:30
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
def related_branches
|
|
|
|
@related_branches = @issue.related_branches(current_user)
|
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
|
|
|
render json: {
|
|
|
|
html: view_to_html_string('projects/issues/_related_branches')
|
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
def can_create_branch
|
|
|
|
can_create = current_user &&
|
|
|
|
can?(current_user, :push_code, @project) &&
|
|
|
|
@issue.can_be_worked_on?(current_user)
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
2017-08-17 22:00:37 +05:30
|
|
|
render json: { can_create_branch: can_create, has_related_branch: @issue.has_related_branch? }
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
def rendered_title
|
|
|
|
Gitlab::PollingInterval.set_header(response, interval: 3_000)
|
|
|
|
|
|
|
|
response = {
|
|
|
|
title: view_context.markdown_field(@issue, :title),
|
|
|
|
title_text: @issue.title,
|
|
|
|
description: view_context.markdown_field(@issue, :description),
|
|
|
|
description_text: @issue.description,
|
|
|
|
task_status: @issue.task_status,
|
|
|
|
issue_number: @issue.iid,
|
|
|
|
}
|
|
|
|
|
|
|
|
if @issue.is_edited?
|
|
|
|
response[:updated_at] = @issue.updated_at
|
|
|
|
response[:updated_by_name] = @issue.last_edited_by.name
|
|
|
|
response[:updated_by_path] = user_path(@issue.last_edited_by)
|
|
|
|
end
|
|
|
|
|
|
|
|
render json: response
|
|
|
|
end
|
|
|
|
|
|
|
|
def create_merge_request
|
|
|
|
result = MergeRequests::CreateFromIssueService.new(project, current_user, issue_iid: issue.iid).execute
|
|
|
|
|
|
|
|
if result[:status] == :success
|
|
|
|
render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
|
|
|
|
else
|
|
|
|
render json: result[:messsage], status: :unprocessable_entity
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
protected
|
|
|
|
|
|
|
|
def issue
|
2016-11-03 12:29:30 +05:30
|
|
|
# The Sortable default scope causes performance issues when used with find_by
|
|
|
|
@noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take || redirect_old
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
alias_method :subscribable_resource, :issue
|
|
|
|
alias_method :issuable, :issue
|
2016-06-16 23:09:34 +05:30
|
|
|
alias_method :awardable, :issue
|
2016-09-13 17:45:13 +05:30
|
|
|
alias_method :spammable, :issue
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
def authorize_read_issue!
|
|
|
|
return render_404 unless can?(current_user, :read_issue, @issue)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
def authorize_update_issue!
|
|
|
|
return render_404 unless can?(current_user, :update_issue, @issue)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def authorize_admin_issues!
|
|
|
|
return render_404 unless can?(current_user, :admin_issue, @project)
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
def authorize_create_merge_request!
|
|
|
|
return render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?(current_user)
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
def module_enabled
|
2016-09-29 09:46:39 +05:30
|
|
|
return render_404 unless @project.feature_available?(:issues, current_user) && @project.default_issues_tracker?
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2016-09-13 17:45:13 +05:30
|
|
|
def redirect_to_external_issue_tracker
|
|
|
|
external = @project.external_issue_tracker
|
|
|
|
|
|
|
|
return unless external
|
|
|
|
|
|
|
|
if action_name == 'new'
|
|
|
|
redirect_to external.new_issue_path
|
|
|
|
else
|
|
|
|
redirect_to external.project_path
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
# Since iids are implemented only in 6.1
|
|
|
|
# user may navigate to issue page using old global ids.
|
|
|
|
#
|
|
|
|
# To prevent 404 errors we provide a redirect to correct iids until 7.0 release
|
|
|
|
#
|
|
|
|
def redirect_old
|
|
|
|
issue = @project.issues.find_by(id: params[:id])
|
|
|
|
|
|
|
|
if issue
|
2015-04-26 12:48:37 +05:30
|
|
|
redirect_to issue_path(issue)
|
2014-09-02 18:07:02 +05:30
|
|
|
else
|
|
|
|
raise ActiveRecord::RecordNotFound.new
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def issue_params
|
2015-12-23 02:04:40 +05:30
|
|
|
params.require(:issue).permit(
|
2016-06-02 11:05:42 +05:30
|
|
|
:title, :assignee_id, :position, :description, :confidential,
|
2017-08-17 22:00:37 +05:30
|
|
|
:milestone_id, :due_date, :state_event, :task_num, :lock_version, label_ids: [], assignee_ids: [],
|
2014-09-02 18:07:02 +05:30
|
|
|
)
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
def authenticate_user!
|
|
|
|
return if current_user
|
|
|
|
|
|
|
|
notice = "Please sign in to create the new issue."
|
|
|
|
|
|
|
|
store_location_for :user, request.fullpath
|
|
|
|
redirect_to new_user_session_path, notice: notice
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|