debian-mirror-gitlab/spec/features/snippets/notes_on_personal_snippets_spec.rb

165 lines
4.6 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe 'Comments on personal snippets', :js do
2017-09-10 17:25:29 +05:30
include NoteInteractionHelpers
2020-07-02 01:45:43 +05:30
let_it_be(:snippet) { create(:personal_snippet, :public) }
let_it_be(:other_note) { create(:note_on_personal_snippet) }
let(:user_name) { 'Test User' }
let!(:user) { create(:user, name: user_name) }
2017-08-17 22:00:37 +05:30
let!(:snippet_notes) do
[
create(:note_on_personal_snippet, noteable: snippet, author: user),
create(:note_on_personal_snippet, noteable: snippet)
]
end
before do
2017-09-10 17:25:29 +05:30
sign_in user
2017-08-17 22:00:37 +05:30
visit snippet_path(snippet)
2018-11-18 11:00:15 +05:30
wait_for_requests
2017-08-17 22:00:37 +05:30
end
subject { page }
context 'when viewing the snippet detail page' do
it 'contains notes for a snippet with correct action icons' do
expect(page).to have_selector('#notes-list li', count: 2)
2017-09-10 17:25:29 +05:30
open_more_actions_dropdown(snippet_notes[0])
2017-08-17 22:00:37 +05:30
# comment authored by current user
page.within("#notes-list li#note_#{snippet_notes[0].id}") do
expect(page).to have_content(snippet_notes[0].note)
expect(page).to have_selector('.js-note-delete')
expect(page).to have_selector('.note-emoji-button')
end
2017-09-10 17:25:29 +05:30
find('body').click # close dropdown
open_more_actions_dropdown(snippet_notes[1])
2017-08-17 22:00:37 +05:30
page.within("#notes-list li#note_#{snippet_notes[1].id}") do
expect(page).to have_content(snippet_notes[1].note)
expect(page).not_to have_selector('.js-note-delete')
expect(page).to have_selector('.note-emoji-button')
end
end
2018-11-18 11:00:15 +05:30
it 'shows the status of a note author' do
status = create(:user_status, user: user)
visit snippet_path(snippet)
within("#note_#{snippet_notes[0].id}") do
expect(page).to show_user_status(status)
end
end
2020-07-02 01:45:43 +05:30
it 'shows the author name' do
visit snippet_path(snippet)
within("#note_#{snippet_notes[0].id}") do
expect(page).to have_content(user_name)
end
end
context 'when the author name contains HTML' do
let(:user_name) { '<h1><a href="https://bad.link/malicious.exe" class="evil">Fake Content<img class="fake-icon" src="image.png"></a></h1>' }
it 'renders the name as plain text' do
visit snippet_path(snippet)
content = find("#note_#{snippet_notes[0].id} .note-header-author-name").text
expect(content).to eq user_name
end
end
2017-08-17 22:00:37 +05:30
end
context 'when submitting a note' do
it 'shows a valid form' do
is_expected.to have_css('.js-main-target-form', visible: true, count: 1)
2017-09-10 17:25:29 +05:30
expect(find('.js-main-target-form .js-comment-button').value)
.to eq('Comment')
2017-08-17 22:00:37 +05:30
page.within('.js-main-target-form') do
expect(page).not_to have_link('Cancel')
end
end
it 'previews a note' do
fill_in 'note[note]', with: 'This is **awesome**!'
find('.js-md-preview-button').click
2019-07-07 11:18:12 +05:30
page.within('.new-note .md-preview-holder') do
2017-08-17 22:00:37 +05:30
expect(page).to have_content('This is awesome!')
expect(page).to have_selector('strong')
end
end
it 'creates a note' do
fill_in 'note[note]', with: 'This is **awesome**!'
click_button 'Comment'
expect(find('div#notes')).to have_content('This is awesome!')
end
2017-09-10 17:25:29 +05:30
2019-07-07 11:18:12 +05:30
it 'does not have autocomplete' do
2017-09-10 17:25:29 +05:30
fill_in 'note[note]', with: '@'
wait_for_requests
# This selector probably won't be in place even if autocomplete was enabled
# but we want to make sure
expect(page).not_to have_selector('.atwho-view')
end
2020-10-24 23:57:45 +05:30
it_behaves_like 'personal snippet with references' do
let(:container) { 'div#notes' }
subject do
fill_in 'note[note]', with: references
click_button 'Comment'
wait_for_requests
end
end
2017-08-17 22:00:37 +05:30
end
context 'when editing a note' do
it 'changes the text' do
2018-03-17 18:26:18 +05:30
find('.js-note-edit').click
2017-08-17 22:00:37 +05:30
page.within('.current-note-edit-form') do
fill_in 'note[note]', with: 'new content'
2018-12-05 23:21:45 +05:30
find('.btn-success').click
2017-08-17 22:00:37 +05:30
end
page.within("#notes-list li#note_#{snippet_notes[0].id}") do
edited_text = find('.edited-text')
expect(page).to have_css('.note_edited_ago')
expect(page).to have_content('new content')
expect(edited_text).to have_selector('.note_edited_ago')
end
end
end
context 'when deleting a note' do
it 'removes the note from the snippet detail page' do
2017-09-10 17:25:29 +05:30
open_more_actions_dropdown(snippet_notes[0])
2017-08-17 22:00:37 +05:30
page.within("#notes-list li#note_#{snippet_notes[0].id}") do
2018-03-17 18:26:18 +05:30
accept_confirm { click_on 'Delete comment' }
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
wait_for_requests
2017-08-17 22:00:37 +05:30
expect(page).not_to have_selector("#notes-list li#note_#{snippet_notes[0].id}")
end
end
end