2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Projects::Ci::LintsController do
|
2019-06-05 12:25:43 +05:30
|
|
|
include StubRequests
|
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #show' do
|
|
|
|
context 'with enough privileges' do
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
get :show, params: { namespace_id: project.namespace, project_id: project }
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'is success' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(response).to be_success
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'renders show page' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(response).to render_template :show
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'retrieves project' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(assigns(:project)).to eq(project)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without enough privileges' do
|
|
|
|
before do
|
|
|
|
project.add_guest(user)
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
get :show, params: { namespace_id: project.namespace, project_id: project }
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'responds with 404' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST #create' do
|
|
|
|
let(:remote_file_path) { 'https://gitlab.com/gitlab-org/gitlab-ce/blob/1234/.gitlab-ci-1.yml' }
|
|
|
|
|
|
|
|
let(:remote_file_content) do
|
|
|
|
<<~HEREDOC
|
|
|
|
before_script:
|
|
|
|
- apt-get update -qq && apt-get install -y -qq sqlite3 libsqlite3-dev nodejs
|
|
|
|
- ruby -v
|
|
|
|
- which ruby
|
|
|
|
- bundle install --jobs $(nproc) "${FLAGS[@]}"
|
|
|
|
HEREDOC
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:content) do
|
|
|
|
<<~HEREDOC
|
|
|
|
include:
|
|
|
|
- #{remote_file_path}
|
|
|
|
|
|
|
|
rubocop:
|
|
|
|
script:
|
|
|
|
- bundle exec rubocop
|
|
|
|
HEREDOC
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a valid gitlab-ci.yml' do
|
|
|
|
before do
|
2019-06-05 12:25:43 +05:30
|
|
|
stub_full_request(remote_file_path).to_return(body: remote_file_content)
|
2018-05-09 12:01:36 +05:30
|
|
|
project.add_developer(user)
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
post :create, params: { namespace_id: project.namespace, project_id: project, content: content }
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'is success' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(response).to be_success
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'render show page' do
|
|
|
|
expect(response).to render_template :show
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'retrieves project' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(assigns(:project)).to eq(project)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an invalid gitlab-ci.yml' do
|
|
|
|
let(:content) do
|
|
|
|
<<~HEREDOC
|
|
|
|
rubocop:
|
|
|
|
scriptt:
|
|
|
|
- bundle exec rubocop
|
|
|
|
HEREDOC
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
post :create, params: { namespace_id: project.namespace, project_id: project, content: content }
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'assigns errors' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(assigns[:error]).to eq('jobs:rubocop config contains unknown keys: scriptt')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without enough privileges' do
|
|
|
|
before do
|
|
|
|
project.add_guest(user)
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
post :create, params: { namespace_id: project.namespace, project_id: project, content: content }
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'responds with 404' do
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|