2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe Gitlab::Config::Loader::Yaml do
|
2016-06-16 23:09:34 +05:30
|
|
|
let(:loader) { described_class.new(yml) }
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:yml) do
|
|
|
|
<<~YAML
|
|
|
|
image: 'ruby:2.7'
|
|
|
|
texts:
|
|
|
|
nested_key: 'value1'
|
|
|
|
more_text:
|
|
|
|
more_nested_key: 'value2'
|
|
|
|
YAML
|
|
|
|
end
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
context 'when yaml syntax is correct' do
|
2020-04-22 19:07:51 +05:30
|
|
|
let(:yml) { 'image: ruby:2.7' }
|
2016-06-16 23:09:34 +05:30
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'returns true' do
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(loader).to be_valid
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#load!' do
|
|
|
|
it 'returns a valid hash' do
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(loader.load!).to eq(image: 'ruby:2.7')
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when yaml syntax is incorrect' do
|
|
|
|
let(:yml) { '// incorrect' }
|
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'returns false' do
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(loader).not_to be_valid
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#load!' do
|
|
|
|
it 'raises error' do
|
|
|
|
expect { loader.load! }.to raise_error(
|
2019-02-15 15:39:39 +05:30
|
|
|
Gitlab::Config::Loader::FormatError,
|
2016-06-16 23:09:34 +05:30
|
|
|
'Invalid configuration format'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when there is an unknown alias' do
|
|
|
|
let(:yml) { 'steps: *bad_alias' }
|
|
|
|
|
|
|
|
describe '#initialize' do
|
|
|
|
it 'raises FormatError' do
|
2019-07-07 11:18:12 +05:30
|
|
|
expect { loader }.to raise_error(
|
|
|
|
Gitlab::Config::Loader::FormatError,
|
|
|
|
'Unknown alias: bad_alias'
|
|
|
|
)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
context 'when yaml config is empty' do
|
|
|
|
let(:yml) { '' }
|
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'returns false' do
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(loader).not_to be_valid
|
|
|
|
end
|
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
describe '#load_raw!' do
|
|
|
|
it 'raises error' do
|
|
|
|
expect { loader.load_raw! }.to raise_error(
|
|
|
|
Gitlab::Config::Loader::FormatError,
|
|
|
|
'Invalid configuration format'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
# Prevent Billion Laughs attack: https://gitlab.com/gitlab-org/gitlab-foss/issues/56018
|
2019-07-07 11:18:12 +05:30
|
|
|
context 'when yaml size is too large' do
|
|
|
|
let(:yml) do
|
|
|
|
<<~YAML
|
|
|
|
a: &a ["lol","lol","lol","lol","lol","lol","lol","lol","lol"]
|
|
|
|
b: &b [*a,*a,*a,*a,*a,*a,*a,*a,*a]
|
|
|
|
c: &c [*b,*b,*b,*b,*b,*b,*b,*b,*b]
|
|
|
|
d: &d [*c,*c,*c,*c,*c,*c,*c,*c,*c]
|
|
|
|
e: &e [*d,*d,*d,*d,*d,*d,*d,*d,*d]
|
|
|
|
f: &f [*e,*e,*e,*e,*e,*e,*e,*e,*e]
|
|
|
|
g: &g [*f,*f,*f,*f,*f,*f,*f,*f,*f]
|
|
|
|
h: &h [*g,*g,*g,*g,*g,*g,*g,*g,*g]
|
|
|
|
i: &i [*h,*h,*h,*h,*h,*h,*h,*h,*h]
|
|
|
|
YAML
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'returns false' do
|
|
|
|
expect(loader).not_to be_valid
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true if "ci_yaml_limit_size" feature flag is disabled' do
|
|
|
|
stub_feature_flags(ci_yaml_limit_size: false)
|
|
|
|
|
|
|
|
expect(loader).to be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#load!' do
|
|
|
|
it 'raises FormatError' do
|
|
|
|
expect { loader.load! }.to raise_error(
|
|
|
|
Gitlab::Config::Loader::FormatError,
|
|
|
|
'The parsed YAML is too big'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
# Prevent Billion Laughs attack: https://gitlab.com/gitlab-org/gitlab-foss/issues/56018
|
2019-07-07 11:18:12 +05:30
|
|
|
context 'when yaml has cyclic data structure' do
|
|
|
|
let(:yml) do
|
|
|
|
<<~YAML
|
|
|
|
--- &1
|
|
|
|
- hi
|
|
|
|
- *1
|
|
|
|
YAML
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'returns false' do
|
|
|
|
expect(loader.valid?).to be(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#load!' do
|
|
|
|
it 'raises FormatError' do
|
|
|
|
expect { loader.load! }.to raise_error(Gitlab::Config::Loader::FormatError, 'The parsed YAML is too big')
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
describe '#load_raw!' do
|
|
|
|
it 'loads keys as strings' do
|
|
|
|
expect(loader.load_raw!).to eq(
|
|
|
|
'image' => 'ruby:2.7',
|
|
|
|
'texts' => {
|
|
|
|
'nested_key' => 'value1',
|
|
|
|
'more_text' => {
|
|
|
|
'more_nested_key' => 'value2'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#load!' do
|
|
|
|
it 'symbolizes keys' do
|
|
|
|
expect(loader.load!).to eq(
|
|
|
|
image: 'ruby:2.7',
|
|
|
|
texts: {
|
|
|
|
nested_key: 'value1',
|
|
|
|
more_text: {
|
|
|
|
more_nested_key: 'value2'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|