2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
RSpec.describe 'Metrics rendering', :js, :kubeclient, :use_clean_rails_memory_store_caching, :sidekiq_inline, feature_category: :metrics do
|
2019-10-12 21:52:04 +05:30
|
|
|
include PrometheusHelpers
|
2020-07-28 23:09:34 +05:30
|
|
|
include KubernetesHelpers
|
2019-12-26 22:10:19 +05:30
|
|
|
include GrafanaApiHelpers
|
2020-04-08 14:13:33 +05:30
|
|
|
include MetricsDashboardUrlHelpers
|
|
|
|
|
|
|
|
let_it_be(:user) { create(:user) }
|
2022-11-25 23:54:43 +05:30
|
|
|
let_it_be(:project) { create(:project, :with_prometheus_integration) }
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:environment) { create(:environment, project: project) }
|
2019-10-12 21:52:04 +05:30
|
|
|
|
|
|
|
let(:issue) { create(:issue, project: project, description: description) }
|
|
|
|
let(:description) { "See [metrics dashboard](#{metrics_url}) for info." }
|
2020-04-08 14:13:33 +05:30
|
|
|
let(:metrics_url) { urls.metrics_project_environment_url(project, environment) }
|
2019-10-12 21:52:04 +05:30
|
|
|
|
|
|
|
before do
|
2023-07-09 08:55:56 +05:30
|
|
|
stub_feature_flags(remove_monitor_metrics: false)
|
2020-04-08 14:13:33 +05:30
|
|
|
clear_host_from_memoized_variables
|
2020-10-24 23:57:45 +05:30
|
|
|
stub_gitlab_domain
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
project.add_developer(user)
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
2020-04-08 14:13:33 +05:30
|
|
|
clear_host_from_memoized_variables
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
shared_examples_for 'metrics dashboard unavailable' do
|
|
|
|
context 'when metrics dashboard feature is unavailable' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(remove_monitor_metrics: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows no embedded metrics' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_no_css('div.prometheus-graph')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'internal metrics embeds' do
|
|
|
|
before do
|
|
|
|
import_common_metrics
|
|
|
|
stub_any_prometheus_request_with_response
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
allow(Prometheus::ProxyService).to receive(:new).and_call_original
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
include_examples 'metrics dashboard unavailable'
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'shows embedded metrics' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
|
|
|
expect(page).to have_text('Memory Usage (Total)')
|
|
|
|
expect(page).to have_text('Core Usage (Total)')
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
# Ensure that the FE is calling the BE with expected params
|
|
|
|
expect(Prometheus::ProxyService)
|
|
|
|
.to have_received(:new)
|
|
|
|
.with(environment, 'GET', 'query_range', hash_including('start', 'end', 'step'))
|
|
|
|
.at_least(:once)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
context 'with remove_monitor_metrics flag enabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(remove_monitor_metrics: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show embedded metrics' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).not_to have_css('div.prometheus-graph')
|
|
|
|
expect(page).not_to have_text('Memory Usage (Total)')
|
|
|
|
expect(page).not_to have_text('Core Usage (Total)')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'when dashboard params are in included the url' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let(:metrics_url) { urls.metrics_project_environment_url(project, environment, **chart_params) }
|
2019-10-12 21:52:04 +05:30
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
let(:chart_params) do
|
|
|
|
{
|
|
|
|
group: 'System metrics (Kubernetes)',
|
|
|
|
title: 'Memory Usage (Pod average)',
|
|
|
|
y_label: 'Memory Used per Pod (MB)'
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows embedded metrics for the specific chart' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
|
|
|
expect(page).to have_text(chart_params[:title])
|
|
|
|
expect(page).to have_text(chart_params[:y_label])
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
# Ensure that the FE is calling the BE with expected params
|
|
|
|
expect(Prometheus::ProxyService)
|
|
|
|
.to have_received(:new)
|
|
|
|
.with(environment, 'GET', 'query_range', hash_including('start', 'end', 'step'))
|
|
|
|
.at_least(:once)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
context 'when two dashboard urls are included' do
|
|
|
|
let(:chart_params_2) do
|
|
|
|
{
|
|
|
|
group: 'System metrics (Kubernetes)',
|
|
|
|
title: 'Core Usage (Total)',
|
|
|
|
y_label: 'Total Cores'
|
|
|
|
}
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
let(:metrics_url_2) { urls.metrics_project_environment_url(project, environment, **chart_params_2) }
|
|
|
|
let(:description) { "See [metrics dashboard](#{metrics_url}) for info. \n See [metrics dashboard](#{metrics_url_2}) for info." }
|
|
|
|
let(:issue) { create(:issue, project: project, description: description) }
|
|
|
|
|
|
|
|
it 'shows embedded metrics for both urls' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
|
|
|
expect(page).to have_text(chart_params[:title])
|
|
|
|
expect(page).to have_text(chart_params[:y_label])
|
|
|
|
expect(page).to have_text(chart_params_2[:title])
|
|
|
|
expect(page).to have_text(chart_params_2[:y_label])
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
# Ensure that the FE is calling the BE with expected params
|
|
|
|
expect(Prometheus::ProxyService)
|
|
|
|
.to have_received(:new)
|
|
|
|
.with(environment, 'GET', 'query_range', hash_including('start', 'end', 'step'))
|
|
|
|
.at_least(:once)
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'grafana metrics embeds' do
|
|
|
|
let(:grafana_integration) { create(:grafana_integration, project: project) }
|
|
|
|
let(:grafana_base_url) { grafana_integration.grafana_url }
|
|
|
|
let(:metrics_url) { valid_grafana_dashboard_link(grafana_base_url) }
|
2019-10-12 21:52:04 +05:30
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
before do
|
|
|
|
stub_dashboard_request(grafana_base_url)
|
|
|
|
stub_datasource_request(grafana_base_url)
|
|
|
|
stub_all_grafana_proxy_requests(grafana_base_url)
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
allow(Grafana::ProxyService).to receive(:new).and_call_original
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
include_examples 'metrics dashboard unavailable'
|
|
|
|
|
2023-06-20 00:43:36 +05:30
|
|
|
it 'shows embedded metrics', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/402973' do
|
2019-10-12 21:52:04 +05:30
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
2019-12-26 22:10:19 +05:30
|
|
|
expect(page).to have_text('Expired / Evicted')
|
|
|
|
expect(page).to have_text('expired - test-attribute-value')
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
# Ensure that the FE is calling the BE with expected params
|
|
|
|
expect(Grafana::ProxyService)
|
|
|
|
.to have_received(:new)
|
|
|
|
.with(project, anything, anything, hash_including('query', 'start', 'end', 'step'))
|
|
|
|
.at_least(:once)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'transient metrics embeds' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:metrics_url) { urls.metrics_dashboard_project_environment_url(project, environment, embed_json: embed_json) }
|
2020-04-22 19:07:51 +05:30
|
|
|
let(:title) { 'Important Metrics' }
|
|
|
|
let(:embed_json) do
|
|
|
|
{
|
|
|
|
panel_groups: [{
|
|
|
|
panels: [{
|
2020-10-24 23:57:45 +05:30
|
|
|
type: 'area-chart',
|
2020-04-22 19:07:51 +05:30
|
|
|
title: title,
|
2020-10-24 23:57:45 +05:30
|
|
|
y_label: 'metric',
|
2020-04-22 19:07:51 +05:30
|
|
|
metrics: [{
|
2020-10-24 23:57:45 +05:30
|
|
|
query_range: 'metric * 0.5 < 1'
|
2020-04-22 19:07:51 +05:30
|
|
|
}]
|
|
|
|
}]
|
|
|
|
}]
|
|
|
|
}.to_json
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_any_prometheus_request_with_response
|
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
include_examples 'metrics dashboard unavailable'
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
it 'shows embedded metrics' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
|
|
|
expect(page).to have_text(title)
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
context 'for GitLab embedded cluster health metrics' do
|
|
|
|
before do
|
|
|
|
project.add_maintainer(user)
|
|
|
|
import_common_metrics
|
|
|
|
stub_any_prometheus_request_with_response
|
|
|
|
|
|
|
|
allow(Prometheus::ProxyService).to receive(:new).and_call_original
|
|
|
|
|
2021-09-04 01:27:46 +05:30
|
|
|
create(:clusters_integrations_prometheus, cluster: cluster)
|
2020-07-28 23:09:34 +05:30
|
|
|
stub_kubeclient_discover(cluster.platform.api_url)
|
|
|
|
stub_prometheus_request(/prometheus-prometheus-server/, body: prometheus_values_body)
|
2021-09-30 23:02:18 +05:30
|
|
|
stub_prometheus_request(%r{prometheus/api/v1}, body: prometheus_values_body)
|
2020-07-28 23:09:34 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :project, projects: [project], user: user) }
|
2021-09-30 23:02:18 +05:30
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
let(:params) { [project.namespace.path, project.path, cluster.id] }
|
|
|
|
let(:query_params) { { group: 'Cluster Health', title: 'CPU Usage', y_label: 'CPU (cores)' } }
|
|
|
|
let(:metrics_url) { urls.namespace_project_cluster_url(*params, **query_params) }
|
|
|
|
let(:description) { "# Summary \n[](#{metrics_url})" }
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
include_examples 'metrics dashboard unavailable'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'shows embedded metrics' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_css('div.prometheus-graph')
|
|
|
|
expect(page).to have_text(query_params[:title])
|
|
|
|
expect(page).to have_text(query_params[:y_label])
|
|
|
|
expect(page).not_to have_text(metrics_url)
|
|
|
|
|
|
|
|
expect(Prometheus::ProxyService)
|
|
|
|
.to have_received(:new)
|
|
|
|
.with(cluster, 'GET', 'query_range', hash_including('start', 'end', 'step'))
|
|
|
|
.at_least(:once)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
def import_common_metrics
|
|
|
|
::Gitlab::DatabaseImporters::CommonMetrics::Importer.new.execute
|
|
|
|
end
|
|
|
|
end
|