debian-mirror-gitlab/spec/controllers/projects/runners_controller_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

253 lines
6.9 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2023-03-04 22:38:38 +05:30
RSpec.describe Projects::RunnersController, feature_category: :runner_fleet do
2023-07-09 08:55:56 +05:30
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:runner) { create(:ci_runner, :project, projects: [project]) }
2017-08-17 22:00:37 +05:30
let(:params) do
{
namespace_id: project.namespace,
project_id: project,
id: runner
}
end
before do
sign_in(user)
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2017-08-17 22:00:37 +05:30
end
2023-07-09 08:55:56 +05:30
describe '#new' do
let(:params) do
{
namespace_id: project.namespace,
project_id: project
}
end
context 'when create_runner_workflow_for_namespace is enabled' do
before do
stub_feature_flags(create_runner_workflow_for_namespace: [project.namespace])
end
context 'when user is maintainer' do
before do
project.add_maintainer(user)
end
it 'renders new with 200 status code' do
get :new, params: params
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:new)
end
end
context 'when user is not maintainer' do
before do
project.add_developer(user)
end
it 'renders a 404' do
get :new, params: params
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when create_runner_workflow_for_namespace is disabled' do
before do
stub_feature_flags(create_runner_workflow_for_namespace: false)
end
context 'when user is maintainer' do
before do
project.add_maintainer(user)
end
it 'renders a 404' do
get :new, params: params
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
describe '#register' do
subject(:register) { get :register, params: { namespace_id: project.namespace, project_id: project, id: new_runner } }
context 'when create_runner_workflow_for_namespace is enabled' do
before do
stub_feature_flags(create_runner_workflow_for_namespace: [project.namespace])
end
context 'when user is maintainer' do
before do
project.add_maintainer(user)
end
context 'when runner can be registered after creation' do
let_it_be(:new_runner) { create(:ci_runner, :project, projects: [project], registration_type: :authenticated_user) }
it 'renders a :register template' do
register
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:register)
end
end
context 'when runner cannot be registered after creation' do
let_it_be(:new_runner) { runner }
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'when user is not maintainer' do
before do
project.add_developer(user)
end
context 'when runner can be registered after creation' do
let_it_be(:new_runner) { create(:ci_runner, :project, projects: [project], registration_type: :authenticated_user) }
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
context 'when create_runner_workflow_for_namespace is disabled' do
let_it_be(:new_runner) { create(:ci_runner, :project, projects: [project], registration_type: :authenticated_user) }
before do
stub_feature_flags(create_runner_workflow_for_namespace: false)
end
context 'when user is maintainer' do
before do
project.add_maintainer(user)
end
it 'returns :not_found' do
register
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
2017-08-17 22:00:37 +05:30
describe '#update' do
it 'updates the runner and ticks the queue' do
new_desc = runner.description.swapcase
expect do
2023-01-13 00:05:48 +05:30
post :update, params: params.merge(runner: { description: new_desc })
2017-08-17 22:00:37 +05:30
end.to change { runner.ensure_runner_queue_value }
runner.reload
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:found)
2017-08-17 22:00:37 +05:30
expect(runner.description).to eq(new_desc)
end
end
describe '#destroy' do
it 'destroys the runner' do
2022-05-07 20:08:51 +05:30
expect_next_instance_of(Ci::Runners::UnregisterRunnerService, runner, user) do |service|
2022-04-04 11:22:00 +05:30
expect(service).to receive(:execute).once.and_call_original
end
2019-02-15 15:39:39 +05:30
delete :destroy, params: params
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:found)
2017-08-17 22:00:37 +05:30
expect(Ci::Runner.find_by(id: runner.id)).to be_nil
end
end
describe '#resume' do
it 'marks the runner as active and ticks the queue' do
2021-04-29 21:17:54 +05:30
runner.update!(active: false)
2017-08-17 22:00:37 +05:30
expect do
2019-02-15 15:39:39 +05:30
post :resume, params: params
2017-08-17 22:00:37 +05:30
end.to change { runner.ensure_runner_queue_value }
runner.reload
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:found)
2017-08-17 22:00:37 +05:30
expect(runner.active).to eq(true)
end
end
describe '#pause' do
it 'marks the runner as inactive and ticks the queue' do
2021-04-29 21:17:54 +05:30
runner.update!(active: true)
2017-08-17 22:00:37 +05:30
expect do
2019-02-15 15:39:39 +05:30
post :pause, params: params
2017-08-17 22:00:37 +05:30
end.to change { runner.ensure_runner_queue_value }
runner.reload
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:found)
2017-08-17 22:00:37 +05:30
expect(runner.active).to eq(false)
end
end
2021-01-03 14:25:43 +05:30
describe '#toggle_shared_runners' do
let(:group) { create(:group) }
let(:project) { create(:project, group: group) }
2021-06-08 01:23:25 +05:30
it 'toggles shared_runners_enabled when the group allows shared runners' do
project.update!(shared_runners_enabled: true)
2021-01-03 14:25:43 +05:30
2021-06-08 01:23:25 +05:30
post :toggle_shared_runners, params: params
2021-01-03 14:25:43 +05:30
2021-06-08 01:23:25 +05:30
project.reload
2021-01-03 14:25:43 +05:30
2021-06-08 01:23:25 +05:30
expect(response).to have_gitlab_http_status(:ok)
expect(project.shared_runners_enabled).to eq(false)
2021-01-03 14:25:43 +05:30
end
2021-06-08 01:23:25 +05:30
it 'toggles shared_runners_enabled when the group disallows shared runners but allows overrides' do
group.update!(shared_runners_enabled: false, allow_descendants_override_disabled_shared_runners: true)
project.update!(shared_runners_enabled: false)
2021-01-03 14:25:43 +05:30
2021-06-08 01:23:25 +05:30
post :toggle_shared_runners, params: params
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
project.reload
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
expect(response).to have_gitlab_http_status(:ok)
expect(project.shared_runners_enabled).to eq(true)
end
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
it 'does not enable if the group disallows shared runners' do
group.update!(shared_runners_enabled: false, allow_descendants_override_disabled_shared_runners: false)
project.update!(shared_runners_enabled: false)
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
post :toggle_shared_runners, params: params
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
project.reload
2021-02-22 17:27:13 +05:30
2021-06-08 01:23:25 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
expect(project.shared_runners_enabled).to eq(false)
2021-09-30 23:02:18 +05:30
expect(json_response['error']).to eq('Shared runners enabled cannot be enabled because parent group does not allow it')
2021-01-03 14:25:43 +05:30
end
end
2017-08-17 22:00:37 +05:30
end