2018-12-05 23:21:45 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
class Projects::IssuesController < Projects::ApplicationController
|
2017-08-17 22:00:37 +05:30
|
|
|
include RendersNotes
|
2016-06-02 11:05:42 +05:30
|
|
|
include ToggleSubscriptionAction
|
|
|
|
include IssuableActions
|
2016-06-16 23:09:34 +05:30
|
|
|
include ToggleAwardEmoji
|
2016-09-13 17:45:13 +05:30
|
|
|
include IssuableCollections
|
2018-11-08 19:23:39 +05:30
|
|
|
include IssuesCalendar
|
2016-09-13 17:45:13 +05:30
|
|
|
include SpammableActions
|
2019-03-02 22:35:43 +05:30
|
|
|
include RecordUserLastActivity
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
def issue_except_actions
|
2020-04-22 19:07:51 +05:30
|
|
|
%i[index calendar new create bulk_update import_csv export_csv]
|
2018-12-13 13:39:08 +05:30
|
|
|
end
|
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
def set_issuables_index_only_actions
|
2018-12-13 13:39:08 +05:30
|
|
|
%i[index calendar]
|
|
|
|
end
|
|
|
|
|
2018-11-29 20:51:05 +05:30
|
|
|
prepend_before_action(only: [:index]) { authenticate_sessionless_user!(:rss) }
|
|
|
|
prepend_before_action(only: [:calendar]) { authenticate_sessionless_user!(:ics) }
|
2020-04-22 19:07:51 +05:30
|
|
|
prepend_before_action :authenticate_user!, only: [:new, :export_csv]
|
2019-12-04 20:38:33 +05:30
|
|
|
prepend_before_action :store_uri, only: [:new, :show, :designs]
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
before_action :whitelist_query_limiting, only: [:create, :create_merge_request, :move, :bulk_update]
|
2017-09-10 17:25:29 +05:30
|
|
|
before_action :check_issues_available!
|
2019-07-31 22:56:46 +05:30
|
|
|
before_action :issue, unless: ->(c) { c.issue_except_actions.include?(c.action_name.to_sym) }
|
2018-12-13 13:39:08 +05:30
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
before_action :set_issuables_index, if: ->(c) { c.set_issuables_index_only_actions.include?(c.action_name.to_sym) }
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
# Allow write(create) issue
|
2015-09-11 14:41:01 +05:30
|
|
|
before_action :authorize_create_issue!, only: [:new, :create]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
# Allow modify issue
|
2019-09-30 21:07:59 +05:30
|
|
|
before_action :authorize_update_issuable!, only: [:edit, :update, :move, :reorder]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Allow create a new branch and empty WIP merge request from current issue
|
2018-05-09 12:01:36 +05:30
|
|
|
before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
before_action :authorize_import_issues!, only: [:import_csv]
|
2019-04-03 18:18:56 +05:30
|
|
|
before_action :authorize_download_code!, only: [:related_branches]
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
# Limit the amount of issues created per minute
|
|
|
|
before_action :create_rate_limit, only: [:create]
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
before_action do
|
|
|
|
push_frontend_feature_flag(:vue_issuable_sidebar, project.group)
|
2020-04-22 19:07:51 +05:30
|
|
|
push_frontend_feature_flag(:save_issuable_health_status, project.group, default_enabled: true)
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
before_action only: :show do
|
|
|
|
push_frontend_feature_flag(:real_time_issue_sidebar, @project)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
around_action :allow_gitaly_ref_name_caching, only: [:discussions]
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to :html
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
alias_method :designs, :show
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
def index
|
2018-03-17 18:26:18 +05:30
|
|
|
@issues = @issuables
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.html
|
2017-09-10 17:25:29 +05:30
|
|
|
format.atom { render layout: 'xml.atom' }
|
2014-09-02 18:07:02 +05:30
|
|
|
format.json do
|
|
|
|
render json: {
|
2016-06-02 11:05:42 +05:30
|
|
|
html: view_to_html_string("projects/issues/_issues"),
|
|
|
|
labels: @labels.as_json(methods: :text_color)
|
2014-09-02 18:07:02 +05:30
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
def calendar
|
|
|
|
render_issues_calendar(@issuables)
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
def new
|
|
|
|
params[:issue] ||= ActionController::Parameters.new(
|
2017-08-17 22:00:37 +05:30
|
|
|
assignee_ids: ""
|
2014-09-02 18:07:02 +05:30
|
|
|
)
|
2017-08-17 22:00:37 +05:30
|
|
|
build_params = issue_params.merge(
|
|
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
2020-05-24 23:13:21 +05:30
|
|
|
discussion_to_resolve: params[:discussion_to_resolve],
|
|
|
|
confidential: !!Gitlab::Utils.to_boolean(params[:issue][:confidential])
|
2017-08-17 22:00:37 +05:30
|
|
|
)
|
|
|
|
service = Issues::BuildService.new(project, current_user, build_params)
|
|
|
|
|
|
|
|
@issue = @noteable = service.execute
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
@merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
|
|
|
|
@discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def edit
|
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def create
|
2017-08-17 22:00:37 +05:30
|
|
|
create_params = issue_params.merge(spammable_params).merge(
|
|
|
|
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
|
|
|
|
discussion_to_resolve: params[:discussion_to_resolve]
|
|
|
|
)
|
|
|
|
|
|
|
|
service = Issues::CreateService.new(project, current_user, create_params)
|
|
|
|
@issue = service.execute
|
|
|
|
|
|
|
|
if service.discussions_to_resolve.count(&:resolved?) > 0
|
|
|
|
flash[:notice] = if service.discussion_to_resolve_id
|
2019-07-07 11:18:12 +05:30
|
|
|
_("Resolved 1 discussion.")
|
2017-08-17 22:00:37 +05:30
|
|
|
else
|
2019-07-07 11:18:12 +05:30
|
|
|
_("Resolved all discussions.")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.html do
|
2017-08-17 22:00:37 +05:30
|
|
|
recaptcha_check_with_fallback { render :new }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2016-09-13 17:45:13 +05:30
|
|
|
format.js do
|
2014-09-02 18:07:02 +05:30
|
|
|
@link = @issue.attachment.url.to_js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
def move
|
|
|
|
params.require(:move_to_project_id)
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
if params[:move_to_project_id].to_i > 0
|
|
|
|
new_project = Project.find(params[:move_to_project_id])
|
|
|
|
return render_404 unless issue.can_move?(current_user, new_project)
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
@issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
respond_to do |format|
|
2016-06-02 11:05:42 +05:30
|
|
|
format.json do
|
2018-03-17 18:26:18 +05:30
|
|
|
render_issue_json
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
rescue ActiveRecord::StaleObjectError
|
2017-08-17 22:00:37 +05:30
|
|
|
render_conflict_response
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2019-09-30 21:07:59 +05:30
|
|
|
def reorder
|
|
|
|
service = Issues::ReorderService.new(project, current_user, reorder_params)
|
|
|
|
|
|
|
|
if service.execute(issue)
|
|
|
|
head :ok
|
|
|
|
else
|
|
|
|
head :unprocessable_entity
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
def related_branches
|
2020-05-24 23:13:21 +05:30
|
|
|
@related_branches = Issues::RelatedBranchesService
|
|
|
|
.new(project, current_user)
|
|
|
|
.execute(issue)
|
|
|
|
.map { |branch| branch.merge(link: branch_link(branch)) }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
|
|
|
render json: {
|
|
|
|
html: view_to_html_string('projects/issues/_related_branches')
|
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
def can_create_branch
|
|
|
|
can_create = current_user &&
|
|
|
|
can?(current_user, :push_code, @project) &&
|
2018-10-15 14:42:47 +05:30
|
|
|
@issue.can_be_worked_on?
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
2018-10-15 14:42:47 +05:30
|
|
|
render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
def create_merge_request
|
2018-03-17 18:26:18 +05:30
|
|
|
create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
|
2020-05-24 23:13:21 +05:30
|
|
|
create_params[:target_project_id] = params[:target_project_id]
|
2018-03-17 18:26:18 +05:30
|
|
|
result = ::MergeRequests::CreateFromIssueService.new(project, current_user, create_params).execute
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
if result[:status] == :success
|
|
|
|
render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
|
|
|
|
else
|
2020-04-22 19:07:51 +05:30
|
|
|
render json: result[:message], status: :unprocessable_entity
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
def export_csv
|
|
|
|
ExportCsvWorker.perform_async(current_user.id, project.id, finder_options.to_h) # rubocop:disable CodeReuse/Worker
|
|
|
|
|
|
|
|
index_path = project_issues_path(project)
|
2020-05-24 23:13:21 +05:30
|
|
|
message = _('Your CSV export has started. It will be emailed to %{email} when complete.') % { email: current_user.notification_email }
|
|
|
|
redirect_to(index_path, notice: message)
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
def import_csv
|
|
|
|
if uploader = UploadService.new(project, params[:file]).execute
|
2020-03-13 15:44:24 +05:30
|
|
|
ImportIssuesCsvWorker.perform_async(current_user.id, project.id, uploader.upload.id) # rubocop:disable CodeReuse/Worker
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
flash[:notice] = _("Your issues are being imported. Once finished, you'll get a confirmation email.")
|
|
|
|
else
|
|
|
|
flash[:alert] = _("File upload error.")
|
|
|
|
end
|
|
|
|
|
|
|
|
redirect_to project_issues_path(project)
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
protected
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
def sorting_field
|
2019-03-02 22:35:43 +05:30
|
|
|
Issue::SORTING_PREFERENCE_FIELD
|
|
|
|
end
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
2014-09-02 18:07:02 +05:30
|
|
|
def issue
|
2017-09-10 17:25:29 +05:30
|
|
|
return @issue if defined?(@issue)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
# The Sortable default scope causes performance issues when used with find_by
|
2018-11-18 11:00:15 +05:30
|
|
|
@issuable = @noteable = @issue ||= @project.issues.includes(author: :status).where(iid: params[:id]).reorder(nil).take!
|
2018-03-17 18:26:18 +05:30
|
|
|
@note = @project.notes.new(noteable: @issuable)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
return render_404 unless can?(current_user, :read_issue, @issue)
|
|
|
|
|
|
|
|
@issue
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
2016-06-02 11:05:42 +05:30
|
|
|
alias_method :subscribable_resource, :issue
|
|
|
|
alias_method :issuable, :issue
|
2016-06-16 23:09:34 +05:30
|
|
|
alias_method :awardable, :issue
|
2016-09-13 17:45:13 +05:30
|
|
|
alias_method :spammable, :issue
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
def spammable_path
|
|
|
|
project_issue_path(@project, @issue)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
def authorize_create_merge_request!
|
2018-10-15 14:42:47 +05:30
|
|
|
render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
def render_issue_json
|
|
|
|
if @issue.valid?
|
|
|
|
render json: serializer.represent(@issue)
|
2016-09-13 17:45:13 +05:30
|
|
|
else
|
2018-03-17 18:26:18 +05:30
|
|
|
render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
|
2016-09-13 17:45:13 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
def issue_params
|
2020-01-01 13:55:28 +05:30
|
|
|
params.require(:issue).permit(
|
|
|
|
*issue_params_attributes,
|
|
|
|
sentry_issue_attributes: [:sentry_issue_identifier]
|
|
|
|
)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
def issue_params_attributes
|
|
|
|
%i[
|
|
|
|
title
|
|
|
|
assignee_id
|
|
|
|
position
|
|
|
|
description
|
|
|
|
confidential
|
|
|
|
milestone_id
|
|
|
|
due_date
|
|
|
|
state_event
|
|
|
|
task_num
|
|
|
|
lock_version
|
2018-03-17 18:26:18 +05:30
|
|
|
discussion_locked
|
2019-03-02 22:35:43 +05:30
|
|
|
] + [{ label_ids: [], assignee_ids: [], update_task: [:index, :checked, :line_number, :line_source] }]
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2019-09-30 21:07:59 +05:30
|
|
|
def reorder_params
|
|
|
|
params.permit(:move_before_id, :move_after_id, :group_full_path)
|
|
|
|
end
|
|
|
|
|
2018-11-29 20:51:05 +05:30
|
|
|
def store_uri
|
2017-09-10 17:25:29 +05:30
|
|
|
if request.get? && !request.xhr?
|
|
|
|
store_location_for :user, request.fullpath
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
def serializer
|
|
|
|
IssueSerializer.new(current_user: current_user, project: issue.project)
|
|
|
|
end
|
|
|
|
|
|
|
|
def update_service
|
|
|
|
update_params = issue_params.merge(spammable_params)
|
|
|
|
Issues::UpdateService.new(project, current_user, update_params)
|
|
|
|
end
|
|
|
|
|
2018-03-27 19:54:05 +05:30
|
|
|
def finder_type
|
|
|
|
IssuesFinder
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def whitelist_query_limiting
|
|
|
|
# Also see the following issues:
|
|
|
|
#
|
2019-12-04 20:38:33 +05:30
|
|
|
# 1. https://gitlab.com/gitlab-org/gitlab-foss/issues/42423
|
|
|
|
# 2. https://gitlab.com/gitlab-org/gitlab-foss/issues/42424
|
|
|
|
# 3. https://gitlab.com/gitlab-org/gitlab-foss/issues/42426
|
|
|
|
Gitlab::QueryLimiting.whitelist('https://gitlab.com/gitlab-org/gitlab-foss/issues/42422')
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
private
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
def branch_link(branch)
|
|
|
|
project_compare_path(project, from: project.default_branch, to: branch[:name])
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
def create_rate_limit
|
|
|
|
key = :issues_create
|
|
|
|
|
|
|
|
if rate_limiter.throttled?(key, scope: [@project, @current_user])
|
|
|
|
rate_limiter.log_request(request, "#{key}_request_limit".to_sym, current_user)
|
|
|
|
|
|
|
|
render plain: _('This endpoint has been requested too many times. Try again later.'), status: :too_many_requests
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def rate_limiter
|
|
|
|
::Gitlab::ApplicationRateLimiter
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
Projects::IssuesController.prepend_if_ee('EE::Projects::IssuesController')
|